RFR: 8255240: Mobile builds need to exclude some modules [v4]

[Magnus Ihse Bursie]

On Sun, 14 Apr 2024 07:09:17 GMT, Johan Vos <jvos at openjdk.org> wrote:

>> This PR enables to build the static libs for ios/android for the native code in most of the modules. 
>> It also adds GA scripts to build those libs on Android and iOS.
>> Note that building hotspot is disabled by this PR.
>
> Johan Vos has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains ten commits:
> 
>  - Merge branch 'master' into staticlibs
>  - re-enable gensrc for X11 on Android
>    fix whitespace issue
>  - Process reviewer comments
>  - Merge branch 'master' into staticlibs
>  - When building for ios, deal with non-supported @objectfilenames (similar to macos and aix)
>  - Merge branch 'master' into minimal-android-23
>    Fix conflict related to major changes in NativeCompilation.gmk
>  - Add android workflow (#2)
>    
>    * Add android build
>    
>    * fix env variable use
>    
>    * fix condition
>    
>    * update conf and build for android
>    
>    * add config name
>    
>    * remove build jdk
>    
>    * update id
>    
>    * fix command
>    
>    * add ls to debug
>    
>    * fix build command
>    
>    * update conf name
>    
>    * update directory name
>    
>    * remove ${{ }} to fix condition
>    
>    * do not remove bundle for android
>    
>    * add debug
>    
>    * add debug
>    
>    * do not build debug
>    
>    * s/x64/aarch64
>    
>    * add debug logs
>    
>    * fix condition
>    
>    * create only release
>    
>    * build on push
>    
>    * add ios build
>    
>    * fix platform name
>    
>    * download cups from source
>    
>    * fix command
>    
>    * skip running make for product-bundles and test-bundles
>    
>    * update upload to support ios static
>  - Add required ios changes for building static libs.
>    Add sample configure script for ios
>  - Changes required to build static libs for Android with JDK 23-ea

.github/actions/upload-bundles/action.yml line 44:

> 42:       run: |
> 43:         # Rename bundles to consistent names
> 44:         echo "build/${{ inputs.platform }} contents..."

This (and more below) looks like debug code that could/should be removed once you have made sure the builds are working.

.github/workflows/main.yml line 93:

> 91:                 return
> 92:               else
> 93:                 input='android-linux-aarch64, ios-macos-aarch64'

Actually, this should be reverted, otherwise you can never run a user-specified set of platforms on GHA.

configure-ios.sh line 1:

> 1: # sample configure command for ios

I also don't think this belongs in the repo. A command example like this can be documented on the wiki or the JDK project web page.

-------------

PR Review Comment: https://git.openjdk.org/mobile/pull/20#discussion_r1570463436
PR Review Comment: https://git.openjdk.org/mobile/pull/20#discussion_r1570460273
PR Review Comment: https://git.openjdk.org/mobile/pull/20#discussion_r1570461657