RFR: 8333795: [mobile] allow building jdk native libs for ios/android

[Magnus Ihse Bursie]

On Fri, 7 Jun 2024 13:09:26 GMT, Johan Vos <jvos at openjdk.org> wrote:

> This PR contains the changes that are needed to build the native JDK class libraries for ios/android.
> After a successful configuration, invoking
> `make static-libs`
> should produces static libs for the JDK classes.

The patch looks overall good. I left a couple of questions that I'd like to see answered before integration.

make/modules/java.desktop/Lib.gmk line 38:

> 36: # Create the AWT/2D libraries
> 37: 
> 38: ifeq ($(call isTargetOs, android ios), false)

This is acceptable for now, but I think we should try to find a more elegant way to resolve this.

src/hotspot/share/utilities/elfFile.hpp line 28:

> 26: #define SHARE_UTILITIES_ELFFILE_HPP
> 27: 
> 28: #if !defined(_WINDOWS) && (!defined(__APPLE__) || defined(__BIOS__)) && !defined(_AIX)

Is this really correct?

src/java.base/macosx/native/libjli/java_md_macosx.m line 279:

> 277: 
> 278: #ifdef __IOS__
> 279: static jboolean awtLoaded = 0;

How come this change is needed? Why do `BOOL` not work on iOS? Or contrary, could `jboolean` work on macOS as well?

-------------

Marked as reviewed by ihse (Reviewer).

PR Review: https://git.openjdk.org/mobile/pull/26#pullrequestreview-2118221743
PR Review Comment: https://git.openjdk.org/mobile/pull/26#discussion_r1639718361
PR Review Comment: https://git.openjdk.org/mobile/pull/26#discussion_r1639718755
PR Review Comment: https://git.openjdk.org/mobile/pull/26#discussion_r1639720155