RFR: 8255240: Mobile builds need to exclude some modules

[Magnus Ihse Bursie]

On Sat, 23 Mar 2024 16:30:46 GMT, Johan Vos <jvos at openjdk.org> wrote:

> This PR enables to build the static libs for ios/android for the native code in most of the modules. 
> It also adds GA scripts to build those libs on Android and iOS.
> Note that building hotspot is disabled by this PR.

The GHA scripts are interesting. I did not realize it could be possible to cross-compile to ios and android on GHA. 

I have tried to review them, but I did not go into too much detail. If they are ever to be upstreamed, I think they will need some cleanup and be made to fit better into the existing structure, but for a separate port I assume they are okay.

And why are you disabling the hotspot build? How can anything good come out of a JDK build without hotspot?

make/modules/java.desktop/Gensrc.gmk line 35:

> 33: endif
> 34: 
> 35: ifeq ($(call isTargetOs, linux aix android ios), true)

Should ios really have X11Wrappers?

src/jdk.management/unix/native/libmanagement_ext/OperatingSystemImpl.c line 321:

> 319:     return nfiles;
> 320: #else
> 321:     return (100);

This seem like a hack?

Also, why the parenthesis?

-------------

PR Comment: https://git.openjdk.org/mobile/pull/20#issuecomment-2022368630
PR Comment: https://git.openjdk.org/mobile/pull/20#issuecomment-2022369660
PR Review Comment: https://git.openjdk.org/mobile/pull/20#discussion_r1540791102
PR Review Comment: https://git.openjdk.org/mobile/pull/20#discussion_r1540793030