From johan.vos at gluonhq.com Sat May 11 08:33:12 2024 From: johan.vos at gluonhq.com (Johan Vos) Date: Sat, 11 May 2024 10:33:12 +0200 Subject: Result: New Mobile Reviewer: Magnus Ihse Bursie Message-ID: Voting for Magnus Ihse Bursie [1] is now closed. Yes: 2 Veto: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination. - Johan [1] https://mail.openjdk.org/pipermail/mobile-dev/2024-April/000862.html -------------- next part -------------- An HTML attachment was scrubbed... URL: From johan.vos at gluonhq.com Tue May 14 14:21:09 2024 From: johan.vos at gluonhq.com (Johan Vos) Date: Tue, 14 May 2024 16:21:09 +0200 Subject: diff against openjdk/jdk head Message-ID: Hi, The current master branch of openjdk/mobile has some changes that are not in upstream openjdk/jdk, but not all of them are (still) relevant and there is also a major syntax error. Rather than adding mobile-specific changes on top of the current master branch, I started from the head of openjdk/jdk to find out what changes I had to make to build both ios and android versions. I did this in my personal fork, in a branch named android-may-2024: https://github.com/johanvos/jdk/tree/android-may-2024 There are 4 commits in this branch: * changes required to build Android * changes required to build iOS * header files I added for the hotspot build for Android * header files I added for the hotspot build for iOS With these commits, I can build the static libs and VM for ios and android using make static-libs-image - Johan -------------- next part -------------- An HTML attachment was scrubbed... URL: From johan.vos at gluonhq.com Wed May 22 14:27:40 2024 From: johan.vos at gluonhq.com (Johan Vos) Date: Wed, 22 May 2024 16:27:40 +0200 Subject: next steps Message-ID: Hi, As explained in a previous mail [1], I have a branch from the (almost) head of openjdk/jdk that allows to build the static JDK libs for iOS and Android. I can rebase this branch on top of the existing commits of the current openjdk/mobile head, but some of those commits are no longer needed. Hence, I suggest that we start with a clean version, taken from the current openjdk/jdk so that I can create a PR against this clean state. In order to do so, I can first create a PR that reverts the current diff between mobile and jdk. Apart from that, I am locally working on making changes in hotspot so that it allows to create an application with a launcher that is statically linked against libjvm.a, libjli.a and the native libs for the JDK classes. I created a simple launcher that I compile and link with the slightly modified VM libs (mainly #ifdef STATIC_BUILD). The branch I use for that slightly modified libs version is at [2] and it mainly contains additional debug info. The latter is just an experiment, as I am personally unsure yet what VM would be optimal for being used in mobile -- especially given Apple's restriction on the dynamic generation of code. - Johan [1] https://mail.openjdk.org/pipermail/mobile-dev/2024-May/000873.html [2] https://github.com/johanvos/jdk/tree/statichotspot -------------- next part -------------- An HTML attachment was scrubbed... URL: From davidalayachew at gmail.com Wed May 22 16:50:52 2024 From: davidalayachew at gmail.com (David Alayachew) Date: Wed, 22 May 2024 12:50:52 -0400 Subject: next steps In-Reply-To: References: Message-ID: This is extremely exciting. Please let us know if there is anything we can do to help out! On Wed, May 22, 2024 at 10:28?AM Johan Vos wrote: > Hi, > > As explained in a previous mail [1], I have a branch from the (almost) > head of openjdk/jdk that allows to build the static JDK libs for iOS and > Android. I can rebase this branch on top of the existing commits of the > current openjdk/mobile head, but some of those commits are no longer needed. > Hence, I suggest that we start with a clean version, taken from the > current openjdk/jdk so that I can create a PR against this clean state. In > order to do so, I can first create a PR that reverts the current diff > between mobile and jdk. > > Apart from that, I am locally working on making changes in hotspot so that > it allows to create an application with a launcher that is statically > linked against libjvm.a, libjli.a and the native libs for the JDK classes. > I created a simple launcher that I compile and link with the > slightly modified VM libs (mainly #ifdef STATIC_BUILD). The branch I use > for that slightly modified libs version is at [2] and it mainly contains > additional debug info. > > The latter is just an experiment, as I am personally unsure yet what VM > would be optimal for being used in mobile -- especially given Apple's > restriction on the dynamic generation of code. > > - Johan > > [1] https://mail.openjdk.org/pipermail/mobile-dev/2024-May/000873.html > [2] https://github.com/johanvos/jdk/tree/statichotspot > -------------- next part -------------- An HTML attachment was scrubbed... URL: From stemmlersisters at gmail.com Fri May 24 20:34:30 2024 From: stemmlersisters at gmail.com (Rebecca Stemmler) Date: Fri, 24 May 2024 13:34:30 -0700 Subject: K Message-ID: <6291EF05-822C-426C-9C61-46F92D67E505@gmail.com> Sent from my iPhone From magnus.ihse.bursie at oracle.com Thu May 30 19:09:26 2024 From: magnus.ihse.bursie at oracle.com (Magnus Ihse Bursie) Date: Thu, 30 May 2024 21:09:26 +0200 Subject: diff against openjdk/jdk head In-Reply-To: References: Message-ID: <0c2e70f4-c2c9-4dc5-b79f-c46a08a48e89@oracle.com> On 2024-05-14 16:21, Johan Vos wrote: > Hi, > > The current master branch of openjdk/mobile has some changes that are > not in upstream openjdk/jdk, but not all of them are (still) relevant > and there is also a major syntax error. > Rather than adding mobile-specific changes on top of the current > master branch, I started from the head of openjdk/jdk to?find out what > changes I had to make to build both ios and android versions. > I did this in my personal?fork, in a branch named android-may-2024: > https://github.com/johanvos/jdk/tree/android-may-2024 > > There are 4 commits in this branch: > * changes required to build Android > * changes required to build iOS > * header files I added for the hotspot build for Android > * header files I added for the hotspot build for iOS > > With these commits, I can build the static libs and VM for ios and > android using > make static-libs-image These changes look very clean. I think it would be much better to restart from jdk mainline and apply these patches. Have you had any progress in figuring out how to best achieve that? /Magnus From mickyminie3 at gmail.com Fri May 31 04:23:25 2024 From: mickyminie3 at gmail.com (Micky Minie) Date: Fri, 31 May 2024 12:23:25 +0800 Subject: No subject Message-ID: richelle -------------- next part -------------- An HTML attachment was scrubbed... URL: From jvos at openjdk.org Fri May 31 13:45:38 2024 From: jvos at openjdk.org (Johan Vos) Date: Fri, 31 May 2024 13:45:38 GMT Subject: RFR: 8333357: revert current mobile changes Message-ID: Revert mobile-specific changes that are in openjdk/mobile but not inpenjdk/jdk This allows us to add new, clean commits that are in line with the recent changes in jdk and the requirements for ios/android ports. ------------- Commit messages: - Revert mobile-specific changes that are in openjdk/mobile but not in Changes: https://git.openjdk.org/mobile/pull/25/files Webrev: https://webrevs.openjdk.org/?repo=mobile&pr=25&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8333357 Stats: 293 lines in 17 files changed: 123 ins; 154 del; 16 mod Patch: https://git.openjdk.org/mobile/pull/25.diff Fetch: git fetch https://git.openjdk.org/mobile.git pull/25/head:pull/25 PR: https://git.openjdk.org/mobile/pull/25 From johan.vos at gluonhq.com Fri May 31 13:47:40 2024 From: johan.vos at gluonhq.com (Johan Vos) Date: Fri, 31 May 2024 15:47:40 +0200 Subject: diff against openjdk/jdk head In-Reply-To: <0c2e70f4-c2c9-4dc5-b79f-c46a08a48e89@oracle.com> References: <0c2e70f4-c2c9-4dc5-b79f-c46a08a48e89@oracle.com> Message-ID: Thanks for looking into this. As for the next steps: I have a PR that reverts the existing changes, and that brings openjdk/mobile 100% on par with openjdk/jdk: https://github.com/openjdk/mobile/pull/25 I tried to create a branch in openjdk/mobile but I don't seem to have permission to do that. A branch would be a good point to have a copy of the current mobile repository. If a branch is not possible, a tag should be sufficient. Once PR-25 is reviewed and approved, I will add a tag to the current HEAD (e.g. mobile_classic or mobile_gen1) and integrate PR-25 immediately after that. thoughts? - Johan On Thu, May 30, 2024 at 9:09?PM Magnus Ihse Bursie < magnus.ihse.bursie at oracle.com> wrote: > On 2024-05-14 16:21, Johan Vos wrote: > > > Hi, > > > > The current master branch of openjdk/mobile has some changes that are > > not in upstream openjdk/jdk, but not all of them are (still) relevant > > and there is also a major syntax error. > > Rather than adding mobile-specific changes on top of the current > > master branch, I started from the head of openjdk/jdk to find out what > > changes I had to make to build both ios and android versions. > > I did this in my personal fork, in a branch named android-may-2024: > > https://github.com/johanvos/jdk/tree/android-may-2024 > > > > There are 4 commits in this branch: > > * changes required to build Android > > * changes required to build iOS > > * header files I added for the hotspot build for Android > > * header files I added for the hotspot build for iOS > > > > With these commits, I can build the static libs and VM for ios and > > android using > > make static-libs-image > > These changes look very clean. I think it would be much better to > restart from jdk mainline and apply these patches. Have you had any > progress in figuring out how to best achieve that? > > /Magnus > > -------------- next part -------------- An HTML attachment was scrubbed... URL: