From jvos at openjdk.org  Wed Aug 13 14:25:44 2025
From: jvos at openjdk.org (Johan Vos)
Date: Wed, 13 Aug 2025 14:25:44 GMT
Subject: RFR: 8359163: Fix path to current module on ios
In-Reply-To: <fA6RszOee6TUnP0V_zdzjvQktUVoDmfPJGC7iHmmPlo=.1def58e6-ce00-4564-bf93-08f737e390b0@github.com>
References: <fA6RszOee6TUnP0V_zdzjvQktUVoDmfPJGC7iHmmPlo=.1def58e6-ce00-4564-bf93-08f737e390b0@github.com>
Message-ID: <kNtzlRRX0kI0ZSDphJU39LFebyVF1WczcxUbZuYFhSc=.73337d7a-d792-4dee-89e7-ed7326dcf099@github.com>

On Tue, 29 Jul 2025 14:18:28 GMT, Johan Vos <jvos at openjdk.org> wrote:

> Minimize ios-specific logic to calculate the location for java_home.
> The java_home property should be based on the jvm_path, and not on the user_home
> 
> Fix JDK-8359163
> 
> This patch still has ios-specific logic, e.g. we don't have a {client/server} suffix to the jvm home. More important, though, is that we do not want to point to userspace for the location of the jvm modules etc itself. Those should be derived from the installed application location, which matches the jvm_home property.
> Applying this patch removes one more location where the mobile repository differs from upstream jdk.

@magicus can you review this?

-------------

PR Comment: https://git.openjdk.org/mobile/pull/39#issuecomment-3184144652

From ihse at openjdk.org  Thu Aug 14 09:25:29 2025
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Thu, 14 Aug 2025 09:25:29 GMT
Subject: RFR: 8359163: Fix path to current module on ios
In-Reply-To: <fA6RszOee6TUnP0V_zdzjvQktUVoDmfPJGC7iHmmPlo=.1def58e6-ce00-4564-bf93-08f737e390b0@github.com>
References: <fA6RszOee6TUnP0V_zdzjvQktUVoDmfPJGC7iHmmPlo=.1def58e6-ce00-4564-bf93-08f737e390b0@github.com>
Message-ID: <xRiBzROeW-h2PLMuS4ys62Rvxzt_vGhRTiqQ_O5sLT4=.ed4e88a9-0d75-49cf-90a5-5deb647d223f@github.com>

On Tue, 29 Jul 2025 14:18:28 GMT, Johan Vos <jvos at openjdk.org> wrote:

> Minimize ios-specific logic to calculate the location for java_home.
> The java_home property should be based on the jvm_path, and not on the user_home
> 
> Fix JDK-8359163
> 
> This patch still has ios-specific logic, e.g. we don't have a {client/server} suffix to the jvm home. More important, though, is that we do not want to point to userspace for the location of the jvm modules etc itself. Those should be derived from the installed application location, which matches the jvm_home property.
> Applying this patch removes one more location where the mobile repository differs from upstream jdk.

LGTM. There is still a couple of `#ifndef __IOS__` left so the diff towards main is unfortunately mostly there. :( But sure, just ifdeffing out code is superior to adding new logic so it's definitely a step in the right direction.

-------------

Marked as reviewed by ihse (Reviewer).

PR Review: https://git.openjdk.org/mobile/pull/39#pullrequestreview-3119792521

From jvos at openjdk.org  Thu Aug 14 09:39:31 2025
From: jvos at openjdk.org (Johan Vos)
Date: Thu, 14 Aug 2025 09:39:31 GMT
Subject: RFR: 8359163: Fix path to current module on ios
In-Reply-To: <xRiBzROeW-h2PLMuS4ys62Rvxzt_vGhRTiqQ_O5sLT4=.ed4e88a9-0d75-49cf-90a5-5deb647d223f@github.com>
References: <fA6RszOee6TUnP0V_zdzjvQktUVoDmfPJGC7iHmmPlo=.1def58e6-ce00-4564-bf93-08f737e390b0@github.com>
 <xRiBzROeW-h2PLMuS4ys62Rvxzt_vGhRTiqQ_O5sLT4=.ed4e88a9-0d75-49cf-90a5-5deb647d223f@github.com>
Message-ID: <GOljfATwCuykPdRKcTVkFGQ5s2hu-mBEMQgkLBalKlY=.b148ca54-9adb-40e8-9637-d9b4e8ecf330@github.com>

On Thu, 14 Aug 2025 09:22:57 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> LGTM. There is still a couple of `#ifndef __IOS__` left so the diff towards main is unfortunately mostly there. :( But sure, just ifdeffing out code is superior to adding new logic so it's definitely a step in the right direction.

Agree. There is more work to be done. I'm not 100% sure though about the best approach to fix the other IOS specific logic. There are a couple of options, and I try to avoid commiting option A only to realize later that option B would have been better. 
But with this PR, we can run HelloWorld without much boilerplate code, and we can gain experience and feedback now.
Thanks!

-------------

PR Comment: https://git.openjdk.org/mobile/pull/39#issuecomment-3187794259

From jvos at openjdk.org  Thu Aug 14 09:39:31 2025
From: jvos at openjdk.org (Johan Vos)
Date: Thu, 14 Aug 2025 09:39:31 GMT
Subject: Integrated: 8359163: Fix path to current module on ios
In-Reply-To: <fA6RszOee6TUnP0V_zdzjvQktUVoDmfPJGC7iHmmPlo=.1def58e6-ce00-4564-bf93-08f737e390b0@github.com>
References: <fA6RszOee6TUnP0V_zdzjvQktUVoDmfPJGC7iHmmPlo=.1def58e6-ce00-4564-bf93-08f737e390b0@github.com>
Message-ID: <HF5XWxqarlg0CqH-ODwO67Sx-UlupdST9JOVjpI3Ckg=.c7cc9d9e-2ea1-402a-93dd-7018681ea43d@github.com>

On Tue, 29 Jul 2025 14:18:28 GMT, Johan Vos <jvos at openjdk.org> wrote:

> Minimize ios-specific logic to calculate the location for java_home.
> The java_home property should be based on the jvm_path, and not on the user_home
> 
> Fix JDK-8359163
> 
> This patch still has ios-specific logic, e.g. we don't have a {client/server} suffix to the jvm home. More important, though, is that we do not want to point to userspace for the location of the jvm modules etc itself. Those should be derived from the installed application location, which matches the jvm_home property.
> Applying this patch removes one more location where the mobile repository differs from upstream jdk.

This pull request has now been integrated.

Changeset: 4c777924
Author:    Johan Vos <jvos at openjdk.org>
URL:       https://git.openjdk.org/mobile/commit/4c7779247d16b83229cb6ebb08c2ec46c91e65e3
Stats:     7 lines in 1 file changed: 1 ins; 6 del; 0 mod

8359163: Fix path to current module on ios

Reviewed-by: ihse

-------------

PR: https://git.openjdk.org/mobile/pull/39