From duke at openjdk.org Thu Feb 6 13:57:49 2025 From: duke at openjdk.org (J. Duke) Date: Thu, 6 Feb 2025 13:57:49 GMT Subject: RFR: Merge jdk:master [v2] In-Reply-To: References: Message-ID: > Hi all, > > this is an _automatically_ generated pull request to notify you that there is 1 commit from the branch `jdk:master`that can **not** be merged into the branch `master`: > > The following files contains merge conflicts: > > - src/hotspot/os/bsd/os_perf_bsd.cpp > - src/hotspot/share/nmt/memMapPrinter.cpp > > All Committers in this [project](https://openjdk.org/census#mobile) have access to my [personal fork](https://github.com/openjdk-bots/mobile) and can therefore help resolve these merge conflicts (you may want to coordinate who should do this). > The following paragraphs will give an example on how to solve these merge conflicts and push the resulting merge commit to this pull request. > The below commands should be run in a local clone of your [personal fork](https://wiki.openjdk.org/display/skara#Skara-Personalforks) of the [openjdk/mobile](https://github.com/openjdk/mobile) repository. > > > # Ensure target branch is up to date > $ git checkout master > $ git pull https://github.com/openjdk/mobile.git master > > # Fetch and checkout the branch for this pull request > $ git fetch https://github.com/openjdk-bots/mobile.git +7:openjdk-bot-7 > $ git checkout openjdk-bot-7 > > # Merge the target branch > $ git merge master > > > When you have resolved the conflicts resulting from the `git merge` command above, run the following commands to create a merge commit: > > > $ git add paths/to/files/with/conflicts > $ git commit -m 'Merge jdk:master' > > > > When you have created the merge commit, run the following command to push the merge commit to this pull request: > > > $ git push https://github.com/openjdk-bots/mobile.git openjdk-bot-7:7 > > > _Note_: if you are using SSH to push commits to GitHub, then change the URL in the above `git push` command accordingly. > > Thanks, > J. Duke J. Duke has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11932 additional commits since the last revision: - Merge jdk:master - Automatic merge of jdk:master into master - Automatic merge of jdk:master into master - Automatic merge of jdk:master into master - Automatic merge of jdk:master into master - Automatic merge of jdk:master into master - Automatic merge of jdk:master into master - Automatic merge of jdk:master into master - Automatic merge of jdk:master into master - Automatic merge of jdk:master into master - ... and 11922 more: https://git.openjdk.org/mobile/compare/c33c1cfe...2fcf7077 ------------- Changes: - all: https://git.openjdk.org/mobile/pull/33/files - new: https://git.openjdk.org/mobile/pull/33/files/c33c1cfe..2fcf7077 Webrevs: - full: https://webrevs.openjdk.org/?repo=mobile&pr=33&range=01 - incr: https://webrevs.openjdk.org/?repo=mobile&pr=33&range=00-01 Stats: 176 lines in 41 files changed: 147 ins; 0 del; 29 mod Patch: https://git.openjdk.org/mobile/pull/33.diff Fetch: git fetch https://git.openjdk.org/mobile.git pull/33/head:pull/33 PR: https://git.openjdk.org/mobile/pull/33 From duke at openjdk.org Thu Feb 6 13:57:50 2025 From: duke at openjdk.org (J. Duke) Date: Thu, 6 Feb 2025 13:57:50 GMT Subject: Integrated: Merge jdk:master In-Reply-To: References: Message-ID: <1M0hKX7FxwtIxsNlDoOh2cq85ECnUXbDnoI-hRDQavM=.560a3c20-fbf6-4809-8e95-5aa039e991be@github.com> On Tue, 21 Jan 2025 10:21:41 GMT, J. Duke wrote: > Hi all, > > this is an _automatically_ generated pull request to notify you that there is 1 commit from the branch `jdk:master`that can **not** be merged into the branch `master`: > > The following files contains merge conflicts: > > - src/hotspot/os/bsd/os_perf_bsd.cpp > - src/hotspot/share/nmt/memMapPrinter.cpp > > All Committers in this [project](https://openjdk.org/census#mobile) have access to my [personal fork](https://github.com/openjdk-bots/mobile) and can therefore help resolve these merge conflicts (you may want to coordinate who should do this). > The following paragraphs will give an example on how to solve these merge conflicts and push the resulting merge commit to this pull request. > The below commands should be run in a local clone of your [personal fork](https://wiki.openjdk.org/display/skara#Skara-Personalforks) of the [openjdk/mobile](https://github.com/openjdk/mobile) repository. > > > # Ensure target branch is up to date > $ git checkout master > $ git pull https://github.com/openjdk/mobile.git master > > # Fetch and checkout the branch for this pull request > $ git fetch https://github.com/openjdk-bots/mobile.git +7:openjdk-bot-7 > $ git checkout openjdk-bot-7 > > # Merge the target branch > $ git merge master > > > When you have resolved the conflicts resulting from the `git merge` command above, run the following commands to create a merge commit: > > > $ git add paths/to/files/with/conflicts > $ git commit -m 'Merge jdk:master' > > > > When you have created the merge commit, run the following command to push the merge commit to this pull request: > > > $ git push https://github.com/openjdk-bots/mobile.git openjdk-bot-7:7 > > > _Note_: if you are using SSH to push commits to GitHub, then change the URL in the above `git push` command accordingly. > > Thanks, > J. Duke This pull request has now been integrated. Changeset: 49742316 Author: J. Duke Committer: Johan Vos URL: https://git.openjdk.org/mobile/commit/49742316fa54dad374b0068e8bb040334be32750 Stats: 3159 lines in 1757 files changed: 7 ins; 1837 del; 1315 mod Merge ------------- PR: https://git.openjdk.org/mobile/pull/33 From duke at openjdk.org Tue Feb 18 08:30:15 2025 From: duke at openjdk.org (Abhinay Agarwal) Date: Tue, 18 Feb 2025 08:30:15 GMT Subject: RFR: 8347033: add build instructions for iOS Message-ID: Adds build instruction for iOS ------------- Commit messages: - 8347033: add build instructions for iOS Changes: https://git.openjdk.org/mobile/pull/34/files Webrev: https://webrevs.openjdk.org/?repo=mobile&pr=34&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8347033 Stats: 70 lines in 1 file changed: 70 ins; 0 del; 0 mod Patch: https://git.openjdk.org/mobile/pull/34.diff Fetch: git fetch https://git.openjdk.org/mobile.git pull/34/head:pull/34 PR: https://git.openjdk.org/mobile/pull/34 From jvos at openjdk.org Tue Feb 18 09:13:34 2025 From: jvos at openjdk.org (Johan Vos) Date: Tue, 18 Feb 2025 09:13:34 GMT Subject: RFR: 8347033: [mobile] add ios-specific build docs In-Reply-To: References: Message-ID: <5T6-iFU1xDwklT20EiFBoyFpgXN4r5bhvukacDImMFA=.516d62ce-5807-4af8-8e3e-bcd8978d8409@github.com> On Tue, 18 Feb 2025 08:24:54 GMT, Abhinay Agarwal wrote: > Adds build instruction for iOS @abhinayagarwal can you edit the title of this PR to exactly match the title of the JBS issue? ------------- PR Comment: https://git.openjdk.org/mobile/pull/34#issuecomment-2665020584 From jwaters at openjdk.org Wed Feb 19 04:17:19 2025 From: jwaters at openjdk.org (Julian Waters) Date: Wed, 19 Feb 2025 04:17:19 GMT Subject: RFR: 8347033: [mobile] add ios-specific build docs In-Reply-To: References: Message-ID: On Tue, 18 Feb 2025 08:24:54 GMT, Abhinay Agarwal wrote: > Adds build instruction for iOS Why not add it under building.md instead and regenerate the html with make update-build-docs? ------------- PR Comment: https://git.openjdk.org/mobile/pull/34#issuecomment-2667467149 From jvos at openjdk.org Wed Feb 19 08:59:08 2025 From: jvos at openjdk.org (Johan Vos) Date: Wed, 19 Feb 2025 08:59:08 GMT Subject: RFR: 8347033: [mobile] add ios-specific build docs In-Reply-To: References: Message-ID: <7pk3Mb5iNZz_tEv54moCa8vRvm2aDjOk17skNxbmt2Q=.d088dd9d-0904-4a2b-860a-e0efd0bd92a6@github.com> On Wed, 19 Feb 2025 04:14:00 GMT, Julian Waters wrote: > Why not add it under building.md instead and regenerate the html with make update-build-docs? That would be the ultimate best approach indeed, but in that case it needs to be very well integrated with the structure of that file (e.g. with a clean separation between the different options for what to build, and how to build) I see this current approach as a good step to show developers in one glance how to build the mobile SDK for iOS. I don't think this is something we ever want to upstream to openjdk/jdk (I consider it a working document that would be handy if it was in the same repository as the code). But once things are clear and stable, I absolutely agree that modifying the upstream building.md would be the goal. ------------- PR Comment: https://git.openjdk.org/mobile/pull/34#issuecomment-2667959431 From jvos at openjdk.org Wed Feb 19 10:53:02 2025 From: jvos at openjdk.org (Johan Vos) Date: Wed, 19 Feb 2025 10:53:02 GMT Subject: RFR: 8347033: [mobile] add ios-specific build docs In-Reply-To: References: Message-ID: <52aQgh5cJogT4-O22kZ0b9gljcWWXKVsOYVb-aSJDX0=.fbb80596-1cf8-42f7-8c4a-3ad5aad0be5f@github.com> On Tue, 18 Feb 2025 08:24:54 GMT, Abhinay Agarwal wrote: > Adds build instruction for iOS doc/building_ios.md line 6: > 4: > 5: ## Build static image for mac (Test) > 6: The following steps are to test if you can build the static image targeting mac. I think this section can be removed, and replaced with something like "Follow the instructions in build.md to make sure you can build the JDK" ------------- PR Review Comment: https://git.openjdk.org/mobile/pull/34#discussion_r1961452331 From duke at openjdk.org Wed Feb 19 18:44:19 2025 From: duke at openjdk.org (Abhinay Agarwal) Date: Wed, 19 Feb 2025 18:44:19 GMT Subject: RFR: 8347033: [mobile] add ios-specific build docs [v2] In-Reply-To: References: Message-ID: > Adds build instruction for iOS Abhinay Agarwal has updated the pull request incrementally with one additional commit since the last revision: replace build instructions for macos with a note ------------- Changes: - all: https://git.openjdk.org/mobile/pull/34/files - new: https://git.openjdk.org/mobile/pull/34/files/ae35b7b0..07e2d7ba Webrevs: - full: https://webrevs.openjdk.org/?repo=mobile&pr=34&range=01 - incr: https://webrevs.openjdk.org/?repo=mobile&pr=34&range=00-01 Stats: 27 lines in 1 file changed: 0 ins; 23 del; 4 mod Patch: https://git.openjdk.org/mobile/pull/34.diff Fetch: git fetch https://git.openjdk.org/mobile.git pull/34/head:pull/34 PR: https://git.openjdk.org/mobile/pull/34 From jvos at openjdk.org Thu Feb 20 07:36:15 2025 From: jvos at openjdk.org (Johan Vos) Date: Thu, 20 Feb 2025 07:36:15 GMT Subject: RFR: 8347033: [mobile] add ios-specific build docs [v2] In-Reply-To: References: Message-ID: On Wed, 19 Feb 2025 18:44:19 GMT, Abhinay Agarwal wrote: >> Adds build instruction for iOS > > Abhinay Agarwal has updated the pull request incrementally with one additional commit since the last revision: > > replace build instructions for macos with a note doc/building_ios.md line 5: > 3: > [!NOTE] > 4: > Follow the instructions in [building.md](building.md) to make sure you can build the JDK > 5: > targeting a desktop platform before trying to build for iOS instead of "a desktop platform" it is probably better to mention the mac platform explicitly, as we want to make it clear that you (currently) can not build the iOS SDK from a windows or linux system. ------------- PR Review Comment: https://git.openjdk.org/mobile/pull/34#discussion_r1962996861 From duke at openjdk.org Fri Feb 21 06:13:22 2025 From: duke at openjdk.org (Abhinay Agarwal) Date: Fri, 21 Feb 2025 06:13:22 GMT Subject: RFR: 8347033: [mobile] add ios-specific build docs [v3] In-Reply-To: References: Message-ID: <_lXXcghhSw2ZUthQYWNbJHSIxPVu3mzVFjqHURmWL5M=.d578da4d-dca3-4b76-9908-ca5d0415220a@github.com> > Adds build instruction for iOS Abhinay Agarwal has updated the pull request incrementally with one additional commit since the last revision: update note ------------- Changes: - all: https://git.openjdk.org/mobile/pull/34/files - new: https://git.openjdk.org/mobile/pull/34/files/07e2d7ba..09bb3d2b Webrevs: - full: https://webrevs.openjdk.org/?repo=mobile&pr=34&range=02 - incr: https://webrevs.openjdk.org/?repo=mobile&pr=34&range=01-02 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/mobile/pull/34.diff Fetch: git fetch https://git.openjdk.org/mobile.git pull/34/head:pull/34 PR: https://git.openjdk.org/mobile/pull/34 From ihse at openjdk.org Fri Feb 21 12:03:56 2025 From: ihse at openjdk.org (Magnus Ihse Bursie) Date: Fri, 21 Feb 2025 12:03:56 GMT Subject: RFR: 8347033: [mobile] add ios-specific build docs [v3] In-Reply-To: <_lXXcghhSw2ZUthQYWNbJHSIxPVu3mzVFjqHURmWL5M=.d578da4d-dca3-4b76-9908-ca5d0415220a@github.com> References: <_lXXcghhSw2ZUthQYWNbJHSIxPVu3mzVFjqHURmWL5M=.d578da4d-dca3-4b76-9908-ca5d0415220a@github.com> Message-ID: On Fri, 21 Feb 2025 06:13:22 GMT, Abhinay Agarwal wrote: >> Adds build instruction for iOS > > Abhinay Agarwal has updated the pull request incrementally with one additional commit since the last revision: > > update note Maybe it would be even better to put these instructions in the top-level README file? That way they are clearly visible to anyone looking at this repository. That would also mimick how some other project repos have done with project-specific information. doc/building_ios.md line 44: > 42: ``` > 43: cd build/zero-ios-aarch64 > 44: make static-libs-image A simpler way to achieve this without having to change directories is by just executing `make CONF=zero-ios-aarch64 static-libs-image`. ------------- PR Comment: https://git.openjdk.org/mobile/pull/34#issuecomment-2674370807 PR Review Comment: https://git.openjdk.org/mobile/pull/34#discussion_r1965366472 From duke at openjdk.org Mon Feb 24 09:03:17 2025 From: duke at openjdk.org (Abhinay Agarwal) Date: Mon, 24 Feb 2025 09:03:17 GMT Subject: RFR: 8347033: [mobile] add ios-specific build docs [v3] In-Reply-To: References: <_lXXcghhSw2ZUthQYWNbJHSIxPVu3mzVFjqHURmWL5M=.d578da4d-dca3-4b76-9908-ca5d0415220a@github.com> Message-ID: On Fri, 21 Feb 2025 11:59:32 GMT, Magnus Ihse Bursie wrote: >> Abhinay Agarwal has updated the pull request incrementally with one additional commit since the last revision: >> >> update note > > doc/building_ios.md line 44: > >> 42: ``` >> 43: cd build/zero-ios-aarch64 >> 44: make static-libs-image > > A simpler way to achieve this without having to change directories is by just executing `make CONF=zero-ios-aarch64 static-libs-image`. Thanks for this ? ------------- PR Review Comment: https://git.openjdk.org/mobile/pull/34#discussion_r1967234960 From duke at openjdk.org Mon Feb 24 09:16:35 2025 From: duke at openjdk.org (Abhinay Agarwal) Date: Mon, 24 Feb 2025 09:16:35 GMT Subject: RFR: 8347033: [mobile] add ios-specific build docs [v4] In-Reply-To: References: Message-ID: > Adds build instruction for iOS Abhinay Agarwal has updated the pull request incrementally with one additional commit since the last revision: move documentation to README.md ------------- Changes: - all: https://git.openjdk.org/mobile/pull/34/files - new: https://git.openjdk.org/mobile/pull/34/files/09bb3d2b..69e9d4f8 Webrevs: - full: https://webrevs.openjdk.org/?repo=mobile&pr=34&range=03 - incr: https://webrevs.openjdk.org/?repo=mobile&pr=34&range=02-03 Stats: 92 lines in 2 files changed: 45 ins; 47 del; 0 mod Patch: https://git.openjdk.org/mobile/pull/34.diff Fetch: git fetch https://git.openjdk.org/mobile.git pull/34/head:pull/34 PR: https://git.openjdk.org/mobile/pull/34 From jvos at openjdk.org Tue Feb 25 12:37:06 2025 From: jvos at openjdk.org (Johan Vos) Date: Tue, 25 Feb 2025 12:37:06 GMT Subject: RFR: 8347033: [mobile] add ios-specific build docs [v4] In-Reply-To: References: Message-ID: On Mon, 24 Feb 2025 09:16:35 GMT, Abhinay Agarwal wrote: >> Adds build instruction for iOS > > Abhinay Agarwal has updated the pull request incrementally with one additional commit since the last revision: > > move documentation to README.md looks good now. All comments seem to be addressed. ------------- Marked as reviewed by jvos (Lead). PR Review: https://git.openjdk.org/mobile/pull/34#pullrequestreview-2640896727 From ihse at openjdk.org Wed Feb 26 23:22:16 2025 From: ihse at openjdk.org (Magnus Ihse Bursie) Date: Wed, 26 Feb 2025 23:22:16 GMT Subject: RFR: 8347033: [mobile] add ios-specific build docs [v4] In-Reply-To: References: Message-ID: On Mon, 24 Feb 2025 09:16:35 GMT, Abhinay Agarwal wrote: >> Adds build instruction for iOS > > Abhinay Agarwal has updated the pull request incrementally with one additional commit since the last revision: > > move documentation to README.md LGTM ------------- Marked as reviewed by ihse (Reviewer). PR Review: https://git.openjdk.org/mobile/pull/34#pullrequestreview-2646177911 From duke at openjdk.org Thu Feb 27 08:43:01 2025 From: duke at openjdk.org (duke) Date: Thu, 27 Feb 2025 08:43:01 GMT Subject: RFR: 8347033: [mobile] add ios-specific build docs [v4] In-Reply-To: References: Message-ID: <0A1pAHAuifFB2oQCxvap9-LbOq02S49wHsQhDu7aI9o=.9ad58f1f-3ef2-46a5-9dd0-3514eac05818@github.com> On Mon, 24 Feb 2025 09:16:35 GMT, Abhinay Agarwal wrote: >> Adds build instruction for iOS > > Abhinay Agarwal has updated the pull request incrementally with one additional commit since the last revision: > > move documentation to README.md @abhinayagarwal Your change (at version 69e9d4f8b6691b2ffff332e6221d51d2aa4af5c7) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/mobile/pull/34#issuecomment-2687264004 From duke at openjdk.org Thu Feb 27 12:37:32 2025 From: duke at openjdk.org (Abhinay Agarwal) Date: Thu, 27 Feb 2025 12:37:32 GMT Subject: Integrated: 8347033: [mobile] add ios-specific build docs In-Reply-To: References: Message-ID: On Tue, 18 Feb 2025 08:24:54 GMT, Abhinay Agarwal wrote: > Adds build instruction for iOS This pull request has now been integrated. Changeset: a4d67fc5 Author: Abhinay Agarwal Committer: Johan Vos URL: https://git.openjdk.org/mobile/commit/a4d67fc5171229298a166ef92a50ae4772e34c74 Stats: 45 lines in 1 file changed: 45 ins; 0 del; 0 mod 8347033: [mobile] add ios-specific build docs Reviewed-by: jvos, ihse ------------- PR: https://git.openjdk.org/mobile/pull/34