RFR: 8357119: Make Zero the default and only variant of HotSpot for iOS [v2]
Julian Waters
jwaters at openjdk.org
Sat May 17 04:10:02 UTC 2025
On Fri, 16 May 2025 13:01:27 GMT, Johan Vos <jvos at openjdk.org> wrote:
>> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Touch up README.md
>
> README.md line 48:
>
>> 46:
>> 47: If you need to tell configure the path of the boot JDK, or if configure fails with an error saying
>> 48: it can't find the boot JDK, for instance if you downloaded a JDK in compressed archive form rather
>
> minor: change "the boot JDK" to "a boot JDK"
I'll change this as soon as possible.
> make/autoconf/hotspot.m4 line 82:
>
>> 80:
>> 81: if test "x$OPENJDK_TARGET_OS" = xios; then
>> 82: VALID_JVM_VARIANTS="zero"
>
> This should probably be guarded with a check on Device versus simulator. When running on an iOS simulator, it is technically possible to dynamically generate AND execute code, hence this is not restricted to zero.
Ah, I was not aware that one could run server on the iOS simulator. I can remove this part since my assumption seems to be incorrect.
-------------
PR Review Comment: https://git.openjdk.org/mobile/pull/35#discussion_r2093884829
PR Review Comment: https://git.openjdk.org/mobile/pull/35#discussion_r2093885063
More information about the mobile-dev
mailing list