[modules-dev] Review request for 6588155 (fixes to borken tests)

Kumar Srinivasan Kumar.Srinivasan at Sun.COM
Wed Aug 1 15:09:59 PDT 2007


Hi Dave,

Looks fine to me. However, I thought we had to handle the special characters
as space in Program Files. Does that work when you call  url.toURI() ?
I will putback my changes after your putback.


> Hi folks,
>
> This fixes the broken tests, and, at least temporarily, resolves the issue 
> which fixing those tests revealed in JamUtils.getFile().  The changes are all 
> very small: could someone please take a look?
>
> webrev: http://analemma.sfbay.sun.com/java/jdk/ws/libs/rev/6588155/
> bugster: http://monaco.sfbay/detail.jsf?cr=6588155
>
> Aside from the relatively straightforward fixes:
>
> * Makefile: Changed so that the mkdir's output is in the log; when first 
> investigating the problem I wondered if perhaps the target's action had not 
> been executed
>
>
> * RepositoryConfig: Now yields useful output from the InvocationTargetException.
>
> Thanks,
> 	Dave
> _______________________________________________
> modules-dev mailing list
> modules-dev at openjdk.java.net
> http://mail.openjdk.java.net/mailman/listinfo/modules-dev
>   


-- 
Kumar Srinivasan           
Sun Microsystems, Java Software.
408-276-7586




More information about the modules-dev mailing list