[modules-dev] [Fwd: [Fwd: Review request: 6563535, URLRepository.install]]

[Kumar Srinivasan]

> Kumar, did my feedback on your comment make sense or does the issue remain 
> unresolved?
>   
Yep, need I need to get my vision checked too. Affirmative wrt. your 
response.

> Thanks,
> 	Dave
>
> -------- Original Message --------
> Subject: [modules-dev] [Fwd:  Review request: 6563535, URLRepository.install]
> Date: Tue, 07 Aug 2007 14:05:18 -0700
> From: Dave Bristor <David.Bristor at Sun.COM>
> To: modules-dev at openjdk.java.net
>
> Hi folks,
>
> Here's the notice I sent earlier: haven't received any feedback yet.  I sent
> this when JPRT wasn't running tests: all tests were then passing on Solaris;
> I've got a x-platform jprt job running right now on the rest.
>
> Please note: when I did this work, platform & architecture were not available
> from a module definition, so use of them is still not implemented: I will do
> that as a separate task.  OTOH, if anyone feels strongly, I could do it now.
>
> Thanks,
> 	Dave
>
> -------- Original Message --------
> Subject: [modules-dev] Review request: 6563535, URLRepository.install
> Date: Tue, 24 Jul 2007 17:24:27 -0700
> From: Dave Bristor <David.Bristor at Sun.COM>
> To: modules-dev at openjdk.java.net
>
> Hi folks,
>
> This one allows URLRepository.install() to succeed on URLRepositories created
> with a file: URL.
>
> The review is ever-so-slightly preliminary; I've tested on solaris-x86 but
> want to test on Windows also and will do so tomorrow.
>
>
> bugster: http://monaco.sfbay/detail.jsf?cr=6563535
> webrev: http://javaweb.sfbay/java/jdk/ws/libs/rev/6563535/
>
>
> URLRepositoryTest is changed to verify that install() yields exceptions as
> expected.
>
> URLRepoBuilder is changed so that it can build a single JAM, which is used by
> URLRepoInstallTest; most of the changes are code movement.
>
> URLRepository is changed for implementation of install() and uninstall().
> Note also that, when a repository is initialized, if it is file-based and
> repository-metadata.xml does not exist, it gets created.
>
> URLRepoInstallTest verifies that install works.  It is a very basic test;
> there are several error conditions that would be hard to check and so that's
> not done now.
>
> Thanks,
> 	Dave
> _______________________________________________
> modules-dev mailing list
> modules-dev at openjdk.java.net
> http://mail.openjdk.java.net/mailman/listinfo/modules-dev
> _______________________________________________
> modules-dev mailing list
> modules-dev at openjdk.java.net
> http://mail.openjdk.java.net/mailman/listinfo/modules-dev
>
> _______________________________________________
> modules-dev mailing list
> modules-dev at openjdk.java.net
> http://mail.openjdk.java.net/mailman/listinfo/modules-dev
>   


-- 
Kumar Srinivasan           
Sun Microsystems, Java Software.
408-276-7586