[modules-dev] [Fwd: [Fwd: Review request: 6563535, URLRepository.install]]

Stanley M. Ho Stanley.Ho at Sun.COM
Wed Aug 15 16:58:47 PDT 2007


Looks good. One last nitpick ;-)

  733             contents.remove(mai);
  794                 // Restore previous state
  795                 contents.put(mai, md);
  803                 contents.put(mai, md);

You might want to apply similar logic here - mai should be removed from 
the contents only after the JAM file has been uninstalled and the 
metadata has been updated successfully.

- Stanley



More information about the modules-dev mailing list