[modules-dev] Review request: 6559092

[Stanley M. Ho]

Hi Dave,

Looks good. Several comments inline:

-  src/share/classes/sun/module/repository/RepositoryConfig.java

I think rather than creating a fake system repository if one doesn't yet 
exist, it would be better to simply use the bootstrap repository as the 
default system repository, i.e.

	private static Repository systemRepository =       		
			Repository.getBootstrapRepository();

Then if the module launcher needs to change the system repository later, 
it could simply reset it, e.g.

         repository = Modules.newLocalRepository(
                 RepositoryConfig.getSystemRepository(),
                 "application",
                 tmp.getCanonicalFile().toURI().toURL()
                 );
	RepositoryConfig.setSystemRepository(repository);


- test/java/module/repository/LocalRepositoryTest.java

81         check(systemRepo.getParent() == 
Repository.getBootstrapRepository());

This check would break as soon as the repository configuration file 
support is in place, but should be okay for now.

- Stanley