[modules-dev] Review request: 6559092

Dave Bristor David.Bristor at Sun.COM
Fri Jul 13 11:35:18 PDT 2007


Stanley M. Ho wrote:
> 
> Dave Bristor wrote:
> 
>> I've combined our approaches: no more fake system repository, and a 
>> flag to ensure setSystemRepository succeeds only once.
>>
>> I updated the webrev:
>> http://javaweb.sfbay/java/jdk/ws/libs/rev/6559092/
> 
> 
> Looks good. One last thing, I am not sure if you really need 
> RepositoryConfig.getParentForSystemRepository() anymore. You could 
> simply call RepositoryConfig.getSystemRepository() instead and later set 
> the new one back through RepositoryConfig.setSystemRepository().

That seems reasonable.  webrev updated: many more files are changed than last 
time, but the new changes are merely to effect your suggestion.  All tests 
passing.

http://javaweb.sfbay/java/jdk/ws/libs/rev/6559092/

Thanks,
	Dave
> 
> - Stanley



More information about the modules-dev mailing list