[modules-dev] Review request: 6560281

[Dave Bristor]

Hi folks,

This change provides the means to have repositories configured & created.

bugster: http://monaco.sfbay/detail.jsf?cr=6560281
webrev: http://javaweb.sfbay/java/jdk/ws/libs/rev/6560281/

The bulk of the interesting work is in RepositoryConfig.java.

Changes in Modules.java and URLRepository.java are largely to get rid of 
initialize(Map) and instead do initialization during construction; this is 
similar to what was done in fixing 6559071 (see 
http://javaweb.sfbay/java/jdk/ws/libs/rev/6559065%2b6559071%2b6559075).

In earlier review discussion (attached) we'd agreed to remove 
Repository.initialize(Map<String, String>) when this repository configuration 
work was done.  That had a ripple effect, since Repository.initialize() 
invoked it.  Some classes now have the latter, e.g. BootstrapRepository.

The changes include a separate fix proposed by Stanley: in LocalRepository, I 
removed the code in constructors which caused an IOException to be ignored.

RepositoryConfigTest is "reasonable" but there are other interesting cases to 
test; I've noted a couple in the testcase itself.  Should I/we be filing bugs 
for testcases we'd like to write?

Tests passing, javadoc looks good.

Thanks,
	Dave
-------------- next part --------------
An embedded message was scrubbed...
From: "Stanley M. Ho" <Stanley.Ho at Sun.COM>
Subject: Re: Review request for 6559065, 6559071, 6559075
Date: Thu, 07 Jun 2007 12:05:01 -0700
Size: 2360
Url: http://mail.openjdk.java.net/pipermail/modules-dev/attachments/20070718/4b0f1a0b/attachment.mht