[modules-dev] Review please for launcher bugs

[Stanley M. Ho]

Hi Kumar,

Looks good. Several comments inline:

- src/share/classes/sun/module/ModuleLauncher.java

  188         String fname = new File(jamFileName).getName();
  189         String moduleName = fname.substring(0, 
fname.lastIndexOf('.'));
  190         List<ModuleArchiveInfo> ilist =  repository.list();
  191         for (ModuleArchiveInfo i : ilist) {
  192             if (i.getFileName().endsWith(fname + 
JamUtils.EXPANDED_EXT)) {
  193                 definition = getModuleDefinition(repository, 
i.getName());

This looks a bit funny. ModuleArchiveInfo.getFileName() should retain 
the original filename of the jam, not the internal cooked filename. 
Perhaps Dave could clarify.

238                 repository.initialize();

Assuming Dave will putback his changes soon, and we won't need to call 
initialize() manually anymore.

- Stanley


Kumar Srinivasan wrote:
> Hi,
> 
> I need a review of these fixes asap.
> http://javaweb.sfbay/~ksrini/webrevs/j2se-tools/jsr277-6/
> [The webrev contains the CRs].
> 
> Built and tested on Solaris and Windows all the regresssion
> tests in test/java/module pass.
> 
> Thanks
>