[modules-dev] Review request: 6563535, URLRepository.install

Dave Bristor David.Bristor at Sun.COM
Tue Jul 24 17:24:27 PDT 2007


Hi folks,

This one allows URLRepository.install() to succeed on URLRepositories created 
with a file: URL.

The review is ever-so-slightly preliminary; I've tested on solaris-x86 but 
want to test on Windows also and will do so tomorrow.


bugster: http://monaco.sfbay/detail.jsf?cr=6563535
webrev: http://javaweb.sfbay/java/jdk/ws/libs/rev/6563535/


URLRepositoryTest is changed to verify that install() yields exceptions as 
expected.

URLRepoBuilder is changed so that it can build a single JAM, which is used by 
URLRepoInstallTest; most of the changes are code movement.

URLRepository is changed for implementation of install() and uninstall(). 
Note also that, when a repository is initialized, if it is file-based and 
repository-metadata.xml does not exist, it gets created.

URLRepoInstallTest verifies that install works.  It is a very basic test; 
there are several error conditions that would be hard to check and so that's 
not done now.

Thanks,
	Dave



More information about the modules-dev mailing list