[modules-dev] Review request: 6560281

[Stanley M. Ho]

Hi Dave,

Dave Bristor wrote:
> They are uppercase so that they stand out: the intent is that they be 
> treated as reserved words, and that other respository implementation 
> specific properties can be in lower case.  Perhaps make them lower case 
> and/or use a case-insensitive comparison?

Sounds reasonable.

> Related: the default jre extension repository directory is
>     ${java.home}/lib/module/ext
> Do you know into which Makefile I should cause that directory to be 
> created? I've modified LocalRepository to create the sourceLocation if 

Try make/java/module/Makefile.

> it does not exist (which will presumably suffice for the user repository).

If the location doesn't exist, I think it's better to ignore it. It 
would be annoying if the user just mistypes the repository path in the 
launcher and then finds the directory being created as a side effect.

> Fixed.  In line with your suggestion of "classname" above, shouldn't 
> these all be "filename"?

Apparently no. "file" has been the convention used in other 
configurations in the JDK.

> Thanks, I didn't know about PropertyExpander: fixed.  Well, maybe not: 
> if you give PropertyExpander.expand this string:
>     ${user.home/foo/bar
> it doesn't throw an exception, which doesn't seem reasonable (IMHO).  At 
> your suggestion, the code currently uses PropertyExpander, but I 
> disabled the test which checked for the condition above.  Please let me 
> know if I should restore the code I had before.

Let's use PropertyExpander for now. If it turns out we need better error 
handling, then we will migrate all the usages of PropertyExpander into 
something better.

- Stanley