[modules-dev] Review request: 6560281

[Stanley M. Ho]

Hi Dave,

Dave Bristor wrote:
>> If the location doesn't exist, I think it's better to ignore it. It 
>> would be annoying if the user just mistypes the repository path in the 
>> launcher and then finds the directory being created as a side effect.
> 
> This presents a conundrum: As we agreed Monday, the standard 
> repository.properties has
>     user.source=file:${user.home}/.java/module
> and that does not exist, then the JVM will exit.  Something needs to 
> create that directory first.  So along with your mention in earlier 
> email (attached) about having system properties to define the locations 
> of repositories, we still need something to create them.
> 
> One option, for now, is to comment out the user repository entry in 
> repository.properties, and uncomment it once we know how its directory 
> will be created.  For now, this is what's at the updated webrev.  What 
> do you think?

I think there are repositories (e.g. extension repository) that must 
exist as a prerequisite for the module system to run, but there are also 
repositories (e.g. this user level repository) that are optional. Like 
other user specific files or directories under {user.home}, we should 
neither expect this user level repository will always exist nor it be 
created by us. If we can't address this in this putback, let's comment 
out the entry for now.

- Stanley