[modules-dev] Review request for 6560271 (embedded JAR files)

[Dave Bristor]

Hi folks,

This set of changes lets embedded legacy JAR files work, including with the 
JarLibraryPath annotation.  I plan to build on this in making changes to 
support native libraries.  Comments welcome!

bugster: http://monaco.sfbay/detail.jsp?cr=6560271
webrev: http://analemma.sfbay.sun.com/java/jdk/ws/libs/rev/6560271

Description of changes:

Several bits of cleanup, such as for javadoc, consistency, etc.

JamUtils: Added copyFile() which is therefore removed from URLRepository.

LocalRepository: Improve location of expansionDir.

URLRepository: Just cleanup.

LocalJamDefinitionContent: Support for legacy/embedded JAR files.  Code 
cleanup to make it more consistent with URLModuleDefinitionContent.  I think 
this should be renamed to LocalModuleDefinitionContent for consistency (or 
rename the other class); opinions?

URLModuleDefinitionContent: Support for legacy/embedded JAR files.

RepositoryUtils: This new class has static methods which were formerly 
duplicated in others, especially {Local,URL}Repository.  In theory, this could 
be a pair of base classes, one for the *Repository implementations, and one 
for the *ModuleDefinition implementations.  The former is particularly likely.

JamBuilder: now public constructor and can add annotations to the JAM that's 
to be built.

LegacyJarTest: makes sure the above works ;-)

Thanks,
	Dave