[modules-dev] [Fwd: Re: Review request for 6560271 (embedded JAR files)]

[Andreas Sterbenz]

Dave Bristor wrote:
> 
> bugster: http://monaco.sfbay/detail.jsp?cr=6560271
> webrev: http://analemma.sfbay.sun.com/java/jdk/ws/libs/rev/6560271/

Looks fine, some minor comments:

  . JamUtils.copyFile(): creating a BufferedInputStream is not really 
useful here since the reads are all done in BUFFER_SIZEd blocks anyway

  . LocalRepository.installJams(): not sure why you deleted the comment 
about .pack.gz here, but if you don't need it, that is fine with me

  . LocalRepository.assertValidDirs(): why did you change !isDirectory() 
to isFile() ?

  . LocalJamDefinitionContent.createModuleDefinition(): is that string 
really intended to be "URLModuleDefinitionContent" ?

  . RepositoryUtils.extractJarFiles(): is that always 
"URLModuleDefinitionContent" ?

  . RepositoryUtils.extractJarFiles:223: I may be missing something, but 
are you creating a file and then immediately deleting it in some cases?


Andreas.