[modules-dev] Review request for 6601899

[Stephen J. McConnell]

On Fri, 2007-10-26 at 17:45 -0700, Dave Bristor wrote:
> Hi folks,
> 
> This is to fix
> 
> 6601899 (repo) URLRepository.find*() must not return modules for other than 
> the appropriate platform/arch
> 
> bugster: http://monaco.sfbay/detail.jsp?cr=6601899
> webrev: http://analemma.sfbay.sun.com/java/jdk/ws/libs/rev/6601899/
> 
> The bulk of the work involves taking into account platform & arch when 
> installing, finding, and listing modules.  There are several simplifications & 
> cleanups.  The "interesting" changes are in
> 
> LocalRepository
> ModuleInfoXMLReader
> URLRepository
> 
> Changes in those (and to a lesser extent other files) are based on additions 
> to RepositoryUtils.
> 
> LocalRepositoryTest and URLRepositoryTest were updated to take into account 
> platform/arch specifics.  There currently aren't any tests which look for the 
> (IMHO unlikely) case of having specified platform but not arch or vice versa. 

According to javadoc that I've reading though recently (and supporting
implementation code), the scenario you describe cannot exist.  Either
both architecture and platform are specified as non-null OR both
attributes are null.

Cheers, Steve.