[modules-dev] Review request for 6601899

[Dave Bristor]

Brief update: I noticed that URLModuleDefinitionContent.getData() is 
superfluous, given JamUtils.readFile(); the former is removed and prior uses 
of it now use the latter.  Webrev updated.
Thanks,
	Dave

Dave Bristor wrote:
> Hi folks,
> 
> This is to fix
> 
> 6601899 (repo) URLRepository.find*() must not return modules for other than 
> the appropriate platform/arch
> 
> bugster: http://monaco.sfbay/detail.jsp?cr=6601899
> webrev: http://analemma.sfbay.sun.com/java/jdk/ws/libs/rev/6601899/
> 
> The bulk of the work involves taking into account platform & arch when 
> installing, finding, and listing modules.  There are several simplifications & 
> cleanups.  The "interesting" changes are in
> 
> LocalRepository
> ModuleInfoXMLReader
> URLRepository
> 
> Changes in those (and to a lesser extent other files) are based on additions 
> to RepositoryUtils.
> 
> LocalRepositoryTest and URLRepositoryTest were updated to take into account 
> platform/arch specifics.  There currently aren't any tests which look for the 
> (IMHO unlikely) case of having specified platform but not arch or vice versa. 
>   Nor are there (yet) any tests which take into account a user-specified path.
> 
> The changes also include a fix to Jam.java so that temp files are deleted on 
> exit.  Ditto for JamBuilder.java (only used as part of tests, but equally good 
> for it to clean up after itself).
> 
> Thanks,
> 	Dave
> _______________________________________________
> modules-dev mailing list
> modules-dev at openjdk.java.net
> http://mail.openjdk.java.net/mailman/listinfo/modules-dev