[modules-dev] Review request for 6581299

Andreas Sterbenz Andreas.Sterbenz at Sun.COM
Fri Sep 7 18:37:25 PDT 2007


Stanley M. Ho wrote:
> 
> This will support the -C option in the jam tool, and it's similar to the 
> -C option in the jar tool that instructs the tool to change to a 
> specified directory to include files.
> 
> bugster: http://monaco.sfbay/detail.jsf?cr=6581299
> webrev: http://javaweb.sfbay.sun.com/~stanleyh/webrev/jsr-277/6581299-2/
> 
> Regression test is also included.

Looks fine.

About the test, I don't understand why you always do "sep + sep". Isn't 
that already covered by doTest() being called with different values?

Also, is it intentional that you called the directory "jrepos" rather than 
"jrepo" ?

Andreas.




More information about the modules-dev mailing list