[modules-dev] Review request for 6608500

[Kumar Srinivasan]

Hi Dave,

Generally  looks good.

*src/share/classes/sun/module/repository/URLRepository.java*
Why bother with the check to see if it is null, it looks
like platform and arch never gets initialized otherwise right ?
thereby we can also get rid of String value.
389 String value;
390 if ((value = config.get(propertyPrefix + "test.platform")) != null) {
391 platform = value;
392 }
393
394 if ((value = config.get(propertyPrefix + "test.arch")) != null) {
395 arch = value;
396 }


> Hi folks,
>
> This cleans up some tests.  It includes the changes we mentioned yesterday 
> w.r.t. *Repository implementations: they can now be configured from system 
> properties, and those values override values in the Map<String, String> that's 
> provided when the instance is created.  These changes should keep old test 
> files from filling JPRT's temp directories.
>
> bugster: http://monaco.sfbay/detail.jsf?cr=6608500
> webrev: http://analemma.sfbay.sun.com/java/jdk/ws/libs/rev/6608500/
>
> Please note that, with respect to configuring repositories use of the Map is 
> still in LocalRepositoryTest and URLRepositoryTest.  Testing via 
> System.getProperty is in BasicLauncherTests.
>
> Thanks,
> 	Dave
> _______________________________________________
> modules-dev mailing list
> modules-dev at openjdk.java.net
> http://mail.openjdk.java.net/mailman/listinfo/modules-dev
>   


-- 
Kumar Srinivasan           
Sun Microsystems, Java Software.
408-276-7586