[modules-dev] Review request for 6617765, Repository reload() semantics

Dave Bristor David.Bristor at Sun.COM
Wed Feb 13 12:17:26 PST 2008


Hi folks,

This change causes {Local,URL}Repository.reload() to obey the semantics as 
defined in the spec.  Before this change, reload() would blow away any current 
structures and recreate everything from scratch.  Now, only those things which 
are changed are actually affected.  Testing is via additions to 
{Local,URL}RepositoryTest.java.

bugster: http://monaco.sfbay/detail.jsf?cr=6617765
bugs.sun.com: http://bugs.sun.com/view_bug.do?bug_id=6617765
webref: http://analemma.sfbay.sun.com/java/jdk/ws/libs/rev/6617765/

Passes all tests on all platforms via JPRT.

Some notes:

In URLRepository, there was an inner class that wrote the 
repository-metadata.xml file.  That's now in MetadataXMLWriter.java; I renamed 
ModuleInfoXMLReader.java to MetadataXMLReader.java to correspond.

Several places were using a String form of a Version which now instead use a 
java.module.Version form.

Thanks,
	Dave



More information about the modules-dev mailing list