[modules-dev] Updated review request for 6628143, Service Loader support

Dave Bristor David.Bristor at Sun.COM
Tue Jul 1 16:20:33 PDT 2008


Mandy Chung wrote:
> Dave Bristor wrote:
>>
>>>   line 204: since the service providers are loaded lazily, your 
>>> previous spec change should be removed.
>>
>> Could you be more specific?  The javadoc describes how services & 
>> providers are loaded from repositories, and this still holds.  The 
>> implementation is completely lazy :-) so the pre-existing comment 
>> about laziness still applies too.  I think the new text in the webrev 
>> was originally suggested by Stanley.
> 
> I referenced the wrong line number!!  Sorry about that.
> 
> At line 276 in the new version (line 204 in the old version), the diff is:
> 
> -     * #iterator() iterator} method will lazily look up and instantiate
> +     * #iterator() iterator} method will look up and instantiate
> 
> With this new version (supporting the lazy loading), you need to add 
> back the word "lazily" so that the spec of the reload method remains 
> unchanged. This line was modified in your previous version and you 
> probably missed it in this revision.

Got it, fixed!
	Dave
> 
> Mandy



More information about the modules-dev mailing list