[modules-dev] Review request for 6628143, Service Loader support

Dave Bristor David.Bristor at Sun.COM
Thu Jun 12 15:36:54 PDT 2008


Hi folks,

I'd appreciate a review of these changes:

6621843 Support service- and service-provider modules
webrev: http://webrev.invokedynamic.info/bristor/6621843/
bug report: http://bugs.sun.com/view_bug.do?bug_id=6621843

The changes pass all our regression tests, plus those for ServiceLoader, on 
all platforms (tested via JPRT).

The bulk of the changes are in java/util/ServiceLoader.java.

sun/module/core/ServiceProcessor.java is new; it generates service-related 
files under META-INF based on annotations on module-info.

The other new files are all tests.

It would be great to get feedback by 18/Jun.

Folks outside of Sun, please note that the webrev, which is our traditional 
way of showing proposed changes, is hosted on a public site.

Thanks!
	Dave



More information about the modules-dev mailing list