Review request for JDK-8011714: Regexp decimal escape handling still not correct

Hannes Wallnoefer hannes.wallnoefer at oracle.com
Tue Apr 9 05:44:13 PDT 2013


Marcus spotted a local/field mix-up that managed to pass the test 
because backreferences only occurred at the end of regular expressions 
in the test. Here's a version with that fixed and better tests:

http://cr.openjdk.java.net/~hannesw/8011714/webrev.03/

Hannes

Am 2013-04-09 12:43, schrieb Hannes Wallnoefer:
> I uploaded a new webrev, please review:
>
> http://cr.openjdk.java.net/~hannesw/8011714/webrev.02/
>
> I think we now fully replicate V8 behaviour on this. If a 
> backreference turns out to be invalid as much of it as constitutes a 
> valid octal escape is converted to a unicode escape, the rest is added 
> as number literal.
>
> Hannes
>
>
> Am 2013-04-09 11:01, schrieb Hannes Wallnoefer:
>> Please ignore this patch. I found even more border cases which will 
>> be included in a forthcoming patch.
>>
>> Hannes
>>
>> Am 2013-04-08 21:59, schrieb Hannes Wallnoefer:
>>> Please review JDK-8011714: Regexp decimal escape handling still not 
>>> correct
>>>
>>> http://cr.openjdk.java.net/~hannesw/8011714/
>>>
>>> thanks,
>>> Hannes
>>
>



More information about the nashorn-dev mailing list