hg: nashorn/jdk8/nashorn: 8010701: Immutable nodes - final iteration

[Marcus Lagergren]

For the historical record, here is the final webrev after review comments had been applied. A great thank you is in order to Hannes Wallnöfer as well, who found a subtle Splitter bug in the 11th hour, and who provided a fix.

http://cr.openjdk.java.net/~lagergren/8010701/webrev2/

/M
 
On Apr 19, 2013, at 4:35 PM, Marcus Lagergren <marcus.lagergren at oracle.com> wrote:

> There doesn't seem to be a way to credit multiple authors in hg, and if it were, I couldn't figure it out. I just wanted to make it known that Attila Szegedi is as much the author of this change set as me and he deserves full credit for it as well.
> 
> /M
> 
> On Apr 19, 2013, at 4:16 PM, marcus.lagergren at oracle.com wrote:
> 
>> Changeset: 3a209cbd1d8f
>> Author:    lagergren
>> Date:      2013-04-19 16:11 +0200
>> URL:       http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/3a209cbd1d8f
>> 
>> 8010701: Immutable nodes - final iteration
>> Reviewed-by: sundar, hannesw, jlaskey
>> 
>> ! bin/verbose_octane.sh
>> ! src/jdk/nashorn/api/scripting/NashornScriptEngine.java
>> ! src/jdk/nashorn/internal/codegen/Attr.java
>> ! src/jdk/nashorn/internal/codegen/ClassEmitter.java
>> ! src/jdk/nashorn/internal/codegen/CodeGenerator.java
>> ! src/jdk/nashorn/internal/codegen/CompilationPhase.java
>> ! src/jdk/nashorn/internal/codegen/Compiler.java
>> ! src/jdk/nashorn/internal/codegen/CompilerConstants.java
>> ! src/jdk/nashorn/internal/codegen/FieldObjectCreator.java
>> ! src/jdk/nashorn/internal/codegen/FinalizeTypes.java
>> ! src/jdk/nashorn/internal/codegen/FoldConstants.java
>> - src/jdk/nashorn/internal/codegen/Frame.java
>> ! src/jdk/nashorn/internal/codegen/Lower.java
>> ! src/jdk/nashorn/internal/codegen/MethodEmitter.java
>> ! src/jdk/nashorn/internal/codegen/Namespace.java
>> ! src/jdk/nashorn/internal/codegen/ObjectClassGenerator.java
>> ! src/jdk/nashorn/internal/codegen/ObjectCreator.java
>> + src/jdk/nashorn/internal/codegen/SplitMethodEmitter.java
>> ! src/jdk/nashorn/internal/codegen/Splitter.java
>> ! src/jdk/nashorn/internal/codegen/WeighNodes.java
>> ! src/jdk/nashorn/internal/ir/AccessNode.java
>> ! src/jdk/nashorn/internal/ir/BaseNode.java
>> ! src/jdk/nashorn/internal/ir/BinaryNode.java
>> ! src/jdk/nashorn/internal/ir/Block.java
>> + src/jdk/nashorn/internal/ir/BlockLexicalContext.java
>> ! src/jdk/nashorn/internal/ir/BreakNode.java
>> ! src/jdk/nashorn/internal/ir/BreakableNode.java
>> ! src/jdk/nashorn/internal/ir/CallNode.java
>> ! src/jdk/nashorn/internal/ir/CaseNode.java
>> ! src/jdk/nashorn/internal/ir/CatchNode.java
>> ! src/jdk/nashorn/internal/ir/ContinueNode.java
>> - src/jdk/nashorn/internal/ir/DoWhileNode.java
>> ! src/jdk/nashorn/internal/ir/EmptyNode.java
>> ! src/jdk/nashorn/internal/ir/ExecuteNode.java
>> + src/jdk/nashorn/internal/ir/Flags.java
>> ! src/jdk/nashorn/internal/ir/ForNode.java
>> ! src/jdk/nashorn/internal/ir/FunctionNode.java
>> ! src/jdk/nashorn/internal/ir/IdentNode.java
>> ! src/jdk/nashorn/internal/ir/IfNode.java
>> ! src/jdk/nashorn/internal/ir/IndexNode.java
>> ! src/jdk/nashorn/internal/ir/LabelNode.java
>> - src/jdk/nashorn/internal/ir/LabeledNode.java
>> ! src/jdk/nashorn/internal/ir/LexicalContext.java
>> + src/jdk/nashorn/internal/ir/LexicalContextNode.java
>> ! src/jdk/nashorn/internal/ir/LineNumberNode.java
>> ! src/jdk/nashorn/internal/ir/LiteralNode.java
>> ! src/jdk/nashorn/internal/ir/Location.java
>> + src/jdk/nashorn/internal/ir/LoopNode.java
>> ! src/jdk/nashorn/internal/ir/Node.java
>> ! src/jdk/nashorn/internal/ir/ObjectNode.java
>> ! src/jdk/nashorn/internal/ir/PropertyNode.java
>> ! src/jdk/nashorn/internal/ir/ReturnNode.java
>> ! src/jdk/nashorn/internal/ir/RuntimeNode.java
>> ! src/jdk/nashorn/internal/ir/SplitNode.java
>> ! src/jdk/nashorn/internal/ir/SwitchNode.java
>> ! src/jdk/nashorn/internal/ir/Symbol.java
>> ! src/jdk/nashorn/internal/ir/TernaryNode.java
>> ! src/jdk/nashorn/internal/ir/ThrowNode.java
>> ! src/jdk/nashorn/internal/ir/TryNode.java
>> ! src/jdk/nashorn/internal/ir/UnaryNode.java
>> ! src/jdk/nashorn/internal/ir/VarNode.java
>> ! src/jdk/nashorn/internal/ir/WhileNode.java
>> ! src/jdk/nashorn/internal/ir/WithNode.java
>> + src/jdk/nashorn/internal/ir/annotations/Immutable.java
>> ! src/jdk/nashorn/internal/ir/debug/ASTWriter.java
>> ! src/jdk/nashorn/internal/ir/debug/JSONWriter.java
>> ! src/jdk/nashorn/internal/ir/debug/PrintVisitor.java
>> ! src/jdk/nashorn/internal/ir/visitor/NodeOperatorVisitor.java
>> ! src/jdk/nashorn/internal/ir/visitor/NodeVisitor.java
>> ! src/jdk/nashorn/internal/lookup/MethodHandleFactory.java
>> ! src/jdk/nashorn/internal/objects/NativeString.java
>> ! src/jdk/nashorn/internal/parser/AbstractParser.java
>> ! src/jdk/nashorn/internal/parser/JSONParser.java
>> ! src/jdk/nashorn/internal/parser/Parser.java
>> ! src/jdk/nashorn/internal/parser/TokenType.java
>> ! src/jdk/nashorn/internal/runtime/Context.java
>> ! src/jdk/nashorn/internal/runtime/DebugLogger.java
>> ! src/jdk/nashorn/internal/runtime/RecompilableScriptFunctionData.java
>> ! src/jdk/nashorn/internal/runtime/StructureLoader.java
>> ! src/jdk/nashorn/internal/runtime/linker/ClassAndLoader.java
>> ! src/jdk/nashorn/tools/Shell.java
>> + test/script/basic/try2.js
>> + test/script/basic/try2.js.EXPECTED
>> 
>