Review request for JDK-8012334: ToUint32, ToInt32, and ToUint16 don't conform to spec

Marcus Lagergren marcus.lagergren at oracle.com
Tue Apr 23 11:51:47 PDT 2013


How much is a bit and what did you measure?

On Apr 23, 2013, at 8:33 PM, Hannes Wallnoefer <hannes.wallnoefer at oracle.com> wrote:

> Please review webrev for JDK-8012334: ToUint32, ToInt32, and ToUint16 don't conform to spec:
> 
> http://cr.openjdk.java.net/~hannesw/8012334/
> 
> The code path for small numbers is now a little bit slower but not much. The code path for large numbers  that don't fit in 32 bits is quite a bit slower, but it should be correct now. The patch also contains a microbenchmark for ToInt32 (signed right shift) and ToUint32 (unsigned right shift).
> 
> Hannes



More information about the nashorn-dev mailing list