Review request for JDK-8013208 Octane performance regression

Hannes Wallnoefer hannes.wallnoefer at oracle.com
Thu Apr 25 14:16:20 PDT 2013


+1 with two minor nit-pickings:

- you could call the 4 parameter version of findProperty() with this as 
last argument to avoid constructing a new FindProperty immediately 
afterwards
- local variable 'index' is redundant in methods taking an int parameter.

Hannes

Am 2013-04-25 22:01, schrieb Jim Laskey:
> http://cr.openjdk.java.net/~jlaskey/8013208/webrev.01/index.html
>
> convertKey was called every time an indexed getter was invoked, instead of conditionally.  Reworked the code to be conditionally calledl, also optimizing for Integer (boxed) values (very frequent) and cases when key is not an index.
>



More information about the nashorn-dev mailing list