Review request for JDK-8008814

Attila Szegedi attila.szegedi at oracle.com
Mon Apr 29 14:13:06 PDT 2013


Interesting… Eclipse apparently uses case sensitive ordering, for better or worse. I took a look at few other files, and this is apparently the case, i.e. NativeArray.java imports have this order:

import jdk.nashorn.internal.runtime.JSType;
import jdk.nashorn.internal.runtime.PropertyDescriptor;
import jdk.nashorn.internal.runtime.ScriptFunction;
import jdk.nashorn.internal.runtime.ScriptObject;
import jdk.nashorn.internal.runtime.ScriptRuntime;
import jdk.nashorn.internal.runtime.Undefined;
import jdk.nashorn.internal.runtime.arrays.ArrayData;
import jdk.nashorn.internal.runtime.arrays.ArrayIndex;
import jdk.nashorn.internal.runtime.arrays.ArrayLikeIterator;
import jdk.nashorn.internal.runtime.arrays.IteratorAction;
import jdk.nashorn.internal.runtime.linker.Bootstrap;
import jdk.nashorn.internal.runtime.linker.InvokeByName;

On Apr 29, 2013, at 7:33 PM, Jim Laskey (Oracle) <james.laskey at oracle.com> wrote:

> +1
> 
> But not sure about the ordering of
> 
> 40 import jdk.nashorn.internal.runtime.Source;
> 41 import jdk.nashorn.internal.runtime.regexp.RegExpFactory;
> 
> 
> On 2013-04-29, at 1:08 PM, Attila Szegedi <attila.szegedi at oracle.com> wrote:
> 
>> Please review JDK-8008814 at http://cr.openjdk.java.net/~attila/8008814/webrev.00
>> 
>> Thanks,
>> Attila.
> 



More information about the nashorn-dev mailing list