Review request for JDK-8023373

Marcus Lagergren marcus.lagergren at oracle.com
Wed Aug 21 04:07:53 PDT 2013


+1. It would be nice if we had a more consistent way to express it like Java.super or something, though, for consistency. Even though Rhino does it this way. What do you other guys think?

/M

On Aug 21, 2013, at 11:19 AM, Attila Szegedi <attila.szegedi at oracle.com> wrote:

> Please review JDK-8023373 at http://cr.openjdk.java.net/~attila/8023373/webrev.00
> 
> Much of the change is just refactoring -- we already had code for emitting super calls, as overridable methods that did not have an overridde specified by an adapter instance had to delegate to the super call, so the change really was to extract it into emitSuperCall() method, which in turn made generateSuperMethod() really trivial. The rest of the changes in generateMethod() are really just  refactorings, and moving some code around (e.g. definition of nextLocalVar was moved closer to the point where it was used). 
> 
> Thanks,
>  Attila.



More information about the nashorn-dev mailing list