Review request for 8023368: Instance __proto__ property should exist and be writable.

Hannes Wallnoefer hannes.wallnoefer at oracle.com
Wed Aug 21 04:28:03 PDT 2013


+1

Am 2013-08-21 13:09, schrieb A. Sundararajan:
> Thanks for the review.
>
> As Hannes pointed given that Object.setPrototypeOf *may* make into 
> ES6, we are future proof ;-)
>
> PS. Updated webrev.01 to remove --proto-assign flag.
>
> -Sundar
>
> On Wednesday 21 August 2013 02:13 PM, Attila Szegedi wrote:
>> Your patch seems okay to me, so +1. I'm somewhat anxious if we have a 
>> prototype change switchpoint everywhere right now (specifically for 
>> negative lookups, e.g. property not found), but I suppose we do -- I 
>> mean, changing the prototype of an object should not be much 
>> different than replacing all the properties of the original prototype 
>> (except it's only scoped to a single object), and that works already.
>>
>> Cue my inevitable grumbling about having to support this 
>> functionality and the questionable programming practices of people 
>> who rely on it, but I'll just take a deep breath and carry on :-)
>>
>> Attila.
>>
>> On Aug 21, 2013, at 7:43 AM, "A. Sundararajan" 
>> <sundararajan.athijegannathan at oracle.com> wrote:
>>
>>> Please review http://cr.openjdk.java.net/~sundar/8023368/
>>>
>>> Thanks
>>> -Sundar
>



More information about the nashorn-dev mailing list