From james.laskey at oracle.com Sat Feb 2 08:21:41 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Sat, 2 Feb 2013 12:21:41 -0400 Subject: Review request for JDK-8006191 Message-ID: Please review http://cr.openjdk.java.net/~jlaskey/8006191/webrev.00/index.html Cheers, -- Jim From hannes.wallnoefer at oracle.com Mon Feb 4 01:14:12 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Mon, 04 Feb 2013 10:14:12 +0100 Subject: Review request for JDK-8007273 Message-ID: <510F7BE4.5040705@oracle.com> Please review webrev for JDK-8007273 (Creation of ScriptFunctions can be refactored): http://cr.openjdk.java.net/~hannesw/8007273/ This introduces a ScriptFunctionData class that stores everything needed to instantiate functions and is stored in a script class's constants array. It also adds a dedicated ScriptFunction constructors for functions from compiled code as opposed to other types of functions such as built-ins. This makes code simpler since different types of functions have different properties (e.g. built-ins don't have source or token, compiled functions don't have to compute arity from signature...). I also tried various forms of optimization and found the one thing that helps is to not adapt method handle signatures into something that can be used by used by ScriptFunction.invoke()/.construct() (which mainly means boxing the return value to Object) right away in the constructor. Instead the method handle is now left unchanged in ScriptFunction and only adapted lazily for invoke()/construct(). This seems to improve performance in earley-boyer and gbemu by something like 10-20%. Hannes From hannes.wallnoefer at oracle.com Mon Feb 4 02:02:24 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Mon, 04 Feb 2013 11:02:24 +0100 Subject: Review request for JDK-8007273 In-Reply-To: <510F7BE4.5040705@oracle.com> References: <510F7BE4.5040705@oracle.com> Message-ID: <510F8730.1000104@oracle.com> I have to take the statement below back - I see 10% improvement in earley-boyer, but gbemu seems mostly unchanged now. You know how that is with octane, you get good runs and bad runs... Hannes Am 2013-02-04 10:14, schrieb Hannes Wallnoefer: > > This seems to improve performance in earley-boyer and gbemu by > something like 10-20%. > > Hannes From marcus.lagergren at oracle.com Mon Feb 4 02:11:39 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Mon, 4 Feb 2013 11:11:39 +0100 Subject: Review request for JDK-8007273 In-Reply-To: <510F7BE4.5040705@oracle.com> References: <510F7BE4.5040705@oracle.com> Message-ID: <86DFAD5C-0ED5-48D3-A6E8-C22C415228C8@oracle.com> +1. This is great. It made stuff simpler. Can you reconfirm the performance numbers (I understand you are doing that anyway). Won't most of the improvement be because of reuse of ScriptFunctionData at Function creation sites rather than lack of method handle adaptation. I like that we are as lazy as possible with modifying method handles too though, we've learnt that it does indeed matter. This should play nicely with my call site type specialization work. Attila brought up the the issue of deconstructing the ScriptFunctionData into fields in the ScriptFunction again, but I don't have any strong opinions about it. Deconstructing it may be unnecessary, but it buys some readability and not all constructors have access to ScriptFunctionData I guess. /M On Feb 4, 2013, at 10:14 AM, Hannes Wallnoefer wrote: > Please review webrev for JDK-8007273 (Creation of ScriptFunctions can be refactored): > > http://cr.openjdk.java.net/~hannesw/8007273/ > > This introduces a ScriptFunctionData class that stores everything needed to instantiate functions and is stored in a script class's constants array. > > It also adds a dedicated ScriptFunction constructors for functions from compiled code as opposed to other types of functions such as built-ins. This makes code simpler since different types of functions have different properties (e.g. built-ins don't have source or token, compiled functions don't have to compute arity from signature...). > > I also tried various forms of optimization and found the one thing that helps is to not adapt method handle signatures into something that can be used by used by ScriptFunction.invoke()/.construct() (which mainly means boxing the return value to Object) right away in the constructor. Instead the method handle is now left unchanged in ScriptFunction and only adapted lazily for invoke()/construct(). This seems to improve performance in earley-boyer and gbemu by something like 10-20%. > > Hannes From sundararajan.athijegannathan at oracle.com Mon Feb 4 03:00:51 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Mon, 04 Feb 2013 16:30:51 +0530 Subject: Review request for JDK-8006191 In-Reply-To: References: Message-ID: <510F94E3.8000309@oracle.com> Looks good - few changes suggested: * Global.java - exec_name for local variable name. We don't use _ names for locals * ScriptingFunctions.java - the exec function may just throw IOException, InterupptedException etc. let the script caller deal with exceptions by try..catch (if desired) * $ starting names in ScriptingFunctions.exec - I think $ starting names are reserved for tools like javac and other compile time tools. Better to avoid the same. Script variable names are fine. (i.e., $ starting names for script global vars are fine). -Sundar On Saturday 02 February 2013 09:51 PM, Jim Laskey (Oracle) wrote: > Please review http://cr.openjdk.java.net/~jlaskey/8006191/webrev.00/index.html > > Cheers, > > -- Jim > From sundararajan.athijegannathan at oracle.com Mon Feb 4 03:44:02 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Mon, 04 Feb 2013 17:14:02 +0530 Subject: Review request JDK-8007452: add scripting programmers doc changes for nashorn Message-ID: <510F9F02.8020702@oracle.com> Please review http://cr.openjdk.java.net/~sundar/8007452/ Thanks -Sundar From james.laskey at oracle.com Mon Feb 4 04:15:04 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Mon, 04 Feb 2013 12:15:04 +0000 Subject: hg: nashorn/jdk8/nashorn: 8007455: Extraneous $(ECHO) in make/Makefile Message-ID: <20130204121505.82F89477DA@hg.openjdk.java.net> Changeset: a704700470fb Author: jlaskey Date: 2013-02-04 08:13 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/a704700470fb 8007455: Extraneous $(ECHO) in make/Makefile Reviewed-by: sundar Contributed-by: james.laskey at oracle.com ! make/Makefile From hannes.wallnoefer at oracle.com Mon Feb 4 05:14:54 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Mon, 04 Feb 2013 14:14:54 +0100 Subject: Review request for JDK-8006191 In-Reply-To: References: Message-ID: <510FB44E.5060605@oracle.com> +1. Minor nitpick: There are two unused imports for java.util.logging classes in ScriptingFunctions.java. Hannes Am 2013-02-02 17:21, schrieb Jim Laskey (Oracle): > Please review http://cr.openjdk.java.net/~jlaskey/8006191/webrev.00/index.html > > Cheers, > > -- Jim > From marcus.lagergren at oracle.com Mon Feb 4 06:02:58 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Mon, 4 Feb 2013 15:02:58 +0100 Subject: Please review http://cr.openjdk.java.net/~lagergren/8007215/ Message-ID: <7423E0E3-0E76-4A74-AEB0-46F8D950B465@oracle.com> Fixed broken varargs. http://cr.openjdk.java.net/~lagergren/8007215/ /M From marcus.lagergren at oracle.com Mon Feb 4 06:06:23 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Mon, 4 Feb 2013 15:06:23 +0100 Subject: Review request for JDK-8006191 In-Reply-To: <510FB44E.5060605@oracle.com> References: <510FB44E.5060605@oracle.com> Message-ID: <2C092C00-B7E2-45A2-A706-FD1FFB371DA1@oracle.com> Also - if you need logging in Nashorn, pls go through the DebugLogger API for inter-module compatibility. /M On Feb 4, 2013, at 2:14 PM, Hannes Wallnoefer wrote: > +1. > > Minor nitpick: There are two unused imports for java.util.logging classes in ScriptingFunctions.java. > > Hannes > > > Am 2013-02-02 17:21, schrieb Jim Laskey (Oracle): >> Please review http://cr.openjdk.java.net/~jlaskey/8006191/webrev.00/index.html >> >> Cheers, >> >> -- Jim >> > From hannes.wallnoefer at oracle.com Mon Feb 4 06:47:23 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Mon, 04 Feb 2013 15:47:23 +0100 Subject: Review request JDK-8007452: add scripting programmers doc changes for nashorn In-Reply-To: <510F9F02.8020702@oracle.com> References: <510F9F02.8020702@oracle.com> Message-ID: <510FC9FB.90303@oracle.com> Nice docs and examples! A few notes below. - There's a bit of overlap between the treatment of abstract classes in "Accessing Java Classes" and the "Implementing Java Interfaces" section further down. These concepts are very similar, maybe they should be treated together (or next to each other)? - These two sentences seem redundant: "Multiple scopes are supported by |javax.script.ScriptContext| interface. A script context supports one or more scopes with associated Bindings for each scope." Maybe combine to something like "The |javax.script.ScriptContext| interface supports multiple scopes with associated Bindings for each scope." - I think the following comment (contained twice) should have an "it" near the end ("implements it or not"): | //|javax.script.Invocable| is an optional interface. // Check whether your script engine implements or not!| Hannes Am 2013-02-04 12:44, schrieb A. Sundararajan: > Please review http://cr.openjdk.java.net/~sundar/8007452/ > > Thanks > -Sundar From attila.szegedi at oracle.com Mon Feb 4 06:49:09 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Mon, 4 Feb 2013 15:49:09 +0100 Subject: Review request for JDK-8007460 Message-ID: <2C4C8AE4-DBED-465D-B3A4-59ABED204C25@oracle.com> Please review JDK-8007460 at http://cr.openjdk.java.net/~attila/8007460/webrev.00 Thanks, Attila. From marcus.lagergren at oracle.com Mon Feb 4 06:55:11 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Mon, 4 Feb 2013 15:55:11 +0100 Subject: Review request for JDK-8007460 In-Reply-To: <2C4C8AE4-DBED-465D-B3A4-59ABED204C25@oracle.com> References: <2C4C8AE4-DBED-465D-B3A4-59ABED204C25@oracle.com> Message-ID: <98C9C222-58C7-4DE4-B1BC-6BD349AD5B74@oracle.com> +1 On Feb 4, 2013, at 3:49 PM, Attila Szegedi wrote: > Please review JDK-8007460 at http://cr.openjdk.java.net/~attila/8007460/webrev.00 > > Thanks, > Attila. From james.laskey at oracle.com Mon Feb 4 06:58:34 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Mon, 4 Feb 2013 10:58:34 -0400 Subject: Review request for JDK-8007460 In-Reply-To: <2C4C8AE4-DBED-465D-B3A4-59ABED204C25@oracle.com> References: <2C4C8AE4-DBED-465D-B3A4-59ABED204C25@oracle.com> Message-ID: +1 On 2013-02-04, at 10:49 AM, Attila Szegedi wrote: > Please review JDK-8007460 at http://cr.openjdk.java.net/~attila/8007460/webrev.00 > > Thanks, > Attila. From attila.szegedi at oracle.com Mon Feb 4 07:00:03 2013 From: attila.szegedi at oracle.com (attila.szegedi at oracle.com) Date: Mon, 04 Feb 2013 15:00:03 +0000 Subject: hg: nashorn/jdk8/nashorn: 8007460: var assignment to a parameter in a varargs method causes compilation error Message-ID: <20130204150004.751F7477E3@hg.openjdk.java.net> Changeset: bb86bf840f9f Author: attila Date: 2013-02-04 15:59 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/bb86bf840f9f 8007460: var assignment to a parameter in a varargs method causes compilation error Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/MethodEmitter.java + test/script/basic/JDK-8007460.js + test/script/basic/JDK-8007460.js.EXPECTED From marcus.lagergren at oracle.com Mon Feb 4 07:17:41 2013 From: marcus.lagergren at oracle.com (marcus.lagergren at oracle.com) Date: Mon, 04 Feb 2013 15:17:41 +0000 Subject: hg: nashorn/jdk8/nashorn: 8007215: Varargs broken for the case of passing more than the arg limit arguments. Message-ID: <20130204151741.E1D48477E5@hg.openjdk.java.net> Changeset: bee7c8a45a04 Author: lagergren Date: 2013-02-04 16:20 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/bee7c8a45a04 8007215: Varargs broken for the case of passing more than the arg limit arguments. Reviewed-by: jlaskey, attila ! src/jdk/nashorn/api/scripting/NashornException.java ! src/jdk/nashorn/api/scripting/NashornScriptEngine.java ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/FunctionSignature.java ! src/jdk/nashorn/internal/codegen/MethodEmitter.java ! src/jdk/nashorn/internal/codegen/RuntimeCallSite.java ! src/jdk/nashorn/internal/codegen/SharedScopeCall.java ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/runtime/ECMAException.java ! src/jdk/nashorn/internal/runtime/ScriptFunction.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java + test/script/basic/JDK-8007215.js + test/script/basic/JDK-8007215.js.EXPECTED From james.laskey at oracle.com Mon Feb 4 10:55:05 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Mon, 04 Feb 2013 18:55:05 +0000 Subject: hg: nashorn/jdk8/nashorn: 8006191: `cmd` -> exec("cmd") in script mode Message-ID: <20130204185507.042A9477F5@hg.openjdk.java.net> Changeset: 6f58c28c4faa Author: jlaskey Date: 2013-02-04 14:48 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/6f58c28c4faa 8006191: `cmd` -> exec("cmd") in script mode Reviewed-by: sundar, lagergren, hannesw Contributed-by: james.laskey at oracle.com ! src/jdk/nashorn/api/scripting/NashornScriptEngine.java ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/parser/Lexer.java ! src/jdk/nashorn/internal/parser/Parser.java ! src/jdk/nashorn/internal/parser/TokenType.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/OptionsObject.java ! src/jdk/nashorn/internal/runtime/ScriptingFunctions.java ! src/jdk/nashorn/internal/runtime/resources/Messages.properties + test/script/basic/JDK-8006191.js + test/script/basic/JDK-8006191.js.EXPECTED From james.laskey at oracle.com Mon Feb 4 13:36:57 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Mon, 04 Feb 2013 21:36:57 +0000 Subject: hg: nashorn/jdk8: 20 new changesets Message-ID: <20130204213658.39A96477FF@hg.openjdk.java.net> Changeset: 50307da0149e Author: jqzuo Date: 2012-12-31 14:52 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/50307da0149e 8005583: Install build(gnumake all) failed preventing RE from doing JDK8 combo builds Reviewed-by: paulk, billyh ! make/install-rules.gmk Changeset: e5664599a127 Author: cgruszka Date: 2013-01-02 14:54 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/e5664599a127 Merge Changeset: 75634cbeab47 Author: cgruszka Date: 2013-01-04 13:11 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/75634cbeab47 Merge Changeset: 61d7e2971723 Author: cgruszka Date: 2013-01-14 14:40 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/61d7e2971723 Merge Changeset: f9163f9cb1da Author: cgruszka Date: 2013-01-23 08:50 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/f9163f9cb1da Merge Changeset: 5a5e97f9ac0a Author: erikj Date: 2013-01-18 09:58 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/5a5e97f9ac0a 8006520: build-infra: Fix sparkle-framework configure parameter Reviewed-by: tbell, ohair ! common/autoconf/generated-configure.sh ! common/makefiles/Jprt.gmk Changeset: edad83acbd46 Author: erikj Date: 2013-01-18 16:48 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/edad83acbd46 8003693: build-infra: bridgeBuild should allow for partial build (no hotspot) Reviewed-by: tbell ! common/makefiles/Jprt.gmk Changeset: c3bf62746a80 Author: tbell Date: 2013-01-23 13:30 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/c3bf62746a80 8006797: build-infra JPRT builds need JPRT_ARCHIVE_INSTALL_BUNDLE in common/makefiles/Jprt.gmk Reviewed-by: ohair ! common/makefiles/Jprt.gmk Changeset: b43aa5bd8ca5 Author: katleman Date: 2013-01-23 15:40 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/b43aa5bd8ca5 Merge Changeset: cd2fa0d0ed3d Author: katleman Date: 2013-01-24 16:48 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/cd2fa0d0ed3d Added tag jdk8-b74 for changeset b43aa5bd8ca5 ! .hgtags Changeset: 039783b67959 Author: lana Date: 2013-01-26 18:24 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/039783b67959 Merge Changeset: e28985c549aa Author: raginip Date: 2013-01-18 11:31 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/e28985c549aa 8000839: Integrate the Java Access Bridge with Java Runtime Reviewed-by: ptbrunet, erikj ! common/bin/compare_exceptions.sh.incl Changeset: db46b1c27a93 Author: erikj Date: 2013-01-28 14:23 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/db46b1c27a93 Merge - common/autoconf/closed.version.numbers ! common/autoconf/generated-configure.sh - common/autoconf/version.numbers ! common/bin/compare_exceptions.sh.incl Changeset: 8baaaba2ee6b Author: lana Date: 2013-01-29 20:16 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/8baaaba2ee6b Merge Changeset: 0d4b0a13adb2 Author: erikj Date: 2013-01-23 11:37 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/0d4b0a13adb2 8005855: build-infra: Remove -R flag when cross compiling Reviewed-by: dholmes, tbell ! common/autoconf/generated-configure.sh ! common/autoconf/libraries.m4 Changeset: ea6379d4624f Author: erikj Date: 2013-01-23 11:41 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/ea6379d4624f 8006663: build-infra: Compare two arbitrary zip/jar files with compare.sh Reviewed-by: tbell ! common/bin/compare.sh Changeset: 0d46733cfffb Author: erikj Date: 2013-01-23 11:42 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/0d46733cfffb 8006658: build-infra: Make MILESTONE behave the same as JDK_BUILD_NUMBER Reviewed-by: ohrstrom, dholmes, tbell ! common/autoconf/generated-configure.sh ! common/autoconf/jdk-options.m4 Changeset: 9e5847257731 Author: erikj Date: 2013-01-24 09:17 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/9e5847257731 Merge Changeset: 2a713921952c Author: katleman Date: 2013-01-30 13:39 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/2a713921952c Merge ! common/autoconf/generated-configure.sh Changeset: ecd447139a39 Author: jlaskey Date: 2013-02-04 17:30 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/ecd447139a39 Merge ! common/autoconf/generated-configure.sh From james.laskey at oracle.com Mon Feb 4 13:37:44 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Mon, 04 Feb 2013 21:37:44 +0000 Subject: hg: nashorn/jdk8/corba: Added tag jdk8-b74 for changeset 2132845cf5f7 Message-ID: <20130204213745.CA23B47800@hg.openjdk.java.net> Changeset: d4e68ce17795 Author: katleman Date: 2013-01-24 16:48 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/corba/rev/d4e68ce17795 Added tag jdk8-b74 for changeset 2132845cf5f7 ! .hgtags From james.laskey at oracle.com Mon Feb 4 13:38:17 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Mon, 04 Feb 2013 21:38:17 +0000 Subject: hg: nashorn/jdk8/hotspot: 65 new changesets Message-ID: <20130204214020.7497847801@hg.openjdk.java.net> Changeset: 89fc17e8d808 Author: katleman Date: 2013-01-24 16:48 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/89fc17e8d808 Added tag jdk8-b74 for changeset 1a3e54283c54 ! .hgtags Changeset: d58b7b43031b Author: amurillo Date: 2013-01-11 02:02 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/d58b7b43031b 8006034: new hotspot build - hs25-b16 Reviewed-by: jcoomes ! make/hotspot_version Changeset: adc176e95bf2 Author: acorn Date: 2013-01-09 11:39 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/adc176e95bf2 8005689: InterfaceAccessFlagsTest failures in Lambda-JDK tests Summary: Fix verifier for new interface access flags Reviewed-by: acorn, kvn Contributed-by: bharadwaj.yadavalli at oracle.com ! src/share/vm/classfile/classFileParser.cpp Changeset: dd7248d3e151 Author: zgu Date: 2013-01-09 14:46 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/dd7248d3e151 7152671: RFE: Windows decoder should add some std dirs to the symbol search path Summary: Added JRE/JDK bin directories to decoder's symbol search path Reviewed-by: dcubed, sla ! src/os/windows/vm/decoder_windows.cpp ! src/os/windows/vm/decoder_windows.hpp Changeset: 97ee8abd6ab2 Author: zgu Date: 2013-01-09 12:10 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/97ee8abd6ab2 Merge Changeset: aefb345d3f5e Author: acorn Date: 2013-01-10 17:38 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/aefb345d3f5e 7199207: NPG: Crash in PlaceholderTable::verify after StackOverflow Summary: Reduce scope of placeholder table entries to improve cleanup Reviewed-by: dholmes, coleenp ! src/share/vm/classfile/placeholders.cpp ! src/share/vm/classfile/placeholders.hpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/utilities/exceptions.hpp Changeset: 91bf7da5c609 Author: mikael Date: 2013-01-10 17:06 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/91bf7da5c609 8004747: Remove last_entry from VM_STRUCT macros Summary: Instead of passing in last_entry to all the VM_ macros just expand it in the main vmStructs.cpp file. Reviewed-by: dholmes, sspitsyn, minqi ! src/cpu/sparc/vm/vmStructs_sparc.hpp ! src/cpu/x86/vm/vmStructs_x86.hpp ! src/cpu/zero/vm/vmStructs_zero.hpp ! src/os_cpu/bsd_x86/vm/vmStructs_bsd_x86.hpp ! src/os_cpu/bsd_zero/vm/vmStructs_bsd_zero.hpp ! src/os_cpu/linux_sparc/vm/vmStructs_linux_sparc.hpp ! src/os_cpu/linux_x86/vm/vmStructs_linux_x86.hpp ! src/os_cpu/linux_zero/vm/vmStructs_linux_zero.hpp ! src/os_cpu/solaris_sparc/vm/vmStructs_solaris_sparc.hpp ! src/os_cpu/solaris_x86/vm/vmStructs_solaris_x86.hpp ! src/os_cpu/windows_x86/vm/vmStructs_windows_x86.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: c1c8479222cd Author: dholmes Date: 2013-01-10 21:00 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/c1c8479222cd 8005921: Memory leaks in vmStructs.cpp Reviewed-by: dholmes, mikael, rasbold Contributed-by: Jeremy Manson ! src/share/vm/runtime/vmStructs.cpp Changeset: e0cf9af8978e Author: zgu Date: 2013-01-11 12:30 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/e0cf9af8978e 8005936: PrintNMTStatistics doesn't work for normal JVM exit Summary: Moved NMT shutdown code to JVM exit handler to ensure NMT statistics is printed when PrintNMTStatistics is enabled Reviewed-by: acorn, dholmes, coleenp ! src/share/vm/runtime/java.cpp ! src/share/vm/runtime/thread.cpp Changeset: 90a92d5bca17 Author: zgu Date: 2013-01-11 09:53 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/90a92d5bca17 Merge Changeset: 4a916f2ce331 Author: jwilhelm Date: 2013-01-14 15:17 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/4a916f2ce331 8003985: Support @Contended Annotation - JEP 142 Summary: HotSpot changes to support @Contended annotation. Reviewed-by: coleenp, kvn, jrose Contributed-by: Aleksey Shipilev ! agent/src/share/classes/sun/jvm/hotspot/oops/InstanceKlass.java ! src/cpu/sparc/vm/vm_version_sparc.cpp ! src/cpu/x86/vm/vm_version_x86.cpp ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/classFileParser.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/oops/fieldInfo.hpp ! src/share/vm/oops/fieldStreams.hpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: f9eb431c3efe Author: coleenp Date: 2013-01-14 11:01 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/f9eb431c3efe 8006005: Fix constant pool index validation and alignment trap for method parameter reflection Summary: This patch addresses an alignment trap due to the storage format of method parameters data in constMethod. It also adds code to validate constant pool indexes for method parameters data. Reviewed-by: jrose, dholmes Contributed-by: eric.mccorkle at oracle.com ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/oops/constMethod.hpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/runtime/reflection.cpp Changeset: 5b6a231e5a86 Author: coleenp Date: 2013-01-14 08:37 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/5b6a231e5a86 Merge ! src/share/vm/classfile/classFileParser.cpp Changeset: fe1472c87a27 Author: mikael Date: 2013-01-14 11:00 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/fe1472c87a27 8005592: ClassLoaderDataGraph::_unloading incorrectly defined as nonstatic in vmStructs Summary: Added assertion to catch problem earlier and removed the unused field Reviewed-by: dholmes, acorn ! src/share/vm/runtime/vmStructs.cpp Changeset: c793367610c1 Author: coleenp Date: 2013-01-15 17:05 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/c793367610c1 8005467: CDS size information is incorrect and unfriendly Summary: Changed words to bytes, and added usage percentage information Reviewed-by: coleenp, twisti Contributed-by: ioi.lam at oracle.com ! src/share/vm/memory/metaspaceShared.cpp Changeset: 92d4b5d8dde4 Author: acorn Date: 2013-01-16 18:23 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/92d4b5d8dde4 Merge ! src/cpu/x86/vm/vm_version_x86.cpp ! src/share/vm/runtime/globals.hpp Changeset: 337e1dd9d902 Author: jiangli Date: 2013-01-11 16:55 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/337e1dd9d902 8005895: Inefficient InstanceKlass field packing wasts memory. Summary: Pack _misc_has_default_methods into the _misc_flags, move _idnum_allocated_count. Reviewed-by: coleenp, shade ! src/share/vm/oops/instanceKlass.hpp Changeset: 94fa3c4e7643 Author: vladidan Date: 2013-01-14 13:44 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/94fa3c4e7643 8005639: Move InlineSynchronizedMethods flag from develop to product Summary: Move InlineSynchronizedMethods flag from develop to product Reviewed-by: kvn, vladidan Contributed-by: Alexander Harlap ! src/share/vm/c1/c1_globals.hpp Changeset: 9deda4d8e126 Author: vladidan Date: 2013-01-14 13:52 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/9deda4d8e126 8005204: Code Cache Reduction: command line options implementation Summary: Adding more detailed output on CodeCache usage Reviewed-by: kvn, vladidan Contributed-by: Alexander Harlap ! src/share/vm/code/codeCache.cpp ! src/share/vm/code/codeCache.hpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/java.cpp ! src/share/vm/utilities/vmError.cpp Changeset: 212c5b9c38e7 Author: dlong Date: 2013-01-17 01:27 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/212c5b9c38e7 Merge ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/java.cpp Changeset: a3f92e6c0274 Author: twisti Date: 2013-01-11 14:07 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/a3f92e6c0274 8006031: LibraryCallKit::inline_array_copyOf disabled unintentionally with 7172640 Reviewed-by: kvn ! src/share/vm/opto/library_call.cpp Changeset: f9bda35f4226 Author: twisti Date: 2013-01-11 16:47 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/f9bda35f4226 8005816: Shark: fix volatile float field access Reviewed-by: twisti Contributed-by: Roman Kennke ! src/share/vm/shark/sharkBlock.cpp Changeset: c566b81b3323 Author: twisti Date: 2013-01-11 16:47 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/c566b81b3323 8005817: Shark: implement deoptimization support Reviewed-by: twisti Contributed-by: Roman Kennke ! src/cpu/zero/vm/frame_zero.cpp ! src/cpu/zero/vm/frame_zero.inline.hpp ! src/cpu/zero/vm/sharkFrame_zero.hpp ! src/share/vm/shark/sharkInvariants.hpp ! src/share/vm/shark/sharkTopLevelBlock.cpp Changeset: c095a7f289aa Author: twisti Date: 2013-01-11 16:47 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/c095a7f289aa 8005818: Shark: fix OSR for non-empty incoming stack Reviewed-by: twisti Contributed-by: Roman Kennke ! src/share/vm/shark/sharkCompiler.cpp ! src/share/vm/shark/sharkFunction.cpp ! src/share/vm/shark/sharkInvariants.hpp Changeset: 606eada1bf86 Author: twisti Date: 2013-01-11 16:47 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/606eada1bf86 8005820: Shark: enable JSR292 support Reviewed-by: twisti Contributed-by: Roman Kennke ! src/share/vm/compiler/abstractCompiler.hpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/shark/sharkBlock.cpp ! src/share/vm/shark/sharkCompiler.hpp ! src/share/vm/shark/sharkConstant.cpp ! src/share/vm/shark/sharkInliner.cpp ! src/share/vm/shark/sharkTopLevelBlock.cpp Changeset: 6d1f5516534e Author: twisti Date: 2013-01-11 20:01 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/6d1f5516534e 8006127: remove printing code added with 8006031 Reviewed-by: kvn ! src/share/vm/opto/library_call.cpp Changeset: d92fa52a5d03 Author: vlivanov Date: 2013-01-14 08:22 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/d92fa52a5d03 8006095: C1: SIGSEGV w/ -XX:+LogCompilation Summary: avoid printing inlining decision when compilation fails Reviewed-by: kvn, roland ! src/share/vm/c1/c1_GraphBuilder.cpp Changeset: f1de9dbc914e Author: twisti Date: 2013-01-15 12:06 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/f1de9dbc914e 8006109: test/java/util/AbstractSequentialList/AddAll.java fails: assert(rtype == ctype) failed: mismatched return types Reviewed-by: kvn ! src/share/vm/ci/ciType.cpp ! src/share/vm/ci/ciType.hpp ! src/share/vm/opto/doCall.cpp Changeset: 5b8548391bf3 Author: kvn Date: 2013-01-15 14:45 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/5b8548391bf3 8005821: C2: -XX:+PrintIntrinsics is broken Summary: Check all print inlining flags when processing inlining list. Reviewed-by: kvn, twisti Contributed-by: david.r.chase at oracle.com ! src/share/vm/opto/compile.cpp Changeset: bf623b2d5508 Author: kvn Date: 2013-01-16 14:55 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/bf623b2d5508 8006204: please JTREGify test/compiler/7190310/Test7190310.java Summary: Add proper jtreg annotations in the preceding comment, including an explicit timeout. Reviewed-by: kvn, twisti Contributed-by: david.r.chase at oracle.com ! test/compiler/7190310/Test7190310.java Changeset: eab4f9ed602c Author: kvn Date: 2013-01-17 18:47 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/eab4f9ed602c Merge ! src/share/vm/compiler/compileBroker.cpp Changeset: 689e1218d7fe Author: brutisso Date: 2013-01-14 09:58 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/689e1218d7fe 8004018: Remove old initialization flags Reviewed-by: dholmes, stefank Contributed-by: erik.helin at oracle.com ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/thread.cpp Changeset: a30e7b564541 Author: brutisso Date: 2013-01-14 21:30 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/a30e7b564541 8005972: ParNew should not update the tenuring threshold when promotion failed has occurred Reviewed-by: ysr, johnc, jwilhelm ! src/share/vm/gc_implementation/parNew/parNewGeneration.cpp ! src/share/vm/gc_implementation/parNew/parNewGeneration.hpp ! src/share/vm/memory/defNewGeneration.cpp ! src/share/vm/memory/defNewGeneration.hpp Changeset: ed6154d7d259 Author: stefank Date: 2013-01-15 13:32 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/ed6154d7d259 8005590: java_lang_Class injected field resolved_constructor appears unused Reviewed-by: coleenp, dholmes ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/runtime/vmStructs.cpp Changeset: ff0a7943fd29 Author: stefank Date: 2013-01-15 10:09 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/ff0a7943fd29 8005994: Method annotations are allocated unnecessarily during class file parsing Summary: Also reviewed by: vitalyd at gmail.com Reviewed-by: coleenp, acorn ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/prims/jvm.cpp Changeset: 4967eb4f67a9 Author: johnc Date: 2013-01-15 12:32 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/4967eb4f67a9 8001425: G1: Change the default values for certain G1 specific flags Summary: Changes to default and ergonomic flag values recommended by performance team. Changes were also reviewed by Monica Beckwith . Reviewed-by: brutisso, huntch ! src/share/vm/gc_implementation/g1/g1_globals.hpp Changeset: 2dce7c34c564 Author: stefank Date: 2013-01-17 11:39 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/2dce7c34c564 8006513: Null pointer in DefaultMethods::generate_default_methods when merging annotations Reviewed-by: brutisso, jfranck ! src/share/vm/classfile/defaultMethods.cpp Changeset: 59a58e20dc60 Author: jmasa Date: 2013-01-17 19:04 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/59a58e20dc60 8006537: Assert when dumping archive with default methods Reviewed-by: coleenp ! src/share/vm/classfile/classLoaderData.cpp ! src/share/vm/memory/metadataFactory.hpp Changeset: f422634e5828 Author: brutisso Date: 2013-01-18 11:03 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/f422634e5828 Merge ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 70c89bd6b895 Author: amurillo Date: 2013-01-18 05:19 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/70c89bd6b895 Merge Changeset: 2b878edabfc0 Author: amurillo Date: 2013-01-18 05:19 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/2b878edabfc0 Added tag hs25-b16 for changeset 70c89bd6b895 ! .hgtags Changeset: 46e60405583b Author: amurillo Date: 2013-01-18 05:33 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/46e60405583b 8006511: new hotspot build - hs25-b17 Reviewed-by: jcoomes ! make/hotspot_version Changeset: e94ed1591b42 Author: sla Date: 2013-01-16 16:30 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/e94ed1591b42 8006403: Regression: jstack failed due to the FieldInfo regression in SA Reviewed-by: sla, dholmes Contributed-by: Aleksey Shipilev ! agent/src/share/classes/sun/jvm/hotspot/oops/InstanceKlass.java ! src/share/vm/runtime/vmStructs.cpp Changeset: 557bda927cc2 Author: sla Date: 2013-01-18 14:15 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/557bda927cc2 Merge ! src/share/vm/runtime/vmStructs.cpp Changeset: 617b18aadb33 Author: sla Date: 2013-01-18 19:13 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/617b18aadb33 Merge Changeset: 203f64878aab Author: hseigel Date: 2013-01-17 10:25 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/203f64878aab 7102489: RFE: cleanup jlong typedef on __APPLE__and _LLP64 systems. Summary: Define jlong as long on all LP64 platforms and add JLONG_FORMAT macro. Reviewed-by: dholmes, coleenp, mikael, kvn ! src/cpu/x86/vm/jni_x86.h ! src/os/bsd/vm/os_bsd.inline.hpp ! src/os/linux/vm/os_linux.inline.hpp ! src/os/posix/launcher/java_md.c ! src/os/posix/launcher/java_md.h ! src/os/solaris/vm/os_solaris.inline.hpp ! src/os/windows/launcher/java_md.c ! src/os/windows/launcher/java_md.h ! src/os/windows/vm/os_windows.cpp ! src/os/windows/vm/os_windows.inline.hpp ! src/share/tools/launcher/java.c ! src/share/tools/launcher/java.h ! src/share/vm/c1/c1_InstructionPrinter.cpp ! src/share/vm/c1/c1_LIR.cpp ! src/share/vm/ci/ciReplay.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp ! src/share/vm/gc_implementation/shared/ageTable.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/opto/idealGraphPrinter.cpp ! src/share/vm/opto/type.cpp ! src/share/vm/runtime/aprofiler.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/os.hpp ! src/share/vm/runtime/perfData.cpp ! src/share/vm/runtime/virtualspace.cpp ! src/share/vm/services/diagnosticArgument.cpp ! src/share/vm/services/heapDumper.cpp ! src/share/vm/services/lowMemoryDetector.cpp ! src/share/vm/utilities/globalDefinitions.hpp ! src/share/vm/utilities/globalDefinitions_gcc.hpp ! src/share/vm/utilities/ostream.cpp ! src/share/vm/utilities/taskqueue.cpp Changeset: b14da2e6f2dc Author: coleenp Date: 2013-01-17 13:40 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/b14da2e6f2dc 7174978: NPG: Fix bactrace builder for class redefinition Summary: Remove Method* from backtrace but save version so redefine classes doesn't give inaccurate line numbers. Removed old Merlin API with duplicate code. Reviewed-by: dholmes, sspitsyn ! make/bsd/makefiles/mapfile-vers-debug ! make/bsd/makefiles/mapfile-vers-product ! make/linux/makefiles/mapfile-vers-debug ! make/linux/makefiles/mapfile-vers-product ! make/solaris/makefiles/mapfile-vers ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/oops/constantPool.cpp ! src/share/vm/oops/constantPool.hpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvm.h ! src/share/vm/prims/jvmtiRedefineClasses.cpp Changeset: b5f6465019f6 Author: coleenp Date: 2013-01-17 22:11 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/b5f6465019f6 8006548: version wrong in new constantPool code Summary: fix increment problem with saved_version Reviewed-by: dholmes ! src/share/vm/oops/constantPool.hpp Changeset: c07c102cbad7 Author: brutisso Date: 2013-01-21 09:00 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/c07c102cbad7 8006431: os::Bsd::initialize_system_info() sets _physical_memory too large Summary: Use HW_MEMSIZE instead of HW_USERMEM to get a 64 bit value of the physical memory on the machine. Also reviewed by vitalyd at gmail.com. Reviewed-by: sla, dholmes, dlong, mikael ! src/os/bsd/vm/os_bsd.cpp Changeset: c73c3f2c5b3b Author: acorn Date: 2013-01-21 16:11 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/c73c3f2c5b3b Merge ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/services/diagnosticArgument.cpp Changeset: f3184f32ce0b Author: dcubed Date: 2013-01-22 05:55 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/f3184f32ce0b 6444286: Possible naked oop related to biased locking revocation safepoint in jni_exit() Summary: Add missing Handle. Reviewed-by: acorn, dholmes, dice, sspitsyn Contributed-by: karen.kinnear at oracle.com ! src/share/vm/runtime/synchronizer.cpp Changeset: 22ba8c8ce6a6 Author: dcubed Date: 2013-01-22 05:56 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/22ba8c8ce6a6 8004902: correctness fixes motivated by contended locking work (6607129) Summary: misc correctness fixes Reviewed-by: acorn, dholmes, dice, sspitsyn Contributed-by: dave.dice at oracle.com ! src/os/bsd/vm/os_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/runtime/objectMonitor.cpp ! src/share/vm/runtime/objectMonitor.inline.hpp Changeset: 5ce621176715 Author: dcubed Date: 2013-01-22 05:57 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/5ce621176715 8004903: VMThread::execute() calls Thread::check_for_valid_safepoint_state() on concurrent VM ops Summary: check_for_valid_safepoint_state() only applies to blocking VM ops Reviewed-by: acorn, dholmes, dice, sspitsyn Contributed-by: karen.kinnear at oracle.com ! src/share/vm/runtime/vmThread.cpp Changeset: edd23b35b1a5 Author: zgu Date: 2013-01-22 14:27 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/edd23b35b1a5 6871190: Don't terminate JVM if it is running in a non-interactive session Summary: Don't handle CTRL_LOGOFF_EVENT event when the process is running in a non-interactive session Reviewed-by: ctornqvi, acorn ! src/os/windows/vm/os_windows.cpp Changeset: 2ef7061f13b4 Author: zgu Date: 2013-01-22 11:54 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/2ef7061f13b4 Merge ! src/os/windows/vm/os_windows.cpp Changeset: 7df93f7c14a5 Author: brutisso Date: 2013-01-16 12:46 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/7df93f7c14a5 8006242: G1: WorkerDataArray::verify() too strict for double calculations Summary: Also reviewed by vitalyd at gmail.com. Reviewed-by: johnc, mgerdin ! src/share/vm/gc_implementation/g1/g1GCPhaseTimes.cpp ! src/share/vm/gc_implementation/g1/g1GCPhaseTimes.hpp Changeset: bf8c2b2c8cfa Author: mgerdin Date: 2013-01-22 13:42 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/bf8c2b2c8cfa 8004147: test/Makefile jtreg_tests target does not work with cygwin Reviewed-by: ctornqvi, brutisso ! test/Makefile Changeset: d754ef7b9352 Author: jmasa Date: 2013-01-24 06:04 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/d754ef7b9352 Merge Changeset: a7114d3d712e Author: kvn Date: 2013-01-22 11:31 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/a7114d3d712e 8005055: pass outputStream to more opto debug routines Summary: pass the output stream to node->dump() and everything reachable from there Reviewed-by: kvn Contributed-by: goetz.lindenmaier at sap.com ! src/share/vm/compiler/oopMap.cpp ! src/share/vm/opto/callnode.cpp ! src/share/vm/opto/callnode.hpp ! src/share/vm/opto/machnode.cpp ! src/share/vm/opto/node.cpp ! src/share/vm/opto/node.hpp ! src/share/vm/opto/optoreg.hpp ! src/share/vm/opto/regalloc.cpp ! src/share/vm/opto/regmask.cpp ! src/share/vm/opto/regmask.hpp Changeset: b30b3c2a0cf2 Author: kvn Date: 2013-01-22 15:34 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/b30b3c2a0cf2 6896617: Optimize sun.nio.cs.ISO_8859_1$Encode.encodeArrayLoop() on x86 Summary: Use SSE4.2 and AVX2 instructions for encodeArray intrinsic. Reviewed-by: roland ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/macroAssembler_x86.cpp ! src/cpu/x86/vm/macroAssembler_x86.hpp ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/share/vm/adlc/formssel.cpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/opto/classes.hpp ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/lcm.cpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/matcher.cpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/memnode.hpp + test/compiler/6896617/Test6896617.java Changeset: 522c328b8b77 Author: kvn Date: 2013-01-23 15:11 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/522c328b8b77 8003878: compiler/7196199 test failed on OS X since 8b54, jdk7u12b01 Summary: Limit vectors size to 16 bytes on BSD until the problem is fixed Reviewed-by: twisti ! src/cpu/x86/vm/vm_version_x86.cpp Changeset: 22ead76da3f4 Author: kmo Date: 2013-01-24 02:03 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/22ead76da3f4 8006758: LinkResolver assertion (caused by @Contended changes) Summary: treat anonymous classes as privileged code to restore the special handling for @Compiled during class file parsing Reviewed-by: jrose, coleenp, kvn, dholmes ! src/share/vm/classfile/classFileParser.cpp Changeset: 274a29bf5682 Author: kmo Date: 2013-01-24 09:06 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/274a29bf5682 Merge Changeset: b4391649e91e Author: amurillo Date: 2013-01-25 02:36 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/b4391649e91e Merge ! .hgtags Changeset: 6778d0b16593 Author: amurillo Date: 2013-01-25 02:36 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/6778d0b16593 Added tag hs25-b17 for changeset b4391649e91e ! .hgtags From james.laskey at oracle.com Mon Feb 4 13:40:25 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Mon, 04 Feb 2013 21:40:25 +0000 Subject: hg: nashorn/jdk8/jaxp: 2 new changesets Message-ID: <20130204214032.9902847802@hg.openjdk.java.net> Changeset: 69bc57b1ebdd Author: katleman Date: 2013-01-24 16:48 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxp/rev/69bc57b1ebdd Added tag jdk8-b74 for changeset 2087e24a4357 ! .hgtags Changeset: ff0b73a6b3f6 Author: lana Date: 2013-01-26 18:25 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxp/rev/ff0b73a6b3f6 Merge From james.laskey at oracle.com Mon Feb 4 13:40:38 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Mon, 04 Feb 2013 21:40:38 +0000 Subject: hg: nashorn/jdk8/jaxws: Added tag jdk8-b74 for changeset 12db3c5a3393 Message-ID: <20130204214042.4FEBC47803@hg.openjdk.java.net> Changeset: 966bf9f3c41a Author: katleman Date: 2013-01-24 16:49 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxws/rev/966bf9f3c41a Added tag jdk8-b74 for changeset 12db3c5a3393 ! .hgtags From james.laskey at oracle.com Mon Feb 4 13:40:58 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Mon, 04 Feb 2013 21:40:58 +0000 Subject: hg: nashorn/jdk8/langtools: 16 new changesets Message-ID: <20130204214141.173F747804@hg.openjdk.java.net> Changeset: 950d8195a5a4 Author: jjg Date: 2013-01-30 09:40 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/950d8195a5a4 8007096: DocLint parsing problems with some comments Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/parser/DocCommentParser.java ! src/share/classes/com/sun/tools/javac/parser/JavadocTokenizer.java + test/tools/doclint/EndWithIdentifierTest.java + test/tools/doclint/EndWithIdentifierTest.out + test/tools/doclint/UnfinishedInlineTagTest.java + test/tools/doclint/UnfinishedInlineTagTest.out Changeset: c924291865e5 Author: jjg Date: 2013-01-30 09:47 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/c924291865e5 8007034: debug printer for javac internals Reviewed-by: mcimadamore + test/tools/javac/lib/DPrinter.java Changeset: 8e4c22acebeb Author: darcy Date: 2013-01-31 12:16 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/8e4c22acebeb 8007313: Remove use of {ContainerFor/ContainedBy} from langtools Reviewed-by: jjg ! test/tools/javac/annotations/typeAnnotations/classfile/CombinationsTargetTest1.java ! test/tools/javac/annotations/typeAnnotations/classfile/CombinationsTargetTest2.java ! test/tools/javac/annotations/typeAnnotations/newlocations/RepeatingTypeAnnotations.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/Driver.java Changeset: 54e4ba223319 Author: katleman Date: 2013-01-24 16:49 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/54e4ba223319 Added tag jdk8-b74 for changeset 56c97aff46bb ! .hgtags Changeset: c2e11e2ec4a3 Author: lana Date: 2013-01-26 19:24 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/c2e11e2ec4a3 Merge - test/tools/javac/annotations/repeatingAnnotations/MissingContainedBy.java - test/tools/javac/annotations/repeatingAnnotations/MissingContainerFor.java - test/tools/javac/annotations/repeatingAnnotations/UseWrongContainedBy.java - test/tools/javac/annotations/repeatingAnnotations/UseWrongContainerFor.java - test/tools/javac/annotations/repeatingAnnotations/WrongContainedBy.java - test/tools/javac/annotations/repeatingAnnotations/WrongContainerFor.java - test/tools/javac/diags/examples/ContainedByDocumentedMismatch.java - test/tools/javac/diags/examples/ContainedByInheritedMismatch.java - test/tools/javac/diags/examples/ContainedByNoValue.java - test/tools/javac/diags/examples/ContainedByNonDefault.java - test/tools/javac/diags/examples/ContainedByRetentionMismatch.java - test/tools/javac/diags/examples/ContainedByTargetMismatch.java - test/tools/javac/diags/examples/ContainedByWrongValueType.java - test/tools/javac/diags/examples/InferredDoNotConformToLower.java - test/tools/javac/diags/examples/NoUniqueMaximalInstance.java - test/tools/javac/diags/examples/WrongContainedBy.java - test/tools/javac/diags/examples/WrongContainerFor.java - test/tools/javac/lambda/MethodReference26.out - test/tools/javac/lambda/TargetType06.out - test/tools/javac/lambda/TargetType11.out - test/tools/javac/lambda/TargetType45.out - test/tools/javac/lambda/VoidCompatibility.out - test/tools/javac/typeAnnotations/newlocations/BasicTest.java - test/tools/javac/typeAnnotations/newlocations/BasicTest.out Changeset: b7cb3d7ade25 Author: lana Date: 2013-01-31 10:23 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/b7cb3d7ade25 Merge Changeset: 7b269e916e06 Author: lana Date: 2013-01-31 14:10 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/7b269e916e06 Merge Changeset: bec996065c45 Author: darcy Date: 2013-01-31 18:58 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/bec996065c45 8007351: Malformed copyright statements in typeAnnotations test directory Reviewed-by: jjg ! test/tools/javac/annotations/typeAnnotations/TargetTypes.java ! test/tools/javac/annotations/typeAnnotations/TypeProcOnly.java ! test/tools/javac/annotations/typeAnnotations/api/AnnotatedArrayOrder.java ! test/tools/javac/annotations/typeAnnotations/api/ArrayCreationTree.java ! test/tools/javac/annotations/typeAnnotations/api/ArrayPositionConsistency.java ! test/tools/javac/annotations/typeAnnotations/classfile/ClassfileTestHelper.java ! test/tools/javac/annotations/typeAnnotations/classfile/CombinationsTargetTest1.java ! test/tools/javac/annotations/typeAnnotations/classfile/CombinationsTargetTest2.java ! test/tools/javac/annotations/typeAnnotations/classfile/NewTypeArguments.java ! test/tools/javac/annotations/typeAnnotations/classfile/NoTargetAnnotations.java ! test/tools/javac/annotations/typeAnnotations/classfile/TypeCasts.java ! test/tools/javac/annotations/typeAnnotations/classfile/Wildcards.java ! test/tools/javac/annotations/typeAnnotations/failures/target/DotClass.java ! test/tools/javac/annotations/typeAnnotations/newlocations/Varargs.java ! test/tools/javac/annotations/typeAnnotations/packageanno/PackageProcessor.java ! test/tools/javac/annotations/typeAnnotations/packageanno/mypackage/Anno.java ! test/tools/javac/annotations/typeAnnotations/packageanno/mypackage/MyClass.java ! test/tools/javac/annotations/typeAnnotations/packageanno/mypackage/package-info.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/ClassExtends.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/ClassTypeParam.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/Constructors.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/Driver.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/ExceptionParameters.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/Fields.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/FromSpecification.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/MethodParameters.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/MethodReceivers.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/MethodReturns.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/MethodThrows.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/MethodTypeParam.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/MultiCatch.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/NestedTypes.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/NewObjects.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/ReferenceInfoUtil.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/RepeatingTypeAnnotations.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/TypeCasts.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/TypeTests.java Changeset: 3ab64e4293a1 Author: jjg Date: 2013-01-31 19:19 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/3ab64e4293a1 8007329: minor issues in impl class hierarchry for DCTree.* classes Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/tree/DCTree.java Changeset: 3d97a9a7a82b Author: jjg Date: 2013-01-31 19:31 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/3d97a9a7a82b 8004353: Generated html is wrong for overview.html; content has incorrect css footer class Reviewed-by: jjg Contributed-by: roger.riggs at oracle.com ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexWriter.java Changeset: 8590c20af3ce Author: jjg Date: 2013-02-01 08:33 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/8590c20af3ce 8007306: DPrinter: improve display of impl-class, internal tag/kind, and external tag/kind Reviewed-by: mcimadamore ! test/tools/javac/lib/DPrinter.java Changeset: 6df931ce1a81 Author: jjg Date: 2013-02-01 08:36 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/6df931ce1a81 8007305: DPrinter: provide better usage message Reviewed-by: mcimadamore ! test/tools/javac/lib/DPrinter.java Changeset: 0b1c88705568 Author: jjg Date: 2013-02-01 12:01 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/0b1c88705568 8007344: javac may not make tree end positions and/or doc comments available to processors and listeners Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java + test/tools/javac/api/8007344/Test.java Changeset: 55cca2f38ee6 Author: darcy Date: 2013-02-01 13:01 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/55cca2f38ee6 8001614: Include annotation type to documented supported-ness Reviewed-by: alanb, jjg, tbell ! make/Makefile-classic ! make/build.properties + src/share/classes/jdk/Supported.java Changeset: 4cc73ec94686 Author: vromero Date: 2013-02-02 21:04 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/4cc73ec94686 8005075: Pool.Method, and Pool.Variable redundant Symbol field should be removed Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/jvm/Pool.java Changeset: a51a8dac0a2f Author: vromero Date: 2013-02-03 02:31 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/a51a8dac0a2f 7199823: javac generates inner class that can't be verified Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Lower.java + test/tools/javac/7199823/InnerClassCannotBeVerified.java From james.laskey at oracle.com Mon Feb 4 13:43:58 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Mon, 04 Feb 2013 21:43:58 +0000 Subject: hg: nashorn/jdk8/jdk: 63 new changesets Message-ID: <20130204215557.1FF1847806@hg.openjdk.java.net> Changeset: a343d280bd8c Author: jfranck Date: 2013-01-29 10:32 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/a343d280bd8c 8004698: Implement Core Reflection for Type Annotations Reviewed-by: darcy ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/System.java + src/share/classes/java/lang/reflect/AnnotatedArrayType.java + src/share/classes/java/lang/reflect/AnnotatedParameterizedType.java + src/share/classes/java/lang/reflect/AnnotatedType.java + src/share/classes/java/lang/reflect/AnnotatedTypeVariable.java + src/share/classes/java/lang/reflect/AnnotatedWildcardType.java ! src/share/classes/java/lang/reflect/Constructor.java ! src/share/classes/java/lang/reflect/Executable.java ! src/share/classes/java/lang/reflect/Field.java ! src/share/classes/java/lang/reflect/Method.java ! src/share/classes/java/lang/reflect/ReflectAccess.java ! src/share/classes/java/lang/reflect/TypeVariable.java ! src/share/classes/sun/misc/JavaLangAccess.java ! src/share/classes/sun/reflect/LangReflectAccess.java ! src/share/classes/sun/reflect/ReflectionFactory.java + src/share/classes/sun/reflect/annotation/AnnotatedTypeFactory.java ! src/share/classes/sun/reflect/annotation/AnnotationParser.java + src/share/classes/sun/reflect/annotation/TypeAnnotation.java + src/share/classes/sun/reflect/annotation/TypeAnnotationParser.java ! src/share/classes/sun/reflect/generics/reflectiveObjects/TypeVariableImpl.java ! src/share/javavm/export/jvm.h ! src/share/native/java/lang/Class.c + test/java/lang/annotation/TypeAnnotationReflection.java + test/java/lang/annotation/TypeParamAnnotation.java Changeset: 5097fe015763 Author: jfranck Date: 2013-01-31 10:10 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/5097fe015763 8005712: Simplify support for repeating annotations in j.l.r.AnnotatedElement 8004919: AnnotationSupport uses possibly half-constructed AnnotationType instances Summary: Implements the simplified semantics for repeating annotations and removes the incorrect obtaining of an AnnotationType Reviewed-by: darcy, abuckley ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/System.java ! src/share/classes/java/lang/reflect/AnnotatedElement.java ! src/share/classes/java/lang/reflect/Executable.java ! src/share/classes/java/lang/reflect/Field.java ! src/share/classes/java/lang/reflect/Parameter.java ! src/share/classes/sun/misc/JavaLangAccess.java ! src/share/classes/sun/reflect/annotation/AnnotationSupport.java ! test/java/lang/annotation/repeatingAnnotations/RepeatedUnitTest.java ! test/java/lang/annotation/repeatingAnnotations/subpackage/Containee.java ! test/java/lang/annotation/repeatingAnnotations/subpackage/Container.java ! test/java/lang/annotation/repeatingAnnotations/subpackage/InheritedContainee.java ! test/java/lang/annotation/repeatingAnnotations/subpackage/InheritedContainer.java Changeset: 3f766f58c48a Author: dbuck Date: 2013-01-31 10:55 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/3f766f58c48a 7042126: (alt-rt) HashMap.clone implementation should be re-examined Summary: Test case for cr7042126. Issue only found in OracleJDK, but test case is valid for OpenJDK as well Reviewed-by: mduigou + test/java/util/HashMap/HashMapCloneLeak.java Changeset: 857d99bef21d Author: sherman Date: 2013-01-31 11:09 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/857d99bef21d 8005394: Base64.Decoder/Encoder.wrap(XStream) don't throw NPE for null args passed Summary: to check null for dec/enc.wrap methods Reviewed-by: alanb ! src/share/classes/java/util/Base64.java ! test/java/util/Base64/TestBase64.java Changeset: 278397f752da Author: darcy Date: 2013-01-31 12:13 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/278397f752da 8005832: Remove java.lang.annotation.{ContainedBy, ContainerFor} annotation types Reviewed-by: mduigou - src/share/classes/java/lang/annotation/ContainedBy.java - src/share/classes/java/lang/annotation/ContainerFor.java ! src/share/classes/java/lang/annotation/InvalidContainerAnnotationError.java Changeset: a5f38e811ab0 Author: darcy Date: 2013-01-31 12:23 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/a5f38e811ab0 8007115: Refactor regression tests for java.lang.reflect.Parameter Reviewed-by: emc ! test/java/lang/reflect/Parameter/WithoutParameters.java Changeset: e5ce312a5b10 Author: sherman Date: 2013-01-31 13:13 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/e5ce312a5b10 8007298: Base64.getMimeDecoder().decode() throws IAE for a single non-base64 character 8006526: Base64.Decoder.decode(String) spec contains a copy-paste mistake Summary: to ignore single non-base64 char in mime decoding Reviewed-by: alanb ! src/share/classes/java/util/Base64.java ! test/java/util/Base64/TestBase64.java Changeset: cff8d7768d72 Author: mduigou Date: 2013-01-31 13:27 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/cff8d7768d72 8006709: Add minimal support of MacOSX platform for NetBeans Projects Summary: Adds support for MacOSX platform and architecture detection. Other minor updates (-source/target 1.8) Reviewed-by: ohair + make/netbeans/common/architectures/arch-x86_64.properties + make/netbeans/common/architectures/name-Macosx.properties ! make/netbeans/common/java-data-native.ent ! make/netbeans/common/java-data-no-native.ent ! make/netbeans/common/make.xml ! make/netbeans/common/shared.xml Changeset: 6d849e883c40 Author: yhuang Date: 2013-01-13 18:45 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/6d849e883c40 7114053: [sq] Inproper tanslation for iso lanugage of Albanian Reviewed-by: naoto ! src/share/classes/sun/util/resources/sq/LocaleNames_sq.properties ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java Changeset: 2de23975ee10 Author: yhuang Date: 2013-01-15 19:08 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/2de23975ee10 Merge Changeset: 68fc838d5e89 Author: yhuang Date: 2013-01-16 19:05 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/68fc838d5e89 Merge Changeset: 595baf3cc781 Author: yhuang Date: 2013-01-16 23:08 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/595baf3cc781 Merge Changeset: 478d8354285a Author: erikj Date: 2013-01-18 16:44 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/478d8354285a 8006567: jre/lib/applet missing from Mac JDK installation Reviewed-by: tbell ! makefiles/Bundles.gmk Changeset: 92d8880d5406 Author: erikj Date: 2013-01-21 11:42 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/92d8880d5406 8006583: build-infra: Remove /javax/swing/SwingBeanInfoBase.java from src.zip Reviewed-by: tbell ! makefiles/GensrcSwing.gmk Changeset: a9839ed93340 Author: erikj Date: 2013-01-21 11:42 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/a9839ed93340 Merge Changeset: 506bf3d23f06 Author: erikj Date: 2013-01-21 14:58 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/506bf3d23f06 8006579: build-infra: In jvm.cfg, alias -server to -client when no server jvm is built. Reviewed-by: tbell ! makefiles/CopyFiles.gmk Changeset: 57d5d9544628 Author: erikj Date: 2013-01-22 09:01 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/57d5d9544628 8004151: build-infra: Generating X11 wrapper offset file is not cross compilable Reviewed-by: dholmes, ohrstrom ! makefiles/GensrcX11Wrappers.gmk + src/solaris/classes/sun/awt/X11/generator/sizes.32 + src/solaris/classes/sun/awt/X11/generator/sizes.64 Changeset: ef592aceb40e Author: katleman Date: 2013-01-24 16:49 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/ef592aceb40e Added tag jdk8-b74 for changeset 57d5d9544628 ! .hgtags Changeset: 57561ea851d2 Author: lana Date: 2013-01-26 19:22 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/57561ea851d2 Merge - test/java/rmi/activation/ActivationSystem/unregisterGroup/CallbackInterface.java - test/java/rmi/activation/ActivationSystem/unregisterGroup/Callback_Stub.java - test/java/rmi/activation/ActivationSystem/unregisterGroup/UnregisterGroup_Stub.java ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java Changeset: 4faaaf5027a5 Author: alexsch Date: 2013-01-14 08:32 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/4faaaf5027a5 7166409: bug4331515.java fail with NullPointerException on ubuntu10.04-x86 for JDK8 Reviewed-by: serb ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsLookAndFeel.java Changeset: 9c6ca265b4a1 Author: alexsch Date: 2013-01-15 12:49 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/9c6ca265b4a1 8003978: closed/javax/swing/JRootPane/bug4670486.java fails since jdk7u12b01 on macosx Reviewed-by: serb, leonidr ! src/share/classes/com/sun/java/swing/plaf/gtk/GTKLookAndFeel.java ! src/share/classes/com/sun/java/swing/plaf/motif/MotifLookAndFeel.java ! src/share/classes/javax/swing/plaf/basic/BasicLookAndFeel.java ! src/share/classes/sun/swing/SwingUtilities2.java ! test/java/awt/KeyboardFocusmanager/TypeAhead/SubMenuShowTest/SubMenuShowTest.java Changeset: 1b886bd5e5bf Author: serb Date: 2013-01-15 21:57 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/1b886bd5e5bf 7124525: [macosx] No animation on certain Swing components in Aqua LaF Reviewed-by: alexsch, swingler ! src/macosx/classes/com/apple/laf/AquaPainter.java ! src/macosx/classes/com/apple/laf/ImageCache.java Changeset: 7ea1372be2fe Author: mcherkas Date: 2013-01-16 17:26 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/7ea1372be2fe 8005492: Reduce number of warnings in sun/awt/* classes Reviewed-by: art, anthony ! src/share/classes/java/awt/Button.java ! src/share/classes/java/awt/Checkbox.java ! src/share/classes/java/awt/Choice.java ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Container.java ! src/share/classes/java/awt/Dialog.java ! src/share/classes/java/awt/Frame.java ! src/share/classes/java/awt/KeyboardFocusManager.java ! src/share/classes/java/awt/Scrollbar.java ! src/share/classes/java/awt/TextArea.java ! src/share/classes/java/awt/TextComponent.java ! src/share/classes/java/awt/TextField.java ! src/share/classes/java/awt/Toolkit.java ! src/share/classes/java/awt/Window.java ! src/share/classes/sun/awt/image/SurfaceManager.java Changeset: 23f9955ae34a Author: lana Date: 2013-01-16 15:57 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/23f9955ae34a Merge Changeset: 47243a4efb8b Author: kshefov Date: 2013-01-17 15:08 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/47243a4efb8b 7124209: [macosx] SpringLayout issue. BASELINE is not in the range: [NORTH, SOUTH] Reviewed-by: serb, alexsch + test/javax/swing/SpringLayout/4726194/bug4726194.java Changeset: 035f87fc9f74 Author: anthony Date: 2013-01-18 14:17 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/035f87fc9f74 8005465: [macosx] Evaluate if checking for the -XstartOnFirstThread is still needed in awt.m Summary: Allow one to start AWT on the main thread w/o exceptions Reviewed-by: art, serb ! src/macosx/native/sun/awt/awt.m Changeset: 5309fed435b5 Author: serb Date: 2013-01-18 18:17 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/5309fed435b5 7179050: [macosx] Make LWAWT be able to run on AppKit thread Summary: Removed irrelevant assertions from the LWAWT native methods Reviewed-by: serb, anthony Contributed-by: petr.pchelko at oracle.com ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/macosx/native/sun/awt/AWTSurfaceLayers.m ! src/macosx/native/sun/awt/AWTView.m ! src/macosx/native/sun/awt/AWTWindow.m ! src/macosx/native/sun/awt/ApplicationDelegate.m ! src/macosx/native/sun/awt/CClipboard.m ! src/macosx/native/sun/awt/CCursorManager.m ! src/macosx/native/sun/awt/CDesktopPeer.m ! src/macosx/native/sun/awt/CDragSourceContextPeer.m ! src/macosx/native/sun/awt/CImage.m ! src/macosx/native/sun/awt/CInputMethod.m ! src/macosx/native/sun/awt/CMenu.m ! src/macosx/native/sun/awt/CMenuComponent.m ! src/macosx/native/sun/awt/CMenuItem.m ! src/macosx/native/sun/awt/CPopupMenu.m ! src/macosx/native/sun/awt/CTrayIcon.m ! src/macosx/native/sun/awt/CWrapper.m ! src/macosx/native/sun/awt/JavaComponentAccessibility.m ! src/macosx/native/sun/awt/LWCToolkit.m ! src/macosx/native/sun/awt/awt.m ! src/macosx/native/sun/osxapp/ThreadUtilities.h ! src/macosx/native/sun/osxapp/ThreadUtilities.m Changeset: 112c08b41ca2 Author: alitvinov Date: 2013-01-18 18:34 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/112c08b41ca2 8006417: JComboBox.showPopup(), hidePopup() fails in JRE 1.7 on OS X Reviewed-by: art, serb ! src/macosx/classes/sun/lwawt/LWToolkit.java ! src/macosx/classes/sun/lwawt/LWWindowPeer.java + test/javax/swing/JComboBox/ShowPopupAfterHidePopupTest/ShowPopupAfterHidePopupTest.java Changeset: b4131358120a Author: raginip Date: 2013-01-18 11:33 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/b4131358120a 8000839: Integrate the Java Access Bridge with Java Runtime Reviewed-by: ptbrunet, erikj ! make/Makefile + make/bridge/AccessBridgeJava/Makefile + make/bridge/JAWTAccessBridge/Files_cpp.gmk + make/bridge/JAWTAccessBridge/Makefile + make/bridge/Jabswitch/Makefile + make/bridge/Jaccess/Makefile + make/bridge/JavaAccessBridge/Files_cpp.gmk + make/bridge/JavaAccessBridge/Makefile + make/bridge/Makefile + make/bridge/WindowsAccessBridge/Files_cpp.gmk + make/bridge/WindowsAccessBridge/Makefile ! makefiles/CompileJavaClasses.gmk ! makefiles/CompileLaunchers.gmk ! makefiles/CompileNativeLibraries.gmk ! makefiles/CopyFiles.gmk ! makefiles/CreateJars.gmk ! makefiles/GensrcMisc.gmk Changeset: f55d869052dd Author: alexsch Date: 2013-01-21 17:55 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/f55d869052dd 8004298: NPE in WindowsTreeUI.ensureRowsAreVisible Reviewed-by: serb ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsTreeUI.java + test/javax/swing/JTree/8004298/bug8004298.java Changeset: dd7e1cc4253c Author: alexp Date: 2013-01-24 15:26 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/dd7e1cc4253c 7147078: [macosx] Echo char set in TextField doesn't prevent word jumping Reviewed-by: art ! src/macosx/classes/com/apple/laf/AquaKeyBindings.java ! src/macosx/classes/com/apple/laf/AquaLookAndFeel.java ! src/macosx/classes/sun/lwawt/LWTextFieldPeer.java Changeset: 04d2005fa178 Author: alexp Date: 2013-01-24 15:52 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/04d2005fa178 7132793: [macosx] setWheelScrollEnabled action reversed Reviewed-by: serb, art ! src/macosx/classes/sun/lwawt/LWComponentPeer.java ! src/macosx/classes/sun/lwawt/LWScrollPanePeer.java Changeset: 40a45a72a120 Author: serb Date: 2013-01-24 15:55 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/40a45a72a120 8005997: [macosx] Printer Dialog opens an additional title bar Reviewed-by: anthony, art Contributed-by: petr.pchelko at oracle.com ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java Changeset: fab11b21ee6e Author: kizune Date: 2013-01-24 16:09 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/fab11b21ee6e 7143768: [macosx] Unexpected NullPointerException and java.io.IOException during DnD Reviewed-by: alexp ! src/macosx/classes/sun/lwawt/macosx/CDataTransferer.java Changeset: 7dd1896b37c8 Author: malenkov Date: 2013-01-24 17:26 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/7dd1896b37c8 6817933: Setting the background of an HTML Widget changes the native Windows JFileChooser Reviewed-by: alexsch ! src/share/classes/sun/swing/WindowsPlacesBar.java + test/javax/swing/JFileChooser/6817933/Test6817933.java Changeset: f8526b99b825 Author: serb Date: 2013-01-24 17:50 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/f8526b99b825 8003173: [macosx] Fullscreen on Mac leaves an empty rectangle Reviewed-by: anthony, alexsch ! src/macosx/classes/sun/awt/CGraphicsDevice.java ! src/macosx/classes/sun/lwawt/LWWindowPeer.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformView.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java + test/java/awt/FullScreen/FullScreenInsets/FullScreenInsets.java Changeset: 32721a1a8da8 Author: malenkov Date: 2013-01-24 17:57 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/32721a1a8da8 8005138: test/java/beans/Introspector/TestTypeResolver.java fails Reviewed-by: alexsch ! test/java/beans/Introspector/TestTypeResolver.java Changeset: 7cda96a78260 Author: malenkov Date: 2013-01-24 18:06 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/7cda96a78260 8003400: JTree scrolling problem when using large model in WindowsLookAndFeel Reviewed-by: alexsch ! src/share/classes/javax/swing/plaf/basic/BasicTreeUI.java + test/javax/swing/JTree/8003400/Test8003400.java Changeset: e616c28c5120 Author: erikj Date: 2013-01-28 14:23 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/e616c28c5120 Merge - make/tools/swing-beans/beaninfo/BeanInfoUtils.java - make/tools/swing-beans/beaninfo/SwingBeanInfoBase.java ! makefiles/CompileJavaClasses.gmk ! makefiles/CompileLaunchers.gmk ! makefiles/CompileNativeLibraries.gmk ! makefiles/CopyFiles.gmk ! makefiles/CreateJars.gmk - src/share/demo/jfc/CodePointIM/CodePointInputMethod.java - src/share/demo/jfc/CodePointIM/CodePointInputMethodDescriptor.java Changeset: a1a55db02f34 Author: lana Date: 2013-01-29 20:19 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/a1a55db02f34 Merge ! makefiles/CreateJars.gmk Changeset: 9d5c43050210 Author: dl Date: 2013-01-11 16:50 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/9d5c43050210 8006123: Support @Contended Annotation - JEP 142 (jdk part) Summary: jdk changes for 8003895. Reviewed-by: darcy, jrose, coleenp, dholmes, kvn Contributed-by: Aleksey Shipilev + src/share/classes/sun/misc/Contended.java Changeset: 739351a0a7a1 Author: kvn Date: 2013-01-23 11:47 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/739351a0a7a1 8006799: Optimize sun.nio.cs.ISO_8859_1$Encode.encodeArrayLoop() (jdk part of 6896617) Summary: Move hot loop in ISO_8859_1$Encode.encodeArrayLoop() into separate method encodeISOArray() to be replaced by JVM JIT compiler with optimized intrinsic code. Reviewed-by: alanb, sherman ! src/share/classes/sun/nio/cs/ISO_8859_1.java Changeset: e9d00d30fcca Author: amurillo Date: 2013-01-25 03:02 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/e9d00d30fcca Merge Changeset: ac286bf65242 Author: amurillo Date: 2013-01-30 10:18 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/ac286bf65242 Merge - test/java/rmi/activation/ActivationSystem/unregisterGroup/CallbackInterface.java - test/java/rmi/activation/ActivationSystem/unregisterGroup/Callback_Stub.java - test/java/rmi/activation/ActivationSystem/unregisterGroup/UnregisterGroup_Stub.java Changeset: 3c499051a5df Author: erikj Date: 2013-01-29 16:35 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/3c499051a5df 8006873: SWAT-b74 msvcr100.dll does not have the permission for all Reviewed-by: alanb, tbell ! makefiles/CopyFiles.gmk Changeset: 4a67fdb752b7 Author: katleman Date: 2013-01-30 13:04 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/4a67fdb752b7 Merge ! makefiles/CopyFiles.gmk Changeset: 771551bc9e02 Author: lana Date: 2013-01-31 10:22 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/771551bc9e02 Merge Changeset: e822b4d50a5b Author: lana Date: 2013-01-31 14:10 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/e822b4d50a5b Merge - src/share/classes/java/lang/annotation/ContainedBy.java - src/share/classes/java/lang/annotation/ContainerFor.java Changeset: a09a37cff333 Author: mchung Date: 2013-01-31 14:29 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/a09a37cff333 6355704: (fmt) %f formatting of BigDecimals is incorrect Reviewed-by: darcy Contributed-by: brian.burkhalter at oracle.com ! test/java/util/Formatter/Basic-X.java.template ! test/java/util/Formatter/BasicBigDecimal.java Changeset: d2495b9984fa Author: weijun Date: 2013-02-01 07:39 +0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/d2495b9984fa 8006564: Test sun/security/util/Oid/S11N.sh fails with timeout on Linux 32-bit Reviewed-by: alanb + test/sun/security/util/Oid/S11N.java - test/sun/security/util/Oid/S11N.sh - test/sun/security/util/Oid/SerialTest.java Changeset: 17b643956999 Author: chegar Date: 2013-02-01 06:51 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/17b643956999 8006395: Race in async socket close on Linux Reviewed-by: alanb, dsamersoff ! src/solaris/native/java/net/linux_close.c + test/java/net/Socket/asyncClose/Race.java Changeset: ea8f3ca83501 Author: ksrini Date: 2013-02-01 07:25 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/ea8f3ca83501 8006536: [launcher] removes trailing slashes on arguments Reviewed-by: ksrini, akhil Contributed-by: jviswana at linux.vnet.ibm.com ! src/windows/bin/cmdtoargs.c ! test/tools/launcher/Arrrghs.java Changeset: 5e47ee4d7196 Author: alanb Date: 2013-02-01 21:01 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/5e47ee4d7196 5035569: Formatter should document that %a conversion unsupported for BigDecimal args Reviewed-by: darcy Contributed-by: brian.burkhalter at oracle.com ! src/share/classes/java/util/Formatter.java Changeset: cba578db5f39 Author: darcy Date: 2013-02-01 19:30 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/cba578db5f39 6964528: Double.toHexString(double d) String manipulation with + in an append of StringBuilder Reviewed-by: shade ! src/share/classes/java/lang/Double.java Changeset: c1aaa8451547 Author: ksrini Date: 2013-02-01 22:12 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/c1aaa8451547 8003549: (pack200) assertion errors when processing lambda class files with IMethods Summary: add more check for opcode, sketch provided by jrose Reviewed-by: jrose ! src/share/classes/com/sun/java/util/jar/pack/Attribute.java ! src/share/classes/com/sun/java/util/jar/pack/ClassReader.java ! src/share/classes/com/sun/java/util/jar/pack/ConstantPool.java ! src/share/classes/com/sun/java/util/jar/pack/Instruction.java ! src/share/classes/com/sun/java/util/jar/pack/PackageWriter.java ! src/share/classes/com/sun/java/util/jar/pack/PackerImpl.java ! src/share/classes/com/sun/java/util/jar/pack/PropMap.java ! src/share/classes/com/sun/java/util/jar/pack/Utils.java ! test/ProblemList.txt + test/tools/pack200/InstructionTests.java ! test/tools/pack200/pack200-verifier/src/xmlkit/ClassReader.java Changeset: 6c88a12ea834 Author: ksrini Date: 2013-02-01 22:18 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/6c88a12ea834 8007428: [launcher] add tools/launcher/FXLauncherTest.java to ProblemList.txt Reviewed-by: mchung ! test/ProblemList.txt Changeset: ee83319029a5 Author: chegar Date: 2013-02-02 17:15 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/ee83319029a5 8007322: untangle ftp protocol from general networking URL tests Reviewed-by: alanb ! test/java/net/URL/Constructor.java ! test/java/net/URL/HandlerLoop.java ! test/java/net/URL/Test.java ! test/java/net/URL/URIToURLTest.java - test/java/net/URL/abnormal_http_urls - test/java/net/URL/ftp_urls - test/java/net/URL/jar_urls - test/java/net/URL/normal_http_urls - test/java/net/URL/runconstructor.sh - test/java/net/URL/share_file_urls - test/java/net/URL/win32_file_urls ! test/java/net/URLConnection/RequestProperties.java ! test/java/net/URLConnection/RequestPropertyValues.java + test/sun/net/ftp/EncDec.doc + test/sun/net/ftp/MarkResetTest.java + test/sun/net/ftp/MarkResetTest.sh - test/sun/net/www/EncDec.doc - test/sun/net/www/MarkResetTest.java - test/sun/net/www/MarkResetTest.sh ! test/sun/net/www/http/HttpClient/ProxyTest.java Changeset: 25831e7009c4 Author: ksrini Date: 2013-02-02 12:08 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/25831e7009c4 8007135: tools/launcher/VersionCheck.java failing with new tool jabswitch Reviewed-by: ksrini, mduigou Contributed-by: ragini.prasad at oracle.com ! test/tools/launcher/VersionCheck.java Changeset: 308d1362b60a Author: dmeetry Date: 2013-02-03 18:20 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/308d1362b60a 6471906: java.lang.NegativeArraySizeException in tenToThe Reviewed-by: darcy Contributed-by: brian.burkhalter at oracle.com ! src/share/classes/java/math/BigDecimal.java Changeset: 962d6612cace Author: dsamersoff Date: 2013-02-03 21:39 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/962d6612cace 8002048: Protocol to discovery of manageable Java processes on a network Summary: Introduce a protocol to discover manageble Java instances across a network subnet, JDP Reviewed-by: sla, dfuchs ! src/share/classes/sun/management/Agent.java + src/share/classes/sun/management/jdp/JdpBroadcaster.java + src/share/classes/sun/management/jdp/JdpController.java + src/share/classes/sun/management/jdp/JdpException.java + src/share/classes/sun/management/jdp/JdpGenericPacket.java + src/share/classes/sun/management/jdp/JdpJmxPacket.java + src/share/classes/sun/management/jdp/JdpPacket.java + src/share/classes/sun/management/jdp/JdpPacketReader.java + src/share/classes/sun/management/jdp/JdpPacketWriter.java + src/share/classes/sun/management/jdp/package-info.java + test/sun/management/jdp/JdpClient.java + test/sun/management/jdp/JdpDoSomething.java + test/sun/management/jdp/JdpTest.sh + test/sun/management/jdp/JdpUnitTest.java Changeset: 5bf1c9e6be60 Author: vinnie Date: 2013-02-04 17:20 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/5bf1c9e6be60 8006994: Cleanup PKCS12 tests to ensure streams get closed Reviewed-by: mullan ! test/java/security/KeyStore/PBETest.java ! test/sun/security/pkcs12/StorePasswordTest.java ! test/sun/security/pkcs12/StoreSecretKeyTest.java ! test/sun/security/pkcs12/StoreTrustedCertTest.java Changeset: e202f43a8b8a Author: sherman Date: 2013-02-04 11:58 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/e202f43a8b8a 8006295: Base64.Decoder.wrap(java.io.InputStream) returns InputStream which throws unspecified IOException on attempt to decode invalid Base64 byte stream 8006315: Base64.Decoder decoding methods are not consistent in treating non-padded data 8006530: Base64.getMimeDecoder().decode() throws exception for non-base64 character after adding = Summary: updated the spec to describe the expected behave explicitly and the implementation to follow Reviewed-by: alanb, chegar, lancea ! src/share/classes/java/util/Base64.java ! test/java/util/Base64/TestBase64.java Changeset: 41654275896d Author: jlaskey Date: 2013-02-04 17:29 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/41654275896d Merge ! makefiles/CompileLaunchers.gmk ! makefiles/CreateJars.gmk - src/share/classes/java/lang/annotation/ContainedBy.java - src/share/classes/java/lang/annotation/ContainerFor.java - test/java/net/URL/abnormal_http_urls - test/java/net/URL/ftp_urls - test/java/net/URL/jar_urls - test/java/net/URL/normal_http_urls - test/java/net/URL/runconstructor.sh - test/java/net/URL/share_file_urls - test/java/net/URL/win32_file_urls - test/sun/net/www/EncDec.doc - test/sun/net/www/MarkResetTest.java - test/sun/net/www/MarkResetTest.sh - test/sun/security/util/Oid/S11N.sh - test/sun/security/util/Oid/SerialTest.java ! test/tools/launcher/VersionCheck.java From sundararajan.athijegannathan at oracle.com Mon Feb 4 19:36:36 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Tue, 05 Feb 2013 09:06:36 +0530 Subject: Review request JDK-8007452: add scripting programmers doc changes for nashorn In-Reply-To: <510FC9FB.90303@oracle.com> References: <510F9F02.8020702@oracle.com> <510FC9FB.90303@oracle.com> Message-ID: <51107E44.5000204@oracle.com> Hi, Incorporated these changes and uploaded updated webrev for historical purpose. http://cr.openjdk.java.net/~sundar/8007452/webrev.01/ Thanks -Sundar On Monday 04 February 2013 08:17 PM, Hannes Wallnoefer wrote: > Nice docs and examples! A few notes below. > > - There's a bit of overlap between the treatment of abstract classes > in "Accessing Java Classes" and the "Implementing Java Interfaces" > section further down. These concepts are very similar, maybe they > should be treated together (or next to each other)? > > - These two sentences seem redundant: "Multiple scopes are supported > by |javax.script.ScriptContext| interface. A script context supports > one or more scopes with associated Bindings for each scope." Maybe > combine to something like "The |javax.script.ScriptContext| interface > supports multiple scopes with associated Bindings for each scope." > > - I think the following comment (contained twice) should have an "it" > near the end ("implements it or not"): > | //|javax.script.Invocable| is an optional interface. > // Check whether your script engine implements or not!| > > Hannes > > > Am 2013-02-04 12:44, schrieb A. Sundararajan: >> Please review http://cr.openjdk.java.net/~sundar/8007452/ >> >> Thanks >> -Sundar > From sundararajan.athijegannathan at oracle.com Mon Feb 4 19:41:13 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Tue, 05 Feb 2013 03:41:13 +0000 Subject: hg: nashorn/jdk8/nashorn: 8007452: add scripting programmers doc changes for nashorn Message-ID: <20130205034114.5CD8E47816@hg.openjdk.java.net> Changeset: 5c2ed5d89524 Author: sundar Date: 2013-02-05 09:11 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/5c2ed5d89524 8007452: add scripting programmers doc changes for nashorn Reviewed-by: jlaskey, hannesw + docs/JavaScriptingProgrammersGuide.html + docs/source/EvalFile.java + docs/source/EvalScript.java + docs/source/InvokeScriptFunction.java + docs/source/InvokeScriptMethod.java + docs/source/MultiScopes.java + docs/source/RunnableImpl.java + docs/source/RunnableImplObject.java + docs/source/ScriptVars.java + docs/source/importpackageclass.js + docs/source/javaarray.js + docs/source/javaextend.js + docs/source/javaimporter.js + docs/source/javatypes.js + docs/source/overload.js + docs/source/runnable.js + docs/source/samfunc.js + docs/source/test.js ! src/jdk/nashorn/internal/objects/NativeJava.java From rieberandreas at gmail.com Tue Feb 5 00:52:48 2013 From: rieberandreas at gmail.com (Andreas Rieber) Date: Tue, 05 Feb 2013 09:52:48 +0100 Subject: 8006191 test failed Message-ID: <5110C860.2000201@gmail.com> Hi, i just tried to compile Nashorn for some more JSR-223 related test but the build failed: [testng] Test test/script/basic/JDK-8006191.js failed at line 11 - [testng] expected: 'ls: illegal option -- Q' [testng] found: '' Looked up the test and my ls, hm that has the -Q parameter: -Q, --quote-name enclose entry names in double quotes i am using ubuntu 12.04. invalid options there are: e,j,w,y,z,E,I,J,K,M,O,P,T,V,W,Y - Andreas From sundararajan.athijegannathan at oracle.com Tue Feb 5 05:16:00 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Tue, 05 Feb 2013 13:16:00 +0000 Subject: hg: nashorn/jdk8/nashorn: 8007521: $ENV should be undefined when security manager is present Message-ID: <20130205131602.0F13747837@hg.openjdk.java.net> Changeset: c48e8a28da90 Author: sundar Date: 2013-02-05 18:44 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/c48e8a28da90 8007521: $ENV should be undefined when security manager is present Reviewed-by: hannesw, jlaskey ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/runtime/ScriptingFunctions.java - test/script/basic/JDK-8006191.js - test/script/basic/JDK-8006191.js.EXPECTED + test/script/currently-failing/JDK-8006191.js + test/script/currently-failing/JDK-8006191.js.EXPECTED + test/script/sandbox/env.js + test/script/sandbox/exec.js From sundararajan.athijegannathan at oracle.com Tue Feb 5 06:46:09 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Tue, 05 Feb 2013 20:16:09 +0530 Subject: Review request JDK-8007522: IllegalStateException thrown from String.prototype.search function Message-ID: <51111B31.5060604@oracle.com> Please review http://cr.openjdk.java.net/~sundar/8007522/ Thanks -Sundar From james.laskey at oracle.com Tue Feb 5 06:59:47 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Tue, 5 Feb 2013 10:59:47 -0400 Subject: Review request JDK-8007522: IllegalStateException thrown from String.prototype.search function In-Reply-To: <51111B31.5060604@oracle.com> References: <51111B31.5060604@oracle.com> Message-ID: <4E0561B6-E46A-4E95-BFE0-7F1DD9234FFC@oracle.com> +1 On 2013-02-05, at 10:46 AM, "A. Sundararajan" wrote: > Please review http://cr.openjdk.java.net/~sundar/8007522/ > > Thanks > -Sundar From sundararajan.athijegannathan at oracle.com Tue Feb 5 07:30:33 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Tue, 05 Feb 2013 15:30:33 +0000 Subject: hg: nashorn/jdk8/nashorn: 8007522: IllegalStateException thrown from String.prototype.search function Message-ID: <20130205153034.BC68D4783B@hg.openjdk.java.net> Changeset: 819b5485949d Author: sundar Date: 2013-02-05 21:00 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/819b5485949d 8007522: IllegalStateException thrown from String.prototype.search function Reviewed-by: jlaskey ! src/jdk/nashorn/internal/objects/NativeRegExp.java + test/script/basic/JDK-8007522.js From hannes.wallnoefer at oracle.com Tue Feb 5 08:13:13 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Tue, 05 Feb 2013 17:13:13 +0100 Subject: Review request JDK-8007522: IllegalStateException thrown from String.prototype.search function In-Reply-To: <51111B31.5060604@oracle.com> References: <51111B31.5060604@oracle.com> Message-ID: <51112F99.2090309@oracle.com> +1 Am 2013-02-05 15:46, schrieb A. Sundararajan: > Please review http://cr.openjdk.java.net/~sundar/8007522/ > > Thanks > -Sundar From sundararajan.athijegannathan at oracle.com Tue Feb 5 08:29:12 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Tue, 05 Feb 2013 21:59:12 +0530 Subject: Review request JDK-8007523: VerifyError on script that uses regular expression literals with ternary operator Message-ID: <51113358.9010600@oracle.com> Please review http://cr.openjdk.java.net/~sundar/8007523/ Thanks -Sundar From sundararajan.athijegannathan at oracle.com Tue Feb 5 08:37:22 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Tue, 05 Feb 2013 16:37:22 +0000 Subject: hg: nashorn/jdk8/nashorn: 8007523: VerifyError on script that uses regular expression literals with ternary operator Message-ID: <20130205163724.4D0774783E@hg.openjdk.java.net> Changeset: f05d4dae30f7 Author: sundar Date: 2013-02-05 22:07 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/f05d4dae30f7 8007523: VerifyError on script that uses regular expression literals with ternary operator Reviewed-by: lagergren ! src/jdk/nashorn/internal/ir/LiteralNode.java ! test/script/basic/JDK-8007522.js + test/script/basic/JDK-8007523.js From james.laskey at oracle.com Tue Feb 5 10:29:52 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Tue, 5 Feb 2013 14:29:52 -0400 Subject: Review request 8007545 - jjs input evalinput need to be NOT_ENUMERABLE Message-ID: Please review http://cr.openjdk.java.net/~jlaskey/8007545/webrev.00/index.html Cheers, -- Jim From sundararajan.athijegannathan at oracle.com Tue Feb 5 19:12:40 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Wed, 06 Feb 2013 08:42:40 +0530 Subject: Review request 8007545 - jjs input evalinput need to be NOT_ENUMERABLE In-Reply-To: References: Message-ID: <5111CA28.1070204@oracle.com> You may want to set writable: true and configurable: true for those properties. Default for these properties is false - unless you want these properties to be non-writable, non-configurable (why?), you've to set these properties to true. Other than that, looks good to me. -Sundar On Tuesday 05 February 2013 11:59 PM, Jim Laskey (Oracle) wrote: > Please review http://cr.openjdk.java.net/~jlaskey/8007545/webrev.00/index.html > > Cheers, > > -- Jim > From sundararajan.athijegannathan at oracle.com Wed Feb 6 00:06:50 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Wed, 06 Feb 2013 13:36:50 +0530 Subject: Review request JDK-8007619: Add support for deprecated properties of RegExp constructor Message-ID: <51120F1A.4030208@oracle.com> Please review http://cr.openjdk.java.net/~sundar/8007619/ Thanks, -Sundar From marcus.lagergren at oracle.com Wed Feb 6 00:41:05 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Wed, 6 Feb 2013 09:41:05 +0100 Subject: Review request 8007545 - jjs input evalinput need to be NOT_ENUMERABLE In-Reply-To: References: Message-ID: <0B234FAA-CF72-4EE7-B8C1-251E415B6113@oracle.com> +1 On Feb 5, 2013, at 7:29 PM, Jim Laskey (Oracle) wrote: > Please review http://cr.openjdk.java.net/~jlaskey/8007545/webrev.00/index.html > > Cheers, > > -- Jim > From marcus.lagergren at oracle.com Wed Feb 6 00:41:19 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Wed, 6 Feb 2013 09:41:19 +0100 Subject: Review request JDK-8007523: VerifyError on script that uses regular expression literals with ternary operator In-Reply-To: <51113358.9010600@oracle.com> References: <51113358.9010600@oracle.com> Message-ID: <13EC8B4C-1DBE-4F2A-97D9-C199C7918F31@oracle.com> +1 On Feb 5, 2013, at 5:29 PM, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~sundar/8007523/ > > Thanks > -Sundar From hannes.wallnoefer at oracle.com Wed Feb 6 00:55:24 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Wed, 06 Feb 2013 09:55:24 +0100 Subject: Review request for JDK-8007273 In-Reply-To: <86DFAD5C-0ED5-48D3-A6E8-C22C415228C8@oracle.com> References: <510F7BE4.5040705@oracle.com> <86DFAD5C-0ED5-48D3-A6E8-C22C415228C8@oracle.com> Message-ID: <51121A7C.7050007@oracle.com> I followed Attila's suggestion to actually keep data in ScriptFunctionData for all functions. While the change is more involved than with the previous patch I think it's worth it: Field count in ScriptFunction is greatly reduced, constructors got even simpler, and ScriptFunction class as a whole got smaller and simpler since much of its static initalization code moved to ScriptFunctionData. New patch is at http://cr.openjdk.java.net/~hannesw/8007273/webrev.01/ Hannes Am 2013-02-04 11:11, schrieb Marcus Lagergren: > +1. > > This is great. It made stuff simpler. > > Can you reconfirm the performance numbers (I understand you are doing that anyway). Won't most of the improvement be because of reuse of ScriptFunctionData at Function creation sites rather than lack of method handle adaptation. I like that we are as lazy as possible with modifying method handles too though, we've learnt that it does indeed matter. > > This should play nicely with my call site type specialization work. > > Attila brought up the the issue of deconstructing the ScriptFunctionData into fields in the ScriptFunction again, but I don't have any strong opinions about it. Deconstructing it may be unnecessary, but it buys some readability and not all constructors have access to ScriptFunctionData I guess. > > /M > > On Feb 4, 2013, at 10:14 AM, Hannes Wallnoefer wrote: > >> Please review webrev for JDK-8007273 (Creation of ScriptFunctions can be refactored): >> >> http://cr.openjdk.java.net/~hannesw/8007273/ >> >> This introduces a ScriptFunctionData class that stores everything needed to instantiate functions and is stored in a script class's constants array. >> >> It also adds a dedicated ScriptFunction constructors for functions from compiled code as opposed to other types of functions such as built-ins. This makes code simpler since different types of functions have different properties (e.g. built-ins don't have source or token, compiled functions don't have to compute arity from signature...). >> >> I also tried various forms of optimization and found the one thing that helps is to not adapt method handle signatures into something that can be used by used by ScriptFunction.invoke()/.construct() (which mainly means boxing the return value to Object) right away in the constructor. Instead the method handle is now left unchanged in ScriptFunction and only adapted lazily for invoke()/construct(). This seems to improve performance in earley-boyer and gbemu by something like 10-20%. >> >> Hannes From attila.szegedi at oracle.com Wed Feb 6 01:13:09 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Wed, 6 Feb 2013 10:13:09 +0100 Subject: Review request for JDK-8007273 In-Reply-To: <51121A7C.7050007@oracle.com> References: <510F7BE4.5040705@oracle.com> <86DFAD5C-0ED5-48D3-A6E8-C22C415228C8@oracle.com> <51121A7C.7050007@oracle.com> Message-ID: <7BB2F16A-98D3-47B6-96F7-868ADDB4AC81@oracle.com> +1 - this resulted in an amazingly nice design. ScriptFunction is now as it should be - a triple of (prototype, scope, immutable data shared across instances). On Feb 6, 2013, at 9:55 AM, Hannes Wallnoefer wrote: > I followed Attila's suggestion to actually keep data in ScriptFunctionData for all functions. While the change is more involved than with the previous patch I think it's worth it: Field count in ScriptFunction is greatly reduced, constructors got even simpler, and ScriptFunction class as a whole got smaller and simpler since much of its static initalization code moved to ScriptFunctionData. > > New patch is at http://cr.openjdk.java.net/~hannesw/8007273/webrev.01/ > > Hannes > > Am 2013-02-04 11:11, schrieb Marcus Lagergren: >> +1. >> >> This is great. It made stuff simpler. >> >> Can you reconfirm the performance numbers (I understand you are doing that anyway). Won't most of the improvement be because of reuse of ScriptFunctionData at Function creation sites rather than lack of method handle adaptation. I like that we are as lazy as possible with modifying method handles too though, we've learnt that it does indeed matter. >> >> This should play nicely with my call site type specialization work. >> >> Attila brought up the the issue of deconstructing the ScriptFunctionData into fields in the ScriptFunction again, but I don't have any strong opinions about it. Deconstructing it may be unnecessary, but it buys some readability and not all constructors have access to ScriptFunctionData I guess. >> >> /M >> >> On Feb 4, 2013, at 10:14 AM, Hannes Wallnoefer wrote: >> >>> Please review webrev for JDK-8007273 (Creation of ScriptFunctions can be refactored): >>> >>> http://cr.openjdk.java.net/~hannesw/8007273/ >>> >>> This introduces a ScriptFunctionData class that stores everything needed to instantiate functions and is stored in a script class's constants array. >>> >>> It also adds a dedicated ScriptFunction constructors for functions from compiled code as opposed to other types of functions such as built-ins. This makes code simpler since different types of functions have different properties (e.g. built-ins don't have source or token, compiled functions don't have to compute arity from signature...). >>> >>> I also tried various forms of optimization and found the one thing that helps is to not adapt method handle signatures into something that can be used by used by ScriptFunction.invoke()/.construct() (which mainly means boxing the return value to Object) right away in the constructor. Instead the method handle is now left unchanged in ScriptFunction and only adapted lazily for invoke()/construct(). This seems to improve performance in earley-boyer and gbemu by something like 10-20%. >>> >>> Hannes > From hannes.wallnoefer at oracle.com Wed Feb 6 01:32:35 2013 From: hannes.wallnoefer at oracle.com (hannes.wallnoefer at oracle.com) Date: Wed, 06 Feb 2013 09:32:35 +0000 Subject: hg: nashorn/jdk8/nashorn: 8007273: Creation of ScriptFunctions can be refactored Message-ID: <20130206093236.8C5D84787E@hg.openjdk.java.net> Changeset: f6fae6de6f4f Author: hannesw Date: 2013-02-06 10:31 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/f6fae6de6f4f 8007273: Creation of ScriptFunctions can be refactored Reviewed-by: lagergren, attila ! src/jdk/nashorn/internal/codegen/objects/FunctionObjectCreator.java ! src/jdk/nashorn/internal/codegen/objects/ObjectCreator.java ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java ! src/jdk/nashorn/internal/runtime/PropertyMap.java ! src/jdk/nashorn/internal/runtime/ScriptFunction.java + src/jdk/nashorn/internal/runtime/ScriptFunctionData.java From hannes.wallnoefer at oracle.com Wed Feb 6 02:43:57 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Wed, 06 Feb 2013 11:43:57 +0100 Subject: Review request JDK-8007619: Add support for deprecated properties of RegExp constructor In-Reply-To: <51120F1A.4030208@oracle.com> References: <51120F1A.4030208@oracle.com> Message-ID: <511233ED.6020006@oracle.com> To be honest this looks a bit hacky to me. The properties on the constructor are configurable and writable (since they are technically not defined), and the __last_regexp_match__ property leaks out to the script. I think ideally we should support getters on the constructor (which I think we currently do not): @Getter(where = Where.CONSTRUCTOR) public static Object lastMatch(Object self) { ... } And maybe we could think of a way to let the getter know what to return without using a public property on the constructor? Hannes Am 2013-02-06 09:06, schrieb A. Sundararajan: > Please review http://cr.openjdk.java.net/~sundar/8007619/ > > Thanks, > -Sundar From james.laskey at oracle.com Wed Feb 6 02:48:03 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Wed, 6 Feb 2013 06:48:03 -0400 Subject: Review request 8007545 - jjs input evalinput need to be NOT_ENUMERABLE In-Reply-To: <5111CA28.1070204@oracle.com> References: <5111CA28.1070204@oracle.com> Message-ID: K Sent from my iPhone 4 On 2013-02-05, at 11:12 PM, "A. Sundararajan" wrote: > You may want to set writable: true and configurable: true for those properties. Default for these properties is false - unless you want these properties to be non-writable, non-configurable (why?), you've to set these properties to true. > > Other than that, looks good to me. > > -Sundar > > On Tuesday 05 February 2013 11:59 PM, Jim Laskey (Oracle) wrote: >> Please review http://cr.openjdk.java.net/~jlaskey/8007545/webrev.00/index.html >> >> Cheers, >> >> -- Jim > From sundararajan.athijegannathan at oracle.com Wed Feb 6 02:50:42 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Wed, 06 Feb 2013 16:20:42 +0530 Subject: Review request JDK-8007619: Add support for deprecated properties of RegExp constructor In-Reply-To: <511233ED.6020006@oracle.com> References: <51120F1A.4030208@oracle.com> <511233ED.6020006@oracle.com> Message-ID: <51123582.5020707@oracle.com> $1-$9 properties change b/w invocations. For eg. $5 may not exist after an exec call - if there are only 4 matches. Also, adding as properties implies fixed cost - you pay regardless of using those deprecated properties or not - i.e., propertyMap gets added entries. With __noSuchProperty__ hook, this is called only when user really uses it. On avoiding another "internal" property: we may expect constructor to be of specific type and use package private field or something -- but then we can't access NativeRegExp$Constructor at compile time as it is generated by nasgen :-( -Sundar On Wednesday 06 February 2013 04:13 PM, Hannes Wallnoefer wrote: > To be honest this looks a bit hacky to me. The properties on the > constructor are configurable and writable (since they are technically > not defined), and the __last_regexp_match__ property leaks out to the > script. > > I think ideally we should support getters on the constructor (which I > think we currently do not): > > @Getter(where = Where.CONSTRUCTOR) > public static Object lastMatch(Object self) { > ... > } > > And maybe we could think of a way to let the getter know what to > return without using a public property on the constructor? > > Hannes > > Am 2013-02-06 09:06, schrieb A. Sundararajan: >> Please review http://cr.openjdk.java.net/~sundar/8007619/ >> >> Thanks, >> -Sundar > From sundararajan.athijegannathan at oracle.com Wed Feb 6 04:26:42 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Wed, 06 Feb 2013 12:26:42 +0000 Subject: hg: nashorn/jdk8/nashorn: 8007619: Add support for deprecated properties of RegExp constructor Message-ID: <20130206122643.48EE247881@hg.openjdk.java.net> Changeset: fcf541418304 Author: sundar Date: 2013-02-06 17:56 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/fcf541418304 8007619: Add support for deprecated properties of RegExp constructor Reviewed-by: lagergren, hannesw ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/objects/NativeRegExp.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java + test/script/basic/JDK-8007619.js + test/script/basic/JDK-8007619.js.EXPECTED From hannes.wallnoefer at oracle.com Wed Feb 6 04:29:16 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Wed, 06 Feb 2013 13:29:16 +0100 Subject: Review request JDK-8007619: Add support for deprecated properties of RegExp constructor In-Reply-To: <51123582.5020707@oracle.com> References: <51120F1A.4030208@oracle.com> <511233ED.6020006@oracle.com> <51123582.5020707@oracle.com> Message-ID: <51124C9C.90909@oracle.com> After talking to Sundar some more we agreed that this patch is fine until the issues with nasgen for supporting actual properties are solved. I've filed a bug for that: https://jbs.oracle.com/bugs/browse/JDK-8007627 Hannes Am 2013-02-06 11:50, schrieb A. Sundararajan: > $1-$9 properties change b/w invocations. For eg. $5 may not exist > after an exec call - if there are only 4 matches. > > Also, adding as properties implies fixed cost - you pay regardless of > using those deprecated properties or not - i.e., propertyMap gets > added entries. With __noSuchProperty__ hook, this is called only when > user really uses it. > > On avoiding another "internal" property: we may expect constructor to > be of specific type and use package private field or something -- but > then we can't access NativeRegExp$Constructor at compile time as it is > generated by nasgen :-( > > -Sundar > > On Wednesday 06 February 2013 04:13 PM, Hannes Wallnoefer wrote: >> To be honest this looks a bit hacky to me. The properties on the >> constructor are configurable and writable (since they are technically >> not defined), and the __last_regexp_match__ property leaks out to the >> script. >> >> I think ideally we should support getters on the constructor (which I >> think we currently do not): >> >> @Getter(where = Where.CONSTRUCTOR) >> public static Object lastMatch(Object self) { >> ... >> } >> >> And maybe we could think of a way to let the getter know what to >> return without using a public property on the constructor? >> >> Hannes >> >> Am 2013-02-06 09:06, schrieb A. Sundararajan: >>> Please review http://cr.openjdk.java.net/~sundar/8007619/ >>> >>> Thanks, >>> -Sundar >> > From james.laskey at oracle.com Wed Feb 6 04:42:43 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Wed, 06 Feb 2013 12:42:43 +0000 Subject: hg: nashorn/jdk8/nashorn: 8007545: jjs input evalinput need to be NOT_ENUMERABLE Message-ID: <20130206124244.D822747883@hg.openjdk.java.net> Changeset: ec4d59c9b8d2 Author: jlaskey Date: 2013-02-06 08:42 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/ec4d59c9b8d2 8007545: jjs input evalinput need to be NOT_ENUMERABLE Reviewed-by: sundar, lagergren Contributed-by: james.laskey at oracle.com ! src/jdk/nashorn/tools/resources/shell.js From james.laskey at oracle.com Wed Feb 6 05:41:47 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Wed, 6 Feb 2013 09:41:47 -0400 Subject: Review request JDK-8007629 Remove extraneous quit from shell.js Message-ID: <22CF9945-B2D7-48A8-B49E-B55223AA387B@oracle.com> Please review http://cr.openjdk.java.net/~jlaskey/8007629/webrev.00/index.html This solidifies quit and exit has always being available. quit is an alias for exit. Both accept an exit code. The assumption is that quit() will primarily be used for interactive sessions and that exit(0) will be used for shell scripting. Tests will follow with a more comprehensive shell scripting test bed. From james.laskey at oracle.com Wed Feb 6 05:44:03 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Wed, 6 Feb 2013 09:44:03 -0400 Subject: Review request JDK-8007629 Remove extraneous quit from shell.js Message-ID: <9F5D00F0-AA4E-4BA8-8BD4-3499C67A7C73@oracle.com> Please review http://cr.openjdk.java.net/~jlaskey/8007629/webrev.00/index.html This solidifies quit and exit has always being available. quit is an alias for exit. Both accept an exit code. The assumption is that quit() will primarily be used for interactive sessions and that exit(0) will be used for shell scripting. Tests will follow with a more comprehensive shell scripting test bed. From hannes.wallnoefer at oracle.com Wed Feb 6 07:59:28 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Wed, 06 Feb 2013 16:59:28 +0100 Subject: Review request JDK-8007629 Remove extraneous quit from shell.js In-Reply-To: <9F5D00F0-AA4E-4BA8-8BD4-3499C67A7C73@oracle.com> References: <9F5D00F0-AA4E-4BA8-8BD4-3499C67A7C73@oracle.com> Message-ID: <51127DE0.2020905@oracle.com> I have some reservations against adding globals to the core language itself (versus adding them just to the shell), but since we're already doing this now with things like load() and print() I guess it should be discussed independently. Otherwise looks good to me. Hannes Am 2013-02-06 14:44, schrieb Jim Laskey (Oracle): > Please review http://cr.openjdk.java.net/~jlaskey/8007629/webrev.00/index.html > > This solidifies quit and exit has always being available. quit is an alias for exit. Both accept an exit code. The assumption is that quit() will primarily be used for interactive sessions and that exit(0) will be used for shell scripting. > > Tests will follow with a more comprehensive shell scripting test bed. > > From james.laskey at oracle.com Wed Feb 6 07:58:09 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Wed, 06 Feb 2013 15:58:09 +0000 Subject: hg: nashorn/jdk8/nashorn: 8007629: Remove extraneous quit from shell.js Message-ID: <20130206155810.209AF4788B@hg.openjdk.java.net> Changeset: 2ca25bf25d0c Author: jlaskey Date: 2013-02-06 11:57 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/2ca25bf25d0c 8007629: Remove extraneous quit from shell.js Reviewed-by: sundar, hannesw Contributed-by: james.laskey at oracle.com ! src/jdk/nashorn/api/scripting/resources/init.js ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/runtime/ScriptingFunctions.java ! src/jdk/nashorn/tools/resources/shell.js From james.laskey at oracle.com Wed Feb 6 08:34:34 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Wed, 6 Feb 2013 12:34:34 -0400 Subject: Review request 8007643 - Add testing for quit and exit Message-ID: <452B2DDA-3394-4410-B4FE-E56E4B788299@oracle.com> Please review http://cr.openjdk.java.net/~jlaskey/8007643/webrev.00/index.html From james.laskey at oracle.com Wed Feb 6 08:51:25 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Wed, 06 Feb 2013 16:51:25 +0000 Subject: hg: nashorn/jdk8/nashorn: 8007643: Add testing for quit and exit Message-ID: <20130206165126.370024788F@hg.openjdk.java.net> Changeset: 02f810c26ff9 Author: jlaskey Date: 2013-02-06 12:51 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/02f810c26ff9 8007643: Add testing for quit and exit Reviewed-by: sundar Contributed-by: james.laskey at oracle.com ! test/script/sandbox/exit.js ! test/script/sandbox/exit.js.EXPECTED From james.laskey at oracle.com Wed Feb 6 09:37:59 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Wed, 06 Feb 2013 17:37:59 +0000 Subject: hg: nashorn/jdk8: 8007666: nashorn missing from hgforest.sh Message-ID: <20130206173759.74A8E47892@hg.openjdk.java.net> Changeset: 9ed388a04fa7 Author: jlaskey Date: 2013-02-06 13:37 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/9ed388a04fa7 8007666: nashorn missing from hgforest.sh Reviewed-by: jlaskey Contributed-by: james.laskey at oracle.com ! common/bin/hgforest.sh From sundararajan.athijegannathan at oracle.com Thu Feb 7 03:48:27 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Thu, 07 Feb 2013 11:48:27 +0000 Subject: hg: nashorn/jdk8/nashorn: 8007715: Make sure that not all tests run with AllPermission Message-ID: <20130207114828.41628478D4@hg.openjdk.java.net> Changeset: d7e83be6e7aa Author: sundar Date: 2013-02-07 17:17 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/d7e83be6e7aa 8007715: Make sure that not all tests run with AllPermission Reviewed-by: lagergren, attila ! make/build.xml ! make/project.properties ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java + test/script/README - test/script/basic/JDK-8006424.js - test/script/basic/JDK-8006529.js - test/script/basic/NASHORN-638.js - test/script/basic/NASHORN-638.js.EXPECTED - test/script/basic/NASHORN-653.js ! test/script/basic/NASHORN-758.js - test/script/basic/getenv.js - test/script/basic/getenv.js.EXPECTED ! test/script/basic/javaexceptions.js ! test/script/basic/newexpr.js + test/script/sandbox/interfaceimpl.js + test/script/sandbox/loadcompat.js + test/script/trusted/JDK-8006424.js + test/script/trusted/JDK-8006529.js + test/script/trusted/NASHORN-638.js + test/script/trusted/NASHORN-638.js.EXPECTED + test/script/trusted/NASHORN-653.js + test/script/trusted/README + test/script/trusted/getenv.js + test/script/trusted/getenv.js.EXPECTED ! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java ! test/src/jdk/nashorn/internal/runtime/ContextTest.java From hannes.wallnoefer at oracle.com Thu Feb 7 04:54:46 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Thu, 07 Feb 2013 13:54:46 +0100 Subject: Review request for JDK-8007627 Message-ID: <5113A416.40606@oracle.com> Please review webrev for JDK-8007627: Support @Getter annotation on constructor. http://cr.openjdk.java.net/~hannesw/8007627/ Patch is trivial, a the method in Nasgen that sets up the getter method handle was called with the wrong class name. Hannes From hannes.wallnoefer at oracle.com Thu Feb 7 04:59:39 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Thu, 07 Feb 2013 13:59:39 +0100 Subject: Review request for JDK-8007718 Message-ID: <5113A53B.7010308@oracle.com> Please review webrev for JDK-8007718: Make static RegExp properties compatible to other engines. http://cr.openjdk.java.net/~hannesw/8007718/ This defines non-standard properties on RegExp constructor as ordinary properties. The test script now prints the same results for V8, Spidermonkey and Nashorn. Note that this requires patch for JDK-8007627 (@Getter annotation on constructor) in order to run. Hannes From attila.szegedi at oracle.com Thu Feb 7 05:40:52 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Thu, 7 Feb 2013 14:40:52 +0100 Subject: Review request for JDK-8007627 In-Reply-To: <5113A416.40606@oracle.com> References: <5113A416.40606@oracle.com> Message-ID: +1 On Feb 7, 2013, at 1:54 PM, Hannes Wallnoefer wrote: > Please review webrev for JDK-8007627: Support @Getter annotation on constructor. > > http://cr.openjdk.java.net/~hannesw/8007627/ > > Patch is trivial, a the method in Nasgen that sets up the getter method handle was called with the wrong class name. > > Hannes From marcus.lagergren at oracle.com Thu Feb 7 05:48:43 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Thu, 7 Feb 2013 14:48:43 +0100 Subject: Review request for JDK-8007627 In-Reply-To: <5113A416.40606@oracle.com> References: <5113A416.40606@oracle.com> Message-ID: +1 On Feb 7, 2013, at 1:54 PM, Hannes Wallnoefer wrote: > Please review webrev for JDK-8007627: Support @Getter annotation on constructor. > > http://cr.openjdk.java.net/~hannesw/8007627/ > > Patch is trivial, a the method in Nasgen that sets up the getter method handle was called with the wrong class name. > > Hannes From marcus.lagergren at oracle.com Thu Feb 7 05:50:23 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Thu, 7 Feb 2013 14:50:23 +0100 Subject: Review request for JDK-8007718 In-Reply-To: <5113A53B.7010308@oracle.com> References: <5113A53B.7010308@oracle.com> Message-ID: <6AB67C68-0BC5-47EF-B7EE-A3EB80248C49@oracle.com> +1 On Feb 7, 2013, at 1:59 PM, Hannes Wallnoefer wrote: > Please review webrev for JDK-8007718: Make static RegExp properties compatible to other engines. > > http://cr.openjdk.java.net/~hannesw/8007718/ > > This defines non-standard properties on RegExp constructor as ordinary properties. The test script now prints the same results for V8, Spidermonkey and Nashorn. > > Note that this requires patch for JDK-8007627 (@Getter annotation on constructor) in order to run. > > Hannes From hannes.wallnoefer at oracle.com Thu Feb 7 05:59:12 2013 From: hannes.wallnoefer at oracle.com (hannes.wallnoefer at oracle.com) Date: Thu, 07 Feb 2013 13:59:12 +0000 Subject: hg: nashorn/jdk8/nashorn: 8007627: Support @Getter annotation on constructor Message-ID: <20130207135913.133D4478DB@hg.openjdk.java.net> Changeset: bca3a64a4a82 Author: hannesw Date: 2013-02-07 14:58 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/bca3a64a4a82 8007627: Support @Getter annotation on constructor Reviewed-by: attila, lagergren ! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/ConstructorGenerator.java ! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/PrototypeGenerator.java From sundararajan.athijegannathan at oracle.com Thu Feb 7 06:11:36 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Thu, 07 Feb 2013 19:41:36 +0530 Subject: Review request for JDK-8007718 In-Reply-To: <5113A53B.7010308@oracle.com> References: <5113A53B.7010308@oracle.com> Message-ID: <5113B618.70707@oracle.com> +1 -Sundar On Thursday 07 February 2013 06:29 PM, Hannes Wallnoefer wrote: > Please review webrev for JDK-8007718: Make static RegExp properties > compatible to other engines. > > http://cr.openjdk.java.net/~hannesw/8007718/ > > This defines non-standard properties on RegExp constructor as ordinary > properties. The test script now prints the same results for V8, > Spidermonkey and Nashorn. > > Note that this requires patch for JDK-8007627 (@Getter annotation on > constructor) in order to run. > > Hannes From hannes.wallnoefer at oracle.com Thu Feb 7 06:34:29 2013 From: hannes.wallnoefer at oracle.com (hannes.wallnoefer at oracle.com) Date: Thu, 07 Feb 2013 14:34:29 +0000 Subject: hg: nashorn/jdk8/nashorn: 8007718: Make static RegExp properties fully compatible to other engines Message-ID: <20130207143430.6DD5E478DC@hg.openjdk.java.net> Changeset: d5130a5803d1 Author: hannesw Date: 2013-02-07 15:33 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/d5130a5803d1 8007718: Make static RegExp properties fully compatible to other engines Reviewed-by: lagergren, sundar ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/objects/NativeRegExp.java ! src/jdk/nashorn/internal/runtime/RegExpMatch.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java + test/script/basic/JDK-8007718.js + test/script/basic/JDK-8007718.js.EXPECTED From james.laskey at oracle.com Thu Feb 7 12:01:22 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Thu, 7 Feb 2013 16:01:22 -0400 Subject: Review request 8006222 - Move slot from SpillProperty to Property Message-ID: <3477ABC3-304B-4E83-B7FE-33CA7BDC0623@oracle.com> Just some little stuff sitting on my desk for a bit. leading up to more changes in properties. Please review http://cr.openjdk.java.net/~jlaskey/8006222/webrev.00/index.html From harsz89 at gmail.com Fri Feb 8 00:37:45 2013 From: harsz89 at gmail.com (Harsha Kumara) Date: Fri, 8 Feb 2013 14:07:45 +0530 Subject: Get nashron work in opnjdk8 Message-ID: Hi! I had tried to run some performance tests.But results are not impressive than I thought.I have build openjdk8 and set JAVA_HOME to it.Then I have build nashron.But when I run the jrunscript -q it still show the rhino as underline javascript engine.Then how can I configure it to use nashron? Thanks! -- *Harsha Kumara* *Undergraduate* *Department of Computer Science and Engineering* *University of Moratuwa* *Sri Lanka.* From hannes.wallnoefer at oracle.com Fri Feb 8 00:58:48 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Fri, 08 Feb 2013 09:58:48 +0100 Subject: Review request 8006222 - Move slot from SpillProperty to Property In-Reply-To: <3477ABC3-304B-4E83-B7FE-33CA7BDC0623@oracle.com> References: <3477ABC3-304B-4E83-B7FE-33CA7BDC0623@oracle.com> Message-ID: <5114BE48.1070807@oracle.com> Looks good to me. To small issues: - one of the two calls to super.equals(other) in UserAccessorProperty.equals() is redundant. - javadoc for "self" parameter in FindProperty constructor should also say "... where search began" instead of "... where property was found". Hannes Am 2013-02-07 21:01, schrieb Jim Laskey (Oracle): > Just some little stuff sitting on my desk for a bit. leading up to more changes in properties. > > Please review http://cr.openjdk.java.net/~jlaskey/8006222/webrev.00/index.html > > From marcus.lagergren at oracle.com Fri Feb 8 03:16:19 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Fri, 8 Feb 2013 12:16:19 +0100 Subject: Review request 8006222 - Move slot from SpillProperty to Property In-Reply-To: <3477ABC3-304B-4E83-B7FE-33CA7BDC0623@oracle.com> References: <3477ABC3-304B-4E83-B7FE-33CA7BDC0623@oracle.com> Message-ID: I'm fine with it, please verify that dual fields still works by doing java -Dnashorn.fields.dual=true -jar dist/nashorn.jar --log=fields test/examples/typechain.js you should see several forType=xxx where xxx != Object in the log . if you only see forType=Object it's broken somehow /M On Feb 7, 2013, at 9:01 PM, Jim Laskey (Oracle) wrote: > Just some little stuff sitting on my desk for a bit. leading up to more changes in properties. > > Please review http://cr.openjdk.java.net/~jlaskey/8006222/webrev.00/index.html > > From sundararajan.athijegannathan at oracle.com Fri Feb 8 04:29:10 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Fri, 08 Feb 2013 17:59:10 +0530 Subject: Get nashron work in opnjdk8 In-Reply-To: References: Message-ID: <5114EF96.6040101@oracle.com> Hi, Nashorn has not yet hit the openjdk8 main repo. You need to pull nashorn forest for now: http://hg.openjdk.java.net/nashorn/jdk8 It'll be some time before nashorn hits main jdk8 repo. But, you can pull the above forest in the interim and build it. -Sundar On Friday 08 February 2013 02:07 PM, Harsha Kumara wrote: > Hi! > I had tried to run some performance tests.But results are not impressive > than I thought.I have build openjdk8 and set JAVA_HOME to it.Then I have > build nashron.But when I run the jrunscript -q it still show the rhino as > underline javascript engine.Then how can I configure it to use nashron? > Thanks! > From james.laskey at oracle.com Fri Feb 8 05:20:11 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Fri, 08 Feb 2013 13:20:11 +0000 Subject: hg: nashorn/jdk8/nashorn: 8006222: Move slot from SpillProperty to Property Message-ID: <20130208132012.71AB34793B@hg.openjdk.java.net> Changeset: 8742be332c8a Author: jlaskey Date: 2013-02-08 09:19 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/8742be332c8a 8006222: Move slot from SpillProperty to Property Reviewed-by: hannesw, lagergren Contributed-by: james.laskey at oracle.com ! src/jdk/nashorn/internal/codegen/objects/FieldObjectCreator.java ! src/jdk/nashorn/internal/codegen/objects/MapCreator.java ! src/jdk/nashorn/internal/codegen/objects/ObjectCreator.java ! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java ! src/jdk/nashorn/internal/runtime/AccessorProperty.java ! src/jdk/nashorn/internal/runtime/FindProperty.java ! src/jdk/nashorn/internal/runtime/Property.java ! src/jdk/nashorn/internal/runtime/PropertyMap.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/SpillProperty.java ! src/jdk/nashorn/internal/runtime/UserAccessorProperty.java ! src/jdk/nashorn/internal/runtime/linker/Lookup.java From sundararajan.athijegannathan at oracle.com Fri Feb 8 05:22:08 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Fri, 08 Feb 2013 18:52:08 +0530 Subject: Get nashron work in opnjdk8 In-Reply-To: References: <5114EF96.6040101@oracle.com> Message-ID: <5114FC00.6060608@oracle.com> [Please reply to list as it will be record for similar queries from others as well] You said it is not as fast as rhino on your test. Is it possible to share your test or reduced version of it demonstrating performance issue? thanks -Sundar On Friday 08 February 2013 06:15 PM, Harsha Kumara wrote: > Hi! > I have pull jdk8 and build it.Then I build nashron after setting java > home poiting to the jdk8.But ant build return with a javadoc error.I > have the nashron jar which is build during the ant build.And I ran jjs > executable with a some test it's not fast as rhino.I wonder whether I > need to other configuration to get nashron into play? > Thanks! > > On Fri, Feb 8, 2013 at 5:59 PM, A. Sundararajan > > wrote: > > Hi, > > Nashorn has not yet hit the openjdk8 main repo. You need to pull > nashorn forest for now: > > http://hg.openjdk.java.net/nashorn/jdk8 > > It'll be some time before nashorn hits main jdk8 repo. But, you > can pull the above forest in the interim and build it. > > -Sundar > > > On Friday 08 February 2013 02:07 PM, Harsha Kumara wrote: > > Hi! > I had tried to run some performance tests.But results are not > impressive > than I thought.I have build openjdk8 and set JAVA_HOME to > it.Then I have > build nashron.But when I run the jrunscript -q it still show > the rhino as > underline javascript engine.Then how can I configure it to use > nashron? > Thanks! > > > > > > -- > /Harsha Kumara/ > /Undergraduate/ > /Department of Computer Science and Engineering/ > /University of Moratuwa/ > /Sri Lanka./ From harsz89 at gmail.com Fri Feb 8 05:29:49 2013 From: harsz89 at gmail.com (Harsha Kumara) Date: Fri, 8 Feb 2013 18:59:49 +0530 Subject: Get nashron work in opnjdk8 In-Reply-To: <5114FC00.6060608@oracle.com> References: <5114EF96.6040101@oracle.com> <5114FC00.6060608@oracle.com> Message-ID: Yeah the problem is i'm not quite sure whether I have configure the nashorn correctly.I had run crypto test in v8 bench mark test suit in jjs console it gives around 110ms to run the encryption operation where rhino just take around 31ms.My concern is how can I know whether I have correctly configure nashorn in my machine. Thanks! On Fri, Feb 8, 2013 at 6:52 PM, A. Sundararajan < sundararajan.athijegannathan at oracle.com> wrote: > [Please reply to list as it will be record for similar queries from others > as well] > > You said it is not as fast as rhino on your test. Is it possible to share > your test or reduced version of it demonstrating performance issue? > > thanks > -Sundar > > > On Friday 08 February 2013 06:15 PM, Harsha Kumara wrote: > >> Hi! >> >> I have pull jdk8 and build it.Then I build nashron after setting java >> home poiting to the jdk8.But ant build return with a javadoc error.I have >> the nashron jar which is build during the ant build.And I ran jjs >> executable with a some test it's not fast as rhino.I wonder whether I need >> to other configuration to get nashron into play? >> Thanks! >> >> On Fri, Feb 8, 2013 at 5:59 PM, A. Sundararajan < >> sundararajan.athijegannathan@**oracle.com> sundararajan.**athijegannathan at oracle.com>> >> wrote: >> >> Hi, >> >> Nashorn has not yet hit the openjdk8 main repo. You need to pull >> nashorn forest for now: >> >> http://hg.openjdk.java.net/**nashorn/jdk8 >> >> It'll be some time before nashorn hits main jdk8 repo. But, you >> can pull the above forest in the interim and build it. >> >> -Sundar >> >> >> On Friday 08 February 2013 02:07 PM, Harsha Kumara wrote: >> >> Hi! >> I had tried to run some performance tests.But results are not >> impressive >> than I thought.I have build openjdk8 and set JAVA_HOME to >> it.Then I have >> build nashron.But when I run the jrunscript -q it still show >> the rhino as >> underline javascript engine.Then how can I configure it to use >> nashron? >> Thanks! >> >> >> >> >> >> -- >> /Harsha Kumara/ >> /Undergraduate/ >> /Department of Computer Science and Engineering/ >> /University of Moratuwa/ >> /Sri Lanka./ >> > > -- *Harsha Kumara* *Undergraduate* *Department of Computer Science and Engineering* *University of Moratuwa* *Sri Lanka.* From marcus.lagergren at oracle.com Fri Feb 8 05:40:39 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Fri, 8 Feb 2013 14:40:39 +0100 Subject: Get nashron work in opnjdk8 In-Reply-To: References: <5114EF96.6040101@oracle.com> <5114FC00.6060608@oracle.com> Message-ID: Can you tell us how you run it in JJS? For the best current Nashorn performance, any build over Java8 b74 should be used, as it contains significant fixes to the inlining in the JVM. You probably need to give any microbenchmark a few warmup rounds for performance to stabilize. If you only run one round, there will be too much noise and warmup issues for results to be meaningful. This is especially true with invoke dynamic based programs running on Java 8 now, as they tend to warm up slower than standard "Java" programs. Running with the octane test harness in the Nashorn repo (modified to provide multiple rounds for VM warmup) (after doing ant externals to get the benchmarks) java -jar dist/nashorn.jar test/script/basic/run-octane.js -- test/script/external/octane/crypto.js --iterations 10 --verbose I get ~2000 points on my machine, where Rhino gives me ~850 points. /M On Feb 8, 2013, at 2:29 PM, Harsha Kumara wrote: > Yeah the problem is i'm not quite sure whether I have configure the nashorn > correctly.I had run crypto test in v8 bench mark test suit in jjs console > it gives around 110ms to run the encryption operation where rhino just take > around 31ms.My concern is how can I know whether I have correctly configure > nashorn in my machine. > Thanks! > > On Fri, Feb 8, 2013 at 6:52 PM, A. Sundararajan < > sundararajan.athijegannathan at oracle.com> wrote: > >> [Please reply to list as it will be record for similar queries from others >> as well] >> >> You said it is not as fast as rhino on your test. Is it possible to share >> your test or reduced version of it demonstrating performance issue? >> >> thanks >> -Sundar >> >> >> On Friday 08 February 2013 06:15 PM, Harsha Kumara wrote: >> >>> Hi! >>> >>> I have pull jdk8 and build it.Then I build nashron after setting java >>> home poiting to the jdk8.But ant build return with a javadoc error.I have >>> the nashron jar which is build during the ant build.And I ran jjs >>> executable with a some test it's not fast as rhino.I wonder whether I need >>> to other configuration to get nashron into play? >>> Thanks! >>> >>> On Fri, Feb 8, 2013 at 5:59 PM, A. Sundararajan < >>> sundararajan.athijegannathan@**oracle.com>> sundararajan.**athijegannathan at oracle.com>> >>> wrote: >>> >>> Hi, >>> >>> Nashorn has not yet hit the openjdk8 main repo. You need to pull >>> nashorn forest for now: >>> >>> http://hg.openjdk.java.net/**nashorn/jdk8 >>> >>> It'll be some time before nashorn hits main jdk8 repo. But, you >>> can pull the above forest in the interim and build it. >>> >>> -Sundar >>> >>> >>> On Friday 08 February 2013 02:07 PM, Harsha Kumara wrote: >>> >>> Hi! >>> I had tried to run some performance tests.But results are not >>> impressive >>> than I thought.I have build openjdk8 and set JAVA_HOME to >>> it.Then I have >>> build nashron.But when I run the jrunscript -q it still show >>> the rhino as >>> underline javascript engine.Then how can I configure it to use >>> nashron? >>> Thanks! >>> >>> >>> >>> >>> >>> -- >>> /Harsha Kumara/ >>> /Undergraduate/ >>> /Department of Computer Science and Engineering/ >>> /University of Moratuwa/ >>> /Sri Lanka./ >>> >> >> > > > -- > *Harsha Kumara* > *Undergraduate* > *Department of Computer Science and Engineering* > *University of Moratuwa* > *Sri Lanka.* From harsz89 at gmail.com Fri Feb 8 06:00:36 2013 From: harsz89 at gmail.com (Harsha Kumara) Date: Fri, 8 Feb 2013 19:30:36 +0530 Subject: Get nashron work in opnjdk8 In-Reply-To: References: <5114EF96.6040101@oracle.com> <5114FC00.6060608@oracle.com> Message-ID: I have locally build openjdk8 forest.Then I set java home to jdk8 which was build from my local build.I think the way i ran jjs is not correct.Using consoe I ran ./jjs then I got the console.Afterthat I manually load javascript file using load function (ed:load("foo.js")) and call the function.Is that correct? Thanks! On Fri, Feb 8, 2013 at 7:10 PM, Marcus Lagergren < marcus.lagergren at oracle.com> wrote: > Can you tell us how you run it in JJS? > > For the best current Nashorn performance, any build over Java8 b74 should > be used, as it contains significant fixes to the inlining in the JVM. > You probably need to give any microbenchmark a few warmup rounds for > performance to stabilize. If you only run one round, there will be too much > noise and warmup issues for results to be meaningful. This is especially > true with invoke dynamic based programs running on Java 8 now, as they > tend to warm up slower than standard "Java" programs. > > Running with the octane test harness in the Nashorn repo (modified to > provide multiple rounds for VM warmup) > (after doing ant externals to get the benchmarks) > > java -jar dist/nashorn.jar test/script/basic/run-octane.js -- > test/script/external/octane/crypto.js --iterations 10 --verbose > > I get ~2000 points on my machine, where Rhino gives me ~850 points. > > > /M > > > On Feb 8, 2013, at 2:29 PM, Harsha Kumara wrote: > > > Yeah the problem is i'm not quite sure whether I have configure the > nashorn > > correctly.I had run crypto test in v8 bench mark test suit in jjs console > > it gives around 110ms to run the encryption operation where rhino just > take > > around 31ms.My concern is how can I know whether I have correctly > configure > > nashorn in my machine. > > Thanks! > > > > On Fri, Feb 8, 2013 at 6:52 PM, A. Sundararajan < > > sundararajan.athijegannathan at oracle.com> wrote: > > > >> [Please reply to list as it will be record for similar queries from > others > >> as well] > >> > >> You said it is not as fast as rhino on your test. Is it possible to > share > >> your test or reduced version of it demonstrating performance issue? > >> > >> thanks > >> -Sundar > >> > >> > >> On Friday 08 February 2013 06:15 PM, Harsha Kumara wrote: > >> > >>> Hi! > >>> > >>> I have pull jdk8 and build it.Then I build nashron after setting java > >>> home poiting to the jdk8.But ant build return with a javadoc error.I > have > >>> the nashron jar which is build during the ant build.And I ran jjs > >>> executable with a some test it's not fast as rhino.I wonder whether I > need > >>> to other configuration to get nashron into play? > >>> Thanks! > >>> > >>> On Fri, Feb 8, 2013 at 5:59 PM, A. Sundararajan < > >>> sundararajan.athijegannathan@**oracle.com< > sundararajan.athijegannathan at oracle.com> >>> sundararajan.**athijegannathan at oracle.com< > sundararajan.athijegannathan at oracle.com>>> > >>> wrote: > >>> > >>> Hi, > >>> > >>> Nashorn has not yet hit the openjdk8 main repo. You need to pull > >>> nashorn forest for now: > >>> > >>> http://hg.openjdk.java.net/**nashorn/jdk8< > http://hg.openjdk.java.net/nashorn/jdk8> > >>> > >>> It'll be some time before nashorn hits main jdk8 repo. But, you > >>> can pull the above forest in the interim and build it. > >>> > >>> -Sundar > >>> > >>> > >>> On Friday 08 February 2013 02:07 PM, Harsha Kumara wrote: > >>> > >>> Hi! > >>> I had tried to run some performance tests.But results are not > >>> impressive > >>> than I thought.I have build openjdk8 and set JAVA_HOME to > >>> it.Then I have > >>> build nashron.But when I run the jrunscript -q it still show > >>> the rhino as > >>> underline javascript engine.Then how can I configure it to use > >>> nashron? > >>> Thanks! > >>> > >>> > >>> > >>> > >>> > >>> -- > >>> /Harsha Kumara/ > >>> /Undergraduate/ > >>> /Department of Computer Science and Engineering/ > >>> /University of Moratuwa/ > >>> /Sri Lanka./ > >>> > >> > >> > > > > > > -- > > *Harsha Kumara* > > *Undergraduate* > > *Department of Computer Science and Engineering* > > *University of Moratuwa* > > *Sri Lanka.* > > -- *Harsha Kumara* *Undergraduate* *Department of Computer Science and Engineering* *University of Moratuwa* *Sri Lanka.* From hannes.wallnoefer at oracle.com Fri Feb 8 06:31:10 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Fri, 08 Feb 2013 15:31:10 +0100 Subject: Get nashron work in opnjdk8 In-Reply-To: References: <5114EF96.6040101@oracle.com> <5114FC00.6060608@oracle.com> Message-ID: <51150C2E.108@oracle.com> Am 2013-02-08 15:00, schrieb Harsha Kumara: > I have locally build openjdk8 forest.Then I set java home to jdk8 which was > build from my local build.I think the way i ran jjs is not correct.Using > consoe I ran ./jjs then I got the console.Afterthat I manually load > javascript file using load function (ed:load("foo.js")) and call the > function.Is that correct? If you were able to load and run JavaScript you probably did everything right. However, if you just want to play with Nashorn the simpler option may be to use an official JDK preview release from http://jdk8.java.net/download.html. You can use the following command to just get the Nashhorn sources: hg clone http://hg.openjdk.java.net/nashorn/jdk8/nashorn nashorn Hannes > Thanks! > On Fri, Feb 8, 2013 at 7:10 PM, Marcus Lagergren < > marcus.lagergren at oracle.com> wrote: > >> Can you tell us how you run it in JJS? >> >> For the best current Nashorn performance, any build over Java8 b74 should >> be used, as it contains significant fixes to the inlining in the JVM. >> You probably need to give any microbenchmark a few warmup rounds for >> performance to stabilize. If you only run one round, there will be too much >> noise and warmup issues for results to be meaningful. This is especially >> true with invoke dynamic based programs running on Java 8 now, as they >> tend to warm up slower than standard "Java" programs. >> >> Running with the octane test harness in the Nashorn repo (modified to >> provide multiple rounds for VM warmup) >> (after doing ant externals to get the benchmarks) >> >> java -jar dist/nashorn.jar test/script/basic/run-octane.js -- >> test/script/external/octane/crypto.js --iterations 10 --verbose >> >> I get ~2000 points on my machine, where Rhino gives me ~850 points. >> >> >> /M >> >> >> On Feb 8, 2013, at 2:29 PM, Harsha Kumara wrote: >> >>> Yeah the problem is i'm not quite sure whether I have configure the >> nashorn >>> correctly.I had run crypto test in v8 bench mark test suit in jjs console >>> it gives around 110ms to run the encryption operation where rhino just >> take >>> around 31ms.My concern is how can I know whether I have correctly >> configure >>> nashorn in my machine. >>> Thanks! >>> >>> On Fri, Feb 8, 2013 at 6:52 PM, A. Sundararajan < >>> sundararajan.athijegannathan at oracle.com> wrote: >>> >>>> [Please reply to list as it will be record for similar queries from >> others >>>> as well] >>>> >>>> You said it is not as fast as rhino on your test. Is it possible to >> share >>>> your test or reduced version of it demonstrating performance issue? >>>> >>>> thanks >>>> -Sundar >>>> >>>> >>>> On Friday 08 February 2013 06:15 PM, Harsha Kumara wrote: >>>> >>>>> Hi! >>>>> >>>>> I have pull jdk8 and build it.Then I build nashron after setting java >>>>> home poiting to the jdk8.But ant build return with a javadoc error.I >> have >>>>> the nashron jar which is build during the ant build.And I ran jjs >>>>> executable with a some test it's not fast as rhino.I wonder whether I >> need >>>>> to other configuration to get nashron into play? >>>>> Thanks! >>>>> >>>>> On Fri, Feb 8, 2013 at 5:59 PM, A. Sundararajan < >>>>> sundararajan.athijegannathan@**oracle.com< >> sundararajan.athijegannathan at oracle.com>>>>> sundararajan.**athijegannathan at oracle.com< >> sundararajan.athijegannathan at oracle.com>>> >>>>> wrote: >>>>> >>>>> Hi, >>>>> >>>>> Nashorn has not yet hit the openjdk8 main repo. You need to pull >>>>> nashorn forest for now: >>>>> >>>>> http://hg.openjdk.java.net/**nashorn/jdk8< >> http://hg.openjdk.java.net/nashorn/jdk8> >>>>> It'll be some time before nashorn hits main jdk8 repo. But, you >>>>> can pull the above forest in the interim and build it. >>>>> >>>>> -Sundar >>>>> >>>>> >>>>> On Friday 08 February 2013 02:07 PM, Harsha Kumara wrote: >>>>> >>>>> Hi! >>>>> I had tried to run some performance tests.But results are not >>>>> impressive >>>>> than I thought.I have build openjdk8 and set JAVA_HOME to >>>>> it.Then I have >>>>> build nashron.But when I run the jrunscript -q it still show >>>>> the rhino as >>>>> underline javascript engine.Then how can I configure it to use >>>>> nashron? >>>>> Thanks! >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> /Harsha Kumara/ >>>>> /Undergraduate/ >>>>> /Department of Computer Science and Engineering/ >>>>> /University of Moratuwa/ >>>>> /Sri Lanka./ >>>>> >>>> >>> >>> -- >>> *Harsha Kumara* >>> *Undergraduate* >>> *Department of Computer Science and Engineering* >>> *University of Moratuwa* >>> *Sri Lanka.* >> > From harsz89 at gmail.com Fri Feb 8 07:04:48 2013 From: harsz89 at gmail.com (Harsha Kumara) Date: Fri, 8 Feb 2013 20:34:48 +0530 Subject: Get nashron work in opnjdk8 In-Reply-To: <51150C2E.108@oracle.com> References: <5114EF96.6040101@oracle.com> <5114FC00.6060608@oracle.com> <51150C2E.108@oracle.com> Message-ID: Yeap.I have build the nashron by checkout it.I'll run tests again compare with rhino.I went through some articles and some of articles express that nashorn is faster and perform well than v8 java script engine.But the performance of the v8 is still higher than the nashorn I guess.I did some bechmark test with v8 and nashorn.So far v8 perform well.Am I correct?are there a any ways to tune nashorn to perform faster? On Fri, Feb 8, 2013 at 8:01 PM, Hannes Wallnoefer < hannes.wallnoefer at oracle.com> wrote: > Am 2013-02-08 15:00, schrieb Harsha Kumara: > > I have locally build openjdk8 forest.Then I set java home to jdk8 which was > build from my local build.I think the way i ran jjs is not correct.Using > consoe I ran ./jjs then I got the console.Afterthat I manually load > javascript file using load function (ed:load("foo.js")) and call the > function.Is that correct? > > > If you were able to load and run JavaScript you probably did everything > right. > > However, if you just want to play with Nashorn the simpler option may be > to use an official JDK preview release from > http://jdk8.java.net/download.html. You can use the following command to > just get the Nashhorn sources: > > hg clone http://hg.openjdk.java.net/nashorn/jdk8/nashorn nashorn > > Hannes > > > Thanks! > On Fri, Feb 8, 2013 at 7:10 PM, Marcus Lagergren wrote: > > > Can you tell us how you run it in JJS? > > For the best current Nashorn performance, any build over Java8 b74 should > be used, as it contains significant fixes to the inlining in the JVM. > You probably need to give any microbenchmark a few warmup rounds for > performance to stabilize. If you only run one round, there will be too much > noise and warmup issues for results to be meaningful. This is especially > true with invoke dynamic based programs running on Java 8 now, as they > tend to warm up slower than standard "Java" programs. > > Running with the octane test harness in the Nashorn repo (modified to > provide multiple rounds for VM warmup) > (after doing ant externals to get the benchmarks) > > java -jar dist/nashorn.jar test/script/basic/run-octane.js -- > test/script/external/octane/crypto.js --iterations 10 --verbose > > I get ~2000 points on my machine, where Rhino gives me ~850 points. > > > /M > > > On Feb 8, 2013, at 2:29 PM, Harsha Kumara wrote: > > > Yeah the problem is i'm not quite sure whether I have configure the > > nashorn > > correctly.I had run crypto test in v8 bench mark test suit in jjs console > it gives around 110ms to run the encryption operation where rhino just > > take > > around 31ms.My concern is how can I know whether I have correctly > > configure > > nashorn in my machine. > Thanks! > > On Fri, Feb 8, 2013 at 6:52 PM, A. Sundararajan wrote: > > > [Please reply to list as it will be record for similar queries from > > others > > as well] > > You said it is not as fast as rhino on your test. Is it possible to > > share > > your test or reduced version of it demonstrating performance issue? > > thanks > -Sundar > > > On Friday 08 February 2013 06:15 PM, Harsha Kumara wrote: > > > Hi! > > I have pull jdk8 and build it.Then I build nashron after setting java > home poiting to the jdk8.But ant build return with a javadoc error.I > > have > > the nashron jar which is build during the ant build.And I ran jjs > executable with a some test it's not fast as rhino.I wonder whether I > > need > > to other configuration to get nashron into play? > Thanks! > > On Fri, Feb 8, 2013 at 5:59 PM, A. Sundararajan > sundararajan.athijegannathan at oracle.com> > sundararajan.**athijegannathan at oracle.com< > > sundararajan.athijegannathan at oracle.com>>> > > wrote: > > Hi, > > Nashorn has not yet hit the openjdk8 main repo. You need to pull > nashorn forest for now: > > http://hg.openjdk.java.net/**nashorn/jdk8< > > http://hg.openjdk.java.net/nashorn/jdk8> > > It'll be some time before nashorn hits main jdk8 repo. But, you > can pull the above forest in the interim and build it. > > -Sundar > > > On Friday 08 February 2013 02:07 PM, Harsha Kumara wrote: > > Hi! > I had tried to run some performance tests.But results are not > impressive > than I thought.I have build openjdk8 and set JAVA_HOME to > it.Then I have > build nashron.But when I run the jrunscript -q it still show > the rhino as > underline javascript engine.Then how can I configure it to use > nashron? > Thanks! > > > > > > -- > /Harsha Kumara/ > /Undergraduate/ > /Department of Computer Science and Engineering/ > /University of Moratuwa/ > /Sri Lanka./ > > > -- > *Harsha Kumara* > *Undergraduate* > *Department of Computer Science and Engineering* > *University of Moratuwa* > *Sri Lanka.* > > > -- *Harsha Kumara* *Undergraduate* *Department of Computer Science and Engineering* *University of Moratuwa* *Sri Lanka.* From marcus.lagergren at oracle.com Fri Feb 8 07:45:49 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Fri, 8 Feb 2013 16:45:49 +0100 Subject: Get nashron work in opnjdk8 In-Reply-To: References: <5114EF96.6040101@oracle.com> <5114FC00.6060608@oracle.com> <51150C2E.108@oracle.com> Message-ID: <5611DF55-3283-4B10-AA64-9517410B2A21@oracle.com> Actually, Nashorn currently beats v8 on the splay benchmark in the Octane suite, but for pure number crunching tests like crypto we are still behind, as we don't have the luxury of our own native value representation - producing strongly typed Java byte code is rather high level for a runtime. We have several tricks up our sleeve though, both on the JVM side and in Nashorn itself, so this gap is expected to get smaller. If you want to know more about how to implement dynamic languages on the JVM and get some performance out of it, I did a presentation at Devoxx last November that is freely available online. http://www.devoxx.com/display/DV12/Nashorn++Optimizing+JavaScript+and+Dynamic+Language+Execution+on+the+JVM Regards Marcus On Feb 8, 2013, at 4:04 PM, Harsha Kumara wrote: > Yeap.I have build the nashron by checkout it.I'll run tests again compare > with rhino.I went through some articles and some of articles express that > nashorn is faster and perform well than v8 java script engine.But the > performance of the v8 is still higher than the nashorn I guess.I did some > bechmark test with v8 and nashorn.So far v8 perform well.Am I correct?are > there a any ways to tune nashorn to perform faster? > > On Fri, Feb 8, 2013 at 8:01 PM, Hannes Wallnoefer < > hannes.wallnoefer at oracle.com> wrote: > >> Am 2013-02-08 15:00, schrieb Harsha Kumara: >> >> I have locally build openjdk8 forest.Then I set java home to jdk8 which was >> build from my local build.I think the way i ran jjs is not correct.Using >> consoe I ran ./jjs then I got the console.Afterthat I manually load >> javascript file using load function (ed:load("foo.js")) and call the >> function.Is that correct? >> >> >> If you were able to load and run JavaScript you probably did everything >> right. >> >> However, if you just want to play with Nashorn the simpler option may be >> to use an official JDK preview release from >> http://jdk8.java.net/download.html. You can use the following command to >> just get the Nashhorn sources: >> >> hg clone http://hg.openjdk.java.net/nashorn/jdk8/nashorn nashorn >> >> Hannes >> >> >> Thanks! >> On Fri, Feb 8, 2013 at 7:10 PM, Marcus Lagergren wrote: >> >> >> Can you tell us how you run it in JJS? >> >> For the best current Nashorn performance, any build over Java8 b74 should >> be used, as it contains significant fixes to the inlining in the JVM. >> You probably need to give any microbenchmark a few warmup rounds for >> performance to stabilize. If you only run one round, there will be too much >> noise and warmup issues for results to be meaningful. This is especially >> true with invoke dynamic based programs running on Java 8 now, as they >> tend to warm up slower than standard "Java" programs. >> >> Running with the octane test harness in the Nashorn repo (modified to >> provide multiple rounds for VM warmup) >> (after doing ant externals to get the benchmarks) >> >> java -jar dist/nashorn.jar test/script/basic/run-octane.js -- >> test/script/external/octane/crypto.js --iterations 10 --verbose >> >> I get ~2000 points on my machine, where Rhino gives me ~850 points. >> >> >> /M >> >> >> On Feb 8, 2013, at 2:29 PM, Harsha Kumara wrote: >> >> >> Yeah the problem is i'm not quite sure whether I have configure the >> >> nashorn >> >> correctly.I had run crypto test in v8 bench mark test suit in jjs console >> it gives around 110ms to run the encryption operation where rhino just >> >> take >> >> around 31ms.My concern is how can I know whether I have correctly >> >> configure >> >> nashorn in my machine. >> Thanks! >> >> On Fri, Feb 8, 2013 at 6:52 PM, A. Sundararajan wrote: >> >> >> [Please reply to list as it will be record for similar queries from >> >> others >> >> as well] >> >> You said it is not as fast as rhino on your test. Is it possible to >> >> share >> >> your test or reduced version of it demonstrating performance issue? >> >> thanks >> -Sundar >> >> >> On Friday 08 February 2013 06:15 PM, Harsha Kumara wrote: >> >> >> Hi! >> >> I have pull jdk8 and build it.Then I build nashron after setting java >> home poiting to the jdk8.But ant build return with a javadoc error.I >> >> have >> >> the nashron jar which is build during the ant build.And I ran jjs >> executable with a some test it's not fast as rhino.I wonder whether I >> >> need >> >> to other configuration to get nashron into play? >> Thanks! >> >> On Fri, Feb 8, 2013 at 5:59 PM, A. Sundararajan > >> sundararajan.athijegannathan at oracle.com>> >> sundararajan.**athijegannathan at oracle.com< >> >> sundararajan.athijegannathan at oracle.com>>> >> >> wrote: >> >> Hi, >> >> Nashorn has not yet hit the openjdk8 main repo. You need to pull >> nashorn forest for now: >> >> http://hg.openjdk.java.net/**nashorn/jdk8< >> >> http://hg.openjdk.java.net/nashorn/jdk8> >> >> It'll be some time before nashorn hits main jdk8 repo. But, you >> can pull the above forest in the interim and build it. >> >> -Sundar >> >> >> On Friday 08 February 2013 02:07 PM, Harsha Kumara wrote: >> >> Hi! >> I had tried to run some performance tests.But results are not >> impressive >> than I thought.I have build openjdk8 and set JAVA_HOME to >> it.Then I have >> build nashron.But when I run the jrunscript -q it still show >> the rhino as >> underline javascript engine.Then how can I configure it to use >> nashron? >> Thanks! >> >> >> >> >> >> -- >> /Harsha Kumara/ >> /Undergraduate/ >> /Department of Computer Science and Engineering/ >> /University of Moratuwa/ >> /Sri Lanka./ >> >> >> -- >> *Harsha Kumara* >> *Undergraduate* >> *Department of Computer Science and Engineering* >> *University of Moratuwa* >> *Sri Lanka.* >> >> >> > > > -- > *Harsha Kumara* > *Undergraduate* > *Department of Computer Science and Engineering* > *University of Moratuwa* > *Sri Lanka.* From harsz89 at gmail.com Fri Feb 8 08:22:21 2013 From: harsz89 at gmail.com (Harsha Kumara) Date: Fri, 8 Feb 2013 21:52:21 +0530 Subject: Get nashron work in opnjdk8 In-Reply-To: <5611DF55-3283-4B10-AA64-9517410B2A21@oracle.com> References: <5114EF96.6040101@oracle.com> <5114FC00.6060608@oracle.com> <51150C2E.108@oracle.com> <5611DF55-3283-4B10-AA64-9517410B2A21@oracle.com> Message-ID: Thanks for the presentations resources.I downloaded latest rhino version and load crypto file into the rhino and nashorn seperately and run the encrypt method. In rhino when i repeatedly run the encrypt method in the consolde I got this results js> encrypt(); 54 js> encrypt(); 33 js> encrypt(); 27 js> encrypt(); 46 js> encrypt(); 28 js> encrypt(); 25 js> encrypt(); 35 js> encrypt(); 28 js> encrypt(); 27 js> encrypt(); 23 js> encrypt(); 26 js> encrypt(); 17 js> encrypt(); 24 js> encrypt(); 23 js> encrypt(); 26 And when I run it in the nashorn jjs> encrypt(); 153 jjs> encrypt(); 125 jjs> encrypt(); 118 jjs> encrypt(); 114 jjs> encrypt(); 139 jjs> encrypt(); 53 jjs> encrypt(); 51 jjs> encrypt(); 56 jjs> encrypt(); 49 jjs> encrypt(); 49 jjs> encrypt(); 47 jjs> encrypt(); 72 jjs> encrypt(); 46 jjs> encrypt(); 36 jjs> encrypt(); 25 jjs> encrypt(); 27 jjs> encrypt(); 36 jjs> encrypt(); 31 jjs> encrypt(); 26 jjs> encrypt(); 25 jjs> encrypt(); 24 jjs> encrypt(); 25 jjs> encrypt(); 33 jjs> encrypt(); 40 jjs> encrypt(); 27 jjs> encrypt(); 27 jjs> encrypt(); 26 jjs> encrypt(); 103 jjs> encrypt(); 134 jjs> encrypt(); 40 jjs> encrypt(); 23 jjs> encrypt(); 26 jjs> encrypt(); 27 jjs> encrypt(); 26 jjs> encrypt(); 28 jjs> encrypt(); 24 I have got this variate results.I have attach the crypto file.Any idea is this why this varying? On Fri, Feb 8, 2013 at 9:15 PM, Marcus Lagergren < marcus.lagergren at oracle.com> wrote: > Actually, Nashorn currently beats v8 on the splay benchmark in the Octane > suite, but for pure number crunching tests like crypto we are still behind, > as we don't have the luxury of our own native value representation - > producing strongly typed Java byte code is rather high level for a runtime. > We have several tricks up our sleeve though, both on the JVM side and in > Nashorn itself, so this gap is expected to get smaller. > > If you want to know more about how to implement dynamic languages on the > JVM and get some performance out of it, I did a presentation at Devoxx last > November that is freely available online. > http://www.devoxx.com/display/DV12/Nashorn++Optimizing+JavaScript+and+Dynamic+Language+Execution+on+the+JVM > > Regards > Marcus > > On Feb 8, 2013, at 4:04 PM, Harsha Kumara wrote: > > > Yeap.I have build the nashron by checkout it.I'll run tests again compare > > with rhino.I went through some articles and some of articles express that > > nashorn is faster and perform well than v8 java script engine.But the > > performance of the v8 is still higher than the nashorn I guess.I did some > > bechmark test with v8 and nashorn.So far v8 perform well.Am I correct?are > > there a any ways to tune nashorn to perform faster? > > > > On Fri, Feb 8, 2013 at 8:01 PM, Hannes Wallnoefer < > > hannes.wallnoefer at oracle.com> wrote: > > > >> Am 2013-02-08 15:00, schrieb Harsha Kumara: > >> > >> I have locally build openjdk8 forest.Then I set java home to jdk8 which > was > >> build from my local build.I think the way i ran jjs is not correct.Using > >> consoe I ran ./jjs then I got the console.Afterthat I manually load > >> javascript file using load function (ed:load("foo.js")) and call the > >> function.Is that correct? > >> > >> > >> If you were able to load and run JavaScript you probably did everything > >> right. > >> > >> However, if you just want to play with Nashorn the simpler option may be > >> to use an official JDK preview release from > >> http://jdk8.java.net/download.html. You can use the following command > to > >> just get the Nashhorn sources: > >> > >> hg clone http://hg.openjdk.java.net/nashorn/jdk8/nashorn nashorn > >> > >> Hannes > >> > >> > >> Thanks! > >> On Fri, Feb 8, 2013 at 7:10 PM, Marcus Lagergren < > marcus.lagergren at oracle.com> wrote: > >> > >> > >> Can you tell us how you run it in JJS? > >> > >> For the best current Nashorn performance, any build over Java8 b74 > should > >> be used, as it contains significant fixes to the inlining in the JVM. > >> You probably need to give any microbenchmark a few warmup rounds for > >> performance to stabilize. If you only run one round, there will be too > much > >> noise and warmup issues for results to be meaningful. This is especially > >> true with invoke dynamic based programs running on Java 8 now, as they > >> tend to warm up slower than standard "Java" programs. > >> > >> Running with the octane test harness in the Nashorn repo (modified to > >> provide multiple rounds for VM warmup) > >> (after doing ant externals to get the benchmarks) > >> > >> java -jar dist/nashorn.jar test/script/basic/run-octane.js -- > >> test/script/external/octane/crypto.js --iterations 10 --verbose > >> > >> I get ~2000 points on my machine, where Rhino gives me ~850 points. > >> > >> > >> /M > >> > >> > >> On Feb 8, 2013, at 2:29 PM, Harsha Kumara < > harsz89 at gmail.com> wrote: > >> > >> > >> Yeah the problem is i'm not quite sure whether I have configure the > >> > >> nashorn > >> > >> correctly.I had run crypto test in v8 bench mark test suit in jjs > console > >> it gives around 110ms to run the encryption operation where rhino just > >> > >> take > >> > >> around 31ms.My concern is how can I know whether I have correctly > >> > >> configure > >> > >> nashorn in my machine. > >> Thanks! > >> > >> On Fri, Feb 8, 2013 at 6:52 PM, A. Sundararajan < > sundararajan.athijegannathan at oracle.com> wrote: > >> > >> > >> [Please reply to list as it will be record for similar queries from > >> > >> others > >> > >> as well] > >> > >> You said it is not as fast as rhino on your test. Is it possible to > >> > >> share > >> > >> your test or reduced version of it demonstrating performance issue? > >> > >> thanks > >> -Sundar > >> > >> > >> On Friday 08 February 2013 06:15 PM, Harsha Kumara wrote: > >> > >> > >> Hi! > >> > >> I have pull jdk8 and build it.Then I build nashron after setting java > >> home poiting to the jdk8.But ant build return with a javadoc error.I > >> > >> have > >> > >> the nashron jar which is build during the ant build.And I ran jjs > >> executable with a some test it's not fast as rhino.I wonder whether I > >> > >> need > >> > >> to other configuration to get nashron into play? > >> Thanks! > >> > >> On Fri, Feb 8, 2013 at 5:59 PM, A. Sundararajan > >> > >> sundararajan.athijegannathan at oracle.com> >> > >> sundararajan.**athijegannathan at oracle.com< > >> > >> sundararajan.athijegannathan at oracle.com>>> > >> > >> wrote: > >> > >> Hi, > >> > >> Nashorn has not yet hit the openjdk8 main repo. You need to pull > >> nashorn forest for now: > >> > >> http://hg.openjdk.java.net/**nashorn/jdk8< > >> > >> http://hg.openjdk.java.net/nashorn/jdk8> > >> > >> It'll be some time before nashorn hits main jdk8 repo. But, you > >> can pull the above forest in the interim and build it. > >> > >> -Sundar > >> > >> > >> On Friday 08 February 2013 02:07 PM, Harsha Kumara wrote: > >> > >> Hi! > >> I had tried to run some performance tests.But results are not > >> impressive > >> than I thought.I have build openjdk8 and set JAVA_HOME to > >> it.Then I have > >> build nashron.But when I run the jrunscript -q it still show > >> the rhino as > >> underline javascript engine.Then how can I configure it to use > >> nashron? > >> Thanks! > >> > >> > >> > >> > >> > >> -- > >> /Harsha Kumara/ > >> /Undergraduate/ > >> /Department of Computer Science and Engineering/ > >> /University of Moratuwa/ > >> /Sri Lanka./ > >> > >> > >> -- > >> *Harsha Kumara* > >> *Undergraduate* > >> *Department of Computer Science and Engineering* > >> *University of Moratuwa* > >> *Sri Lanka.* > >> > >> > >> > > > > > > -- > > *Harsha Kumara* > > *Undergraduate* > > *Department of Computer Science and Engineering* > > *University of Moratuwa* > > *Sri Lanka.* > > -- *Harsha Kumara* *Undergraduate* *Department of Computer Science and Engineering* *University of Moratuwa* *Sri Lanka.* From harsz89 at gmail.com Fri Feb 8 20:40:27 2013 From: harsz89 at gmail.com (Harsha Kumara) Date: Sat, 9 Feb 2013 10:10:27 +0530 Subject: Get nashron work in opnjdk8 In-Reply-To: References: <5114EF96.6040101@oracle.com> <5114FC00.6060608@oracle.com> <51150C2E.108@oracle.com> <5611DF55-3283-4B10-AA64-9517410B2A21@oracle.com> Message-ID: I have downloaded the jdk8 build 75 which is available in the java.net and run tests separately.Still I got rhino perform well than nashorn.Is something I doing wrong here?Or is there anyway to set performance parameters for nashorn?Because for our final year university project,we need to find the currently available best java script engine.Since we working on server side java scripting project.We found that V8 perform well than rhino.After do some research we got to know that nashorn will become a pretty handy java script engine.So if nashorn is better our project on V8 not will much usable.Is there a place which we can have test results where we can compare v8,rhino,nashorn. Thanks! On Fri, Feb 8, 2013 at 9:52 PM, Harsha Kumara wrote: > Thanks for the presentations resources.I downloaded latest rhino version > and load crypto file into the rhino and nashorn seperately and run the > encrypt method. > In rhino when i repeatedly run the encrypt method in the consolde I got > this results > > js> encrypt(); > 54 > js> encrypt(); > 33 > js> encrypt(); > 27 > js> encrypt(); > 46 > js> encrypt(); > 28 > js> encrypt(); > 25 > js> encrypt(); > 35 > js> encrypt(); > 28 > js> encrypt(); > 27 > js> encrypt(); > 23 > js> encrypt(); > 26 > js> encrypt(); > 17 > js> encrypt(); > 24 > js> encrypt(); > 23 > js> encrypt(); > 26 > > And when I run it in the nashorn > > jjs> encrypt(); > 153 > jjs> encrypt(); > 125 > jjs> encrypt(); > 118 > jjs> encrypt(); > 114 > jjs> encrypt(); > 139 > jjs> encrypt(); > 53 > jjs> encrypt(); > 51 > jjs> encrypt(); > 56 > jjs> encrypt(); > 49 > jjs> encrypt(); > 49 > jjs> encrypt(); > 47 > jjs> encrypt(); > 72 > jjs> encrypt(); > 46 > jjs> encrypt(); > 36 > jjs> encrypt(); > 25 > jjs> encrypt(); > 27 > jjs> encrypt(); > 36 > jjs> encrypt(); > 31 > jjs> encrypt(); > 26 > jjs> encrypt(); > 25 > jjs> encrypt(); > 24 > jjs> encrypt(); > 25 > jjs> encrypt(); > 33 > jjs> encrypt(); > 40 > jjs> encrypt(); > 27 > jjs> encrypt(); > 27 > jjs> encrypt(); > 26 > jjs> encrypt(); > 103 > jjs> encrypt(); > 134 > jjs> encrypt(); > 40 > jjs> encrypt(); > 23 > jjs> encrypt(); > 26 > jjs> encrypt(); > 27 > jjs> encrypt(); > 26 > jjs> encrypt(); > 28 > jjs> encrypt(); > 24 > > I have got this variate results.I have attach the crypto file.Any idea is > this why this varying? > > On Fri, Feb 8, 2013 at 9:15 PM, Marcus Lagergren < > marcus.lagergren at oracle.com> wrote: > >> Actually, Nashorn currently beats v8 on the splay benchmark in the Octane >> suite, but for pure number crunching tests like crypto we are still behind, >> as we don't have the luxury of our own native value representation - >> producing strongly typed Java byte code is rather high level for a runtime. >> We have several tricks up our sleeve though, both on the JVM side and in >> Nashorn itself, so this gap is expected to get smaller. >> >> If you want to know more about how to implement dynamic languages on the >> JVM and get some performance out of it, I did a presentation at Devoxx last >> November that is freely available online. >> http://www.devoxx.com/display/DV12/Nashorn++Optimizing+JavaScript+and+Dynamic+Language+Execution+on+the+JVM >> >> Regards >> Marcus >> >> On Feb 8, 2013, at 4:04 PM, Harsha Kumara wrote: >> >> > Yeap.I have build the nashron by checkout it.I'll run tests again >> compare >> > with rhino.I went through some articles and some of articles express >> that >> > nashorn is faster and perform well than v8 java script engine.But the >> > performance of the v8 is still higher than the nashorn I guess.I did >> some >> > bechmark test with v8 and nashorn.So far v8 perform well.Am I >> correct?are >> > there a any ways to tune nashorn to perform faster? >> > >> > On Fri, Feb 8, 2013 at 8:01 PM, Hannes Wallnoefer < >> > hannes.wallnoefer at oracle.com> wrote: >> > >> >> Am 2013-02-08 15:00, schrieb Harsha Kumara: >> >> >> >> I have locally build openjdk8 forest.Then I set java home to jdk8 >> which was >> >> build from my local build.I think the way i ran jjs is not >> correct.Using >> >> consoe I ran ./jjs then I got the console.Afterthat I manually load >> >> javascript file using load function (ed:load("foo.js")) and call the >> >> function.Is that correct? >> >> >> >> >> >> If you were able to load and run JavaScript you probably did everything >> >> right. >> >> >> >> However, if you just want to play with Nashorn the simpler option may >> be >> >> to use an official JDK preview release from >> >> http://jdk8.java.net/download.html. You can use the following command >> to >> >> just get the Nashhorn sources: >> >> >> >> hg clone http://hg.openjdk.java.net/nashorn/jdk8/nashorn nashorn >> >> >> >> Hannes >> >> >> >> >> >> Thanks! >> >> On Fri, Feb 8, 2013 at 7:10 PM, Marcus Lagergren < >> marcus.lagergren at oracle.com> wrote: >> >> >> >> >> >> Can you tell us how you run it in JJS? >> >> >> >> For the best current Nashorn performance, any build over Java8 b74 >> should >> >> be used, as it contains significant fixes to the inlining in the JVM. >> >> You probably need to give any microbenchmark a few warmup rounds for >> >> performance to stabilize. If you only run one round, there will be too >> much >> >> noise and warmup issues for results to be meaningful. This is >> especially >> >> true with invoke dynamic based programs running on Java 8 now, as they >> >> tend to warm up slower than standard "Java" programs. >> >> >> >> Running with the octane test harness in the Nashorn repo (modified to >> >> provide multiple rounds for VM warmup) >> >> (after doing ant externals to get the benchmarks) >> >> >> >> java -jar dist/nashorn.jar test/script/basic/run-octane.js -- >> >> test/script/external/octane/crypto.js --iterations 10 --verbose >> >> >> >> I get ~2000 points on my machine, where Rhino gives me ~850 points. >> >> >> >> >> >> /M >> >> >> >> >> >> On Feb 8, 2013, at 2:29 PM, Harsha Kumara < >> harsz89 at gmail.com> wrote: >> >> >> >> >> >> Yeah the problem is i'm not quite sure whether I have configure the >> >> >> >> nashorn >> >> >> >> correctly.I had run crypto test in v8 bench mark test suit in jjs >> console >> >> it gives around 110ms to run the encryption operation where rhino just >> >> >> >> take >> >> >> >> around 31ms.My concern is how can I know whether I have correctly >> >> >> >> configure >> >> >> >> nashorn in my machine. >> >> Thanks! >> >> >> >> On Fri, Feb 8, 2013 at 6:52 PM, A. Sundararajan < >> sundararajan.athijegannathan at oracle.com> wrote: >> >> >> >> >> >> [Please reply to list as it will be record for similar queries from >> >> >> >> others >> >> >> >> as well] >> >> >> >> You said it is not as fast as rhino on your test. Is it possible to >> >> >> >> share >> >> >> >> your test or reduced version of it demonstrating performance issue? >> >> >> >> thanks >> >> -Sundar >> >> >> >> >> >> On Friday 08 February 2013 06:15 PM, Harsha Kumara wrote: >> >> >> >> >> >> Hi! >> >> >> >> I have pull jdk8 and build it.Then I build nashron after setting java >> >> home poiting to the jdk8.But ant build return with a javadoc error.I >> >> >> >> have >> >> >> >> the nashron jar which is build during the ant build.And I ran jjs >> >> executable with a some test it's not fast as rhino.I wonder whether I >> >> >> >> need >> >> >> >> to other configuration to get nashron into play? >> >> Thanks! >> >> >> >> On Fri, Feb 8, 2013 at 5:59 PM, A. Sundararajan >> > >> >> >> sundararajan.athijegannathan at oracle.com>> >> >> >> sundararajan.**athijegannathan at oracle.com< >> >> >> >> sundararajan.athijegannathan at oracle.com>>> >> >> >> >> wrote: >> >> >> >> Hi, >> >> >> >> Nashorn has not yet hit the openjdk8 main repo. You need to pull >> >> nashorn forest for now: >> >> >> >> http://hg.openjdk.java.net/**nashorn/jdk8< >> >> >> >> http://hg.openjdk.java.net/nashorn/jdk8> >> >> >> >> It'll be some time before nashorn hits main jdk8 repo. But, you >> >> can pull the above forest in the interim and build it. >> >> >> >> -Sundar >> >> >> >> >> >> On Friday 08 February 2013 02:07 PM, Harsha Kumara wrote: >> >> >> >> Hi! >> >> I had tried to run some performance tests.But results are not >> >> impressive >> >> than I thought.I have build openjdk8 and set JAVA_HOME to >> >> it.Then I have >> >> build nashron.But when I run the jrunscript -q it still show >> >> the rhino as >> >> underline javascript engine.Then how can I configure it to use >> >> nashron? >> >> Thanks! >> >> >> >> >> >> >> >> >> >> >> >> -- >> >> /Harsha Kumara/ >> >> /Undergraduate/ >> >> /Department of Computer Science and Engineering/ >> >> /University of Moratuwa/ >> >> /Sri Lanka./ >> >> >> >> >> >> -- >> >> *Harsha Kumara* >> >> *Undergraduate* >> >> *Department of Computer Science and Engineering* >> >> *University of Moratuwa* >> >> *Sri Lanka.* >> >> >> >> >> >> >> > >> > >> > -- >> > *Harsha Kumara* >> > *Undergraduate* >> > *Department of Computer Science and Engineering* >> > *University of Moratuwa* >> > *Sri Lanka.* >> >> > > > -- > *Harsha Kumara* > *Undergraduate* > *Department of Computer Science and Engineering* > *University of Moratuwa* > *Sri Lanka.* > -- *Harsha Kumara* *Undergraduate* *Department of Computer Science and Engineering* *University of Moratuwa* *Sri Lanka.* From sundararajan.athijegannathan at oracle.com Fri Feb 8 21:18:35 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Sat, 09 Feb 2013 10:48:35 +0530 Subject: Get nashron work in opnjdk8 In-Reply-To: References: <5114EF96.6040101@oracle.com> <5114FC00.6060608@oracle.com> <51150C2E.108@oracle.com> <5611DF55-3283-4B10-AA64-9517410B2A21@oracle.com> Message-ID: <5115DC2B.6030307@oracle.com> Hi, I am not sure I understand your sense of what "best javascript engine" is. What is the comparison that you are interested? What kind of application load you'd expect? Pure javascript number cruching and object/array manipulation only? You mentioned server-side project. I am sure your project would involve libraries (network, xml, database , webservices etc.). It may not be appropriate to decide just based on micro-benchmark numbers alone. For Java, apart from JDK itself, there are tons of libraries to deal with server side requirements. If it is the choice b/w rhino and nashorn, then you've similar java access (you can access any Java package from both, implement interfaces, extend classes and son). Nashorn is always compiled/jsr292 based. Rhino has interpreted mode as well as "optimizer" mode. From our measurements, nashorn performs better than rhino on many v8 benchmarks ( which are pure JS number crunching, object/array manipulations etc.) Also, because nashorn always compiles and java library calls are not based on reflection - instead it uses dynalink library. Essentially method handles to Java classes - which should perform better in long running scripts. We don't (yet) have perf. comparison of java access. As Marcus already pointed out, unless you do proper "warm up", you'll get misleading numbers with Java programs - not just nashorn. Hope this helps, -Sundar On Saturday 09 February 2013 10:10 AM, Harsha Kumara wrote: > I have downloaded the jdk8 build 75 which is available in the java.net and > run tests separately.Still I got rhino perform well than nashorn.Is > something I doing wrong here?Or is there anyway to set performance > parameters for nashorn?Because for our final year university project,we > need to find the currently available best java script engine.Since we > working on server side java scripting project.We found that V8 perform well > than rhino.After do some research we got to know that nashorn will become a > pretty handy java script engine.So if nashorn is better our project on V8 > not will much usable.Is there a place which we can have test results where > we can compare v8,rhino,nashorn. > Thanks! > On Fri, Feb 8, 2013 at 9:52 PM, Harsha Kumara wrote: > >> Thanks for the presentations resources.I downloaded latest rhino version >> and load crypto file into the rhino and nashorn seperately and run the >> encrypt method. >> In rhino when i repeatedly run the encrypt method in the consolde I got >> this results >> >> js> encrypt(); >> 54 >> js> encrypt(); >> 33 >> js> encrypt(); >> 27 >> js> encrypt(); >> 46 >> js> encrypt(); >> 28 >> js> encrypt(); >> 25 >> js> encrypt(); >> 35 >> js> encrypt(); >> 28 >> js> encrypt(); >> 27 >> js> encrypt(); >> 23 >> js> encrypt(); >> 26 >> js> encrypt(); >> 17 >> js> encrypt(); >> 24 >> js> encrypt(); >> 23 >> js> encrypt(); >> 26 >> >> And when I run it in the nashorn >> >> jjs> encrypt(); >> 153 >> jjs> encrypt(); >> 125 >> jjs> encrypt(); >> 118 >> jjs> encrypt(); >> 114 >> jjs> encrypt(); >> 139 >> jjs> encrypt(); >> 53 >> jjs> encrypt(); >> 51 >> jjs> encrypt(); >> 56 >> jjs> encrypt(); >> 49 >> jjs> encrypt(); >> 49 >> jjs> encrypt(); >> 47 >> jjs> encrypt(); >> 72 >> jjs> encrypt(); >> 46 >> jjs> encrypt(); >> 36 >> jjs> encrypt(); >> 25 >> jjs> encrypt(); >> 27 >> jjs> encrypt(); >> 36 >> jjs> encrypt(); >> 31 >> jjs> encrypt(); >> 26 >> jjs> encrypt(); >> 25 >> jjs> encrypt(); >> 24 >> jjs> encrypt(); >> 25 >> jjs> encrypt(); >> 33 >> jjs> encrypt(); >> 40 >> jjs> encrypt(); >> 27 >> jjs> encrypt(); >> 27 >> jjs> encrypt(); >> 26 >> jjs> encrypt(); >> 103 >> jjs> encrypt(); >> 134 >> jjs> encrypt(); >> 40 >> jjs> encrypt(); >> 23 >> jjs> encrypt(); >> 26 >> jjs> encrypt(); >> 27 >> jjs> encrypt(); >> 26 >> jjs> encrypt(); >> 28 >> jjs> encrypt(); >> 24 >> >> I have got this variate results.I have attach the crypto file.Any idea is >> this why this varying? >> >> On Fri, Feb 8, 2013 at 9:15 PM, Marcus Lagergren < >> marcus.lagergren at oracle.com> wrote: >> >>> Actually, Nashorn currently beats v8 on the splay benchmark in the Octane >>> suite, but for pure number crunching tests like crypto we are still behind, >>> as we don't have the luxury of our own native value representation - >>> producing strongly typed Java byte code is rather high level for a runtime. >>> We have several tricks up our sleeve though, both on the JVM side and in >>> Nashorn itself, so this gap is expected to get smaller. >>> >>> If you want to know more about how to implement dynamic languages on the >>> JVM and get some performance out of it, I did a presentation at Devoxx last >>> November that is freely available online. >>> http://www.devoxx.com/display/DV12/Nashorn++Optimizing+JavaScript+and+Dynamic+Language+Execution+on+the+JVM >>> >>> Regards >>> Marcus >>> >>> On Feb 8, 2013, at 4:04 PM, Harsha Kumara wrote: >>> >>>> Yeap.I have build the nashron by checkout it.I'll run tests again >>> compare >>>> with rhino.I went through some articles and some of articles express >>> that >>>> nashorn is faster and perform well than v8 java script engine.But the >>>> performance of the v8 is still higher than the nashorn I guess.I did >>> some >>>> bechmark test with v8 and nashorn.So far v8 perform well.Am I >>> correct?are >>>> there a any ways to tune nashorn to perform faster? >>>> >>>> On Fri, Feb 8, 2013 at 8:01 PM, Hannes Wallnoefer < >>>> hannes.wallnoefer at oracle.com> wrote: >>>> >>>>> Am 2013-02-08 15:00, schrieb Harsha Kumara: >>>>> >>>>> I have locally build openjdk8 forest.Then I set java home to jdk8 >>> which was >>>>> build from my local build.I think the way i ran jjs is not >>> correct.Using >>>>> consoe I ran ./jjs then I got the console.Afterthat I manually load >>>>> javascript file using load function (ed:load("foo.js")) and call the >>>>> function.Is that correct? >>>>> >>>>> >>>>> If you were able to load and run JavaScript you probably did everything >>>>> right. >>>>> >>>>> However, if you just want to play with Nashorn the simpler option may >>> be >>>>> to use an official JDK preview release from >>>>> http://jdk8.java.net/download.html. You can use the following command >>> to >>>>> just get the Nashhorn sources: >>>>> >>>>> hg clone http://hg.openjdk.java.net/nashorn/jdk8/nashorn nashorn >>>>> >>>>> Hannes >>>>> >>>>> >>>>> Thanks! >>>>> On Fri, Feb 8, 2013 at 7:10 PM, Marcus Lagergren < >>> marcus.lagergren at oracle.com> wrote: >>>>> >>>>> Can you tell us how you run it in JJS? >>>>> >>>>> For the best current Nashorn performance, any build over Java8 b74 >>> should >>>>> be used, as it contains significant fixes to the inlining in the JVM. >>>>> You probably need to give any microbenchmark a few warmup rounds for >>>>> performance to stabilize. If you only run one round, there will be too >>> much >>>>> noise and warmup issues for results to be meaningful. This is >>> especially >>>>> true with invoke dynamic based programs running on Java 8 now, as they >>>>> tend to warm up slower than standard "Java" programs. >>>>> >>>>> Running with the octane test harness in the Nashorn repo (modified to >>>>> provide multiple rounds for VM warmup) >>>>> (after doing ant externals to get the benchmarks) >>>>> >>>>> java -jar dist/nashorn.jar test/script/basic/run-octane.js -- >>>>> test/script/external/octane/crypto.js --iterations 10 --verbose >>>>> >>>>> I get ~2000 points on my machine, where Rhino gives me ~850 points. >>>>> >>>>> >>>>> /M >>>>> >>>>> >>>>> On Feb 8, 2013, at 2:29 PM, Harsha Kumara < >>> harsz89 at gmail.com> wrote: >>>>> >>>>> Yeah the problem is i'm not quite sure whether I have configure the >>>>> >>>>> nashorn >>>>> >>>>> correctly.I had run crypto test in v8 bench mark test suit in jjs >>> console >>>>> it gives around 110ms to run the encryption operation where rhino just >>>>> >>>>> take >>>>> >>>>> around 31ms.My concern is how can I know whether I have correctly >>>>> >>>>> configure >>>>> >>>>> nashorn in my machine. >>>>> Thanks! >>>>> >>>>> On Fri, Feb 8, 2013 at 6:52 PM, A. Sundararajan < >>> sundararajan.athijegannathan at oracle.com> wrote: >>>>> >>>>> [Please reply to list as it will be record for similar queries from >>>>> >>>>> others >>>>> >>>>> as well] >>>>> >>>>> You said it is not as fast as rhino on your test. Is it possible to >>>>> >>>>> share >>>>> >>>>> your test or reduced version of it demonstrating performance issue? >>>>> >>>>> thanks >>>>> -Sundar >>>>> >>>>> >>>>> On Friday 08 February 2013 06:15 PM, Harsha Kumara wrote: >>>>> >>>>> >>>>> Hi! >>>>> >>>>> I have pull jdk8 and build it.Then I build nashron after setting java >>>>> home poiting to the jdk8.But ant build return with a javadoc error.I >>>>> >>>>> have >>>>> >>>>> the nashron jar which is build during the ant build.And I ran jjs >>>>> executable with a some test it's not fast as rhino.I wonder whether I >>>>> >>>>> need >>>>> >>>>> to other configuration to get nashron into play? >>>>> Thanks! >>>>> >>>>> On Fri, Feb 8, 2013 at 5:59 PM, A. Sundararajan >>> >>>> sundararajan.athijegannathan at oracle.com>>>>> >>>>> sundararajan.**athijegannathan at oracle.com< >>>>> >>>>> sundararajan.athijegannathan at oracle.com>>> >>>>> >>>>> wrote: >>>>> >>>>> Hi, >>>>> >>>>> Nashorn has not yet hit the openjdk8 main repo. You need to pull >>>>> nashorn forest for now: >>>>> >>>>> http://hg.openjdk.java.net/**nashorn/jdk8< >>>>> >>>>> http://hg.openjdk.java.net/nashorn/jdk8> >>>>> >>>>> It'll be some time before nashorn hits main jdk8 repo. But, you >>>>> can pull the above forest in the interim and build it. >>>>> >>>>> -Sundar >>>>> >>>>> >>>>> On Friday 08 February 2013 02:07 PM, Harsha Kumara wrote: >>>>> >>>>> Hi! >>>>> I had tried to run some performance tests.But results are not >>>>> impressive >>>>> than I thought.I have build openjdk8 and set JAVA_HOME to >>>>> it.Then I have >>>>> build nashron.But when I run the jrunscript -q it still show >>>>> the rhino as >>>>> underline javascript engine.Then how can I configure it to use >>>>> nashron? >>>>> Thanks! >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> /Harsha Kumara/ >>>>> /Undergraduate/ >>>>> /Department of Computer Science and Engineering/ >>>>> /University of Moratuwa/ >>>>> /Sri Lanka./ >>>>> >>>>> >>>>> -- >>>>> *Harsha Kumara* >>>>> *Undergraduate* >>>>> *Department of Computer Science and Engineering* >>>>> *University of Moratuwa* >>>>> *Sri Lanka.* >>>>> >>>>> >>>>> >>>> >>>> -- >>>> *Harsha Kumara* >>>> *Undergraduate* >>>> *Department of Computer Science and Engineering* >>>> *University of Moratuwa* >>>> *Sri Lanka.* >>> >> >> -- >> *Harsha Kumara* >> *Undergraduate* >> *Department of Computer Science and Engineering* >> *University of Moratuwa* >> *Sri Lanka.* >> > > From harsz89 at gmail.com Fri Feb 8 22:23:58 2013 From: harsz89 at gmail.com (Harsha Kumara) Date: Sat, 9 Feb 2013 11:53:58 +0530 Subject: Get nashron work in opnjdk8 In-Reply-To: <5115DC2B.6030307@oracle.com> References: <5114EF96.6040101@oracle.com> <5114FC00.6060608@oracle.com> <51150C2E.108@oracle.com> <5611DF55-3283-4B10-AA64-9517410B2A21@oracle.com> <5115DC2B.6030307@oracle.com> Message-ID: Thank you very much for the detailed description.It opens many areas to think about when selecting a java script engine.There is existing project called jaggary [0] which is written above the rhino java script engine.It allows developers to write web application using pure java script.But the low performance of Rhino make us to write jaggary framework using separate java script engine.Our one of major target is to embed jaggary in a small devices like android mobile or Raspberry PI machine.To achieve our goals we need to select java script engine which support these functionality.Since nashorn expose a api similar to Rhino and support with embedding will make us our work much easier and need to consider twice about doing the project.We have done some performance comparisons using existing java-script test frameworks and it gives us V8 perform well in many cases.We will look into what needs most in jaggary.Thanks heaps for the help. [0]-*jaggeryjs*.org/ On Sat, Feb 9, 2013 at 10:48 AM, A. Sundararajan < sundararajan.athijegannathan at oracle.com> wrote: > Hi > > I am not sure I understand your sense of what "best javascript engine" is. > What is the comparison that you are interested? What kind of application > load you'd expect? Pure javascript number cruching and object/array > manipulation only? You mentioned server-side project. I am sure your > project would involve libraries (network, xml, database , webservices > etc.). It may not be appropriate to decide just based on micro-benchmark > numbers alone. For Java, apart from JDK itself, there are tons of libraries > to deal with server side requirements. > > If it is the choice b/w rhino and nashorn, then you've similar java access > (you can access any Java package from both, implement interfaces, extend > classes and son). Nashorn is always compiled/jsr292 based. Rhino has > interpreted mode as well as "optimizer" mode. From our measurements, > nashorn performs better than rhino on many v8 benchmarks ( which are pure > JS number crunching, object/array manipulations etc.) > > Also, because nashorn always compiles and java library calls are not based > on reflection - instead it uses dynalink library. Essentially method > handles to Java classes - which should perform better in long running > scripts. We don't (yet) have perf. comparison of java access. As Marcus > already pointed out, unless you do proper "warm up", you'll get misleading > numbers with Java programs - not just nashorn. > > Hope this helps, > -Sundar > > > > On Saturday 09 February 2013 10:10 AM, Harsha Kumara wrote: > >> I have downloaded the jdk8 build 75 which is available in the java.netand >> run tests separately.Still I got rhino perform well than nashorn.Is >> something I doing wrong here?Or is there anyway to set performance >> parameters for nashorn?Because for our final year university project,we >> need to find the currently available best java script engine.Since we >> working on server side java scripting project.We found that V8 perform >> well >> than rhino.After do some research we got to know that nashorn will become >> a >> pretty handy java script engine.So if nashorn is better our project on V8 >> not will much usable.Is there a place which we can have test results where >> we can compare v8,rhino,nashorn. >> Thanks! >> On Fri, Feb 8, 2013 at 9:52 PM, Harsha Kumara wrote: >> >> Thanks for the presentations resources.I downloaded latest rhino version >>> and load crypto file into the rhino and nashorn seperately and run the >>> encrypt method. >>> In rhino when i repeatedly run the encrypt method in the consolde I got >>> this results >>> >>> js> encrypt(); >>> 54 >>> js> encrypt(); >>> 33 >>> js> encrypt(); >>> 27 >>> js> encrypt(); >>> 46 >>> js> encrypt(); >>> 28 >>> js> encrypt(); >>> 25 >>> js> encrypt(); >>> 35 >>> js> encrypt(); >>> 28 >>> js> encrypt(); >>> 27 >>> js> encrypt(); >>> 23 >>> js> encrypt(); >>> 26 >>> js> encrypt(); >>> 17 >>> js> encrypt(); >>> 24 >>> js> encrypt(); >>> 23 >>> js> encrypt(); >>> 26 >>> >>> And when I run it in the nashorn >>> >>> jjs> encrypt(); >>> 153 >>> jjs> encrypt(); >>> 125 >>> jjs> encrypt(); >>> 118 >>> jjs> encrypt(); >>> 114 >>> jjs> encrypt(); >>> 139 >>> jjs> encrypt(); >>> 53 >>> jjs> encrypt(); >>> 51 >>> jjs> encrypt(); >>> 56 >>> jjs> encrypt(); >>> 49 >>> jjs> encrypt(); >>> 49 >>> jjs> encrypt(); >>> 47 >>> jjs> encrypt(); >>> 72 >>> jjs> encrypt(); >>> 46 >>> jjs> encrypt(); >>> 36 >>> jjs> encrypt(); >>> 25 >>> jjs> encrypt(); >>> 27 >>> jjs> encrypt(); >>> 36 >>> jjs> encrypt(); >>> 31 >>> jjs> encrypt(); >>> 26 >>> jjs> encrypt(); >>> 25 >>> jjs> encrypt(); >>> 24 >>> jjs> encrypt(); >>> 25 >>> jjs> encrypt(); >>> 33 >>> jjs> encrypt(); >>> 40 >>> jjs> encrypt(); >>> 27 >>> jjs> encrypt(); >>> 27 >>> jjs> encrypt(); >>> 26 >>> jjs> encrypt(); >>> 103 >>> jjs> encrypt(); >>> 134 >>> jjs> encrypt(); >>> 40 >>> jjs> encrypt(); >>> 23 >>> jjs> encrypt(); >>> 26 >>> jjs> encrypt(); >>> 27 >>> jjs> encrypt(); >>> 26 >>> jjs> encrypt(); >>> 28 >>> jjs> encrypt(); >>> 24 >>> >>> I have got this variate results.I have attach the crypto file.Any idea is >>> this why this varying? >>> >>> On Fri, Feb 8, 2013 at 9:15 PM, Marcus Lagergren < >>> marcus.lagergren at oracle.com> wrote: >>> >>> Actually, Nashorn currently beats v8 on the splay benchmark in the >>>> Octane >>>> suite, but for pure number crunching tests like crypto we are still >>>> behind, >>>> as we don't have the luxury of our own native value representation - >>>> producing strongly typed Java byte code is rather high level for a >>>> runtime. >>>> We have several tricks up our sleeve though, both on the JVM side and in >>>> Nashorn itself, so this gap is expected to get smaller. >>>> >>>> If you want to know more about how to implement dynamic languages on the >>>> JVM and get some performance out of it, I did a presentation at Devoxx >>>> last >>>> November that is freely available online. >>>> http://www.devoxx.com/display/**DV12/Nashorn++Optimizing+** >>>> JavaScript+and+Dynamic+**Language+Execution+on+the+JVM >>>> >>>> Regards >>>> Marcus >>>> >>>> On Feb 8, 2013, at 4:04 PM, Harsha Kumara wrote: >>>> >>>> Yeap.I have build the nashron by checkout it.I'll run tests again >>>>> >>>> compare >>>> >>>>> with rhino.I went through some articles and some of articles express >>>>> >>>> that >>>> >>>>> nashorn is faster and perform well than v8 java script engine.But the >>>>> performance of the v8 is still higher than the nashorn I guess.I did >>>>> >>>> some >>>> >>>>> bechmark test with v8 and nashorn.So far v8 perform well.Am I >>>>> >>>> correct?are >>>> >>>>> there a any ways to tune nashorn to perform faster? >>>>> >>>>> On Fri, Feb 8, 2013 at 8:01 PM, Hannes Wallnoefer < >>>>> hannes.wallnoefer at oracle.com> wrote: >>>>> >>>>> Am 2013-02-08 15:00, schrieb Harsha Kumara: >>>>>> >>>>>> I have locally build openjdk8 forest.Then I set java home to jdk8 >>>>>> >>>>> which was >>>> >>>>> build from my local build.I think the way i ran jjs is not >>>>>> >>>>> correct.Using >>>> >>>>> consoe I ran ./jjs then I got the console.Afterthat I manually load >>>>>> javascript file using load function (ed:load("foo.js")) and call the >>>>>> function.Is that correct? >>>>>> >>>>>> >>>>>> If you were able to load and run JavaScript you probably did >>>>>> everything >>>>>> right. >>>>>> >>>>>> However, if you just want to play with Nashorn the simpler option may >>>>>> >>>>> be >>>> >>>>> to use an official JDK preview release from >>>>>> http://jdk8.java.net/download.**html. >>>>>> You can use the following command >>>>>> >>>>> to >>>> >>>>> just get the Nashhorn sources: >>>>>> >>>>>> hg clone http://hg.openjdk.java.net/**nashorn/jdk8/nashornnashorn >>>>>> >>>>>> Hannes >>>>>> >>>>>> >>>>>> Thanks! >>>>>> On Fri, Feb 8, 2013 at 7:10 PM, Marcus Lagergren < >>>>>> >>>>> marcus.lagergren at oracle.com> wrote: >>>> >>>>> >>>>>> Can you tell us how you run it in JJS? >>>>>> >>>>>> For the best current Nashorn performance, any build over Java8 b74 >>>>>> >>>>> should >>>> >>>>> be used, as it contains significant fixes to the inlining in the JVM. >>>>>> You probably need to give any microbenchmark a few warmup rounds for >>>>>> performance to stabilize. If you only run one round, there will be too >>>>>> >>>>> much >>>> >>>>> noise and warmup issues for results to be meaningful. This is >>>>>> >>>>> especially >>>> >>>>> true with invoke dynamic based programs running on Java 8 now, as they >>>>>> tend to warm up slower than standard "Java" programs. >>>>>> >>>>>> Running with the octane test harness in the Nashorn repo (modified to >>>>>> provide multiple rounds for VM warmup) >>>>>> (after doing ant externals to get the benchmarks) >>>>>> >>>>>> java -jar dist/nashorn.jar test/script/basic/run-octane.**js -- >>>>>> test/script/external/octane/**crypto.js --iterations 10 --verbose >>>>>> >>>>>> I get ~2000 points on my machine, where Rhino gives me ~850 points. >>>>>> >>>>>> >>>>>> /M >>>>>> >>>>>> >>>>>> On Feb 8, 2013, at 2:29 PM, Harsha Kumara < >>>>>> >>>>> harsz89 at gmail.com> wrote: >>>> >>>>> >>>>>> Yeah the problem is i'm not quite sure whether I have configure the >>>>>> >>>>>> nashorn >>>>>> >>>>>> correctly.I had run crypto test in v8 bench mark test suit in jjs >>>>>> >>>>> console >>>> >>>>> it gives around 110ms to run the encryption operation where rhino just >>>>>> >>>>>> take >>>>>> >>>>>> around 31ms.My concern is how can I know whether I have correctly >>>>>> >>>>>> configure >>>>>> >>>>>> nashorn in my machine. >>>>>> Thanks! >>>>>> >>>>>> On Fri, Feb 8, 2013 at 6:52 PM, A. Sundararajan < >>>>>> >>>>> sundararajan.athijegannathan@**oracle.com> >>>> wrote: >>>> >>>>> >>>>>> [Please reply to list as it will be record for similar queries from >>>>>> >>>>>> others >>>>>> >>>>>> as well] >>>>>> >>>>>> You said it is not as fast as rhino on your test. Is it possible to >>>>>> >>>>>> share >>>>>> >>>>>> your test or reduced version of it demonstrating performance issue? >>>>>> >>>>>> thanks >>>>>> -Sundar >>>>>> >>>>>> >>>>>> On Friday 08 February 2013 06:15 PM, Harsha Kumara wrote: >>>>>> >>>>>> >>>>>> Hi! >>>>>> >>>>>> I have pull jdk8 and build it.Then I build nashron after setting java >>>>>> home poiting to the jdk8.But ant build return with a javadoc error.I >>>>>> >>>>>> have >>>>>> >>>>>> the nashron jar which is build during the ant build.And I ran jjs >>>>>> executable with a some test it's not fast as rhino.I wonder whether I >>>>>> >>>>>> need >>>>>> >>>>>> to other configuration to get nashron into play? >>>>>> Thanks! >>>>>> >>>>>> On Fri, Feb 8, 2013 at 5:59 PM, A. Sundararajan >>>>>> >>>>> >>> >>>>> sundararajan.athijegannathan@**oracle.com >>>>>> >>>>>> >>>>>> sundararajan.**athijegannathan**@oracle.com >>>>>> < >>>>>> >>>>>> sundararajan.athijegannathan@**oracle.com >>>>>> >>> >>>>>> >>>>>> wrote: >>>>>> >>>>>> Hi, >>>>>> >>>>>> Nashorn has not yet hit the openjdk8 main repo. You need to pull >>>>>> nashorn forest for now: >>>>>> >>>>>> http://hg.openjdk.java.net/****nashorn/jdk8 >>>>>> < >>>>>> >>>>>> http://hg.openjdk.java.net/**nashorn/jdk8 >>>>>> > >>>>>> >>>>>> It'll be some time before nashorn hits main jdk8 repo. But, you >>>>>> can pull the above forest in the interim and build it. >>>>>> >>>>>> -Sundar >>>>>> >>>>>> >>>>>> On Friday 08 February 2013 02:07 PM, Harsha Kumara wrote: >>>>>> >>>>>> Hi! >>>>>> I had tried to run some performance tests.But results are not >>>>>> impressive >>>>>> than I thought.I have build openjdk8 and set JAVA_HOME to >>>>>> it.Then I have >>>>>> build nashron.But when I run the jrunscript -q it still show >>>>>> the rhino as >>>>>> underline javascript engine.Then how can I configure it to use >>>>>> nashron? >>>>>> Thanks! >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> /Harsha Kumara/ >>>>>> /Undergraduate/ >>>>>> /Department of Computer Science and Engineering/ >>>>>> /University of Moratuwa/ >>>>>> /Sri Lanka./ >>>>>> >>>>>> >>>>>> -- >>>>>> *Harsha Kumara* >>>>>> *Undergraduate* >>>>>> *Department of Computer Science and Engineering* >>>>>> *University of Moratuwa* >>>>>> *Sri Lanka.* >>>>>> >>>>>> >>>>>> >>>>>> >>>>> -- >>>>> *Harsha Kumara* >>>>> *Undergraduate* >>>>> *Department of Computer Science and Engineering* >>>>> *University of Moratuwa* >>>>> *Sri Lanka.* >>>>> >>>> >>>> >>> -- >>> *Harsha Kumara* >>> *Undergraduate* >>> *Department of Computer Science and Engineering* >>> *University of Moratuwa* >>> *Sri Lanka.* >>> >>> >> >> > -- *Harsha Kumara* *Undergraduate* *Department of Computer Science and Engineering* *University of Moratuwa* *Sri Lanka.* From newair007 at gmail.com Fri Feb 8 22:26:45 2013 From: newair007 at gmail.com (AMILA RANATUNGA) Date: Sat, 9 Feb 2013 11:56:45 +0530 Subject: Get nashron work in opnjdk8 In-Reply-To: References: <5114EF96.6040101@oracle.com> <5114FC00.6060608@oracle.com> <51150C2E.108@oracle.com> <5611DF55-3283-4B10-AA64-9517410B2A21@oracle.com> <5115DC2B.6030307@oracle.com> Message-ID: Hi, Thanks a lot for the replies so far. I am also working on that project. It was server side scripting with javascript previously implemented on top of Rhino, using its host objects. Now we are considering increasing its performance. Since both Rhino and Nashorn has similar java access and using Nashorn rather than v8 will give us much more advantages . We also have a requirement of enable that server in embedded devices. Yes it might not be worth to decide just on micro benchmark numbers. But there is a requirement of doing such a comparison. What benchmark suits would you recommend to measure Nashorn performance with v8 other than v8 benchmark ?. Thanks ..!! On Sat, Feb 9, 2013 at 11:53 AM, Harsha Kumara wrote: > Thank you very much for the detailed description.It opens many areas to > think about when selecting a java script engine.There is existing project > called jaggary [0] which is written above the rhino java script engine.It > allows developers to write web application using pure java script.But the > low performance of Rhino make us to write jaggary framework > using separate java script engine.Our one of major target is to embed > jaggary in a small devices like android mobile or Raspberry PI > machine.To achieve our goals we need to select java script engine which > support these functionality.Since nashorn expose a api similar to Rhino and > support with embedding will make us our work much easier and need to > consider twice about doing the project.We have done some performance > comparisons using existing java-script test frameworks and it gives us V8 > perform well in many cases.We will look into what needs most in > jaggary.Thanks heaps for the help. > > [0]-*jaggeryjs*.org/ > > On Sat, Feb 9, 2013 at 10:48 AM, A. Sundararajan < > sundararajan.athijegannathan at oracle.com> wrote: > > > Hi > > > > I am not sure I understand your sense of what "best javascript engine" > is. > > What is the comparison that you are interested? What kind of application > > load you'd expect? Pure javascript number cruching and object/array > > manipulation only? You mentioned server-side project. I am sure your > > project would involve libraries (network, xml, database , webservices > > etc.). It may not be appropriate to decide just based on micro-benchmark > > numbers alone. For Java, apart from JDK itself, there are tons of > libraries > > to deal with server side requirements. > > > > If it is the choice b/w rhino and nashorn, then you've similar java > access > > (you can access any Java package from both, implement interfaces, extend > > classes and son). Nashorn is always compiled/jsr292 based. Rhino has > > interpreted mode as well as "optimizer" mode. From our measurements, > > nashorn performs better than rhino on many v8 benchmarks ( which are pure > > JS number crunching, object/array manipulations etc.) > > > > Also, because nashorn always compiles and java library calls are not > based > > on reflection - instead it uses dynalink library. Essentially method > > handles to Java classes - which should perform better in long running > > scripts. We don't (yet) have perf. comparison of java access. As Marcus > > already pointed out, unless you do proper "warm up", you'll get > misleading > > numbers with Java programs - not just nashorn. > > > > Hope this helps, > > -Sundar > > > > > > > > On Saturday 09 February 2013 10:10 AM, Harsha Kumara wrote: > > > >> I have downloaded the jdk8 build 75 which is available in the > java.netand > >> run tests separately.Still I got rhino perform well than nashorn.Is > >> something I doing wrong here?Or is there anyway to set performance > >> parameters for nashorn?Because for our final year university project,we > >> need to find the currently available best java script engine.Since we > >> working on server side java scripting project.We found that V8 perform > >> well > >> than rhino.After do some research we got to know that nashorn will > become > >> a > >> pretty handy java script engine.So if nashorn is better our project on > V8 > >> not will much usable.Is there a place which we can have test results > where > >> we can compare v8,rhino,nashorn. > >> Thanks! > >> On Fri, Feb 8, 2013 at 9:52 PM, Harsha Kumara > wrote: > >> > >> Thanks for the presentations resources.I downloaded latest rhino > version > >>> and load crypto file into the rhino and nashorn seperately and run the > >>> encrypt method. > >>> In rhino when i repeatedly run the encrypt method in the consolde I got > >>> this results > >>> > >>> js> encrypt(); > >>> 54 > >>> js> encrypt(); > >>> 33 > >>> js> encrypt(); > >>> 27 > >>> js> encrypt(); > >>> 46 > >>> js> encrypt(); > >>> 28 > >>> js> encrypt(); > >>> 25 > >>> js> encrypt(); > >>> 35 > >>> js> encrypt(); > >>> 28 > >>> js> encrypt(); > >>> 27 > >>> js> encrypt(); > >>> 23 > >>> js> encrypt(); > >>> 26 > >>> js> encrypt(); > >>> 17 > >>> js> encrypt(); > >>> 24 > >>> js> encrypt(); > >>> 23 > >>> js> encrypt(); > >>> 26 > >>> > >>> And when I run it in the nashorn > >>> > >>> jjs> encrypt(); > >>> 153 > >>> jjs> encrypt(); > >>> 125 > >>> jjs> encrypt(); > >>> 118 > >>> jjs> encrypt(); > >>> 114 > >>> jjs> encrypt(); > >>> 139 > >>> jjs> encrypt(); > >>> 53 > >>> jjs> encrypt(); > >>> 51 > >>> jjs> encrypt(); > >>> 56 > >>> jjs> encrypt(); > >>> 49 > >>> jjs> encrypt(); > >>> 49 > >>> jjs> encrypt(); > >>> 47 > >>> jjs> encrypt(); > >>> 72 > >>> jjs> encrypt(); > >>> 46 > >>> jjs> encrypt(); > >>> 36 > >>> jjs> encrypt(); > >>> 25 > >>> jjs> encrypt(); > >>> 27 > >>> jjs> encrypt(); > >>> 36 > >>> jjs> encrypt(); > >>> 31 > >>> jjs> encrypt(); > >>> 26 > >>> jjs> encrypt(); > >>> 25 > >>> jjs> encrypt(); > >>> 24 > >>> jjs> encrypt(); > >>> 25 > >>> jjs> encrypt(); > >>> 33 > >>> jjs> encrypt(); > >>> 40 > >>> jjs> encrypt(); > >>> 27 > >>> jjs> encrypt(); > >>> 27 > >>> jjs> encrypt(); > >>> 26 > >>> jjs> encrypt(); > >>> 103 > >>> jjs> encrypt(); > >>> 134 > >>> jjs> encrypt(); > >>> 40 > >>> jjs> encrypt(); > >>> 23 > >>> jjs> encrypt(); > >>> 26 > >>> jjs> encrypt(); > >>> 27 > >>> jjs> encrypt(); > >>> 26 > >>> jjs> encrypt(); > >>> 28 > >>> jjs> encrypt(); > >>> 24 > >>> > >>> I have got this variate results.I have attach the crypto file.Any idea > is > >>> this why this varying? > >>> > >>> On Fri, Feb 8, 2013 at 9:15 PM, Marcus Lagergren < > >>> marcus.lagergren at oracle.com> wrote: > >>> > >>> Actually, Nashorn currently beats v8 on the splay benchmark in the > >>>> Octane > >>>> suite, but for pure number crunching tests like crypto we are still > >>>> behind, > >>>> as we don't have the luxury of our own native value representation - > >>>> producing strongly typed Java byte code is rather high level for a > >>>> runtime. > >>>> We have several tricks up our sleeve though, both on the JVM side and > in > >>>> Nashorn itself, so this gap is expected to get smaller. > >>>> > >>>> If you want to know more about how to implement dynamic languages on > the > >>>> JVM and get some performance out of it, I did a presentation at Devoxx > >>>> last > >>>> November that is freely available online. > >>>> http://www.devoxx.com/display/**DV12/Nashorn++Optimizing+** > >>>> JavaScript+and+Dynamic+**Language+Execution+on+the+JVM< > http://www.devoxx.com/display/DV12/Nashorn++Optimizing+JavaScript+and+Dynamic+Language+Execution+on+the+JVM > > > >>>> > >>>> Regards > >>>> Marcus > >>>> > >>>> On Feb 8, 2013, at 4:04 PM, Harsha Kumara wrote: > >>>> > >>>> Yeap.I have build the nashron by checkout it.I'll run tests again > >>>>> > >>>> compare > >>>> > >>>>> with rhino.I went through some articles and some of articles express > >>>>> > >>>> that > >>>> > >>>>> nashorn is faster and perform well than v8 java script engine.But the > >>>>> performance of the v8 is still higher than the nashorn I guess.I did > >>>>> > >>>> some > >>>> > >>>>> bechmark test with v8 and nashorn.So far v8 perform well.Am I > >>>>> > >>>> correct?are > >>>> > >>>>> there a any ways to tune nashorn to perform faster? > >>>>> > >>>>> On Fri, Feb 8, 2013 at 8:01 PM, Hannes Wallnoefer < > >>>>> hannes.wallnoefer at oracle.com> wrote: > >>>>> > >>>>> Am 2013-02-08 15:00, schrieb Harsha Kumara: > >>>>>> > >>>>>> I have locally build openjdk8 forest.Then I set java home to jdk8 > >>>>>> > >>>>> which was > >>>> > >>>>> build from my local build.I think the way i ran jjs is not > >>>>>> > >>>>> correct.Using > >>>> > >>>>> consoe I ran ./jjs then I got the console.Afterthat I manually load > >>>>>> javascript file using load function (ed:load("foo.js")) and call the > >>>>>> function.Is that correct? > >>>>>> > >>>>>> > >>>>>> If you were able to load and run JavaScript you probably did > >>>>>> everything > >>>>>> right. > >>>>>> > >>>>>> However, if you just want to play with Nashorn the simpler option > may > >>>>>> > >>>>> be > >>>> > >>>>> to use an official JDK preview release from > >>>>>> http://jdk8.java.net/download.**html< > http://jdk8.java.net/download.html>. > >>>>>> You can use the following command > >>>>>> > >>>>> to > >>>> > >>>>> just get the Nashhorn sources: > >>>>>> > >>>>>> hg clone http://hg.openjdk.java.net/**nashorn/jdk8/nashorn< > http://hg.openjdk.java.net/nashorn/jdk8/nashorn>nashorn > >>>>>> > >>>>>> Hannes > >>>>>> > >>>>>> > >>>>>> Thanks! > >>>>>> On Fri, Feb 8, 2013 at 7:10 PM, Marcus Lagergren < > >>>>>> > >>>>> marcus.lagergren at oracle.com> wrote: > >>>> > >>>>> > >>>>>> Can you tell us how you run it in JJS? > >>>>>> > >>>>>> For the best current Nashorn performance, any build over Java8 b74 > >>>>>> > >>>>> should > >>>> > >>>>> be used, as it contains significant fixes to the inlining in the JVM. > >>>>>> You probably need to give any microbenchmark a few warmup rounds for > >>>>>> performance to stabilize. If you only run one round, there will be > too > >>>>>> > >>>>> much > >>>> > >>>>> noise and warmup issues for results to be meaningful. This is > >>>>>> > >>>>> especially > >>>> > >>>>> true with invoke dynamic based programs running on Java 8 now, as > they > >>>>>> tend to warm up slower than standard "Java" programs. > >>>>>> > >>>>>> Running with the octane test harness in the Nashorn repo (modified > to > >>>>>> provide multiple rounds for VM warmup) > >>>>>> (after doing ant externals to get the benchmarks) > >>>>>> > >>>>>> java -jar dist/nashorn.jar test/script/basic/run-octane.**js -- > >>>>>> test/script/external/octane/**crypto.js --iterations 10 --verbose > >>>>>> > >>>>>> I get ~2000 points on my machine, where Rhino gives me ~850 points. > >>>>>> > >>>>>> > >>>>>> /M > >>>>>> > >>>>>> > >>>>>> On Feb 8, 2013, at 2:29 PM, Harsha Kumara < > >>>>>> > >>>>> harsz89 at gmail.com> wrote: > >>>> > >>>>> > >>>>>> Yeah the problem is i'm not quite sure whether I have configure the > >>>>>> > >>>>>> nashorn > >>>>>> > >>>>>> correctly.I had run crypto test in v8 bench mark test suit in jjs > >>>>>> > >>>>> console > >>>> > >>>>> it gives around 110ms to run the encryption operation where rhino > just > >>>>>> > >>>>>> take > >>>>>> > >>>>>> around 31ms.My concern is how can I know whether I have correctly > >>>>>> > >>>>>> configure > >>>>>> > >>>>>> nashorn in my machine. > >>>>>> Thanks! > >>>>>> > >>>>>> On Fri, Feb 8, 2013 at 6:52 PM, A. Sundararajan < > >>>>>> > >>>>> sundararajan.athijegannathan@**oracle.com< > sundararajan.athijegannathan at oracle.com>> > >>>> wrote: > >>>> > >>>>> > >>>>>> [Please reply to list as it will be record for similar queries from > >>>>>> > >>>>>> others > >>>>>> > >>>>>> as well] > >>>>>> > >>>>>> You said it is not as fast as rhino on your test. Is it possible to > >>>>>> > >>>>>> share > >>>>>> > >>>>>> your test or reduced version of it demonstrating performance issue? > >>>>>> > >>>>>> thanks > >>>>>> -Sundar > >>>>>> > >>>>>> > >>>>>> On Friday 08 February 2013 06:15 PM, Harsha Kumara wrote: > >>>>>> > >>>>>> > >>>>>> Hi! > >>>>>> > >>>>>> I have pull jdk8 and build it.Then I build nashron after setting > java > >>>>>> home poiting to the jdk8.But ant build return with a javadoc error.I > >>>>>> > >>>>>> have > >>>>>> > >>>>>> the nashron jar which is build during the ant build.And I ran jjs > >>>>>> executable with a some test it's not fast as rhino.I wonder whether > I > >>>>>> > >>>>>> need > >>>>>> > >>>>>> to other configuration to get nashron into play? > >>>>>> Thanks! > >>>>>> > >>>>>> On Fri, Feb 8, 2013 at 5:59 PM, A. Sundararajan > >>>>>> > >>>>> >>>> > >>>>> sundararajan.athijegannathan@**oracle.com< > sundararajan.athijegannathan at oracle.com> > >>>>>> > >>>>>> > >>>>>> sundararajan.**athijegannathan**@oracle.com< > athijegannathan at oracle.com> > >>>>>> < > >>>>>> > >>>>>> sundararajan.athijegannathan@**oracle.com< > sundararajan.athijegannathan at oracle.com> > >>>>>> >>> > >>>>>> > >>>>>> wrote: > >>>>>> > >>>>>> Hi, > >>>>>> > >>>>>> Nashorn has not yet hit the openjdk8 main repo. You need to pull > >>>>>> nashorn forest for now: > >>>>>> > >>>>>> http://hg.openjdk.java.net/****nashorn/jdk8< > http://hg.openjdk.java.net/**nashorn/jdk8> > >>>>>> < > >>>>>> > >>>>>> http://hg.openjdk.java.net/**nashorn/jdk8< > http://hg.openjdk.java.net/nashorn/jdk8> > >>>>>> > > >>>>>> > >>>>>> It'll be some time before nashorn hits main jdk8 repo. But, you > >>>>>> can pull the above forest in the interim and build it. > >>>>>> > >>>>>> -Sundar > >>>>>> > >>>>>> > >>>>>> On Friday 08 February 2013 02:07 PM, Harsha Kumara wrote: > >>>>>> > >>>>>> Hi! > >>>>>> I had tried to run some performance tests.But results are not > >>>>>> impressive > >>>>>> than I thought.I have build openjdk8 and set JAVA_HOME to > >>>>>> it.Then I have > >>>>>> build nashron.But when I run the jrunscript -q it still show > >>>>>> the rhino as > >>>>>> underline javascript engine.Then how can I configure it to > use > >>>>>> nashron? > >>>>>> Thanks! > >>>>>> > >>>>>> > >>>>>> > >>>>>> > >>>>>> > >>>>>> -- > >>>>>> /Harsha Kumara/ > >>>>>> /Undergraduate/ > >>>>>> /Department of Computer Science and Engineering/ > >>>>>> /University of Moratuwa/ > >>>>>> /Sri Lanka./ > >>>>>> > >>>>>> > >>>>>> -- > >>>>>> *Harsha Kumara* > >>>>>> *Undergraduate* > >>>>>> *Department of Computer Science and Engineering* > >>>>>> *University of Moratuwa* > >>>>>> *Sri Lanka.* > >>>>>> > >>>>>> > >>>>>> > >>>>>> > >>>>> -- > >>>>> *Harsha Kumara* > >>>>> *Undergraduate* > >>>>> *Department of Computer Science and Engineering* > >>>>> *University of Moratuwa* > >>>>> *Sri Lanka.* > >>>>> > >>>> > >>>> > >>> -- > >>> *Harsha Kumara* > >>> *Undergraduate* > >>> *Department of Computer Science and Engineering* > >>> *University of Moratuwa* > >>> *Sri Lanka.* > >>> > >>> > >> > >> > > > > > -- > *Harsha Kumara* > *Undergraduate* > *Department of Computer Science and Engineering* > *University of Moratuwa* > *Sri Lanka.* > From attila.szegedi at oracle.com Sat Feb 9 04:07:07 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Sat, 9 Feb 2013 13:07:07 +0100 Subject: Review request for JDK-8006943 Message-ID: <8D96BB96-F65D-4D27-8709-E0A4683F357F@oracle.com> Please review JDK-8006943 at http://cr.openjdk.java.net/~attila/8006943/webrev.00 Thanks, Attila. From attila.szegedi at oracle.com Sat Feb 9 04:09:48 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Sat, 9 Feb 2013 13:09:48 +0100 Subject: Review request for JDK-8006943 Message-ID: Please review JDK-8006943 at http://cr.openjdk.java.net/~attila/8006943/webrev.00 Thanks, Attila. From james.laskey at oracle.com Sat Feb 9 05:09:25 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Sat, 9 Feb 2013 09:09:25 -0400 Subject: Review request for JDK-8006943 In-Reply-To: References: Message-ID: +1 On 2013-02-09, at 8:09 AM, Attila Szegedi wrote: > Please review JDK-8006943 at http://cr.openjdk.java.net/~attila/8006943/webrev.00 > > Thanks, > Attila. From marcus.lagergren at oracle.com Sat Feb 9 07:42:58 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Sat, 9 Feb 2013 16:42:58 +0100 Subject: Review request for JDK-8006943 In-Reply-To: References: Message-ID: +1 On Feb 9, 2013, at 1:09 PM, Attila Szegedi wrote: > Please review JDK-8006943 at http://cr.openjdk.java.net/~attila/8006943/webrev.00 > > Thanks, > Attila. From attila.szegedi at oracle.com Sat Feb 9 08:03:04 2013 From: attila.szegedi at oracle.com (attila.szegedi at oracle.com) Date: Sat, 09 Feb 2013 16:03:04 +0000 Subject: hg: nashorn/jdk8/nashorn: 8006943: Fix order of function method arguments to be (callee, thisObject) Message-ID: <20130209160306.9FBC04797A@hg.openjdk.java.net> Changeset: 5ead5333fa59 Author: attila Date: 2013-02-09 16:58 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/5ead5333fa59 8006943: Fix order of function method arguments to be (callee, thisObject) Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/CompilerConstants.java ! src/jdk/nashorn/internal/codegen/FunctionSignature.java ! src/jdk/nashorn/internal/codegen/MethodEmitter.java ! src/jdk/nashorn/internal/codegen/objects/ObjectClassGenerator.java ! src/jdk/nashorn/internal/codegen/types/ObjectType.java ! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/ScriptFunction.java ! src/jdk/nashorn/internal/runtime/ScriptFunctionData.java From sundararajan.athijegannathan at oracle.com Mon Feb 11 07:56:28 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Mon, 11 Feb 2013 15:56:28 +0000 Subject: hg: nashorn/jdk8/nashorn: 8007915: Nashorn IR, codegen, parser packages and Context instance should be inaccessible to user code Message-ID: <20130211155629.EBFB7479A5@hg.openjdk.java.net> Changeset: abea4ba28901 Author: sundar Date: 2013-02-11 21:26 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/abea4ba28901 8007915: Nashorn IR, codegen, parser packages and Context instance should be inaccessible to user code Reviewed-by: lagergren, jlaskey, attila ! bin/jjssecure ! bin/jjssecure.bat ! bin/nashornsecure ! bin/nashornsecure.bat ! make/Makefile ! make/build.xml + make/java.security.override ! make/project.properties ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/Compiler.java ! src/jdk/nashorn/internal/codegen/RuntimeCallSite.java ! src/jdk/nashorn/internal/ir/Symbol.java ! src/jdk/nashorn/internal/ir/debug/JSONWriter.java ! src/jdk/nashorn/internal/objects/AccessorPropertyDescriptor.java ! src/jdk/nashorn/internal/objects/DataPropertyDescriptor.java ! src/jdk/nashorn/internal/objects/GenericPropertyDescriptor.java ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/objects/NativeArray.java ! src/jdk/nashorn/internal/objects/NativeArrayBuffer.java ! src/jdk/nashorn/internal/objects/NativeDebug.java ! src/jdk/nashorn/internal/objects/NativeError.java ! src/jdk/nashorn/internal/objects/NativeEvalError.java ! src/jdk/nashorn/internal/objects/NativeFloat32Array.java ! src/jdk/nashorn/internal/objects/NativeFloat64Array.java ! src/jdk/nashorn/internal/objects/NativeFunction.java ! src/jdk/nashorn/internal/objects/NativeInt16Array.java ! src/jdk/nashorn/internal/objects/NativeInt32Array.java ! src/jdk/nashorn/internal/objects/NativeInt8Array.java ! src/jdk/nashorn/internal/objects/NativeJSAdapter.java ! src/jdk/nashorn/internal/objects/NativeJSON.java ! src/jdk/nashorn/internal/objects/NativeJava.java ! src/jdk/nashorn/internal/objects/NativeJavaImporter.java ! src/jdk/nashorn/internal/objects/NativeRangeError.java ! src/jdk/nashorn/internal/objects/NativeReferenceError.java ! src/jdk/nashorn/internal/objects/NativeRegExp.java ! src/jdk/nashorn/internal/objects/NativeRegExpExecResult.java ! src/jdk/nashorn/internal/objects/NativeString.java ! src/jdk/nashorn/internal/objects/NativeSyntaxError.java ! src/jdk/nashorn/internal/objects/NativeTypeError.java ! src/jdk/nashorn/internal/objects/NativeURIError.java ! src/jdk/nashorn/internal/objects/NativeUint16Array.java ! src/jdk/nashorn/internal/objects/NativeUint32Array.java ! src/jdk/nashorn/internal/objects/NativeUint8Array.java ! src/jdk/nashorn/internal/objects/NativeUint8ClampedArray.java ! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java ! src/jdk/nashorn/internal/parser/AbstractParser.java ! src/jdk/nashorn/internal/parser/Lexer.java - src/jdk/nashorn/internal/parser/RegExp.java - src/jdk/nashorn/internal/parser/RegExpScanner.java ! src/jdk/nashorn/internal/runtime/ArgumentSetter.java ! src/jdk/nashorn/internal/runtime/BitVector.java ! src/jdk/nashorn/internal/runtime/ConsString.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/Debug.java ! src/jdk/nashorn/internal/runtime/DebugLogger.java ! src/jdk/nashorn/internal/runtime/GlobalFunctions.java + src/jdk/nashorn/internal/runtime/JSONFunctions.java ! src/jdk/nashorn/internal/runtime/Logging.java ! src/jdk/nashorn/internal/runtime/NashornLoader.java ! src/jdk/nashorn/internal/runtime/NativeJavaPackage.java + src/jdk/nashorn/internal/runtime/RegExp.java + src/jdk/nashorn/internal/runtime/RegExpScanner.java ! src/jdk/nashorn/internal/runtime/ScriptFunction.java ! src/jdk/nashorn/internal/runtime/ScriptFunctionData.java ! src/jdk/nashorn/internal/runtime/ScriptLoader.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/ScriptRuntime.java ! src/jdk/nashorn/internal/runtime/ScriptingFunctions.java ! src/jdk/nashorn/internal/runtime/SetMethodCreator.java ! src/jdk/nashorn/internal/runtime/StructureLoader.java ! src/jdk/nashorn/internal/runtime/WithObject.java ! src/jdk/nashorn/internal/runtime/arrays/EmptyArrayLikeIterator.java ! src/jdk/nashorn/internal/runtime/arrays/MapIterator.java ! src/jdk/nashorn/internal/runtime/linker/Bootstrap.java ! src/jdk/nashorn/internal/runtime/resources/parser.js + test/script/sandbox/nashorninternals.js ! test/script/trusted/JDK-8006529.js + test/src/jdk/nashorn/api/javaaccess/BooleanAccessTest.java + test/src/jdk/nashorn/api/javaaccess/MethodAccessTest.java + test/src/jdk/nashorn/api/javaaccess/NumberAccessTest.java + test/src/jdk/nashorn/api/javaaccess/NumberBoxingTest.java + test/src/jdk/nashorn/api/javaaccess/ObjectAccessTest.java + test/src/jdk/nashorn/api/javaaccess/Person.java + test/src/jdk/nashorn/api/javaaccess/SharedObject.java + test/src/jdk/nashorn/api/javaaccess/StringAccessTest.java - test/src/jdk/nashorn/internal/access/BooleanAccessTest.java - test/src/jdk/nashorn/internal/access/MethodAccessTest.java - test/src/jdk/nashorn/internal/access/NumberAccessTest.java - test/src/jdk/nashorn/internal/access/NumberBoxingTest.java - test/src/jdk/nashorn/internal/access/ObjectAccessTest.java - test/src/jdk/nashorn/internal/access/Person.java - test/src/jdk/nashorn/internal/access/SharedObject.java - test/src/jdk/nashorn/internal/access/StringAccessTest.java - test/src/jdk/nashorn/internal/codegen/CompilerAccess.java From hannes.wallnoefer at oracle.com Tue Feb 12 02:51:13 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Tue, 12 Feb 2013 11:51:13 +0100 Subject: Review request for JDK-8007956 Message-ID: <511A1EA1.2050709@oracle.com> Please review webrev for JDK-8007956 - Wrong or obsolete system properties in docs/DEVELOPER_README: http://cr.openjdk.java.net/~hannesw/8007956/ Thanks, Hannes From attila.szegedi at oracle.com Tue Feb 12 03:42:12 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Tue, 12 Feb 2013 12:42:12 +0100 Subject: Review request for JDK-8007956 In-Reply-To: <511A1EA1.2050709@oracle.com> References: <511A1EA1.2050709@oracle.com> Message-ID: <88FA0072-0C3A-4070-932B-8FF63A150D2F@oracle.com> +1 On Feb 12, 2013, at 11:51 AM, Hannes Wallnoefer wrote: > Please review webrev for JDK-8007956 - Wrong or obsolete system properties in docs/DEVELOPER_README: > > http://cr.openjdk.java.net/~hannesw/8007956/ > > Thanks, > Hannes From james.laskey at oracle.com Tue Feb 12 04:04:35 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Tue, 12 Feb 2013 08:04:35 -0400 Subject: Review request for JDK-8007956 In-Reply-To: <511A1EA1.2050709@oracle.com> References: <511A1EA1.2050709@oracle.com> Message-ID: <0A21C848-3869-4181-879B-F2421F49F2A9@oracle.com> +1 On 2013-02-12, at 6:51 AM, Hannes Wallnoefer wrote: > Please review webrev for JDK-8007956 - Wrong or obsolete system properties in docs/DEVELOPER_README: > > http://cr.openjdk.java.net/~hannesw/8007956/ > > Thanks, > Hannes From hannes.wallnoefer at oracle.com Tue Feb 12 04:56:06 2013 From: hannes.wallnoefer at oracle.com (hannes.wallnoefer at oracle.com) Date: Tue, 12 Feb 2013 12:56:06 +0000 Subject: hg: nashorn/jdk8/nashorn: 8007956: Wrong or obsolete system properties in docs/DEVELOPER_README Message-ID: <20130212125607.818D5479D5@hg.openjdk.java.net> Changeset: 774a0f349cc0 Author: hannesw Date: 2013-02-12 13:55 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/774a0f349cc0 8007956: Wrong or obsolete system properties in docs/DEVELOPER_README Reviewed-by: attila, jlaskey ! docs/DEVELOPER_README From attila.szegedi at oracle.com Tue Feb 12 05:08:44 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Tue, 12 Feb 2013 14:08:44 +0100 Subject: Review request for JDK-8007900 Message-ID: Please review JDK-8007900 at http://cr.openjdk.java.net/~attila/8007900/webrev.00 Thanks, Attila. From james.laskey at oracle.com Tue Feb 12 05:17:55 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Tue, 12 Feb 2013 09:17:55 -0400 Subject: Review request for JDK-8007900 In-Reply-To: References: Message-ID: <93AE9587-542D-4CE8-B7B4-089923AFF0AF@oracle.com> +1 On 2013-02-12, at 9:08 AM, Attila Szegedi wrote: > Please review JDK-8007900 at http://cr.openjdk.java.net/~attila/8007900/webrev.00 > > Thanks, > Attila. From attila.szegedi at oracle.com Tue Feb 12 08:28:21 2013 From: attila.szegedi at oracle.com (attila.szegedi at oracle.com) Date: Tue, 12 Feb 2013 16:28:21 +0000 Subject: hg: nashorn/jdk8/nashorn: 8007900: Function binding is inefficient Message-ID: <20130212162822.DC182479DF@hg.openjdk.java.net> Changeset: d50e1752f59b Author: attila Date: 2013-02-12 12:47 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/d50e1752f59b 8007900: Function binding is inefficient Reviewed-by: jlaskey, lagergren + src/jdk/nashorn/internal/objects/BoundScriptFunctionImpl.java ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/objects/NativeStrictArguments.java ! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java ! src/jdk/nashorn/internal/runtime/ArgumentSetter.java ! src/jdk/nashorn/internal/runtime/PropertyMap.java ! src/jdk/nashorn/internal/runtime/ScriptFunction.java ! src/jdk/nashorn/internal/runtime/ScriptFunctionData.java ! src/jdk/nashorn/internal/runtime/ScriptRuntime.java + src/jdk/nashorn/internal/runtime/SpecializedMethodChooser.java + test/script/basic/funcbind2.js + test/script/basic/funcbind2.js.EXPECTED + test/script/basic/funcbind3.js + test/script/basic/funcbind3.js.EXPECTED From hannes.wallnoefer at oracle.com Wed Feb 13 03:49:20 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Wed, 13 Feb 2013 12:49:20 +0100 Subject: Review request for JDK-8008096 Message-ID: <511B7DC0.80607@oracle.com> Please review http://cr.openjdk.java.net/~hannesw/8008096/. This is a simple patch that helps reduce pdfjs.js parse time by about 200 ms on my machine, not much difference on other large scripts. Hannes From attila.szegedi at oracle.com Wed Feb 13 03:59:49 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Wed, 13 Feb 2013 12:59:49 +0100 Subject: Review request for JDK-8008096 In-Reply-To: <511B7DC0.80607@oracle.com> References: <511B7DC0.80607@oracle.com> Message-ID: +1 On Feb 13, 2013, at 12:49 PM, Hannes Wallnoefer wrote: > Please review http://cr.openjdk.java.net/~hannesw/8008096/. > > This is a simple patch that helps reduce pdfjs.js parse time by about 200 ms on my machine, not much difference on other large scripts. > > Hannes From sundararajan.athijegannathan at oracle.com Wed Feb 13 04:17:45 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Wed, 13 Feb 2013 17:47:45 +0530 Subject: Review request for JDK-8008096 In-Reply-To: References: <511B7DC0.80607@oracle.com> Message-ID: <511B8469.2040108@oracle.com> +1 On Wednesday 13 February 2013 05:29 PM, Attila Szegedi wrote: > +1 > > On Feb 13, 2013, at 12:49 PM, Hannes Wallnoefer wrote: > >> Please review http://cr.openjdk.java.net/~hannesw/8008096/. >> >> This is a simple patch that helps reduce pdfjs.js parse time by about 200 ms on my machine, not much difference on other large scripts. >> >> Hannes From marcus.lagergren at oracle.com Wed Feb 13 04:17:51 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Wed, 13 Feb 2013 13:17:51 +0100 Subject: Review request for JDK-8008096 In-Reply-To: <511B7DC0.80607@oracle.com> References: <511B7DC0.80607@oracle.com> Message-ID: <56EFDBCF-079F-46E9-A457-21EF356B68E8@oracle.com> +1 On Feb 13, 2013, at 12:49 PM, Hannes Wallnoefer wrote: > Please review http://cr.openjdk.java.net/~hannesw/8008096/. > > This is a simple patch that helps reduce pdfjs.js parse time by about 200 ms on my machine, not much difference on other large scripts. > > Hannes From hannes.wallnoefer at oracle.com Wed Feb 13 04:31:31 2013 From: hannes.wallnoefer at oracle.com (hannes.wallnoefer at oracle.com) Date: Wed, 13 Feb 2013 12:31:31 +0000 Subject: hg: nashorn/jdk8/nashorn: 8008096: TokenStream buffer should grow exponentially Message-ID: <20130213123132.8FDFA47A19@hg.openjdk.java.net> Changeset: a3dc1b180ce7 Author: hannesw Date: 2013-02-13 13:30 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/a3dc1b180ce7 8008096: TokenStream buffer should grow exponentially Reviewed-by: attila, lagergren, sundar ! src/jdk/nashorn/internal/parser/TokenStream.java From sundararajan.athijegannathan at oracle.com Wed Feb 13 05:54:59 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Wed, 13 Feb 2013 19:24:59 +0530 Subject: Review request JDK-8008103 : Source object should maintain URL of the script source as a private field Message-ID: <511B9B33.4060802@oracle.com> Please review http://cr.openjdk.java.net/~sundar/8008103/ Thanks -Sundar From james.laskey at oracle.com Wed Feb 13 05:59:13 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Wed, 13 Feb 2013 09:59:13 -0400 Subject: Review request JDK-8008103 : Source object should maintain URL of the script source as a private field In-Reply-To: <511B9B33.4060802@oracle.com> References: <511B9B33.4060802@oracle.com> Message-ID: <9A7AC8F0-D559-4A0C-9DE7-5E03EBA6249E@oracle.com> +1 On 2013-02-13, at 9:54 AM, "A. Sundararajan" wrote: > Please review http://cr.openjdk.java.net/~sundar/8008103/ > > Thanks > -Sundar From attila.szegedi at oracle.com Wed Feb 13 05:59:43 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Wed, 13 Feb 2013 14:59:43 +0100 Subject: Review request JDK-8008103 : Source object should maintain URL of the script source as a private field In-Reply-To: <511B9B33.4060802@oracle.com> References: <511B9B33.4060802@oracle.com> Message-ID: <4E4BDBA9-DF05-4BB6-BF71-71EE161C23A7@oracle.com> +1. On Feb 13, 2013, at 2:54 PM, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~sundar/8008103/ > > Thanks > -Sundar From sundararajan.athijegannathan at oracle.com Wed Feb 13 06:34:03 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Wed, 13 Feb 2013 14:34:03 +0000 Subject: hg: nashorn/jdk8/nashorn: 8008103: Source object should maintain URL of the script source as a private field Message-ID: <20130213143404.ACD3E47A1E@hg.openjdk.java.net> Changeset: 38c44687e4bd Author: sundar Date: 2013-02-13 19:59 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/38c44687e4bd 8008103: Source object should maintain URL of the script source as a private field Reviewed-by: lagergren, jlaskey ! src/jdk/nashorn/api/scripting/NashornScriptEngine.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/Source.java ! src/jdk/nashorn/tools/Shell.java ! test/src/jdk/nashorn/internal/codegen/CompilerTest.java ! test/src/jdk/nashorn/internal/runtime/ContextTest.java ! test/src/jdk/nashorn/internal/test/framework/SharedContextEvaluator.java From mark.reinhold at oracle.com Wed Feb 13 08:06:32 2013 From: mark.reinhold at oracle.com (mark.reinhold at oracle.com) Date: Wed, 13 Feb 2013 08:06:32 -0800 Subject: Review request JDK-8008103 : Source object should maintain URL of the script source as a private field In-Reply-To: sundararajan.athijegannathan@oracle.com; Wed, 13 Feb 2013 19:24:59 +0530; <511B9B33.4060802@oracle.com> Message-ID: <20130213160632.2AECAB0A@eggemoggin.niobe.net> 2013/2/13 5:54 -0800, sundararajan.athijegannathan at oracle.com: > Please review http://cr.openjdk.java.net/~sundar/8008103/ Just wondering ... is there a reason you're using java.net.URL rather than the (generally preferable) java.net.URI class? - Mark From sundararajan.athijegannathan at oracle.com Wed Feb 13 08:16:12 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Wed, 13 Feb 2013 21:46:12 +0530 Subject: Review request JDK-8008103 : Source object should maintain URL of the script source as a private field In-Reply-To: <20130213160632.2AECAB0A@eggemoggin.niobe.net> References: <20130213160632.2AECAB0A@eggemoggin.niobe.net> Message-ID: <511BBC4C.8050201@oracle.com> The URL of script Source object is subsequently used for the CodeSource for the compiled .class file - so that scripts are associated with the correct ProtectionDomains. -Sundar On Wednesday 13 February 2013 09:36 PM, mark.reinhold at oracle.com wrote: > 2013/2/13 5:54 -0800, sundararajan.athijegannathan at oracle.com: >> Please review http://cr.openjdk.java.net/~sundar/8008103/ > Just wondering ... is there a reason you're using java.net.URL rather > than the (generally preferable) java.net.URI class? > > - Mark From attila.szegedi at oracle.com Wed Feb 13 08:27:11 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Wed, 13 Feb 2013 17:27:11 +0100 Subject: Review request for JDK-8008085 Message-ID: <9A8D8BFD-212F-48E3-8C09-92DF59074C79@oracle.com> Please review JDK-8008085 at http://cr.openjdk.java.net/~attila/8008085/webrev.00 Thanks, Attila. From sundararajan.athijegannathan at oracle.com Wed Feb 13 08:45:31 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Wed, 13 Feb 2013 22:15:31 +0530 Subject: Review request for JDK-8008085 In-Reply-To: <9A8D8BFD-212F-48E3-8C09-92DF59074C79@oracle.com> References: <9A8D8BFD-212F-48E3-8C09-92DF59074C79@oracle.com> Message-ID: <511BC32B.7000101@oracle.com> import order is messed for dynalink imports. Other than that +1 from me. -Sundar On Wednesday 13 February 2013 09:57 PM, Attila Szegedi wrote: > Please review JDK-8008085 at http://cr.openjdk.java.net/~attila/8008085/webrev.00 > > Thanks, > Attila. From james.laskey at oracle.com Wed Feb 13 08:50:19 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Wed, 13 Feb 2013 12:50:19 -0400 Subject: Review request for JDK-8008085 In-Reply-To: <9A8D8BFD-212F-48E3-8C09-92DF59074C79@oracle.com> References: <9A8D8BFD-212F-48E3-8C09-92DF59074C79@oracle.com> Message-ID: +1 If import and copyright fixes (THIRD_PARTY_README) are included. On 2013-02-13, at 12:27 PM, Attila Szegedi wrote: > Please review JDK-8008085 at http://cr.openjdk.java.net/~attila/8008085/webrev.00 > > Thanks, > Attila. From marcus.lagergren at oracle.com Wed Feb 13 09:30:04 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Wed, 13 Feb 2013 18:30:04 +0100 Subject: Review request for JDK-8008085 In-Reply-To: <9A8D8BFD-212F-48E3-8C09-92DF59074C79@oracle.com> References: <9A8D8BFD-212F-48E3-8C09-92DF59074C79@oracle.com> Message-ID: <68EAAC36-CD24-4E5B-B0D2-05088B307C88@oracle.com> +1 if you fix the import order. On Feb 13, 2013, at 5:27 PM, Attila Szegedi wrote: > Please review JDK-8008085 at http://cr.openjdk.java.net/~attila/8008085/webrev.00 > > Thanks, > Attila. From sundararajan.athijegannathan at oracle.com Wed Feb 13 19:43:21 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Thu, 14 Feb 2013 09:13:21 +0530 Subject: Review request JDK-8008193 : test262 tests should be run with security manager enabled Message-ID: <511C5D59.40100@oracle.com> Please review http://cr.openjdk.java.net/~sundar/8008193/ Thanks -Sundar From sundararajan.athijegannathan at oracle.com Wed Feb 13 19:44:42 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Thu, 14 Feb 2013 03:44:42 +0000 Subject: hg: nashorn/jdk8/nashorn: 8008193: test262 tests should be run with security manager enabled Message-ID: <20130214034444.407F547A66@hg.openjdk.java.net> Changeset: 222b9f32b674 Author: sundar Date: 2013-02-14 09:14 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/222b9f32b674 8008193: test262 tests should be run with security manager enabled Reviewed-by: jlaskey ! make/build.xml From marcus.lagergren at oracle.com Wed Feb 13 22:33:20 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Thu, 14 Feb 2013 07:33:20 +0100 Subject: Review request JDK-8008193 : test262 tests should be run with security manager enabled In-Reply-To: <511C5D59.40100@oracle.com> References: <511C5D59.40100@oracle.com> Message-ID: <39591414-7AB3-4086-AEB7-58E49D8939CB@oracle.com> +1. Did you notice any slowdown? /M On Feb 14, 2013, at 4:43 AM, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~sundar/8008193/ > > Thanks > -Sundar From sundararajan.athijegannathan at oracle.com Wed Feb 13 23:02:45 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Thu, 14 Feb 2013 12:32:45 +0530 Subject: Review request JDK-8008197 Cross script engine function calls do not work as expected Message-ID: <511C8C15.5010702@oracle.com> Please review http://cr.openjdk.java.net/~sundar/8008197/ Thanks -Sundar From sundararajan.athijegannathan at oracle.com Wed Feb 13 23:04:12 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Thu, 14 Feb 2013 12:34:12 +0530 Subject: Review request JDK-8008193 : test262 tests should be run with security manager enabled In-Reply-To: <39591414-7AB3-4086-AEB7-58E49D8939CB@oracle.com> References: <511C5D59.40100@oracle.com> <39591414-7AB3-4086-AEB7-58E49D8939CB@oracle.com> Message-ID: <511C8C6C.7030202@oracle.com> Not much . PS. My machine is a bit old one anyway. I think on better machines it should not be visible much. Running again after another fix... -Sundar On Thursday 14 February 2013 12:03 PM, Marcus Lagergren wrote: > +1. Did you notice any slowdown? > > /M > > On Feb 14, 2013, at 4:43 AM, A. Sundararajan wrote: > >> Please review http://cr.openjdk.java.net/~sundar/8008193/ >> >> Thanks >> -Sundar From hannes.wallnoefer at oracle.com Thu Feb 14 00:20:16 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Thu, 14 Feb 2013 09:20:16 +0100 Subject: Review request JDK-8008197 Cross script engine function calls do not work as expected In-Reply-To: <511C8C15.5010702@oracle.com> References: <511C8C15.5010702@oracle.com> Message-ID: <511C9E40.7040404@oracle.com> The code looks good to me. I think we should check return values in the test to make sure it works full circle, also using ScriptObjects to test wrapping and unwrapping. Hannes Am 2013-02-14 08:02, schrieb A. Sundararajan: > Please review http://cr.openjdk.java.net/~sundar/8008197/ > > Thanks > -Sundar From sundararajan.athijegannathan at oracle.com Thu Feb 14 00:42:24 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Thu, 14 Feb 2013 14:12:24 +0530 Subject: Review request JDK-8008197 Cross script engine function calls do not work as expected In-Reply-To: <511C9E40.7040404@oracle.com> References: <511C8C15.5010702@oracle.com> <511C9E40.7040404@oracle.com> Message-ID: <511CA370.6000207@oracle.com> Expanded the test to check return values. http://cr.openjdk.java.net/~sundar/8008197/webrev.01/ Thanks -Sundar On Thursday 14 February 2013 01:50 PM, Hannes Wallnoefer wrote: > The code looks good to me. > > I think we should check return values in the test to make sure it > works full circle, also using ScriptObjects to test wrapping and > unwrapping. > > Hannes > > Am 2013-02-14 08:02, schrieb A. Sundararajan: >> Please review http://cr.openjdk.java.net/~sundar/8008197/ >> >> Thanks >> -Sundar > From hannes.wallnoefer at oracle.com Thu Feb 14 00:43:54 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Thu, 14 Feb 2013 09:43:54 +0100 Subject: Review request JDK-8008193 : test262 tests should be run with security manager enabled In-Reply-To: <511C5D59.40100@oracle.com> References: <511C5D59.40100@oracle.com> Message-ID: <511CA3CA.6080803@oracle.com> +1 Am 2013-02-14 04:43, schrieb A. Sundararajan: > Please review http://cr.openjdk.java.net/~sundar/8008193/ > > Thanks > -Sundar From sundararajan.athijegannathan at oracle.com Thu Feb 14 00:47:18 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Thu, 14 Feb 2013 08:47:18 +0000 Subject: hg: nashorn/jdk8/nashorn: 8008197: Cross script engine function calls do not work as expected Message-ID: <20130214084720.3622C47A6D@hg.openjdk.java.net> Changeset: 8c72a2bec1be Author: sundar Date: 2013-02-14 14:16 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/8c72a2bec1be 8008197: Cross script engine function calls do not work as expected Reviewed-by: lagergren, hannesw ! src/jdk/nashorn/api/scripting/NashornScriptEngine.java ! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java ! src/jdk/nashorn/internal/runtime/ScriptFunction.java ! src/jdk/nashorn/internal/runtime/ScriptRuntime.java + test/script/basic/JDK-8008197.js ! test/script/basic/jquery.js From marcus.lagergren at oracle.com Thu Feb 14 01:50:59 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Thu, 14 Feb 2013 10:50:59 +0100 Subject: Requesting code review for JDK-8008199 - lazy jitting/Trampoline work Message-ID: <9AF927BD-8536-44F4-BBD8-6E43C9035BE0@oracle.com> Enhancement: https://jbs.oracle.com/bugs/browse/JDK-8008199 With the experimental -Dnashorn.compiler.lazy flag, we will only jit the script by default, and create trampolines for all inner functions, causing them to be generated and executed upon first call. No type specialization yet and no intelligent picking and choosing candidates. Every lazy function will appear in a new CompileUnit of its own when the trampoline hits. Infrastructure is in place, but additional CRs will be filed to something cool with this. Disabled by default. Webrev: http://cr.openjdk.java.net/~lagergren/8008199/ From sundararajan.athijegannathan at oracle.com Thu Feb 14 03:50:48 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Thu, 14 Feb 2013 17:20:48 +0530 Subject: Requesting code review for JDK-8008199 - lazy jitting/Trampoline work In-Reply-To: <9AF927BD-8536-44F4-BBD8-6E43C9035BE0@oracle.com> References: <9AF927BD-8536-44F4-BBD8-6E43C9035BE0@oracle.com> Message-ID: <511CCF98.4060405@oracle.com> +1 -Sundar On Thursday 14 February 2013 03:20 PM, Marcus Lagergren wrote: > Enhancement: https://jbs.oracle.com/bugs/browse/JDK-8008199 > > With the experimental -Dnashorn.compiler.lazy flag, we will only jit the script by default, and create trampolines for all inner functions, causing them to be generated and executed upon first call. No type specialization yet and no intelligent picking and choosing candidates. Every lazy function will appear in a new CompileUnit of its own when the trampoline hits. Infrastructure is in place, but additional CRs will be filed to something cool with this. Disabled by default. > > Webrev: > http://cr.openjdk.java.net/~lagergren/8008199/ > > > From attila.szegedi at oracle.com Thu Feb 14 04:06:44 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Thu, 14 Feb 2013 13:06:44 +0100 Subject: Requesting code review for JDK-8008199 - lazy jitting/Trampoline work In-Reply-To: <9AF927BD-8536-44F4-BBD8-6E43C9035BE0@oracle.com> References: <9AF927BD-8536-44F4-BBD8-6E43C9035BE0@oracle.com> Message-ID: <303E01EC-AD27-4805-9E5F-911218349ECA@oracle.com> +1 On Feb 14, 2013, at 10:50 AM, Marcus Lagergren wrote: > Enhancement: https://jbs.oracle.com/bugs/browse/JDK-8008199 > > With the experimental -Dnashorn.compiler.lazy flag, we will only jit the script by default, and create trampolines for all inner functions, causing them to be generated and executed upon first call. No type specialization yet and no intelligent picking and choosing candidates. Every lazy function will appear in a new CompileUnit of its own when the trampoline hits. Infrastructure is in place, but additional CRs will be filed to something cool with this. Disabled by default. > > Webrev: > http://cr.openjdk.java.net/~lagergren/8008199/ > > > From marcus.lagergren at oracle.com Thu Feb 14 04:22:08 2013 From: marcus.lagergren at oracle.com (marcus.lagergren at oracle.com) Date: Thu, 14 Feb 2013 12:22:08 +0000 Subject: hg: nashorn/jdk8/nashorn: 8008199: Lazy compilation and trampoline implementation Message-ID: <20130214122209.D0A0447A75@hg.openjdk.java.net> Changeset: 43e32b36153c Author: lagergren Date: 2013-02-14 13:01 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/43e32b36153c 8008199: Lazy compilation and trampoline implementation Summary: The code pipeline now supports lazy compilation, which can be used to only compile certain FunctionNodes and leave others be, saving startup time. When these uncompiled nodes are hit, a trampoline will force them to be recompiled. This can also be used to specialize compilation fixing parameter types and return types to a callsite specific compilation. This will give performance. Reviewed-by: attila, sundar ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/codegen/ClassEmitter.java ! src/jdk/nashorn/internal/codegen/CodeGenerator.java + src/jdk/nashorn/internal/codegen/CompilationPhase.java ! src/jdk/nashorn/internal/codegen/CompileUnit.java ! src/jdk/nashorn/internal/codegen/Compiler.java ! src/jdk/nashorn/internal/codegen/ConstantData.java ! src/jdk/nashorn/internal/codegen/FinalizeTypes.java ! src/jdk/nashorn/internal/codegen/FoldConstants.java ! src/jdk/nashorn/internal/codegen/FunctionSignature.java ! src/jdk/nashorn/internal/codegen/Lower.java ! src/jdk/nashorn/internal/codegen/SharedScopeCall.java ! src/jdk/nashorn/internal/codegen/Splitter.java ! src/jdk/nashorn/internal/codegen/WeighNodes.java - src/jdk/nashorn/internal/codegen/objects/FunctionObjectCreator.java ! src/jdk/nashorn/internal/codegen/objects/ObjectClassGenerator.java ! src/jdk/nashorn/internal/ir/FunctionNode.java ! src/jdk/nashorn/internal/ir/debug/JSONWriter.java ! src/jdk/nashorn/internal/ir/visitor/NodeVisitor.java ! src/jdk/nashorn/internal/objects/BoundScriptFunctionImpl.java ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/objects/NativeJava.java ! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java + src/jdk/nashorn/internal/objects/ScriptFunctionTrampolineImpl.java ! src/jdk/nashorn/internal/parser/Lexer.java ! src/jdk/nashorn/internal/parser/Parser.java ! src/jdk/nashorn/internal/runtime/CodeInstaller.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/DebugLogger.java ! src/jdk/nashorn/internal/runtime/FindProperty.java ! src/jdk/nashorn/internal/runtime/ScriptFunction.java ! src/jdk/nashorn/internal/runtime/ScriptFunctionData.java ! src/jdk/nashorn/internal/runtime/ScriptingFunctions.java ! src/jdk/nashorn/tools/Shell.java ! test/script/trusted/JDK-8006529.js ! test/src/jdk/nashorn/internal/parser/ParserTest.java ! test/src/jdk/nashorn/internal/test/framework/SharedContextEvaluator.java From marcus.lagergren at oracle.com Thu Feb 14 04:47:01 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Thu, 14 Feb 2013 13:47:01 +0100 Subject: Please review JBK-8008206 - Switch integer literal bug Message-ID: <11D22797-F998-4298-B96A-7A43662AF564@oracle.com> Code Generator assumes that a SwitchNode has all integer literals for the case that tag.type == Integer. Webrev: http://cr.openjdk.java.net/~lagergren/8008206/ /M From hannes.wallnoefer at oracle.com Thu Feb 14 04:49:29 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Thu, 14 Feb 2013 13:49:29 +0100 Subject: Review request JDK-8008198 Message-ID: <511CDD59.8090608@oracle.com> Please review patch for JDK-8008198: http://cr.openjdk.java.net/~hannesw/8008198/ thanks, Hannes From attila.szegedi at oracle.com Thu Feb 14 04:50:58 2013 From: attila.szegedi at oracle.com (attila.szegedi at oracle.com) Date: Thu, 14 Feb 2013 12:50:58 +0000 Subject: hg: nashorn/jdk8/nashorn: 8008085: Integrate Dynalink source code into Nashorn codebase Message-ID: <20130214125059.8C57147A76@hg.openjdk.java.net> Changeset: 5a820fb11814 Author: attila Date: 2013-02-14 13:22 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/5a820fb11814 8008085: Integrate Dynalink source code into Nashorn codebase Reviewed-by: jlaskey, lagergren, sundar ! THIRD_PARTY_README ! make/build.xml ! make/nbproject/project.xml ! make/project.properties + src/jdk/internal/dynalink/CallSiteDescriptor.java + src/jdk/internal/dynalink/ChainedCallSite.java + src/jdk/internal/dynalink/DefaultBootstrapper.java + src/jdk/internal/dynalink/DynamicLinker.java + src/jdk/internal/dynalink/DynamicLinkerFactory.java + src/jdk/internal/dynalink/MonomorphicCallSite.java + src/jdk/internal/dynalink/NoSuchDynamicMethodException.java + src/jdk/internal/dynalink/RelinkableCallSite.java + src/jdk/internal/dynalink/beans/AbstractJavaLinker.java + src/jdk/internal/dynalink/beans/AccessibleMembersLookup.java + src/jdk/internal/dynalink/beans/ApplicableOverloadedMethods.java + src/jdk/internal/dynalink/beans/BeanIntrospector.java + src/jdk/internal/dynalink/beans/BeanLinker.java + src/jdk/internal/dynalink/beans/BeansLinker.java + src/jdk/internal/dynalink/beans/CheckRestrictedPackage.java + src/jdk/internal/dynalink/beans/CheckRestrictedPackageInternal.java + src/jdk/internal/dynalink/beans/ClassLinker.java + src/jdk/internal/dynalink/beans/ClassString.java + src/jdk/internal/dynalink/beans/DynamicMethod.java + src/jdk/internal/dynalink/beans/DynamicMethodLinker.java + src/jdk/internal/dynalink/beans/FacetIntrospector.java + src/jdk/internal/dynalink/beans/GuardedInvocationComponent.java + src/jdk/internal/dynalink/beans/MaximallySpecific.java + src/jdk/internal/dynalink/beans/OverloadedDynamicMethod.java + src/jdk/internal/dynalink/beans/OverloadedMethod.java + src/jdk/internal/dynalink/beans/RestrictedPackageTester.java + src/jdk/internal/dynalink/beans/SimpleDynamicMethod.java + src/jdk/internal/dynalink/beans/StaticClass.java + src/jdk/internal/dynalink/beans/StaticClassIntrospector.java + src/jdk/internal/dynalink/beans/StaticClassLinker.java + src/jdk/internal/dynalink/beans/messages.properties + src/jdk/internal/dynalink/beans/package.html + src/jdk/internal/dynalink/linker/ConversionComparator.java + src/jdk/internal/dynalink/linker/GuardedInvocation.java + src/jdk/internal/dynalink/linker/GuardingDynamicLinker.java + src/jdk/internal/dynalink/linker/GuardingTypeConverterFactory.java + src/jdk/internal/dynalink/linker/LinkRequest.java + src/jdk/internal/dynalink/linker/LinkerServices.java + src/jdk/internal/dynalink/linker/TypeBasedGuardingDynamicLinker.java + src/jdk/internal/dynalink/linker/package.html + src/jdk/internal/dynalink/package.html + src/jdk/internal/dynalink/support/AbstractCallSiteDescriptor.java + src/jdk/internal/dynalink/support/AbstractRelinkableCallSite.java + src/jdk/internal/dynalink/support/AutoDiscovery.java + src/jdk/internal/dynalink/support/Backport.java + src/jdk/internal/dynalink/support/BottomGuardingDynamicLinker.java + src/jdk/internal/dynalink/support/CallSiteDescriptorFactory.java + src/jdk/internal/dynalink/support/ClassMap.java + src/jdk/internal/dynalink/support/CompositeGuardingDynamicLinker.java + src/jdk/internal/dynalink/support/CompositeTypeBasedGuardingDynamicLinker.java + src/jdk/internal/dynalink/support/DefaultCallSiteDescriptor.java + src/jdk/internal/dynalink/support/Guards.java + src/jdk/internal/dynalink/support/LinkRequestImpl.java + src/jdk/internal/dynalink/support/LinkerServicesImpl.java + src/jdk/internal/dynalink/support/Lookup.java + src/jdk/internal/dynalink/support/LookupCallSiteDescriptor.java + src/jdk/internal/dynalink/support/NameCodec.java + src/jdk/internal/dynalink/support/NamedDynCallSiteDescriptor.java + src/jdk/internal/dynalink/support/RuntimeContextLinkRequestImpl.java + src/jdk/internal/dynalink/support/TypeConverterFactory.java + src/jdk/internal/dynalink/support/TypeUtilities.java + src/jdk/internal/dynalink/support/UnnamedDynCallSiteDescriptor.java + src/jdk/internal/dynalink/support/messages.properties + src/jdk/internal/dynalink/support/package.html ! src/jdk/nashorn/internal/codegen/Compiler.java ! src/jdk/nashorn/internal/codegen/MethodEmitter.java ! src/jdk/nashorn/internal/codegen/WeighNodes.java ! src/jdk/nashorn/internal/ir/Block.java ! src/jdk/nashorn/internal/ir/CallNode.java ! src/jdk/nashorn/internal/ir/Node.java ! src/jdk/nashorn/internal/ir/Symbol.java ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/objects/NativeBoolean.java ! src/jdk/nashorn/internal/objects/NativeJSAdapter.java ! src/jdk/nashorn/internal/objects/NativeJava.java ! src/jdk/nashorn/internal/objects/NativeJavaImporter.java ! src/jdk/nashorn/internal/objects/NativeNumber.java ! src/jdk/nashorn/internal/objects/NativeString.java ! src/jdk/nashorn/internal/parser/Lexer.java ! src/jdk/nashorn/internal/runtime/GlobalObject.java ! src/jdk/nashorn/internal/runtime/JSType.java ! src/jdk/nashorn/internal/runtime/NativeJavaPackage.java ! src/jdk/nashorn/internal/runtime/ScriptFunction.java ! src/jdk/nashorn/internal/runtime/ScriptLoader.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/ScriptRuntime.java ! src/jdk/nashorn/internal/runtime/SetMethodCreator.java ! src/jdk/nashorn/internal/runtime/StructureLoader.java ! src/jdk/nashorn/internal/runtime/Undefined.java ! src/jdk/nashorn/internal/runtime/WithObject.java ! src/jdk/nashorn/internal/runtime/linker/Bootstrap.java ! src/jdk/nashorn/internal/runtime/linker/JSObjectLinker.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java ! src/jdk/nashorn/internal/runtime/linker/JavaArgumentConverters.java ! src/jdk/nashorn/internal/runtime/linker/LinkerCallSite.java ! src/jdk/nashorn/internal/runtime/linker/NashornBottomLinker.java ! src/jdk/nashorn/internal/runtime/linker/NashornCallSiteDescriptor.java ! src/jdk/nashorn/internal/runtime/linker/NashornLinker.java ! src/jdk/nashorn/internal/runtime/linker/NashornPrimitiveLinker.java ! src/jdk/nashorn/internal/runtime/linker/NashornStaticClassLinker.java ! src/jdk/nashorn/internal/runtime/linker/PrimitiveLookup.java ! src/jdk/nashorn/internal/runtime/options/Options.java ! test/script/sandbox/nashorninternals.js ! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java ! test/src/jdk/nashorn/internal/runtime/ContextTest.java ! test/src/jdk/nashorn/internal/runtime/JSTypeTest.java From marcus.lagergren at oracle.com Thu Feb 14 04:52:22 2013 From: marcus.lagergren at oracle.com (marcus.lagergren at oracle.com) Date: Thu, 14 Feb 2013 12:52:22 +0000 Subject: hg: nashorn/jdk8/nashorn: 8008206: The allInteger case for SwitchNode generation in CodeGenerator assumes integer LITERALS only. Message-ID: <20130214125223.8418347A77@hg.openjdk.java.net> Changeset: d086c3eead6b Author: lagergren Date: 2013-02-14 13:52 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/d086c3eead6b 8008206: The allInteger case for SwitchNode generation in CodeGenerator assumes integer LITERALS only. Reviewed-by: sundar, jlaskey ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/codegen/CodeGenerator.java + test/script/basic/JDK-8008206.js + test/script/basic/JDK-8008206.js.EXPECTED From attila.szegedi at oracle.com Thu Feb 14 04:54:14 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Thu, 14 Feb 2013 13:54:14 +0100 Subject: Review request for JDK-8007990 Message-ID: Please review JDK-8007990 at http://cr.openjdk.java.net/~attila/8007990/webrev.00 Thanks, Attila. From hannes.wallnoefer at oracle.com Thu Feb 14 04:57:10 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Thu, 14 Feb 2013 13:57:10 +0100 Subject: Please review JBK-8008206 - Switch integer literal bug In-Reply-To: <11D22797-F998-4298-B96A-7A43662AF564@oracle.com> References: <11D22797-F998-4298-B96A-7A43662AF564@oracle.com> Message-ID: <511CDF26.8080808@oracle.com> +1 Am 2013-02-14 13:47, schrieb Marcus Lagergren: > Code Generator assumes that a SwitchNode has all integer literals for the case that tag.type == Integer. > > Webrev: > > http://cr.openjdk.java.net/~lagergren/8008206/ > > /M > From attila.szegedi at oracle.com Thu Feb 14 04:58:25 2013 From: attila.szegedi at oracle.com (attila.szegedi at oracle.com) Date: Thu, 14 Feb 2013 12:58:25 +0000 Subject: hg: nashorn/jdk8/nashorn: 8007990: No access to interface methods on a restricted class Message-ID: <20130214125826.A091F47A78@hg.openjdk.java.net> Changeset: 3df0a0d62d60 Author: attila Date: 2013-02-14 13:51 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/3df0a0d62d60 8007990: No access to interface methods on a restricted class Reviewed-by: jlaskey, lagergren, sundar ! make/build.xml + test/script/basic/JDK-8007990.js + test/script/basic/JDK-8007990.js.EXPECTED From sundararajan.athijegannathan at oracle.com Thu Feb 14 04:58:41 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Thu, 14 Feb 2013 18:28:41 +0530 Subject: Please review JBK-8008206 - Switch integer literal bug In-Reply-To: <11D22797-F998-4298-B96A-7A43662AF564@oracle.com> References: <11D22797-F998-4298-B96A-7A43662AF564@oracle.com> Message-ID: <511CDF81.1090907@oracle.com> +1 -Sundar On Thursday 14 February 2013 06:17 PM, Marcus Lagergren wrote: > Code Generator assumes that a SwitchNode has all integer literals for the case that tag.type == Integer. > > Webrev: > > http://cr.openjdk.java.net/~lagergren/8008206/ > > /M > From attila.szegedi at oracle.com Thu Feb 14 05:00:01 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Thu, 14 Feb 2013 14:00:01 +0100 Subject: Review request JDK-8008198 In-Reply-To: <511CDD59.8090608@oracle.com> References: <511CDD59.8090608@oracle.com> Message-ID: <8671D731-50DB-4E5D-9745-A6E82174CF74@oracle.com> +1 On Feb 14, 2013, at 1:49 PM, Hannes Wallnoefer wrote: > Please review patch for JDK-8008198: > > http://cr.openjdk.java.net/~hannesw/8008198/ > > thanks, > Hannes From james.laskey at oracle.com Thu Feb 14 05:01:16 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Thu, 14 Feb 2013 09:01:16 -0400 Subject: Review request for JDK-8007990 In-Reply-To: References: Message-ID: <8ADD27D4-276B-4FAE-875A-7C749FA14D11@oracle.com> +1 On 2013-02-14, at 8:54 AM, Attila Szegedi wrote: > Please review JDK-8007990 at http://cr.openjdk.java.net/~attila/8007990/webrev.00 > > Thanks, > Attila. From james.laskey at oracle.com Thu Feb 14 05:01:34 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Thu, 14 Feb 2013 09:01:34 -0400 Subject: Please review JBK-8008206 - Switch integer literal bug In-Reply-To: <11D22797-F998-4298-B96A-7A43662AF564@oracle.com> References: <11D22797-F998-4298-B96A-7A43662AF564@oracle.com> Message-ID: <0C8928D4-57DC-46DC-AB99-D7ACFD52D906@oracle.com> +1 On 2013-02-14, at 8:47 AM, Marcus Lagergren wrote: > Code Generator assumes that a SwitchNode has all integer literals for the case that tag.type == Integer. > > Webrev: > > http://cr.openjdk.java.net/~lagergren/8008206/ > > /M > From james.laskey at oracle.com Thu Feb 14 05:02:35 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Thu, 14 Feb 2013 09:02:35 -0400 Subject: Review request JDK-8008198 In-Reply-To: <511CDD59.8090608@oracle.com> References: <511CDD59.8090608@oracle.com> Message-ID: +1 On 2013-02-14, at 8:49 AM, Hannes Wallnoefer wrote: > Please review patch for JDK-8008198: > > http://cr.openjdk.java.net/~hannesw/8008198/ > > thanks, > Hannes From hannes.wallnoefer at oracle.com Thu Feb 14 05:09:00 2013 From: hannes.wallnoefer at oracle.com (hannes.wallnoefer at oracle.com) Date: Thu, 14 Feb 2013 13:09:00 +0000 Subject: hg: nashorn/jdk8/nashorn: 8008198: java.lang.AssertionError: Invalid break target class jdk.nashorn.internal.ir.TryNode Message-ID: <20130214130902.0C3BD47A7A@hg.openjdk.java.net> Changeset: d1ce4e09e4ba Author: hannesw Date: 2013-02-14 14:07 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/d1ce4e09e4ba 8008198: java.lang.AssertionError: Invalid break target class jdk.nashorn.internal.ir.TryNode Reviewed-by: attila, jlaskey ! src/jdk/nashorn/internal/ir/LabelNode.java ! src/jdk/nashorn/internal/parser/Parser.java + test/script/basic/JDK-8008198.js + test/script/basic/JDK-8008198.js.EXPECTED From james.laskey at oracle.com Thu Feb 14 07:35:56 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Thu, 14 Feb 2013 15:35:56 +0000 Subject: hg: nashorn/jdk8/nashorn: 8008231: Fix build system to accommodate integration of dynalink Message-ID: <20130214153557.71B1D47A8D@hg.openjdk.java.net> Changeset: d41d7cf9ab8b Author: jlaskey Date: 2013-02-14 11:32 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/d41d7cf9ab8b 8008231: Fix build system to accommodate integration of dynalink Reviewed-by: jlaskey Contributed-by: james.laskey at oracle.com ! makefiles/BuildNashorn.gmk From mark.reinhold at oracle.com Thu Feb 14 07:49:33 2013 From: mark.reinhold at oracle.com (mark.reinhold at oracle.com) Date: Thu, 14 Feb 2013 07:49:33 -0800 Subject: Review request JDK-8008103 : Source object should maintain URL of the script source as a private field In-Reply-To: <511BBC4C.8050201@oracle.com> References: <20130213160632.2AECAB0A@eggemoggin.niobe.net>, <511BBC4C.8050201@oracle.com> Message-ID: <20130214074933.349005@eggemoggin.niobe.net> 2013/2/13 0:16 -0800, sundararajan.athijegannathan at oracle.com: > The URL of script Source object is subsequently used for the CodeSource > for the compiled .class file - so that scripts are associated with the > correct ProtectionDomains. Ah, okay. That makes sense. - Mark From hannes.wallnoefer at oracle.com Thu Feb 14 08:46:50 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Thu, 14 Feb 2013 17:46:50 +0100 Subject: Review request for JDK-8008215 Message-ID: <511D14FA.5070705@oracle.com> Please review webrev for JDK-8008215: break in catch clause causes java.lang.VerifyError: Inconsistent stackmap. http://cr.openjdk.java.net/~hannesw/8008215/ thanks, Hannes From james.laskey at oracle.com Thu Feb 14 09:08:47 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Thu, 14 Feb 2013 13:08:47 -0400 Subject: Review request for JDK-8008215 In-Reply-To: <511D14FA.5070705@oracle.com> References: <511D14FA.5070705@oracle.com> Message-ID: <35C4C659-6254-401D-BFB5-19778BC6865C@oracle.com> +1 On 2013-02-14, at 12:46 PM, Hannes Wallnoefer wrote: > Please review webrev for JDK-8008215: break in catch clause causes java.lang.VerifyError: Inconsistent stackmap. > > http://cr.openjdk.java.net/~hannesw/8008215/ > > thanks, > Hannes From marcus.lagergren at oracle.com Thu Feb 14 09:59:14 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Thu, 14 Feb 2013 18:59:14 +0100 Subject: Review request for JDK-8008215 In-Reply-To: <511D14FA.5070705@oracle.com> References: <511D14FA.5070705@oracle.com> Message-ID: +1 On Feb 14, 2013, at 5:46 PM, Hannes Wallnoefer wrote: > Please review webrev for JDK-8008215: break in catch clause causes java.lang.VerifyError: Inconsistent stackmap. > > http://cr.openjdk.java.net/~hannesw/8008215/ > > thanks, > Hannes From marcus.lagergren at oracle.com Thu Feb 14 10:03:28 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Thu, 14 Feb 2013 19:03:28 +0100 Subject: Please review JDK-8088239 Message-ID: <9E0603AC-D4C2-44AB-920D-78F91854A18F@oracle.com> Unpublicize as much as possible of the codegen package. No functionality changes. Tests run. Don't be scared ;-) http://cr.openjdk.java.net/~lagergren/8008239/ /M From hannes.wallnoefer at oracle.com Fri Feb 15 00:13:05 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Fri, 15 Feb 2013 09:13:05 +0100 Subject: Please review JDK-8088239 In-Reply-To: <9E0603AC-D4C2-44AB-920D-78F91854A18F@oracle.com> References: <9E0603AC-D4C2-44AB-920D-78F91854A18F@oracle.com> Message-ID: <511DEE11.8050902@oracle.com> +1 except for some obsolete imports in the classes moved to codegen package. Hannes Am 2013-02-14 19:03, schrieb Marcus Lagergren: > Unpublicize as much as possible of the codegen package. No functionality changes. Tests run. Don't be scared ;-) > > http://cr.openjdk.java.net/~lagergren/8008239/ > > /M > > > > From marcus.lagergren at oracle.com Fri Feb 15 00:14:10 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Fri, 15 Feb 2013 09:14:10 +0100 Subject: Please review JDK-8088239 In-Reply-To: <511DEE11.8050902@oracle.com> References: <9E0603AC-D4C2-44AB-920D-78F91854A18F@oracle.com> <511DEE11.8050902@oracle.com> Message-ID: New webrev is up. On Feb 15, 2013, at 9:13 AM, Hannes Wallnoefer wrote: > +1 except for some obsolete imports in the classes moved to codegen package. > > Hannes > > Am 2013-02-14 19:03, schrieb Marcus Lagergren: >> Unpublicize as much as possible of the codegen package. No functionality changes. Tests run. Don't be scared ;-) >> >> http://cr.openjdk.java.net/~lagergren/8008239/ >> >> /M >> >> >> >> > From hannes.wallnoefer at oracle.com Fri Feb 15 00:14:31 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Fri, 15 Feb 2013 09:14:31 +0100 Subject: Review request for JDK-8008215 In-Reply-To: <511D14FA.5070705@oracle.com> References: <511D14FA.5070705@oracle.com> Message-ID: <511DEE67.7000001@oracle.com> I uploaded a new webrev with the test moved to a separate file as proposed by Sundar. Otherwise unchanged. http://cr.openjdk.java.net/~hannesw/8008215/webrev.01/ Hannes Am 2013-02-14 17:46, schrieb Hannes Wallnoefer: > Please review webrev for JDK-8008215: break in catch clause causes > java.lang.VerifyError: Inconsistent stackmap. > > http://cr.openjdk.java.net/~hannesw/8008215/ > > thanks, > Hannes From hannes.wallnoefer at oracle.com Fri Feb 15 00:20:21 2013 From: hannes.wallnoefer at oracle.com (hannes.wallnoefer at oracle.com) Date: Fri, 15 Feb 2013 08:20:21 +0000 Subject: hg: nashorn/jdk8/nashorn: 8008215: break in catch clause causes java.lang.VerifyError: Inconsistent stackmap Message-ID: <20130215082023.0B72347ABD@hg.openjdk.java.net> Changeset: 36065e5ea3d1 Author: hannesw Date: 2013-02-15 09:18 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/36065e5ea3d1 8008215: break in catch clause causes java.lang.VerifyError: Inconsistent stackmap Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/internal/parser/Parser.java + test/script/basic/JDK-8008215.js + test/script/basic/JDK-8008215.js.EXPECTED From attila.szegedi at oracle.com Fri Feb 15 00:27:44 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Fri, 15 Feb 2013 09:27:44 +0100 Subject: Please review JDK-8088239 In-Reply-To: References: <9E0603AC-D4C2-44AB-920D-78F91854A18F@oracle.com> <511DEE11.8050902@oracle.com> Message-ID: <704429EE-D950-41AA-91B5-A4238EB29BC0@oracle.com> +1 on new one. On Feb 15, 2013, at 9:14 AM, Marcus Lagergren wrote: > New webrev is up. > > On Feb 15, 2013, at 9:13 AM, Hannes Wallnoefer wrote: > >> +1 except for some obsolete imports in the classes moved to codegen package. >> >> Hannes >> >> Am 2013-02-14 19:03, schrieb Marcus Lagergren: >>> Unpublicize as much as possible of the codegen package. No functionality changes. Tests run. Don't be scared ;-) >>> >>> http://cr.openjdk.java.net/~lagergren/8008239/ >>> >>> /M >>> >>> >>> >>> >> > From marcus.lagergren at oracle.com Fri Feb 15 00:45:11 2013 From: marcus.lagergren at oracle.com (marcus.lagergren at oracle.com) Date: Fri, 15 Feb 2013 08:45:11 +0000 Subject: hg: nashorn/jdk8/nashorn: 8008239: Unpublicized parts of the code generator package that were only package internal. Message-ID: <20130215084512.9AC3347AC1@hg.openjdk.java.net> Changeset: e478708faa22 Author: lagergren Date: 2013-02-15 09:44 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/e478708faa22 8008239: Unpublicized parts of the code generator package that were only package internal. Reviewed-by: hannesw, attila ! src/jdk/nashorn/internal/codegen/BranchOptimizer.java ! src/jdk/nashorn/internal/codegen/ClassEmitter.java ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/CompilationPhase.java ! src/jdk/nashorn/internal/codegen/CompilerConstants.java + src/jdk/nashorn/internal/codegen/Condition.java + src/jdk/nashorn/internal/codegen/FieldObjectCreator.java ! src/jdk/nashorn/internal/codegen/FunctionSignature.java + src/jdk/nashorn/internal/codegen/Label.java + src/jdk/nashorn/internal/codegen/MapCreator.java ! src/jdk/nashorn/internal/codegen/MethodEmitter.java + src/jdk/nashorn/internal/codegen/ObjectClassGenerator.java + src/jdk/nashorn/internal/codegen/ObjectCreator.java ! src/jdk/nashorn/internal/codegen/SharedScopeCall.java ! src/jdk/nashorn/internal/codegen/Splitter.java - src/jdk/nashorn/internal/codegen/objects/FieldObjectCreator.java - src/jdk/nashorn/internal/codegen/objects/MapCreator.java - src/jdk/nashorn/internal/codegen/objects/ObjectClassGenerator.java - src/jdk/nashorn/internal/codegen/objects/ObjectCreator.java - src/jdk/nashorn/internal/codegen/objects/ObjectMapCreator.java ! src/jdk/nashorn/internal/codegen/types/BooleanType.java ! src/jdk/nashorn/internal/codegen/types/IntType.java ! src/jdk/nashorn/internal/codegen/types/LongType.java ! src/jdk/nashorn/internal/codegen/types/NumberType.java ! src/jdk/nashorn/internal/ir/AccessNode.java ! src/jdk/nashorn/internal/ir/BaseNode.java ! src/jdk/nashorn/internal/ir/Block.java ! src/jdk/nashorn/internal/ir/BreakNode.java ! src/jdk/nashorn/internal/ir/BreakableNode.java ! src/jdk/nashorn/internal/ir/CallNode.java ! src/jdk/nashorn/internal/ir/CaseNode.java ! src/jdk/nashorn/internal/ir/CatchNode.java ! src/jdk/nashorn/internal/ir/ContinueNode.java ! src/jdk/nashorn/internal/ir/IdentNode.java ! src/jdk/nashorn/internal/ir/IndexNode.java ! src/jdk/nashorn/internal/ir/LabelNode.java ! src/jdk/nashorn/internal/ir/LineNumberNode.java ! src/jdk/nashorn/internal/ir/ObjectNode.java ! src/jdk/nashorn/internal/ir/ReturnNode.java ! src/jdk/nashorn/internal/ir/SplitNode.java ! src/jdk/nashorn/internal/ir/SwitchNode.java ! src/jdk/nashorn/internal/ir/ThrowNode.java ! src/jdk/nashorn/internal/ir/TryNode.java ! src/jdk/nashorn/internal/ir/UnaryNode.java ! src/jdk/nashorn/internal/ir/WhileNode.java ! src/jdk/nashorn/internal/ir/WithNode.java ! src/jdk/nashorn/internal/objects/NativeRegExp.java ! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java ! src/jdk/nashorn/internal/runtime/AccessorProperty.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/ECMAException.java ! src/jdk/nashorn/internal/runtime/FindProperty.java ! src/jdk/nashorn/internal/runtime/Property.java ! src/jdk/nashorn/internal/runtime/Scope.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/ScriptRuntime.java ! src/jdk/nashorn/internal/runtime/SetMethodCreator.java ! src/jdk/nashorn/internal/runtime/StructureLoader.java From sundararajan.athijegannathan at oracle.com Fri Feb 15 03:10:03 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Fri, 15 Feb 2013 16:40:03 +0530 Subject: Review request for JDK-8008215 In-Reply-To: <511DEE67.7000001@oracle.com> References: <511D14FA.5070705@oracle.com> <511DEE67.7000001@oracle.com> Message-ID: <511E178B.90609@oracle.com> +1 -Sundar On Friday 15 February 2013 01:44 PM, Hannes Wallnoefer wrote: > I uploaded a new webrev with the test moved to a separate file as > proposed by Sundar. Otherwise unchanged. > > http://cr.openjdk.java.net/~hannesw/8008215/webrev.01/ > > Hannes > > Am 2013-02-14 17:46, schrieb Hannes Wallnoefer: >> Please review webrev for JDK-8008215: break in catch clause causes >> java.lang.VerifyError: Inconsistent stackmap. >> >> http://cr.openjdk.java.net/~hannesw/8008215/ >> >> thanks, >> Hannes > From sundararajan.athijegannathan at oracle.com Fri Feb 15 03:48:44 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Fri, 15 Feb 2013 17:18:44 +0530 Subject: Review request JDK-8008291: Add more tests for better coverage of objects, scripting and parser packages Message-ID: <511E209C.1030605@oracle.com> Please review http://cr.openjdk.java.net/~sundar/8008291/ Thanks -Sundar From james.laskey at oracle.com Fri Feb 15 03:57:56 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Fri, 15 Feb 2013 03:57:56 -0800 (PST) Subject: Review request JDK-8008291: Add more tests for better coverage of objects, scripting and parser packages In-Reply-To: <511E209C.1030605@oracle.com> References: <511E209C.1030605@oracle.com> Message-ID: +1 On 2013-02-15, at 7:48 AM, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~sundar/8008291/ > > Thanks > -Sundar From sundararajan.athijegannathan at oracle.com Fri Feb 15 05:00:44 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Fri, 15 Feb 2013 13:00:44 +0000 Subject: hg: nashorn/jdk8/nashorn: 8008291: Add more tests for better coverage of objects, scripting and parser packages Message-ID: <20130215130045.84F9447AE6@hg.openjdk.java.net> Changeset: 757a49aaad02 Author: sundar Date: 2013-02-15 18:30 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/757a49aaad02 8008291: Add more tests for better coverage of objects, scripting and parser packages Reviewed-by: lagergren, jlaskey ! src/jdk/nashorn/internal/parser/AbstractParser.java ! src/jdk/nashorn/internal/parser/Scanner.java ! src/jdk/nashorn/internal/runtime/BitVector.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/QuotedStringTokenizer.java ! src/jdk/nashorn/internal/runtime/RegExpScanner.java ! src/jdk/nashorn/internal/runtime/Source.java ! src/jdk/nashorn/tools/Shell.java ! test/script/basic/NASHORN-401.js ! test/script/basic/NASHORN-401.js.EXPECTED + test/script/basic/assign_builtin_func_props.js + test/script/basic/debugger.js + test/script/basic/yield.js ! test/src/jdk/nashorn/api/scripting/MultipleEngineTest.java ! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java ! test/src/jdk/nashorn/api/scripting/Window.java ! test/src/jdk/nashorn/internal/parser/ParserTest.java From marcus.lagergren at oracle.com Fri Feb 15 05:54:06 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Fri, 15 Feb 2013 14:54:06 +0100 Subject: Review request JDK-8008291: Add more tests for better coverage of objects, scripting and parser packages In-Reply-To: <511E209C.1030605@oracle.com> References: <511E209C.1030605@oracle.com> Message-ID: <42517C2B-B0A1-4133-8740-35CCA231F9A9@oracle.com> +1 On Feb 15, 2013, at 12:48 PM, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~sundar/8008291/ > > Thanks > -Sundar From sundararajan.athijegannathan at oracle.com Fri Feb 15 06:59:37 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Fri, 15 Feb 2013 20:29:37 +0530 Subject: Review request JDK-8008298: Add tests to cover specialized versions of Math functions. Message-ID: <511E4D59.6070303@oracle.com> Please review http://cr.openjdk.java.net/~sundar/8008298/ Thanks -Sundar From james.laskey at oracle.com Fri Feb 15 07:04:27 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Fri, 15 Feb 2013 11:04:27 -0400 Subject: Review request JDK-8008298: Add tests to cover specialized versions of Math functions. In-Reply-To: <511E4D59.6070303@oracle.com> References: <511E4D59.6070303@oracle.com> Message-ID: <84706282-8789-4AD4-A6AE-48A6993981D8@oracle.com> +1 On 2013-02-15, at 10:59 AM, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~sundar/8008298/ > > Thanks > -Sundar From sundararajan.athijegannathan at oracle.com Fri Feb 15 07:11:12 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Fri, 15 Feb 2013 15:11:12 +0000 Subject: hg: nashorn/jdk8/nashorn: 8008298: Add tests to cover specialized versions of Math functions. Message-ID: <20130215151113.2B26847AE9@hg.openjdk.java.net> Changeset: 5851c5dac260 Author: sundar Date: 2013-02-15 20:40 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/5851c5dac260 8008298: Add tests to cover specialized versions of Math functions. Reviewed-by: jlaskey, lagergren + test/script/basic/JDK-8008298.js From marcus.lagergren at oracle.com Fri Feb 15 07:13:02 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Fri, 15 Feb 2013 16:13:02 +0100 Subject: Review request JDK-8008298: Add tests to cover specialized versions of Math functions. In-Reply-To: <84706282-8789-4AD4-A6AE-48A6993981D8@oracle.com> References: <511E4D59.6070303@oracle.com> <84706282-8789-4AD4-A6AE-48A6993981D8@oracle.com> Message-ID: <2E749119-F6C8-4B3F-85E9-948F494E2C1F@oracle.com> +1 On Feb 15, 2013, at 4:04 PM, "Jim Laskey (Oracle)" wrote: > +1 > On 2013-02-15, at 10:59 AM, A. Sundararajan wrote: > >> Please review http://cr.openjdk.java.net/~sundar/8008298/ >> >> Thanks >> -Sundar > From harsz89 at gmail.com Sat Feb 16 18:58:55 2013 From: harsz89 at gmail.com (Harsha Kumara) Date: Sun, 17 Feb 2013 08:28:55 +0530 Subject: Is there any resources which compare the java script engine performance along with nashorn? Message-ID: Hi! $Subject please.I ask for a place which nashorn runs benchmark test suits and publish the results? Thanks! -- *Harsha Kumara* *Undergraduate* *Department of Computer Science and Engineering* *University of Moratuwa* *Sri Lanka.* From sundararajan.athijegannathan at oracle.com Sun Feb 17 20:46:35 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Mon, 18 Feb 2013 10:16:35 +0530 Subject: Review request JDK-8008305: ScriptEngine.eval should offer the ability to provide a codebase Message-ID: <5121B22B.5020201@oracle.com> Please review http://cr.openjdk.java.net/~sundar/8008305/ Thanks -Sundar From marcus.lagergren at oracle.com Sun Feb 17 22:17:27 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Mon, 18 Feb 2013 07:17:27 +0100 Subject: Review request JDK-8008305: ScriptEngine.eval should offer the ability to provide a codebase In-Reply-To: <5121B22B.5020201@oracle.com> References: <5121B22B.5020201@oracle.com> Message-ID: <1C55E0D7-78E1-49CE-8253-E141076E8A7E@oracle.com> Looks good. On Feb 18, 2013, at 5:46 AM, "A. Sundararajan" wrote: > Please review http://cr.openjdk.java.net/~sundar/8008305/ > > Thanks > -Sundar From hannes.wallnoefer at oracle.com Sun Feb 17 23:08:40 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Mon, 18 Feb 2013 08:08:40 +0100 Subject: Review request JDK-8008305: ScriptEngine.eval should offer the ability to provide a codebase In-Reply-To: <5121B22B.5020201@oracle.com> References: <5121B22B.5020201@oracle.com> Message-ID: <5121D378.7060800@oracle.com> +1 except for two typos in comments: "underlyging" in URLReader.java and "rums" in JDK-8008305.js. Hannes Am 2013-02-18 05:46, schrieb A. Sundararajan: > Please review http://cr.openjdk.java.net/~sundar/8008305/ > > Thanks > -Sundar From hannes.wallnoefer at oracle.com Sun Feb 17 23:17:15 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Mon, 18 Feb 2013 08:17:15 +0100 Subject: Review request JDK-8008351 Message-ID: <5121D57B.70108@oracle.com> Please review webrev for JDK-8008351 - Avoid using String.replace(String, String) in codegen: http://cr.openjdk.java.net/~hannesw/8008351/ This also removes two unused methods in codegen/Condition.java. Hannes From sundararajan.athijegannathan at oracle.com Mon Feb 18 01:06:29 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Mon, 18 Feb 2013 14:36:29 +0530 Subject: Review request JDK-8008305: ScriptEngine.eval should offer the ability to provide a codebase In-Reply-To: <5121D378.7060800@oracle.com> References: <5121B22B.5020201@oracle.com> <5121D378.7060800@oracle.com> Message-ID: <5121EF15.6010608@oracle.com> Thanks. Fixed those typos. -Sundar On Monday 18 February 2013 12:38 PM, Hannes Wallnoefer wrote: > +1 except for two typos in comments: "underlyging" in URLReader.java > and "rums" in JDK-8008305.js. > > Hannes > > > Am 2013-02-18 05:46, schrieb A. Sundararajan: >> Please review http://cr.openjdk.java.net/~sundar/8008305/ >> >> Thanks >> -Sundar > From sundararajan.athijegannathan at oracle.com Mon Feb 18 01:07:50 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Mon, 18 Feb 2013 14:37:50 +0530 Subject: Review request JDK-8008351 In-Reply-To: <5121D57B.70108@oracle.com> References: <5121D57B.70108@oracle.com> Message-ID: <5121EF66.3030207@oracle.com> +1 -Sundar On Monday 18 February 2013 12:47 PM, Hannes Wallnoefer wrote: > Please review webrev for JDK-8008351 - Avoid using > String.replace(String, String) in codegen: > > http://cr.openjdk.java.net/~hannesw/8008351/ > > This also removes two unused methods in codegen/Condition.java. > > Hannes From attila.szegedi at oracle.com Mon Feb 18 01:09:05 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Mon, 18 Feb 2013 10:09:05 +0100 Subject: Review request JDK-8008305: ScriptEngine.eval should offer the ability to provide a codebase In-Reply-To: <5121B22B.5020201@oracle.com> References: <5121B22B.5020201@oracle.com> Message-ID: <8CBD6B8F-BEF1-4C03-9972-FD4F06DA7413@oracle.com> Looks good. To be honest, URLReader should rightfully be part of javax.script. For completeness sake w/regard to interaction with Java security mechanism, we should also use JarURLConnection.getCertificates() when the URL is a jar: URL when constructing the CodeSource. Can be filed as a separate issue. Attila. On Feb 18, 2013, at 5:46 AM, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~sundar/8008305/ > > Thanks > -Sundar From attila.szegedi at oracle.com Mon Feb 18 01:09:50 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Mon, 18 Feb 2013 10:09:50 +0100 Subject: Review request JDK-8008351 In-Reply-To: <5121D57B.70108@oracle.com> References: <5121D57B.70108@oracle.com> Message-ID: <9A4E9DFF-2746-4921-876C-83BB0F9E0A29@oracle.com> Looks good. On Feb 18, 2013, at 8:17 AM, Hannes Wallnoefer wrote: > Please review webrev for JDK-8008351 - Avoid using String.replace(String, String) in codegen: > > http://cr.openjdk.java.net/~hannesw/8008351/ > > This also removes two unused methods in codegen/Condition.java. > > Hannes From sundararajan.athijegannathan at oracle.com Mon Feb 18 01:12:18 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Mon, 18 Feb 2013 09:12:18 +0000 Subject: hg: nashorn/jdk8/nashorn: 8008305: ScriptEngine.eval should offer the ability to provide a codebase Message-ID: <20130218091220.3356247B55@hg.openjdk.java.net> Changeset: d5f74bd2dc20 Author: sundar Date: 2013-02-18 14:41 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/d5f74bd2dc20 8008305: ScriptEngine.eval should offer the ability to provide a codebase Reviewed-by: lagergren, hannesw, attila ! src/jdk/nashorn/api/scripting/NashornScriptEngine.java + src/jdk/nashorn/api/scripting/URLReader.java + test/script/trusted/JDK-8008305.js + test/script/trusted/JDK-8008305_subtest.js + test/script/trusted/urlreader.js From james.laskey at oracle.com Mon Feb 18 01:16:27 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Mon, 18 Feb 2013 05:16:27 -0400 Subject: Review request JDK-8008305: ScriptEngine.eval should offer the ability to provide a codebase In-Reply-To: <8CBD6B8F-BEF1-4C03-9972-FD4F06DA7413@oracle.com> References: <5121B22B.5020201@oracle.com> <8CBD6B8F-BEF1-4C03-9972-FD4F06DA7413@oracle.com> Message-ID: With the schedule change, I wonder if we can get this in as a public API change, even if it's past FF. Sent from my iPhone 4 On 2013-02-18, at 5:09 AM, Attila Szegedi wrote: > Looks good. To be honest, URLReader should rightfully be part of javax.script. > > For completeness sake w/regard to interaction with Java security mechanism, we should also use JarURLConnection.getCertificates() when the URL is a jar: URL when constructing the CodeSource. Can be filed as a separate issue. > > Attila. > > On Feb 18, 2013, at 5:46 AM, A. Sundararajan wrote: > >> Please review http://cr.openjdk.java.net/~sundar/8008305/ >> >> Thanks >> -Sundar > From hannes.wallnoefer at oracle.com Mon Feb 18 01:37:30 2013 From: hannes.wallnoefer at oracle.com (hannes.wallnoefer at oracle.com) Date: Mon, 18 Feb 2013 09:37:30 +0000 Subject: hg: nashorn/jdk8/nashorn: 8008351: Avoid using String.replace(String, String) in codegen Message-ID: <20130218093732.0969147B58@hg.openjdk.java.net> Changeset: 3245e174fe3a Author: hannesw Date: 2013-02-18 10:36 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/3245e174fe3a 8008351: Avoid using String.replace(String, String) in codegen Reviewed-by: sundar, attila ! src/jdk/nashorn/internal/codegen/Condition.java ! src/jdk/nashorn/internal/codegen/RuntimeCallSite.java ! src/jdk/nashorn/internal/ir/RuntimeNode.java From sundararajan.athijegannathan at oracle.com Mon Feb 18 02:48:40 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Mon, 18 Feb 2013 16:18:40 +0530 Subject: Review request JDK-8008305: ScriptEngine.eval should offer the ability to provide a codebase In-Reply-To: <8CBD6B8F-BEF1-4C03-9972-FD4F06DA7413@oracle.com> References: <5121B22B.5020201@oracle.com> <8CBD6B8F-BEF1-4C03-9972-FD4F06DA7413@oracle.com> Message-ID: <51220708.7080604@oracle.com> I'll file another issue on that. Thanks -Sundar On Monday 18 February 2013 02:39 PM, Attila Szegedi wrote: > Looks good. To be honest, URLReader should rightfully be part of javax.script. > > For completeness sake w/regard to interaction with Java security mechanism, we should also use JarURLConnection.getCertificates() when the URL is a jar: URL when constructing the CodeSource. Can be filed as a separate issue. > > Attila. > > On Feb 18, 2013, at 5:46 AM, A. Sundararajan wrote: > >> Please review http://cr.openjdk.java.net/~sundar/8008305/ >> >> Thanks >> -Sundar From james.laskey at oracle.com Mon Feb 18 04:00:17 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Mon, 18 Feb 2013 08:00:17 -0400 Subject: Is there any resources which compare the java script engine performance along with nashorn? In-Reply-To: References: Message-ID: <72B81FC0-60AA-424A-BED3-DFB7B0FD5703@oracle.com> We use the bin/verbose_octane.sh script to run the v8 octane tests. On 2013-02-16, at 10:58 PM, Harsha Kumara wrote: > Hi! > $Subject please.I ask for a place which nashorn runs benchmark test suits > and publish the results? > Thanks! > > -- > *Harsha Kumara* > *Undergraduate* > *Department of Computer Science and Engineering* > *University of Moratuwa* > *Sri Lanka.* From attila.szegedi at oracle.com Mon Feb 18 05:00:55 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Mon, 18 Feb 2013 14:00:55 +0100 Subject: Review request for JDK-8008371 Message-ID: <5B737C0B-AD17-4B85-87AF-6B3ECDCB65EE@oracle.com> Please review JDK-8008371 at http://cr.openjdk.java.net/~attila/8008371/webrev.00 Thanks, Attila. From attila.szegedi at oracle.com Mon Feb 18 06:15:33 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Mon, 18 Feb 2013 15:15:33 +0100 Subject: Is there any resources which compare the java script engine performance along with nashorn? In-Reply-To: References: Message-ID: <9B96BAA7-5035-4416-B339-CA14930AF3AF@oracle.com> Basically, we aren't publishing our own comparative tests, but you're free to run the benchmarks yourself. You can go to Nashorn's make directory and run: $ ant octane to run all octane tests with Nashorn. You can also use $ ant octane-v8 to run all octane tests with V8 for comparison; you'll need to define the ${v8.shell} property to point to a V8 command line launcher. Similarly, you can use $ ant octane-rhino to run all octane tests with Rhino for comparision; you'll need to define the ${rhino.jar} property to point to a Rhino JAR file. Hope that helps, Attila. On Feb 17, 2013, at 3:58 AM, Harsha Kumara wrote: > Hi! > $Subject please.I ask for a place which nashorn runs benchmark test suits > and publish the results? > Thanks! > > -- > *Harsha Kumara* > *Undergraduate* > *Department of Computer Science and Engineering* > *University of Moratuwa* > *Sri Lanka.* From sundararajan.athijegannathan at oracle.com Mon Feb 18 06:36:42 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Mon, 18 Feb 2013 20:06:42 +0530 Subject: Review request JDK-8008387: Improve code coverage tests for JSObjectLinker and NashornBottomLinker Message-ID: <51223C7A.5080104@oracle.com> Please review http://cr.openjdk.java.net/~sundar/8008387/ Thanks -Sundar From marcus.lagergren at oracle.com Mon Feb 18 06:46:06 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Mon, 18 Feb 2013 15:46:06 +0100 Subject: Review request JDK-8008387: Improve code coverage tests for JSObjectLinker and NashornBottomLinker In-Reply-To: <51223C7A.5080104@oracle.com> References: <51223C7A.5080104@oracle.com> Message-ID: <8169BE2A-FE5A-488F-8D3A-20B8975046C5@oracle.com> +1 On Feb 18, 2013, at 3:36 PM, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~sundar/8008387/ > > Thanks > -Sundar From james.laskey at oracle.com Mon Feb 18 06:46:19 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Mon, 18 Feb 2013 10:46:19 -0400 Subject: Review request JDK-8008387: Improve code coverage tests for JSObjectLinker and NashornBottomLinker In-Reply-To: <51223C7A.5080104@oracle.com> References: <51223C7A.5080104@oracle.com> Message-ID: +1 On 2013-02-18, at 10:36 AM, "A. Sundararajan" wrote: > Please review http://cr.openjdk.java.net/~sundar/8008387/ > > Thanks > -Sundar From hannes.wallnoefer at oracle.com Mon Feb 18 06:50:26 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Mon, 18 Feb 2013 15:50:26 +0100 Subject: Review request JDK-8008387: Improve code coverage tests for JSObjectLinker and NashornBottomLinker In-Reply-To: <51223C7A.5080104@oracle.com> References: <51223C7A.5080104@oracle.com> Message-ID: <51223FB2.90407@oracle.com> +1 Hannes Am 2013-02-18 15:36, schrieb A. Sundararajan: > Please review http://cr.openjdk.java.net/~sundar/8008387/ > > Thanks > -Sundar From attila.szegedi at oracle.com Mon Feb 18 06:58:30 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Mon, 18 Feb 2013 15:58:30 +0100 Subject: Review request for JDK-8008371 (second) Message-ID: <3544415B-33EC-49D6-82D7-F3CD750B328F@oracle.com> Please review JDK-8008371 at http://cr.openjdk.java.net/~attila/8008371/webrev.02 Thanks, Attila. From attila.szegedi at oracle.com Mon Feb 18 07:00:14 2013 From: attila.szegedi at oracle.com (attila.szegedi at oracle.com) Date: Mon, 18 Feb 2013 15:00:14 +0000 Subject: hg: nashorn/jdk8/nashorn: 8008371: Fix Dynalink compiler warnings and whitespace Message-ID: <20130218150016.159C047B61@hg.openjdk.java.net> Changeset: f8221ce53c2e Author: attila Date: 2013-02-18 16:00 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/f8221ce53c2e 8008371: Fix Dynalink compiler warnings and whitespace Reviewed-by: jlaskey, sundar ! src/jdk/internal/dynalink/CallSiteDescriptor.java ! src/jdk/internal/dynalink/ChainedCallSite.java ! src/jdk/internal/dynalink/DefaultBootstrapper.java ! src/jdk/internal/dynalink/DynamicLinker.java ! src/jdk/internal/dynalink/DynamicLinkerFactory.java ! src/jdk/internal/dynalink/MonomorphicCallSite.java ! src/jdk/internal/dynalink/NoSuchDynamicMethodException.java ! src/jdk/internal/dynalink/RelinkableCallSite.java ! src/jdk/internal/dynalink/beans/AbstractJavaLinker.java ! src/jdk/internal/dynalink/beans/ApplicableOverloadedMethods.java ! src/jdk/internal/dynalink/beans/BeanLinker.java ! src/jdk/internal/dynalink/beans/BeansLinker.java ! src/jdk/internal/dynalink/beans/CheckRestrictedPackageInternal.java ! src/jdk/internal/dynalink/beans/ClassLinker.java ! src/jdk/internal/dynalink/beans/ClassString.java ! src/jdk/internal/dynalink/beans/DynamicMethod.java ! src/jdk/internal/dynalink/beans/DynamicMethodLinker.java ! src/jdk/internal/dynalink/beans/FacetIntrospector.java ! src/jdk/internal/dynalink/beans/GuardedInvocationComponent.java ! src/jdk/internal/dynalink/beans/MaximallySpecific.java ! src/jdk/internal/dynalink/beans/OverloadedDynamicMethod.java ! src/jdk/internal/dynalink/beans/OverloadedMethod.java ! src/jdk/internal/dynalink/beans/SimpleDynamicMethod.java ! src/jdk/internal/dynalink/beans/StaticClass.java ! src/jdk/internal/dynalink/beans/StaticClassLinker.java ! src/jdk/internal/dynalink/linker/GuardedInvocation.java ! src/jdk/internal/dynalink/linker/GuardingDynamicLinker.java ! src/jdk/internal/dynalink/linker/GuardingTypeConverterFactory.java ! src/jdk/internal/dynalink/linker/LinkRequest.java ! src/jdk/internal/dynalink/linker/LinkerServices.java ! src/jdk/internal/dynalink/support/AbstractCallSiteDescriptor.java ! src/jdk/internal/dynalink/support/AbstractRelinkableCallSite.java ! src/jdk/internal/dynalink/support/AutoDiscovery.java ! src/jdk/internal/dynalink/support/BottomGuardingDynamicLinker.java ! src/jdk/internal/dynalink/support/CallSiteDescriptorFactory.java ! src/jdk/internal/dynalink/support/CompositeGuardingDynamicLinker.java ! src/jdk/internal/dynalink/support/CompositeTypeBasedGuardingDynamicLinker.java ! src/jdk/internal/dynalink/support/DefaultCallSiteDescriptor.java ! src/jdk/internal/dynalink/support/Guards.java ! src/jdk/internal/dynalink/support/LinkRequestImpl.java ! src/jdk/internal/dynalink/support/LinkerServicesImpl.java ! src/jdk/internal/dynalink/support/Lookup.java ! src/jdk/internal/dynalink/support/LookupCallSiteDescriptor.java ! src/jdk/internal/dynalink/support/NamedDynCallSiteDescriptor.java ! src/jdk/internal/dynalink/support/RuntimeContextLinkRequestImpl.java ! src/jdk/internal/dynalink/support/TypeConverterFactory.java ! src/jdk/internal/dynalink/support/TypeUtilities.java ! src/jdk/internal/dynalink/support/UnnamedDynCallSiteDescriptor.java ! src/jdk/nashorn/internal/codegen/CompilationPhase.java ! src/jdk/nashorn/internal/codegen/FunctionSignature.java ! src/jdk/nashorn/internal/ir/FunctionNode.java ! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java ! src/jdk/nashorn/internal/objects/ScriptFunctionTrampolineImpl.java ! src/jdk/nashorn/internal/parser/Parser.java ! src/jdk/nashorn/internal/runtime/Context.java From james.laskey at oracle.com Mon Feb 18 07:01:26 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Mon, 18 Feb 2013 11:01:26 -0400 Subject: Review request for JDK-8008371 (second) In-Reply-To: <3544415B-33EC-49D6-82D7-F3CD750B328F@oracle.com> References: <3544415B-33EC-49D6-82D7-F3CD750B328F@oracle.com> Message-ID: <7A38096F-11A4-4B5F-AA98-7CCDD464BC63@oracle.com> +1 On 2013-02-18, at 10:58 AM, Attila Szegedi wrote: > Please review JDK-8008371 at http://cr.openjdk.java.net/~attila/8008371/webrev.02 > > Thanks, > Attila. From sundararajan.athijegannathan at oracle.com Mon Feb 18 07:01:51 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Mon, 18 Feb 2013 20:31:51 +0530 Subject: Review request for JDK-8008371 (second) In-Reply-To: <3544415B-33EC-49D6-82D7-F3CD750B328F@oracle.com> References: <3544415B-33EC-49D6-82D7-F3CD750B328F@oracle.com> Message-ID: <5122425F.2070008@oracle.com> +1 On Monday 18 February 2013 08:28 PM, Attila Szegedi wrote: > Please review JDK-8008371 at http://cr.openjdk.java.net/~attila/8008371/webrev.02 > > Thanks, > Attila. From marcus.lagergren at oracle.com Mon Feb 18 07:05:12 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Mon, 18 Feb 2013 16:05:12 +0100 Subject: Review request for JDK-8008371 (second) In-Reply-To: <3544415B-33EC-49D6-82D7-F3CD750B328F@oracle.com> References: <3544415B-33EC-49D6-82D7-F3CD750B328F@oracle.com> Message-ID: <105E9D4C-F87F-49C5-A6FA-937F1A42805C@oracle.com> +1 On Feb 18, 2013, at 3:58 PM, Attila Szegedi wrote: > Please review JDK-8008371 at http://cr.openjdk.java.net/~attila/8008371/webrev.02 > > Thanks, > Attila. From attila.szegedi at oracle.com Mon Feb 18 07:07:44 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Mon, 18 Feb 2013 16:07:44 +0100 Subject: Review request JDK-8008387: Improve code coverage tests for JSObjectLinker and NashornBottomLinker In-Reply-To: <51223C7A.5080104@oracle.com> References: <51223C7A.5080104@oracle.com> Message-ID: <67B5A7FC-58C7-457C-B5FA-6B4C8DD5A64B@oracle.com> +1 for the technical content of the changes. From administrative point of view, a minor problem is that I can't incorporate changes into Dynalink source files on GitHub unless you sign a Contributor License Agreement for Dynalink with me. I'm not saying I insist on a CLA, just stating the fact that without it I can't move any other person's contribution into the GitHub Dynalink, otherwise it jeopardizes my ability to continue offering it under the Apache license. So we'll end up with diverging codebases. Asking me to implement whatever changes are needed, explained in English prose, is an alternative way around the issue :-) Attila. On Feb 18, 2013, at 3:36 PM, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~sundar/8008387/ > > Thanks > -Sundar From sundararajan.athijegannathan at oracle.com Mon Feb 18 07:11:25 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Mon, 18 Feb 2013 15:11:25 +0000 Subject: hg: nashorn/jdk8/nashorn: 8008387: Improve code coverage tests for JSObjectLinker and NashornBottomLinker Message-ID: <20130218151126.3681547B62@hg.openjdk.java.net> Changeset: 4738de1bd57f Author: sundar Date: 2013-02-18 20:41 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/4738de1bd57f 8008387: Improve code coverage tests for JSObjectLinker and NashornBottomLinker Reviewed-by: lagergren, jlaskey, hannesw ! src/jdk/internal/dynalink/beans/BeansLinker.java ! src/jdk/nashorn/internal/runtime/linker/NashornBottomLinker.java + test/script/basic/javamethodcallerrors.js + test/script/basic/jsobject.js From james.laskey at oracle.com Mon Feb 18 15:03:09 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Mon, 18 Feb 2013 23:03:09 +0000 Subject: hg: nashorn/jdk8: 8008420: Fix Nashorn forest to build with NEWBUILD=false Message-ID: <20130218230309.B8E6947B78@hg.openjdk.java.net> Changeset: 8b19b55f695d Author: jlaskey Date: 2013-02-18 19:01 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/8b19b55f695d 8008420: Fix Nashorn forest to build with NEWBUILD=false Reviewed-by: jjh Contributed-by: james.laskey at oracle.com ! Makefile ! make/nashorn-rules.gmk From harsz89 at gmail.com Mon Feb 18 19:57:51 2013 From: harsz89 at gmail.com (Harsha Kumara) Date: Tue, 19 Feb 2013 09:27:51 +0530 Subject: Is there any resources which compare the java script engine performance along with nashorn? In-Reply-To: <9B96BAA7-5035-4416-B339-CA14930AF3AF@oracle.com> References: <9B96BAA7-5035-4416-B339-CA14930AF3AF@oracle.com> Message-ID: Thanks for the reply!I'll work on it. On Mon, Feb 18, 2013 at 7:45 PM, Attila Szegedi wrote: > Basically, we aren't publishing our own comparative tests, but you're free > to run the benchmarks yourself. You can go to Nashorn's make directory and > run: > > $ ant octane > > to run all octane tests with Nashorn. You can also use > > $ ant octane-v8 > > to run all octane tests with V8 for comparison; you'll need to define the > ${v8.shell} property to point to a V8 command line launcher. Similarly, you > can use > > $ ant octane-rhino > > to run all octane tests with Rhino for comparision; you'll need to define > the ${rhino.jar} property to point to a Rhino JAR file. > > Hope that helps, > Attila. > > On Feb 17, 2013, at 3:58 AM, Harsha Kumara wrote: > > > Hi! > > $Subject please.I ask for a place which nashorn runs benchmark test suits > > and publish the results? > > Thanks! > > > > -- > > *Harsha Kumara* > > *Undergraduate* > > *Department of Computer Science and Engineering* > > *University of Moratuwa* > > *Sri Lanka.* > > -- *Harsha Kumara* *Undergraduate* *Department of Computer Science and Engineering* *University of Moratuwa* *Sri Lanka.* From harsz89 at gmail.com Tue Feb 19 05:18:47 2013 From: harsz89 at gmail.com (Harsha Kumara) Date: Tue, 19 Feb 2013 18:48:47 +0530 Subject: Is there any resources which compare the java script engine performance along with nashorn? In-Reply-To: References: <9B96BAA7-5035-4416-B339-CA14930AF3AF@oracle.com> Message-ID: Hi! I able to run the benchmark test suits successfully and I saw nashorn perform well than v8 in some benchmarks.Is nashorn still at optimization levels?As I saw the results I think there are lots of optimization s still need to do at nashorn.I think nashorn can become competitor for v8 and perform well than v8.What you folks think? Thanks! On Tue, Feb 19, 2013 at 9:27 AM, Harsha Kumara wrote: > Thanks for the reply!I'll work on it. > > > On Mon, Feb 18, 2013 at 7:45 PM, Attila Szegedi > wrote: > >> Basically, we aren't publishing our own comparative tests, but you're >> free to run the benchmarks yourself. You can go to Nashorn's make directory >> and run: >> >> $ ant octane >> >> to run all octane tests with Nashorn. You can also use >> >> $ ant octane-v8 >> >> to run all octane tests with V8 for comparison; you'll need to define the >> ${v8.shell} property to point to a V8 command line launcher. Similarly, you >> can use >> >> $ ant octane-rhino >> >> to run all octane tests with Rhino for comparision; you'll need to define >> the ${rhino.jar} property to point to a Rhino JAR file. >> >> Hope that helps, >> Attila. >> >> On Feb 17, 2013, at 3:58 AM, Harsha Kumara wrote: >> >> > Hi! >> > $Subject please.I ask for a place which nashorn runs benchmark test >> suits >> > and publish the results? >> > Thanks! >> > >> > -- >> > *Harsha Kumara* >> > *Undergraduate* >> > *Department of Computer Science and Engineering* >> > *University of Moratuwa* >> > *Sri Lanka.* >> >> > > > -- > *Harsha Kumara* > *Undergraduate* > *Department of Computer Science and Engineering* > *University of Moratuwa* > *Sri Lanka.* > -- *Harsha Kumara* *Undergraduate* *Department of Computer Science and Engineering* *University of Moratuwa* *Sri Lanka.* From james.laskey at oracle.com Tue Feb 19 05:42:19 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Tue, 19 Feb 2013 09:42:19 -0400 Subject: Is there any resources which compare the java script engine performance along with nashorn? In-Reply-To: References: <9B96BAA7-5035-4416-B339-CA14930AF3AF@oracle.com> Message-ID: <8AB12C4F-ECA1-4C30-98E1-3951CA659569@oracle.com> That's the goal, but yes more work needs to be done before we ship in the fall. Most of our focus right now is on performance and robustness. Cheers, -- Jim On 2013-02-19, at 9:18 AM, Harsha Kumara wrote: > Hi! > I able to run the benchmark test suits successfully and I saw nashorn > perform well than v8 in some benchmarks.Is nashorn still at optimization > levels?As I saw the results I think there are lots of optimization s still > need to do at nashorn.I think nashorn can become competitor for v8 and > perform well than v8.What you folks think? > Thanks! > On Tue, Feb 19, 2013 at 9:27 AM, Harsha Kumara wrote: > >> Thanks for the reply!I'll work on it. >> >> >> On Mon, Feb 18, 2013 at 7:45 PM, Attila Szegedi >> wrote: >> >>> Basically, we aren't publishing our own comparative tests, but you're >>> free to run the benchmarks yourself. You can go to Nashorn's make directory >>> and run: >>> >>> $ ant octane >>> >>> to run all octane tests with Nashorn. You can also use >>> >>> $ ant octane-v8 >>> >>> to run all octane tests with V8 for comparison; you'll need to define the >>> ${v8.shell} property to point to a V8 command line launcher. Similarly, you >>> can use >>> >>> $ ant octane-rhino >>> >>> to run all octane tests with Rhino for comparision; you'll need to define >>> the ${rhino.jar} property to point to a Rhino JAR file. >>> >>> Hope that helps, >>> Attila. >>> >>> On Feb 17, 2013, at 3:58 AM, Harsha Kumara wrote: >>> >>>> Hi! >>>> $Subject please.I ask for a place which nashorn runs benchmark test >>> suits >>>> and publish the results? >>>> Thanks! >>>> >>>> -- >>>> *Harsha Kumara* >>>> *Undergraduate* >>>> *Department of Computer Science and Engineering* >>>> *University of Moratuwa* >>>> *Sri Lanka.* >>> >>> >> >> >> -- >> *Harsha Kumara* >> *Undergraduate* >> *Department of Computer Science and Engineering* >> *University of Moratuwa* >> *Sri Lanka.* >> > > > > -- > *Harsha Kumara* > *Undergraduate* > *Department of Computer Science and Engineering* > *University of Moratuwa* > *Sri Lanka.* From james.laskey at oracle.com Tue Feb 19 05:48:08 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Tue, 19 Feb 2013 13:48:08 +0000 Subject: hg: nashorn/jdk8/nashorn: 2 new changesets Message-ID: <20130219134811.085D047B98@hg.openjdk.java.net> Changeset: b6798a83dbd4 Author: jlaskey Date: 2013-02-19 09:46 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/b6798a83dbd4 8008420: Tweaks to make all NEWBUILD=false round 2 Reviewed-by: jjh Contributed-by: james.laskey at oracle.com ! make/Makefile Changeset: b228e3cdbfc3 Author: jlaskey Date: 2013-02-19 09:47 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/b228e3cdbfc3 Merge From james.laskey at oracle.com Tue Feb 19 06:03:28 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Tue, 19 Feb 2013 14:03:28 +0000 Subject: hg: nashorn/jdk8: 8008446: Tweaks to make all NEWBUILD=false round 2 Message-ID: <20130219140328.DAEB547B9A@hg.openjdk.java.net> Changeset: f9a1cb245484 Author: jlaskey Date: 2013-02-19 10:02 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/f9a1cb245484 8008446: Tweaks to make all NEWBUILD=false round 2 Reviewed-by: jjh Contributed-by: james.laskey at oracle.com ! make/Defs-internal.gmk From sundararajan.athijegannathan at oracle.com Tue Feb 19 06:21:30 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Tue, 19 Feb 2013 19:51:30 +0530 Subject: Review request JDK-8008448: Add coverage test for jdk.nashorn.internal.ir.debug.JSONWriter Message-ID: <51238A6A.9020601@oracle.com> Please review http://cr.openjdk.java.net/~sundar/8008448/ -Sundar From james.laskey at oracle.com Tue Feb 19 06:35:08 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Tue, 19 Feb 2013 10:35:08 -0400 Subject: Review request JDK-8008448: Add coverage test for jdk.nashorn.internal.ir.debug.JSONWriter In-Reply-To: <51238A6A.9020601@oracle.com> References: <51238A6A.9020601@oracle.com> Message-ID: <8283D6EA-BD89-4959-B8F7-BBA94474793D@oracle.com> +1 On 2013-02-19, at 10:21 AM, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~sundar/8008448/ > > -Sundar From attila.szegedi at oracle.com Tue Feb 19 06:51:49 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Tue, 19 Feb 2013 15:51:49 +0100 Subject: Review request JDK-8008448: Add coverage test for jdk.nashorn.internal.ir.debug.JSONWriter In-Reply-To: <51238A6A.9020601@oracle.com> References: <51238A6A.9020601@oracle.com> Message-ID: <5D7F4071-08F0-4915-9A2B-F20AD2F68050@oracle.com> +1 On Feb 19, 2013, at 3:21 PM, "A. Sundararajan" wrote: > Please review http://cr.openjdk.java.net/~sundar/8008448/ > > -Sundar From sundararajan.athijegannathan at oracle.com Tue Feb 19 07:04:00 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Tue, 19 Feb 2013 15:04:00 +0000 Subject: hg: nashorn/jdk8/nashorn: 8008448: Add coverage test for jdk.nashorn.internal.ir.debug.JSONWriter Message-ID: <20130219150401.3DEB747B9D@hg.openjdk.java.net> Changeset: b632446ba138 Author: sundar Date: 2013-02-19 20:33 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/b632446ba138 8008448: Add coverage test for jdk.nashorn.internal.ir.debug.JSONWriter Reviewed-by: jlaskey, attila ! src/jdk/nashorn/internal/ir/debug/JSONWriter.java + test/script/basic/JDK-8008448.js From sundararajan.athijegannathan at oracle.com Wed Feb 20 02:55:44 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Wed, 20 Feb 2013 16:25:44 +0530 Subject: Review request JDK-8008207: Make constants array and source fields private Message-ID: <5124ABB0.4080400@oracle.com> Please review http://cr.openjdk.java.net/~sundar/8008207/ Thanks -Sundar From hannes.wallnoefer at oracle.com Wed Feb 20 03:16:54 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Wed, 20 Feb 2013 12:16:54 +0100 Subject: Review request JDK-8008207: Make constants array and source fields private In-Reply-To: <5124ABB0.4080400@oracle.com> References: <5124ABB0.4080400@oracle.com> Message-ID: <5124B0A6.80704@oracle.com> +1 Hannes Am 2013-02-20 11:55, schrieb A. Sundararajan: > Please review http://cr.openjdk.java.net/~sundar/8008207/ > > Thanks > -Sundar From marcus.lagergren at oracle.com Wed Feb 20 03:38:21 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Wed, 20 Feb 2013 12:38:21 +0100 Subject: Review request JDK-8008207: Make constants array and source fields private In-Reply-To: <5124ABB0.4080400@oracle.com> References: <5124ABB0.4080400@oracle.com> Message-ID: +1 if you can't measure any class installation slowdowns. Merge it and we can deal with it later, should it be a problem, e.g. in the lazy jit. On Feb 20, 2013, at 11:55 AM, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~sundar/8008207/ > > Thanks > -Sundar From sundararajan.athijegannathan at oracle.com Wed Feb 20 03:38:48 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Wed, 20 Feb 2013 11:38:48 +0000 Subject: hg: nashorn/jdk8/nashorn: 8008207: Make constants array and source fields private Message-ID: <20130220113849.C91C647BED@hg.openjdk.java.net> Changeset: 58eea0e8f369 Author: sundar Date: 2013-02-20 17:08 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/58eea0e8f369 8008207: Make constants array and source fields private Reviewed-by: hannesw, lagergren ! src/jdk/nashorn/internal/codegen/ClassEmitter.java ! src/jdk/nashorn/internal/codegen/Compiler.java From attila.szegedi at oracle.com Wed Feb 20 03:50:58 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Wed, 20 Feb 2013 12:50:58 +0100 Subject: Review request JDK-8008207: Make constants array and source fields private In-Reply-To: <5124ABB0.4080400@oracle.com> References: <5124ABB0.4080400@oracle.com> Message-ID: <2BBCC2BA-8D36-423C-A2AD-38AA8CB1E331@oracle.com> +1 On Feb 20, 2013, at 11:55 AM, "A. Sundararajan" wrote: > Please review http://cr.openjdk.java.net/~sundar/8008207/ > > Thanks > -Sundar From james.laskey at oracle.com Wed Feb 20 04:10:45 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Wed, 20 Feb 2013 08:10:45 -0400 Subject: Review request JDK-8008207: Make constants array and source fields private In-Reply-To: <5124ABB0.4080400@oracle.com> References: <5124ABB0.4080400@oracle.com> Message-ID: <6D365CE6-37B4-4CC0-AEE4-BB06CE120B62@oracle.com> +1 On 2013-02-20, at 6:55 AM, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~sundar/8008207/ > > Thanks > -Sundar From marcus.lagergren at oracle.com Wed Feb 20 07:41:01 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Wed, 20 Feb 2013 16:41:01 +0100 Subject: Pls review 8008166 Message-ID: <68FAB232-2DBF-4884-83A7-5850DE32E2C0@oracle.com> Partly contributed by klara.ward at oracle.com. Load was broken on Windows due to errors in URL handling when there are colons in the path. Webrev at: http://cr.openjdk.java.net/~lagergren/8008166/ /M From marcus.lagergren at oracle.com Wed Feb 20 07:42:16 2013 From: marcus.lagergren at oracle.com (marcus.lagergren at oracle.com) Date: Wed, 20 Feb 2013 15:42:16 +0000 Subject: hg: nashorn/jdk8/nashorn: 8008166: URL handling was broken on windows, causing "load" to malfunction Message-ID: <20130220154216.C6DC747C05@hg.openjdk.java.net> Changeset: 671852e35ced Author: lagergren Date: 2013-02-20 16:43 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/671852e35ced 8008166: URL handling was broken on windows, causing "load" to malfunction Reviewed-by: attila, jlaskey Contributed-by: klara.ward at oracle.com ! make/build.xml ! src/jdk/nashorn/internal/runtime/Context.java From james.laskey at oracle.com Wed Feb 20 08:25:58 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Wed, 20 Feb 2013 12:25:58 -0400 Subject: Pls review 8008166 In-Reply-To: <68FAB232-2DBF-4884-83A7-5850DE32E2C0@oracle.com> References: <68FAB232-2DBF-4884-83A7-5850DE32E2C0@oracle.com> Message-ID: +1 On 2013-02-20, at 11:41 AM, Marcus Lagergren wrote: > Partly contributed by klara.ward at oracle.com. > > Load was broken on Windows due to errors in URL handling when there are colons in the path. > > Webrev at: http://cr.openjdk.java.net/~lagergren/8008166/ > > /M > From attila.szegedi at oracle.com Wed Feb 20 10:52:45 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Wed, 20 Feb 2013 19:52:45 +0100 Subject: Pls review 8008166 In-Reply-To: <68FAB232-2DBF-4884-83A7-5850DE32E2C0@oracle.com> References: <68FAB232-2DBF-4884-83A7-5850DE32E2C0@oracle.com> Message-ID: +1 On Feb 20, 2013, at 4:41 PM, Marcus Lagergren wrote: > Partly contributed by klara.ward at oracle.com. > > Load was broken on Windows due to errors in URL handling when there are colons in the path. > > Webrev at: http://cr.openjdk.java.net/~lagergren/8008166/ > > /M > From marcus.lagergren at oracle.com Thu Feb 21 06:00:09 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Thu, 21 Feb 2013 15:00:09 +0100 Subject: Please review https://jbs.oracle.com/bugs/browse/JDK-8008648 Message-ID: <80385625-71E5-4BFA-BFA0-104CC8887C38@oracle.com> Various scoping and callee problem related to the lazy JIT. Modified wall clock timing framework slightly to enable better logging. http://cr.openjdk.java.net/~lagergren/8008648/ Lazy JIT now bootstraps significantly faster than normal JIT for large scripts. -- Mandreel startup (3 MB of JavaScript) - with the harness lazy jit and normal jit respectively cthulhu:tip marcus$ java -Dnashorn.time -Dnashorn.compiler.lazy -jar dist/nashorn.jar test/script/external/octane/mandreel.js test/script/external/octane/mandreel.js:30 ReferenceError: "BenchmarkSuite" is not defined [JavaScript Parsing] 845 ms [Lazy JIT Initialization] 66 ms [Constant Folding] 86 ms [Control Flow Lowering] 549 ms [Type Attribution] 128 ms [Code Splitting] 105 ms [Type Finalization] 20 ms [Bytecode Generation] 660 ms [Code Installation] 27 ms Total runtime: 3176 ms (Non-runtime: 2486 [78%]) cthulhu:tip marcus$ java -Dnashorn.time -Dznashorn.compiler.lazy -jar dist/nashorn.jar test/script/external/octane/mandreel.js test/script/external/octane/mandreel.js:30 ReferenceError: "BenchmarkSuite" is not defined [JavaScript Parsing] 902 ms [Constant Folding] 102 ms [Control Flow Lowering] 1545 ms [Type Attribution] 1656 ms [Code Splitting] 428 ms [Type Finalization] 559 ms [Bytecode Generation] 3710 ms [Code Installation] 628 ms Total runtime: 12353 ms (Non-runtime: 9530 [77%]) From attila.szegedi at oracle.com Thu Feb 21 07:17:48 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Thu, 21 Feb 2013 16:17:48 +0100 Subject: Please review https://jbs.oracle.com/bugs/browse/JDK-8008648 In-Reply-To: <80385625-71E5-4BFA-BFA0-104CC8887C38@oracle.com> References: <80385625-71E5-4BFA-BFA0-104CC8887C38@oracle.com> Message-ID: <482586B2-367A-4A96-80ED-B5C26BE71071@oracle.com> +1, with the understanding that lazy inner functions force their outer functions to have all their variables in scope. Might want to raise an issue to track that. On Feb 21, 2013, at 3:00 PM, Marcus Lagergren wrote: > Various scoping and callee problem related to the lazy JIT. Modified wall clock timing framework slightly to enable better logging. > > http://cr.openjdk.java.net/~lagergren/8008648/ > > Lazy JIT now bootstraps significantly faster than normal JIT for large scripts. > > > -- > > Mandreel startup (3 MB of JavaScript) - with the harness lazy jit and normal jit respectively > > cthulhu:tip marcus$ java -Dnashorn.time -Dnashorn.compiler.lazy -jar dist/nashorn.jar test/script/external/octane/mandreel.js > test/script/external/octane/mandreel.js:30 ReferenceError: "BenchmarkSuite" is not defined > [JavaScript Parsing] 845 ms > [Lazy JIT Initialization] 66 ms > [Constant Folding] 86 ms > [Control Flow Lowering] 549 ms > [Type Attribution] 128 ms > [Code Splitting] 105 ms > [Type Finalization] 20 ms > [Bytecode Generation] 660 ms > [Code Installation] 27 ms > Total runtime: 3176 ms (Non-runtime: 2486 [78%]) > > cthulhu:tip marcus$ java -Dnashorn.time -Dznashorn.compiler.lazy -jar dist/nashorn.jar test/script/external/octane/mandreel.js > test/script/external/octane/mandreel.js:30 ReferenceError: "BenchmarkSuite" is not defined > [JavaScript Parsing] 902 ms > [Constant Folding] 102 ms > [Control Flow Lowering] 1545 ms > [Type Attribution] 1656 ms > [Code Splitting] 428 ms > [Type Finalization] 559 ms > [Bytecode Generation] 3710 ms > [Code Installation] 628 ms > Total runtime: 12353 ms (Non-runtime: 9530 [77%]) > From hannes.wallnoefer at oracle.com Thu Feb 21 07:22:08 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Thu, 21 Feb 2013 16:22:08 +0100 Subject: Review request for JDK-8008093 Message-ID: <51263BA0.9090205@oracle.com> Please review patch for JDK-8008093 - Make RegExp engine pluggable: http://cr.openjdk.java.net/~hannesw/8008093/webrev.01/ This makes regexp engine configurable via system property and adds the Joni engine from JRuby. Hannes From marcus.lagergren at oracle.com Thu Feb 21 07:36:37 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Thu, 21 Feb 2013 16:36:37 +0100 Subject: Please review https://jbs.oracle.com/bugs/browse/JDK-8008648 In-Reply-To: <482586B2-367A-4A96-80ED-B5C26BE71071@oracle.com> References: <80385625-71E5-4BFA-BFA0-104CC8887C38@oracle.com> <482586B2-367A-4A96-80ED-B5C26BE71071@oracle.com> Message-ID: <4834E6AF-0E54-4F82-994F-0EFC0582C0C5@oracle.com> Yep. This is an initial model to make sure everything is sound. The heuristic for picking lazy methods will most likely change to something less aggressive. I would welcome suggestions as to how to determine if a variable function should be in scope or not in an outer function when inner functions haven't been evaluated yet. /M On Feb 21, 2013, at 4:17 PM, Attila Szegedi wrote: > +1, with the understanding that lazy inner functions force their outer functions to have all their variables in scope. Might want to raise an issue to track that. > > > On Feb 21, 2013, at 3:00 PM, Marcus Lagergren wrote: > >> Various scoping and callee problem related to the lazy JIT. Modified wall clock timing framework slightly to enable better logging. >> >> http://cr.openjdk.java.net/~lagergren/8008648/ >> >> Lazy JIT now bootstraps significantly faster than normal JIT for large scripts. >> >> >> -- >> >> Mandreel startup (3 MB of JavaScript) - with the harness lazy jit and normal jit respectively >> >> cthulhu:tip marcus$ java -Dnashorn.time -Dnashorn.compiler.lazy -jar dist/nashorn.jar test/script/external/octane/mandreel.js >> test/script/external/octane/mandreel.js:30 ReferenceError: "BenchmarkSuite" is not defined >> [JavaScript Parsing] 845 ms >> [Lazy JIT Initialization] 66 ms >> [Constant Folding] 86 ms >> [Control Flow Lowering] 549 ms >> [Type Attribution] 128 ms >> [Code Splitting] 105 ms >> [Type Finalization] 20 ms >> [Bytecode Generation] 660 ms >> [Code Installation] 27 ms >> Total runtime: 3176 ms (Non-runtime: 2486 [78%]) >> >> cthulhu:tip marcus$ java -Dnashorn.time -Dznashorn.compiler.lazy -jar dist/nashorn.jar test/script/external/octane/mandreel.js >> test/script/external/octane/mandreel.js:30 ReferenceError: "BenchmarkSuite" is not defined >> [JavaScript Parsing] 902 ms >> [Constant Folding] 102 ms >> [Control Flow Lowering] 1545 ms >> [Type Attribution] 1656 ms >> [Code Splitting] 428 ms >> [Type Finalization] 559 ms >> [Bytecode Generation] 3710 ms >> [Code Installation] 628 ms >> Total runtime: 12353 ms (Non-runtime: 9530 [77%]) >> > From marcus.lagergren at oracle.com Thu Feb 21 07:55:46 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Thu, 21 Feb 2013 16:55:46 +0100 Subject: Review request for JDK-8008093 In-Reply-To: <51263BA0.9090205@oracle.com> References: <51263BA0.9090205@oracle.com> Message-ID: <8AB8C275-2E8D-4C3E-AA6F-E9D8002E82E3@oracle.com> +1 (including my earlier over-Skype comments about JavaDoc for new public methods in places it was missing) On Feb 21, 2013, at 4:22 PM, Hannes Wallnoefer wrote: > Please review patch for JDK-8008093 - Make RegExp engine pluggable: > > http://cr.openjdk.java.net/~hannesw/8008093/webrev.01/ > > This makes regexp engine configurable via system property and adds the Joni engine from JRuby. > > Hannes From marcus.lagergren at oracle.com Thu Feb 21 08:02:45 2013 From: marcus.lagergren at oracle.com (marcus.lagergren at oracle.com) Date: Thu, 21 Feb 2013 16:02:45 +0000 Subject: hg: nashorn/jdk8/nashorn: 8008648: Lazy JIT scope and callee semantics bugfixes. Broke out wallclock timer. Message-ID: <20130221160246.75F9947C3D@hg.openjdk.java.net> Changeset: a971adb68f38 Author: lagergren Date: 2013-02-21 16:57 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/a971adb68f38 8008648: Lazy JIT scope and callee semantics bugfixes. Broke out wallclock timer. Reviewed-by: attila, hannesw ! src/jdk/internal/dynalink/beans/BeansLinker.java ! src/jdk/nashorn/internal/codegen/CodeGenerator.java + src/jdk/nashorn/internal/codegen/CompilationException.java ! src/jdk/nashorn/internal/codegen/CompilationPhase.java ! src/jdk/nashorn/internal/codegen/Compiler.java ! src/jdk/nashorn/internal/codegen/FinalizeTypes.java ! src/jdk/nashorn/internal/codegen/Lower.java ! src/jdk/nashorn/internal/codegen/MethodEmitter.java ! src/jdk/nashorn/internal/codegen/Splitter.java ! src/jdk/nashorn/internal/ir/FunctionNode.java ! src/jdk/nashorn/internal/ir/TernaryNode.java ! src/jdk/nashorn/internal/objects/ScriptFunctionTrampolineImpl.java ! src/jdk/nashorn/internal/parser/Parser.java ! src/jdk/nashorn/internal/runtime/NashornLoader.java ! src/jdk/nashorn/internal/runtime/ScriptingFunctions.java + src/jdk/nashorn/internal/runtime/Timing.java ! test/script/trusted/JDK-8006529.js From hannes.wallnoefer at oracle.com Thu Feb 21 08:02:48 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Thu, 21 Feb 2013 17:02:48 +0100 Subject: Please review https://jbs.oracle.com/bugs/browse/JDK-8008648 In-Reply-To: <80385625-71E5-4BFA-BFA0-104CC8887C38@oracle.com> References: <80385625-71E5-4BFA-BFA0-104CC8887C38@oracle.com> Message-ID: <51264528.5000300@oracle.com> +1. A short comment explaining handling of self reference calls as non-lazy would be nice. Hannes Am 2013-02-21 15:00, schrieb Marcus Lagergren: > Various scoping and callee problem related to the lazy JIT. Modified wall clock timing framework slightly to enable better logging. > > http://cr.openjdk.java.net/~lagergren/8008648/ > > Lazy JIT now bootstraps significantly faster than normal JIT for large scripts. > > > -- > > Mandreel startup (3 MB of JavaScript) - with the harness lazy jit and normal jit respectively > > cthulhu:tip marcus$ java -Dnashorn.time -Dnashorn.compiler.lazy -jar dist/nashorn.jar test/script/external/octane/mandreel.js > test/script/external/octane/mandreel.js:30 ReferenceError: "BenchmarkSuite" is not defined > [JavaScript Parsing] 845 ms > [Lazy JIT Initialization] 66 ms > [Constant Folding] 86 ms > [Control Flow Lowering] 549 ms > [Type Attribution] 128 ms > [Code Splitting] 105 ms > [Type Finalization] 20 ms > [Bytecode Generation] 660 ms > [Code Installation] 27 ms > Total runtime: 3176 ms (Non-runtime: 2486 [78%]) > > cthulhu:tip marcus$ java -Dnashorn.time -Dznashorn.compiler.lazy -jar dist/nashorn.jar test/script/external/octane/mandreel.js > test/script/external/octane/mandreel.js:30 ReferenceError: "BenchmarkSuite" is not defined > [JavaScript Parsing] 902 ms > [Constant Folding] 102 ms > [Control Flow Lowering] 1545 ms > [Type Attribution] 1656 ms > [Code Splitting] 428 ms > [Type Finalization] 559 ms > [Bytecode Generation] 3710 ms > [Code Installation] 628 ms > Total runtime: 12353 ms (Non-runtime: 9530 [77%]) > From james.laskey at oracle.com Thu Feb 21 11:27:40 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Thu, 21 Feb 2013 19:27:40 +0000 Subject: hg: nashorn/jdk8: 8008447: Tweaks to make all NEWBUILD=false round 3 Message-ID: <20130221192741.2080347C4C@hg.openjdk.java.net> Changeset: 887fde71977e Author: jlaskey Date: 2013-02-21 15:25 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/887fde71977e 8008447: Tweaks to make all NEWBUILD=false round 3 Reviewed-by: jjh, sundar Contributed-by: james.laskey at oracle.com ! make/jdk-rules.gmk ! make/sanity-rules.gmk From james.laskey at oracle.com Thu Feb 21 11:28:02 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Thu, 21 Feb 2013 19:28:02 +0000 Subject: hg: nashorn/jdk8/jdk: 8008447: Tweaks to make all NEWBUILD=false round 3 Message-ID: <20130221192826.1AFFB47C4D@hg.openjdk.java.net> Changeset: a174944b0c00 Author: jlaskey Date: 2013-02-21 15:25 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/a174944b0c00 8008447: Tweaks to make all NEWBUILD=false round 3 Reviewed-by: jjh, sundar Contributed-by: james.laskey at oracle.com ! make/launchers/Makefile From james.laskey at oracle.com Thu Feb 21 11:28:38 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Thu, 21 Feb 2013 19:28:38 +0000 Subject: hg: nashorn/jdk8/nashorn: 8008447: Tweaks to make all NEWBUILD=false round 3 Message-ID: <20130221192839.4D06947C4E@hg.openjdk.java.net> Changeset: ae1c9716685b Author: jlaskey Date: 2013-02-21 15:24 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/ae1c9716685b 8008447: Tweaks to make all NEWBUILD=false round 3 Reviewed-by: jjh, sundar Contributed-by: james.laskey at oracle.com ! make/Makefile From marcus.lagergren at oracle.com Thu Feb 21 23:12:03 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Fri, 22 Feb 2013 08:12:03 +0100 Subject: Please review JDK-8008554 Message-ID: <39AF697B-A9BB-4C5D-9255-FD0E95DBF2EA@oracle.com> URL loading is now working again. Verified on all platforms, including Windows. Already got one +1 from Attila. http://cr.openjdk.java.net/~lagergren/8008554/ /M From sundararajan.athijegannathan at oracle.com Thu Feb 21 23:41:03 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Fri, 22 Feb 2013 13:11:03 +0530 Subject: Please review JDK-8008554 In-Reply-To: <39AF697B-A9BB-4C5D-9255-FD0E95DBF2EA@oracle.com> References: <39AF697B-A9BB-4C5D-9255-FD0E95DBF2EA@oracle.com> Message-ID: <5127210F.7030409@oracle.com> +1 Do we have a test that exercises load function with URL string? Perhaps file: URL? -Sundar On Friday 22 February 2013 12:42 PM, Marcus Lagergren wrote: > URL loading is now working again. Verified on all platforms, including Windows. Already got one +1 from Attila. > > http://cr.openjdk.java.net/~lagergren/8008554/ > > /M > > From marcus.lagergren at oracle.com Thu Feb 21 23:57:40 2013 From: marcus.lagergren at oracle.com (marcus.lagergren at oracle.com) Date: Fri, 22 Feb 2013 07:57:40 +0000 Subject: hg: nashorn/jdk8/nashorn: 8008554: load was broken for URLs Message-ID: <20130222075741.C0AF147C69@hg.openjdk.java.net> Changeset: 678da59a29b3 Author: lagergren Date: 2013-02-22 08:57 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/678da59a29b3 8008554: load was broken for URLs Reviewed-by: attila, sundar ! src/jdk/nashorn/internal/runtime/Context.java + test/script/basic/JDK-8008554.js From marcus.lagergren at oracle.com Thu Feb 21 23:59:17 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Fri, 22 Feb 2013 08:59:17 +0100 Subject: Please review JDK-8008554 In-Reply-To: <5127210F.7030409@oracle.com> References: <39AF697B-A9BB-4C5D-9255-FD0E95DBF2EA@oracle.com> <5127210F.7030409@oracle.com> Message-ID: Added unit test. Pushed. On Feb 22, 2013, at 8:41 AM, "A. Sundararajan" wrote: > +1 Do we have a test that exercises load function with URL string? Perhaps file: URL? > > -Sundar > > On Friday 22 February 2013 12:42 PM, Marcus Lagergren wrote: >> URL loading is now working again. Verified on all platforms, including Windows. Already got one +1 from Attila. >> >> http://cr.openjdk.java.net/~lagergren/8008554/ >> >> /M >> >> > From marcus.lagergren at oracle.com Fri Feb 22 02:01:10 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Fri, 22 Feb 2013 11:01:10 +0100 Subject: Please review JDK-8007002 Message-ID: For control flow reasons, we should let the various error throwing functions return the error to be thrown rather than throwing it in a sub function. Got rid of a lot of nonsense return points and warnings in all IDEs. Discussed with Attila previously. http://cr.openjdk.java.net/~lagergren/8007002/ Test and Test262 pass. /M From marcus.lagergren at oracle.com Fri Feb 22 02:24:07 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Fri, 22 Feb 2013 11:24:07 +0100 Subject: Please review JDK-8008575 Message-ID: Code coverage re-integration. http://cr.openjdk.java.net/~lagergren/8008575 /M From hannes.wallnoefer at oracle.com Fri Feb 22 02:24:57 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Fri, 22 Feb 2013 11:24:57 +0100 Subject: Please review JDK-8007002 In-Reply-To: References: Message-ID: <51274779.1090505@oracle.com> Much nicer this way - +1. Hannes Am 2013-02-22 11:01, schrieb Marcus Lagergren: > For control flow reasons, we should let the various error throwing functions return the error to be thrown rather than throwing it in a sub function. Got rid of a lot of nonsense return points and warnings in all IDEs. > > Discussed with Attila previously. > > http://cr.openjdk.java.net/~lagergren/8007002/ > > Test and Test262 pass. > > /M > From attila.szegedi at oracle.com Fri Feb 22 02:28:02 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Fri, 22 Feb 2013 11:28:02 +0100 Subject: Please review JDK-8008575 In-Reply-To: References: Message-ID: +1 On Feb 22, 2013, at 11:24 AM, Marcus Lagergren wrote: > Code coverage re-integration. > > http://cr.openjdk.java.net/~lagergren/8008575 > > /M > From attila.szegedi at oracle.com Fri Feb 22 02:37:57 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Fri, 22 Feb 2013 11:37:57 +0100 Subject: Please review JDK-8007002 In-Reply-To: <51274779.1090505@oracle.com> References: <51274779.1090505@oracle.com> Message-ID: Rename back isBuiltTypeError to isBuiltinTypeError, and throw new AssertionError(e) in asEcmaException default case. Other than these two, remarks, +1. On Feb 22, 2013, at 11:24 AM, Hannes Wallnoefer wrote: > Much nicer this way - +1. > > Hannes > > Am 2013-02-22 11:01, schrieb Marcus Lagergren: >> For control flow reasons, we should let the various error throwing functions return the error to be thrown rather than throwing it in a sub function. Got rid of a lot of nonsense return points and warnings in all IDEs. >> >> Discussed with Attila previously. >> >> http://cr.openjdk.java.net/~lagergren/8007002/ >> >> Test and Test262 pass. >> >> /M >> > From attila.szegedi at oracle.com Fri Feb 22 02:44:42 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Fri, 22 Feb 2013 11:44:42 +0100 Subject: Review request for JDK-8008093 In-Reply-To: <51263BA0.9090205@oracle.com> References: <51263BA0.9090205@oracle.com> Message-ID: Looks good to me. I like how having two implementations cleaned up the architecture :-). Also, it's a bit scary how you still needed this much plumbing around 'em - must've been quite a job to get through all of this. I'm fairly sure you need to add an Oracle copyright notice to all Joni files; see how I added one to Dynalink files. On Feb 21, 2013, at 4:22 PM, Hannes Wallnoefer wrote: > Please review patch for JDK-8008093 - Make RegExp engine pluggable: > > http://cr.openjdk.java.net/~hannesw/8008093/webrev.01/ > > This makes regexp engine configurable via system property and adds the Joni engine from JRuby. > > Hannes From marcus.lagergren at oracle.com Fri Feb 22 03:30:33 2013 From: marcus.lagergren at oracle.com (marcus.lagergren at oracle.com) Date: Fri, 22 Feb 2013 11:30:33 +0000 Subject: hg: nashorn/jdk8/nashorn: 2 new changesets Message-ID: <20130222113037.6043B47C6E@hg.openjdk.java.net> Changeset: 230a711062c1 Author: lagergren Date: 2013-02-22 11:27 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/230a711062c1 8008575: Re-integrate code coverage Reviewed-by: attila, hannesw Contributed-by: eugene.drobitko at oracle.com, ilya.dergalin at oracle.com ! make/build.xml + make/code_coverage.xml ! make/project.properties Changeset: 267cc4c85160 Author: lagergren Date: 2013-02-22 12:22 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/267cc4c85160 8007002: Replace implicit exception throwing methods with explicit throws - simplify control flow and remove useless code Reviewed-by: attila, hannesw ! src/jdk/nashorn/api/scripting/NashornException.java ! src/jdk/nashorn/api/scripting/NashornScriptEngine.java ! src/jdk/nashorn/api/scripting/URLReader.java ! src/jdk/nashorn/internal/objects/AccessorPropertyDescriptor.java ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/objects/NativeArguments.java ! src/jdk/nashorn/internal/objects/NativeArray.java ! src/jdk/nashorn/internal/objects/NativeBoolean.java ! src/jdk/nashorn/internal/objects/NativeDate.java ! src/jdk/nashorn/internal/objects/NativeError.java ! src/jdk/nashorn/internal/objects/NativeFunction.java ! src/jdk/nashorn/internal/objects/NativeJSAdapter.java ! src/jdk/nashorn/internal/objects/NativeJSON.java ! src/jdk/nashorn/internal/objects/NativeJava.java ! src/jdk/nashorn/internal/objects/NativeNumber.java ! src/jdk/nashorn/internal/objects/NativeObject.java ! src/jdk/nashorn/internal/objects/NativeRegExp.java ! src/jdk/nashorn/internal/objects/NativeString.java ! src/jdk/nashorn/internal/parser/AbstractParser.java ! src/jdk/nashorn/internal/parser/Lexer.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/ECMAErrors.java ! src/jdk/nashorn/internal/runtime/ECMAException.java ! src/jdk/nashorn/internal/runtime/ErrorManager.java ! src/jdk/nashorn/internal/runtime/JSONFunctions.java ! src/jdk/nashorn/internal/runtime/JSType.java ! src/jdk/nashorn/internal/runtime/ParserException.java ! src/jdk/nashorn/internal/runtime/ScriptFunction.java ! src/jdk/nashorn/internal/runtime/ScriptFunctionData.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/ScriptRuntime.java ! src/jdk/nashorn/internal/runtime/ScriptingFunctions.java ! src/jdk/nashorn/internal/runtime/SetMethodCreator.java ! src/jdk/nashorn/internal/runtime/URIUtils.java ! src/jdk/nashorn/internal/runtime/Undefined.java ! src/jdk/nashorn/internal/runtime/arrays/FrozenArrayFilter.java ! src/jdk/nashorn/internal/runtime/arrays/IteratorAction.java ! src/jdk/nashorn/internal/runtime/arrays/SealedArrayFilter.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java ! src/jdk/nashorn/internal/runtime/linker/JavaArgumentConverters.java ! src/jdk/nashorn/internal/runtime/linker/Lookup.java ! src/jdk/nashorn/internal/runtime/linker/NashornBottomLinker.java ! src/jdk/nashorn/internal/runtime/linker/NashornStaticClassLinker.java From hannes.wallnoefer at oracle.com Fri Feb 22 05:53:24 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Fri, 22 Feb 2013 14:53:24 +0100 Subject: Review request for JDK-8008093 In-Reply-To: References: <51263BA0.9090205@oracle.com> Message-ID: <51277854.9060109@oracle.com> I uploaded a new webrev to http://cr.openjdk.java.net/~hannesw/8008093/webrev.02/ with the following changes: - Added missing final declarations - Added missing Javadoc - Added licence to THIRD_PARTY_README As for the Joni license headers, I followed Jim's advice: 1) existing work keeps its copyright notice, 2) new/original work gets GPLv2+CP, 3) Insert an entry for JONI in THIRD_PARTY_README which includes the full text of the licence. Hannes Am 2013-02-22 11:44, schrieb Attila Szegedi: > Looks good to me. I like how having two implementations cleaned up the architecture :-). Also, it's a bit scary how you still needed this much plumbing around 'em - must've been quite a job to get through all of this. > > I'm fairly sure you need to add an Oracle copyright notice to all Joni files; see how I added one to Dynalink files. > > On Feb 21, 2013, at 4:22 PM, Hannes Wallnoefer wrote: > >> Please review patch for JDK-8008093 - Make RegExp engine pluggable: >> >> http://cr.openjdk.java.net/~hannesw/8008093/webrev.01/ >> >> This makes regexp engine configurable via system property and adds the Joni engine from JRuby. >> >> Hannes From james.laskey at oracle.com Fri Feb 22 06:28:04 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Fri, 22 Feb 2013 14:28:04 +0000 Subject: hg: nashorn/jdk8/jdk: 8008721: Tweaks to make all NEWBUILD=false round 4 Message-ID: <20130222142830.4864747C74@hg.openjdk.java.net> Changeset: 25db7658a063 Author: jlaskey Date: 2013-02-22 10:23 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/25db7658a063 8008721: Tweaks to make all NEWBUILD=false round 4 Reviewed-by: jjh Contributed-by: james.laskey at oracle.com ! make/launchers/Makefile From james.laskey at oracle.com Fri Feb 22 06:39:45 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Fri, 22 Feb 2013 14:39:45 +0000 Subject: hg: nashorn/jdk8/nashorn: 8008721: Tweaks to make all NEWBUILD=false round 4 Message-ID: <20130222143945.A69E147C75@hg.openjdk.java.net> Changeset: 3f0ff84aaf36 Author: jlaskey Date: 2013-02-22 10:39 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/3f0ff84aaf36 8008721: Tweaks to make all NEWBUILD=false round 4 Reviewed-by: jjh Contributed-by: james.laskey at oracle.com ! makefiles/BuildNashorn.gmk From hannes.wallnoefer at oracle.com Fri Feb 22 07:46:04 2013 From: hannes.wallnoefer at oracle.com (hannes.wallnoefer at oracle.com) Date: Fri, 22 Feb 2013 15:46:04 +0000 Subject: hg: nashorn/jdk8/nashorn: 8008093: Make RegExp engine pluggable Message-ID: <20130222154605.568BE47C7F@hg.openjdk.java.net> Changeset: 508da3c7fc3a Author: hannesw Date: 2013-02-22 16:31 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/508da3c7fc3a 8008093: Make RegExp engine pluggable Reviewed-by: lagergren, attila ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/objects/NativeRegExp.java ! src/jdk/nashorn/internal/objects/NativeRegExpExecResult.java ! src/jdk/nashorn/internal/objects/NativeString.java ! src/jdk/nashorn/internal/parser/AbstractParser.java - src/jdk/nashorn/internal/runtime/RegExp.java - src/jdk/nashorn/internal/runtime/RegExpMatch.java - src/jdk/nashorn/internal/runtime/RegExpScanner.java + src/jdk/nashorn/internal/runtime/regexp/DefaultRegExp.java + src/jdk/nashorn/internal/runtime/regexp/RegExp.java + src/jdk/nashorn/internal/runtime/regexp/RegExpFactory.java + src/jdk/nashorn/internal/runtime/regexp/RegExpMatcher.java + src/jdk/nashorn/internal/runtime/regexp/RegExpResult.java + src/jdk/nashorn/internal/runtime/regexp/RegExpScanner.java From hannes.wallnoefer at oracle.com Fri Feb 22 08:01:00 2013 From: hannes.wallnoefer at oracle.com (hannes.wallnoefer at oracle.com) Date: Fri, 22 Feb 2013 16:01:00 +0000 Subject: hg: nashorn/jdk8/nashorn: 8006028: Integrate Joni regexp engine with Nashorn Message-ID: <20130222160101.695C247C83@hg.openjdk.java.net> Changeset: e42fd1640ff9 Author: hannesw Date: 2013-02-22 17:00 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/e42fd1640ff9 8006028: Integrate Joni regexp engine with Nashorn Reviewed-by: lagergren, attila ! THIRD_PARTY_README ! docs/DEVELOPER_README + src/jdk/nashorn/internal/runtime/regexp/JoniRegExp.java ! src/jdk/nashorn/internal/runtime/regexp/RegExpFactory.java + src/jdk/nashorn/internal/runtime/regexp/joni/Analyser.java + src/jdk/nashorn/internal/runtime/regexp/joni/ApplyCaseFold.java + src/jdk/nashorn/internal/runtime/regexp/joni/ApplyCaseFoldArg.java + src/jdk/nashorn/internal/runtime/regexp/joni/ArrayCompiler.java + src/jdk/nashorn/internal/runtime/regexp/joni/AsmCompiler.java + src/jdk/nashorn/internal/runtime/regexp/joni/AsmCompilerSupport.java + src/jdk/nashorn/internal/runtime/regexp/joni/BitSet.java + src/jdk/nashorn/internal/runtime/regexp/joni/BitStatus.java + src/jdk/nashorn/internal/runtime/regexp/joni/ByteCodeMachine.java + src/jdk/nashorn/internal/runtime/regexp/joni/ByteCodePrinter.java + src/jdk/nashorn/internal/runtime/regexp/joni/CaptureTreeNode.java + src/jdk/nashorn/internal/runtime/regexp/joni/CodeRangeBuffer.java + src/jdk/nashorn/internal/runtime/regexp/joni/Compiler.java + src/jdk/nashorn/internal/runtime/regexp/joni/Config.java + src/jdk/nashorn/internal/runtime/regexp/joni/EncodingHelper.java + src/jdk/nashorn/internal/runtime/regexp/joni/Lexer.java + src/jdk/nashorn/internal/runtime/regexp/joni/Matcher.java + src/jdk/nashorn/internal/runtime/regexp/joni/MatcherFactory.java + src/jdk/nashorn/internal/runtime/regexp/joni/MinMaxLen.java + src/jdk/nashorn/internal/runtime/regexp/joni/NameEntry.java + src/jdk/nashorn/internal/runtime/regexp/joni/NativeMachine.java + src/jdk/nashorn/internal/runtime/regexp/joni/NodeOptInfo.java + src/jdk/nashorn/internal/runtime/regexp/joni/OptAnchorInfo.java + src/jdk/nashorn/internal/runtime/regexp/joni/OptEnvironment.java + src/jdk/nashorn/internal/runtime/regexp/joni/OptExactInfo.java + src/jdk/nashorn/internal/runtime/regexp/joni/OptMapInfo.java + src/jdk/nashorn/internal/runtime/regexp/joni/Option.java + src/jdk/nashorn/internal/runtime/regexp/joni/Parser.java + src/jdk/nashorn/internal/runtime/regexp/joni/Regex.java + src/jdk/nashorn/internal/runtime/regexp/joni/Region.java + src/jdk/nashorn/internal/runtime/regexp/joni/ScanEnvironment.java + src/jdk/nashorn/internal/runtime/regexp/joni/ScannerSupport.java + src/jdk/nashorn/internal/runtime/regexp/joni/SearchAlgorithm.java + src/jdk/nashorn/internal/runtime/regexp/joni/StackEntry.java + src/jdk/nashorn/internal/runtime/regexp/joni/StackMachine.java + src/jdk/nashorn/internal/runtime/regexp/joni/Syntax.java + src/jdk/nashorn/internal/runtime/regexp/joni/Token.java + src/jdk/nashorn/internal/runtime/regexp/joni/UnsetAddrList.java + src/jdk/nashorn/internal/runtime/regexp/joni/WarnCallback.java + src/jdk/nashorn/internal/runtime/regexp/joni/Warnings.java + src/jdk/nashorn/internal/runtime/regexp/joni/ast/AnchorNode.java + src/jdk/nashorn/internal/runtime/regexp/joni/ast/AnyCharNode.java + src/jdk/nashorn/internal/runtime/regexp/joni/ast/BackRefNode.java + src/jdk/nashorn/internal/runtime/regexp/joni/ast/CClassNode.java + src/jdk/nashorn/internal/runtime/regexp/joni/ast/CTypeNode.java + src/jdk/nashorn/internal/runtime/regexp/joni/ast/CallNode.java + src/jdk/nashorn/internal/runtime/regexp/joni/ast/ConsAltNode.java + src/jdk/nashorn/internal/runtime/regexp/joni/ast/EncloseNode.java + src/jdk/nashorn/internal/runtime/regexp/joni/ast/Node.java + src/jdk/nashorn/internal/runtime/regexp/joni/ast/QuantifierNode.java + src/jdk/nashorn/internal/runtime/regexp/joni/ast/StateNode.java + src/jdk/nashorn/internal/runtime/regexp/joni/ast/StringNode.java + src/jdk/nashorn/internal/runtime/regexp/joni/bench/AbstractBench.java + src/jdk/nashorn/internal/runtime/regexp/joni/bench/BenchGreedyBacktrack.java + src/jdk/nashorn/internal/runtime/regexp/joni/bench/BenchRailsRegs.java + src/jdk/nashorn/internal/runtime/regexp/joni/bench/BenchSeveralRegexps.java + src/jdk/nashorn/internal/runtime/regexp/joni/constants/AnchorType.java + src/jdk/nashorn/internal/runtime/regexp/joni/constants/Arguments.java + src/jdk/nashorn/internal/runtime/regexp/joni/constants/AsmConstants.java + src/jdk/nashorn/internal/runtime/regexp/joni/constants/CCSTATE.java + src/jdk/nashorn/internal/runtime/regexp/joni/constants/CCVALTYPE.java + src/jdk/nashorn/internal/runtime/regexp/joni/constants/EncloseType.java + src/jdk/nashorn/internal/runtime/regexp/joni/constants/MetaChar.java + src/jdk/nashorn/internal/runtime/regexp/joni/constants/NodeStatus.java + src/jdk/nashorn/internal/runtime/regexp/joni/constants/NodeType.java + src/jdk/nashorn/internal/runtime/regexp/joni/constants/OPCode.java + src/jdk/nashorn/internal/runtime/regexp/joni/constants/OPSize.java + src/jdk/nashorn/internal/runtime/regexp/joni/constants/Reduce.java + src/jdk/nashorn/internal/runtime/regexp/joni/constants/RegexState.java + src/jdk/nashorn/internal/runtime/regexp/joni/constants/StackPopLevel.java + src/jdk/nashorn/internal/runtime/regexp/joni/constants/StackType.java + src/jdk/nashorn/internal/runtime/regexp/joni/constants/StringType.java + src/jdk/nashorn/internal/runtime/regexp/joni/constants/SyntaxProperties.java + src/jdk/nashorn/internal/runtime/regexp/joni/constants/TargetInfo.java + src/jdk/nashorn/internal/runtime/regexp/joni/constants/TokenType.java + src/jdk/nashorn/internal/runtime/regexp/joni/constants/Traverse.java + src/jdk/nashorn/internal/runtime/regexp/joni/encoding/AsciiTables.java + src/jdk/nashorn/internal/runtime/regexp/joni/encoding/CharacterType.java + src/jdk/nashorn/internal/runtime/regexp/joni/encoding/IntHolder.java + src/jdk/nashorn/internal/runtime/regexp/joni/encoding/ObjPtr.java + src/jdk/nashorn/internal/runtime/regexp/joni/encoding/PosixBracket.java + src/jdk/nashorn/internal/runtime/regexp/joni/encoding/Ptr.java + src/jdk/nashorn/internal/runtime/regexp/joni/exception/ErrorMessages.java + src/jdk/nashorn/internal/runtime/regexp/joni/exception/InternalException.java + src/jdk/nashorn/internal/runtime/regexp/joni/exception/JOniException.java + src/jdk/nashorn/internal/runtime/regexp/joni/exception/SyntaxException.java + src/jdk/nashorn/internal/runtime/regexp/joni/exception/ValueException.java From hannes.wallnoefer at oracle.com Fri Feb 22 08:11:30 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Fri, 22 Feb 2013 17:11:30 +0100 Subject: Review request for JDK-8008093 In-Reply-To: <51277854.9060109@oracle.com> References: <51263BA0.9090205@oracle.com> <51277854.9060109@oracle.com> Message-ID: <512798B2.9010409@oracle.com> One more note: I split this patch up in two commits to make it use the appropriate bug-ids and messages. I uploaded the new / final webrevs: http://cr.openjdk.java.net/~hannesw/8008093/webrev.03/ http://cr.openjdk.java.net/~hannesw/8006028/webrev.01/ These webrevs together are identical to the patch already reviewed by Marcus and Attila so committed them without further review. Hannes Am 2013-02-22 14:53, schrieb Hannes Wallnoefer: > I uploaded a new webrev to > http://cr.openjdk.java.net/~hannesw/8008093/webrev.02/ with the > following changes: > > - Added missing final declarations > - Added missing Javadoc > - Added licence to THIRD_PARTY_README > > As for the Joni license headers, I followed Jim's advice: 1) existing > work keeps its copyright notice, 2) new/original work gets GPLv2+CP, > 3) Insert an entry for JONI in THIRD_PARTY_README which includes the > full text of the licence. > > Hannes > > Am 2013-02-22 11:44, schrieb Attila Szegedi: >> Looks good to me. I like how having two implementations cleaned up >> the architecture :-). Also, it's a bit scary how you still needed >> this much plumbing around 'em - must've been quite a job to get >> through all of this. >> >> I'm fairly sure you need to add an Oracle copyright notice to all >> Joni files; see how I added one to Dynalink files. >> >> On Feb 21, 2013, at 4:22 PM, Hannes Wallnoefer >> wrote: >> >>> Please review patch for JDK-8008093 - Make RegExp engine pluggable: >>> >>> http://cr.openjdk.java.net/~hannesw/8008093/webrev.01/ >>> >>> This makes regexp engine configurable via system property and adds >>> the Joni engine from JRuby. >>> >>> Hannes > From sundararajan.athijegannathan at oracle.com Fri Feb 22 08:42:37 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Fri, 22 Feb 2013 22:12:37 +0530 Subject: Please review JDK-8008729: Make sure that we can run basic jsr223 tests using jtreg Message-ID: <51279FFD.9050800@oracle.com> Please review http://cr.openjdk.java.net/~sundar/8008729/ Thanks -Sundar From hannes.wallnoefer at oracle.com Fri Feb 22 09:00:12 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Fri, 22 Feb 2013 18:00:12 +0100 Subject: Please review JDK-8008729: Make sure that we can run basic jsr223 tests using jtreg In-Reply-To: <51279FFD.9050800@oracle.com> References: <51279FFD.9050800@oracle.com> Message-ID: <5127A41C.6060801@oracle.com> Looks good to me. Hannes Am 2013-02-22 17:42, schrieb A. Sundararajan: > Please review http://cr.openjdk.java.net/~sundar/8008729/ > > Thanks > -Sundar From marcus.lagergren at oracle.com Fri Feb 22 09:09:59 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Fri, 22 Feb 2013 18:09:59 +0100 Subject: Please review JDK-8008729: Make sure that we can run basic jsr223 tests using jtreg In-Reply-To: <51279FFD.9050800@oracle.com> References: <51279FFD.9050800@oracle.com> Message-ID: +1 On Feb 22, 2013, at 5:42 PM, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~sundar/8008729/ > > Thanks > -Sundar From sundararajan.athijegannathan at oracle.com Fri Feb 22 09:09:38 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Fri, 22 Feb 2013 17:09:38 +0000 Subject: hg: nashorn/jdk8/nashorn: 8008729: Make sure that we can run basic jsr223 tests using jtreg Message-ID: <20130222170939.9986947CA5@hg.openjdk.java.net> Changeset: 7f5b7c6859d7 Author: sundar Date: 2013-02-22 22:39 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/7f5b7c6859d7 8008729: Make sure that we can run basic jsr223 tests using jtreg Reviewed-by: jlaskey, hannesw, lagergren + test/TEST.ROOT ! test/src/jdk/nashorn/api/scripting/MultipleEngineTest.java + test/src/jdk/nashorn/api/scripting/ScriptEngineSecurityTest.java ! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java From james.laskey at oracle.com Fri Feb 22 09:21:00 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Fri, 22 Feb 2013 13:21:00 -0400 Subject: Please review JDK-8008729: Make sure that we can run basic jsr223 tests using jtreg In-Reply-To: <51279FFD.9050800@oracle.com> References: <51279FFD.9050800@oracle.com> Message-ID: <186D9D45-7B0F-4558-8EE2-C9DF5ED02635@oracle.com> +1 On 2013-02-22, at 12:42 PM, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~sundar/8008729/ > > Thanks > -Sundar From james.laskey at oracle.com Fri Feb 22 09:19:41 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Fri, 22 Feb 2013 17:19:41 +0000 Subject: hg: nashorn/jdk8/corba: 7 new changesets Message-ID: <20130222171946.A203147CAB@hg.openjdk.java.net> Changeset: 4a6be02e66a3 Author: katleman Date: 2013-01-31 17:04 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/corba/rev/4a6be02e66a3 Added tag jdk8-b75 for changeset d4e68ce17795 ! .hgtags Changeset: ce106b6b7394 Author: ohrstrom Date: 2013-01-31 14:02 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/corba/rev/ce106b6b7394 8006872: Stop creating four jars with identical content in the new build system. Reviewed-by: erikj ! makefiles/BuildCorba.gmk Changeset: 58be6ca3c060 Author: katleman Date: 2013-02-05 18:54 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/corba/rev/58be6ca3c060 Merge Changeset: 35684a40c584 Author: katleman Date: 2013-02-07 12:32 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/corba/rev/35684a40c584 Added tag jdk8-b76 for changeset 58be6ca3c060 ! .hgtags Changeset: e725dd195858 Author: dmeetry Date: 2013-02-15 01:49 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/corba/rev/e725dd195858 7199858: Marshal exception is wrong Reviewed-by: lancea ! src/share/classes/com/sun/corba/se/impl/corba/TypeCodeImpl.java Changeset: 27d6368ae8ba Author: katleman Date: 2013-02-14 11:43 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/corba/rev/27d6368ae8ba Added tag jdk8-b77 for changeset 35684a40c584 ! .hgtags Changeset: c528d8ce83f1 Author: lana Date: 2013-02-19 20:48 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/corba/rev/c528d8ce83f1 Merge From james.laskey at oracle.com Fri Feb 22 09:19:35 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Fri, 22 Feb 2013 17:19:35 +0000 Subject: hg: nashorn/jdk8: 29 new changesets Message-ID: <20130222171936.8040047CA8@hg.openjdk.java.net> Changeset: 5b19cef637a6 Author: katleman Date: 2013-01-31 17:04 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/5b19cef637a6 Added tag jdk8-b75 for changeset 2a713921952c ! .hgtags Changeset: 8dd61906da5f Author: chegar Date: 2013-02-06 11:36 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/8dd61906da5f 8007625: race with nested repos in /common/bin/hgforest.sh Reviewed-by: dholmes, ohair, ohrstrom ! common/bin/hgforest.sh ! get_source.sh Changeset: 168dd033604a Author: mduigou Date: 2013-02-06 11:09 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/168dd033604a 8004726: Link bug ids to jbs rather than monaco. Reviewed-by: ohair, chegar, katleman ! make/scripts/webrev.ksh Changeset: 7817368287cd Author: mduigou Date: 2013-02-06 11:12 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/7817368287cd 8006595: Use jdk/test/Makefile targets in preference to local definitions Reviewed-by: alanb ! common/makefiles/Main.gmk ! test/Makefile Changeset: fdb1e09519ed Author: sherman Date: 2013-02-12 09:27 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/fdb1e09519ed 8007392: JSR 310: DateTime API Updates Summary: Integration of JSR310 Date/Time API for M7 Reviewed-by: darcy, alanb, naoto Contributed-by: scolebourne at joda.org, roger.riggs at oracle.com, masayoshi.okutsu at oracle.com, patrick.zhang at oracle.com ! common/makefiles/javadoc/CORE_PKGS.gmk Changeset: 6e296219633d Author: tbell Date: 2013-01-31 13:31 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/6e296219633d 8006933: Need to use nawk on Solaris to avoid awk limitations Reviewed-by: erikj, dholmes, dsamersoff ! common/makefiles/IdlCompilation.gmk Changeset: 12782ec1da5f Author: ohrstrom Date: 2013-01-31 14:00 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/12782ec1da5f 8006872: Stop creating four jars with identical content in the new build system. Reviewed-by: erikj ! common/autoconf/spec.gmk.in ! common/makefiles/JavaCompilation.gmk ! common/makefiles/javadoc/Javadoc.gmk Changeset: 7e584be2ee58 Author: ohrstrom Date: 2013-02-01 11:22 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/7e584be2ee58 Merge Changeset: 339e4df096a2 Author: erikj Date: 2013-02-04 10:53 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/339e4df096a2 8007093: build-infra: Make should fail if spec is older than configure files Reviewed-by: tbell ! common/makefiles/Main.gmk Changeset: dea045cc48ca Author: erikj Date: 2013-02-04 11:02 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/dea045cc48ca 8007275: build-infra: Create final-images target Reviewed-by: tbell ! common/autoconf/generated-configure.sh ! common/makefiles/Jprt.gmk Changeset: d3d9ab8ee7b0 Author: erikj Date: 2013-02-05 16:50 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/d3d9ab8ee7b0 8007524: build-infra: Incremental build of tools.jar broken Reviewed-by: tbell ! common/makefiles/JavaCompilation.gmk Changeset: 278af9fc67e7 Author: katleman Date: 2013-02-05 18:54 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/278af9fc67e7 Merge Changeset: 3933eebc659d Author: katleman Date: 2013-02-07 12:32 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/3933eebc659d Added tag jdk8-b76 for changeset 278af9fc67e7 ! .hgtags Changeset: 76808fb4194a Author: lana Date: 2013-02-13 11:21 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/76808fb4194a Merge ! common/makefiles/Main.gmk Changeset: ecc8fda8f187 Author: darcy Date: 2013-02-19 00:24 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/ecc8fda8f187 8008435: Fix new build to include jdk.Supported in ct.sym Reviewed-by: erikj ! common/makefiles/javadoc/NON_CORE_PKGS.gmk Changeset: 45dcccc6d221 Author: katleman Date: 2013-02-14 11:43 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/45dcccc6d221 Added tag jdk8-b77 for changeset 3933eebc659d ! .hgtags Changeset: bbb7548d45c7 Author: lana Date: 2013-02-14 22:11 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/bbb7548d45c7 Merge Changeset: eca3bce3d151 Author: lana Date: 2013-02-19 20:48 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/eca3bce3d151 Merge Changeset: c641268c4532 Author: mduigou Date: 2013-02-20 17:56 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/c641268c4532 8008629: webrev.ksh needs to quote bug title it gets back from scraping bugs.sun.com Reviewed-by: darcy ! make/scripts/webrev.ksh Changeset: ffb4d2e95140 Author: erikj Date: 2013-02-15 10:40 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/ffb4d2e95140 8005879: Add -DMAC_OS_X_VERSION_MAX_ALLOWED=1070 to builds on Mac Reviewed-by: ohair ! common/autoconf/generated-configure.sh ! common/autoconf/spec.gmk.in ! common/autoconf/toolchain.m4 Changeset: b0642df54d63 Author: erikj Date: 2013-02-18 10:46 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/b0642df54d63 Merge Changeset: b80abec66e70 Author: bpatel Date: 2013-01-21 00:29 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/b80abec66e70 8006124: javadoc/doclet should be updated to support profiles Reviewed-by: jjg, dholmes ! common/makefiles/javadoc/Javadoc.gmk Changeset: 7ed0c9db6943 Author: dholmes Date: 2013-01-21 01:50 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/7ed0c9db6943 8004265: Add build support for Compact Profiles Reviewed-by: erikj, ohair ! NewMakefile.gmk ! common/autoconf/generated-configure.sh ! common/makefiles/Main.gmk Changeset: 2f8fd30f02e6 Author: dholmes Date: 2013-01-22 19:30 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/2f8fd30f02e6 Merge ! common/autoconf/generated-configure.sh Changeset: bebeaa04ab8e Author: dholmes Date: 2013-02-04 18:08 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/bebeaa04ab8e Merge ! common/autoconf/generated-configure.sh ! common/makefiles/javadoc/Javadoc.gmk Changeset: 28071e4ca1de Author: dholmes Date: 2013-02-17 16:44 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/28071e4ca1de Merge ! common/autoconf/generated-configure.sh ! common/makefiles/Main.gmk Changeset: fd1a5574cf68 Author: dholmes Date: 2013-02-18 15:35 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/fd1a5574cf68 Merge ! common/autoconf/generated-configure.sh Changeset: b70196e01c53 Author: lana Date: 2013-02-21 17:39 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/b70196e01c53 Merge Changeset: e877cb3eb4d6 Author: jlaskey Date: 2013-02-22 13:09 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/e877cb3eb4d6 Merge ! common/autoconf/generated-configure.sh ! common/autoconf/spec.gmk.in ! common/bin/hgforest.sh ! common/makefiles/Main.gmk From james.laskey at oracle.com Fri Feb 22 09:20:51 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Fri, 22 Feb 2013 17:20:51 +0000 Subject: hg: nashorn/jdk8/hotspot: 111 new changesets Message-ID: <20130222172424.88E1347CB5@hg.openjdk.java.net> Changeset: 20b605466ccb Author: katleman Date: 2013-01-31 17:04 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/20b605466ccb Added tag jdk8-b75 for changeset 6778d0b16593 ! .hgtags Changeset: da53cb17186a Author: katleman Date: 2013-02-07 12:32 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/da53cb17186a Added tag jdk8-b76 for changeset 20b605466ccb ! .hgtags Changeset: 6fbe8a57549d Author: amurillo Date: 2013-01-25 03:03 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/6fbe8a57549d 8006827: new hotspot build - hs25-b18 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 3c327c2b6782 Author: jmasa Date: 2013-01-03 15:03 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/3c327c2b6782 8004895: NPG: JMapPermCore test failure caused by warnings about missing field Reviewed-by: johnc ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/vmStructs_cms.hpp ! src/share/vm/memory/binaryTreeDictionary.cpp ! src/share/vm/memory/binaryTreeDictionary.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: ef1e11845e18 Author: jmasa Date: 2013-02-04 12:01 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/ef1e11845e18 Merge ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 5daaddd917a1 Author: coleenp Date: 2013-01-23 10:34 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/5daaddd917a1 8006040: NPG: on_stack processing wastes space in ConstantPool Summary: Added on_stack bit to flags. Also MetadataMarkOnStack is used for more than JVMTI so had to be moved. Reviewed-by: dholmes, stefank ! src/share/vm/classfile/classLoaderData.cpp + src/share/vm/classfile/metadataOnStackMark.cpp + src/share/vm/classfile/metadataOnStackMark.hpp ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/oops/constantPool.cpp ! src/share/vm/oops/constantPool.hpp ! src/share/vm/oops/method.cpp ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! src/share/vm/prims/jvmtiRedefineClasses.hpp Changeset: 6cf2530f7fd3 Author: minqi Date: 2013-01-24 23:30 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/6cf2530f7fd3 8005278: Serviceability Agent: jmap -heap and jstack -m fail Summary: BinaryTreeDictionary is typedef'ed as AFLBinaryTreeDictionary in vmStructs and in SA we still use old name for that. FreeList now is a template based class which is not reflect in SA type library. When SA does calculation of heap for CMS, the former will cause failure to retrieve BinaryTreeDictionary sine the rename. The later will fail wherever it is used in SA. Reviewed-by: dholmes, sla, coleenp Contributed-by: yunda.mly at taobao.com + agent/src/share/classes/sun/jvm/hotspot/memory/AFLBinaryTreeDictionary.java - agent/src/share/classes/sun/jvm/hotspot/memory/BinaryTreeDictionary.java ! agent/src/share/classes/sun/jvm/hotspot/memory/CompactibleFreeListSpace.java ! agent/src/share/classes/sun/jvm/hotspot/memory/FreeList.java ! src/share/vm/gc_implementation/concurrentMarkSweep/vmStructs_cms.hpp Changeset: 8b46b0196eb0 Author: zgu Date: 2013-01-25 10:04 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/8b46b0196eb0 8000692: Remove old KERNEL code Summary: Removed depreciated kernel VM source code from hotspot VM Reviewed-by: dholmes, acorn ! make/Makefile ! make/bsd/makefiles/dtrace.make ! make/solaris/Makefile ! make/solaris/makefiles/dtrace.make - make/solaris/makefiles/kernel.make ! make/windows/build.bat ! make/windows/create_obj_files.sh ! make/windows/makefiles/defs.make ! make/windows/makefiles/projectcreator.make ! make/windows/makefiles/vm.make ! src/cpu/x86/vm/assembler_x86.hpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/prims/jniCheck.hpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvmtiCodeBlobEvents.hpp ! src/share/vm/prims/jvmtiEnv.cpp ! src/share/vm/prims/jvmtiEnvBase.cpp ! src/share/vm/prims/jvmtiExport.cpp ! src/share/vm/prims/jvmtiExtensions.hpp ! src/share/vm/prims/jvmtiImpl.cpp ! src/share/vm/prims/jvmtiImpl.hpp ! src/share/vm/prims/jvmtiRawMonitor.hpp ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! src/share/vm/prims/jvmtiTagMap.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/arguments.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/vmStructs.hpp ! src/share/vm/runtime/vm_version.cpp ! src/share/vm/services/attachListener.cpp ! src/share/vm/services/attachListener.hpp Changeset: edd76a5856f7 Author: sspitsyn Date: 2013-01-24 22:13 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/edd76a5856f7 8005128: JSR 292: the mlvm redefineClassInBootstrap test crashes in ConstantPool::compare_entry_to Summary: When constant pool is copied in merge_constant_pools the invokedynamic operands must be copied before. Reviewed-by: coleenp, twisti Contributed-by: serguei.spitsyn at oracle.com ! src/share/vm/oops/constantPool.cpp ! src/share/vm/oops/constantPool.hpp ! src/share/vm/prims/jvmtiRedefineClasses.cpp Changeset: 4a0dd3799a44 Author: minqi Date: 2013-01-25 04:23 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/4a0dd3799a44 Merge Changeset: 8d1fb417a42d Author: minqi Date: 2013-01-25 13:47 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/8d1fb417a42d Merge ! src/share/vm/prims/jvmtiRedefineClasses.cpp Changeset: cf8470eaf7e5 Author: acorn Date: 2013-01-27 21:58 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/cf8470eaf7e5 Merge - agent/src/share/classes/sun/jvm/hotspot/memory/BinaryTreeDictionary.java - make/solaris/makefiles/kernel.make ! src/cpu/x86/vm/assembler_x86.hpp ! src/share/vm/classfile/vmSymbols.hpp Changeset: 16fb9f942703 Author: acorn Date: 2013-01-25 15:06 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/16fb9f942703 6479360: PrintClassHistogram improvements Summary: jcmd GC.class_stats (UnlockDiagnosticVMOptions) Reviewed-by: coleenp, hseigel, sla, acorn Contributed-by: ioi.lam at oracle.com ! src/share/vm/classfile/classLoaderData.cpp ! src/share/vm/classfile/classLoaderData.hpp ! src/share/vm/gc_implementation/shared/vmGCOperations.cpp ! src/share/vm/gc_implementation/shared/vmGCOperations.hpp ! src/share/vm/memory/heapInspection.cpp ! src/share/vm/memory/heapInspection.hpp ! src/share/vm/oops/annotations.cpp ! src/share/vm/oops/annotations.hpp ! src/share/vm/oops/arrayKlass.hpp ! src/share/vm/oops/constMethod.cpp ! src/share/vm/oops/constMethod.hpp ! src/share/vm/oops/constantPool.cpp ! src/share/vm/oops/constantPool.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/klass.cpp ! src/share/vm/oops/klass.hpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/method.hpp ! src/share/vm/oops/methodData.cpp ! src/share/vm/oops/methodData.hpp ! src/share/vm/services/diagnosticCommand.cpp ! src/share/vm/services/diagnosticCommand.hpp Changeset: 0d26ce8e9251 Author: acorn Date: 2013-01-28 10:34 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/0d26ce8e9251 Merge - make/solaris/makefiles/kernel.make ! src/share/vm/oops/constantPool.cpp ! src/share/vm/oops/constantPool.hpp Changeset: 815957d0203e Author: acorn Date: 2013-01-28 10:55 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/815957d0203e 8004967: Default method cause VerifyError: Illegal use of nonvirtual Summary: Recognize VM generated method in old verifier Reviewed-by: acorn, coleenp Contributed-by: bharadwaj.yadavelli at oracle.com ! make/bsd/makefiles/mapfile-vers-debug ! make/bsd/makefiles/mapfile-vers-product ! make/linux/makefiles/mapfile-vers-debug ! make/linux/makefiles/mapfile-vers-product ! make/solaris/makefiles/mapfile-vers ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvm.h Changeset: 7885e162c30f Author: acorn Date: 2013-01-28 09:33 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/7885e162c30f Merge Changeset: 9be6cde7919d Author: ctornqvi Date: 2013-01-25 10:14 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/9be6cde7919d 8006413: Add utility classes for writing better multiprocess tests in jtreg Summary: Add a few utility classes to test/testlibrary to support multi process testing in jtreg tests. Added a test case for one of the utility classes. Also reviewed by Vitaly Davidovich Reviewed-by: brutisso, dholmes, vlivanov, nloodin, mgerdin + test/testlibrary/OutputAnalyzerTest.java + test/testlibrary/com/oracle/java/testlibrary/JDKToolFinder.java + test/testlibrary/com/oracle/java/testlibrary/OutputAnalyzer.java + test/testlibrary/com/oracle/java/testlibrary/OutputBuffer.java + test/testlibrary/com/oracle/java/testlibrary/ProcessTools.java + test/testlibrary/com/oracle/java/testlibrary/StreamPumper.java Changeset: baf7fac3167e Author: hseigel Date: 2013-02-01 14:14 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/baf7fac3167e 8006298: Specifying malformed JFR options (-XX:+FlightRecorderOptions) outputs non-sensical error Summary: Change error messages for malformed options so the messages are more useful. Reviewed-by: mikael, kvn, nloodin ! src/share/vm/runtime/arguments.cpp Changeset: 4c75576d18d0 Author: hseigel Date: 2013-02-01 13:30 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/4c75576d18d0 Merge Changeset: 9bf5f643d1cf Author: sspitsyn Date: 2013-01-31 20:07 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/9bf5f643d1cf 8006542: JSR 292: the VM_RedefineClasses::append_entry() must support invokedynamic entry kinds Summary: Need a support for invokedynamic entry kinds when new and old constant pools are merged. Reviewed-by: coleenp, twisti Contributed-by: serguei.spitsyn at oracle.com ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! src/share/vm/prims/jvmtiRedefineClasses.hpp Changeset: dc31f560d6e7 Author: sspitsyn Date: 2013-01-31 20:09 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/dc31f560d6e7 8006546: JSR 292: typos in the ConstantPool::copy_cp_impl() Summary: Simple typos that need to be fixed Reviewed-by: coleenp, twisti Contributed-by: serguei.spitsyn at oracle.com ! src/share/vm/oops/constantPool.cpp Changeset: 79c1bb8fce5d Author: sspitsyn Date: 2013-01-31 20:11 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/79c1bb8fce5d 8006731: JSR 292: the VM_RedefineClasses::rewrite_cp_refs_in_method() must support invokedynamic Summary: The invokedynamic bytecode ref to a CP entry needs to be checked and fixed as well. Reviewed-by: coleenp, twisti Contributed-by: serguei.spitsyn at oracle.com ! src/share/vm/prims/jvmtiRedefineClasses.cpp Changeset: 9a9f870325cf Author: minqi Date: 2013-02-01 10:57 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/9a9f870325cf Merge Changeset: b935589d2807 Author: minqi Date: 2013-02-01 14:42 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/b935589d2807 Merge Changeset: 44c5fcd9cb25 Author: iklam Date: 2013-01-24 10:57 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/44c5fcd9cb25 8006280: Need to reorder metadata structures to reduce size (64-bit) Summary: Reordered Klass, InstanceKlass and Method to save 8 bytes each Reviewed-by: coleenp, jiangli Contributed-by: ioi.lam at oracle.com ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/klass.hpp ! src/share/vm/oops/method.hpp Changeset: 1eae78177059 Author: jiangli Date: 2013-02-01 15:25 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/1eae78177059 Merge - make/solaris/makefiles/kernel.make ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/klass.hpp ! src/share/vm/oops/method.hpp Changeset: dc8ad3fd7050 Author: jiangli Date: 2013-02-01 19:36 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/dc8ad3fd7050 Merge Changeset: 4102b59539ce Author: ctornqvi Date: 2013-02-01 23:48 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/4102b59539ce 8005012: Add WB APIs to better support NMT testing Summary: Add WB API functions to enable better NMT testing Reviewed-by: dholmes, zgu ! src/share/tools/whitebox/sun/hotspot/WhiteBox.java ! src/share/vm/memory/allocation.hpp ! src/share/vm/prims/whitebox.cpp ! src/share/vm/services/memBaseline.cpp ! src/share/vm/services/memPtr.cpp ! src/share/vm/services/memPtr.hpp ! src/share/vm/services/memRecorder.cpp ! src/share/vm/services/memRecorder.hpp ! src/share/vm/services/memTrackWorker.cpp ! src/share/vm/services/memTrackWorker.hpp ! src/share/vm/services/memTracker.cpp ! src/share/vm/services/memTracker.hpp Changeset: 4460acf8687b Author: ctornqvi Date: 2013-02-02 07:24 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/4460acf8687b Merge Changeset: 9fe95b01ad32 Author: ctornqvi Date: 2013-02-02 08:46 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/9fe95b01ad32 Merge Changeset: 43badbe2717a Author: minqi Date: 2013-01-31 17:43 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/43badbe2717a 8000973: SA on windows thread inspection is broken Summary: After bug 7161732, On Windows SA could not find correct address of thread_id of OSThread since _thread_id moved to end of the class . The presupposition of the address is following thread handle no longer stands. Fix by adding thread_id field to OSThread and getting the address directly from OSThread. Reviewed-by: nloodin, sspitsyn Contributed-by: yumin.qi at oracle.com ! agent/src/share/classes/sun/jvm/hotspot/debugger/windbg/amd64/WindbgAMD64Thread.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/windbg/x86/WindbgX86Thread.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/OSThread.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/win32_amd64/Win32AMD64JavaThreadPDAccess.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/win32_x86/Win32X86JavaThreadPDAccess.java Changeset: 65b632b77a97 Author: minqi Date: 2013-02-01 22:41 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/65b632b77a97 Merge Changeset: ff5401ad5635 Author: minqi Date: 2013-02-02 03:51 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/ff5401ad5635 Merge Changeset: 879c6de913d6 Author: ctornqvi Date: 2013-02-02 16:34 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/879c6de913d6 8005013: Add NMT tests Summary: Add tests for the Native Memory Tracking feature, includes regression tests for 8005936 and 8004802 Reviewed-by: zgu, coleenp ! test/TEST.ROOT + test/runtime/NMT/AllocTestType.java + test/runtime/NMT/BaselineWithParameter.java + test/runtime/NMT/CommandLineDetail.java + test/runtime/NMT/CommandLineEmptyArgument.java + test/runtime/NMT/CommandLineInvalidArgument.java + test/runtime/NMT/CommandLineSummary.java + test/runtime/NMT/CommandLineTurnOffNMT.java + test/runtime/NMT/JcmdScale.java + test/runtime/NMT/JcmdWithNMTDisabled.java + test/runtime/NMT/PrintNMTStatistics.java + test/runtime/NMT/PrintNMTStatisticsWithNMTDisabled.java + test/runtime/NMT/ShutdownTwice.java + test/runtime/NMT/SummaryAfterShutdown.java + test/runtime/NMT/SummarySanityCheck.java Changeset: a7f9a1195d86 Author: ctornqvi Date: 2013-02-02 20:13 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/a7f9a1195d86 8000363: runtime/7158988/FieldMonitor.java fails with exception Summary: Removed unnecessary shell script in the test. Reviewed-by: coleenp, sla ! test/runtime/7158988/FieldMonitor.java - test/runtime/7158988/TestFieldMonitor.sh Changeset: 8f696cf1a0fb Author: dsamersoff Date: 2013-02-03 22:28 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/8f696cf1a0fb 8002048: Protocol to discovery of manageable Java processes on a network Summary: Introduce a protocol to discover manageble Java instances across a network subnet, JDP Reviewed-by: sla, dfuchs ! src/share/vm/services/diagnosticCommand.cpp ! src/share/vm/services/diagnosticCommand.hpp Changeset: c4ef3380a70b Author: hseigel Date: 2013-02-03 16:49 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/c4ef3380a70b 7197672: There are issues with shared data on windows Summary: On Windows, set rw protection on the CDS file just before removing it. Reviewed-by: dcubed, iklam ! src/share/vm/memory/filemap.cpp Changeset: ce5467120c84 Author: hseigel Date: 2013-02-03 17:12 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/ce5467120c84 Merge Changeset: 10d5f25a7c67 Author: hseigel Date: 2013-02-04 08:26 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/10d5f25a7c67 8000968: NPG: UseCompressedKlassPointers asserts with ObjectAlignmentInBytes for > 32G CompressedOops Summary: Pick a base that works for both CompressedOpps alignment and CompressedKlassPtrs alignment. Reviewed-by: kvn, roland ! src/share/vm/memory/universe.cpp ! src/share/vm/memory/universe.hpp ! src/share/vm/oops/oop.inline.hpp ! src/share/vm/runtime/arguments.cpp + test/runtime/8000968/Test8000968.sh Changeset: 24a91505f9d5 Author: emc Date: 2013-02-04 13:05 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/24a91505f9d5 8006949: Update hotspot for MethodParameters format change 8006907: Hotspot should reject classfiles with multiple MethodParameters attributes Summary: Update to Hotspot's processing of MethodParameters attributes in classfiles Reviewed-by: coleenp, jrose ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/oops/constMethod.hpp ! src/share/vm/prims/jvm.cpp Changeset: 42ea5e1fad75 Author: coleenp Date: 2013-02-04 13:51 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/42ea5e1fad75 Merge Changeset: ab826603e572 Author: simonis Date: 2013-02-04 13:14 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/ab826603e572 8007475: Memory stomp with UseMallocOnly Summary: Fix off-by-one error Reviewed-by: coleenp, hseigel ! src/share/vm/classfile/stackMapFrame.hpp + test/runtime/8007475/StackMapFrameTest.java Changeset: a401757763f9 Author: coleenp Date: 2013-02-04 22:59 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/a401757763f9 Merge Changeset: 12285410684f Author: dholmes Date: 2013-02-04 23:53 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/12285410684f 8006508: Wrong frame constructor is called in os_linux_x86.cpp Reviewed-by: dholmes, coleenp Contributed-by: Jeremy Manson ! src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp ! src/os_cpu/linux_x86/vm/os_linux_x86.cpp ! src/os_cpu/windows_x86/vm/os_windows_x86.cpp Changeset: f3ea1af9207a Author: dholmes Date: 2013-02-05 00:59 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/f3ea1af9207a Merge Changeset: 454d7cc622ab Author: dcubed Date: 2013-02-06 15:22 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/454d7cc622ab Merge - agent/src/share/classes/sun/jvm/hotspot/memory/BinaryTreeDictionary.java - make/solaris/makefiles/kernel.make ! src/share/vm/gc_implementation/concurrentMarkSweep/vmStructs_cms.hpp - test/runtime/7158988/TestFieldMonitor.sh Changeset: fcc9e7681d63 Author: vlivanov Date: 2013-02-01 02:50 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/fcc9e7681d63 8006410: allocating without ResourceMark when CompileCommand was specified Reviewed-by: kvn, vlivanov Contributed-by: Igor Ignatyev ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciInstanceKlass.cpp ! src/share/vm/ci/ciMethod.cpp ! src/share/vm/ci/ciMethodData.cpp ! src/share/vm/oops/symbol.cpp Changeset: 60bba1398c51 Author: vlivanov Date: 2013-02-01 03:02 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/60bba1398c51 8005439: no message about inline method if it specifed by CompileCommand Reviewed-by: kvn, vlivanov Contributed-by: Igor Ignatyev ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/parse.hpp Changeset: e4bb0bda20a4 Author: morris Date: 2013-01-25 16:31 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/e4bb0bda20a4 8005811: Turn off TierdCompilation in JDK8 trunk for all platforms Summary: Disable tiered compilation in jdk8 because of CodeCache and performance anomalies Reviewed-by: kvn, twisti ! src/cpu/sparc/vm/c2_globals_sparc.hpp ! src/cpu/x86/vm/c2_globals_x86.hpp Changeset: 76341426b645 Author: drchase Date: 2013-01-25 16:09 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/76341426b645 8006500: compiler/8004741/Test8004741.java fails intermediately Summary: rewrote the test to be more reliable, add test for invalid size exception Reviewed-by: kvn ! test/compiler/8004741/Test8004741.java Changeset: 9fae07c31641 Author: morris Date: 2013-01-25 16:50 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/9fae07c31641 6518907: cleanup IA64 specific code in Hotspot Summary: removed unused IA64 specific code Reviewed-by: twisti, kvn, dholmes ! agent/src/os/linux/LinuxDebuggerLocal.c ! agent/src/os/linux/libproc.h ! agent/src/os/win32/windbg/sawindbg.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/windows/vm/os_windows.cpp ! src/share/vm/interpreter/bytecodeInterpreter.cpp ! src/share/vm/opto/generateOptoStub.cpp ! src/share/vm/runtime/os.cpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/synchronizer.cpp ! src/share/vm/runtime/vframeArray.cpp Changeset: 37c18711a0df Author: roland Date: 2013-02-04 09:11 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/37c18711a0df 8005114: VM is crashing in ciKlass*ciObjArrayKlass::element_klass() if metaspaces are full Summary: missing test for loaded klass in c1 Reviewed-by: kvn ! src/share/vm/c1/c1_Instruction.cpp Changeset: 39901f2f1abe Author: mikael Date: 2013-02-04 10:28 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/39901f2f1abe 8007403: Incorrect format arguments in adlparse.cpp Reviewed-by: kvn, twisti ! src/share/vm/adlc/adlparse.cpp Changeset: 8bd61471a109 Author: roland Date: 2013-02-04 11:30 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/8bd61471a109 8007144: Incremental inlining mistakes some call sites for dead ones and doesn't inline them Summary: wrong detection for dead call sites. Reviewed-by: kvn ! src/share/vm/opto/callGenerator.cpp Changeset: 6a51fc70a15e Author: vlivanov Date: 2013-02-05 08:25 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/6a51fc70a15e 8006613: adding reason to made_not_compilable Reviewed-by: kvn, vlivanov Contributed-by: Igor Ignatyev ! src/share/vm/ci/ciMethod.cpp ! src/share/vm/ci/ciMethod.hpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/method.hpp ! src/share/vm/oops/methodData.hpp ! src/share/vm/runtime/deoptimization.cpp Changeset: 4fcf990aa34a Author: drchase Date: 2013-02-06 11:33 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/4fcf990aa34a 8006807: C2 crash due to out of bounds array access in Parse::do_multianewarray Summary: check ndimensions before accessing length[i] element Reviewed-by: kvn Contributed-by: volker.simonis at gmail.com ! src/share/vm/opto/parse3.cpp Changeset: d05ff4bf41b3 Author: vlivanov Date: 2013-02-07 12:23 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/d05ff4bf41b3 Merge ! src/share/vm/oops/method.cpp ! src/share/vm/oops/method.hpp ! src/share/vm/oops/methodData.hpp Changeset: db9981fd3124 Author: jprovino Date: 2013-01-23 13:02 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/db9981fd3124 8005915: Unify SERIALGC and INCLUDE_ALTERNATE_GCS Summary: Rename INCLUDE_ALTERNATE_GCS to INCLUDE_ALL_GCS and replace SERIALGC with INCLUDE_ALL_GCS. Reviewed-by: coleenp, stefank ! make/bsd/makefiles/minimal1.make ! make/excludeSrc.make ! make/linux/makefiles/minimal1.make ! src/cpu/sparc/vm/c1_CodeStubs_sparc.cpp ! src/cpu/sparc/vm/c1_Runtime1_sparc.cpp ! src/cpu/sparc/vm/cppInterpreter_sparc.cpp ! src/cpu/sparc/vm/macroAssembler_sparc.cpp ! src/cpu/sparc/vm/macroAssembler_sparc.hpp ! src/cpu/sparc/vm/templateInterpreter_sparc.cpp ! src/cpu/sparc/vm/templateTable_sparc.cpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/c1_CodeStubs_x86.cpp ! src/cpu/x86/vm/c1_Runtime1_x86.cpp ! src/cpu/x86/vm/cppInterpreter_x86.cpp ! src/cpu/x86/vm/macroAssembler_x86.cpp ! src/cpu/x86/vm/macroAssembler_x86.hpp ! src/cpu/x86/vm/templateInterpreter_x86_32.cpp ! src/cpu/x86/vm/templateInterpreter_x86_64.cpp ! src/cpu/x86/vm/templateTable_x86_32.cpp ! src/cpu/x86/vm/templateTable_x86_64.cpp ! src/cpu/zero/vm/assembler_zero.cpp ! src/cpu/zero/vm/cppInterpreter_zero.cpp ! src/share/vm/c1/c1_CodeStubs.hpp ! src/share/vm/c1/c1_LIRGenerator.cpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciReplay.cpp ! src/share/vm/gc_implementation/g1/g1SATBCardTableModRefBS.hpp ! src/share/vm/gc_implementation/g1/heapRegion.hpp ! src/share/vm/gc_implementation/shared/allocationStats.cpp ! src/share/vm/gc_implementation/shared/allocationStats.hpp ! src/share/vm/gc_implementation/shared/concurrentGCThread.hpp ! src/share/vm/gc_implementation/shared/gSpaceCounters.cpp ! src/share/vm/gc_implementation/shared/gSpaceCounters.hpp ! src/share/vm/gc_implementation/shared/gcAdaptivePolicyCounters.hpp ! src/share/vm/gc_implementation/shared/hSpaceCounters.hpp ! src/share/vm/gc_implementation/shared/immutableSpace.cpp ! src/share/vm/gc_implementation/shared/isGCActiveMark.hpp ! src/share/vm/gc_implementation/shared/markSweep.inline.hpp ! src/share/vm/gc_implementation/shared/mutableNUMASpace.hpp ! src/share/vm/gc_implementation/shared/mutableSpace.cpp ! src/share/vm/gc_implementation/shared/spaceCounters.cpp ! src/share/vm/gc_implementation/shared/spaceCounters.hpp ! src/share/vm/gc_implementation/shared/vmGCOperations.cpp ! src/share/vm/memory/binaryTreeDictionary.cpp ! src/share/vm/memory/cardTableModRefBS.cpp ! src/share/vm/memory/cardTableRS.cpp ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/memory/collectorPolicy.hpp ! src/share/vm/memory/freeBlockDictionary.cpp ! src/share/vm/memory/freeList.cpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/generationSpec.cpp ! src/share/vm/memory/heapInspection.cpp ! src/share/vm/memory/heapInspection.hpp ! src/share/vm/memory/space.cpp ! src/share/vm/memory/space.hpp ! src/share/vm/memory/specialized_oop_closures.hpp ! src/share/vm/memory/tenuredGeneration.cpp ! src/share/vm/memory/tenuredGeneration.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/oops/cpCache.cpp ! src/share/vm/oops/instanceClassLoaderKlass.cpp ! src/share/vm/oops/instanceClassLoaderKlass.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/instanceMirrorKlass.cpp ! src/share/vm/oops/instanceMirrorKlass.hpp ! src/share/vm/oops/instanceRefKlass.cpp ! src/share/vm/oops/instanceRefKlass.hpp ! src/share/vm/oops/klass.cpp ! src/share/vm/oops/klass.hpp ! src/share/vm/oops/klassPS.hpp ! src/share/vm/oops/objArrayKlass.cpp ! src/share/vm/oops/objArrayKlass.hpp ! src/share/vm/oops/objArrayKlass.inline.hpp ! src/share/vm/oops/oop.hpp ! src/share/vm/oops/oop.inline.hpp ! src/share/vm/oops/oop.pcgc.inline.hpp ! src/share/vm/oops/oop.psgc.inline.hpp ! src/share/vm/oops/typeArrayKlass.cpp ! src/share/vm/precompiled/precompiled.hpp ! src/share/vm/prims/jni.cpp ! src/share/vm/prims/jvmtiEnvBase.hpp ! src/share/vm/prims/jvmtiExport.cpp ! src/share/vm/prims/jvmtiExport.hpp ! src/share/vm/prims/jvmtiTagMap.cpp ! src/share/vm/prims/nativeLookup.cpp ! src/share/vm/prims/unsafe.cpp ! src/share/vm/prims/whitebox.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/fprofiler.hpp ! src/share/vm/runtime/globals.cpp ! src/share/vm/runtime/globals_extension.hpp ! src/share/vm/runtime/init.cpp ! src/share/vm/runtime/java.cpp ! src/share/vm/runtime/safepoint.cpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/sharedRuntime.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/services/attachListener.hpp ! src/share/vm/services/classLoadingService.cpp ! src/share/vm/services/classLoadingService.hpp ! src/share/vm/services/diagnosticCommand.cpp ! src/share/vm/services/diagnosticCommand.hpp ! src/share/vm/services/g1MemoryPool.hpp ! src/share/vm/services/heapDumper.cpp ! src/share/vm/services/management.cpp ! src/share/vm/services/memReporter.hpp ! src/share/vm/services/memoryPool.cpp ! src/share/vm/services/memoryPool.hpp ! src/share/vm/services/memoryService.cpp ! src/share/vm/services/psMemoryPool.hpp ! src/share/vm/services/runtimeService.cpp ! src/share/vm/utilities/macros.hpp ! src/share/vm/utilities/top.hpp ! src/share/vm/utilities/yieldingWorkgroup.cpp ! src/share/vm/utilities/yieldingWorkgroup.hpp Changeset: 8391fdd36e1f Author: dlong Date: 2013-01-27 01:07 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/8391fdd36e1f Merge ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/macroAssembler_x86.cpp ! src/cpu/x86/vm/macroAssembler_x86.hpp ! src/share/vm/ci/ciReplay.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/services/heapDumper.cpp Changeset: 3c9bc17b9403 Author: bpittore Date: 2013-02-07 16:05 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/3c9bc17b9403 Merge ! src/share/vm/gc_implementation/shared/vmGCOperations.cpp ! src/share/vm/memory/binaryTreeDictionary.cpp ! src/share/vm/memory/heapInspection.cpp ! src/share/vm/memory/heapInspection.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/klass.cpp ! src/share/vm/oops/klass.hpp ! src/share/vm/oops/oop.inline.hpp ! src/share/vm/prims/jvmtiExport.cpp ! src/share/vm/prims/whitebox.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/services/attachListener.hpp ! src/share/vm/services/diagnosticCommand.cpp ! src/share/vm/services/diagnosticCommand.hpp Changeset: df8462fbe585 Author: vladidan Date: 2013-02-07 20:40 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/df8462fbe585 Merge ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/runtime/sharedRuntime.cpp Changeset: ec0c4951286c Author: stefank Date: 2013-01-29 10:51 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/ec0c4951286c 8004710: NPG: jmap could throw sun.jvm.hotspot.types.WrongTypeException after PermGen removal Summary: When calculating live object regions, make sure that the alignment reserve, at the end of a TLAB, is excluded. Reviewed-by: jmasa, brutisso ! agent/src/share/classes/sun/jvm/hotspot/oops/ObjectHeap.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/ThreadLocalAllocBuffer.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java ! src/share/vm/runtime/vmStructs.cpp Changeset: 4700e77d44c1 Author: johnc Date: 2013-02-01 13:17 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/4700e77d44c1 8006894: G1: Number of marking threads missing from PrintFlagsFinal output Summary: Set ConcGCThreads to the calculated number of marking threads. Reviewed-by: jmasa, ysr ! src/share/vm/gc_implementation/g1/concurrentMark.cpp Changeset: d9058e388631 Author: mikael Date: 2013-02-01 17:21 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/d9058e388631 8007257: NPG: metaspace.cpp: Incorrect arguments in calls to err_msg Summary: Fix size checks in assert and corrected some print formats. Also reviewed by vitalyd at gmail.com. Reviewed-by: coleenp, sspitsyn ! src/share/vm/memory/metaspace.cpp Changeset: 256d3f43c177 Author: johnc Date: 2013-01-31 10:45 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/256d3f43c177 8005875: G1: Kitchensink fails with ParallelGCThreads=0 Summary: Check that the concurrent marking worker gang exists in ConcurrentMark::print_worker_threads_on(). Changes were also reviewed by Vitaly Davidovich . Reviewed-by: brutisso ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp Changeset: 80518f4ecf32 Author: jmasa Date: 2013-02-04 12:51 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/80518f4ecf32 Merge ! src/share/vm/runtime/vmStructs.cpp Changeset: f2f0cf0f5444 Author: jmasa Date: 2013-02-04 13:26 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/f2f0cf0f5444 Merge Changeset: 06fd03af6ce4 Author: johnc Date: 2013-02-04 13:24 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/06fd03af6ce4 8001384: G1: assert(!is_null(v)) failed: narrow oop value can never be zero Summary: Flush any deferred card mark before a Java thread exits. Reviewed-by: brutisso, jmasa ! src/share/vm/runtime/thread.cpp Changeset: 84304a77c4e3 Author: johnc Date: 2013-02-04 19:40 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/84304a77c4e3 Merge Changeset: 95ccff9eee8e Author: jwilhelm Date: 2013-01-28 15:41 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/95ccff9eee8e 6348447: Specifying -XX:OldSize crashes 64-bit VMs Summary: Heap size will be set to allow for OldSize to fit. Also reviewed by vitalyd at gmail.com Reviewed-by: ehelin, jmasa ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/memory/collectorPolicy.hpp Changeset: f90b9bceb8e5 Author: johnc Date: 2013-02-05 09:13 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/f90b9bceb8e5 8005032: G1: Cleanup serial reference processing closures in concurrent marking Summary: Reuse the parallel reference processing oop closures during serial reference processing. Reviewed-by: brutisso ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp Changeset: 50d3b37d5bcd Author: johnc Date: 2013-02-05 22:24 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/50d3b37d5bcd Merge Changeset: 1135141fb97e Author: brutisso Date: 2013-02-08 10:08 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/1135141fb97e Merge ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/memory/collectorPolicy.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 412d722168bc Author: amurillo Date: 2013-02-08 08:07 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/412d722168bc Merge - agent/src/share/classes/sun/jvm/hotspot/memory/BinaryTreeDictionary.java - make/solaris/makefiles/kernel.make - test/runtime/7158988/TestFieldMonitor.sh Changeset: cdb46031e718 Author: amurillo Date: 2013-02-08 08:07 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/cdb46031e718 Added tag hs25-b18 for changeset 412d722168bc ! .hgtags Changeset: 1f84c84f8e1a Author: katleman Date: 2013-02-14 11:43 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/1f84c84f8e1a Added tag jdk8-b77 for changeset cdb46031e718 ! .hgtags Changeset: 1a0174612b49 Author: amurillo Date: 2013-02-08 08:16 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/1a0174612b49 8007801: new hotspot build - hs25-b19 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 8d9fc28831cc Author: dcubed Date: 2013-02-06 14:31 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/8d9fc28831cc 7182152: Instrumentation hot swap test incorrect monitor count Summary: Add/refine new tracing support using -XX:TraceRedefineClasses=16384. Reviewed-by: coleenp, acorn, sspitsyn ! src/share/vm/oops/cpCache.cpp ! src/share/vm/oops/cpCache.hpp ! src/share/vm/oops/klassVtable.cpp ! src/share/vm/oops/klassVtable.hpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/method.hpp ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! src/share/vm/prims/jvmtiRedefineClasses.hpp ! src/share/vm/prims/jvmtiRedefineClassesTrace.hpp ! src/share/vm/utilities/accessFlags.cpp ! src/share/vm/utilities/accessFlags.hpp Changeset: 3a88007634b0 Author: ctornqvi Date: 2013-02-08 10:42 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/3a88007634b0 8007434: Write tests for 8006298 Summary: Four tests written for 8006298 Reviewed-by: mgerdin, coleenp + test/runtime/CommandLine/BooleanFlagWithInvalidValue.java + test/runtime/CommandLine/FlagWithInvalidValue.java + test/runtime/CommandLine/NonBooleanFlagWithInvalidBooleanPrefix.java + test/runtime/CommandLine/UnrecognizedVMOption.java Changeset: 758935f7c23f Author: sla Date: 2013-02-08 12:48 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/758935f7c23f 8006423: SA: NullPointerException in sun.jvm.hotspot.debugger.bsd.BsdThread.getContext(BsdThread.java:67) Summary: Do not rely on mach thread port names to identify threads from SA Reviewed-by: dholmes, minqi, rbackman ! agent/src/os/bsd/MacosxDebuggerLocal.m ! agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebugger.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebuggerLocal.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdThread.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/bsd_amd64/BsdAMD64JavaThreadPDAccess.java ! src/os/bsd/vm/osThread_bsd.hpp ! src/os/bsd/vm/os_bsd.cpp ! src/os_cpu/bsd_x86/vm/vmStructs_bsd_x86.hpp Changeset: 7194f764221c Author: sla Date: 2013-02-08 14:05 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/7194f764221c Merge Changeset: 461a3adac4d1 Author: sspitsyn Date: 2013-02-08 09:14 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/461a3adac4d1 Merge ! src/share/vm/oops/cpCache.cpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/method.hpp Changeset: 8bf62bd86a4e Author: zgu Date: 2013-02-08 14:49 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/8bf62bd86a4e 8007791: More Restricted hs_err file permission Summary: Enforce more restricted hs_file permission Reviewed-by: acorn, dcubed, dsamersoff ! src/share/vm/utilities/vmError.cpp Changeset: 1ba5b18088a8 Author: zgu Date: 2013-02-08 14:32 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/1ba5b18088a8 Merge Changeset: 41d73c9b30a8 Author: zgu Date: 2013-02-08 16:31 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/41d73c9b30a8 8006691: Remove jvm_version_info.is_kernel_jvm field Summary: Removed is_kernel_jvm from jvm_version_info as Kernel VM has been deprecated Reviewed-by: mchung, coleenp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvm.h Changeset: 3f11b37f047c Author: zgu Date: 2013-02-08 13:55 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/3f11b37f047c Merge Changeset: f989aff6946f Author: zgu Date: 2013-02-08 16:56 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/f989aff6946f Merge Changeset: 927a311d00f9 Author: coleenp Date: 2013-02-11 14:06 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/927a311d00f9 8007320: NPG: move method annotations Summary: allocate method annotations and attach to ConstMethod if present Reviewed-by: dcubed, jiangli, sspitsyn, iklam ! agent/src/share/classes/sun/jvm/hotspot/oops/ConstMethod.java ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/classFileParser.hpp ! src/share/vm/classfile/defaultMethods.cpp ! src/share/vm/memory/heapInspection.hpp ! src/share/vm/oops/annotations.cpp ! src/share/vm/oops/annotations.hpp ! src/share/vm/oops/constMethod.cpp ! src/share/vm/oops/constMethod.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/method.hpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! src/share/vm/prims/jvmtiRedefineClasses.hpp ! src/share/vm/runtime/fieldDescriptor.cpp ! src/share/vm/runtime/vmStructs.cpp + test/runtime/8007320/ConstMethodTest.java Changeset: 5ee2b330eacd Author: zgu Date: 2013-02-12 12:19 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/5ee2b330eacd 8007950: Undo hs_file permission change Summary: Reverse hs_err file permission back to 0666, as early push was premature Reviewed-by: dsamersoff, dcubed, acorn ! src/share/vm/utilities/vmError.cpp Changeset: deb43b8a436e Author: sspitsyn Date: 2013-02-13 08:42 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/deb43b8a436e Merge Changeset: bce1ac447f6b Author: johnc Date: 2013-02-06 14:50 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/bce1ac447f6b 7052429: G1: Avoid unnecessary scanning of humongous regions during concurrent marking Summary: Skip unnecessary scanning of bitmap for unmarked humongous objects/regions. Reviewed-by: jwilhelm, johnc Contributed-by: Tao Mao ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/runtime/globals.hpp Changeset: f64ffbf81af5 Author: jwilhelm Date: 2013-02-07 15:51 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/f64ffbf81af5 8006432: Ratio flags should be unsigned Summary: Flags changed to be of uintx type Reviewed-by: johnc, tamao ! src/cpu/zero/vm/shark_globals_zero.hpp ! src/os_cpu/bsd_x86/vm/globals_bsd_x86.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp ! src/share/vm/gc_implementation/g1/g1_globals.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: 5d8325eb8240 Author: brutisso Date: 2013-02-07 22:04 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/5d8325eb8240 Merge ! src/share/vm/runtime/thread.cpp Changeset: 9425ba04792d Author: brutisso Date: 2013-02-07 18:40 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/9425ba04792d Merge - agent/src/share/classes/sun/jvm/hotspot/memory/BinaryTreeDictionary.java - make/solaris/makefiles/kernel.make ! src/share/vm/runtime/arguments.cpp - test/runtime/7158988/TestFieldMonitor.sh Changeset: ad747ee9d0b1 Author: brutisso Date: 2013-02-10 21:15 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/ad747ee9d0b1 8002144: G1: large number of evacuation failures may lead to large c heap memory usage Summary: Use Stack<> instead of GrowableArray to keep track of preserved marks. Also reviewed by vitalyd at gmail.com. Reviewed-by: johnc, jcoomes ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp Changeset: 5e401ef52ec0 Author: johnc Date: 2013-02-11 15:24 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/5e401ef52ec0 8007772: G1: assert(!hr->isHumongous() || mr.start() == hr->bottom()) failed: the start of HeapRegion and MemRegion should be consistent for humongous regions Summary: In do_marking_step(), we should always give up current region after scanning the object, if the region is humongous. Reviewed-by: brutisso, jwilhelm, tamao ! src/share/vm/gc_implementation/g1/concurrentMark.cpp Changeset: a83cd101fd62 Author: jmasa Date: 2013-01-23 19:08 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/a83cd101fd62 8005452: NPG: Create new flags for Metaspace resizing policy Reviewed-by: johnc, jwilhelm, coleenp, stefank ! src/share/vm/memory/metaspace.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: b8d5d7a6c94c Author: brutisso Date: 2013-02-14 11:01 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/b8d5d7a6c94c Merge ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/thread.cpp Changeset: 91a23b11d8dc Author: kvn Date: 2013-02-08 15:07 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/91a23b11d8dc 8007708: compiler/6855215 assert(VM_Version::supports_sse4_2()) Summary: Added missing UseSSE42 check. Also added missing avx2 assert for vpermq instruction. Reviewed-by: roland, twisti ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/macroAssembler_x86.cpp Changeset: 309460dcedf7 Author: morris Date: 2013-02-08 15:39 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/309460dcedf7 8006851: When TieredCompilation is set, max code cache should be bumped to 256mb Summary: Set ReservedCodeCacheSize to (default value)*5 when TieredCompilation is on. Reviewed-by: kvn, twisti ! src/share/vm/runtime/arguments.cpp Changeset: 2c673161698a Author: drchase Date: 2013-02-09 12:55 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/2c673161698a 8007402: Code cleanup to remove Parfait false positive Summary: add array access range check Reviewed-by: kvn ! src/share/vm/opto/regmask.cpp ! src/share/vm/opto/regmask.hpp Changeset: 64d2a0a39954 Author: kmo Date: 2013-02-10 22:35 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/64d2a0a39954 8006430: TraceTypeProfile is a product flag while it should be a diagnostic flag Summary: make sure all diagnostic and experimental flag kinds are checked in Flag::is_unlocked() Reviewed-by: kvn ! src/share/vm/runtime/globals.cpp Changeset: a9c29dfc7d73 Author: morris Date: 2013-02-11 10:38 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/a9c29dfc7d73 8003251: ARM: move MacroAssembler into separate file Summary: moved MacroAssembler into separate file Reviewed-by: twisti, kvn, dlong ! src/share/vm/asm/macroAssembler.hpp ! src/share/vm/asm/macroAssembler.inline.hpp Changeset: 1e5e28bac299 Author: morris Date: 2013-02-11 14:47 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/1e5e28bac299 8003252: PPC: move MacroAssembler into separate file Summary: moved MacroAssembler into separate file Reviewed-by: twisti, kvn, dlong ! src/share/vm/asm/macroAssembler.hpp ! src/share/vm/asm/macroAssembler.inline.hpp Changeset: 8b3da8d14c93 Author: roland Date: 2013-02-12 12:56 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/8b3da8d14c93 7197327: 40% regression on 8 b41 comp 8 b40 on specjvm2008.mpegaudio on oob Summary: Add support for expensive nodes. Reviewed-by: kvn ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/loopnode.cpp ! src/share/vm/opto/loopnode.hpp ! src/share/vm/opto/node.cpp ! src/share/vm/opto/node.hpp ! src/share/vm/opto/phaseX.cpp ! src/share/vm/opto/subnode.hpp Changeset: c703f9c4b025 Author: kmo Date: 2013-02-12 07:39 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/c703f9c4b025 8002169: TEST_BUG: compiler/7009359/Test7009359.java sometimes times out Summary: make the test less prone to timeout by reducing the amount of iteration and allowing main to be compiled Reviewed-by: jrose ! test/compiler/7009359/Test7009359.java Changeset: aaad39923cdb Author: kmo Date: 2013-02-12 14:33 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/aaad39923cdb Merge Changeset: 12e01444ca2d Author: iignatyev Date: 2013-02-13 08:29 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/12e01444ca2d 8006683: Add WhiteBox API to testing of compiler Reviewed-by: kvn, vlivanov ! src/share/tools/whitebox/sun/hotspot/WhiteBox.java ! src/share/vm/prims/wbtestmethods/parserTests.hpp ! src/share/vm/prims/whitebox.cpp ! src/share/vm/prims/whitebox.hpp + test/compiler/whitebox/CompilerWhiteBoxTest.java + test/compiler/whitebox/DeoptimizeAllTest.java + test/compiler/whitebox/DeoptimizeMethodTest.java + test/compiler/whitebox/IsMethodCompilableTest.java + test/compiler/whitebox/MakeMethodNotCompilableTest.java + test/compiler/whitebox/SetDontInlineMethodTest.java Changeset: 1cdf241a4b26 Author: vlivanov Date: 2013-02-14 05:36 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/1cdf241a4b26 Merge ! src/share/vm/runtime/arguments.cpp Changeset: 9f19f4a7d48a Author: amurillo Date: 2013-02-15 13:27 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/9f19f4a7d48a Merge Changeset: d5e12e7d2f71 Author: amurillo Date: 2013-02-15 13:27 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/d5e12e7d2f71 Added tag hs25-b19 for changeset 9f19f4a7d48a ! .hgtags From james.laskey at oracle.com Fri Feb 22 09:24:56 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Fri, 22 Feb 2013 17:24:56 +0000 Subject: hg: nashorn/jdk8/jaxws: 5 new changesets Message-ID: <20130222172509.84D2447CBB@hg.openjdk.java.net> Changeset: a63ef2391c20 Author: katleman Date: 2013-01-31 17:04 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxws/rev/a63ef2391c20 Added tag jdk8-b75 for changeset 966bf9f3c41a ! .hgtags Changeset: 54beebb17494 Author: ohrstrom Date: 2013-01-31 14:02 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxws/rev/54beebb17494 8006872: Stop creating four jars with identical content in the new build system. Reviewed-by: erikj ! makefiles/BuildJaxws.gmk Changeset: c4853f3f0e89 Author: katleman Date: 2013-02-05 18:54 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxws/rev/c4853f3f0e89 Merge Changeset: 64dfba1bad16 Author: katleman Date: 2013-02-07 12:33 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxws/rev/64dfba1bad16 Added tag jdk8-b76 for changeset c4853f3f0e89 ! .hgtags Changeset: 391de4c992d1 Author: katleman Date: 2013-02-14 11:43 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxws/rev/391de4c992d1 Added tag jdk8-b77 for changeset 64dfba1bad16 ! .hgtags From james.laskey at oracle.com Fri Feb 22 09:24:30 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Fri, 22 Feb 2013 17:24:30 +0000 Subject: hg: nashorn/jdk8/jaxp: 7 new changesets Message-ID: <20130222172450.5700047CB8@hg.openjdk.java.net> Changeset: 8d65b381880b Author: katleman Date: 2013-01-31 17:04 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxp/rev/8d65b381880b Added tag jdk8-b75 for changeset ff0b73a6b3f6 ! .hgtags Changeset: f0ad3747b40e Author: emc Date: 2013-02-05 14:56 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxp/rev/f0ad3747b40e 8007389: Remove uses of _ as identifier in jaxp Reviewed-by: lancea, joehw ! src/javax/xml/validation/SchemaFactoryFinder.java ! src/javax/xml/xpath/XPathFactoryFinder.java Changeset: 8f6ca8755f46 Author: ohrstrom Date: 2013-01-31 14:02 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxp/rev/8f6ca8755f46 8006872: Stop creating four jars with identical content in the new build system. Reviewed-by: erikj ! makefiles/BuildJaxp.gmk Changeset: 0c08593944d0 Author: katleman Date: 2013-02-05 18:54 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxp/rev/0c08593944d0 Merge Changeset: 02195d0e96b9 Author: katleman Date: 2013-02-07 12:32 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxp/rev/02195d0e96b9 Added tag jdk8-b76 for changeset 0c08593944d0 ! .hgtags Changeset: 573e789c187a Author: lana Date: 2013-02-11 16:12 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxp/rev/573e789c187a Merge Changeset: 00958c5a7070 Author: katleman Date: 2013-02-14 11:43 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxp/rev/00958c5a7070 Added tag jdk8-b77 for changeset 573e789c187a ! .hgtags From james.laskey at oracle.com Fri Feb 22 09:33:50 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Fri, 22 Feb 2013 17:33:50 +0000 Subject: hg: nashorn/jdk8/langtools: 62 new changesets Message-ID: <20130222173642.24D1047CC5@hg.openjdk.java.net> Changeset: 1690928dc560 Author: jjg Date: 2013-02-04 15:30 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/1690928dc560 8007490: NPE from DocumentationTool.run Reviewed-by: darcy ! src/share/classes/com/sun/tools/javadoc/api/JavadocTool.java ! test/tools/javadoc/api/basic/RunTest.java Changeset: 62d91c13dce2 Author: jjg Date: 2013-02-04 18:14 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/62d91c13dce2 8007492: DocumentationTool cannot locate standard doclet when invoked from JRE Reviewed-by: darcy ! src/share/classes/com/sun/tools/javadoc/api/JavadocTool.java Changeset: 716935fec613 Author: katleman Date: 2013-01-31 17:04 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/716935fec613 Added tag jdk8-b75 for changeset c2e11e2ec4a3 ! .hgtags Changeset: 10619513f51a Author: lana Date: 2013-02-04 22:38 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/10619513f51a Merge Changeset: 2480aec9a3f1 Author: jjh Date: 2013-02-05 18:55 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/2480aec9a3f1 8007504: Remove @ignore from tests that no longer need it Reviewed-by: mcimadamore ! test/tools/javac/api/T6306137.java ! test/tools/javac/defaultMethods/TestNoBridgeOnDefaults.java ! test/tools/javac/lambda/LambdaCapture06.java ! test/tools/javac/lambda/LambdaExpr15.java Changeset: de932285124c Author: jjg Date: 2013-02-05 21:55 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/de932285124c 8007485: test creates .class files in the test/ directory Reviewed-by: mcimadamore ! test/tools/javac/api/8007344/Test.java Changeset: 1df20330f6bd Author: mcimadamore Date: 2013-02-06 14:03 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/1df20330f6bd 8007463: Cleanup inference related classes Summary: Make Infer.InferenceContext an inner class; adjust bound replacement logic in Type.UndetVar Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/util/List.java ! test/tools/javac/generics/inference/7154127/T7154127.out ! test/tools/javac/lib/DPrinter.java Changeset: 8cdd96f2fdb9 Author: mcimadamore Date: 2013-02-06 14:04 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/8cdd96f2fdb9 8007479: Refactor DeferredAttrContext so that it points to parent context Summary: Move DeferredAttrNode out of DeferredAttrContext; add support for nested deferred contexts Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java Changeset: 153d20d0cac5 Author: jjg Date: 2013-02-06 07:49 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/153d20d0cac5 8007566: DocLint too aggressive with not allowed here:

Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/doclint/Checker.java + test/tools/doclint/ParaTagTest.java Changeset: b386b8c45387 Author: jjh Date: 2013-02-06 23:10 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/b386b8c45387 8007698: jtreg test T6306137.java won't compile with ASCII encoding Reviewed-by: ksrini ! test/tools/javac/api/T6306137.java Changeset: 5125b9854d07 Author: darcy Date: 2013-02-07 20:47 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/5125b9854d07 7195131: Update 2 compiler combo tests for repeating annotations to include package and default use cases Reviewed-by: darcy Contributed-by: sonali.goel at oracle.com ! test/tools/javac/annotations/repeatingAnnotations/combo/Helper.java + test/tools/javac/annotations/repeatingAnnotations/combo/TargetAnnoCombo.java + test/tools/javac/annotations/repeatingAnnotations/combo/TestCaseGenerator.java Changeset: 762d0af062f5 Author: vromero Date: 2013-02-08 09:12 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/762d0af062f5 7166455: javac doesn't set ACC_STRICT bit on for strictfp class Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java + test/tools/javac/7166455/CheckACC_STRICTFlagOnclinitTest.java Changeset: b1deb90d2e37 Author: vromero Date: 2013-02-08 09:15 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/b1deb90d2e37 8005931: javac doesn't set ACC_STRICT for classes with package access Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java + test/tools/javac/8005931/CheckACC_STRICTFlagOnPkgAccessClassTest.java Changeset: 017e8bdd440f Author: vromero Date: 2013-02-08 09:21 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/017e8bdd440f 7167125: Two variables after the same operation in a inner class return different results Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Lower.java + test/tools/javac/7167125/DiffResultAfterSameOperationInnerClasses.java Changeset: 60caf53b98e2 Author: jjg Date: 2013-02-08 17:35 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/60caf53b98e2 8007610: javadoc doclint does not work with -private Reviewed-by: darcy ! src/share/classes/com/sun/tools/javadoc/DocEnv.java ! test/com/sun/javadoc/T6735320/T6735320.java ! test/tools/javadoc/doclint/DocLintTest.java Changeset: 01af1b5c631d Author: darcy Date: 2013-02-11 13:37 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/01af1b5c631d 8007574: Provide isFunctionalInterface in javax.lang.model Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/model/JavacElements.java ! src/share/classes/javax/lang/model/element/TypeElement.java ! src/share/classes/javax/lang/model/util/Elements.java + test/tools/javac/processing/model/util/elements/TestIsFunctionalInterface.java Changeset: 973646bf043a Author: jfranck Date: 2013-02-12 11:28 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/973646bf043a 8004822: RFE to write language model API tests for repeating annotations based on the spec updates Reviewed-by: jjg, abuckley Contributed-by: Matherey Nunez + test/tools/javac/processing/model/element/repeatingAnnotations/ElementRepAnnoTester.java + test/tools/javac/processing/model/element/repeatingAnnotations/MixRepeatableAndOfficialContainerBasicTest.java + test/tools/javac/processing/model/element/repeatingAnnotations/MixRepeatableAndOfficialContainerInheritedA1Test.java + test/tools/javac/processing/model/element/repeatingAnnotations/MixRepeatableAndOfficialContainerInheritedA2Test.java + test/tools/javac/processing/model/element/repeatingAnnotations/MixRepeatableAndOfficialContainerInheritedB1Test.java + test/tools/javac/processing/model/element/repeatingAnnotations/MixRepeatableAndOfficialContainerInheritedB2Test.java + test/tools/javac/processing/model/element/repeatingAnnotations/MixSingularAndUnofficialContainerBasicTest.java + test/tools/javac/processing/model/element/repeatingAnnotations/MixSingularAndUnofficialContainerInheritedA1Test.java + test/tools/javac/processing/model/element/repeatingAnnotations/MixSingularAndUnofficialContainerInheritedA2Test.java + test/tools/javac/processing/model/element/repeatingAnnotations/MixSingularAndUnofficialContainerInheritedB1Test.java + test/tools/javac/processing/model/element/repeatingAnnotations/MixSingularAndUnofficialContainerInheritedB2Test.java + test/tools/javac/processing/model/element/repeatingAnnotations/OfficialContainerBasicTest.java + test/tools/javac/processing/model/element/repeatingAnnotations/OfficialContainerInheritedTest.java + test/tools/javac/processing/model/element/repeatingAnnotations/RepeatableBasicTest.java + test/tools/javac/processing/model/element/repeatingAnnotations/RepeatableInheritedTest.java + test/tools/javac/processing/model/element/repeatingAnnotations/RepeatableOfficialContainerBasicTest.java + test/tools/javac/processing/model/element/repeatingAnnotations/RepeatableOfficialContainerInheritedTest.java + test/tools/javac/processing/model/element/repeatingAnnotations/RepeatableOverrideATest.java + test/tools/javac/processing/model/element/repeatingAnnotations/RepeatableOverrideBTest.java + test/tools/javac/processing/model/element/repeatingAnnotations/SingularBasicTest.java + test/tools/javac/processing/model/element/repeatingAnnotations/SingularInheritedATest.java + test/tools/javac/processing/model/element/repeatingAnnotations/SingularInheritedBTest.java + test/tools/javac/processing/model/element/repeatingAnnotations/UnofficialContainerBasicTest.java + test/tools/javac/processing/model/element/repeatingAnnotations/UnofficialContainerInheritedTest.java + test/tools/javac/processing/model/element/repeatingAnnotations/supportingAnnotations/Bar.java + test/tools/javac/processing/model/element/repeatingAnnotations/supportingAnnotations/BarContainer.java + test/tools/javac/processing/model/element/repeatingAnnotations/supportingAnnotations/BarContainerContainer.java + test/tools/javac/processing/model/element/repeatingAnnotations/supportingAnnotations/BarInherited.java + test/tools/javac/processing/model/element/repeatingAnnotations/supportingAnnotations/BarInheritedContainer.java + test/tools/javac/processing/model/element/repeatingAnnotations/supportingAnnotations/BarInheritedContainerContainer.java + test/tools/javac/processing/model/element/repeatingAnnotations/supportingAnnotations/ExpectedBase.java + test/tools/javac/processing/model/element/repeatingAnnotations/supportingAnnotations/ExpectedContainer.java + test/tools/javac/processing/model/element/repeatingAnnotations/supportingAnnotations/Foo.java + test/tools/javac/processing/model/element/repeatingAnnotations/supportingAnnotations/FooInherited.java + test/tools/javac/processing/model/element/repeatingAnnotations/supportingAnnotations/UnofficialContainer.java + test/tools/javac/processing/model/element/repeatingAnnotations/supportingAnnotations/UnofficialInheritedContainer.java Changeset: 073696f59241 Author: vromero Date: 2013-02-12 13:36 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/073696f59241 8006334: javap, JavapTask constructor breaks with null pointer exception if parameter options is null Reviewed-by: jjg ! src/share/classes/com/sun/tools/javap/JavapTask.java + test/tools/javap/8006334/JavapTaskCtorFailWithNPE.java Changeset: 2154ed9ff6c8 Author: mcimadamore Date: 2013-02-12 19:25 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/2154ed9ff6c8 8007464: Add graph inference support Summary: Add support for more aggressive type-inference scheme Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java + src/share/classes/com/sun/tools/javac/util/GraphUtils.java ! test/tools/javac/6758789/T6758789b.out ! test/tools/javac/Diagnostics/6799605/T6799605.out ! test/tools/javac/diags/examples/CantApplyDiamond1.java ! test/tools/javac/diags/examples/InferredDoNotConformToEq.java ! test/tools/javac/diags/examples/InferredDoNotConformToUpper.java ! test/tools/javac/diags/examples/WhereFreshTvar.java ! test/tools/javac/generics/7015430/T7015430.out ! test/tools/javac/generics/7151802/T7151802.out ! test/tools/javac/generics/diamond/neg/Neg06.out ! test/tools/javac/generics/inference/6278587/T6278587Neg.java ! test/tools/javac/generics/inference/6638712/T6638712d.out ! test/tools/javac/generics/inference/6638712/T6638712e.out ! test/tools/javac/generics/inference/7154127/T7154127.java ! test/tools/javac/generics/inference/7154127/T7154127.out ! test/tools/javac/generics/inference/7177306/T7177306a.out ! test/tools/javac/generics/inference/7177306/T7177306e.java ! test/tools/javac/generics/inference/7177306/T7177306e.out ! test/tools/javac/generics/odersky/BadTest4.java ! test/tools/javac/lambda/TargetType14.out ! test/tools/javac/lambda/TargetType20.java - test/tools/javac/lambda/TargetType20.out ! test/tools/javac/lambda/TargetType28.out ! test/tools/javac/lambda/TargetType50.java - test/tools/javac/lambda/TargetType50.out ! test/tools/javac/lambda/TargetType51.java ! test/tools/javac/lambda/TargetType52.java ! test/tools/javac/lambda/TargetType52.out + test/tools/javac/lambda/TargetType53.java + test/tools/javac/lambda/TargetType54.java + test/tools/javac/lambda/TargetType55.java + test/tools/javac/lambda/TargetType56.java + test/tools/javac/lambda/TargetType57.java + test/tools/javac/lambda/TargetType57.out + test/tools/javac/lambda/TargetType58.java + test/tools/javac/lambda/TargetType59.java + test/tools/javac/lambda/TargetType61.java + test/tools/javac/lambda/TargetType62.java Changeset: bc456436c613 Author: jjg Date: 2013-02-12 17:15 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/bc456436c613 8008077: update reference impl for type-annotations Reviewed-by: jjg Contributed-by: wmdietl at cs.washington.edu ! src/share/classes/com/sun/tools/classfile/ClassWriter.java ! src/share/classes/com/sun/tools/classfile/TypeAnnotation.java ! src/share/classes/com/sun/tools/javac/code/TargetType.java ! src/share/classes/com/sun/tools/javac/code/TypeAnnotationPosition.java ! src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! src/share/classes/com/sun/tools/javap/AnnotationWriter.java + test/tools/javac/annotations/typeAnnotations/failures/LazyConstantValue.java + test/tools/javac/annotations/typeAnnotations/failures/TypeVariable.java ! test/tools/javac/annotations/typeAnnotations/failures/VoidGenericMethod.java + test/tools/javac/annotations/typeAnnotations/newlocations/Lambda.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/Lambda.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/MethodParameters.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/TypeCasts.java Changeset: aeadaf905d78 Author: jfranck Date: 2013-02-13 10:33 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/aeadaf905d78 8007279: Rename javax.l.model.element.Element.getAnnotations(Class) to getAnnotationsByType(Class) Reviewed-by: darcy, abuckley ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/javax/lang/model/element/Element.java ! test/tools/javac/processing/model/element/repeatingAnnotations/ElementRepAnnoTester.java Changeset: d04960f05593 Author: mcimadamore Date: 2013-02-13 17:04 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/d04960f05593 8006345: Report Synthesized Parameters in java.lang.reflect.Parameter API 8006896: ClassReader doesn't see MethodParameters attr for method of anon inner class 8007098: Output Synthesized Parameters to MethodParameters Attributes Summary: Correctly report synthesized and mandated parameters Reviewed-by: mcimadamore, jjg Contributed-by: eric.mccorkle at oracle.com ! src/share/classes/com/sun/tools/classfile/AccessFlags.java ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javap/AttributeWriter.java Changeset: 2d6789a725a4 Author: ohrstrom Date: 2013-01-31 14:01 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/2d6789a725a4 8006872: Stop creating four jars with identical content in the new build system. Reviewed-by: erikj ! makefiles/BuildLangtools.gmk Changeset: e81839b32337 Author: katleman Date: 2013-02-05 18:55 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/e81839b32337 Merge Changeset: 6fde20398015 Author: katleman Date: 2013-02-07 12:33 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/6fde20398015 Added tag jdk8-b76 for changeset e81839b32337 ! .hgtags Changeset: 89c664151689 Author: lana Date: 2013-02-11 16:15 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/89c664151689 Merge Changeset: 3f9875aa5d67 Author: lana Date: 2013-02-13 11:25 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/3f9875aa5d67 Merge Changeset: 63872da94576 Author: darcy Date: 2013-02-13 23:05 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/63872da94576 8001457: New tests needed for library-side changes for repeating annotations Reviewed-by: darcy Contributed-by: sonali.goel at oracle.com ! test/tools/javac/annotations/repeatingAnnotations/combo/Helper.java + test/tools/javac/annotations/repeatingAnnotations/combo/ReflectionTest.java + test/tools/javac/annotations/repeatingAnnotations/combo/expectedFiles/ExpectedBase.java + test/tools/javac/annotations/repeatingAnnotations/combo/expectedFiles/ExpectedContainer.java Changeset: 88286a36bb34 Author: mchung Date: 2013-02-14 09:43 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/88286a36bb34 8006225: tools/jdeps/Basic.java failes with AssertionError Reviewed-by: alanb + src/share/classes/com/sun/tools/jdeps/Analyzer.java ! src/share/classes/com/sun/tools/jdeps/Archive.java ! src/share/classes/com/sun/tools/jdeps/JdepsTask.java ! test/tools/jdeps/Basic.java Changeset: 040f02711b73 Author: jjg Date: 2013-02-15 08:28 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/040f02711b73 8007052: javap should include the descriptor for a method in verbose mode Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javap/ClassWriter.java ! src/share/classes/com/sun/tools/javap/JavapTask.java ! src/share/classes/com/sun/tools/javap/Options.java + test/tools/javap/DescriptorTest.java Changeset: 0baaae675b19 Author: mcimadamore Date: 2013-02-15 16:28 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/0baaae675b19 8006749: compiler does not allow Object protected methods to be used in lambda Summary: Check.checkFunctionalInterface should take into account 'fake' override Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/lambda/LambdaConv26.java Changeset: f6e667f52af4 Author: mcimadamore Date: 2013-02-15 16:28 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/f6e667f52af4 8007285: AbstractMethodError instead of compile-time error when method reference with super and abstract Summary: Missing abstractness check on super rmethod references Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java + test/tools/javac/lambda/MethodReference62.java + test/tools/javac/lambda/MethodReference62.out Changeset: 4ff468de829d Author: mcimadamore Date: 2013-02-15 16:29 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/4ff468de829d 8007462: Fix provisional applicability for method references Summary: Add speculative arity-based check to rule out potential candidates when stuck reference is passed to method Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties + test/tools/javac/diags/examples/IncompatibleArgTypesInMethodRef.java + test/tools/javac/lambda/TargetType60.java + test/tools/javac/lambda/TargetType60.out Changeset: 3cd997b9fd84 Author: mcimadamore Date: 2013-02-15 16:30 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/3cd997b9fd84 8007535: Compiler crashes on @FunctionalInterface used on interface with two inherited methods with same signatures Summary: Bad check in Types.interfaceCandidates Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Types.java + test/tools/javac/lambda/FunctionalInterfaceAnno02.java Changeset: 186023614cd3 Author: mcimadamore Date: 2013-02-15 16:31 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/186023614cd3 8007427: Annotation element as '_' gives compiler error instead of a warning 8007401: Write test to check for generation of warnings when '_' is used as an identifier Summary: Extended identifier production not used in annotation values Reviewed-by: jjg Contributed-by: sonali.goel at oracle.com ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java + test/tools/javac/lambda/IdentifierTest.java + test/tools/javac/lambda/IdentifierTest.out Changeset: 258c72fa7fa2 Author: mcimadamore Date: 2013-02-15 16:37 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/258c72fa7fa2 Merge Changeset: da2f7dd53915 Author: mcimadamore Date: 2013-02-15 18:13 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/da2f7dd53915 8008309: TargetType60 fails because of bad golden file Summary: bad golden file Reviewed-by: jjg ! test/tools/javac/lambda/TargetType60.out Changeset: 9fb4f223a90d Author: jjg Date: 2013-02-15 11:26 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/9fb4f223a90d 8008313: 8007052 breaks test/tools/javap/MethodParameters.java Reviewed-by: darcy ! test/tools/javap/MethodParameters.java Changeset: f1f605f85850 Author: rfield Date: 2013-02-15 18:40 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/f1f605f85850 8004969: Generate $deserializeLambda$ method 8006763: super in method reference used in anonymous class - ClassFormatError is produced 8005632: Inner classes within lambdas cause build failures 8005653: Lambdas containing inner classes referencing external type variables do not correctly parameterize the inner classes Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/util/Names.java + test/tools/javac/lambda/LambdaInnerTypeVarArgs.java + test/tools/javac/lambda/LambdaInnerTypeVarReflect.java + test/tools/javac/lambda/MethodReference61.java Changeset: 2620c953e9fe Author: vromero Date: 2013-02-18 14:33 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/2620c953e9fe 6563143: javac should issue a warning for overriding equals without hashCode Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/code/Lint.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/sjavac/comp/Dependencies.java + test/tools/javac/6563143/OverridesEqualsButNotHashCodeTest.java + test/tools/javac/6563143/OverridesEqualsButNotHashCodeTest.out ! test/tools/javac/diags/examples.not-yet.txt Changeset: 87884cd0fea3 Author: jjg Date: 2013-02-18 14:29 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/87884cd0fea3 8008339: Test TargetAnnoCombo.java is broken Reviewed-by: jjh ! test/tools/javac/annotations/repeatingAnnotations/combo/TargetAnnoCombo.java Changeset: 011cf7e0a148 Author: darcy Date: 2013-02-19 00:31 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/011cf7e0a148 8008267: Add @Supported annotation to com.sun.source types Reviewed-by: jjg ! src/share/classes/com/sun/source/doctree/AttributeTree.java ! src/share/classes/com/sun/source/doctree/AuthorTree.java ! src/share/classes/com/sun/source/doctree/BlockTagTree.java ! src/share/classes/com/sun/source/doctree/CommentTree.java ! src/share/classes/com/sun/source/doctree/DeprecatedTree.java ! src/share/classes/com/sun/source/doctree/DocCommentTree.java ! src/share/classes/com/sun/source/doctree/DocRootTree.java ! src/share/classes/com/sun/source/doctree/DocTree.java ! src/share/classes/com/sun/source/doctree/DocTreeVisitor.java ! src/share/classes/com/sun/source/doctree/EndElementTree.java ! src/share/classes/com/sun/source/doctree/EntityTree.java ! src/share/classes/com/sun/source/doctree/ErroneousTree.java ! src/share/classes/com/sun/source/doctree/IdentifierTree.java ! src/share/classes/com/sun/source/doctree/InheritDocTree.java ! src/share/classes/com/sun/source/doctree/InlineTagTree.java ! src/share/classes/com/sun/source/doctree/LinkTree.java ! src/share/classes/com/sun/source/doctree/LiteralTree.java ! src/share/classes/com/sun/source/doctree/ParamTree.java ! src/share/classes/com/sun/source/doctree/ReferenceTree.java ! src/share/classes/com/sun/source/doctree/ReturnTree.java ! src/share/classes/com/sun/source/doctree/SeeTree.java ! src/share/classes/com/sun/source/doctree/SerialDataTree.java ! src/share/classes/com/sun/source/doctree/SerialFieldTree.java ! src/share/classes/com/sun/source/doctree/SerialTree.java ! src/share/classes/com/sun/source/doctree/SinceTree.java ! src/share/classes/com/sun/source/doctree/StartElementTree.java ! src/share/classes/com/sun/source/doctree/TextTree.java ! src/share/classes/com/sun/source/doctree/ThrowsTree.java ! src/share/classes/com/sun/source/doctree/UnknownBlockTagTree.java ! src/share/classes/com/sun/source/doctree/UnknownInlineTagTree.java ! src/share/classes/com/sun/source/doctree/ValueTree.java ! src/share/classes/com/sun/source/doctree/VersionTree.java ! src/share/classes/com/sun/source/doctree/package-info.java ! src/share/classes/com/sun/source/tree/AnnotatedTypeTree.java ! src/share/classes/com/sun/source/tree/AnnotationTree.java ! src/share/classes/com/sun/source/tree/ArrayAccessTree.java ! src/share/classes/com/sun/source/tree/ArrayTypeTree.java ! src/share/classes/com/sun/source/tree/AssertTree.java ! src/share/classes/com/sun/source/tree/AssignmentTree.java ! src/share/classes/com/sun/source/tree/BinaryTree.java ! src/share/classes/com/sun/source/tree/BlockTree.java ! src/share/classes/com/sun/source/tree/BreakTree.java ! src/share/classes/com/sun/source/tree/CaseTree.java ! src/share/classes/com/sun/source/tree/CatchTree.java ! src/share/classes/com/sun/source/tree/ClassTree.java ! src/share/classes/com/sun/source/tree/CompilationUnitTree.java ! src/share/classes/com/sun/source/tree/CompoundAssignmentTree.java ! src/share/classes/com/sun/source/tree/ConditionalExpressionTree.java ! src/share/classes/com/sun/source/tree/ContinueTree.java ! src/share/classes/com/sun/source/tree/DoWhileLoopTree.java ! src/share/classes/com/sun/source/tree/EmptyStatementTree.java ! src/share/classes/com/sun/source/tree/EnhancedForLoopTree.java ! src/share/classes/com/sun/source/tree/ErroneousTree.java ! src/share/classes/com/sun/source/tree/ExpressionStatementTree.java ! src/share/classes/com/sun/source/tree/ExpressionTree.java ! src/share/classes/com/sun/source/tree/ForLoopTree.java ! src/share/classes/com/sun/source/tree/IdentifierTree.java ! src/share/classes/com/sun/source/tree/IfTree.java ! src/share/classes/com/sun/source/tree/ImportTree.java ! src/share/classes/com/sun/source/tree/InstanceOfTree.java ! src/share/classes/com/sun/source/tree/IntersectionTypeTree.java ! src/share/classes/com/sun/source/tree/LabeledStatementTree.java ! src/share/classes/com/sun/source/tree/LambdaExpressionTree.java ! src/share/classes/com/sun/source/tree/LineMap.java ! src/share/classes/com/sun/source/tree/LiteralTree.java ! src/share/classes/com/sun/source/tree/MemberReferenceTree.java ! src/share/classes/com/sun/source/tree/MemberSelectTree.java ! src/share/classes/com/sun/source/tree/MethodInvocationTree.java ! src/share/classes/com/sun/source/tree/MethodTree.java ! src/share/classes/com/sun/source/tree/ModifiersTree.java ! src/share/classes/com/sun/source/tree/NewArrayTree.java ! src/share/classes/com/sun/source/tree/NewClassTree.java ! src/share/classes/com/sun/source/tree/ParameterizedTypeTree.java ! src/share/classes/com/sun/source/tree/ParenthesizedTree.java ! src/share/classes/com/sun/source/tree/PrimitiveTypeTree.java ! src/share/classes/com/sun/source/tree/ReturnTree.java ! src/share/classes/com/sun/source/tree/Scope.java ! src/share/classes/com/sun/source/tree/StatementTree.java ! src/share/classes/com/sun/source/tree/SwitchTree.java ! src/share/classes/com/sun/source/tree/SynchronizedTree.java ! src/share/classes/com/sun/source/tree/ThrowTree.java ! src/share/classes/com/sun/source/tree/Tree.java ! src/share/classes/com/sun/source/tree/TreeVisitor.java ! src/share/classes/com/sun/source/tree/TryTree.java ! src/share/classes/com/sun/source/tree/TypeCastTree.java ! src/share/classes/com/sun/source/tree/TypeParameterTree.java ! src/share/classes/com/sun/source/tree/UnaryTree.java ! src/share/classes/com/sun/source/tree/UnionTypeTree.java ! src/share/classes/com/sun/source/tree/VariableTree.java ! src/share/classes/com/sun/source/tree/WhileLoopTree.java ! src/share/classes/com/sun/source/tree/WildcardTree.java ! src/share/classes/com/sun/source/tree/package-info.java ! src/share/classes/com/sun/source/util/DocTreeScanner.java ! src/share/classes/com/sun/source/util/DocTrees.java ! src/share/classes/com/sun/source/util/JavacTask.java ! src/share/classes/com/sun/source/util/Plugin.java ! src/share/classes/com/sun/source/util/SimpleDocTreeVisitor.java ! src/share/classes/com/sun/source/util/SimpleTreeVisitor.java ! src/share/classes/com/sun/source/util/SourcePositions.java ! src/share/classes/com/sun/source/util/TaskEvent.java ! src/share/classes/com/sun/source/util/TaskListener.java ! src/share/classes/com/sun/source/util/TreePath.java ! src/share/classes/com/sun/source/util/TreePathScanner.java ! src/share/classes/com/sun/source/util/TreeScanner.java ! src/share/classes/com/sun/source/util/Trees.java ! src/share/classes/com/sun/source/util/package-info.java ! src/share/classes/com/sun/tools/javac/Main.java ! src/share/classes/com/sun/tools/javac/Server.java Changeset: dc8b7aa7cef3 Author: vromero Date: 2013-02-19 17:53 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/dc8b7aa7cef3 8006212: javac, convert jtreg tests from shell script to java Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/api/JavacTaskImpl.java ! src/share/classes/com/sun/tools/javac/util/ArrayUtils.java + test/tools/apt/Basics/CheckAptIsRemovedTest.java - test/tools/apt/Basics/NullAPF.java - test/tools/apt/Basics/apt.sh - test/tools/apt/verifyVariables.sh + test/tools/javac/4846262/CheckEBCDICLocaleTest.java - test/tools/javac/4846262/Test.java - test/tools/javac/4846262/Test.out - test/tools/javac/4846262/Test.sh + test/tools/javac/6302184/HiddenOptionsShouldUseGivenEncodingTest.java - test/tools/javac/6302184/T6302184.sh + test/tools/javac/ClassPathTest/ClassPathTest.java - test/tools/javac/ClassPathTest/ClassPathTest.sh - test/tools/javac/ClassPathTest/ClassPathTest1.java - test/tools/javac/ClassPathTest/ClassPathTest2.java - test/tools/javac/ClassPathTest/ClassPathTest3.java - test/tools/javac/ClassPathTest/bar/pkg/ClassPathTestAux2.java - test/tools/javac/ClassPathTest/foo/pkg/ClassPathTestAux1.java - test/tools/javac/ClassPathTest/pkg/ClassPathTestAux3.java + test/tools/javac/ExtDirs/ExtDirTest.java - test/tools/javac/ExtDirs/ExtDirTest_1.java - test/tools/javac/ExtDirs/ExtDirTest_2.java - test/tools/javac/ExtDirs/ExtDirTest_3.java - test/tools/javac/ExtDirs/ExtDirs.sh - test/tools/javac/MissingInclude.java - test/tools/javac/MissingInclude.sh + test/tools/javac/MissingInclude/MissingIncludeTest.java - test/tools/javac/ProtectedInnerClass/ProtectedInnerClass.sh - test/tools/javac/ProtectedInnerClass/ProtectedInnerClass_2.java + test/tools/javac/ProtectedInnerClass/ProtectedInnerClassesTest.java - test/tools/javac/ProtectedInnerClass/p1/ProtectedInnerClass1.java - test/tools/javac/ProtectedInnerClass/p2/ProtectedInnerClass2.java - test/tools/javac/ProtectedInnerClass/p2/ProtectedInnerClass3.java + test/tools/javac/T5090006/AssertionFailureTest.java - test/tools/javac/T5090006/T5090006.java - test/tools/javac/T5090006/compiler.sh - test/tools/javac/constDebug/ConstDebug.java - test/tools/javac/constDebug/ConstDebug.sh + test/tools/javac/constDebug/ConstDebugTest.java - test/tools/javac/fatalErrors/NoJavaLang.java - test/tools/javac/fatalErrors/NoJavaLang.out - test/tools/javac/fatalErrors/NoJavaLang.sh + test/tools/javac/fatalErrors/NoJavaLangTest.java - test/tools/javac/innerClassFile/Driver.sh + test/tools/javac/innerClassFile/InnerClassFileTest.java - test/tools/javac/innerClassFile/x/B.java - test/tools/javac/innerClassFile/x/C.java - test/tools/javac/innerClassFile/y/Main.java - test/tools/javac/innerClassFile/y/R1.java - test/tools/javac/innerClassFile/y/R2.java - test/tools/javac/innerClassFile/y/R3.java - test/tools/javac/javazip/A.java + test/tools/javac/javazip/JavaZipTest.java - test/tools/javac/javazip/Test.sh - test/tools/javac/javazip/bad/B.java - test/tools/javac/javazip/good/B.java + test/tools/javac/lib/ToolBox.java + test/tools/javac/links/LinksTest.java - test/tools/javac/links/T.java - test/tools/javac/links/b/B.java - test/tools/javac/links/links.sh + test/tools/javac/newlines/NewLineTest.java - test/tools/javac/newlines/Newlines.sh + test/tools/javac/stackmap/StackMapTest.java - test/tools/javac/stackmap/T4955930.java - test/tools/javac/stackmap/T4955930.sh ! test/tools/javac/unicode/SupplementaryJavaID6.java - test/tools/javac/unicode/SupplementaryJavaID6.sh + test/tools/javah/6257087/T6257087.java - test/tools/javah/6257087/foo.java - test/tools/javah/6257087/foo.sh - test/tools/javah/6257087/foo_bar.h - test/tools/javah/ConstMacroTest.sh - test/tools/javah/MissingParamClassException.java - test/tools/javah/MissingParamClassTest.sh - test/tools/javah/ParamClassTest.java - test/tools/javah/SubClassConsts.java - test/tools/javah/SubClassConsts.out - test/tools/javah/SubClassConsts.win - test/tools/javah/SuperClassConsts.java + test/tools/javah/T4942232/MissingParamClassTest.java + test/tools/javah/constMacroTest/ConstMacroTest.java + test/tools/javap/4798312/JavapShouldLoadClassesFromRTJarTest.java + test/tools/javap/4866831/PublicInterfaceTest.java - test/tools/javap/NotPackagePrivateInterface.java - test/tools/javap/PublicInterfaceTest.sh - test/tools/javap/pathsep.sh + test/tools/javap/stackmap/StackmapTest.java - test/tools/javap/stackmap/T6271292.java - test/tools/javap/stackmap/T6271292.out - test/tools/javap/stackmap/T6271292.sh Changeset: 9345394ac8fe Author: ksrini Date: 2013-02-19 17:19 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/9345394ac8fe 8006948: Update javac for MethodParameters format change Reviewed-by: ksrini, forax Contributed-by: eric.mccorkle at oracle.com ! src/share/classes/com/sun/tools/classfile/ClassWriter.java ! src/share/classes/com/sun/tools/classfile/MethodParameters_attribute.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java Changeset: bc24411bcc37 Author: katleman Date: 2013-02-14 11:44 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/bc24411bcc37 Added tag jdk8-b77 for changeset 89c664151689 ! .hgtags Changeset: a3aa32fe4536 Author: lana Date: 2013-02-14 22:11 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/a3aa32fe4536 Merge Changeset: 4cf6e84f844f Author: lana Date: 2013-02-19 20:53 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/4cf6e84f844f Merge Changeset: 267225edc1fe Author: strarup Date: 2013-02-20 15:47 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/267225edc1fe 8006582: Test for parameter names feature Reviewed-by: jjg, darcy, emc - test/tools/javac/MethodParameters.java + test/tools/javac/MethodParameters/AnnotationTest.java + test/tools/javac/MethodParameters/AnonymousClass.java + test/tools/javac/MethodParameters/AttributeVisitor.java + test/tools/javac/MethodParameters/ClassFileVisitor.java + test/tools/javac/MethodParameters/Constructors.java + test/tools/javac/MethodParameters/EnumTest.java + test/tools/javac/MethodParameters/InstanceMethods.java + test/tools/javac/MethodParameters/LambdaTest.java + test/tools/javac/MethodParameters/LocalClassTest.java + test/tools/javac/MethodParameters/MemberClassTest.java + test/tools/javac/MethodParameters/ReflectionVisitor.java + test/tools/javac/MethodParameters/StaticMethods.java + test/tools/javac/MethodParameters/Tester.java + test/tools/javac/MethodParameters/UncommonParamNames.java + test/tools/javac/MethodParametersTest.java Changeset: d686d8a7eb78 Author: mcimadamore Date: 2013-02-21 15:19 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/d686d8a7eb78 8008227: Mixing lambdas with anonymous classes leads to NPE thrown by compiler Summary: Disentangle cyclic dependency between static-ness of synthetic lambda method and static-ness of classes nested within lambdas Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java + test/tools/javac/lambda/LambdaConv27.java Changeset: 3a39d123d33a Author: mcimadamore Date: 2013-02-21 15:21 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/3a39d123d33a 8008276: assertion error in com.sun.tools.javac.comp.TransTypes.visitApply Summary: DiagnosticFilter used during speculative attribution is too broad Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java ! src/share/classes/com/sun/tools/javac/util/JCDiagnostic.java + test/tools/javac/lambda/speculative/MissingError.java + test/tools/javac/lambda/speculative/MissingError.out Changeset: f4fdd53f8b3e Author: mcimadamore Date: 2013-02-21 15:23 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/f4fdd53f8b3e 8005183: Missing accessor for constructor reference pointing to private inner class ctor Summary: Compiler should add bridges when translating private constructor reference Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java + test/tools/javac/lambda/MethodReference63.java Changeset: 7ac9242d2ca6 Author: mcimadamore Date: 2013-02-21 15:25 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/7ac9242d2ca6 8008293: Declared bounds not considered when functional interface containing unbound wildcards is instantiated Summary: Wildcards inference should re-use some of the bounds info generated during capture conversion Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Types.java + test/tools/javac/lambda/TargetType64.java Changeset: 9f0ec00514b6 Author: mcimadamore Date: 2013-02-21 15:26 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/9f0ec00514b6 8007461: Regression: bad overload resolution when inner class and outer class have method with same name Summary: Fix regression in varargs method resolution introduced by bad refactoring Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! test/tools/javac/resolve/Pos.java + test/tools/javac/resolve/tests/InnerOverOuter.java Changeset: 3fef0cae83b3 Author: mcimadamore Date: 2013-02-21 15:27 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/3fef0cae83b3 8008444: Inherited generic functional descriptors are merged incorrectly Summary: Missing call to Types.createMethodWithThrownTypes Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Types.java + test/tools/javac/lambda/LambdaConv25.java + test/tools/javac/lambda/LambdaConv25.out Changeset: cd7340a84bb8 Author: rfield Date: 2013-02-21 14:43 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/cd7340a84bb8 8008405: Now that metafactory is in place, add javac lambda serialization tests Summary: Tests part of original langtools serialization review. Reviewed-by: mcimadamore + test/tools/javac/T8004969.java + test/tools/javac/lambda/LambdaInnerTypeVarArgsSerialize.java + test/tools/javac/lambda/LambdaInnerTypeVarSerialize.java Changeset: dabb36173c63 Author: ksrini Date: 2013-02-21 12:23 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/dabb36173c63 8008658: Four new method param jtreg tests fail in nightly tests Reviewed-by: jjg, ksrini, mcimadamore Contributed-by: eric.mccorkle at oracle.com ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! test/tools/javac/MethodParameters/EnumTest.java ! test/tools/javac/MethodParameters/LocalClassTest.java ! test/tools/javac/MethodParameters/MemberClassTest.java Changeset: 5f0731e4e5e6 Author: bpatel Date: 2013-01-21 00:45 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/5f0731e4e5e6 8006124: javadoc/doclet should be updated to support profiles Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractPackageIndexWriter.java + src/share/classes/com/sun/tools/doclets/formats/html/AbstractProfileIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/FrameOutputWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDoclet.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexWriter.java + src/share/classes/com/sun/tools/doclets/formats/html/ProfileIndexFrameWriter.java + src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageFrameWriter.java + src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageIndexFrameWriter.java + src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageWriterImpl.java + src/share/classes/com/sun/tools/doclets/formats/html/ProfileWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/WriterFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlConstants.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/resources/standard.properties ! src/share/classes/com/sun/tools/doclets/internal/toolkit/AbstractDoclet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java + src/share/classes/com/sun/tools/doclets/internal/toolkit/ProfilePackageSummaryWriter.java + src/share/classes/com/sun/tools/doclets/internal/toolkit/ProfileSummaryWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/WriterFactory.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/BuilderFactory.java + src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ProfilePackageSummaryBuilder.java + src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ProfileSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/doclet.xml ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/doclets.properties ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/stylesheet.css ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocPaths.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/MetaKeywords.java + test/com/sun/javadoc/testProfiles/TestProfiles.java + test/com/sun/javadoc/testProfiles/pkg1/Class1Pkg1.java + test/com/sun/javadoc/testProfiles/pkg1/Class2Pkg1.java + test/com/sun/javadoc/testProfiles/pkg1/Class3Pkg1.java + test/com/sun/javadoc/testProfiles/pkg1/Interface1Pkg1.java + test/com/sun/javadoc/testProfiles/pkg2/Anno1Pkg2.java + test/com/sun/javadoc/testProfiles/pkg2/Anno2Pkg2.java + test/com/sun/javadoc/testProfiles/pkg2/Class1Pkg2.java + test/com/sun/javadoc/testProfiles/pkg3/Class1Pkg3.java + test/com/sun/javadoc/testProfiles/pkg3/Class2Pkg3.java + test/com/sun/javadoc/testProfiles/pkg3/Interface1Pkg3.java + test/com/sun/javadoc/testProfiles/pkg4/Anno1Pkg4.java + test/com/sun/javadoc/testProfiles/pkg4/Class1Pkg4.java + test/com/sun/javadoc/testProfiles/pkg5/Class1Pkg5.java + test/com/sun/javadoc/testProfiles/pkg5/Interface1Pkg5.java + test/com/sun/javadoc/testProfiles/profile-rtjar-includes.txt Changeset: 475eb15dfdad Author: jjg Date: 2013-01-21 01:27 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/475eb15dfdad 8004182: Add support for profiles in javac Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/api/JavacTaskImpl.java ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java + src/share/classes/com/sun/tools/javac/jvm/Profile.java ! src/share/classes/com/sun/tools/javac/jvm/Target.java ! src/share/classes/com/sun/tools/javac/main/Main.java ! src/share/classes/com/sun/tools/javac/main/Option.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/resources/javac.properties ! src/share/classes/com/sun/tools/javac/sym/CreateSymbols.java + src/share/classes/com/sun/tools/javac/sym/Profiles.java ! src/share/classes/com/sun/tools/javac/util/AbstractDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/RichDiagnosticFormatter.java + test/tools/javac/diags/examples/NotInProfile.java + test/tools/javac/profiles/ProfileOptionTest.java Changeset: f91144b7da75 Author: dholmes Date: 2013-02-04 18:08 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/f91144b7da75 Merge ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/doclets.properties ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/util/RichDiagnosticFormatter.java - test/tools/javac/annotations/repeatingAnnotations/MissingContainedBy.java - test/tools/javac/annotations/repeatingAnnotations/MissingContainerFor.java - test/tools/javac/annotations/repeatingAnnotations/UseWrongContainedBy.java - test/tools/javac/annotations/repeatingAnnotations/UseWrongContainerFor.java - test/tools/javac/annotations/repeatingAnnotations/WrongContainedBy.java - test/tools/javac/annotations/repeatingAnnotations/WrongContainerFor.java - test/tools/javac/diags/examples/ContainedByDocumentedMismatch.java - test/tools/javac/diags/examples/ContainedByInheritedMismatch.java - test/tools/javac/diags/examples/ContainedByNoValue.java - test/tools/javac/diags/examples/ContainedByNonDefault.java - test/tools/javac/diags/examples/ContainedByRetentionMismatch.java - test/tools/javac/diags/examples/ContainedByTargetMismatch.java - test/tools/javac/diags/examples/ContainedByWrongValueType.java - test/tools/javac/diags/examples/InferredDoNotConformToLower.java - test/tools/javac/diags/examples/NoUniqueMaximalInstance.java - test/tools/javac/diags/examples/WrongContainedBy.java - test/tools/javac/diags/examples/WrongContainerFor.java - test/tools/javac/lambda/MethodReference26.out - test/tools/javac/lambda/TargetType06.out - test/tools/javac/lambda/TargetType11.out - test/tools/javac/lambda/TargetType45.out - test/tools/javac/lambda/VoidCompatibility.out - test/tools/javac/typeAnnotations/newlocations/BasicTest.java - test/tools/javac/typeAnnotations/newlocations/BasicTest.out Changeset: af8417e590f4 Author: dholmes Date: 2013-02-17 16:44 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/af8417e590f4 Merge ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexWriter.java ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java - test/tools/javac/lambda/TargetType20.out - test/tools/javac/lambda/TargetType50.out Changeset: 6118072811e5 Author: lana Date: 2013-02-21 17:49 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/6118072811e5 Merge ! src/share/classes/com/sun/tools/javac/api/JavacTaskImpl.java ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties Changeset: 8e82e4f225e4 Author: mcimadamore Date: 2013-02-22 13:31 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/8e82e4f225e4 8008337: Write test to check for compiler error when static method in interface is called via super() Reviewed-by: mcimadamore Contributed-by: sonali.goel at oracle.com + test/tools/javac/lambda/StaticMethodNegTest.java + test/tools/javac/lambda/StaticMethodNegTest.out From sundararajan.athijegannathan at oracle.com Fri Feb 22 09:53:22 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Fri, 22 Feb 2013 23:23:22 +0530 Subject: Review request JDK-8008731: Separate configuration environment (options, error/output writer etc.) from Context Message-ID: <5127B092.30707@oracle.com> Please review http://cr.openjdk.java.net/~sundar/8008731/ Thanks -Sundar From james.laskey at oracle.com Fri Feb 22 10:15:44 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Fri, 22 Feb 2013 18:15:44 +0000 Subject: hg: nashorn/jdk8/jdk: 122 new changesets Message-ID: <20130222184121.DB4D547CCA@hg.openjdk.java.net> Changeset: e04467fa13af Author: darcy Date: 2013-02-04 17:56 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/e04467fa13af 8007113: Upgrade AnnotatedElement.isAnnotionPresent to be a default method Reviewed-by: chegar, jfranck ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/Package.java ! src/share/classes/java/lang/reflect/AccessibleObject.java ! src/share/classes/java/lang/reflect/AnnotatedElement.java ! src/share/classes/java/lang/reflect/Parameter.java ! src/share/classes/sun/reflect/annotation/AnnotatedTypeFactory.java ! src/share/classes/sun/reflect/generics/reflectiveObjects/TypeVariableImpl.java Changeset: 6ba6353ab42c Author: katleman Date: 2013-01-31 17:04 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/6ba6353ab42c Added tag jdk8-b75 for changeset 4a67fdb752b7 ! .hgtags Changeset: fd37f0846653 Author: lana Date: 2013-02-04 22:37 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/fd37f0846653 Merge Changeset: 9ffcd758e2be Author: jbachorik Date: 2013-02-05 12:28 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/9ffcd758e2be 7170447: Intermittent DeadListenerTest.java failure Summary: Due to asynchronous nature of processing server notifications it may happen that an "unregister" notification ha$ Reviewed-by: sjiang ! test/javax/management/remote/mandatory/notif/DeadListenerTest.java Changeset: 3119f0ebb58d Author: jbachorik Date: 2013-02-05 12:36 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/3119f0ebb58d 8005791: Remove java.beans.* imports from com.sun.jmx.mbeanserver.Introspector Reviewed-by: rbackman ! src/share/classes/com/sun/jmx/mbeanserver/Introspector.java Changeset: e526277b51be Author: vinnie Date: 2013-02-05 14:25 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/e526277b51be 8007483: attributes are ignored when loading keys from a PKCS12 keystore Reviewed-by: mullan ! src/share/classes/sun/security/pkcs12/PKCS12KeyStore.java ! test/sun/security/pkcs12/StorePasswordTest.java Changeset: 0e7d5dd84fdf Author: dsamersoff Date: 2013-02-06 16:53 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/0e7d5dd84fdf 8007277: JDK-8002048 testcase fails to compile Summary: sun.* classes is not included to ct.sym file and symbol file have to be ignored Reviewed-by: alanb ! test/sun/management/jdp/JdpTest.sh Changeset: 1574fa3df1c0 Author: lancea Date: 2013-02-06 14:15 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/1574fa3df1c0 8006505: additional changes for JSR 310 support Reviewed-by: naoto, ulfzibis ! src/share/classes/java/sql/JDBCType.java ! src/share/classes/java/sql/SQLInput.java ! src/share/classes/java/sql/SQLOutput.java ! src/share/classes/java/sql/Types.java Changeset: 2f1505c49e79 Author: martin Date: 2013-02-06 17:59 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/2f1505c49e79 8006995: java launcher fails to open executable JAR > 2GB Summary: Use O_LARGEFILE consistently when opening jar files Reviewed-by: alanb, sherman ! src/share/bin/parse_manifest.c Changeset: 2de8c6c2d652 Author: ykantser Date: 2013-02-07 11:22 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/2de8c6c2d652 8007142: Add utility classes for writing better multiprocess tests in jtreg Reviewed-by: alanb, rbackman + test/lib/testlibrary/OutputAnalyzerTest.java + test/lib/testlibrary/jdk/testlibrary/JcmdBase.java + test/lib/testlibrary/jdk/testlibrary/JdkFinder.java + test/lib/testlibrary/jdk/testlibrary/OutputAnalyzer.java + test/lib/testlibrary/jdk/testlibrary/OutputBuffer.java + test/lib/testlibrary/jdk/testlibrary/ProcessTools.java + test/lib/testlibrary/jdk/testlibrary/StreamPumper.java Changeset: 79d7595abe95 Author: naoto Date: 2013-02-08 09:35 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/79d7595abe95 8007038: ArrayIndexOutOfBoundsException on calling localizedDateTime().print() with JapaneseChrono Reviewed-by: okutsu ! src/share/classes/sun/util/locale/provider/CalendarNameProviderImpl.java + test/java/util/Calendar/Bug8007038.java Changeset: 522fb3867a3a Author: darcy Date: 2013-02-08 16:00 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/522fb3867a3a 8005623: Retrofit FunctionalInterface annotations to core platform interfaces Reviewed-by: mduigou, chegar, alanb ! src/share/classes/java/io/Closeable.java ! src/share/classes/java/io/FileFilter.java ! src/share/classes/java/io/FilenameFilter.java ! src/share/classes/java/io/Flushable.java ! src/share/classes/java/lang/AutoCloseable.java ! src/share/classes/java/lang/Comparable.java ! src/share/classes/java/lang/Iterable.java ! src/share/classes/java/lang/Readable.java ! src/share/classes/java/lang/Runnable.java ! src/share/classes/java/lang/Thread.java ! src/share/classes/java/nio/file/DirectoryStream.java ! src/share/classes/java/nio/file/PathMatcher.java ! src/share/classes/java/util/Comparator.java ! src/share/classes/java/util/function/BinaryOperator.java ! src/share/classes/java/util/function/Block.java ! src/share/classes/java/util/function/DoubleBinaryOperator.java ! src/share/classes/java/util/function/DoubleBlock.java ! src/share/classes/java/util/function/DoubleFunction.java ! src/share/classes/java/util/function/DoubleSupplier.java ! src/share/classes/java/util/function/DoubleUnaryOperator.java ! src/share/classes/java/util/function/Function.java ! src/share/classes/java/util/function/IntBinaryOperator.java ! src/share/classes/java/util/function/IntBlock.java ! src/share/classes/java/util/function/IntFunction.java ! src/share/classes/java/util/function/IntSupplier.java ! src/share/classes/java/util/function/IntUnaryOperator.java ! src/share/classes/java/util/function/LongBinaryOperator.java ! src/share/classes/java/util/function/LongBlock.java ! src/share/classes/java/util/function/LongFunction.java ! src/share/classes/java/util/function/LongSupplier.java ! src/share/classes/java/util/function/LongUnaryOperator.java ! src/share/classes/java/util/function/Predicate.java ! src/share/classes/java/util/function/Supplier.java ! src/share/classes/java/util/function/UnaryOperator.java ! src/share/classes/java/util/logging/Filter.java ! src/share/classes/java/util/prefs/PreferenceChangeListener.java Changeset: 36d25dc2b8f0 Author: dl Date: 2013-02-09 08:35 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/36d25dc2b8f0 8005697: Add StampedLock Reviewed-by: chegar, alanb, dice, martin ! make/java/java/FILES_java.gmk ! src/share/classes/java/util/concurrent/locks/LockSupport.java + src/share/classes/java/util/concurrent/locks/StampedLock.java + test/java/util/concurrent/locks/StampedLock/Basic.java Changeset: d14cd2272b2d Author: weijun Date: 2013-02-09 16:43 +0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/d14cd2272b2d 8001104: Unbound SASL service: the GSSAPI/krb5 mech Reviewed-by: valeriep ! src/share/classes/com/sun/security/auth/module/Krb5LoginModule.java ! src/share/classes/javax/security/auth/kerberos/JavaxSecurityAuthKerberosAccessImpl.java ! src/share/classes/javax/security/auth/kerberos/KeyTab.java ! src/share/classes/sun/security/jgss/LoginConfigImpl.java ! src/share/classes/sun/security/jgss/krb5/Krb5Util.java ! src/share/classes/sun/security/jgss/krb5/ServiceCreds.java ! src/share/classes/sun/security/jgss/krb5/SubjectComber.java ! src/share/classes/sun/security/krb5/JavaxSecurityAuthKerberosAccess.java ! src/share/classes/sun/security/krb5/internal/ktab/KeyTab.java ! src/share/classes/sun/security/provider/ConfigSpiFile.java ! test/sun/security/krb5/ServiceCredsCombination.java ! test/sun/security/krb5/auto/AcceptPermissions.java + test/sun/security/krb5/auto/GSSUnbound.java ! test/sun/security/krb5/auto/OneKDC.java + test/sun/security/krb5/auto/SaslUnbound.java + test/sun/security/krb5/auto/UnboundService.java Changeset: 57cb988c811e Author: weijun Date: 2013-02-09 16:43 +0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/57cb988c811e 8007761: NTLM coding errors Reviewed-by: chegar ! src/share/classes/com/sun/security/ntlm/Client.java ! src/share/classes/com/sun/security/ntlm/NTLM.java Changeset: 58c95d0b6b1a Author: ksrini Date: 2013-02-10 08:07 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/58c95d0b6b1a 8007519: [unpack200] produces bad class files when producing BootstrapMethods attribute Reviewed-by: alanb ! test/ProblemList.txt Changeset: 520a3433883d Author: ksrini Date: 2013-02-10 08:49 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/520a3433883d 8007902: [unpack200] incorrect BootstrapMethods attribute Reviewed-by: jjh ! src/share/native/com/sun/java/util/jar/pack/unpack.cpp ! test/tools/pack200/Pack200Test.java ! test/tools/pack200/pack200-verifier/data/golden.jar Changeset: 1df991184045 Author: dsamersoff Date: 2013-02-11 18:44 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/1df991184045 8007536: Incorrect copyright header in JDP files Summary: Copyright header in JDP files missed the "classpath exception" rule. Reviewed-by: mikael ! src/share/classes/sun/management/jdp/JdpBroadcaster.java ! src/share/classes/sun/management/jdp/JdpController.java ! src/share/classes/sun/management/jdp/JdpException.java ! src/share/classes/sun/management/jdp/JdpGenericPacket.java ! src/share/classes/sun/management/jdp/JdpJmxPacket.java ! src/share/classes/sun/management/jdp/JdpPacket.java ! src/share/classes/sun/management/jdp/JdpPacketReader.java ! src/share/classes/sun/management/jdp/JdpPacketWriter.java ! src/share/classes/sun/management/jdp/package-info.java Changeset: abd530253f01 Author: dcubed Date: 2013-02-11 10:07 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/abd530253f01 8007420: add test for 6805864 to com/sun/jdi, add test for 7182152 to java/lang/instrument Reviewed-by: coleenp, sspitsyn + test/com/sun/jdi/RedefineAbstractClass.sh + test/java/lang/instrument/RedefineSubclassWithTwoInterfaces.sh + test/java/lang/instrument/RedefineSubclassWithTwoInterfacesAgent.java + test/java/lang/instrument/RedefineSubclassWithTwoInterfacesApp.java + test/java/lang/instrument/RedefineSubclassWithTwoInterfacesImpl.java + test/java/lang/instrument/RedefineSubclassWithTwoInterfacesImpl_1.java + test/java/lang/instrument/RedefineSubclassWithTwoInterfacesIntf1.java + test/java/lang/instrument/RedefineSubclassWithTwoInterfacesIntf2.java + test/java/lang/instrument/RedefineSubclassWithTwoInterfacesRemote.java + test/java/lang/instrument/RedefineSubclassWithTwoInterfacesTarget.java + test/java/lang/instrument/RedefineSubclassWithTwoInterfacesTarget_1.java Changeset: f21a4b761424 Author: alanb Date: 2013-02-11 20:16 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/f21a4b761424 8007405: Update java.lang.reflect API to replace SYNTHESIZED with MANDATED Reviewed-by: darcy ! src/share/classes/java/lang/reflect/Executable.java ! src/share/classes/java/lang/reflect/Modifier.java ! src/share/classes/java/lang/reflect/Parameter.java Changeset: 465cce29a9ed Author: mduigou Date: 2013-02-06 11:28 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/465cce29a9ed 8006594: Add jdk_core target to jdk/test/Makefile Reviewed-by: alanb ! make/jprt.properties ! test/Makefile ! test/ProblemList.txt Changeset: f7fb173ac833 Author: dsamersoff Date: 2013-02-12 16:02 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/f7fb173ac833 8007786: JDK-8002048 testcase doesn't work on Solaris Summary: test built in into Solaris shell doesn't have -e operator Reviewed-by: sla, sspitsyn ! test/sun/management/jdp/JdpTest.sh Changeset: 7dcb74c3ffba Author: sherman Date: 2013-02-12 09:25 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/7dcb74c3ffba 8007392: JSR 310: DateTime API Updates 8007520: Update date/time classes in j.util and j.sql packages 8007572: Replace existing jdk timezone data at /lib/zi with JSR310's tzdb Summary: Integration of JSR310 Date/Time API for M7 Reviewed-by: darcy, alanb, naoto Contributed-by: scolebourne at joda.org, roger.riggs at oracle.com, masayoshi.okutsu at oracle.com, patrick.zhang at oracle.com ! make/docs/CORE_PKGS.gmk ! make/java/java/FILES_java.gmk ! make/sun/Makefile ! make/sun/javazic/Makefile + make/sun/javazic/tzdata/gmt + make/sun/javazic/tzdata/jdk11_backward ! make/sun/tzdb/Makefile ! make/tools/Makefile ! make/tools/src/build/tools/javazic/Zoneinfo.java ! make/tools/src/build/tools/tzdb/TzdbZoneRulesCompiler.java ! makefiles/GendataTZDB.gmk ! makefiles/GendataTimeZone.gmk ! makefiles/GenerateData.gmk ! makefiles/Tools.gmk ! src/share/classes/java/sql/Date.java ! src/share/classes/java/sql/Time.java ! src/share/classes/java/sql/Timestamp.java ! src/share/classes/java/time/Clock.java ! src/share/classes/java/time/DayOfWeek.java ! src/share/classes/java/time/Duration.java ! src/share/classes/java/time/Instant.java ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/LocalDateTime.java ! src/share/classes/java/time/LocalTime.java ! src/share/classes/java/time/Month.java + src/share/classes/java/time/MonthDay.java + src/share/classes/java/time/OffsetDateTime.java + src/share/classes/java/time/OffsetTime.java ! src/share/classes/java/time/Period.java - src/share/classes/java/time/PeriodParser.java ! src/share/classes/java/time/Ser.java + src/share/classes/java/time/Year.java + src/share/classes/java/time/YearMonth.java ! src/share/classes/java/time/ZoneId.java ! src/share/classes/java/time/ZoneOffset.java ! src/share/classes/java/time/ZoneRegion.java ! src/share/classes/java/time/ZonedDateTime.java - src/share/classes/java/time/calendar/ChronoDateImpl.java - src/share/classes/java/time/calendar/HijrahChrono.java - src/share/classes/java/time/calendar/HijrahDate.java - src/share/classes/java/time/calendar/HijrahDeviationReader.java - src/share/classes/java/time/calendar/HijrahEra.java - src/share/classes/java/time/calendar/JapaneseChrono.java - src/share/classes/java/time/calendar/JapaneseDate.java - src/share/classes/java/time/calendar/JapaneseEra.java - src/share/classes/java/time/calendar/MinguoChrono.java - src/share/classes/java/time/calendar/MinguoDate.java - src/share/classes/java/time/calendar/MinguoEra.java - src/share/classes/java/time/calendar/Ser.java - src/share/classes/java/time/calendar/ThaiBuddhistChrono.java - src/share/classes/java/time/calendar/ThaiBuddhistDate.java - src/share/classes/java/time/calendar/ThaiBuddhistEra.java - src/share/classes/java/time/calendar/package-info.java + src/share/classes/java/time/chrono/ChronoDateImpl.java + src/share/classes/java/time/chrono/ChronoLocalDate.java + src/share/classes/java/time/chrono/ChronoLocalDateTime.java + src/share/classes/java/time/chrono/ChronoLocalDateTimeImpl.java + src/share/classes/java/time/chrono/ChronoZonedDateTime.java + src/share/classes/java/time/chrono/ChronoZonedDateTimeImpl.java + src/share/classes/java/time/chrono/Chronology.java + src/share/classes/java/time/chrono/Era.java + src/share/classes/java/time/chrono/HijrahChronology.java + src/share/classes/java/time/chrono/HijrahDate.java + src/share/classes/java/time/chrono/HijrahDeviationReader.java + src/share/classes/java/time/chrono/HijrahEra.java + src/share/classes/java/time/chrono/IsoChronology.java + src/share/classes/java/time/chrono/IsoEra.java + src/share/classes/java/time/chrono/JapaneseChronology.java + src/share/classes/java/time/chrono/JapaneseDate.java + src/share/classes/java/time/chrono/JapaneseEra.java + src/share/classes/java/time/chrono/MinguoChronology.java + src/share/classes/java/time/chrono/MinguoDate.java + src/share/classes/java/time/chrono/MinguoEra.java + src/share/classes/java/time/chrono/Ser.java + src/share/classes/java/time/chrono/ThaiBuddhistChronology.java + src/share/classes/java/time/chrono/ThaiBuddhistDate.java + src/share/classes/java/time/chrono/ThaiBuddhistEra.java + src/share/classes/java/time/chrono/package-info.java ! src/share/classes/java/time/format/DateTimeBuilder.java ! src/share/classes/java/time/format/DateTimeFormatStyleProvider.java ! src/share/classes/java/time/format/DateTimeFormatter.java ! src/share/classes/java/time/format/DateTimeFormatterBuilder.java - src/share/classes/java/time/format/DateTimeFormatters.java ! src/share/classes/java/time/format/DateTimeParseContext.java ! src/share/classes/java/time/format/DateTimePrintContext.java - src/share/classes/java/time/format/DateTimePrintException.java ! src/share/classes/java/time/format/DateTimeTextProvider.java ! src/share/classes/java/time/format/FormatStyle.java + src/share/classes/java/time/format/ZoneName.java ! src/share/classes/java/time/format/package-info.java ! src/share/classes/java/time/overview.html ! src/share/classes/java/time/package-info.java - src/share/classes/java/time/temporal/Chrono.java ! src/share/classes/java/time/temporal/ChronoField.java - src/share/classes/java/time/temporal/ChronoLocalDate.java - src/share/classes/java/time/temporal/ChronoLocalDateTime.java - src/share/classes/java/time/temporal/ChronoLocalDateTimeImpl.java ! src/share/classes/java/time/temporal/ChronoUnit.java - src/share/classes/java/time/temporal/ChronoZonedDateTime.java - src/share/classes/java/time/temporal/ChronoZonedDateTimeImpl.java - src/share/classes/java/time/temporal/Era.java - src/share/classes/java/time/temporal/ISOChrono.java - src/share/classes/java/time/temporal/ISOEra.java - src/share/classes/java/time/temporal/ISOFields.java + src/share/classes/java/time/temporal/IsoFields.java ! src/share/classes/java/time/temporal/JulianFields.java - src/share/classes/java/time/temporal/MonthDay.java - src/share/classes/java/time/temporal/OffsetDate.java - src/share/classes/java/time/temporal/OffsetDateTime.java - src/share/classes/java/time/temporal/OffsetTime.java ! src/share/classes/java/time/temporal/Queries.java - src/share/classes/java/time/temporal/Ser.java - src/share/classes/java/time/temporal/SimplePeriod.java ! src/share/classes/java/time/temporal/Temporal.java ! src/share/classes/java/time/temporal/TemporalAccessor.java - src/share/classes/java/time/temporal/TemporalAdder.java ! src/share/classes/java/time/temporal/TemporalAdjuster.java + src/share/classes/java/time/temporal/TemporalAmount.java ! src/share/classes/java/time/temporal/TemporalField.java ! src/share/classes/java/time/temporal/TemporalQuery.java - src/share/classes/java/time/temporal/TemporalSubtractor.java ! src/share/classes/java/time/temporal/TemporalUnit.java ! src/share/classes/java/time/temporal/WeekFields.java - src/share/classes/java/time/temporal/Year.java - src/share/classes/java/time/temporal/YearMonth.java ! src/share/classes/java/time/temporal/package-info.java ! src/share/classes/java/time/zone/TzdbZoneRulesProvider.java ! src/share/classes/java/time/zone/ZoneOffsetTransitionRule.java ! src/share/classes/java/time/zone/ZoneRules.java ! src/share/classes/java/time/zone/ZoneRulesProvider.java ! src/share/classes/java/util/Calendar.java ! src/share/classes/java/util/Date.java ! src/share/classes/java/util/Formatter.java ! src/share/classes/java/util/GregorianCalendar.java ! src/share/classes/java/util/TimeZone.java ! src/share/classes/sun/text/resources/FormatData.java ! src/share/classes/sun/text/resources/ar/FormatData_ar.java ! src/share/classes/sun/text/resources/el/FormatData_el.java ! src/share/classes/sun/text/resources/hr/FormatData_hr.java ! src/share/classes/sun/text/resources/ja/FormatData_ja.java ! src/share/classes/sun/text/resources/ko/FormatData_ko.java ! src/share/classes/sun/text/resources/sr/FormatData_sr.java ! src/share/classes/sun/text/resources/sv/FormatData_sv.java ! src/share/classes/sun/text/resources/zh/FormatData_zh.java ! src/share/classes/sun/text/resources/zh/FormatData_zh_TW.java ! src/share/classes/sun/util/calendar/CalendarSystem.java ! src/share/classes/sun/util/calendar/LocalGregorianCalendar.java - src/share/classes/sun/util/calendar/TzIDOldMapping.java ! src/share/classes/sun/util/calendar/ZoneInfo.java ! src/share/classes/sun/util/calendar/ZoneInfoFile.java ! src/share/classes/sun/util/locale/provider/CalendarDataUtility.java ! src/share/classes/sun/util/locale/provider/CalendarNameProviderImpl.java ! src/share/classes/sun/util/locale/provider/LocaleResources.java + test/java/sql/JavatimeTest.java + test/java/time/META-INF/services/java.time.chrono.Chronology - test/java/time/META-INF/services/java.time.temporal.Chrono ! test/java/time/tck/java/time/AbstractTCKTest.java + test/java/time/tck/java/time/MockSimplePeriod.java ! test/java/time/tck/java/time/TCKClock.java ! test/java/time/tck/java/time/TCKClock_Fixed.java ! test/java/time/tck/java/time/TCKClock_Offset.java ! test/java/time/tck/java/time/TCKClock_System.java ! test/java/time/tck/java/time/TCKClock_Tick.java ! test/java/time/tck/java/time/TCKDayOfWeek.java ! test/java/time/tck/java/time/TCKDuration.java ! test/java/time/tck/java/time/TCKInstant.java ! test/java/time/tck/java/time/TCKLocalDate.java ! test/java/time/tck/java/time/TCKLocalDateTime.java ! test/java/time/tck/java/time/TCKLocalTime.java ! test/java/time/tck/java/time/TCKMonth.java + test/java/time/tck/java/time/TCKMonthDay.java + test/java/time/tck/java/time/TCKOffsetDateTime.java + test/java/time/tck/java/time/TCKOffsetTime.java + test/java/time/tck/java/time/TCKPeriod.java + test/java/time/tck/java/time/TCKYear.java + test/java/time/tck/java/time/TCKYearMonth.java ! test/java/time/tck/java/time/TCKZoneId.java ! test/java/time/tck/java/time/TCKZoneOffset.java ! test/java/time/tck/java/time/TCKZonedDateTime.java + test/java/time/tck/java/time/TestChronology.java + test/java/time/tck/java/time/TestIsoChronology.java - test/java/time/tck/java/time/calendar/CopticChrono.java - test/java/time/tck/java/time/calendar/CopticDate.java - test/java/time/tck/java/time/calendar/CopticEra.java - test/java/time/tck/java/time/calendar/TestChronoLocalDate.java - test/java/time/tck/java/time/calendar/TestChronoLocalDateTime.java - test/java/time/tck/java/time/calendar/TestHijrahChrono.java - test/java/time/tck/java/time/calendar/TestJapaneseChrono.java - test/java/time/tck/java/time/calendar/TestMinguoChrono.java - test/java/time/tck/java/time/calendar/TestServiceLoader.java - test/java/time/tck/java/time/calendar/TestThaiBuddhistChrono.java + test/java/time/tck/java/time/chrono/CopticChronology.java + test/java/time/tck/java/time/chrono/CopticDate.java + test/java/time/tck/java/time/chrono/CopticEra.java + test/java/time/tck/java/time/chrono/TCKChronology.java + test/java/time/tck/java/time/chrono/TCKTestServiceLoader.java + test/java/time/tck/java/time/chrono/TestChronoLocalDate.java + test/java/time/tck/java/time/chrono/TestChronoLocalDateTime.java + test/java/time/tck/java/time/chrono/TestHijrahChronology.java + test/java/time/tck/java/time/chrono/TestJapaneseChronology.java + test/java/time/tck/java/time/chrono/TestMinguoChronology.java + test/java/time/tck/java/time/chrono/TestThaiBuddhistChronology.java + test/java/time/tck/java/time/format/TCKChronoPrinterParser.java ! test/java/time/tck/java/time/format/TCKDateTimeFormatter.java ! test/java/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java ! test/java/time/tck/java/time/format/TCKDateTimeFormatters.java - test/java/time/tck/java/time/format/TCKDateTimePrintException.java ! test/java/time/tck/java/time/format/TCKDateTimeTextPrinting.java ! test/java/time/tck/java/time/format/TCKLocalizedFieldParser.java ! test/java/time/tck/java/time/format/TCKLocalizedFieldPrinter.java + test/java/time/tck/java/time/format/TCKLocalizedPrinterParser.java + test/java/time/tck/java/time/format/TCKOffsetPrinterParser.java + test/java/time/tck/java/time/format/TCKPadPrinterParser.java + test/java/time/tck/java/time/format/TCKZoneIdPrinterParser.java - test/java/time/tck/java/time/temporal/TCKISOFields.java + test/java/time/tck/java/time/temporal/TCKIsoFields.java ! test/java/time/tck/java/time/temporal/TCKJulianFields.java - test/java/time/tck/java/time/temporal/TCKMonthDay.java - test/java/time/tck/java/time/temporal/TCKOffsetDate.java - test/java/time/tck/java/time/temporal/TCKOffsetDateTime.java - test/java/time/tck/java/time/temporal/TCKOffsetTime.java - test/java/time/tck/java/time/temporal/TCKSimplePeriod.java ! test/java/time/tck/java/time/temporal/TCKWeekFields.java - test/java/time/tck/java/time/temporal/TCKYear.java - test/java/time/tck/java/time/temporal/TCKYearMonth.java - test/java/time/tck/java/time/temporal/TestChrono.java ! test/java/time/tck/java/time/temporal/TestChronoLocalDate.java ! test/java/time/tck/java/time/temporal/TestChronoLocalDateTime.java ! test/java/time/tck/java/time/temporal/TestChronoZonedDateTime.java - test/java/time/tck/java/time/temporal/TestISOChrono.java ! test/java/time/tck/java/time/zone/TCKFixedZoneRules.java ! test/java/time/tck/java/time/zone/TCKZoneOffsetTransition.java ! test/java/time/tck/java/time/zone/TCKZoneOffsetTransitionRule.java ! test/java/time/tck/java/time/zone/TCKZoneRules.java ! test/java/time/tck/java/time/zone/TCKZoneRulesProvider.java ! test/java/time/test/java/time/MockSimplePeriod.java ! test/java/time/test/java/time/TestDuration.java ! test/java/time/test/java/time/TestLocalDateTime.java ! test/java/time/test/java/time/TestLocalTime.java + test/java/time/test/java/time/TestMonthDay.java + test/java/time/test/java/time/TestOffsetDateTime.java + test/java/time/test/java/time/TestOffsetDateTime_instants.java + test/java/time/test/java/time/TestOffsetTime.java ! test/java/time/test/java/time/TestPeriod.java - test/java/time/test/java/time/TestPeriodParser.java + test/java/time/test/java/time/TestYear.java + test/java/time/test/java/time/TestYearMonth.java ! test/java/time/test/java/time/TestZoneId.java + test/java/time/test/java/time/chrono/TestExampleCode.java + test/java/time/test/java/time/chrono/TestIsoChronoImpl.java + test/java/time/test/java/time/chrono/TestServiceLoader.java ! test/java/time/test/java/time/format/TestCharLiteralParser.java ! test/java/time/test/java/time/format/TestCharLiteralPrinter.java + test/java/time/test/java/time/format/TestDateTimeFormatterBuilder.java - test/java/time/test/java/time/format/TestDateTimeFormatters.java - test/java/time/test/java/time/format/TestDateTimePrintException.java ! test/java/time/test/java/time/format/TestDateTimeTextProvider.java ! test/java/time/test/java/time/format/TestFractionPrinterParser.java + test/java/time/test/java/time/format/TestNonIsoFormatter.java ! test/java/time/test/java/time/format/TestNumberParser.java ! test/java/time/test/java/time/format/TestNumberPrinter.java - test/java/time/test/java/time/format/TestPadParserDecorator.java ! test/java/time/test/java/time/format/TestPadPrinterDecorator.java ! test/java/time/test/java/time/format/TestReducedParser.java ! test/java/time/test/java/time/format/TestReducedPrinter.java ! test/java/time/test/java/time/format/TestSettingsParser.java ! test/java/time/test/java/time/format/TestStringLiteralParser.java ! test/java/time/test/java/time/format/TestStringLiteralPrinter.java ! test/java/time/test/java/time/format/TestTextParser.java ! test/java/time/test/java/time/format/TestTextPrinter.java - test/java/time/test/java/time/format/TestZoneIdParser.java ! test/java/time/test/java/time/format/TestZoneOffsetParser.java ! test/java/time/test/java/time/format/TestZoneOffsetPrinter.java ! test/java/time/test/java/time/format/TestZoneTextPrinterParser.java + test/java/time/test/java/time/format/ZoneName.java ! test/java/time/test/java/time/temporal/MockFieldNoValue.java ! test/java/time/test/java/time/temporal/MockFieldValue.java ! test/java/time/test/java/time/temporal/TestChronoUnit.java ! test/java/time/test/java/time/temporal/TestDateTimeBuilderCombinations.java - test/java/time/test/java/time/temporal/TestISOChronoImpl.java ! test/java/time/test/java/time/temporal/TestJapaneseChronoImpl.java + test/java/time/test/java/time/temporal/TestJulianFields.java - test/java/time/test/java/time/temporal/TestMonthDay.java - test/java/time/test/java/time/temporal/TestOffsetDate.java - test/java/time/test/java/time/temporal/TestOffsetDateTime.java - test/java/time/test/java/time/temporal/TestOffsetDateTime_instants.java - test/java/time/test/java/time/temporal/TestOffsetTime.java ! test/java/time/test/java/time/temporal/TestThaiBuddhistChronoImpl.java - test/java/time/test/java/time/temporal/TestYear.java - test/java/time/test/java/time/temporal/TestYearMonth.java ! test/java/time/test/java/time/zone/TestFixedZoneRules.java ! test/java/time/test/java/util/TestFormatter.java + test/java/util/Calendar/JavatimeTest.java ! test/java/util/TimeZone/OldIDMappingTest.java + test/java/util/TimeZone/TzIDOldMapping.java + test/sun/util/calendar/zi/BackEnd.java + test/sun/util/calendar/zi/Checksum.java + test/sun/util/calendar/zi/DayOfWeek.java + test/sun/util/calendar/zi/Gen.java + test/sun/util/calendar/zi/GenDoc.java + test/sun/util/calendar/zi/Main.java + test/sun/util/calendar/zi/Mappings.java + test/sun/util/calendar/zi/Month.java + test/sun/util/calendar/zi/Rule.java + test/sun/util/calendar/zi/RuleDay.java + test/sun/util/calendar/zi/RuleRec.java + test/sun/util/calendar/zi/Simple.java + test/sun/util/calendar/zi/TestZoneInfo310.java + test/sun/util/calendar/zi/Time.java + test/sun/util/calendar/zi/Timezone.java + test/sun/util/calendar/zi/TzIDOldMapping.java + test/sun/util/calendar/zi/Zone.java + test/sun/util/calendar/zi/ZoneInfoFile.java + test/sun/util/calendar/zi/ZoneInfoOld.java + test/sun/util/calendar/zi/ZoneRec.java + test/sun/util/calendar/zi/Zoneinfo.java + test/sun/util/calendar/zi/tzdata/VERSION + test/sun/util/calendar/zi/tzdata/africa + test/sun/util/calendar/zi/tzdata/antarctica + test/sun/util/calendar/zi/tzdata/asia + test/sun/util/calendar/zi/tzdata/australasia + test/sun/util/calendar/zi/tzdata/backward + test/sun/util/calendar/zi/tzdata/etcetera + test/sun/util/calendar/zi/tzdata/europe + test/sun/util/calendar/zi/tzdata/factory + test/sun/util/calendar/zi/tzdata/gmt + test/sun/util/calendar/zi/tzdata/iso3166.tab + test/sun/util/calendar/zi/tzdata/jdk11_backward + test/sun/util/calendar/zi/tzdata/leapseconds + test/sun/util/calendar/zi/tzdata/northamerica + test/sun/util/calendar/zi/tzdata/pacificnew + test/sun/util/calendar/zi/tzdata/solar87 + test/sun/util/calendar/zi/tzdata/solar88 + test/sun/util/calendar/zi/tzdata/solar89 + test/sun/util/calendar/zi/tzdata/southamerica + test/sun/util/calendar/zi/tzdata/systemv + test/sun/util/calendar/zi/tzdata/zone.tab + test/sun/util/calendar/zi/tzdata_jdk/gmt + test/sun/util/calendar/zi/tzdata_jdk/jdk11_backward + test/sun/util/calendar/zi/tzdata_jdk/jdk11_full_backward Changeset: 2cd67a8c7abc Author: jfranck Date: 2013-02-13 10:36 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/2cd67a8c7abc 8007278: Rename j.l.r.AnnotatedElement.getAnnotations(Class) to getAnnotationsByType(Class) Reviewed-by: darcy, abuckley ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/Package.java ! src/share/classes/java/lang/reflect/AccessibleObject.java ! src/share/classes/java/lang/reflect/AnnotatedElement.java ! src/share/classes/java/lang/reflect/Executable.java ! src/share/classes/java/lang/reflect/Field.java ! src/share/classes/java/lang/reflect/Parameter.java ! src/share/classes/sun/reflect/annotation/AnnotatedTypeFactory.java ! src/share/classes/sun/reflect/generics/reflectiveObjects/TypeVariableImpl.java ! test/java/lang/annotation/TypeParamAnnotation.java ! test/java/lang/annotation/repeatingAnnotations/RepeatedUnitTest.java Changeset: cd111064d4e9 Author: zgu Date: 2013-02-12 14:47 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/cd111064d4e9 8006691: Remove jvm_version_info->is_kernel_jvm field Summary: Remove is_kernel_jvm field in jvm_version_info structure, as kernel VM has been deprecated Reviewed-by: mchung ! src/share/javavm/export/jvm.h Changeset: bf64f83aa0cd Author: vinnie Date: 2013-02-13 16:01 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/bf64f83aa0cd 8007934: algorithm parameters for PBE Scheme 2 not decoded correctly in PKCS12 keystore Reviewed-by: mullan ! src/share/classes/sun/security/pkcs12/PKCS12KeyStore.java ! test/java/security/KeyStore/PBETest.java Changeset: ceb7c712c693 Author: vinnie Date: 2013-02-13 16:03 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/ceb7c712c693 Merge Changeset: 8181be9a3538 Author: dsamersoff Date: 2013-02-13 21:06 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/8181be9a3538 8008095: TEST_BUG: JDK-8002048 one more testcase failure on Solaris Summary: fixed couple of more Solaris shell incompatibilities Reviewed-by: chegar ! test/sun/management/jdp/JdpTest.sh Changeset: 11438befdd4c Author: vinnie Date: 2013-02-13 19:40 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/11438befdd4c 8007755: Support the logical grouping of keystores Reviewed-by: mullan ! src/share/classes/java/security/KeyStore.java + src/share/classes/sun/security/provider/DomainKeyStore.java ! src/share/classes/sun/security/provider/PolicyParser.java ! src/share/classes/sun/security/provider/Sun.java ! src/share/classes/sun/security/provider/SunEntries.java ! src/share/classes/sun/security/util/Resources.java + test/sun/security/provider/KeyStore/DKSTest.java + test/sun/security/provider/KeyStore/DKSTest.sh + test/sun/security/provider/KeyStore/domains.cfg ! test/sun/security/tools/keytool/AltProviderPath.sh ! test/sun/security/tools/keytool/DummyProvider.java Changeset: efc66fe16f91 Author: sherman Date: 2013-02-13 11:49 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/efc66fe16f91 8008161: Regression: j.u.TimeZone.getAvailableIDs(rawOffset) returns non-sorted list Summary: to return a sorted list Reviewed-by: lancea, naoto ! src/share/classes/sun/util/calendar/ZoneInfoFile.java ! test/sun/util/calendar/zi/TestZoneInfo310.java Changeset: c5a7ac2a721f Author: ohrstrom Date: 2013-01-31 14:03 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/c5a7ac2a721f 8006872: Stop creating four jars with identical content in the new build system. Reviewed-by: erikj ! makefiles/CreateJars.gmk ! makefiles/GensrcSwing.gmk ! makefiles/Setup.gmk Changeset: 35cf77f633c9 Author: tbell Date: 2013-02-01 09:16 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/35cf77f633c9 8006808: mapfile use check in jdk/make/common/shared/Defs-solaris.gmk is throwing 'egrep: syntax error' Summary: Use a valid egrep expression in the non-SPARC case Reviewed-by: dholmes ! make/common/shared/Defs-solaris.gmk Changeset: 5692ebe15321 Author: erikj Date: 2013-02-04 10:58 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/5692ebe15321 8007268: build-infra: configure reports Solaris needs gcc for deploy, but logs don't indicate it's used. Reviewed-by: tbell, katleman ! make/common/shared/Sanity.gmk Changeset: 3a2630528661 Author: katleman Date: 2013-02-05 18:54 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/3a2630528661 Merge Changeset: 933742f4bb4c Author: katleman Date: 2013-02-07 12:33 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/933742f4bb4c Added tag jdk8-b76 for changeset 3a2630528661 ! .hgtags Changeset: e63e7ee18412 Author: bae Date: 2013-02-01 20:06 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/e63e7ee18412 8004801: The image of BufferedImage.TYPE_INT_ARGB is blank. Reviewed-by: prr ! src/share/native/sun/awt/image/awt_parseImage.c ! src/solaris/native/sun/awt/awt_Mlib.c ! src/solaris/native/sun/awt/awt_Mlib.h ! src/windows/native/sun/windows/awt_Mlib.cpp ! src/windows/native/sun/windows/awt_Mlib.h + test/java/awt/image/LookupOp/IntImageReverseTest.java Changeset: 1df2944db538 Author: serb Date: 2013-02-04 19:50 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/1df2944db538 8004821: Graphics2D.drawPolygon() fails with IllegalPathStateException Reviewed-by: prr, flar ! src/share/classes/sun/java2d/pipe/PixelToShapeConverter.java + test/sun/java2d/pipe/Test8004821.java Changeset: 8fc3e4015b09 Author: jgodinez Date: 2013-02-04 12:04 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/8fc3e4015b09 8005052: [parfait] #416 X11SurfaceData.c UNINITIALISED OR MISSING RETURN VALUE 8005054: [parfait] #417 X11SurfaceData.c UNINITIALISED OR MISSING RETURN VALUE Reviewed-by: prr, vadim Contributed-by: jia-hong.chen at oracle.com ! src/solaris/native/sun/java2d/x11/X11SurfaceData.c Changeset: fd61fcc1a5a9 Author: leonidr Date: 2013-01-31 18:25 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/fd61fcc1a5a9 8007006: [macosx] Closing subwindow loses main window menus Reviewed-by: anthony ! src/macosx/native/sun/awt/AWTWindow.m Changeset: 452deb976c92 Author: ptbrunet Date: 2013-01-31 18:51 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/452deb976c92 7179482: Component.accessibleContext and JComponent.accessibleContext refactoring Reviewed-by: art, anthony, alexsch ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Container.java ! src/share/classes/javax/swing/JComponent.java Changeset: 0b56a169295f Author: pchelko Date: 2013-02-04 13:54 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/0b56a169295f 8005405: [macosx] Drag and Drop: wrong animation when dropped outside any drop target. Summary: Changed the calculation of the drag image offset Reviewed-by: serb, kizune ! src/macosx/classes/sun/lwawt/macosx/CDragSourceContextPeer.java ! src/macosx/native/sun/awt/CDragSource.m Changeset: 171443b1eb3b Author: kshefov Date: 2013-02-04 16:01 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/171443b1eb3b 7077259: [TEST_BUG] [macosx] Test work correctly only when default L&F is Metal Reviewed-by: serb, alexsch ! test/javax/swing/JSlider/4252173/bug4252173.java ! test/javax/swing/JSpinner/6532833/bug6532833.java ! test/javax/swing/plaf/metal/MetalSliderUI/Test6657026.java Changeset: 0e929be3a9da Author: lana Date: 2013-02-05 11:10 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/0e929be3a9da Merge Changeset: f26b539bf1d5 Author: lana Date: 2013-02-05 11:11 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/f26b539bf1d5 Merge - src/share/classes/java/lang/annotation/ContainedBy.java - src/share/classes/java/lang/annotation/ContainerFor.java - test/java/net/URL/abnormal_http_urls - test/java/net/URL/ftp_urls - test/java/net/URL/jar_urls - test/java/net/URL/normal_http_urls - test/java/net/URL/runconstructor.sh - test/java/net/URL/share_file_urls - test/java/net/URL/win32_file_urls - test/sun/net/www/EncDec.doc - test/sun/net/www/MarkResetTest.java - test/sun/net/www/MarkResetTest.sh - test/sun/security/util/Oid/S11N.sh - test/sun/security/util/Oid/SerialTest.java Changeset: b2fc8e31cecc Author: lana Date: 2013-02-11 16:14 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/b2fc8e31cecc Merge - src/share/classes/java/lang/annotation/ContainedBy.java - src/share/classes/java/lang/annotation/ContainerFor.java - test/java/net/URL/abnormal_http_urls - test/java/net/URL/ftp_urls - test/java/net/URL/jar_urls - test/java/net/URL/normal_http_urls - test/java/net/URL/runconstructor.sh - test/java/net/URL/share_file_urls - test/java/net/URL/win32_file_urls - test/sun/net/www/EncDec.doc - test/sun/net/www/MarkResetTest.java - test/sun/net/www/MarkResetTest.sh - test/sun/security/util/Oid/S11N.sh - test/sun/security/util/Oid/SerialTest.java Changeset: ff80a6b2ae9b Author: lana Date: 2013-02-13 11:25 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/ff80a6b2ae9b Merge Changeset: a5aad284904e Author: lana Date: 2013-02-13 11:57 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/a5aad284904e Merge Changeset: 83c09292f5ad Author: ksrini Date: 2013-02-13 12:56 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/83c09292f5ad 8005750: [parfait] Memory leak at jdk/src/share/bin/parse_manifest.c Reviewed-by: jjh ! src/share/bin/parse_manifest.c Changeset: b13247d5408d Author: dcubed Date: 2013-02-13 13:22 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/b13247d5408d 8007935: java/lang/instrument/RedefineSubclassWithTwoInterfaces.sh should use $COMPILEJAVA for javac Reviewed-by: sspitsyn, alanb ! test/java/lang/instrument/RedefineSubclassWithTwoInterfaces.sh Changeset: 4f520ce7ba3f Author: acorn Date: 2013-02-13 16:09 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/4f520ce7ba3f 8007888: jdk fix default method: VerifyError: Illegal use of nonvirtual Summary: Recognize VM generated method in old verifier. With 8004967 Reviewed-by: coleenp, acorn Contributed-by: bharadwaj.yadavalli at oracle.com ! src/share/javavm/export/jvm.h ! src/share/native/common/check_code.c Changeset: e6f34051c60c Author: acorn Date: 2013-02-13 16:15 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/e6f34051c60c Merge Changeset: 153884b550f0 Author: chegar Date: 2013-02-14 13:01 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/153884b550f0 8008201: Add java/lang/Class/asSubclass/BasicUnit.java to the ProblemList Reviewed-by: mcimadamore ! test/ProblemList.txt Changeset: e57019d2f34a Author: mduigou Date: 2013-02-13 14:50 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/e57019d2f34a 8008167: IdentityHashMap.[keySet|values|entrySet].toArray speed-up Reviewed-by: mduigou, martin Contributed-by: Peter Levart ! src/share/classes/java/util/IdentityHashMap.java Changeset: 1405ad6afb1e Author: bharadwaj Date: 2013-02-14 11:09 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/1405ad6afb1e 8007736: VerifyError for use of static method in interface Reviewed-by: mchung ! src/share/native/common/check_code.c + test/vm/verifier/TestStaticIF.java Changeset: 1ce1a307cded Author: sherman Date: 2013-02-15 01:17 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/1ce1a307cded 8008254: j.u.Calendar.JavatimeTest failed at TL b78 pit testing Summary: to use j.t.ZoneId zone name to keep round-trip Reviewed-by: okutsu ! test/java/util/Calendar/JavatimeTest.java Changeset: 048637b40787 Author: chegar Date: 2013-02-15 11:06 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/048637b40787 8008223: java/net/BindException/Test.java fails rarely Reviewed-by: khazra, alanb ! test/java/net/BindException/Test.java Changeset: 7748ffdca16a Author: rfield Date: 2013-02-16 12:36 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/7748ffdca16a 8004970: Implement serialization in the lambda metafactory Reviewed-by: forax ! src/share/classes/java/lang/invoke/AbstractValidatingLambdaMetafactory.java ! src/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java ! src/share/classes/java/lang/invoke/LambdaMetafactory.java ! src/share/classes/java/lang/invoke/MethodHandleInfo.java + src/share/classes/java/lang/invoke/SerializedLambda.java ! src/share/classes/java/lang/invoke/TypeConvertingMethodAdapter.java + test/java/lang/invoke/lambda/LambdaSerialization.java Changeset: 43726ed11fb3 Author: sherman Date: 2013-02-17 01:01 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/43726ed11fb3 8008348: The leftover jdk/make/tools/javazic causes build problems with hs25-b19 control Summary: To remove jdk/make/tools/javazic from the jdk repo Reviewed-by: alanb - make/tools/javazic/Makefile - make/tools/src/build/tools/javazic/BackEnd.java - make/tools/src/build/tools/javazic/Checksum.java - make/tools/src/build/tools/javazic/DayOfWeek.java - make/tools/src/build/tools/javazic/Gen.java - make/tools/src/build/tools/javazic/GenDoc.java - make/tools/src/build/tools/javazic/Main.java - make/tools/src/build/tools/javazic/Mappings.java - make/tools/src/build/tools/javazic/Month.java - make/tools/src/build/tools/javazic/Rule.java - make/tools/src/build/tools/javazic/RuleDay.java - make/tools/src/build/tools/javazic/RuleRec.java - make/tools/src/build/tools/javazic/Simple.java - make/tools/src/build/tools/javazic/Time.java - make/tools/src/build/tools/javazic/Timezone.java - make/tools/src/build/tools/javazic/Zone.java - make/tools/src/build/tools/javazic/ZoneRec.java - make/tools/src/build/tools/javazic/Zoneinfo.java Changeset: ce6a2fcb4c9b Author: yhuang Date: 2013-02-16 21:22 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/ce6a2fcb4c9b 8006748: getISO3Country() returns wrong value Reviewed-by: naoto ! src/share/classes/java/util/LocaleISOData.java Changeset: bcde0486261e Author: dingxmin Date: 2013-02-18 08:14 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/bcde0486261e 6429204: (se) Concurrent Selector.register and SelectionKey.interestOps can ignore interestOps Reviewed-by: alanb ! src/windows/classes/sun/nio/ch/WindowsSelectorImpl.java + test/java/nio/channels/Selector/RacyDeregister.java Changeset: 49b3d8efd30a Author: darcy Date: 2013-02-19 00:19 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/49b3d8efd30a 8008434: Misc javadoc warning fixes in DateTimeFormatterBuilder and TimeZone Reviewed-by: mduigou, okutsu ! src/share/classes/java/time/format/DateTimeFormatterBuilder.java ! src/share/classes/java/util/TimeZone.java Changeset: 885bb24f6018 Author: coffeys Date: 2013-02-19 14:07 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/885bb24f6018 7197187: Currency.isPastCutoverDate should be made more robust Reviewed-by: alanb ! src/share/classes/java/util/Currency.java Changeset: 01b6b0dd2006 Author: coffeys Date: 2013-02-19 14:12 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/01b6b0dd2006 8007315: HttpURLConnection.filterHeaderField method returns null where empty string is expected Reviewed-by: chegar ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java ! test/sun/net/www/protocol/http/HttpOnly.java Changeset: 824187de1591 Author: jzavgren Date: 2013-02-19 16:19 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/824187de1591 8007609: WinNTFileSystem_md.c should correctly check value returned from realloc Reviewed-by: alanb, chegar, dholmes ! src/windows/native/java/io/WinNTFileSystem_md.c Changeset: e20c1c9197bf Author: emc Date: 2013-02-19 17:09 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/e20c1c9197bf 8008312: Re-enable MethodParameter tests in JDK Reviewed-by: darcy ! src/share/classes/java/lang/reflect/Parameter.java ! test/java/lang/reflect/Parameter/WithParameters.java Changeset: af396ec087f4 Author: naoto Date: 2013-02-19 10:34 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/af396ec087f4 7092447: Clarify the default locale used in each locale sensitive operation Reviewed-by: okutsu ! src/share/classes/java/text/DateFormat.java ! src/share/classes/java/text/DateFormatSymbols.java ! src/share/classes/java/text/DecimalFormat.java ! src/share/classes/java/text/DecimalFormatSymbols.java ! src/share/classes/java/text/MessageFormat.java ! src/share/classes/java/text/NumberFormat.java ! src/share/classes/java/text/SimpleDateFormat.java ! src/share/classes/java/time/format/DateTimeFormatSymbols.java ! src/share/classes/java/util/Calendar.java ! src/share/classes/java/util/Currency.java ! src/share/classes/java/util/Formatter.java ! src/share/classes/java/util/GregorianCalendar.java ! src/share/classes/java/util/Locale.java ! src/share/classes/java/util/Scanner.java Changeset: 16efb7ba188f Author: mduigou Date: 2013-02-19 11:56 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/16efb7ba188f 8004561: Additional functional interfaces, extension methods and name changes Summary: Adds additional functional interfaces for primitives and "Bi" (two operand). Adds utility extension methods. Includes some name changes for existing functional interfaces per EG decisions. Reviewed-by: briangoetz, darcy, chegar, dholmes ! src/share/classes/java/time/chrono/HijrahDeviationReader.java ! src/share/classes/java/util/concurrent/atomic/AtomicInteger.java ! src/share/classes/java/util/concurrent/atomic/AtomicIntegerArray.java ! src/share/classes/java/util/concurrent/atomic/AtomicIntegerFieldUpdater.java ! src/share/classes/java/util/concurrent/atomic/AtomicLong.java ! src/share/classes/java/util/concurrent/atomic/AtomicLongArray.java ! src/share/classes/java/util/concurrent/atomic/AtomicLongFieldUpdater.java ! src/share/classes/java/util/concurrent/atomic/AtomicReference.java ! src/share/classes/java/util/concurrent/atomic/AtomicReferenceArray.java ! src/share/classes/java/util/concurrent/atomic/AtomicReferenceFieldUpdater.java ! src/share/classes/java/util/concurrent/atomic/DoubleAccumulator.java ! src/share/classes/java/util/concurrent/atomic/LongAccumulator.java ! src/share/classes/java/util/concurrent/atomic/Striped64.java + src/share/classes/java/util/function/BiConsumer.java + src/share/classes/java/util/function/BiFunction.java + src/share/classes/java/util/function/BiPredicate.java ! src/share/classes/java/util/function/BinaryOperator.java - src/share/classes/java/util/function/Block.java + src/share/classes/java/util/function/BooleanSupplier.java + src/share/classes/java/util/function/Consumer.java ! src/share/classes/java/util/function/DoubleBinaryOperator.java - src/share/classes/java/util/function/DoubleBlock.java + src/share/classes/java/util/function/DoubleConsumer.java ! src/share/classes/java/util/function/DoubleFunction.java + src/share/classes/java/util/function/DoublePredicate.java ! src/share/classes/java/util/function/DoubleSupplier.java ! src/share/classes/java/util/function/DoubleUnaryOperator.java ! src/share/classes/java/util/function/Function.java ! src/share/classes/java/util/function/IntBinaryOperator.java - src/share/classes/java/util/function/IntBlock.java + src/share/classes/java/util/function/IntConsumer.java ! src/share/classes/java/util/function/IntFunction.java + src/share/classes/java/util/function/IntPredicate.java ! src/share/classes/java/util/function/IntSupplier.java ! src/share/classes/java/util/function/IntUnaryOperator.java ! src/share/classes/java/util/function/LongBinaryOperator.java - src/share/classes/java/util/function/LongBlock.java + src/share/classes/java/util/function/LongConsumer.java ! src/share/classes/java/util/function/LongFunction.java + src/share/classes/java/util/function/LongPredicate.java ! src/share/classes/java/util/function/LongSupplier.java ! src/share/classes/java/util/function/LongUnaryOperator.java + src/share/classes/java/util/function/ObjDoubleConsumer.java + src/share/classes/java/util/function/ObjIntConsumer.java + src/share/classes/java/util/function/ObjLongConsumer.java ! src/share/classes/java/util/function/Predicate.java + src/share/classes/java/util/function/ToDoubleBiFunction.java + src/share/classes/java/util/function/ToDoubleFunction.java + src/share/classes/java/util/function/ToIntBiFunction.java + src/share/classes/java/util/function/ToIntFunction.java + src/share/classes/java/util/function/ToLongBiFunction.java + src/share/classes/java/util/function/ToLongFunction.java ! src/share/classes/java/util/function/UnaryOperator.java ! src/share/classes/java/util/function/package-info.java ! test/java/lang/PrimitiveSumMinMaxTest.java Changeset: 267bca6af07e Author: jzavgren Date: 2013-02-19 15:31 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/267bca6af07e 8008107: [parfait] Use after free of pointer in jdk/src/share/native/sun/security/pkcs11/wrapper/p11_convert.c Reviewed-by: mullan, chegar ! src/share/native/sun/security/pkcs11/wrapper/p11_convert.c Changeset: ec1a79c3a99c Author: ksrini Date: 2013-02-19 16:49 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/ec1a79c3a99c 8008262: pack200 should support MethodParameters - part 2 Reviewed-by: jrose ! src/share/classes/com/sun/java/util/jar/pack/Attribute.java ! src/share/classes/com/sun/java/util/jar/pack/BandStructure.java ! src/share/classes/com/sun/java/util/jar/pack/PackageReader.java ! src/share/native/com/sun/java/util/jar/pack/bands.cpp ! src/share/native/com/sun/java/util/jar/pack/bands.h ! src/share/native/com/sun/java/util/jar/pack/unpack.cpp ! test/tools/pack200/AttributeTests.java ! test/tools/pack200/Utils.java Changeset: c1304eb051f6 Author: katleman Date: 2013-02-14 11:44 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/c1304eb051f6 Added tag jdk8-b77 for changeset b2fc8e31cecc ! .hgtags Changeset: 37719b174e87 Author: jgodinez Date: 2013-02-06 14:45 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/37719b174e87 8005194: [parfait] #353 sun/awt/image/jpeg/imageioJPEG.c Memory leak of pointer 'scale' allocated with calloc() Reviewed-by: prr, vadim Contributed-by: jia-hong.chen at oracle.com ! src/share/native/sun/awt/image/jpeg/imageioJPEG.c Changeset: ad49012d10a1 Author: jgodinez Date: 2013-02-08 11:25 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/ad49012d10a1 8005129: [parfait] #1122 - #1130 native/sun/awt/medialib/mlib_Image*.c Memory leak of pointer 'k' allocated with mlib_malloc Reviewed-by: prr, vadim Contributed-by: jia-hong.chen at oracle.com ! src/share/native/sun/awt/medialib/mlib_ImageConv.h ! src/share/native/sun/awt/medialib/mlib_ImageConvMxN_ext.c ! src/share/native/sun/awt/medialib/mlib_ImageConv_16ext.c ! src/share/native/sun/awt/medialib/mlib_ImageConv_16nw.c ! src/share/native/sun/awt/medialib/mlib_ImageConv_32nw.c ! src/share/native/sun/awt/medialib/mlib_ImageConv_8ext.c ! src/share/native/sun/awt/medialib/mlib_ImageConv_8nw.c ! src/share/native/sun/awt/medialib/mlib_ImageConv_u16ext.c ! src/share/native/sun/awt/medialib/mlib_ImageConv_u16nw.c ! src/share/native/sun/awt/medialib/mlib_ImageCreate.c ! src/share/native/sun/awt/medialib/mlib_c_ImageConv.h Changeset: 1ea9feb6d8c5 Author: jgodinez Date: 2013-02-08 11:36 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/1ea9feb6d8c5 8005261: [parfait] #415 sun/java2d/opengl/GLXSurfaceData.c Memory leak of pointer 'glxsdo' allocated with malloc Reviewed-by: prr, vadim Contributed-by: jia-hong.chen at oracle.com ! src/solaris/native/sun/java2d/opengl/GLXSurfaceData.c Changeset: 5f0217537435 Author: prr Date: 2013-02-12 09:58 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/5f0217537435 8007748: MacOSX build error : cast of type 'SEL' to 'uintptr_t' (aka 'unsigned long') is deprecated; use sel_getName instead Reviewed-by: anthony ! src/macosx/native/jobjc/src/core/native/SEL.m Changeset: 1b47e2dfa89a Author: lana Date: 2013-02-13 13:01 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/1b47e2dfa89a Merge - src/share/classes/java/lang/annotation/ContainedBy.java - src/share/classes/java/lang/annotation/ContainerFor.java - test/java/net/URL/abnormal_http_urls - test/java/net/URL/ftp_urls - test/java/net/URL/jar_urls - test/java/net/URL/normal_http_urls - test/java/net/URL/runconstructor.sh - test/java/net/URL/share_file_urls - test/java/net/URL/win32_file_urls - test/sun/net/www/EncDec.doc - test/sun/net/www/MarkResetTest.java - test/sun/net/www/MarkResetTest.sh - test/sun/security/util/Oid/S11N.sh - test/sun/security/util/Oid/SerialTest.java Changeset: 6df3acd02449 Author: prr Date: 2013-02-13 15:06 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/6df3acd02449 8008017: The fix for 8005129 does not build on Windows Reviewed-by: prr, jgodinez Contributed-by: jia-hong.chen at oracle.com ! src/share/native/sun/awt/medialib/mlib_ImageConv_16ext.c ! src/share/native/sun/awt/medialib/mlib_ImageConv_16nw.c ! src/share/native/sun/awt/medialib/mlib_ImageConv_8ext.c ! src/share/native/sun/awt/medialib/mlib_ImageConv_8nw.c ! src/share/native/sun/awt/medialib/mlib_ImageConv_u16ext.c ! src/share/native/sun/awt/medialib/mlib_ImageConv_u16nw.c Changeset: ac89a5d71466 Author: alexsch Date: 2013-02-06 18:25 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/ac89a5d71466 8000326: Focus unable to traverse in the menubar Reviewed-by: alexsch, malenkov ! src/share/classes/javax/swing/JMenuBar.java Changeset: 6e17465f4a1a Author: mcherkas Date: 2013-02-08 22:08 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/6e17465f4a1a 8005932: Java 7 on mac os x only provides text clipboard formats Reviewed-by: alexp, denis ! src/macosx/lib/flavormap.properties + test/java/awt/DataFlavor/MissedHtmlAndRtfBug/AbsoluteComponentCenterCalculator.java + test/java/awt/DataFlavor/MissedHtmlAndRtfBug/DataFlavorSearcher.java + test/java/awt/DataFlavor/MissedHtmlAndRtfBug/InterprocessMessages.java + test/java/awt/DataFlavor/MissedHtmlAndRtfBug/MissedHtmlAndRtfBug.html + test/java/awt/DataFlavor/MissedHtmlAndRtfBug/MissedHtmlAndRtfBug.java + test/java/awt/DataFlavor/MissedHtmlAndRtfBug/MyTransferable.java + test/java/awt/DataFlavor/MissedHtmlAndRtfBug/NextFramePositionCalculator.java + test/java/awt/DataFlavor/MissedHtmlAndRtfBug/SourcePanel.java + test/java/awt/DataFlavor/MissedHtmlAndRtfBug/TargetPanel.java Changeset: 5406c4e381e2 Author: kshefov Date: 2013-02-13 18:01 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/5406c4e381e2 7161759: TEST_BUG: java/awt/Frame/WindowDragTest/WindowDragTest.java fails to compile, should be modified Summary: Added @build Util jtreg tag Reviewed-by: serb, alexsch Contributed-by: Vera Akulova ! test/java/awt/Frame/WindowDragTest/WindowDragTest.java Changeset: dd6cf41a6953 Author: kshefov Date: 2013-02-13 19:06 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/dd6cf41a6953 7132383: [macosx] bug6596966.java should be adapted for Mac Reviewed-by: serb, alexsch Contributed-by: Vera Akulova ! test/javax/swing/JLabel/6596966/bug6596966.java ! test/javax/swing/regtesthelpers/Util.java Changeset: caec64340f42 Author: vkarnauk Date: 2013-02-13 19:23 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/caec64340f42 4199622: RFE: JComboBox shouldn't sending ActionEvents for keyboard navigation Reviewed-by: alexp, alexsch ! src/share/classes/javax/swing/plaf/basic/BasicComboBoxUI.java ! src/share/classes/javax/swing/plaf/basic/BasicLookAndFeel.java + test/javax/swing/JComboBox/4199622/bug4199622.java Changeset: 4d9691e95e05 Author: pchelko Date: 2013-02-13 15:27 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/4d9691e95e05 7079260: InputContext leaks memory Summary: Replaced strong refs with weak refs Reviewed-by: art, serb ! src/share/classes/sun/awt/im/CompositionAreaHandler.java ! src/solaris/classes/sun/awt/X11InputMethod.java + test/java/awt/im/memoryleak/InputContextMemoryLeakTest.java ! test/java/awt/regtesthelpers/Util.java Changeset: c552cde0e3f9 Author: pchelko Date: 2013-02-13 15:32 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/c552cde0e3f9 8005629: javac warnings compiling java.awt.EventDispatchThread and sun.awt.X11.XIconWindow Summary: Removed macosx specific workaround from shared code and made macosx use public API Reviewed-by: art, serb ! src/macosx/classes/sun/lwawt/macosx/CPrinterJob.java - src/macosx/classes/sun/lwawt/macosx/EventDispatchAccess.java ! src/macosx/native/sun/awt/CPrinterJob.m ! src/share/classes/java/awt/EventDispatchThread.java ! src/solaris/classes/sun/awt/X11/XIconWindow.java Changeset: c95dc15ac183 Author: lana Date: 2013-02-13 12:38 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/c95dc15ac183 Merge - src/share/classes/java/lang/annotation/ContainedBy.java - src/share/classes/java/lang/annotation/ContainerFor.java - test/java/net/URL/abnormal_http_urls - test/java/net/URL/ftp_urls - test/java/net/URL/jar_urls - test/java/net/URL/normal_http_urls - test/java/net/URL/runconstructor.sh - test/java/net/URL/share_file_urls - test/java/net/URL/win32_file_urls - test/sun/net/www/EncDec.doc - test/sun/net/www/MarkResetTest.java - test/sun/net/www/MarkResetTest.sh - test/sun/security/util/Oid/S11N.sh - test/sun/security/util/Oid/SerialTest.java Changeset: c9efb349b391 Author: lana Date: 2013-02-13 17:55 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/c9efb349b391 Merge - src/macosx/classes/sun/lwawt/macosx/EventDispatchAccess.java Changeset: dc3019a336c0 Author: lana Date: 2013-02-13 17:57 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/dc3019a336c0 Merge - src/share/classes/java/time/PeriodParser.java - src/share/classes/java/time/calendar/ChronoDateImpl.java - src/share/classes/java/time/calendar/HijrahChrono.java - src/share/classes/java/time/calendar/HijrahDate.java - src/share/classes/java/time/calendar/HijrahDeviationReader.java - src/share/classes/java/time/calendar/HijrahEra.java - src/share/classes/java/time/calendar/JapaneseChrono.java - src/share/classes/java/time/calendar/JapaneseDate.java - src/share/classes/java/time/calendar/JapaneseEra.java - src/share/classes/java/time/calendar/MinguoChrono.java - src/share/classes/java/time/calendar/MinguoDate.java - src/share/classes/java/time/calendar/MinguoEra.java - src/share/classes/java/time/calendar/Ser.java - src/share/classes/java/time/calendar/ThaiBuddhistChrono.java - src/share/classes/java/time/calendar/ThaiBuddhistDate.java - src/share/classes/java/time/calendar/ThaiBuddhistEra.java - src/share/classes/java/time/calendar/package-info.java - src/share/classes/java/time/format/DateTimeFormatters.java - src/share/classes/java/time/format/DateTimePrintException.java - src/share/classes/java/time/temporal/Chrono.java - src/share/classes/java/time/temporal/ChronoLocalDate.java - src/share/classes/java/time/temporal/ChronoLocalDateTime.java - src/share/classes/java/time/temporal/ChronoLocalDateTimeImpl.java - src/share/classes/java/time/temporal/ChronoZonedDateTime.java - src/share/classes/java/time/temporal/ChronoZonedDateTimeImpl.java - src/share/classes/java/time/temporal/Era.java - src/share/classes/java/time/temporal/ISOChrono.java - src/share/classes/java/time/temporal/ISOEra.java - src/share/classes/java/time/temporal/ISOFields.java - src/share/classes/java/time/temporal/MonthDay.java - src/share/classes/java/time/temporal/OffsetDate.java - src/share/classes/java/time/temporal/OffsetDateTime.java - src/share/classes/java/time/temporal/OffsetTime.java - src/share/classes/java/time/temporal/Ser.java - src/share/classes/java/time/temporal/SimplePeriod.java - src/share/classes/java/time/temporal/TemporalAdder.java - src/share/classes/java/time/temporal/TemporalSubtractor.java - src/share/classes/java/time/temporal/Year.java - src/share/classes/java/time/temporal/YearMonth.java - src/share/classes/sun/util/calendar/TzIDOldMapping.java - test/java/time/META-INF/services/java.time.temporal.Chrono - test/java/time/tck/java/time/calendar/CopticChrono.java - test/java/time/tck/java/time/calendar/CopticDate.java - test/java/time/tck/java/time/calendar/CopticEra.java - test/java/time/tck/java/time/calendar/TestChronoLocalDate.java - test/java/time/tck/java/time/calendar/TestChronoLocalDateTime.java - test/java/time/tck/java/time/calendar/TestHijrahChrono.java - test/java/time/tck/java/time/calendar/TestJapaneseChrono.java - test/java/time/tck/java/time/calendar/TestMinguoChrono.java - test/java/time/tck/java/time/calendar/TestServiceLoader.java - test/java/time/tck/java/time/calendar/TestThaiBuddhistChrono.java - test/java/time/tck/java/time/format/TCKDateTimePrintException.java - test/java/time/tck/java/time/temporal/TCKISOFields.java - test/java/time/tck/java/time/temporal/TCKMonthDay.java - test/java/time/tck/java/time/temporal/TCKOffsetDate.java - test/java/time/tck/java/time/temporal/TCKOffsetDateTime.java - test/java/time/tck/java/time/temporal/TCKOffsetTime.java - test/java/time/tck/java/time/temporal/TCKSimplePeriod.java - test/java/time/tck/java/time/temporal/TCKYear.java - test/java/time/tck/java/time/temporal/TCKYearMonth.java - test/java/time/tck/java/time/temporal/TestChrono.java - test/java/time/tck/java/time/temporal/TestISOChrono.java - test/java/time/test/java/time/TestPeriodParser.java - test/java/time/test/java/time/format/TestDateTimeFormatters.java - test/java/time/test/java/time/format/TestDateTimePrintException.java - test/java/time/test/java/time/format/TestPadParserDecorator.java - test/java/time/test/java/time/format/TestZoneIdParser.java - test/java/time/test/java/time/temporal/TestISOChronoImpl.java - test/java/time/test/java/time/temporal/TestMonthDay.java - test/java/time/test/java/time/temporal/TestOffsetDate.java - test/java/time/test/java/time/temporal/TestOffsetDateTime.java - test/java/time/test/java/time/temporal/TestOffsetDateTime_instants.java - test/java/time/test/java/time/temporal/TestOffsetTime.java - test/java/time/test/java/time/temporal/TestYear.java - test/java/time/test/java/time/temporal/TestYearMonth.java Changeset: 5ea0024ba765 Author: lana Date: 2013-02-14 22:12 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/5ea0024ba765 Merge Changeset: 85a44860f5bb Author: lana Date: 2013-02-19 20:52 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/85a44860f5bb Merge - src/macosx/classes/sun/lwawt/macosx/EventDispatchAccess.java Changeset: ca43e2761a1d Author: ykantser Date: 2013-02-13 10:24 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/ca43e2761a1d 8008089: Delete OS dependent check in JdkFinder.getExecutable() Reviewed-by: egahlin, alanb ! test/lib/testlibrary/jdk/testlibrary/JdkFinder.java Changeset: 0a2b308cc82d Author: uta Date: 2013-02-20 16:39 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/0a2b308cc82d 8007454: (process) SetHandleInformation parameters DWORD (not BOOLEAN) Summary: the SetHandleInformation arguments list was fixed. Reviewed-by: alanb ! src/windows/native/java/lang/ProcessImpl_md.c Changeset: 5772e9edbc4c Author: dcubed Date: 2013-02-20 13:23 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/5772e9edbc4c 8008352: java/lang/instrument/RedefineSubclassWithTwoInterfaces.sh fails on MKS Summary: Use more portable pattern counting constructs in test driver. Reviewed-by: sspitsyn, sla, coleenp ! test/java/lang/instrument/RedefineSubclassWithTwoInterfaces.sh Changeset: 1da987f0311a Author: rfield Date: 2013-02-21 15:46 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/1da987f0311a 8008356: Test LambdaSerialization.java failing Summary: run in /othervm mode Reviewed-by: ksrini ! test/java/lang/invoke/lambda/LambdaSerialization.java Changeset: 90707943f83c Author: erikj Date: 2013-02-15 10:41 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/90707943f83c 8005879: Add -DMAC_OS_X_VERSION_MAX_ALLOWED=1070 to builds on Mac Reviewed-by: ohair ! make/common/Defs-macosx.gmk Changeset: 9a693ebd5595 Author: erikj Date: 2013-02-18 10:48 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/9a693ebd5595 Merge - src/macosx/classes/sun/lwawt/macosx/EventDispatchAccess.java - src/share/classes/java/time/PeriodParser.java - src/share/classes/java/time/calendar/ChronoDateImpl.java - src/share/classes/java/time/calendar/HijrahChrono.java - src/share/classes/java/time/calendar/HijrahDate.java - src/share/classes/java/time/calendar/HijrahDeviationReader.java - src/share/classes/java/time/calendar/HijrahEra.java - src/share/classes/java/time/calendar/JapaneseChrono.java - src/share/classes/java/time/calendar/JapaneseDate.java - src/share/classes/java/time/calendar/JapaneseEra.java - src/share/classes/java/time/calendar/MinguoChrono.java - src/share/classes/java/time/calendar/MinguoDate.java - src/share/classes/java/time/calendar/MinguoEra.java - src/share/classes/java/time/calendar/Ser.java - src/share/classes/java/time/calendar/ThaiBuddhistChrono.java - src/share/classes/java/time/calendar/ThaiBuddhistDate.java - src/share/classes/java/time/calendar/ThaiBuddhistEra.java - src/share/classes/java/time/calendar/package-info.java - src/share/classes/java/time/format/DateTimeFormatters.java - src/share/classes/java/time/format/DateTimePrintException.java - src/share/classes/java/time/temporal/Chrono.java - src/share/classes/java/time/temporal/ChronoLocalDate.java - src/share/classes/java/time/temporal/ChronoLocalDateTime.java - src/share/classes/java/time/temporal/ChronoLocalDateTimeImpl.java - src/share/classes/java/time/temporal/ChronoZonedDateTime.java - src/share/classes/java/time/temporal/ChronoZonedDateTimeImpl.java - src/share/classes/java/time/temporal/Era.java - src/share/classes/java/time/temporal/ISOChrono.java - src/share/classes/java/time/temporal/ISOEra.java - src/share/classes/java/time/temporal/ISOFields.java - src/share/classes/java/time/temporal/MonthDay.java - src/share/classes/java/time/temporal/OffsetDate.java - src/share/classes/java/time/temporal/OffsetDateTime.java - src/share/classes/java/time/temporal/OffsetTime.java - src/share/classes/java/time/temporal/Ser.java - src/share/classes/java/time/temporal/SimplePeriod.java - src/share/classes/java/time/temporal/TemporalAdder.java - src/share/classes/java/time/temporal/TemporalSubtractor.java - src/share/classes/java/time/temporal/Year.java - src/share/classes/java/time/temporal/YearMonth.java - src/share/classes/sun/util/calendar/TzIDOldMapping.java - test/java/time/META-INF/services/java.time.temporal.Chrono - test/java/time/tck/java/time/calendar/CopticChrono.java - test/java/time/tck/java/time/calendar/CopticDate.java - test/java/time/tck/java/time/calendar/CopticEra.java - test/java/time/tck/java/time/calendar/TestChronoLocalDate.java - test/java/time/tck/java/time/calendar/TestChronoLocalDateTime.java - test/java/time/tck/java/time/calendar/TestHijrahChrono.java - test/java/time/tck/java/time/calendar/TestJapaneseChrono.java - test/java/time/tck/java/time/calendar/TestMinguoChrono.java - test/java/time/tck/java/time/calendar/TestServiceLoader.java - test/java/time/tck/java/time/calendar/TestThaiBuddhistChrono.java - test/java/time/tck/java/time/format/TCKDateTimePrintException.java - test/java/time/tck/java/time/temporal/TCKISOFields.java - test/java/time/tck/java/time/temporal/TCKMonthDay.java - test/java/time/tck/java/time/temporal/TCKOffsetDate.java - test/java/time/tck/java/time/temporal/TCKOffsetDateTime.java - test/java/time/tck/java/time/temporal/TCKOffsetTime.java - test/java/time/tck/java/time/temporal/TCKSimplePeriod.java - test/java/time/tck/java/time/temporal/TCKYear.java - test/java/time/tck/java/time/temporal/TCKYearMonth.java - test/java/time/tck/java/time/temporal/TestChrono.java - test/java/time/tck/java/time/temporal/TestISOChrono.java - test/java/time/test/java/time/TestPeriodParser.java - test/java/time/test/java/time/format/TestDateTimeFormatters.java - test/java/time/test/java/time/format/TestDateTimePrintException.java - test/java/time/test/java/time/format/TestPadParserDecorator.java - test/java/time/test/java/time/format/TestZoneIdParser.java - test/java/time/test/java/time/temporal/TestISOChronoImpl.java - test/java/time/test/java/time/temporal/TestMonthDay.java - test/java/time/test/java/time/temporal/TestOffsetDate.java - test/java/time/test/java/time/temporal/TestOffsetDateTime.java - test/java/time/test/java/time/temporal/TestOffsetDateTime_instants.java - test/java/time/test/java/time/temporal/TestOffsetTime.java - test/java/time/test/java/time/temporal/TestYear.java - test/java/time/test/java/time/temporal/TestYearMonth.java Changeset: fb7e3edf22b2 Author: erikj Date: 2013-02-18 11:26 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/fb7e3edf22b2 8008294: build-infra: Build-infra closed fails on solaris 11.1 Reviewed-by: ohrstrom, dholmes, tbell ! makefiles/CompileDemos.gmk ! makefiles/CompileNativeLibraries.gmk Changeset: a23b0df73324 Author: erikj Date: 2013-02-18 11:27 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/a23b0df73324 8008295: build-infra: Cleanup in Import.gmk Reviewed-by: ohrstrom, tbell ! makefiles/Import.gmk Changeset: 32549d339437 Author: bpatel Date: 2013-01-21 00:31 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/32549d339437 8006124: javadoc/doclet should be updated to support profiles Reviewed-by: jjg, dholmes ! make/docs/Makefile Changeset: 80afadbf967d Author: alanb Date: 2013-01-21 01:46 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/80afadbf967d 8004182: Add support for profiles in javac Reviewed-by: dholmes ! make/common/Release.gmk Changeset: 353b88963430 Author: dholmes Date: 2013-01-21 21:54 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/353b88963430 8006651: build-infra: Import.gmk needs to add support for the minimal VM Reviewed-by: erikj, ohair ! makefiles/Import.gmk Changeset: 7096f51288ab Author: dholmes Date: 2013-01-21 23:17 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/7096f51288ab 8004265: Add build support for Compact Profiles Reviewed-by: erikj, ohair ! make/tools/src/build/tools/jarreorder/JarReorder.java ! makefiles/BuildJdk.gmk ! makefiles/CreateJars.gmk ! makefiles/Images.gmk + makefiles/ProfileNames.gmk + makefiles/Profiles.gmk Changeset: ccd0aceb1190 Author: alanb Date: 2013-01-21 23:20 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/ccd0aceb1190 8003255: (profiles) Update JAR file specification to support profiles Reviewed-by: dholmes, mchung, ksrini ! src/share/classes/java/net/URLClassLoader.java ! src/share/classes/java/util/jar/Attributes.java + src/share/classes/java/util/jar/UnsupportedProfileException.java ! src/share/classes/sun/launcher/LauncherHelper.java ! src/share/classes/sun/launcher/resources/launcher.properties ! src/share/classes/sun/misc/URLClassPath.java ! src/share/classes/sun/tools/jar/Main.java ! src/share/classes/sun/tools/jar/resources/jar.properties + test/java/net/URLClassLoader/profiles/Basic.java + test/java/net/URLClassLoader/profiles/Lib.java + test/java/net/URLClassLoader/profiles/basic.sh + test/tools/jar/AddAndUpdateProfile.java + test/tools/launcher/profiles/Basic.java + test/tools/launcher/profiles/Logging.java + test/tools/launcher/profiles/Main.java Changeset: c024147205f6 Author: alanb Date: 2013-01-21 23:21 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/c024147205f6 8003256: (profiles) Add support for profile identification Reviewed-by: dholmes, mchung, ksrini ! make/java/version/Makefile ! makefiles/GensrcMisc.gmk ! src/share/classes/sun/misc/Version.java.template + test/tools/launcher/profiles/VersionCheck.java Changeset: 4b3434f5f509 Author: alanb Date: 2013-01-21 23:23 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/4b3434f5f509 8004931: add/removePropertyChangeListener should not exist in subset Profiles of Java SE Reviewed-by: dholmes, mchung, ksrini + make/tools/src/build/tools/RemoveMethods.java ! makefiles/Tools.gmk ! src/share/classes/java/util/jar/Pack200.java ! src/share/classes/java/util/logging/LogManager.java + test/java/util/logging/Reflect.java + test/tools/pack200/NoBeans.java + test/tools/pack200/Reflect.java Changeset: d9cfe581c8fe Author: alanb Date: 2013-01-21 23:35 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/d9cfe581c8fe 8004502: Compact Profiles contents Reviewed-by: dholmes, mchung + makefiles/profile-includes.txt + makefiles/profile-rtjar-includes.txt + test/java/lang/SecurityManager/NoAWT.java + test/java/security/cert/CertStore/NoLDAP.java + test/javax/management/remote/mandatory/connection/NoIIOP.java + test/javax/naming/InitialContext/NoApplet.java + test/sun/net/www/protocol/http/NoNTLM.java + test/sun/security/ssl/sanity/ciphersuites/NoKerberos.java Changeset: d1b29d290ebd Author: dholmes Date: 2013-01-22 19:31 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/d1b29d290ebd Merge Changeset: 0918d6d9c18b Author: dholmes Date: 2013-01-22 20:04 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/0918d6d9c18b 8006667: Merge issue: Profile attribute need to be examined before custom attributes Summary: swap profile checking and FXHelper checking Reviewed-by: alanb ! src/share/classes/sun/launcher/LauncherHelper.java Changeset: 77668918a388 Author: dholmes Date: 2013-02-04 18:08 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/77668918a388 Merge ! make/docs/Makefile ! makefiles/CreateJars.gmk ! makefiles/GensrcMisc.gmk ! makefiles/Tools.gmk ! src/share/classes/sun/misc/URLClassPath.java - test/java/rmi/activation/ActivationSystem/unregisterGroup/CallbackInterface.java - test/java/rmi/activation/ActivationSystem/unregisterGroup/Callback_Stub.java - test/java/rmi/activation/ActivationSystem/unregisterGroup/UnregisterGroup_Stub.java Changeset: f308a689c049 Author: dholmes Date: 2013-02-17 16:44 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/f308a689c049 Merge ! makefiles/Tools.gmk - src/macosx/classes/sun/lwawt/macosx/EventDispatchAccess.java - src/share/classes/java/lang/annotation/ContainedBy.java - src/share/classes/java/lang/annotation/ContainerFor.java - src/share/classes/java/time/PeriodParser.java - src/share/classes/java/time/calendar/ChronoDateImpl.java - src/share/classes/java/time/calendar/HijrahChrono.java - src/share/classes/java/time/calendar/HijrahDate.java - src/share/classes/java/time/calendar/HijrahDeviationReader.java - src/share/classes/java/time/calendar/HijrahEra.java - src/share/classes/java/time/calendar/JapaneseChrono.java - src/share/classes/java/time/calendar/JapaneseDate.java - src/share/classes/java/time/calendar/JapaneseEra.java - src/share/classes/java/time/calendar/MinguoChrono.java - src/share/classes/java/time/calendar/MinguoDate.java - src/share/classes/java/time/calendar/MinguoEra.java - src/share/classes/java/time/calendar/Ser.java - src/share/classes/java/time/calendar/ThaiBuddhistChrono.java - src/share/classes/java/time/calendar/ThaiBuddhistDate.java - src/share/classes/java/time/calendar/ThaiBuddhistEra.java - src/share/classes/java/time/calendar/package-info.java - src/share/classes/java/time/format/DateTimeFormatters.java - src/share/classes/java/time/format/DateTimePrintException.java - src/share/classes/java/time/temporal/Chrono.java - src/share/classes/java/time/temporal/ChronoLocalDate.java - src/share/classes/java/time/temporal/ChronoLocalDateTime.java - src/share/classes/java/time/temporal/ChronoLocalDateTimeImpl.java - src/share/classes/java/time/temporal/ChronoZonedDateTime.java - src/share/classes/java/time/temporal/ChronoZonedDateTimeImpl.java - src/share/classes/java/time/temporal/Era.java - src/share/classes/java/time/temporal/ISOChrono.java - src/share/classes/java/time/temporal/ISOEra.java - src/share/classes/java/time/temporal/ISOFields.java - src/share/classes/java/time/temporal/MonthDay.java - src/share/classes/java/time/temporal/OffsetDate.java - src/share/classes/java/time/temporal/OffsetDateTime.java - src/share/classes/java/time/temporal/OffsetTime.java - src/share/classes/java/time/temporal/Ser.java - src/share/classes/java/time/temporal/SimplePeriod.java - src/share/classes/java/time/temporal/TemporalAdder.java - src/share/classes/java/time/temporal/TemporalSubtractor.java - src/share/classes/java/time/temporal/Year.java - src/share/classes/java/time/temporal/YearMonth.java - src/share/classes/sun/util/calendar/TzIDOldMapping.java - test/java/net/URL/abnormal_http_urls - test/java/net/URL/ftp_urls - test/java/net/URL/jar_urls - test/java/net/URL/normal_http_urls - test/java/net/URL/runconstructor.sh - test/java/net/URL/share_file_urls - test/java/net/URL/win32_file_urls - test/java/time/META-INF/services/java.time.temporal.Chrono - test/java/time/tck/java/time/calendar/CopticChrono.java - test/java/time/tck/java/time/calendar/CopticDate.java - test/java/time/tck/java/time/calendar/CopticEra.java - test/java/time/tck/java/time/calendar/TestChronoLocalDate.java - test/java/time/tck/java/time/calendar/TestChronoLocalDateTime.java - test/java/time/tck/java/time/calendar/TestHijrahChrono.java - test/java/time/tck/java/time/calendar/TestJapaneseChrono.java - test/java/time/tck/java/time/calendar/TestMinguoChrono.java - test/java/time/tck/java/time/calendar/TestServiceLoader.java - test/java/time/tck/java/time/calendar/TestThaiBuddhistChrono.java - test/java/time/tck/java/time/format/TCKDateTimePrintException.java - test/java/time/tck/java/time/temporal/TCKISOFields.java - test/java/time/tck/java/time/temporal/TCKMonthDay.java - test/java/time/tck/java/time/temporal/TCKOffsetDate.java - test/java/time/tck/java/time/temporal/TCKOffsetDateTime.java - test/java/time/tck/java/time/temporal/TCKOffsetTime.java - test/java/time/tck/java/time/temporal/TCKSimplePeriod.java - test/java/time/tck/java/time/temporal/TCKYear.java - test/java/time/tck/java/time/temporal/TCKYearMonth.java - test/java/time/tck/java/time/temporal/TestChrono.java - test/java/time/tck/java/time/temporal/TestISOChrono.java - test/java/time/test/java/time/TestPeriodParser.java - test/java/time/test/java/time/format/TestDateTimeFormatters.java - test/java/time/test/java/time/format/TestDateTimePrintException.java - test/java/time/test/java/time/format/TestPadParserDecorator.java - test/java/time/test/java/time/format/TestZoneIdParser.java - test/java/time/test/java/time/temporal/TestISOChronoImpl.java - test/java/time/test/java/time/temporal/TestMonthDay.java - test/java/time/test/java/time/temporal/TestOffsetDate.java - test/java/time/test/java/time/temporal/TestOffsetDateTime.java - test/java/time/test/java/time/temporal/TestOffsetDateTime_instants.java - test/java/time/test/java/time/temporal/TestOffsetTime.java - test/java/time/test/java/time/temporal/TestYear.java - test/java/time/test/java/time/temporal/TestYearMonth.java - test/sun/net/www/EncDec.doc - test/sun/net/www/MarkResetTest.java - test/sun/net/www/MarkResetTest.sh - test/sun/security/util/Oid/S11N.sh - test/sun/security/util/Oid/SerialTest.java Changeset: 16c684b2ab82 Author: alanb Date: 2013-02-18 08:57 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/16c684b2ab82 8007436: (profiles) Add JSR-310 to Compact Profiles contents Reviewed-by: dholmes, erikj ! makefiles/profile-includes.txt ! makefiles/profile-rtjar-includes.txt Changeset: c24bc91caa67 Author: dholmes Date: 2013-02-18 15:35 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/c24bc91caa67 Merge ! makefiles/Import.gmk Changeset: b46c75e221c7 Author: dholmes Date: 2013-02-19 06:27 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/b46c75e221c7 8008424: Isolate PROFILE make variable from incidental setting in the environment Reviewed-by: erikj, alanb ! makefiles/BuildJdk.gmk Changeset: 6f4615fd32da Author: alanb Date: 2013-02-19 11:08 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/6f4615fd32da 8007097: (profiles) Build needs test to ensure that profile definitions are updated Reviewed-by: dholmes, erikj - make/tools/src/build/tools/RemoveMethods.java + make/tools/src/build/tools/classfile/RemoveMethods.java + make/tools/src/build/tools/deps/CheckDeps.java + make/tools/src/build/tools/deps/refs.allowed ! makefiles/Images.gmk ! makefiles/Tools.gmk ! makefiles/profile-rtjar-includes.txt Changeset: 033f2707ef32 Author: alanb Date: 2013-02-19 11:32 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/033f2707ef32 Merge Changeset: 00b7535d743f Author: dholmes Date: 2013-02-19 17:32 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/00b7535d743f 8008481: Dependency analyzer needs exclusion for profile builds with JFR disabled Reviewed-by: alanb ! make/tools/src/build/tools/deps/refs.allowed Changeset: 03db11a7fb8e Author: lana Date: 2013-02-21 17:43 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/03db11a7fb8e Merge Changeset: 9078c34437ab Author: msheppar Date: 2013-02-21 20:01 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/9078c34437ab 8006182: cleanup to use java.util.Base64 in java security component, providers, and regression tests Summary: Refactored code to use java.util.Base64 Mime Encoder and Decoder as a replacement for sun.misc.BASE64Encoder and sun.misc.BASE64Decoder Reviewed-by: vinnie, chegar, sherman ! src/share/classes/sun/security/pkcs10/PKCS10.java ! src/share/classes/sun/security/provider/X509Factory.java ! src/share/classes/sun/security/tools/jarsigner/Main.java ! src/share/classes/sun/security/tools/keytool/Main.java ! src/share/classes/sun/security/util/ManifestEntryVerifier.java ! src/share/classes/sun/security/util/SignatureFileVerifier.java ! src/share/classes/sun/security/x509/X509CertImpl.java ! src/share/classes/sun/tools/jar/Manifest.java ! src/share/classes/sun/tools/jar/SignatureFile.java ! test/javax/security/auth/kerberos/KerberosTixDateTest.java ! test/sun/security/krb5/auto/HttpNegotiateServer.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLContextImpl/MD2InTrustAnchor.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLContextImpl/TrustTrustedCert.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/X509TrustManagerImpl/BasicConstraints.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/X509TrustManagerImpl/SelfIssuedCert.java ! test/sun/security/ssl/com/sun/net/ssl/internal/www/protocol/https/HttpsClient/ProxyTunnelServer.java ! test/sun/security/ssl/javax/net/ssl/ServerName/SSLSocketSNISensitive.java ! test/sun/security/ssl/javax/net/ssl/TLSv12/DisabledShortRSAKeys.java ! test/sun/security/ssl/javax/net/ssl/TLSv12/ShortRSAKey512.java ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/ProxyTunnelServer.java Changeset: c6d77b2b4478 Author: stefank Date: 2013-01-22 13:53 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/c6d77b2b4478 8006506: Add test for redefining methods in backtraces to java/lang/instrument tests Reviewed-by: sspitsyn, coleenp + test/java/lang/instrument/RedefineMethodInBacktrace.sh + test/java/lang/instrument/RedefineMethodInBacktraceAgent.java + test/java/lang/instrument/RedefineMethodInBacktraceApp.java + test/java/lang/instrument/RedefineMethodInBacktraceTarget.java + test/java/lang/instrument/RedefineMethodInBacktraceTarget_2.java Changeset: 0e93015e77f6 Author: stefank Date: 2013-01-22 15:25 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/0e93015e77f6 7140852: Add test for 7022100 Reviewed-by: sspitsyn, coleenp + test/java/lang/instrument/RedefineMethodWithAnnotations.sh + test/java/lang/instrument/RedefineMethodWithAnnotationsAgent.java + test/java/lang/instrument/RedefineMethodWithAnnotationsAnnotations.java + test/java/lang/instrument/RedefineMethodWithAnnotationsApp.java + test/java/lang/instrument/RedefineMethodWithAnnotationsTarget.java + test/java/lang/instrument/RedefineMethodWithAnnotationsTarget_2.java Changeset: 63fe6a9820b6 Author: alanb Date: 2013-02-22 14:04 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/63fe6a9820b6 8008290: (profiles) Startup regression due to additional checking of JAR file manifests Reviewed-by: lancea, chegar, iris, mchung, sherman ! src/share/classes/java/util/jar/JarFile.java ! src/share/classes/java/util/jar/JavaUtilJarAccessImpl.java ! src/share/classes/sun/misc/JavaUtilJarAccess.java ! src/share/classes/sun/misc/URLClassPath.java Changeset: 9f9dac5a9e74 Author: lancea Date: 2013-02-22 09:29 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/9f9dac5a9e74 8008716: address typo in CallableStatement javadocs Reviewed-by: chegar ! src/share/classes/java/sql/CallableStatement.java Changeset: 8d8a35ac7d40 Author: lancea Date: 2013-02-22 09:58 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/8d8a35ac7d40 Merge Changeset: ea22045ce09b Author: jlaskey Date: 2013-02-22 14:05 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/ea22045ce09b Merge ! makefiles/CreateJars.gmk From james.laskey at oracle.com Fri Feb 22 13:46:09 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Fri, 22 Feb 2013 21:46:09 +0000 Subject: hg: nashorn/jdk8/jdk: 8008756: THIRD_PARTY_README contains Unicode Message-ID: <20130222214645.E87C347D1E@hg.openjdk.java.net> Changeset: ff68fafd6302 Author: jlaskey Date: 2013-02-22 17:45 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/ff68fafd6302 8008756: THIRD_PARTY_README contains Unicode Reviewed-by: jjh Contributed-by: james.laskey at oracle.com ! THIRD_PARTY_README From james.laskey at oracle.com Fri Feb 22 14:03:34 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Fri, 22 Feb 2013 22:03:34 +0000 Subject: hg: nashorn/jdk8/jdk: 8008757: NEWBUILD=true has separate launcher code for jjs Message-ID: <20130222220356.0E83947D2E@hg.openjdk.java.net> Changeset: ce82a0ee7735 Author: jlaskey Date: 2013-02-22 18:03 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/ce82a0ee7735 8008757: NEWBUILD=true has separate launcher code for jjs Reviewed-by: jjh Contributed-by: james.laskey at oracle.com ! makefiles/CompileLaunchers.gmk From james.laskey at oracle.com Fri Feb 22 15:49:28 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Fri, 22 Feb 2013 19:49:28 -0400 Subject: Nashorn forest build break Message-ID: <07A8E259-0E40-433D-893F-856B7F5CB7B9@oracle.com> Don't pull until I figure out what went wrong. Apologies. From james.laskey at oracle.com Fri Feb 22 18:59:24 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Sat, 23 Feb 2013 02:59:24 +0000 Subject: hg: nashorn/jdk8: 8008774: nashorn missing from dependencies after merge with tl Message-ID: <20130223025924.6CF6147D4D@hg.openjdk.java.net> Changeset: 528a9984198f Author: jlaskey Date: 2013-02-22 22:58 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/528a9984198f 8008774: nashorn missing from dependencies after merge with tl Reviewed-by: jjh Contributed-by: james.laskey at oracle.com ! common/makefiles/Main.gmk From james.laskey at oracle.com Fri Feb 22 19:35:00 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Sat, 23 Feb 2013 03:35:00 +0000 Subject: hg: nashorn/jdk8/nashorn: 8008776: Revise BuildNashorn.gmk for changes in new build system Message-ID: <20130223033501.B526A47D50@hg.openjdk.java.net> Changeset: 5452f82eb2ce Author: jlaskey Date: 2013-02-22 23:33 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/5452f82eb2ce 8008776: Revise BuildNashorn.gmk for changes in new build system Reviewed-by: jjh Contributed-by: james.laskey at oracle.com ! makefiles/BuildNashorn.gmk From james.laskey at oracle.com Fri Feb 22 19:37:14 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Sat, 23 Feb 2013 03:37:14 +0000 Subject: hg: nashorn/jdk8/jdk: 8008775: Remove non-ascii from jdk/THIRD_PARTY_README Message-ID: <20130223033734.7EAA847D53@hg.openjdk.java.net> Changeset: 20a827b22a2e Author: jlaskey Date: 2013-02-22 23:36 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/20a827b22a2e 8008775: Remove non-ascii from jdk/THIRD_PARTY_README Reviewed-by: jjh Contributed-by: james.laskey at oracle.com ! THIRD_PARTY_README From james.laskey at oracle.com Fri Feb 22 19:47:29 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Fri, 22 Feb 2013 23:47:29 -0400 Subject: Nashorn forest build break - repaired In-Reply-To: <07A8E259-0E40-433D-893F-856B7F5CB7B9@oracle.com> References: <07A8E259-0E40-433D-893F-856B7F5CB7B9@oracle.com> Message-ID: Safe to pull again. On 2013-02-22, at 7:49 PM, Jim Laskey (Oracle) wrote: > Don't pull until I figure out what went wrong. Apologies. From newair007 at gmail.com Sat Feb 23 06:24:31 2013 From: newair007 at gmail.com (AMILA RANATUNGA) Date: Sat, 23 Feb 2013 19:54:31 +0530 Subject: Using Nashorn instead of Rhino in a project. Message-ID: Hi, We have a project which has been implemented using Rhino. Will it be compatible with Nashorn?. Are those API's are equivalent? Thnaks ..!! From sundararajan.athijegannathan at oracle.com Sat Feb 23 06:31:07 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Sat, 23 Feb 2013 20:01:07 +0530 Subject: Using Nashorn instead of Rhino in a project. In-Reply-To: References: Message-ID: <5128D2AB.3000003@oracle.com> When you say API, do you mean Java API to access script engine? If you use javax.script API to access Rhino engine, you could use the same API to access nashorn as well. If you had used Rhino's own API, then you'll have to port - I'd suggest using javax.script API. In terms of language, nashorn is compliant with ECMAScript 262 Edition 5.2 specification (pass all test262 tests). Rhino has a number of language additions + standard object additions (like __proto__ non-standard property for objects). Nashorn does not support all of it - but most often used are supported. Also, there is a mozilla_compat.js script which can be loaded load("nashorn:mozilla_compat.js"); This will support for __proto__, __defineGetter__ etc. (few of the less often used features). You may want to check out nashorn/doc/JavaScriptingProgrammersGuide.html for details. -Sundar On Saturday 23 February 2013 07:54 PM, AMILA RANATUNGA wrote: > Hi, > > We have a project which has been implemented using Rhino. Will it be > compatible with Nashorn?. Are those API's are equivalent? > > Thnaks ..!! From sundararajan.athijegannathan at oracle.com Mon Feb 25 00:54:05 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Mon, 25 Feb 2013 14:24:05 +0530 Subject: Review request JDK-800871 Message-ID: <512B26AD.9000703@oracle.com> Please review http://cr.openjdk.java.net/~sundar/8008731/webrev.01/ PS. Please ignore earlier webrev.00 on the same bug -Sundar From hannes.wallnoefer at oracle.com Mon Feb 25 01:15:45 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Mon, 25 Feb 2013 10:15:45 +0100 Subject: Review request JDK-800871 In-Reply-To: <512B26AD.9000703@oracle.com> References: <512B26AD.9000703@oracle.com> Message-ID: <512B2BC1.1000907@oracle.com> Nice to have all those options out of context. +1. Hannes Am 2013-02-25 09:54, schrieb A. Sundararajan: > Please review http://cr.openjdk.java.net/~sundar/8008731/webrev.01/ > > PS. Please ignore earlier webrev.00 on the same bug > > -Sundar From sundararajan.athijegannathan at oracle.com Mon Feb 25 01:23:54 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Mon, 25 Feb 2013 14:53:54 +0530 Subject: Review request JDK-8008789: Enable java access and nashorn runtime tests for jtreg Message-ID: <512B2DAA.8010403@oracle.com> Please review http://cr.openjdk.java.net/~sundar/8008789/ Thanks -Sundar From sundararajan.athijegannathan at oracle.com Mon Feb 25 03:29:02 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Mon, 25 Feb 2013 11:29:02 +0000 Subject: hg: nashorn/jdk8/nashorn: 8008731: Separate configuration environment (options, error/output writer etc.) from Context Message-ID: <20130225112904.38CF147E1C@hg.openjdk.java.net> Changeset: 927fba6785b0 Author: sundar Date: 2013-02-25 16:58 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/927fba6785b0 8008731: Separate configuration environment (options, error/output writer etc.) from Context Reviewed-by: hannesw, lagergren ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/codegen/ClassEmitter.java ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/CompilationPhase.java ! src/jdk/nashorn/internal/codegen/Compiler.java ! src/jdk/nashorn/internal/codegen/MethodEmitter.java ! src/jdk/nashorn/internal/codegen/ObjectClassGenerator.java ! src/jdk/nashorn/internal/ir/debug/JSONWriter.java ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/objects/NativeDate.java ! src/jdk/nashorn/internal/objects/NativeString.java ! src/jdk/nashorn/internal/objects/ScriptFunctionTrampolineImpl.java ! src/jdk/nashorn/internal/parser/Parser.java ! src/jdk/nashorn/internal/runtime/CodeInstaller.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/JSONFunctions.java - src/jdk/nashorn/internal/runtime/OptionsObject.java + src/jdk/nashorn/internal/runtime/ScriptEnvironment.java ! src/jdk/nashorn/internal/runtime/ScriptRuntime.java ! src/jdk/nashorn/tools/Shell.java ! test/script/trusted/JDK-8006529.js ! test/src/jdk/nashorn/internal/parser/ParserTest.java ! test/src/jdk/nashorn/internal/test/framework/SharedContextEvaluator.java From marcus.lagergren at oracle.com Mon Feb 25 03:37:55 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Mon, 25 Feb 2013 12:37:55 +0100 Subject: Review request JDK-800871 In-Reply-To: <512B26AD.9000703@oracle.com> References: <512B26AD.9000703@oracle.com> Message-ID: <3466828C-7680-45F5-AADE-EFDBBEDF4F47@oracle.com> +1 On Feb 25, 2013, at 9:54 AM, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~sundar/8008731/webrev.01/ > > PS. Please ignore earlier webrev.00 on the same bug > > -Sundar From marcus.lagergren at oracle.com Mon Feb 25 03:38:03 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Mon, 25 Feb 2013 12:38:03 +0100 Subject: Review request JDK-8008789: Enable java access and nashorn runtime tests for jtreg In-Reply-To: <512B2DAA.8010403@oracle.com> References: <512B2DAA.8010403@oracle.com> Message-ID: <9DFD3FA2-2CD3-459F-A863-36A15F74C2F2@oracle.com> +1 On Feb 25, 2013, at 10:23 AM, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~sundar/8008789/ > > Thanks > -Sundar From james.laskey at oracle.com Mon Feb 25 03:38:42 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Mon, 25 Feb 2013 07:38:42 -0400 Subject: Review request JDK-800871 In-Reply-To: <512B26AD.9000703@oracle.com> References: <512B26AD.9000703@oracle.com> Message-ID: <59B1B850-761B-44B1-9F9C-42BF9EF2B664@oracle.com> +1 On 2013-02-25, at 4:54 AM, "A. Sundararajan" wrote: > Please review http://cr.openjdk.java.net/~sundar/8008731/webrev.01/ > > PS. Please ignore earlier webrev.00 on the same bug > > -Sundar From james.laskey at oracle.com Mon Feb 25 03:45:46 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Mon, 25 Feb 2013 07:45:46 -0400 Subject: Review request JDK-8008789: Enable java access and nashorn runtime tests for jtreg In-Reply-To: <512B2DAA.8010403@oracle.com> References: <512B2DAA.8010403@oracle.com> Message-ID: <3CADC326-B9F5-4730-BA9E-AD67FF606E68@oracle.com> +1 On 2013-02-25, at 5:23 AM, "A. Sundararajan" wrote: > Please review http://cr.openjdk.java.net/~sundar/8008789/ > > Thanks > -Sundar From hannes.wallnoefer at oracle.com Mon Feb 25 04:27:57 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Mon, 25 Feb 2013 13:27:57 +0100 Subject: Review request JDK-8008789: Enable java access and nashorn runtime tests for jtreg In-Reply-To: <512B2DAA.8010403@oracle.com> References: <512B2DAA.8010403@oracle.com> Message-ID: <512B58CD.5000106@oracle.com> +1 Hannes Am 2013-02-25 10:23, schrieb A. Sundararajan: > Please review http://cr.openjdk.java.net/~sundar/8008789/ > > Thanks > -Sundar From sundararajan.athijegannathan at oracle.com Mon Feb 25 04:43:54 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Mon, 25 Feb 2013 12:43:54 +0000 Subject: hg: nashorn/jdk8/nashorn: 8008789: Enable java access and nashorn runtime tests for jtreg Message-ID: <20130225124356.A7AC847E22@hg.openjdk.java.net> Changeset: 5610ac25d8ff Author: sundar Date: 2013-02-25 18:13 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/5610ac25d8ff 8008789: Enable java access and nashorn runtime tests for jtreg Reviewed-by: lagergren, jlaskey, hannesw ! make/build.xml ! test/TEST.ROOT ! test/src/jdk/nashorn/api/javaaccess/BooleanAccessTest.java ! test/src/jdk/nashorn/api/javaaccess/MethodAccessTest.java ! test/src/jdk/nashorn/api/javaaccess/NumberAccessTest.java ! test/src/jdk/nashorn/api/javaaccess/NumberBoxingTest.java ! test/src/jdk/nashorn/api/javaaccess/ObjectAccessTest.java ! test/src/jdk/nashorn/api/javaaccess/StringAccessTest.java ! test/src/jdk/nashorn/internal/runtime/ContextTest.java ! test/src/jdk/nashorn/internal/runtime/JSTypeTest.java + test/src/jdk/nashorn/internal/runtime/TrustedScriptEngineTest.java From attila.szegedi at oracle.com Mon Feb 25 01:11:20 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Mon, 25 Feb 2013 10:11:20 +0100 Subject: Please review https://jbs.oracle.com/bugs/browse/JDK-8006984 Message-ID: <88179F9B-0249-4758-BBF5-4D96EDAE6FDC@oracle.com> Please review the attached fix for https://jbs.oracle.com/bugs/browse/JDK-8006984 "introducing local into a function inside with statement confuses its scope" Mailing the patch as the network at my current location prevents webrev from getting to the Mercurial repo. From sundararajan.athijegannathan at oracle.com Mon Feb 25 06:40:45 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Mon, 25 Feb 2013 20:10:45 +0530 Subject: Please review https://jbs.oracle.com/bugs/browse/JDK-8006984 In-Reply-To: <88179F9B-0249-4758-BBF5-4D96EDAE6FDC@oracle.com> References: <88179F9B-0249-4758-BBF5-4D96EDAE6FDC@oracle.com> Message-ID: <512B77ED.1030308@oracle.com> Attachment missing? Or is it in JBS? -Sundar On Monday 25 February 2013 02:41 PM, Attila Szegedi wrote: > Please review the attached fix for https://jbs.oracle.com/bugs/browse/JDK-8006984 "introducing local into a function inside with statement confuses its scope" > > Mailing the patch as the network at my current location prevents webrev from getting to the Mercurial repo. > > From attila.szegedi at oracle.com Mon Feb 25 06:43:51 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Mon, 25 Feb 2013 15:43:51 +0100 Subject: Review request for JDK-8006984 Message-ID: <74B57FA8-FFAD-4774-B698-1B30809D12BF@oracle.com> Please review JDK-8006984 at http://cr.openjdk.java.net/~attila/8006984/webrev.00 Thanks, Attila. From attila.szegedi at oracle.com Mon Feb 25 06:47:21 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Mon, 25 Feb 2013 15:47:21 +0100 Subject: Please review https://jbs.oracle.com/bugs/browse/JDK-8006984 In-Reply-To: <512B77ED.1030308@oracle.com> References: <88179F9B-0249-4758-BBF5-4D96EDAE6FDC@oracle.com> <512B77ED.1030308@oracle.com> Message-ID: <5F48032F-1C07-4432-9296-6530BCD23EA9@oracle.com> Huh? I thought this didn't even go out, the wifi was acting up. Anyway, sent out a new request with an actual webrev now. On Feb 25, 2013, at 3:40 PM, A. Sundararajan wrote: > Attachment missing? Or is it in JBS? > > -Sundar > > On Monday 25 February 2013 02:41 PM, Attila Szegedi wrote: >> Please review the attached fix for https://jbs.oracle.com/bugs/browse/JDK-8006984 "introducing local into a function inside with statement confuses its scope" >> >> Mailing the patch as the network at my current location prevents webrev from getting to the Mercurial repo. >> >> > From attila.szegedi at oracle.com Mon Feb 25 07:36:26 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Mon, 25 Feb 2013 16:36:26 +0100 Subject: Review request for JDK-8006984 In-Reply-To: <74B57FA8-FFAD-4774-B698-1B30809D12BF@oracle.com> References: <74B57FA8-FFAD-4774-B698-1B30809D12BF@oracle.com> Message-ID: Second review request, now with the test: http://cr.openjdk.java.net/~attila/8006984/webrev.01/ On Feb 25, 2013, at 3:43 PM, Attila Szegedi wrote: > Please review JDK-8006984 at http://cr.openjdk.java.net/~attila/8006984/webrev.00 > > Thanks, > Attila. From sundararajan.athijegannathan at oracle.com Mon Feb 25 07:37:58 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Mon, 25 Feb 2013 21:07:58 +0530 Subject: Review request for JDK-8006984 In-Reply-To: References: <74B57FA8-FFAD-4774-B698-1B30809D12BF@oracle.com> Message-ID: <512B8556.1060409@oracle.com> +1 On Monday 25 February 2013 09:06 PM, Attila Szegedi wrote: > Second review request, now with the test: http://cr.openjdk.java.net/~attila/8006984/webrev.01/ > > On Feb 25, 2013, at 3:43 PM, Attila Szegedi wrote: > >> Please review JDK-8006984 at http://cr.openjdk.java.net/~attila/8006984/webrev.00 >> >> Thanks, >> Attila. From marcus.lagergren at oracle.com Mon Feb 25 07:47:22 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Mon, 25 Feb 2013 16:47:22 +0100 Subject: Review request for JDK-8006984 In-Reply-To: References: <74B57FA8-FFAD-4774-B698-1B30809D12BF@oracle.com> Message-ID: <22A7688D-4FA6-470D-B065-CA45E1774444@oracle.com> +1 On Feb 25, 2013, at 4:36 PM, Attila Szegedi wrote: > Second review request, now with the test: http://cr.openjdk.java.net/~attila/8006984/webrev.01/ > > On Feb 25, 2013, at 3:43 PM, Attila Szegedi wrote: > >> Please review JDK-8006984 at http://cr.openjdk.java.net/~attila/8006984/webrev.00 >> >> Thanks, >> Attila. > From james.laskey at oracle.com Mon Feb 25 07:46:12 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Mon, 25 Feb 2013 11:46:12 -0400 Subject: Review request for JDK-8006984 In-Reply-To: References: <74B57FA8-FFAD-4774-B698-1B30809D12BF@oracle.com> Message-ID: <0DD8C408-CDAD-43EF-84FC-248E056A25DB@oracle.com> +1 On 2013-02-25, at 11:36 AM, Attila Szegedi wrote: > Second review request, now with the test: http://cr.openjdk.java.net/~attila/8006984/webrev.01/ > > On Feb 25, 2013, at 3:43 PM, Attila Szegedi wrote: > >> Please review JDK-8006984 at http://cr.openjdk.java.net/~attila/8006984/webrev.00 >> >> Thanks, >> Attila. > From attila.szegedi at oracle.com Mon Feb 25 07:53:22 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Mon, 25 Feb 2013 16:53:22 +0100 Subject: Review request for JDK-8006984 In-Reply-To: References: <74B57FA8-FFAD-4774-B698-1B30809D12BF@oracle.com> Message-ID: <4F8213DC-481C-4B77-BE63-7DCA31B556A5@oracle.com> As an additional, semi-related follow-up, we should disallow accepting FunctionDeclaration as a Statement: On Feb 25, 2013, at 4:36 PM, Attila Szegedi wrote: > Second review request, now with the test: http://cr.openjdk.java.net/~attila/8006984/webrev.01/ > > On Feb 25, 2013, at 3:43 PM, Attila Szegedi wrote: > >> Please review JDK-8006984 at http://cr.openjdk.java.net/~attila/8006984/webrev.00 >> >> Thanks, >> Attila. > From attila.szegedi at oracle.com Mon Feb 25 07:51:37 2013 From: attila.szegedi at oracle.com (attila.szegedi at oracle.com) Date: Mon, 25 Feb 2013 15:51:37 +0000 Subject: hg: nashorn/jdk8/nashorn: 8006984: Introducing local into a function inside with statement confuses its scope Message-ID: <20130225155138.7432247E2F@hg.openjdk.java.net> Changeset: 1654918e0612 Author: attila Date: 2013-02-25 16:51 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/1654918e0612 8006984: Introducing local into a function inside with statement confuses its scope Reviewed-by: jlaskey, lagergren, sundar ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/WithObject.java + test/script/basic/JDK-8006984.js + test/script/basic/JDK-8006984.js.EXPECTED From rieberandreas at gmail.com Mon Feb 25 09:37:09 2013 From: rieberandreas at gmail.com (Andreas Rieber) Date: Mon, 25 Feb 2013 18:37:09 +0100 Subject: Review request for JDK-8006984 In-Reply-To: References: <74B57FA8-FFAD-4774-B698-1B30809D12BF@oracle.com> Message-ID: <512BA145.9080106@gmail.com> Hi Attila, i found that fix and retested. One line more and another one... couldn't break it ;-) Andreas On 25.02.13 16:36, Attila Szegedi wrote: > Second review request, now with the test: http://cr.openjdk.java.net/~attila/8006984/webrev.01/ > > On Feb 25, 2013, at 3:43 PM, Attila Szegedi wrote: > >> Please review JDK-8006984 at http://cr.openjdk.java.net/~attila/8006984/webrev.00 >> >> Thanks, >> Attila. From attila.szegedi at oracle.com Mon Feb 25 09:46:48 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Mon, 25 Feb 2013 18:46:48 +0100 Subject: Review request for JDK-8006984 In-Reply-To: <512BA145.9080106@gmail.com> References: <74B57FA8-FFAD-4774-B698-1B30809D12BF@oracle.com> <512BA145.9080106@gmail.com> Message-ID: <202FABEA-CB24-4465-BA5C-936DCAAEF579@oracle.com> Excellent? On that note, I want to make you aware that we'll soon make Nashorn reject with a syntax error those function declarations that occur within "with" and "catch" blocks; we're shooting for 100% ECMAScript 5.1 compliance, and it disallows function declarations except directly on the top-level of script and in another function's body. In such cases, you'll need to use a function expression instead. So this: var guiPkgs = { JFrame: function() { print("created"); } }; with (guiPkgs) { function main() { // <---- this is not legal in ECMAScript 5.1 var frame; function createFrame() { frame = new JFrame(); } createFrame(); } } main(); will soon stop working. If you want the "main" function and whatever is in it to be affected by the with() block, you'll have to use a function expression instead like this: with (guiPkgs) { var main = function() { // <---- this expresses your actual intent, and is the only valid construct here in ES5.1 var frame; function createFrame() { // <-- this is still okay, as it's defined directly on the function body level of main() frame = new JFrame(); } createFrame(); } } main(); Attila. On Feb 25, 2013, at 6:37 PM, Andreas Rieber wrote: > Hi Attila, > > i found that fix and retested. One line more and another one... couldn't break it ;-) > > Andreas > > On 25.02.13 16:36, Attila Szegedi wrote: >> Second review request, now with the test: http://cr.openjdk.java.net/~attila/8006984/webrev.01/ >> >> On Feb 25, 2013, at 3:43 PM, Attila Szegedi wrote: >> >>> Please review JDK-8006984 at http://cr.openjdk.java.net/~attila/8006984/webrev.00 >>> >>> Thanks, >>> Attila. From marcus.lagergren at oracle.com Mon Feb 25 10:59:34 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Mon, 25 Feb 2013 19:59:34 +0100 Subject: Review request for JDK-8006984 In-Reply-To: <512BA145.9080106@gmail.com> References: <74B57FA8-FFAD-4774-B698-1B30809D12BF@oracle.com> <512BA145.9080106@gmail.com> Message-ID: <949E03DA-2D26-4CB0-9EE0-9B3AB5103913@oracle.com> Andreas, That's good news! Any horror-unit tests that you may have written for this or any other issue can be graciously accepted as contributions. /M On Feb 25, 2013, at 6:37 PM, Andreas Rieber wrote: > Hi Attila, > > i found that fix and retested. One line more and another one... couldn't break it ;-) > > Andreas > > On 25.02.13 16:36, Attila Szegedi wrote: >> Second review request, now with the test: http://cr.openjdk.java.net/~attila/8006984/webrev.01/ >> >> On Feb 25, 2013, at 3:43 PM, Attila Szegedi wrote: >> >>> Please review JDK-8006984 at http://cr.openjdk.java.net/~attila/8006984/webrev.00 >>> >>> Thanks, >>> Attila. From rieberandreas at gmail.com Mon Feb 25 11:03:00 2013 From: rieberandreas at gmail.com (Andreas Rieber) Date: Mon, 25 Feb 2013 20:03:00 +0100 Subject: Review request for JDK-8006984 In-Reply-To: <202FABEA-CB24-4465-BA5C-936DCAAEF579@oracle.com> References: <74B57FA8-FFAD-4774-B698-1B30809D12BF@oracle.com> <512BA145.9080106@gmail.com> <202FABEA-CB24-4465-BA5C-936DCAAEF579@oracle.com> Message-ID: <512BB564.1040007@gmail.com> Hi Attila, i can't read that out of ecma-262 spec but i guess you read that many times more than i did. I try to follow "The Good Pars", which would make all easier. Is there a way to access the issue tracking? I mean it would make my live easier. At the moment i follow every commit and try to get in but i don't see what is open, coming, etc. cheers Andreas PS: if i am not totally wrong - that code was from Sundar. On 25.02.13 18:46, Attila Szegedi wrote: > Excellent? > > On that note, I want to make you aware that we'll soon make Nashorn > reject with a syntax error those function declarations that occur > within "with" and "catch" blocks; we're shooting for 100% ECMAScript > 5.1 compliance, and it disallows function declarations except directly > on the top-level of script and in another function's body. In such > cases, you'll need to use a function expression instead. So this: > > var guiPkgs = { JFrame: function() { print("created"); } }; > > with (guiPkgs) { > function main() { // <---- this is not legal in ECMAScript 5.1 > var frame; > > function createFrame() { > frame = new JFrame(); > } > > createFrame(); > } > } > main(); > > will soon stop working. If you want the "main" function and whatever > is in it to be affected by the with() block, you'll have to use a > function expression instead like this: > > with (guiPkgs) { > var main = function() { // <---- this expresses your actual > intent, and is the only valid construct here in ES5.1 > var frame; > > function createFrame() { // <-- this is still okay, as it's > defined directly on the function body level of main() > frame = new JFrame(); > } > > createFrame(); > } > } > main(); > > Attila. > > On Feb 25, 2013, at 6:37 PM, Andreas Rieber > wrote: > >> Hi Attila, >> >> i found that fix and retested. One line more and another one... >> couldn't break it ;-) >> >> Andreas >> >> On 25.02.13 16:36, Attila Szegedi wrote: >>> Second review request, now with the test: >>> http://cr.openjdk.java.net/~attila/8006984/webrev.01/ >>> >>> >>> On Feb 25, 2013, at 3:43 PM, Attila Szegedi >>> > wrote: >>> >>>> Please review JDK-8006984 at >>>> http://cr.openjdk.java.net/~attila/8006984/webrev.00 >>>> >>>> >>>> Thanks, >>>> Attila. > From attila.szegedi at oracle.com Mon Feb 25 11:18:20 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Mon, 25 Feb 2013 20:18:20 +0100 Subject: Review request for JDK-8006984 In-Reply-To: <512BB564.1040007@gmail.com> References: <74B57FA8-FFAD-4774-B698-1B30809D12BF@oracle.com> <512BA145.9080106@gmail.com> <202FABEA-CB24-4465-BA5C-936DCAAEF579@oracle.com> <512BB564.1040007@gmail.com> Message-ID: <0DCA4C4B-B697-4A21-857D-797CB14CDEC0@oracle.com> If you look at the Program grammar production in Chapter 14, it says: Program : SourceElementsopt SourceElements : SourceElement SourceElements SourceElement SourceElement : Statement FunctionDeclaration As you can see, SourceElement is either a Statement or a FunctionDeclaration -- they're considered two different things, and through their union SourceElement they can both occur as top-level elements in a program. Further, the grammar production FunctionBody in Chapter 13 is: FunctionBody : SourceElementsopt meaning a function body also consists of SourceElements - either Statements or FunctionDeclarations. That are the only contexts in which FunctionDeclaration can occur, it occurs nowhere else in the grammar. Finally, Chapter 12 "Statements" is quite articulate in *not* listing FunctionDeclaration as part of the Statement production: Statement : Block VariableStatement EmptyStatement ExpressionStatement IfStatement IterationStatement ContinueStatement BreakStatement ReturnStatement WithStatement LabelledStatement SwitchStatement ThrowStatement TryStatement DebuggerStatement There is also this non-normative "NOTE" section in Chapter 12 saying "Several widely used implementations of ECMAScript are known to support the use of FunctionDeclaration as a Statement. However there are significant and irreconcilable variations among the implementations in the semantics applied to such FunctionDeclarations. Because of these irreconcilable differences, the use of a FunctionDeclaration as a Statement results in code that is not reliably portable among implementations. ?" The specification writers clearly frowns upon this practice, for quite obvious reasons - function declarations are instantiated upon entry to the program or their parent function, not when the declaration is executed in source code statement order, therefore programmers can have mistaken assumptions about their lexical scope, because such declarations always have the VariableEnvironment of the execution context at script/function entry point as their scope, and not the LexicalEnvironment at the point of their declaration (which is what function expressions get). We hope that by strict adherence to the specification we can steer people towards writing cleaner, more maintainable code in the future; one of goals of the ECMAScript 5.1 specification was eliminating or clarifying a lot of arcane quirks of the language; this purpose would be partially defeated if we just ignored it. HTH, Attila. On Feb 25, 2013, at 8:03 PM, Andreas Rieber wrote: > Hi Attila, > > i can't read that out of ecma-262 spec but i guess you read that many times more than i did. I try to follow "The Good Pars", which would make all easier. > > Is there a way to access the issue tracking? I mean it would make my live easier. At the moment i follow every commit and try to get in but i don't see what is open, coming, etc. > > cheers > Andreas > > PS: if i am not totally wrong - that code was from Sundar. > > > On 25.02.13 18:46, Attila Szegedi wrote: >> Excellent? >> >> On that note, I want to make you aware that we'll soon make Nashorn reject with a syntax error those function declarations that occur within "with" and "catch" blocks; we're shooting for 100% ECMAScript 5.1 compliance, and it disallows function declarations except directly on the top-level of script and in another function's body. In such cases, you'll need to use a function expression instead. So this: >> >> var guiPkgs = { JFrame: function() { print("created"); } }; >> >> with (guiPkgs) { >> function main() { // <---- this is not legal in ECMAScript 5.1 >> var frame; >> >> function createFrame() { >> frame = new JFrame(); >> } >> >> createFrame(); >> } >> } >> main(); >> >> will soon stop working. If you want the "main" function and whatever is in it to be affected by the with() block, you'll have to use a function expression instead like this: >> >> with (guiPkgs) { >> var main = function() { // <---- this expresses your actual intent, and is the only valid construct here in ES5.1 >> var frame; >> >> function createFrame() { // <-- this is still okay, as it's defined directly on the function body level of main() >> frame = new JFrame(); >> } >> >> createFrame(); >> } >> } >> main(); >> >> Attila. >> >> On Feb 25, 2013, at 6:37 PM, Andreas Rieber wrote: >> >>> Hi Attila, >>> >>> i found that fix and retested. One line more and another one... couldn't break it ;-) >>> >>> Andreas >>> >>> On 25.02.13 16:36, Attila Szegedi wrote: >>>> Second review request, now with the test: http://cr.openjdk.java.net/~attila/8006984/webrev.01/ >>>> >>>> On Feb 25, 2013, at 3:43 PM, Attila Szegedi wrote: >>>> >>>>> Please review JDK-8006984 at http://cr.openjdk.java.net/~attila/8006984/webrev.00 >>>>> >>>>> Thanks, >>>>> Attila. >> > From rieberandreas at gmail.com Mon Feb 25 11:19:08 2013 From: rieberandreas at gmail.com (Andreas Rieber) Date: Mon, 25 Feb 2013 20:19:08 +0100 Subject: Review request for JDK-8006984 In-Reply-To: <949E03DA-2D26-4CB0-9EE0-9B3AB5103913@oracle.com> References: <74B57FA8-FFAD-4774-B698-1B30809D12BF@oracle.com> <512BA145.9080106@gmail.com> <949E03DA-2D26-4CB0-9EE0-9B3AB5103913@oracle.com> Message-ID: <512BB92C.4070505@gmail.com> Hi Markus, that's why i changed every line very - very - carefully ;-) I might have another one, but i want to wait for the full nashorn integration into jdk8, not that the configuration i have is causing the troubles. I still try to run rhino in parallel. Andreas On 25.02.13 19:59, Marcus Lagergren wrote: > Andreas, > > That's good news! > > Any horror-unit tests that you may have written for this or any other issue can be graciously accepted as contributions. > > /M > > > On Feb 25, 2013, at 6:37 PM, Andreas Rieber wrote: > >> Hi Attila, >> >> i found that fix and retested. One line more and another one... couldn't break it ;-) >> >> Andreas >> >> On 25.02.13 16:36, Attila Szegedi wrote: >>> Second review request, now with the test: http://cr.openjdk.java.net/~attila/8006984/webrev.01/ >>> >>> On Feb 25, 2013, at 3:43 PM, Attila Szegedi wrote: >>> >>>> Please review JDK-8006984 at http://cr.openjdk.java.net/~attila/8006984/webrev.00 >>>> >>>> Thanks, >>>> Attila. From attila.szegedi at oracle.com Mon Feb 25 11:19:41 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Mon, 25 Feb 2013 20:19:41 +0100 Subject: Review request for JDK-8006984 In-Reply-To: <0DCA4C4B-B697-4A21-857D-797CB14CDEC0@oracle.com> References: <74B57FA8-FFAD-4774-B698-1B30809D12BF@oracle.com> <512BA145.9080106@gmail.com> <202FABEA-CB24-4465-BA5C-936DCAAEF579@oracle.com> <512BB564.1040007@gmail.com> <0DCA4C4B-B697-4A21-857D-797CB14CDEC0@oracle.com> Message-ID: <12CD217E-998C-43D4-92BB-D32D19088747@oracle.com> (Apologies if this came across overly nit-picking and pedantic; I just wanted to make sure that I have a detailed trail of my reasoning out in the open) On Feb 25, 2013, at 8:18 PM, Attila Szegedi wrote: > If you look at the Program grammar production in Chapter 14, it says: > Program : > SourceElementsopt > SourceElements : > SourceElement > SourceElements SourceElement > SourceElement : > Statement > FunctionDeclaration > As you can see, SourceElement is either a Statement or a FunctionDeclaration -- they're considered two different things, and through their union SourceElement they can both occur as top-level elements in a program. > > Further, the grammar production FunctionBody in Chapter 13 is: > FunctionBody : > SourceElementsopt > meaning a function body also consists of SourceElements - either Statements or FunctionDeclarations. That are the only contexts in which FunctionDeclaration can occur, it occurs nowhere else in the grammar. > > Finally, Chapter 12 "Statements" is quite articulate in *not* listing FunctionDeclaration as part of the Statement production: > Statement : > Block > VariableStatement > EmptyStatement > ExpressionStatement > IfStatement > IterationStatement > ContinueStatement > BreakStatement > ReturnStatement > WithStatement > LabelledStatement > SwitchStatement > ThrowStatement > TryStatement > DebuggerStatement > There is also this non-normative "NOTE" section in Chapter 12 saying "Several widely used implementations of ECMAScript are known to support the use of FunctionDeclaration as a Statement. However there are significant and irreconcilable variations among the implementations in the semantics applied to such FunctionDeclarations. Because of these irreconcilable differences, the use of a FunctionDeclaration as a Statement results in code that is not reliably portable among implementations. ?" > > The specification writers clearly frowns upon this practice, for quite obvious reasons - function declarations are instantiated upon entry to the program or their parent function, not when the declaration is executed in source code statement order, therefore programmers can have mistaken assumptions about their lexical scope, because such declarations always have the VariableEnvironment of the execution context at script/function entry point as their scope, and not the LexicalEnvironment at the point of their declaration (which is what function expressions get). > > We hope that by strict adherence to the specification we can steer people towards writing cleaner, more maintainable code in the future; one of goals of the ECMAScript 5.1 specification was eliminating or clarifying a lot of arcane quirks of the language; this purpose would be partially defeated if we just ignored it. > > HTH, > Attila. > > > On Feb 25, 2013, at 8:03 PM, Andreas Rieber wrote: > >> Hi Attila, >> >> i can't read that out of ecma-262 spec but i guess you read that many times more than i did. I try to follow "The Good Pars", which would make all easier. >> >> Is there a way to access the issue tracking? I mean it would make my live easier. At the moment i follow every commit and try to get in but i don't see what is open, coming, etc. >> >> cheers >> Andreas >> >> PS: if i am not totally wrong - that code was from Sundar. >> >> >> On 25.02.13 18:46, Attila Szegedi wrote: >>> Excellent? >>> >>> On that note, I want to make you aware that we'll soon make Nashorn reject with a syntax error those function declarations that occur within "with" and "catch" blocks; we're shooting for 100% ECMAScript 5.1 compliance, and it disallows function declarations except directly on the top-level of script and in another function's body. In such cases, you'll need to use a function expression instead. So this: >>> >>> var guiPkgs = { JFrame: function() { print("created"); } }; >>> >>> with (guiPkgs) { >>> function main() { // <---- this is not legal in ECMAScript 5.1 >>> var frame; >>> >>> function createFrame() { >>> frame = new JFrame(); >>> } >>> >>> createFrame(); >>> } >>> } >>> main(); >>> >>> will soon stop working. If you want the "main" function and whatever is in it to be affected by the with() block, you'll have to use a function expression instead like this: >>> >>> with (guiPkgs) { >>> var main = function() { // <---- this expresses your actual intent, and is the only valid construct here in ES5.1 >>> var frame; >>> >>> function createFrame() { // <-- this is still okay, as it's defined directly on the function body level of main() >>> frame = new JFrame(); >>> } >>> >>> createFrame(); >>> } >>> } >>> main(); >>> >>> Attila. >>> >>> On Feb 25, 2013, at 6:37 PM, Andreas Rieber wrote: >>> >>>> Hi Attila, >>>> >>>> i found that fix and retested. One line more and another one... couldn't break it ;-) >>>> >>>> Andreas >>>> >>>> On 25.02.13 16:36, Attila Szegedi wrote: >>>>> Second review request, now with the test: http://cr.openjdk.java.net/~attila/8006984/webrev.01/ >>>>> >>>>> On Feb 25, 2013, at 3:43 PM, Attila Szegedi wrote: >>>>> >>>>>> Please review JDK-8006984 at http://cr.openjdk.java.net/~attila/8006984/webrev.00 >>>>>> >>>>>> Thanks, >>>>>> Attila. >>> >> > From rieberandreas at gmail.com Mon Feb 25 12:00:39 2013 From: rieberandreas at gmail.com (Andreas Rieber) Date: Mon, 25 Feb 2013 21:00:39 +0100 Subject: Review request for JDK-8006984 In-Reply-To: <12CD217E-998C-43D4-92BB-D32D19088747@oracle.com> References: <74B57FA8-FFAD-4774-B698-1B30809D12BF@oracle.com> <512BA145.9080106@gmail.com> <202FABEA-CB24-4465-BA5C-936DCAAEF579@oracle.com> <512BB564.1040007@gmail.com> <0DCA4C4B-B697-4A21-857D-797CB14CDEC0@oracle.com> <12CD217E-998C-43D4-92BB-D32D19088747@oracle.com> Message-ID: <512BC2E7.6000904@gmail.com> absolutely correct, and easy to oversee! On 25.02.13 20:19, Attila Szegedi wrote: > (Apologies if this came across overly nit-picking and pedantic; I just > wanted to make sure that I have a detailed trail of my reasoning out > in the open) > > On Feb 25, 2013, at 8:18 PM, Attila Szegedi > wrote: > >> If you look at the Program grammar production in Chapter 14, it says: >> >> /Program /*:* >> >> /SourceElements/_opt >> >> /SourceElements /*:* >> >> /SourceElement >> SourceElements SourceElement/ >> >> /SourceElement /*:* >> >> /Statement >> FunctionDeclaration / >> As you can see, SourceElement is either a Statement or a >> FunctionDeclaration -- they're considered two different things, and >> through their union SourceElement they can both occur as top-level >> elements in a program. >> >> Further, the grammar production FunctionBody in Chapter 13 is: >> >> /FunctionBody /*:* >> >> /SourceElements /_opt >> meaning a function body also consists of SourceElements - either >> Statements or FunctionDeclarations. That are the only contexts in >> which FunctionDeclaration can occur, it occurs nowhere else in the >> grammar. >> >> Finally, Chapter 12 "Statements" is quite articulate in *not* listing >> FunctionDeclaration as part of the Statement production: >> >> /Statement /*:* >> >> /Block >> VariableStatement >> EmptyStatement >> ExpressionStatement >> IfStatement >> IterationStatement >> ContinueStatement >> BreakStatement >> ReturnStatement >> WithStatement >> LabelledStatement >> SwitchStatement >> ThrowStatement >> TryStatement >> DebuggerStatement/ >> There is also this non-normative "NOTE" section in Chapter 12 saying >> "Several widely used implementations of ECMAScript are known to >> support the use of FunctionDeclaration as a Statement. However there >> are significant and irreconcilable variations among the >> implementations in the semantics applied to such >> FunctionDeclarations. Because of these irreconcilable differences, >> the use of a FunctionDeclaration as a Statement results in code that >> is not reliably portable among implementations. ?" >> >> The specification writers clearly frowns upon this practice, for >> quite obvious reasons - function declarations are instantiated upon >> entry to the program or their parent function, not when the >> declaration is executed in source code statement order, therefore >> programmers can have mistaken assumptions about their lexical scope, >> because such declarations always have the VariableEnvironment of the >> execution context at script/function entry point as their scope, and >> not the LexicalEnvironment at the point of their declaration (which >> is what function expressions get). >> >> We hope that by strict adherence to the specification we can steer >> people towards writing cleaner, more maintainable code in the future; >> one of goals of the ECMAScript 5.1 specification was eliminating or >> clarifying a lot of arcane quirks of the language; this purpose would >> be partially defeated if we just ignored it. >> >> HTH, >> Attila. >> >> >> On Feb 25, 2013, at 8:03 PM, Andreas Rieber > > wrote: >> >>> Hi Attila, >>> >>> i can't read that out of ecma-262 spec but i guess you read that >>> many times more than i did. I try to follow "The Good Pars", which >>> would make all easier. >>> >>> Is there a way to access the issue tracking? I mean it would make my >>> live easier. At the moment i follow every commit and try to get in >>> but i don't see what is open, coming, etc. >>> >>> cheers >>> Andreas >>> >>> PS: if i am not totally wrong - that code was from Sundar. >>> >>> >>> On 25.02.13 18:46, Attila Szegedi wrote: >>>> Excellent? >>>> >>>> On that note, I want to make you aware that we'll soon make Nashorn >>>> reject with a syntax error those function declarations that occur >>>> within "with" and "catch" blocks; we're shooting for 100% >>>> ECMAScript 5.1 compliance, and it disallows function declarations >>>> except directly on the top-level of script and in another >>>> function's body. In such cases, you'll need to use a function >>>> expression instead. So this: >>>> >>>> var guiPkgs = { JFrame: function() { print("created"); } }; >>>> >>>> with (guiPkgs) { >>>> function main() { // <---- this is not legal in ECMAScript 5.1 >>>> var frame; >>>> >>>> function createFrame() { >>>> frame = new JFrame(); >>>> } >>>> >>>> createFrame(); >>>> } >>>> } >>>> main(); >>>> >>>> will soon stop working. If you want the "main" function and >>>> whatever is in it to be affected by the with() block, you'll have >>>> to use a function expression instead like this: >>>> >>>> with (guiPkgs) { >>>> var main = function() { // <---- this expresses your actual >>>> intent, and is the only valid construct here in ES5.1 >>>> var frame; >>>> >>>> function createFrame() { // <-- this is still okay, as it's defined >>>> directly on the function body level of main() >>>> frame = new JFrame(); >>>> } >>>> >>>> createFrame(); >>>> } >>>> } >>>> main(); >>>> >>>> Attila. >>>> >>>> On Feb 25, 2013, at 6:37 PM, Andreas Rieber >>>> > wrote: >>>> >>>>> Hi Attila, >>>>> >>>>> i found that fix and retested. One line more and another one... >>>>> couldn't break it ;-) >>>>> >>>>> Andreas >>>>> >>>>> On 25.02.13 16:36, Attila Szegedi wrote: >>>>>> Second review request, now with the test: >>>>>> http://cr.openjdk.java.net/~attila/8006984/webrev.01/ >>>>>> >>>>>> >>>>>> On Feb 25, 2013, at 3:43 PM, Attila Szegedi >>>>>> > wrote: >>>>>> >>>>>>> Please review JDK-8006984 at >>>>>>> http://cr.openjdk.java.net/~attila/8006984/webrev.00 >>>>>>> >>>>>>> >>>>>>> Thanks, >>>>>>> Attila. >>>> From sundararajan.athijegannathan at oracle.com Mon Feb 25 19:08:10 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Tue, 26 Feb 2013 08:38:10 +0530 Subject: Review request for JDK-8006984 In-Reply-To: <512BB564.1040007@gmail.com> References: <74B57FA8-FFAD-4774-B698-1B30809D12BF@oracle.com> <512BA145.9080106@gmail.com> <202FABEA-CB24-4465-BA5C-936DCAAEF579@oracle.com> <512BB564.1040007@gmail.com> Message-ID: <512C271A.8050403@oracle.com> Hi Andreas, Yep, I wrote that "scriptpad" sample - as a demo for embedded Rhino in jdk6/7. Yes, when nashorn is changed to fix as per spec, I/we need to fix that sample to work on nashorn as well. Function-declaration-to-expression fix needs to be done on this sample as well as other such script, if any, in jdk code/samples/docs. -Sundar On Tuesday 26 February 2013 12:33 AM, Andreas Rieber wrote: > Hi Attila, > > i can't read that out of ecma-262 spec but i guess you read that many > times more than i did. I try to follow "The Good Pars", which would > make all easier. > > Is there a way to access the issue tracking? I mean it would make my > live easier. At the moment i follow every commit and try to get in but > i don't see what is open, coming, etc. > > cheers > Andreas > > PS: if i am not totally wrong - that code was from Sundar. > > > On 25.02.13 18:46, Attila Szegedi wrote: >> Excellent? >> >> On that note, I want to make you aware that we'll soon make Nashorn >> reject with a syntax error those function declarations that occur >> within "with" and "catch" blocks; we're shooting for 100% ECMAScript >> 5.1 compliance, and it disallows function declarations except >> directly on the top-level of script and in another function's body. >> In such cases, you'll need to use a function expression instead. So >> this: >> >> var guiPkgs = { JFrame: function() { print("created"); } }; >> >> with (guiPkgs) { >> function main() { // <---- this is not legal in ECMAScript 5.1 >> var frame; >> >> function createFrame() { >> frame = new JFrame(); >> } >> >> createFrame(); >> } >> } >> main(); >> >> will soon stop working. If you want the "main" function and whatever >> is in it to be affected by the with() block, you'll have to use a >> function expression instead like this: >> >> with (guiPkgs) { >> var main = function() { // <---- this expresses your actual >> intent, and is the only valid construct here in ES5.1 >> var frame; >> >> function createFrame() { // <-- this is still okay, as it's >> defined directly on the function body level of main() >> frame = new JFrame(); >> } >> >> createFrame(); >> } >> } >> main(); >> >> Attila. >> >> On Feb 25, 2013, at 6:37 PM, Andreas Rieber > > wrote: >> >>> Hi Attila, >>> >>> i found that fix and retested. One line more and another one... >>> couldn't break it ;-) >>> >>> Andreas >>> >>> On 25.02.13 16:36, Attila Szegedi wrote: >>>> Second review request, now with the test: >>>> http://cr.openjdk.java.net/~attila/8006984/webrev.01/ >>>> >>>> >>>> On Feb 25, 2013, at 3:43 PM, Attila Szegedi >>>> > wrote: >>>> >>>>> Please review JDK-8006984 at >>>>> http://cr.openjdk.java.net/~attila/8006984/webrev.00 >>>>> >>>>> >>>>> Thanks, >>>>> Attila. >> > From ninghua at linux.vnet.ibm.com Mon Feb 25 23:52:52 2013 From: ninghua at linux.vnet.ibm.com (RichardNing) Date: Tue, 26 Feb 2013 15:52:52 +0800 Subject: build failure Message-ID: <512C69D4.8010307@linux.vnet.ibm.com> While I build Nashorn, the failure happened. Does anyone know the reason? Thanks. shelldoc: BUILD FAILED C:\repos\nashorn\make\build.xml:160: Java returned: 1 From luchsh at linux.vnet.ibm.com Tue Feb 26 06:32:21 2013 From: luchsh at linux.vnet.ibm.com (Jonathan Lu) Date: Tue, 26 Feb 2013 22:32:21 +0800 Subject: build failure Message-ID: <512CC775.4020400@linux.vnet.ibm.com> Hello Richard, I've got similar problems, to be more specific, I was playing with the code from http://hg.openjdk.java.net/nashorn/jdk8/nashorn on a Windows 7, 32bit box and following the instructions from the README file. OpenJDK 1.8.0-b77 downloaded from official snapshot website was used as bootstrap JDK, the build process will stop on the "javadoc" target of nashorn/make/build.xml with a lot of errors, most of which are about parsing javadocs (of course). like [javadoc] D:\nashorn8\nashorn\src\jdk\nashorn\internal\codegen\ClassEmitter.java:80: error: tag not allowed here:

[javadoc] *

[javadoc] ^ [javadoc] D:\nashorn8\nashorn\src\jdk\nashorn\internal\codegen\ClassEmitter.java:84: error: tag not allowed here:

[javadoc] *

[javadoc] ^ [javadoc] D:\nashorn8\nashorn\src\jdk\nashorn\internal\codegen\ClassEmitter.java:91: error: tag not allowed here:

[javadoc] *

[javadoc] ^ [javadoc] D:\nashorn8\nashorn\src\jdk\nashorn\internal\codegen\ClassEmitter.java:95: error: tag not allowed here:

[javadoc] *

[javadoc] ^ One simple workaround I have to use is to set useexternalfile="yes" for javadoc ANT task, otherwise there'll be a error reporting too long filename, see the diff below: diff -r 1654918e0612 make/build.xml --- a/make/build.xml Mon Feb 25 16:51:04 2013 +0100 +++ b/make/build.xml Tue Feb 26 22:24:01 2013 +0800 @@ -141,7 +141,7 @@ - + The actual problem is that OpenJDK8-b73 would make the build pass, but OpenJDK8-b77 failed. So I was guessing some recent introduced changes lead to this problem. Will continue to look into it and update this thread once got any progress, if anybody has got a clue about the recommended bootstrap JDK or experiences of building on Windows platform, it would be very helpful and welcome. Thanks a lot and best regards - Jonathan > While I build Nashorn, the failure happened. Does anyone know the > reason? Thanks. > > shelldoc: > > BUILD FAILED > C:\repos\nashorn\make\build.xml:160: Java returned: 1 > From rieberandreas at gmail.com Tue Feb 26 07:47:27 2013 From: rieberandreas at gmail.com (Andreas Rieber) Date: Tue, 26 Feb 2013 16:47:27 +0100 Subject: Review request for JDK-8006984 In-Reply-To: <512C271A.8050403@oracle.com> References: <74B57FA8-FFAD-4774-B698-1B30809D12BF@oracle.com> <512BA145.9080106@gmail.com> <202FABEA-CB24-4465-BA5C-936DCAAEF579@oracle.com> <512BB564.1040007@gmail.com> <512C271A.8050403@oracle.com> Message-ID: <512CD90F.1030406@gmail.com> Hm, i would like to get that scriptpad sample working but what should i say... The next scope problem is here: var guiPkgs = new JavaImporter(javax.swing); with (guiPkgs) { var main = function() { var frame; function createFrame() { frame = new JFrame(); } createFrame(); print("created"); }; } main(); I checked out all again, recompiled, this time a clean jdk8/tl without any rhino or other hack. This sample fails with jjs and jrunscript: /usr/local/src/jdk8tl/build/linux-x86-normal-server-release/images/j2sdk-image/bin/jjs scriptpad.js scriptpad.js:9 ReferenceError: "JFrame" is not defined - Andreas On 26.02.13 04:08, A. Sundararajan wrote: > Hi Andreas, > > Yep, I wrote that "scriptpad" sample - as a demo for embedded Rhino in > jdk6/7. Yes, when nashorn is changed to fix as per spec, I/we need to > fix that sample to work on nashorn as well. > > Function-declaration-to-expression fix needs to be done on this sample > as well as other such script, if any, in jdk code/samples/docs. > > -Sundar > > On Tuesday 26 February 2013 12:33 AM, Andreas Rieber wrote: >> Hi Attila, >> >> i can't read that out of ecma-262 spec but i guess you read that many >> times more than i did. I try to follow "The Good Pars", which would >> make all easier. >> >> Is there a way to access the issue tracking? I mean it would make my >> live easier. At the moment i follow every commit and try to get in >> but i don't see what is open, coming, etc. >> >> cheers >> Andreas >> >> PS: if i am not totally wrong - that code was from Sundar. >> >> >> On 25.02.13 18:46, Attila Szegedi wrote: >>> Excellent? >>> >>> On that note, I want to make you aware that we'll soon make Nashorn >>> reject with a syntax error those function declarations that occur >>> within "with" and "catch" blocks; we're shooting for 100% ECMAScript >>> 5.1 compliance, and it disallows function declarations except >>> directly on the top-level of script and in another function's body. >>> In such cases, you'll need to use a function expression instead. So >>> this: >>> >>> var guiPkgs = { JFrame: function() { print("created"); } }; >>> >>> with (guiPkgs) { >>> function main() { // <---- this is not legal in ECMAScript 5.1 >>> var frame; >>> >>> function createFrame() { >>> frame = new JFrame(); >>> } >>> >>> createFrame(); >>> } >>> } >>> main(); >>> >>> will soon stop working. If you want the "main" function and whatever >>> is in it to be affected by the with() block, you'll have to use a >>> function expression instead like this: >>> >>> with (guiPkgs) { >>> var main = function() { // <---- this expresses your actual >>> intent, and is the only valid construct here in ES5.1 >>> var frame; >>> >>> function createFrame() { // <-- this is still okay, as it's >>> defined directly on the function body level of main() >>> frame = new JFrame(); >>> } >>> >>> createFrame(); >>> } >>> } >>> main(); >>> >>> Attila. >>> >>> On Feb 25, 2013, at 6:37 PM, Andreas Rieber >> > wrote: >>> >>>> Hi Attila, >>>> >>>> i found that fix and retested. One line more and another one... >>>> couldn't break it ;-) >>>> >>>> Andreas >>>> >>>> On 25.02.13 16:36, Attila Szegedi wrote: >>>>> Second review request, now with the test: >>>>> http://cr.openjdk.java.net/~attila/8006984/webrev.01/ >>>>> >>>>> >>>>> On Feb 25, 2013, at 3:43 PM, Attila Szegedi >>>>> > wrote: >>>>> >>>>>> Please review JDK-8006984 at >>>>>> http://cr.openjdk.java.net/~attila/8006984/webrev.00 >>>>>> >>>>>> >>>>>> Thanks, >>>>>> Attila. From rieberandreas at gmail.com Tue Feb 26 08:18:11 2013 From: rieberandreas at gmail.com (Andreas Rieber) Date: Tue, 26 Feb 2013 17:18:11 +0100 Subject: Review request for JDK-8006984 In-Reply-To: <512CD90F.1030406@gmail.com> References: <74B57FA8-FFAD-4774-B698-1B30809D12BF@oracle.com> <512BA145.9080106@gmail.com> <202FABEA-CB24-4465-BA5C-936DCAAEF579@oracle.com> <512BB564.1040007@gmail.com> <512C271A.8050403@oracle.com> <512CD90F.1030406@gmail.com> Message-ID: <512CE043.2020708@gmail.com> this time it could be something with the importer as that test fails: [testng] test/script/basic/importpackage.js:38 TypeError: Cannot call undefined [testng] test/script/basic/importpackage.js:38 TypeError: Cannot call undefined [testng] at jdk.nashorn.internal.runtime.ECMAErrors.error(Unknown Source) [testng] at jdk.nashorn.internal.runtime.ECMAErrors.typeError(Unknown Source) [testng] at jdk.nashorn.internal.runtime.ECMAErrors.typeError(Unknown Source) [testng] at jdk.nashorn.internal.runtime.ECMAErrors.typeError(Unknown Source) [testng] at jdk.nashorn.internal.runtime.Undefined.lookupTypeError(Unknown Source) [testng] at jdk.nashorn.internal.runtime.Undefined.lookup(Unknown Source) [testng] at jdk.nashorn.internal.runtime.linker.NashornLinker.getGuardedInvocation(Unknown Source) [testng] at jdk.internal.dynalink.support.CompositeTypeBasedGuardingDynamicLinker.getGuardedInvocation(Unknown Source) [testng] at jdk.internal.dynalink.support.CompositeGuardingDynamicLinker.getGuardedInvocation(Unknown Source) [testng] at jdk.internal.dynalink.support.LinkerServicesImpl.getGuardedInvocation(Unknown Source) [testng] at jdk.internal.dynalink.DynamicLinker.relink(Unknown Source) [testng] at jdk.nashorn.internal.scripts.Script$importpackage.runScript(test/script/basic/importpackage.js:38) [testng] at jdk.nashorn.internal.runtime.ScriptFunctionData.invoke(Unknown Source) [testng] at jdk.nashorn.internal.runtime.ScriptFunction.invoke(Unknown Source) [testng] at jdk.nashorn.internal.runtime.ScriptRuntime.apply(Unknown Source) [testng] at jdk.nashorn.tools.Shell.apply(Unknown Source) [testng] at jdk.nashorn.tools.Shell.runScripts(Unknown Source) [testng] at jdk.nashorn.tools.Shell.run(Unknown Source) [testng] at jdk.nashorn.tools.Shell.main(Unknown Source) ... On 26.02.13 16:47, Andreas Rieber wrote: > Hm, i would like to get that scriptpad sample working but what should > i say... The next scope problem is here: > > var guiPkgs = new JavaImporter(javax.swing); > > with (guiPkgs) { > var main = function() { > var frame; > > function createFrame() { > frame = new JFrame(); > } > > createFrame(); > print("created"); > }; > } > > main(); > > I checked out all again, recompiled, this time a clean jdk8/tl without > any rhino or other hack. This sample fails with jjs and jrunscript: > > /usr/local/src/jdk8tl/build/linux-x86-normal-server-release/images/j2sdk-image/bin/jjs > scriptpad.js > scriptpad.js:9 ReferenceError: "JFrame" is not defined > > - Andreas > > On 26.02.13 04:08, A. Sundararajan wrote: >> Hi Andreas, >> >> Yep, I wrote that "scriptpad" sample - as a demo for embedded Rhino >> in jdk6/7. Yes, when nashorn is changed to fix as per spec, I/we need >> to fix that sample to work on nashorn as well. >> >> Function-declaration-to-expression fix needs to be done on this >> sample as well as other such script, if any, in jdk code/samples/docs. >> >> -Sundar >> >> On Tuesday 26 February 2013 12:33 AM, Andreas Rieber wrote: >>> Hi Attila, >>> >>> i can't read that out of ecma-262 spec but i guess you read that >>> many times more than i did. I try to follow "The Good Pars", which >>> would make all easier. >>> >>> Is there a way to access the issue tracking? I mean it would make my >>> live easier. At the moment i follow every commit and try to get in >>> but i don't see what is open, coming, etc. >>> >>> cheers >>> Andreas >>> >>> PS: if i am not totally wrong - that code was from Sundar. >>> >>> >>> On 25.02.13 18:46, Attila Szegedi wrote: >>>> Excellent? >>>> >>>> On that note, I want to make you aware that we'll soon make Nashorn >>>> reject with a syntax error those function declarations that occur >>>> within "with" and "catch" blocks; we're shooting for 100% >>>> ECMAScript 5.1 compliance, and it disallows function declarations >>>> except directly on the top-level of script and in another >>>> function's body. In such cases, you'll need to use a function >>>> expression instead. So this: >>>> >>>> var guiPkgs = { JFrame: function() { print("created"); } }; >>>> >>>> with (guiPkgs) { >>>> function main() { // <---- this is not legal in ECMAScript 5.1 >>>> var frame; >>>> >>>> function createFrame() { >>>> frame = new JFrame(); >>>> } >>>> >>>> createFrame(); >>>> } >>>> } >>>> main(); >>>> >>>> will soon stop working. If you want the "main" function and >>>> whatever is in it to be affected by the with() block, you'll have >>>> to use a function expression instead like this: >>>> >>>> with (guiPkgs) { >>>> var main = function() { // <---- this expresses your actual >>>> intent, and is the only valid construct here in ES5.1 >>>> var frame; >>>> >>>> function createFrame() { // <-- this is still okay, as it's >>>> defined directly on the function body level of main() >>>> frame = new JFrame(); >>>> } >>>> >>>> createFrame(); >>>> } >>>> } >>>> main(); >>>> >>>> Attila. >>>> >>>> On Feb 25, 2013, at 6:37 PM, Andreas Rieber >>>> > wrote: >>>> >>>>> Hi Attila, >>>>> >>>>> i found that fix and retested. One line more and another one... >>>>> couldn't break it ;-) >>>>> >>>>> Andreas >>>>> >>>>> On 25.02.13 16:36, Attila Szegedi wrote: >>>>>> Second review request, now with the test: >>>>>> http://cr.openjdk.java.net/~attila/8006984/webrev.01/ >>>>>> >>>>>> >>>>>> On Feb 25, 2013, at 3:43 PM, Attila Szegedi >>>>>> > >>>>>> wrote: >>>>>> >>>>>>> Please review JDK-8006984 at >>>>>>> http://cr.openjdk.java.net/~attila/8006984/webrev.00 >>>>>>> >>>>>>> >>>>>>> Thanks, >>>>>>> Attila. From sundararajan.athijegannathan at oracle.com Tue Feb 26 09:28:33 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Tue, 26 Feb 2013 17:28:33 +0000 Subject: hg: nashorn/jdk8/nashorn: 8009021: nasgen should be run on boot jdk rather than currenly built jdk Message-ID: <20130226172834.EDCB44741F@hg.openjdk.java.net> Changeset: a90094ae5be3 Author: sundar Date: 2013-02-26 22:57 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/a90094ae5be3 8009021: nasgen should be run on boot jdk rather than currenly built jdk Reviewed-by: jlaskey ! makefiles/BuildNashorn.gmk From sundararajan.athijegannathan at oracle.com Tue Feb 26 22:14:09 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Wed, 27 Feb 2013 11:44:09 +0530 Subject: Review request JDK-8009115: jtreg tests under jdk/test/javax/script should use nashorn as script engine Message-ID: <512DA431.5030408@oracle.com> Please review http://cr.openjdk.java.net/~sundar/8009115/ README has details on changes: http://cr.openjdk.java.net/~sundar/8009115/README -Sundar From marcus.lagergren at oracle.com Wed Feb 27 01:29:16 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Wed, 27 Feb 2013 10:29:16 +0100 Subject: Review request JDK-8009115: jtreg tests under jdk/test/javax/script should use nashorn as script engine In-Reply-To: <512DA431.5030408@oracle.com> References: <512DA431.5030408@oracle.com> Message-ID: +1 On Feb 27, 2013, at 7:14 AM, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~sundar/8009115/ > > README has details on changes: http://cr.openjdk.java.net/~sundar/8009115/README > > -Sundar From hannes.wallnoefer at oracle.com Wed Feb 27 01:51:32 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Wed, 27 Feb 2013 10:51:32 +0100 Subject: Review request JDK-8009115: jtreg tests under jdk/test/javax/script should use nashorn as script engine In-Reply-To: <512DA431.5030408@oracle.com> References: <512DA431.5030408@oracle.com> Message-ID: <512DD724.1010608@oracle.com> Looks good to me. I'm wondering if we shouldn't leave the engine name as "js" in the tests though, as part of their purpose seems to test the standard JS engine? Hannes Am 2013-02-27 07:14, schrieb A. Sundararajan: > Please review http://cr.openjdk.java.net/~sundar/8009115/ > > README has details on changes: > http://cr.openjdk.java.net/~sundar/8009115/README > > -Sundar From sundararajan.athijegannathan at oracle.com Wed Feb 27 02:48:25 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Wed, 27 Feb 2013 16:18:25 +0530 Subject: Review request JDK-8009115: jtreg tests under jdk/test/javax/script should use nashorn as script engine In-Reply-To: <512DD724.1010608@oracle.com> References: <512DA431.5030408@oracle.com> <512DD724.1010608@oracle.com> Message-ID: <512DE479.8030204@oracle.com> Well, the tests do assume things about the underlying engine - such as engine version, language version, language extensions like java support and so on. (like importPackage). We used to depend on rhino engine - I made nashorn dependency and used explicit dependency to use other js engines. -Sundar On Wednesday 27 February 2013 03:21 PM, Hannes Wallnoefer wrote: > Looks good to me. > > I'm wondering if we shouldn't leave the engine name as "js" in the > tests though, as part of their purpose seems to test the standard JS > engine? > > Hannes > > Am 2013-02-27 07:14, schrieb A. Sundararajan: >> Please review http://cr.openjdk.java.net/~sundar/8009115/ >> >> README has details on changes: >> http://cr.openjdk.java.net/~sundar/8009115/README >> >> -Sundar > From rieberandreas at gmail.com Wed Feb 27 03:10:24 2013 From: rieberandreas at gmail.com (Andreas Rieber) Date: Wed, 27 Feb 2013 12:10:24 +0100 Subject: Review request JDK-8009115: jtreg tests under jdk/test/javax/script should use nashorn as script engine In-Reply-To: <512DE479.8030204@oracle.com> References: <512DA431.5030408@oracle.com> <512DD724.1010608@oracle.com> <512DE479.8030204@oracle.com> Message-ID: <512DE9A0.7020808@gmail.com> Hi Sundar, i had the same thought like Hannes. It would be more 'compatible' when it comes to jsr223 adding print, println and the load mozilla_compat.js in the engine.js file. This does not affect standalone Nashorn. Just an idea... Andreas diff -r a90094ae5be3 src/jdk/nashorn/api/scripting/resources/engine.js --- a/src/jdk/nashorn/api/scripting/resources/engine.js Tue Feb 26 22:57:51 2013 +0530 +++ b/src/jdk/nashorn/api/scripting/resources/engine.js Wed Feb 27 12:01:36 2013 +0100 @@ -39,10 +39,22 @@ } }); -function print(str) { - var writer = context.getWriter(); - if (! (writer instanceof java.io.PrintWriter)) { - writer = new java.io.PrintWriter(writer); +function print(str, newline) { + if (typeof(str) == 'undefined') { + str = 'undefined'; + } else if (str == null) { + str = 'null'; } - writer.println(String(str)); + var out = context.getWriter(); + if (!(out instanceof java.io.PrintWriter)) + out = new java.io.PrintWriter(out); + out.print(String(str)); + if (newline) out.print("\n"); + out.flush(); } + +function println(str) { + print(str, true); +} + +load("nashorn:mozilla_compat.js"); On 27.02.13 11:48, A. Sundararajan wrote: > Well, the tests do assume things about the underlying engine - such as > engine version, language version, language extensions like java > support and so on. (like importPackage). We used to depend on rhino > engine - I made nashorn dependency and used explicit dependency to use > other js engines. > > -Sundar > > On Wednesday 27 February 2013 03:21 PM, Hannes Wallnoefer wrote: >> Looks good to me. >> >> I'm wondering if we shouldn't leave the engine name as "js" in the >> tests though, as part of their purpose seems to test the standard JS >> engine? >> >> Hannes >> >> Am 2013-02-27 07:14, schrieb A. Sundararajan: >>> Please review http://cr.openjdk.java.net/~sundar/8009115/ >>> >>> README has details on changes: >>> http://cr.openjdk.java.net/~sundar/8009115/README >>> >>> -Sundar From sundararajan.athijegannathan at oracle.com Wed Feb 27 03:16:21 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Wed, 27 Feb 2013 16:46:21 +0530 Subject: Review request JDK-8009115: jtreg tests under jdk/test/javax/script should use nashorn as script engine In-Reply-To: <512DE9A0.7020808@gmail.com> References: <512DA431.5030408@oracle.com> <512DD724.1010608@oracle.com> <512DE479.8030204@oracle.com> <512DE9A0.7020808@gmail.com> Message-ID: <512DEB05.8060707@oracle.com> Hi Andreas, The issue is that user script can't be used "as is" between jjs, jrunscript, nodejar. i.e., user script has to use print or println based on which tool runs the script and load mozilla_compat.js conditionally (although loading again won't harm in this case) and so on. Not sure if that is desirable. I'll discuss and then file a bug. Thanks -Sundar On Wednesday 27 February 2013 04:40 PM, Andreas Rieber wrote: > Hi Sundar, > > i had the same thought like Hannes. It would be more 'compatible' when > it comes to jsr223 adding print, println and the load > mozilla_compat.js in the engine.js file. This does not affect > standalone Nashorn. Just an idea... > > Andreas > > diff -r a90094ae5be3 src/jdk/nashorn/api/scripting/resources/engine.js > --- a/src/jdk/nashorn/api/scripting/resources/engine.js Tue Feb 26 > 22:57:51 2013 +0530 > +++ b/src/jdk/nashorn/api/scripting/resources/engine.js Wed Feb 27 > 12:01:36 2013 +0100 > @@ -39,10 +39,22 @@ > } > }); > > -function print(str) { > - var writer = context.getWriter(); > - if (! (writer instanceof java.io.PrintWriter)) { > - writer = new java.io.PrintWriter(writer); > +function print(str, newline) { > + if (typeof(str) == 'undefined') { > + str = 'undefined'; > + } else if (str == null) { > + str = 'null'; > } > - writer.println(String(str)); > + var out = context.getWriter(); > + if (!(out instanceof java.io.PrintWriter)) > + out = new java.io.PrintWriter(out); > + out.print(String(str)); > + if (newline) out.print("\n"); > + out.flush(); > } > + > +function println(str) { > + print(str, true); > +} > + > +load("nashorn:mozilla_compat.js"); > > > > On 27.02.13 11:48, A. Sundararajan wrote: >> Well, the tests do assume things about the underlying engine - such >> as engine version, language version, language extensions like java >> support and so on. (like importPackage). We used to depend on rhino >> engine - I made nashorn dependency and used explicit dependency to >> use other js engines. >> >> -Sundar >> >> On Wednesday 27 February 2013 03:21 PM, Hannes Wallnoefer wrote: >>> Looks good to me. >>> >>> I'm wondering if we shouldn't leave the engine name as "js" in the >>> tests though, as part of their purpose seems to test the standard JS >>> engine? >>> >>> Hannes >>> >>> Am 2013-02-27 07:14, schrieb A. Sundararajan: >>>> Please review http://cr.openjdk.java.net/~sundar/8009115/ >>>> >>>> README has details on changes: >>>> http://cr.openjdk.java.net/~sundar/8009115/README >>>> >>>> -Sundar From attila.szegedi at oracle.com Wed Feb 27 06:14:17 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Wed, 27 Feb 2013 15:14:17 +0100 Subject: Review request for JDK-8009143 Message-ID: Please review JDK-8009143 at http://cr.openjdk.java.net/~attila/8009143/webrev.00 Thanks, Attila. From sundararajan.athijegannathan at oracle.com Wed Feb 27 06:14:45 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Wed, 27 Feb 2013 19:44:45 +0530 Subject: Please review 8009140: jtreg tests under sun/tools/jrunscript should use nashorn engine Message-ID: <512E14D5.4040102@oracle.com> Hi, Please review http://cr.openjdk.java.net/~sundar/8009140/ Thanks -Sundar From attila.szegedi at oracle.com Wed Feb 27 06:22:22 2013 From: attila.szegedi at oracle.com (attila.szegedi at oracle.com) Date: Wed, 27 Feb 2013 14:22:22 +0000 Subject: hg: nashorn/jdk8/nashorn: 8009143: Eliminate Dynalink dependency on java.beans Message-ID: <20130227142223.B396747464@hg.openjdk.java.net> Changeset: 071e859b371e Author: attila Date: 2013-02-27 15:20 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/071e859b371e 8009143: Eliminate Dynalink dependency on java.beans Reviewed-by: jlaskey, lagergren, sundar ! src/jdk/internal/dynalink/beans/AbstractJavaLinker.java ! src/jdk/internal/dynalink/beans/BeansLinker.java From attila.szegedi at oracle.com Wed Feb 27 06:44:53 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Wed, 27 Feb 2013 15:44:53 +0100 Subject: Review request for JDK-8009146 Message-ID: <0EE4FABF-95D7-4196-A0A7-A6774AAAEE4E@oracle.com> Please review JDK-8009146 at http://cr.openjdk.java.net/~attila/8009146/webrev.00 Thanks, Attila. From james.laskey at oracle.com Wed Feb 27 06:49:59 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Wed, 27 Feb 2013 10:49:59 -0400 Subject: Review request for JDK-8009143 In-Reply-To: References: Message-ID: +1 On 2013-02-27, at 10:14 AM, Attila Szegedi wrote: > Please review JDK-8009143 at http://cr.openjdk.java.net/~attila/8009143/webrev.00 > > Thanks, > Attila. From attila.szegedi at oracle.com Wed Feb 27 06:49:30 2013 From: attila.szegedi at oracle.com (attila.szegedi at oracle.com) Date: Wed, 27 Feb 2013 14:49:30 +0000 Subject: hg: nashorn/jdk8/nashorn: 8009146: Eliminate some dead code in preparation for immutable AST Message-ID: <20130227144931.66D1347468@hg.openjdk.java.net> Changeset: 928ea3d8faf0 Author: attila Date: 2013-02-27 15:49 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/928ea3d8faf0 8009146: Eliminate some dead code in preparation for immutable AST Reviewed-by: hannesw, lagergren ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/ir/Assignment.java ! src/jdk/nashorn/internal/ir/UnaryNode.java ! src/jdk/nashorn/internal/ir/VarNode.java ! src/jdk/nashorn/internal/runtime/linker/NashornCallSiteDescriptor.java From Alan.Bateman at oracle.com Wed Feb 27 06:29:26 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 27 Feb 2013 14:29:26 +0000 Subject: Please review 8009140: jtreg tests under sun/tools/jrunscript should use nashorn engine In-Reply-To: <512E14D5.4040102@oracle.com> References: <512E14D5.4040102@oracle.com> Message-ID: <512E1846.1020806@oracle.com> On 27/02/2013 14:14, A. Sundararajan wrote: > Hi, > > Please review http://cr.openjdk.java.net/~sundar/8009140/ This looks okay to me. -Alan From marcus.lagergren at oracle.com Wed Feb 27 07:08:01 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Wed, 27 Feb 2013 16:08:01 +0100 Subject: Review request for JDK-8009146 In-Reply-To: <0EE4FABF-95D7-4196-A0A7-A6774AAAEE4E@oracle.com> References: <0EE4FABF-95D7-4196-A0A7-A6774AAAEE4E@oracle.com> Message-ID: <5809CFD8-6160-4EC5-815C-42571520AF58@oracle.com> +1 On Feb 27, 2013, at 3:44 PM, Attila Szegedi wrote: > Please review JDK-8009146 at http://cr.openjdk.java.net/~attila/8009146/webrev.00 > > Thanks, > Attila. From hannes.wallnoefer at oracle.com Wed Feb 27 07:14:18 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Wed, 27 Feb 2013 16:14:18 +0100 Subject: Review request for JDK-8009146 In-Reply-To: <0EE4FABF-95D7-4196-A0A7-A6774AAAEE4E@oracle.com> References: <0EE4FABF-95D7-4196-A0A7-A6774AAAEE4E@oracle.com> Message-ID: <512E22CA.2070204@oracle.com> +1 Am 2013-02-27 15:44, schrieb Attila Szegedi: > Please review JDK-8009146 at http://cr.openjdk.java.net/~attila/8009146/webrev.00 > > Thanks, > Attila. From attila.szegedi at oracle.com Wed Feb 27 07:23:03 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Wed, 27 Feb 2013 16:23:03 +0100 Subject: Review request for JDK-8009150 Message-ID: Please review JDK-8009150 at http://cr.openjdk.java.net/~attila/8009150/webrev.00 Thanks, Attila. From hannes.wallnoefer at oracle.com Wed Feb 27 07:25:33 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Wed, 27 Feb 2013 16:25:33 +0100 Subject: Review request for JDK-8009150 In-Reply-To: References: Message-ID: <512E256D.30706@oracle.com> +1 Am 2013-02-27 16:23, schrieb Attila Szegedi: > Please review JDK-8009150 at http://cr.openjdk.java.net/~attila/8009150/webrev.00 > > Thanks, > Attila. From attila.szegedi at oracle.com Wed Feb 27 07:25:33 2013 From: attila.szegedi at oracle.com (attila.szegedi at oracle.com) Date: Wed, 27 Feb 2013 15:25:33 +0000 Subject: hg: nashorn/jdk8/nashorn: 8009150: Previous dead code elimination was incomplete Message-ID: <20130227152535.44E394746A@hg.openjdk.java.net> Changeset: 1da9e37697f6 Author: attila Date: 2013-02-27 16:25 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/1da9e37697f6 8009150: Previous dead code elimination was incomplete Reviewed-by: hannesw, lagergren ! src/jdk/nashorn/internal/ir/BinaryNode.java From james.laskey at oracle.com Wed Feb 27 07:42:57 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Wed, 27 Feb 2013 11:42:57 -0400 Subject: Review request for JDK-8009146 In-Reply-To: <0EE4FABF-95D7-4196-A0A7-A6774AAAEE4E@oracle.com> References: <0EE4FABF-95D7-4196-A0A7-A6774AAAEE4E@oracle.com> Message-ID: <4E755163-9250-4EA8-8C08-DE3BED1E0F1C@oracle.com> +1 On 2013-02-27, at 10:44 AM, Attila Szegedi wrote: > Please review JDK-8009146 at http://cr.openjdk.java.net/~attila/8009146/webrev.00 > > Thanks, > Attila. From sundararajan.athijegannathan at oracle.com Wed Feb 27 09:04:47 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Wed, 27 Feb 2013 22:34:47 +0530 Subject: Please review JDK-8009141: Avoid using netscape.javascript.JSObject in nashorn code Message-ID: <512E3CAF.5020303@oracle.com> Please review http://cr.openjdk.java.net/~sundar/8009141/ Thanks, -Sundar From james.laskey at oracle.com Wed Feb 27 09:33:58 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Wed, 27 Feb 2013 13:33:58 -0400 Subject: Please review JDK-8009141: Avoid using netscape.javascript.JSObject in nashorn code In-Reply-To: <512E3CAF.5020303@oracle.com> References: <512E3CAF.5020303@oracle.com> Message-ID: +1 On 2013-02-27, at 1:04 PM, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~sundar/8009141/ > > Thanks, > -Sundar From marcus.lagergren at oracle.com Wed Feb 27 10:28:21 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Wed, 27 Feb 2013 19:28:21 +0100 Subject: Please review JDK-8009141: Avoid using netscape.javascript.JSObject in nashorn code In-Reply-To: <512E3CAF.5020303@oracle.com> References: <512E3CAF.5020303@oracle.com> Message-ID: +1 On Feb 27, 2013, at 6:04 PM, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~sundar/8009141/ > > Thanks, > -Sundar From sundararajan.athijegannathan at oracle.com Thu Feb 28 06:57:57 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Thu, 28 Feb 2013 20:27:57 +0530 Subject: Review request for JDK-8009229: ant makefile default target should be "test" Message-ID: <512F7075.4040000@oracle.com> Please review http://cr.openjdk.java.net/~sundar/8009229/ Thanks -Sundar From sundararajan.athijegannathan at oracle.com Thu Feb 28 07:03:22 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Thu, 28 Feb 2013 15:03:22 +0000 Subject: hg: nashorn/jdk8/nashorn: 8009229: ant makefile default target should be "test" Message-ID: <20130228150323.7A0CA474B2@hg.openjdk.java.net> Changeset: 1e03be240534 Author: sundar Date: 2013-02-28 20:31 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/1e03be240534 8009229: ant makefile default target should be "test" Reviewed-by: lagergren, jlaskey ! make/build.xml From james.laskey at oracle.com Thu Feb 28 07:17:26 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Thu, 28 Feb 2013 11:17:26 -0400 Subject: Review request for JDK-8009229: ant makefile default target should be "test" In-Reply-To: <512F7075.4040000@oracle.com> References: <512F7075.4040000@oracle.com> Message-ID: <84B54581-4933-42E4-A640-C640016EAF46@oracle.com> +1 On 2013-02-28, at 10:57 AM, "A. Sundararajan" wrote: > Please review http://cr.openjdk.java.net/~sundar/8009229/ > > Thanks > -Sundar From rieberandreas at gmail.com Thu Feb 28 08:03:09 2013 From: rieberandreas at gmail.com (Andreas Rieber) Date: Thu, 28 Feb 2013 17:03:09 +0100 Subject: scriptpad close to finish Message-ID: <512F7FBD.7050002@gmail.com> Hi, i finished the nashorn-scriptpad patch and tested also all jdk/src/share/sample/scripting.... Found only two more minor issues. -- CASE 1 -- var charsLeft = 100; charsLeft -= 58; var min = java.lang.Math.min(4096, charsLeft); print(min); -- the result should be 42, what else ;-) To get scriptpad working i changed it to Math.min(). It fails with: java.lang.RuntimeException: java.lang.NoSuchMethodException: Can't unambiguously select between fixed arity signatures [(double, double), (int, int)] of the method java.lang.Math.min for argument types [java.lang.Integer, java.lang.Double] at jdk.nashorn.internal.runtime.ScriptRuntime.apply(ScriptRuntime.java:349) at jdk.nashorn.api.scripting.NashornScriptEngine.evalImpl(NashornScriptEngine.java:405) at jdk.nashorn.api.scripting.NashornScriptEngine.evalImpl(NashornScriptEngine.java:379) at jdk.nashorn.api.scripting.NashornScriptEngine.eval(NashornScriptEngine.java:126) at javax.script.AbstractScriptEngine.eval(AbstractScriptEngine.java:249) at com.sun.tools.script.shell.Main.evaluateReader(Main.java:332) at com.sun.tools.script.shell.Main.evaluateStream(Main.java:368) ... -- CASE 2 -- var chooser = new javax.swing.JColorChooser(); var res = chooser.showDialog(null, "Choose Color", java.awt.Color.BLACK); print(res); -- should open the color dialog, but fails with: script error in file colorChooser.js : TypeError: javax.swing.JColorChooser[,0,0,0x0,invalid,layout=java.awt.BorderLayout,alignmentX=0.0,alignmentY=0.0,border=,flags=8,maximumSize=,minimumSize=,preferredSize=,chooserPanels=[javax.swing.colorchooser.DefaultSwatchChooserPanel[,0,0,0x0,invalid,layout=java.awt.FlowLayout,alignmentX=0.0,alignmentY=0.0,border=,flags=8388617,maximumSize=,minimumSize=,preferredSize=]][javax.swing.colorchooser.ColorChooserPanel[,0,0,0x0,invalid,layout=java.awt.GridBagLayout,alignmentX=0.0,alignmentY=0.0,border=,flags=8388617,maximumSize=,minimumSize=,preferredSize=]][javax.swing.colorchooser.ColorChooserPanel[,0,0,0x0,invalid,layout=java.awt.GridBagLayout,alignmentX=0.0,alignmentY=0.0,border=,flags=8388617,maximumSize=,minimumSize=,preferredSize=]][javax.swing.colorchooser.ColorChooserPanel[,0,0,0x0,invalid,layout=java.awt.GridBagLayout,alignmentX=0.0,alignmentY=0.0,border=,flags=8388617,maximumSize=,minimumSize=,preferredSize=]][javax.swing.colorchooser.ColorChooserPanel[,0,0,0x0,invalid,layout=java.awt.GridBagLayout,alignmentX=0.0,alignmentY=0.0,border=,flags=8388617,maximumSize=,minimumSize=,preferredSize=]],previewPanel=javax.swing.colorchooser.DefaultPreviewPanel[,0,0,0x0,invalid,layout=java.awt.FlowLayout,alignmentX=0.0,alignmentY=0.0,border=,flags=8388617,maximumSize=,minimumSize=,preferredSize=]] has no such function "showDialog" in colorChooser.js at line number 3 I guess Sundar is the one for the scriptpad patch? Will send separate mail... Andreas From rieberandreas at gmail.com Thu Feb 28 08:26:21 2013 From: rieberandreas at gmail.com (Andreas Rieber) Date: Thu, 28 Feb 2013 17:26:21 +0100 Subject: scriptpad patch Message-ID: <512F852D.7090808@gmail.com> Hi Sundar, please find attached the scriptpad patch. I added a sync function in conc.js and removed the with(guiPkgs). Some more minor cleanup here and there. I checked that every menu entry and sample work (only the textcolor.js sample fails because of the previous mailed dialog problem). cheers Andreas -------------- next part -------------- diff --git a/src/share/sample/scripting/scriptpad/src/com/sun/sample/scriptpad/Main.java b/src/share/sample/scripting/scriptpad/src/com/sun/sample/scriptpad/Main.java --- a/src/share/sample/scripting/scriptpad/src/com/sun/sample/scriptpad/Main.java +++ b/src/share/sample/scripting/scriptpad/src/com/sun/sample/scriptpad/Main.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2006, 2011, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2006, 2013, Oracle and/or its affiliates. All rights reserved. * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -75,7 +75,7 @@ */ InputStream is = Main.class.getResourceAsStream("/resources/" + name); // current script file name for better error messages - engine.put(ScriptEngine.NAME, name); + engine.put(ScriptEngine.FILENAME, name); // evaluate the script in the InputStream engine.eval(new InputStreamReader(is)); } diff --git a/src/share/sample/scripting/scriptpad/src/resources/Main.js b/src/share/sample/scripting/scriptpad/src/resources/Main.js --- a/src/share/sample/scripting/scriptpad/src/resources/Main.js +++ b/src/share/sample/scripting/scriptpad/src/resources/Main.js @@ -1,5 +1,5 @@ /* - * Copyright (c) 2006, 2011, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2006, 2013, Oracle and/or its affiliates. All rights reserved. * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -37,7 +37,6 @@ * this sample code. */ - /* * This script can be loaded in jrunscript to start scriptpad. * @@ -48,4 +47,3 @@ load("gui.js"); load("scriptpad.js"); load("mm.js"); - diff --git a/src/share/sample/scripting/scriptpad/src/resources/conc.js b/src/share/sample/scripting/scriptpad/src/resources/conc.js --- a/src/share/sample/scripting/scriptpad/src/resources/conc.js +++ b/src/share/sample/scripting/scriptpad/src/resources/conc.js @@ -1,5 +1,5 @@ /* - * Copyright (c) 2006, 2011, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2006, 2013, Oracle and/or its affiliates. All rights reserved. * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -37,15 +37,43 @@ * this sample code. */ - /* * Concurrency utilities for JavaScript. These are based on - * java.lang and java.util.concurrent API. The following functions + * java.lang and java.util.concurrent API. The following functions * provide a simpler API for scripts. Instead of directly using java.lang * and java.util.concurrent classes, scripts can use functions and - * objects exported from here. + * objects exported from here. */ +// shortcut for j.u.c lock classes +var Lock = java.util.concurrent.locks.ReentrantLock; +var RWLock = java.util.concurrent.locks.ReentrantReadWriteLock; + +// check if there is a build in sync function, define one if missing +if (typeof sync === "undefined") { + var sync = function(func, obj) { + if (arguments.length < 1 || arguments.length > 2 ) { + throw "sync(function [,object]) parameter count mismatch"; + } + + var syncobj = (arguments.length == 2 ? obj : this); + + if (!syncobj._syncLock) { + syncobj._syncLock = new Lock(); + } + + return function() { + syncobj._syncLock.lock(); + try { + func.apply(null, arguments); + } finally { + syncobj._syncLock.unlock(); + } + }; + }; + sync.docString = "synchronize a function, optionally on an object"; +} + /** * Wrapper for java.lang.Object.wait * @@ -58,7 +86,6 @@ } wait.docString = "convenient wrapper for java.lang.Object.wait method"; - /** * Wrapper for java.lang.Object.notify * @@ -71,7 +98,6 @@ } notify.docString = "convenient wrapper for java.lang.Object.notify method"; - /** * Wrapper for java.lang.Object.notifyAll * @@ -84,7 +110,6 @@ } notifyAll.docString = "convenient wrapper for java.lang.Object.notifyAll method"; - /** * Creates a java.lang.Runnable from a given script * function. @@ -97,7 +122,7 @@ func.apply(null, args); } } -} +}; /** * Executes the function on a new Java Thread. @@ -106,7 +131,7 @@ var t = new java.lang.Thread(this.runnable.apply(this, arguments)); t.start(); return t; -} +}; /** * Executes the function on a new Java daemon Thread. @@ -116,7 +141,7 @@ t.setDaemon(true); t.start(); return t; -} +}; /** * Creates a java.util.concurrent.Callable from a given script @@ -128,7 +153,7 @@ return new java.util.concurrent.Callable() { call: function() { return func.apply(null, args); } } -} +}; /** * Registers the script function so that it will be called exit. @@ -137,10 +162,10 @@ var args = arguments; java.lang.Runtime.getRuntime().addShutdownHook( new java.lang.Thread(this.runnable.apply(this, args))); -} +}; /** - * Executes the function asynchronously. + * Executes the function asynchronously. * * @return a java.util.concurrent.FutureTask */ @@ -152,13 +177,9 @@ (function() { theExecutor.shutdown(); }).atexit(); return function() { return theExecutor.submit(this.callable.apply(this, arguments)); - } + }; })(); -// shortcut for j.u.c lock classes -var Lock = java.util.concurrent.locks.ReentrantLock; -var RWLock = java.util.concurrent.locks.ReentrantReadWriteLock; - /** * Executes a function after acquiring given lock. On return, * (normal or exceptional), lock is released. @@ -179,7 +200,7 @@ } finally { lock.unlock(); } -} +}; /** * Causes current thread to sleep for specified @@ -193,15 +214,48 @@ sleep.docString = "wrapper for java.lang.Thread.sleep method"; /** - * Schedules a task to be executed once in - * every N milliseconds specified. + * Schedules a task to be executed once in N milliseconds specified. * * @param callback function or expression to evaluate * @param interval in milliseconds to sleep * @return timeout ID (which is nothing but Thread instance) */ function setTimeout(callback, interval) { - if (! (callback instanceof Function)) { + if (! (callback instanceof Function) && typeof callback !== "function") { + callback = new Function(callback); + } + + // start a new thread that sleeps given time + // and calls callback in an infinite loop + return (function() { + try { + sleep(interval); + } catch (x) { } + callback(); + }).daemon(); +} +setTimeout.docString = "calls given callback once after specified interval"; + +/** + * Cancels a timeout set earlier. + * @param tid timeout ID returned from setTimeout + */ +function clearTimeout(tid) { + // we just interrupt the timer thread + tid.interrupt(); +} +clearTimeout.docString = "interrupt a setTimeout timer"; + +/** + * Schedules a task to be executed once in + * every N milliseconds specified. + * + * @param callback function or expression to evaluate + * @param interval in milliseconds to sleep + * @return timeout ID (which is nothing but Thread instance) + */ +function setInterval(callback, interval) { + if (! (callback instanceof Function) && typeof callback !== "function") { callback = new Function(callback); } @@ -209,38 +263,43 @@ // and calls callback in an infinite loop return (function() { while (true) { - sleep(interval); + try { + sleep(interval); + } catch (x) { + break; + } callback(); } }).daemon(); } -setTimeout.docString = "calls given callback once after specified interval" +setInterval.docString = "calls given callback every specified interval"; -/** +/** * Cancels a timeout set earlier. * @param tid timeout ID returned from setTimeout */ -function clearTimeout(tid) { +function clearInterval(tid) { // we just interrupt the timer thread tid.interrupt(); } +clearInterval.docString = "interrupt a setInterval timer"; /** - * Simple access to thread local storage. + * Simple access to thread local storage. * * Script sample: * * __thread.x = 44; - * function f() { - * __thread.x = 'hello'; - * print(__thread.x); + * function f() { + * __thread.x = 'hello'; + * print(__thread.x); * } * f.thread(); // prints 'hello' * print(__thread.x); // prints 44 in main thread */ var __thread = (function () { var map = new Object(); - return new JSAdapter() { + return new JSAdapter({ __has__: function(name) { return map[name] != undefined; }, @@ -263,8 +322,8 @@ __delete__: function(name) { if (map[name] != undefined) { map[name].set(null); - } + } } - } + }); })(); diff --git a/src/share/sample/scripting/scriptpad/src/resources/gui.js b/src/share/sample/scripting/scriptpad/src/resources/gui.js --- a/src/share/sample/scripting/scriptpad/src/resources/gui.js +++ b/src/share/sample/scripting/scriptpad/src/resources/gui.js @@ -1,5 +1,5 @@ /* - * Copyright (c) 2006, 2011, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2006, 2013, Oracle and/or its affiliates. All rights reserved. * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -37,16 +37,15 @@ * this sample code. */ - /* - * Few user interface utilities. + * Few user interface utilities. */ if (this.window === undefined) { this.window = null; } -/** +/** * Swing invokeLater - invokes given function in AWT event thread */ Function.prototype.invokeLater = function() { @@ -54,13 +53,13 @@ var func = this; var args = arguments; SwingUtilities.invokeLater(new java.lang.Runnable() { - run: function() { + run: function() { func.apply(func, args); } }); -} +}; -/** +/** * Swing invokeAndWait - invokes given function in AWT event thread * and waits for it's completion */ @@ -69,11 +68,11 @@ var func = this; var args = arguments; SwingUtilities.invokeAndWait(new java.lang.Runnable() { - run: function() { + run: function() { func.apply(func, args); } }); -} +}; /** * Am I running in AWT event dispatcher thread? @@ -85,22 +84,24 @@ isEventThread.docString = "returns whether the current thread is GUI thread"; /** - * Opens a file dialog box + * Opens a file dialog box * * @param curDir current directory [optional] * @param save flag tells whether this is a save dialog or not * @return selected file or else null */ -function fileDialog(curDir, save) { +function fileDialog(curDir, save) { var result; function _fileDialog() { if (curDir == undefined) { curDir = new java.io.File("."); } + var JFileChooser = javax.swing.JFileChooser; - var dialog = new JFileChooser(curDir); - var res = save? dialog.showSaveDialog(window): - dialog.showOpenDialog(window); + var dialog = new JFileChooser(curDir); + var res = save ? dialog.showSaveDialog(window): + dialog.showOpenDialog(window); + if (res == JFileChooser.APPROVE_OPTION) { result = dialog.getSelectedFile(); } else { @@ -113,37 +114,41 @@ } else { _fileDialog.invokeAndWait(); } + return result; } fileDialog.docString = "show a file dialog box"; /** - * Opens a color chooser dialog box + * Opens a color chooser dialog box * * @param title of the dialog box [optional] * @param color default color [optional] * @return choosen color or default color */ - function colorDialog(title, color) { var result; + function _colorDialog() { if (title == undefined) { title = "Choose Color"; } + if (color == undefined) { color = java.awt.Color.BLACK; } + var chooser = new javax.swing.JColorChooser(); var res = chooser.showDialog(window, title, color); - result = res? res : color; - } + result = res ? res : color; + } if (isEventThread()) { _colorDialog(); } else { _colorDialog.invokeAndWait(); } + return result; } colorDialog.docString = "shows a color chooser dialog box"; @@ -156,15 +161,15 @@ * @param msgType type of message box [constants in JOptionPane] */ function msgBox(msg, title, msgType) { - - function _msgBox() { + function _msgBox() { var JOptionPane = javax.swing.JOptionPane; if (msg === undefined) msg = "undefined"; if (msg === null) msg = "null"; if (title == undefined) title = msg; - if (msgType == undefined) type = JOptionPane.INFORMATION_MESSAGE; + if (msgType == undefined) msgType = JOptionPane.INFORMATION_MESSAGE; JOptionPane.showMessageDialog(window, msg, title, msgType); } + if (isEventThread()) { _msgBox(); } else { @@ -172,13 +177,13 @@ } } msgBox.docString = "shows MessageBox to the user"; - + /** * Shows an information alert box * * @param msg message to be shown * @param title title of message box [optional] - */ + */ function alert(msg, title) { var JOptionPane = javax.swing.JOptionPane; msgBox(msg, title, JOptionPane.INFORMATION_MESSAGE); @@ -197,7 +202,6 @@ } error.docString = "shows an error message box to the user"; - /** * Shows a warning alert box * @@ -210,7 +214,6 @@ } warn.docString = "shows a warning message box to the user"; - /** * Shows a prompt dialog box * @@ -225,11 +228,13 @@ if (answer == undefined) answer = ""; result = JOptionPane.showInputDialog(window, question, answer); } + if (isEventThread()) { _prompt(); } else { _prompt.invokeAndWait(); } + return result; } prompt.docString = "shows a prompt box to the user and returns the answer"; @@ -244,30 +249,33 @@ function confirm(msg, title) { var result; var JOptionPane = javax.swing.JOptionPane; + function _confirm() { if (title == undefined) title = msg; var optionType = JOptionPane.YES_NO_OPTION; result = JOptionPane.showConfirmDialog(window, msg, title, optionType); } + if (isEventThread()) { _confirm(); } else { _confirm.invokeAndWait(); - } + } + return result == JOptionPane.YES_OPTION; } confirm.docString = "shows a confirmation message box to the user"; /** - * Exit the process after confirmation from user - * + * Exit the process after confirmation from user + * * @param exitCode return code to OS [optional] */ function exit(exitCode) { if (exitCode == undefined) exitCode = 0; if (confirm("Do you really want to exit?")) { java.lang.System.exit(exitCode); - } + } } exit.docString = "exits jconsole"; diff --git a/src/share/sample/scripting/scriptpad/src/resources/mm.js b/src/share/sample/scripting/scriptpad/src/resources/mm.js --- a/src/share/sample/scripting/scriptpad/src/resources/mm.js +++ b/src/share/sample/scripting/scriptpad/src/resources/mm.js @@ -1,5 +1,5 @@ /* - * Copyright (c) 2006, 2011, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2006, 2013, Oracle and/or its affiliates. All rights reserved. * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -37,10 +37,9 @@ * this sample code. */ - /* * This is a collection of utilities for Monitoring - * and management API. + * and management API. * * File dependency: * conc.js -> for concurrency utilities @@ -71,14 +70,14 @@ } jmxConnect.docString = "connects to the given host, port (specified as name:port)"; -function mbeanConnection() { - if (mmConnection == null) { +function mbeanConnection() { + if (mmConnection == null) { throw "Not connected to MBeanServer yet!"; } return mmConnection; } -mbeanConnection.docString = "returns the current MBeanServer connection" +mbeanConnection.docString = "returns the current MBeanServer connection"; /** * Returns a platform MXBean proxy for given MXBean name and interface class @@ -102,7 +101,6 @@ } objectName.docString = "creates JMX ObjectName for a given String"; - /** * Creates a new (M&M) Attribute object * @@ -146,7 +144,6 @@ } queryNames.docString = "returns QueryNames using given ObjectName and optional query"; - /** * Queries with given ObjectName and QueryExp. * QueryExp may be null. @@ -220,7 +217,6 @@ } getMBeanAttribute.docString = "returns a single Attribute of given ObjectName"; - // sets MBean attributes function setMBeanAttributes(objName, attrList) { objName = objectName(objName); @@ -237,7 +233,6 @@ } setMBeanAttribute.docString = "sets a single Attribute of given ObjectName"; - // invokes an operation on given MBean function invokeMBean(objName, operation, params, signature) { objName = objectName(objName); @@ -260,16 +255,17 @@ * will be of type FutureTask. When you need value, call 'get' on it. */ function mbean(objName, async) { + var index; objName = objectName(objName); - var info = mbeanInfo(objName); + var info = mbeanInfo(objName); var attrs = info.attributes; var attrMap = new Object; - for (var index in attrs) { + for (index in attrs) { attrMap[attrs[index].name] = attrs[index]; } var opers = info.operations; var operMap = new Object; - for (var index in opers) { + for (index in opers) { operMap[opers[index].name] = opers[index]; } @@ -288,9 +284,9 @@ __get__: function (name) { if (isAttribute(name)) { if (async) { - return getMBeanAttribute.future(objName, name); + return getMBeanAttribute.future(objName, name); } else { - return getMBeanAttribute(objName, name); + return getMBeanAttribute(objName, name); } } else if (isOperation(name)) { var oper = operMap[name]; @@ -302,12 +298,12 @@ sigNames[index] = sigs[index].getType(); } if (async) { - return invokeMBean.future(objName, name, + return invokeMBean.future(objName, name, params, sigNames); } else { return invokeMBean(objName, name, params, sigNames); } - } + }; } else { return undefined; } @@ -327,9 +323,9 @@ } mbean.docString = "returns a conveninent script wrapper for a MBean of given ObjectName"; -if (this.application != undefined) { - this.application.addTool("JMX Connect", - // connect to a JMX MBean Server +if (this.application != undefined) { + this.application.addTool("JMX Connect", + // connect to a JMX MBean Server function () { var url = prompt("Connect to JMX server (host:port)"); if (url != null) { diff --git a/src/share/sample/scripting/scriptpad/src/resources/scriptpad.js b/src/share/sample/scripting/scriptpad/src/resources/scriptpad.js --- a/src/share/sample/scripting/scriptpad/src/resources/scriptpad.js +++ b/src/share/sample/scripting/scriptpad/src/resources/scriptpad.js @@ -1,5 +1,5 @@ /* - * Copyright (c) 2006, 2011, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2006, 2013, Oracle and/or its affiliates. All rights reserved. * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -37,9 +37,8 @@ * this sample code. */ - /* - * This script creates a simple Notepad-like interface, which + * This script creates a simple Notepad-like interface, which * serves as a simple script editor, runner. * * File dependency: @@ -48,579 +47,583 @@ */ /* + * globalThis is used for actionHelpGlobals() and showFrame(). + */ +var globalThis = this; + +/* * JavaImporter helps in avoiding pollution of JavaScript * global namespace. We can import multiple Java packages * with this and use the JavaImporter object with "with" * statement. */ var guiPkgs = new JavaImporter(java.awt, java.awt.event, - javax.swing, javax.swing.undo, - javax.swing.event, javax.swing.text); + javax.swing, javax.swing.undo, + javax.swing.event, javax.swing.text); -with (guiPkgs) { +// main entry point of the scriptpad application +var main = function() { + function createEditor() { + var c = new guiPkgs.JTextArea(); + c.setDragEnabled(true); + c.setFont(new guiPkgs.Font("monospaced", guiPkgs.Font.PLAIN, 12)); + return c; + } - /* - * within this "with" statement all Java classes in - * packages defined in "guiPkgs" can be used as simple - * names instead of the fully qualified names. - */ + /*const*/ var titleSuffix = "- Scriptpad"; + /*const*/ var defaultTitle = "Untitled" + titleSuffix; + // Scriptpad's main frame + var frame; + // Scriptpad's main editor + var editor; - // main entry point of the scriptpad application - function main() { - function createEditor() { - var c = new JTextArea(); - c.setDragEnabled(true); - c.setFont(new Font("monospaced", Font.PLAIN, 12)); - return c; - } + // To track the current file name + var curFileName = null; - /*const*/ var titleSuffix = "- Scriptpad"; - /*const*/ var defaultTitle = "Untitled" + titleSuffix; + // To track whether the current document + // has been modified or not + var docChanged = false; - // Scriptpad's main frame - var frame; - // Scriptpad's main editor - var editor; - - // To track the current file name - var curFileName = null; - - // To track whether the current document - // has been modified or not - var docChanged = false; - - // check and alert user for unsaved - // but modified document - function checkDocChanged() { - if (docChanged) { - // ignore zero-content untitled document - if (curFileName == null && - editor.document.length == 0) { - return; - } - - if (confirm( - "Do you want to save the changes?", - "The document has changed")) { - actionSave(); - } - } - } - - // set a document listener to track - // whether that is modified or not - function setDocListener() { - var doc = editor.getDocument(); - docChanged = false; - doc.addDocumentListener(new DocumentListener() { - equals: function(o) { return this === o; }, - toString: function() { return "doc listener"; }, - changeUpdate: function() { docChanged = true; }, - insertUpdate: function() { docChanged = true; }, - removeUpdate: function() { docChanged = true; }, - }); - } - - // menu action functions - - // "File" menu - - // create a "new" document - function actionNew(){ - checkDocChanged(); - curFileName = null; - editor.setDocument(new PlainDocument()); - setDocListener(); - frame.setTitle(defaultTitle); - editor.revalidate(); - } - - // open an existing file - function actionOpen() { - checkDocChanged(); - var f = fileDialog(); - if (f == null) { - return; - } - if (f.isFile() && f.canRead()) { - frame.setTitle(f.getName() + titleSuffix); - editor.setDocument(new PlainDocument()); - var progress = new JProgressBar(); - progress.setMinimum(0); - progress.setMaximum(f.length()); - var doc = editor.getDocument(); - var inp = new java.io.FileReader(f); - var buff = java.lang.reflect.Array.newInstance( - java.lang.Character.TYPE, 4096); - var nch; - while ((nch = inp.read(buff, 0, buff.length)) != -1) { - doc.insertString(doc.getLength(), - new java.lang.String(buff, 0, nch), null); - progress.setValue(progress.getValue() + nch); - } - inp.close(); - curFileName = f.getAbsolutePath(); - setDocListener(); - } else { - error("Can not open file: " + f, - "Error opening file: " + f); - } - } - - // open script from a URL - function actionOpenURL() { - checkDocChanged(); - var url = prompt("Address:"); - if (url == null) { + // check and alert user for unsaved + // but modified document + function checkDocChanged() { + if (docChanged) { + // ignore zero-content untitled document + if (curFileName == null && + editor.document.length == 0) { return; } - try { - var u = new java.net.URL(url); - editor.setDocument(new PlainDocument()); - frame.setTitle(url + titleSuffix); - var progress = new JProgressBar(); - progress.setMinimum(0); - progress.setIndeterminate(true); - var doc = editor.getDocument(); - var inp = new java.io.InputStreamReader(u.openStream()); - var buff = java.lang.reflect.Array.newInstance( - java.lang.Character.TYPE, 4096); - var nch; - while ((nch = inp.read(buff, 0, buff.length)) != -1) { - doc.insertString(doc.getLength(), - new java.lang.String(buff, 0, nch), null); - progress.setValue(progress.getValue() + nch); - } - curFileName = null; - setDocListener(); - } catch (e) { - error("Error opening URL: " + e, - "Can not open URL: " + url); - } - } + if (confirm("Do you want to save the changes?", + "The document has changed")) { + actionSave(); + } + } + } - // factored out "save" function used by - // save, save as menu actions - function save(file) { - var doc = editor.getDocument(); - frame.setTitle(file.getName() + titleSuffix); - curFileName = file; - var progress = new JProgressBar(); - progress.setMinimum(0); - progress.setMaximum(file.length()); - var out = new java.io.FileWriter(file); - var text = new Segment(); - text.setPartialReturn(true); - var charsLeft = doc.getLength(); - var offset = 0; - while (charsLeft > 0) { - doc.getText(offset, java.lang.Math.min(4096, charsLeft), text); - out.write(text.array, text.offset, text.count); - charsLeft -= text.count; - offset += text.count; - progress.setValue(offset); - java.lang.Thread.sleep(10); - } - out.flush(); - out.close(); - docChanged = false; + // set a document listener to track + // whether that is modified or not + function setDocListener() { + var doc = editor.getDocument(); + docChanged = false; + doc.addDocumentListener( new guiPkgs.DocumentListener() { + equals: function(o) { + return this === o; }, + toString: function() { + return "doc listener"; }, + changeUpdate: function() { + docChanged = true; }, + insertUpdate: function() { + docChanged = true; }, + removeUpdate: function() { + docChanged = true; } + }); + } + + // menu action functions + + // "File" menu + + // create a "new" document + function actionNew() { + checkDocChanged(); + curFileName = null; + editor.setDocument(new guiPkgs.PlainDocument()); + setDocListener(); + frame.setTitle(defaultTitle); + editor.revalidate(); + } + + // open an existing file + function actionOpen() { + checkDocChanged(); + var f = fileDialog(); + if (f == null) { + return; } - // file-save as menu - function actionSaveAs() { - var ret = fileDialog(null, true); - if (ret == null) { - return; + if (f.isFile() && f.canRead()) { + frame.setTitle(f.getName() + titleSuffix); + editor.setDocument(new guiPkgs.PlainDocument()); + var progress = new guiPkgs.JProgressBar(); + progress.setMinimum(0); + progress.setMaximum(f.length()); + var doc = editor.getDocument(); + var inp = new java.io.FileReader(f); + var buff = java.lang.reflect.Array.newInstance( + java.lang.Character.TYPE, 4096); + var nch; + while ((nch = inp.read(buff, 0, buff.length)) != -1) { + doc.insertString(doc.getLength(), + new java.lang.String(buff, 0, nch), null); + progress.setValue(progress.getValue() + nch); } - save(ret); + inp.close(); + curFileName = f.getAbsolutePath(); + setDocListener(); + } else { + error("Can not open file: " + f, + "Error opening file: " + f); + } + } + + // open script from a URL + function actionOpenURL() { + checkDocChanged(); + var url = prompt("Address:"); + if (url == null) { + return; } - // file-save menu - function actionSave() { - if (curFileName) { - save(new java.io.File(curFileName)); - } else { - actionSaveAs(); + try { + var u = new java.net.URL(url); + editor.setDocument(new guiPkgs.PlainDocument()); + frame.setTitle(url + titleSuffix); + var progress = new guiPkgs.JProgressBar(); + progress.setMinimum(0); + progress.setIndeterminate(true); + var doc = editor.getDocument(); + var inp = new java.io.InputStreamReader(u.openStream()); + var buff = java.lang.reflect.Array.newInstance( + java.lang.Character.TYPE, 4096); + var nch; + while ((nch = inp.read(buff, 0, buff.length)) != -1) { + doc.insertString(doc.getLength(), + new java.lang.String(buff, 0, nch), null); + progress.setValue(progress.getValue() + nch); + } + curFileName = null; + setDocListener(); + } catch (e) { + error("Error opening URL: " + e, + "Can not open URL: " + url); + } + } + + // factored out "save" function used by + // save, save as menu actions + function save(file) { + var doc = editor.getDocument(); + frame.setTitle(file.getName() + titleSuffix); + curFileName = file; + var progress = new guiPkgs.JProgressBar(); + progress.setMinimum(0); + progress.setMaximum(file.length()); + var out = new java.io.FileWriter(file); + var text = new guiPkgs.Segment(); + text.setPartialReturn(true); + var charsLeft = doc.getLength(); + var offset = 0; + var min; + + while (charsLeft > 0) { + doc.getText(offset, Math.min(4096, charsLeft), text); + out.write(text.array, text.offset, text.count); + charsLeft -= text.count; + offset += text.count; + progress.setValue(offset); + java.lang.Thread.sleep(10); + } + + out.flush(); + out.close(); + docChanged = false; + } + + // file-save as menu + function actionSaveAs() { + var ret = fileDialog(null, true); + if (ret == null) { + return; + } + save(ret); + } + + // file-save menu + function actionSave() { + if (curFileName) { + save(new java.io.File(curFileName)); + } else { + actionSaveAs(); + } + } + + // exit from scriptpad + function actionExit() { + checkDocChanged(); + java.lang.System.exit(0); + } + + // "Edit" menu + + // cut the currently selected text + function actionCut() { + editor.cut(); + } + + // copy the currently selected text to clipboard + function actionCopy() { + editor.copy(); + } + + // paste clipboard content to document + function actionPaste() { + editor.paste(); + } + + // select all the text in editor + function actionSelectAll() { + editor.selectAll(); + } + + // "Tools" menu + + // run the current document as JavaScript + function actionRun() { + var doc = editor.getDocument(); + var script = doc.getText(0, doc.getLength()); + var oldFile = engine.get(javax.script.ScriptEngine.FILENAME); + try { + if (engine == undefined) { + var m = new javax.script.ScriptEngineManager(); + engine = m.getEngineByName("nashorn"); + } + engine.put(javax.script.ScriptEngine.FILENAME, frame.title); + engine.eval(script, context); + } catch (e) { + error(e, "Script Error"); + e.printStackTrace(); + } finally { + engine.put(javax.script.ScriptEngine.FILENAME, oldFile); + } + } + + // "Examples" menu + + // show given script as new document + function showScript(title, str) { + actionNew(); + frame.setTitle("Example - " + title + titleSuffix); + var doc = editor.document; + doc.insertString(0, str, null); + } + + // "hello world" + function actionHello() { + showScript(actionEval.title, + "alert('Hello, world');"); + } + actionHello.title = "Hello, World"; + + // eval the "hello world"! + function actionEval() { + showScript(actionEval.title, + "eval(\"alert('Hello, world')\");"); + } + actionEval.title = "Eval"; + + // show how to access Java static methods + function actionJavaStatic() { + showScript(arguments.callee.title, + "// Just use Java syntax\n" + + "var props = java.lang.System.getProperties();\n" + + "alert(props.get('os.name'));"); + } + actionJavaStatic.title = "Java Static Calls"; + + // show how to access Java classes, methods + function actionJavaAccess() { + showScript(arguments.callee.title, + "// just use new JavaClass();\n" + + "var fr = new javax.swing.JFrame();\n" + + "// call all public methods as in Java\n" + + "fr.setTitle('hello');\n" + + "fr.setDefaultCloseOperation(javax.swing.WindowConstants.DISPOSE_ON_CLOSE);\n" + + "fr.setSize(200, 200);\n" + + "fr.setVisible(true);"); + } + actionJavaAccess.title = "Java Object Access"; + + // show how to use Java bean conventions + function actionJavaBean() { + showScript(arguments.callee.title, + "var fr = new javax.swing.JFrame();\n" + + "fr.setSize(200, 200);\n" + + "// access public get/set methods as fields\n" + + "fr.defaultCloseOperation = javax.swing.WindowConstants.DISPOSE_ON_CLOSE;\n" + + "fr.title = 'hello';\n" + + "fr.visible = true;"); + } + actionJavaBean.title = "Java Beans"; + + // show how to implement Java interface + function actionJavaInterface() { + showScript(arguments.callee.title, + "// use Java anonymizer class-like syntax!\n" + + "var r = new java.lang.Runnable() {\n" + + " run: function() {\n" + + " alert('hello');\n" + + " }\n" + + " };\n" + + "// use the above Runnable to create a Thread\n" + + "new java.lang.Thread(r).start();\n" + + "// For simple one method interfaces, just pass script function\n" + + "new java.lang.Thread(function() { alert('world'); }).start();"); + } + actionJavaInterface.title = "Java Interfaces"; + + // show how to import Java classes, packages + function actionJavaImport() { + showScript(arguments.callee.title, + "// use Java-like import *...\n" + + "// importPackage(java.io);\n" + + "// or import a specific class\n" + + "// importClass(java.io.File);\n" + + "// or better - import just within a scope!\n" + + "var ioPkgs = JavaImporter(java.io);\n" + + "with (ioPkgs) { alert(new File('.').absolutePath); }"); + } + actionJavaImport.title = "Java Import"; + + // "Help" menu + + /* + * Shows a one liner help message for each + * global function. Note that this function + * depends on docString meta-data for each + * function. + */ + function actionHelpGlobals() { + var names = new java.util.ArrayList(); + for (var i in globalThis) { + var func = globalThis[i]; + if (typeof(func) == "function" && + ("docString" in func)) { + names.add(i); } } + java.util.Collections.sort(names); + var helpDoc = new java.lang.StringBuffer(); + helpDoc.append(""); + var itr = names.iterator(); + while (itr.hasNext()) { + var name = itr.next(); + helpDoc.append(""); + } + helpDoc.append("
"); + helpDoc.append(name); + helpDoc.append(""); + helpDoc.append(globalThis[name].docString); + helpDoc.append("
"); - // exit from scriptpad - function actionExit() { - checkDocChanged(); - java.lang.System.exit(0); + var helpEditor = new guiPkgs.JEditorPane(); + helpEditor.setContentType("text/html"); + helpEditor.setEditable(false); + helpEditor.setText(helpDoc.toString()); + + var scroller = new guiPkgs.JScrollPane(); + var port = scroller.getViewport(); + port.add(helpEditor); + + var helpFrame = new guiPkgs.JFrame("Help - Global Functions"); + helpFrame.getContentPane().add("Center", scroller); + helpFrame.setDefaultCloseOperation(guiPkgs.WindowConstants.DISPOSE_ON_CLOSE); + helpFrame.pack(); + helpFrame.setSize(500, 600); + helpFrame.setVisible(true); + } + + // show a simple about message for scriptpad + function actionAbout() { + alert("Scriptpad\nVersion 1.1", "Scriptpad"); + } + + /* + * This data is used to construct menu bar. + * This way adding a menu is easier. Just add + * top level menu or add an item to an existing + * menu. "action" should be a function that is + * called back on clicking the correponding menu. + */ + var menuData = [ + { + menu: "File", + items: [ + { name: "New", action: actionNew , accel: guiPkgs.KeyEvent.VK_N }, + { name: "Open...", action: actionOpen, accel: guiPkgs.KeyEvent.VK_O }, + { name: "Open URL...", action: actionOpenURL, accel: guiPkgs.KeyEvent.VK_U }, + { name: "Save", action: actionSave, accel: guiPkgs.KeyEvent.VK_S }, + { name: "Save As...", action: actionSaveAs }, + { name: "-" }, + { name: "Exit", action: actionExit, accel: guiPkgs.KeyEvent.VK_Q } + ] + }, + + { + menu: "Edit", + items: [ + { name: "Cut", action: actionCut, accel: guiPkgs.KeyEvent.VK_X }, + { name: "Copy", action: actionCopy, accel: guiPkgs.KeyEvent.VK_C }, + { name: "Paste", action: actionPaste, accel: guiPkgs.KeyEvent.VK_V }, + { name: "-" }, + { name: "Select All", action: actionSelectAll, accel: guiPkgs.KeyEvent.VK_A } + ] + }, + + { + menu: "Tools", + items: [ + { name: "Run", action: actionRun, accel: guiPkgs.KeyEvent.VK_R } + ] + }, + + { + menu: "Examples", + items: [ + { name: actionHello.title, action: actionHello }, + { name: actionEval.title, action: actionEval }, + { name: actionJavaStatic.title, action: actionJavaStatic }, + { name: actionJavaAccess.title, action: actionJavaAccess }, + { name: actionJavaBean.title, action: actionJavaBean }, + { name: actionJavaInterface.title, action: actionJavaInterface }, + { name: actionJavaImport.title, action: actionJavaImport } + ] + }, + + { + menu: "Help", + items: [ + { name: "Global Functions", action: actionHelpGlobals }, + { name: "-" }, + { name: "About Scriptpad", action: actionAbout } + ] + } + ]; + + function setMenuAccelerator(mi, accel) { + var keyStroke = guiPkgs.KeyStroke.getKeyStroke(accel, + guiPkgs.Toolkit.getDefaultToolkit().getMenuShortcutKeyMask(), false); + mi.setAccelerator(keyStroke); + } + + // create a menubar using the above menu data + function createMenubar() { + var mb = new guiPkgs.JMenuBar(); + for (var m in menuData) { + var items = menuData[m].items; + var menu = new guiPkgs.JMenu(menuData[m].menu); + + for (var i in items) { + if (items[i].name.equals("-")) { + menu.addSeparator(); + } else { + var mi = new guiPkgs.JMenuItem(items[i].name); + var action = items[i].action; + mi.addActionListener(action); + var accel = items[i].accel; + if (accel) { + setMenuAccelerator(mi, accel); + } + menu.add(mi); + } + } + + mb.add(menu); } - // "Edit" menu + return mb; + } - // cut the currently selected text - function actionCut() { - editor.cut(); + // function to add a new menu item under "Tools" menu + function addTool(menuItem, action, accel) { + if (typeof(action) != "function") { + return; } - // copy the currently selected text to clipboard - function actionCopy() { - editor.copy(); - } - - // paste clipboard content to document - function actionPaste() { - editor.paste(); - } - - // select all the text in editor - function actionSelectAll() { - editor.selectAll(); - } - - // "Tools" menu - - // run the current document as JavaScript - function actionRun() { - var doc = editor.getDocument(); - var script = doc.getText(0, doc.getLength()); - var oldFile = engine.get(javax.script.ScriptEngine.FILENAME); - try { - if (this.engine == undefined) { - var m = new javax.script.ScriptEngineManager(); - engine = m.getEngineByName("js"); - } - engine.put(javax.script.ScriptEngine.FILENAME, frame.title); - engine.eval(script, context); - } catch (e) { - error(e, "Script Error"); - // e.rhinoException.printStackTrace(); - } finally { - engine.put(javax.script.ScriptEngine.FILENAME, oldFile); + var toolsIndex = -1; + // find the index of the "Tools" menu + for (var i in menuData) { + if (menuData[i].menu.equals("Tools")) { + toolsIndex = i; + break; } } + if (toolsIndex == -1) { + return; + } + var toolsMenu = frame.getJMenuBar().getMenu(toolsIndex); + var mi = new guiPkgs.JMenuItem(menuItem); + mi.addActionListener(action); + if (accel) { + setMenuAccelerator(mi, accel); + } + toolsMenu.add(mi); + } - // "Examples" menu + // create Scriptpad frame + function createFrame() { + frame = new guiPkgs.JFrame(); + frame.setTitle(defaultTitle); + frame.setBackground(guiPkgs.Color.lightGray); + frame.getContentPane().setLayout(new guiPkgs.BorderLayout()); - // show given script as new document - function showScript(title, str) { - actionNew(); - frame.setTitle("Example - " + title + titleSuffix); - var doc = editor.document; - doc.insertString(0, str, null); - } + // create notepad panel + var notepad = new guiPkgs.JPanel(); + notepad.setBorder(guiPkgs.BorderFactory.createEtchedBorder()); + notepad.setLayout(new guiPkgs.BorderLayout()); - // "hello world" - function actionHello() { - showScript(arguments.callee.title, - "alert('Hello, world');"); - } - actionHello.title = "Hello, World"; + // create editor + editor = createEditor(); + var scroller = new guiPkgs.JScrollPane(); + var port = scroller.getViewport(); + port.add(editor); - // eval the "hello world"! - function actionEval() { - showScript(actionEval.title, - "eval(\"alert('Hello, world')\");"); - } - actionEval.title = "Eval"; + // add editor to notepad panel + var panel = new guiPkgs.JPanel(); + panel.setLayout(new guiPkgs.BorderLayout()); + panel.add("Center", scroller); + notepad.add("Center", panel); - // show how to access Java static methods - function actionJavaStatic() { - showScript(arguments.callee.title, - "// Just use Java syntax\n" + - "var props = java.lang.System.getProperties();\n" + - "alert(props.get('os.name'));"); - } - actionJavaStatic.title = "Java Static Calls"; + // add notepad panel to frame + frame.getContentPane().add("Center", notepad); - // show how to access Java classes, methods - function actionJavaAccess() { - showScript(arguments.callee.title, - "// just use new JavaClass();\n" + - "var fr = new javax.swing.JFrame();\n" + - "// call all public methods as in Java\n" + - "fr.setTitle('hello');\n" + - "fr.setDefaultCloseOperation(javax.swing.WindowConstants.DISPOSE_ON_CLOSE);\n" + - "fr.setSize(200, 200);\n" + - "fr.setVisible(true);"); - } - actionJavaAccess.title = "Java Object Access"; + // set menu bar to frame and show the frame + frame.setJMenuBar(createMenubar()); + frame.setDefaultCloseOperation(guiPkgs.JFrame.EXIT_ON_CLOSE); + frame.pack(); + frame.setSize(500, 600); + } - // show how to use Java bean conventions - function actionJavaBean() { - showScript(arguments.callee.title, - "var fr = new javax.swing.JFrame();\n" + - "fr.setSize(200, 200);\n" + - "// access public get/set methods as fields\n" + - "fr.defaultCloseOperation = javax.swing.WindowConstants.DISPOSE_ON_CLOSE;\n" + - "fr.title = 'hello';\n" + - "fr.visible = true;"); - } - actionJavaBean.title = "Java Beans"; + // show Scriptpad frame + function showFrame() { + // set global variable by the name "window" + globalThis.window = frame; - // show how to implement Java interface - function actionJavaInterface() { - showScript(arguments.callee.title, - "// use Java anonymizer class-like syntax!\n" + - "var r = new java.lang.Runnable() {\n" + - " run: function() {\n" + - " alert('hello');\n" + - " }\n" + - " };\n" + - "// use the above Runnable to create a Thread\n" + - "java.lang.Thread(r).start();\n" + - "// For simple one method interfaces, just pass script function\n" + - "java.lang.Thread(function() { alert('world'); }).start();"); - } - actionJavaInterface.title = "Java Interfaces"; + // open new document + actionNew(); - // show how to import Java classes, packages - function actionJavaImport() { - showScript(arguments.callee.title, - "// use Java-like import *...\n" + - "// importPackage(java.io);\n" + - "// or import a specific class\n" + - "// importClass(java.io.File);\n" + - "// or better - import just within a scope!\n" + - "var ioPkgs = JavaImporter(java.io);\n" + - "with (ioPkgs) { alert(new File('.').absolutePath); }"); - } - actionJavaImport.title = "Java Import"; + frame.setVisible(true); + } - // "Help" menu + // create and show Scriptpad frame + createFrame(); + showFrame(); - /* - * Shows a one liner help message for each - * global function. Note that this function - * depends on docString meta-data for each - * function. - */ - function actionHelpGlobals() { - var names = new java.util.ArrayList(); - for (var i in this) { - var func = this[i]; - if (typeof(func) == "function" && - ("docString" in func)) { - names.add(i); - } - } - java.util.Collections.sort(names); - var helpDoc = new java.lang.StringBuffer(); - helpDoc.append(""); - var itr = names.iterator(); - while (itr.hasNext()) { - var name = itr.next(); - helpDoc.append(""); - } - helpDoc.append("
"); - helpDoc.append(name); - helpDoc.append(""); - helpDoc.append(this[name].docString); - helpDoc.append("
"); - - var helpEditor = new JEditorPane(); - helpEditor.setContentType("text/html"); - helpEditor.setEditable(false); - helpEditor.setText(helpDoc.toString()); - - var scroller = new JScrollPane(); - var port = scroller.getViewport(); - port.add(helpEditor); - - var helpFrame = new JFrame("Help - Global Functions"); - helpFrame.getContentPane().add("Center", scroller); - helpFrame.setDefaultCloseOperation(WindowConstants.DISPOSE_ON_CLOSE); - helpFrame.pack(); - helpFrame.setSize(500, 600); - helpFrame.setVisible(true); - } - - // show a simple about message for scriptpad - function actionAbout() { - alert("Scriptpad\nVersion 1.0", "Scriptpad"); - } - - /* - * This data is used to construct menu bar. - * This way adding a menu is easier. Just add - * top level menu or add an item to an existing - * menu. "action" should be a function that is - * called back on clicking the correponding menu. - */ - var menuData = [ - { - menu: "File", - items: [ - { name: "New", action: actionNew , accel: KeyEvent.VK_N }, - { name: "Open...", action: actionOpen, accel: KeyEvent.VK_O }, - { name: "Open URL...", action: actionOpenURL, accel: KeyEvent.VK_U }, - { name: "Save", action: actionSave, accel: KeyEvent.VK_S }, - { name: "Save As...", action: actionSaveAs }, - { name: "-" }, - { name: "Exit", action: actionExit } - ] - }, - - { - menu: "Edit", - items: [ - { name: "Cut", action: actionCut, accel: KeyEvent.VK_X }, - { name: "Copy", action: actionCopy, accel: KeyEvent.VK_C }, - { name: "Paste", action: actionPaste, accel: KeyEvent.VK_V }, - { name: "-" }, - { name: "Select All", action: actionSelectAll, accel: KeyEvent.VK_A } - ] - }, - - { - menu: "Tools", - items: [ - { name: "Run", action: actionRun, accel: KeyEvent.VK_R }, - ] - }, - - { - menu: "Examples", - items: [ - { name: actionHello.title, action: actionHello }, - { name: actionEval.title, action: actionEval }, - { name: actionJavaStatic.title, action: actionJavaStatic }, - { name: actionJavaAccess.title, action: actionJavaAccess }, - { name: actionJavaBean.title, action: actionJavaBean }, - { name: actionJavaInterface.title, action: actionJavaInterface }, - { name: actionJavaImport.title, action: actionJavaImport }, - ] - }, - - { - menu: "Help", - items: [ - { name: "Global Functions", action: actionHelpGlobals }, - { name: "-" }, - { name: "About Scriptpad", action: actionAbout }, - ] - } - ]; - - - function setMenuAccelerator(mi, accel) { - var keyStroke = KeyStroke.getKeyStroke(accel, - Toolkit.getDefaultToolkit().getMenuShortcutKeyMask(), false); - mi.setAccelerator(keyStroke); - } - - // create a menubar using the above menu data - function createMenubar() { - var mb = new JMenuBar(); - for (var m in menuData) { - var items = menuData[m].items; - var menu = new JMenu(menuData[m].menu); - for (var i in items) { - if (items[i].name.equals("-")) { - menu.addSeparator(); - } else { - var mi = new JMenuItem(items[i].name); - var action = items[i].action; - mi.addActionListener(action); - var accel = items[i].accel; - if (accel) { - setMenuAccelerator(mi, accel); - } - menu.add(mi); - } - } - mb.add(menu); - } - return mb; - } - - // function to add a new menu item under "Tools" menu - function addTool(menuItem, action, accel) { - if (typeof(action) != "function") { - return; - } - - var toolsIndex = -1; - // find the index of the "Tools" menu - for (var i in menuData) { - if (menuData[i].menu.equals("Tools")) { - toolsIndex = i; - break; - } - } - if (toolsIndex == -1) { - return; - } - var toolsMenu = frame.getJMenuBar().getMenu(toolsIndex); - var mi = new JMenuItem(menuItem); - mi.addActionListener(action); - if (accel) { - setMenuAccelerator(mi, accel); - } - toolsMenu.add(mi); - } - - - // create Scriptpad frame - function createFrame() { - frame = new JFrame(); - frame.setTitle(defaultTitle); - frame.setBackground(Color.lightGray); - frame.getContentPane().setLayout(new BorderLayout()); - - // create notepad panel - var notepad = new JPanel(); - notepad.setBorder(BorderFactory.createEtchedBorder()); - notepad.setLayout(new BorderLayout()); - - // create editor - editor = createEditor(); - var scroller = new JScrollPane(); - var port = scroller.getViewport(); - port.add(editor); - - // add editor to notepad panel - var panel = new JPanel(); - panel.setLayout(new BorderLayout()); - panel.add("Center", scroller); - notepad.add("Center", panel); - - // add notepad panel to frame - frame.getContentPane().add("Center", notepad); - - // set menu bar to frame and show the frame - frame.setJMenuBar(createMenubar()); - frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE); - frame.pack(); - frame.setSize(500, 600); - } - - // show Scriptpad frame - function showFrame() { - // set global variable by the name "window" - this.window = frame; - - // open new document - actionNew(); - - frame.setVisible(true); - } - - // create and show Scriptpad frame - createFrame(); - showFrame(); - - /* - * Application object has two fields "frame", "editor" - * which are current JFrame and editor and a method - * called "addTool" to add new menu item to "Tools" menu. - */ - return { - frame: frame, - editor: editor, - addTool: addTool - }; - } -} + /* + * Application object has two fields "frame", "editor" + * which are current JFrame and editor and a method + * called "addTool" to add new menu item to "Tools" menu. + */ + return { + frame: frame, + editor: editor, + addTool: addTool + }; +}; /* - * Call the main and store Application object + * Call the main and store Application object * in a global variable named "application". */ var application = main(); @@ -657,4 +660,3 @@ } loadUserInit(); - diff --git a/src/share/sample/scripting/scriptpad/src/scripts/browse.js b/src/share/sample/scripting/scriptpad/src/scripts/browse.js --- a/src/share/sample/scripting/scriptpad/src/scripts/browse.js +++ b/src/share/sample/scripting/scriptpad/src/scripts/browse.js @@ -1,5 +1,5 @@ /* - * Copyright (c) 2006, 2011, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2006, 2013, Oracle and/or its affiliates. All rights reserved. * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -37,33 +37,30 @@ * this sample code. */ - /* * This function uses new Swing Desktop API in JDK 6. * To use this with scriptpad, open this in scriptpad * and use "Tools->Run Script" menu. */ function browse() { - with (guiPkgs) { - var desktop = null; - // Before more Desktop API is used, first check - // whether the API is supported by this particular - // virtual machine (VM) on this particular host. - if (Desktop.isDesktopSupported()) { - desktop = Desktop.getDesktop(); - } else { - alert("no desktop support"); - return; + var desktop = null; + // Before more Desktop API is used, first check + // whether the API is supported by this particular + // virtual machine (VM) on this particular host. + if (java.awt.Desktop.isDesktopSupported()) { + desktop = java.awt.Desktop.getDesktop(); + } else { + alert("no desktop support"); + return; + } + + if (desktop.isSupported(java.awt.Desktop.Action.BROWSE)) { + var url = prompt("Address:"); + if (url != null) { + desktop.browse(new java.net.URI(url)); } - - if (desktop.isSupported(Desktop.Action.BROWSE)) { - var url = prompt("Address:"); - if (url != null) { - desktop.browse(new java.net.URI(url)); - } - } else { - alert("no browser support"); - } + } else { + alert("no browser support"); } } @@ -71,4 +68,3 @@ // add "Browse" menu item under "Tools" menu this.application.addTool("Browse", browse); } - diff --git a/src/share/sample/scripting/scriptpad/src/scripts/insertfile.js b/src/share/sample/scripting/scriptpad/src/scripts/insertfile.js --- a/src/share/sample/scripting/scriptpad/src/scripts/insertfile.js +++ b/src/share/sample/scripting/scriptpad/src/scripts/insertfile.js @@ -1,5 +1,5 @@ /* - * Copyright (c) 2006, 2011, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2006, 2013, Oracle and/or its affiliates. All rights reserved. * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -37,7 +37,6 @@ * this sample code. */ - /* * This script adds "Insert File" mode menu item to "Tools" menu. * When selected, this menu shows a file dialog box and inserts @@ -48,18 +47,22 @@ application.addTool("Insert File...", function() { var file = fileDialog(); - if (file) { + + if (file) { var reader = new java.io.FileReader(file); var arr = java.lang.reflect.Array.newInstance( java.lang.Character.TYPE, 8*1024); // 8K at a time var buf = new java.lang.StringBuffer(); var numChars; + while ((numChars = reader.read(arr, 0, arr.length)) > 0) { buf.append(arr, 0, numChars); } + var pos = application.editor.caretPosition; var doc = application.editor.document; + doc.insertString(pos, buf.toString(), null); } - }) + }); } diff --git a/src/share/sample/scripting/scriptpad/src/scripts/linewrap.js b/src/share/sample/scripting/scriptpad/src/scripts/linewrap.js --- a/src/share/sample/scripting/scriptpad/src/scripts/linewrap.js +++ b/src/share/sample/scripting/scriptpad/src/scripts/linewrap.js @@ -1,5 +1,5 @@ /* - * Copyright (c) 2006, 2011, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2006, 2013, Oracle and/or its affiliates. All rights reserved. * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -37,19 +37,15 @@ * this sample code. */ - /* * This script adds "Line Wrap" mode menu item to "Tools" menu. * When selected, this menu toggles the current word wrap mode * of the editor. */ -with (guiPkgs) { - function toggleLineWrap() { - var wrap = application.editor.lineWrap; - application.editor.lineWrap = !wrap; - } - - application.addTool("Line Wrap", toggleLineWrap); +function toggleLineWrap() { + var wrap = application.editor.lineWrap; + application.editor.lineWrap = !wrap; } +application.addTool("Line Wrap", toggleLineWrap); diff --git a/src/share/sample/scripting/scriptpad/src/scripts/mail.js b/src/share/sample/scripting/scriptpad/src/scripts/mail.js --- a/src/share/sample/scripting/scriptpad/src/scripts/mail.js +++ b/src/share/sample/scripting/scriptpad/src/scripts/mail.js @@ -1,5 +1,5 @@ /* - * Copyright (c) 2006, 2011, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2006, 2013, Oracle and/or its affiliates. All rights reserved. * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -37,30 +37,27 @@ * this sample code. */ - /* * This function uses new Swing Desktop API in JDK 6. * To use this with scriptpad, open this in scriptpad * and use "Tools->Run Script" menu. */ function mail() { - with (guiPkgs) { - var desktop = null; - // Before more Desktop API is used, first check - // whether the API is supported by this particular - // virtual machine (VM) on this particular host. - if (Desktop.isDesktopSupported()) { - desktop = Desktop.getDesktop(); - } else { - alert("no desktop support"); - return; - } + var desktop = null; + // Before more Desktop API is used, first check + // whether the API is supported by this particular + // virtual machine (VM) on this particular host. + if (java.awt.Desktop.isDesktopSupported()) { + desktop = java.awt.Desktop.getDesktop(); + } else { + alert("no desktop support"); + return; + } - if (desktop.isSupported(Desktop.Action.MAIL)) { - var mailTo = prompt("Mail To:"); - if (mailTo != null) { - desktop.mail(new java.net.URI("mailto", mailTo, null)); - } + if (desktop.isSupported(java.awt.Desktop.Action.MAIL)) { + var mailTo = prompt("Mail To:"); + if (mailTo != null) { + desktop.mail(new java.net.URI("mailto", mailTo, null)); } } } diff --git a/src/share/sample/scripting/scriptpad/src/scripts/memmonitor.js b/src/share/sample/scripting/scriptpad/src/scripts/memmonitor.js --- a/src/share/sample/scripting/scriptpad/src/scripts/memmonitor.js +++ b/src/share/sample/scripting/scriptpad/src/scripts/memmonitor.js @@ -1,5 +1,5 @@ /* - * Copyright (c) 2006, 2011, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2006, 2013, Oracle and/or its affiliates. All rights reserved. * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -37,36 +37,37 @@ * this sample code. */ - // this checker function runs asynchronously function memoryChecker(memoryBean, threshold, interval) { while (true) { var memUsage = memoryBean.HeapMemoryUsage; var usage = memUsage.get("used") / (1024 * 1024); - println(usage); + + println("usage: " + usage); + if (usage > threshold) { alert("Hey! heap usage threshold exceeded!"); // after first alert just return. return; } - java.lang.Thread.currentThread().sleep(interval); + + java.lang.Thread.sleep(interval); } } - // add "Tools->Memory Monitor" menu item if (this.application != undefined) { - this.application.addTool("Memory Monitor", + this.application.addTool("Memory Monitor", function () { // show threshold box with default of 50 MB var threshold = prompt("Threshold (mb)", 50); + // show interval box with default of 1000 millisec. var interval = prompt("Sample Interval (ms):", 1000); var memoryBean = mbean("java.lang:type=Memory"); - // ".future" makes the function to be called + // ".future" makes the function to be called // asynchronously in a separate thread. memoryChecker.future(memoryBean, threshold, interval); }); } - diff --git a/src/share/sample/scripting/scriptpad/src/scripts/memory.js b/src/share/sample/scripting/scriptpad/src/scripts/memory.js --- a/src/share/sample/scripting/scriptpad/src/scripts/memory.js +++ b/src/share/sample/scripting/scriptpad/src/scripts/memory.js @@ -1,5 +1,5 @@ /* - * Copyright (c) 2006, 2011, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2006, 2013, Oracle and/or its affiliates. All rights reserved. * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -37,7 +37,6 @@ * this sample code. */ - /* * This script serves as a simple "monitored application". * Start this script using memory.bat or memory.sh in the @@ -45,12 +44,11 @@ */ java.lang.System.out.print("Enter a number and press enter:"); -java.lang.System["in"].read(); +var input = java.lang.System["in"].read(); // allocate an integer array of "big enough" size! var a = java.lang.reflect.Array.newInstance( - java.lang.Integer.TYPE, 1024*1024); + java.lang.Integer.TYPE, input * 1024 * 1024); -// loop forever! -while (true); - +// sleep some time... +java.lang.Thread.sleep(10*60*1000); diff --git a/src/share/sample/scripting/scriptpad/src/scripts/memory.sh b/src/share/sample/scripting/scriptpad/src/scripts/memory.sh --- a/src/share/sample/scripting/scriptpad/src/scripts/memory.sh +++ b/src/share/sample/scripting/scriptpad/src/scripts/memory.sh @@ -30,7 +30,3 @@ # jrunscript -J-Dcom.sun.management.jmxremote.port=1090 -J-Dcom.sun.management.jmxremote.ssl=false -J-Dcom.sun.management.jmxremote.authenticate=false memory.js - - - - diff --git a/src/share/sample/scripting/scriptpad/src/scripts/textcolor.js b/src/share/sample/scripting/scriptpad/src/scripts/textcolor.js --- a/src/share/sample/scripting/scriptpad/src/scripts/textcolor.js +++ b/src/share/sample/scripting/scriptpad/src/scripts/textcolor.js @@ -1,5 +1,5 @@ /* - * Copyright (c) 2006, 2011, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2006, 2013, Oracle and/or its affiliates. All rights reserved. * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -37,14 +37,13 @@ * this sample code. */ - /* * This script adds "Selected Text Color" menu item to "Tools" menu. * When selected, this menu changes the "selected text" color. */ if (this.application) { application.addTool("Selected Text Color...", - function() { + function() { var color = application.editor.selectedTextColor; color = colorDialog("Selected Text Color", color); application.editor.selectedTextColor = color; From marcus.lagergren at oracle.com Thu Feb 28 10:19:36 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Thu, 28 Feb 2013 19:19:36 +0100 Subject: Review request for JDK-8009229: ant makefile default target should be "test" In-Reply-To: <512F7075.4040000@oracle.com> References: <512F7075.4040000@oracle.com> Message-ID: <5EA2C7E6-F6FE-49BD-BC01-9D409A7E8545@oracle.com> +1 On Feb 28, 2013, at 3:57 PM, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~sundar/8009229/ > > Thanks > -Sundar From hannes.wallnoefer at oracle.com Thu Feb 28 12:13:47 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Thu, 28 Feb 2013 21:13:47 +0100 Subject: Review request for JDK-8009240 Message-ID: <512FBA7B.4060207@oracle.com> Please review patch for JDK-8009240 - RegExpScanner code is inefficient and too complex. http://cr.openjdk.java.net/~hannesw/8009240/ This gets rid of the token tree in RegExpScanner and instead directly generates the rewritten regex. The code is more efficient now and I think it's also easier to understand. The generated regular expressions should be the same as before except for the case of the empty character class followed by a min-0 quantifier which isn't optimized away in the new version, mostly because I don't think this is really relevant for real code. I've tested with ant test, test262parallel and octane. Haven't run nodejar tests yet but will do so before I push. Hannes From james.laskey at oracle.com Thu Feb 28 12:31:50 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Thu, 28 Feb 2013 16:31:50 -0400 Subject: Review request for JDK-8009240 In-Reply-To: <512FBA7B.4060207@oracle.com> References: <512FBA7B.4060207@oracle.com> Message-ID: +1 That simplifies things. On 2013-02-28, at 4:13 PM, Hannes Wallnoefer wrote: > Please review patch for JDK-8009240 - RegExpScanner code is inefficient and too complex. > > http://cr.openjdk.java.net/~hannesw/8009240/ > > This gets rid of the token tree in RegExpScanner and instead directly generates the rewritten regex. The code is more efficient now and I think it's also easier to understand. > > The generated regular expressions should be the same as before except for the case of the empty character class followed by a min-0 quantifier which isn't optimized away in the new version, mostly because I don't think this is really relevant for real code. > > I've tested with ant test, test262parallel and octane. Haven't run nodejar tests yet but will do so before I push. > > Hannes From marcus.lagergren at oracle.com Thu Feb 28 12:46:32 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Thu, 28 Feb 2013 21:46:32 +0100 Subject: Review request for JDK-8009240 In-Reply-To: <512FBA7B.4060207@oracle.com> References: <512FBA7B.4060207@oracle.com> Message-ID: <05817A46-FB45-439B-A339-8F46A57576EA@oracle.com> +1. Love it. /M On Feb 28, 2013, at 9:13 PM, Hannes Wallnoefer wrote: > Please review patch for JDK-8009240 - RegExpScanner code is inefficient and too complex. > > http://cr.openjdk.java.net/~hannesw/8009240/ > > This gets rid of the token tree in RegExpScanner and instead directly generates the rewritten regex. The code is more efficient now and I think it's also easier to understand. > > The generated regular expressions should be the same as before except for the case of the empty character class followed by a min-0 quantifier which isn't optimized away in the new version, mostly because I don't think this is really relevant for real code. > > I've tested with ant test, test262parallel and octane. Haven't run nodejar tests yet but will do so before I push. > > Hannes From hannes.wallnoefer at oracle.com Thu Feb 28 14:00:20 2013 From: hannes.wallnoefer at oracle.com (hannes.wallnoefer at oracle.com) Date: Thu, 28 Feb 2013 22:00:20 +0000 Subject: hg: nashorn/jdk8/nashorn: 8009240: RegExpScanner code is inefficient and too complex Message-ID: <20130228220022.D2AD6474D2@hg.openjdk.java.net> Changeset: 037e1de7ab1a Author: hannesw Date: 2013-02-28 22:59 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/037e1de7ab1a 8009240: RegExpScanner code is inefficient and too complex Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/internal/runtime/regexp/JoniRegExp.java ! src/jdk/nashorn/internal/runtime/regexp/RegExpFactory.java ! src/jdk/nashorn/internal/runtime/regexp/RegExpScanner.java From sundararajan.athijegannathan at oracle.com Thu Feb 28 21:16:14 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Fri, 01 Mar 2013 10:46:14 +0530 Subject: Please review fix for JDK-8009263: Fix all javadoc errors in nashorn code Message-ID: <5130399E.3030001@oracle.com> Please review http://cr.openjdk.java.net/~sundar/8009263/ Thanks -Sundar From marcus.lagergren at oracle.com Thu Feb 28 22:48:51 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Fri, 1 Mar 2013 07:48:51 +0100 Subject: Please review fix for JDK-8009263: Fix all javadoc errors in nashorn code In-Reply-To: <5130399E.3030001@oracle.com> References: <5130399E.3030001@oracle.com> Message-ID: <81F86DAD-A756-4FDF-9B33-5790EC7E95BE@oracle.com> +1 On Mar 1, 2013, at 6:16 AM, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~sundar/8009263/ > > Thanks > -Sundar