Review request JDK-8007452: add scripting programmers doc changes for nashorn

A. Sundararajan sundararajan.athijegannathan at oracle.com
Mon Feb 4 19:36:36 PST 2013


Hi,

Incorporated these changes and uploaded updated webrev for historical 
purpose.
http://cr.openjdk.java.net/~sundar/8007452/webrev.01/

Thanks
-Sundar


On Monday 04 February 2013 08:17 PM, Hannes Wallnoefer wrote:
> Nice docs and examples! A few notes below.
>
> - There's a bit of overlap between the treatment of abstract classes 
> in "Accessing Java Classes" and the "Implementing Java Interfaces" 
> section further down. These concepts are very similar, maybe they 
> should be treated together (or next to each other)?
>
> - These two sentences seem redundant: "Multiple scopes are supported 
> by |javax.script.ScriptContext| interface. A script context supports 
> one or more scopes with associated Bindings for each scope."  Maybe 
> combine to something like "The |javax.script.ScriptContext| interface 
> supports multiple scopes with associated Bindings for each scope."
>
> - I think the following comment (contained twice) should have an "it"  
> near the end ("implements it or not"):
> |         //|javax.script.Invocable|  is an optional interface.
>          // Check whether your script engine implements or not!|
>
> Hannes
>
>
> Am 2013-02-04 12:44, schrieb A. Sundararajan:
>> Please review http://cr.openjdk.java.net/~sundar/8007452/
>>
>> Thanks
>> -Sundar
>



More information about the nashorn-dev mailing list