Review request JDK-8008387: Improve code coverage tests for JSObjectLinker and NashornBottomLinker

Attila Szegedi attila.szegedi at oracle.com
Mon Feb 18 07:07:44 PST 2013


+1 for the technical content of the changes.

From administrative point of view, a minor problem is that I can't incorporate changes into Dynalink source files on GitHub unless you sign a Contributor License Agreement for Dynalink with me. I'm not saying I insist on a CLA, just stating the fact that without it I can't move any other person's contribution into the GitHub Dynalink, otherwise it jeopardizes my ability to continue offering it under the Apache license. So we'll end up with diverging codebases.

Asking me to implement whatever changes are needed, explained in English prose, is an alternative way around the issue :-)

Attila.

On Feb 18, 2013, at 3:36 PM, A. Sundararajan <sundararajan.athijegannathan at oracle.com> wrote:

> Please review http://cr.openjdk.java.net/~sundar/8008387/
> 
> Thanks
> -Sundar



More information about the nashorn-dev mailing list