Please review JDK-8007002

Attila Szegedi attila.szegedi at oracle.com
Fri Feb 22 02:37:57 PST 2013


Rename back isBuiltTypeError to isBuiltinTypeError, and throw new AssertionError(e) in asEcmaException default case.

Other than these two, remarks, +1.

On Feb 22, 2013, at 11:24 AM, Hannes Wallnoefer <hannes.wallnoefer at oracle.com> wrote:

> Much nicer this way - +1.
> 
> Hannes
> 
> Am 2013-02-22 11:01, schrieb Marcus Lagergren:
>> For control flow reasons, we should let the various error throwing functions return the error to be thrown rather than throwing it in a sub function. Got rid of a lot of nonsense return points and warnings in all IDEs.
>> 
>> Discussed with Attila previously.
>> 
>> http://cr.openjdk.java.net/~lagergren/8007002/
>> 
>> Test and Test262 pass.
>> 
>> /M
>> 
> 



More information about the nashorn-dev mailing list