Review request for JDK-8008093

Attila Szegedi attila.szegedi at oracle.com
Fri Feb 22 02:44:42 PST 2013


Looks good to me. I like how having two implementations cleaned up the architecture :-). Also, it's a bit scary how you still needed this much plumbing around 'em - must've been quite a job to get through all of this.

I'm fairly sure you need to add an Oracle copyright notice to all Joni files; see how I added one to Dynalink files.

On Feb 21, 2013, at 4:22 PM, Hannes Wallnoefer <hannes.wallnoefer at oracle.com> wrote:

> Please review patch for JDK-8008093 - Make RegExp engine pluggable:
> 
> http://cr.openjdk.java.net/~hannesw/8008093/webrev.01/
> 
> This makes regexp engine configurable via system property and adds the Joni engine from JRuby.
> 
> Hannes



More information about the nashorn-dev mailing list