Review request for JDK-8008093

[Hannes Wallnoefer]

One more note: I split this patch up in two commits to make it use the 
appropriate bug-ids and messages. I uploaded the new / final webrevs:

http://cr.openjdk.java.net/~hannesw/8008093/webrev.03/
http://cr.openjdk.java.net/~hannesw/8006028/webrev.01/

These webrevs together are identical to the patch already reviewed by 
Marcus and Attila so committed them without further review.

Hannes

Am 2013-02-22 14:53, schrieb Hannes Wallnoefer:
> I uploaded a new webrev to 
> http://cr.openjdk.java.net/~hannesw/8008093/webrev.02/ with the 
> following changes:
>
>  - Added missing final declarations
>  - Added missing Javadoc
>  - Added licence to THIRD_PARTY_README
>
> As for the Joni license headers, I followed Jim's advice: 1) existing 
> work keeps its copyright notice, 2) new/original work gets GPLv2+CP, 
> 3) Insert an entry for JONI in THIRD_PARTY_README which includes the 
> full text of the licence.
>
> Hannes
>
> Am 2013-02-22 11:44, schrieb Attila Szegedi:
>> Looks good to me. I like how having two implementations cleaned up 
>> the architecture :-). Also, it's a bit scary how you still needed 
>> this much plumbing around 'em - must've been quite a job to get 
>> through all of this.
>>
>> I'm fairly sure you need to add an Oracle copyright notice to all 
>> Joni files; see how I added one to Dynalink files.
>>
>> On Feb 21, 2013, at 4:22 PM, Hannes Wallnoefer 
>> <hannes.wallnoefer at oracle.com> wrote:
>>
>>> Please review patch for JDK-8008093 - Make RegExp engine pluggable:
>>>
>>> http://cr.openjdk.java.net/~hannesw/8008093/webrev.01/
>>>
>>> This makes regexp engine configurable via system property and adds 
>>> the Joni engine from JRuby.
>>>
>>> Hannes
>