From james.laskey at oracle.com Thu Jan 3 08:34:45 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Thu, 3 Jan 2013 12:34:45 -0400 Subject: Review Request: 8005663 Update copyright year to 2013 Message-ID: http://cr.openjdk.java.net/~jlaskey/8005663/webrev.zip From james.laskey at oracle.com Thu Jan 3 08:55:22 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Thu, 3 Jan 2013 12:55:22 -0400 Subject: Review request: 8005665: JavaDoc should only display public interfaces Message-ID: http://cr.openjdk.java.net/~jlaskey/8005665/webrev/index.html From james.laskey at oracle.com Thu Jan 3 09:14:03 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Thu, 3 Jan 2013 13:14:03 -0400 Subject: Review Request: 8005666: Add webrev to .hgignore Message-ID: <7DA03B89-7B8F-4868-99FD-10B29C37ACB9@oracle.com> http://cr.openjdk.java.net/~jlaskey/8005666/webrev/index.html From sundararajan.athijegannathan at oracle.com Thu Jan 3 20:14:36 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Fri, 04 Jan 2013 09:44:36 +0530 Subject: Review Request: 8005666: Add webrev to .hgignore In-Reply-To: <7DA03B89-7B8F-4868-99FD-10B29C37ACB9@oracle.com> References: <7DA03B89-7B8F-4868-99FD-10B29C37ACB9@oracle.com> Message-ID: <50E6572C.4010304@oracle.com> Looks good. -Sundar Jim Laskey (Oracle) wrote: > http://cr.openjdk.java.net/~jlaskey/8005666/webrev/index.html > > From sundararajan.athijegannathan at oracle.com Thu Jan 3 20:15:26 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Fri, 04 Jan 2013 09:45:26 +0530 Subject: Review request: 8005665: JavaDoc should only display public interfaces In-Reply-To: References: Message-ID: <50E6575E.3020706@oracle.com> Looks good. -Sundar Jim Laskey (Oracle) wrote: > http://cr.openjdk.java.net/~jlaskey/8005665/webrev/index.html > > From sundararajan.athijegannathan at oracle.com Thu Jan 3 20:20:27 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Fri, 04 Jan 2013 09:50:27 +0530 Subject: Review Request: 8005663 Update copyright year to 2013 In-Reply-To: References: Message-ID: <50E6588B.7070809@oracle.com> Looks good. -Sundar Jim Laskey (Oracle) wrote: > http://cr.openjdk.java.net/~jlaskey/8005663/webrev.zip > > From james.laskey at oracle.com Fri Jan 4 06:02:37 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Fri, 04 Jan 2013 14:02:37 +0000 Subject: hg: nashorn/jdk8/nashorn: 3 new changesets Message-ID: <20130104140239.95DD547557@hg.openjdk.java.net> Changeset: 3a7e1580bc0a Author: jlaskey Date: 2013-01-04 09:58 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/3a7e1580bc0a 8005666: Add webrev to .hgignore Reviewed-by: sundar Contributed-by: james.laskey at oracle.com ! .hgignore Changeset: c6e194450af7 Author: jlaskey Date: 2013-01-04 09:58 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/c6e194450af7 8005665: JavaDoc should only display public interfaces Reviewed-by: sundar Contributed-by: james.laskey at oracle.com ! make/build.xml Changeset: 5a1b0714df0e Author: jlaskey Date: 2013-01-04 09:58 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/5a1b0714df0e 8005663: Update copyright year to 2013 Reviewed-by: sundar Contributed-by: james.laskey at oracle.com ! bin/checkintest.sh ! bin/fixorphantests.sh ! bin/fixwhitespace.sh ! bin/jjs ! bin/jjs.bat ! bin/jjssecure ! bin/jjssecure.bat ! bin/nashorn ! bin/nashorn.bat ! bin/rm-non-tracked.sh ! bin/verbose_octane.bat ! bin/verbose_octane.sh ! buildtools/nasgen/build.xml ! buildtools/nasgen/nasgen.iml ! buildtools/nasgen/project.properties ! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/ClassGenerator.java ! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/ConstructorGenerator.java ! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/Main.java ! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/MemberInfo.java ! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/MethodGenerator.java ! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/NullVisitor.java ! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/PrototypeGenerator.java ! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/ScriptClassInfo.java ! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/ScriptClassInfoCollector.java ! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/ScriptClassInstrumentor.java ! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/StringConstants.java ! docs/genshelldoc.js ! make/Makefile ! make/build-benchmark.xml ! make/build-nasgen.xml ! make/build.xml ! make/nbproject/ide-file-targets.xml ! make/nbproject/ide-targets.xml ! make/nbproject/jdk.xml ! make/nbproject/nbjdk.properties ! make/nbproject/nbjdk.xml ! make/nbproject/project.xml ! make/project.properties ! samples/counters.js ! samples/letter.js ! samples/parser.js ! samples/shell.js ! samples/test.js ! samples/uniq.js ! src/META-INF/services/javax.script.ScriptEngineFactory ! src/jdk/nashorn/api/scripting/NashornException.java ! src/jdk/nashorn/api/scripting/NashornScriptEngine.java ! src/jdk/nashorn/api/scripting/NashornScriptEngineFactory.java ! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java ! src/jdk/nashorn/api/scripting/package-info.java ! src/jdk/nashorn/api/scripting/resources/engine.js ! src/jdk/nashorn/internal/codegen/AccessSpecializer.java ! src/jdk/nashorn/internal/codegen/BranchOptimizer.java ! src/jdk/nashorn/internal/codegen/ClassEmitter.java ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/CompileUnit.java ! src/jdk/nashorn/internal/codegen/Compiler.java ! src/jdk/nashorn/internal/codegen/CompilerConstants.java ! src/jdk/nashorn/internal/codegen/ConstantData.java ! src/jdk/nashorn/internal/codegen/Emitter.java ! src/jdk/nashorn/internal/codegen/Frame.java ! src/jdk/nashorn/internal/codegen/FunctionSignature.java ! src/jdk/nashorn/internal/codegen/Lower.java ! src/jdk/nashorn/internal/codegen/MethodEmitter.java ! src/jdk/nashorn/internal/codegen/Namespace.java ! src/jdk/nashorn/internal/codegen/RuntimeCallSite.java ! src/jdk/nashorn/internal/codegen/SharedScopeCall.java ! src/jdk/nashorn/internal/codegen/Splitter.java ! src/jdk/nashorn/internal/codegen/Transform.java ! src/jdk/nashorn/internal/codegen/WeighNodes.java ! src/jdk/nashorn/internal/codegen/objects/FieldObjectCreator.java ! src/jdk/nashorn/internal/codegen/objects/FunctionObjectCreator.java ! src/jdk/nashorn/internal/codegen/objects/MapCreator.java ! src/jdk/nashorn/internal/codegen/objects/ObjectClassGenerator.java ! src/jdk/nashorn/internal/codegen/objects/ObjectCreator.java ! src/jdk/nashorn/internal/codegen/objects/ObjectMapCreator.java ! src/jdk/nashorn/internal/codegen/types/ArrayType.java ! src/jdk/nashorn/internal/codegen/types/BitwiseType.java ! src/jdk/nashorn/internal/codegen/types/BooleanType.java ! src/jdk/nashorn/internal/codegen/types/BytecodeArrayOps.java ! src/jdk/nashorn/internal/codegen/types/BytecodeBitwiseOps.java ! src/jdk/nashorn/internal/codegen/types/BytecodeNumericOps.java ! src/jdk/nashorn/internal/codegen/types/BytecodeOps.java ! src/jdk/nashorn/internal/codegen/types/IntType.java ! src/jdk/nashorn/internal/codegen/types/LongType.java ! src/jdk/nashorn/internal/codegen/types/NumberType.java ! src/jdk/nashorn/internal/codegen/types/NumericType.java ! src/jdk/nashorn/internal/codegen/types/ObjectType.java ! src/jdk/nashorn/internal/codegen/types/Type.java ! src/jdk/nashorn/internal/ir/AccessNode.java ! src/jdk/nashorn/internal/ir/Assignment.java ! src/jdk/nashorn/internal/ir/BaseNode.java ! src/jdk/nashorn/internal/ir/BinaryNode.java ! src/jdk/nashorn/internal/ir/Block.java ! src/jdk/nashorn/internal/ir/BreakNode.java ! src/jdk/nashorn/internal/ir/BreakableNode.java ! src/jdk/nashorn/internal/ir/CallNode.java ! src/jdk/nashorn/internal/ir/CaseNode.java ! src/jdk/nashorn/internal/ir/CatchNode.java ! src/jdk/nashorn/internal/ir/ContinueNode.java ! src/jdk/nashorn/internal/ir/DoWhileNode.java ! src/jdk/nashorn/internal/ir/EmptyNode.java ! src/jdk/nashorn/internal/ir/ExecuteNode.java ! src/jdk/nashorn/internal/ir/ForNode.java ! src/jdk/nashorn/internal/ir/FunctionCall.java ! src/jdk/nashorn/internal/ir/FunctionNode.java ! src/jdk/nashorn/internal/ir/IdentNode.java ! src/jdk/nashorn/internal/ir/IfNode.java ! src/jdk/nashorn/internal/ir/IndexNode.java ! src/jdk/nashorn/internal/ir/LabelNode.java ! src/jdk/nashorn/internal/ir/LabeledNode.java ! src/jdk/nashorn/internal/ir/LineNumberNode.java ! src/jdk/nashorn/internal/ir/LiteralNode.java ! src/jdk/nashorn/internal/ir/Location.java ! src/jdk/nashorn/internal/ir/Node.java ! src/jdk/nashorn/internal/ir/ObjectNode.java ! src/jdk/nashorn/internal/ir/PropertyKey.java ! src/jdk/nashorn/internal/ir/PropertyNode.java ! src/jdk/nashorn/internal/ir/ReferenceNode.java ! src/jdk/nashorn/internal/ir/ReturnNode.java ! src/jdk/nashorn/internal/ir/RuntimeNode.java ! src/jdk/nashorn/internal/ir/SplitNode.java ! src/jdk/nashorn/internal/ir/SwitchNode.java ! src/jdk/nashorn/internal/ir/Symbol.java ! src/jdk/nashorn/internal/ir/TernaryNode.java ! src/jdk/nashorn/internal/ir/ThrowNode.java ! src/jdk/nashorn/internal/ir/TryNode.java ! src/jdk/nashorn/internal/ir/TypeOverride.java ! src/jdk/nashorn/internal/ir/UnaryNode.java ! src/jdk/nashorn/internal/ir/VarNode.java ! src/jdk/nashorn/internal/ir/WhileNode.java ! src/jdk/nashorn/internal/ir/WithNode.java ! src/jdk/nashorn/internal/ir/annotations/ChildNode.java ! src/jdk/nashorn/internal/ir/annotations/Ignore.java ! src/jdk/nashorn/internal/ir/annotations/ParentNode.java ! src/jdk/nashorn/internal/ir/annotations/Reference.java ! src/jdk/nashorn/internal/ir/debug/ASTWriter.java ! src/jdk/nashorn/internal/ir/debug/JSONWriter.java ! src/jdk/nashorn/internal/ir/debug/PrintVisitor.java ! src/jdk/nashorn/internal/ir/visitor/NodeOperatorVisitor.java ! src/jdk/nashorn/internal/ir/visitor/NodeVisitor.java ! src/jdk/nashorn/internal/objects/AccessorPropertyDescriptor.java ! src/jdk/nashorn/internal/objects/ArrayBufferView.java ! src/jdk/nashorn/internal/objects/DataPropertyDescriptor.java ! src/jdk/nashorn/internal/objects/DateParser.java ! src/jdk/nashorn/internal/objects/GenericPropertyDescriptor.java ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/objects/NativeArguments.java ! src/jdk/nashorn/internal/objects/NativeArray.java ! src/jdk/nashorn/internal/objects/NativeArrayBuffer.java ! src/jdk/nashorn/internal/objects/NativeBoolean.java ! src/jdk/nashorn/internal/objects/NativeDate.java ! src/jdk/nashorn/internal/objects/NativeDebug.java ! src/jdk/nashorn/internal/objects/NativeError.java ! src/jdk/nashorn/internal/objects/NativeEvalError.java ! src/jdk/nashorn/internal/objects/NativeFloat32Array.java ! src/jdk/nashorn/internal/objects/NativeFloat64Array.java ! src/jdk/nashorn/internal/objects/NativeFunction.java ! src/jdk/nashorn/internal/objects/NativeInt16Array.java ! src/jdk/nashorn/internal/objects/NativeInt32Array.java ! src/jdk/nashorn/internal/objects/NativeInt8Array.java ! src/jdk/nashorn/internal/objects/NativeJSAdapter.java ! src/jdk/nashorn/internal/objects/NativeJSON.java ! src/jdk/nashorn/internal/objects/NativeJava.java ! src/jdk/nashorn/internal/objects/NativeJavaImporter.java ! src/jdk/nashorn/internal/objects/NativeMath.java ! src/jdk/nashorn/internal/objects/NativeNumber.java ! src/jdk/nashorn/internal/objects/NativeObject.java ! src/jdk/nashorn/internal/objects/NativeRangeError.java ! src/jdk/nashorn/internal/objects/NativeReferenceError.java ! src/jdk/nashorn/internal/objects/NativeRegExp.java ! src/jdk/nashorn/internal/objects/NativeRegExpExecResult.java ! src/jdk/nashorn/internal/objects/NativeStrictArguments.java ! src/jdk/nashorn/internal/objects/NativeString.java ! src/jdk/nashorn/internal/objects/NativeSyntaxError.java ! src/jdk/nashorn/internal/objects/NativeTypeError.java ! src/jdk/nashorn/internal/objects/NativeURIError.java ! src/jdk/nashorn/internal/objects/NativeUint16Array.java ! src/jdk/nashorn/internal/objects/NativeUint32Array.java ! src/jdk/nashorn/internal/objects/NativeUint8Array.java ! src/jdk/nashorn/internal/objects/NativeUint8ClampedArray.java ! src/jdk/nashorn/internal/objects/PrototypeObject.java ! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java ! src/jdk/nashorn/internal/objects/annotations/Attribute.java ! src/jdk/nashorn/internal/objects/annotations/Constructor.java ! src/jdk/nashorn/internal/objects/annotations/Function.java ! src/jdk/nashorn/internal/objects/annotations/Getter.java ! src/jdk/nashorn/internal/objects/annotations/Property.java ! src/jdk/nashorn/internal/objects/annotations/ScriptClass.java ! src/jdk/nashorn/internal/objects/annotations/Setter.java ! src/jdk/nashorn/internal/objects/annotations/SpecializedConstructor.java ! src/jdk/nashorn/internal/objects/annotations/SpecializedFunction.java ! src/jdk/nashorn/internal/objects/annotations/Where.java ! src/jdk/nashorn/internal/objects/package-info.java ! src/jdk/nashorn/internal/parser/AbstractParser.java ! src/jdk/nashorn/internal/parser/JSONParser.java ! src/jdk/nashorn/internal/parser/Lexer.java ! src/jdk/nashorn/internal/parser/Parser.java ! src/jdk/nashorn/internal/parser/RegExp.java ! src/jdk/nashorn/internal/parser/RegExpScanner.java ! src/jdk/nashorn/internal/parser/Scanner.java ! src/jdk/nashorn/internal/parser/Token.java ! src/jdk/nashorn/internal/parser/TokenKind.java ! src/jdk/nashorn/internal/parser/TokenLookup.java ! src/jdk/nashorn/internal/parser/TokenStream.java ! src/jdk/nashorn/internal/parser/TokenType.java ! src/jdk/nashorn/internal/runtime/AccessorProperty.java ! src/jdk/nashorn/internal/runtime/BitVector.java ! src/jdk/nashorn/internal/runtime/CodeInstaller.java ! src/jdk/nashorn/internal/runtime/ConsString.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/Debug.java ! src/jdk/nashorn/internal/runtime/DebugLogger.java ! src/jdk/nashorn/internal/runtime/DefaultPropertyAccess.java ! src/jdk/nashorn/internal/runtime/ECMAErrors.java ! src/jdk/nashorn/internal/runtime/ECMAException.java ! src/jdk/nashorn/internal/runtime/ErrorManager.java ! src/jdk/nashorn/internal/runtime/FindProperty.java ! src/jdk/nashorn/internal/runtime/FunctionScope.java ! src/jdk/nashorn/internal/runtime/GlobalFunctions.java ! src/jdk/nashorn/internal/runtime/GlobalObject.java ! src/jdk/nashorn/internal/runtime/JSErrorType.java ! src/jdk/nashorn/internal/runtime/JSType.java ! src/jdk/nashorn/internal/runtime/Logging.java ! src/jdk/nashorn/internal/runtime/NashornLoader.java ! src/jdk/nashorn/internal/runtime/NativeJavaPackage.java ! src/jdk/nashorn/internal/runtime/NumberToString.java ! src/jdk/nashorn/internal/runtime/ParserException.java ! src/jdk/nashorn/internal/runtime/Property.java ! src/jdk/nashorn/internal/runtime/PropertyAccess.java ! src/jdk/nashorn/internal/runtime/PropertyDescriptor.java ! src/jdk/nashorn/internal/runtime/PropertyHashMap.java ! src/jdk/nashorn/internal/runtime/PropertyListener.java ! src/jdk/nashorn/internal/runtime/PropertyListenerManager.java ! src/jdk/nashorn/internal/runtime/PropertyMap.java ! src/jdk/nashorn/internal/runtime/QuotedStringTokenizer.java ! src/jdk/nashorn/internal/runtime/RegExpMatch.java ! src/jdk/nashorn/internal/runtime/Scope.java ! src/jdk/nashorn/internal/runtime/ScriptFunction.java ! src/jdk/nashorn/internal/runtime/ScriptLoader.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/ScriptRuntime.java ! src/jdk/nashorn/internal/runtime/ScriptingFunctions.java ! src/jdk/nashorn/internal/runtime/Source.java ! src/jdk/nashorn/internal/runtime/SpillProperty.java ! src/jdk/nashorn/internal/runtime/StructureLoader.java ! src/jdk/nashorn/internal/runtime/URIUtils.java ! src/jdk/nashorn/internal/runtime/Undefined.java ! src/jdk/nashorn/internal/runtime/UserAccessorProperty.java ! src/jdk/nashorn/internal/runtime/Version.java ! src/jdk/nashorn/internal/runtime/WithObject.java ! src/jdk/nashorn/internal/runtime/arrays/ArrayData.java ! src/jdk/nashorn/internal/runtime/arrays/ArrayFilter.java ! src/jdk/nashorn/internal/runtime/arrays/ArrayIndex.java ! src/jdk/nashorn/internal/runtime/arrays/ArrayIterator.java ! src/jdk/nashorn/internal/runtime/arrays/ArrayLikeIterator.java ! src/jdk/nashorn/internal/runtime/arrays/DeletedArrayFilter.java ! src/jdk/nashorn/internal/runtime/arrays/DeletedRangeArrayFilter.java ! src/jdk/nashorn/internal/runtime/arrays/EmptyArrayLikeIterator.java ! src/jdk/nashorn/internal/runtime/arrays/FrozenArrayFilter.java ! src/jdk/nashorn/internal/runtime/arrays/IntArrayData.java ! src/jdk/nashorn/internal/runtime/arrays/InvalidArrayIndexException.java ! src/jdk/nashorn/internal/runtime/arrays/IteratorAction.java ! src/jdk/nashorn/internal/runtime/arrays/LongArrayData.java ! src/jdk/nashorn/internal/runtime/arrays/MapIterator.java ! src/jdk/nashorn/internal/runtime/arrays/NoTypeArrayData.java ! src/jdk/nashorn/internal/runtime/arrays/NumberArrayData.java ! src/jdk/nashorn/internal/runtime/arrays/ObjectArrayData.java ! src/jdk/nashorn/internal/runtime/arrays/ReverseArrayIterator.java ! src/jdk/nashorn/internal/runtime/arrays/ReverseMapIterator.java ! src/jdk/nashorn/internal/runtime/arrays/SealedArrayFilter.java ! src/jdk/nashorn/internal/runtime/arrays/SparseArrayData.java ! src/jdk/nashorn/internal/runtime/arrays/UndefinedArrayFilter.java ! src/jdk/nashorn/internal/runtime/linker/Bootstrap.java ! src/jdk/nashorn/internal/runtime/linker/InvokeByName.java ! src/jdk/nashorn/internal/runtime/linker/JSObjectLinker.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java ! src/jdk/nashorn/internal/runtime/linker/JavaArgumentConverters.java ! src/jdk/nashorn/internal/runtime/linker/LinkerCallSite.java ! src/jdk/nashorn/internal/runtime/linker/Lookup.java ! src/jdk/nashorn/internal/runtime/linker/Mangler.java ! src/jdk/nashorn/internal/runtime/linker/MethodHandleFactory.java ! src/jdk/nashorn/internal/runtime/linker/MethodHandleFunctionality.java ! src/jdk/nashorn/internal/runtime/linker/NashornBottomLinker.java ! src/jdk/nashorn/internal/runtime/linker/NashornCallSiteDescriptor.java ! src/jdk/nashorn/internal/runtime/linker/NashornGuardedInvocation.java ! src/jdk/nashorn/internal/runtime/linker/NashornGuards.java ! src/jdk/nashorn/internal/runtime/linker/NashornLinker.java ! src/jdk/nashorn/internal/runtime/linker/NashornPrimitiveLinker.java ! src/jdk/nashorn/internal/runtime/linker/PrimitiveLookup.java ! src/jdk/nashorn/internal/runtime/options/KeyValueOption.java ! src/jdk/nashorn/internal/runtime/options/Option.java ! src/jdk/nashorn/internal/runtime/options/OptionTemplate.java ! src/jdk/nashorn/internal/runtime/options/Options.java ! src/jdk/nashorn/internal/runtime/options/ValueOption.java ! src/jdk/nashorn/internal/runtime/resources/Messages.properties ! src/jdk/nashorn/internal/runtime/resources/Options.properties ! src/jdk/nashorn/internal/runtime/resources/mozilla_compat.js ! src/jdk/nashorn/internal/runtime/resources/parser.js ! src/jdk/nashorn/internal/runtime/resources/version.properties-template ! src/jdk/nashorn/internal/scripts/JO$.java ! src/jdk/nashorn/internal/scripts/JS$.java ! src/jdk/nashorn/tools/Shell.java ! src/jdk/nashorn/tools/resources/Shell.properties ! src/jdk/nashorn/tools/resources/shell.js ! src/netscape/javascript/JSObject.java ! src/overview.html ! test/examples/dual-fields-micro.js ! test/examples/innerbench.js ! test/examples/typechain.js ! test/lib/benchmark.js ! test/opt/add.js ! test/opt/add_constant.js ! test/opt/add_reuse_callsite.js ! test/opt/add_revert2.js ! test/opt/cascade_specialize.js ! test/script/assert.js ! test/script/basic/NASHORN-100.js ! test/script/basic/NASHORN-101.js ! test/script/basic/NASHORN-102.js ! test/script/basic/NASHORN-103.js ! test/script/basic/NASHORN-104.js ! test/script/basic/NASHORN-105.js ! test/script/basic/NASHORN-106.js ! test/script/basic/NASHORN-107.js ! test/script/basic/NASHORN-108.js ! test/script/basic/NASHORN-109.js ! test/script/basic/NASHORN-11.js ! test/script/basic/NASHORN-111.js ! test/script/basic/NASHORN-113.js ! test/script/basic/NASHORN-114.js ! test/script/basic/NASHORN-115.js ! test/script/basic/NASHORN-117.js ! test/script/basic/NASHORN-118.js ! test/script/basic/NASHORN-119.js ! test/script/basic/NASHORN-12.js ! test/script/basic/NASHORN-120.js ! test/script/basic/NASHORN-122.js ! test/script/basic/NASHORN-126.js ! test/script/basic/NASHORN-127.js ! test/script/basic/NASHORN-130.js ! test/script/basic/NASHORN-132.js ! test/script/basic/NASHORN-133.js ! test/script/basic/NASHORN-135.js ! test/script/basic/NASHORN-136.js ! test/script/basic/NASHORN-14.js ! test/script/basic/NASHORN-148.js ! test/script/basic/NASHORN-15.js ! test/script/basic/NASHORN-153.js ! test/script/basic/NASHORN-156.js ! test/script/basic/NASHORN-157.js ! test/script/basic/NASHORN-163.js ! test/script/basic/NASHORN-164.js ! test/script/basic/NASHORN-165.js ! test/script/basic/NASHORN-166.js ! test/script/basic/NASHORN-168.js ! test/script/basic/NASHORN-169.js ! test/script/basic/NASHORN-172.js ! test/script/basic/NASHORN-173.js ! test/script/basic/NASHORN-174.js ! test/script/basic/NASHORN-175.js ! test/script/basic/NASHORN-176.js ! test/script/basic/NASHORN-177.js ! test/script/basic/NASHORN-178.js ! test/script/basic/NASHORN-179.js ! test/script/basic/NASHORN-18.js ! test/script/basic/NASHORN-181.js ! test/script/basic/NASHORN-182.js ! test/script/basic/NASHORN-183.js ! test/script/basic/NASHORN-184.js ! test/script/basic/NASHORN-185.js ! test/script/basic/NASHORN-187.js ! test/script/basic/NASHORN-188.js ! test/script/basic/NASHORN-19.js ! test/script/basic/NASHORN-190.js ! test/script/basic/NASHORN-192.js ! test/script/basic/NASHORN-194.js ! test/script/basic/NASHORN-196.js ! test/script/basic/NASHORN-198.js ! test/script/basic/NASHORN-20.js ! test/script/basic/NASHORN-201.js ! test/script/basic/NASHORN-202.js ! test/script/basic/NASHORN-203.js ! test/script/basic/NASHORN-204.js ! test/script/basic/NASHORN-205.js ! test/script/basic/NASHORN-206.js ! test/script/basic/NASHORN-207.js ! test/script/basic/NASHORN-207_2.js ! test/script/basic/NASHORN-208.js ! test/script/basic/NASHORN-209.js ! test/script/basic/NASHORN-21.js ! test/script/basic/NASHORN-211.js ! test/script/basic/NASHORN-212.js ! test/script/basic/NASHORN-213.js ! test/script/basic/NASHORN-215.js ! test/script/basic/NASHORN-216.js ! test/script/basic/NASHORN-217.js ! test/script/basic/NASHORN-219.js ! test/script/basic/NASHORN-22.js ! test/script/basic/NASHORN-221.js ! test/script/basic/NASHORN-222.js ! test/script/basic/NASHORN-223.js ! test/script/basic/NASHORN-225.js ! test/script/basic/NASHORN-226.js ! test/script/basic/NASHORN-227.js ! test/script/basic/NASHORN-228.js ! test/script/basic/NASHORN-229.js ! test/script/basic/NASHORN-229_subtest.js ! test/script/basic/NASHORN-23.js ! test/script/basic/NASHORN-232.js ! test/script/basic/NASHORN-234.js ! test/script/basic/NASHORN-235.js ! test/script/basic/NASHORN-236.js ! test/script/basic/NASHORN-237.js ! test/script/basic/NASHORN-239.js ! test/script/basic/NASHORN-24.js ! test/script/basic/NASHORN-241.js ! test/script/basic/NASHORN-242.js ! test/script/basic/NASHORN-245.js ! test/script/basic/NASHORN-247.js ! test/script/basic/NASHORN-25.js ! test/script/basic/NASHORN-251.js ! test/script/basic/NASHORN-252.js ! test/script/basic/NASHORN-253.js ! test/script/basic/NASHORN-256.js ! test/script/basic/NASHORN-258.js ! test/script/basic/NASHORN-26.js ! test/script/basic/NASHORN-260.js ! test/script/basic/NASHORN-261.js ! test/script/basic/NASHORN-262.js ! test/script/basic/NASHORN-263.js ! test/script/basic/NASHORN-264.js ! test/script/basic/NASHORN-265.js ! test/script/basic/NASHORN-266.js ! test/script/basic/NASHORN-269.js ! test/script/basic/NASHORN-27.js ! test/script/basic/NASHORN-270.js ! test/script/basic/NASHORN-271.js ! test/script/basic/NASHORN-275.js ! test/script/basic/NASHORN-276.js ! test/script/basic/NASHORN-277.js ! test/script/basic/NASHORN-278.js ! test/script/basic/NASHORN-28.js ! test/script/basic/NASHORN-281.js ! test/script/basic/NASHORN-284.js ! test/script/basic/NASHORN-285.js ! test/script/basic/NASHORN-288.js ! test/script/basic/NASHORN-29.js ! test/script/basic/NASHORN-293.js ! test/script/basic/NASHORN-294.js ! test/script/basic/NASHORN-296.js ! test/script/basic/NASHORN-297.js ! test/script/basic/NASHORN-30.js ! test/script/basic/NASHORN-300.js ! test/script/basic/NASHORN-301.js ! test/script/basic/NASHORN-304.js ! test/script/basic/NASHORN-310.js ! test/script/basic/NASHORN-318.js ! test/script/basic/NASHORN-32.js ! test/script/basic/NASHORN-321.js ! test/script/basic/NASHORN-323.js ! test/script/basic/NASHORN-324.js ! test/script/basic/NASHORN-33.js ! test/script/basic/NASHORN-331.js ! test/script/basic/NASHORN-337.js ! test/script/basic/NASHORN-34.js ! test/script/basic/NASHORN-340.js ! test/script/basic/NASHORN-349.js ! test/script/basic/NASHORN-354.js ! test/script/basic/NASHORN-355.js ! test/script/basic/NASHORN-36.js ! test/script/basic/NASHORN-365.js ! test/script/basic/NASHORN-366.js ! test/script/basic/NASHORN-368.js ! test/script/basic/NASHORN-37.js ! test/script/basic/NASHORN-375.js ! test/script/basic/NASHORN-376.js ! test/script/basic/NASHORN-377.js ! test/script/basic/NASHORN-378.js ! test/script/basic/NASHORN-38.js ! test/script/basic/NASHORN-380.js ! test/script/basic/NASHORN-381.js ! test/script/basic/NASHORN-382.js ! test/script/basic/NASHORN-383.js ! test/script/basic/NASHORN-384.js ! test/script/basic/NASHORN-385.js ! test/script/basic/NASHORN-389.js ! test/script/basic/NASHORN-393.js ! test/script/basic/NASHORN-394.js ! test/script/basic/NASHORN-396.js ! test/script/basic/NASHORN-397.js ! test/script/basic/NASHORN-398.js ! test/script/basic/NASHORN-40.js ! test/script/basic/NASHORN-400.js ! test/script/basic/NASHORN-401.js ! test/script/basic/NASHORN-402.js ! test/script/basic/NASHORN-404.js ! test/script/basic/NASHORN-405.js ! test/script/basic/NASHORN-406.js ! test/script/basic/NASHORN-408.js ! test/script/basic/NASHORN-415.js ! test/script/basic/NASHORN-416.js ! test/script/basic/NASHORN-417.js ! test/script/basic/NASHORN-418.js ! test/script/basic/NASHORN-420.js ! test/script/basic/NASHORN-421.js ! test/script/basic/NASHORN-423.js ! test/script/basic/NASHORN-423a.js ! test/script/basic/NASHORN-424.js ! test/script/basic/NASHORN-425.js ! test/script/basic/NASHORN-426.js ! test/script/basic/NASHORN-427.js ! test/script/basic/NASHORN-428.js ! test/script/basic/NASHORN-429.js ! test/script/basic/NASHORN-432.js ! test/script/basic/NASHORN-433.js ! test/script/basic/NASHORN-434.js ! test/script/basic/NASHORN-435.js ! test/script/basic/NASHORN-437.js ! test/script/basic/NASHORN-44.js ! test/script/basic/NASHORN-441.js ! test/script/basic/NASHORN-442.js ! test/script/basic/NASHORN-443.js ! test/script/basic/NASHORN-444.js ! test/script/basic/NASHORN-445.js ! test/script/basic/NASHORN-446.js ! test/script/basic/NASHORN-447.js ! test/script/basic/NASHORN-448.js ! test/script/basic/NASHORN-449.js ! test/script/basic/NASHORN-45.js ! test/script/basic/NASHORN-450.js ! test/script/basic/NASHORN-452.js ! test/script/basic/NASHORN-459.js ! test/script/basic/NASHORN-46.js ! test/script/basic/NASHORN-462.js ! test/script/basic/NASHORN-463.js ! test/script/basic/NASHORN-468.js ! test/script/basic/NASHORN-47.js ! test/script/basic/NASHORN-473.js ! test/script/basic/NASHORN-474.js ! test/script/basic/NASHORN-478.js ! test/script/basic/NASHORN-48.js ! test/script/basic/NASHORN-481.js ! test/script/basic/NASHORN-482.js ! test/script/basic/NASHORN-484.js ! test/script/basic/NASHORN-486.js ! test/script/basic/NASHORN-487.js ! test/script/basic/NASHORN-488.js ! test/script/basic/NASHORN-49.js ! test/script/basic/NASHORN-490.js ! test/script/basic/NASHORN-494.js ! test/script/basic/NASHORN-497.js ! test/script/basic/NASHORN-498.js ! test/script/basic/NASHORN-499.js ! test/script/basic/NASHORN-50.js ! test/script/basic/NASHORN-500.js ! test/script/basic/NASHORN-503.js ! test/script/basic/NASHORN-51.js ! test/script/basic/NASHORN-511.js ! test/script/basic/NASHORN-515.js ! test/script/basic/NASHORN-516.js ! test/script/basic/NASHORN-52.js ! test/script/basic/NASHORN-534.js ! test/script/basic/NASHORN-535.js ! test/script/basic/NASHORN-544.js ! test/script/basic/NASHORN-55.js ! test/script/basic/NASHORN-554.js ! test/script/basic/NASHORN-556.js ! test/script/basic/NASHORN-56.js ! test/script/basic/NASHORN-562.js ! test/script/basic/NASHORN-565.js ! test/script/basic/NASHORN-575.js ! test/script/basic/NASHORN-58.js ! test/script/basic/NASHORN-59.js ! test/script/basic/NASHORN-592.js ! test/script/basic/NASHORN-597.js ! test/script/basic/NASHORN-60.js ! test/script/basic/NASHORN-609.js ! test/script/basic/NASHORN-61.js ! test/script/basic/NASHORN-62.js ! test/script/basic/NASHORN-620.js ! test/script/basic/NASHORN-623.js ! test/script/basic/NASHORN-627.js ! test/script/basic/NASHORN-63.js ! test/script/basic/NASHORN-637.js ! test/script/basic/NASHORN-638.js ! test/script/basic/NASHORN-639.js ! test/script/basic/NASHORN-64.js ! test/script/basic/NASHORN-642.js ! test/script/basic/NASHORN-646.js ! test/script/basic/NASHORN-653.js ! test/script/basic/NASHORN-658.js ! test/script/basic/NASHORN-659.js ! test/script/basic/NASHORN-66.js ! test/script/basic/NASHORN-664.js ! test/script/basic/NASHORN-665.js ! test/script/basic/NASHORN-67.js ! test/script/basic/NASHORN-678.js ! test/script/basic/NASHORN-68.js ! test/script/basic/NASHORN-689.js ! test/script/basic/NASHORN-69.js ! test/script/basic/NASHORN-691.js ! test/script/basic/NASHORN-694.js ! test/script/basic/NASHORN-697.js ! test/script/basic/NASHORN-703.js ! test/script/basic/NASHORN-703a.js ! test/script/basic/NASHORN-705.js ! test/script/basic/NASHORN-71.js ! test/script/basic/NASHORN-710.js ! test/script/basic/NASHORN-711.js ! test/script/basic/NASHORN-72.js ! test/script/basic/NASHORN-722.js ! test/script/basic/NASHORN-73.js ! test/script/basic/NASHORN-737.js ! test/script/basic/NASHORN-74.js ! test/script/basic/NASHORN-740.js ! test/script/basic/NASHORN-75.js ! test/script/basic/NASHORN-758.js ! test/script/basic/NASHORN-759.js ! test/script/basic/NASHORN-760.js ! test/script/basic/NASHORN-768.js ! test/script/basic/NASHORN-778.js ! test/script/basic/NASHORN-78.js ! test/script/basic/NASHORN-79.js ! test/script/basic/NASHORN-792.js ! test/script/basic/NASHORN-80.js ! test/script/basic/NASHORN-81.js ! test/script/basic/NASHORN-833.js ! test/script/basic/NASHORN-85.js ! test/script/basic/NASHORN-86.js ! test/script/basic/NASHORN-87.js ! test/script/basic/NASHORN-89.js ! test/script/basic/NASHORN-90.js ! test/script/basic/NASHORN-91.js ! test/script/basic/NASHORN-92.js ! test/script/basic/NASHORN-93.js ! test/script/basic/NASHORN-95.js ! test/script/basic/NASHORN-96.js ! test/script/basic/NASHORN-97.js ! test/script/basic/NASHORN-98.js ! test/script/basic/NASHORN-99.js ! test/script/basic/addition.js ! test/script/basic/allgettersetters.js ! test/script/basic/andor.js ! test/script/basic/anonrecur.js ! test/script/basic/applycall.js ! test/script/basic/args.js ! test/script/basic/arity.js ! test/script/basic/arrayprotoclass.js ! test/script/basic/arrays.js ! test/script/basic/arrays2.js ! test/script/basic/arraysIntKey.js ! test/script/basic/arrayset.js ! test/script/basic/arrayundefined.js ! test/script/basic/assign.js ! test/script/basic/bitwise_and.js ! test/script/basic/booleangetter.js ! test/script/basic/builtin.js ! test/script/basic/builtin_assign.js ! test/script/basic/builtinchain.js ! test/script/basic/calllink.js ! test/script/basic/closure.js ! test/script/basic/commandargs.js ! test/script/basic/compile-octane.js ! test/script/basic/condassign.js ! test/script/basic/construct.js ! test/script/basic/constructorname.js ! test/script/basic/date.js ! test/script/basic/dateparse.js ! test/script/basic/decinc.js ! test/script/basic/delete.js ! test/script/basic/delete2.js ! test/script/basic/dotpropname.js ! test/script/basic/doublecache.js ! test/script/basic/enumeration.js ! test/script/basic/errors.js ! test/script/basic/errorstack.js ! test/script/basic/eval.js ! test/script/basic/evalreturn.js ! test/script/basic/exprclosure.js ! test/script/basic/extensibility.js ! test/script/basic/fileline.js ! test/script/basic/finally-catchalls.js ! test/script/basic/finallyreturn.js ! test/script/basic/forin.js ! test/script/basic/forin2.js ! test/script/basic/funcarray.js ! test/script/basic/funcbind.js ! test/script/basic/funcconstructor.js ! test/script/basic/getclassname.js ! test/script/basic/getenv.js ! test/script/basic/getter_callsite.js ! test/script/basic/gettercalls.js ! test/script/basic/getterfunc.js ! test/script/basic/gettersetter.js ! test/script/basic/globalaccess.js ! test/script/basic/globals.js ! test/script/basic/globalscope.js ! test/script/basic/hello.js ! test/script/basic/herestr_operator.js ! test/script/basic/illegaljavaname.js ! test/script/basic/incheck.js ! test/script/basic/indexedcall.js ! test/script/basic/info.js ! test/script/basic/inherited_nonwritable.js ! test/script/basic/instanceof.js ! test/script/basic/instanceof2.js ! test/script/basic/interfaces.js ! test/script/basic/iterator.js ! test/script/basic/java.js ! test/script/basic/javaarray.js ! test/script/basic/javaarrayconversion.js ! test/script/basic/javaexceptions.js ! test/script/basic/javaimporter.js ! test/script/basic/javainnerclasses.js ! test/script/basic/javasigcall.js ! test/script/basic/jquery.js ! test/script/basic/jsadapter.js ! test/script/basic/jsadapterlink.js ! test/script/basic/json.js ! test/script/basic/list.js ! test/script/basic/literal.js ! test/script/basic/load.js ! test/script/basic/loadedfile.js ! test/script/basic/localundef.js ! test/script/basic/map.js ! test/script/basic/math.js ! test/script/basic/minuszero.js ! test/script/basic/module.js ! test/script/basic/moduleload.js ! test/script/basic/nashorn2.js ! test/script/basic/natives.js ! test/script/basic/new.js ! test/script/basic/newexpr.js ! test/script/basic/newnew.js ! test/script/basic/nonconstructors.js ! test/script/basic/nosuchmethod.js ! test/script/basic/nosuchproperty.js ! test/script/basic/number.js ! test/script/basic/numberstring.js ! test/script/basic/objectprops.js ! test/script/basic/objects.js ! test/script/basic/options.js ! test/script/basic/propchange.js ! test/script/basic/propertycheck.js ! test/script/basic/prototype.js ! test/script/basic/pushpull.js ! test/script/basic/regex.js ! test/script/basic/regexp_flags.js ! test/script/basic/run-octane.js ! test/script/basic/runsunspider.js ! test/script/basic/samfunc.js ! test/script/basic/scripting.js ! test/script/basic/scripting.js.EXPECTED ! test/script/basic/sealfreeze.js ! test/script/basic/setlength.js ! test/script/basic/stdin.js ! test/script/basic/strings.js ! test/script/basic/throws.js ! test/script/basic/tosource.js ! test/script/basic/tostring.js ! test/script/basic/try.js ! test/script/basic/trybreakcont.js ! test/script/basic/trycatch.js ! test/script/basic/trycatchfor.js ! test/script/basic/tryfinallyreturn.js ! test/script/basic/tryforbreak.js ! test/script/basic/typechange.js ! test/script/basic/typeof.js ! test/script/basic/typeof2.js ! test/script/basic/undefined.js ! test/script/basic/underscore.js ! test/script/basic/varargs.js ! test/script/basic/void.js ! test/script/basic/with.js ! test/script/basic/withprimitive.js ! test/script/basic/writable_relink.js ! test/script/basic/xorassign.js ! test/script/basic/yui.js ! test/script/error/NASHORN-154/function_mult_params_in_strict.js ! test/script/error/NASHORN-154/improper_return_break_continue.js ! test/script/error/NASHORN-154/invalid_lvalue.js ! test/script/error/NASHORN-154/literal_data_and_accessor.js ! test/script/error/NASHORN-154/literal_mult_getters.js ! test/script/error/NASHORN-154/literal_mult_prop_in_strict.js ! test/script/error/NASHORN-154/with_in_strict.js ! test/script/error/NASHORN-214.js ! test/script/error/NASHORN-35.js ! test/script/error/NASHORN-39.js ! test/script/error/NASHORN-568.js ! test/script/error/NASHORN-57.js ! test/script/error/NASHORN-668.js ! test/script/error/quotemissing.js ! test/script/error/strictmode.js ! test/script/representations/NASHORN-592a.js ! test/script/sandbox/NASHORN-525.js ! test/script/sandbox/classloader.js ! test/script/sandbox/doprivileged.js ! test/script/sandbox/exit.js ! test/script/sandbox/file.js ! test/script/sandbox/javaextend.js ! test/script/sandbox/loadLibrary.js ! test/script/sandbox/net.js ! test/script/sandbox/property.js ! test/script/sandbox/reflection.js ! test/script/sandbox/runnable.js ! test/script/sandbox/unsafe.js ! test/script/test262.js ! test/script/test262_single.js ! test/src/UnnamedPackageTestCallback.java ! test/src/jdk/nashorn/api/scripting/MultipleEngineTest.java ! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java ! test/src/jdk/nashorn/api/scripting/Window.java ! test/src/jdk/nashorn/api/scripting/WindowEventHandler.java ! test/src/jdk/nashorn/internal/access/BooleanAccessTest.java ! test/src/jdk/nashorn/internal/access/MethodAccessTest.java ! test/src/jdk/nashorn/internal/access/NumberAccessTest.java ! test/src/jdk/nashorn/internal/access/NumberBoxingTest.java ! test/src/jdk/nashorn/internal/access/ObjectAccessTest.java ! test/src/jdk/nashorn/internal/access/Person.java ! test/src/jdk/nashorn/internal/access/SharedObject.java ! test/src/jdk/nashorn/internal/access/StringAccessTest.java ! test/src/jdk/nashorn/internal/codegen/CompilerTest.java ! test/src/jdk/nashorn/internal/parser/ParserTest.java ! test/src/jdk/nashorn/internal/performance/AuroraWrapper.java ! test/src/jdk/nashorn/internal/performance/OctaneTest.java ! test/src/jdk/nashorn/internal/performance/PerformanceWrapper.java ! test/src/jdk/nashorn/internal/performance/SplayTest.java ! test/src/jdk/nashorn/internal/runtime/ContextTest.java ! test/src/jdk/nashorn/internal/runtime/JSTypeTest.java ! test/src/jdk/nashorn/internal/runtime/Nashorn401TestSubject.java ! test/src/jdk/nashorn/internal/test/framework/AbstractScriptRunnable.java ! test/src/jdk/nashorn/internal/test/framework/JSJUnitReportReporter.java ! test/src/jdk/nashorn/internal/test/framework/OrphanTestFinder.java ! test/src/jdk/nashorn/internal/test/framework/ParallelTestRunner.java ! test/src/jdk/nashorn/internal/test/framework/ScriptEvaluator.java ! test/src/jdk/nashorn/internal/test/framework/ScriptRunnable.java ! test/src/jdk/nashorn/internal/test/framework/ScriptTest.java ! test/src/jdk/nashorn/internal/test/framework/SeparateContextEvaluator.java ! test/src/jdk/nashorn/internal/test/framework/SharedContextEvaluator.java ! test/src/jdk/nashorn/internal/test/framework/TestConfig.java ! test/src/jdk/nashorn/internal/test/framework/TestFinder.java ! test/src/jdk/nashorn/internal/test/framework/TestHelper.java ! test/src/jdk/nashorn/internal/test/framework/TestReorderInterceptor.java ! test/src/jdk/nashorn/internal/test/models/ConstructorWithArgument.java ! test/src/jdk/nashorn/internal/test/models/FinalClass.java ! test/src/jdk/nashorn/internal/test/models/NoAccessibleConstructorClass.java ! test/src/jdk/nashorn/internal/test/models/NonPublicClass.java ! test/src/jdk/nashorn/internal/test/models/OuterClass.java ! test/src/jdk/nashorn/internal/test/models/OverloadedSam.java ! test/src/jdk/nashorn/internal/test/models/OverrideObject.java From petr.hejl at oracle.com Fri Jan 4 06:48:35 2013 From: petr.hejl at oracle.com (Petr Hejl) Date: Fri, 04 Jan 2013 15:48:35 +0100 Subject: Contribution: Offset quickfixes Message-ID: <50E6EBC3.7070006@oracle.com> Hi, I noticed some issues with offset while using the current Nashorn with NetBeans. The patch contains _quickfixes_ for: - wrong block offsets - wrong literal finish offset - wrong case node block finish offset - block containing var node ending with semicolon finish I'm not really sure the solution is the best one. Leaving up to you for evaluation. Thanks, P. From petr.hejl at oracle.com Fri Jan 4 07:03:52 2013 From: petr.hejl at oracle.com (Petr Hejl) Date: Fri, 04 Jan 2013 16:03:52 +0100 Subject: Contribution: Offset quickfixes In-Reply-To: <50E6EBC3.7070006@oracle.com> References: <50E6EBC3.7070006@oracle.com> Message-ID: <50E6EF58.3050502@oracle.com> Here is the patch (at the end of the message). P. On 01/04/2013 03:48 PM, Petr Hejl wrote: > Hi, > I noticed some issues with offset while using the current Nashorn with > NetBeans. The patch contains _quickfixes_ for: > - wrong block offsets > - wrong literal finish offset > - wrong case node block finish offset > - block containing var node ending with semicolon finish > > I'm not really sure the solution is the best one. Leaving up to you for > evaluation. > > Thanks, > P. > diff -r 7e1eb46cd092 -r 63d015d13bc9 src/jdk/nashorn/internal/ir/Block.java --- a/src/jdk/nashorn/internal/ir/Block.java Thu Jan 03 15:45:05 2013 +0100 +++ b/src/jdk/nashorn/internal/ir/Block.java Fri Jan 04 15:16:50 2013 +0100 @@ -185,6 +185,9 @@ public void addStatement(final Node statement) { if (statement != null) { statements.add(statement); + if (getFinish() < statement.getFinish()) { + setFinish(statement.getFinish()); + } } } diff -r 7e1eb46cd092 -r 63d015d13bc9 src/jdk/nashorn/internal/parser/AbstractParser.java --- a/src/jdk/nashorn/internal/parser/AbstractParser.java Thu Jan 03 15:45:05 2013 +0100 +++ b/src/jdk/nashorn/internal/parser/AbstractParser.java Fri Jan 04 15:16:50 2013 +0100 @@ -429,6 +429,8 @@ // Create literal node. final Object value = getValue(); + // move it immediately to have a right finish + next(); LiteralNode node = null; @@ -452,7 +454,6 @@ assert false : "unknown type for LiteralNode: " + value.getClass(); } - next(); return node; } } diff -r 7e1eb46cd092 -r 63d015d13bc9 src/jdk/nashorn/internal/parser/Parser.java --- a/src/jdk/nashorn/internal/parser/Parser.java Thu Jan 03 15:45:05 2013 +0100 +++ b/src/jdk/nashorn/internal/parser/Parser.java Fri Jan 04 15:16:50 2013 +0100 @@ -934,7 +934,11 @@ // If is a statement then handle end of line. if (isStatement) { + boolean semicolon = (type == SEMICOLON); endOfLine(); + if (semicolon) { + block.setFinish(finish); + } } return vars; @@ -950,7 +954,8 @@ */ private void emptyStatement() { if (context._empty_statements) { - block.addStatement(new EmptyNode(source, token, Token.descPosition(token))); + block.addStatement(new EmptyNode(source, token, + Token.descPosition(token) + Token.descLength(token))); } // SEMICOLON checked in caller. @@ -984,6 +989,7 @@ if (executeNode != null) { executeNode.setFinish(finish); + block.setFinish(finish); } } @@ -1567,6 +1573,7 @@ // Get CASE body. final Block statements = getBlock(false); final CaseNode caseNode = new CaseNode(source, caseToken, finish, caseExpression, statements); + statements.setFinish(finish); if (caseExpression == null) { defaultCase = caseNode; From james.laskey at oracle.com Fri Jan 4 09:55:22 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Fri, 4 Jan 2013 13:55:22 -0400 Subject: Contribution: Offset quickfixes In-Reply-To: <50E6EF58.3050502@oracle.com> References: <50E6EBC3.7070006@oracle.com> <50E6EF58.3050502@oracle.com> Message-ID: Test -------------- next part -------------- From james.laskey at oracle.com Fri Jan 4 10:03:16 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Fri, 4 Jan 2013 14:03:16 -0400 Subject: Review Request: 8005703: Offsets miscalculated for blocks Message-ID: http://cr.openjdk.java.net/~jlaskey/8005703/webrev/index.html From james.laskey at oracle.com Sat Jan 5 05:51:50 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Sat, 5 Jan 2013 09:51:50 -0400 Subject: Contribution: Offset quickfixes In-Reply-To: References: <50E6EBC3.7070006@oracle.com> <50E6EF58.3050502@oracle.com> Message-ID: Testing attachments -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: nashorn.txt Url: http://mail.openjdk.java.net/pipermail/nashorn-dev/attachments/20130105/125a67c6/nashorn.txt -------------- next part -------------- From james.laskey at oracle.com Sat Jan 5 05:56:43 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Sat, 5 Jan 2013 09:56:43 -0400 Subject: Contribution: Offset quickfixes In-Reply-To: References: <50E6EBC3.7070006@oracle.com> <50E6EF58.3050502@oracle.com> Message-ID: <20452C7E-0747-40C3-A3B1-FFA68DE54379@oracle.com> Testing attachments -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: nashorn.txt Url: http://mail.openjdk.java.net/pipermail/nashorn-dev/attachments/20130105/dbc31e83/nashorn.txt -------------- next part -------------- From james.laskey at oracle.com Sat Jan 5 06:22:14 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Sat, 5 Jan 2013 10:22:14 -0400 Subject: Contribution: Offset quickfixes In-Reply-To: References: <50E6EBC3.7070006@oracle.com> <50E6EF58.3050502@oracle.com> Message-ID: <6FDAF747-968B-4AA6-8F3C-999D1124BFA8@oracle.com> Testing attachments -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: nashorn.txt Url: http://mail.openjdk.java.net/pipermail/nashorn-dev/attachments/20130105/9e5d81d5/nashorn.txt -------------- next part -------------- A non-text attachment was scrubbed... Name: nashorn.zip Type: application/zip Size: 1918 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/nashorn-dev/attachments/20130105/9e5d81d5/nashorn.zip -------------- next part -------------- From castillo.bryan at gmail.com Sun Jan 6 08:43:25 2013 From: castillo.bryan at gmail.com (Bryan Castillo) Date: Sun, 6 Jan 2013 08:43:25 -0800 Subject: Error trying to use slf4j Message-ID: I just ran into an error using Nashorn today with slf4j. I don't see this error with Rhino. source: ---------------- package bcc; import javax.script.ScriptEngine; import javax.script.ScriptEngineManager; public class UseSlf4j { public static void main(String[] args) throws Exception { ScriptEngine engine = new ScriptEngineManager().getEngineByName("nashorn"); engine.eval( "var logger = Packages.org.slf4j.LoggerFactory.getLogger('my_script');\n" + "java.lang.System.out.println('Here is a logger: ' + logger);\n" + "logger.info('From a script.');" ); } } output: ----------------- Here is a logger: org.slf4j.impl.Log4jLoggerAdapter(my_script) Exception in thread "main" java.lang.IllegalAccessError: Failed to unreflect method public java.lang.String org.slf4j.helpers.NamedLoggerBase.getName() at org.dynalang.dynalink.support.Lookup.unreflect(Lookup.java:61) at org.dynalang.dynalink.beans.FacetIntrospector.unreflect(FacetIntrospector.java:113) at org.dynalang.dynalink.beans.AbstractJavaLinker.(AbstractJavaLinker.java:101) at org.dynalang.dynalink.beans.BeanLinker.(BeanLinker.java:44) at org.dynalang.dynalink.beans.BeansLinker$1.computeValue(BeansLinker.java:71) at org.dynalang.dynalink.beans.BeansLinker$1.computeValue(BeansLinker.java:67) at java.lang.ClassValue.getFromHashMap(ClassValue.java:227) at java.lang.ClassValue.getFromBackup(ClassValue.java:209) at java.lang.ClassValue.get(ClassValue.java:115) at org.dynalang.dynalink.beans.BeansLinker.getLinkerForClass(BeansLinker.java:93) at org.dynalang.dynalink.beans.BeansLinker.getGuardedInvocation(BeansLinker.java:111) at org.dynalang.dynalink.support.CompositeGuardingDynamicLinker.getGuardedInvocation(CompositeGuardingDynamicLinker.java:58) at org.dynalang.dynalink.support.LinkerServicesImpl.getGuardedInvocation(LinkerServicesImpl.java:72) at org.dynalang.dynalink.DynamicLinker.relink(DynamicLinker.java:163) at jdk.nashorn.internal.scripts.Script$?003Ceval?003E.runScript(:3) at jdk.nashorn.internal.runtime.ScriptFunction.invoke(ScriptFunction.java:359) at jdk.nashorn.internal.runtime.ScriptRuntime.apply(ScriptRuntime.java:310) at jdk.nashorn.api.scripting.NashornScriptEngine.evalImpl(NashornScriptEngine.java:438) at jdk.nashorn.api.scripting.NashornScriptEngine.evalImpl(NashornScriptEngine.java:423) at jdk.nashorn.api.scripting.NashornScriptEngine.eval(NashornScriptEngine.java:150) at javax.script.AbstractScriptEngine.eval(AbstractScriptEngine.java:264) at bcc.UseSlf4j.main(UseSlf4j.java:10) Caused by: java.lang.IllegalAccessException: class is not public: org.slf4j.helpers.NamedLoggerBase.getName()String/invokeVirtual, from java.lang.Object/public at java.lang.invoke.MemberName.makeAccessException(MemberName.java:732) at java.lang.invoke.MethodHandles$Lookup.checkAccess(MethodHandles.java:1135) at java.lang.invoke.MethodHandles$Lookup.checkMethod(MethodHandles.java:1098) at java.lang.invoke.MethodHandles$Lookup.getDirectMethodCommon(MethodHandles.java:1209) at java.lang.invoke.MethodHandles$Lookup.getDirectMethod(MethodHandles.java:1199) at java.lang.invoke.MethodHandles$Lookup.unreflect(MethodHandles.java:914) at org.dynalang.dynalink.support.Lookup.unreflect(Lookup.java:59) ... 21 more jdk: ----------------- C:\Users\bcastill>"c:\Program Files\Java\jdk1.8.0\bin\java" -version java version "1.8.0-ea" Java(TM) SE Runtime Environment (build 1.8.0-ea-b71) Java HotSpot(TM) 64-Bit Server VM (build 25.0-b14, mixed mode) Nashorn version: ------------------------------------------ bcastill at US-SEA-R9CMKD3 /cygdrive/c/bcastill/nashorn $ hg log -l 1 changeset: 6:5a1b0714df0e tag: tip user: jlaskey date: Fri Jan 04 09:58:33 2013 -0400 summary: 8005663: Update copyright year to 2013 Slf4j related jars: ---------------------------------- $ ls -l *slf4j*.jar log*.jar ----------+ 1 bcastill Domain Users 17308 Jan 5 21:59 jcl-over-slf4j-1.6.1.jar ----------+ 1 bcastill Domain Users 481534 Jan 5 22:00 log4j-1.2.16.jar ----------+ 1 bcastill Domain Users 25496 Jan 5 21:59 slf4j-api-1.6.1.jar ----------+ 1 bcastill Domain Users 9753 Jan 5 21:59 slf4j-log4j12-1.6.1.jar From forax at univ-mlv.fr Sun Jan 6 10:07:38 2013 From: forax at univ-mlv.fr (Remi Forax) Date: Sun, 06 Jan 2013 19:07:38 +0100 Subject: Error trying to use slf4j In-Reply-To: References: Message-ID: <50E9BD6A.3030202@univ-mlv.fr> On 01/06/2013 05:43 PM, Bryan Castillo wrote: > I just ran into an error using Nashorn today with slf4j. I don't see this > error with Rhino. It's a bug in the FacetIntrospector of dynalink, if the class is not public, the introspector should try to find a super class or an interface that declares the method, here Object::toString. R?mi > > source: > ---------------- > > package bcc; > > import javax.script.ScriptEngine; > import javax.script.ScriptEngineManager; > > public class UseSlf4j { > > public static void main(String[] args) throws Exception { > ScriptEngine engine = new ScriptEngineManager().getEngineByName("nashorn"); > engine.eval( > "var logger = > Packages.org.slf4j.LoggerFactory.getLogger('my_script');\n" + > "java.lang.System.out.println('Here is a logger: ' + logger);\n" + > "logger.info('From a script.');" > ); > } > > } > > > output: > ----------------- > > Here is a logger: org.slf4j.impl.Log4jLoggerAdapter(my_script) > Exception in thread "main" java.lang.IllegalAccessError: Failed to > unreflect method public java.lang.String > org.slf4j.helpers.NamedLoggerBase.getName() > at org.dynalang.dynalink.support.Lookup.unreflect(Lookup.java:61) > at > org.dynalang.dynalink.beans.FacetIntrospector.unreflect(FacetIntrospector.java:113) > at > org.dynalang.dynalink.beans.AbstractJavaLinker.(AbstractJavaLinker.java:101) > at org.dynalang.dynalink.beans.BeanLinker.(BeanLinker.java:44) > at > org.dynalang.dynalink.beans.BeansLinker$1.computeValue(BeansLinker.java:71) > at > org.dynalang.dynalink.beans.BeansLinker$1.computeValue(BeansLinker.java:67) > at java.lang.ClassValue.getFromHashMap(ClassValue.java:227) > at java.lang.ClassValue.getFromBackup(ClassValue.java:209) > at java.lang.ClassValue.get(ClassValue.java:115) > at > org.dynalang.dynalink.beans.BeansLinker.getLinkerForClass(BeansLinker.java:93) > at > org.dynalang.dynalink.beans.BeansLinker.getGuardedInvocation(BeansLinker.java:111) > at > org.dynalang.dynalink.support.CompositeGuardingDynamicLinker.getGuardedInvocation(CompositeGuardingDynamicLinker.java:58) > at > org.dynalang.dynalink.support.LinkerServicesImpl.getGuardedInvocation(LinkerServicesImpl.java:72) > at org.dynalang.dynalink.DynamicLinker.relink(DynamicLinker.java:163) > at jdk.nashorn.internal.scripts.Script$?003Ceval?003E.runScript(:3) > at > jdk.nashorn.internal.runtime.ScriptFunction.invoke(ScriptFunction.java:359) > at jdk.nashorn.internal.runtime.ScriptRuntime.apply(ScriptRuntime.java:310) > at > jdk.nashorn.api.scripting.NashornScriptEngine.evalImpl(NashornScriptEngine.java:438) > at > jdk.nashorn.api.scripting.NashornScriptEngine.evalImpl(NashornScriptEngine.java:423) > at > jdk.nashorn.api.scripting.NashornScriptEngine.eval(NashornScriptEngine.java:150) > at javax.script.AbstractScriptEngine.eval(AbstractScriptEngine.java:264) > at bcc.UseSlf4j.main(UseSlf4j.java:10) > Caused by: java.lang.IllegalAccessException: class is not public: > org.slf4j.helpers.NamedLoggerBase.getName()String/invokeVirtual, from > java.lang.Object/public > at java.lang.invoke.MemberName.makeAccessException(MemberName.java:732) > at > java.lang.invoke.MethodHandles$Lookup.checkAccess(MethodHandles.java:1135) > at > java.lang.invoke.MethodHandles$Lookup.checkMethod(MethodHandles.java:1098) > at > java.lang.invoke.MethodHandles$Lookup.getDirectMethodCommon(MethodHandles.java:1209) > at > java.lang.invoke.MethodHandles$Lookup.getDirectMethod(MethodHandles.java:1199) > at java.lang.invoke.MethodHandles$Lookup.unreflect(MethodHandles.java:914) > at org.dynalang.dynalink.support.Lookup.unreflect(Lookup.java:59) > ... 21 more > > > > jdk: > ----------------- > > C:\Users\bcastill>"c:\Program Files\Java\jdk1.8.0\bin\java" -version > java version "1.8.0-ea" > Java(TM) SE Runtime Environment (build 1.8.0-ea-b71) > Java HotSpot(TM) 64-Bit Server VM (build 25.0-b14, mixed mode) > > > Nashorn version: > ------------------------------------------ > > bcastill at US-SEA-R9CMKD3 /cygdrive/c/bcastill/nashorn > $ hg log -l 1 > changeset: 6:5a1b0714df0e > tag: tip > user: jlaskey > date: Fri Jan 04 09:58:33 2013 -0400 > summary: 8005663: Update copyright year to 2013 > > > > Slf4j related jars: > ---------------------------------- > $ ls -l *slf4j*.jar log*.jar > ----------+ 1 bcastill Domain Users 17308 Jan 5 21:59 > jcl-over-slf4j-1.6.1.jar > ----------+ 1 bcastill Domain Users 481534 Jan 5 22:00 log4j-1.2.16.jar > ----------+ 1 bcastill Domain Users 25496 Jan 5 21:59 slf4j-api-1.6.1.jar > ----------+ 1 bcastill Domain Users 9753 Jan 5 21:59 > slf4j-log4j12-1.6.1.jar From james.laskey at oracle.com Sun Jan 6 10:46:33 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Sun, 6 Jan 2013 14:46:33 -0400 Subject: Error trying to use slf4j In-Reply-To: <50E9BD6A.3030202@univ-mlv.fr> References: <50E9BD6A.3030202@univ-mlv.fr> Message-ID: <34925B64-A08B-436A-B911-D55999DDCC3E@oracle.com> Bug filed : 8005777 (internal) On 2013-01-06, at 2:07 PM, Remi Forax wrote: > On 01/06/2013 05:43 PM, Bryan Castillo wrote: >> I just ran into an error using Nashorn today with slf4j. I don't see this >> error with Rhino. > > It's a bug in the FacetIntrospector of dynalink, if the class is not public, the introspector should try to find a super class or an interface that declares the method, here Object::toString. > > R?mi > >> >> source: >> ---------------- >> >> package bcc; >> >> import javax.script.ScriptEngine; >> import javax.script.ScriptEngineManager; >> >> public class UseSlf4j { >> >> public static void main(String[] args) throws Exception { >> ScriptEngine engine = new ScriptEngineManager().getEngineByName("nashorn"); >> engine.eval( >> "var logger = >> Packages.org.slf4j.LoggerFactory.getLogger('my_script');\n" + >> "java.lang.System.out.println('Here is a logger: ' + logger);\n" + >> "logger.info('From a script.');" >> ); >> } >> >> } >> >> >> output: >> ----------------- >> >> Here is a logger: org.slf4j.impl.Log4jLoggerAdapter(my_script) >> Exception in thread "main" java.lang.IllegalAccessError: Failed to >> unreflect method public java.lang.String >> org.slf4j.helpers.NamedLoggerBase.getName() >> at org.dynalang.dynalink.support.Lookup.unreflect(Lookup.java:61) >> at >> org.dynalang.dynalink.beans.FacetIntrospector.unreflect(FacetIntrospector.java:113) >> at >> org.dynalang.dynalink.beans.AbstractJavaLinker.(AbstractJavaLinker.java:101) >> at org.dynalang.dynalink.beans.BeanLinker.(BeanLinker.java:44) >> at >> org.dynalang.dynalink.beans.BeansLinker$1.computeValue(BeansLinker.java:71) >> at >> org.dynalang.dynalink.beans.BeansLinker$1.computeValue(BeansLinker.java:67) >> at java.lang.ClassValue.getFromHashMap(ClassValue.java:227) >> at java.lang.ClassValue.getFromBackup(ClassValue.java:209) >> at java.lang.ClassValue.get(ClassValue.java:115) >> at >> org.dynalang.dynalink.beans.BeansLinker.getLinkerForClass(BeansLinker.java:93) >> at >> org.dynalang.dynalink.beans.BeansLinker.getGuardedInvocation(BeansLinker.java:111) >> at >> org.dynalang.dynalink.support.CompositeGuardingDynamicLinker.getGuardedInvocation(CompositeGuardingDynamicLinker.java:58) >> at >> org.dynalang.dynalink.support.LinkerServicesImpl.getGuardedInvocation(LinkerServicesImpl.java:72) >> at org.dynalang.dynalink.DynamicLinker.relink(DynamicLinker.java:163) >> at jdk.nashorn.internal.scripts.Script$?003Ceval?003E.runScript(:3) >> at >> jdk.nashorn.internal.runtime.ScriptFunction.invoke(ScriptFunction.java:359) >> at jdk.nashorn.internal.runtime.ScriptRuntime.apply(ScriptRuntime.java:310) >> at >> jdk.nashorn.api.scripting.NashornScriptEngine.evalImpl(NashornScriptEngine.java:438) >> at >> jdk.nashorn.api.scripting.NashornScriptEngine.evalImpl(NashornScriptEngine.java:423) >> at >> jdk.nashorn.api.scripting.NashornScriptEngine.eval(NashornScriptEngine.java:150) >> at javax.script.AbstractScriptEngine.eval(AbstractScriptEngine.java:264) >> at bcc.UseSlf4j.main(UseSlf4j.java:10) >> Caused by: java.lang.IllegalAccessException: class is not public: >> org.slf4j.helpers.NamedLoggerBase.getName()String/invokeVirtual, from >> java.lang.Object/public >> at java.lang.invoke.MemberName.makeAccessException(MemberName.java:732) >> at >> java.lang.invoke.MethodHandles$Lookup.checkAccess(MethodHandles.java:1135) >> at >> java.lang.invoke.MethodHandles$Lookup.checkMethod(MethodHandles.java:1098) >> at >> java.lang.invoke.MethodHandles$Lookup.getDirectMethodCommon(MethodHandles.java:1209) >> at >> java.lang.invoke.MethodHandles$Lookup.getDirectMethod(MethodHandles.java:1199) >> at java.lang.invoke.MethodHandles$Lookup.unreflect(MethodHandles.java:914) >> at org.dynalang.dynalink.support.Lookup.unreflect(Lookup.java:59) >> ... 21 more >> >> >> >> jdk: >> ----------------- >> >> C:\Users\bcastill>"c:\Program Files\Java\jdk1.8.0\bin\java" -version >> java version "1.8.0-ea" >> Java(TM) SE Runtime Environment (build 1.8.0-ea-b71) >> Java HotSpot(TM) 64-Bit Server VM (build 25.0-b14, mixed mode) >> >> >> Nashorn version: >> ------------------------------------------ >> >> bcastill at US-SEA-R9CMKD3 /cygdrive/c/bcastill/nashorn >> $ hg log -l 1 >> changeset: 6:5a1b0714df0e >> tag: tip >> user: jlaskey >> date: Fri Jan 04 09:58:33 2013 -0400 >> summary: 8005663: Update copyright year to 2013 >> >> >> >> Slf4j related jars: >> ---------------------------------- >> $ ls -l *slf4j*.jar log*.jar >> ----------+ 1 bcastill Domain Users 17308 Jan 5 21:59 >> jcl-over-slf4j-1.6.1.jar >> ----------+ 1 bcastill Domain Users 481534 Jan 5 22:00 log4j-1.2.16.jar >> ----------+ 1 bcastill Domain Users 25496 Jan 5 21:59 slf4j-api-1.6.1.jar >> ----------+ 1 bcastill Domain Users 9753 Jan 5 21:59 >> slf4j-log4j12-1.6.1.jar > From sundararajan.athijegannathan at oracle.com Sun Jan 6 20:35:58 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Mon, 07 Jan 2013 10:05:58 +0530 Subject: Review Request: 8005782 : get rid of javadoc errors, warnings in nashorn build In-Reply-To: <7DA03B89-7B8F-4868-99FD-10B29C37ACB9@oracle.com> References: <7DA03B89-7B8F-4868-99FD-10B29C37ACB9@oracle.com> Message-ID: <50EA50AE.2070006@oracle.com> Hi, Please review: http://cr.openjdk.java.net/~sundar/8005782/ Thanks -Sundar From marcus.lagergren at oracle.com Sun Jan 6 23:52:10 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Mon, 7 Jan 2013 08:52:10 +0100 Subject: Review Request: 8005782 : get rid of javadoc errors, warnings in nashorn build In-Reply-To: <50EA50AE.2070006@oracle.com> References: <7DA03B89-7B8F-4868-99FD-10B29C37ACB9@oracle.com> <50EA50AE.2070006@oracle.com> Message-ID: <124A80BD-46CB-497F-A8D8-1010CB03BC04@oracle.com> +1 On Jan 7, 2013, at 5:35 AM, "A. Sundararajan" wrote: > Hi, > > Please review: http://cr.openjdk.java.net/~sundar/8005782/ > > Thanks > -Sundar From marcus.lagergren at oracle.com Mon Jan 7 01:38:29 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Mon, 7 Jan 2013 10:38:29 +0100 Subject: Review 8005789 Message-ID: <4A041FB5-4DC3-40ED-B3E6-55684B583288@oracle.com> Please review http://cr.openjdk.java.net/~lagergren/8005789/ , simple doc change that was forgotten in the open jdk source plus 3 warnings that were spotted when I repaired the Eclipse project to work with the new open jdk layout. /M From hannes.wallnoefer at oracle.com Mon Jan 7 02:20:29 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Mon, 07 Jan 2013 11:20:29 +0100 Subject: Review 8005789 In-Reply-To: <4A041FB5-4DC3-40ED-B3E6-55684B583288@oracle.com> References: <4A041FB5-4DC3-40ED-B3E6-55684B583288@oracle.com> Message-ID: <50EAA16D.8080208@oracle.com> +1 Am 2013-01-07 10:38, schrieb Marcus Lagergren: > Please review http://cr.openjdk.java.net/~lagergren/8005789/ , simple doc change that was forgotten in the open jdk source plus 3 warnings that were spotted when I repaired the Eclipse project to work with the new open jdk layout. > > /M > > From attila.szegedi at oracle.com Mon Jan 7 03:21:01 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Mon, 7 Jan 2013 12:21:01 +0100 Subject: Review 8005789 In-Reply-To: <4A041FB5-4DC3-40ED-B3E6-55684B583288@oracle.com> References: <4A041FB5-4DC3-40ED-B3E6-55684B583288@oracle.com> Message-ID: +1 On Jan 7, 2013, at 10:38 AM, Marcus Lagergren wrote: > Please review http://cr.openjdk.java.net/~lagergren/8005789/ , simple doc change that was forgotten in the open jdk source plus 3 warnings that were spotted when I repaired the Eclipse project to work with the new open jdk layout. > > /M > > From attila.szegedi at oracle.com Mon Jan 7 03:21:11 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Mon, 7 Jan 2013 12:21:11 +0100 Subject: Review Request: 8005782 : get rid of javadoc errors, warnings in nashorn build In-Reply-To: <50EA50AE.2070006@oracle.com> References: <7DA03B89-7B8F-4868-99FD-10B29C37ACB9@oracle.com> <50EA50AE.2070006@oracle.com> Message-ID: +1 On Jan 7, 2013, at 5:35 AM, A. Sundararajan wrote: > Hi, > > Please review: http://cr.openjdk.java.net/~sundar/8005782/ > > Thanks > -Sundar From marcus.lagergren at oracle.com Mon Jan 7 07:24:31 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Mon, 7 Jan 2013 16:24:31 +0100 Subject: Review request for 8005788 Message-ID: Pls review https://jbs.oracle.com/bugs/browse/JDK-8005788 at http://cr.openjdk.java.net/~lagergren/8005788/ Loggers and their system defines were inconsistent, one did not enable the other, and several hardcoded System.err look at the Context error stream instead. /M From james.laskey at oracle.com Mon Jan 7 09:46:19 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Mon, 7 Jan 2013 13:46:19 -0400 Subject: Review request for 8005788 In-Reply-To: References: Message-ID: +1 On 2013-01-07, at 11:24 AM, Marcus Lagergren wrote: > Pls review https://jbs.oracle.com/bugs/browse/JDK-8005788 at http://cr.openjdk.java.net/~lagergren/8005788/ > > Loggers and their system defines were inconsistent, one did not enable the other, and several hardcoded System.err look at the Context error stream instead. > > /M > From marcus.lagergren at oracle.com Mon Jan 7 10:31:49 2013 From: marcus.lagergren at oracle.com (marcus.lagergren at oracle.com) Date: Mon, 07 Jan 2013 18:31:49 +0000 Subject: hg: nashorn/jdk8/nashorn: 8005789: Forgot to document -Dnashorn.unstable.relink.threshold Message-ID: <20130107183150.D3F33470BC@hg.openjdk.java.net> Changeset: 1e3f411f47bf Author: lagergren Date: 2013-01-07 19:31 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/1e3f411f47bf 8005789: Forgot to document -Dnashorn.unstable.relink.threshold Summary: Added documentation to DEVELOPER_README, fixed code convention warnings Reviewed-by: attila ! docs/DEVELOPER_README ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/Splitter.java ! src/jdk/nashorn/internal/runtime/PropertyMap.java ! src/jdk/nashorn/internal/runtime/options/Options.java From james.laskey at oracle.com Mon Jan 7 10:42:28 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Mon, 07 Jan 2013 18:42:28 +0000 Subject: hg: nashorn/jdk8/nashorn: 8005703: Offsets miscalculated for blocks Message-ID: <20130107184229.196CD470BE@hg.openjdk.java.net> Changeset: 41c7093477ae Author: jlaskey Date: 2013-01-07 14:41 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/41c7093477ae 8005703: Offsets miscalculated for blocks Reviewed-by: lagergren Contributed-by: petr.hejl at oracle.com ! src/jdk/nashorn/internal/ir/Block.java ! src/jdk/nashorn/internal/parser/AbstractParser.java ! src/jdk/nashorn/internal/parser/Parser.java From sundararajan.athijegannathan at oracle.com Mon Jan 7 19:17:07 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Tue, 08 Jan 2013 03:17:07 +0000 Subject: hg: nashorn/jdk8/nashorn: 8005782: get rid of javadoc errors, warnings in nashorn build Message-ID: <20130108031708.30547470D8@hg.openjdk.java.net> Changeset: d14da0d0c577 Author: sundar Date: 2013-01-08 08:51 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/d14da0d0c577 8005782: get rid of javadoc errors, warnings in nashorn build Reviewed-by: lagergren ! make/build.xml ! make/project.properties ! src/jdk/nashorn/internal/codegen/MethodEmitter.java ! src/jdk/nashorn/internal/runtime/ECMAErrors.java ! src/jdk/nashorn/internal/runtime/PropertyMap.java From sundararajan.athijegannathan at oracle.com Mon Jan 7 20:21:28 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Tue, 08 Jan 2013 09:51:28 +0530 Subject: Review Request: 8005835 : NASHORN-668 output fails to compare with the corresponding .EXPECTED file In-Reply-To: References: <7DA03B89-7B8F-4868-99FD-10B29C37ACB9@oracle.com> <50EA50AE.2070006@oracle.com> Message-ID: <50EB9EC8.2050204@oracle.com> Hi, Please review http://cr.openjdk.java.net/~sundar/8005835/ Testing: with this change, "make test" and "make test262parallel" ran fine. Thanks, -Sundar From marcus.lagergren at oracle.com Mon Jan 7 23:24:34 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Tue, 8 Jan 2013 08:24:34 +0100 Subject: Review Request: 8005835 : NASHORN-668 output fails to compare with the corresponding .EXPECTED file In-Reply-To: <50EB9EC8.2050204@oracle.com> References: <7DA03B89-7B8F-4868-99FD-10B29C37ACB9@oracle.com> <50EA50AE.2070006@oracle.com> <50EB9EC8.2050204@oracle.com> Message-ID: +1 On Jan 8, 2013, at 5:21 AM, A. Sundararajan wrote: > Hi, > > Please review http://cr.openjdk.java.net/~sundar/8005835/ > > Testing: with this change, "make test" and "make test262parallel" ran fine. > > Thanks, > -Sundar From hannes.wallnoefer at oracle.com Tue Jan 8 00:41:18 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Tue, 08 Jan 2013 09:41:18 +0100 Subject: Review Request: 8005835 : NASHORN-668 output fails to compare with the corresponding .EXPECTED file In-Reply-To: <50EB9EC8.2050204@oracle.com> References: <7DA03B89-7B8F-4868-99FD-10B29C37ACB9@oracle.com> <50EA50AE.2070006@oracle.com> <50EB9EC8.2050204@oracle.com> Message-ID: <50EBDBAE.1080205@oracle.com> +1 Am 2013-01-08 05:21, schrieb A. Sundararajan: > Hi, > > Please review http://cr.openjdk.java.net/~sundar/8005835/ > > Testing: with this change, "make test" and "make test262parallel" ran > fine. > > Thanks, > -Sundar From marcus.lagergren at oracle.com Tue Jan 8 00:58:20 2013 From: marcus.lagergren at oracle.com (marcus.lagergren at oracle.com) Date: Tue, 08 Jan 2013 08:58:20 +0000 Subject: hg: nashorn/jdk8/nashorn: 8005788: Loggers and their corresponding system properties not working correctly Message-ID: <20130108085821.7F8F8470DF@hg.openjdk.java.net> Changeset: 0e7da548ef6a Author: lagergren Date: 2013-01-08 09:59 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/0e7da548ef6a 8005788: Loggers and their corresponding system properties not working correctly Summary: 1-1 mapping now maintained. Used Context err instead of System.err in several places (after bootstrapping Context). Problematic closing of err stream replaced by @SuppressWarnings("resource") Reviewed-by: jlaskey, sundar ! src/jdk/nashorn/internal/ir/Symbol.java ! src/jdk/nashorn/internal/objects/NativeDebug.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/DebugLogger.java ! src/jdk/nashorn/internal/runtime/ECMAException.java ! src/jdk/nashorn/internal/runtime/ErrorManager.java ! src/jdk/nashorn/internal/runtime/Logging.java ! src/jdk/nashorn/internal/runtime/linker/LinkerCallSite.java ! src/jdk/nashorn/internal/runtime/linker/MethodHandleFactory.java ! src/jdk/nashorn/internal/runtime/options/Options.java ! src/jdk/nashorn/tools/Shell.java From sundararajan.athijegannathan at oracle.com Tue Jan 8 01:09:38 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Tue, 08 Jan 2013 14:39:38 +0530 Subject: Review request for 8005788 In-Reply-To: References: Message-ID: <50EBE252.3080500@oracle.com> +1 Marcus Lagergren wrote: > Pls review https://jbs.oracle.com/bugs/browse/JDK-8005788 at http://cr.openjdk.java.net/~lagergren/8005788/ > > Loggers and their system defines were inconsistent, one did not enable the other, and several hardcoded System.err look at the Context error stream instead. > > /M > > From sundararajan.athijegannathan at oracle.com Tue Jan 8 01:28:49 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Tue, 08 Jan 2013 09:28:49 +0000 Subject: hg: nashorn/jdk8/nashorn: 8005835: NASHORN-668 output fails to compare with the corresponding .EXPECTED file Message-ID: <20130108092849.CCA2B470E2@hg.openjdk.java.net> Changeset: 5f2db2d8a7fa Author: sundar Date: 2013-01-08 15:02 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/5f2db2d8a7fa 8005835: NASHORN-668 output fails to compare with the corresponding .EXPECTED file Reviewed-by: lagergren, hannesw ! test/script/error/NASHORN-668.js.EXPECTED From marcus.lagergren at oracle.com Tue Jan 8 01:51:50 2013 From: marcus.lagergren at oracle.com (marcus.lagergren at oracle.com) Date: Tue, 08 Jan 2013 09:51:50 +0000 Subject: hg: nashorn/jdk8/nashorn: 8005843: refSymbols lookup of unbound variable could cause NullPointerException in Lower Message-ID: <20130108095151.BC258470E4@hg.openjdk.java.net> Changeset: d8e4d66f1a06 Author: lagergren Date: 2013-01-08 10:52 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/d8e4d66f1a06 8005843: refSymbols lookup of unbound variable could cause NullPointerException in Lower Reviewed-by: hannesw, attila ! src/jdk/nashorn/internal/codegen/Lower.java + test/script/basic/NASHORN-837.js From attila.szegedi at oracle.com Tue Jan 8 02:52:02 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Tue, 8 Jan 2013 11:52:02 +0100 Subject: Review request for 8005801 Message-ID: Please review https://jbs.oracle.com/bugs/browse/JDK-8005801 at http://cr.openjdk.java.net/~attila/8005801/webrev.01 "ScriptObject.findSetMethod() is a huge, complex method. It needs to be refactored into an easy to understand form." Thanks, Attila. From marcus.lagergren at oracle.com Tue Jan 8 02:57:13 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Tue, 8 Jan 2013 11:57:13 +0100 Subject: Review request for 8005801 In-Reply-To: References: Message-ID: +1 On Jan 8, 2013, at 11:52 AM, Attila Szegedi wrote: > Please review https://jbs.oracle.com/bugs/browse/JDK-8005801 at http://cr.openjdk.java.net/~attila/8005801/webrev.01 > > "ScriptObject.findSetMethod() is a huge, complex method. It needs to be refactored into an easy to understand form." > > Thanks, > Attila. From marcus.lagergren at oracle.com Tue Jan 8 03:08:13 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Tue, 8 Jan 2013 12:08:13 +0100 Subject: Please review http://cr.openjdk.java.net/~lagergren/8005842/ - ASTWriter went into infinite loops Message-ID: <1B554E6E-262B-44AD-8F61-C63B426DAF3B@oracle.com> http://cr.openjdk.java.net/~lagergren/8005842/ /M From sundararajan.athijegannathan at oracle.com Tue Jan 8 03:26:04 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Tue, 08 Jan 2013 16:56:04 +0530 Subject: Please review http://cr.openjdk.java.net/~lagergren/8005842/ - ASTWriter went into infinite loops In-Reply-To: <1B554E6E-262B-44AD-8F61-C63B426DAF3B@oracle.com> References: <1B554E6E-262B-44AD-8F61-C63B426DAF3B@oracle.com> Message-ID: <50EC024C.8020002@oracle.com> +1 Marcus Lagergren wrote: > http://cr.openjdk.java.net/~lagergren/8005842/ > > /M > > From szegedia at gmail.com Tue Jan 8 03:26:49 2013 From: szegedia at gmail.com (Attila Szegedi) Date: Tue, 8 Jan 2013 12:26:49 +0100 Subject: Review request for JDK-8005846 Message-ID: <96B566F6-2956-485E-9D21-FB08002B42F7@gmail.com> Please review https://jbs.oracle.com/bugs/browse/JDK-8005846 at http://cr.openjdk.java.net/~attila/8005846/webrev.00 Thanks, Attila. From james.laskey at oracle.com Tue Jan 8 03:38:14 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Tue, 8 Jan 2013 07:38:14 -0400 Subject: Review request for JDK-8005846 In-Reply-To: <96B566F6-2956-485E-9D21-FB08002B42F7@gmail.com> References: <96B566F6-2956-485E-9D21-FB08002B42F7@gmail.com> Message-ID: <8B90878D-596D-4339-BC8A-E76D6F4049AA@oracle.com> +1 On 2013-01-08, at 7:26 AM, Attila Szegedi wrote: > Please review https://jbs.oracle.com/bugs/browse/JDK-8005846 at http://cr.openjdk.java.net/~attila/8005846/webrev.00 > > Thanks, > Attila. From sundararajan.athijegannathan at oracle.com Tue Jan 8 03:55:48 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Tue, 08 Jan 2013 17:25:48 +0530 Subject: Review request for JDK-8005846 In-Reply-To: <96B566F6-2956-485E-9D21-FB08002B42F7@gmail.com> References: <96B566F6-2956-485E-9D21-FB08002B42F7@gmail.com> Message-ID: <50EC0944.3040008@oracle.com> +1 Attila Szegedi wrote: > Please review https://jbs.oracle.com/bugs/browse/JDK-8005846 at http://cr.openjdk.java.net/~attila/8005846/webrev.00 > > Thanks, > Attila. From sundararajan.athijegannathan at oracle.com Tue Jan 8 04:03:01 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Tue, 08 Jan 2013 17:33:01 +0530 Subject: Review request for 8005801 In-Reply-To: References: Message-ID: <50EC0AF5.1010603@oracle.com> * The new file SetMethodCreator.java misses copyright header * SpillProperty "slot" field has been made package-private and non-final. Is it used outside class and is it updated after construction? -Sundar Attila Szegedi wrote: > Please review https://jbs.oracle.com/bugs/browse/JDK-8005801 at http://cr.openjdk.java.net/~attila/8005801/webrev.01 > > "ScriptObject.findSetMethod() is a huge, complex method. It needs to be refactored into an easy to understand form." > > Thanks, > Attila. From sundararajan.athijegannathan at oracle.com Tue Jan 8 04:12:33 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Tue, 08 Jan 2013 17:42:33 +0530 Subject: Review request for 8005801 In-Reply-To: <50EC0AF5.1010603@oracle.com> References: <50EC0AF5.1010603@oracle.com> Message-ID: <50EC0D31.7030304@oracle.com> My mistake. It was package-private and non-final. But changed to be private and final. The first comment is valid though.. -Sundar A. Sundararajan wrote: > > * The new file SetMethodCreator.java misses copyright header > * SpillProperty "slot" field has been made package-private and > non-final. Is it used outside class and is it updated after construction? > > -Sundar > > Attila Szegedi wrote: >> Please review https://jbs.oracle.com/bugs/browse/JDK-8005801 at >> http://cr.openjdk.java.net/~attila/8005801/webrev.01 >> >> "ScriptObject.findSetMethod() is a huge, complex method. It needs to >> be refactored into an easy to understand form." >> >> Thanks, >> Attila. > From attila.szegedi at oracle.com Tue Jan 8 04:50:46 2013 From: attila.szegedi at oracle.com (attila.szegedi at oracle.com) Date: Tue, 08 Jan 2013 12:50:46 +0000 Subject: hg: nashorn/jdk8/nashorn: 8005846: Remove Mangler in favor of Dynalink's NameCodec Message-ID: <20130108125047.8E79D470E9@hg.openjdk.java.net> Changeset: c5a321205f49 Author: attila Date: 2013-01-08 13:50 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/c5a321205f49 8005846: Remove Mangler in favor of Dynalink's NameCodec Reviewed-by: jlaskey, sundar ! src/jdk/nashorn/internal/codegen/Compiler.java From attila.szegedi at oracle.com Tue Jan 8 05:14:41 2013 From: attila.szegedi at oracle.com (attila.szegedi at oracle.com) Date: Tue, 08 Jan 2013 13:14:41 +0000 Subject: hg: nashorn/jdk8/nashorn: 8005801: Refactor findSetMethod Message-ID: <20130108131442.38E1B470EA@hg.openjdk.java.net> Changeset: 4620ac94e7dc Author: attila Date: 2013-01-08 14:14 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/4620ac94e7dc 8005801: Refactor findSetMethod Summary: findSetMethod() was a very large single method, very unreadable and unmaintainable. It was broken into easy-to-understand pieces. The refactoring required introduction of a comand-object like entity, SetMethodCreator, to contain the nontrivial transient state of the algorithm that made the original big method so resistant to refactoring in the first place. Reviewed-by: lagergren, sundar ! src/jdk/nashorn/internal/runtime/ScriptObject.java + src/jdk/nashorn/internal/runtime/SetMethodCreator.java ! src/jdk/nashorn/internal/runtime/SpillProperty.java - src/jdk/nashorn/internal/runtime/linker/Mangler.java From marcus.lagergren at oracle.com Tue Jan 8 05:52:09 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Tue, 8 Jan 2013 14:52:09 +0100 Subject: hg: nashorn/jdk8/nashorn: 8005801: Refactor findSetMethod In-Reply-To: <20130108131442.38E1B470EA@hg.openjdk.java.net> References: <20130108131442.38E1B470EA@hg.openjdk.java.net> Message-ID: <0AAA3B04-C077-457A-A05C-1CE07EACCEE9@oracle.com> +1 On Jan 8, 2013, at 2:14 PM, attila.szegedi at oracle.com wrote: > Changeset: 4620ac94e7dc > Author: attila > Date: 2013-01-08 14:14 +0100 > URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/4620ac94e7dc > > 8005801: Refactor findSetMethod > Summary: findSetMethod() was a very large single method, very unreadable and unmaintainable. It was broken into easy-to-understand pieces. The refactoring required introduction of a comand-object like entity, SetMethodCreator, to contain the nontrivial transient state of the algorithm that made the original big method so resistant to refactoring in the first place. > Reviewed-by: lagergren, sundar > > ! src/jdk/nashorn/internal/runtime/ScriptObject.java > + src/jdk/nashorn/internal/runtime/SetMethodCreator.java > ! src/jdk/nashorn/internal/runtime/SpillProperty.java > - src/jdk/nashorn/internal/runtime/linker/Mangler.java > From hannes.wallnoefer at oracle.com Tue Jan 8 06:21:05 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Tue, 08 Jan 2013 15:21:05 +0100 Subject: Please review http://cr.openjdk.java.net/~lagergren/8005842/ - ASTWriter went into infinite loops In-Reply-To: <1B554E6E-262B-44AD-8F61-C63B426DAF3B@oracle.com> References: <1B554E6E-262B-44AD-8F61-C63B426DAF3B@oracle.com> Message-ID: <50EC2B51.9080301@oracle.com> +1 Am 2013-01-08 12:08, schrieb Marcus Lagergren: > http://cr.openjdk.java.net/~lagergren/8005842/ > > /M > From marcus.lagergren at oracle.com Tue Jan 8 06:19:32 2013 From: marcus.lagergren at oracle.com (marcus.lagergren at oracle.com) Date: Tue, 08 Jan 2013 14:19:32 +0000 Subject: hg: nashorn/jdk8/nashorn: 8005842: Loops in ASTWriter. Corrected @Reference and @Ignore node annotation for IR nodes Message-ID: <20130108141933.70BD8470EE@hg.openjdk.java.net> Changeset: 69a4f0363d0f Author: lagergren Date: 2013-01-08 15:20 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/69a4f0363d0f 8005842: Loops in ASTWriter. Corrected @Reference and @Ignore node annotation for IR nodes Reviewed-by: hannesw, sundar ! src/jdk/nashorn/internal/ir/Block.java ! src/jdk/nashorn/internal/ir/FunctionNode.java ! src/jdk/nashorn/internal/ir/LabelNode.java ! src/jdk/nashorn/internal/ir/LabeledNode.java ! src/jdk/nashorn/internal/ir/ObjectNode.java ! src/jdk/nashorn/internal/ir/ReferenceNode.java ! src/jdk/nashorn/internal/ir/ReturnNode.java ! src/jdk/nashorn/internal/ir/SplitNode.java ! src/jdk/nashorn/internal/ir/SwitchNode.java ! src/jdk/nashorn/internal/ir/ThrowNode.java ! src/jdk/nashorn/internal/ir/TryNode.java ! src/jdk/nashorn/internal/ir/debug/ASTWriter.java From sundararajan.athijegannathan at oracle.com Tue Jan 8 07:13:49 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Tue, 08 Jan 2013 20:43:49 +0530 Subject: Review request 8005848 : assigning to global toString variable affects Object.prototype.toString Message-ID: <50EC37AD.7060602@oracle.com> Hi, Please review http://cr.openjdk.java.net/~sundar/8005848/ Thanks -Sundar From james.laskey at oracle.com Tue Jan 8 07:16:06 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Tue, 8 Jan 2013 11:16:06 -0400 Subject: Review request 8005848 : assigning to global toString variable affects Object.prototype.toString In-Reply-To: <50EC37AD.7060602@oracle.com> References: <50EC37AD.7060602@oracle.com> Message-ID: <8D43B048-BF3E-4D25-8C27-D948D9B12F1D@oracle.com> +1 On 2013-01-08, at 11:13 AM, A. Sundararajan wrote: > Hi, > > Please review http://cr.openjdk.java.net/~sundar/8005848/ > > Thanks > -Sundar From marcus.lagergren at oracle.com Tue Jan 8 07:21:48 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Tue, 8 Jan 2013 16:21:48 +0100 Subject: Review request 8005848 : assigning to global toString variable affects Object.prototype.toString In-Reply-To: <50EC37AD.7060602@oracle.com> References: <50EC37AD.7060602@oracle.com> Message-ID: +1 On Jan 8, 2013, at 4:13 PM, A. Sundararajan wrote: > Hi, > > Please review http://cr.openjdk.java.net/~sundar/8005848/ > > Thanks > -Sundar From sundararajan.athijegannathan at oracle.com Tue Jan 8 07:42:16 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Tue, 08 Jan 2013 15:42:16 +0000 Subject: hg: nashorn/jdk8/nashorn: 8005848: assigning to global toString variable affects Object.prototype.toString Message-ID: <20130108154218.34D56470F4@hg.openjdk.java.net> Changeset: 548587cfb065 Author: sundar Date: 2013-01-08 21:16 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/548587cfb065 8005848: assigning to global toString variable affects Object.prototype.toString Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/internal/runtime/ScriptObject.java + test/script/basic/JDK_8005848.js From rieberandreas at gmail.com Tue Jan 8 09:22:14 2013 From: rieberandreas at gmail.com (Andreas Rieber) Date: Tue, 08 Jan 2013 18:22:14 +0100 Subject: some nashorn testing Message-ID: <50EC55C6.1040109@gmail.com> Hi, i tested Nashorn with a project i am currently working on (scripting java). The first thing i spotted is that Rhino comes with print() and println() as default functions in: jdk8/jdk/src/share/classes/com/sun/script/javascript/RhinoScriptEngine.java while Nashorn has only a print(): jdk8/nashorn/src/jdk/nashorn/api/scripting/NashornScriptEngine.java jdk8/nashorn/src/jdk/nashorn/api/scripting/resources/engine.js Will this be changed or is that a migration issue? importClass works only with: load("nashorn:mozilla_compat.js"); What is with importPackage (also used in jrunscript)? Next problem i had was related to java array creation. Here the sample from JSE 7 Documentation "Java Scripting Programmer's Guide": // create Java String array of 5 elements var a = java.lang.reflect.Array.newInstance(java.lang.String, 5); // Accessing elements and length access is by usual Java syntax a[0] = "scripting is great!"; print(a.length); It works with Rhino but fails with Nashorn: Exception in thread "main" java.lang.RuntimeException: java.lang.NoSuchMethodException: None of the fixed arity signatures [(java.lang.Class, int[]), (java.lang.Class, int)] or the variable arity signatures [(java.lang.Class, int...)] of the method java.lang.reflect.Array.newInstance match the argument types [org.dynalang.dynalink.beans.StaticClass, java.lang.Integer] The default number type for Rhino in vararg functions is double while Nashorn has also integer (nice), might be a migration issue. Is jrunscript and the scriptpad sample application (jdk8/jdk/src/share/sample/scripting/scriptpad) now also developed under Nashorn project? I would like to contribute a patch for jrunscript (printf never worked and i added also a sprintf), the scriptpad needed only a few fixes to work with Rhino. I signed the OCA recently. best regards Andreas From attila.szegedi at oracle.com Tue Jan 8 10:05:22 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Tue, 8 Jan 2013 19:05:22 +0100 Subject: some nashorn testing In-Reply-To: <50EC55C6.1040109@gmail.com> References: <50EC55C6.1040109@gmail.com> Message-ID: <87349BDC-91EE-43E2-9B04-ABB08FCEAF2F@oracle.com> On Jan 8, 2013, at 6:22 PM, Andreas Rieber wrote: > > // create Java String array of 5 elements > var a = java.lang.reflect.Array.newInstance(java.lang.String, 5); > In Nashorn, the expression "java.lang.String" doesn't give you the Class object for String (just as it doesn't do it in Java, in Java you need to write "java.lang.String.class" (or just "String.class" due to autoimport of java.lang in Java); note the ".class"; the name of the type ("java.lang.String") is in Java used for constructor invocation as well as for access to static members - we happen to follow this practice in Nashorn. In Nashorn, you have several choices. I would suggest using the type() function on the Java built-in object: var a = new (Java.type("java.lang.String[]"))(5) You can find the explanation for integration of Nashorn into the Java type system in the JavaDoc for NativeJava class' type() and extend() methods (I might need to write a blog post about this as it keeps popping up?). If you expect to instantiate several arrays, it might make sense to do: var stringArrayType = Java.type("java.lang.String[]") var a = new stringArrayType(5) var b = new stringArrayType(10) ... You can keep using the Array.newInstance if you wish, but you'll need to tack .class at the end of java.lang.String: var a = java.lang.reflect.Array.newInstance(java.lang.String.class, 5); should work. Attila. From james.laskey at oracle.com Tue Jan 8 10:12:56 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Tue, 8 Jan 2013 14:12:56 -0400 Subject: some nashorn testing In-Reply-To: <50EC55C6.1040109@gmail.com> References: <50EC55C6.1040109@gmail.com> Message-ID: <405B16AC-2B92-4692-B7D3-C25FD0300A81@oracle.com> On 2013-01-08, at 1:22 PM, Andreas Rieber wrote: > Hi, > > i tested Nashorn with a project i am currently working on (scripting > java). The first thing i spotted is that Rhino comes with print() and > println() as default functions in: > > jdk8/jdk/src/share/classes/com/sun/script/javascript/RhinoScriptEngine.java > > while Nashorn has only a print(): > > jdk8/nashorn/src/jdk/nashorn/api/scripting/NashornScriptEngine.java > jdk8/nashorn/src/jdk/nashorn/api/scripting/resources/engine.js > > Will this be changed or is that a migration issue? We opted for print because we were primarily using V8 performance tests and v8 only supports print. Standalone rhino does not support println either. We did have a switch for turning on println, but it fell out of favour to be consistent with other VMs. You can duplicate the behaviour with; function print(s) { java.lang.System.out.print("" + s); } function println(s) { java.lang.System.out.println("" + s); } > > importClass works only with: load("nashorn:mozilla_compat.js"); > What is with importPackage (also used in jrunscript)? > importClass is being phased out since it duplicates the builtin behaviour of Packages and JavaClass. importPackage(java.awt); importClass(java.awt.Frame); is just var awt = java.awt; var Frame = java.awt.Frame; > Next problem i had was related to java array creation. Here the sample > from JSE 7 Documentation "Java Scripting Programmer's Guide": > > // create Java String array of 5 elements > var a = java.lang.reflect.Array.newInstance(java.lang.String, 5); > > // Accessing elements and length access is by usual Java syntax > a[0] = "scripting is great!"; > print(a.length); > > It works with Rhino but fails with Nashorn: > > Exception in thread "main" java.lang.RuntimeException: java.lang.NoSuchMethodException: None of the fixed arity signatures [(java.lang.Class, int[]), (java.lang.Class, int)] or the variable arity signatures [(java.lang.Class, int...)] of the method java.lang.reflect.Array.newInstance match the argument types [org.dynalang.dynalink.beans.StaticClass, java.lang.Integer] > > The default number type for Rhino in vararg functions is double while > Nashorn has also integer (nice), might be a migration issue. We are pushing the Java syntax here to eliminate confusion between the java class and the JavaClass javascript object. This eliminates the confusion when accessing members of the (String) class when a javascript object and members of the class itself when a java object. jjs> java.lang.String [JavaClass java.lang.String] jjs> java.lang.String.class class java.lang.String so var a = java.lang.reflect.Array.newInstance(java.lang.String.class, 5); > > Is jrunscript and the scriptpad sample application > (jdk8/jdk/src/share/sample/scripting/scriptpad) now also developed > under Nashorn project? I would like to contribute a patch for > jrunscript (printf never worked and i added also a sprintf), the > scriptpad needed only a few fixes to work with Rhino. I signed the OCA > recently. Contributions welcome. I just see Attila answered differently, but both forms work. > > best regards > Andreas > From rieberandreas at gmail.com Tue Jan 8 10:53:09 2013 From: rieberandreas at gmail.com (Andreas Rieber) Date: Tue, 08 Jan 2013 19:53:09 +0100 Subject: some nashorn testing In-Reply-To: <405B16AC-2B92-4692-B7D3-C25FD0300A81@oracle.com> References: <50EC55C6.1040109@gmail.com> <405B16AC-2B92-4692-B7D3-C25FD0300A81@oracle.com> Message-ID: <50EC6B15.2000801@gmail.com> On 08.01.13 19:12, Jim Laskey (Oracle) wrote: > On 2013-01-08, at 1:22 PM, Andreas Rieber wrote: > >> Hi, >> >> i tested Nashorn with a project i am currently working on (scripting >> java). The first thing i spotted is that Rhino comes with print() and >> println() as default functions in: >> >> jdk8/jdk/src/share/classes/com/sun/script/javascript/RhinoScriptEngine.java >> >> while Nashorn has only a print(): >> >> jdk8/nashorn/src/jdk/nashorn/api/scripting/NashornScriptEngine.java >> jdk8/nashorn/src/jdk/nashorn/api/scripting/resources/engine.js >> >> Will this be changed or is that a migration issue? > We opted for print because we were primarily using V8 performance tests and v8 only supports print. Standalone rhino does not support println either. We did have a switch for turning on println, but it fell out of favour to be consistent with other VMs. > > You can duplicate the behaviour with; > > function print(s) { java.lang.System.out.print("" + s); } > function println(s) { java.lang.System.out.println("" + s); } Well, i would use the print/println versions from jdk8/jdk/src/share/classes/com/sun/script/javascript/RhinoScriptEngine.java because they use context.getWriter(). One might set/change with context.setWriter(). >> importClass works only with: load("nashorn:mozilla_compat.js"); >> What is with importPackage (also used in jrunscript)? >> > importClass is being phased out since it duplicates the builtin behaviour of Packages and JavaClass. > > importPackage(java.awt); > importClass(java.awt.Frame); > > is just > > var awt = java.awt; > var Frame = java.awt.Frame; > > >> Next problem i had was related to java array creation. Here the sample >> from JSE 7 Documentation "Java Scripting Programmer's Guide": >> >> // create Java String array of 5 elements >> var a = java.lang.reflect.Array.newInstance(java.lang.String, 5); >> >> // Accessing elements and length access is by usual Java syntax >> a[0] = "scripting is great!"; >> print(a.length); >> >> It works with Rhino but fails with Nashorn: >> >> Exception in thread "main" java.lang.RuntimeException: java.lang.NoSuchMethodException: None of the fixed arity signatures [(java.lang.Class, int[]), (java.lang.Class, int)] or the variable arity signatures [(java.lang.Class, int...)] of the method java.lang.reflect.Array.newInstance match the argument types [org.dynalang.dynalink.beans.StaticClass, java.lang.Integer] >> >> The default number type for Rhino in vararg functions is double while >> Nashorn has also integer (nice), might be a migration issue. > > We are pushing the Java syntax here to eliminate confusion between the java class and the JavaClass javascript object. This eliminates the confusion when accessing members of the (String) class when a javascript object and members of the class itself when a java object. > > jjs> java.lang.String > [JavaClass java.lang.String] > jjs> java.lang.String.class > class java.lang.String > > so > > var a = java.lang.reflect.Array.newInstance(java.lang.String.class, 5); I worked around the issues, no problem. I use IcedTea7 which comes with Rhino (no standalone Rhino). So i just wrote it down for others which might want to migrate later. >> Is jrunscript and the scriptpad sample application >> (jdk8/jdk/src/share/sample/scripting/scriptpad) now also developed >> under Nashorn project? I would like to contribute a patch for >> jrunscript (printf never worked and i added also a sprintf), the >> scriptpad needed only a few fixes to work with Rhino. I signed the OCA >> recently. > Contributions welcome. Coming soon, need to change the patch so it works with Rhino and Nashorn. The number handling is pretty interesting to handle now. > > I just see Attila answered differently, but both forms work. > > >> best regards >> Andreas >> From rieberandreas at gmail.com Tue Jan 8 12:30:58 2013 From: rieberandreas at gmail.com (Andreas Rieber) Date: Tue, 08 Jan 2013 21:30:58 +0100 Subject: some nashorn testing In-Reply-To: <87349BDC-91EE-43E2-9B04-ABB08FCEAF2F@oracle.com> References: <50EC55C6.1040109@gmail.com> <87349BDC-91EE-43E2-9B04-ABB08FCEAF2F@oracle.com> Message-ID: <50EC8202.4060004@gmail.com> On 08.01.13 19:05, Attila Szegedi wrote: > On Jan 8, 2013, at 6:22 PM, Andreas Rieber > wrote: > >> >> // create Java String array of 5 elements >> var a = java.lang.reflect.Array.newInstance(java.lang.String, 5); >> > > In Nashorn, the expression "java.lang.String" doesn't give you the > Class object for String (just as it doesn't do it in Java, in Java you > need to write "java.lang.String.class" (or just "String.class" due to > autoimport of java.lang in Java); note the ".class"; the name of the > type ("java.lang.String") is in Java used for constructor invocation > as well as for access to static members - we happen to follow this > practice in Nashorn. > > In Nashorn, you have several choices. I would suggest using the type() > function on the Java built-in object: > > var a = new (Java.type("java.lang.String[]"))(5) > > You can find the explanation for integration of Nashorn into the Java > type system in the JavaDoc for NativeJava class' type() and extend() > methods (I might need to write a blog post about this as it keeps > popping up?). > > If you expect to instantiate several arrays, it might make sense to do: > > var stringArrayType = Java.type("java.lang.String[]") > > var a = new stringArrayType(5) > var b = new stringArrayType(10) > ... > > > You can keep using the Array.newInstance if you wish, but you'll need > to tack .class at the end of java.lang.String: > > var a = > java.lang.reflect.Array.newInstance(java.lang.String*.class*, 5); > > should work. > > Attila. > I tried some cases and will go for (Nashorn and Rhino): var array; try { array = new (Java.type("java.lang.Object[]"))(len); } catch (x) { array = []; } The catch block works with Rhino but gives with Nashorn: Exception in thread "main" java.lang.ClassCastException: Cannot cast jdk.nashorn.internal.objects.NativeArray to [Ljava.lang.Object; at sun.invoke.util.ValueConversions.newClassCastException(ValueConversions.java:461) at sun.invoke.util.ValueConversions.castReference(ValueConversions.java:456) at jdk.nashorn.internal.scripts.Script$main.sprintf(main.js:114) at jdk.nashorn.internal.runtime.ScriptFunction.invoke(ScriptFunction.java:350) at jdk.nashorn.internal.runtime.ScriptRuntime.apply(ScriptRuntime.java:310) at jdk.nashorn.internal.objects.NativeFunction.apply(NativeFunction.java:133) cheers Andreas From attila.szegedi at oracle.com Tue Jan 8 13:49:15 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Tue, 8 Jan 2013 22:49:15 +0100 Subject: some nashorn testing In-Reply-To: <50EC8202.4060004@gmail.com> References: <50EC55C6.1040109@gmail.com> <87349BDC-91EE-43E2-9B04-ABB08FCEAF2F@oracle.com> <50EC8202.4060004@gmail.com> Message-ID: <21D8E6BB-126A-4DC3-AE74-6CB1B2DC4DBE@oracle.com> Hey Marcus and Jim, this is similar to that bug we saw before with array literals in the ternary operator. Something related to codegen's inference of types? On Jan 8, 2013, at 9:30 PM, Andreas Rieber wrote: > I tried some cases and will go for (Nashorn and Rhino): > > var array; > try { > array = new (Java.type("java.lang.Object[]"))(len); > } catch (x) { > array = []; > } > > The catch block works with Rhino but gives with Nashorn: > > Exception in thread "main" java.lang.ClassCastException: Cannot cast jdk.nashorn.internal.objects.NativeArray to [Ljava.lang.Object; > at sun.invoke.util.ValueConversions.newClassCastException(ValueConversions.java:461) > at sun.invoke.util.ValueConversions.castReference(ValueConversions.java:456) > at jdk.nashorn.internal.scripts.Script$main.sprintf(main.js:114) > at jdk.nashorn.internal.runtime.ScriptFunction.invoke(ScriptFunction.java:350) > at jdk.nashorn.internal.runtime.ScriptRuntime.apply(ScriptRuntime.java:310) > at jdk.nashorn.internal.objects.NativeFunction.apply(NativeFunction.java:133) > > > cheers > Andreas > From forax at univ-mlv.fr Tue Jan 8 13:56:14 2013 From: forax at univ-mlv.fr (Remi Forax) Date: Tue, 08 Jan 2013 22:56:14 +0100 Subject: some nashorn testing In-Reply-To: <21D8E6BB-126A-4DC3-AE74-6CB1B2DC4DBE@oracle.com> References: <50EC55C6.1040109@gmail.com> <87349BDC-91EE-43E2-9B04-ABB08FCEAF2F@oracle.com> <50EC8202.4060004@gmail.com> <21D8E6BB-126A-4DC3-AE74-6CB1B2DC4DBE@oracle.com> Message-ID: <50EC95FE.6000106@univ-mlv.fr> On 01/08/2013 10:49 PM, Attila Szegedi wrote: > Hey Marcus and Jim, this is similar to that bug we saw before with array literals in the ternary operator. Something related to codegen's inference of types? a simple workaround is to change the last line var array; try { array = new (Java.type("java.lang.Object[]"))(len); // array is Object[] } catch (x) { //array = []; // array is NativeArray array = new (Java.type("java.lang.Object[]"))(0); // array is Object[] } R?mi > > On Jan 8, 2013, at 9:30 PM, Andreas Rieber wrote: > >> I tried some cases and will go for (Nashorn and Rhino): >> >> var array; >> try { >> array = new (Java.type("java.lang.Object[]"))(len); >> } catch (x) { >> array = []; >> } >> >> The catch block works with Rhino but gives with Nashorn: >> >> Exception in thread "main" java.lang.ClassCastException: Cannot cast jdk.nashorn.internal.objects.NativeArray to [Ljava.lang.Object; >> at sun.invoke.util.ValueConversions.newClassCastException(ValueConversions.java:461) >> at sun.invoke.util.ValueConversions.castReference(ValueConversions.java:456) >> at jdk.nashorn.internal.scripts.Script$main.sprintf(main.js:114) >> at jdk.nashorn.internal.runtime.ScriptFunction.invoke(ScriptFunction.java:350) >> at jdk.nashorn.internal.runtime.ScriptRuntime.apply(ScriptRuntime.java:310) >> at jdk.nashorn.internal.objects.NativeFunction.apply(NativeFunction.java:133) >> >> >> cheers >> Andreas >> From marcus.lagergren at oracle.com Tue Jan 8 21:45:46 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Wed, 9 Jan 2013 06:45:46 +0100 Subject: Testing Message-ID: Hi guys! Just wanted to check that testing is moving to the open jdk repo, as we will not be checking anything else into the kenai one. Is this already automated, or are the nightly testing mails results of running on the Kenai repo? /M From marcus.lagergren at oracle.com Tue Jan 8 23:45:21 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Wed, 9 Jan 2013 08:45:21 +0100 Subject: some nashorn testing In-Reply-To: <50EC95FE.6000106@univ-mlv.fr> References: <50EC55C6.1040109@gmail.com> <87349BDC-91EE-43E2-9B04-ABB08FCEAF2F@oracle.com> <50EC8202.4060004@gmail.com> <21D8E6BB-126A-4DC3-AE74-6CB1B2DC4DBE@oracle.com> <50EC95FE.6000106@univ-mlv.fr> Message-ID: Remi, Andreas I can't reproduce your problem running java -jar nashorn.jar script.js where script.js is -- var array; try { array = new (Java.type("java.lang.Object[]"))(len); } catch (x) { array = []; } -- Do you have a reproducer you can send me ? I know there was a bug regarding array literal types just before Christmas, but it's in the openjdk as far as I can tell. Regards Marcus On Jan 8, 2013, at 10:56 PM, Remi Forax wrote: > On 01/08/2013 10:49 PM, Attila Szegedi wrote: >> Hey Marcus and Jim, this is similar to that bug we saw before with array literals in the ternary operator. Something related to codegen's inference of types? > > a simple workaround is to change the last line > > var array; > try { > array = new (Java.type("java.lang.Object[]"))(len); // array is Object[] > } catch (x) { > //array = []; // array is NativeArray > array = new (Java.type("java.lang.Object[]"))(0); // array is Object[] > } > > R?mi > >> >> On Jan 8, 2013, at 9:30 PM, Andreas Rieber wrote: >> >>> I tried some cases and will go for (Nashorn and Rhino): >>> >>> var array; >>> try { >>> array = new (Java.type("java.lang.Object[]"))(len); >>> } catch (x) { >>> array = []; >>> } >>> >>> The catch block works with Rhino but gives with Nashorn: >>> >>> Exception in thread "main" java.lang.ClassCastException: Cannot cast jdk.nashorn.internal.objects.NativeArray to [Ljava.lang.Object; >>> at sun.invoke.util.ValueConversions.newClassCastException(ValueConversions.java:461) >>> at sun.invoke.util.ValueConversions.castReference(ValueConversions.java:456) >>> at jdk.nashorn.internal.scripts.Script$main.sprintf(main.js:114) >>> at jdk.nashorn.internal.runtime.ScriptFunction.invoke(ScriptFunction.java:350) >>> at jdk.nashorn.internal.runtime.ScriptRuntime.apply(ScriptRuntime.java:310) >>> at jdk.nashorn.internal.objects.NativeFunction.apply(NativeFunction.java:133) >>> >>> >>> cheers >>> Andreas >>> > From marcus.lagergren at oracle.com Tue Jan 8 23:59:47 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Wed, 9 Jan 2013 08:59:47 +0100 Subject: some nashorn testing In-Reply-To: References: <50EC55C6.1040109@gmail.com> <87349BDC-91EE-43E2-9B04-ABB08FCEAF2F@oracle.com> <50EC8202.4060004@gmail.com> <21D8E6BB-126A-4DC3-AE74-6CB1B2DC4DBE@oracle.com> <50EC95FE.6000106@univ-mlv.fr> Message-ID: > > > Do you have a reproducer you can send me ? I know there was a bug regarding array literal types just before Christmas, but it's in the openjdk as far as I can tell. s/it's in the openjdk/it is NOT in the openjdk/g /M From james.laskey at oracle.com Wed Jan 9 02:33:35 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Wed, 9 Jan 2013 06:33:35 -0400 Subject: Testing In-Reply-To: References: Message-ID: <7E1815A7-1487-4B7C-91C5-50D0F4EE6F75@oracle.com> They are probably waiting for us to set up closedjdk, and then the ask. Sent from my iPhone 4 On 2013-01-09, at 1:45 AM, Marcus Lagergren wrote: > Hi guys! > > Just wanted to check that testing is moving to the open jdk repo, as we will not be checking anything else into the kenai one. Is this already automated, or are the nightly testing mails results of running on the Kenai repo? > > /M > From attila.szegedi at oracle.com Wed Jan 9 04:59:18 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Wed, 9 Jan 2013 13:59:18 +0100 Subject: Please review JDK-8005777 Message-ID: <4C57D03A-CED6-416C-B5A2-8D24ECA15EBF@oracle.com> Please review JDK-8005777; the webrev at is trivial as it only specifies a different Dynalink snapshot version; the actual fix is in Dynalink at Thank you, Attila. From marcus.lagergren at oracle.com Wed Jan 9 05:26:51 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Wed, 9 Jan 2013 14:26:51 +0100 Subject: Please review JDK-8005777 In-Reply-To: <4C57D03A-CED6-416C-B5A2-8D24ECA15EBF@oracle.com> References: <4C57D03A-CED6-416C-B5A2-8D24ECA15EBF@oracle.com> Message-ID: That looks good. +1 /M On Jan 9, 2013, at 1:59 PM, Attila Szegedi wrote: > Please review JDK-8005777; the webrev at is trivial as it only specifies a different Dynalink snapshot version; the actual fix is in Dynalink at > > Thank you, > Attila. From sundararajan.athijegannathan at oracle.com Wed Jan 9 05:31:02 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Wed, 09 Jan 2013 19:01:02 +0530 Subject: Please review JDK-8005777 In-Reply-To: <4C57D03A-CED6-416C-B5A2-8D24ECA15EBF@oracle.com> References: <4C57D03A-CED6-416C-B5A2-8D24ECA15EBF@oracle.com> Message-ID: <50ED7116.9030302@oracle.com> +1 Attila Szegedi wrote: > Please review JDK-8005777; the webrev at is trivial as it only specifies a different Dynalink snapshot version; the actual fix is in Dynalink at > > Thank you, > Attila. From attila.szegedi at oracle.com Wed Jan 9 06:03:05 2013 From: attila.szegedi at oracle.com (attila.szegedi at oracle.com) Date: Wed, 09 Jan 2013 14:03:05 +0000 Subject: hg: nashorn/jdk8/nashorn: 8005777: Bug in the FacetIntrospector of Dynalink - non-public class should search super Message-ID: <20130109140306.8B9D947140@hg.openjdk.java.net> Changeset: 812b9963b1c7 Author: attila Date: 2013-01-09 15:02 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/812b9963b1c7 8005777: Bug in the FacetIntrospector of Dynalink - non-public class should search super Reviewed-by: lagergren, sundar ! make/project.properties From rieberandreas at gmail.com Wed Jan 9 06:51:10 2013 From: rieberandreas at gmail.com (Andreas Rieber) Date: Wed, 09 Jan 2013 15:51:10 +0100 Subject: some nashorn testing In-Reply-To: References: <50EC55C6.1040109@gmail.com> <87349BDC-91EE-43E2-9B04-ABB08FCEAF2F@oracle.com> <50EC8202.4060004@gmail.com> <21D8E6BB-126A-4DC3-AE74-6CB1B2DC4DBE@oracle.com> <50EC95FE.6000106@univ-mlv.fr> Message-ID: <50ED83DE.5010703@gmail.com> Hi Marcus and Remi, please find attached a better test to reproduce. Rhino output: ------------- data 0 : 1.0 data 1 : 2.0 data 2 : 3.0 Nashorn output: --------------- Exception in thread "main" java.lang.ClassCastException: Cannot cast jdk.nashorn.internal.objects.NativeArray to [Ljava.lang.Object; at sun.invoke.util.ValueConversions.newClassCastException(ValueConversions.java:461) at sun.invoke.util.ValueConversions.castReference(ValueConversions.java:456) at jdk.nashorn.internal.scripts.Script$\^eval\_.varargFunc(:10) at jdk.nashorn.internal.scripts.Script$\^eval\_.runScript(:13) at jdk.nashorn.internal.runtime.ScriptFunction.invoke(ScriptFunction.java:359) at jdk.nashorn.internal.runtime.ScriptRuntime.apply(ScriptRuntime.java:310) at jdk.nashorn.api.scripting.NashornScriptEngine.evalImpl(NashornScriptEngine.java:438) at jdk.nashorn.api.scripting.NashornScriptEngine.evalImpl(NashornScriptEngine.java:423) at jdk.nashorn.api.scripting.NashornScriptEngine.eval(NashornScriptEngine.java:150) at javax.script.AbstractScriptEngine.eval(AbstractScriptEngine.java:264) at ObjectArray.main(ObjectArray.java:16) On 09.01.13 08:45, Marcus Lagergren wrote: > Remi, Andreas > > I can't reproduce your problem running > > java -jar nashorn.jar script.js > > where script.js is > > -- > var array; > try { > array = new (Java.type("java.lang.Object[]"))(len); > } catch (x) { > array = []; > } > -- > > Do you have a reproducer you can send me ? I know there was a bug regarding array literal types just before Christmas, but it's in the openjdk as far as I can tell. > > Regards > Marcus > > > On Jan 8, 2013, at 10:56 PM, Remi Forax wrote: > >> On 01/08/2013 10:49 PM, Attila Szegedi wrote: >>> Hey Marcus and Jim, this is similar to that bug we saw before with array literals in the ternary operator. Something related to codegen's inference of types? >> a simple workaround is to change the last line >> >> var array; >> try { >> array = new (Java.type("java.lang.Object[]"))(len); // array is Object[] >> } catch (x) { >> //array = []; // array is NativeArray >> array = new (Java.type("java.lang.Object[]"))(0); // array is Object[] >> } >> >> R?mi >> >>> On Jan 8, 2013, at 9:30 PM, Andreas Rieber wrote: >>> >>>> I tried some cases and will go for (Nashorn and Rhino): >>>> >>>> var array; >>>> try { >>>> array = new (Java.type("java.lang.Object[]"))(len); >>>> } catch (x) { >>>> array = []; >>>> } >>>> >>>> The catch block works with Rhino but gives with Nashorn: >>>> >>>> Exception in thread "main" java.lang.ClassCastException: Cannot cast jdk.nashorn.internal.objects.NativeArray to [Ljava.lang.Object; >>>> at sun.invoke.util.ValueConversions.newClassCastException(ValueConversions.java:461) >>>> at sun.invoke.util.ValueConversions.castReference(ValueConversions.java:456) >>>> at jdk.nashorn.internal.scripts.Script$main.sprintf(main.js:114) >>>> at jdk.nashorn.internal.runtime.ScriptFunction.invoke(ScriptFunction.java:350) >>>> at jdk.nashorn.internal.runtime.ScriptRuntime.apply(ScriptRuntime.java:310) >>>> at jdk.nashorn.internal.objects.NativeFunction.apply(NativeFunction.java:133) >>>> >>>> >>>> cheers >>>> Andreas >>>> -------------- next part -------------- import javax.script.*; public class ObjectArray { public static void objFunc(String input, Object[] data) { for (int i = 0; i < data.length; i++) { System.out.println("data " + i + " : " + data[i]); } } public static void main( String args[]) throws Exception { ScriptEngineManager manager = new ScriptEngineManager(); ScriptEngine engine = manager.getEngineByName("js"); engine.eval("\n" + "function varargFunc(firstParam) {\n" + " var len = arguments.length - 1;\n" + " var array = [];\n" + "\n" + " for (var i = 0; i < len; i++) {\n" + " array[i] = arguments[i+1];\n" + " }\n" + "\n" + " return Packages.ObjectArray.objFunc(firstParam, array);\n" + "};\n" + "\n" + "varargFunc('test',1,2,3);\n"); } } From marcus.lagergren at oracle.com Wed Jan 9 07:26:57 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Wed, 9 Jan 2013 16:26:57 +0100 Subject: some nashorn testing In-Reply-To: <50ED83DE.5010703@gmail.com> References: <50EC55C6.1040109@gmail.com> <87349BDC-91EE-43E2-9B04-ABB08FCEAF2F@oracle.com> <50EC8202.4060004@gmail.com> <21D8E6BB-126A-4DC3-AE74-6CB1B2DC4DBE@oracle.com> <50EC95FE.6000106@univ-mlv.fr> <50ED83DE.5010703@gmail.com> Message-ID: <98C104F3-F3F1-4FE7-B07A-454CB483B2AD@oracle.com> Where did you get/build your nashorn.jar? We'll get proper versioning in there as soon as we've integrated fully with the OpenJDK build system. I still get nothing when I manually build the latest nashorn.jar from the openjdk and run the JS snippet from the command line with java -jar nashorn.jar (Haven't gone through the script engine bridge, but as it seems to be a JavaScript problem it should be sufficient to run it as a standalone script). This very much looks like a bug that I fixed before christmas and pushed into the closed repo - I've verified that it made it into the openjdk source. /M On Jan 9, 2013, at 3:51 PM, Andreas Rieber wrote: > Hi Marcus and Remi, > > please find attached a better test to reproduce. > > Rhino output: > ------------- > data 0 : 1.0 > data 1 : 2.0 > data 2 : 3.0 > > Nashorn output: > --------------- > Exception in thread "main" java.lang.ClassCastException: Cannot cast jdk.nashorn.internal.objects.NativeArray to [Ljava.lang.Object; > at sun.invoke.util.ValueConversions.newClassCastException(ValueConversions.java:461) > at sun.invoke.util.ValueConversions.castReference(ValueConversions.java:456) > at jdk.nashorn.internal.scripts.Script$\^eval\_.varargFunc(:10) > at jdk.nashorn.internal.scripts.Script$\^eval\_.runScript(:13) > at jdk.nashorn.internal.runtime.ScriptFunction.invoke(ScriptFunction.java:359) > at jdk.nashorn.internal.runtime.ScriptRuntime.apply(ScriptRuntime.java:310) > at jdk.nashorn.api.scripting.NashornScriptEngine.evalImpl(NashornScriptEngine.java:438) > at jdk.nashorn.api.scripting.NashornScriptEngine.evalImpl(NashornScriptEngine.java:423) > at jdk.nashorn.api.scripting.NashornScriptEngine.eval(NashornScriptEngine.java:150) > at javax.script.AbstractScriptEngine.eval(AbstractScriptEngine.java:264) > at ObjectArray.main(ObjectArray.java:16) > > > > On 09.01.13 08:45, Marcus Lagergren wrote: >> Remi, Andreas >> >> I can't reproduce your problem running >> >> java -jar nashorn.jar script.js >> >> where script.js is >> >> -- >> var array; >> try { >> array = new (Java.type("java.lang.Object[]"))(len); >> } catch (x) { >> array = []; >> } >> -- >> >> Do you have a reproducer you can send me ? I know there was a bug regarding array literal types just before Christmas, but it's in the openjdk as far as I can tell. >> >> Regards >> Marcus >> >> >> On Jan 8, 2013, at 10:56 PM, Remi Forax wrote: >> >>> On 01/08/2013 10:49 PM, Attila Szegedi wrote: >>>> Hey Marcus and Jim, this is similar to that bug we saw before with array literals in the ternary operator. Something related to codegen's inference of types? >>> a simple workaround is to change the last line >>> >>> var array; >>> try { >>> array = new (Java.type("java.lang.Object[]"))(len); // array is Object[] >>> } catch (x) { >>> //array = []; // array is NativeArray >>> array = new (Java.type("java.lang.Object[]"))(0); // array is Object[] >>> } >>> >>> R?mi >>> >>>> On Jan 8, 2013, at 9:30 PM, Andreas Rieber wrote: >>>> >>>>> I tried some cases and will go for (Nashorn and Rhino): >>>>> >>>>> var array; >>>>> try { >>>>> array = new (Java.type("java.lang.Object[]"))(len); >>>>> } catch (x) { >>>>> array = []; >>>>> } >>>>> >>>>> The catch block works with Rhino but gives with Nashorn: >>>>> >>>>> Exception in thread "main" java.lang.ClassCastException: Cannot cast jdk.nashorn.internal.objects.NativeArray to [Ljava.lang.Object; >>>>> at sun.invoke.util.ValueConversions.newClassCastException(ValueConversions.java:461) >>>>> at sun.invoke.util.ValueConversions.castReference(ValueConversions.java:456) >>>>> at jdk.nashorn.internal.scripts.Script$main.sprintf(main.js:114) >>>>> at jdk.nashorn.internal.runtime.ScriptFunction.invoke(ScriptFunction.java:350) >>>>> at jdk.nashorn.internal.runtime.ScriptRuntime.apply(ScriptRuntime.java:310) >>>>> at jdk.nashorn.internal.objects.NativeFunction.apply(NativeFunction.java:133) >>>>> >>>>> >>>>> cheers >>>>> Andreas >>>>> > From rieberandreas at gmail.com Wed Jan 9 07:34:35 2013 From: rieberandreas at gmail.com (Andreas Rieber) Date: Wed, 09 Jan 2013 16:34:35 +0100 Subject: some nashorn testing In-Reply-To: <98C104F3-F3F1-4FE7-B07A-454CB483B2AD@oracle.com> References: <50EC55C6.1040109@gmail.com> <87349BDC-91EE-43E2-9B04-ABB08FCEAF2F@oracle.com> <50EC8202.4060004@gmail.com> <21D8E6BB-126A-4DC3-AE74-6CB1B2DC4DBE@oracle.com> <50EC95FE.6000106@univ-mlv.fr> <50ED83DE.5010703@gmail.com> <98C104F3-F3F1-4FE7-B07A-454CB483B2AD@oracle.com> Message-ID: <50ED8E0B.2030501@gmail.com> I use nashorn clone from http://hg.openjdk.java.net/nashorn/jdk8/nashorn last update yesterday evening, and it doesn't work as standalone js program as it fails scripting java so you would need to compile the sample. On 09.01.13 16:26, Marcus Lagergren wrote: > Where did you get/build your nashorn.jar? We'll get proper versioning in there as soon as we've integrated fully with the OpenJDK build system. I still get nothing when I manually build the latest nashorn.jar from the openjdk and run the JS snippet from the command line with java -jar nashorn.jar (Haven't gone through the script engine bridge, but as it seems to be a JavaScript problem it should be sufficient to run it as a standalone script). This very much looks like a bug that I fixed before christmas and pushed into the closed repo - I've verified that it made it into the openjdk source. > /M > > On Jan 9, 2013, at 3:51 PM, Andreas Rieber wrote: > >> Hi Marcus and Remi, >> >> please find attached a better test to reproduce. >> >> Rhino output: >> ------------- >> data 0 : 1.0 >> data 1 : 2.0 >> data 2 : 3.0 >> >> Nashorn output: >> --------------- >> Exception in thread "main" java.lang.ClassCastException: Cannot cast jdk.nashorn.internal.objects.NativeArray to [Ljava.lang.Object; >> at sun.invoke.util.ValueConversions.newClassCastException(ValueConversions.java:461) >> at sun.invoke.util.ValueConversions.castReference(ValueConversions.java:456) >> at jdk.nashorn.internal.scripts.Script$\^eval\_.varargFunc(:10) >> at jdk.nashorn.internal.scripts.Script$\^eval\_.runScript(:13) >> at jdk.nashorn.internal.runtime.ScriptFunction.invoke(ScriptFunction.java:359) >> at jdk.nashorn.internal.runtime.ScriptRuntime.apply(ScriptRuntime.java:310) >> at jdk.nashorn.api.scripting.NashornScriptEngine.evalImpl(NashornScriptEngine.java:438) >> at jdk.nashorn.api.scripting.NashornScriptEngine.evalImpl(NashornScriptEngine.java:423) >> at jdk.nashorn.api.scripting.NashornScriptEngine.eval(NashornScriptEngine.java:150) >> at javax.script.AbstractScriptEngine.eval(AbstractScriptEngine.java:264) >> at ObjectArray.main(ObjectArray.java:16) >> >> >> >> On 09.01.13 08:45, Marcus Lagergren wrote: >>> Remi, Andreas >>> >>> I can't reproduce your problem running >>> >>> java -jar nashorn.jar script.js >>> >>> where script.js is >>> >>> -- >>> var array; >>> try { >>> array = new (Java.type("java.lang.Object[]"))(len); >>> } catch (x) { >>> array = []; >>> } >>> -- >>> >>> Do you have a reproducer you can send me ? I know there was a bug regarding array literal types just before Christmas, but it's in the openjdk as far as I can tell. >>> >>> Regards >>> Marcus >>> >>> >>> On Jan 8, 2013, at 10:56 PM, Remi Forax wrote: >>> >>>> On 01/08/2013 10:49 PM, Attila Szegedi wrote: >>>>> Hey Marcus and Jim, this is similar to that bug we saw before with array literals in the ternary operator. Something related to codegen's inference of types? >>>> a simple workaround is to change the last line >>>> >>>> var array; >>>> try { >>>> array = new (Java.type("java.lang.Object[]"))(len); // array is Object[] >>>> } catch (x) { >>>> //array = []; // array is NativeArray >>>> array = new (Java.type("java.lang.Object[]"))(0); // array is Object[] >>>> } >>>> >>>> R?mi >>>> >>>>> On Jan 8, 2013, at 9:30 PM, Andreas Rieber wrote: >>>>> >>>>>> I tried some cases and will go for (Nashorn and Rhino): >>>>>> >>>>>> var array; >>>>>> try { >>>>>> array = new (Java.type("java.lang.Object[]"))(len); >>>>>> } catch (x) { >>>>>> array = []; >>>>>> } >>>>>> >>>>>> The catch block works with Rhino but gives with Nashorn: >>>>>> >>>>>> Exception in thread "main" java.lang.ClassCastException: Cannot cast jdk.nashorn.internal.objects.NativeArray to [Ljava.lang.Object; >>>>>> at sun.invoke.util.ValueConversions.newClassCastException(ValueConversions.java:461) >>>>>> at sun.invoke.util.ValueConversions.castReference(ValueConversions.java:456) >>>>>> at jdk.nashorn.internal.scripts.Script$main.sprintf(main.js:114) >>>>>> at jdk.nashorn.internal.runtime.ScriptFunction.invoke(ScriptFunction.java:350) >>>>>> at jdk.nashorn.internal.runtime.ScriptRuntime.apply(ScriptRuntime.java:310) >>>>>> at jdk.nashorn.internal.objects.NativeFunction.apply(NativeFunction.java:133) >>>>>> >>>>>> >>>>>> cheers >>>>>> Andreas >>>>>> >> From marcus.lagergren at oracle.com Wed Jan 9 07:50:26 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Wed, 9 Jan 2013 16:50:26 +0100 Subject: some nashorn testing In-Reply-To: <98C104F3-F3F1-4FE7-B07A-454CB483B2AD@oracle.com> References: <50EC55C6.1040109@gmail.com> <87349BDC-91EE-43E2-9B04-ABB08FCEAF2F@oracle.com> <50EC8202.4060004@gmail.com> <21D8E6BB-126A-4DC3-AE74-6CB1B2DC4DBE@oracle.com> <50EC95FE.6000106@univ-mlv.fr> <50ED83DE.5010703@gmail.com> <98C104F3-F3F1-4FE7-B07A-454CB483B2AD@oracle.com> Message-ID: My bad. This actually reproduces through the JSR223 bridge. Must be an eval related problem. I am on it! /M On Jan 9, 2013, at 4:26 PM, Marcus Lagergren wrote: > Where did you get/build your nashorn.jar? We'll get proper versioning in there as soon as we've integrated fully with the OpenJDK build system. I still get nothing when I manually build the latest nashorn.jar from the openjdk and run the JS snippet from the command line with java -jar nashorn.jar (Haven't gone through the script engine bridge, but as it seems to be a JavaScript problem it should be sufficient to run it as a standalone script). This very much looks like a bug that I fixed before christmas and pushed into the closed repo - I've verified that it made it into the openjdk source. > /M > > On Jan 9, 2013, at 3:51 PM, Andreas Rieber wrote: > >> Hi Marcus and Remi, >> >> please find attached a better test to reproduce. >> >> Rhino output: >> ------------- >> data 0 : 1.0 >> data 1 : 2.0 >> data 2 : 3.0 >> >> Nashorn output: >> --------------- >> Exception in thread "main" java.lang.ClassCastException: Cannot cast jdk.nashorn.internal.objects.NativeArray to [Ljava.lang.Object; >> at sun.invoke.util.ValueConversions.newClassCastException(ValueConversions.java:461) >> at sun.invoke.util.ValueConversions.castReference(ValueConversions.java:456) >> at jdk.nashorn.internal.scripts.Script$\^eval\_.varargFunc(:10) >> at jdk.nashorn.internal.scripts.Script$\^eval\_.runScript(:13) >> at jdk.nashorn.internal.runtime.ScriptFunction.invoke(ScriptFunction.java:359) >> at jdk.nashorn.internal.runtime.ScriptRuntime.apply(ScriptRuntime.java:310) >> at jdk.nashorn.api.scripting.NashornScriptEngine.evalImpl(NashornScriptEngine.java:438) >> at jdk.nashorn.api.scripting.NashornScriptEngine.evalImpl(NashornScriptEngine.java:423) >> at jdk.nashorn.api.scripting.NashornScriptEngine.eval(NashornScriptEngine.java:150) >> at javax.script.AbstractScriptEngine.eval(AbstractScriptEngine.java:264) >> at ObjectArray.main(ObjectArray.java:16) >> >> >> >> On 09.01.13 08:45, Marcus Lagergren wrote: >>> Remi, Andreas >>> >>> I can't reproduce your problem running >>> >>> java -jar nashorn.jar script.js >>> >>> where script.js is >>> >>> -- >>> var array; >>> try { >>> array = new (Java.type("java.lang.Object[]"))(len); >>> } catch (x) { >>> array = []; >>> } >>> -- >>> >>> Do you have a reproducer you can send me ? I know there was a bug regarding array literal types just before Christmas, but it's in the openjdk as far as I can tell. >>> >>> Regards >>> Marcus >>> >>> >>> On Jan 8, 2013, at 10:56 PM, Remi Forax wrote: >>> >>>> On 01/08/2013 10:49 PM, Attila Szegedi wrote: >>>>> Hey Marcus and Jim, this is similar to that bug we saw before with array literals in the ternary operator. Something related to codegen's inference of types? >>>> a simple workaround is to change the last line >>>> >>>> var array; >>>> try { >>>> array = new (Java.type("java.lang.Object[]"))(len); // array is Object[] >>>> } catch (x) { >>>> //array = []; // array is NativeArray >>>> array = new (Java.type("java.lang.Object[]"))(0); // array is Object[] >>>> } >>>> >>>> R?mi >>>> >>>>> On Jan 8, 2013, at 9:30 PM, Andreas Rieber wrote: >>>>> >>>>>> I tried some cases and will go for (Nashorn and Rhino): >>>>>> >>>>>> var array; >>>>>> try { >>>>>> array = new (Java.type("java.lang.Object[]"))(len); >>>>>> } catch (x) { >>>>>> array = []; >>>>>> } >>>>>> >>>>>> The catch block works with Rhino but gives with Nashorn: >>>>>> >>>>>> Exception in thread "main" java.lang.ClassCastException: Cannot cast jdk.nashorn.internal.objects.NativeArray to [Ljava.lang.Object; >>>>>> at sun.invoke.util.ValueConversions.newClassCastException(ValueConversions.java:461) >>>>>> at sun.invoke.util.ValueConversions.castReference(ValueConversions.java:456) >>>>>> at jdk.nashorn.internal.scripts.Script$main.sprintf(main.js:114) >>>>>> at jdk.nashorn.internal.runtime.ScriptFunction.invoke(ScriptFunction.java:350) >>>>>> at jdk.nashorn.internal.runtime.ScriptRuntime.apply(ScriptRuntime.java:310) >>>>>> at jdk.nashorn.internal.objects.NativeFunction.apply(NativeFunction.java:133) >>>>>> >>>>>> >>>>>> cheers >>>>>> Andreas >>>>>> >> > From sundararajan.athijegannathan at oracle.com Wed Jan 9 08:25:18 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Wed, 09 Jan 2013 21:55:18 +0530 Subject: some nashorn testing In-Reply-To: <50ED8E0B.2030501@gmail.com> References: <50EC55C6.1040109@gmail.com> <87349BDC-91EE-43E2-9B04-ABB08FCEAF2F@oracle.com> <50EC8202.4060004@gmail.com> <21D8E6BB-126A-4DC3-AE74-6CB1B2DC4DBE@oracle.com> <50EC95FE.6000106@univ-mlv.fr> <50ED83DE.5010703@gmail.com> <98C104F3-F3F1-4FE7-B07A-454CB483B2AD@oracle.com> <50ED8E0B.2030501@gmail.com> Message-ID: <50ED99EE.7010704@oracle.com> Hi Andreas, In the line: + " return Packages.ObjectArray.objFunc(firstParam, array);\n" You convert a JS array "array" to a Java Object[]. With nashorn array conversion is not implicit. You need to call Java.toJavaArray convert script array to Java array. + " return Packages.ObjectArray.objFunc(firstParam, Java.toJavaArray(array));\n" Also, to make sure nashorn script engine is used, I modified engine name to be "nashorn". Please try the updated ObjectArray.java attached. Thanks -Sundar Andreas Rieber wrote: > I use nashorn clone from http://hg.openjdk.java.net/nashorn/jdk8/nashorn > last update yesterday evening, and it doesn't work as standalone js > program as it fails scripting java so you would need to compile the > sample. > > > On 09.01.13 16:26, Marcus Lagergren wrote: >> Where did you get/build your nashorn.jar? We'll get proper versioning >> in there as soon as we've integrated fully with the OpenJDK build >> system. I still get nothing when I manually build the latest >> nashorn.jar from the openjdk and run the JS snippet from the command >> line with java -jar nashorn.jar (Haven't gone through >> the script engine bridge, but as it seems to be a JavaScript problem >> it should be sufficient to run it as a standalone script). This very >> much looks like a bug that I fixed before christmas and pushed into >> the closed repo - I've verified that it made it into the openjdk source. >> /M >> >> On Jan 9, 2013, at 3:51 PM, Andreas Rieber >> wrote: >> >>> Hi Marcus and Remi, >>> >>> please find attached a better test to reproduce. >>> >>> Rhino output: >>> ------------- >>> data 0 : 1.0 >>> data 1 : 2.0 >>> data 2 : 3.0 >>> >>> Nashorn output: >>> --------------- >>> Exception in thread "main" java.lang.ClassCastException: Cannot cast >>> jdk.nashorn.internal.objects.NativeArray to [Ljava.lang.Object; >>> at >>> sun.invoke.util.ValueConversions.newClassCastException(ValueConversions.java:461) >>> >>> at >>> sun.invoke.util.ValueConversions.castReference(ValueConversions.java:456) >>> >>> at >>> jdk.nashorn.internal.scripts.Script$\^eval\_.varargFunc(:10) >>> at >>> jdk.nashorn.internal.scripts.Script$\^eval\_.runScript(:13) >>> at >>> jdk.nashorn.internal.runtime.ScriptFunction.invoke(ScriptFunction.java:359) >>> >>> at >>> jdk.nashorn.internal.runtime.ScriptRuntime.apply(ScriptRuntime.java:310) >>> >>> at >>> jdk.nashorn.api.scripting.NashornScriptEngine.evalImpl(NashornScriptEngine.java:438) >>> >>> at >>> jdk.nashorn.api.scripting.NashornScriptEngine.evalImpl(NashornScriptEngine.java:423) >>> >>> at >>> jdk.nashorn.api.scripting.NashornScriptEngine.eval(NashornScriptEngine.java:150) >>> >>> at >>> javax.script.AbstractScriptEngine.eval(AbstractScriptEngine.java:264) >>> at ObjectArray.main(ObjectArray.java:16) >>> >>> >>> >>> On 09.01.13 08:45, Marcus Lagergren wrote: >>>> Remi, Andreas >>>> >>>> I can't reproduce your problem running >>>> >>>> java -jar nashorn.jar script.js >>>> >>>> where script.js is >>>> >>>> -- >>>> var array; >>>> try { >>>> array = new (Java.type("java.lang.Object[]"))(len); >>>> } catch (x) { >>>> array = []; >>>> } >>>> -- >>>> >>>> Do you have a reproducer you can send me ? I know there was a bug >>>> regarding array literal types just before Christmas, but it's in >>>> the openjdk as far as I can tell. >>>> >>>> Regards >>>> Marcus >>>> >>>> >>>> On Jan 8, 2013, at 10:56 PM, Remi Forax wrote: >>>> >>>>> On 01/08/2013 10:49 PM, Attila Szegedi wrote: >>>>>> Hey Marcus and Jim, this is similar to that bug we saw before >>>>>> with array literals in the ternary operator. Something related to >>>>>> codegen's inference of types? >>>>> a simple workaround is to change the last line >>>>> >>>>> var array; >>>>> try { >>>>> array = new (Java.type("java.lang.Object[]"))(len); // array >>>>> is Object[] >>>>> } catch (x) { >>>>> //array = []; // array >>>>> is NativeArray >>>>> array = new (Java.type("java.lang.Object[]"))(0); // array >>>>> is Object[] >>>>> } >>>>> >>>>> R?mi >>>>> >>>>>> On Jan 8, 2013, at 9:30 PM, Andreas Rieber >>>>>> wrote: >>>>>> >>>>>>> I tried some cases and will go for (Nashorn and Rhino): >>>>>>> >>>>>>> var array; >>>>>>> try { >>>>>>> array = new (Java.type("java.lang.Object[]"))(len); >>>>>>> } catch (x) { >>>>>>> array = []; >>>>>>> } >>>>>>> >>>>>>> The catch block works with Rhino but gives with Nashorn: >>>>>>> >>>>>>> Exception in thread "main" java.lang.ClassCastException: Cannot >>>>>>> cast jdk.nashorn.internal.objects.NativeArray to >>>>>>> [Ljava.lang.Object; >>>>>>> at >>>>>>> sun.invoke.util.ValueConversions.newClassCastException(ValueConversions.java:461) >>>>>>> >>>>>>> at >>>>>>> sun.invoke.util.ValueConversions.castReference(ValueConversions.java:456) >>>>>>> >>>>>>> at >>>>>>> jdk.nashorn.internal.scripts.Script$main.sprintf(main.js:114) >>>>>>> at >>>>>>> jdk.nashorn.internal.runtime.ScriptFunction.invoke(ScriptFunction.java:350) >>>>>>> >>>>>>> at >>>>>>> jdk.nashorn.internal.runtime.ScriptRuntime.apply(ScriptRuntime.java:310) >>>>>>> >>>>>>> at >>>>>>> jdk.nashorn.internal.objects.NativeFunction.apply(NativeFunction.java:133) >>>>>>> >>>>>>> >>>>>>> >>>>>>> cheers >>>>>>> Andreas >>>>>>> >>> > -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: ObjectArray.java Url: http://mail.openjdk.java.net/pipermail/nashorn-dev/attachments/20130109/b17f3dc7/ObjectArray.java From sundararajan.athijegannathan at oracle.com Wed Jan 9 08:38:24 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Wed, 09 Jan 2013 22:08:24 +0530 Subject: Review request : JDK-8005940 : provide ant targets to get and update external test scripts Message-ID: <50ED9D00.2060202@oracle.com> Hi, Please review http://cr.openjdk.java.net/~sundar/8005940/ Thanks -Sundar From james.laskey at oracle.com Wed Jan 9 08:40:35 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Wed, 9 Jan 2013 12:40:35 -0400 Subject: Review request : JDK-8005940 : provide ant targets to get and update external test scripts In-Reply-To: <50ED9D00.2060202@oracle.com> References: <50ED9D00.2060202@oracle.com> Message-ID: <170168D4-52CD-4AE4-8394-31499655175C@oracle.com> +1 On 2013-01-09, at 12:38 PM, "A. Sundararajan" wrote: > Hi, > > Please review http://cr.openjdk.java.net/~sundar/8005940/ > > Thanks > -Sundar From marcus.lagergren at oracle.com Wed Jan 9 08:46:29 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Wed, 9 Jan 2013 17:46:29 +0100 Subject: Review request : JDK-8005940 : provide ant targets to get and update external test scripts In-Reply-To: <50ED9D00.2060202@oracle.com> References: <50ED9D00.2060202@oracle.com> Message-ID: <3D067ACF-5A36-47D1-9B10-58F3796B124C@oracle.com> +1 On Jan 9, 2013, at 5:38 PM, A. Sundararajan wrote: > Hi, > > Please review http://cr.openjdk.java.net/~sundar/8005940/ > > Thanks > -Sundar From sundararajan.athijegannathan at oracle.com Wed Jan 9 08:58:56 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Wed, 09 Jan 2013 16:58:56 +0000 Subject: hg: nashorn/jdk8/nashorn: 8005940: provide ant targets to get and update external test scripts Message-ID: <20130109165857.C810347149@hg.openjdk.java.net> Changeset: 4cd65798ec70 Author: sundar Date: 2013-01-09 22:32 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/4cd65798ec70 8005940: provide ant targets to get and update external test scripts Reviewed-by: jlaskey, lagergren ! bin/verbose_octane.bat ! bin/verbose_octane.sh ! make/Makefile ! make/build-benchmark.xml ! make/build.xml ! make/project.properties ! test/script/basic/run-octane.js ! test/script/basic/runsunspider.js ! test/src/jdk/nashorn/internal/codegen/CompilerTest.java ! test/src/jdk/nashorn/internal/parser/ParserTest.java From marcus.lagergren at oracle.com Thu Jan 10 01:05:08 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Thu, 10 Jan 2013 10:05:08 +0100 Subject: Review request for http://cr.openjdk.java.net/~lagergren/8005971/ Message-ID: <8180FF7E-B096-44FA-BC8B-C181B8EAE247@oracle.com> Can I get a review for http://cr.openjdk.java.net/~lagergren/8005971/ please. runsunspider.js now checks results as the legally licensed third party libraries for the external repo did not. /M From attila.szegedi at oracle.com Thu Jan 10 01:27:51 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Thu, 10 Jan 2013 10:27:51 +0100 Subject: Review request for http://cr.openjdk.java.net/~lagergren/8005971/ In-Reply-To: <8180FF7E-B096-44FA-BC8B-C181B8EAE247@oracle.com> References: <8180FF7E-B096-44FA-BC8B-C181B8EAE247@oracle.com> Message-ID: +1 On Jan 10, 2013, at 10:05 AM, Marcus Lagergren wrote: > Can I get a review for http://cr.openjdk.java.net/~lagergren/8005971/ please. runsunspider.js now checks results as the legally licensed third party libraries for the external repo did not. > > /M > From marcus.lagergren at oracle.com Thu Jan 10 01:29:56 2013 From: marcus.lagergren at oracle.com (marcus.lagergren at oracle.com) Date: Thu, 10 Jan 2013 09:29:56 +0000 Subject: hg: nashorn/jdk8/nashorn: 8005971: runsunspider.js should check results of benchmarks Message-ID: <20130110092957.A4F3547175@hg.openjdk.java.net> Changeset: 9f59ba5090f2 Author: lagergren Date: 2013-01-10 10:28 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/9f59ba5090f2 8005971: runsunspider.js should check results of benchmarks Reviewed-by: attila, hannesw ! test/script/basic/runsunspider.js From hannes.wallnoefer at oracle.com Thu Jan 10 01:32:11 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Thu, 10 Jan 2013 10:32:11 +0100 Subject: Review request for http://cr.openjdk.java.net/~lagergren/8005971/ In-Reply-To: <8180FF7E-B096-44FA-BC8B-C181B8EAE247@oracle.com> References: <8180FF7E-B096-44FA-BC8B-C181B8EAE247@oracle.com> Message-ID: <50EE8A9B.4010006@oracle.com> Looks good to me. Maybe file an issue for the 4 unchecked tests? Hannes Am 2013-01-10 10:05, schrieb Marcus Lagergren: > Can I get a review for http://cr.openjdk.java.net/~lagergren/8005971/ please. runsunspider.js now checks results as the legally licensed third party libraries for the external repo did not. > > /M > From rieberandreas at gmail.com Thu Jan 10 05:07:31 2013 From: rieberandreas at gmail.com (Andreas Rieber) Date: Thu, 10 Jan 2013 14:07:31 +0100 Subject: some nashorn testing In-Reply-To: References: <50EC55C6.1040109@gmail.com> <87349BDC-91EE-43E2-9B04-ABB08FCEAF2F@oracle.com> <50EC8202.4060004@gmail.com> <21D8E6BB-126A-4DC3-AE74-6CB1B2DC4DBE@oracle.com> <50EC95FE.6000106@univ-mlv.fr> <50ED83DE.5010703@gmail.com> <98C104F3-F3F1-4FE7-B07A-454CB483B2AD@oracle.com> Message-ID: <50EEBD13.8000808@gmail.com> Hi Marcus, i improved the test and found another case (sorry for that ;-) Whenever you have a fix, i could provide the patch for jrunscript (workaround working): ./usr/local/src/jdk8/build/linux-i586/j2sdk-image/bin/jrunscript -cp /usr/local/src/jdk8/nashorn/dist/nashorn.jar:. -l nashorn nashorn> printf("%03d %2.2f%n",1,2); 001 2.00 nashorn> - Andreas On 09.01.13 16:50, Marcus Lagergren wrote: > My bad. This actually reproduces through the JSR223 bridge. Must be an eval related problem. I am on it! > > /M > > > On Jan 9, 2013, at 4:26 PM, Marcus Lagergren wrote: > >> Where did you get/build your nashorn.jar? We'll get proper versioning in there as soon as we've integrated fully with the OpenJDK build system. I still get nothing when I manually build the latest nashorn.jar from the openjdk and run the JS snippet from the command line with java -jar nashorn.jar (Haven't gone through the script engine bridge, but as it seems to be a JavaScript problem it should be sufficient to run it as a standalone script). This very much looks like a bug that I fixed before christmas and pushed into the closed repo - I've verified that it made it into the openjdk source. >> /M -------------- next part -------------- import javax.script.*; public class ObjectArray { public static void objFunc1(Object[] data) { for (int i = 0; i < data.length; i++) { System.out.println(i + " " + data[i]); } } public static void objFunc2(Object[][] data) { for (int i = 0; i < data.length; i++) { for (int j = 0; j < data[i].length; j++) { System.out.println(i + " " + j + " " + data[i][j]); } } } public static void main(String args[]) throws Exception { ScriptEngineManager manager = new ScriptEngineManager(); ScriptEngine engine = manager.getEngineByName("nashorn"); engine.eval("Packages.ObjectArray.objFunc1([1,2,3]);"); engine.eval("Packages.ObjectArray.objFunc2([[1,2],[3,4]]);"); } } From sundararajan.athijegannathan at oracle.com Thu Jan 10 05:15:45 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Thu, 10 Jan 2013 18:45:45 +0530 Subject: Review request JDK-8005987 : ant octane tries to run non-benchmark scripts Message-ID: <50EEBF01.8000704@oracle.com> Hi, Please review http://cr.openjdk.java.net/~sundar/8005987/ Thanks -Sundar From sundararajan.athijegannathan at oracle.com Thu Jan 10 05:30:53 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Thu, 10 Jan 2013 19:00:53 +0530 Subject: Nashorn does not support implicit array conversion b/w script and Java array [ Re: some nashorn testing] In-Reply-To: <50EEBD13.8000808@gmail.com> References: <50EC55C6.1040109@gmail.com> <87349BDC-91EE-43E2-9B04-ABB08FCEAF2F@oracle.com> <50EC8202.4060004@gmail.com> <21D8E6BB-126A-4DC3-AE74-6CB1B2DC4DBE@oracle.com> <50EC95FE.6000106@univ-mlv.fr> <50ED83DE.5010703@gmail.com> <98C104F3-F3F1-4FE7-B07A-454CB483B2AD@oracle.com> <50EEBD13.8000808@gmail.com> Message-ID: <50EEC28D.5000707@oracle.com> Hi Andreas, As I said in my last email, Nashorn does not support implicit conversion from JS array to Java array. You need to call Java.toJavaArray method to do the conversion. I've attached modified ObjectArray.java with this email -- both single dimensional and 2 D array need conversion. With the changed file, I get proper output Thanks, -Sundar Andreas Rieber wrote: > Hi Marcus, > > i improved the test and found another case (sorry for that ;-) > > Whenever you have a fix, i could provide the patch for jrunscript > (workaround working): > > ./usr/local/src/jdk8/build/linux-i586/j2sdk-image/bin/jrunscript -cp > /usr/local/src/jdk8/nashorn/dist/nashorn.jar:. -l nashorn > nashorn> printf("%03d %2.2f%n",1,2); > 001 2.00 > nashorn> > > - Andreas > > On 09.01.13 16:50, Marcus Lagergren wrote: >> My bad. This actually reproduces through the JSR223 bridge. Must be >> an eval related problem. I am on it! >> >> /M >> >> >> On Jan 9, 2013, at 4:26 PM, Marcus Lagergren >> wrote: >> >>> Where did you get/build your nashorn.jar? We'll get proper >>> versioning in there as soon as we've integrated fully with the >>> OpenJDK build system. I still get nothing when I manually build the >>> latest nashorn.jar from the openjdk and run the JS snippet from the >>> command line with java -jar nashorn.jar (Haven't gone >>> through the script engine bridge, but as it seems to be a JavaScript >>> problem it should be sufficient to run it as a standalone script). >>> This very much looks like a bug that I fixed before christmas and >>> pushed into the closed repo - I've verified that it made it into the >>> openjdk source. >>> /M > -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: ObjectArray.java Url: http://mail.openjdk.java.net/pipermail/nashorn-dev/attachments/20130110/c5aeb3df/ObjectArray.java From marcus.lagergren at oracle.com Thu Jan 10 05:28:13 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Thu, 10 Jan 2013 14:28:13 +0100 Subject: Review request JDK-8005987 : ant octane tries to run non-benchmark scripts In-Reply-To: <50EEBF01.8000704@oracle.com> References: <50EEBF01.8000704@oracle.com> Message-ID: <03D28511-4B95-4F2F-9363-9D80314B4A33@oracle.com> +1 On Jan 10, 2013, at 2:15 PM, A. Sundararajan wrote: > Hi, > > Please review http://cr.openjdk.java.net/~sundar/8005987/ > > Thanks > -Sundar From attila.szegedi at oracle.com Thu Jan 10 05:28:29 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Thu, 10 Jan 2013 14:28:29 +0100 Subject: Review request JDK-8005987 : ant octane tries to run non-benchmark scripts In-Reply-To: <50EEBF01.8000704@oracle.com> References: <50EEBF01.8000704@oracle.com> Message-ID: +1 On Jan 10, 2013, at 2:15 PM, "A. Sundararajan" wrote: > Hi, > > Please review http://cr.openjdk.java.net/~sundar/8005987/ > > Thanks > -Sundar From attila.szegedi at oracle.com Thu Jan 10 05:34:15 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Thu, 10 Jan 2013 14:34:15 +0100 Subject: some nashorn testing In-Reply-To: <50EEBD13.8000808@gmail.com> References: <50EC55C6.1040109@gmail.com> <87349BDC-91EE-43E2-9B04-ABB08FCEAF2F@oracle.com> <50EC8202.4060004@gmail.com> <21D8E6BB-126A-4DC3-AE74-6CB1B2DC4DBE@oracle.com> <50EC95FE.6000106@univ-mlv.fr> <50ED83DE.5010703@gmail.com> <98C104F3-F3F1-4FE7-B07A-454CB483B2AD@oracle.com> <50EEBD13.8000808@gmail.com> Message-ID: <13891F9D-80BD-48E1-995B-0E0531FCF09F@oracle.com> Andreas, did you read Sundar's response where he explained to you the need to use Java.toJavaArray() for explicit conversion of JavaScript arrays to Java arrays? It seems that your code still doesn't use Java.toJavaArray(). Attila. On Jan 10, 2013, at 2:07 PM, Andreas Rieber wrote: > Hi Marcus, > > i improved the test and found another case (sorry for that ;-) > > Whenever you have a fix, i could provide the patch for jrunscript (workaround working): > > ./usr/local/src/jdk8/build/linux-i586/j2sdk-image/bin/jrunscript -cp /usr/local/src/jdk8/nashorn/dist/nashorn.jar:. -l nashorn > nashorn> printf("%03d %2.2f%n",1,2); > 001 2.00 > nashorn> > > - Andreas > > On 09.01.13 16:50, Marcus Lagergren wrote: >> My bad. This actually reproduces through the JSR223 bridge. Must be an eval related problem. I am on it! >> >> /M >> >> >> On Jan 9, 2013, at 4:26 PM, Marcus Lagergren wrote: >> >>> Where did you get/build your nashorn.jar? We'll get proper versioning in there as soon as we've integrated fully with the OpenJDK build system. I still get nothing when I manually build the latest nashorn.jar from the openjdk and run the JS snippet from the command line with java -jar nashorn.jar (Haven't gone through the script engine bridge, but as it seems to be a JavaScript problem it should be sufficient to run it as a standalone script). This very much looks like a bug that I fixed before christmas and pushed into the closed repo - I've verified that it made it into the openjdk source. >>> /M > > From attila.szegedi at oracle.com Thu Jan 10 05:45:36 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Thu, 10 Jan 2013 14:45:36 +0100 Subject: Review request for JDK-8005983 Message-ID: <22ECD86B-8C62-45F3-9F43-0E3510E2AC5E@oracle.com> Please review JDK-8005983 at http://cr.openjdk.java.net/~attila/8005983/webrev.00 Thanks, Attila. From sundararajan.athijegannathan at oracle.com Thu Jan 10 05:29:57 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Thu, 10 Jan 2013 13:29:57 +0000 Subject: hg: nashorn/jdk8/nashorn: 8005987: ant octane tries to run non-benchmark scripts Message-ID: <20130110133003.E746647181@hg.openjdk.java.net> Changeset: a7f177d6639c Author: sundar Date: 2013-01-10 19:03 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/a7f177d6639c 8005987: ant octane tries to run non-benchmark scripts Reviewed-by: lagergren, attila, jlaskey ! make/build-benchmark.xml ! make/project.properties From james.laskey at oracle.com Thu Jan 10 06:02:19 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Thu, 10 Jan 2013 10:02:19 -0400 Subject: Review request for JDK-8005983 In-Reply-To: <22ECD86B-8C62-45F3-9F43-0E3510E2AC5E@oracle.com> References: <22ECD86B-8C62-45F3-9F43-0E3510E2AC5E@oracle.com> Message-ID: <99FBB3EA-844E-4994-92F5-8BE2A8D39D28@oracle.com> +1 On 2013-01-10, at 9:45 AM, Attila Szegedi wrote: > Please review JDK-8005983 at http://cr.openjdk.java.net/~attila/8005983/webrev.00 > > Thanks, > Attila. From sundararajan.athijegannathan at oracle.com Thu Jan 10 06:08:12 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Thu, 10 Jan 2013 19:38:12 +0530 Subject: Review request for JDK-8005983 In-Reply-To: <22ECD86B-8C62-45F3-9F43-0E3510E2AC5E@oracle.com> References: <22ECD86B-8C62-45F3-9F43-0E3510E2AC5E@oracle.com> Message-ID: <50EECB4C.30908@oracle.com> +1 Attila Szegedi wrote: > Please review JDK-8005983 at http://cr.openjdk.java.net/~attila/8005983/webrev.00 > > Thanks, > Attila. From sundararajan.athijegannathan at oracle.com Thu Jan 10 06:20:15 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Thu, 10 Jan 2013 19:50:15 +0530 Subject: Review request JDK-8005982 : NASHORN-71.js failing in nightlys Message-ID: <50EECE1F.2050304@oracle.com> Hi, Please review http://cr.openjdk.java.net/~sundar/8005982/ Thanks -Sundar From sundararajan.athijegannathan at oracle.com Thu Jan 10 06:21:53 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Thu, 10 Jan 2013 14:21:53 +0000 Subject: hg: nashorn/jdk8/nashorn: 8005982: NASHORN-71.js failing in nightlys Message-ID: <20130110142154.845A147184@hg.openjdk.java.net> Changeset: 0362d36d3dd6 Author: sundar Date: 2013-01-10 19:55 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/0362d36d3dd6 8005982: NASHORN-71.js failing in nightlys Reviewed-by: attila, lagergren, jlaskey ! test/script/basic/NASHORN-71.js - test/script/basic/NASHORN-71.js.EXPECTED From attila.szegedi at oracle.com Thu Jan 10 06:28:14 2013 From: attila.szegedi at oracle.com (attila.szegedi at oracle.com) Date: Thu, 10 Jan 2013 14:28:14 +0000 Subject: hg: nashorn/jdk8/nashorn: 8005983: JavaAdapterFactory generated proxy classes should take extra constructor arguments at the end Message-ID: <20130110142814.EF0D347185@hg.openjdk.java.net> Changeset: 2a5c2258827b Author: attila Date: 2013-01-10 15:28 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/2a5c2258827b 8005983: JavaAdapterFactory generated proxy classes should take extra constructor arguments at the end Reviewed-by: lagergren, sundar ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java ! src/jdk/nashorn/internal/runtime/linker/NashornLinker.java ! test/script/sandbox/javaextend.js ! test/script/sandbox/javaextend.js.EXPECTED From james.laskey at oracle.com Thu Jan 10 06:32:18 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Thu, 10 Jan 2013 10:32:18 -0400 Subject: Review request JDK-8005982 : NASHORN-71.js failing in nightlys In-Reply-To: <50EECE1F.2050304@oracle.com> References: <50EECE1F.2050304@oracle.com> Message-ID: <62F58543-979C-4B81-AC41-57B35381560E@oracle.com> +1 On 2013-01-10, at 10:20 AM, "A. Sundararajan" wrote: > Hi, > > Please review http://cr.openjdk.java.net/~sundar/8005982/ > > Thanks > -Sundar From rieberandreas at gmail.com Thu Jan 10 07:05:59 2013 From: rieberandreas at gmail.com (Andreas Rieber) Date: Thu, 10 Jan 2013 16:05:59 +0100 Subject: some nashorn testing In-Reply-To: <13891F9D-80BD-48E1-995B-0E0531FCF09F@oracle.com> References: <50EC55C6.1040109@gmail.com> <87349BDC-91EE-43E2-9B04-ABB08FCEAF2F@oracle.com> <50EC8202.4060004@gmail.com> <21D8E6BB-126A-4DC3-AE74-6CB1B2DC4DBE@oracle.com> <50EC95FE.6000106@univ-mlv.fr> <50ED83DE.5010703@gmail.com> <98C104F3-F3F1-4FE7-B07A-454CB483B2AD@oracle.com> <50EEBD13.8000808@gmail.com> <13891F9D-80BD-48E1-995B-0E0531FCF09F@oracle.com> Message-ID: <50EED8D7.40106@gmail.com> Hi Attila, yes i read all mails and there are already four different workaround for the array topic. No problem, just different from Rhino. Andreas On 10.01.13 14:34, Attila Szegedi wrote: > Andreas, did you read Sundar's response where he explained to you the need to use Java.toJavaArray() for explicit conversion of JavaScript arrays to Java arrays? It seems that your code still doesn't use Java.toJavaArray(). > > Attila. > > On Jan 10, 2013, at 2:07 PM, Andreas Rieber wrote: > >> Hi Marcus, >> >> i improved the test and found another case (sorry for that ;-) >> >> Whenever you have a fix, i could provide the patch for jrunscript (workaround working): >> >> ./usr/local/src/jdk8/build/linux-i586/j2sdk-image/bin/jrunscript -cp /usr/local/src/jdk8/nashorn/dist/nashorn.jar:. -l nashorn >> nashorn> printf("%03d %2.2f%n",1,2); >> 001 2.00 >> nashorn> >> >> - Andreas >> >> On 09.01.13 16:50, Marcus Lagergren wrote: >>> My bad. This actually reproduces through the JSR223 bridge. Must be an eval related problem. I am on it! >>> >>> /M >>> >>> >>> On Jan 9, 2013, at 4:26 PM, Marcus Lagergren wrote: >>> >>>> Where did you get/build your nashorn.jar? We'll get proper versioning in there as soon as we've integrated fully with the OpenJDK build system. I still get nothing when I manually build the latest nashorn.jar from the openjdk and run the JS snippet from the command line with java -jar nashorn.jar (Haven't gone through the script engine bridge, but as it seems to be a JavaScript problem it should be sufficient to run it as a standalone script). This very much looks like a bug that I fixed before christmas and pushed into the closed repo - I've verified that it made it into the openjdk source. >>>> /M >> From attila.szegedi at oracle.com Thu Jan 10 07:18:54 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Thu, 10 Jan 2013 16:18:54 +0100 Subject: some nashorn testing In-Reply-To: <50EED8D7.40106@gmail.com> References: <50EC55C6.1040109@gmail.com> <87349BDC-91EE-43E2-9B04-ABB08FCEAF2F@oracle.com> <50EC8202.4060004@gmail.com> <21D8E6BB-126A-4DC3-AE74-6CB1B2DC4DBE@oracle.com> <50EC95FE.6000106@univ-mlv.fr> <50ED83DE.5010703@gmail.com> <98C104F3-F3F1-4FE7-B07A-454CB483B2AD@oracle.com> <50EEBD13.8000808@gmail.com> <13891F9D-80BD-48E1-995B-0E0531FCF09F@oracle.com> <50EED8D7.40106@gmail.com> Message-ID: Hi Andreas, I'm sorry - maybe then I did not understand the motivation for you sending that last code snippet with 2D arrays. Did you just want to illustrate another difference in array handling, or does it illustrate a further problem that you'd need solved? Attila. On Jan 10, 2013, at 4:05 PM, Andreas Rieber wrote: > Hi Attila, > > yes i read all mails and there are already four different workaround for the array topic. No problem, just different from Rhino. > > Andreas > > On 10.01.13 14:34, Attila Szegedi wrote: >> Andreas, did you read Sundar's response where he explained to you the need to use Java.toJavaArray() for explicit conversion of JavaScript arrays to Java arrays? It seems that your code still doesn't use Java.toJavaArray(). >> >> Attila. >> >> On Jan 10, 2013, at 2:07 PM, Andreas Rieber wrote: >> >>> Hi Marcus, >>> >>> i improved the test and found another case (sorry for that ;-) >>> >>> Whenever you have a fix, i could provide the patch for jrunscript (workaround working): >>> >>> ./usr/local/src/jdk8/build/linux-i586/j2sdk-image/bin/jrunscript -cp /usr/local/src/jdk8/nashorn/dist/nashorn.jar:. -l nashorn >>> nashorn> printf("%03d %2.2f%n",1,2); >>> 001 2.00 >>> nashorn> >>> >>> - Andreas >>> >>> On 09.01.13 16:50, Marcus Lagergren wrote: >>>> My bad. This actually reproduces through the JSR223 bridge. Must be an eval related problem. I am on it! >>>> >>>> /M >>>> >>>> >>>> On Jan 9, 2013, at 4:26 PM, Marcus Lagergren wrote: >>>> >>>>> Where did you get/build your nashorn.jar? We'll get proper versioning in there as soon as we've integrated fully with the OpenJDK build system. I still get nothing when I manually build the latest nashorn.jar from the openjdk and run the JS snippet from the command line with java -jar nashorn.jar (Haven't gone through the script engine bridge, but as it seems to be a JavaScript problem it should be sufficient to run it as a standalone script). This very much looks like a bug that I fixed before christmas and pushed into the closed repo - I've verified that it made it into the openjdk source. >>>>> /M >>> From rieberandreas at gmail.com Thu Jan 10 08:12:51 2013 From: rieberandreas at gmail.com (Andreas Rieber) Date: Thu, 10 Jan 2013 17:12:51 +0100 Subject: some nashorn testing In-Reply-To: References: <50EC55C6.1040109@gmail.com> <87349BDC-91EE-43E2-9B04-ABB08FCEAF2F@oracle.com> <50EC8202.4060004@gmail.com> <21D8E6BB-126A-4DC3-AE74-6CB1B2DC4DBE@oracle.com> <50EC95FE.6000106@univ-mlv.fr> <50ED83DE.5010703@gmail.com> <98C104F3-F3F1-4FE7-B07A-454CB483B2AD@oracle.com> <50EEBD13.8000808@gmail.com> <13891F9D-80BD-48E1-995B-0E0531FCF09F@oracle.com> <50EED8D7.40106@gmail.com> Message-ID: <50EEE883.2020303@gmail.com> Hi Attila, the motivation with 2D array is that Rhino does support that as well as the 1D array. Hope the list of differences will not get too long. But no worries, i will go on with Nashorn. Andreas On 10.01.13 16:18, Attila Szegedi wrote: > Hi Andreas, > > I'm sorry - maybe then I did not understand the motivation for you sending that last code snippet with 2D arrays. Did you just want to illustrate another difference in array handling, or does it illustrate a further problem that you'd need solved? > > Attila. > > On Jan 10, 2013, at 4:05 PM, Andreas Rieber wrote: > >> Hi Attila, >> >> yes i read all mails and there are already four different workaround for the array topic. No problem, just different from Rhino. >> >> Andreas >> >> On 10.01.13 14:34, Attila Szegedi wrote: >>> Andreas, did you read Sundar's response where he explained to you the need to use Java.toJavaArray() for explicit conversion of JavaScript arrays to Java arrays? It seems that your code still doesn't use Java.toJavaArray(). >>> >>> Attila. >>> >>> On Jan 10, 2013, at 2:07 PM, Andreas Rieber wrote: >>> >>>> Hi Marcus, >>>> >>>> i improved the test and found another case (sorry for that ;-) >>>> >>>> Whenever you have a fix, i could provide the patch for jrunscript (workaround working): >>>> >>>> ./usr/local/src/jdk8/build/linux-i586/j2sdk-image/bin/jrunscript -cp /usr/local/src/jdk8/nashorn/dist/nashorn.jar:. -l nashorn >>>> nashorn> printf("%03d %2.2f%n",1,2); >>>> 001 2.00 >>>> nashorn> >>>> >>>> - Andreas >>>> >>>> On 09.01.13 16:50, Marcus Lagergren wrote: >>>>> My bad. This actually reproduces through the JSR223 bridge. Must be an eval related problem. I am on it! >>>>> >>>>> /M >>>>> >>>>> >>>>> On Jan 9, 2013, at 4:26 PM, Marcus Lagergren wrote: >>>>> >>>>>> Where did you get/build your nashorn.jar? We'll get proper versioning in there as soon as we've integrated fully with the OpenJDK build system. I still get nothing when I manually build the latest nashorn.jar from the openjdk and run the JS snippet from the command line with java -jar nashorn.jar (Haven't gone through the script engine bridge, but as it seems to be a JavaScript problem it should be sufficient to run it as a standalone script). This very much looks like a bug that I fixed before christmas and pushed into the closed repo - I've verified that it made it into the openjdk source. >>>>>> /M >>>> From marcus.lagergren at oracle.com Thu Jan 10 08:19:04 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Thu, 10 Jan 2013 17:19:04 +0100 Subject: some nashorn testing In-Reply-To: References: <50EC55C6.1040109@gmail.com> <87349BDC-91EE-43E2-9B04-ABB08FCEAF2F@oracle.com> <50EC8202.4060004@gmail.com> <21D8E6BB-126A-4DC3-AE74-6CB1B2DC4DBE@oracle.com> <50EC95FE.6000106@univ-mlv.fr> <50ED83DE.5010703@gmail.com> <98C104F3-F3F1-4FE7-B07A-454CB483B2AD@oracle.com> <50EEBD13.8000808@gmail.com> <13891F9D-80BD-48E1-995B-0E0531FCF09F@oracle.com> <50EED8D7.40106@gmail.com> Message-ID: <9D405C37-3A41-4922-8681-7ACE5E9438EB@oracle.com> So code generation wise, I've verified that the type system is internally consistent. This is a rhino/nashorn different when it comes to JSR223. /M On Jan 10, 2013, at 4:18 PM, Attila Szegedi wrote: > Hi Andreas, > > I'm sorry - maybe then I did not understand the motivation for you sending that last code snippet with 2D arrays. Did you just want to illustrate another difference in array handling, or does it illustrate a further problem that you'd need solved? > > Attila. > > On Jan 10, 2013, at 4:05 PM, Andreas Rieber wrote: > >> Hi Attila, >> >> yes i read all mails and there are already four different workaround for the array topic. No problem, just different from Rhino. >> >> Andreas >> >> On 10.01.13 14:34, Attila Szegedi wrote: >>> Andreas, did you read Sundar's response where he explained to you the need to use Java.toJavaArray() for explicit conversion of JavaScript arrays to Java arrays? It seems that your code still doesn't use Java.toJavaArray(). >>> >>> Attila. >>> >>> On Jan 10, 2013, at 2:07 PM, Andreas Rieber wrote: >>> >>>> Hi Marcus, >>>> >>>> i improved the test and found another case (sorry for that ;-) >>>> >>>> Whenever you have a fix, i could provide the patch for jrunscript (workaround working): >>>> >>>> ./usr/local/src/jdk8/build/linux-i586/j2sdk-image/bin/jrunscript -cp /usr/local/src/jdk8/nashorn/dist/nashorn.jar:. -l nashorn >>>> nashorn> printf("%03d %2.2f%n",1,2); >>>> 001 2.00 >>>> nashorn> >>>> >>>> - Andreas >>>> >>>> On 09.01.13 16:50, Marcus Lagergren wrote: >>>>> My bad. This actually reproduces through the JSR223 bridge. Must be an eval related problem. I am on it! >>>>> >>>>> /M >>>>> >>>>> >>>>> On Jan 9, 2013, at 4:26 PM, Marcus Lagergren wrote: >>>>> >>>>>> Where did you get/build your nashorn.jar? We'll get proper versioning in there as soon as we've integrated fully with the OpenJDK build system. I still get nothing when I manually build the latest nashorn.jar from the openjdk and run the JS snippet from the command line with java -jar nashorn.jar (Haven't gone through the script engine bridge, but as it seems to be a JavaScript problem it should be sufficient to run it as a standalone script). This very much looks like a bug that I fixed before christmas and pushed into the closed repo - I've verified that it made it into the openjdk source. >>>>>> /M >>>> > From sundararajan.athijegannathan at oracle.com Thu Jan 10 08:46:40 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Thu, 10 Jan 2013 22:16:40 +0530 Subject: some nashorn testing In-Reply-To: <9D405C37-3A41-4922-8681-7ACE5E9438EB@oracle.com> References: <50EC55C6.1040109@gmail.com> <87349BDC-91EE-43E2-9B04-ABB08FCEAF2F@oracle.com> <50EC8202.4060004@gmail.com> <21D8E6BB-126A-4DC3-AE74-6CB1B2DC4DBE@oracle.com> <50EC95FE.6000106@univ-mlv.fr> <50ED83DE.5010703@gmail.com> <98C104F3-F3F1-4FE7-B07A-454CB483B2AD@oracle.com> <50EEBD13.8000808@gmail.com> <13891F9D-80BD-48E1-995B-0E0531FCF09F@oracle.com> <50EED8D7.40106@gmail.com> <9D405C37-3A41-4922-8681-7ACE5E9438EB@oracle.com> Message-ID: <50EEF070.6000305@oracle.com> Hi, This is the difference with/without jsr-223 layer. Even by using 'jjs' shell - which uses straight nashorn Context API - user will see these differences. There are Java integration differences b/w rhino and nashorn - which will make into jdk8 docs eventually. For now, user can generate javadocs and go through javadoc of the class "NativeJava". -Sundar Marcus Lagergren wrote: > So code generation wise, I've verified that the type system is internally consistent. This is a rhino/nashorn different when it comes to JSR223. > > /M > > On Jan 10, 2013, at 4:18 PM, Attila Szegedi wrote: > > >> Hi Andreas, >> >> I'm sorry - maybe then I did not understand the motivation for you sending that last code snippet with 2D arrays. Did you just want to illustrate another difference in array handling, or does it illustrate a further problem that you'd need solved? >> >> Attila. >> >> On Jan 10, 2013, at 4:05 PM, Andreas Rieber wrote: >> >> >>> Hi Attila, >>> >>> yes i read all mails and there are already four different workaround for the array topic. No problem, just different from Rhino. >>> >>> Andreas >>> >>> On 10.01.13 14:34, Attila Szegedi wrote: >>> >>>> Andreas, did you read Sundar's response where he explained to you the need to use Java.toJavaArray() for explicit conversion of JavaScript arrays to Java arrays? It seems that your code still doesn't use Java.toJavaArray(). >>>> >>>> Attila. >>>> >>>> On Jan 10, 2013, at 2:07 PM, Andreas Rieber wrote: >>>> >>>> >>>>> Hi Marcus, >>>>> >>>>> i improved the test and found another case (sorry for that ;-) >>>>> >>>>> Whenever you have a fix, i could provide the patch for jrunscript (workaround working): >>>>> >>>>> ./usr/local/src/jdk8/build/linux-i586/j2sdk-image/bin/jrunscript -cp /usr/local/src/jdk8/nashorn/dist/nashorn.jar:. -l nashorn >>>>> nashorn> printf("%03d %2.2f%n",1,2); >>>>> 001 2.00 >>>>> nashorn> >>>>> >>>>> - Andreas >>>>> >>>>> On 09.01.13 16:50, Marcus Lagergren wrote: >>>>> >>>>>> My bad. This actually reproduces through the JSR223 bridge. Must be an eval related problem. I am on it! >>>>>> >>>>>> /M >>>>>> >>>>>> >>>>>> On Jan 9, 2013, at 4:26 PM, Marcus Lagergren wrote: >>>>>> >>>>>> >>>>>>> Where did you get/build your nashorn.jar? We'll get proper versioning in there as soon as we've integrated fully with the OpenJDK build system. I still get nothing when I manually build the latest nashorn.jar from the openjdk and run the JS snippet from the command line with java -jar nashorn.jar (Haven't gone through the script engine bridge, but as it seems to be a JavaScript problem it should be sufficient to run it as a standalone script). This very much looks like a bug that I fixed before christmas and pushed into the closed repo - I've verified that it made it into the openjdk source. >>>>>>> /M >>>>>>> >>>>> >>>>> > > From rieberandreas at gmail.com Thu Jan 10 11:45:21 2013 From: rieberandreas at gmail.com (Andreas Rieber) Date: Thu, 10 Jan 2013 20:45:21 +0100 Subject: some nashorn testing/ jrunscript patch In-Reply-To: <405B16AC-2B92-4692-B7D3-C25FD0300A81@oracle.com> References: <50EC55C6.1040109@gmail.com> <405B16AC-2B92-4692-B7D3-C25FD0300A81@oracle.com> Message-ID: <50EF1A51.6010906@gmail.com> Hi Jim, please find attached the jrunscript patch(es). The small Nashorn patch took me a while to find out... The jdk8 patch is hg export -g like expected on openjdk.java.net contributing page. I also updated the jtreg test. The patch for jdk8 has a new file for the formatting. Tricky part for printf/sprintf was to do the type conversion of the javascript types. The init.js file will now work with Nashorn and Rhino. nashorn> printf("%5d %f %s %B %c % printf("java.util.Date(): %1$tm %1$te, %1$tY%n", new java.util.Date()); java.util.Date(): 01 10, 2013 nashorn> printf("javascript Date(): %1$tm %1$te, %1$tY%n", new Date()); javascript Date(): 01 10, 2013 nashorn> printf("%c %c %c %d %d%n", 'a', "b", 65, -1, "Hello"); a b A -1 72 nashorn> The jdk8 patch works also for jdk7u as that's where i started. I will see if i get scriptpad sample also working. - Andreas On 08.01.13 19:12, Jim Laskey (Oracle) wrote: > On 2013-01-08, at 1:22 PM, Andreas Rieber wrote: > >> Hi, >> >> i tested Nashorn with a project i am currently working on (scripting >> java). The first thing i spotted is that Rhino comes with print() and >> println() as default functions in: >> >> jdk8/jdk/src/share/classes/com/sun/script/javascript/RhinoScriptEngine.java >> >> while Nashorn has only a print(): >> >> jdk8/nashorn/src/jdk/nashorn/api/scripting/NashornScriptEngine.java >> jdk8/nashorn/src/jdk/nashorn/api/scripting/resources/engine.js >> >> Will this be changed or is that a migration issue? > We opted for print because we were primarily using V8 performance tests and v8 only supports print. Standalone rhino does not support println either. We did have a switch for turning on println, but it fell out of favour to be consistent with other VMs. > > You can duplicate the behaviour with; > > function print(s) { java.lang.System.out.print("" + s); } > function println(s) { java.lang.System.out.println("" + s); } > > >> importClass works only with: load("nashorn:mozilla_compat.js"); >> What is with importPackage (also used in jrunscript)? >> > importClass is being phased out since it duplicates the builtin behaviour of Packages and JavaClass. > > importPackage(java.awt); > importClass(java.awt.Frame); > > is just > > var awt = java.awt; > var Frame = java.awt.Frame; > > >> Next problem i had was related to java array creation. Here the sample >> from JSE 7 Documentation "Java Scripting Programmer's Guide": >> >> // create Java String array of 5 elements >> var a = java.lang.reflect.Array.newInstance(java.lang.String, 5); >> >> // Accessing elements and length access is by usual Java syntax >> a[0] = "scripting is great!"; >> print(a.length); >> >> It works with Rhino but fails with Nashorn: >> >> Exception in thread "main" java.lang.RuntimeException: java.lang.NoSuchMethodException: None of the fixed arity signatures [(java.lang.Class, int[]), (java.lang.Class, int)] or the variable arity signatures [(java.lang.Class, int...)] of the method java.lang.reflect.Array.newInstance match the argument types [org.dynalang.dynalink.beans.StaticClass, java.lang.Integer] >> >> The default number type for Rhino in vararg functions is double while >> Nashorn has also integer (nice), might be a migration issue. > > We are pushing the Java syntax here to eliminate confusion between the java class and the JavaClass javascript object. This eliminates the confusion when accessing members of the (String) class when a javascript object and members of the class itself when a java object. > > jjs> java.lang.String > [JavaClass java.lang.String] > jjs> java.lang.String.class > class java.lang.String > > so > > var a = java.lang.reflect.Array.newInstance(java.lang.String.class, 5); > >> Is jrunscript and the scriptpad sample application >> (jdk8/jdk/src/share/sample/scripting/scriptpad) now also developed >> under Nashorn project? I would like to contribute a patch for >> jrunscript (printf never worked and i added also a sprintf), the >> scriptpad needed only a few fixes to work with Rhino. I signed the OCA >> recently. > Contributions welcome. > > I just see Attila answered differently, but both forms work. > > >> best regards >> Andreas >> -------------- next part -------------- diff --git a/src/jdk/nashorn/api/scripting/NashornScriptEngine.java b/src/jdk/nashorn/api/scripting/NashornScriptEngine.java --- a/src/jdk/nashorn/api/scripting/NashornScriptEngine.java +++ b/src/jdk/nashorn/api/scripting/NashornScriptEngine.java @@ -485,12 +485,6 @@ try { final Object val = ctxt.getAttribute(ScriptEngine.FILENAME); final String fileName = (val != null) ? val.toString() : ""; - - // !!HACK!! do not evaluate "init.js" from jrunscript tool!! - if ("".equals(fileName)) { - return null; - } - final Source source = new Source(fileName, buf); if (globalChanged) { setNashornGlobal(global); -------------- next part -------------- # HG changeset patch # User arieber # Date 1357845438 -3600 # Node ID 99350545e3f5ecb0fe11fb9cce86f36664a375e9 # Parent 32a57e645e012a1f0665c075969ca598e0dbb948 fixed jrunscript for Nashorn+Rhino, added sprintf and got printf working. diff --git a/src/share/classes/com/sun/tools/script/shell/Formatter.java b/src/share/classes/com/sun/tools/script/shell/Formatter.java new file mode 100644 --- /dev/null +++ b/src/share/classes/com/sun/tools/script/shell/Formatter.java @@ -0,0 +1,182 @@ +/* + * Copyright (c) 2013 Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. Oracle designates this + * particular file as subject to the "Classpath" exception as provided + * by Oracle in the LICENSE file that accompanied this code. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +package com.sun.tools.script.shell; + +import java.util.regex.Matcher; +import java.util.regex.Pattern; + +/** + * Formatter is a class to get the type conversion between javascript types and + * java types for the format (sprintf) method working. + * + *

In javascript the type for numbers can be different from the format type + * specifier. For format type '%d', '%o', '%x', '%X' double need to be + * converted to integer. For format type 'e', 'E', 'f', 'g', 'G', 'a', 'A' + * integer needs to be converted to double. + * + *

Format type "%c" and javascript string needs special handling. + * + *

The javascript date objects can be handled if they are type double (the + * related javascript code will convert with Date.getTime() to double). So + * double date types are converted to long. + * + *

Pattern and the logic for parameter position: java.util.Formatter + * + * @author Andreas Rieber + * @since 1.8 + */ +public class Formatter { + + /** + * Method which converts javascript types to java types for the + * String.format method (jrunscript function sprintf). + * + * @param format a format string + * @param args arguments referenced by the format specifiers in format + * @return a formatted string + */ + public static String format(String format, Object[] args) { + Matcher m = fsPattern.matcher(format); + int positionalParameter = 1; + + while (m.find()) { + int index = index(m.group(1)); + boolean previous = isPreviousArgument(m.group(2)); + char conversion = m.group(6).charAt(0); + + // skip over some formats + if (index < 0 || previous + || conversion == 'n' || conversion == '%') { + continue; + } + + // index 0 here means take a positional parameter + if (index == 0) { + index = positionalParameter++; + } + + // out of index, String.format will handle + if (index > args.length) { + continue; + } + + // current argument + Object arg = args[index - 1]; + + // for date we convert double to long + if (m.group(5) != null) { + // convert double to long + if (arg instanceof Double) { + args[index - 1] = ((Double) arg).longValue(); + } + } else { + // we have to convert some types + switch (conversion) { + case 'd': + case 'o': + case 'x': + case 'X': + if (arg instanceof Double) { + // convert double to long + args[index - 1] = ((Double) arg).longValue(); + } else if (arg instanceof String + && ((String) arg).length() > 0) { + // convert string (first character) to int + args[index - 1] = (int) ((String) arg).charAt(0); + } + break; + case 'e': + case 'E': + case 'f': + case 'g': + case 'G': + case 'a': + case 'A': + if (arg instanceof Integer) { + // convert integer to double + args[index - 1] = ((Integer) arg).doubleValue(); + } + break; + case 'c': + if (arg instanceof Double) { + // convert double to integer + args[index - 1] = ((Double) arg).intValue(); + } else if (arg instanceof String + && ((String) arg).length() > 0) { + // get the first character from string + args[index - 1] = (int) ((String) arg).charAt(0); + } + break; + default: + break; + } + } + } + + return String.format(format, args); + } + + /** + * Method to parse the integer of the argument index. + * + * @param s + * @return -1 if parsing failed, 0 if string is null, > 0 integer + */ + private static int index(String s) { + int index = -1; + + if (s != null) { + try { + index = Integer.parseInt(s.substring(0, s.length() - 1)); + } catch (NumberFormatException e) { } + } else { + index = 0; + } + + return index; + } + + /** + * Method to check if a string contains '<'. This is used to find out if + * previous parameter is used. + * + * @param s + * @return true if '<' is in the string, else false + */ + private static boolean isPreviousArgument(String s) { + return (s != null && s.indexOf('<') >= 0) ? true : false; + } + + // %[argument_index$][flags][width][.precision][t]conversion + private static final String formatSpecifier = + "%(\\d+\\$)?([-#+ 0,(\\<]*)?(\\d+)?(\\.\\d+)?([tT])?([a-zA-Z%])"; + // compiled format string + private static Pattern fsPattern; + + static { + fsPattern = Pattern.compile(formatSpecifier); + } +} diff --git a/src/share/classes/com/sun/tools/script/shell/init.js b/src/share/classes/com/sun/tools/script/shell/init.js --- a/src/share/classes/com/sun/tools/script/shell/init.js +++ b/src/share/classes/com/sun/tools/script/shell/init.js @@ -1,5 +1,5 @@ /* - * Copyright (c) 2005, 2010, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2005, 2013, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -47,7 +47,7 @@ __get__ : function(name) { return function() { return obj.invoke(name, arguments); - } + }; } }); } @@ -200,8 +200,18 @@ var inp = java.lang.System["in"]; // useful imports for often used io, net classes -importPackage(java.io); -importPackage(java.net); +var BufferedInputStream = java.io.BufferedInputStream; +var BufferedOutputStream = java.io.BufferedOutputStream; +var BufferedReader = java.io.BufferedReader; +var DataInputStream = java.io.DataInputStream; +var File = java.io.File; +var FileInputStream = java.io.FileInputStream; +var FileOutputStream = java.io.FileOutputStream; +var InputStream = java.io.InputStream; +var InputStreamReader = java.io.InputStreamReader; +var OutputStream = java.io.OutputStream; +var Reader = java.io.Reader; +var URL = java.net.URL; /** * Generic any object to input stream mapper @@ -302,18 +312,20 @@ * * @param str input from which script is loaded and evaluated */ -function load(str) { - var stream = inStream(str); - var bstream = new BufferedInputStream(stream); - var reader = new BufferedReader(new InputStreamReader(bstream)); - var oldFilename = engine.get(engine.FILENAME); - engine.put(engine.FILENAME, str); - try { - engine.eval(reader); - } finally { - engine.put(engine.FILENAME, oldFilename); +if (load === undefined) { + var load = function load(str) { + var stream = inStream(str); + var bstream = new BufferedInputStream(stream); + var reader = new BufferedReader(new InputStreamReader(bstream)); + var oldFilename = engine.get(engine.FILENAME); + engine.put(engine.FILENAME, str); + try { + engine.eval(reader); + } finally { + engine.put(engine.FILENAME, oldFilename); streamClose(stream); - } + } + }; } // file system utilities @@ -458,7 +470,7 @@ * @param dir name of the new directory */ function mkdir(dir) { - var dir = pathToFile(dir); + dir = pathToFile(dir); println(dir.mkdir()? "created" : "can not create dir"); } @@ -469,7 +481,7 @@ * @param dir input path name */ function mkdirs(dir) { - var dir = pathToFile(dir); + dir = pathToFile(dir); println(dir.mkdirs()? "created" : "can not create dirs"); } @@ -479,7 +491,7 @@ * @param pathname name of the file */ function rm(pathname) { - file = pathToFile(pathname); + var file = pathToFile(pathname); if (!file.exists()) { println("file not found: " + pathname); return false; @@ -586,7 +598,7 @@ for (var i in files) { var f = files[i]; if (filter) { - if(!f.getName().match(filter)) { + if (!f.getName().match(filter)) { continue; } } @@ -776,7 +788,7 @@ } var factory = javax.xml.transform.TransformerFactory.newInstance(); - var tranformer; + var transformer; if (style) { transformer = factory.newTransformer(XMLSource(style)); } else { @@ -840,18 +852,42 @@ } /** - * This is C-like printf + * This is C-like printf * * @param format string to format the rest of the print items * @param args variadic argument list */ -function printf(format, args/*, more args*/) { - var array = java.lang.reflect.Array.newInstance(java.lang.Object, - arguments.length - 1); - for (var i = 0; i < array.length; i++) { - array[i] = arguments[i+1]; +function printf(format, args/*, more args*/) { + print(sprintf.apply(this, arguments)); +} + +/** + * This is C-like sprintf + * + * @param format string to format the rest of the print items + * @param args variadic argument list + */ +function sprintf(format, args/*, more args*/) { + var len = arguments.length - 1; + var array = []; + + if (len < 0) { + return ""; } - return java.lang.System.out.printf(format, array); + + for (var i = 0; i < len; i++) { + if (arguments[i+1] instanceof Date) { + array[i] = arguments[i+1].getTime(); + } else { + array[i] = arguments[i+1]; + } + } + + if( typeof Java !== "undefined") { + array = Java.toJavaArray(array); + } + + return Packages.com.sun.tools.script.shell.Formatter.format(format, array); } /** @@ -882,3 +918,23 @@ return reader.readLine(); } } + +// Nashorn has only print, so we define it here +if (println === undefined) { + var print = function print(str, newline) { + if (typeof(str) == 'undefined') { + str = 'undefined'; + } else if (str == null) { + str = 'null'; + } + if (!(out instanceof java.io.PrintWriter)) + out = new java.io.PrintWriter(out); + out.print(String(str)); + if (newline) out.print('\n'); + out.flush(); + }; + + var println = function println(str) { + print(str, true); + }; +} diff --git a/test/sun/tools/jrunscript/jrunscriptTest.sh b/test/sun/tools/jrunscript/jrunscriptTest.sh --- a/test/sun/tools/jrunscript/jrunscriptTest.sh +++ b/test/sun/tools/jrunscript/jrunscriptTest.sh @@ -46,6 +46,7 @@ v = v + " is the value"; if (v != 0) { println('yes v != 0'); } java.lang.System.out.println('hello world from script'); +printf("%3d\n",1); new java.lang.Runnable() { run: function() { println('I am runnable'); }}.run(); EOF @@ -64,6 +65,7 @@ v = v + " is the value"; if (v != 0) { println('yes v != 0'); } java.lang.System.out.println('hello world from script'); +printf("%3d\n",1); new java.lang.Runnable() { run: function() { println('I am runnable'); }}.run(); EOF diff --git a/test/sun/tools/jrunscript/repl.out b/test/sun/tools/jrunscript/repl.out --- a/test/sun/tools/jrunscript/repl.out +++ b/test/sun/tools/jrunscript/repl.out @@ -3,5 +3,6 @@ js> 35 is the value js> yes v != 0 js> hello world from script +js> 1 js> I am runnable js> \ No newline at end of file From james.laskey at oracle.com Thu Jan 10 12:12:03 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Thu, 10 Jan 2013 16:12:03 -0400 Subject: some nashorn testing/ jrunscript patch In-Reply-To: <50EF1A51.6010906@gmail.com> References: <50EC55C6.1040109@gmail.com> <405B16AC-2B92-4692-B7D3-C25FD0300A81@oracle.com> <50EF1A51.6010906@gmail.com> Message-ID: Thanks Andreas. Looks good, but I'll get Sundar (jrunscript expert) to review everything first. Cheers, -- Jim On 2013-01-10, at 3:45 PM, Andreas Rieber wrote: > Hi Jim, > > please find attached the jrunscript patch(es). The small Nashorn patch took me a while to find out... The jdk8 patch is hg export -g like expected on openjdk.java.net contributing page. I also updated the jtreg test. > > The patch for jdk8 has a new file for the formatting. Tricky part for printf/sprintf was to do the type conversion of the javascript types. The init.js file will now work with Nashorn and Rhino. > > nashorn> printf("%5d %f %s %B %c % 1 2.000000 3 TRUE a 97 > nashorn> printf("java.util.Date(): %1$tm %1$te, %1$tY%n", new java.util.Date()); > java.util.Date(): 01 10, 2013 > nashorn> printf("javascript Date(): %1$tm %1$te, %1$tY%n", new Date()); > javascript Date(): 01 10, 2013 > nashorn> printf("%c %c %c %d %d%n", 'a', "b", 65, -1, "Hello"); > a b A -1 72 > nashorn> > > The jdk8 patch works also for jdk7u as that's where i started. > I will see if i get scriptpad sample also working. > > - Andreas > > > On 08.01.13 19:12, Jim Laskey (Oracle) wrote: >> On 2013-01-08, at 1:22 PM, Andreas Rieber wrote: >> >>> Hi, >>> >>> i tested Nashorn with a project i am currently working on (scripting >>> java). The first thing i spotted is that Rhino comes with print() and >>> println() as default functions in: >>> >>> jdk8/jdk/src/share/classes/com/sun/script/javascript/RhinoScriptEngine.java >>> >>> while Nashorn has only a print(): >>> >>> jdk8/nashorn/src/jdk/nashorn/api/scripting/NashornScriptEngine.java >>> jdk8/nashorn/src/jdk/nashorn/api/scripting/resources/engine.js >>> >>> Will this be changed or is that a migration issue? >> We opted for print because we were primarily using V8 performance tests and v8 only supports print. Standalone rhino does not support println either. We did have a switch for turning on println, but it fell out of favour to be consistent with other VMs. >> >> You can duplicate the behaviour with; >> >> function print(s) { java.lang.System.out.print("" + s); } >> function println(s) { java.lang.System.out.println("" + s); } >> >> >>> importClass works only with: load("nashorn:mozilla_compat.js"); >>> What is with importPackage (also used in jrunscript)? >>> >> importClass is being phased out since it duplicates the builtin behaviour of Packages and JavaClass. >> >> importPackage(java.awt); >> importClass(java.awt.Frame); >> >> is just >> >> var awt = java.awt; >> var Frame = java.awt.Frame; >> >> >>> Next problem i had was related to java array creation. Here the sample >>> from JSE 7 Documentation "Java Scripting Programmer's Guide": >>> >>> // create Java String array of 5 elements >>> var a = java.lang.reflect.Array.newInstance(java.lang.String, 5); >>> >>> // Accessing elements and length access is by usual Java syntax >>> a[0] = "scripting is great!"; >>> print(a.length); >>> >>> It works with Rhino but fails with Nashorn: >>> >>> Exception in thread "main" java.lang.RuntimeException: java.lang.NoSuchMethodException: None of the fixed arity signatures [(java.lang.Class, int[]), (java.lang.Class, int)] or the variable arity signatures [(java.lang.Class, int...)] of the method java.lang.reflect.Array.newInstance match the argument types [org.dynalang.dynalink.beans.StaticClass, java.lang.Integer] >>> >>> The default number type for Rhino in vararg functions is double while >>> Nashorn has also integer (nice), might be a migration issue. >> >> We are pushing the Java syntax here to eliminate confusion between the java class and the JavaClass javascript object. This eliminates the confusion when accessing members of the (String) class when a javascript object and members of the class itself when a java object. >> >> jjs> java.lang.String >> [JavaClass java.lang.String] >> jjs> java.lang.String.class >> class java.lang.String >> >> so >> >> var a = java.lang.reflect.Array.newInstance(java.lang.String.class, 5); >> >>> Is jrunscript and the scriptpad sample application >>> (jdk8/jdk/src/share/sample/scripting/scriptpad) now also developed >>> under Nashorn project? I would like to contribute a patch for >>> jrunscript (printf never worked and i added also a sprintf), the >>> scriptpad needed only a few fixes to work with Rhino. I signed the OCA >>> recently. >> Contributions welcome. >> >> I just see Attila answered differently, but both forms work. >> >> >>> best regards >>> Andreas >>> -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: jrunscript_nashorn.patch Url: http://mail.openjdk.java.net/pipermail/nashorn-dev/attachments/20130110/02ddb21e/jrunscript_nashorn.patch -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: jrunscript_jdk8.patch Url: http://mail.openjdk.java.net/pipermail/nashorn-dev/attachments/20130110/02ddb21e/jrunscript_jdk8.patch -------------- next part -------------- From marcus.lagergren at oracle.com Fri Jan 11 00:47:59 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Fri, 11 Jan 2013 09:47:59 +0100 Subject: Review request for http://cr.openjdk.java.net/~lagergren/8005976/webrev/ Message-ID: Can I get a review request for http://cr.openjdk.java.net/~lagergren/8005976/webrev/ please. I've finally managed to break out Access Specialization (call site specialization) as an iterative phase inside code generator and put it after Lowering. The next step is to assign symbol types only after Lower and Access Specialization have been completed so constructs like var x ; function f() { var y = (x=55); } won't get object fields. y can be a local slot of type int, but right now Lower, before any scope analysis has taken places goes ahead and says "d'uh - this x - it's an Object". This has been the behavior since the beginning of time, before we started looking at individual callsites. Access Specializer then says "well, it's in scope, but at least you can specialize the callsite to an int" and then no one ever updates y. So I'm slowly starting to decouple these too conservative type analysis dependencies. This is because good call site type information is the absolute key for iterative/lazy jitting in the future execution model. I've verified that we do more and not fewer call site specializations with this change (I checked in a previous version of this in November that was reverted becaus as the scope analysis was incorrect and the AccessSpecializer got a lot more conservative.) This is not a problem anymore with this change. Also added some more compiler logging so we can see what the Compiler is doing in greater detail with --log=compile. Test runs. Test 262 runs. Node.js tests run (at least as well good as tip does). /M ' From attila.szegedi at oracle.com Fri Jan 11 01:14:41 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Fri, 11 Jan 2013 10:14:41 +0100 Subject: Review request for http://cr.openjdk.java.net/~lagergren/8005976/webrev/ In-Reply-To: References: Message-ID: - updateSymbolsLog() is only ever invoked with setScope==true - In Symbol.java, if you now have if() statements for checking whether setIsScope() and setSlot() will actually change any state for logging purposes, why not move the operations themselves into the conditional block? These two minor things are all I have. Attila. On Jan 11, 2013, at 9:47 AM, Marcus Lagergren wrote: > Can I get a review request for http://cr.openjdk.java.net/~lagergren/8005976/webrev/ please. > > I've finally managed to break out Access Specialization (call site specialization) as an iterative phase inside code generator and put it after Lowering. > > The next step is to assign symbol types only after Lower and Access Specialization have been completed so constructs like > > var x ; > function f() { > var y = (x=55); > } > > won't get object fields. y can be a local slot of type int, but right now Lower, before any scope analysis has taken places goes ahead and says "d'uh - this x - it's an Object". This has been the behavior since the beginning of time, before we started looking at individual callsites. Access Specializer then says "well, it's in scope, but at least you can specialize the callsite to an int" and then no one ever updates y. > > So I'm slowly starting to decouple these too conservative type analysis dependencies. This is because good call site type information is the absolute key for iterative/lazy jitting in the future execution model. > > I've verified that we do more and not fewer call site specializations with this change (I checked in a previous version of this in November that was reverted becaus as the scope analysis was incorrect and the AccessSpecializer got a lot more conservative.) This is not a problem anymore with this change. > > Also added some more compiler logging so we can see what the Compiler is doing in greater detail with --log=compile. > > Test runs. Test 262 runs. Node.js tests run (at least as well good as tip does). > > /M > ' From marcus.lagergren at oracle.com Fri Jan 11 01:17:47 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Fri, 11 Jan 2013 10:17:47 +0100 Subject: Review request for http://cr.openjdk.java.net/~lagergren/8005976/webrev/ In-Reply-To: References: Message-ID: <8167744C-8E89-4EF8-AB06-FAB8603D5DA2@oracle.com> Fixed. Thanks, dude. On Jan 11, 2013, at 10:14 AM, Attila Szegedi wrote: > - updateSymbolsLog() is only ever invoked with setScope==true > - In Symbol.java, if you now have if() statements for checking whether setIsScope() and setSlot() will actually change any state for logging purposes, why not move the operations themselves into the conditional block? > > These two minor things are all I have. > > Attila. > > On Jan 11, 2013, at 9:47 AM, Marcus Lagergren wrote: > >> Can I get a review request for http://cr.openjdk.java.net/~lagergren/8005976/webrev/ please. >> >> I've finally managed to break out Access Specialization (call site specialization) as an iterative phase inside code generator and put it after Lowering. >> >> The next step is to assign symbol types only after Lower and Access Specialization have been completed so constructs like >> >> var x ; >> function f() { >> var y = (x=55); >> } >> >> won't get object fields. y can be a local slot of type int, but right now Lower, before any scope analysis has taken places goes ahead and says "d'uh - this x - it's an Object". This has been the behavior since the beginning of time, before we started looking at individual callsites. Access Specializer then says "well, it's in scope, but at least you can specialize the callsite to an int" and then no one ever updates y. >> >> So I'm slowly starting to decouple these too conservative type analysis dependencies. This is because good call site type information is the absolute key for iterative/lazy jitting in the future execution model. >> >> I've verified that we do more and not fewer call site specializations with this change (I checked in a previous version of this in November that was reverted becaus as the scope analysis was incorrect and the AccessSpecializer got a lot more conservative.) This is not a problem anymore with this change. >> >> Also added some more compiler logging so we can see what the Compiler is doing in greater detail with --log=compile. >> >> Test runs. Test 262 runs. Node.js tests run (at least as well good as tip does). >> >> /M >> ' > From hannes.wallnoefer at oracle.com Fri Jan 11 01:37:41 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Fri, 11 Jan 2013 10:37:41 +0100 Subject: Review request for http://cr.openjdk.java.net/~lagergren/8005976/webrev/ In-Reply-To: References: Message-ID: <50EFDD65.5070905@oracle.com> Looks good to me! Hannes Am 2013-01-11 09:47, schrieb Marcus Lagergren: > Can I get a review request for http://cr.openjdk.java.net/~lagergren/8005976/webrev/ please. > > I've finally managed to break out Access Specialization (call site specialization) as an iterative phase inside code generator and put it after Lowering. > > The next step is to assign symbol types only after Lower and Access Specialization have been completed so constructs like > > var x ; > function f() { > var y = (x=55); > } > > won't get object fields. y can be a local slot of type int, but right now Lower, before any scope analysis has taken places goes ahead and says "d'uh - this x - it's an Object". This has been the behavior since the beginning of time, before we started looking at individual callsites. Access Specializer then says "well, it's in scope, but at least you can specialize the callsite to an int" and then no one ever updates y. > > So I'm slowly starting to decouple these too conservative type analysis dependencies. This is because good call site type information is the absolute key for iterative/lazy jitting in the future execution model. > > I've verified that we do more and not fewer call site specializations with this change (I checked in a previous version of this in November that was reverted becaus as the scope analysis was incorrect and the AccessSpecializer got a lot more conservative.) This is not a problem anymore with this change. > > Also added some more compiler logging so we can see what the Compiler is doing in greater detail with --log=compile. > > Test runs. Test 262 runs. Node.js tests run (at least as well good as tip does). > > /M > ' From sundararajan.athijegannathan at oracle.com Fri Jan 11 04:25:00 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Fri, 11 Jan 2013 17:55:00 +0530 Subject: Review request JDK-8006082 : Provide option to run octane benchmarks in separate processes Message-ID: <50F0049C.7040604@oracle.com> Hi, Please review http://cr.openjdk.java.net/~sundar/8006082/ Thanks -Sundar From marcus.lagergren at oracle.com Fri Jan 11 04:26:27 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Fri, 11 Jan 2013 13:26:27 +0100 Subject: Review request JDK-8006082 : Provide option to run octane benchmarks in separate processes In-Reply-To: <50F0049C.7040604@oracle.com> References: <50F0049C.7040604@oracle.com> Message-ID: <0A1430CA-ABEE-46C8-83DD-976487168BA7@oracle.com> +1 On Jan 11, 2013, at 1:25 PM, A. Sundararajan wrote: > Hi, > > Please review http://cr.openjdk.java.net/~sundar/8006082/ > > Thanks > -Sundar From james.laskey at oracle.com Fri Jan 11 04:29:38 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Fri, 11 Jan 2013 08:29:38 -0400 Subject: Review request JDK-8006082 : Provide option to run octane benchmarks in separate processes In-Reply-To: <50F0049C.7040604@oracle.com> References: <50F0049C.7040604@oracle.com> Message-ID: <894CE162-CA39-4EFE-AAF3-FBB02A654C1A@oracle.com> +1 On 2013-01-11, at 8:25 AM, "A. Sundararajan" wrote: > Hi, > > Please review http://cr.openjdk.java.net/~sundar/8006082/ > > Thanks > -Sundar From marcus.lagergren at oracle.com Fri Jan 11 04:28:59 2013 From: marcus.lagergren at oracle.com (marcus.lagergren at oracle.com) Date: Fri, 11 Jan 2013 12:28:59 +0000 Subject: hg: nashorn/jdk8/nashorn: 8005976: Break out AccessSpecializer into one pass before CodeGenerator instead of iterative applications from CodeGenerator Message-ID: <20130111122909.C9EA2471E4@hg.openjdk.java.net> Changeset: 2a4769fcd13f Author: lagergren Date: 2013-01-11 10:40 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/2a4769fcd13f 8005976: Break out AccessSpecializer into one pass before CodeGenerator instead of iterative applications from CodeGenerator Summary: Now scope and slot information is guaranteed to be fixed AND NOT CHANGE before CodeGeneration. We want to keep it that way to build future type specializations and bring all type work out of CodeGenerator. Reviewed-by: attila, hannesw + bin/dump_octane_code.sh ! bin/verbose_octane.sh ! docs/DEVELOPER_README ! src/jdk/nashorn/internal/codegen/AccessSpecializer.java ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/Compiler.java ! src/jdk/nashorn/internal/codegen/Lower.java ! src/jdk/nashorn/internal/codegen/Splitter.java - src/jdk/nashorn/internal/codegen/Transform.java ! src/jdk/nashorn/internal/ir/Block.java ! src/jdk/nashorn/internal/ir/FunctionNode.java ! src/jdk/nashorn/internal/ir/Symbol.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java From sundararajan.athijegannathan at oracle.com Fri Jan 11 04:52:39 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Fri, 11 Jan 2013 12:52:39 +0000 Subject: hg: nashorn/jdk8/nashorn: 8006082: Provide option to run octane benchmarks in separate processes Message-ID: <20130111125240.4E8CB471E6@hg.openjdk.java.net> Changeset: f67bf56495ca Author: sundar Date: 2013-01-11 18:26 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/f67bf56495ca 8006082: Provide option to run octane benchmarks in separate processes Reviewed-by: lagergren, jlaskey ! make/build-benchmark.xml ! make/project.properties From sundararajan.athijegannathan at oracle.com Fri Jan 11 06:48:56 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Fri, 11 Jan 2013 20:18:56 +0530 Subject: Review request JDK-8006093 : Add a makefile target to run all tests (test, test262, perf tests) Message-ID: <50F02658.2060005@oracle.com> Hi, Please review http://cr.openjdk.java.net/~sundar/8006093/ Thanks -Sundar From sundararajan.athijegannathan at oracle.com Fri Jan 11 07:00:36 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Fri, 11 Jan 2013 15:00:36 +0000 Subject: hg: nashorn/jdk8/nashorn: 8006093: Add a makefile target to run all tests (test, test262, perf tests) Message-ID: <20130111150038.5A843471ED@hg.openjdk.java.net> Changeset: 8a5922638ff0 Author: sundar Date: 2013-01-11 20:34 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/8a5922638ff0 8006093: Add a makefile target to run all tests (test, test262, perf tests) Reviewed-by: attila, hannesw ! make/Makefile ! make/build.xml From attila.szegedi at oracle.com Fri Jan 11 07:16:28 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Fri, 11 Jan 2013 16:16:28 +0100 Subject: Review request JDK-8006093 : Add a makefile target to run all tests (test, test262, perf tests) In-Reply-To: <50F02658.2060005@oracle.com> References: <50F02658.2060005@oracle.com> Message-ID: +1 On Jan 11, 2013, at 3:48 PM, "A. Sundararajan" wrote: > Hi, > > Please review http://cr.openjdk.java.net/~sundar/8006093/ > > Thanks > -Sundar From james.laskey at oracle.com Fri Jan 11 07:29:27 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Fri, 11 Jan 2013 11:29:27 -0400 Subject: Review request JDK-8006093 : Add a makefile target to run all tests (test, test262, perf tests) In-Reply-To: <50F02658.2060005@oracle.com> References: <50F02658.2060005@oracle.com> Message-ID: +1 On 2013-01-11, at 10:48 AM, A. Sundararajan wrote: > Hi, > > Please review http://cr.openjdk.java.net/~sundar/8006093/ > > Thanks > -Sundar From james.laskey at oracle.com Fri Jan 11 09:29:02 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Fri, 11 Jan 2013 13:29:02 -0400 Subject: some nashorn testing/ jrunscript patch In-Reply-To: References: <50EC55C6.1040109@gmail.com> <405B16AC-2B92-4692-B7D3-C25FD0300A81@oracle.com> <50EF1A51.6010906@gmail.com> Message-ID: <12E2A1A0-1F20-401D-BB9D-A741464729C6@oracle.com> Andreas, We will accept these changes with slight modifications. The changes will have be broken into two parts those affect Nashorn directly and those affecting jrunscript. The first part will go into the nashorn forest soon. The later will have to go thru ccc and will take some time. Thank you again. Cheers, -- Jim On 2013-01-10, at 4:12 PM, "Jim Laskey (Oracle)" wrote: > Thanks Andreas. Looks good, but I'll get Sundar (jrunscript expert) to review everything first. > > Cheers, > > -- Jim > > > On 2013-01-10, at 3:45 PM, Andreas Rieber wrote: > >> Hi Jim, >> >> please find attached the jrunscript patch(es). The small Nashorn patch took me a while to find out... The jdk8 patch is hg export -g like expected on openjdk.java.net contributing page. I also updated the jtreg test. >> >> The patch for jdk8 has a new file for the formatting. Tricky part for printf/sprintf was to do the type conversion of the javascript types. The init.js file will now work with Nashorn and Rhino. >> >> nashorn> printf("%5d %f %s %B %c %> 1 2.000000 3 TRUE a 97 >> nashorn> printf("java.util.Date(): %1$tm %1$te, %1$tY%n", new java.util.Date()); >> java.util.Date(): 01 10, 2013 >> nashorn> printf("javascript Date(): %1$tm %1$te, %1$tY%n", new Date()); >> javascript Date(): 01 10, 2013 >> nashorn> printf("%c %c %c %d %d%n", 'a', "b", 65, -1, "Hello"); >> a b A -1 72 >> nashorn> >> >> The jdk8 patch works also for jdk7u as that's where i started. >> I will see if i get scriptpad sample also working. >> >> - Andreas >> >> >> On 08.01.13 19:12, Jim Laskey (Oracle) wrote: >>> On 2013-01-08, at 1:22 PM, Andreas Rieber wrote: >>> >>>> Hi, >>>> >>>> i tested Nashorn with a project i am currently working on (scripting >>>> java). The first thing i spotted is that Rhino comes with print() and >>>> println() as default functions in: >>>> >>>> jdk8/jdk/src/share/classes/com/sun/script/javascript/RhinoScriptEngine.java >>>> >>>> while Nashorn has only a print(): >>>> >>>> jdk8/nashorn/src/jdk/nashorn/api/scripting/NashornScriptEngine.java >>>> jdk8/nashorn/src/jdk/nashorn/api/scripting/resources/engine.js >>>> >>>> Will this be changed or is that a migration issue? >>> We opted for print because we were primarily using V8 performance tests and v8 only supports print. Standalone rhino does not support println either. We did have a switch for turning on println, but it fell out of favour to be consistent with other VMs. >>> >>> You can duplicate the behaviour with; >>> >>> function print(s) { java.lang.System.out.print("" + s); } >>> function println(s) { java.lang.System.out.println("" + s); } >>> >>> >>>> importClass works only with: load("nashorn:mozilla_compat.js"); >>>> What is with importPackage (also used in jrunscript)? >>>> >>> importClass is being phased out since it duplicates the builtin behaviour of Packages and JavaClass. >>> >>> importPackage(java.awt); >>> importClass(java.awt.Frame); >>> >>> is just >>> >>> var awt = java.awt; >>> var Frame = java.awt.Frame; >>> >>> >>>> Next problem i had was related to java array creation. Here the sample >>>> from JSE 7 Documentation "Java Scripting Programmer's Guide": >>>> >>>> // create Java String array of 5 elements >>>> var a = java.lang.reflect.Array.newInstance(java.lang.String, 5); >>>> >>>> // Accessing elements and length access is by usual Java syntax >>>> a[0] = "scripting is great!"; >>>> print(a.length); >>>> >>>> It works with Rhino but fails with Nashorn: >>>> >>>> Exception in thread "main" java.lang.RuntimeException: java.lang.NoSuchMethodException: None of the fixed arity signatures [(java.lang.Class, int[]), (java.lang.Class, int)] or the variable arity signatures [(java.lang.Class, int...)] of the method java.lang.reflect.Array.newInstance match the argument types [org.dynalang.dynalink.beans.StaticClass, java.lang.Integer] >>>> >>>> The default number type for Rhino in vararg functions is double while >>>> Nashorn has also integer (nice), might be a migration issue. >>> >>> We are pushing the Java syntax here to eliminate confusion between the java class and the JavaClass javascript object. This eliminates the confusion when accessing members of the (String) class when a javascript object and members of the class itself when a java object. >>> >>> jjs> java.lang.String >>> [JavaClass java.lang.String] >>> jjs> java.lang.String.class >>> class java.lang.String >>> >>> so >>> >>> var a = java.lang.reflect.Array.newInstance(java.lang.String.class, 5); >>> >>>> Is jrunscript and the scriptpad sample application >>>> (jdk8/jdk/src/share/sample/scripting/scriptpad) now also developed >>>> under Nashorn project? I would like to contribute a patch for >>>> jrunscript (printf never worked and i added also a sprintf), the >>>> scriptpad needed only a few fixes to work with Rhino. I signed the OCA >>>> recently. >>> Contributions welcome. >>> >>> I just see Attila answered differently, but both forms work. >>> >>> >>>> best regards >>>> Andreas >>>> -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: jrunscript_nashorn.patch Url: http://mail.openjdk.java.net/pipermail/nashorn-dev/attachments/20130111/bea3e3e2/jrunscript_nashorn.patch -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: jrunscript_jdk8.patch Url: http://mail.openjdk.java.net/pipermail/nashorn-dev/attachments/20130111/bea3e3e2/jrunscript_jdk8.patch -------------- next part -------------- > From hannes.wallnoefer at oracle.com Fri Jan 11 09:47:23 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Fri, 11 Jan 2013 18:47:23 +0100 Subject: Joni regexp patch Message-ID: <50F0502B.8040106@oracle.com> I've uploaded a patch for using a modded Joni regexp engine (the regexp library from JRuby) with Nashorn: http://cr.openjdk.java.net/~hannesw/8006028/ This passes test and test262parallel, and it speeds up the Octane regexp benchmark almost 2x. Joni code adds about 180kb to the size of nashorn.jar. The patch moves Joni classes into package jdk.nashorn.internal.joni. Otherwise the code is identical to the "noencoding" branch on my github Joni fork where I have removed the dependency on the jcodings library and added some JavaScript support. https://github.com/hns/joni/tree/noencoding I guess there are some things to be considered with a patch this size. Looking forward to the discussion! Hannes From sundararajan.athijegannathan at oracle.com Mon Jan 14 04:58:38 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Mon, 14 Jan 2013 18:28:38 +0530 Subject: Review request JDK-8006181 : nashorn script engine does not run jrunscript's initialization script Message-ID: <50F400FE.20504@oracle.com> Hi, Please review http://cr.openjdk.java.net/~sundar/8006181/ This fix is by Andreas Rieber. The fix is to make sure nashorn script engine runs jrunscript's init script. Previously, nashorn script engine did not run jrunscript's init.js due to various incompatibilities b/w Rhino and Nashorn implementations. But, with Andreas' fix nashorn script engine runs a replacement "init.js". Please note that ideally we should fix JDK8's init.js copy. But, nashorn has not yet hit main jdk repo. Also, there is a chance that rhino *may* be removed for jdk8. So instead of waiting for all those, I am adapting Andreas' change for the interim. With the replacement init.js in nashorn.jar, nashorn will run jrunscript initialization script and we can run existing scripts that use jrunscript's init facilities. We can eventually modify jrunscript's init.js in future. Please review. Thanks -Sundar From james.laskey at oracle.com Mon Jan 14 05:13:18 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Mon, 14 Jan 2013 09:13:18 -0400 Subject: Review request JDK-8006181 : nashorn script engine does not run jrunscript's initialization script In-Reply-To: <50F400FE.20504@oracle.com> References: <50F400FE.20504@oracle.com> Message-ID: <7E502E02-63E9-4729-BF83-9A9C59CFBC31@oracle.com> +1 with tweaks On 2013-01-14, at 8:58 AM, A. Sundararajan wrote: > Hi, > > Please review http://cr.openjdk.java.net/~sundar/8006181/ > > This fix is by Andreas Rieber. The fix is to make sure nashorn script engine runs jrunscript's init script. Previously, nashorn script engine did not run jrunscript's init.js due to various incompatibilities b/w Rhino and Nashorn implementations. But, with Andreas' fix nashorn script engine runs a replacement "init.js". > > Please note that ideally we should fix JDK8's init.js copy. But, nashorn has not yet hit main jdk repo. Also, there is a chance that rhino *may* be removed for jdk8. So instead of waiting for all those, I am adapting Andreas' change for the interim. With the replacement init.js in nashorn.jar, nashorn will run jrunscript initialization script and we can run existing scripts that use jrunscript's init facilities. We can eventually modify jrunscript's init.js in future. > > Please review. > > Thanks > -Sundar > > From marcus.lagergren at oracle.com Mon Jan 14 05:35:37 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Mon, 14 Jan 2013 14:35:37 +0100 Subject: Review request JDK-8006181 : nashorn script engine does not run jrunscript's initialization script In-Reply-To: <50F400FE.20504@oracle.com> References: <50F400FE.20504@oracle.com> Message-ID: <97957177-1408-4B2D-8047-04F2DB2B70EE@oracle.com> +1 with changes discussed On Jan 14, 2013, at 1:58 PM, A. Sundararajan wrote: > Hi, > > Please review http://cr.openjdk.java.net/~sundar/8006181/ > > This fix is by Andreas Rieber. The fix is to make sure nashorn script engine runs jrunscript's init script. Previously, nashorn script engine did not run jrunscript's init.js due to various incompatibilities b/w Rhino and Nashorn implementations. But, with Andreas' fix nashorn script engine runs a replacement "init.js". > > Please note that ideally we should fix JDK8's init.js copy. But, nashorn has not yet hit main jdk repo. Also, there is a chance that rhino *may* be removed for jdk8. So instead of waiting for all those, I am adapting Andreas' change for the interim. With the replacement init.js in nashorn.jar, nashorn will run jrunscript initialization script and we can run existing scripts that use jrunscript's init facilities. We can eventually modify jrunscript's init.js in future. > > Please review. > > Thanks > -Sundar > > From attila.szegedi at oracle.com Mon Jan 14 00:15:39 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Mon, 14 Jan 2013 09:15:39 +0100 Subject: Review request for JDK-8006168 Message-ID: <364BF6AD-7735-4E76-BDBC-6E0F769921FE@oracle.com> Please review JDK-8006168 at http://cr.openjdk.java.net/~attila/8006168/webrev.00 Thanks, Attila. From attila.szegedi at oracle.com Mon Jan 14 06:13:35 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Mon, 14 Jan 2013 15:13:35 +0100 Subject: Review request for JDK-8006168 Message-ID: <98BC0BD2-569E-43F3-867C-B7B7B206AC36@oracle.com> Please review JDK-8006168 at http://cr.openjdk.java.net/~attila/8006168/webrev.00 Thanks, Attila. From james.laskey at oracle.com Mon Jan 14 06:33:21 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Mon, 14 Jan 2013 10:33:21 -0400 Subject: Review request for JDK-8006168 In-Reply-To: <98BC0BD2-569E-43F3-867C-B7B7B206AC36@oracle.com> References: <98BC0BD2-569E-43F3-867C-B7B7B206AC36@oracle.com> Message-ID: <93B70328-D196-4B79-8050-58A8F535251F@oracle.com> +1 On 2013-01-14, at 10:13 AM, Attila Szegedi wrote: > Please review JDK-8006168 at http://cr.openjdk.java.net/~attila/8006168/webrev.00 > > Thanks, > Attila. From sundararajan.athijegannathan at oracle.com Mon Jan 14 06:42:57 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Mon, 14 Jan 2013 20:12:57 +0530 Subject: Review request JDK-8006181 : nashorn script engine does not run jrunscript's initialization script In-Reply-To: <50F400FE.20504@oracle.com> References: <50F400FE.20504@oracle.com> Message-ID: <50F41971.1090108@oracle.com> Hi, Incorporated changes suggested. Please review: http://cr.openjdk.java.net/~sundar/8006181/webrev.01/ Hi Andreas, will you please look at it and see if everything is fine? Thanks -Sundar A. Sundararajan wrote: > Hi, > > Please review http://cr.openjdk.java.net/~sundar/8006181/ > > This fix is by Andreas Rieber. The fix is to make sure nashorn script > engine runs jrunscript's init script. Previously, nashorn script > engine did not run jrunscript's init.js due to various > incompatibilities b/w Rhino and Nashorn implementations. But, with > Andreas' fix nashorn script engine runs a replacement "init.js". > > Please note that ideally we should fix JDK8's init.js copy. But, > nashorn has not yet hit main jdk repo. Also, there is a chance that > rhino *may* be removed for jdk8. So instead of waiting for all those, > I am adapting Andreas' change for the interim. With the replacement > init.js in nashorn.jar, nashorn will run jrunscript initialization > script and we can run existing scripts that use jrunscript's init > facilities. We can eventually modify jrunscript's init.js in future. > > Please review. > > Thanks > -Sundar > > From rieberandreas at gmail.com Mon Jan 14 06:52:22 2013 From: rieberandreas at gmail.com (Andreas Rieber) Date: Mon, 14 Jan 2013 15:52:22 +0100 Subject: Review request JDK-8006181 : nashorn script engine does not run jrunscript's initialization script In-Reply-To: <50F41971.1090108@oracle.com> References: <50F400FE.20504@oracle.com> <50F41971.1090108@oracle.com> Message-ID: <50F41BA6.2000009@gmail.com> looks good to me. The only problem is if someone has a file name called ''. So i would add a comment that it is still a hack. Up to you. Andreas On 14.01.13 15:42, A. Sundararajan wrote: > Hi, > > Incorporated changes suggested. Please review: > http://cr.openjdk.java.net/~sundar/8006181/webrev.01/ > > Hi Andreas, will you please look at it and see if everything is fine? > > Thanks > -Sundar > > A. Sundararajan wrote: >> Hi, >> >> Please review http://cr.openjdk.java.net/~sundar/8006181/ >> >> This fix is by Andreas Rieber. The fix is to make sure nashorn script >> engine runs jrunscript's init script. Previously, nashorn script >> engine did not run jrunscript's init.js due to various >> incompatibilities b/w Rhino and Nashorn implementations. But, with >> Andreas' fix nashorn script engine runs a replacement "init.js". >> >> Please note that ideally we should fix JDK8's init.js copy. But, >> nashorn has not yet hit main jdk repo. Also, there is a chance that >> rhino *may* be removed for jdk8. So instead of waiting for all those, >> I am adapting Andreas' change for the interim. With the replacement >> init.js in nashorn.jar, nashorn will run jrunscript initialization >> script and we can run existing scripts that use jrunscript's init >> facilities. We can eventually modify jrunscript's init.js in future. >> >> Please review. >> >> Thanks >> -Sundar >> >> > -- Dipl.Inform. (FH) Andreas Rieber Freiburger Str. 30 65205 Wiesbaden Tel./Fax: +49 (0) 6122 72 765 12 Mobil: +49 (0) 1573 4831338 E-Mail: andreas.rieber at t-online.de, rieberandreas at gmail.com Skype: Andreas.Rieber From sundararajan.athijegannathan at oracle.com Mon Jan 14 06:58:00 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Mon, 14 Jan 2013 20:28:00 +0530 Subject: Review request JDK-8006181 : nashorn script engine does not run jrunscript's initialization script In-Reply-To: <50F41BA6.2000009@gmail.com> References: <50F400FE.20504@oracle.com> <50F41971.1090108@oracle.com> <50F41BA6.2000009@gmail.com> Message-ID: <50F41CF8.2010100@oracle.com> Good point. I'll add a FIXME comment there and commit the changes. Thanks for the review. -Sundar Andreas Rieber wrote: > looks good to me. The only problem is if someone has a file name > called ''. So i would add a comment that it is still a > hack. Up to you. > > Andreas > > On 14.01.13 15:42, A. Sundararajan wrote: >> Hi, >> >> Incorporated changes suggested. Please review: >> http://cr.openjdk.java.net/~sundar/8006181/webrev.01/ >> >> Hi Andreas, will you please look at it and see if everything is fine? >> >> Thanks >> -Sundar >> >> A. Sundararajan wrote: >>> Hi, >>> >>> Please review http://cr.openjdk.java.net/~sundar/8006181/ >>> >>> This fix is by Andreas Rieber. The fix is to make sure nashorn >>> script engine runs jrunscript's init script. Previously, nashorn >>> script engine did not run jrunscript's init.js due to various >>> incompatibilities b/w Rhino and Nashorn implementations. But, with >>> Andreas' fix nashorn script engine runs a replacement "init.js". >>> >>> Please note that ideally we should fix JDK8's init.js copy. But, >>> nashorn has not yet hit main jdk repo. Also, there is a chance that >>> rhino *may* be removed for jdk8. So instead of waiting for all >>> those, I am adapting Andreas' change for the interim. With the >>> replacement init.js in nashorn.jar, nashorn will run jrunscript >>> initialization script and we can run existing scripts that use >>> jrunscript's init facilities. We can eventually modify jrunscript's >>> init.js in future. >>> >>> Please review. >>> >>> Thanks >>> -Sundar >>> >>> >> > > From marcus.lagergren at oracle.com Mon Jan 14 06:57:19 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Mon, 14 Jan 2013 15:57:19 +0100 Subject: Review request for JDK-8006168 In-Reply-To: <98BC0BD2-569E-43F3-867C-B7B7B206AC36@oracle.com> References: <98BC0BD2-569E-43F3-867C-B7B7B206AC36@oracle.com> Message-ID: <2826EF70-0078-4FE9-AC19-EE4CDAA4437B@oracle.com> +1 - some nitpicks about inconsistent use of finals . Possibly we need more unit tests but that can be done later. On Jan 14, 2013, at 3:13 PM, Attila Szegedi wrote: > Please review JDK-8006168 at http://cr.openjdk.java.net/~attila/8006168/webrev.00 > > Thanks, > Attila. From attila.szegedi at oracle.com Mon Jan 14 07:01:19 2013 From: attila.szegedi at oracle.com (attila.szegedi at oracle.com) Date: Mon, 14 Jan 2013 15:01:19 +0000 Subject: hg: nashorn/jdk8/nashorn: 8006168: ability to generate multi-type Java adapters Message-ID: <20130114150121.2938B4724A@hg.openjdk.java.net> Changeset: eda69555239a Author: attila Date: 2013-01-14 16:00 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/eda69555239a 8006168: ability to generate multi-type Java adapters Reviewed-by: lagergren, jlaskey ! src/jdk/nashorn/internal/objects/NativeJava.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java ! src/jdk/nashorn/internal/runtime/linker/NashornPrimitiveLinker.java ! src/jdk/nashorn/internal/runtime/resources/Messages.properties ! test/script/sandbox/javaextend.js ! test/script/sandbox/javaextend.js.EXPECTED + test/src/jdk/nashorn/internal/test/models/DessertTopping.java + test/src/jdk/nashorn/internal/test/models/DessertToppingFloorWaxDriver.java + test/src/jdk/nashorn/internal/test/models/FloorWax.java + test/src/jdk/nashorn/internal/test/models/Toothpaste.java From hannes.wallnoefer at oracle.com Mon Jan 14 07:02:54 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Mon, 14 Jan 2013 16:02:54 +0100 Subject: Review request for JDK-8006168 In-Reply-To: <98BC0BD2-569E-43F3-867C-B7B7B206AC36@oracle.com> References: <98BC0BD2-569E-43F3-867C-B7B7B206AC36@oracle.com> Message-ID: <50F41E1E.8060508@oracle.com> +1. Class loader selection is a bit hairy, but I couldn't find any way to make it simpler either - I guess that complexity is necessary. Hannes Am 2013-01-14 15:13, schrieb Attila Szegedi: > Please review JDK-8006168 at http://cr.openjdk.java.net/~attila/8006168/webrev.00 > > Thanks, > Attila. From attila.szegedi at oracle.com Mon Jan 14 07:11:27 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Mon, 14 Jan 2013 16:11:27 +0100 Subject: Review request for JDK-8006168 In-Reply-To: <50F41E1E.8060508@oracle.com> References: <98BC0BD2-569E-43F3-867C-B7B7B206AC36@oracle.com> <50F41E1E.8060508@oracle.com> Message-ID: <21F0F71D-056E-4EF7-AED5-03AEBA2C3070@oracle.com> Yeah; trust me, I had interim code stages where it was even hairier -- this is pretty much reduced :-) Thanks. On Jan 14, 2013, at 4:02 PM, Hannes Wallnoefer wrote: > +1. > > Class loader selection is a bit hairy, but I couldn't find any way to make it simpler either - I guess that complexity is necessary. > > Hannes > > Am 2013-01-14 15:13, schrieb Attila Szegedi: >> Please review JDK-8006168 at http://cr.openjdk.java.net/~attila/8006168/webrev.00 >> >> Thanks, >> Attila. > From sundararajan.athijegannathan at oracle.com Mon Jan 14 07:58:11 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Mon, 14 Jan 2013 15:58:11 +0000 Subject: hg: nashorn/jdk8/nashorn: 8006181: nashorn script engine does not run jrunscript's initialization script Message-ID: <20130114155812.23B794724D@hg.openjdk.java.net> Changeset: 3c6db5ea0ecc Author: sundar Date: 2013-01-14 21:30 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/3c6db5ea0ecc 8006181: nashorn script engine does not run jrunscript's initialization script Reviewed-by: lagergren, jlaskey Contributed-by: rieberandreas at gmail.com + src/jdk/nashorn/api/scripting/Formatter.java ! src/jdk/nashorn/api/scripting/NashornScriptEngine.java ! src/jdk/nashorn/api/scripting/resources/engine.js + src/jdk/nashorn/api/scripting/resources/init.js From sundararajan.athijegannathan at oracle.com Mon Jan 14 08:11:43 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Mon, 14 Jan 2013 21:41:43 +0530 Subject: hg: nashorn/jdk8/nashorn: 8006181: nashorn script engine does not run jrunscript's initialization script In-Reply-To: <20130114155812.23B794724D@hg.openjdk.java.net> References: <20130114155812.23B794724D@hg.openjdk.java.net> Message-ID: <50F42E3F.30301@oracle.com> Hi Andreas, Thanks for your contribution! Looking forward to receive more contributions in future... Thanks -Sundar sundararajan.athijegannathan at oracle.com wrote: > Changeset: 3c6db5ea0ecc > Author: sundar > Date: 2013-01-14 21:30 +0530 > URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/3c6db5ea0ecc > > 8006181: nashorn script engine does not run jrunscript's initialization script > Reviewed-by: lagergren, jlaskey > Contributed-by: rieberandreas at gmail.com > > + src/jdk/nashorn/api/scripting/Formatter.java > ! src/jdk/nashorn/api/scripting/NashornScriptEngine.java > ! src/jdk/nashorn/api/scripting/resources/engine.js > + src/jdk/nashorn/api/scripting/resources/init.js > > From attila.szegedi at oracle.com Tue Jan 15 02:55:02 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Tue, 15 Jan 2013 11:55:02 +0100 Subject: Review request for JDK-8006293 Message-ID: <7FA9A705-F15B-490C-81FD-9E41D629E941@oracle.com> Please review JDK-8006293 at http://cr.openjdk.java.net/~attila/8006293/webrev.00 Thanks, Attila. From james.laskey at oracle.com Tue Jan 15 03:37:06 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Tue, 15 Jan 2013 07:37:06 -0400 Subject: Review request for JDK-8006293 In-Reply-To: <7FA9A705-F15B-490C-81FD-9E41D629E941@oracle.com> References: <7FA9A705-F15B-490C-81FD-9E41D629E941@oracle.com> Message-ID: +1 On 2013-01-15, at 6:55 AM, Attila Szegedi wrote: > Please review JDK-8006293 at http://cr.openjdk.java.net/~attila/8006293/webrev.00 > > Thanks, > Attila. From marcus.lagergren at oracle.com Tue Jan 15 03:41:17 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Tue, 15 Jan 2013 12:41:17 +0100 Subject: Review request for JDK-8006293 In-Reply-To: <7FA9A705-F15B-490C-81FD-9E41D629E941@oracle.com> References: <7FA9A705-F15B-490C-81FD-9E41D629E941@oracle.com> Message-ID: <70D7CC84-0AC4-471B-8184-C7DD213CABA4@oracle.com> +1 On Jan 15, 2013, at 11:55 AM, Attila Szegedi wrote: > Please review JDK-8006293 at http://cr.openjdk.java.net/~attila/8006293/webrev.00 > > Thanks, > Attila. From attila.szegedi at oracle.com Tue Jan 15 04:10:45 2013 From: attila.szegedi at oracle.com (attila.szegedi at oracle.com) Date: Tue, 15 Jan 2013 12:10:45 +0000 Subject: hg: nashorn/jdk8/nashorn: 8006293: Reduce ScriptObject.findCallMethodMethod Message-ID: <20130115121046.AFC764728B@hg.openjdk.java.net> Changeset: 1d0307c2bb4c Author: attila Date: 2013-01-15 13:10 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/1d0307c2bb4c 8006293: Reduce ScriptObject.findCallMethodMethod Reviewed-by: lagergren, jlaskey ! src/jdk/nashorn/internal/runtime/ScriptFunction.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/WithObject.java ! src/jdk/nashorn/internal/runtime/linker/Bootstrap.java ! src/jdk/nashorn/internal/runtime/linker/MethodHandleFactory.java ! src/jdk/nashorn/internal/runtime/linker/MethodHandleFunctionality.java From attila.szegedi at oracle.com Tue Jan 15 08:05:46 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Tue, 15 Jan 2013 17:05:46 +0100 Subject: Review request for JDK-8005958 Message-ID: Please review JDK-8005958 at http://cr.openjdk.java.net/~attila/8005958/webrev.00 Thanks, Attila. From marcus.lagergren at oracle.com Tue Jan 15 08:09:58 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Tue, 15 Jan 2013 17:09:58 +0100 Subject: Review request for JDK-8005958 In-Reply-To: References: Message-ID: <518D8387-0ED6-4367-8086-D61D33CBDD88@oracle.com> +1. There are two hard problems in computer science: naming stuff, cache coherency and off by one errors. On Jan 15, 2013, at 5:05 PM, Attila Szegedi wrote: > Please review JDK-8005958 at http://cr.openjdk.java.net/~attila/8005958/webrev.00 > > Thanks, > Attila. From attila.szegedi at oracle.com Tue Jan 15 08:09:49 2013 From: attila.szegedi at oracle.com (attila.szegedi at oracle.com) Date: Tue, 15 Jan 2013 16:09:49 +0000 Subject: hg: nashorn/jdk8/nashorn: 8005958: invoking a function through INVOKESTATIC with more arguments than it declares resulted in malformed bytecode being generated Message-ID: <20130115160949.D64D74728F@hg.openjdk.java.net> Changeset: ee73d7378e3e Author: attila Date: 2013-01-15 17:09 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/ee73d7378e3e 8005958: invoking a function through INVOKESTATIC with more arguments than it declares resulted in malformed bytecode being generated Reviewed-by: lagergren, jlaskey ! src/jdk/nashorn/internal/codegen/CodeGenerator.java + test/script/basic/JDK-8005958.js From attila.szegedi at oracle.com Tue Jan 15 08:56:02 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Tue, 15 Jan 2013 17:56:02 +0100 Subject: Review request for JDK-8006337 Message-ID: <5B5D8364-EC29-492D-808F-6E0CA8486380@oracle.com> Please review JDK-8006337 at http://cr.openjdk.java.net/~attila/8006337/webrev.00 Thanks, Attila. From attila.szegedi at oracle.com Tue Jan 15 09:08:57 2013 From: attila.szegedi at oracle.com (attila.szegedi at oracle.com) Date: Tue, 15 Jan 2013 17:08:57 +0000 Subject: hg: nashorn/jdk8/nashorn: 8006337: Discarded arguments for INVOKESTATIC must still be evaluated for side effects Message-ID: <20130115170858.BA25547293@hg.openjdk.java.net> Changeset: 9088170e68df Author: attila Date: 2013-01-15 18:08 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/9088170e68df 8006337: Discarded arguments for INVOKESTATIC must still be evaluated for side effects Reviewed-by: hannesw, jlaskey, sundar ! src/jdk/nashorn/internal/codegen/CodeGenerator.java + test/script/basic/JDK-8006337.js + test/script/basic/JDK-8006337.js.EXPECTED From hannes.wallnoefer at oracle.com Tue Jan 15 09:17:41 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Tue, 15 Jan 2013 18:17:41 +0100 Subject: Review request for JDK-8006337 In-Reply-To: <5B5D8364-EC29-492D-808F-6E0CA8486380@oracle.com> References: <5B5D8364-EC29-492D-808F-6E0CA8486380@oracle.com> Message-ID: <50F58F35.1000001@oracle.com> +1 Am 2013-01-15 17:56, schrieb Attila Szegedi: > Please review JDK-8006337 at http://cr.openjdk.java.net/~attila/8006337/webrev.00 > > Thanks, > Attila. From james.laskey at oracle.com Tue Jan 15 09:26:13 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Tue, 15 Jan 2013 13:26:13 -0400 Subject: Review request for JDK-8006337 In-Reply-To: <5B5D8364-EC29-492D-808F-6E0CA8486380@oracle.com> References: <5B5D8364-EC29-492D-808F-6E0CA8486380@oracle.com> Message-ID: <95436FD7-D715-4F98-B814-7EE89865025C@oracle.com> +1 On 2013-01-15, at 12:56 PM, Attila Szegedi wrote: > Please review JDK-8006337 at http://cr.openjdk.java.net/~attila/8006337/webrev.00 > > Thanks, > Attila. From james.laskey at oracle.com Tue Jan 15 13:31:20 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Tue, 15 Jan 2013 17:31:20 -0400 Subject: Review Request for JDK-8006304 Message-ID: - CodeGenerator.java is marked TODO because the real fix requires major surgery that will come with further property map work. This interim fix should address several pending bugs related to premature constructor properties. - Plus two unrelated items found along the way, missing eoln on .hgignore and misspelling in FunctionObjectCreator.java . http://cr.openjdk.java.net/~jlaskey/8006304/webrev/index.html From sundararajan.athijegannathan at oracle.com Tue Jan 15 20:04:13 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Wed, 16 Jan 2013 09:34:13 +0530 Subject: Review Request for JDK-8006304 In-Reply-To: References: Message-ID: <50F626BD.6060501@oracle.com> +1 PS. There were other variants of the conditional constructor path tests - I recall at least 3 bugs. Do we want to add few variants to test ? -Sundar Jim Laskey (Oracle) wrote: > - CodeGenerator.java is marked TODO because the real fix requires major surgery that will come with further property map work. This interim fix should address several pending bugs related to premature constructor properties. > > - Plus two unrelated items found along the way, missing eoln on .hgignore and misspelling in FunctionObjectCreator.java . > > http://cr.openjdk.java.net/~jlaskey/8006304/webrev/index.html > > From sundararajan.athijegannathan at oracle.com Tue Jan 15 20:07:46 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Wed, 16 Jan 2013 09:37:46 +0530 Subject: Review request for JDK-8006337 In-Reply-To: <5B5D8364-EC29-492D-808F-6E0CA8486380@oracle.com> References: <5B5D8364-EC29-492D-808F-6E0CA8486380@oracle.com> Message-ID: <50F62792.5080000@oracle.com> +1 Attila Szegedi wrote: > Please review JDK-8006337 at http://cr.openjdk.java.net/~attila/8006337/webrev.00 > > Thanks, > Attila. From marcus.lagergren at oracle.com Tue Jan 15 22:23:09 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Wed, 16 Jan 2013 07:23:09 +0100 Subject: Review Request for JDK-8006304 In-Reply-To: <50F626BD.6060501@oracle.com> References: <50F626BD.6060501@oracle.com> Message-ID: <61A88491-D509-4EA0-A08B-96B610BE8739@oracle.com> More parts of the TODO fix? Perhaps get rid of the FunctionNode.thisProperties collection altogether? I agree with what sundar Says to add unit tests for all varieties of this bug if possible. Regarding the one Hannes filed yesterday with env.js & query: I'm not sure what the status of env.js is but jquery is approved for inclusion in the external test suite. Otherwise +1 On Jan 16, 2013, at 5:04 AM, A. Sundararajan wrote: > +1 > > PS. There were other variants of the conditional constructor path tests - I recall at least 3 bugs. Do we want to add few variants to test ? > > -Sundar > > Jim Laskey (Oracle) wrote: >> - CodeGenerator.java is marked TODO because the real fix requires major surgery that will come with further property map work. This interim fix should address several pending bugs related to premature constructor properties. >> >> - Plus two unrelated items found along the way, missing eoln on .hgignore and misspelling in FunctionObjectCreator.java . >> >> http://cr.openjdk.java.net/~jlaskey/8006304/webrev/index.html >> >> > From marcus.lagergren at oracle.com Tue Jan 15 22:40:17 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Wed, 16 Jan 2013 07:40:17 +0100 Subject: Review Request for JDK-8006304 In-Reply-To: <61A88491-D509-4EA0-A08B-96B610BE8739@oracle.com> References: <50F626BD.6060501@oracle.com> <61A88491-D509-4EA0-A08B-96B610BE8739@oracle.com> Message-ID: Especially http://kenai.com/jira/browse/NASHORN-410 and http://kenai.com/jira/browse/NASHORN-501 in their original bug-producing form would be nice to have as unit tests. Both repros are attached to respective CRs. On Jan 16, 2013, at 7:23 AM, Marcus Lagergren wrote: > More parts of the TODO fix? Perhaps get rid of the FunctionNode.thisProperties collection altogether? > > I agree with what sundar Says to add unit tests for all varieties of this bug if possible. Regarding the one Hannes filed yesterday with env.js & query: I'm not sure what the status of env.js is but jquery is approved for inclusion in the external test suite. > > Otherwise +1 > > On Jan 16, 2013, at 5:04 AM, A. Sundararajan wrote: > >> +1 >> >> PS. There were other variants of the conditional constructor path tests - I recall at least 3 bugs. Do we want to add few variants to test ? >> >> -Sundar >> >> Jim Laskey (Oracle) wrote: >>> - CodeGenerator.java is marked TODO because the real fix requires major surgery that will come with further property map work. This interim fix should address several pending bugs related to premature constructor properties. >>> >>> - Plus two unrelated items found along the way, missing eoln on .hgignore and misspelling in FunctionObjectCreator.java . >>> >>> http://cr.openjdk.java.net/~jlaskey/8006304/webrev/index.html >>> >>> >> > From james.laskey at oracle.com Wed Jan 16 03:04:16 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Wed, 16 Jan 2013 07:04:16 -0400 Subject: Review Request for JDK-8006304 In-Reply-To: <50F626BD.6060501@oracle.com> References: <50F626BD.6060501@oracle.com> Message-ID: Yes. On 2013-01-16, at 12:04 AM, A. Sundararajan wrote: > +1 > > PS. There were other variants of the conditional constructor path tests - I recall at least 3 bugs. Do we want to add few variants to test ? > > -Sundar > > Jim Laskey (Oracle) wrote: >> - CodeGenerator.java is marked TODO because the real fix requires major surgery that will come with further property map work. This interim fix should address several pending bugs related to premature constructor properties. >> >> - Plus two unrelated items found along the way, missing eoln on .hgignore and misspelling in FunctionObjectCreator.java . >> >> http://cr.openjdk.java.net/~jlaskey/8006304/webrev/index.html >> >> > From james.laskey at oracle.com Wed Jan 16 03:06:10 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Wed, 16 Jan 2013 07:06:10 -0400 Subject: Review Request for JDK-8006304 In-Reply-To: <61A88491-D509-4EA0-A08B-96B610BE8739@oracle.com> References: <50F626BD.6060501@oracle.com> <61A88491-D509-4EA0-A08B-96B610BE8739@oracle.com> Message-ID: <55340CBE-2673-4258-B7E3-1356607B7021@oracle.com> Indirectly but yes. On 2013-01-16, at 2:23 AM, Marcus Lagergren wrote: > More parts of the TODO fix? Perhaps get rid of the FunctionNode.thisProperties collection altogether? > > I agree with what sundar Says to add unit tests for all varieties of this bug if possible. Regarding the one Hannes filed yesterday with env.js & query: I'm not sure what the status of env.js is but jquery is approved for inclusion in the external test suite. > > Otherwise +1 > > On Jan 16, 2013, at 5:04 AM, A. Sundararajan wrote: > >> +1 >> >> PS. There were other variants of the conditional constructor path tests - I recall at least 3 bugs. Do we want to add few variants to test ? >> >> -Sundar >> >> Jim Laskey (Oracle) wrote: >>> - CodeGenerator.java is marked TODO because the real fix requires major surgery that will come with further property map work. This interim fix should address several pending bugs related to premature constructor properties. >>> >>> - Plus two unrelated items found along the way, missing eoln on .hgignore and misspelling in FunctionObjectCreator.java . >>> >>> http://cr.openjdk.java.net/~jlaskey/8006304/webrev/index.html >>> >>> >> > From james.laskey at oracle.com Wed Jan 16 03:09:27 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Wed, 16 Jan 2013 11:09:27 +0000 Subject: hg: nashorn/jdk8/nashorn: 8006304: Remove pre-population of maps for constructor produced maps Message-ID: <20130116110928.55221472D8@hg.openjdk.java.net> Changeset: 617313881c55 Author: jlaskey Date: 2013-01-16 07:06 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/617313881c55 8006304: Remove pre-population of maps for constructor produced maps Reviewed-by: sundar Contributed-by: james.laskey at oracle.com ! .hgignore ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/objects/FunctionObjectCreator.java + test/script/basic/JDK-8006304.js + test/script/basic/JDK-8006304.js.EXPECTED From sundararajan.athijegannathan at oracle.com Wed Jan 16 04:17:45 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Wed, 16 Jan 2013 17:47:45 +0530 Subject: Review request JDK-8006412 : Improve toString method of ScriptObjectMirror class Message-ID: <50F69A69.6010608@oracle.com> Hi, Please review http://cr.openjdk.java.net/~sundar/8006412 Thanks, -Sundar From james.laskey at oracle.com Wed Jan 16 04:19:46 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Wed, 16 Jan 2013 08:19:46 -0400 Subject: Review request JDK-8006412 : Improve toString method of ScriptObjectMirror class In-Reply-To: <50F69A69.6010608@oracle.com> References: <50F69A69.6010608@oracle.com> Message-ID: <16F4F3AF-5F6B-41FD-84C8-73C3D58575AF@oracle.com> +1 On 2013-01-16, at 8:17 AM, "A. Sundararajan" wrote: > Hi, > > Please review http://cr.openjdk.java.net/~sundar/8006412 > > Thanks, > -Sundar From marcus.lagergren at oracle.com Wed Jan 16 04:22:07 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Wed, 16 Jan 2013 13:22:07 +0100 Subject: Review request JDK-8006412 : Improve toString method of ScriptObjectMirror class In-Reply-To: <50F69A69.6010608@oracle.com> References: <50F69A69.6010608@oracle.com> Message-ID: <75ACA508-D3DF-4ECB-950F-0F93EBDC94AA@oracle.com> Looks good. On Jan 16, 2013, at 1:17 PM, "A. Sundararajan" wrote: > Hi, > > Please review http://cr.openjdk.java.net/~sundar/8006412 > > Thanks, > -Sundar From sundararajan.athijegannathan at oracle.com Wed Jan 16 04:25:02 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Wed, 16 Jan 2013 12:25:02 +0000 Subject: hg: nashorn/jdk8/nashorn: 8006412: Improve toString method of ScriptObjectMirror class Message-ID: <20130116122503.7FA21472DE@hg.openjdk.java.net> Changeset: 80447df16322 Author: sundar Date: 2013-01-16 17:58 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/80447df16322 8006412: Improve toString method of ScriptObjectMirror class Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java ! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java From attila.szegedi at oracle.com Wed Jan 16 04:52:51 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Wed, 16 Jan 2013 13:52:51 +0100 Subject: Review request JDK-8006412 : Improve toString method of ScriptObjectMirror class In-Reply-To: <50F69A69.6010608@oracle.com> References: <50F69A69.6010608@oracle.com> Message-ID: +1 On Jan 16, 2013, at 1:17 PM, "A. Sundararajan" wrote: > Hi, > > Please review http://cr.openjdk.java.net/~sundar/8006412 > > Thanks, > -Sundar From sundararajan.athijegannathan at oracle.com Wed Jan 16 07:19:27 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Wed, 16 Jan 2013 20:49:27 +0530 Subject: Review request JDK-8006424 : Passing null or undefined to adapter class constructors results in NPE or ClassCastException Message-ID: <50F6C4FF.304@oracle.com> Hi, Please review http://cr.openjdk.java.net/~sundar/8006424/ Thanks -Sundar From attila.szegedi at oracle.com Wed Jan 16 07:23:47 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Wed, 16 Jan 2013 16:23:47 +0100 Subject: Review request JDK-8006424 : Passing null or undefined to adapter class constructors results in NPE or ClassCastException In-Reply-To: <50F6C4FF.304@oracle.com> References: <50F6C4FF.304@oracle.com> Message-ID: <6D3DDC9E-52AC-46F7-9474-A7F3B39475A8@oracle.com> +1 On Jan 16, 2013, at 4:19 PM, "A. Sundararajan" wrote: > Hi, > > Please review http://cr.openjdk.java.net/~sundar/8006424/ > > Thanks > -Sundar From seth at tisue.net Wed Jan 16 07:29:51 2013 From: seth at tisue.net (Seth Tisue) Date: Wed, 16 Jan 2013 10:29:51 -0500 Subject: Are the JIRA tickets supposed to be public? Message-ID: <47069.1358350191@sethp.local> ....now that Nashorn is open source? I made myself an account on Project Kenai, but I'm still unable to see the tickets being discussed on this list, for example . I get "PERMISSION VIOLATION: ERROR: It seems that you have tried to perform an operation which you are not permitted to perform." -- Seth Tisue | Northwestern University | http://tisue.net developer, NetLogo: http://ccl.northwestern.edu/netlogo/ From hannes.wallnoefer at oracle.com Wed Jan 16 07:30:41 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Wed, 16 Jan 2013 16:30:41 +0100 Subject: Review request JDK-8006424 : Passing null or undefined to adapter class constructors results in NPE or ClassCastException In-Reply-To: <50F6C4FF.304@oracle.com> References: <50F6C4FF.304@oracle.com> Message-ID: <50F6C7A1.8010604@oracle.com> +1 Am 2013-01-16 16:19, schrieb A. Sundararajan: > Hi, > > Please review http://cr.openjdk.java.net/~sundar/8006424/ > > Thanks > -Sundar From james.laskey at oracle.com Wed Jan 16 07:35:37 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Wed, 16 Jan 2013 11:35:37 -0400 Subject: Review request JDK-8006424 : Passing null or undefined to adapter class constructors results in NPE or ClassCastException In-Reply-To: <50F6C4FF.304@oracle.com> References: <50F6C4FF.304@oracle.com> Message-ID: <15C6D7CD-B845-4A16-BE4F-7CC016B2ADDF@oracle.com> +1 On 2013-01-16, at 11:19 AM, A. Sundararajan wrote: > Hi, > > Please review http://cr.openjdk.java.net/~sundar/8006424/ > > Thanks > -Sundar From pavel.stepanov at oracle.com Wed Jan 16 07:48:49 2013 From: pavel.stepanov at oracle.com (Pavel A. Stepanoff) Date: Wed, 16 Jan 2013 19:48:49 +0400 Subject: Testing In-Reply-To: References: Message-ID: <50F6CBE1.8040301@oracle.com> Hello Eugene, please update all necessary scripts Pavel On 09.01.2013 9:45, Marcus Lagergren wrote: > Hi guys! > > Just wanted to check that testing is moving to the open jdk repo, as we will not be checking anything else into the kenai one. Is this already automated, or are the nightly testing mails results of running on the Kenai repo? > > /M > From sundararajan.athijegannathan at oracle.com Wed Jan 16 07:53:07 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Wed, 16 Jan 2013 15:53:07 +0000 Subject: hg: nashorn/jdk8/nashorn: 8006424: Passing null or undefined to adapter class constructors results in NPE or ClassCastException Message-ID: <20130116155310.238E9472EA@hg.openjdk.java.net> Changeset: cd5b684ce7b2 Author: sundar Date: 2013-01-16 21:26 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/cd5b684ce7b2 8006424: Passing null or undefined to adapter class constructors results in NPE or ClassCastException Reviewed-by: attila, hannesw, jlaskey ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java + test/script/basic/JDK-8006424.js From james.laskey at oracle.com Wed Jan 16 08:05:37 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Wed, 16 Jan 2013 12:05:37 -0400 Subject: Are the JIRA tickets supposed to be public? In-Reply-To: <47069.1358350191@sethp.local> References: <47069.1358350191@sethp.local> Message-ID: Currently, no. We're in the process of migrating to a new bug system, which is not currently public (but we're working hard to make it so.) The JIRA on Kenai (old repo) is frozen, so we can migrate a non-moving target. Unfortunately, that also locks out public viewing. Over time we will be excising references to the old JIRA and relink to the new. Cheers, -- Jim On 2013-01-16, at 11:29 AM, Seth Tisue wrote: > > ....now that Nashorn is open source? > > I made myself an account on Project Kenai, but I'm still unable to see > the tickets being discussed on this list, for example > . I get "PERMISSION > VIOLATION: ERROR: It seems that you have tried to perform an operation > which you are not permitted to perform." > > -- > Seth Tisue | Northwestern University | http://tisue.net > developer, NetLogo: http://ccl.northwestern.edu/netlogo/ From seth at tisue.net Wed Jan 16 12:02:33 2013 From: seth at tisue.net (Seth Tisue) Date: Wed, 16 Jan 2013 15:02:33 -0500 Subject: Are the JIRA tickets supposed to be public? In-Reply-To: References: <47069.1358350191@sethp.local> Message-ID: On Wed, Jan 16, 2013 at 11:05 AM, Jim Laskey (Oracle) wrote: > We're in the process of migrating to a new bug system, which is not currently public (but we're working hard to make it so.) Cool. Thanks. -- Seth Tisue | Northwestern University | http://tisue.net developer, NetLogo: http://ccl.northwestern.edu/netlogo/ From mark.reinhold at oracle.com Wed Jan 16 12:57:25 2013 From: mark.reinhold at oracle.com (mark.reinhold at oracle.com) Date: Wed, 16 Jan 2013 12:57:25 -0800 (PST) Subject: JEP 174: Nashorn JavaScript Engine Message-ID: <20130116205725.021AF61D@eggemoggin.niobe.net> Posted: http://openjdk.java.net/jeps/174 - Mark From james.laskey at oracle.com Thu Jan 17 06:04:40 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Thu, 17 Jan 2013 10:04:40 -0400 Subject: Review Request for JDK-8006304 Message-ID: <8A7819B1-A02E-4C7D-94ED-83936650EE33@oracle.com> - CodeGenerator.java is marked TODO because the real fix requires major surgery that will come with further property map work. This interim fix should address several pending bugs related to premature constructor properties. - Plus two unrelated items found along the way, missing eoln on .hgignore and misspelling in FunctionObjectCreator.java . http://cr.openjdk.java.net/~jlaskey/8006304/webrev/index.html From marcus.lagergren at oracle.com Thu Jan 17 06:29:25 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Thu, 17 Jan 2013 15:29:25 +0100 Subject: Review Request for JDK-8006304 In-Reply-To: <8A7819B1-A02E-4C7D-94ED-83936650EE33@oracle.com> References: <8A7819B1-A02E-4C7D-94ED-83936650EE33@oracle.com> Message-ID: <8AD65D82-4B0A-4B38-92F6-D0443DDD0E17@oracle.com> I thought we reviewed this already? I'd like unit tests for the issues reported in Kenai to be added. NASHORN-410 NASHORN-501 Aside from that good to go. On Jan 17, 2013, at 3:04 PM, Jim Laskey (Oracle) wrote: > - CodeGenerator.java is marked TODO because the real fix requires major surgery that will come with further property map work. This interim fix should address several pending bugs related to premature constructor properties. > > - Plus two unrelated items found along the way, missing eoln on .hgignore and misspelling in FunctionObjectCreator.java . > > http://cr.openjdk.java.net/~jlaskey/8006304/webrev/index.html > From james.laskey at oracle.com Thu Jan 17 06:36:35 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Thu, 17 Jan 2013 10:36:35 -0400 Subject: Review Request for JDK-8006304 In-Reply-To: <8AD65D82-4B0A-4B38-92F6-D0443DDD0E17@oracle.com> References: <8A7819B1-A02E-4C7D-94ED-83936650EE33@oracle.com> <8AD65D82-4B0A-4B38-92F6-D0443DDD0E17@oracle.com> Message-ID: <0A69279B-94F3-467D-8248-9506F6343CD5@oracle.com> Appears to be a very long delay. "Jan 17, 2013, at 3:04 PM" I'll open a new bug for the tests. On 2013-01-17, at 10:29 AM, Marcus Lagergren wrote: > I thought we reviewed this already? I'd like unit tests for the issues reported in Kenai to be added. > > NASHORN-410 > NASHORN-501 > > Aside from that good to go. > > On Jan 17, 2013, at 3:04 PM, Jim Laskey (Oracle) wrote: > >> - CodeGenerator.java is marked TODO because the real fix requires major surgery that will come with further property map work. This interim fix should address several pending bugs related to premature constructor properties. >> >> - Plus two unrelated items found along the way, missing eoln on .hgignore and misspelling in FunctionObjectCreator.java . >> >> http://cr.openjdk.java.net/~jlaskey/8006304/webrev/index.html >> > From james.laskey at oracle.com Thu Jan 17 06:50:02 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Thu, 17 Jan 2013 14:50:02 +0000 Subject: hg: nashorn/jdk8/nashorn: 8006517: PropertyHashMap.Element.equals() compares to Property Message-ID: <20130117145006.1E34E47367@hg.openjdk.java.net> Changeset: 4acebfe9e504 Author: jlaskey Date: 2013-01-17 10:33 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/4acebfe9e504 8006517: PropertyHashMap.Element.equals() compares to Property Reviewed-by: sundar Contributed-by: james.laskey at oracle.com ! src/jdk/nashorn/internal/runtime/PropertyHashMap.java From sundararajan.athijegannathan at oracle.com Thu Jan 17 08:52:13 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Thu, 17 Jan 2013 22:22:13 +0530 Subject: Review request JDK-8006527 : nashorn jsr223 engine does not work in sandbox Message-ID: <50F82C3D.3040600@oracle.com> Hi, Please review http://cr.openjdk.java.net/~sundar/8006527/ Thanks -Sundar From james.laskey at oracle.com Thu Jan 17 09:00:08 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Thu, 17 Jan 2013 13:00:08 -0400 Subject: Review request JDK-8006527 : nashorn jsr223 engine does not work in sandbox In-Reply-To: <50F82C3D.3040600@oracle.com> References: <50F82C3D.3040600@oracle.com> Message-ID: <9DE1C6FB-E9DB-40B8-A554-FBE865CB53C9@oracle.com> +1 On 2013-01-17, at 12:52 PM, "A. Sundararajan" wrote: > Hi, > > Please review http://cr.openjdk.java.net/~sundar/8006527/ > > Thanks > -Sundar From sundararajan.athijegannathan at oracle.com Thu Jan 17 09:12:31 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Thu, 17 Jan 2013 22:42:31 +0530 Subject: Review request JDK-8006527 : nashorn jsr223 engine does not work in sandbox In-Reply-To: <9DE1C6FB-E9DB-40B8-A554-FBE865CB53C9@oracle.com> References: <50F82C3D.3040600@oracle.com> <9DE1C6FB-E9DB-40B8-A554-FBE865CB53C9@oracle.com> Message-ID: <50F830FF.70803@oracle.com> Hi, Fixed missing copyrights in new scripts (engine.js and jsadapter.js). Please review the updated webrev http://cr.openjdk.java.net/~sundar/8006527/webrev.01/ Thanks -Sundar On Thursday 17 January 2013 10:30 PM, Jim Laskey (Oracle) wrote: > +1 > > On 2013-01-17, at 12:52 PM, "A. Sundararajan" wrote: > >> Hi, >> >> Please review http://cr.openjdk.java.net/~sundar/8006527/ >> >> Thanks >> -Sundar From attila.szegedi at oracle.com Thu Jan 17 09:25:32 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Thu, 17 Jan 2013 18:25:32 +0100 Subject: Review request JDK-8006527 : nashorn jsr223 engine does not work in sandbox In-Reply-To: <50F830FF.70803@oracle.com> References: <50F82C3D.3040600@oracle.com> <9DE1C6FB-E9DB-40B8-A554-FBE865CB53C9@oracle.com> <50F830FF.70803@oracle.com> Message-ID: <43390A29-F15E-4011-9FF2-0C10FF61DF4D@oracle.com> Looks good to me. One thing that I noticed is that we aren't closing the stream in evalSupportScript. I suspect it's mostly moot as it comes from the .jar file, and will get GC'd anyway soon. It was there before, so it's not an argument against your patch, just something that you maybe can still sneak into this issue. If not, doesn't matter. On Jan 17, 2013, at 6:12 PM, "A. Sundararajan" wrote: > Hi, > > Fixed missing copyrights in new scripts (engine.js and jsadapter.js). Please review the updated webrev > > http://cr.openjdk.java.net/~sundar/8006527/webrev.01/ > > Thanks > -Sundar > > On Thursday 17 January 2013 10:30 PM, Jim Laskey (Oracle) wrote: >> +1 >> >> On 2013-01-17, at 12:52 PM, "A. Sundararajan" wrote: >> >>> Hi, >>> >>> Please review http://cr.openjdk.java.net/~sundar/8006527/ >>> >>> Thanks >>> -Sundar > From marcus.lagergren at oracle.com Thu Jan 17 10:12:23 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Thu, 17 Jan 2013 19:12:23 +0100 Subject: Review request JDK-8006527 : nashorn jsr223 engine does not work in sandbox In-Reply-To: <43390A29-F15E-4011-9FF2-0C10FF61DF4D@oracle.com> References: <50F82C3D.3040600@oracle.com> <9DE1C6FB-E9DB-40B8-A554-FBE865CB53C9@oracle.com> <50F830FF.70803@oracle.com> <43390A29-F15E-4011-9FF2-0C10FF61DF4D@oracle.com> Message-ID: <984C401A-FE53-4BC2-AF76-24979AFB6599@oracle.com> +1 On Jan 17, 2013, at 6:25 PM, Attila Szegedi wrote: > Looks good to me. > > One thing that I noticed is that we aren't closing the stream in evalSupportScript. I suspect it's mostly moot as it comes from the .jar file, and will get GC'd anyway soon. It was there before, so it's not an argument against your patch, just something that you maybe can still sneak into this issue. If not, doesn't matter. > > On Jan 17, 2013, at 6:12 PM, "A. Sundararajan" wrote: > >> Hi, >> >> Fixed missing copyrights in new scripts (engine.js and jsadapter.js). Please review the updated webrev >> >> http://cr.openjdk.java.net/~sundar/8006527/webrev.01/ >> >> Thanks >> -Sundar >> >> On Thursday 17 January 2013 10:30 PM, Jim Laskey (Oracle) wrote: >>> +1 >>> >>> On 2013-01-17, at 12:52 PM, "A. Sundararajan" wrote: >>> >>>> Hi, >>>> >>>> Please review http://cr.openjdk.java.net/~sundar/8006527/ >>>> >>>> Thanks >>>> -Sundar >> > From sundararajan.athijegannathan at oracle.com Thu Jan 17 19:13:42 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Fri, 18 Jan 2013 08:43:42 +0530 Subject: Review request JDK-8006527 : nashorn jsr223 engine does not work in sandbox In-Reply-To: <43390A29-F15E-4011-9FF2-0C10FF61DF4D@oracle.com> References: <50F82C3D.3040600@oracle.com> <9DE1C6FB-E9DB-40B8-A554-FBE865CB53C9@oracle.com> <50F830FF.70803@oracle.com> <43390A29-F15E-4011-9FF2-0C10FF61DF4D@oracle.com> Message-ID: <50F8BDE6.5010107@oracle.com> Yes, stream from jar should not be an issue. But, I'll revisit this code pattern in a later change in this area. Thanks -Sundar On Thursday 17 January 2013 10:55 PM, Attila Szegedi wrote: > Looks good to me. > > One thing that I noticed is that we aren't closing the stream in evalSupportScript. I suspect it's mostly moot as it comes from the .jar file, and will get GC'd anyway soon. It was there before, so it's not an argument against your patch, just something that you maybe can still sneak into this issue. If not, doesn't matter. > > On Jan 17, 2013, at 6:12 PM, "A. Sundararajan" wrote: > >> Hi, >> >> Fixed missing copyrights in new scripts (engine.js and jsadapter.js). Please review the updated webrev >> >> http://cr.openjdk.java.net/~sundar/8006527/webrev.01/ >> >> Thanks >> -Sundar >> >> On Thursday 17 January 2013 10:30 PM, Jim Laskey (Oracle) wrote: >>> +1 >>> >>> On 2013-01-17, at 12:52 PM, "A. Sundararajan" wrote: >>> >>>> Hi, >>>> >>>> Please review http://cr.openjdk.java.net/~sundar/8006527/ >>>> >>>> Thanks >>>> -Sundar From sundararajan.athijegannathan at oracle.com Thu Jan 17 19:18:01 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Fri, 18 Jan 2013 03:18:01 +0000 Subject: hg: nashorn/jdk8/nashorn: 8006527: nashorn jsr223 engine does not work in sandbox Message-ID: <20130118031802.E82B24739F@hg.openjdk.java.net> Changeset: f8136c060914 Author: sundar Date: 2013-01-18 08:45 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/f8136c060914 8006527: nashorn jsr223 engine does not work in sandbox Reviewed-by: jlaskey, attila, lagergren + bin/nashornsecure + bin/nashornsecure.bat ! src/jdk/nashorn/api/scripting/NashornScriptEngine.java ! src/jdk/nashorn/api/scripting/resources/init.js ! src/jdk/nashorn/internal/objects/NativeJSAdapter.java + test/script/sandbox/engine.js + test/script/sandbox/engine.js.EXPECTED + test/script/sandbox/jsadapter.js From sundararajan.athijegannathan at oracle.com Fri Jan 18 04:14:42 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Fri, 18 Jan 2013 17:44:42 +0530 Subject: Review request JDK-8006562: findOwnMH in nashorn "objects" package should be cleaned up Message-ID: <50F93CB2.5000907@oracle.com> Hi, Please review JDK-8006562: findOwnMH in nashorn "objects" package should be cleaned up Thanks -Sundar From james.laskey at oracle.com Fri Jan 18 04:17:29 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Fri, 18 Jan 2013 08:17:29 -0400 Subject: Review request JDK-8006562: findOwnMH in nashorn "objects" package should be cleaned up In-Reply-To: <50F93CB2.5000907@oracle.com> References: <50F93CB2.5000907@oracle.com> Message-ID: <1A06BDFD-A5BF-40CA-8052-887E33F168E2@oracle.com> +1 On 2013-01-18, at 8:14 AM, "A. Sundararajan" wrote: > Hi, > > Please review JDK-8006562: findOwnMH in nashorn "objects" package should be cleaned up > > Thanks > -Sundar From sundararajan.athijegannathan at oracle.com Fri Jan 18 04:17:29 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Fri, 18 Jan 2013 17:47:29 +0530 Subject: Review request JDK-8006562: findOwnMH in nashorn "objects" package should be cleaned up In-Reply-To: <50F93CB2.5000907@oracle.com> References: <50F93CB2.5000907@oracle.com> Message-ID: <50F93D59.8080700@oracle.com> Sorry missed the link: http://cr.openjdk.java.net/~sundar/8006562/ -Sundar On Friday 18 January 2013 05:44 PM, A. Sundararajan wrote: > Hi, > > Please review JDK-8006562: findOwnMH in nashorn "objects" package > should be cleaned up > > Thanks > -Sundar From marcus.lagergren at oracle.com Fri Jan 18 04:20:57 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Fri, 18 Jan 2013 13:20:57 +0100 Subject: Review request JDK-8006562: findOwnMH in nashorn "objects" package should be cleaned up In-Reply-To: <50F93CB2.5000907@oracle.com> References: <50F93CB2.5000907@oracle.com> Message-ID: +1 after explanations about public scope of MethodHandle lookup by Sundar. On Jan 18, 2013, at 1:14 PM, A. Sundararajan wrote: > Hi, > > Please review JDK-8006562: findOwnMH in nashorn "objects" package should be cleaned up > > Thanks > -Sundar From sundararajan.athijegannathan at oracle.com Fri Jan 18 04:23:30 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Fri, 18 Jan 2013 17:53:30 +0530 Subject: Review request JDK-8006562: findOwnMH in nashorn "objects" package should be cleaned up In-Reply-To: References: <50F93CB2.5000907@oracle.com> Message-ID: <50F93EC2.6060007@oracle.com> MethodHandles.lookup() to resolve 'private' methods of caller can not be passed across class loaders. "objects" package classes are loaded by a different loader and so MethodHandleFactory (runtime) class can not make use of "own" lookups and resolve private methods as method handles. So to create method handles of public methods, we use MH and publicLookup. We use direct jsr292 API call to create method handles on private methods. -Sundar On Friday 18 January 2013 05:50 PM, Marcus Lagergren wrote: > +1 after explanations about public scope of MethodHandle lookup by Sundar. > > On Jan 18, 2013, at 1:14 PM, A. Sundararajan wrote: > >> Hi, >> >> Please review JDK-8006562: findOwnMH in nashorn "objects" package should be cleaned up >> >> Thanks >> -Sundar From sundararajan.athijegannathan at oracle.com Fri Jan 18 04:25:21 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Fri, 18 Jan 2013 12:25:21 +0000 Subject: hg: nashorn/jdk8/nashorn: 8006562: findOwnMH in nashorn "objects" package should be cleaned up Message-ID: <20130118122522.91397473B4@hg.openjdk.java.net> Changeset: 4361e8cd6a02 Author: sundar Date: 2013-01-18 17:55 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/4361e8cd6a02 8006562: findOwnMH in nashorn "objects" package should be cleaned up Reviewed-by: jlaskey, lagergren ! make/project.properties ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/objects/NativeArguments.java ! src/jdk/nashorn/internal/objects/NativeBoolean.java ! src/jdk/nashorn/internal/objects/NativeError.java ! src/jdk/nashorn/internal/objects/NativeJSAdapter.java ! src/jdk/nashorn/internal/objects/NativeNumber.java ! src/jdk/nashorn/internal/objects/NativeStrictArguments.java ! src/jdk/nashorn/internal/objects/NativeString.java ! src/jdk/nashorn/internal/objects/PrototypeObject.java ! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java From james.laskey at oracle.com Fri Jan 18 04:38:14 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Fri, 18 Jan 2013 08:38:14 -0400 Subject: Are the JIRA tickets supposed to be public? In-Reply-To: References: <47069.1358350191@sethp.local> Message-ID: <3E555259-F806-4C73-9E5D-F5B375151D36@oracle.com> I've just been informed that bugs are copied to a public proxy daily via bugs.sun.com. Ex. http://bugs.sun.com/view_bug.do?bug_id=8005782 Cheers, -- Jim On 2013-01-16, at 4:02 PM, Seth Tisue wrote: > On Wed, Jan 16, 2013 at 11:05 AM, Jim Laskey (Oracle) > wrote: >> We're in the process of migrating to a new bug system, which is not currently public (but we're working hard to make it so.) > > Cool. Thanks. > > -- > Seth Tisue | Northwestern University | http://tisue.net > developer, NetLogo: http://ccl.northwestern.edu/netlogo/ From sundararajan.athijegannathan at oracle.com Fri Jan 18 08:53:09 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Fri, 18 Jan 2013 22:23:09 +0530 Subject: Review request JDK-8006584 : improve variable handling in NashfornScriptEngine Message-ID: <50F97DF5.5040803@oracle.com> Hi, Please review http://cr.openjdk.java.net/~sundar/8006584/ Thanks -Sundar From james.laskey at oracle.com Fri Jan 18 09:10:30 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Fri, 18 Jan 2013 13:10:30 -0400 Subject: Review request JDK-8006584 : improve variable handling in NashfornScriptEngine In-Reply-To: <50F97DF5.5040803@oracle.com> References: <50F97DF5.5040803@oracle.com> Message-ID: +1 On 2013-01-18, at 12:53 PM, A. Sundararajan wrote: > Hi, > > Please review http://cr.openjdk.java.net/~sundar/8006584/ > > Thanks > -Sundar From hannes.wallnoefer at oracle.com Fri Jan 18 09:52:04 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Fri, 18 Jan 2013 18:52:04 +0100 Subject: Review request JDK-8006584 : improve variable handling in NashfornScriptEngine In-Reply-To: <50F97DF5.5040803@oracle.com> References: <50F97DF5.5040803@oracle.com> Message-ID: <50F98BC4.5020602@oracle.com> Looks good to me. Hannes Am 2013-01-18 17:53, schrieb A. Sundararajan: > Hi, > > Please review http://cr.openjdk.java.net/~sundar/8006584/ > > Thanks > -Sundar From sundararajan.athijegannathan at oracle.com Fri Jan 18 19:45:12 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Sat, 19 Jan 2013 03:45:12 +0000 Subject: hg: nashorn/jdk8/nashorn: 8006584: improve variable handling in NashornScriptEngine Message-ID: <20130119034515.369BF473EC@hg.openjdk.java.net> Changeset: c887baec012a Author: sundar Date: 2013-01-19 09:14 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/c887baec012a 8006584: improve variable handling in NashornScriptEngine Reviewed-by: jlaskey, hannesw ! src/jdk/nashorn/api/scripting/NashornScriptEngine.java ! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java ! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java From james.laskey at oracle.com Sat Jan 19 06:17:11 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Sat, 19 Jan 2013 10:17:11 -0400 Subject: JavaDoc Message-ID: <9CC56AAB-854F-4E28-AE2E-0D365A8460DB@oracle.com> One thing we need to keep in mind when we build in master, is not to contribute the Nashorn JavaDoc to the master JavaDoc (since none of the Nashorn interfaces are usable to those outside our group.) From sundararajan.athijegannathan at oracle.com Sat Jan 19 07:23:55 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Sat, 19 Jan 2013 20:53:55 +0530 Subject: Review request JDK-8006557: JDK8/Lambda build clashes on Map.replace() Message-ID: <50FABA8B.3060803@oracle.com> Hi, Please review http://cr.openjdk.java.net/~sundar/8006557/ Thanks -Sundar From james.laskey at oracle.com Sat Jan 19 08:03:28 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Sat, 19 Jan 2013 12:03:28 -0400 Subject: Review request JDK-8006557: JDK8/Lambda build clashes on Map.replace() In-Reply-To: <50FABA8B.3060803@oracle.com> References: <50FABA8B.3060803@oracle.com> Message-ID: <39A12BB5-5955-4937-AF63-2436F709D399@oracle.com> +1 On 2013-01-19, at 11:23 AM, A. Sundararajan wrote: > Hi, > > Please review http://cr.openjdk.java.net/~sundar/8006557/ > > Thanks > -Sundar From sundararajan.athijegannathan at oracle.com Sat Jan 19 09:06:35 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Sat, 19 Jan 2013 17:06:35 +0000 Subject: hg: nashorn/jdk8/nashorn: 8006557: JDK8/Lambda build clashes on Map.replace() Message-ID: <20130119170637.1C167473F7@hg.openjdk.java.net> Changeset: a8966074d4e9 Author: sundar Date: 2013-01-19 22:35 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/a8966074d4e9 8006557: JDK8/Lambda build clashes on Map.replace() Reviewed-by: jlaskey ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! test/src/jdk/nashorn/internal/runtime/ContextTest.java From attila.szegedi at oracle.com Mon Jan 21 01:55:36 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Mon, 21 Jan 2013 10:55:36 +0100 Subject: Review request for JDK-8006525 Message-ID: Please review JDK-8006525 at http://cr.openjdk.java.net/~attila/8006525/webrev.00 Thanks, Attila. From hannes.wallnoefer at oracle.com Mon Jan 21 02:02:20 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Mon, 21 Jan 2013 11:02:20 +0100 Subject: Review request for JDK-8006525 In-Reply-To: References: Message-ID: <50FD122C.6070107@oracle.com> +1 Am 2013-01-21 10:55, schrieb Attila Szegedi: > Please review JDK-8006525 at http://cr.openjdk.java.net/~attila/8006525/webrev.00 > > Thanks, > Attila. From attila.szegedi at oracle.com Mon Jan 21 02:04:18 2013 From: attila.szegedi at oracle.com (attila.szegedi at oracle.com) Date: Mon, 21 Jan 2013 10:04:18 +0000 Subject: hg: nashorn/jdk8/nashorn: 8006525: Give StaticClass objects their own linker Message-ID: <20130121100419.C616D4741A@hg.openjdk.java.net> Changeset: 0cee498b330d Author: attila Date: 2013-01-21 11:03 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/0cee498b330d 8006525: Give StaticClass objects their own linker Reviewed-by: hannesw, lagergren ! src/jdk/nashorn/internal/runtime/linker/Bootstrap.java ! src/jdk/nashorn/internal/runtime/linker/NashornPrimitiveLinker.java + src/jdk/nashorn/internal/runtime/linker/NashornStaticClassLinker.java From marcus.lagergren at oracle.com Mon Jan 21 02:19:22 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Mon, 21 Jan 2013 11:19:22 +0100 Subject: Review request for JDK-8006525 In-Reply-To: References: Message-ID: <2F85C94F-DA07-49A1-B0A3-52A15EB77500@oracle.com> +1 if you add a copyright header to the new file On Jan 21, 2013, at 10:55 AM, Attila Szegedi wrote: > Please review JDK-8006525 at http://cr.openjdk.java.net/~attila/8006525/webrev.00 > > Thanks, > Attila. From james.laskey at oracle.com Mon Jan 21 04:19:30 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Mon, 21 Jan 2013 08:19:30 -0400 Subject: Review request for JDK-8006525 In-Reply-To: References: Message-ID: <1981EC51-12CA-414E-A9F8-B7EAB44DD38E@oracle.com> +1 On 2013-01-21, at 5:55 AM, Attila Szegedi wrote: > Please review JDK-8006525 at http://cr.openjdk.java.net/~attila/8006525/webrev.00 > > Thanks, > Attila. From sundararajan.athijegannathan at oracle.com Mon Jan 21 05:34:50 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Mon, 21 Jan 2013 19:04:50 +0530 Subject: Review request JDK-8006635 : Reduce access levels as much as possible Message-ID: <50FD43FA.3050407@oracle.com> Hi, Please review http://cr.openjdk.java.net/~sundar/8006635/ Thanks -Sundar From james.laskey at oracle.com Mon Jan 21 05:42:05 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Mon, 21 Jan 2013 09:42:05 -0400 Subject: Review request JDK-8006635 : Reduce access levels as much as possible In-Reply-To: <50FD43FA.3050407@oracle.com> References: <50FD43FA.3050407@oracle.com> Message-ID: +1 On 2013-01-21, at 9:34 AM, A. Sundararajan wrote: > Hi, > > Please review http://cr.openjdk.java.net/~sundar/8006635/ > > Thanks > -Sundar From marcus.lagergren at oracle.com Mon Jan 21 06:24:56 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Mon, 21 Jan 2013 15:24:56 +0100 Subject: Review request JDK-8006635 : Reduce access levels as much as possible In-Reply-To: <50FD43FA.3050407@oracle.com> References: <50FD43FA.3050407@oracle.com> Message-ID: +1 On Jan 21, 2013, at 2:34 PM, A. Sundararajan wrote: > Hi, > > Please review http://cr.openjdk.java.net/~sundar/8006635/ > > Thanks > -Sundar From sundararajan.athijegannathan at oracle.com Mon Jan 21 07:48:04 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Mon, 21 Jan 2013 15:48:04 +0000 Subject: hg: nashorn/jdk8/nashorn: 8006635: Reduce access levels as much as possible Message-ID: <20130121154806.E01C347427@hg.openjdk.java.net> Changeset: 8b3cc4ad1810 Author: sundar Date: 2013-01-21 21:17 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/8b3cc4ad1810 8006635: Reduce access levels as much as possible Reviewed-by: jlaskey, lagergren, attila ! src/jdk/nashorn/api/scripting/NashornScriptEngine.java ! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java ! src/jdk/nashorn/internal/codegen/Compiler.java ! src/jdk/nashorn/internal/ir/Symbol.java ! src/jdk/nashorn/internal/ir/debug/JSONWriter.java ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/objects/NativeArray.java ! src/jdk/nashorn/internal/objects/NativeDebug.java ! src/jdk/nashorn/internal/objects/NativeJava.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/DebugLogger.java ! src/jdk/nashorn/internal/runtime/ECMAException.java + src/jdk/nashorn/internal/runtime/OptionsObject.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/StructureLoader.java ! src/jdk/nashorn/internal/runtime/arrays/ArrayIterator.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java ! src/jdk/nashorn/internal/runtime/linker/LinkerCallSite.java ! src/jdk/nashorn/tools/Shell.java ! test/src/jdk/nashorn/internal/access/BooleanAccessTest.java ! test/src/jdk/nashorn/internal/codegen/CompilerTest.java ! test/src/jdk/nashorn/internal/parser/ParserTest.java ! test/src/jdk/nashorn/internal/runtime/ContextTest.java ! test/src/jdk/nashorn/internal/runtime/JSTypeTest.java ! test/src/jdk/nashorn/internal/test/framework/SharedContextEvaluator.java From hannes.wallnoefer at oracle.com Mon Jan 21 08:28:57 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Mon, 21 Jan 2013 17:28:57 +0100 Subject: Review request for JDK-8006570 Message-ID: <50FD6CC9.40301@oracle.com> Please review JDK-8006570 at http://cr.openjdk.java.net/~hannesw/8006570/. Thanks, Hannes From james.laskey at oracle.com Mon Jan 21 08:50:17 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Mon, 21 Jan 2013 12:50:17 -0400 Subject: Review request for JDK-8006570 In-Reply-To: <50FD6CC9.40301@oracle.com> References: <50FD6CC9.40301@oracle.com> Message-ID: +1 On 2013-01-21, at 12:28 PM, Hannes Wallnoefer wrote: > Please review JDK-8006570 at http://cr.openjdk.java.net/~hannesw/8006570/. > > Thanks, > Hannes From marcus.lagergren at oracle.com Mon Jan 21 09:44:15 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Mon, 21 Jan 2013 18:44:15 +0100 Subject: Review request for JDK-8006570 In-Reply-To: <50FD6CC9.40301@oracle.com> References: <50FD6CC9.40301@oracle.com> Message-ID: Looks solid. Someone more versed than me in the "strict" semantics of JavaScript should give the final word though. /M On Jan 21, 2013, at 5:28 PM, Hannes Wallnoefer wrote: > Please review JDK-8006570 at http://cr.openjdk.java.net/~hannesw/8006570/. > > Thanks, > Hannes From hannes.wallnoefer at oracle.com Tue Jan 22 03:01:13 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Tue, 22 Jan 2013 12:01:13 +0100 Subject: Review request for JDK-8006570 In-Reply-To: <50FD6CC9.40301@oracle.com> References: <50FD6CC9.40301@oracle.com> Message-ID: <50FE7179.4010301@oracle.com> I've uploaded a new webrev based mostly on feedback by Sundar. http://cr.openjdk.java.net/~hannesw/8006570/ Changes to the first webrev: - Test now also covers this-conversion cases that were not subject of this bug. - NashornGuardedInvocation does no longer make use of the NashornCallSiteDescriptor.CALLSITE_STRICT flag. The purpose of NashornGuardedInvocation never was to track strictness of the callsite, but of the invocation target function (Javadoc comments were misleading and have also been fixed). What we really need to know from NashornGuardedInvocation is whether the target function is a non-strict script function (i.e. neither built-in nor strict) so I changed the NashornGuardedInvocation.isStrict() methods to NashornGuardedInvocation.isNonStrict() with these semantics (neither strict nor built-in). Most checks for target function strictness already did this correctly (i.e. check for both not-strict and not-builtin) but the one in PrimitiveLookup.lookupPrimitive() did not, making string method invocation 2-3 times more expensive because of the unnecessary string wrapper creation (I'll add a String microbenchmark later as part of JDK-8006408). Hannes Am 2013-01-21 17:28, schrieb Hannes Wallnoefer: > Please review JDK-8006570 at > http://cr.openjdk.java.net/~hannesw/8006570/. > > Thanks, > Hannes From attila.szegedi at oracle.com Tue Jan 22 03:35:21 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Tue, 22 Jan 2013 12:35:21 +0100 Subject: Review request for JDK-8006570 In-Reply-To: <50FE7179.4010301@oracle.com> References: <50FD6CC9.40301@oracle.com> <50FE7179.4010301@oracle.com> Message-ID: <53D2B8D9-0047-4560-8A9B-E378E9F70780@oracle.com> Looks good to me. On Jan 22, 2013, at 12:01 PM, Hannes Wallnoefer wrote: > I've uploaded a new webrev based mostly on feedback by Sundar. > > http://cr.openjdk.java.net/~hannesw/8006570/ > > Changes to the first webrev: > > - Test now also covers this-conversion cases that were not subject of this bug. > > - NashornGuardedInvocation does no longer make use of the NashornCallSiteDescriptor.CALLSITE_STRICT flag. The purpose of NashornGuardedInvocation never was to track strictness of the callsite, but of the invocation target function (Javadoc comments were misleading and have also been fixed). > > What we really need to know from NashornGuardedInvocation is whether the target function is a non-strict script function (i.e. neither built-in nor strict) so I changed the NashornGuardedInvocation.isStrict() methods to NashornGuardedInvocation.isNonStrict() with these semantics (neither strict nor built-in). > > Most checks for target function strictness already did this correctly (i.e. check for both not-strict and not-builtin) but the one in PrimitiveLookup.lookupPrimitive() did not, making string method invocation 2-3 times more expensive because of the unnecessary string wrapper creation (I'll add a String microbenchmark later as part of JDK-8006408). > > Hannes > > Am 2013-01-21 17:28, schrieb Hannes Wallnoefer: >> Please review JDK-8006570 at http://cr.openjdk.java.net/~hannesw/8006570/. >> >> Thanks, >> Hannes > From james.laskey at oracle.com Tue Jan 22 04:46:07 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Tue, 22 Jan 2013 08:46:07 -0400 Subject: Review request for JDK-8006570 In-Reply-To: <50FE7179.4010301@oracle.com> References: <50FD6CC9.40301@oracle.com> <50FE7179.4010301@oracle.com> Message-ID: <7A063F21-BFF8-42BE-8D62-440A2868942C@oracle.com> Looks good. On 2013-01-22, at 7:01 AM, Hannes Wallnoefer wrote: > I've uploaded a new webrev based mostly on feedback by Sundar. > > http://cr.openjdk.java.net/~hannesw/8006570/ > > Changes to the first webrev: > > - Test now also covers this-conversion cases that were not subject of this bug. > > - NashornGuardedInvocation does no longer make use of the NashornCallSiteDescriptor.CALLSITE_STRICT flag. The purpose of NashornGuardedInvocation never was to track strictness of the callsite, but of the invocation target function (Javadoc comments were misleading and have also been fixed). > > What we really need to know from NashornGuardedInvocation is whether the target function is a non-strict script function (i.e. neither built-in nor strict) so I changed the NashornGuardedInvocation.isStrict() methods to NashornGuardedInvocation.isNonStrict() with these semantics (neither strict nor built-in). > > Most checks for target function strictness already did this correctly (i.e. check for both not-strict and not-builtin) but the one in PrimitiveLookup.lookupPrimitive() did not, making string method invocation 2-3 times more expensive because of the unnecessary string wrapper creation (I'll add a String microbenchmark later as part of JDK-8006408). > > Hannes > > Am 2013-01-21 17:28, schrieb Hannes Wallnoefer: >> Please review JDK-8006570 at http://cr.openjdk.java.net/~hannesw/8006570/. >> >> Thanks, >> Hannes > From hannes.wallnoefer at oracle.com Tue Jan 22 05:20:07 2013 From: hannes.wallnoefer at oracle.com (hannes.wallnoefer at oracle.com) Date: Tue, 22 Jan 2013 13:20:07 +0000 Subject: hg: nashorn/jdk8/nashorn: 8006570: This-value for non-strict functions should be converted to object Message-ID: <20130122132009.376AF4745B@hg.openjdk.java.net> Changeset: 935dcec38e9a Author: hannesw Date: 2013-01-22 14:14 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/935dcec38e9a 8006570: This-value for non-strict functions should be converted to object Reviewed-by: jlaskey, lagergren, attila ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/objects/NativeBoolean.java ! src/jdk/nashorn/internal/objects/NativeFunction.java ! src/jdk/nashorn/internal/objects/NativeNumber.java ! src/jdk/nashorn/internal/objects/NativeString.java ! src/jdk/nashorn/internal/runtime/GlobalObject.java ! src/jdk/nashorn/internal/runtime/ScriptFunction.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/SetMethodCreator.java ! src/jdk/nashorn/internal/runtime/linker/NashornGuardedInvocation.java ! src/jdk/nashorn/internal/runtime/linker/NashornLinker.java ! src/jdk/nashorn/internal/runtime/linker/PrimitiveLookup.java + test/script/basic/JDK-8006570.js + test/script/basic/JDK-8006570.js.EXPECTED From attila.szegedi at oracle.com Tue Jan 22 05:26:26 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Tue, 22 Jan 2013 14:26:26 +0100 Subject: Review request for JDK-8006677 Message-ID: Please review JDK-8006677 at http://cr.openjdk.java.net/~attila/8006677/webrev.00 Thanks, Attila. From attila.szegedi at oracle.com Tue Jan 22 05:36:47 2013 From: attila.szegedi at oracle.com (attila.szegedi at oracle.com) Date: Tue, 22 Jan 2013 13:36:47 +0000 Subject: hg: nashorn/jdk8/nashorn: 8006677: Remove unused FunctionNode flags Message-ID: <20130122133650.1321D4745C@hg.openjdk.java.net> Changeset: e43d1013d871 Author: attila Date: 2013-01-22 14:36 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/e43d1013d871 8006677: Remove unused FunctionNode flags Reviewed-by: hannesw, jlaskey ! src/jdk/nashorn/internal/codegen/Lower.java ! src/jdk/nashorn/internal/ir/FunctionNode.java ! src/jdk/nashorn/internal/parser/Parser.java From hannes.wallnoefer at oracle.com Tue Jan 22 05:43:35 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Tue, 22 Jan 2013 14:43:35 +0100 Subject: Review request for JDK-8006677 In-Reply-To: References: Message-ID: <50FE9787.2070203@oracle.com> +1 Am 2013-01-22 14:26, schrieb Attila Szegedi: > Please review JDK-8006677 at http://cr.openjdk.java.net/~attila/8006677/webrev.00 > > Thanks, > Attila. From james.laskey at oracle.com Tue Jan 22 05:54:43 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Tue, 22 Jan 2013 09:54:43 -0400 Subject: Review request for JDK-8006677 In-Reply-To: References: Message-ID: <8A3833D4-F4F7-4B4B-B9A1-163BF7C63DE4@oracle.com> +1 On 2013-01-22, at 9:26 AM, Attila Szegedi wrote: > Please review JDK-8006677 at http://cr.openjdk.java.net/~attila/8006677/webrev.00 > > Thanks, > Attila. From marcus.lagergren at oracle.com Tue Jan 22 06:16:38 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Tue, 22 Jan 2013 15:16:38 +0100 Subject: Review request for JDK-8006677 In-Reply-To: References: Message-ID: <4A3845CE-D3F4-4884-8F6F-286841CC5DD9@oracle.com> +1 On Jan 22, 2013, at 2:26 PM, Attila Szegedi wrote: > Please review JDK-8006677 at http://cr.openjdk.java.net/~attila/8006677/webrev.00 > > Thanks, > Attila. From sundararajan.athijegannathan at oracle.com Tue Jan 22 06:26:51 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Tue, 22 Jan 2013 19:56:51 +0530 Subject: Review request JDK-8006678 : Avoid too many Context.getGlobal() calls Message-ID: <50FEA1AB.8010807@oracle.com> Hi, Please review http://cr.openjdk.java.net/~sundar/8006678/ Thanks -Sundar From marcus.lagergren at oracle.com Tue Jan 22 06:31:47 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Tue, 22 Jan 2013 15:31:47 +0100 Subject: Review request JDK-8006678 : Avoid too many Context.getGlobal() calls In-Reply-To: <50FEA1AB.8010807@oracle.com> References: <50FEA1AB.8010807@oracle.com> Message-ID: <030004FF-CAE6-4DAC-B523-BFE1F5F29805@oracle.com> +1 On Jan 22, 2013, at 3:26 PM, A. Sundararajan wrote: > Hi, > > Please review http://cr.openjdk.java.net/~sundar/8006678/ > > Thanks > -Sundar From james.laskey at oracle.com Tue Jan 22 06:43:10 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Tue, 22 Jan 2013 10:43:10 -0400 Subject: Review request JDK-8006678 : Avoid too many Context.getGlobal() calls In-Reply-To: <50FEA1AB.8010807@oracle.com> References: <50FEA1AB.8010807@oracle.com> Message-ID: +1 On 2013-01-22, at 10:26 AM, A. Sundararajan wrote: > Hi, > > Please review http://cr.openjdk.java.net/~sundar/8006678/ > > Thanks > -Sundar From sundararajan.athijegannathan at oracle.com Tue Jan 22 08:37:42 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Tue, 22 Jan 2013 16:37:42 +0000 Subject: hg: nashorn/jdk8/nashorn: 8006678: Avoid too many Context.getGlobal() calls Message-ID: <20130122163743.C033047462@hg.openjdk.java.net> Changeset: e62dba3ce52b Author: sundar Date: 2013-01-22 22:07 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/e62dba3ce52b 8006678: Avoid too many Context.getGlobal() calls Reviewed-by: lagergren, jlaskey ! make/project.properties ! src/jdk/nashorn/api/scripting/NashornScriptEngine.java ! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java ! src/jdk/nashorn/internal/codegen/Lower.java ! src/jdk/nashorn/internal/ir/debug/JSONWriter.java ! src/jdk/nashorn/internal/objects/AccessorPropertyDescriptor.java ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/objects/NativeArguments.java ! src/jdk/nashorn/internal/objects/NativeArray.java ! src/jdk/nashorn/internal/objects/NativeBoolean.java ! src/jdk/nashorn/internal/objects/NativeDate.java ! src/jdk/nashorn/internal/objects/NativeFunction.java ! src/jdk/nashorn/internal/objects/NativeJSAdapter.java ! src/jdk/nashorn/internal/objects/NativeJSON.java ! src/jdk/nashorn/internal/objects/NativeJava.java ! src/jdk/nashorn/internal/objects/NativeNumber.java ! src/jdk/nashorn/internal/objects/NativeObject.java ! src/jdk/nashorn/internal/objects/NativeRegExp.java ! src/jdk/nashorn/internal/objects/NativeString.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/ECMAErrors.java ! src/jdk/nashorn/internal/runtime/ErrorManager.java ! src/jdk/nashorn/internal/runtime/JSType.java ! src/jdk/nashorn/internal/runtime/ParserException.java ! src/jdk/nashorn/internal/runtime/ScriptFunction.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/ScriptRuntime.java ! src/jdk/nashorn/internal/runtime/ScriptingFunctions.java ! src/jdk/nashorn/internal/runtime/SetMethodCreator.java ! src/jdk/nashorn/internal/runtime/URIUtils.java ! src/jdk/nashorn/internal/runtime/Undefined.java ! src/jdk/nashorn/internal/runtime/arrays/ArrayLikeIterator.java ! src/jdk/nashorn/internal/runtime/arrays/FrozenArrayFilter.java ! src/jdk/nashorn/internal/runtime/arrays/IteratorAction.java ! src/jdk/nashorn/internal/runtime/arrays/SealedArrayFilter.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java ! src/jdk/nashorn/internal/runtime/linker/JavaArgumentConverters.java ! src/jdk/nashorn/internal/runtime/linker/Lookup.java ! src/jdk/nashorn/internal/runtime/linker/NashornBottomLinker.java ! src/jdk/nashorn/internal/runtime/linker/NashornStaticClassLinker.java From sundararajan.athijegannathan at oracle.com Tue Jan 22 22:15:32 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Wed, 23 Jan 2013 11:45:32 +0530 Subject: Review request JDK-8006736 : nashorn script engine should support the usage multiple global objects with same engine instance Message-ID: <50FF8004.2080609@oracle.com> Hi, Please review http://cr.openjdk.java.net/~sundar/8006736/ Thanks -Sundar From hannes.wallnoefer at oracle.com Wed Jan 23 02:48:36 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Wed, 23 Jan 2013 11:48:36 +0100 Subject: Review request JDK-8006736 : nashorn script engine should support the usage multiple global objects with same engine instance In-Reply-To: <50FF8004.2080609@oracle.com> References: <50FF8004.2080609@oracle.com> Message-ID: <50FFC004.20504@oracle.com> Looks good to me. Hannes Am 2013-01-23 07:15, schrieb A. Sundararajan: > Hi, > > Please review http://cr.openjdk.java.net/~sundar/8006736/ > > Thanks > -Sundar From darren.cruse at gmail.com Tue Jan 22 14:41:06 2013 From: darren.cruse at gmail.com (Darren Cruse) Date: Tue, 22 Jan 2013 16:41:06 -0600 Subject: what is the debugging story for nashorn? Message-ID: Hi guys been reading all I can find, but haven't actually played with nashorn yet, and I have questions about debugging/debuggers and nashorn - namely: a. I know NetBeans is already supporting javascript debugging using nashorn - but how about Eclipse? (e.g. is nashorn by chance supporting the standard java debugger protocol such that eclipse support should be easy?) And on a related note: b. Will remote debugging be supported out of the box? (we're doing a lot of amazon cloud stuff these days I feel like remote debugging is incredibly important) Thanks, Darren From darren.cruse at gmail.com Tue Jan 22 15:15:17 2013 From: darren.cruse at gmail.com (Darren Cruse) Date: Tue, 22 Jan 2013 17:15:17 -0600 Subject: nashorn on android? (impossible? improbable? :)) Message-ID: Hope this question isn't annoying (because the more I'd researched the more I think this is a real challenge). But I'm excited at the idea of "javascript everywhere" and it would be really nice if "everywhere" wound up including nashorn on android. >From googling around my suspicion is that invokedynamic is probably slow if ever coming to the Dalvik VM - am I seeing it right? Or is there some solution coming for this? e.g. I thought I'd seen something about a JSR for emulating invokedynamic on older JVMs but I can't find it - and now wonder if I dreamed it :). Also I just stumbled on this: http://code.google.com/p/droid292/ But it looks more like a proposal than a going concern at this point. Any thoughts? What are the odds of nashorn ever coming to android? From james.laskey at oracle.com Wed Jan 23 03:17:57 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Wed, 23 Jan 2013 07:17:57 -0400 Subject: Review request JDK-8006736 : nashorn script engine should support the usage multiple global objects with same engine instance In-Reply-To: <50FF8004.2080609@oracle.com> References: <50FF8004.2080609@oracle.com> Message-ID: +1 On 2013-01-23, at 2:15 AM, A. Sundararajan wrote: > Hi, > > Please review http://cr.openjdk.java.net/~sundar/8006736/ > > Thanks > -Sundar From james.laskey at oracle.com Wed Jan 23 03:30:15 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Wed, 23 Jan 2013 07:30:15 -0400 Subject: what is the debugging story for nashorn? In-Reply-To: References: Message-ID: <428A1B44-45C1-40B2-82DD-A5365BAB945C@oracle.com> On 2013-01-22, at 6:41 PM, Darren Cruse wrote: > Hi guys been reading all I can find, but haven't actually played with > nashorn yet, and I have questions about debugging/debuggers and nashorn - > namely: > > a. I know NetBeans is already supporting javascript debugging using > nashorn - but how about Eclipse? > > (e.g. is nashorn by chance supporting the standard java debugger protocol > such that eclipse support should be easy?) > > And on a related note: > > b. Will remote debugging be supported out of the box? > > (we're doing a lot of amazon cloud stuff these days I feel like remote > debugging is incredibly important) > > Thanks, > > Darren I posted a library at the last JVM language summit that provided a debugging API for plugin support. We have no plans for debugging for JDK8 but will likely see debuggers popping up after it is shipped. From james.laskey at oracle.com Wed Jan 23 03:32:45 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Wed, 23 Jan 2013 07:32:45 -0400 Subject: nashorn on android? (impossible? improbable? :)) In-Reply-To: References: Message-ID: On 2013-01-22, at 7:15 PM, Darren Cruse wrote: > Hope this question isn't annoying (because the more I'd researched the more > I think this is a real challenge). > > But I'm excited at the idea of "javascript everywhere" and it would be > really nice if "everywhere" wound up including nashorn on android. > >> From googling around my suspicion is that invokedynamic is probably slow if > ever coming to the Dalvik VM - am I seeing it right? > > Or is there some solution coming for this? > > e.g. I thought I'd seen something about a JSR for emulating invokedynamic > on older JVMs but I can't find it - and now wonder if I dreamed it :). > > Also I just stumbled on this: http://code.google.com/p/droid292/ > > But it looks more like a proposal than a going concern at this point. > > Any thoughts? > > What are the odds of nashorn ever coming to android? We are only supporting on the JVM. Another group would have to take on Dalvik. From sundararajan.athijegannathan at oracle.com Wed Jan 23 03:34:24 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Wed, 23 Jan 2013 11:34:24 +0000 Subject: hg: nashorn/jdk8/nashorn: 8006736: nashorn script engine should support the usage multiple global objects with same engine instance Message-ID: <20130123113426.405C4474C7@hg.openjdk.java.net> Changeset: 0dbcb7350595 Author: sundar Date: 2013-01-23 17:04 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/0dbcb7350595 8006736: nashorn script engine should support the usage multiple global objects with same engine instance Reviewed-by: lagergren, jlaskey, hannesw ! src/jdk/nashorn/api/scripting/NashornScriptEngine.java ! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java ! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java From forax at univ-mlv.fr Wed Jan 23 04:22:13 2013 From: forax at univ-mlv.fr (Remi Forax) Date: Wed, 23 Jan 2013 13:22:13 +0100 Subject: nashorn on android? (impossible? improbable? :)) In-Reply-To: References: Message-ID: <50FFD5F5.3050804@univ-mlv.fr> On 01/23/2013 12:32 PM, Jim Laskey (Oracle) wrote: > On 2013-01-22, at 7:15 PM, Darren Cruse wrote: > >> Hope this question isn't annoying (because the more I'd researched the more >> I think this is a real challenge). >> >> But I'm excited at the idea of "javascript everywhere" and it would be >> really nice if "everywhere" wound up including nashorn on android. >> >>> From googling around my suspicion is that invokedynamic is probably slow if >> ever coming to the Dalvik VM - am I seeing it right? >> >> Or is there some solution coming for this? >> >> e.g. I thought I'd seen something about a JSR for emulating invokedynamic >> on older JVMs but I can't find it - and now wonder if I dreamed it :). >> >> Also I just stumbled on this: http://code.google.com/p/droid292/ >> >> But it looks more like a proposal than a going concern at this point. >> >> Any thoughts? >> >> What are the odds of nashorn ever coming to android? > We are only supporting on the JVM. Another group would have to take on Dalvik. > Hi Darren, porting Nashorn on Android is a big project because Android doesn't implement the JSR 292, droid292 was a prototype done by some of my students for there master thesis (in computer engineering) to evaluate how difficult it is. Since last september, Jerome Pilliet has started his Phd thesis on porting the JSR 292 on Android, the main issue is that you can not directly port or re-implement what Hotspot (the Oracle VM) does because the battery of your smartphone will not last more than one hour in that case :) The first set of patches have hit the Android repository not long ago and you can find a most recent version here: https://bitbucket.org/jpilliet/android-292 https://bitbucket.org/jpilliet/dalvik-292 https://bitbucket.org/jpilliet/libcore-292 Anyway, don't expect Nashorn to work on Android before at least one year. R?mi From rieberandreas at gmail.com Wed Jan 23 04:31:44 2013 From: rieberandreas at gmail.com (Andreas Rieber) Date: Wed, 23 Jan 2013 13:31:44 +0100 Subject: scriptpad testing Message-ID: <50FFD830.8060407@gmail.com> Hi, i tried now the scriptpad sample from openjdk with Nashorn and have found 2 minor issues. The file: jdk8/jdk/src/share/sample/scripting/scriptpad/src/resources/conc.js relies on a 'sync' function. Looks to be a Rhino only - so a migration issue. The next one is about scopes in file: jdk8/jdk/src/share/sample/scripting/scriptpad/src/resources/scriptpad.js. I removed everything unimportant and the following code snippet show the problem: ------ var guiPkgs = { JFrame: function() { print("created"); } }; with (guiPkgs) { function main() { function createFrame() { var frame = new JFrame(); } createFrame(); } } main(); ------ 'created' should come out but JFrame is unknown. I tested this with some browsers (Firefox, Safari, Chrome) but only Rhino and Firefox can handle that construct. I had also some more complex problems related to JSR223 but will come back with samples when i can separate them better. - Andreas From sundararajan.athijegannathan at oracle.com Wed Jan 23 05:22:11 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Wed, 23 Jan 2013 18:52:11 +0530 Subject: scriptpad testing In-Reply-To: <50FFD830.8060407@gmail.com> References: <50FFD830.8060407@gmail.com> Message-ID: <50FFE403.1000807@oracle.com> Hi, Yes, 'sync' is rhino specific. 'with' statement seems to be a bug. I'll file a bug. I've recently made some changes to jsr223 interface to nashorn. In particular global scope handling and multiple globals per engine etc. have been improved and fixed. Please pull the latest code. And please send us your test cases showing failure. Thanks, -Sundar On Wednesday 23 January 2013 06:01 PM, Andreas Rieber wrote: > Hi, > > i tried now the scriptpad sample from openjdk with Nashorn and have > found 2 minor issues. > > The file: > jdk8/jdk/src/share/sample/scripting/scriptpad/src/resources/conc.js > relies on a 'sync' function. Looks to be a Rhino only - so a migration > issue. > > The next one is about scopes in file: > jdk8/jdk/src/share/sample/scripting/scriptpad/src/resources/scriptpad.js. > I removed everything unimportant and the following code snippet show > the problem: > > ------ > var guiPkgs = { JFrame: function() { print("created"); } }; > > with (guiPkgs) { > function main() { > function createFrame() { > var frame = new JFrame(); > } > > createFrame(); > } > } > > main(); > > ------ > > 'created' should come out but JFrame is unknown. I tested this with > some browsers (Firefox, Safari, Chrome) but only Rhino and Firefox can > handle that construct. > > I had also some more complex problems related to JSR223 but will come > back with samples when i can separate them better. > > - Andreas > From james.laskey at oracle.com Wed Jan 23 05:26:59 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Wed, 23 Jan 2013 09:26:59 -0400 Subject: scriptpad testing In-Reply-To: <50FFE403.1000807@oracle.com> References: <50FFD830.8060407@gmail.com> <50FFE403.1000807@oracle.com> Message-ID: <8AB24C62-A092-49EB-839B-F0831BC09202@oracle.com> Bug ID: 8006755 On 2013-01-23, at 9:22 AM, "A. Sundararajan" wrote: > Hi, > > Yes, 'sync' is rhino specific. 'with' statement seems to be a bug. I'll file a bug. > > I've recently made some changes to jsr223 interface to nashorn. In particular global scope handling and multiple globals per engine etc. have been improved and fixed. Please pull the latest code. And please send us your test cases showing failure. > > Thanks, > -Sundar > > > On Wednesday 23 January 2013 06:01 PM, Andreas Rieber wrote: >> Hi, >> >> i tried now the scriptpad sample from openjdk with Nashorn and have found 2 minor issues. >> >> The file: jdk8/jdk/src/share/sample/scripting/scriptpad/src/resources/conc.js relies on a 'sync' function. Looks to be a Rhino only - so a migration issue. >> >> The next one is about scopes in file: jdk8/jdk/src/share/sample/scripting/scriptpad/src/resources/scriptpad.js. I removed everything unimportant and the following code snippet show the problem: >> >> ------ >> var guiPkgs = { JFrame: function() { print("created"); } }; >> >> with (guiPkgs) { >> function main() { >> function createFrame() { >> var frame = new JFrame(); >> } >> >> createFrame(); >> } >> } >> >> main(); >> >> ------ >> >> 'created' should come out but JFrame is unknown. I tested this with some browsers (Firefox, Safari, Chrome) but only Rhino and Firefox can handle that construct. >> >> I had also some more complex problems related to JSR223 but will come back with samples when i can separate them better. >> >> - Andreas >> > From rieberandreas at gmail.com Wed Jan 23 05:33:45 2013 From: rieberandreas at gmail.com (Andreas Rieber) Date: Wed, 23 Jan 2013 14:33:45 +0100 Subject: scriptpad testing In-Reply-To: <50FFE403.1000807@oracle.com> References: <50FFD830.8060407@gmail.com> <50FFE403.1000807@oracle.com> Message-ID: <50FFE6B9.3060300@gmail.com> Hi Sundar, i have your last changes, did another update and fresh build 1 minute ago: sh bin/jjs scriptpad.js scriptpad.js:7 ReferenceError: "JFrame" is not defined where the scriptpad.js is: var guiPkgs = { JFrame: function() { print("created"); } }; with (guiPkgs) { function main() { function createFrame() { var frame = new JFrame(); } createFrame(); } } main(); - Andreas On 23.01.13 14:22, A. Sundararajan wrote: > Hi, > > Yes, 'sync' is rhino specific. 'with' statement seems to be a bug. > I'll file a bug. > > I've recently made some changes to jsr223 interface to nashorn. In > particular global scope handling and multiple globals per engine etc. > have been improved and fixed. Please pull the latest code. And please > send us your test cases showing failure. > > Thanks, > -Sundar > > > On Wednesday 23 January 2013 06:01 PM, Andreas Rieber wrote: >> Hi, >> >> i tried now the scriptpad sample from openjdk with Nashorn and have >> found 2 minor issues. >> >> The file: >> jdk8/jdk/src/share/sample/scripting/scriptpad/src/resources/conc.js >> relies on a 'sync' function. Looks to be a Rhino only - so a >> migration issue. >> >> The next one is about scopes in file: >> jdk8/jdk/src/share/sample/scripting/scriptpad/src/resources/scriptpad.js. >> I removed everything unimportant and the following code snippet show >> the problem: >> >> ------ >> var guiPkgs = { JFrame: function() { print("created"); } }; >> >> with (guiPkgs) { >> function main() { >> function createFrame() { >> var frame = new JFrame(); >> } >> >> createFrame(); >> } >> } >> >> main(); >> >> ------ >> >> 'created' should come out but JFrame is unknown. I tested this with >> some browsers (Firefox, Safari, Chrome) but only Rhino and Firefox >> can handle that construct. >> >> I had also some more complex problems related to JSR223 but will come >> back with samples when i can separate them better. >> >> - Andreas >> > From sundararajan.athijegannathan at oracle.com Wed Jan 23 05:36:19 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Wed, 23 Jan 2013 19:06:19 +0530 Subject: scriptpad testing In-Reply-To: <50FFE6B9.3060300@gmail.com> References: <50FFD830.8060407@gmail.com> <50FFE403.1000807@oracle.com> <50FFE6B9.3060300@gmail.com> Message-ID: <50FFE753.803@oracle.com> Hi Andreas, No, I've not fixed anything w.r.t "with" statement. You mentioned you had faced complex issues with JSR223 -- I did some fixes in nashorn's JSR223 engine implementation. For the 'with' issue, Jim has filed a bug thanks -Sundar On Wednesday 23 January 2013 07:03 PM, Andreas Rieber wrote: > Hi Sundar, > > i have your last changes, did another update and fresh build 1 minute > ago: > > sh bin/jjs scriptpad.js > scriptpad.js:7 ReferenceError: "JFrame" is not defined > > where the scriptpad.js is: > > var guiPkgs = { JFrame: function() { print("created"); } }; > > with (guiPkgs) { > function main() { > function createFrame() { > var frame = new JFrame(); > } > > createFrame(); > } > } > > main(); > > > - Andreas > > > On 23.01.13 14:22, A. Sundararajan wrote: >> Hi, >> >> Yes, 'sync' is rhino specific. 'with' statement seems to be a bug. >> I'll file a bug. >> >> I've recently made some changes to jsr223 interface to nashorn. In >> particular global scope handling and multiple globals per engine etc. >> have been improved and fixed. Please pull the latest code. And please >> send us your test cases showing failure. >> >> Thanks, >> -Sundar >> >> >> On Wednesday 23 January 2013 06:01 PM, Andreas Rieber wrote: >>> Hi, >>> >>> i tried now the scriptpad sample from openjdk with Nashorn and have >>> found 2 minor issues. >>> >>> The file: >>> jdk8/jdk/src/share/sample/scripting/scriptpad/src/resources/conc.js >>> relies on a 'sync' function. Looks to be a Rhino only - so a >>> migration issue. >>> >>> The next one is about scopes in file: >>> jdk8/jdk/src/share/sample/scripting/scriptpad/src/resources/scriptpad.js. >>> I removed everything unimportant and the following code snippet show >>> the problem: >>> >>> ------ >>> var guiPkgs = { JFrame: function() { print("created"); } }; >>> >>> with (guiPkgs) { >>> function main() { >>> function createFrame() { >>> var frame = new JFrame(); >>> } >>> >>> createFrame(); >>> } >>> } >>> >>> main(); >>> >>> ------ >>> >>> 'created' should come out but JFrame is unknown. I tested this with >>> some browsers (Firefox, Safari, Chrome) but only Rhino and Firefox >>> can handle that construct. >>> >>> I had also some more complex problems related to JSR223 but will >>> come back with samples when i can separate them better. >>> >>> - Andreas >>> >> From rieberandreas at gmail.com Wed Jan 23 05:51:54 2013 From: rieberandreas at gmail.com (Andreas Rieber) Date: Wed, 23 Jan 2013 14:51:54 +0100 Subject: scriptpad testing In-Reply-To: <50FFE753.803@oracle.com> References: <50FFD830.8060407@gmail.com> <50FFE403.1000807@oracle.com> <50FFE6B9.3060300@gmail.com> <50FFE753.803@oracle.com> Message-ID: <50FFEAFA.8000809@gmail.com> Hi Sundar, it is awt event which ends in a classcastexception. Let me try to build a smaller sample, or should i send you the scriptpad i have so you can try? Exception in thread "AWT-EventQueue-0" java.lang.ClassCastException: Cannot cast java.awt.event.ActionEvent to [Ljava.lang.Object; at sun.invoke.util.ValueConversions.newClassCastException(ValueConversions.java:461) at sun.invoke.util.ValueConversions.castReference(ValueConversions.java:456) at jdk.nashorn.internal.javaadapters.java.awt.event.ActionListener.actionPerformed(Unknown Source) at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:2022) at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2346) - Andreas On 23.01.13 14:36, A. Sundararajan wrote: > Hi Andreas, > > No, I've not fixed anything w.r.t "with" statement. You mentioned you > had faced complex issues with JSR223 -- I did some fixes in nashorn's > JSR223 engine implementation. > > For the 'with' issue, Jim has filed a bug > > thanks > -Sundar > > On Wednesday 23 January 2013 07:03 PM, Andreas Rieber wrote: >> Hi Sundar, >> >> i have your last changes, did another update and fresh build 1 minute >> ago: >> >> sh bin/jjs scriptpad.js >> scriptpad.js:7 ReferenceError: "JFrame" is not defined >> >> where the scriptpad.js is: >> >> var guiPkgs = { JFrame: function() { print("created"); } }; >> >> with (guiPkgs) { >> function main() { >> function createFrame() { >> var frame = new JFrame(); >> } >> >> createFrame(); >> } >> } >> >> main(); >> >> >> - Andreas >> >> >> On 23.01.13 14:22, A. Sundararajan wrote: >>> Hi, >>> >>> Yes, 'sync' is rhino specific. 'with' statement seems to be a bug. >>> I'll file a bug. >>> >>> I've recently made some changes to jsr223 interface to nashorn. In >>> particular global scope handling and multiple globals per engine >>> etc. have been improved and fixed. Please pull the latest code. And >>> please send us your test cases showing failure. >>> >>> Thanks, >>> -Sundar >>> >>> >>> On Wednesday 23 January 2013 06:01 PM, Andreas Rieber wrote: >>>> Hi, >>>> >>>> i tried now the scriptpad sample from openjdk with Nashorn and have >>>> found 2 minor issues. >>>> >>>> The file: >>>> jdk8/jdk/src/share/sample/scripting/scriptpad/src/resources/conc.js >>>> relies on a 'sync' function. Looks to be a Rhino only - so a >>>> migration issue. >>>> >>>> The next one is about scopes in file: >>>> jdk8/jdk/src/share/sample/scripting/scriptpad/src/resources/scriptpad.js. >>>> I removed everything unimportant and the following code snippet >>>> show the problem: >>>> >>>> ------ >>>> var guiPkgs = { JFrame: function() { print("created"); } }; >>>> >>>> with (guiPkgs) { >>>> function main() { >>>> function createFrame() { >>>> var frame = new JFrame(); >>>> } >>>> >>>> createFrame(); >>>> } >>>> } >>>> >>>> main(); >>>> >>>> ------ >>>> >>>> 'created' should come out but JFrame is unknown. I tested this with >>>> some browsers (Firefox, Safari, Chrome) but only Rhino and Firefox >>>> can handle that construct. >>>> >>>> I had also some more complex problems related to JSR223 but will >>>> come back with samples when i can separate them better. >>>> >>>> - Andreas >>>> From sundararajan.athijegannathan at oracle.com Wed Jan 23 05:53:04 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Wed, 23 Jan 2013 19:23:04 +0530 Subject: scriptpad testing In-Reply-To: <50FFEAFA.8000809@gmail.com> References: <50FFD830.8060407@gmail.com> <50FFE403.1000807@oracle.com> <50FFE6B9.3060300@gmail.com> <50FFE753.803@oracle.com> <50FFEAFA.8000809@gmail.com> Message-ID: <50FFEB40.60006@oracle.com> HI Andreas, Sounds good. Please send zip/tar of your modified app -Sundar On Wednesday 23 January 2013 07:21 PM, Andreas Rieber wrote: > Hi Sundar, > > it is awt event which ends in a classcastexception. Let me try to > build a smaller sample, or should i send you the scriptpad i have so > you can try? > > Exception in thread "AWT-EventQueue-0" java.lang.ClassCastException: > Cannot cast java.awt.event.ActionEvent to [Ljava.lang.Object; > at > sun.invoke.util.ValueConversions.newClassCastException(ValueConversions.java:461) > at > sun.invoke.util.ValueConversions.castReference(ValueConversions.java:456) > at > jdk.nashorn.internal.javaadapters.java.awt.event.ActionListener.actionPerformed(Unknown > Source) > at > javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:2022) > at > javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2346) > > - Andreas > > On 23.01.13 14:36, A. Sundararajan wrote: >> Hi Andreas, >> >> No, I've not fixed anything w.r.t "with" statement. You mentioned you >> had faced complex issues with JSR223 -- I did some fixes in nashorn's >> JSR223 engine implementation. >> >> For the 'with' issue, Jim has filed a bug >> >> thanks >> -Sundar >> >> On Wednesday 23 January 2013 07:03 PM, Andreas Rieber wrote: >>> Hi Sundar, >>> >>> i have your last changes, did another update and fresh build 1 >>> minute ago: >>> >>> sh bin/jjs scriptpad.js >>> scriptpad.js:7 ReferenceError: "JFrame" is not defined >>> >>> where the scriptpad.js is: >>> >>> var guiPkgs = { JFrame: function() { print("created"); } }; >>> >>> with (guiPkgs) { >>> function main() { >>> function createFrame() { >>> var frame = new JFrame(); >>> } >>> >>> createFrame(); >>> } >>> } >>> >>> main(); >>> >>> >>> - Andreas >>> >>> >>> On 23.01.13 14:22, A. Sundararajan wrote: >>>> Hi, >>>> >>>> Yes, 'sync' is rhino specific. 'with' statement seems to be a bug. >>>> I'll file a bug. >>>> >>>> I've recently made some changes to jsr223 interface to nashorn. In >>>> particular global scope handling and multiple globals per engine >>>> etc. have been improved and fixed. Please pull the latest code. And >>>> please send us your test cases showing failure. >>>> >>>> Thanks, >>>> -Sundar >>>> >>>> >>>> On Wednesday 23 January 2013 06:01 PM, Andreas Rieber wrote: >>>>> Hi, >>>>> >>>>> i tried now the scriptpad sample from openjdk with Nashorn and >>>>> have found 2 minor issues. >>>>> >>>>> The file: >>>>> jdk8/jdk/src/share/sample/scripting/scriptpad/src/resources/conc.js relies >>>>> on a 'sync' function. Looks to be a Rhino only - so a migration >>>>> issue. >>>>> >>>>> The next one is about scopes in file: >>>>> jdk8/jdk/src/share/sample/scripting/scriptpad/src/resources/scriptpad.js. >>>>> I removed everything unimportant and the following code snippet >>>>> show the problem: >>>>> >>>>> ------ >>>>> var guiPkgs = { JFrame: function() { print("created"); } }; >>>>> >>>>> with (guiPkgs) { >>>>> function main() { >>>>> function createFrame() { >>>>> var frame = new JFrame(); >>>>> } >>>>> >>>>> createFrame(); >>>>> } >>>>> } >>>>> >>>>> main(); >>>>> >>>>> ------ >>>>> >>>>> 'created' should come out but JFrame is unknown. I tested this >>>>> with some browsers (Firefox, Safari, Chrome) but only Rhino and >>>>> Firefox can handle that construct. >>>>> >>>>> I had also some more complex problems related to JSR223 but will >>>>> come back with samples when i can separate them better. >>>>> >>>>> - Andreas >>>>> From rieberandreas at gmail.com Wed Jan 23 06:05:03 2013 From: rieberandreas at gmail.com (Andreas Rieber) Date: Wed, 23 Jan 2013 15:05:03 +0100 Subject: scriptpad testing In-Reply-To: <50FFEB40.60006@oracle.com> References: <50FFD830.8060407@gmail.com> <50FFE403.1000807@oracle.com> <50FFE6B9.3060300@gmail.com> <50FFE753.803@oracle.com> <50FFEAFA.8000809@gmail.com> <50FFEB40.60006@oracle.com> Message-ID: <50FFEE0F.5050900@gmail.com> Hi Sundar, find attached the tgz. You can run it direct with jjs or better with jrunscript for the JavaImporter. The exception happens when you select samples from the menu. First two entries work, but from 3rd you get the exception. - Andreas On 23.01.13 14:53, A. Sundararajan wrote: > HI Andreas, > > Sounds good. Please send zip/tar of your modified app > > -Sundar > > On Wednesday 23 January 2013 07:21 PM, Andreas Rieber wrote: >> Hi Sundar, >> >> it is awt event which ends in a classcastexception. Let me try to >> build a smaller sample, or should i send you the scriptpad i have so >> you can try? >> >> Exception in thread "AWT-EventQueue-0" java.lang.ClassCastException: >> Cannot cast java.awt.event.ActionEvent to [Ljava.lang.Object; >> at >> sun.invoke.util.ValueConversions.newClassCastException(ValueConversions.java:461) >> at >> sun.invoke.util.ValueConversions.castReference(ValueConversions.java:456) >> at >> jdk.nashorn.internal.javaadapters.java.awt.event.ActionListener.actionPerformed(Unknown >> Source) >> at >> javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:2022) >> at >> javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2346) >> >> - Andreas >> >> On 23.01.13 14:36, A. Sundararajan wrote: >>> Hi Andreas, >>> >>> No, I've not fixed anything w.r.t "with" statement. You mentioned >>> you had faced complex issues with JSR223 -- I did some fixes in >>> nashorn's JSR223 engine implementation. >>> >>> For the 'with' issue, Jim has filed a bug >>> >>> thanks >>> -Sundar >>> >>> On Wednesday 23 January 2013 07:03 PM, Andreas Rieber wrote: >>>> Hi Sundar, >>>> >>>> i have your last changes, did another update and fresh build 1 >>>> minute ago: >>>> >>>> sh bin/jjs scriptpad.js >>>> scriptpad.js:7 ReferenceError: "JFrame" is not defined >>>> >>>> where the scriptpad.js is: >>>> >>>> var guiPkgs = { JFrame: function() { print("created"); } }; >>>> >>>> with (guiPkgs) { >>>> function main() { >>>> function createFrame() { >>>> var frame = new JFrame(); >>>> } >>>> >>>> createFrame(); >>>> } >>>> } >>>> >>>> main(); >>>> >>>> >>>> - Andreas >>>> >>>> >>>> On 23.01.13 14:22, A. Sundararajan wrote: >>>>> Hi, >>>>> >>>>> Yes, 'sync' is rhino specific. 'with' statement seems to be a >>>>> bug. I'll file a bug. >>>>> >>>>> I've recently made some changes to jsr223 interface to nashorn. In >>>>> particular global scope handling and multiple globals per engine >>>>> etc. have been improved and fixed. Please pull the latest code. >>>>> And please send us your test cases showing failure. >>>>> >>>>> Thanks, >>>>> -Sundar >>>>> >>>>> >>>>> On Wednesday 23 January 2013 06:01 PM, Andreas Rieber wrote: >>>>>> Hi, >>>>>> >>>>>> i tried now the scriptpad sample from openjdk with Nashorn and >>>>>> have found 2 minor issues. >>>>>> >>>>>> The file: >>>>>> jdk8/jdk/src/share/sample/scripting/scriptpad/src/resources/conc.js >>>>>> relies on a 'sync' function. Looks to be a Rhino only - so a >>>>>> migration issue. >>>>>> >>>>>> The next one is about scopes in file: >>>>>> jdk8/jdk/src/share/sample/scripting/scriptpad/src/resources/scriptpad.js. >>>>>> I removed everything unimportant and the following code snippet >>>>>> show the problem: >>>>>> >>>>>> ------ >>>>>> var guiPkgs = { JFrame: function() { print("created"); } }; >>>>>> >>>>>> with (guiPkgs) { >>>>>> function main() { >>>>>> function createFrame() { >>>>>> var frame = new JFrame(); >>>>>> } >>>>>> >>>>>> createFrame(); >>>>>> } >>>>>> } >>>>>> >>>>>> main(); >>>>>> >>>>>> ------ >>>>>> >>>>>> 'created' should come out but JFrame is unknown. I tested this >>>>>> with some browsers (Firefox, Safari, Chrome) but only Rhino and >>>>>> Firefox can handle that construct. >>>>>> >>>>>> I had also some more complex problems related to JSR223 but will >>>>>> come back with samples when i can separate them better. >>>>>> >>>>>> - Andreas >>>>>> > From hannes.wallnoefer at oracle.com Wed Jan 23 06:49:04 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Wed, 23 Jan 2013 15:49:04 +0100 Subject: Review request for JDK-8006408 Message-ID: <50FFF860.1050309@oracle.com> Please review patch for JDK-8006408: http://cr.openjdk.java.net/~hannesw/8006408/ This adds int/double/missing args specializations for the charAt, charCodeAt, indexOf, slice, substring string methods, and an optimized version of String.prototype.split() when called with a string rather than a regexp as separator argument. It also contains a string micro-benchmark script. Hannes From james.laskey at oracle.com Wed Jan 23 06:56:57 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Wed, 23 Jan 2013 10:56:57 -0400 Subject: Review request for JDK-8006408 In-Reply-To: <50FFF860.1050309@oracle.com> References: <50FFF860.1050309@oracle.com> Message-ID: <0DF62A6F-D573-4563-BEAF-E1DFC05EA8C7@oracle.com> +1 On 2013-01-23, at 10:49 AM, Hannes Wallnoefer wrote: > Please review patch for JDK-8006408: > > http://cr.openjdk.java.net/~hannesw/8006408/ > > This adds int/double/missing args specializations for the charAt, charCodeAt, indexOf, slice, substring string methods, and an optimized version of String.prototype.split() when called with a string rather than a regexp as separator argument. > > It also contains a string micro-benchmark script. > > Hannes > From marcus.lagergren at oracle.com Wed Jan 23 09:15:10 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Wed, 23 Jan 2013 18:15:10 +0100 Subject: Review request for JDK-8006408 In-Reply-To: <50FFF860.1050309@oracle.com> References: <50FFF860.1050309@oracle.com> Message-ID: +1 On Jan 23, 2013, at 3:49 PM, Hannes Wallnoefer wrote: > Please review patch for JDK-8006408: > > http://cr.openjdk.java.net/~hannesw/8006408/ > > This adds int/double/missing args specializations for the charAt, charCodeAt, indexOf, slice, substring string methods, and an optimized version of String.prototype.split() when called with a string rather than a regexp as separator argument. > > It also contains a string micro-benchmark script. > > Hannes > From james.laskey at oracle.com Wed Jan 23 10:05:25 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Wed, 23 Jan 2013 14:05:25 -0400 Subject: Proposed patches for nashorn build infrastructure Message-ID: <158C9586-D5FD-4ECA-AB07-C52435D0C706@oracle.com> [For the hard core] I successfully built a jdk with nashorn bits included. More work to do, but I thought I'd post the preliminary patches here so others can play with/review them (and as a backup). I'll check these changes into the nashorn forest in a bit, once I find out what the ccc processes are. Pending is the licence for dynalink. Once we have that, we will include dynalink sources and remove the ant step. Steps: hg fclone http://hg.openjdk.java.net/nashorn/jdk8 nashorn~jdk8~infra cd nashorn~jdk8~infra hg fpull -u http://hg.openjdk.java.net/jdk8/jdk8 patch -p1 < nashorn~top.patch (cd jdk l patch -p1 < nashorn~jdk.patch) (cd nashon l patch -p1 < nashorn~ nashon.patch) (cd nashorn/make ; ant dist) sh ./configure make all NEWBUILD=true You may have to stop and fix the encoding in jdk/THIRD_PARTY_README to be UTF-8. Then just restart the make. Once done, you should be able to; cd build/yourplatform/images/j2re-bundle/jre1.8.0.jre/Contents/Home setenv JAVA_HOME . bin/jjs jjs> print("hello"); hello From james.laskey at oracle.com Wed Jan 23 10:46:36 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Wed, 23 Jan 2013 14:46:36 -0400 Subject: Proposed patches for nashorn build infrastructure In-Reply-To: <158C9586-D5FD-4ECA-AB07-C52435D0C706@oracle.com> References: <158C9586-D5FD-4ECA-AB07-C52435D0C706@oracle.com> Message-ID: I forgot the patches would be stripped from the e-mail Find them at http://cr.openjdk.java.net/~jlaskey/patches/nashorn~top.patch http://cr.openjdk.java.net/~jlaskey/patches/nashorn~jdk.patch http://cr.openjdk.java.net/~jlaskey/patches/nashorn~nashorn.patch On 2013-01-23, at 2:05 PM, Jim Laskey (Oracle) wrote: > [For the hard core] > > I successfully built a jdk with nashorn bits included. More work to do, but I thought I'd post the preliminary patches here so others can play with/review them (and as a backup). I'll check these changes into the nashorn forest in a bit, once I find out what the ccc processes are. Pending is the licence for dynalink. Once we have that, we will include dynalink sources and remove the ant step. > > Steps: > > hg fclone http://hg.openjdk.java.net/nashorn/jdk8 nashorn~jdk8~infra > cd nashorn~jdk8~infra > hg fpull -u http://hg.openjdk.java.net/jdk8/jdk8 > patch -p1 < nashorn~top.patch > (cd jdk l patch -p1 < nashorn~jdk.patch) > (cd nashon l patch -p1 < nashorn~ nashon.patch) > (cd nashorn/make ; ant dist) > sh ./configure > make all NEWBUILD=true > > You may have to stop and fix the encoding in jdk/THIRD_PARTY_README to be UTF-8. Then just restart the make. > > Once done, you should be able to; > > cd build/yourplatform/images/j2re-bundle/jre1.8.0.jre/Contents/Home > setenv JAVA_HOME . > bin/jjs > jjs> print("hello"); > hello > > > > > > > > From sundararajan.athijegannathan at oracle.com Wed Jan 23 22:34:11 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Thu, 24 Jan 2013 12:04:11 +0530 Subject: Review request JDK-8006575 : Error in codegen for element access on primitive value Message-ID: <5100D5E3.7030601@oracle.com> Hi, Please review http://cr.openjdk.java.net/~sundar/8006575/ Thanks -Sundar From hannes.wallnoefer at oracle.com Thu Jan 24 00:13:16 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Thu, 24 Jan 2013 09:13:16 +0100 Subject: Review request JDK-8006575 : Error in codegen for element access on primitive value In-Reply-To: <5100D5E3.7030601@oracle.com> References: <5100D5E3.7030601@oracle.com> Message-ID: <5100ED1C.5040804@oracle.com> +1 Am 2013-01-24 07:34, schrieb A. Sundararajan: > Hi, > > Please review http://cr.openjdk.java.net/~sundar/8006575/ > > Thanks > -Sundar From marcus.lagergren at oracle.com Thu Jan 24 01:59:28 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Thu, 24 Jan 2013 10:59:28 +0100 Subject: Review request JDK-8006575 : Error in codegen for element access on primitive value In-Reply-To: <5100D5E3.7030601@oracle.com> References: <5100D5E3.7030601@oracle.com> Message-ID: <2D457305-FB9B-46FE-8729-FCD738AF6BCD@oracle.com> +1 On Jan 24, 2013, at 7:34 AM, A. Sundararajan wrote: > Hi, > > Please review http://cr.openjdk.java.net/~sundar/8006575/ > > Thanks > -Sundar From sundararajan.athijegannathan at oracle.com Thu Jan 24 02:52:17 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Thu, 24 Jan 2013 10:52:17 +0000 Subject: hg: nashorn/jdk8/nashorn: 8006575: Error in codegen for element access on primitive value Message-ID: <20130124105220.1B35B4750D@hg.openjdk.java.net> Changeset: d4a968ca8953 Author: sundar Date: 2013-01-24 16:21 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/d4a968ca8953 8006575: Error in codegen for element access on primitive value Reviewed-by: hannesw, lagergren ! src/jdk/nashorn/internal/codegen/CodeGenerator.java + test/script/basic/JDK-8006575.js From sundararajan.athijegannathan at oracle.com Thu Jan 24 03:41:41 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Thu, 24 Jan 2013 17:11:41 +0530 Subject: Review request JDK-8006755: Functions inside with statements dont get correct scope Message-ID: <51011DF5.8040704@oracle.com> Hi, Please review http://cr.openjdk.java.net/~sundar/8006755/ Thanks -Sundar From marcus.lagergren at oracle.com Thu Jan 24 03:45:28 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Thu, 24 Jan 2013 12:45:28 +0100 Subject: Review request JDK-8006755: Functions inside with statements dont get correct scope In-Reply-To: <51011DF5.8040704@oracle.com> References: <51011DF5.8040704@oracle.com> Message-ID: <42BBE7A6-3126-4F27-BBB1-019E8EBB2715@oracle.com> Looks good! That was surprisingly simple. On Jan 24, 2013, at 12:41 PM, A. Sundararajan wrote: > Hi, > > Please review http://cr.openjdk.java.net/~sundar/8006755/ > > Thanks > -Sundar From sundararajan.athijegannathan at oracle.com Thu Jan 24 04:19:30 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Thu, 24 Jan 2013 12:19:30 +0000 Subject: hg: nashorn/jdk8/nashorn: 8006755: Functions inside with statements dont get correct scope Message-ID: <20130124121931.DD78547513@hg.openjdk.java.net> Changeset: 3f528769aee1 Author: sundar Date: 2013-01-24 17:49 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/3f528769aee1 8006755: Functions inside with statements dont get correct scope Reviewed-by: lagergren, attila ! src/jdk/nashorn/internal/parser/Parser.java + test/script/basic/JDK-8006755.js From sundararajan.athijegannathan at oracle.com Thu Jan 24 04:47:56 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Thu, 24 Jan 2013 18:17:56 +0530 Subject: scriptpad testing In-Reply-To: <50FFEE0F.5050900@gmail.com> References: <50FFD830.8060407@gmail.com> <50FFE403.1000807@oracle.com> <50FFE6B9.3060300@gmail.com> <50FFE753.803@oracle.com> <50FFEAFA.8000809@gmail.com> <50FFEB40.60006@oracle.com> <50FFEE0F.5050900@gmail.com> Message-ID: <51012D7C.3030506@oracle.com> Hi Andreas Fixed that function-inside-with-statement issue.( http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/3f528769aee1 ) I reproduced the ClassCastException you mentioned. I'll file a bug after collecting bit more info. FYI. Thanks -Sundar On Wednesday 23 January 2013 07:35 PM, Andreas Rieber wrote: > Hi Sundar, > > find attached the tgz. You can run it direct with jjs or better with > jrunscript for the JavaImporter. The exception happens when you select > samples from the menu. First two entries work, but from 3rd you get > the exception. > > - Andreas > > On 23.01.13 14:53, A. Sundararajan wrote: >> HI Andreas, >> >> Sounds good. Please send zip/tar of your modified app >> >> -Sundar >> >> On Wednesday 23 January 2013 07:21 PM, Andreas Rieber wrote: >>> Hi Sundar, >>> >>> it is awt event which ends in a classcastexception. Let me try to >>> build a smaller sample, or should i send you the scriptpad i have so >>> you can try? >>> >>> Exception in thread "AWT-EventQueue-0" java.lang.ClassCastException: >>> Cannot cast java.awt.event.ActionEvent to [Ljava.lang.Object; >>> at >>> sun.invoke.util.ValueConversions.newClassCastException(ValueConversions.java:461) >>> at >>> sun.invoke.util.ValueConversions.castReference(ValueConversions.java:456) >>> at >>> jdk.nashorn.internal.javaadapters.java.awt.event.ActionListener.actionPerformed(Unknown >>> Source) >>> at >>> javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:2022) >>> >>> at >>> javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2346) >>> >>> - Andreas >>> >>> On 23.01.13 14:36, A. Sundararajan wrote: >>>> Hi Andreas, >>>> >>>> No, I've not fixed anything w.r.t "with" statement. You mentioned >>>> you had faced complex issues with JSR223 -- I did some fixes in >>>> nashorn's JSR223 engine implementation. >>>> >>>> For the 'with' issue, Jim has filed a bug >>>> >>>> thanks >>>> -Sundar >>>> >>>> On Wednesday 23 January 2013 07:03 PM, Andreas Rieber wrote: >>>>> Hi Sundar, >>>>> >>>>> i have your last changes, did another update and fresh build 1 >>>>> minute ago: >>>>> >>>>> sh bin/jjs scriptpad.js >>>>> scriptpad.js:7 ReferenceError: "JFrame" is not defined >>>>> >>>>> where the scriptpad.js is: >>>>> >>>>> var guiPkgs = { JFrame: function() { print("created"); } }; >>>>> >>>>> with (guiPkgs) { >>>>> function main() { >>>>> function createFrame() { >>>>> var frame = new JFrame(); >>>>> } >>>>> >>>>> createFrame(); >>>>> } >>>>> } >>>>> >>>>> main(); >>>>> >>>>> >>>>> - Andreas >>>>> >>>>> >>>>> On 23.01.13 14:22, A. Sundararajan wrote: >>>>>> Hi, >>>>>> >>>>>> Yes, 'sync' is rhino specific. 'with' statement seems to be a >>>>>> bug. I'll file a bug. >>>>>> >>>>>> I've recently made some changes to jsr223 interface to nashorn. >>>>>> In particular global scope handling and multiple globals per >>>>>> engine etc. have been improved and fixed. Please pull the latest >>>>>> code. And please send us your test cases showing failure. >>>>>> >>>>>> Thanks, >>>>>> -Sundar >>>>>> >>>>>> >>>>>> On Wednesday 23 January 2013 06:01 PM, Andreas Rieber wrote: >>>>>>> Hi, >>>>>>> >>>>>>> i tried now the scriptpad sample from openjdk with Nashorn and >>>>>>> have found 2 minor issues. >>>>>>> >>>>>>> The file: >>>>>>> jdk8/jdk/src/share/sample/scripting/scriptpad/src/resources/conc.js >>>>>>> relies on a 'sync' function. Looks to be a Rhino only - so a >>>>>>> migration issue. >>>>>>> >>>>>>> The next one is about scopes in file: >>>>>>> jdk8/jdk/src/share/sample/scripting/scriptpad/src/resources/scriptpad.js. >>>>>>> I removed everything unimportant and the following code snippet >>>>>>> show the problem: >>>>>>> >>>>>>> ------ >>>>>>> var guiPkgs = { JFrame: function() { print("created"); } }; >>>>>>> >>>>>>> with (guiPkgs) { >>>>>>> function main() { >>>>>>> function createFrame() { >>>>>>> var frame = new JFrame(); >>>>>>> } >>>>>>> >>>>>>> createFrame(); >>>>>>> } >>>>>>> } >>>>>>> >>>>>>> main(); >>>>>>> >>>>>>> ------ >>>>>>> >>>>>>> 'created' should come out but JFrame is unknown. I tested this >>>>>>> with some browsers (Firefox, Safari, Chrome) but only Rhino and >>>>>>> Firefox can handle that construct. >>>>>>> >>>>>>> I had also some more complex problems related to JSR223 but will >>>>>>> come back with samples when i can separate them better. >>>>>>> >>>>>>> - Andreas >>>>>>> >> From rieberandreas at gmail.com Thu Jan 24 05:33:01 2013 From: rieberandreas at gmail.com (Andreas Rieber) Date: Thu, 24 Jan 2013 14:33:01 +0100 Subject: scriptpad testing In-Reply-To: <51012D7C.3030506@oracle.com> References: <50FFD830.8060407@gmail.com> <50FFE403.1000807@oracle.com> <50FFE6B9.3060300@gmail.com> <50FFE753.803@oracle.com> <50FFEAFA.8000809@gmail.com> <50FFEB40.60006@oracle.com> <50FFEE0F.5050900@gmail.com> <51012D7C.3030506@oracle.com> Message-ID: <5101380D.20500@gmail.com> Hi Sundar, i found that fix and retested. One line more and same problem (the 'var frame' outside the createFrame() function). >> var guiPkgs = { JFrame: function() { print("created"); } }; with (guiPkgs) { function main() { var frame; function createFrame() { frame = new JFrame(); } createFrame(); } } main(); >> scriptpad.js:9 ReferenceError: "JFrame" is not defined - Andreas On 24.01.13 13:47, A. Sundararajan wrote: > Hi Andreas > > Fixed that function-inside-with-statement issue.( > http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/3f528769aee1 ) > > I reproduced the ClassCastException you mentioned. I'll file a bug > after collecting bit more info. FYI. > > Thanks > -Sundar > > > On Wednesday 23 January 2013 07:35 PM, Andreas Rieber wrote: >> Hi Sundar, >> >> find attached the tgz. You can run it direct with jjs or better with >> jrunscript for the JavaImporter. The exception happens when you >> select samples from the menu. First two entries work, but from 3rd >> you get the exception. >> >> - Andreas >> >> On 23.01.13 14:53, A. Sundararajan wrote: >>> HI Andreas, >>> >>> Sounds good. Please send zip/tar of your modified app >>> >>> -Sundar >>> >>> On Wednesday 23 January 2013 07:21 PM, Andreas Rieber wrote: >>>> Hi Sundar, >>>> >>>> it is awt event which ends in a classcastexception. Let me try to >>>> build a smaller sample, or should i send you the scriptpad i have >>>> so you can try? >>>> >>>> Exception in thread "AWT-EventQueue-0" >>>> java.lang.ClassCastException: Cannot cast >>>> java.awt.event.ActionEvent to [Ljava.lang.Object; >>>> at >>>> sun.invoke.util.ValueConversions.newClassCastException(ValueConversions.java:461) >>>> at >>>> sun.invoke.util.ValueConversions.castReference(ValueConversions.java:456) >>>> at >>>> jdk.nashorn.internal.javaadapters.java.awt.event.ActionListener.actionPerformed(Unknown >>>> Source) >>>> at >>>> javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:2022) >>>> >>>> at >>>> javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2346) >>>> >>>> - Andreas >>>> >>>> On 23.01.13 14:36, A. Sundararajan wrote: >>>>> Hi Andreas, >>>>> >>>>> No, I've not fixed anything w.r.t "with" statement. You mentioned >>>>> you had faced complex issues with JSR223 -- I did some fixes in >>>>> nashorn's JSR223 engine implementation. >>>>> >>>>> For the 'with' issue, Jim has filed a bug >>>>> >>>>> thanks >>>>> -Sundar >>>>> >>>>> On Wednesday 23 January 2013 07:03 PM, Andreas Rieber wrote: >>>>>> Hi Sundar, >>>>>> >>>>>> i have your last changes, did another update and fresh build 1 >>>>>> minute ago: >>>>>> >>>>>> sh bin/jjs scriptpad.js >>>>>> scriptpad.js:7 ReferenceError: "JFrame" is not defined >>>>>> >>>>>> where the scriptpad.js is: >>>>>> >>>>>> var guiPkgs = { JFrame: function() { print("created"); } }; >>>>>> >>>>>> with (guiPkgs) { >>>>>> function main() { >>>>>> function createFrame() { >>>>>> var frame = new JFrame(); >>>>>> } >>>>>> >>>>>> createFrame(); >>>>>> } >>>>>> } >>>>>> >>>>>> main(); >>>>>> >>>>>> >>>>>> - Andreas From hannes.wallnoefer at oracle.com Thu Jan 24 05:58:02 2013 From: hannes.wallnoefer at oracle.com (hannes.wallnoefer at oracle.com) Date: Thu, 24 Jan 2013 13:58:02 +0000 Subject: hg: nashorn/jdk8/nashorn: 8006408: Clean up and specialize NativeString Message-ID: <20130124135802.E60B747517@hg.openjdk.java.net> Changeset: edfa73d9fde7 Author: hannesw Date: 2013-01-24 14:55 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/edfa73d9fde7 8006408: Clean up and specialize NativeString Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/internal/objects/NativeString.java + test/examples/string-micro.js From hannes.wallnoefer at oracle.com Thu Jan 24 06:35:37 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Thu, 24 Jan 2013 15:35:37 +0100 Subject: Review request for JDK-8006766: Array-like access to characters of a string is slow Message-ID: <510146B9.2010906@oracle.com> Please review JDK-8006766 (Array-like access to characters of a string is slow) at http://cr.openjdk.java.net/~hannesw/8006766/ This overrides ScriptObject.findGetIndexMethod() in NativeString to avoid creating a NativeString wrapper for array-like access to the characters of a string (e.g. "foo"[0]). Performance gain as measured by test/examples/string-micro.js is about 3x. The larger part of this patch involves changing the signature of ScriptObject.lookup() and related methods to take the LinkRequest object as second parameter. This is necessary to make sure we're actually dealing with a primitive JS string vs. a wrapped String object in NativeString.findGetIndexMethod(). It also helped rewrite my patch for JDK-8006570 (this-value for non-strict functions should be converted to object) in a much nicer way, doing it locally in ScriptFunction.findCallMethod() rather than centrally in NashornLinker.getGuardedInvocation(). Hannes From marcus.lagergren at oracle.com Thu Jan 24 07:55:33 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Thu, 24 Jan 2013 16:55:33 +0100 Subject: Review request for JDK-8006766: Array-like access to characters of a string is slow In-Reply-To: <510146B9.2010906@oracle.com> References: <510146B9.2010906@oracle.com> Message-ID: <18B7CDA0-EF5D-453C-9B15-9677752DE0D6@oracle.com> Most of the changes seem to be passing around the entire LinkRequest. The rest is fairly simple to understand. +1 from me. /M On Jan 24, 2013, at 3:35 PM, Hannes Wallnoefer wrote: > Please review JDK-8006766 (Array-like access to characters of a string is slow) at > > http://cr.openjdk.java.net/~hannesw/8006766/ > > This overrides ScriptObject.findGetIndexMethod() in NativeString to avoid creating a NativeString wrapper for array-like access to the characters of a string (e.g. "foo"[0]). Performance gain as measured by test/examples/string-micro.js is about 3x. > > The larger part of this patch involves changing the signature of ScriptObject.lookup() and related methods to take the LinkRequest object as second parameter. > > This is necessary to make sure we're actually dealing with a primitive JS string vs. a wrapped String object in NativeString.findGetIndexMethod(). It also helped rewrite my patch for JDK-8006570 (this-value for non-strict functions should be converted to object) in a much nicer way, doing it locally in ScriptFunction.findCallMethod() rather than centrally in NashornLinker.getGuardedInvocation(). > > Hannes > From james.laskey at oracle.com Thu Jan 24 08:14:58 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Thu, 24 Jan 2013 12:14:58 -0400 Subject: Review Request JDK-8006852 : Move tests from JIRA for prepopulated map failures Message-ID: <0B09D269-EB05-4EB0-BB47-67DF7529B303@oracle.com> http://cr.openjdk.java.net/~jlaskey/8006852/webrev.00 From james.laskey at oracle.com Thu Jan 24 08:18:56 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Thu, 24 Jan 2013 16:18:56 +0000 Subject: hg: nashorn/jdk8/nashorn: 8006852: Move tests from JIRA for prepopulated map failures Message-ID: <20130124161859.B34C24751B@hg.openjdk.java.net> Changeset: f336aee22e85 Author: jlaskey Date: 2013-01-24 12:15 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/f336aee22e85 8006852: Move tests from JIRA for prepopulated map failures Reviewed-by: sundar Contributed-by: james.laskey at oracle.com + test/script/basic/JDK-8006852a.js + test/script/basic/JDK-8006852a.js.EXPECTED + test/script/basic/JDK-8006852b.js From sundararajan.athijegannathan at oracle.com Thu Jan 24 08:20:36 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Thu, 24 Jan 2013 21:50:36 +0530 Subject: Review request JDK-8006857: ClassCastException when interface implementing function uses arguments object Message-ID: <51015F54.5020707@oracle.com> Hi, Please review http://cr.openjdk.java.net/~sundar/8006857/ Thanks -Sundar From sundararajan.athijegannathan at oracle.com Thu Jan 24 08:24:27 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Thu, 24 Jan 2013 21:54:27 +0530 Subject: Review Request JDK-8006852 : Move tests from JIRA for prepopulated map failures In-Reply-To: <0B09D269-EB05-4EB0-BB47-67DF7529B303@oracle.com> References: <0B09D269-EB05-4EB0-BB47-67DF7529B303@oracle.com> Message-ID: <5101603B.1050604@oracle.com> Looks good On Thursday 24 January 2013 09:44 PM, Jim Laskey (Oracle) wrote: > http://cr.openjdk.java.net/~jlaskey/8006852/webrev.00 From james.laskey at oracle.com Thu Jan 24 08:26:04 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Thu, 24 Jan 2013 12:26:04 -0400 Subject: Review request JDK-8006857: ClassCastException when interface implementing function uses arguments object In-Reply-To: <51015F54.5020707@oracle.com> References: <51015F54.5020707@oracle.com> Message-ID: +1 On 2013-01-24, at 12:20 PM, "A. Sundararajan" wrote: > Hi, > > Please review http://cr.openjdk.java.net/~sundar/8006857/ > > Thanks > -Sundar From sundararajan.athijegannathan at oracle.com Thu Jan 24 09:09:42 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Thu, 24 Jan 2013 17:09:42 +0000 Subject: hg: nashorn/jdk8/nashorn: 8006857: ClassCastException when interface implementing function uses arguments object Message-ID: <20130124170944.147B847520@hg.openjdk.java.net> Changeset: bff7087396d7 Author: sundar Date: 2013-01-24 22:38 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/bff7087396d7 8006857: ClassCastException when interface implementing function uses arguments object Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/internal/runtime/ScriptObject.java + test/script/basic/JDK-8006857.js + test/script/basic/JDK-8006857.js.EXPECTED From rieberandreas at gmail.com Thu Jan 24 09:20:14 2013 From: rieberandreas at gmail.com (Andreas Rieber) Date: Thu, 24 Jan 2013 18:20:14 +0100 Subject: Proposed patches for nashorn build infrastructure In-Reply-To: <158C9586-D5FD-4ECA-AB07-C52435D0C706@oracle.com> References: <158C9586-D5FD-4ECA-AB07-C52435D0C706@oracle.com> Message-ID: <51016D4E.6020201@gmail.com> Works as expected! I also managed to patch the IcedTea Rhino version from jdk7 in, so i can compare both engines. cd /usr/local/src/jdk8nashorn/build/linux-x86-normal-server-release/images/j2sdk-image/bin ./jrunscript -q Language ECMAScript ECMA - 262 Edition 5.1 implemention "Oracle Nashorn" 0.1 Language ECMAScript 1.8 implemention "Mozilla Rhino" 1.7 release 3 PRERELEASE On 23.01.13 19:05, Jim Laskey (Oracle) wrote: > [For the hard core] > > I successfully built a jdk with nashorn bits included. More work to do, but I thought I'd post the preliminary patches here so others can play with/review them (and as a backup). I'll check these changes into the nashorn forest in a bit, once I find out what the ccc processes are. Pending is the licence for dynalink. Once we have that, we will include dynalink sources and remove the ant step. > > Steps: > > hg fclone http://hg.openjdk.java.net/nashorn/jdk8 nashorn~jdk8~infra > cd nashorn~jdk8~infra > hg fpull -u http://hg.openjdk.java.net/jdk8/jdk8 > patch -p1 < nashorn~top.patch > (cd jdk l patch -p1 < nashorn~jdk.patch) > (cd nashon l patch -p1 < nashorn~ nashon.patch) > (cd nashorn/make ; ant dist) > sh ./configure > make all NEWBUILD=true > > You may have to stop and fix the encoding in jdk/THIRD_PARTY_README to be UTF-8. Then just restart the make. > > Once done, you should be able to; > > cd build/yourplatform/images/j2re-bundle/jre1.8.0.jre/Contents/Home > setenv JAVA_HOME . > bin/jjs > jjs> print("hello"); > hello From hannes.wallnoefer at oracle.com Fri Jan 25 05:49:14 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Fri, 25 Jan 2013 14:49:14 +0100 Subject: Review request for JDK-8006766: Array-like access to characters of a string is slow In-Reply-To: <510146B9.2010906@oracle.com> References: <510146B9.2010906@oracle.com> Message-ID: <51028D5A.1070507@oracle.com> I've uploaded a new patch based on feedback by Marcus (static NativeString.get methods are now private). http://cr.openjdk.java.net/~hannesw/8006766/ Attila: I found that both CallSiteDescriptor and LinkRequest parameters are actually required in ScriptObject.lookup() as ScriptObject.findCallMethodMethod() calls findGetMethod() with a *modified* CallSiteDescriptor (ScriptObject.java line 1587) which, through overridden noSuchProperty/noSuchMethod methods, may get fed back to lookup(). Hannes Am 2013-01-24 15:35, schrieb Hannes Wallnoefer: > Please review JDK-8006766 (Array-like access to characters of a string > is slow) at > > http://cr.openjdk.java.net/~hannesw/8006766/ > > This overrides ScriptObject.findGetIndexMethod() in NativeString to > avoid creating a NativeString wrapper for array-like access to the > characters of a string (e.g. "foo"[0]). Performance gain as measured > by test/examples/string-micro.js is about 3x. > > The larger part of this patch involves changing the signature of > ScriptObject.lookup() and related methods to take the LinkRequest > object as second parameter. > > This is necessary to make sure we're actually dealing with a primitive > JS string vs. a wrapped String object in > NativeString.findGetIndexMethod(). It also helped rewrite my patch for > JDK-8006570 (this-value for non-strict functions should be converted > to object) in a much nicer way, doing it locally in > ScriptFunction.findCallMethod() rather than centrally in > NashornLinker.getGuardedInvocation(). > > Hannes > From hannes.wallnoefer at oracle.com Fri Jan 25 08:37:18 2013 From: hannes.wallnoefer at oracle.com (hannes.wallnoefer at oracle.com) Date: Fri, 25 Jan 2013 16:37:18 +0000 Subject: hg: nashorn/jdk8/nashorn: 8006766: Array-like access to characters of a string is slow Message-ID: <20130125163719.D4AC247561@hg.openjdk.java.net> Changeset: f52d7294536f Author: hannesw Date: 2013-01-25 17:35 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/f52d7294536f 8006766: Array-like access to characters of a string is slow Reviewed-by: lagergren, attila ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/objects/NativeBoolean.java ! src/jdk/nashorn/internal/objects/NativeJSAdapter.java ! src/jdk/nashorn/internal/objects/NativeJavaImporter.java ! src/jdk/nashorn/internal/objects/NativeNumber.java ! src/jdk/nashorn/internal/objects/NativeString.java ! src/jdk/nashorn/internal/runtime/GlobalObject.java ! src/jdk/nashorn/internal/runtime/NativeJavaPackage.java ! src/jdk/nashorn/internal/runtime/ScriptFunction.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/WithObject.java ! src/jdk/nashorn/internal/runtime/linker/NashornLinker.java ! src/jdk/nashorn/internal/runtime/linker/NashornPrimitiveLinker.java ! src/jdk/nashorn/internal/runtime/linker/PrimitiveLookup.java From sundararajan.athijegannathan at oracle.com Mon Jan 28 03:25:03 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Mon, 28 Jan 2013 16:55:03 +0530 Subject: Review request JDK-8006983: Introduce a command line option to switch off syntactic extensions of nashorn Message-ID: <5106600F.5020809@oracle.com> Hi, Please review http://cr.openjdk.java.net/~sundar/8006983/ Thanks -Sundar From marcus.lagergren at oracle.com Mon Jan 28 04:01:31 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Mon, 28 Jan 2013 13:01:31 +0100 Subject: Review request JDK-8006983: Introduce a command line option to switch off syntactic extensions of nashorn In-Reply-To: <5106600F.5020809@oracle.com> References: <5106600F.5020809@oracle.com> Message-ID: <245003E5-7500-450C-8E4B-C5D5140F5BCF@oracle.com> +1 On Jan 28, 2013, at 12:25 PM, A. Sundararajan wrote: > Hi, > > Please review http://cr.openjdk.java.net/~sundar/8006983/ > > Thanks > -Sundar From attila.szegedi at oracle.com Mon Jan 28 04:10:16 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Mon, 28 Jan 2013 13:10:16 +0100 Subject: Review request JDK-8006983: Introduce a command line option to switch off syntactic extensions of nashorn In-Reply-To: <5106600F.5020809@oracle.com> References: <5106600F.5020809@oracle.com> Message-ID: <69A43FC5-1C3A-4D60-BAA0-AD669F561E95@oracle.com> +1 On Jan 28, 2013, at 12:25 PM, "A. Sundararajan" wrote: > Hi, > > Please review http://cr.openjdk.java.net/~sundar/8006983/ > > Thanks > -Sundar From sundararajan.athijegannathan at oracle.com Mon Jan 28 04:40:37 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Mon, 28 Jan 2013 12:40:37 +0000 Subject: hg: nashorn/jdk8/nashorn: 8006983: Introduce a command line option to switch off syntactic extensions of nashorn Message-ID: <20130128124039.459E7475B6@hg.openjdk.java.net> Changeset: 8f7a86f82376 Author: sundar Date: 2013-01-28 18:10 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/8f7a86f82376 8006983: Introduce a command line option to switch off syntactic extensions of nashorn Reviewed-by: lagergren, attila ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/parser/Parser.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/ScriptingFunctions.java ! src/jdk/nashorn/internal/runtime/resources/Options.properties + test/script/basic/JDK-8006983.js ! test/script/basic/scripting.js ! test/script/basic/scripting.js.EXPECTED From sundararajan.athijegannathan at oracle.com Mon Jan 28 07:59:33 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Mon, 28 Jan 2013 15:59:33 +0000 Subject: hg: nashorn/jdk8/nashorn: 8007004: nashorn script engine should not use thread context class loader as script 'application loader' Message-ID: <20130128155934.5E71A475B9@hg.openjdk.java.net> Changeset: 265c46dbcf43 Author: sundar Date: 2013-01-28 21:29 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/265c46dbcf43 8007004: nashorn script engine should not use thread context class loader as script 'application loader' Reviewed-by: attila, hannesw ! src/jdk/nashorn/api/scripting/NashornScriptEngine.java ! src/jdk/nashorn/api/scripting/NashornScriptEngineFactory.java From james.laskey at oracle.com Mon Jan 28 12:32:58 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Mon, 28 Jan 2013 20:32:58 +0000 Subject: hg: nashorn/jdk8/nashorn: 8006676: Integrate Nashorn into new build system Message-ID: <20130128203258.A6C9147623@hg.openjdk.java.net> Changeset: b6c69beebde6 Author: jlaskey Date: 2013-01-28 16:22 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/b6c69beebde6 8006676: Integrate Nashorn into new build system Reviewed-by: jlaskey Contributed-by: james.laskey at oracle.com ! make/Makefile + makefiles/BuildNashorn.gmk + makefiles/Makefile From james.laskey at oracle.com Mon Jan 28 13:23:29 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Mon, 28 Jan 2013 21:23:29 +0000 Subject: hg: nashorn/jdk8/jaxp: 19 new changesets Message-ID: <20130128212417.191AF47629@hg.openjdk.java.net> Changeset: b1fdb101c82e Author: joehw Date: 2012-12-14 13:24 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxp/rev/b1fdb101c82e 8003260: [findbug] some fields should be package protected Summary: change public or protected mutable static fields to private or package private. Reviewed-by: lancea ! src/com/sun/org/apache/xerces/internal/impl/XMLDocumentFragmentScannerImpl.java ! src/com/sun/org/apache/xerces/internal/impl/XMLEntityScanner.java Changeset: 8a20e948b806 Author: lana Date: 2012-12-16 22:05 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxp/rev/8a20e948b806 Merge Changeset: 15b32367b23c Author: joehw Date: 2012-12-18 21:11 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxp/rev/15b32367b23c 8003261: static field is public but not final Summary: add final to fVersion field, and make it a non-compile time constant. Reviewed-by: hawtin, lancea, dholmes, chegar ! src/com/sun/org/apache/xerces/internal/impl/Version.java Changeset: d4aea0225e80 Author: joehw Date: 2012-12-27 18:17 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxp/rev/d4aea0225e80 8005473: Warnings compiling jaxp Summary: clean up compiling warnings. Reviewed-by: weijun, chegar, forax ! src/com/sun/org/apache/xalan/internal/xslt/EnvironmentCheck.java ! src/javax/xml/transform/FactoryFinder.java ! src/javax/xml/validation/SchemaFactoryFinder.java ! src/javax/xml/xpath/XPathFactoryFinder.java Changeset: 27421008f050 Author: katleman Date: 2012-12-20 09:18 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxp/rev/27421008f050 Added tag jdk8-b69 for changeset 789a855de959 ! .hgtags Changeset: a72c8391cdd6 Author: katleman Date: 2012-12-20 16:23 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxp/rev/a72c8391cdd6 8004982: JDK8 source with GPL header errors Reviewed-by: ohair ! src/com/sun/org/apache/xalan/internal/XalanConstants.java ! src/com/sun/org/apache/xalan/internal/utils/FactoryImpl.java Changeset: 6ec9edffc286 Author: katleman Date: 2012-12-26 14:23 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxp/rev/6ec9edffc286 Merge Changeset: 63815efd132f Author: katleman Date: 2012-12-27 12:15 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxp/rev/63815efd132f Added tag jdk8-b70 for changeset 6ec9edffc286 ! .hgtags Changeset: 499be952a291 Author: lana Date: 2012-12-28 18:31 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxp/rev/499be952a291 Merge Changeset: 47738fa4d411 Author: dbuck Date: 2013-01-10 20:26 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxp/rev/47738fa4d411 8003147: port fix for BCEL bug 39695 Summary: Added support for Local Variable Type Table so that BCEL library can be used to modify methods with generics-related debug data without violating class file format Reviewed-by: lancea ! src/com/sun/org/apache/bcel/internal/Constants.java ! src/com/sun/org/apache/bcel/internal/classfile/Attribute.java ! src/com/sun/org/apache/bcel/internal/classfile/DescendingVisitor.java ! src/com/sun/org/apache/bcel/internal/classfile/EmptyVisitor.java + src/com/sun/org/apache/bcel/internal/classfile/LocalVariableTypeTable.java ! src/com/sun/org/apache/bcel/internal/classfile/Visitor.java ! src/com/sun/org/apache/bcel/internal/generic/MethodGen.java Changeset: bdf2af722a6b Author: katleman Date: 2013-01-03 12:44 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxp/rev/bdf2af722a6b Added tag jdk8-b71 for changeset 499be952a291 ! .hgtags Changeset: 84946404d1e1 Author: katleman Date: 2013-01-10 09:55 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxp/rev/84946404d1e1 Added tag jdk8-b72 for changeset bdf2af722a6b ! .hgtags Changeset: 06827097cdd3 Author: lana Date: 2013-01-16 12:06 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxp/rev/06827097cdd3 Merge Changeset: cf0917c0d771 Author: katleman Date: 2013-01-16 11:59 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxp/rev/cf0917c0d771 Added tag jdk8-b73 for changeset 84946404d1e1 ! .hgtags Changeset: 278a2f60c55b Author: erikj Date: 2013-01-04 11:31 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxp/rev/278a2f60c55b 8005575: build-infra: Three JCK tests fails on Solaris with new RE Autoconf-Based build Reviewed-by: ohair ! makefiles/BuildJaxp.gmk Changeset: 2e4d87e6662e Author: katleman Date: 2013-01-08 13:14 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxp/rev/2e4d87e6662e Merge Changeset: a317d3e1bbac Author: katleman Date: 2013-01-15 10:07 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxp/rev/a317d3e1bbac Merge Changeset: 2087e24a4357 Author: katleman Date: 2013-01-16 22:17 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxp/rev/2087e24a4357 Merge Changeset: 4e049aa2495f Author: lana Date: 2013-01-20 23:37 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxp/rev/4e049aa2495f Merge From bryan.atsatt at oracle.com Mon Jan 28 13:29:06 2013 From: bryan.atsatt at oracle.com (Bryan Atsatt) Date: Mon, 28 Jan 2013 13:29:06 -0800 Subject: hg: nashorn/jdk8/nashorn: 8007004: nashorn script engine should not use thread context class loader as script 'application loader' In-Reply-To: <20130128155934.5E71A475B9@hg.openjdk.java.net> References: <20130128155934.5E71A475B9@hg.openjdk.java.net> Message-ID: <5106EDA2.7000207@oracle.com> There needs to be some way to control the loader used here, this change will break us. This change requires that a SecurityManager is installed in order to get the caller's loader, but that will be a rare condition (:^). Even if that restriction was removed, this still wouldn't work for our project: we need to be able to specify a loader other than our own (a child). With the current code, we simply set the TCL and everything works fine. If that needs to change for some reason, can you please find another way for us to pass the loader? // Bryan On 1/28/2013 7:59 AM, sundararajan.athijegannathan at oracle.com wrote: > Changeset: 265c46dbcf43 > Author: sundar > Date: 2013-01-28 21:29 +0530 > URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/265c46dbcf43 > > 8007004: nashorn script engine should not use thread context class loader as script 'application loader' > Reviewed-by: attila, hannesw > > ! src/jdk/nashorn/api/scripting/NashornScriptEngine.java > ! src/jdk/nashorn/api/scripting/NashornScriptEngineFactory.java > > From james.laskey at oracle.com Mon Jan 28 13:25:15 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Mon, 28 Jan 2013 21:25:15 +0000 Subject: hg: nashorn/jdk8/langtools: 82 new changesets Message-ID: <20130128212832.48CC74762A@hg.openjdk.java.net> Changeset: c78acf6c2f3e Author: mcimadamore Date: 2012-12-10 12:10 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/c78acf6c2f3e 8004094: Javac compiler error - synthetic method accessor generated with duplicate name Summary: method clash check logic should skip methods marked with ACC_SYNTHETIC Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/generics/8004094/B.java + test/tools/javac/generics/8004094/T8004094.java Changeset: fcf89720ae71 Author: vromero Date: 2012-12-10 16:21 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/fcf89720ae71 8003967: detect and remove all mutable implicit static enum fields in langtools Reviewed-by: jjg ! src/share/classes/com/sun/tools/classfile/Opcode.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocFileFactory.java ! src/share/classes/com/sun/tools/javac/Server.java ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/code/Kinds.java ! src/share/classes/com/sun/tools/javac/code/Lint.java ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/code/TargetType.java ! src/share/classes/com/sun/tools/javac/code/TypeTag.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/ConstFold.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/file/ZipFileIndex.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/jvm/Target.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/main/Option.java ! src/share/classes/com/sun/tools/javac/parser/JavaTokenizer.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/util/BaseFileManager.java ! src/share/classes/com/sun/tools/javac/util/List.java ! src/share/classes/com/sun/tools/javac/util/MandatoryWarningHandler.java ! src/share/classes/com/sun/tools/javac/util/RichDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javah/JavahTask.java ! src/share/classes/com/sun/tools/javap/JavapTask.java ! src/share/classes/javax/lang/model/element/Modifier.java ! src/share/classes/javax/lang/model/util/ElementFilter.java ! src/share/classes/javax/tools/StandardLocation.java + test/tools/javac/T8003967/DetectMutableStaticFields.java Changeset: cfde9737131e Author: jjg Date: 2012-12-11 15:05 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/cfde9737131e 8004828: refactor init of *DocImpl classes Reviewed-by: darcy ! src/share/classes/com/sun/tools/javadoc/AnnotationTypeDocImpl.java ! src/share/classes/com/sun/tools/javadoc/AnnotationTypeElementDocImpl.java ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java ! src/share/classes/com/sun/tools/javadoc/ConstructorDocImpl.java ! src/share/classes/com/sun/tools/javadoc/DocEnv.java ! src/share/classes/com/sun/tools/javadoc/DocImpl.java ! src/share/classes/com/sun/tools/javadoc/ExecutableMemberDocImpl.java ! src/share/classes/com/sun/tools/javadoc/FieldDocImpl.java ! src/share/classes/com/sun/tools/javadoc/JavadocEnter.java ! src/share/classes/com/sun/tools/javadoc/JavadocMemberEnter.java ! src/share/classes/com/sun/tools/javadoc/MemberDocImpl.java ! src/share/classes/com/sun/tools/javadoc/MethodDocImpl.java ! src/share/classes/com/sun/tools/javadoc/PackageDocImpl.java ! src/share/classes/com/sun/tools/javadoc/ProgramElementDocImpl.java ! src/share/classes/com/sun/tools/javadoc/RootDocImpl.java Changeset: 170e486632d9 Author: jlahoda Date: 2012-12-12 20:26 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/170e486632d9 8004504: ListBuffer could reuse List.nil() as the sentinel element Summary: ListBuffer.last now points to the last elements with client data, or null if none. Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/util/ListBuffer.java + test/tools/javac/util/list/ListBufferTest.java Changeset: 376d6c1b49e5 Author: jfranck Date: 2012-12-03 11:16 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/376d6c1b49e5 8001114: Container annotation is not checked for semantic correctness Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Annotations.java ! src/share/classes/com/sun/tools/javac/comp/Annotate.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/tools/javac/annotations/repeatingAnnotations/MissingDefaultCase1.java ! test/tools/javac/annotations/repeatingAnnotations/MissingDefaultCase1.out ! test/tools/javac/annotations/repeatingAnnotations/MissingDefaultCase2.java ! test/tools/javac/annotations/repeatingAnnotations/MissingDefaultCase2.out ! test/tools/javac/annotations/repeatingAnnotations/NoRepeatableAnno.out + test/tools/javac/annotations/repeatingAnnotations/RepeatingTargetNotAllowed.java + test/tools/javac/annotations/repeatingAnnotations/RepeatingTargetNotAllowed.out ! test/tools/javac/diags/examples/ContainedByNonDefault.java + test/tools/javac/diags/examples/InvalidDuplicateAnnotation.java Changeset: 37a5d7eccb87 Author: vromero Date: 2012-12-14 11:16 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/37a5d7eccb87 8004976: test/tools/javac/7153958/CPoolRefClassContainingInlinedCts.java can fail Reviewed-by: jjg, mcimadamore ! test/tools/javac/7153958/CPoolRefClassContainingInlinedCts.java Changeset: de1ec6fc93fe Author: vromero Date: 2012-12-15 13:54 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/de1ec6fc93fe 8000518: Javac generates duplicate name_and_type constant pool entry for class BinaryOpValueExp.java Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java ! src/share/classes/com/sun/tools/javac/jvm/ClassFile.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/jvm/Pool.java ! src/share/classes/com/sun/tools/javac/sym/CreateSymbols.java + test/tools/javac/8000518/DuplicateConstantPoolEntry.java ! test/tools/javac/lambda/TestInvokeDynamic.java Changeset: f72dc656a306 Author: lana Date: 2012-12-16 22:10 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/f72dc656a306 Merge Changeset: 02a18f209ab3 Author: vromero Date: 2012-12-17 14:54 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/02a18f209ab3 8004814: javadoc should be able to detect default methods Reviewed-by: jjg Contributed-by: maurizio.cimadamore at oracle.com ! src/share/classes/com/sun/javadoc/ClassDoc.java ! src/share/classes/com/sun/javadoc/MethodDoc.java ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java ! src/share/classes/com/sun/tools/javadoc/MethodDocImpl.java Changeset: 75ab654b5cd5 Author: jjg Date: 2012-12-17 07:47 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/75ab654b5cd5 8004832: Add new doclint package Reviewed-by: mcimadamore ! make/build.properties ! src/share/classes/com/sun/source/util/DocTrees.java ! src/share/classes/com/sun/source/util/JavacTask.java ! src/share/classes/com/sun/source/util/TreePath.java + src/share/classes/com/sun/tools/doclint/Checker.java + src/share/classes/com/sun/tools/doclint/DocLint.java + src/share/classes/com/sun/tools/doclint/Entity.java + src/share/classes/com/sun/tools/doclint/Env.java + src/share/classes/com/sun/tools/doclint/HtmlTag.java + src/share/classes/com/sun/tools/doclint/Messages.java + src/share/classes/com/sun/tools/doclint/resources/doclint.properties ! src/share/classes/com/sun/tools/javac/api/BasicJavacTask.java ! src/share/classes/com/sun/tools/javac/api/JavacTaskImpl.java ! src/share/classes/com/sun/tools/javac/api/JavacTrees.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/model/JavacTypes.java ! src/share/classes/com/sun/tools/javac/parser/DocCommentParser.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/tree/DCTree.java ! src/share/classes/com/sun/tools/javac/tree/DocPretty.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java + test/tools/doclint/AccessTest.java + test/tools/doclint/AccessTest.package.out + test/tools/doclint/AccessTest.private.out + test/tools/doclint/AccessTest.protected.out + test/tools/doclint/AccessTest.public.out + test/tools/doclint/AccessibilityTest.java + test/tools/doclint/AccessibilityTest.out + test/tools/doclint/DocLintTester.java + test/tools/doclint/EmptyAuthorTest.java + test/tools/doclint/EmptyAuthorTest.out + test/tools/doclint/EmptyExceptionTest.java + test/tools/doclint/EmptyExceptionTest.out + test/tools/doclint/EmptyParamTest.java + test/tools/doclint/EmptyParamTest.out + test/tools/doclint/EmptyReturnTest.java + test/tools/doclint/EmptyReturnTest.out + test/tools/doclint/EmptySerialDataTest.java + test/tools/doclint/EmptySerialDataTest.out + test/tools/doclint/EmptySerialFieldTest.java + test/tools/doclint/EmptySerialFieldTest.out + test/tools/doclint/EmptySinceTest.java + test/tools/doclint/EmptySinceTest.out + test/tools/doclint/EmptyVersionTest.java + test/tools/doclint/EmptyVersionTest.out + test/tools/doclint/HtmlAttrsTest.java + test/tools/doclint/HtmlAttrsTest.out + test/tools/doclint/HtmlTagsTest.java + test/tools/doclint/HtmlTagsTest.out + test/tools/doclint/MissingCommentTest.java + test/tools/doclint/MissingCommentTest.out + test/tools/doclint/MissingParamsTest.java + test/tools/doclint/MissingParamsTest.out + test/tools/doclint/MissingReturnTest.java + test/tools/doclint/MissingReturnTest.out + test/tools/doclint/MissingThrowsTest.java + test/tools/doclint/MissingThrowsTest.out + test/tools/doclint/OptionTest.java + test/tools/doclint/OverridesTest.java + test/tools/doclint/ReferenceTest.java + test/tools/doclint/ReferenceTest.out + test/tools/doclint/RunTest.java + test/tools/doclint/SyntaxTest.java + test/tools/doclint/SyntaxTest.out + test/tools/doclint/SyntheticTest.java + test/tools/doclint/ValidTest.java + test/tools/doclint/tidy/AnchorAlreadyDefined.java + test/tools/doclint/tidy/AnchorAlreadyDefined.out + test/tools/doclint/tidy/BadEnd.java + test/tools/doclint/tidy/BadEnd.out + test/tools/doclint/tidy/InsertImplicit.java + test/tools/doclint/tidy/InsertImplicit.out + test/tools/doclint/tidy/InvalidEntity.java + test/tools/doclint/tidy/InvalidEntity.out + test/tools/doclint/tidy/InvalidName.java + test/tools/doclint/tidy/InvalidName.out + test/tools/doclint/tidy/InvalidTag.java + test/tools/doclint/tidy/InvalidTag.out + test/tools/doclint/tidy/InvalidURI.java + test/tools/doclint/tidy/InvalidURI.out + test/tools/doclint/tidy/MissingGT.java + test/tools/doclint/tidy/MissingGT.out + test/tools/doclint/tidy/MissingTag.java + test/tools/doclint/tidy/MissingTag.out + test/tools/doclint/tidy/NestedTag.java + test/tools/doclint/tidy/NestedTag.out + test/tools/doclint/tidy/ParaInPre.java + test/tools/doclint/tidy/ParaInPre.out + test/tools/doclint/tidy/README.txt + test/tools/doclint/tidy/RepeatedAttr.java + test/tools/doclint/tidy/RepeatedAttr.out + test/tools/doclint/tidy/TextNotAllowed.java + test/tools/doclint/tidy/TextNotAllowed.out + test/tools/doclint/tidy/TrimmingEmptyTag.java + test/tools/doclint/tidy/TrimmingEmptyTag.out + test/tools/doclint/tidy/UnescapedOrUnknownEntity.java + test/tools/doclint/tidy/UnescapedOrUnknownEntity.out + test/tools/doclint/tidy/util/Main.java + test/tools/doclint/tidy/util/tidy.sh + test/tools/javac/diags/examples/NoContent.java Changeset: f20568328a57 Author: mcimadamore Date: 2012-12-17 16:13 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/f20568328a57 8004099: Bad compiler diagnostic generated when poly expression is passed to non-existent method Summary: Some code paths in resolve do not use methodArguments to correctly format actuals Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java + test/tools/javac/lambda/BadMethodCall2.java + test/tools/javac/lambda/BadMethodCall2.out Changeset: 064e372f273d Author: jjg Date: 2012-12-17 10:55 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/064e372f273d 8004961: rename Plugin.call to Plugin.init Reviewed-by: mcimadamore ! src/share/classes/com/sun/source/util/Plugin.java ! src/share/classes/com/sun/tools/javac/main/Main.java ! test/tools/javac/plugin/showtype/ShowTypePlugin.java ! test/tools/javac/plugin/showtype/Test.java Changeset: ef537bcc825a Author: mchung Date: 2012-12-17 15:19 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/ef537bcc825a 8005137: Rename DocLint.call to DocLint.init which overrides Plugin.init Reviewed-by: darcy, jjh ! src/share/classes/com/sun/tools/doclint/DocLint.java Changeset: bc74006c2d8d Author: darcy Date: 2012-12-18 00:24 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/bc74006c2d8d 8005046: Provide checking for a default method in javax.lang.model Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/javax/lang/model/element/ExecutableElement.java + test/tools/javac/processing/model/element/TestExecutableElement.java Changeset: 92fcf299cd09 Author: ohrstrom Date: 2012-12-18 10:23 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/92fcf299cd09 8004657: Add hooks to javac to enable reporting dependency information. Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/tools/javac/api/JavacTool.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java Changeset: 250f0acf880c Author: mcimadamore Date: 2012-12-18 22:16 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/250f0acf880c 8005193: New regression test test/tools/javac/lambda/BadMethodCall2.java fails Summary: Bad golden file in negative test Reviewed-by: jjh ! test/tools/javac/lambda/BadMethodCall2.out Changeset: d7360bf35ee1 Author: lana Date: 2012-12-14 13:15 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/d7360bf35ee1 Merge Changeset: 573b38691a74 Author: lana Date: 2012-12-18 18:15 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/573b38691a74 Merge Changeset: 67b01d295cd2 Author: jjg Date: 2012-12-19 11:29 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/67b01d295cd2 8004833: Integrate doclint support into javac Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/main/Main.java ! src/share/classes/com/sun/tools/javac/main/Option.java ! src/share/classes/com/sun/tools/javac/resources/javac.properties + test/tools/javac/doclint/DocLintTest.java Changeset: f72c9c5aeaef Author: jfranck Date: 2012-12-16 11:09 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/f72c9c5aeaef 8005098: Provide isSynthesized() information on Attribute.Compound Reviewed-by: jjg ! make/build.properties ! src/share/classes/com/sun/tools/javac/code/Attribute.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/comp/Annotate.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java ! src/share/classes/com/sun/tools/javadoc/PackageDocImpl.java ! src/share/classes/com/sun/tools/javadoc/ParameterImpl.java ! src/share/classes/com/sun/tools/javadoc/ProgramElementDocImpl.java Changeset: a22f23fb7abf Author: jjg Date: 2012-12-20 17:59 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/a22f23fb7abf 8005307: fix missing @bug tags Reviewed-by: jjh ! test/tools/doclint/AccessTest.java ! test/tools/doclint/AccessTest.package.out ! test/tools/doclint/AccessTest.private.out ! test/tools/doclint/AccessTest.protected.out ! test/tools/doclint/AccessTest.public.out ! test/tools/doclint/AccessibilityTest.java ! test/tools/doclint/AccessibilityTest.out ! test/tools/doclint/EmptyAuthorTest.java ! test/tools/doclint/EmptyAuthorTest.out ! test/tools/doclint/EmptyExceptionTest.java ! test/tools/doclint/EmptyExceptionTest.out ! test/tools/doclint/EmptyParamTest.java ! test/tools/doclint/EmptyParamTest.out ! test/tools/doclint/EmptyReturnTest.java ! test/tools/doclint/EmptyReturnTest.out ! test/tools/doclint/EmptySerialDataTest.java ! test/tools/doclint/EmptySerialDataTest.out ! test/tools/doclint/EmptySerialFieldTest.java ! test/tools/doclint/EmptySerialFieldTest.out ! test/tools/doclint/EmptySinceTest.java ! test/tools/doclint/EmptySinceTest.out ! test/tools/doclint/EmptyVersionTest.java ! test/tools/doclint/EmptyVersionTest.out ! test/tools/doclint/HtmlAttrsTest.java ! test/tools/doclint/HtmlAttrsTest.out ! test/tools/doclint/HtmlTagsTest.java ! test/tools/doclint/HtmlTagsTest.out ! test/tools/doclint/MissingParamsTest.java ! test/tools/doclint/MissingParamsTest.out ! test/tools/doclint/MissingReturnTest.java ! test/tools/doclint/MissingReturnTest.out ! test/tools/doclint/MissingThrowsTest.java ! test/tools/doclint/MissingThrowsTest.out ! test/tools/doclint/OptionTest.java ! test/tools/doclint/OverridesTest.java ! test/tools/doclint/ReferenceTest.java ! test/tools/doclint/ReferenceTest.out ! test/tools/doclint/RunTest.java ! test/tools/doclint/SyntaxTest.java ! test/tools/doclint/SyntaxTest.out ! test/tools/doclint/SyntheticTest.java ! test/tools/doclint/ValidTest.java ! test/tools/doclint/tidy/AnchorAlreadyDefined.java ! test/tools/doclint/tidy/AnchorAlreadyDefined.out ! test/tools/doclint/tidy/BadEnd.java ! test/tools/doclint/tidy/BadEnd.out ! test/tools/doclint/tidy/InsertImplicit.java ! test/tools/doclint/tidy/InsertImplicit.out ! test/tools/doclint/tidy/InvalidEntity.java ! test/tools/doclint/tidy/InvalidEntity.out ! test/tools/doclint/tidy/InvalidName.java ! test/tools/doclint/tidy/InvalidName.out ! test/tools/doclint/tidy/InvalidTag.java ! test/tools/doclint/tidy/InvalidTag.out ! test/tools/doclint/tidy/InvalidURI.java ! test/tools/doclint/tidy/InvalidURI.out ! test/tools/doclint/tidy/MissingGT.java ! test/tools/doclint/tidy/MissingGT.out ! test/tools/doclint/tidy/MissingTag.java ! test/tools/doclint/tidy/MissingTag.out ! test/tools/doclint/tidy/NestedTag.java ! test/tools/doclint/tidy/NestedTag.out ! test/tools/doclint/tidy/ParaInPre.java ! test/tools/doclint/tidy/ParaInPre.out ! test/tools/doclint/tidy/RepeatedAttr.java ! test/tools/doclint/tidy/RepeatedAttr.out ! test/tools/doclint/tidy/TextNotAllowed.java ! test/tools/doclint/tidy/TextNotAllowed.out ! test/tools/doclint/tidy/TrimmingEmptyTag.java ! test/tools/doclint/tidy/TrimmingEmptyTag.out ! test/tools/doclint/tidy/UnescapedOrUnknownEntity.java ! test/tools/doclint/tidy/UnescapedOrUnknownEntity.out Changeset: b52a38d4536c Author: darcy Date: 2012-12-21 08:45 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/b52a38d4536c 8005282: Use @library tag with non-relative path for javac tests Reviewed-by: jjg ! test/tools/javac/7129225/TestImportStar.java ! test/tools/javac/cast/intersection/model/Model01.java ! test/tools/javac/classreader/T7031108.java ! test/tools/javac/enum/6350057/T6350057.java ! test/tools/javac/enum/6424358/T6424358.java ! test/tools/javac/file/T7018098.java ! test/tools/javac/multicatch/model/ModelChecker.java ! test/tools/javac/options/T7022337.java ! test/tools/javac/processing/6348499/T6348499.java ! test/tools/javac/processing/6359313/T6359313.java ! test/tools/javac/processing/6365040/T6365040.java ! test/tools/javac/processing/6413690/T6413690.java ! test/tools/javac/processing/6414633/T6414633.java ! test/tools/javac/processing/6430209/T6430209.java ! test/tools/javac/processing/6499119/ClassProcessor.java ! test/tools/javac/processing/6511613/clss41701.java ! test/tools/javac/processing/6512707/T6512707.java ! test/tools/javac/processing/6634138/T6634138.java ! test/tools/javac/processing/6994946/SemanticErrorTest.java ! test/tools/javac/processing/6994946/SyntaxErrorTest.java ! test/tools/javac/processing/T6920317.java ! test/tools/javac/processing/T7196462.java ! test/tools/javac/processing/TestWarnErrorCount.java ! test/tools/javac/processing/environment/TestSourceVersion.java ! test/tools/javac/processing/environment/round/TestContext.java ! test/tools/javac/processing/environment/round/TestElementsAnnotatedWith.java ! test/tools/javac/processing/errors/TestErrorCount.java ! test/tools/javac/processing/errors/TestFatalityOfParseErrors.java ! test/tools/javac/processing/errors/TestOptionSyntaxErrors.java ! test/tools/javac/processing/errors/TestParseErrors/TestParseErrors.java ! test/tools/javac/processing/errors/TestReturnCode.java ! test/tools/javac/processing/filer/TestFilerConstraints.java ! test/tools/javac/processing/filer/TestGetResource.java ! test/tools/javac/processing/filer/TestGetResource2.java ! test/tools/javac/processing/filer/TestInvalidRelativeNames.java ! test/tools/javac/processing/filer/TestLastRound.java ! test/tools/javac/processing/filer/TestPackageInfo.java ! test/tools/javac/processing/filer/TestValidRelativeNames.java ! test/tools/javac/processing/messager/6362067/T6362067.java ! test/tools/javac/processing/messager/MessagerBasics.java ! test/tools/javac/processing/model/6194785/T6194785.java ! test/tools/javac/processing/model/6341534/T6341534.java ! test/tools/javac/processing/model/element/TestAnonClassNames.java ! test/tools/javac/processing/model/element/TestElement.java ! test/tools/javac/processing/model/element/TestMissingElement/TestMissingElement.java ! test/tools/javac/processing/model/element/TestMissingElement2/TestMissingClass.java ! test/tools/javac/processing/model/element/TestMissingElement2/TestMissingGenericClass1.java ! test/tools/javac/processing/model/element/TestMissingElement2/TestMissingGenericClass2.java ! test/tools/javac/processing/model/element/TestMissingElement2/TestMissingGenericInterface1.java ! test/tools/javac/processing/model/element/TestMissingElement2/TestMissingGenericInterface2.java ! test/tools/javac/processing/model/element/TestMissingElement2/TestMissingInterface.java ! test/tools/javac/processing/model/element/TestNames.java ! test/tools/javac/processing/model/element/TestPackageElement.java ! test/tools/javac/processing/model/element/TestResourceElement.java ! test/tools/javac/processing/model/element/TestResourceVariable.java ! test/tools/javac/processing/model/element/TestTypeParameter.java ! test/tools/javac/processing/model/element/TypeParamBounds.java ! test/tools/javac/processing/model/type/MirroredTypeEx/OverEager.java ! test/tools/javac/processing/model/type/MirroredTypeEx/Plurality.java ! test/tools/javac/processing/model/type/NoTypes.java ! test/tools/javac/processing/model/type/TestUnionType.java ! test/tools/javac/processing/model/util/BinaryName.java ! test/tools/javac/processing/model/util/GetTypeElemBadArg.java ! test/tools/javac/processing/model/util/NoSupers.java ! test/tools/javac/processing/model/util/OverridesSpecEx.java ! test/tools/javac/processing/model/util/TypesBadArg.java ! test/tools/javac/processing/model/util/deprecation/TestDeprecation.java ! test/tools/javac/processing/model/util/directSupersOfErr/DirectSupersOfErr.java ! test/tools/javac/processing/model/util/elements/TestGetConstantExpression.java ! test/tools/javac/processing/model/util/elements/TestGetPackageOf.java ! test/tools/javac/processing/model/util/filter/TestIterables.java ! test/tools/javac/processing/options/testCommandLineClasses/Test.java ! test/tools/javac/processing/options/testPrintProcessorInfo/Test.java ! test/tools/javac/processing/options/testPrintProcessorInfo/TestWithXstdout.java ! test/tools/javac/processing/warnings/UseImplicit/TestProcUseImplicitWarning.java ! test/tools/javac/processing/werror/WError1.java ! test/tools/javac/processing/werror/WErrorGen.java ! test/tools/javac/processing/werror/WErrorLast.java ! test/tools/javac/resolve/ResolveHarness.java ! test/tools/javac/util/T6597678.java ! test/tools/javac/util/context/T7021650.java Changeset: 189b26e3818f Author: vromero Date: 2012-12-21 15:27 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/189b26e3818f 8003512: javac doesn't work with jar files with >64k entries Reviewed-by: jjg, ksrini Contributed-by: martinrb at google.com ! src/share/classes/com/sun/tools/javac/file/ZipFileIndex.java + test/tools/javac/file/zip/8003512/LoadClassFromJava6CreatedJarTest.java ! test/tools/javac/file/zip/Utils.java Changeset: 690c41cdab55 Author: bpatel Date: 2012-12-25 17:23 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/690c41cdab55 8004893: the javadoc/doclet needs to be updated to accommodate lambda changes Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/resources/standard.properties ! src/share/classes/com/sun/tools/doclets/internal/toolkit/ClassWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ClassBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/doclet.xml ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/MethodTypes.java ! test/com/sun/javadoc/testHtmlTableTags/TestHtmlTableTags.java + test/com/sun/javadoc/testLambdaFeature/TestLambdaFeature.java + test/com/sun/javadoc/testLambdaFeature/pkg/A.java + test/com/sun/javadoc/testLambdaFeature/pkg/B.java ! test/com/sun/javadoc/testMethodTypes/TestMethodTypes.java Changeset: 0c244701188e Author: mchung Date: 2012-12-28 22:25 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/0c244701188e 8003562: Provide a CLI tool to analyze class dependencies Reviewed-by: jjg, alanb, ulfzibis, erikj ! make/build.properties ! makefiles/BuildLangtools.gmk ! src/share/classes/com/sun/tools/classfile/Dependencies.java ! src/share/classes/com/sun/tools/classfile/Dependency.java + src/share/classes/com/sun/tools/jdeps/Archive.java + src/share/classes/com/sun/tools/jdeps/ClassFileReader.java + src/share/classes/com/sun/tools/jdeps/JdepsTask.java + src/share/classes/com/sun/tools/jdeps/Main.java + src/share/classes/com/sun/tools/jdeps/PlatformClassPath.java + src/share/classes/com/sun/tools/jdeps/resources/jdeps.properties + src/share/classes/com/sun/tools/jdeps/resources/jdk.properties + src/share/classes/com/sun/tools/jdeps/resources/version.properties-template ! test/Makefile + test/tools/jdeps/Basic.java + test/tools/jdeps/Test.java + test/tools/jdeps/p/Foo.java Changeset: 31780dd06ec7 Author: jjg Date: 2012-12-29 17:33 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/31780dd06ec7 8004727: Add compiler support for parameter reflection Reviewed-by: jjg Contributed-by: eric.mccorkle at oracle.com ! src/share/classes/com/sun/tools/classfile/Attribute.java ! src/share/classes/com/sun/tools/classfile/ClassWriter.java + src/share/classes/com/sun/tools/classfile/MethodParameters_attribute.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/main/Option.java ! src/share/classes/com/sun/tools/javac/resources/javac.properties ! src/share/classes/com/sun/tools/javac/util/Names.java ! src/share/classes/com/sun/tools/javap/AttributeWriter.java + test/tools/javac/MethodParameters.java + test/tools/javap/MethodParameters.java Changeset: 383bc0fbd759 Author: jjg Date: 2012-12-30 06:17 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/383bc0fbd759 8005195: Doclint regression tests fail on windows Reviewed-by: mcimadamore ! test/tools/doclint/DocLintTester.java Changeset: 2001991b1b40 Author: katleman Date: 2012-12-20 09:18 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/2001991b1b40 Added tag jdk8-b69 for changeset d7360bf35ee1 ! .hgtags Changeset: 7d34e91f66bb Author: katleman Date: 2012-12-20 16:24 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/7d34e91f66bb 8004982: JDK8 source with GPL header errors Reviewed-by: ohair ! make/Makefile-classic ! src/share/classes/javax/lang/model/util/AbstractAnnotationValueVisitor7.java ! src/share/classes/javax/lang/model/util/AbstractTypeVisitor8.java ! src/share/classes/javax/lang/model/util/ElementKindVisitor8.java ! test/tools/javac/StringsInSwitch/StringSwitches.java ! test/tools/javac/api/T6395981.java ! test/tools/javac/defaultMethods/defaultMethodExecution/DefaultMethodRegressionTests.java ! test/tools/javac/diags/examples/DuplicateAnnotation.java ! test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestKinds.java ! test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestSueCase1.java ! test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestSueCase2.java ! test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestSueCase4.java ! test/tools/javac/lambdaShapes/org/openjdk/tests/separate/AttributeInjector.java ! test/tools/javac/lambdaShapes/org/openjdk/tests/separate/ClassFile.java ! test/tools/javac/lambdaShapes/org/openjdk/tests/separate/ClassFilePreprocessor.java ! test/tools/javac/lambdaShapes/org/openjdk/tests/separate/ClassToInterfaceConverter.java ! test/tools/javac/lambdaShapes/org/openjdk/tests/separate/Compiler.java ! test/tools/javac/lambdaShapes/org/openjdk/tests/separate/DirectedClassLoader.java ! test/tools/javac/lambdaShapes/org/openjdk/tests/separate/SourceModel.java ! test/tools/javac/lambdaShapes/org/openjdk/tests/separate/TestHarness.java ! test/tools/javac/lambdaShapes/org/openjdk/tests/vm/DefaultMethodsTest.java ! test/tools/javac/lambdaShapes/org/openjdk/tests/vm/FDSeparateCompilationTest.java ! test/tools/javac/nativeHeaders/javahComparison/CompareTest.java ! test/tools/javac/processing/model/util/deprecation/TestDeprecation.java Changeset: 47f71d7c124f Author: katleman Date: 2012-12-26 14:25 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/47f71d7c124f Merge Changeset: 7d5032c2d747 Author: katleman Date: 2012-12-27 12:15 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/7d5032c2d747 Added tag jdk8-b70 for changeset 47f71d7c124f ! .hgtags Changeset: 467e4d9281bc Author: lana Date: 2012-12-28 18:39 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/467e4d9281bc Merge ! test/tools/javac/processing/model/util/deprecation/TestDeprecation.java Changeset: 1d8438db45f2 Author: lana Date: 2013-01-01 17:50 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/1d8438db45f2 Merge Changeset: 0e17c3c23e3b Author: bpatel Date: 2013-01-04 23:06 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/0e17c3c23e3b 8004891: Check for abstract method in javadoc does not conform to the language model Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/javadoc/MethodDocImpl.java + test/com/sun/javadoc/testAbstractMethod/TestAbstractMethod.java + test/com/sun/javadoc/testAbstractMethod/pkg/A.java + test/com/sun/javadoc/testAbstractMethod/pkg/B.java + test/com/sun/javadoc/testAbstractMethod/pkg/C.java Changeset: 8c0c63a6e3b7 Author: bpatel Date: 2013-01-05 00:55 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/8c0c63a6e3b7 8005092: javadoc should check for synthesized bit on an annotation Reviewed-by: jjg ! src/share/classes/com/sun/javadoc/AnnotationDesc.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/javadoc/AnnotationDescImpl.java + test/com/sun/javadoc/testRepeatedAnnotations/TestRepeatedAnnotations.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg/C.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg/ContaineeRegDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg/ContaineeSynthDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg/ContainerRegDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg/ContainerRegNotDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg/ContainerSynthDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg/D.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg/NonSynthDocContainer.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg/RegArryDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg/RegContaineeDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg/RegContaineeNotDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg/RegContainerDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg/RegContainerNotDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg/RegDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg1/C.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg1/ContaineeNotDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg1/ContaineeSynthDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg1/ContainerSynthNotDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg1/ContainerValDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg1/ContainerValNotDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg1/RegContaineeDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg1/RegContaineeNotDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg1/RegContainerValDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg1/RegContainerValNotDoc.java Changeset: a9cb93cca229 Author: jjh Date: 2013-01-07 17:51 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/a9cb93cca229 8005647: langtools/test/tools/javap/MethodParameters.java fails on windows Summary: Fix javap to not output \r\r\n Reviewed-by: jjg ! src/share/classes/com/sun/tools/javap/ClassWriter.java ! test/tools/javac/MethodParameters.java ! test/tools/javap/MethodParameters.java Changeset: 38d3d1027f5a Author: mcimadamore Date: 2013-01-08 10:15 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/38d3d1027f5a 8005243: Restructure method check code to allow pluggable checkers Summary: Add interface to perform a method check - to be implemented by helper classes Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java Changeset: db91d860156a Author: mcimadamore Date: 2013-01-08 10:16 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/db91d860156a 8005179: Cleanup Resolve.AmbiguityError Summary: Linearize nested ambiguity errors Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! test/tools/javac/lambda/TargetType21.java ! test/tools/javac/lambda/TargetType21.out Changeset: d07340b61e6a Author: mcimadamore Date: 2013-01-08 10:17 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/d07340b61e6a 8005184: Restructure DeferredAttr to allow pluggable deferred type completers Summary: Add hooks to generalize deferred type completion via custom helper objects Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java Changeset: 954541f13717 Author: vromero Date: 2013-01-08 13:47 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/954541f13717 8005167: execution time of combo tests in javac should be improved Reviewed-by: jjg, jjh ! test/tools/javac/Diagnostics/6769027/T6769027.java ! test/tools/javac/T7093325.java ! test/tools/javac/cast/intersection/IntersectionTypeCastTest.java ! test/tools/javac/defaultMethods/super/TestDefaultSuperCall.java ! test/tools/javac/failover/CheckAttributedTree.java ! test/tools/javac/generics/diamond/7046778/DiamondAndInnerClassTest.java ! test/tools/javac/generics/rawOverride/7062745/GenericOverrideTest.java ! test/tools/javac/lambda/FunctionalInterfaceConversionTest.java ! test/tools/javac/lambda/LambdaParserTest.java ! test/tools/javac/lambda/MethodReferenceParserTest.java ! test/tools/javac/lambda/TestInvokeDynamic.java ! test/tools/javac/lambda/mostSpecific/StructuralMostSpecificTest.java ! test/tools/javac/lambda/typeInference/combo/TypeInferenceComboTest.java + test/tools/javac/lib/JavacTestingAbstractThreadedTest.java ! test/tools/javac/multicatch/7030606/DisjunctiveTypeWellFormednessTest.java ! test/tools/javac/varargs/7042566/T7042566.java ! test/tools/javac/varargs/warning/Warn4.java ! test/tools/javac/varargs/warning/Warn5.java Changeset: d2eb08b3f64f Author: jjg Date: 2013-01-09 10:26 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/d2eb08b3f64f 8005644: set default max errs and max warns Reviewed-by: darcy ! src/share/classes/com/sun/tools/javadoc/Messager.java + test/tools/javadoc/MaxWarns.java Changeset: 7612fe48be90 Author: darcy Date: 2013-01-09 20:02 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/7612fe48be90 8004730: Add language model support for parameter reflection Reviewed-by: abuckley ! src/share/classes/javax/lang/model/element/Element.java ! src/share/classes/javax/lang/model/element/VariableElement.java ! src/share/classes/javax/lang/model/element/package-info.java Changeset: d462da465da6 Author: jjg Date: 2013-01-10 14:09 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/d462da465da6 8006037: extra space in javac -help for -J and @ options Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/main/Option.java + test/tools/javac/main/Option_J_At_Test.java Changeset: 7d2f628f04f1 Author: jjg Date: 2013-01-10 15:48 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/7d2f628f04f1 8006033: bug in Pretty.toSimpleString Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/tree/Pretty.java + test/tools/javac/tree/PrettySimpleStringTest.java Changeset: fc4cb1577ad6 Author: jjg Date: 2013-01-10 19:38 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/fc4cb1577ad6 8004834: Add doclint support into javadoc Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/ConfigurationImpl.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/doclets.properties ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/MessageRetriever.java ! src/share/classes/com/sun/tools/javac/comp/Enter.java ! src/share/classes/com/sun/tools/javadoc/DocEnv.java ! src/share/classes/com/sun/tools/javadoc/DocImpl.java ! src/share/classes/com/sun/tools/javadoc/JavadocMemberEnter.java ! src/share/classes/com/sun/tools/javadoc/RootDocImpl.java ! test/com/sun/javadoc/5093723/T5093723.java ! test/com/sun/javadoc/testBadSourceFile/TestBadSourceFile.java ! test/com/sun/javadoc/testHtmlDefinitionListTag/TestHtmlDefinitionListTag.java ! test/com/sun/javadoc/testNewLanguageFeatures/TestNewLanguageFeatures.java ! test/com/sun/javadoc/testReturnTag/TestReturnTag.java ! test/com/sun/javadoc/testTagInheritence/TestTagInheritence.java ! test/com/sun/javadoc/testTagMisuse/TestTagMisuse.java ! test/com/sun/javadoc/testValueTag/TestValueTag.java ! test/com/sun/javadoc/testWarnBadParamNames/TestWarnBadParamNames.java ! test/com/sun/javadoc/testWarnings/TestWarnings.java ! test/tools/javadoc/6958836/Test.java ! test/tools/javadoc/6964914/Test.java ! test/tools/javadoc/6964914/TestStdDoclet.java ! test/tools/javadoc/MaxWarns.java ! test/tools/javadoc/T6551367.java + test/tools/javadoc/doclint/DocLintTest.java Changeset: 9f42a06a49c0 Author: jfranck Date: 2013-01-14 19:52 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/9f42a06a49c0 7193719: Support repeating annotations in javax.lang.model Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/model/JavacElements.java ! src/share/classes/javax/lang/model/element/Element.java Changeset: df694c775e8a Author: jjg Date: 2013-01-14 13:50 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/df694c775e8a 8006119: update javac to follow latest spec for repeatable annotations Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/code/Annotations.java ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/comp/Annotate.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/model/JavacElements.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/com/sun/javadoc/testRepeatedAnnotations/pkg/ContaineeSynthDoc.java ! test/com/sun/javadoc/testRepeatedAnnotations/pkg/ContainerSynthDoc.java ! test/com/sun/javadoc/testRepeatedAnnotations/pkg1/ContaineeSynthDoc.java ! test/com/sun/javadoc/testRepeatedAnnotations/pkg1/ContainerSynthNotDoc.java ! test/tools/javac/annotations/repeatingAnnotations/BaseAnnoAsContainerAnno.java ! test/tools/javac/annotations/repeatingAnnotations/BaseAnnoAsContainerAnno.out ! test/tools/javac/annotations/repeatingAnnotations/BasicRepeatingAnnotations.java ! test/tools/javac/annotations/repeatingAnnotations/CheckTargets.java ! test/tools/javac/annotations/repeatingAnnotations/ClassReaderDefault.java ! test/tools/javac/annotations/repeatingAnnotations/ContainerHasRepeatedContained.java ! test/tools/javac/annotations/repeatingAnnotations/CyclicAnnotation.java ! test/tools/javac/annotations/repeatingAnnotations/CyclicAnnotation.out ! test/tools/javac/annotations/repeatingAnnotations/DefaultCasePresent.java ! test/tools/javac/annotations/repeatingAnnotations/DelayRepeatedContainer.java ! test/tools/javac/annotations/repeatingAnnotations/DocumentedContainerAnno.java ! test/tools/javac/annotations/repeatingAnnotations/DocumentedContainerAnno.out ! test/tools/javac/annotations/repeatingAnnotations/InheritedContainerAnno.java ! test/tools/javac/annotations/repeatingAnnotations/InheritedContainerAnno.out ! test/tools/javac/annotations/repeatingAnnotations/InvalidTarget.java - test/tools/javac/annotations/repeatingAnnotations/MissingContainedBy.java ! test/tools/javac/annotations/repeatingAnnotations/MissingContainer.java ! test/tools/javac/annotations/repeatingAnnotations/MissingContainer.out - test/tools/javac/annotations/repeatingAnnotations/MissingContainerFor.java ! test/tools/javac/annotations/repeatingAnnotations/MissingDefaultCase1.java ! test/tools/javac/annotations/repeatingAnnotations/MissingDefaultCase1.out ! test/tools/javac/annotations/repeatingAnnotations/MissingDefaultCase2.java ! test/tools/javac/annotations/repeatingAnnotations/MissingDefaultCase2.out ! test/tools/javac/annotations/repeatingAnnotations/MissingValueMethod.java ! test/tools/javac/annotations/repeatingAnnotations/MissingValueMethod.out ! test/tools/javac/annotations/repeatingAnnotations/MultiLevelRepeatableAnno.java ! test/tools/javac/annotations/repeatingAnnotations/MultipleAnnoMixedOrder.java ! test/tools/javac/annotations/repeatingAnnotations/NestedContainers.java ! test/tools/javac/annotations/repeatingAnnotations/NoRepeatableAnno.out ! test/tools/javac/annotations/repeatingAnnotations/RepMemberAnno.java ! test/tools/javac/annotations/repeatingAnnotations/RepSelfMemberAnno.java ! test/tools/javac/annotations/repeatingAnnotations/RepeatingAndContainerPresent.java ! test/tools/javac/annotations/repeatingAnnotations/RepeatingTargetNotAllowed.java ! test/tools/javac/annotations/repeatingAnnotations/RepeatingTargetNotAllowed.out ! test/tools/javac/annotations/repeatingAnnotations/SelfRepeatingAnnotations.java ! test/tools/javac/annotations/repeatingAnnotations/SingleRepeatingAndContainer.java - test/tools/javac/annotations/repeatingAnnotations/UseWrongContainedBy.java - test/tools/javac/annotations/repeatingAnnotations/UseWrongContainerFor.java + test/tools/javac/annotations/repeatingAnnotations/UseWrongRepeatable.java - test/tools/javac/annotations/repeatingAnnotations/WrongContainedBy.java - test/tools/javac/annotations/repeatingAnnotations/WrongContainerFor.java ! test/tools/javac/annotations/repeatingAnnotations/WrongReturnTypeForValue.java ! test/tools/javac/annotations/repeatingAnnotations/WrongReturnTypeForValue.out ! test/tools/javac/annotations/repeatingAnnotations/combo/BasicSyntaxCombo.java ! test/tools/javac/annotations/repeatingAnnotations/combo/DeprecatedAnnoCombo.java ! test/tools/javac/annotations/repeatingAnnotations/combo/DocumentedAnnoCombo.java ! test/tools/javac/annotations/repeatingAnnotations/combo/Helper.java ! test/tools/javac/annotations/repeatingAnnotations/combo/InheritedAnnoCombo.java ! test/tools/javac/annotations/repeatingAnnotations/combo/RetentionAnnoCombo.java ! test/tools/javac/diags/examples.not-yet.txt - test/tools/javac/diags/examples/ContainedByDocumentedMismatch.java - test/tools/javac/diags/examples/ContainedByInheritedMismatch.java - test/tools/javac/diags/examples/ContainedByNoValue.java - test/tools/javac/diags/examples/ContainedByNonDefault.java - test/tools/javac/diags/examples/ContainedByRetentionMismatch.java - test/tools/javac/diags/examples/ContainedByTargetMismatch.java - test/tools/javac/diags/examples/ContainedByWrongValueType.java ! test/tools/javac/diags/examples/InvalidDuplicateAnnotation.java + test/tools/javac/diags/examples/RepeatableDocumentedMismatch.java + test/tools/javac/diags/examples/RepeatableInheritedMismatch.java + test/tools/javac/diags/examples/RepeatableNoValue.java + test/tools/javac/diags/examples/RepeatableNonDefault.java + test/tools/javac/diags/examples/RepeatableRetentionMismatch.java + test/tools/javac/diags/examples/RepeatableTargetMismatch.java + test/tools/javac/diags/examples/RepeatableWrongValueType.java ! test/tools/javac/diags/examples/RepeatingAnnotationAndContainer.java - test/tools/javac/diags/examples/WrongContainedBy.java - test/tools/javac/diags/examples/WrongContainerFor.java Changeset: d54b4a091450 Author: jjg Date: 2013-01-14 14:17 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/d54b4a091450 8006241: Test DocRootSlash.java fails Reviewed-by: darcy ! test/com/sun/javadoc/DocRootSlash/DocRootSlash.java Changeset: f805b5e3c9d1 Author: chegar Date: 2013-01-15 20:38 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/f805b5e3c9d1 8006344: Broken javadoc link in javax.lang.model.element.Element Reviewed-by: lancea, alanb, jfranck ! src/share/classes/javax/lang/model/element/Element.java Changeset: bc1023e0e533 Author: jjg Date: 2013-01-15 13:03 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/bc1023e0e533 8006224: Doclint NPE for attribute with no value Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclint/Checker.java ! src/share/classes/com/sun/tools/doclint/resources/doclint.properties + test/tools/doclint/AnchorTest.java + test/tools/doclint/AnchorTest.out Changeset: f785dcac17b7 Author: mcimadamore Date: 2013-01-16 16:27 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/f785dcac17b7 8005854: Add support for array constructor references Summary: Support constructor references of the kind int[]::new Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/tree/JCTree.java + test/tools/javac/lambda/MethodReference59.java + test/tools/javac/lambda/MethodReference60.java + test/tools/javac/lambda/MethodReference60.out Changeset: 7aa2025bbb7b Author: mcimadamore Date: 2013-01-16 16:30 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/7aa2025bbb7b 8005299: Add FunctionalInterface checking to javac Summary: Javac should check that types annotated with @FunctionalInterface are indeed functional interfaces Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/util/RichDiagnosticFormatter.java ! test/tools/javac/diags/examples.not-yet.txt + test/tools/javac/diags/examples/BadFunctionalIntfAnno.java ! test/tools/javac/lambda/BadConv03.out ! test/tools/javac/lambda/BadLambdaPos.out ! test/tools/javac/lambda/BadTargetType.out + test/tools/javac/lambda/FunctionalInterfaceAnno.java + test/tools/javac/lambda/FunctionalInterfaceAnno.out ! test/tools/javac/lambda/Intersection01.out ! test/tools/javac/lambda/LambdaConv09.out ! test/tools/javac/lambda/LambdaExpr10.out ! test/tools/javac/lambda/MethodReference04.out ! test/tools/javac/lambda/TargetType17.out ! test/tools/javac/lambda/TargetType43.out ! test/tools/javac/lambda/funcInterfaces/LambdaTest2_neg1.out ! test/tools/javac/lambda/funcInterfaces/NonSAM1.out ! test/tools/javac/lambda/funcInterfaces/NonSAM3.out ! test/tools/javac/lambda/lambdaExpression/AbstractClass_neg.out ! test/tools/javac/lambda/lambdaExpression/InvalidExpression5.out Changeset: 1afdf1f1472b Author: mcimadamore Date: 2013-01-16 17:40 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/1afdf1f1472b 8005964: Regression: difference in error recovery after ambiguity causes JCK test failure Summary: Wrong implementation of ResolveError.access in AmbiguityError Reviewed-by: jjh ! src/share/classes/com/sun/tools/javac/comp/Resolve.java Changeset: 6b6311a8c9cc Author: jjg Date: 2013-01-16 10:29 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/6b6311a8c9cc 8006236: doclint: structural issue hidden Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclint/Checker.java + test/tools/doclint/EndTagsTest.java + test/tools/doclint/EndTagsTest.out Changeset: 6f0986ed9b7e Author: katleman Date: 2013-01-03 12:44 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/6f0986ed9b7e Added tag jdk8-b71 for changeset 467e4d9281bc ! .hgtags Changeset: 45fed5cfd1c3 Author: katleman Date: 2013-01-10 09:56 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/45fed5cfd1c3 Added tag jdk8-b72 for changeset 6f0986ed9b7e ! .hgtags Changeset: 8d0baee36c71 Author: lana Date: 2013-01-10 15:53 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/8d0baee36c71 Merge Changeset: 63b20bde7cd6 Author: lana Date: 2013-01-16 12:14 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/63b20bde7cd6 Merge Changeset: 8b749558767b Author: darcy Date: 2013-01-16 13:22 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/8b749558767b 8006283: Change to Class.cast() in javax.lang.model implementation for repeating annotations Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/model/JavacElements.java Changeset: 916143318f10 Author: jjg Date: 2013-01-16 20:41 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/916143318f10 8006228: Doclint doesn't detect {@code nested inline} Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclint/Checker.java ! src/share/classes/com/sun/tools/doclint/resources/doclint.properties + test/tools/doclint/LiteralTest.java + test/tools/doclint/LiteralTest.out Changeset: 2d2b2be57c78 Author: mcimadamore Date: 2013-01-17 18:15 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/2d2b2be57c78 8005852: Treatment of '_' as identifier Summary: warn when '_' is found in an identifier position Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/parser/Tokens.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/tools/javac/lambda/LambdaParserTest.java Changeset: 22e417cdddee Author: ohrstrom Date: 2013-01-18 00:16 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/22e417cdddee 8004658: Add internal smart javac wrapper to solve JEP 139 Reviewed-by: jjg ! make/build.properties ! make/build.xml + src/share/classes/com/sun/tools/sjavac/BuildState.java + src/share/classes/com/sun/tools/sjavac/CleanProperties.java + src/share/classes/com/sun/tools/sjavac/CompileChunk.java + src/share/classes/com/sun/tools/sjavac/CompileJavaPackages.java + src/share/classes/com/sun/tools/sjavac/CompileProperties.java + src/share/classes/com/sun/tools/sjavac/CopyFile.java + src/share/classes/com/sun/tools/sjavac/JavacState.java + src/share/classes/com/sun/tools/sjavac/Log.java + src/share/classes/com/sun/tools/sjavac/Main.java + src/share/classes/com/sun/tools/sjavac/Module.java + src/share/classes/com/sun/tools/sjavac/Package.java + src/share/classes/com/sun/tools/sjavac/ProblemException.java + src/share/classes/com/sun/tools/sjavac/Source.java + src/share/classes/com/sun/tools/sjavac/Transformer.java + src/share/classes/com/sun/tools/sjavac/Util.java + src/share/classes/com/sun/tools/sjavac/comp/Dependencies.java + src/share/classes/com/sun/tools/sjavac/comp/JavaCompilerWithDeps.java + src/share/classes/com/sun/tools/sjavac/comp/PubapiVisitor.java + src/share/classes/com/sun/tools/sjavac/comp/ResolveWithDeps.java + src/share/classes/com/sun/tools/sjavac/comp/SmartFileManager.java + src/share/classes/com/sun/tools/sjavac/comp/SmartFileObject.java + src/share/classes/com/sun/tools/sjavac/comp/SmartWriter.java + src/share/classes/com/sun/tools/sjavac/server/CompilerPool.java + src/share/classes/com/sun/tools/sjavac/server/CompilerThread.java + src/share/classes/com/sun/tools/sjavac/server/JavacServer.java + src/share/classes/com/sun/tools/sjavac/server/PortFile.java + src/share/classes/com/sun/tools/sjavac/server/SysInfo.java + test/tools/sjavac/SJavac.java Changeset: 3d84ae209919 Author: mcimadamore Date: 2013-01-18 15:38 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/3d84ae209919 8006561: Langtools test failure: missing diags/examples Summary: forgot to hg add tests Reviewed-by: jjg + test/tools/javac/diags/examples/UnderscoreAsIdentifier.java + test/tools/javac/lambda/WarnUnderscoreAsIdent.java + test/tools/javac/lambda/WarnUnderscoreAsIdent.out Changeset: 4a3cfc970c6f Author: jjg Date: 2013-01-21 10:00 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/4a3cfc970c6f 8006263: Supplementary test cases needed for doclint Reviewed-by: mcimadamore Contributed-by: peter.jensen at oracle.com ! src/share/classes/com/sun/tools/doclint/Checker.java ! src/share/classes/com/sun/tools/doclint/DocLint.java ! src/share/classes/com/sun/tools/doclint/Entity.java ! src/share/classes/com/sun/tools/doclint/HtmlTag.java + test/tools/doclint/CoverageExtras.java ! test/tools/doclint/DocLintTester.java + test/tools/doclint/html/EntitiesTest.java + test/tools/doclint/html/EntitiesTest.out + test/tools/doclint/tool/HelpTest.java + test/tools/doclint/tool/HelpTest.out + test/tools/doclint/tool/MaxDiagsTest.java + test/tools/doclint/tool/MaxDiagsTest.out + test/tools/doclint/tool/PathsTest.java + test/tools/doclint/tool/RunTest.java + test/tools/doclint/tool/StatsTest.java + test/tools/doclint/tool/StatsTest.out Changeset: 967052c425a1 Author: jjg Date: 2013-01-21 10:07 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/967052c425a1 8006251: doclint: incorrect position for diagnostic for illegal text in tags Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/doclint/Checker.java ! src/share/classes/com/sun/tools/doclint/HtmlTag.java ! src/share/classes/com/sun/tools/doclint/resources/doclint.properties ! test/tools/doclint/HtmlTagsTest.java ! test/tools/doclint/HtmlTagsTest.out + test/tools/doclint/html/BlockTagsTest.java + test/tools/doclint/html/InlineTagsTest.java + test/tools/doclint/html/ListTagsTest.java + test/tools/doclint/html/OtherTagsTest.java + test/tools/doclint/html/OtherTagsTest.out + test/tools/doclint/html/TableTagsTest.java + test/tools/doclint/html/TagNotAllowed.java + test/tools/doclint/html/TagNotAllowed.out + test/tools/doclint/html/TextNotAllowed.java + test/tools/doclint/html/TextNotAllowed.out ! test/tools/doclint/tidy/ParaInPre.out ! test/tools/doclint/tidy/TextNotAllowed.out Changeset: 56c97aff46bb Author: katleman Date: 2013-01-16 12:00 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/56c97aff46bb Added tag jdk8-b73 for changeset 8d0baee36c71 ! .hgtags Changeset: b450959b42ff Author: lana Date: 2013-01-20 23:39 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/b450959b42ff Merge Changeset: 1985e35e97b2 Author: lana Date: 2013-01-21 11:16 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/1985e35e97b2 Merge Changeset: 7873d37f5b37 Author: mcimadamore Date: 2013-01-21 20:13 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/7873d37f5b37 8005244: Implement overload resolution as per latest spec EDR Summary: Add support for stuck expressions and provisional applicability Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! test/tools/javac/Diagnostics/6722234/T6722234d_1.out ! test/tools/javac/Diagnostics/6722234/T6722234d_2.out ! test/tools/javac/diags/examples.not-yet.txt ! test/tools/javac/diags/examples/CyclicInference.java - test/tools/javac/diags/examples/InferredDoNotConformToLower.java - test/tools/javac/diags/examples/NoUniqueMaximalInstance.java ! test/tools/javac/diags/examples/WhereIntersection.java ! test/tools/javac/generics/diamond/T6939780.out ! test/tools/javac/generics/diamond/neg/Neg05.out ! test/tools/javac/generics/diamond/neg/Neg10.java ! test/tools/javac/generics/diamond/neg/Neg10.out ! test/tools/javac/generics/inference/6315770/T6315770.out ! test/tools/javac/generics/inference/6638712/T6638712b.out ! test/tools/javac/generics/inference/6650759/T6650759m.out ! test/tools/javac/lambda/MethodReference25.java + test/tools/javac/lambda/MethodReference25.out ! test/tools/javac/lambda/MethodReference26.java - test/tools/javac/lambda/MethodReference26.out ! test/tools/javac/lambda/MethodReference43.java ! test/tools/javac/lambda/TargetType01.java + test/tools/javac/lambda/TargetType01.out ! test/tools/javac/lambda/TargetType06.java - test/tools/javac/lambda/TargetType06.out ! test/tools/javac/lambda/TargetType10.out ! test/tools/javac/lambda/TargetType11.java - test/tools/javac/lambda/TargetType11.out ! test/tools/javac/lambda/TargetType14.out ! test/tools/javac/lambda/TargetType21.java ! test/tools/javac/lambda/TargetType21.out ! test/tools/javac/lambda/TargetType26.out ! test/tools/javac/lambda/TargetType27.out ! test/tools/javac/lambda/TargetType28.out ! test/tools/javac/lambda/TargetType39.out ! test/tools/javac/lambda/TargetType45.java - test/tools/javac/lambda/TargetType45.out ! test/tools/javac/lambda/TargetType50.out + test/tools/javac/lambda/TargetType51.java + test/tools/javac/lambda/TargetType52.java + test/tools/javac/lambda/TargetType52.out ! test/tools/javac/lambda/VoidCompatibility.java - test/tools/javac/lambda/VoidCompatibility.out ! test/tools/javac/lambda/lambdaExpression/SamConversionComboTest.java ! test/tools/javac/lambda/methodReference/SamConversion.java ! test/tools/javac/lambda/methodReference/SamConversionComboTest.java ! test/tools/javac/lambda/typeInference/InferenceTest_neg5.out ! test/tools/javac/resolve/tests/PrimitiveOverReferenceVarargsAmbiguous.java Changeset: c7c41a044e7c Author: mcimadamore Date: 2013-01-21 20:14 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/c7c41a044e7c 8006566: Remove transient lambda-related guards from JavacParser Summary: Remove transitional internal flag for allowing intersection types in cast Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! test/tools/javac/cast/intersection/IntersectionTypeCastTest.java ! test/tools/javac/cast/intersection/IntersectionTypeParserTest.java ! test/tools/javac/cast/intersection/model/Model01.java ! test/tools/javac/diags/examples/SecondaryBoundMustBeMarkerIntf.java ! test/tools/javac/lambda/Intersection01.java ! test/tools/javac/lambda/intersection/IntersectionTargetTypeTest.java Changeset: b12ffdfa1341 Author: mcimadamore Date: 2013-01-21 20:15 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/b12ffdfa1341 8005851: Remove support for synchronized interface methods Summary: Synchronized default methods are no longer supported Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Flags.java ! test/tools/javac/defaultMethods/syntax/TestDefaultMethodsSyntax.java ! test/tools/javac/lambdaShapes/org/openjdk/tests/vm/DefaultMethodsTest.java Changeset: cf84b07a82db Author: mcimadamore Date: 2013-01-21 20:19 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/cf84b07a82db 8005166: Add support for static interface methods Summary: Support public static interface methods Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties + test/tools/javac/defaultMethods/static/Static01.java + test/tools/javac/defaultMethods/static/Static02.java + test/tools/javac/defaultMethods/static/Static02.out + test/tools/javac/defaultMethods/static/hiding/InterfaceMethodHidingTest.java + test/tools/javac/defaultMethods/static/import/StaticImport1.java + test/tools/javac/defaultMethods/static/import/StaticImport2.java + test/tools/javac/defaultMethods/static/import/StaticImport2.out + test/tools/javac/defaultMethods/static/import/StaticImport3.java + test/tools/javac/defaultMethods/static/import/StaticImport3.out + test/tools/javac/defaultMethods/static/import/pkg/A.java + test/tools/javac/defaultMethods/static/import/pkg/B.java + test/tools/javac/defaultMethods/static/import/pkg/C.java ! test/tools/javac/defaultMethods/syntax/TestDefaultMethodsSyntax.java + test/tools/javac/diags/examples/IllegalStaticIntfMethCall.java + test/tools/javac/diags/examples/StaticIntfMethodNotSupported.java Changeset: be443002e970 Author: mcimadamore Date: 2013-01-22 16:23 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/be443002e970 8006673: TargetType52 fails because of bad golden file Summary: Fix golden file in negative test Reviewed-by: jjg ! test/tools/javac/lambda/TargetType52.out Changeset: b61e5f801f7c Author: mcimadamore Date: 2013-01-22 16:39 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/b61e5f801f7c 8006684: Compiler produces java.lang.VerifyError: Bad type on operand stack Summary: Lambda desugaring generates spurious references to 'this' in static contexts Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java + test/tools/javac/lambda/LambdaExpr21.java Changeset: 8943b4213f59 Author: jjg Date: 2013-01-22 18:43 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/8943b4213f59 8006723: sjavac test fails to compile on clean build Reviewed-by: ksrini ! test/tools/sjavac/SJavac.java + test/tools/sjavac/SJavacWrapper.java Changeset: f5b70712e0d5 Author: jjg Date: 2013-01-22 19:06 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/f5b70712e0d5 8006728: temporarily workaround jtreg problems for doclint tests in othervm Reviewed-by: jjh + test/tools/doclint/html/AAA.java + test/tools/doclint/tidy/AAA.java + test/tools/doclint/tool/AAA.java Changeset: 385828dd5604 Author: jjg Date: 2013-01-22 19:07 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/385828dd5604 Merge Changeset: 97bd5e7151bc Author: mcimadamore Date: 2013-01-23 15:08 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/97bd5e7151bc 8006692: jdk/test/java/util/Collections/BigBinarySearch.java fails to compile Summary: Missing boxing cause spurious inference failure Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Infer.java + test/tools/javac/generics/inference/8006692/T8006692.java Changeset: 5c956be64b9e Author: vromero Date: 2013-01-23 20:57 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/5c956be64b9e 8006694: temporarily workaround combo tests are causing time out in several platforms Reviewed-by: jjg Contributed-by: maurizio.cimadamore at oracle.com ! test/Makefile ! test/tools/javac/Diagnostics/6769027/T6769027.java ! test/tools/javac/T7093325.java ! test/tools/javac/cast/intersection/IntersectionTypeCastTest.java ! test/tools/javac/defaultMethods/super/TestDefaultSuperCall.java ! test/tools/javac/failover/CheckAttributedTree.java ! test/tools/javac/generics/diamond/7046778/DiamondAndInnerClassTest.java ! test/tools/javac/generics/rawOverride/7062745/GenericOverrideTest.java ! test/tools/javac/lambda/FunctionalInterfaceConversionTest.java ! test/tools/javac/lambda/LambdaParserTest.java ! test/tools/javac/lambda/MethodReferenceParserTest.java ! test/tools/javac/lambda/TestInvokeDynamic.java ! test/tools/javac/lambda/mostSpecific/StructuralMostSpecificTest.java ! test/tools/javac/lambda/typeInference/combo/TypeInferenceComboTest.java ! test/tools/javac/lambdaShapes/org/openjdk/tests/vm/FDSeparateCompilationTest.java ! test/tools/javac/lib/JavacTestingAbstractThreadedTest.java ! test/tools/javac/multicatch/7030606/DisjunctiveTypeWellFormednessTest.java ! test/tools/javac/varargs/7042566/T7042566.java ! test/tools/javac/varargs/warning/Warn4.java ! test/tools/javac/varargs/warning/Warn5.java Changeset: 71f35e4b93a5 Author: jjg Date: 2013-01-23 13:27 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/71f35e4b93a5 8006775: JSR 308: Compiler changes in JDK8 Reviewed-by: jjg Contributed-by: mernst at cs.washington.edu, wmdietl at cs.washington.edu, mpapi at csail.mit.edu, mahmood at notnoop.com + src/share/classes/com/sun/javadoc/AnnotatedType.java ! src/share/classes/com/sun/javadoc/ExecutableMemberDoc.java ! src/share/classes/com/sun/javadoc/Type.java ! src/share/classes/com/sun/javadoc/TypeVariable.java + src/share/classes/com/sun/source/tree/AnnotatedTypeTree.java ! src/share/classes/com/sun/source/tree/MethodTree.java ! src/share/classes/com/sun/source/tree/Tree.java ! src/share/classes/com/sun/source/tree/TreeVisitor.java ! src/share/classes/com/sun/source/tree/TypeParameterTree.java ! src/share/classes/com/sun/source/util/SimpleTreeVisitor.java ! src/share/classes/com/sun/source/util/TaskEvent.java ! src/share/classes/com/sun/source/util/TreeScanner.java ! src/share/classes/com/sun/tools/classfile/Attribute.java ! src/share/classes/com/sun/tools/classfile/ClassWriter.java + src/share/classes/com/sun/tools/classfile/RuntimeInvisibleTypeAnnotations_attribute.java + src/share/classes/com/sun/tools/classfile/RuntimeTypeAnnotations_attribute.java + src/share/classes/com/sun/tools/classfile/RuntimeVisibleTypeAnnotations_attribute.java + src/share/classes/com/sun/tools/classfile/TypeAnnotation.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractExecutableMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstructorWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkInfoImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/MethodWriterImpl.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Util.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/LinkFactory.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/LinkInfo.java ! src/share/classes/com/sun/tools/javac/code/Annotations.java ! src/share/classes/com/sun/tools/javac/code/Attribute.java ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/code/Lint.java ! src/share/classes/com/sun/tools/javac/code/Printer.java ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/code/TargetType.java ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/TypeAnnotationPosition.java + src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Annotate.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/ConstFold.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/jvm/JNIWriter.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/model/JavacTypes.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/parser/Scanner.java ! src/share/classes/com/sun/tools/javac/parser/UnicodeReader.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/resources/compiler_ja.properties ! src/share/classes/com/sun/tools/javac/resources/compiler_zh_CN.properties ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/share/classes/com/sun/tools/javac/tree/TreeCopier.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java ! src/share/classes/com/sun/tools/javac/tree/TreeScanner.java ! src/share/classes/com/sun/tools/javac/tree/TreeTranslator.java ! src/share/classes/com/sun/tools/javac/util/JCDiagnostic.java ! src/share/classes/com/sun/tools/javac/util/Log.java ! src/share/classes/com/sun/tools/javadoc/AbstractTypeImpl.java + src/share/classes/com/sun/tools/javadoc/AnnotatedTypeImpl.java ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java ! src/share/classes/com/sun/tools/javadoc/ExecutableMemberDocImpl.java ! src/share/classes/com/sun/tools/javadoc/PrimitiveType.java ! src/share/classes/com/sun/tools/javadoc/TypeMaker.java ! src/share/classes/com/sun/tools/javadoc/TypeVariableImpl.java ! src/share/classes/com/sun/tools/javap/AnnotationWriter.java ! src/share/classes/com/sun/tools/javap/AttributeWriter.java ! src/share/classes/com/sun/tools/javap/CodeWriter.java ! src/share/classes/com/sun/tools/javap/InstructionDetailWriter.java + src/share/classes/com/sun/tools/javap/TypeAnnotationWriter.java ! src/share/classes/javax/lang/model/SourceVersion.java + src/share/classes/javax/lang/model/type/AnnotatedType.java ! src/share/classes/javax/lang/model/type/ExecutableType.java ! src/share/classes/javax/lang/model/type/TypeKind.java ! src/share/classes/javax/lang/model/type/TypeVisitor.java ! src/share/classes/javax/lang/model/util/AbstractTypeVisitor6.java ! src/share/classes/javax/lang/model/util/Types.java + test/com/sun/javadoc/testAnnotationOptional/TestAnnotationOptional.java + test/com/sun/javadoc/testAnnotationOptional/pkg/AnnotationOptional.java + test/com/sun/javadoc/typeAnnotations/smoke/TestSmoke.java + test/com/sun/javadoc/typeAnnotations/smoke/pkg/TargetTypes.java ! test/tools/javac/7129225/TestImportStar.java ! test/tools/javac/7129225/TestImportStar.ref ! test/tools/javac/T6873845.java + test/tools/javac/T6985181.java ! test/tools/javac/annotations/6881115/T6881115.java ! test/tools/javac/annotations/6881115/T6881115.out + test/tools/javac/annotations/typeAnnotations/6967002/T6967002.java + test/tools/javac/annotations/typeAnnotations/6967002/T6967002.out + test/tools/javac/annotations/typeAnnotations/InnerClass.java + test/tools/javac/annotations/typeAnnotations/MultipleTargets.java + test/tools/javac/annotations/typeAnnotations/TargetTypes.java + test/tools/javac/annotations/typeAnnotations/TypeParameterTarget.java + test/tools/javac/annotations/typeAnnotations/TypeProcOnly.java + test/tools/javac/annotations/typeAnnotations/TypeUseTarget.java + test/tools/javac/annotations/typeAnnotations/api/AnnotatedArrayOrder.java + test/tools/javac/annotations/typeAnnotations/api/ArrayCreationTree.java + test/tools/javac/annotations/typeAnnotations/api/ArrayPositionConsistency.java + test/tools/javac/annotations/typeAnnotations/attribution/Scopes.java + test/tools/javac/annotations/typeAnnotations/classfile/ClassfileTestHelper.java + test/tools/javac/annotations/typeAnnotations/classfile/CombinationsTargetTest1.java + test/tools/javac/annotations/typeAnnotations/classfile/CombinationsTargetTest2.java + test/tools/javac/annotations/typeAnnotations/classfile/DeadCode.java + test/tools/javac/annotations/typeAnnotations/classfile/NewTypeArguments.java + test/tools/javac/annotations/typeAnnotations/classfile/NoTargetAnnotations.java + test/tools/javac/annotations/typeAnnotations/classfile/TypeCasts.java + test/tools/javac/annotations/typeAnnotations/classfile/Wildcards.java + test/tools/javac/annotations/typeAnnotations/failures/AnnotatedImport.java + test/tools/javac/annotations/typeAnnotations/failures/AnnotatedImport.out + test/tools/javac/annotations/typeAnnotations/failures/AnnotatedPackage1.java + test/tools/javac/annotations/typeAnnotations/failures/AnnotatedPackage1.out + test/tools/javac/annotations/typeAnnotations/failures/AnnotatedPackage2.java + test/tools/javac/annotations/typeAnnotations/failures/AnnotatedPackage2.out + test/tools/javac/annotations/typeAnnotations/failures/AnnotationVersion.java + test/tools/javac/annotations/typeAnnotations/failures/AnnotationVersion.out + test/tools/javac/annotations/typeAnnotations/failures/AnnotationVersion7.out + test/tools/javac/annotations/typeAnnotations/failures/BadCast.java + test/tools/javac/annotations/typeAnnotations/failures/BadCast.out + test/tools/javac/annotations/typeAnnotations/failures/CantAnnotateStaticClass.java + test/tools/javac/annotations/typeAnnotations/failures/CantAnnotateStaticClass.out + test/tools/javac/annotations/typeAnnotations/failures/IncompleteArray.java + test/tools/javac/annotations/typeAnnotations/failures/IncompleteArray.out + test/tools/javac/annotations/typeAnnotations/failures/IncompleteVararg.java + test/tools/javac/annotations/typeAnnotations/failures/IncompleteVararg.out + test/tools/javac/annotations/typeAnnotations/failures/IndexArray.java + test/tools/javac/annotations/typeAnnotations/failures/IndexArray.out + test/tools/javac/annotations/typeAnnotations/failures/LintCast.java + test/tools/javac/annotations/typeAnnotations/failures/LintCast.out + test/tools/javac/annotations/typeAnnotations/failures/OldArray.java + test/tools/javac/annotations/typeAnnotations/failures/Scopes.java + test/tools/javac/annotations/typeAnnotations/failures/Scopes.out + test/tools/javac/annotations/typeAnnotations/failures/StaticFields.java + test/tools/javac/annotations/typeAnnotations/failures/StaticFields.out + test/tools/javac/annotations/typeAnnotations/failures/StaticMethods.java + test/tools/javac/annotations/typeAnnotations/failures/StaticMethods.out + test/tools/javac/annotations/typeAnnotations/failures/TypeAndField.java + test/tools/javac/annotations/typeAnnotations/failures/VoidGenericMethod.java + test/tools/javac/annotations/typeAnnotations/failures/common/arrays/DuplicateAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/arrays/DuplicateAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/arrays/DuplicateTypeAnnotation.java + test/tools/javac/annotations/typeAnnotations/failures/common/arrays/DuplicateTypeAnnotation.out + test/tools/javac/annotations/typeAnnotations/failures/common/arrays/InvalidLocation.java + test/tools/javac/annotations/typeAnnotations/failures/common/arrays/InvalidLocation.out + test/tools/javac/annotations/typeAnnotations/failures/common/arrays/MissingAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/arrays/MissingAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/innertypeparams/DuplicateAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/innertypeparams/DuplicateAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/innertypeparams/DuplicateTypeAnnotation.java + test/tools/javac/annotations/typeAnnotations/failures/common/innertypeparams/DuplicateTypeAnnotation.out + test/tools/javac/annotations/typeAnnotations/failures/common/innertypeparams/InvalidLocation.java + test/tools/javac/annotations/typeAnnotations/failures/common/innertypeparams/InvalidLocation.out + test/tools/javac/annotations/typeAnnotations/failures/common/innertypeparams/MissingAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/innertypeparams/MissingAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/newarray/DuplicateAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/newarray/DuplicateAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/newarray/DuplicateTypeAnnotation.java + test/tools/javac/annotations/typeAnnotations/failures/common/newarray/DuplicateTypeAnnotation.out + test/tools/javac/annotations/typeAnnotations/failures/common/newarray/InvalidLocation.java + test/tools/javac/annotations/typeAnnotations/failures/common/newarray/InvalidLocation.out + test/tools/javac/annotations/typeAnnotations/failures/common/newarray/MissingAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/newarray/MissingAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/parambounds/BrokenAnnotation.java + test/tools/javac/annotations/typeAnnotations/failures/common/parambounds/BrokenAnnotation.out + test/tools/javac/annotations/typeAnnotations/failures/common/parambounds/DuplicateAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/parambounds/DuplicateAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/parambounds/DuplicateTypeAnnotation.java + test/tools/javac/annotations/typeAnnotations/failures/common/parambounds/DuplicateTypeAnnotation.out + test/tools/javac/annotations/typeAnnotations/failures/common/parambounds/InvalidLocation.java + test/tools/javac/annotations/typeAnnotations/failures/common/parambounds/InvalidLocation.out + test/tools/javac/annotations/typeAnnotations/failures/common/parambounds/MissingAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/parambounds/MissingAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/DuplicateAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/DuplicateAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/DuplicateTypeAnnotation.java + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/DuplicateTypeAnnotation.out + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/InvalidLocation.java + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/InvalidLocation.out + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/MissingAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/MissingAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/Nesting.java + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/StaticThings.java + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/StaticThings.out + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/WrongType.java + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/WrongType.out + test/tools/javac/annotations/typeAnnotations/failures/common/rest/DuplicateAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/rest/DuplicateAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/rest/DuplicateTypeAnnotation.java + test/tools/javac/annotations/typeAnnotations/failures/common/rest/DuplicateTypeAnnotation.out + test/tools/javac/annotations/typeAnnotations/failures/common/rest/InvalidLocation.java + test/tools/javac/annotations/typeAnnotations/failures/common/rest/InvalidLocation.out + test/tools/javac/annotations/typeAnnotations/failures/common/rest/MissingAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/rest/MissingAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/typeArgs/DuplicateAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/typeArgs/DuplicateAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/typeArgs/DuplicateTypeAnnotation.java + test/tools/javac/annotations/typeAnnotations/failures/common/typeArgs/DuplicateTypeAnnotation.out + test/tools/javac/annotations/typeAnnotations/failures/common/typeArgs/InvalidLocation.java + test/tools/javac/annotations/typeAnnotations/failures/common/typeArgs/InvalidLocation.out + test/tools/javac/annotations/typeAnnotations/failures/common/typeArgs/MissingAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/typeArgs/MissingAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/typeparams/DuplicateAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/typeparams/DuplicateAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/typeparams/DuplicateTypeAnnotation.java + test/tools/javac/annotations/typeAnnotations/failures/common/typeparams/DuplicateTypeAnnotation.out + test/tools/javac/annotations/typeAnnotations/failures/common/typeparams/InvalidLocation.java + test/tools/javac/annotations/typeAnnotations/failures/common/typeparams/InvalidLocation.out + test/tools/javac/annotations/typeAnnotations/failures/common/typeparams/MissingAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/typeparams/MissingAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/wildcards/DuplicateAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/wildcards/DuplicateAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/wildcards/DuplicateTypeAnnotation.java + test/tools/javac/annotations/typeAnnotations/failures/common/wildcards/DuplicateTypeAnnotation.out + test/tools/javac/annotations/typeAnnotations/failures/common/wildcards/InvalidLocation.java + test/tools/javac/annotations/typeAnnotations/failures/common/wildcards/InvalidLocation.out + test/tools/javac/annotations/typeAnnotations/failures/common/wildcards/MissingAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/wildcards/MissingAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/target/Constructor.java + test/tools/javac/annotations/typeAnnotations/failures/target/Constructor.out + test/tools/javac/annotations/typeAnnotations/failures/target/DotClass.java + test/tools/javac/annotations/typeAnnotations/failures/target/DotClass.out + test/tools/javac/annotations/typeAnnotations/failures/target/IncompleteArray.java + test/tools/javac/annotations/typeAnnotations/failures/target/IncompleteArray.out + test/tools/javac/annotations/typeAnnotations/failures/target/NotTypeParameter.java + test/tools/javac/annotations/typeAnnotations/failures/target/NotTypeParameter.out + test/tools/javac/annotations/typeAnnotations/failures/target/NotTypeUse.java + test/tools/javac/annotations/typeAnnotations/failures/target/NotTypeUse.out + test/tools/javac/annotations/typeAnnotations/failures/target/VoidMethod.java + test/tools/javac/annotations/typeAnnotations/failures/target/VoidMethod.out + test/tools/javac/annotations/typeAnnotations/newlocations/BasicTest.java + test/tools/javac/annotations/typeAnnotations/newlocations/ClassExtends.java + test/tools/javac/annotations/typeAnnotations/newlocations/ClassParameters.java + test/tools/javac/annotations/typeAnnotations/newlocations/ConstructorTypeArgs.java + test/tools/javac/annotations/typeAnnotations/newlocations/ExceptionParameters.java + test/tools/javac/annotations/typeAnnotations/newlocations/Expressions.java + test/tools/javac/annotations/typeAnnotations/newlocations/Fields.java + test/tools/javac/annotations/typeAnnotations/newlocations/LocalVariables.java + test/tools/javac/annotations/typeAnnotations/newlocations/MethodReturnType.java + test/tools/javac/annotations/typeAnnotations/newlocations/MethodTypeArgs.java + test/tools/javac/annotations/typeAnnotations/newlocations/MethodTypeParameters.java + test/tools/javac/annotations/typeAnnotations/newlocations/MultiCatch.java + test/tools/javac/annotations/typeAnnotations/newlocations/NestedTypes.java + test/tools/javac/annotations/typeAnnotations/newlocations/Parameters.java + test/tools/javac/annotations/typeAnnotations/newlocations/Receivers.java + test/tools/javac/annotations/typeAnnotations/newlocations/RepeatingTypeAnnotations.java + test/tools/javac/annotations/typeAnnotations/newlocations/RepeatingTypeAnnotations.out + test/tools/javac/annotations/typeAnnotations/newlocations/ResourceVariables.java + test/tools/javac/annotations/typeAnnotations/newlocations/Throws.java + test/tools/javac/annotations/typeAnnotations/newlocations/TopLevelBlocks.java + test/tools/javac/annotations/typeAnnotations/newlocations/TypeCasts.java + test/tools/javac/annotations/typeAnnotations/newlocations/TypeParameters.java + test/tools/javac/annotations/typeAnnotations/newlocations/Varargs.java + test/tools/javac/annotations/typeAnnotations/newlocations/Wildcards.java + test/tools/javac/annotations/typeAnnotations/packageanno/PackageProcessor.java + test/tools/javac/annotations/typeAnnotations/packageanno/mypackage/Anno.java + test/tools/javac/annotations/typeAnnotations/packageanno/mypackage/MyClass.java + test/tools/javac/annotations/typeAnnotations/packageanno/mypackage/package-info.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/ClassExtends.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/ClassTypeParam.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/Constructors.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/Driver.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/ExceptionParameters.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/Fields.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/FromSpecification.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/MethodParameters.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/MethodReceivers.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/MethodReturns.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/MethodThrows.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/MethodTypeParam.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/MultiCatch.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/NestedTypes.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/NewObjects.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/ReferenceInfoUtil.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/RepeatingTypeAnnotations.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/TypeCasts.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/TypeTests.java ! test/tools/javac/api/EndPositions.java ! test/tools/javac/diags/CheckResourceKeys.java ! test/tools/javac/diags/examples.not-yet.txt + test/tools/javac/diags/examples/CantAnnotateNestedType.java + test/tools/javac/diags/examples/CantAnnotateStaticClass.java + test/tools/javac/diags/examples/IncorrectReceiverType.java + test/tools/javac/diags/examples/NoAnnotationsOnDotClass.java + test/tools/javac/diags/examples/ThisAsIdentifier.java + test/tools/javac/diags/examples/TypeAnnotationsNotSupported.java ! test/tools/javac/failover/CheckAttributedTree.java ! test/tools/javac/processing/6994946/SemanticErrorTest.2.out ! test/tools/javac/processing/model/element/TestAnonClassNames.java ! test/tools/javac/processing/model/element/TestMissingElement/TestMissingElement.java + test/tools/javac/processing/model/element/TestMissingElement/TestMissingElement.ref ! test/tools/javac/processing/model/util/directSupersOfErr/DirectSupersOfErr.java + test/tools/javac/processing/model/util/directSupersOfErr/DirectSupersOfErr.ref ! test/tools/javac/tree/TreeKindTest.java ! test/tools/javac/tree/TreePosTest.java + test/tools/javac/treeannotests/AnnoTreeTests.java ! test/tools/javac/treeannotests/TestProcessor.java - test/tools/javac/typeAnnotations/newlocations/BasicTest.java - test/tools/javac/typeAnnotations/newlocations/BasicTest.out + test/tools/javap/typeAnnotations/JSR175Annotations.java + test/tools/javap/typeAnnotations/NewArray.java + test/tools/javap/typeAnnotations/Presence.java + test/tools/javap/typeAnnotations/PresenceInner.java + test/tools/javap/typeAnnotations/T6855990.java + test/tools/javap/typeAnnotations/TypeCasts.java + test/tools/javap/typeAnnotations/Visibility.java + test/tools/javap/typeAnnotations/Wildcards.java Changeset: 09f65aad4759 Author: darcy Date: 2013-01-23 20:11 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/09f65aad4759 8006264: Add explanation of why default methods cannot be used in JDK 8 javax.lang.model Reviewed-by: jjg ! src/share/classes/javax/lang/model/element/AnnotationValueVisitor.java ! src/share/classes/javax/lang/model/element/ElementVisitor.java ! src/share/classes/javax/lang/model/type/TypeVisitor.java ! src/share/classes/javax/lang/model/util/AbstractAnnotationValueVisitor6.java ! src/share/classes/javax/lang/model/util/AbstractAnnotationValueVisitor7.java ! src/share/classes/javax/lang/model/util/AbstractAnnotationValueVisitor8.java ! src/share/classes/javax/lang/model/util/AbstractElementVisitor6.java ! src/share/classes/javax/lang/model/util/AbstractElementVisitor7.java ! src/share/classes/javax/lang/model/util/AbstractElementVisitor8.java ! src/share/classes/javax/lang/model/util/AbstractTypeVisitor6.java ! src/share/classes/javax/lang/model/util/AbstractTypeVisitor7.java ! src/share/classes/javax/lang/model/util/AbstractTypeVisitor8.java ! src/share/classes/javax/lang/model/util/ElementKindVisitor6.java ! src/share/classes/javax/lang/model/util/ElementKindVisitor7.java ! src/share/classes/javax/lang/model/util/ElementKindVisitor8.java ! src/share/classes/javax/lang/model/util/SimpleAnnotationValueVisitor6.java ! src/share/classes/javax/lang/model/util/SimpleAnnotationValueVisitor7.java ! src/share/classes/javax/lang/model/util/SimpleAnnotationValueVisitor8.java ! src/share/classes/javax/lang/model/util/SimpleElementVisitor6.java ! src/share/classes/javax/lang/model/util/SimpleElementVisitor7.java ! src/share/classes/javax/lang/model/util/SimpleElementVisitor8.java ! src/share/classes/javax/lang/model/util/SimpleTypeVisitor6.java ! src/share/classes/javax/lang/model/util/SimpleTypeVisitor7.java ! src/share/classes/javax/lang/model/util/SimpleTypeVisitor8.java ! src/share/classes/javax/lang/model/util/TypeKindVisitor6.java ! src/share/classes/javax/lang/model/util/TypeKindVisitor7.java ! src/share/classes/javax/lang/model/util/TypeKindVisitor8.java Changeset: cbcd9b484759 Author: vromero Date: 2013-01-27 19:38 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/cbcd9b484759 8006944: javac, combo tests should print out the number of threads used Reviewed-by: mcimadamore ! test/tools/javac/lib/JavacTestingAbstractThreadedTest.java From james.laskey at oracle.com Mon Jan 28 13:29:38 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Mon, 28 Jan 2013 21:29:38 +0000 Subject: hg: nashorn/jdk8/jaxws: 9 new changesets Message-ID: <20130128212957.3459D4762B@hg.openjdk.java.net> Changeset: 3b1c2733d47e Author: katleman Date: 2012-12-20 09:18 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxws/rev/3b1c2733d47e Added tag jdk8-b69 for changeset 756323c99011 ! .hgtags Changeset: f577a39c9fb3 Author: katleman Date: 2012-12-27 12:15 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxws/rev/f577a39c9fb3 Added tag jdk8-b70 for changeset 3b1c2733d47e ! .hgtags Changeset: d9707230294d Author: katleman Date: 2013-01-03 12:44 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxws/rev/d9707230294d Added tag jdk8-b71 for changeset f577a39c9fb3 ! .hgtags Changeset: c606f644a5d9 Author: katleman Date: 2013-01-10 09:55 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxws/rev/c606f644a5d9 Added tag jdk8-b72 for changeset d9707230294d ! .hgtags Changeset: 68f508979ffe Author: katleman Date: 2013-01-16 11:59 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxws/rev/68f508979ffe Added tag jdk8-b73 for changeset c606f644a5d9 ! .hgtags Changeset: 51f3117e2b75 Author: erikj Date: 2013-01-04 11:31 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxws/rev/51f3117e2b75 8005575: build-infra: Three JCK tests fails on Solaris with new RE Autoconf-Based build Reviewed-by: ohair ! makefiles/BuildJaxws.gmk Changeset: dd7473082690 Author: katleman Date: 2013-01-08 13:14 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxws/rev/dd7473082690 Merge Changeset: b8fd32e44c26 Author: katleman Date: 2013-01-15 10:07 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxws/rev/b8fd32e44c26 Merge Changeset: 12db3c5a3393 Author: katleman Date: 2013-01-16 22:17 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxws/rev/12db3c5a3393 Merge From james.laskey at oracle.com Mon Jan 28 13:33:14 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Mon, 28 Jan 2013 21:33:14 +0000 Subject: hg: nashorn/jdk8/hotspot: 88 new changesets Message-ID: <20130128213558.919184762C@hg.openjdk.java.net> Changeset: 4a2ed49abd51 Author: amurillo Date: 2012-12-07 10:55 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/4a2ed49abd51 8004724: new hotspot build - hs25-b13 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 442f942757c0 Author: johnc Date: 2012-10-01 09:28 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/442f942757c0 8000244: G1: Ergonomically set MarkStackSize and use virtual space for global marking stack Summary: Set the value of MarkStackSize to a value based on the number of parallel marking threads with a reasonable minimum. Expand the marking stack if we have to restart marking due to an overflow up to a reasonable maximum. Allocate the underlying space for the marking stack from virtual memory. Reviewed-by: jmasa, brutisso ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/runtime/arguments.cpp Changeset: a14c5698a162 Author: johnc Date: 2012-12-07 16:08 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/a14c5698a162 Merge Changeset: 2aa953165ade Author: brutisso Date: 2012-12-13 10:09 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/2aa953165ade 8004661: Comment and function name java_lang_String::toHash is wrong Summary: renamed to hash_code Reviewed-by: dholmes, coleenp, brutisso Contributed-by: erik.helin at oracle.com ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/symbolTable.cpp Changeset: db8a7163c682 Author: stefank Date: 2012-12-13 09:28 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/db8a7163c682 8004674: Add necessary .inline.hpp files to fix non-PCH build Reviewed-by: stefank, coleenp Contributed-by: volker.simonis at gmail.com ! src/share/vm/gc_implementation/parallelScavenge/adjoiningVirtualSpaces.cpp ! src/share/vm/gc_implementation/shared/gcStats.cpp Changeset: 4459ef2189f5 Author: stefank Date: 2012-12-13 09:06 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/4459ef2189f5 Merge Changeset: fd74228fd5ca Author: jiangli Date: 2012-12-11 12:41 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/fd74228fd5ca 8004076: Move _max_locals and _size_of_parameters to ConstMethod for better sharing. Summary: Move _max_locals and _size_of_parameters to ConstMethod for better sharing. Reviewed-by: coleenp, minqi, jrose ! agent/src/share/classes/sun/jvm/hotspot/oops/ConstMethod.java ! agent/src/share/classes/sun/jvm/hotspot/oops/Method.java ! src/cpu/sparc/vm/cppInterpreter_sparc.cpp ! src/cpu/sparc/vm/methodHandles_sparc.cpp ! src/cpu/sparc/vm/templateInterpreter_sparc.cpp ! src/cpu/sparc/vm/templateTable_sparc.cpp ! src/cpu/x86/vm/cppInterpreter_x86.cpp ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/cpu/x86/vm/templateInterpreter_x86_32.cpp ! src/cpu/x86/vm/templateInterpreter_x86_64.cpp ! src/share/vm/oops/constMethod.hpp ! src/share/vm/oops/method.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 807f1d348f7b Author: collins Date: 2012-12-14 11:45 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/807f1d348f7b Merge Changeset: b6c9c0109a60 Author: amurillo Date: 2012-12-14 14:19 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/b6c9c0109a60 Merge Changeset: cb8a4e04bc8c Author: amurillo Date: 2012-12-14 14:19 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/cb8a4e04bc8c Added tag hs25-b13 for changeset b6c9c0109a60 ! .hgtags Changeset: 8b4810c80f5d Author: katleman Date: 2012-12-20 09:17 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/8b4810c80f5d Added tag jdk8-b69 for changeset cb8a4e04bc8c ! .hgtags Changeset: 1f323009c3ea Author: amurillo Date: 2012-12-14 14:27 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/1f323009c3ea 8005036: new hotspot build - hs25-b14 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 892acf0431ef Author: dcubed Date: 2012-12-14 10:06 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/892acf0431ef 7153050: remove crufty '_g' support from HotSpot repo makefiles Summary: Phase 1 is removing '_g' support from the Makefiles. Reviewed-by: dcubed, sspitsyn, coleenp, tbell Contributed-by: ron.durbin at oracle.com ! make/bsd/Makefile ! make/bsd/makefiles/buildtree.make ! make/bsd/makefiles/debug.make ! make/bsd/makefiles/dtrace.make ! make/bsd/makefiles/fastdebug.make ! make/bsd/makefiles/gcc.make ! make/bsd/makefiles/jsig.make ! make/bsd/makefiles/jvmg.make ! make/bsd/makefiles/optimized.make ! make/bsd/makefiles/product.make ! make/bsd/makefiles/saproc.make ! make/bsd/makefiles/vm.make ! make/linux/Makefile ! make/linux/makefiles/buildtree.make ! make/linux/makefiles/debug.make ! make/linux/makefiles/fastdebug.make ! make/linux/makefiles/gcc.make ! make/linux/makefiles/jsig.make ! make/linux/makefiles/jvmg.make ! make/linux/makefiles/optimized.make ! make/linux/makefiles/product.make ! make/linux/makefiles/saproc.make ! make/linux/makefiles/vm.make ! make/solaris/Makefile ! make/solaris/makefiles/buildtree.make ! make/solaris/makefiles/debug.make ! make/solaris/makefiles/dtrace.make ! make/solaris/makefiles/fastdebug.make ! make/solaris/makefiles/gcc.make ! make/solaris/makefiles/jsig.make ! make/solaris/makefiles/jvmg.make ! make/solaris/makefiles/optimized.make ! make/solaris/makefiles/product.make ! make/solaris/makefiles/saproc.make ! make/solaris/makefiles/vm.make ! make/windows/build.make ! make/windows/projectfiles/compiler2/ADLCompiler.dsp ! make/windows/projectfiles/tiered/ADLCompiler.dsp Changeset: 30866cd626b0 Author: coleenp Date: 2012-12-12 11:39 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/30866cd626b0 8004883: NPG: clean up anonymous class fix Summary: Add klass_holder() to return either mirror or class_loader depending on if the class is anonymous or not. Reviewed-by: stefank, jrose ! src/share/vm/asm/codeBuffer.cpp ! src/share/vm/classfile/classLoaderData.cpp ! src/share/vm/classfile/classLoaderData.hpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/klass.hpp Changeset: 18712b1caf7a Author: rkennke Date: 2012-12-12 21:40 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/18712b1caf7a 8004898: library_call.cpp build error after 7172640 with GCC 4.7.2 Summary: fix opto/library_call.cpp compilation errors Reviewed-by: twisti, coleenp ! src/share/vm/opto/library_call.cpp Changeset: 8580f22db905 Author: coleenp Date: 2012-12-14 16:43 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/8580f22db905 Merge Changeset: 3f84e17b6bca Author: zgu Date: 2012-12-17 13:14 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/3f84e17b6bca 8004802: jcmd VM.native_memory baseline=false crashes VM Summary: NMT has to check option's value also to determine which command to execute Reviewed-by: acorn, coleenp, hseigel ! src/share/vm/services/nmtDCmd.cpp Changeset: 805aa223d540 Author: zgu Date: 2012-12-17 10:40 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/805aa223d540 Merge Changeset: 594b9b2119ed Author: minqi Date: 2012-12-19 16:10 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/594b9b2119ed Merge Changeset: 0c535211ef13 Author: bharadwaj Date: 2012-12-07 18:13 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/0c535211ef13 8004668: Build failure for Zero target Summary: fixed build failure for Zero target Reviewed-by: twisti, kvn ! src/cpu/zero/vm/assembler_zero.cpp Changeset: a70c88896791 Author: kvn Date: 2012-12-13 17:27 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/a70c88896791 8004713: Stackoverflowerror thrown when thread stack straddles 0x80000000 Summary: use unsigned comparison when checking for stack overflow Reviewed-by: kvn, twisti Contributed-by: paul.nauman at oracle.com ! src/cpu/sparc/vm/templateInterpreter_sparc.cpp Changeset: 1b1e16471e46 Author: stefank Date: 2012-12-12 22:41 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/1b1e16471e46 8005002: Crash because of a raw oop in ClassLoaderData::add_dependency Summary: Move the handelization of 'last' to a point before the GC might enter. Reviewed-by: dholmes, sspitsyn, coleenp ! src/share/vm/classfile/classLoaderData.cpp Changeset: 5c0931d15474 Author: twisti Date: 2012-12-14 12:06 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/5c0931d15474 8003238: JSR 292: intermittent exception failure with java/lang/invoke/CallSiteTest.java Reviewed-by: jrose, kvn ! src/share/vm/prims/methodHandles.cpp Changeset: 3c433d080bae Author: twisti Date: 2012-12-14 12:11 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/3c433d080bae Merge Changeset: 18d56ca3e901 Author: twisti Date: 2012-12-17 11:00 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/18d56ca3e901 8004548: remove unused AbstractAssembler::print(Label&) Reviewed-by: kvn, twisti Contributed-by: Bharadwaj Yadavalli ! src/cpu/sparc/vm/macroAssembler_sparc.cpp ! src/cpu/sparc/vm/macroAssembler_sparc.hpp ! src/cpu/sparc/vm/macroAssembler_sparc.inline.hpp ! src/cpu/x86/vm/macroAssembler_x86.hpp ! src/cpu/zero/vm/assembler_zero.cpp ! src/cpu/zero/vm/assembler_zero.hpp ! src/share/vm/asm/assembler.cpp ! src/share/vm/asm/assembler.hpp Changeset: ad5dd04754ee Author: roland Date: 2012-12-18 14:55 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/ad5dd04754ee 8005031: Some cleanup in c2 to prepare for incremental inlining support Summary: collection of small changes to prepare for incremental inlining. Reviewed-by: twisti, kvn ! src/share/vm/ci/ciField.cpp ! src/share/vm/compiler/compilerOracle.cpp ! src/share/vm/opto/addnode.cpp ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/callGenerator.cpp ! src/share/vm/opto/callGenerator.hpp ! src/share/vm/opto/callnode.cpp ! src/share/vm/opto/cfgnode.cpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/doCall.cpp ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/stringopts.cpp Changeset: eb409f2f146e Author: vlivanov Date: 2012-12-18 06:52 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/eb409f2f146e 8003135: HotSpot inlines and hoists the Thread.currentThread().isInterrupted() out of the loop Summary: Make the load of TLS._osthread._interrupted flag in Thread.isInterrupted(Z)Z intrinsic effectively volatile. Reviewed-by: kvn, jrose ! src/share/vm/opto/library_call.cpp Changeset: 620e502e3f47 Author: vlivanov Date: 2012-12-18 08:19 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/620e502e3f47 Merge ! src/share/vm/opto/library_call.cpp Changeset: c4bd2eccea46 Author: twisti Date: 2012-12-18 10:47 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/c4bd2eccea46 8004536: replace AbstractAssembler emit_word with emit_int16 Reviewed-by: jrose, kvn, twisti Contributed-by: Morris Meyer ! src/cpu/x86/vm/assembler_x86.cpp ! src/share/vm/asm/assembler.hpp Changeset: 1e41b0bc58a0 Author: kvn Date: 2012-12-18 17:37 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/1e41b0bc58a0 8004318: JEP-171: Support Unsafe fences intrinsics Summary: Add three memory-ordering intrinsics to the sun.misc.Unsafe class. Reviewed-by: twisti, kvn Contributed-by: Aleksey Shipilev ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/c1/c1_LIRGenerator.cpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/prims/unsafe.cpp Changeset: 65c8342f726a Author: twisti Date: 2012-12-19 14:44 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/65c8342f726a 8005033: clear high word for integer pop count on SPARC Reviewed-by: kvn, twisti Contributed-by: Richard Reingruber ! src/cpu/sparc/vm/sparc.ad + test/compiler/8005033/Test8005033.java Changeset: 2c7f594145dc Author: kvn Date: 2012-12-19 15:40 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/2c7f594145dc 8004835: Improve AES intrinsics on x86 Summary: Enable AES intrinsics on non-AVX cpus, group together aes instructions in crypto stubs. Reviewed-by: roland, twisti ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/macroAssembler_x86.cpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/cpu/x86/vm/vm_version_x86.cpp ! test/compiler/7184394/TestAESBase.java ! test/compiler/7184394/TestAESMain.java Changeset: 2d6c433b1f38 Author: kvn Date: 2012-12-19 19:21 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/2d6c433b1f38 8004741: Missing compiled exception handle table entry for multidimensional array allocation Summary: Added missing exception path for multidimensional array allocation and use Throwable type instead of OutOfMemoryError for allocation's exception. Reviewed-by: twisti ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/parse3.cpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/opto/runtime.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/thread.cpp + test/compiler/8004741/Test8004741.java Changeset: a46457045d66 Author: kvn Date: 2012-12-20 14:17 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/a46457045d66 8004330: Add missing Unsafe entry points for addAndGet() family Summary: Fix java names for getAndSet intrinsics Reviewed-by: kvn Contributed-by: aleksey.shipilev at oracle.com ! src/share/vm/classfile/vmSymbols.hpp Changeset: d02120b7a34f Author: twisti Date: 2012-12-20 18:53 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/d02120b7a34f 8004250: replace AbstractAssembler a_byte/a_long with emit_int8/emit_int32 Reviewed-by: jrose, kvn, twisti Contributed-by: Morris Meyer ! src/cpu/sparc/vm/c1_CodeStubs_sparc.cpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/c1_CodeStubs_x86.cpp ! src/cpu/x86/vm/macroAssembler_x86.cpp ! src/cpu/zero/vm/assembler_zero.cpp ! src/os_cpu/solaris_x86/vm/assembler_solaris_x86.cpp ! src/os_cpu/windows_x86/vm/assembler_windows_x86.cpp ! src/share/vm/asm/assembler.cpp ! src/share/vm/asm/assembler.hpp Changeset: c52660592f37 Author: roland Date: 2012-12-21 01:39 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/c52660592f37 Merge ! src/cpu/sparc/vm/templateInterpreter_sparc.cpp ! src/share/vm/classfile/classLoaderData.cpp ! src/share/vm/opto/library_call.cpp Changeset: 0b3d19153cc6 Author: johnc Date: 2012-12-12 12:07 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/0b3d19153cc6 8001028: Improve GC option handling Summary: If there are not enough native resources to create the ReferenceHandler or Finalizer Java threads, the VM will attempt to throw an OOME before the java.lang.Class class has been initialized. This can result in assertion failures and other crashes. Move the initialization of the java.lang.Class class to just before the initialization of the java.lang.ref.Finalizer class. Reviewed-by: jwilhelm, dholmes, coleenp ! src/share/vm/runtime/thread.cpp Changeset: 730cc4ddd550 Author: brutisso Date: 2012-12-17 08:49 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/730cc4ddd550 7173959: Jvm crashed during coherence exabus (tmb) testing Summary: Mapping of aligned memory needs to be MT safe. Also reviewed by: vitalyd at gmail.com Reviewed-by: dholmes, coleenp, zgu ! src/os/posix/vm/os_posix.cpp ! src/os/windows/vm/os_windows.cpp ! src/share/vm/runtime/os.hpp ! src/share/vm/runtime/virtualspace.cpp Changeset: 32164d89fe9c Author: brutisso Date: 2012-12-17 15:25 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/32164d89fe9c 8004845: Catch incorrect usage of new and delete during compile time for value objects and stack objects Summary: Makes the "new" and "delete" operator of _ValueObj and StackObj private Reviewed-by: dholmes, coleenp Contributed-by: erik.helin at oracle.com ! src/share/vm/memory/allocation.hpp ! src/share/vm/opto/node.cpp ! src/share/vm/services/memBaseline.hpp ! src/share/vm/utilities/workgroup.hpp ! src/share/vm/utilities/yieldingWorkgroup.hpp Changeset: c71879335291 Author: stefank Date: 2012-12-18 10:40 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/c71879335291 8005108: NPG: MetaspaceAux::used_in_bytes(), capacity_in_bytes() and reserved_in_bytes() return inconsistent numbers Summary: Reverted the changes to these functions from JDK-8000662 Reviewed-by: brutisso, jmasa ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/metaspace.hpp Changeset: 345bd97a77be Author: brutisso Date: 2012-12-20 05:31 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/345bd97a77be 8004691: Add a jtreg test that exercises the ExecuteInternalVMTests flag Reviewed-by: stefank, brutisso, kvn, ctornqvi Contributed-by: erik.helin at oracle.com + test/sanity/ExecuteInternalVMTests.java Changeset: 69627aa9ab10 Author: jwilhelm Date: 2012-12-21 16:33 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/69627aa9ab10 Merge ! src/share/vm/runtime/thread.cpp Changeset: 990bbd393c23 Author: amurillo Date: 2012-12-21 10:17 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/990bbd393c23 Merge Changeset: 6a1fc440b396 Author: amurillo Date: 2012-12-21 10:17 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/6a1fc440b396 Added tag hs25-b14 for changeset 990bbd393c23 ! .hgtags Changeset: 79f492f184d0 Author: katleman Date: 2012-12-20 16:24 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/79f492f184d0 8004982: JDK8 source with GPL header errors Reviewed-by: ohair ! agent/src/share/classes/sun/jvm/hotspot/ci/ciArrayKlass.java ! agent/src/share/classes/sun/jvm/hotspot/ci/ciField.java ! agent/src/share/classes/sun/jvm/hotspot/ci/ciInstance.java ! agent/src/share/classes/sun/jvm/hotspot/ci/ciKlass.java ! agent/src/share/classes/sun/jvm/hotspot/ci/ciMetadata.java ! agent/src/share/classes/sun/jvm/hotspot/ci/ciObjArrayKlass.java ! agent/src/share/classes/sun/jvm/hotspot/ci/ciObject.java ! agent/src/share/classes/sun/jvm/hotspot/ci/ciObjectFactory.java ! agent/src/share/classes/sun/jvm/hotspot/ci/ciReceiverTypeData.java ! agent/src/share/classes/sun/jvm/hotspot/ci/ciSymbol.java ! agent/src/share/classes/sun/jvm/hotspot/ci/ciType.java ! agent/src/share/classes/sun/jvm/hotspot/ci/ciTypeArrayKlass.java ! agent/src/share/classes/sun/jvm/hotspot/ci/ciVirtualCallData.java ! agent/src/share/classes/sun/jvm/hotspot/classfile/ClassLoaderData.java ! agent/src/share/classes/sun/jvm/hotspot/memory/LoaderConstraintTable.java ! agent/src/share/classes/sun/jvm/hotspot/oops/BitData.java ! agent/src/share/classes/sun/jvm/hotspot/oops/ProfileData.java ! agent/src/share/classes/sun/jvm/hotspot/oops/RetData.java ! agent/src/share/classes/sun/jvm/hotspot/opto/Block.java ! agent/src/share/classes/sun/jvm/hotspot/opto/Block_Array.java ! agent/src/share/classes/sun/jvm/hotspot/opto/Block_List.java ! agent/src/share/classes/sun/jvm/hotspot/opto/CallDynamicJavaNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/CallJavaNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/CallNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/CallRuntimeNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/CallStaticJavaNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/Compile.java ! agent/src/share/classes/sun/jvm/hotspot/opto/HaltNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/InlineTree.java ! agent/src/share/classes/sun/jvm/hotspot/opto/JVMState.java ! agent/src/share/classes/sun/jvm/hotspot/opto/LoopNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/MachCallJavaNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/MachCallNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/MachCallRuntimeNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/MachCallStaticJavaNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/MachIfNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/MachNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/MachReturnNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/MachSafePointNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/MultiNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/Node.java ! agent/src/share/classes/sun/jvm/hotspot/opto/Node_Array.java ! agent/src/share/classes/sun/jvm/hotspot/opto/Node_List.java ! agent/src/share/classes/sun/jvm/hotspot/opto/Phase.java ! agent/src/share/classes/sun/jvm/hotspot/opto/PhaseCFG.java ! agent/src/share/classes/sun/jvm/hotspot/opto/PhaseRegAlloc.java ! agent/src/share/classes/sun/jvm/hotspot/opto/PhiNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/ProjNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/RegionNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/RootNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/SafePointNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/TypeNode.java ! agent/src/share/classes/sun/jvm/hotspot/prims/JvmtiExport.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/GenericGrowableArray.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/GrowableArray.java ! agent/src/share/native/sadis.c ! src/share/vm/classfile/classLoaderData.hpp ! src/share/vm/memory/metaspaceCounters.cpp ! src/share/vm/memory/metaspaceCounters.hpp ! src/share/vm/runtime/os_ext.hpp ! src/share/vm/services/diagnosticArgument.cpp ! src/share/vm/services/diagnosticCommand_ext.hpp ! src/share/vm/services/memReporter.cpp ! src/share/vm/services/memReporter.hpp ! test/runtime/7158804/Test7158804.sh Changeset: e94068d4ff52 Author: katleman Date: 2012-12-26 14:23 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/e94068d4ff52 Merge ! src/share/vm/classfile/classLoaderData.hpp Changeset: 0847210f8548 Author: katleman Date: 2012-12-27 12:14 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/0847210f8548 Added tag jdk8-b70 for changeset e94068d4ff52 ! .hgtags Changeset: d5cb5830f570 Author: katleman Date: 2013-01-03 12:44 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/d5cb5830f570 Added tag jdk8-b71 for changeset 0847210f8548 ! .hgtags Changeset: 11619f33cd68 Author: katleman Date: 2013-01-10 09:55 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/11619f33cd68 Added tag jdk8-b72 for changeset d5cb5830f570 ! .hgtags Changeset: cd962e15c08e Author: amurillo Date: 2012-12-21 10:27 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/cd962e15c08e 8005382: new hotspot build - hs25-b15 Reviewed-by: jcoomes ! make/hotspot_version Changeset: e51c9860cf66 Author: jmasa Date: 2012-12-03 15:09 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/e51c9860cf66 8005082: NPG: Add specialized Metachunk sizes for reflection and anonymous classloaders Reviewed-by: johnc, coleenp ! src/share/vm/classfile/classLoaderData.cpp ! src/share/vm/memory/binaryTreeDictionary.cpp ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/memory/metachunk.cpp ! src/share/vm/memory/metachunk.hpp ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/metaspace.hpp ! src/share/vm/runtime/globals.hpp Changeset: 1de1b145f6bc Author: jmasa Date: 2012-12-26 15:05 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/1de1b145f6bc 8005486: NPG: Incorrect assertion in ChunkManager::list_index() Reviewed-by: coleenp ! src/share/vm/memory/metaspace.cpp Changeset: b735136e0d82 Author: johnc Date: 2013-01-02 11:32 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/b735136e0d82 8004132: SerialGC: ValidateMarkSweep broken when running GCOld Summary: Remove bit-rotten ValidateMarkSweep functionality and flag. Reviewed-by: johnc, jmasa Contributed-by: tamao ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp ! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweepDecorator.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp ! src/share/vm/gc_implementation/shared/markSweep.cpp ! src/share/vm/gc_implementation/shared/markSweep.hpp ! src/share/vm/gc_implementation/shared/markSweep.inline.hpp ! src/share/vm/memory/genMarkSweep.cpp ! src/share/vm/memory/space.cpp ! src/share/vm/memory/space.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/utilities/debug.cpp Changeset: 37f7535e5f18 Author: johnc Date: 2012-12-21 11:45 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/37f7535e5f18 8001424: G1: Rename certain G1-specific flags Summary: Rename G1DefaultMinNewGenPercent, G1DefaultMaxNewGenPercent, and G1OldCSetRegionLiveThresholdPercent to G1NewSizePercent, G1MaxNewSizePercent, and G1MixedGCLiveThresholdPercent respectively. The previous names are no longer accepted. Reviewed-by: brutisso, ysr ! src/share/vm/gc_implementation/g1/collectionSetChooser.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/gc_implementation/g1/g1_globals.hpp Changeset: d275c3dc73e6 Author: johnc Date: 2013-01-03 16:28 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/d275c3dc73e6 8004816: G1: Kitchensink failures after marking stack changes Summary: Reset the marking state, including the mark stack overflow flag, in the event of a marking stack overflow during serial reference processing. Reviewed-by: jmasa ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/concurrentMarkThread.cpp Changeset: ca0a78017dc7 Author: brutisso Date: 2012-12-30 08:47 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/ca0a78017dc7 8005396: Use ParNew with only one thread instead of DefNew as default for CMS on single CPU machines Reviewed-by: jmasa, jcoomes ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsCollectorPolicy.cpp ! src/share/vm/gc_implementation/parNew/parNewGeneration.cpp ! src/share/vm/gc_implementation/parNew/parNewGeneration.hpp ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/memory/tenuredGeneration.cpp ! src/share/vm/runtime/arguments.cpp Changeset: e0ab18eafbde Author: brutisso Date: 2013-01-04 11:10 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/e0ab18eafbde 8003820: Deprecate untested and rarely used GC combinations Summary: Log warning messages for DefNew+CMS and ParNew+SerialOld Reviewed-by: ysr, jwilhelm, jcoomes ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/arguments.hpp Changeset: c98b676a98b4 Author: brutisso Date: 2013-01-04 21:33 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/c98b676a98b4 8003822: Deprecate the incremental mode of CMS Reviewed-by: johnc, jwilhelm ! src/share/vm/runtime/arguments.cpp Changeset: 6e9174173e00 Author: jmasa Date: 2013-01-04 17:04 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/6e9174173e00 8000325: Change default for CMSClassUnloadingEnabled to true Reviewed-by: stefank, ysr ! src/share/vm/runtime/globals.hpp Changeset: 0b54ffe4c2d3 Author: jmasa Date: 2013-01-04 17:04 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/0b54ffe4c2d3 8005672: Clean up some changes to GC logging with GCCause's Reviewed-by: johnc, ysr ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/parallelScavenge/psYoungGen.cpp ! src/share/vm/gc_interface/gcCause.hpp Changeset: 7d42f3b08300 Author: dcubed Date: 2012-12-19 10:35 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/7d42f3b08300 8005044: remove crufty '_g' support from HS runtime code Summary: Phase 2 is removing '_g' support from the Runtime code. Reviewed-by: dcubed, coleenp, hseigel Contributed-by: ron.durbin at oracle.com ! src/os/bsd/vm/os_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp ! src/share/tools/ProjectCreator/ProjectCreator.java ! src/share/vm/runtime/arguments.cpp Changeset: 35431a769282 Author: stefank Date: 2012-12-20 10:22 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/35431a769282 8004823: Add VM support for type annotation reflection Reviewed-by: dholmes, coleenp Contributed-by: joel.franck at oracle.com ! make/bsd/makefiles/mapfile-vers-debug ! make/bsd/makefiles/mapfile-vers-product ! make/linux/makefiles/mapfile-vers-debug ! make/linux/makefiles/mapfile-vers-product ! make/solaris/makefiles/mapfile-vers ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/classFileParser.hpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/oops/annotations.cpp ! src/share/vm/oops/annotations.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/method.hpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvm.h ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! src/share/vm/runtime/fieldDescriptor.cpp ! src/share/vm/runtime/fieldDescriptor.hpp ! src/share/vm/runtime/reflection.cpp Changeset: 4daebd4cc1dd Author: minqi Date: 2012-12-24 11:46 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/4daebd4cc1dd Merge ! src/os/windows/vm/os_windows.cpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/oops/method.hpp ! src/share/vm/runtime/arguments.cpp Changeset: cc6a617fffd2 Author: coleenp Date: 2013-01-02 20:28 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/cc6a617fffd2 8005494: SIGSEGV in Rewriter::relocate_and_link() when testing Weblogic with CompressedOops and KlassPtrs Summary: Relocate functions with jsr's when rewriting so not repeated after reading shared archive Reviewed-by: twisti, jrose ! src/share/vm/interpreter/rewriter.cpp ! src/share/vm/interpreter/rewriter.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! src/share/vm/runtime/handles.inline.hpp Changeset: 6c3f47d964f3 Author: hseigel Date: 2013-01-07 15:32 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/6c3f47d964f3 8003705: CDS failed on Windows: can not map in the CDS. Summary: Map memory only once to prevent 'already mapped' failures. Reviewed-by: acorn, zgu ! src/share/vm/memory/filemap.cpp ! src/share/vm/memory/metaspaceShared.cpp Changeset: 561148896559 Author: hseigel Date: 2013-01-08 13:38 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/561148896559 8005076: Creating a CDS archive with one alignment and running another causes a crash. Summary: Save the alignment when writing the CDS and compare it when reading the CDS. Reviewed-by: kvn, coleenp ! src/share/vm/memory/filemap.cpp ! src/share/vm/memory/filemap.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: ade95d680b42 Author: coleenp Date: 2013-01-08 14:01 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/ade95d680b42 8004728: Add hotspot support for parameter reflection Summary: Add hotspot support for parameter reflection Reviewed-by: acorn, jrose, coleenp Contributed-by: eric.mccorkle at oracle.com ! make/bsd/makefiles/mapfile-vers-debug ! make/bsd/makefiles/mapfile-vers-product ! make/linux/makefiles/mapfile-vers-debug ! make/linux/makefiles/mapfile-vers-product ! make/solaris/makefiles/mapfile-vers ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/classFileStream.cpp ! src/share/vm/classfile/classFileStream.hpp ! src/share/vm/classfile/defaultMethods.cpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/oops/constMethod.cpp ! src/share/vm/oops/constMethod.hpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/method.hpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvm.h ! src/share/vm/runtime/reflection.cpp ! src/share/vm/runtime/reflection.hpp Changeset: 185a2c979a0e Author: coleenp Date: 2013-01-08 13:44 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/185a2c979a0e Merge Changeset: ecd24264898b Author: zgu Date: 2013-01-08 14:04 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/ecd24264898b 8005048: NMT: #loaded classes needs to just show the # defined classes Summary: Count number of instance classes so that it matches class metadata size Reviewed-by: coleenp, acorn ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/services/memBaseline.cpp ! src/share/vm/services/memRecorder.cpp ! src/share/vm/services/memRecorder.hpp ! src/share/vm/services/memSnapshot.cpp ! src/share/vm/services/memSnapshot.hpp ! src/share/vm/services/memTrackWorker.cpp ! src/share/vm/services/memTrackWorker.hpp ! src/share/vm/services/memTracker.cpp ! src/share/vm/services/memTracker.hpp Changeset: 37a3e8b7a1e9 Author: zgu Date: 2013-01-08 11:39 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/37a3e8b7a1e9 Merge ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp Changeset: 0c93d4818214 Author: zgu Date: 2013-01-08 15:47 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/0c93d4818214 Merge Changeset: 1f6d10b4cc0c Author: acorn Date: 2013-01-09 18:06 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/1f6d10b4cc0c Merge ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: 608b2e8a0063 Author: bpittore Date: 2013-01-03 15:08 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/608b2e8a0063 8004051: assert(_oprs_len[mode] < maxNumberOfOperands) failed: array overflow Summary: assert is triggered when number of register based arguments passed to a java method exceeds 16. Reviewed-by: roland, vladidan ! src/share/vm/c1/c1_LIR.hpp Changeset: 0c8717a92b2d Author: jiangli Date: 2013-01-08 13:01 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/0c8717a92b2d 8001341: SIGSEGV in methodOopDesc::fast_exception_handler_bci_for(KlassHandle,int,Thread*)+0x3e9. Summary: Use methodHandle. Reviewed-by: coleenp, acorn, twisti, sspitsyn ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/method.hpp ! src/share/vm/prims/jvmtiExport.cpp ! src/share/vm/runtime/sharedRuntime.cpp Changeset: 18c3c3fa291b Author: dlong Date: 2013-01-09 21:18 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/18c3c3fa291b Merge ! src/share/vm/oops/method.cpp ! src/share/vm/oops/method.hpp Changeset: 4c8bf5e55392 Author: brutisso Date: 2013-01-09 09:48 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/4c8bf5e55392 8005489: VM hangs during GC with ParallelGC and ParallelGCThreads=0 Summary: Print an error message and exit the VM if UseParallalGC is combined with ParllelGCThreads==0. Also reviewed by vitalyd at gmail.com. Reviewed-by: stefank, ehelin ! src/share/vm/runtime/arguments.cpp Changeset: b2fef6b220e9 Author: jmasa Date: 2013-01-10 07:32 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/b2fef6b220e9 Merge ! src/share/vm/runtime/arguments.cpp Changeset: d092d1b31229 Author: roland Date: 2012-12-23 17:08 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/d092d1b31229 8005071: Incremental inlining for JSR 292 Summary: post parse inlining driven by number of live nodes. Reviewed-by: twisti, kvn, jrose ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/opto/callGenerator.cpp ! src/share/vm/opto/callGenerator.hpp ! src/share/vm/opto/callnode.cpp ! src/share/vm/opto/callnode.hpp ! src/share/vm/opto/cfgnode.cpp ! src/share/vm/opto/cfgnode.hpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/doCall.cpp ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/parse.hpp ! src/share/vm/opto/phaseX.cpp ! src/share/vm/opto/phaseX.hpp ! src/share/vm/opto/stringopts.cpp ! src/share/vm/runtime/arguments.cpp Changeset: 00af3a3a8df4 Author: kvn Date: 2013-01-03 15:09 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/00af3a3a8df4 8005522: use fast-string instructions on x86 for zeroing Summary: use 'rep stosb' instead of 'rep stosq' when fast-string operations are available. Reviewed-by: twisti, roland ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/globals_x86.hpp ! src/cpu/x86/vm/macroAssembler_x86.cpp ! src/cpu/x86/vm/macroAssembler_x86.hpp ! src/cpu/x86/vm/vm_version_x86.cpp ! src/cpu/x86/vm/vm_version_x86.hpp ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/share/vm/opto/memnode.cpp Changeset: e2e6bf86682c Author: kvn Date: 2013-01-03 16:30 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/e2e6bf86682c 8005544: Use 256bit YMM registers in arraycopy stubs on x86 Summary: Use YMM registers in arraycopy and array_fill stubs. Reviewed-by: roland, twisti ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/macroAssembler_x86.cpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp Changeset: ffa87474d7a4 Author: twisti Date: 2013-01-07 14:08 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/ffa87474d7a4 8004537: replace AbstractAssembler emit_long with emit_int32 Reviewed-by: jrose, kvn, twisti Contributed-by: Morris Meyer ! src/cpu/sparc/vm/assembler_sparc.hpp ! src/cpu/sparc/vm/assembler_sparc.inline.hpp ! src/cpu/sparc/vm/cppInterpreter_sparc.cpp ! src/cpu/sparc/vm/macroAssembler_sparc.cpp ! src/cpu/sparc/vm/templateInterpreter_sparc.cpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/macroAssembler_x86.cpp ! src/share/vm/asm/assembler.hpp Changeset: 038dd2875b94 Author: kvn Date: 2013-01-08 11:30 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/038dd2875b94 8005419: Improve intrinsics code performance on x86 by using AVX2 Summary: use 256bit vpxor,vptest instructions in String.compareTo() and equals() intrinsics. Reviewed-by: twisti ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/macroAssembler_x86.cpp ! src/cpu/x86/vm/macroAssembler_x86.hpp + test/compiler/8005419/Test8005419.java Changeset: 5698813d45eb Author: twisti Date: 2013-01-09 15:37 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/5698813d45eb 8005418: JSR 292: virtual dispatch bug in 292 impl Reviewed-by: jrose, kvn ! src/share/vm/opto/callGenerator.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/doCall.cpp ! src/share/vm/opto/parse.hpp ! src/share/vm/opto/parse1.cpp Changeset: f1c06dcee0b5 Author: kvn Date: 2013-01-10 10:00 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/f1c06dcee0b5 Merge ! src/share/vm/runtime/arguments.cpp Changeset: 1e129851479e Author: amurillo Date: 2013-01-11 01:43 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/1e129851479e Merge Changeset: b5e6bec76f4a Author: amurillo Date: 2013-01-11 01:43 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/b5e6bec76f4a Added tag hs25-b15 for changeset 1e129851479e ! .hgtags Changeset: 41ccb2e737fb Author: katleman Date: 2013-01-16 11:59 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/41ccb2e737fb Added tag jdk8-b73 for changeset 11619f33cd68 ! .hgtags Changeset: 1a3e54283c54 Author: katleman Date: 2013-01-16 20:53 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/1a3e54283c54 Merge ! .hgtags From james.laskey at oracle.com Mon Jan 28 12:37:44 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Mon, 28 Jan 2013 20:37:44 +0000 Subject: hg: nashorn/jdk8/jdk: 217 new changesets Message-ID: <20130128211812.00E7B47626@hg.openjdk.java.net> Changeset: 7004848974a2 Author: jgish Date: 2012-12-04 20:21 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/7004848974a2 8003596: TEST_BUG: java/util/logging/CheckLockLocationTest.java failing [win] Reviewed-by: alanb ! test/ProblemList.txt ! test/java/util/logging/CheckLockLocationTest.java Changeset: 44ae777564eb Author: mullan Date: 2012-12-04 17:40 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/44ae777564eb 8004188: Rename src/share/lib/security/java.security to java.security-linux Reviewed-by: mullan, mchung Contributed-by: jason.uh at oracle.com ! make/java/security/Makefile - src/share/lib/security/java.security + src/share/lib/security/java.security-linux Changeset: b54a5b7d2e65 Author: alanb Date: 2012-12-05 12:20 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/b54a5b7d2e65 8004491: Build breakage on Linux due to 8004188 Reviewed-by: chegar, erikj ! makefiles/CopyFiles.gmk Changeset: a971516029ab Author: jgish Date: 2012-12-05 21:08 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/a971516029ab 8004317: TestLibrary.getUnusedRandomPort() fails intermittently, but exception not reported Reviewed-by: alanb, dmocek, smarks ! test/java/rmi/testlibrary/TestLibrary.java Changeset: 41a1b110f34d Author: lancea Date: 2012-12-06 15:51 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/41a1b110f34d 8004374: CachedRowSetSwriter.writeData reports wrong number of conflicts in SyncProviderException Reviewed-by: naoto ! src/share/classes/com/sun/rowset/internal/CachedRowSetWriter.java Changeset: 896d4af2ebfd Author: rfield Date: 2012-12-06 21:55 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/896d4af2ebfd 8003881: Prevent lambda implementing inner classes from allowing the creation of new instances Summary: Lambda implementing inner classes now has private constructor (thanks Kumar) Reviewed-by: ksrini ! src/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java + test/java/lang/invoke/lambda/LambdaAccessControlDoPrivilegedTest.java + test/java/lang/invoke/lambda/LambdaAccessControlTest.java Changeset: da387f0cecb7 Author: ksrini Date: 2012-12-09 07:43 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/da387f0cecb7 8004042: Arrrghs.java test failed on windows with access error. Reviewed-by: smarks, jjh, ksrini Contributed-by: david.dehaven at oracle.com ! test/tools/launcher/Arrrghs.java ! test/tools/launcher/TestHelper.java Changeset: 343615aa0539 Author: dxu Date: 2012-12-09 19:13 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/343615aa0539 7194370: (fs) WatchService fails if volume S/N is 0 [win] Reviewed-by: alanb, forax ! src/windows/classes/sun/nio/fs/WindowsFileAttributes.java Changeset: fda257689786 Author: okutsu Date: 2012-12-10 10:52 +0900 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/fda257689786 8000983: Support narrow display names for calendar fields 8003267: Support generic time zone names in TimeZoneNameProvider (SPI) Reviewed-by: naoto ! make/tools/src/build/tools/cldrconverter/Bundle.java ! make/tools/src/build/tools/cldrconverter/BundleGenerator.java ! make/tools/src/build/tools/cldrconverter/CLDRConverter.java ! make/tools/src/build/tools/cldrconverter/LDMLParseHandler.java ! make/tools/src/build/tools/cldrconverter/MetaZonesParseHandler.java ! make/tools/src/build/tools/cldrconverter/ResourceBundleGenerator.java ! src/share/classes/java/text/DateFormatSymbols.java ! src/share/classes/java/text/SimpleDateFormat.java ! src/share/classes/java/util/Calendar.java ! src/share/classes/java/util/JapaneseImperialCalendar.java ! src/share/classes/java/util/TimeZone.java ! src/share/classes/java/util/spi/CalendarNameProvider.java ! src/share/classes/java/util/spi/TimeZoneNameProvider.java ! src/share/classes/sun/text/resources/FormatData.java ! src/share/classes/sun/text/resources/ar/FormatData_ar.java ! src/share/classes/sun/text/resources/be/FormatData_be.java ! src/share/classes/sun/text/resources/bg/FormatData_bg.java ! src/share/classes/sun/text/resources/ca/FormatData_ca.java ! src/share/classes/sun/text/resources/cs/FormatData_cs.java ! src/share/classes/sun/text/resources/da/FormatData_da.java ! src/share/classes/sun/text/resources/de/FormatData_de.java ! src/share/classes/sun/text/resources/el/FormatData_el.java ! src/share/classes/sun/text/resources/es/FormatData_es.java ! src/share/classes/sun/text/resources/et/FormatData_et.java ! src/share/classes/sun/text/resources/fi/FormatData_fi.java ! src/share/classes/sun/text/resources/fr/FormatData_fr.java ! src/share/classes/sun/text/resources/hi/FormatData_hi_IN.java ! src/share/classes/sun/text/resources/hr/FormatData_hr.java ! src/share/classes/sun/text/resources/hu/FormatData_hu.java ! src/share/classes/sun/text/resources/is/FormatData_is.java ! src/share/classes/sun/text/resources/it/FormatData_it.java ! src/share/classes/sun/text/resources/iw/FormatData_iw.java ! src/share/classes/sun/text/resources/ja/FormatData_ja.java ! src/share/classes/sun/text/resources/ko/FormatData_ko.java ! src/share/classes/sun/text/resources/lt/FormatData_lt.java ! src/share/classes/sun/text/resources/lv/FormatData_lv.java ! src/share/classes/sun/text/resources/mk/FormatData_mk.java ! src/share/classes/sun/text/resources/ms/FormatData_ms.java ! src/share/classes/sun/text/resources/mt/FormatData_mt.java ! src/share/classes/sun/text/resources/nl/FormatData_nl.java ! src/share/classes/sun/text/resources/pl/FormatData_pl.java ! src/share/classes/sun/text/resources/pt/FormatData_pt.java ! src/share/classes/sun/text/resources/ro/FormatData_ro.java ! src/share/classes/sun/text/resources/ru/FormatData_ru.java ! src/share/classes/sun/text/resources/sk/FormatData_sk.java ! src/share/classes/sun/text/resources/sl/FormatData_sl.java ! src/share/classes/sun/text/resources/sq/FormatData_sq.java ! src/share/classes/sun/text/resources/sr/FormatData_sr.java ! src/share/classes/sun/text/resources/sv/FormatData_sv.java ! src/share/classes/sun/text/resources/th/FormatData_th.java ! src/share/classes/sun/text/resources/tr/FormatData_tr.java ! src/share/classes/sun/text/resources/uk/FormatData_uk.java ! src/share/classes/sun/text/resources/vi/FormatData_vi.java ! src/share/classes/sun/text/resources/zh/FormatData_zh.java ! src/share/classes/sun/util/cldr/CLDRLocaleProviderAdapter.java ! src/share/classes/sun/util/locale/provider/CalendarDataUtility.java ! src/share/classes/sun/util/locale/provider/CalendarNameProviderImpl.java ! src/share/classes/sun/util/locale/provider/LocaleResources.java ! src/share/classes/sun/util/locale/provider/SPILocaleProviderAdapter.java ! src/share/classes/sun/util/locale/provider/TimeZoneNameProviderImpl.java ! src/share/classes/sun/util/locale/provider/TimeZoneNameUtility.java ! src/share/classes/sun/util/resources/LocaleData.java ! src/share/classes/sun/util/resources/OpenListResourceBundle.java ! src/share/classes/sun/util/resources/TimeZoneNames.java ! src/share/classes/sun/util/resources/TimeZoneNamesBundle.java + test/java/util/Calendar/GenericTimeZoneNamesTest.java + test/java/util/Calendar/GenericTimeZoneNamesTest.sh + test/java/util/Calendar/NarrowNamesTest.java + test/java/util/Calendar/NarrowNamesTest.sh ! test/java/util/PluggableLocale/GenericTest.java ! test/java/util/PluggableLocale/TimeZoneNameProviderTest.java ! test/java/util/PluggableLocale/TimeZoneNameProviderTest.sh ! test/java/util/PluggableLocale/barprovider.jar + test/java/util/PluggableLocale/providersrc/GenericTimeZoneNameProviderImpl.java ! test/java/util/PluggableLocale/providersrc/Makefile ! test/java/util/PluggableLocale/providersrc/java.util.spi.TimeZoneNameProvider ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java Changeset: fda2b2b5b98b Author: michaelm Date: 2012-12-10 14:56 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/fda2b2b5b98b 8003948: NTLM/Negotiate authentication problem Reviewed-by: chegar, weijun ! src/share/classes/sun/net/www/MessageHeader.java ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java + test/sun/net/www/MessageHeaderTest.java Changeset: cac1bfaceaaa Author: mchung Date: 2012-12-10 15:15 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/cac1bfaceaaa 4819681: Typo in http://java.sun.com/j2se/1.4.1/docs/api/java/util/logging/LogManager.html Summary: Simple capitalization typo in LogManager() description Reviewed-by: darcy, mchung ! src/share/classes/java/util/logging/LogManager.java Changeset: 883feced1cdd Author: dingxmin Date: 2012-12-11 10:42 +0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/883feced1cdd 6512101: Incorrect encoding in NetworkInterface.getDisplayName() Reviewed-by: chegar, dsamersoff ! src/windows/native/java/net/NetworkInterface.c Changeset: d206e52bf8a6 Author: weijun Date: 2012-12-11 13:14 +0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/d206e52bf8a6 8004488: wrong permissions checked in krb5 Reviewed-by: xuelei ! src/share/classes/com/sun/security/auth/module/Krb5LoginModule.java ! src/share/classes/sun/security/jgss/krb5/Krb5Util.java + test/sun/security/krb5/auto/KeyPermissions.java ! test/sun/security/krb5/auto/KeyTabCompat.java Changeset: c4bd81de2868 Author: akhil Date: 2012-12-11 15:33 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/c4bd81de2868 8003246: Add InitialValue Supplier to ThreadLocal Reviewed-by: mduigou, forax, dl, chegar, briangoetz ! src/share/classes/java/lang/ThreadLocal.java + test/java/lang/ThreadLocal/ThreadLocalSupplierTest.java Changeset: 6c795437f212 Author: mduigou Date: 2012-12-11 20:49 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/6c795437f212 8004905: Correct license of test to remove classpath exception Reviewed-by: akhil ! test/java/lang/ThreadLocal/ThreadLocalSupplierTest.java Changeset: 12fba0974a9d Author: weijun Date: 2012-12-12 18:39 +0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/12fba0974a9d 8004904: Makefile for ntlm Reviewed-by: erikj, chegar ! make/com/sun/security/Makefile + make/com/sun/security/ntlm/Makefile Changeset: 806cf26e5063 Author: chegar Date: 2012-12-12 11:35 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/806cf26e5063 8004921: Trivial javadoc warnings in Base64 Reviewed-by: darcy ! src/share/classes/java/util/Base64.java Changeset: 81640e75c7a7 Author: alanb Date: 2012-12-12 13:03 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/81640e75c7a7 8004874: Reduce dependency on java.beans to only add/removePropertyChangeListener Reviewed-by: ksrini, mchung, dholmes ! src/share/classes/com/sun/java/util/jar/pack/PropMap.java ! src/share/classes/java/util/logging/LogManager.java Changeset: 346c0af4af41 Author: mullan Date: 2012-12-12 09:25 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/346c0af4af41 8004064: Downgrade normative references to ${java.home}/lib/security/java.security Reviewed-by: alanb, vinnie, xuelei ! src/share/classes/com/sun/net/ssl/KeyManagerFactory.java ! src/share/classes/com/sun/net/ssl/TrustManagerFactory.java ! src/share/classes/com/sun/security/auth/PolicyFile.java ! src/share/classes/com/sun/security/auth/login/ConfigFile.java ! src/share/classes/java/net/doc-files/net-properties.html ! src/share/classes/java/security/KeyStore.java ! src/share/classes/java/security/Policy.java ! src/share/classes/java/security/Security.java ! src/share/classes/java/security/cert/CertPathBuilder.java ! src/share/classes/java/security/cert/CertPathValidator.java ! src/share/classes/java/security/cert/CertStore.java ! src/share/classes/javax/net/ssl/KeyManagerFactory.java ! src/share/classes/javax/net/ssl/TrustManagerFactory.java ! src/share/classes/javax/security/auth/Policy.java ! src/share/classes/javax/security/auth/callback/CallbackHandler.java ! src/share/classes/javax/security/auth/login/Configuration.java ! src/share/classes/javax/security/auth/login/LoginContext.java ! src/share/classes/javax/security/cert/X509Certificate.java Changeset: c7f86908d5fd Author: mullan Date: 2012-12-12 09:27 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/c7f86908d5fd Merge - src/share/lib/security/java.security Changeset: 68374c6e65c1 Author: robm Date: 2012-12-12 15:57 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/68374c6e65c1 8004337: java/sql tests aren't run in test/Makefile Reviewed-by: lancea, alanb ! test/Makefile Changeset: bd84d0927a2e Author: smarks Date: 2012-12-12 09:53 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/bd84d0927a2e 8004748: clean up @build tags in RMI tests Reviewed-by: alanb, darcy, mchung ! test/java/rmi/MarshalledObject/compare/Compare.java ! test/java/rmi/MarshalledObject/compare/HashCode.java ! test/java/rmi/MarshalledObject/compare/NullReference.java ! test/java/rmi/Naming/DefaultRegistryPort.java ! test/java/rmi/Naming/LookupIPv6.java ! test/java/rmi/Naming/RmiIsNoScheme.java ! test/java/rmi/Naming/UnderscoreHost.java ! test/java/rmi/Naming/legalRegistryNames/LegalRegistryNames.java ! test/java/rmi/RMISecurityManager/checkPackageAccess/CheckPackageAccess.java ! test/java/rmi/activation/Activatable/checkActivateRef/CheckActivateRef.java ! test/java/rmi/activation/Activatable/checkAnnotations/CheckAnnotations.java ! test/java/rmi/activation/Activatable/checkImplClassLoader/CheckImplClassLoader.java ! test/java/rmi/activation/Activatable/checkRegisterInLog/CheckRegisterInLog.java ! test/java/rmi/activation/Activatable/createPrivateActivable/CreatePrivateActivatable.java ! test/java/rmi/activation/Activatable/downloadParameterClass/DownloadParameterClass.java ! test/java/rmi/activation/Activatable/elucidateNoSuchMethod/ElucidateNoSuchMethod.java ! test/java/rmi/activation/Activatable/extLoadedImpl/ext.sh ! test/java/rmi/activation/Activatable/forceLogSnapshot/ForceLogSnapshot.java ! test/java/rmi/activation/Activatable/inactiveGroup/InactiveGroup.java ! test/java/rmi/activation/Activatable/lookupActivationSystem/LookupActivationSystem.java ! test/java/rmi/activation/Activatable/nestedActivate/NestedActivate.java ! test/java/rmi/activation/Activatable/nonExistentActivatable/NonExistentActivatable.java ! test/java/rmi/activation/Activatable/restartCrashedService/RestartCrashedService.java ! test/java/rmi/activation/Activatable/restartLatecomer/RestartLatecomer.java ! test/java/rmi/activation/Activatable/restartService/RestartService.java ! test/java/rmi/activation/Activatable/shutdownGracefully/ShutdownGracefully.java ! test/java/rmi/activation/Activatable/unregisterInactive/UnregisterInactive.java ! test/java/rmi/activation/ActivateFailedException/activateFails/ActivateFails.java ! test/java/rmi/activation/ActivationGroup/downloadActivationGroup/DownloadActivationGroup.java ! test/java/rmi/activation/ActivationGroupDesc/checkDefaultGroupName/CheckDefaultGroupName.java ! test/java/rmi/activation/ActivationSystem/activeGroup/IdempotentActiveGroup.java ! test/java/rmi/activation/ActivationSystem/modifyDescriptor/ModifyDescriptor.java ! test/java/rmi/activation/ActivationSystem/stubClassesPermitted/StubClassesPermitted.java ! test/java/rmi/activation/ActivationSystem/unregisterGroup/UnregisterGroup.java ! test/java/rmi/activation/CommandEnvironment/NullOptions.java ! test/java/rmi/activation/CommandEnvironment/SetChildEnv.java ! test/java/rmi/activation/checkusage/CheckUsage.java ! test/java/rmi/activation/log/LogTest.java ! test/java/rmi/activation/rmidViaInheritedChannel/InheritedChannelNotServerSocket.java ! test/java/rmi/activation/rmidViaInheritedChannel/RmidViaInheritedChannel.java ! test/java/rmi/dgc/VMID/CheckVMID.java ! test/java/rmi/dgc/dgcAckFailure/DGCAckFailure.java ! test/java/rmi/dgc/dgcImplInsulation/DGCImplInsulation.java ! test/java/rmi/dgc/retryDirtyCalls/RetryDirtyCalls.java ! test/java/rmi/invalidName/InvalidName.java ! test/java/rmi/registry/altSecurityManager/AltSecurityManager.java ! test/java/rmi/registry/checkusage/CheckUsage.java ! test/java/rmi/registry/classPathCodebase/ClassPathCodebase.java ! test/java/rmi/registry/interfaceHash/InterfaceHash.java ! test/java/rmi/registry/multipleRegistries/MultipleRegistries.java ! test/java/rmi/registry/readTest/readTest.sh ! test/java/rmi/registry/reexport/Reexport.java ! test/java/rmi/reliability/benchmark/runRmiBench.sh ! test/java/rmi/reliability/benchmark/runSerialBench.sh ! test/java/rmi/reliability/juicer/AppleUserImpl.java ! test/java/rmi/server/ObjID/randomIDs/RandomIDs.java ! test/java/rmi/server/RMIClassLoader/delegateBeforePermissionCheck/DelegateBeforePermissionCheck.java ! test/java/rmi/server/RMIClassLoader/delegateToContextLoader/DelegateToContextLoader.java ! test/java/rmi/server/RMIClassLoader/downloadArrayClass/DownloadArrayClass.java ! test/java/rmi/server/RMIClassLoader/getClassAnnotation/NullClass.java ! test/java/rmi/server/RMIClassLoader/getClassLoader/GetClassLoader.java ! test/java/rmi/server/RMIClassLoader/loadProxyClasses/LoadProxyClasses.java ! test/java/rmi/server/RMIClassLoader/noSecurityManager/NoSecurityManager.java ! test/java/rmi/server/RMIClassLoader/spi/ContextInsulation.java ! test/java/rmi/server/RMIClassLoader/spi/DefaultProperty.java ! test/java/rmi/server/RMIClassLoader/spi/Installed.java ! test/java/rmi/server/RMIClassLoader/spi/InvalidProperty.java ! test/java/rmi/server/RMIClassLoader/spi/Property.java ! test/java/rmi/server/RMIClassLoader/useCodebaseOnly/UseCodebaseOnly.java ! test/java/rmi/server/RMIClassLoader/useGetURLs/UseGetURLs.java ! test/java/rmi/server/RMISocketFactory/useSocketFactory/activatable/UseCustomSocketFactory.java ! test/java/rmi/server/RMISocketFactory/useSocketFactory/registry/UseCustomSocketFactory.java ! test/java/rmi/server/RMISocketFactory/useSocketFactory/unicast/UseCustomSocketFactory.java ! test/java/rmi/server/RemoteObject/notExtending/NotExtending.java ! test/java/rmi/server/RemoteObject/verifyRemoteEquals/VerifyRemoteEquals.java ! test/java/rmi/server/RemoteServer/AddrInUse.java ! test/java/rmi/server/UnicastRemoteObject/changeHostName/ChangeHostName.java ! test/java/rmi/server/UnicastRemoteObject/exportObject/GcDuringExport.java ! test/java/rmi/server/UnicastRemoteObject/keepAliveDuringCall/KeepAliveDuringCall.java ! test/java/rmi/server/UnicastRemoteObject/marshalAfterUnexport/MarshalAfterUnexport.java ! test/java/rmi/server/UnicastRemoteObject/marshalAfterUnexport/MarshalAfterUnexport2.java ! test/java/rmi/server/UnicastRemoteObject/unexportObject/UnexportLeak.java ! test/java/rmi/server/Unmarshal/PrimitiveClasses.java + test/java/rmi/server/Unmarshal/checkUnmarshalOnStopThread/CheckUnmarshal.java ! test/java/rmi/server/Unmarshal/checkUnmarshalOnStopThread/CheckUnmarshalOnStopThread.java - test/java/rmi/server/Unmarshal/checkUnmarshalOnStopThread/CheckUnmarshall.java ! test/java/rmi/server/Unreferenced/finiteGCLatency/FiniteGCLatency.java ! test/java/rmi/server/Unreferenced/leaseCheckInterval/LeaseCheckInterval.java ! test/java/rmi/server/Unreferenced/marshalledObjectGet/MarshalledObjectGet.java ! test/java/rmi/server/Unreferenced/unreferencedContext/UnreferencedContext.java ! test/java/rmi/server/clientStackTrace/ClientStackTrace.java ! test/java/rmi/server/getRemoteClass/GetRemoteClass.java ! test/java/rmi/server/serverStackTrace/ServerStackTrace.java ! test/java/rmi/server/serverStackTrace/SuppressStackTraces.java ! test/java/rmi/server/useCustomRef/UseCustomRef.java ! test/java/rmi/transport/acceptLoop/CloseServerSocketOnTermination.java ! test/java/rmi/transport/checkFQDN/CheckFQDN.java ! test/java/rmi/transport/checkLeaseInfoLeak/CheckLeaseLeak.java ! test/java/rmi/transport/closeServerSocket/CloseServerSocket.java ! test/java/rmi/transport/dgcDeadLock/DGCDeadLock.java ! test/java/rmi/transport/handshakeFailure/HandshakeFailure.java ! test/java/rmi/transport/handshakeTimeout/HandshakeTimeout.java ! test/java/rmi/transport/httpSocket/HttpSocketTest.java ! test/java/rmi/transport/rapidExportUnexport/RapidExportUnexport.java ! test/java/rmi/transport/readTimeout/ReadTimeoutTest.java ! test/java/rmi/transport/reuseDefaultPort/ReuseDefaultPort.java ! test/java/rmi/transport/runtimeThreadInheritanceLeak/RuntimeThreadInheritanceLeak.java ! test/javax/rmi/ssl/SocketFactoryTest.java ! test/sun/rmi/log/ReliableLog/LogAlignmentTest.java ! test/sun/rmi/log/ReliableLog/SnapshotSize.java ! test/sun/rmi/rmic/RMIGenerator/RmicDefault.java ! test/sun/rmi/rmic/newrmic/equivalence/run.sh ! test/sun/rmi/runtime/Log/6409194/NoConsoleOutput.java ! test/sun/rmi/runtime/Log/checkLogging/CheckLogStreams.java ! test/sun/rmi/runtime/Log/checkLogging/CheckLogging.java ! test/sun/rmi/server/MarshalOutputStream/marshalForeignStub/MarshalForeignStub.java ! test/sun/rmi/transport/proxy/EagerHttpFallback.java ! test/sun/rmi/transport/tcp/DeadCachedConnection.java ! test/sun/rmi/transport/tcp/blockAccept/BlockAcceptTest.java ! test/sun/rmi/transport/tcp/disableMultiplexing/DisableMultiplexing.java Changeset: 56fd5479a98f Author: jgish Date: 2012-12-12 15:37 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/56fd5479a98f 8004651: TEST: java/util/logging/CheckLockLocationTest.java failed to delete file (win) Summary: Failure to delete test log file should be a warning instead of test failure Reviewed-by: mduigou, smarks ! test/java/util/logging/CheckLockLocationTest.java Changeset: 5a2ab2c3f106 Author: weijun Date: 2012-12-13 08:11 +0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/5a2ab2c3f106 8004235: Disable native JGSS provider on Mac Reviewed-by: erikj, valeriep ! make/sun/security/Makefile ! makefiles/CompileNativeLibraries.gmk ! src/share/classes/sun/security/jgss/wrapper/SunNativeProvider.java Changeset: 7a8978a5bb6e Author: lancea Date: 2012-12-12 20:57 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/7a8978a5bb6e 8004357: Implement various methods in SerialBlob/Clob/Array and specify Thread Safety Reviewed-by: naoto ! src/share/classes/javax/sql/rowset/serial/SerialArray.java ! src/share/classes/javax/sql/rowset/serial/SerialBlob.java ! src/share/classes/javax/sql/rowset/serial/SerialClob.java ! src/share/classes/javax/sql/rowset/serial/SerialDatalink.java ! src/share/classes/javax/sql/rowset/serial/SerialJavaObject.java ! src/share/classes/javax/sql/rowset/serial/SerialRef.java ! src/share/classes/javax/sql/rowset/serial/SerialStruct.java Changeset: 775b0050144a Author: chegar Date: 2012-12-13 09:55 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/775b0050144a 8004925: java/net/Socks/SocksV4Test.java failing on all platforms Reviewed-by: alanb, dsamersoff ! test/java/net/Socks/SocksV4Test.java Changeset: 682d2d3ccff5 Author: chegar Date: 2012-12-13 14:33 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/682d2d3ccff5 8004675: Inet6Address.getHostAddress should use string scope identifier where available Summary: ...and some minor stylistic cleanup Reviewed-by: khazra, dsamersoff, michaelm ! src/share/classes/java/net/Inet6Address.java ! src/share/native/java/net/Inet6Address.c + test/java/net/Inet6Address/StringScope.java Changeset: c97618a3c8c2 Author: juh Date: 2012-12-13 09:35 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/c97618a3c8c2 7193792: sun/security/pkcs11/ec/TestECDSA.java failing intermittently Reviewed-by: vinnie, wetmore ! test/ProblemList.txt ! test/sun/security/pkcs11/ec/TestECDSA.java Changeset: 7b697da6626a Author: mullan Date: 2012-12-13 09:37 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/7b697da6626a Merge Changeset: ae5d04dbacd6 Author: chegar Date: 2012-12-13 14:47 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/ae5d04dbacd6 8003890: corelibs test scripts should pass TESTVMOPTS Reviewed-by: chegar, alanb Contributed-by: Mark Sheppard ! test/com/oracle/net/sanity.sh ! test/com/sun/corba/cachedSocket/7056731.sh ! test/com/sun/management/OperatingSystemMXBean/TestTotalSwap.sh ! test/com/sun/management/UnixOperatingSystemMXBean/GetMaxFileDescriptorCount.sh ! test/com/sun/management/UnixOperatingSystemMXBean/GetOpenFileDescriptorCount.sh ! test/com/sun/tools/attach/ApplicationSetup.sh ! test/com/sun/tools/attach/BasicTests.sh ! test/com/sun/tools/attach/PermissionTests.sh ! test/com/sun/tools/attach/ProviderTests.sh ! test/com/sun/tools/extcheck/TestExtcheckArgs.sh ! test/demo/zipfs/basic.sh ! test/java/io/File/GetXSpace.sh ! test/java/io/File/MacPathTest.sh ! test/java/io/File/basic.sh ! test/java/io/FileOutputStream/FileOpen.sh ! test/java/io/Serializable/class/run.sh ! test/java/io/Serializable/evolution/AddedExternField/run.sh ! test/java/io/Serializable/evolution/RenamePackage/run.sh ! test/java/io/Serializable/maskSyntheticModifier/run.sh ! test/java/io/Serializable/packageAccess/run.sh ! test/java/io/Serializable/resolveClass/consTest/run.sh ! test/java/io/Serializable/resolveClass/deserializeButton/run.sh ! test/java/io/Serializable/subclass/run.sh ! test/java/io/Serializable/superclassDataLoss/run.sh ! test/java/io/Serializable/unnamedPackageSwitch/run.sh ! test/java/lang/Class/forName/NonJavaNames.sh ! test/java/lang/ClassLoader/Assert.sh ! test/java/lang/ClassLoader/deadlock/TestCrossDelegate.sh ! test/java/lang/ClassLoader/deadlock/TestOneWayDelegate.sh ! test/java/lang/ClassLoader/getdotresource.sh ! test/java/lang/Runtime/exec/setcwd.sh ! test/java/lang/StringCoding/CheckEncodings.sh ! test/java/lang/System/finalization/FinExit.sh ! test/java/lang/annotation/loaderLeak/LoaderLeak.sh ! test/java/lang/management/OperatingSystemMXBean/TestSystemLoadAvg.sh ! test/java/net/Authenticator/B4933582.sh ! test/java/net/DatagramSocket/SetDatagramSocketImplFactory/ADatagramSocket.sh ! test/java/net/InetAddress/ptr/lookup.sh ! test/java/net/ServerSocket/AcceptCauseFileDescriptorLeak.sh ! test/java/net/Socket/OldSocketImpl.sh ! test/java/net/URL/B5086147.sh ! test/java/net/URL/runconstructor.sh ! test/java/net/URLClassLoader/B5077773.sh ! test/java/net/URLClassLoader/getresourceasstream/test.sh ! test/java/net/URLClassLoader/sealing/checksealed.sh ! test/java/net/URLConnection/6212146/test.sh ! test/java/net/URLConnection/UNCTest.sh ! test/java/nio/Buffer/LimitDirectMemory.sh ! test/java/nio/channels/AsynchronousChannelGroup/run_any_task.sh ! test/java/nio/channels/spi/AsynchronousChannelProvider/custom_provider.sh ! test/java/nio/charset/Charset/default.sh ! test/java/nio/charset/coders/CheckSJISMappingProp.sh ! test/java/nio/charset/spi/basic.sh ! test/java/nio/file/Files/delete_on_close.sh ! test/java/nio/file/Files/walkFileTree/walk_file_tree.sh ! test/java/nio/file/Path/MacPathTest.sh ! test/java/rmi/activation/Activatable/extLoadedImpl/ext.sh ! test/java/rmi/registry/readTest/readTest.sh ! test/java/rmi/reliability/benchmark/runSerialBench.sh ! test/java/security/Security/ClassLoaderDeadlock/ClassLoaderDeadlock.sh ! test/java/security/Security/ClassLoaderDeadlock/Deadlock.sh ! test/java/security/Security/ClassLoaderDeadlock/Deadlock2.sh ! test/java/security/Security/signedfirst/Dyn.sh ! test/java/security/Security/signedfirst/Static.sh ! test/java/security/cert/CertificateFactory/slowstream.sh ! test/java/util/Currency/PropertiesTest.sh ! test/java/util/Locale/LocaleCategory.sh ! test/java/util/Locale/LocaleProviders.sh ! test/java/util/PluggableLocale/ExecTest.sh ! test/java/util/ResourceBundle/Bug6299235Test.sh ! test/java/util/ResourceBundle/Control/MissingResourceCauseTest.sh ! test/java/util/ServiceLoader/basic.sh ! test/java/util/TimeZone/OldIDMappingTest.sh ! test/java/util/TimeZone/TimeZoneDatePermissionCheck.sh ! test/java/util/prefs/CheckUserPrefsStorage.sh ! test/java/util/prefs/PrefsSpi.sh ! test/java/util/spi/ResourceBundleControlProvider/UserDefaultControlTest.sh ! test/java/util/zip/3GBZipFiles.sh ! test/java/util/zip/ZipFile/deletetempjar.sh ! test/javax/crypto/SecretKeyFactory/FailOverTest.sh ! test/javax/print/applet/AppletPrintLookup.sh ! test/javax/script/ProviderTest.sh ! test/javax/security/auth/Subject/doAs/Test.sh ! test/lib/security/java.policy/Ext_AllPolicy.sh ! test/sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh ! test/sun/management/jmxremote/bootstrap/CustomLauncherTest.sh ! test/sun/management/jmxremote/bootstrap/LocalManagementTest.sh ! test/sun/management/jmxremote/bootstrap/PasswordFilePermissionTest.sh ! test/sun/management/jmxremote/bootstrap/SSLConfigFilePermissionTest.sh ! test/sun/management/jmxremote/startstop/JMXStartStopTest.sh ! test/sun/misc/Cleaner/exitOnThrow.sh ! test/sun/net/InetAddress/nameservice/dns/cname.sh ! test/sun/net/sdp/sanity.sh ! test/sun/net/www/MarkResetTest.sh ! test/sun/net/www/http/HttpClient/RetryPost.sh ! test/sun/net/www/protocol/file/DirPermissionDenied.sh ! test/sun/net/www/protocol/jar/B5105410.sh ! test/sun/net/www/protocol/jar/getcontenttype.sh ! test/sun/net/www/protocol/jar/jarbug/run.sh ! test/sun/rmi/rmic/manifestClassPath/run.sh ! test/sun/rmi/rmic/minimizeWrapperInstances/run.sh ! test/sun/rmi/rmic/oldjavacRemoved/sunToolsJavacMain.sh ! test/sun/security/krb5/runNameEquals.sh ! test/sun/security/krb5/tools/ktcheck.sh ! test/sun/security/mscapi/AccessKeyStore.sh ! test/sun/security/mscapi/IsSunMSCAPIAvailable.sh ! test/sun/security/mscapi/KeyStoreCompatibilityMode.sh ! test/sun/security/mscapi/PublicKeyInterop.sh ! test/sun/security/mscapi/RSAEncryptDecrypt.sh ! test/sun/security/mscapi/ShortRSAKey1024.sh ! test/sun/security/mscapi/SignUsingNONEwithRSA.sh ! test/sun/security/mscapi/SignUsingSHA2withRSA.sh ! test/sun/security/pkcs11/KeyStore/Basic.sh ! test/sun/security/pkcs11/KeyStore/ClientAuth.sh ! test/sun/security/pkcs11/KeyStore/SecretKeysBasic.sh ! test/sun/security/pkcs11/KeyStore/Solaris.sh ! test/sun/security/pkcs11/Provider/ConfigQuotedString.sh ! test/sun/security/pkcs11/Provider/Login.sh ! test/sun/security/provider/PolicyFile/GrantAllPermToExtWhenNoPolicy.sh ! test/sun/security/provider/PolicyFile/getinstance/getinstance.sh ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/EngineArgs/DebugReportsOneExtraByte.sh ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLSocketImpl/NotifyHandshakeTest.sh ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/PostThruProxy.sh ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/PostThruProxyWithAuth.sh ! test/sun/security/tools/jarsigner/emptymanifest.sh ! test/sun/security/tools/jarsigner/ts.sh ! test/sun/security/tools/keytool/printssl.sh ! test/sun/security/tools/keytool/standard.sh ! test/sun/security/validator/certreplace.sh ! test/sun/security/validator/samedn.sh ! test/tools/launcher/6842838/Test6842838.sh ! test/tools/launcher/MultipleJRE.sh Changeset: 087425441a48 Author: robm Date: 2012-12-13 15:28 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/087425441a48 8000525: Java.net.httpcookie api does not support 2-digit year format Reviewed-by: chegar ! src/share/classes/java/net/HttpCookie.java ! test/java/net/CookieHandler/B6791927.java ! test/java/net/CookieHandler/CookieManagerTest.java + test/java/net/HttpCookie/ExpiredCookieTest.java Changeset: 8d7323a9d8ed Author: dholmes Date: 2012-12-13 21:18 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/8d7323a9d8ed 8003632: HPROF class file version java.lang.RuntimeException errors Reviewed-by: mchung, lancea ! src/share/javavm/export/classfile_constants.h Changeset: 69fd3f3d20c1 Author: alanb Date: 2012-12-15 15:07 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/69fd3f3d20c1 8004963: URLConnection, downgrade normative reference to ${java.home}/lib/content-types.properties Reviewed-by: chegar ! src/share/classes/java/net/URLConnection.java Changeset: eaaec81aa974 Author: weijun Date: 2012-12-17 12:18 +0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/eaaec81aa974 7197159: accept different kvno if there no match Reviewed-by: xuelei ! src/share/classes/sun/security/krb5/EncryptionKey.java ! test/sun/security/krb5/auto/DynamicKeytab.java + test/sun/security/krb5/auto/KvnoNA.java ! test/sun/security/krb5/auto/MoreKvno.java Changeset: f959e0cc8766 Author: lana Date: 2012-12-16 22:09 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/f959e0cc8766 Merge ! makefiles/CompileNativeLibraries.gmk - src/share/classes/sun/awt/TextureSizeConstraining.java Changeset: a02212de8db6 Author: uta Date: 2012-12-17 14:34 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/a02212de8db6 8004928: TEST_BUG: Reduce dependence of CoreLib tests from the AWT subsystem Summary: the tests were refactored to drop AWT dependence where it was possible. Reviewed-by: alanb, mchung ! test/java/io/Serializable/resolveProxyClass/NonPublicInterface.java ! test/java/lang/Throwable/LegacyChainedExceptionSerialization.java ! test/java/lang/management/CompilationMXBean/Basic.java ! test/java/lang/reflect/Generics/Probe.java ! test/java/lang/reflect/Proxy/ClassRestrictions.java ! test/java/util/Collections/EmptyIterator.java ! test/java/util/logging/LoggingDeadlock4.java ! test/sun/tools/jrunscript/common.sh Changeset: e4d88a7352c6 Author: mullan Date: 2012-12-17 08:28 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/e4d88a7352c6 8004234: Downgrade normative references to ${java.home}/lib/security/krb5.conf Reviewed-by: alanb, weijun ! src/share/classes/javax/security/auth/kerberos/package.html Changeset: 4a21f818ebb1 Author: mullan Date: 2012-12-17 08:30 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/4a21f818ebb1 Merge - src/share/classes/sun/awt/TextureSizeConstraining.java - test/java/rmi/server/Unmarshal/checkUnmarshalOnStopThread/CheckUnmarshall.java Changeset: bcf79e6f52a0 Author: chegar Date: 2012-12-17 16:27 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/bcf79e6f52a0 8005081: java/util/prefs/PrefsSpi.sh fails on macos-x Reviewed-by: alanb ! test/java/util/prefs/PrefsSpi.sh Changeset: 9f1b516cd9cb Author: jjg Date: 2012-12-17 08:34 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/9f1b516cd9cb 8005090: Include com.sun.source.doctree in Tree API docs Reviewed-by: erikj ! make/docs/NON_CORE_PKGS.gmk Changeset: bac477d67867 Author: jjg Date: 2012-12-17 10:31 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/bac477d67867 8004832: Add new doclint package Reviewed-by: erikj, ohair ! make/common/Release.gmk ! make/common/internal/Defs-langtools.gmk ! makefiles/CreateJars.gmk Changeset: 0fabdf676395 Author: martin Date: 2012-12-17 18:39 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/0fabdf676395 8004863: Infinite Loop in KeepAliveStream Reviewed-by: chegar ! src/share/classes/sun/net/www/http/KeepAliveStream.java + test/sun/net/www/http/KeepAliveStream/InfiniteLoop.java Changeset: 0a1398021c7c Author: darcy Date: 2012-12-18 14:44 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/0a1398021c7c 8005042: Add Method.isDefault to core reflection Reviewed-by: alanb, forax, mduigou, jgish, mchung ! src/share/classes/java/lang/reflect/Method.java + test/java/lang/reflect/Method/IsDefaultTest.java Changeset: 6d977f61af5e Author: darcy Date: 2012-12-18 14:49 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/6d977f61af5e 8004699: Add type annotation storage to Constructor, Field and Method Reviewed-by: darcy, dholmes Contributed-by: joel.franck at oracle.com ! src/share/classes/java/lang/reflect/Constructor.java ! src/share/classes/java/lang/reflect/Field.java ! src/share/classes/java/lang/reflect/Method.java Changeset: e8b54ae97344 Author: jviswana Date: 2012-12-12 13:28 +0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/e8b54ae97344 8004316: Printer - tempfile having incorrect extension Reviewed-by: bae, jgodinez ! src/solaris/classes/sun/print/UnixPrintJob.java Changeset: fd9e6b4c8488 Author: lana Date: 2012-12-14 11:21 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/fd9e6b4c8488 Merge Changeset: c69424f78060 Author: serb Date: 2012-12-11 19:45 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/c69424f78060 7154778: [macosx] NSView-based implementation of sun.awt.EmbeddedFrame Summary: The new implementation of EmbeddedFrame to support SWT_AWT Bridge Reviewed-by: anthony, serb, leonidr Contributed-by: Petr Pchelko ! src/macosx/classes/sun/lwawt/LWToolkit.java ! src/macosx/classes/sun/lwawt/LWWindowPeer.java ! src/macosx/classes/sun/lwawt/PlatformWindow.java ! src/macosx/classes/sun/lwawt/macosx/CMouseInfoPeer.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformEmbeddedFrame.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformView.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/macosx/classes/sun/lwawt/macosx/CPrinterDialogPeer.java + src/macosx/classes/sun/lwawt/macosx/CViewEmbeddedFrame.java + src/macosx/classes/sun/lwawt/macosx/CViewPlatformEmbeddedFrame.java ! src/macosx/classes/sun/lwawt/macosx/CWrapper.java ! src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java ! src/macosx/native/sun/awt/AWTSurfaceLayers.m ! src/macosx/native/sun/awt/AWTView.m ! src/macosx/native/sun/awt/AWTWindow.m ! src/macosx/native/sun/awt/CCursorManager.m ! src/macosx/native/sun/awt/CWrapper.m ! src/macosx/native/sun/awt/awt.m ! src/macosx/native/sun/java2d/opengl/CGLLayer.m ! src/macosx/native/sun/osxapp/ThreadUtilities.h ! src/macosx/native/sun/osxapp/ThreadUtilities.m Changeset: e016ad35a764 Author: kshefov Date: 2012-12-13 15:14 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/e016ad35a764 7132385: [macosx] IconifyTest of RepaintManager could use some delay Reviewed-by: serb, alexsch + test/javax/swing/RepaintManager/IconifyTest/IconifyTest.java Changeset: 71e03e17c183 Author: kshefov Date: 2012-12-14 13:32 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/71e03e17c183 6757986: javax/swing/JInternalFrame/5066752/bug5066752.java needs correction Reviewed-by: serb, alexsch + test/javax/swing/JInternalFrame/5066752/bug5066752.java Changeset: 9fc7460ca3ac Author: lana Date: 2012-12-14 11:22 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/9fc7460ca3ac Merge Changeset: de6b54a60d60 Author: lana Date: 2012-12-14 13:14 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/de6b54a60d60 Merge ! makefiles/CompileNativeLibraries.gmk - src/share/lib/security/java.security - test/java/rmi/server/Unmarshal/checkUnmarshalOnStopThread/CheckUnmarshall.java Changeset: e515956879cd Author: lana Date: 2012-12-18 18:14 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/e515956879cd Merge Changeset: c79b26b8efe0 Author: sjiang Date: 2012-12-19 11:06 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/c79b26b8efe0 7158614: JMXStartStopTest.sh failing intermittently Summary: fixed 3 problems here: 1) checked the lock file too eary 2) never got the process id of a java test 3) some shell commands were not supported in some Solaris machines. Reviewed-by: dsamersoff, alanb ! test/ProblemList.txt ! test/sun/management/jmxremote/startstop/JMXStartStopDoSomething.java ! test/sun/management/jmxremote/startstop/JMXStartStopTest.sh Changeset: 3fd3bcc8bd42 Author: joehw Date: 2012-12-19 12:09 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/3fd3bcc8bd42 8004371: (props) Properties.loadFromXML needs small footprint XML parser as fallback when JAXP is not present Reviewed-by: alanb, mchung, psandoz + src/share/classes/jdk/internal/org/xml/sax/Attributes.java + src/share/classes/jdk/internal/org/xml/sax/ContentHandler.java + src/share/classes/jdk/internal/org/xml/sax/DTDHandler.java + src/share/classes/jdk/internal/org/xml/sax/EntityResolver.java + src/share/classes/jdk/internal/org/xml/sax/ErrorHandler.java + src/share/classes/jdk/internal/org/xml/sax/InputSource.java + src/share/classes/jdk/internal/org/xml/sax/Locator.java + src/share/classes/jdk/internal/org/xml/sax/SAXException.java + src/share/classes/jdk/internal/org/xml/sax/SAXNotRecognizedException.java + src/share/classes/jdk/internal/org/xml/sax/SAXNotSupportedException.java + src/share/classes/jdk/internal/org/xml/sax/SAXParseException.java + src/share/classes/jdk/internal/org/xml/sax/XMLReader.java + src/share/classes/jdk/internal/org/xml/sax/helpers/DefaultHandler.java + src/share/classes/jdk/internal/util/xml/PropertiesDefaultHandler.java + src/share/classes/jdk/internal/util/xml/SAXParser.java + src/share/classes/jdk/internal/util/xml/XMLStreamException.java + src/share/classes/jdk/internal/util/xml/XMLStreamWriter.java + src/share/classes/jdk/internal/util/xml/impl/Attrs.java + src/share/classes/jdk/internal/util/xml/impl/Input.java + src/share/classes/jdk/internal/util/xml/impl/Pair.java + src/share/classes/jdk/internal/util/xml/impl/Parser.java + src/share/classes/jdk/internal/util/xml/impl/ParserSAX.java + src/share/classes/jdk/internal/util/xml/impl/ReaderUTF16.java + src/share/classes/jdk/internal/util/xml/impl/ReaderUTF8.java + src/share/classes/jdk/internal/util/xml/impl/SAXParserImpl.java + src/share/classes/jdk/internal/util/xml/impl/XMLStreamWriterImpl.java + src/share/classes/jdk/internal/util/xml/impl/XMLWriter.java Changeset: cf15abdcdf88 Author: alanb Date: 2012-12-19 14:53 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/cf15abdcdf88 8005248: (props) Integrate small footprint parser into Properties Reviewed-by: joehw, mchung, psandoz, erikj ! make/jdk/Makefile - make/jdk/asm/Makefile ! src/share/classes/java/util/Properties.java + src/share/classes/jdk/internal/util/xml/BasicXmlPropertiesProvider.java ! test/java/util/Properties/LoadAndStoreXML.java + test/java/util/Properties/invalidxml/BadCase.xml + test/java/util/Properties/invalidxml/BadDocType.xml.excluded + test/java/util/Properties/invalidxml/NoClosingTag.xml + test/java/util/Properties/invalidxml/NoDocType.xml.excluded + test/java/util/Properties/invalidxml/NoRoot.xml + test/java/util/Properties/invalidxml/NotQuoted.xml + test/java/util/Properties/invalidxml/README.txt Changeset: 1f9c19741285 Author: darcy Date: 2012-12-19 11:53 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/1f9c19741285 8005097: Tie isSynthetic javadoc to the JLS Reviewed-by: mduigou ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/reflect/Constructor.java ! src/share/classes/java/lang/reflect/Executable.java ! src/share/classes/java/lang/reflect/Member.java ! src/share/classes/java/lang/reflect/Method.java Changeset: b600d490dc57 Author: dsamersoff Date: 2012-12-20 16:02 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/b600d490dc57 6783290: MBeanInfo/MBeanFeatureInfo has inconsistent readObject/writeObject Summary: call readObject in all cases Reviewed-by: emcmanus Contributed-by: jaroslav.bachorik at oracle.com ! src/share/classes/javax/management/MBeanFeatureInfo.java ! src/share/classes/javax/management/MBeanInfo.java Changeset: e43f90d5af11 Author: dsamersoff Date: 2012-12-20 16:56 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/e43f90d5af11 6937053: RMI unmarshalling errors in ClientNotifForwarder cause silent failure Summary: the catch block in the fetchNotifs() method is extended to expect UnmarshalException Reviewed-by: emcmanus Contributed-by: jaroslav.bachorik at oracle.com ! src/share/classes/com/sun/jmx/remote/internal/ClientNotifForwarder.java Changeset: 3f014bc09297 Author: dsamersoff Date: 2012-12-20 17:24 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/3f014bc09297 7009998: JMX synchronization during connection restart is faulty Summary: add a return statement after the re-connecting has finished and the state is CONNECTED Reviewed-by: sjiang Contributed-by: jaroslav.bachorik at oracle.com ! make/netbeans/jmx/build.properties ! src/share/classes/com/sun/jmx/remote/internal/ClientCommunicatorAdmin.java Changeset: d01a810798e0 Author: dl Date: 2012-12-20 13:44 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/d01a810798e0 8002356: Add ForkJoin common pool and CountedCompleter Reviewed-by: chegar, mduigou ! make/java/java/FILES_java.gmk + src/share/classes/java/util/concurrent/CountedCompleter.java ! src/share/classes/java/util/concurrent/ForkJoinPool.java ! src/share/classes/java/util/concurrent/ForkJoinTask.java ! src/share/classes/java/util/concurrent/ForkJoinWorkerThread.java Changeset: 31d2f9995d6c Author: chegar Date: 2012-12-20 15:04 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/31d2f9995d6c 8005306: Redundant cast warning in KeepAliveStream.java Reviewed-by: alanb ! src/share/classes/sun/net/www/http/KeepAliveStream.java Changeset: c1a55ee9618e Author: dsamersoff Date: 2012-12-20 20:12 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/c1a55ee9618e 8005309: Missed tests for 6783290,6937053,7009998 Summary: Missed tests for 6783290,6937053,7009998 Reviewed-by: sjiang, emcmanus Contributed-by: jaroslav.bachorik at oracle.com + test/com/sun/jmx/remote/CCAdminReconnectTest.java + test/com/sun/jmx/remote/NotificationMarshalVersions/Client/Client.java + test/com/sun/jmx/remote/NotificationMarshalVersions/Client/ConfigKey.java + test/com/sun/jmx/remote/NotificationMarshalVersions/Client/TestNotification.java + test/com/sun/jmx/remote/NotificationMarshalVersions/Server/ConfigKey.java + test/com/sun/jmx/remote/NotificationMarshalVersions/Server/Server.java + test/com/sun/jmx/remote/NotificationMarshalVersions/Server/Ste.java + test/com/sun/jmx/remote/NotificationMarshalVersions/Server/SteMBean.java + test/com/sun/jmx/remote/NotificationMarshalVersions/Server/TestNotification.java + test/com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.sh + test/javax/management/MBeanInfo/SerializationTest1.java Changeset: edb71a37fcb7 Author: alanb Date: 2012-12-20 20:29 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/edb71a37fcb7 8001048: JSR-160: Allow IIOP transport to be optional Reviewed-by: dsamersoff, dfuchs, mchung ! src/share/classes/com/sun/jmx/remote/internal/IIOPHelper.java ! src/share/classes/javax/management/remote/JMXConnectorFactory.java ! src/share/classes/javax/management/remote/JMXConnectorServerFactory.java ! src/share/classes/javax/management/remote/rmi/RMIConnector.java ! src/share/classes/javax/management/remote/rmi/RMIConnectorServer.java ! src/share/classes/javax/management/remote/rmi/package.html ! test/javax/management/remote/mandatory/connection/AddressableTest.java ! test/javax/management/remote/mandatory/connection/CloseableTest.java ! test/javax/management/remote/mandatory/connection/ConnectionListenerNullTest.java ! test/javax/management/remote/mandatory/connection/IIOPURLTest.java ! test/javax/management/remote/mandatory/connection/IdleTimeoutTest.java ! test/javax/management/remote/mandatory/connection/MultiThreadDeadLockTest.java ! test/javax/management/remote/mandatory/connectorServer/SetMBeanServerForwarder.java ! test/javax/management/remote/mandatory/loading/MissingClassTest.java ! test/javax/management/remote/mandatory/provider/ProviderTest.java ! test/javax/management/remote/mandatory/serverError/JMXServerErrorTest.java Changeset: eeda18683ddc Author: alanb Date: 2012-12-20 20:40 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/eeda18683ddc 8005281: (props) loadFromXML/storeToXML with small parser is not thread safe Reviewed-by: mchung ! src/share/classes/jdk/internal/util/xml/BasicXmlPropertiesProvider.java + test/java/util/Properties/ConcurrentLoadAndStoreXML.java Changeset: 60adb69bf043 Author: smarks Date: 2012-12-20 20:11 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/60adb69bf043 8005290: remove -showversion from RMI test library subprocess mechanism Reviewed-by: jgish, chegar, dmocek ! test/java/rmi/testlibrary/JavaVM.java ! test/java/rmi/testlibrary/StreamPipe.java ! test/sun/rmi/runtime/Log/6409194/NoConsoleOutput.java Changeset: 42ee6b6ad373 Author: jbachorik Date: 2012-12-21 09:27 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/42ee6b6ad373 7146162: javax/management/remote/mandatory/connection/BrokenConnectionTest.java failing intermittently Summary: ClientCommunicatorAdmin should call gotIOException((IOException)e) instead of restart((IOException)e) when detecting a communication error, because the method gotIOException will send a failure notification if necessary. Reviewed-by: emcmanus, sjiang Contributed-by: jaroslav.bachorik at oracle.com ! src/share/classes/com/sun/jmx/remote/internal/ClientCommunicatorAdmin.java Changeset: 86c10d1484e9 Author: sjiang Date: 2012-12-21 10:58 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/86c10d1484e9 8005325: The script should use TESTVMOPTS Summary: Put back TESTVMOPTS which was removed by mistake. Reviewed-by: smarks ! test/sun/management/jmxremote/startstop/JMXStartStopTest.sh Changeset: c1227b872a12 Author: joehw Date: 2012-12-21 17:29 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/c1227b872a12 8005280: (props) Improve test coverage for small XML parser Summary: added a few more invalid XML files, international characters to LoadAndStore test, and a behavior compatibility test. Reviewed-by: alanb, lancea + test/java/util/Properties/Compatibility.xml + test/java/util/Properties/CompatibilityTest.java ! test/java/util/Properties/LoadAndStoreXML.java + test/java/util/Properties/invalidxml/BadDocType.xml - test/java/util/Properties/invalidxml/BadDocType.xml.excluded + test/java/util/Properties/invalidxml/DTDRootNotMatch.xml + test/java/util/Properties/invalidxml/IllegalComment.xml + test/java/util/Properties/invalidxml/IllegalEntry.xml + test/java/util/Properties/invalidxml/IllegalEntry1.xml + test/java/util/Properties/invalidxml/IllegalKeyAttribute.xml + test/java/util/Properties/invalidxml/NoDocType.xml - test/java/util/Properties/invalidxml/NoDocType.xml.excluded + test/java/util/Properties/invalidxml/NoNamespaceSupport.xml Changeset: 4d28776d7007 Author: mullan Date: 2012-12-26 10:07 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/4d28776d7007 8005117: Eliminate dependency from ConfigSpiFile to com.sun.security.auth.login.ConfigFile Reviewed-by: alanb, mchung, weijun ! src/share/classes/com/sun/security/auth/login/ConfigFile.java ! src/share/classes/sun/security/provider/ConfigSpiFile.java Changeset: d9cab18f326a Author: mullan Date: 2012-12-26 10:08 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/d9cab18f326a Merge - make/jdk/asm/Makefile Changeset: 9d984ccd17fc Author: chegar Date: 2012-12-27 21:55 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/9d984ccd17fc 8003981: Support Parallel Array Sorting - JEP 103 Reviewed-by: chegar, forax, dholmes, dl Contributed-by: david.holmes at oracle.com, dl at cs.oswego.edu, chris.hegarty at oracle.com ! make/java/java/FILES_java.gmk ! src/share/classes/java/util/Arrays.java + src/share/classes/java/util/ArraysParallelSortHelpers.java + test/java/util/Arrays/ParallelSorting.java Changeset: 4ad38db38fff Author: okutsu Date: 2012-12-28 14:13 +0900 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/4ad38db38fff 8005471: DateFormat: Time zone info is not localized when adapter is CLDR Reviewed-by: peytoia ! src/share/classes/sun/util/resources/TimeZoneNamesBundle.java + test/java/util/TimeZone/CLDRDisplayNamesTest.java Changeset: 1da019e7999a Author: peytoia Date: 2012-12-28 15:07 +0900 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/1da019e7999a 8005277: Regression in JDK 7 in Bidi implementation Reviewed-by: okutsu ! src/share/classes/sun/text/bidi/BidiBase.java ! test/java/text/Bidi/BidiConformance.java + test/java/text/Bidi/Bug8005277.java Changeset: f3ac419e2bf0 Author: okutsu Date: 2012-12-28 16:39 +0900 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/f3ac419e2bf0 8005561: typo in Calendar Reviewed-by: peytoia ! src/share/classes/java/util/Calendar.java Changeset: 645d774b683a Author: xuelei Date: 2012-12-28 00:48 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/645d774b683a 7109274: Restrict the use of certificates with RSA keys less than 1024 bits Summary: This restriction is applied via the Java Security property, "jdk.certpath.disabledAlgorithms". This will impact providers that adhere to this security property. Reviewed-by: mullan ! src/share/lib/security/java.security-linux ! src/share/lib/security/java.security-macosx ! src/share/lib/security/java.security-solaris ! src/share/lib/security/java.security-windows ! test/java/security/cert/CertPathBuilder/targetConstraints/BuildEEBasicConstraints.java ! test/java/security/cert/pkix/policyChanges/TestPolicy.java ! test/sun/security/provider/certpath/DisabledAlgorithms/CPBuilder.java ! test/sun/security/provider/certpath/DisabledAlgorithms/CPValidatorEndEntity.java ! test/sun/security/provider/certpath/DisabledAlgorithms/CPValidatorIntermediate.java ! test/sun/security/provider/certpath/DisabledAlgorithms/CPValidatorTrustAnchor.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/ClientHandshaker/RSAExport.java + test/sun/security/ssl/javax/net/ssl/TLSv12/DisabledShortRSAKeys.java ! test/sun/security/ssl/javax/net/ssl/TLSv12/ShortRSAKey512.java ! test/sun/security/tools/jarsigner/concise_jarsigner.sh Changeset: 4472a641b4dc Author: xuelei Date: 2012-12-28 03:50 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/4472a641b4dc 8003265: Need to clone array of input/output parameters Reviewed-by: mullan ! src/share/classes/com/sun/jndi/dns/DnsContext.java ! src/share/classes/com/sun/jndi/ldap/BasicControl.java Changeset: 46675076f753 Author: sjiang Date: 2012-12-28 16:44 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/46675076f753 7120365: DiffHBTest.java fails due to ConcurrentModificationException Summary: The problem is from the server notification forwarder, it should use a copy of listener set to do iterate. Reviewed-by: alanb ! src/share/classes/com/sun/jmx/remote/internal/ServerNotifForwarder.java ! test/ProblemList.txt + test/javax/management/remote/mandatory/notif/ConcurrentModificationTest.java Changeset: 0cfcba56cfa7 Author: jgish Date: 2012-12-28 18:32 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/0cfcba56cfa7 8005594: Fix to 8003265 breaks build Summary: backout changeset 4472a641b4dc Reviewed-by: smarks, wetmore ! src/share/classes/com/sun/jndi/dns/DnsContext.java ! src/share/classes/com/sun/jndi/ldap/BasicControl.java Changeset: ac5e29b62288 Author: smarks Date: 2012-12-28 17:36 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/ac5e29b62288 Merge Changeset: 28b47ed08c63 Author: mchung Date: 2012-12-28 22:21 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/28b47ed08c63 8003562: Provide a CLI tool to analyze class dependencies Reviewed-by: jjg, alanb, ulfzibis, erikj ! make/common/Release.gmk ! make/docs/NON_CORE_PKGS.gmk ! make/launchers/Makefile ! make/launchers/Makefile.launcher ! makefiles/CompileLaunchers.gmk ! makefiles/CreateJars.gmk ! makefiles/Images.gmk Changeset: 3cc25d0e3bb0 Author: chegar Date: 2012-12-29 11:00 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/3cc25d0e3bb0 8005556: java/net/Socks/SocksV4Test.java is missing @run tag Reviewed-by: alanb ! test/java/net/Socks/SocksV4Test.java Changeset: 4ea0ac8e02d2 Author: erikj Date: 2012-12-19 09:46 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/4ea0ac8e02d2 8004803: build-infra: Cannot use icedtea as boot for closed build. Summary: Set bootclasspath to javac and not the running jvm Reviewed-by: ohair ! makefiles/CreateJars.gmk Changeset: a8012d8d7e9c Author: katleman Date: 2012-12-19 13:38 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/a8012d8d7e9c Merge Changeset: 4d5db5c038b4 Author: katleman Date: 2012-12-20 09:18 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/4d5db5c038b4 Added tag jdk8-b69 for changeset a8012d8d7e9c ! .hgtags Changeset: ad6097d547e1 Author: kvn Date: 2012-12-18 17:47 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/ad6097d547e1 8004318: JEP-171: Support Unsafe fences intrinsics Summary: Add three memory-ordering intrinsics to the sun.misc.Unsafe class. Reviewed-by: twisti, kvn Contributed-by: Aleksey Shipilev ! src/share/classes/sun/misc/Unsafe.java Changeset: 12fa4d7ecaf5 Author: twisti Date: 2012-12-20 11:16 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/12fa4d7ecaf5 8005345: JSR 292: JDK performance tweaks Reviewed-by: kvn, jrose ! src/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java ! src/share/classes/java/lang/invoke/LambdaForm.java ! src/share/classes/java/lang/invoke/MethodHandleImpl.java ! src/share/classes/sun/invoke/util/ValueConversions.java Changeset: 8cf5b18488d1 Author: dl Date: 2012-12-20 12:24 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/8cf5b18488d1 8004330: Add missing Unsafe entry points for addAndGet() family Summary: Add Unsafe addAndGet() methods which have intrinsics in Hotspot (7023898) Reviewed-by: alanb, kvn ! src/share/classes/sun/misc/Unsafe.java Changeset: 6b41b40526c6 Author: amurillo Date: 2012-12-21 10:27 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/6b41b40526c6 Merge Changeset: 1ad29569d6e9 Author: erikj Date: 2012-12-20 13:05 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/1ad29569d6e9 8005178: build-infra: Dependency on libfdlibm on mac is broken Reviewed-by: tbell, ohair ! makefiles/CompileNativeLibraries.gmk Changeset: a68090f0dc1a Author: katleman Date: 2012-12-20 16:24 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/a68090f0dc1a 8004982: JDK8 source with GPL header errors Reviewed-by: ohair ! src/macosx/native/sun/font/CCharToGlyphMapper.m ! src/share/classes/java/util/function/BinaryOperator.java ! src/share/classes/java/util/function/Block.java ! src/share/classes/java/util/function/DoubleBlock.java ! src/share/classes/java/util/function/Function.java ! src/share/classes/java/util/function/IntBlock.java ! src/share/classes/java/util/function/LongBlock.java ! src/share/classes/java/util/function/Predicate.java ! src/share/classes/sun/java2d/pipe/ParallelogramPipe.java ! src/share/classes/sun/tools/jcmd/JCmd.java ! src/share/native/java/util/zip/zlib-1.2.5/gzlib.c ! src/solaris/native/common/jdk_util_md.h ! src/solaris/native/sun/tools/attach/BsdVirtualMachine.c ! src/windows/classes/java/net/DualStackPlainDatagramSocketImpl.java ! src/windows/native/common/jdk_util_md.h ! test/com/sun/java/swing/plaf/windows/WindowsRadioButtonUI/7089914/bug7089914.java ! test/java/awt/Focus/6981400/Test1.java ! test/java/awt/Focus/6981400/Test2.java ! test/java/awt/Focus/6981400/Test3.java ! test/java/awt/Frame/ResizeAfterSetFont/ResizeAfterSetFont.java ! test/java/awt/JAWT/JAWT.sh ! test/java/awt/JAWT/Makefile.cygwin ! test/java/awt/JAWT/Makefile.unix ! test/java/awt/JAWT/Makefile.win ! test/java/awt/JAWT/MyCanvas.java ! test/java/awt/JAWT/myfile.c ! test/java/awt/JAWT/myfile.cpp ! test/java/awt/TextArea/DisposeTest/TestDispose.java ! test/java/awt/TextArea/TextAreaCaretVisibilityTest/bug7129742.java ! test/java/awt/TextField/DisposeTest/TestDispose.java ! test/java/lang/Integer/Unsigned.java ! test/java/lang/Long/Unsigned.java ! test/java/lang/Math/CubeRootTests.java ! test/java/lang/Math/Expm1Tests.java ! test/java/lang/Math/HyperbolicTests.java ! test/java/lang/Math/Log10Tests.java ! test/java/lang/Math/Log1pTests.java ! test/java/lang/Math/Tests.java ! test/java/lang/StringBuffer/TestSynchronization.java ! test/java/lang/invoke/remote/RemoteExample.java ! test/java/math/BigDecimal/FloatDoubleValueTests.java ! test/java/math/BigDecimal/StrippingZerosTest.java ! test/java/net/Inet4Address/PingThis.java ! test/java/net/ProxySelector/MultiThreadedSystemProxies.java ! test/java/security/Signature/VerifyRangeCheckOverflow.java ! test/java/util/AbstractCollection/ToArrayTest.java ! test/java/util/Map/EntryHashCode.java ! test/java/util/concurrent/FutureTask/DoneTimedGetLoops.java ! test/java/util/logging/LoggerResourceBundleRace.java ! test/java/util/logging/LoggingDeadlock2.java ! test/java/util/logging/LoggingDeadlock3.java ! test/java/util/logging/SimpleFormatterFormat.java ! test/java/util/spi/ResourceBundleControlProvider/providersrc/XmlRB.xml ! test/java/util/spi/ResourceBundleControlProvider/providersrc/XmlRB_ja.xml ! test/javax/swing/JComponent/7154030/bug7154030.java ! test/javax/swing/JTabbedPane/4310381/bug4310381.java ! test/javax/swing/JTable/4235420/bug4235420.java ! test/javax/swing/JTable/6788484/bug6788484.java ! test/javax/swing/JTable/7055065/bug7055065.java ! test/javax/swing/JTable/7188612/JTableAccessibleGetLocationOnScreen.java ! test/javax/swing/JTextArea/7049024/bug7049024.java ! test/javax/swing/border/Test7022041.java ! test/javax/swing/text/DefaultCaret/6938583/bug6938583.java ! test/sun/management/AgentCMETest.java ! test/sun/management/jmxremote/startstop/JMXStartStopTest.sh ! test/sun/nio/ch/SelProvider.java ! test/sun/rmi/rmic/classpath/RMICClassPathTest.java ! test/sun/security/krb5/auto/ReplayCache.java ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/HttpsProxyStackOverflow.java ! test/sun/tools/jps/jps-V_2.sh ! test/tools/jar/JarBackSlash.java ! test/tools/launcher/UnicodeTest.java Changeset: 9dc1990c7d90 Author: yhuang Date: 2012-12-20 18:53 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/9dc1990c7d90 7195759: ISO 4217 Amendment 154 Reviewed-by: naoto ! src/share/classes/java/util/CurrencyData.properties ! src/share/classes/java/util/LocaleISOData.java ! src/share/classes/sun/util/resources/CurrencyNames.properties ! test/java/util/Currency/ValidateISO4217.java ! test/java/util/Currency/tablea1.txt ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java Changeset: cbf255324369 Author: yhuang Date: 2012-12-23 19:11 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/cbf255324369 Merge - src/share/lib/security/java.security - test/java/rmi/server/Unmarshal/checkUnmarshalOnStopThread/CheckUnmarshall.java ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java Changeset: a996b57e5541 Author: katleman Date: 2012-12-26 14:24 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/a996b57e5541 Merge Changeset: 8d7651351cfe Author: katleman Date: 2012-12-27 12:15 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/8d7651351cfe Added tag jdk8-b70 for changeset a996b57e5541 ! .hgtags Changeset: a988c23b8553 Author: jgodinez Date: 2012-12-20 14:43 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/a988c23b8553 7180359: Assertion in awt_Win32GraphicsDevice.cpp when running specjbb in jprt Reviewed-by: bae, prr ! src/windows/native/sun/windows/awt_Debug.cpp Changeset: 2cf07dbdee64 Author: bae Date: 2012-12-24 14:03 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/2cf07dbdee64 7124245: [lcms] ColorConvertOp to color space CS_GRAY apparently converts orange to 244,244,0 Reviewed-by: prr ! src/share/classes/sun/java2d/cmm/lcms/LCMS.java ! src/share/classes/sun/java2d/cmm/lcms/LCMSImageLayout.java ! src/share/classes/sun/java2d/cmm/lcms/LCMSTransform.java ! src/share/native/sun/java2d/cmm/lcms/LCMS.c + test/sun/java2d/cmm/ColorConvertOp/GrayTest.java Changeset: 3c1c0b7abe51 Author: bae Date: 2012-12-24 14:22 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/3c1c0b7abe51 8005402: Need to provide benchmarks for color management Reviewed-by: jgodinez, prr ! src/share/demo/java2d/J2DBench/build.xml ! src/share/demo/java2d/J2DBench/src/j2dbench/J2DBench.java + src/share/demo/java2d/J2DBench/src/j2dbench/tests/cmm/CMMTests.java + src/share/demo/java2d/J2DBench/src/j2dbench/tests/cmm/ColorConversionTests.java + src/share/demo/java2d/J2DBench/src/j2dbench/tests/cmm/ColorConvertOpTests.java + src/share/demo/java2d/J2DBench/src/j2dbench/tests/cmm/DataConversionTests.java + src/share/demo/java2d/J2DBench/src/j2dbench/tests/cmm/ProfileTests.java Changeset: 1316d6d0900e Author: lana Date: 2012-12-28 18:28 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/1316d6d0900e Merge Changeset: c25ea633b4de Author: malenkov Date: 2012-12-17 16:58 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/c25ea633b4de 8005065: [findbugs] reference to mutable array in JavaBeans Reviewed-by: alexsch ! src/share/classes/java/beans/DefaultPersistenceDelegate.java ! src/share/classes/java/beans/EventSetDescriptor.java ! src/share/classes/java/beans/MethodDescriptor.java ! src/share/classes/java/beans/Statement.java + test/java/beans/Introspector/Test8005065.java Changeset: a78cb3c5d434 Author: neugens Date: 2012-12-17 17:43 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/a78cb3c5d434 8005018: X11: focus problems with openjdk 1.7.0 under gnome3 when selected keyboard is not the first in keyboard list Summary: Don't consider extraenous bits when checking button mask, so that grabWindowRef on the window is not confused and released correctly Reviewed-by: art, anthony ! src/solaris/classes/sun/awt/X11/XBaseWindow.java ! src/solaris/classes/sun/awt/X11/XConstants.java ! src/solaris/classes/sun/awt/X11/XToolkit.java ! src/solaris/classes/sun/awt/X11/XWindow.java ! src/solaris/classes/sun/awt/X11/XWindowPeer.java ! src/solaris/classes/sun/awt/X11/XlibUtil.java Changeset: 985b523712c8 Author: kshefov Date: 2012-12-18 15:17 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/985b523712c8 7104594: [macosx] Test closed/javax/swing/JFrame/4962534/bug4962534 expects Metal L&F by default Reviewed-by: yan, alexsch + test/javax/swing/JFrame/4962534/bug4962534.html + test/javax/swing/JFrame/4962534/bug4962534.java Changeset: 90ad9e922042 Author: lana Date: 2012-12-18 16:14 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/90ad9e922042 Merge - src/share/lib/security/java.security - test/java/rmi/server/Unmarshal/checkUnmarshalOnStopThread/CheckUnmarshall.java Changeset: 7082a96c02d2 Author: alexp Date: 2012-12-21 19:11 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/7082a96c02d2 8003982: new test javax/swing/AncestorNotifier/7193219/bug7193219.java failed on macosx Reviewed-by: anthony, alexsch ! test/javax/swing/AncestorNotifier/7193219/bug7193219.java Changeset: 14269f504837 Author: dcherepanov Date: 2012-12-27 16:08 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/14269f504837 8001161: mac: EmbeddedFrame doesn't become active window Reviewed-by: ant ! src/macosx/classes/sun/lwawt/macosx/CEmbeddedFrame.java Changeset: cf2bcb293f0b Author: lana Date: 2012-12-28 18:30 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/cf2bcb293f0b Merge Changeset: 2a5af0f766d0 Author: lana Date: 2012-12-28 18:36 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/2a5af0f766d0 Merge - make/jdk/asm/Makefile ! makefiles/CreateJars.gmk ! test/sun/management/jmxremote/startstop/JMXStartStopTest.sh Changeset: 38b9a7646093 Author: lana Date: 2013-01-01 17:49 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/38b9a7646093 Merge ! makefiles/CreateJars.gmk Changeset: cc78ceb99284 Author: jgish Date: 2012-12-28 16:56 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/cc78ceb99284 8005118: Javadoc styles are inconsistent Summary: use a common javadoc style in the String classes Reviewed-by: darcy ! src/share/classes/java/lang/AbstractStringBuilder.java ! src/share/classes/java/lang/String.java ! src/share/classes/java/lang/StringBuffer.java ! src/share/classes/java/lang/StringBuilder.java ! src/share/classes/java/lang/StringIndexOutOfBoundsException.java Changeset: 21708d15553b Author: chegar Date: 2013-01-03 10:00 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/21708d15553b 8005634: tools/launcher/VersionCheck.java fails version check on jdeps Summary: add jdeps to the list of tools that do not support '-version' Reviewed-by: mchung ! test/tools/launcher/VersionCheck.java Changeset: 438d37d16417 Author: chegar Date: 2013-01-04 11:18 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/438d37d16417 8005659: Add tools/pack200/AttributeTests.java to exclude list (ProblemList.txt) until pack200 updated to support method parameters Reviewed-by: mchung, ksrini ! test/ProblemList.txt Changeset: 6d814b2f9112 Author: chegar Date: 2013-01-04 11:34 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/6d814b2f9112 8005638: Less secure Authentication schemes should work when more secure schemes are not available Reviewed-by: alanb ! src/share/classes/sun/net/www/protocol/http/AuthenticationHeader.java Changeset: 92c3b24a8e9a Author: smarks Date: 2013-01-04 16:10 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/92c3b24a8e9a 8005683: ProblemList.txt updates (01/2013) Reviewed-by: mchung, alanb Contributed-by: amy.lu at oracle.com ! test/ProblemList.txt Changeset: 0c89465b656a Author: chegar Date: 2013-01-05 17:06 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/0c89465b656a 8005709: Add at since tags to new FJP getCommonPoolParallelism and commonPool Reviewed-by: dl ! src/share/classes/java/util/concurrent/ForkJoinPool.java Changeset: 1d9638ba5202 Author: ksrini Date: 2013-01-07 09:58 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/1d9638ba5202 8004547: Extend JavaFX launcher support to allow full JavaFX launch feature set Reviewed-by: mchung, kcr, ksrini Contributed-by: david.dehaven at oracle.com ! src/share/classes/sun/launcher/LauncherHelper.java ! src/share/classes/sun/launcher/resources/launcher.properties ! test/tools/launcher/FXLauncherTest.java Changeset: dbc692ea3f0a Author: bchristi Date: 2013-01-07 13:19 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/dbc692ea3f0a 8003228: (props) sun.jnu.encoding should be set to UTF-8 [macosx] Summary: Hard-code sun.jnu.encoding to UTF-8 on Mac Reviewed-by: naoto ! src/share/native/java/lang/System.c ! src/solaris/native/java/lang/java_props_md.c + test/java/util/Properties/MacJNUEncoding/ExpectedEncoding.java + test/java/util/Properties/MacJNUEncoding/MacJNUEncoding.sh Changeset: 797e8a3dcd51 Author: smarks Date: 2013-01-07 18:09 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/797e8a3dcd51 7187882: TEST_BUG: java/rmi/activation/checkusage/CheckUsage.java fails intermittently Summary: Tighten up JavaVM test library API, and adjust tests to match. Reviewed-by: mchung, dmocek ! test/ProblemList.txt ! test/java/rmi/activation/Activatable/shutdownGracefully/ShutdownGracefully.java ! test/java/rmi/activation/checkusage/CheckUsage.java ! test/java/rmi/registry/altSecurityManager/AltSecurityManager.java ! test/java/rmi/registry/checkusage/CheckUsage.java ! test/java/rmi/registry/reexport/Reexport.java ! test/java/rmi/testlibrary/JavaVM.java ! test/java/rmi/testlibrary/RMID.java ! test/java/rmi/transport/checkFQDN/CheckFQDN.java ! test/java/rmi/transport/checkLeaseInfoLeak/CheckLeaseLeak.java ! test/sun/rmi/runtime/Log/4504153/Test4504153.java ! test/sun/rmi/runtime/Log/6409194/NoConsoleOutput.java ! test/sun/rmi/transport/tcp/DeadCachedConnection.java Changeset: 98935c514de4 Author: weijun Date: 2013-01-08 14:54 +0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/98935c514de4 8005447: default principal should act as anyone Reviewed-by: valeriep ! src/share/classes/sun/security/jgss/krb5/InitSecContextToken.java ! src/share/classes/sun/security/jgss/krb5/Krb5AcceptCredential.java ! src/share/classes/sun/security/jgss/krb5/Krb5Context.java ! src/share/classes/sun/security/jgss/krb5/Krb5MechFactory.java ! src/share/classes/sun/security/jgss/krb5/Krb5Util.java + src/share/classes/sun/security/jgss/krb5/ServiceCreds.java ! src/share/classes/sun/security/jgss/krb5/SubjectComber.java ! src/share/classes/sun/security/krb5/KrbApReq.java ! src/share/classes/sun/security/krb5/internal/ktab/KeyTab.java ! src/share/classes/sun/security/ssl/krb5/Krb5ProxyImpl.java + test/sun/security/krb5/ServiceCredsCombination.java + test/sun/security/krb5/auto/AcceptPermissions.java ! test/sun/security/krb5/auto/CleanState.java ! test/sun/security/krb5/auto/Context.java + test/sun/security/krb5/auto/DiffNameSameKey.java ! test/sun/security/krb5/auto/DynamicKeytab.java ! test/sun/security/krb5/auto/KDC.java ! test/sun/security/krb5/auto/KeyTabCompat.java + test/sun/security/krb5/auto/TwoOrThree.java Changeset: d29a7ce28189 Author: dxu Date: 2013-01-08 20:37 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/d29a7ce28189 8002306: (se) Selector.open fails if invoked with thread interrupt status set [win] Reviewed-by: alanb ! src/windows/classes/sun/nio/ch/PipeImpl.java + test/java/nio/channels/Pipe/PipeInterrupt.java Changeset: 46e6a4b7ca26 Author: valeriep Date: 2013-01-07 11:11 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/46e6a4b7ca26 6996769: support AEAD cipher Summary: Added implementation for GCM mode under AES cipher Reviewed-by: weijun ! src/share/classes/com/sun/crypto/provider/AESCipher.java ! src/share/classes/com/sun/crypto/provider/CipherCore.java ! src/share/classes/com/sun/crypto/provider/CipherTextStealing.java ! src/share/classes/com/sun/crypto/provider/FeedbackCipher.java + src/share/classes/com/sun/crypto/provider/GCMParameters.java + src/share/classes/com/sun/crypto/provider/GCTR.java + src/share/classes/com/sun/crypto/provider/GHASH.java + src/share/classes/com/sun/crypto/provider/GaloisCounterMode.java ! src/share/classes/com/sun/crypto/provider/SunJCE.java ! src/share/classes/javax/crypto/Cipher.java ! src/share/classes/javax/crypto/spec/GCMParameterSpec.java ! test/com/sun/crypto/provider/Cipher/AES/Test4512524.java ! test/com/sun/crypto/provider/Cipher/AES/Test4512704.java ! test/com/sun/crypto/provider/Cipher/AES/Test4517355.java ! test/com/sun/crypto/provider/Cipher/AES/Test4626070.java + test/com/sun/crypto/provider/Cipher/AES/TestGCMKeyAndIvCheck.java + test/com/sun/crypto/provider/Cipher/AES/TestKATForGCM.java ! test/javax/crypto/Cipher/GCMAPI.java Changeset: 5333a4c8cade Author: valeriep Date: 2013-01-07 14:40 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/5333a4c8cade Merge Changeset: 3c5a62290939 Author: valeriep Date: 2013-01-08 11:55 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/3c5a62290939 8004044: Lazily instantiate SunJCE.RANDOM Summary: Replace the static initialization of SunJCE.RANDOM object w/ lazy initialization Reviewed-by: mchung ! src/share/classes/com/sun/crypto/provider/AESKeyGenerator.java ! src/share/classes/com/sun/crypto/provider/BlowfishKeyGenerator.java ! src/share/classes/com/sun/crypto/provider/CipherCore.java ! src/share/classes/com/sun/crypto/provider/DESKeyGenerator.java ! src/share/classes/com/sun/crypto/provider/DESedeKeyGenerator.java ! src/share/classes/com/sun/crypto/provider/DESedeWrapCipher.java ! src/share/classes/com/sun/crypto/provider/DHKeyPairGenerator.java ! src/share/classes/com/sun/crypto/provider/DHParameterGenerator.java ! src/share/classes/com/sun/crypto/provider/HmacMD5KeyGenerator.java ! src/share/classes/com/sun/crypto/provider/HmacPKCS12PBESHA1.java ! src/share/classes/com/sun/crypto/provider/HmacSHA1KeyGenerator.java ! src/share/classes/com/sun/crypto/provider/ISO10126Padding.java ! src/share/classes/com/sun/crypto/provider/KeyGeneratorCore.java ! src/share/classes/com/sun/crypto/provider/KeyProtector.java ! src/share/classes/com/sun/crypto/provider/PBECipherCore.java ! src/share/classes/com/sun/crypto/provider/PBES1Core.java ! src/share/classes/com/sun/crypto/provider/PBES2Core.java ! src/share/classes/com/sun/crypto/provider/PBMAC1Core.java ! src/share/classes/com/sun/crypto/provider/PKCS12PBECipherCore.java ! src/share/classes/com/sun/crypto/provider/SunJCE.java Changeset: 9b6a29cb04ac Author: valeriep Date: 2013-01-08 13:06 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/9b6a29cb04ac Merge Changeset: ac5fd681a7a2 Author: darcy Date: 2013-01-08 16:08 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/ac5fd681a7a2 8005298: Add FunctionalInterface type to the core libraries Reviewed-by: mduigou + src/share/classes/java/lang/FunctionalInterface.java Changeset: 86828e84654f Author: mullan Date: 2013-01-08 19:00 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/86828e84654f 7019834: Eliminate dependency from PolicyFile to com.sun.security.auth.PrincipalComparator Summary: Add new java.security.Principal.implies method Reviewed-by: alanb ! src/share/classes/java/security/Principal.java ! src/share/classes/sun/security/provider/PolicyFile.java ! src/share/classes/sun/security/provider/PolicyParser.java ! src/share/classes/sun/security/tools/policytool/PolicyTool.java + test/java/security/Principal/Implies.java ! test/sun/security/provider/PolicyFile/Comparator.java Changeset: bf6d0bca5ea7 Author: mullan Date: 2013-01-08 19:02 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/bf6d0bca5ea7 Merge - make/jdk/asm/Makefile - src/share/classes/sun/awt/TextureSizeConstraining.java - src/share/lib/security/java.security - test/java/rmi/server/Unmarshal/checkUnmarshalOnStopThread/CheckUnmarshall.java Changeset: f0ed9ef84637 Author: mullan Date: 2013-01-09 08:59 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/f0ed9ef84637 Merge Changeset: 4c8b37f159f9 Author: mchung Date: 2013-01-09 16:58 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/4c8b37f159f9 7103957: NegativeArraySizeException while initializing class IntegerCache Reviewed-by: darcy, mchung Contributed-by: brian.burkhalter at oracle.com ! src/share/classes/java/lang/Integer.java Changeset: 4176e6cc499e Author: darcy Date: 2013-01-09 20:20 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/4176e6cc499e 8005713: Simplify library support for repeating annotations in java.lang.annotation Reviewed-by: abuckley + src/share/classes/java/lang/annotation/Repeatable.java Changeset: c622df692bfb Author: bchristi Date: 2013-01-10 10:21 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/c622df692bfb 8005962: TEST_BUG: java/util/Properties/MacJNUEncoding can fail in certain environments Summary: Test script now sets LC_ALL, other small changes, relocate test Reviewed-by: naoto, alanb + test/java/lang/System/MacJNUEncoding/ExpectedEncoding.java + test/java/lang/System/MacJNUEncoding/MacJNUEncoding.sh - test/java/util/Properties/MacJNUEncoding/ExpectedEncoding.java - test/java/util/Properties/MacJNUEncoding/MacJNUEncoding.sh Changeset: 13ff1089e625 Author: jgish Date: 2013-01-10 15:09 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/13ff1089e625 8005582: java/lang/Runtime/exec/WinCommand.java intermittent test failures Summary: Remove file-deletion code at cleanup which conflicts with jtreg cleanup Reviewed-by: chegar ! test/java/lang/Runtime/exec/WinCommand.java Changeset: 3e906ccad412 Author: chegar Date: 2013-01-10 21:52 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/3e906ccad412 8006007: j.u.c.atomic classes should use intrinsic getAndXXX provided by 7023898 Reviewed-by: dl, shade ! src/share/classes/java/util/concurrent/atomic/AtomicBoolean.java ! src/share/classes/java/util/concurrent/atomic/AtomicInteger.java ! src/share/classes/java/util/concurrent/atomic/AtomicIntegerArray.java ! src/share/classes/java/util/concurrent/atomic/AtomicIntegerFieldUpdater.java ! src/share/classes/java/util/concurrent/atomic/AtomicLong.java ! src/share/classes/java/util/concurrent/atomic/AtomicLongArray.java ! src/share/classes/java/util/concurrent/atomic/AtomicLongFieldUpdater.java ! src/share/classes/java/util/concurrent/atomic/AtomicReference.java ! src/share/classes/java/util/concurrent/atomic/AtomicReferenceArray.java ! src/share/classes/java/util/concurrent/atomic/AtomicReferenceFieldUpdater.java Changeset: c6e8a518c3cd Author: jjg Date: 2013-01-10 19:36 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/c6e8a518c3cd 8004834: Add doclint support into javadoc Reviewed-by: erikj, tbell ! make/docs/Makefile Changeset: c9308137ad9e Author: jjg Date: 2013-01-10 19:37 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/c9308137ad9e Merge - test/java/util/Properties/MacJNUEncoding/ExpectedEncoding.java - test/java/util/Properties/MacJNUEncoding/MacJNUEncoding.sh Changeset: 86c563dc70ca Author: darcy Date: 2013-01-10 21:12 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/86c563dc70ca 8006062: Add @Repeatable to repeating annotations regression tests in JDK repo Reviewed-by: jjg ! test/java/lang/annotation/repeatingAnnotations/subpackage/Containee.java ! test/java/lang/annotation/repeatingAnnotations/subpackage/InheritedContainee.java Changeset: 0ca2e39a110d Author: alanb Date: 2013-01-11 12:27 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/0ca2e39a110d 8005566: (fs) test/java/nio/file/Files/Misc.java failing (sol) Reviewed-by: chegar ! src/solaris/classes/sun/nio/fs/SolarisAclFileAttributeView.java ! test/java/nio/file/Files/Misc.java Changeset: 7da291690aa0 Author: alanb Date: 2013-01-11 20:19 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/7da291690aa0 8005978: shell tests need to use the $COMPILEJDK for javac, jar and other tools Reviewed-by: chegar ! test/ProblemList.txt ! test/com/sun/management/HotSpotDiagnosticMXBean/DumpHeap.sh ! test/com/sun/management/UnixOperatingSystemMXBean/GetMaxFileDescriptorCount.sh ! test/com/sun/management/UnixOperatingSystemMXBean/GetOpenFileDescriptorCount.sh ! test/java/io/FileOutputStream/FileOpen.sh ! test/java/io/Serializable/class/run.sh ! test/java/io/Serializable/evolution/RenamePackage/run.sh ! test/java/io/Serializable/maskSyntheticModifier/run.sh ! test/java/io/Serializable/packageAccess/run.sh ! test/java/io/Serializable/resolveClass/consTest/run.sh ! test/java/io/Serializable/resolveClass/deserializeButton/run.sh ! test/java/io/Serializable/superclassDataLoss/run.sh ! test/java/io/Serializable/unnamedPackageSwitch/run.sh ! test/java/lang/Class/getEnclosingClass/build.sh ! test/java/lang/ClassLoader/Assert.sh ! test/java/lang/ClassLoader/deadlock/TestCrossDelegate.sh ! test/java/lang/ClassLoader/deadlock/TestOneWayDelegate.sh ! test/java/lang/System/MacJNUEncoding/MacJNUEncoding.sh ! test/java/lang/Thread/UncaughtExceptions.sh ! test/java/lang/annotation/loaderLeak/LoaderLeak.sh ! test/java/lang/instrument/AppendToBootstrapClassPathSetUp.sh ! test/java/lang/instrument/AppendToClassPathSetUp.sh ! test/java/lang/instrument/BootClassPath/BootClassPathTest.sh ! test/java/lang/instrument/MakeJAR.sh ! test/java/lang/instrument/MakeJAR2.sh ! test/java/lang/instrument/MakeJAR3.sh ! test/java/lang/instrument/MakeJAR4.sh ! test/java/lang/instrument/ManifestTest.sh ! test/java/lang/instrument/ParallelTransformerLoader.sh ! test/java/lang/instrument/PremainClass/NoPremainAgent.sh ! test/java/lang/instrument/PremainClass/PremainClassTest.sh ! test/java/lang/instrument/PremainClass/ZeroArgPremainAgent.sh ! test/java/lang/instrument/RedefineBigClass.sh ! test/java/lang/instrument/RedefineClassWithNativeMethod.sh ! test/java/lang/instrument/RedefineMethodAddInvoke.sh ! test/java/lang/instrument/RedefineSetUp.sh ! test/java/lang/instrument/RetransformBigClass.sh ! test/java/lang/instrument/appendToClassLoaderSearch/CircularityErrorTest.sh ! test/java/lang/instrument/appendToClassLoaderSearch/ClassUnloadTest.sh ! test/java/lang/instrument/appendToClassLoaderSearch/CommonSetup.sh ! test/java/lang/instrument/appendToClassLoaderSearch/run_tests.sh ! test/java/net/Authenticator/B4933582.sh ! test/java/net/URL/B5086147.sh ! test/java/net/URL/runconstructor.sh ! test/java/net/URLClassLoader/B5077773.sh ! test/java/net/URLClassLoader/closetest/build.sh ! test/java/net/URLClassLoader/getresourceasstream/test.sh ! test/java/net/URLClassLoader/sealing/checksealed.sh ! test/java/net/URLConnection/6212146/test.sh ! test/java/net/URLConnection/UNCTest.sh ! test/java/nio/charset/spi/basic.sh ! test/java/rmi/activation/Activatable/extLoadedImpl/ext.sh ! test/java/rmi/registry/readTest/readTest.sh ! test/java/security/Security/ClassLoaderDeadlock/ClassLoaderDeadlock.sh ! test/java/security/Security/ClassLoaderDeadlock/Deadlock2.sh ! test/java/security/Security/signedfirst/Dyn.sh ! test/java/security/Security/signedfirst/Static.sh ! test/java/security/cert/CertificateFactory/slowstream.sh ! test/java/util/Formatter/Basic.sh ! test/java/util/Locale/LocaleProviders.sh ! test/java/util/PluggableLocale/ExecTest.sh ! test/java/util/ServiceLoader/basic.sh ! test/java/util/TimeZone/TimeZoneDatePermissionCheck.sh ! test/java/util/prefs/PrefsSpi.sh ! test/javax/crypto/SecretKeyFactory/FailOverTest.sh ! test/javax/script/CommonSetup.sh ! test/javax/script/ProviderTest.sh ! test/javax/security/auth/Subject/doAs/Test.sh ! test/lib/security/java.policy/Ext_AllPolicy.sh ! test/sun/management/jmxremote/bootstrap/PasswordFilePermissionTest.sh ! test/sun/management/jmxremote/bootstrap/SSLConfigFilePermissionTest.sh ! test/sun/management/jmxremote/startstop/JMXStartStopTest.sh ! test/sun/net/www/MarkResetTest.sh ! test/sun/net/www/http/HttpClient/RetryPost.sh ! test/sun/net/www/protocol/jar/B5105410.sh ! test/sun/net/www/protocol/jar/jarbug/run.sh ! test/sun/security/krb5/config/dns.sh ! test/sun/security/krb5/runNameEquals.sh ! test/sun/security/mscapi/IsSunMSCAPIAvailable.sh ! test/sun/security/pkcs11/KeyStore/Basic.sh ! test/sun/security/pkcs11/KeyStore/ClientAuth.sh ! test/sun/security/pkcs11/KeyStore/Solaris.sh ! test/sun/security/pkcs11/Provider/ConfigQuotedString.sh ! test/sun/security/pkcs11/Provider/Login.sh ! test/sun/security/provider/PolicyFile/GrantAllPermToExtWhenNoPolicy.sh ! test/sun/security/provider/PolicyFile/getinstance/getinstance.sh ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/EngineArgs/DebugReportsOneExtraByte.sh ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLSocketImpl/NotifyHandshakeTest.sh ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/PostThruProxy.sh ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/PostThruProxyWithAuth.sh ! test/sun/security/tools/keytool/autotest.sh ! test/sun/security/tools/keytool/printssl.sh ! test/sun/security/tools/keytool/readjar.sh ! test/sun/security/tools/keytool/standard.sh ! test/sun/security/util/Oid/S11N.sh ! test/sun/security/validator/certreplace.sh ! test/sun/security/validator/samedn.sh ! test/tools/launcher/ClassPathWildCard.sh ! test/tools/launcher/MultipleJRE.sh Changeset: bc1f16f5566f Author: darcy Date: 2013-01-11 15:39 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/bc1f16f5566f 7131459: [Fmt-De] DecimalFormat produces wrong format() results when close to a tie Reviewed-by: darcy Contributed-by: olivier.lagneau at oracle.com ! src/share/classes/java/text/DigitList.java ! src/share/classes/sun/misc/FloatingDecimal.java + test/java/text/Format/DecimalFormat/TieRoundingTest.java Changeset: 6f6246aced89 Author: sherman Date: 2013-01-11 22:43 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/6f6246aced89 8005466: JAR file entry hash table uses too much memory (zlib_util.c) Summary: realign the fields of jzcell struct Reviewed-by: sherman Contributed-by: ioi.lam at oracle.com ! src/share/native/java/util/zip/zip_util.h Changeset: 8009c7e3899e Author: sherman Date: 2013-01-11 22:45 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/8009c7e3899e Merge Changeset: 7db04ae3378f Author: chegar Date: 2013-01-13 22:09 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/7db04ae3378f 8006153: HTTP protocol handler authenication should use Base64 API Reviewed-by: chegar, alanb Contributed-by: Mark Sheppard ! src/share/classes/sun/net/www/protocol/http/BasicAuthentication.java ! src/share/classes/sun/net/www/protocol/http/NegotiateAuthentication.java Changeset: 1109bfff4e92 Author: dholmes Date: 2013-01-13 19:57 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/1109bfff4e92 8005232: (JEP-149) Class Instance size reduction Summary: Moved the fields for cached reflection objects into a seperate ReflectionData object to reduce dynamic footprint. Reviewed-by: dholmes, mchung, shade Contributed-by: Peter Levart ! src/share/classes/java/lang/Class.java Changeset: 1d7a6adf499f Author: naoto Date: 2013-01-14 11:09 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/1d7a6adf499f 7162007: Clean up i18n related caches Reviewed-by: okutsu, ohair ! make/java/java/FILES_java.gmk ! src/share/classes/java/text/DateFormatSymbols.java ! src/share/classes/java/text/DecimalFormat.java ! src/share/classes/java/text/DecimalFormatSymbols.java ! src/share/classes/java/text/NumberFormat.java ! src/share/classes/java/util/Locale.java ! src/share/classes/java/util/TimeZone.java ! src/share/classes/sun/text/resources/zh/CollationData_zh_HK.java ! src/share/classes/sun/text/resources/zh/FormatData_zh_HK.java ! src/share/classes/sun/util/locale/provider/AuxLocaleProviderAdapter.java ! src/share/classes/sun/util/locale/provider/BreakIteratorProviderImpl.java ! src/share/classes/sun/util/locale/provider/CalendarDataProviderImpl.java ! src/share/classes/sun/util/locale/provider/CalendarNameProviderImpl.java ! src/share/classes/sun/util/locale/provider/CollatorProviderImpl.java ! src/share/classes/sun/util/locale/provider/CurrencyNameProviderImpl.java ! src/share/classes/sun/util/locale/provider/JRELocaleProviderAdapter.java ! src/share/classes/sun/util/locale/provider/LocaleNameProviderImpl.java ! src/share/classes/sun/util/locale/provider/LocaleProviderAdapter.java ! src/share/classes/sun/util/locale/provider/LocaleResources.java + src/share/classes/sun/util/locale/provider/ResourceBundleBasedAdapter.java ! src/share/classes/sun/util/locale/provider/TimeZoneNameProviderImpl.java ! src/share/classes/sun/util/locale/provider/TimeZoneNameUtility.java ! src/share/classes/sun/util/resources/LocaleData.java ! src/share/classes/sun/util/resources/zh/CurrencyNames_zh_HK.java ! src/share/classes/sun/util/resources/zh/CurrencyNames_zh_SG.java ! src/share/classes/sun/util/resources/zh/LocaleNames_zh_HK.java ! src/share/classes/sun/util/resources/zh/TimeZoneNames_zh_HK.java ! test/java/util/PluggableLocale/BreakIteratorProviderTest.java ! test/java/util/PluggableLocale/CollatorProviderTest.java ! test/java/util/PluggableLocale/CurrencyNameProviderTest.java ! test/java/util/PluggableLocale/DateFormatProviderTest.java ! test/java/util/PluggableLocale/DateFormatSymbolsProviderTest.java ! test/java/util/PluggableLocale/DecimalFormatSymbolsProviderTest.java ! test/java/util/PluggableLocale/LocaleNameProviderTest.java ! test/java/util/PluggableLocale/NumberFormatProviderTest.java ! test/java/util/PluggableLocale/TimeZoneNameProviderTest.java Changeset: dcb64d498d5b Author: ksrini Date: 2013-01-14 15:46 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/dcb64d498d5b 8005252: pack200 should support MethodParameters Reviewed-by: jrose ! src/share/classes/com/sun/java/util/jar/pack/Attribute.java ! src/share/classes/com/sun/java/util/jar/pack/BandStructure.java ! src/share/classes/com/sun/java/util/jar/pack/Constants.java ! src/share/classes/com/sun/java/util/jar/pack/PackageReader.java ! src/share/classes/com/sun/java/util/jar/pack/PackageWriter.java ! src/share/native/com/sun/java/util/jar/pack/bands.cpp ! src/share/native/com/sun/java/util/jar/pack/bands.h ! src/share/native/com/sun/java/util/jar/pack/constants.h ! src/share/native/com/sun/java/util/jar/pack/main.cpp ! src/share/native/com/sun/java/util/jar/pack/unpack.cpp ! test/ProblemList.txt ! test/tools/pack200/AttributeTests.java ! test/tools/pack200/pack200-verifier/src/xmlkit/ClassReader.java Changeset: edb7e34a0531 Author: xuelei Date: 2013-01-14 18:31 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/edb7e34a0531 8006265: Add test SSLEngineDeadlock.java to ProblemList Reviewed-by: weijun ! test/ProblemList.txt Changeset: a40052a54801 Author: uta Date: 2013-01-15 14:26 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/a40052a54801 8005250: Downgrade normative references to ${java.home}/lib folder from Java client code. Summary: Javadoc was changed in accordance with CCC-8005250 request. Reviewed-by: alanb, amenkov ! src/share/classes/java/awt/datatransfer/SystemFlavorMap.java ! src/share/classes/javax/imageio/spi/IIORegistry.java ! src/share/classes/javax/sound/midi/MidiSystem.java ! src/share/classes/javax/sound/sampled/AudioSystem.java ! src/share/classes/javax/swing/UIManager.java Changeset: 4b012af44f24 Author: chegar Date: 2013-01-15 11:44 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/4b012af44f24 8005406: HTTP server implementation should use Base64 API Reviewed-by: khazra, alanb, chegar Contributed-by: Mark Sheppard ! src/share/classes/com/sun/net/httpserver/BasicAuthenticator.java ! src/share/classes/sun/net/www/protocol/http/BasicAuthentication.java Changeset: 44d6cabc9a3f Author: robm Date: 2013-01-15 19:58 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/44d6cabc9a3f 8005618: TEST_BUG: java/lang/ProcessBuilder/Basic.java failing intermittently Reviewed-by: alanb, martin, dholmes ! test/java/lang/ProcessBuilder/Basic.java Changeset: 9d8ef6174cfd Author: dl Date: 2013-01-16 10:14 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/9d8ef6174cfd 8005926: Merge ThreadLocalRandom state into java.lang.Thread Reviewed-by: shade, chegar ! src/share/classes/java/lang/Thread.java ! src/share/classes/java/util/concurrent/ThreadLocalRandom.java Changeset: a546d8897e0d Author: dl Date: 2013-01-16 12:09 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/a546d8897e0d 8001666: Add lambda-compatible atomics and accumulators to the ActomicXXX classes Reviewed-by: dl, chegar, darcy, goetz Contributed-by: dl at cs.oswego.edu, chris.hegarty at oracle.com ! src/share/classes/java/util/concurrent/atomic/AtomicInteger.java ! src/share/classes/java/util/concurrent/atomic/AtomicIntegerArray.java ! src/share/classes/java/util/concurrent/atomic/AtomicIntegerFieldUpdater.java ! src/share/classes/java/util/concurrent/atomic/AtomicLong.java ! src/share/classes/java/util/concurrent/atomic/AtomicLongArray.java ! src/share/classes/java/util/concurrent/atomic/AtomicLongFieldUpdater.java ! src/share/classes/java/util/concurrent/atomic/AtomicReference.java ! src/share/classes/java/util/concurrent/atomic/AtomicReferenceArray.java ! src/share/classes/java/util/concurrent/atomic/AtomicReferenceFieldUpdater.java Changeset: c7d54f93d3e5 Author: juh Date: 2013-01-16 09:51 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/c7d54f93d3e5 8005389: Backout fix for JDK-6500133 Reviewed-by: mullan ! src/share/classes/sun/security/x509/URIName.java ! test/sun/security/x509/URIName/Parse.java Changeset: f7f77bdf248b Author: juh Date: 2013-01-16 13:35 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/f7f77bdf248b 8005939: sun/security/x509/{X509CRLImplX509CertImpl}/Verify.java fail in confusing way when some providers not present Reviewed-by: mullan, weijun ! test/sun/security/x509/X509CRLImpl/Verify.java ! test/sun/security/x509/X509CertImpl/Verify.java Changeset: 32a57e645e01 Author: katleman Date: 2013-01-03 12:44 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/32a57e645e01 Added tag jdk8-b71 for changeset 2a5af0f766d0 ! .hgtags Changeset: c9a914b11436 Author: katleman Date: 2013-01-10 09:55 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/c9a914b11436 Added tag jdk8-b72 for changeset 32a57e645e01 ! .hgtags Changeset: d54922883f4c Author: alexsch Date: 2013-01-09 16:52 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/d54922883f4c 8005019: JTable passes row index instead of length when inserts selection interval Reviewed-by: serb, denis ! src/share/classes/javax/swing/JTable.java + test/javax/swing/JTable/8005019/bug8005019.java Changeset: b2c425d7e5be Author: lana Date: 2013-01-10 15:49 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/b2c425d7e5be Merge Changeset: 733885f57e14 Author: lana Date: 2013-01-10 15:52 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/733885f57e14 Merge Changeset: 9fed48caac80 Author: lana Date: 2013-01-16 12:07 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/9fed48caac80 Merge Changeset: 787c7c1c210f Author: sherman Date: 2013-01-17 12:49 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/787c7c1c210f 8006090: Formatter asserts with -esa Summary: removed the offending assert Reviewed-by: alanb, darcy Contributed-by: brian.burkhalter at oracle.com ! src/share/classes/java/util/Formatter.java ! test/ProblemList.txt Changeset: e8414d69692c Author: khazra Date: 2013-01-17 14:50 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/e8414d69692c 7171415: java.net.URI.equals/hashCode not consistent for some URIs Summary: Rewrite URI.hashCode() to consider encoded characters, also reviewed by vitalyd at gmail.com, schlosna at gmail.com Reviewed-by: chegar ! src/share/classes/java/net/URI.java ! test/java/net/URI/Test.java Changeset: 79fed1733d4a Author: jgish Date: 2013-01-17 15:09 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/79fed1733d4a 8006534: CLONE - TestLibrary.getUnusedRandomPort() fails intermittently-doesn't retry enough times Summary: Increase number of retries to twice the number of ports in the reserved range Reviewed-by: mduigou ! test/java/rmi/testlibrary/TestLibrary.java Changeset: f88e963960ae Author: jzavgren Date: 2013-01-18 17:34 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/f88e963960ae 8005120: Compiler warnings in socket transport native code Reviewed-by: chegar, dsamersoff ! src/share/transport/socket/socketTransport.c ! src/share/transport/socket/sysSocket.h ! src/solaris/transport/socket/socket_md.c ! src/windows/transport/socket/socket_md.c Changeset: 06da87777d0e Author: alanb Date: 2013-01-18 18:48 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/06da87777d0e 6939260: (fs) BasicFileAttributes.lastModifiedTime() should return last modified time with higher precision Reviewed-by: chegar ! src/solaris/classes/sun/nio/fs/UnixFileAttributes.java ! src/solaris/native/sun/nio/fs/UnixNativeDispatcher.c ! test/java/nio/file/attribute/BasicFileAttributeView/Basic.java Changeset: 33d0175ea8d9 Author: msheppar Date: 2013-01-19 08:39 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/33d0175ea8d9 8006568: HTTP protocol handler NLTM Authentication should use Base64 API Reviewed-by: chegar, alanb ! src/solaris/classes/sun/net/www/protocol/http/ntlm/NTLMAuthentication.java ! src/windows/classes/sun/net/www/protocol/http/ntlm/NTLMAuthSequence.java ! test/sun/net/www/protocol/http/ProxyTunnelServer.java Changeset: 78514544980d Author: lancea Date: 2013-01-19 10:11 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/78514544980d 8006139: add missing methods to javax.sql.rowset.serial.SQLInputImpl, SQLOutputImpl Reviewed-by: naoto, ulfzibis, alanb ! src/share/classes/javax/sql/rowset/serial/SQLInputImpl.java ! src/share/classes/javax/sql/rowset/serial/SQLOutputImpl.java Changeset: d3da0d29d7cd Author: lancea Date: 2013-01-19 10:53 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/d3da0d29d7cd 8005080: JDBC 4.2 Core changes Reviewed-by: naoto ! src/share/classes/java/sql/BatchUpdateException.java ! src/share/classes/java/sql/CallableStatement.java ! src/share/classes/java/sql/DatabaseMetaData.java ! src/share/classes/java/sql/Driver.java ! src/share/classes/java/sql/DriverManager.java + src/share/classes/java/sql/JDBCType.java ! src/share/classes/java/sql/PreparedStatement.java ! src/share/classes/java/sql/ResultSet.java ! src/share/classes/java/sql/SQLTimeoutException.java + src/share/classes/java/sql/SQLType.java ! src/share/classes/java/sql/Statement.java ! src/share/classes/java/sql/Types.java ! src/share/classes/java/sql/package.html ! src/share/classes/javax/sql/DataSource.java ! src/share/classes/javax/sql/XADataSource.java ! src/share/classes/javax/sql/rowset/BaseRowSet.java Changeset: bb2ed83676d2 Author: chegar Date: 2013-01-20 09:37 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/bb2ed83676d2 8006560: java/net/ipv6tests/B6521014.java fails intermittently Reviewed-by: khazra, wetmore ! test/java/net/ipv6tests/B6521014.java Changeset: 6ca6b6f07653 Author: okutsu Date: 2013-01-21 12:04 +0900 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/6ca6b6f07653 4745761: (cal) RFE: Support builder for constructing Calendar Reviewed-by: peytoia ! src/share/classes/java/util/Calendar.java ! src/share/classes/java/util/GregorianCalendar.java ! src/share/classes/java/util/JapaneseImperialCalendar.java + test/java/util/Calendar/Builder/BuilderTest.java ! test/java/util/Calendar/CalendarTypeTest.java Changeset: 3c1a440a1e12 Author: okutsu Date: 2013-01-21 15:41 +0900 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/3c1a440a1e12 8004489: Add support for Minguo and Hijrah calendars to CalendarNameProvider SPI 8006509: Add more calendar symbol names from CLDR Reviewed-by: peytoia ! make/tools/src/build/tools/cldrconverter/Bundle.java ! make/tools/src/build/tools/cldrconverter/CLDRConverter.java ! make/tools/src/build/tools/cldrconverter/CalendarType.java ! make/tools/src/build/tools/cldrconverter/LDMLParseHandler.java ! src/share/classes/java/util/spi/CalendarNameProvider.java ! src/share/classes/sun/text/resources/FormatData.java ! src/share/classes/sun/text/resources/ar/FormatData_ar.java ! src/share/classes/sun/text/resources/be/FormatData_be.java ! src/share/classes/sun/text/resources/bg/FormatData_bg.java ! src/share/classes/sun/text/resources/ca/FormatData_ca.java ! src/share/classes/sun/text/resources/cs/FormatData_cs.java ! src/share/classes/sun/text/resources/da/FormatData_da.java ! src/share/classes/sun/text/resources/de/FormatData_de.java ! src/share/classes/sun/text/resources/el/FormatData_el.java ! src/share/classes/sun/text/resources/es/FormatData_es.java ! src/share/classes/sun/text/resources/et/FormatData_et.java ! src/share/classes/sun/text/resources/fi/FormatData_fi.java ! src/share/classes/sun/text/resources/fr/FormatData_fr.java ! src/share/classes/sun/text/resources/hi/FormatData_hi_IN.java ! src/share/classes/sun/text/resources/hr/FormatData_hr.java ! src/share/classes/sun/text/resources/hu/FormatData_hu.java ! src/share/classes/sun/text/resources/is/FormatData_is.java ! src/share/classes/sun/text/resources/it/FormatData_it.java ! src/share/classes/sun/text/resources/iw/FormatData_iw.java ! src/share/classes/sun/text/resources/ja/FormatData_ja.java ! src/share/classes/sun/text/resources/ko/FormatData_ko.java ! src/share/classes/sun/text/resources/lt/FormatData_lt.java ! src/share/classes/sun/text/resources/lv/FormatData_lv.java ! src/share/classes/sun/text/resources/mk/FormatData_mk.java ! src/share/classes/sun/text/resources/ms/FormatData_ms.java ! src/share/classes/sun/text/resources/mt/FormatData_mt.java ! src/share/classes/sun/text/resources/nl/FormatData_nl.java ! src/share/classes/sun/text/resources/pl/FormatData_pl.java ! src/share/classes/sun/text/resources/pt/FormatData_pt.java ! src/share/classes/sun/text/resources/ro/FormatData_ro.java ! src/share/classes/sun/text/resources/ru/FormatData_ru.java ! src/share/classes/sun/text/resources/sk/FormatData_sk.java ! src/share/classes/sun/text/resources/sl/FormatData_sl.java ! src/share/classes/sun/text/resources/sr/FormatData_sr.java ! src/share/classes/sun/text/resources/sv/FormatData_sv.java ! src/share/classes/sun/text/resources/th/FormatData_th.java ! src/share/classes/sun/text/resources/tr/FormatData_tr.java ! src/share/classes/sun/text/resources/uk/FormatData_uk.java ! src/share/classes/sun/text/resources/vi/FormatData_vi.java ! src/share/classes/sun/text/resources/zh/FormatData_zh.java ! src/share/classes/sun/text/resources/zh/FormatData_zh_TW.java ! src/share/classes/sun/util/locale/provider/CalendarDataUtility.java ! src/share/classes/sun/util/locale/provider/CalendarNameProviderImpl.java ! src/share/classes/sun/util/locale/provider/LocaleResources.java + test/java/util/Calendar/CldrFormatNamesTest.java ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java Changeset: bb940b2107bd Author: juh Date: 2013-01-21 15:05 +0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/bb940b2107bd 8006092: SecurityPermission: printIdentity doesn't exist Reviewed-by: weijun ! test/sun/security/tools/policytool/UpdatePermissions.html Changeset: f21a3c273fb2 Author: dl Date: 2013-01-21 13:50 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/f21a3c273fb2 8005311: Add Scalable Updatable Variables, DoubleAccumulator, DoubleAdder, LongAccumulator, LongAdder Reviewed-by: chegar, darcy, goetz ! make/java/java/FILES_java.gmk + src/share/classes/java/util/concurrent/atomic/DoubleAccumulator.java + src/share/classes/java/util/concurrent/atomic/DoubleAdder.java + src/share/classes/java/util/concurrent/atomic/LongAccumulator.java + src/share/classes/java/util/concurrent/atomic/LongAdder.java + src/share/classes/java/util/concurrent/atomic/Striped64.java + test/java/util/concurrent/atomic/DoubleAdderDemo.java + test/java/util/concurrent/atomic/LongAdderDemo.java Changeset: de30e46250c5 Author: lancea Date: 2013-01-21 14:08 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/de30e46250c5 8006642: Fix javadoc warnings due to Integer.MAX_VALUE Reviewed-by: alanb ! src/share/classes/java/sql/BatchUpdateException.java ! src/share/classes/java/sql/PreparedStatement.java ! src/share/classes/java/sql/Statement.java Changeset: 965e89e2abd3 Author: katleman Date: 2013-01-16 12:00 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/965e89e2abd3 Added tag jdk8-b73 for changeset 733885f57e14 ! .hgtags Changeset: e91caf05f441 Author: erikj Date: 2012-12-27 20:18 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/e91caf05f441 8005540: build-infra: Improve incremental build speed on windows by caching find results Reviewed-by: ohair ! makefiles/BuildJdk.gmk ! makefiles/CompileDemos.gmk ! makefiles/CompileLaunchers.gmk ! makefiles/CompileNativeLibraries.gmk ! makefiles/CopyIntoClasses.gmk ! makefiles/CreateJars.gmk ! makefiles/GensrcProperties.gmk ! makefiles/GensrcX11Wrappers.gmk ! makefiles/Images.gmk ! makefiles/Tools.gmk Changeset: 368fa50469da Author: erikj Date: 2012-12-28 09:51 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/368fa50469da 8005549: build-infra: Merge NewMakefile.gmk and common/makefiles/Makefile Reviewed-by: ohair, tbell ! makefiles/BuildJdk.gmk Changeset: 461b069100fa Author: erikj Date: 2013-01-02 15:35 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/461b069100fa 8005355: build-infra: Java security signing (need a top-level make target). Reviewed-by: tbell, ohair ! makefiles/BuildJdk.gmk ! makefiles/CompileJavaClasses.gmk ! makefiles/CreateJars.gmk + makefiles/SignJars.gmk Changeset: 3841da683703 Author: erikj Date: 2013-01-03 20:55 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/3841da683703 8005635: build-infra: Support building install in jprt Reviewed-by: ohair Contributed-by: tim.bell at oracle.com, erik.joelsson at oracle.com ! make/common/shared/Defs-windows.gmk ! makefiles/BuildJdk.gmk ! makefiles/Bundles.gmk ! makefiles/Images.gmk ! makefiles/Tools.gmk Changeset: a8d25b689563 Author: erikj Date: 2013-01-04 16:54 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/a8d25b689563 8005694: build-infra: Cleanup of misc changes in build-infra Reviewed-by: tbell ! makefiles/CompileJavaClasses.gmk ! makefiles/CompileNativeLibraries.gmk ! makefiles/CreateJars.gmk Changeset: 3824d8469dcf Author: erikj Date: 2013-01-04 17:09 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/3824d8469dcf 8005654: build-infra: Create sec-bin.zip Reviewed-by: tbell ! makefiles/CreateJars.gmk Changeset: d98e73b7bc78 Author: erikj Date: 2013-01-04 22:43 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/d98e73b7bc78 8005723: build-infra: in new infra build, sec-windows-bin-zip and jgss-windows-*-bin.zip are missing Reviewed-by: tbell ! makefiles/CreateJars.gmk Changeset: 244e481f538b Author: katleman Date: 2013-01-08 13:15 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/244e481f538b Merge ! makefiles/CreateJars.gmk Changeset: 1868bde529b8 Author: ohrstrom Date: 2013-01-09 13:33 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/1868bde529b8 8005096: Move a few source files in swing/beaninfo and in a demo. Reviewed-by: ohair, erikj, malenkov ! make/javax/swing/beaninfo/SwingBeans.gmk - make/tools/swing-beans/beaninfo/BeanInfoUtils.java - make/tools/swing-beans/beaninfo/SwingBeanInfoBase.java + make/tools/swing-beans/javax/swing/SwingBeanInfoBase.java + make/tools/swing-beans/sun/swing/BeanInfoUtils.java ! makefiles/CompileJavaClasses.gmk ! makefiles/GensrcSwing.gmk - src/share/demo/jfc/CodePointIM/CodePointInputMethod.java - src/share/demo/jfc/CodePointIM/CodePointInputMethodDescriptor.java + src/share/demo/jfc/CodePointIM/com/sun/inputmethods/internal/codepointim/CodePointInputMethod.java + src/share/demo/jfc/CodePointIM/com/sun/inputmethods/internal/codepointim/CodePointInputMethodDescriptor.java Changeset: 2cc29d0b9eaf Author: erikj Date: 2013-01-09 16:13 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/2cc29d0b9eaf 8005903: build-infra: bad symlink: j2sdk-bundle/jdk1.8.0.jdk/Contents/MacOS/libjli.dylib Reviewed-by: tbell ! makefiles/Bundles.gmk Changeset: f92ab6dbbff8 Author: erikj Date: 2013-01-10 12:23 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/f92ab6dbbff8 8005856: build-infra: Remove special handling of base module classes header generation Reviewed-by: alanb, tbell, ohair Contributed-by: fredrik.ohrstrom at oracle.com ! makefiles/CompileJavaClasses.gmk ! src/share/classes/java/io/FileSystem.java ! src/share/classes/java/lang/Integer.java ! src/share/classes/java/lang/Long.java ! src/share/classes/java/net/SocketOptions.java ! src/share/classes/sun/nio/ch/IOStatus.java ! src/windows/classes/sun/nio/ch/PollArrayWrapper.java Changeset: 4d80ab394efa Author: erikj Date: 2013-01-15 16:50 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/4d80ab394efa 8006296: build-infra: Unsigned sunmscapi.jar is missing manifest. Reviewed-by: alanb, tbell ! makefiles/CreateJars.gmk Changeset: 6d1a3d43851d Author: katleman Date: 2013-01-15 10:08 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/6d1a3d43851d Merge - make/tools/swing-beans/beaninfo/BeanInfoUtils.java - make/tools/swing-beans/beaninfo/SwingBeanInfoBase.java - src/share/demo/jfc/CodePointIM/CodePointInputMethod.java - src/share/demo/jfc/CodePointIM/CodePointInputMethodDescriptor.java Changeset: 3eef1e0540c4 Author: erikj Date: 2013-01-16 16:40 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/3eef1e0540c4 8006385: build-infra: linux and solaris *-debuginfo-*.zip file created from the new makefile has extra HUDSON direcotry in jre/lib/i386/server Reviewed-by: tbell ! makefiles/Import.gmk Changeset: 54bbeb149525 Author: katleman Date: 2013-01-16 22:21 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/54bbeb149525 Merge - make/tools/swing-beans/beaninfo/BeanInfoUtils.java - make/tools/swing-beans/beaninfo/SwingBeanInfoBase.java ! makefiles/CompileLaunchers.gmk ! makefiles/CreateJars.gmk ! makefiles/Images.gmk ! src/share/classes/java/lang/Integer.java - src/share/demo/jfc/CodePointIM/CodePointInputMethod.java - src/share/demo/jfc/CodePointIM/CodePointInputMethodDescriptor.java Changeset: 8b1857409159 Author: lana Date: 2013-01-20 23:38 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/8b1857409159 Merge - make/tools/swing-beans/beaninfo/BeanInfoUtils.java - make/tools/swing-beans/beaninfo/SwingBeanInfoBase.java - src/share/demo/jfc/CodePointIM/CodePointInputMethod.java - src/share/demo/jfc/CodePointIM/CodePointInputMethodDescriptor.java Changeset: 7f4e3da76ec1 Author: lana Date: 2013-01-21 11:16 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/7f4e3da76ec1 Merge Changeset: 8ee6d45348ba Author: vinnie Date: 2013-01-22 23:32 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/8ee6d45348ba 6263419: No way to clean the memory for a java.security.Key Reviewed-by: mullan ! src/share/classes/java/security/PrivateKey.java ! src/share/classes/javax/crypto/SecretKey.java ! src/share/classes/javax/security/auth/Destroyable.java + test/javax/security/auth/Destroyable/KeyDestructionTest.java Changeset: c18f28312c49 Author: smarks Date: 2013-01-22 18:30 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/c18f28312c49 8005646: TEST_BUG: java/rmi/activation/ActivationSystem/unregisterGroup/UnregisterGroup leaves process running Reviewed-by: mchung ! test/java/rmi/activation/ActivationSystem/unregisterGroup/ActivateMe.java - test/java/rmi/activation/ActivationSystem/unregisterGroup/CallbackInterface.java - test/java/rmi/activation/ActivationSystem/unregisterGroup/Callback_Stub.java ! test/java/rmi/activation/ActivationSystem/unregisterGroup/UnregisterGroup.java - test/java/rmi/activation/ActivationSystem/unregisterGroup/UnregisterGroup_Stub.java ! test/java/rmi/activation/ActivationSystem/unregisterGroup/rmid.security.policy Changeset: 919afffa70b0 Author: sherman Date: 2013-01-22 20:59 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/919afffa70b0 8003680: JSR 310 Date/Time API Summary: Integration of JSR310 Date/Time API for M6 Reviewed-by: alanb, naoto, dholmes Contributed-by: scolebourne at joda.org, roger.riggs at oracle.com, richard.warburton at gmail.com, misterm at gmail.com ! make/docs/CORE_PKGS.gmk ! make/java/Makefile + make/java/time/Makefile ! make/jprt.properties ! make/sun/Makefile + make/sun/tzdb/Makefile ! make/tools/Makefile + make/tools/src/build/tools/tzdb/ChronoField.java + make/tools/src/build/tools/tzdb/DateTimeException.java + make/tools/src/build/tools/tzdb/LocalDate.java + make/tools/src/build/tools/tzdb/LocalDateTime.java + make/tools/src/build/tools/tzdb/LocalTime.java + make/tools/src/build/tools/tzdb/TimeDefinition.java + make/tools/src/build/tools/tzdb/TzdbZoneRulesCompiler.java + make/tools/src/build/tools/tzdb/Utils.java + make/tools/src/build/tools/tzdb/ZoneOffset.java + make/tools/src/build/tools/tzdb/ZoneOffsetTransition.java + make/tools/src/build/tools/tzdb/ZoneOffsetTransitionRule.java + make/tools/src/build/tools/tzdb/ZoneRules.java + make/tools/src/build/tools/tzdb/ZoneRulesBuilder.java + make/tools/tzdb/Makefile ! makefiles/CreateJars.gmk + makefiles/GendataTZDB.gmk ! makefiles/GenerateData.gmk ! makefiles/Tools.gmk + src/share/classes/java/time/Clock.java + src/share/classes/java/time/DateTimeException.java + src/share/classes/java/time/DayOfWeek.java + src/share/classes/java/time/Duration.java + src/share/classes/java/time/Instant.java + src/share/classes/java/time/LocalDate.java + src/share/classes/java/time/LocalDateTime.java + src/share/classes/java/time/LocalTime.java + src/share/classes/java/time/Month.java + src/share/classes/java/time/Period.java + src/share/classes/java/time/PeriodParser.java + src/share/classes/java/time/Ser.java + src/share/classes/java/time/ZoneId.java + src/share/classes/java/time/ZoneOffset.java + src/share/classes/java/time/ZoneRegion.java + src/share/classes/java/time/ZonedDateTime.java + src/share/classes/java/time/calendar/ChronoDateImpl.java + src/share/classes/java/time/calendar/HijrahChrono.java + src/share/classes/java/time/calendar/HijrahDate.java + src/share/classes/java/time/calendar/HijrahDeviationReader.java + src/share/classes/java/time/calendar/HijrahEra.java + src/share/classes/java/time/calendar/JapaneseChrono.java + src/share/classes/java/time/calendar/JapaneseDate.java + src/share/classes/java/time/calendar/JapaneseEra.java + src/share/classes/java/time/calendar/MinguoChrono.java + src/share/classes/java/time/calendar/MinguoDate.java + src/share/classes/java/time/calendar/MinguoEra.java + src/share/classes/java/time/calendar/Ser.java + src/share/classes/java/time/calendar/ThaiBuddhistChrono.java + src/share/classes/java/time/calendar/ThaiBuddhistDate.java + src/share/classes/java/time/calendar/ThaiBuddhistEra.java + src/share/classes/java/time/calendar/package-info.java + src/share/classes/java/time/format/DateTimeBuilder.java + src/share/classes/java/time/format/DateTimeFormatStyleProvider.java + src/share/classes/java/time/format/DateTimeFormatSymbols.java + src/share/classes/java/time/format/DateTimeFormatter.java + src/share/classes/java/time/format/DateTimeFormatterBuilder.java + src/share/classes/java/time/format/DateTimeFormatters.java + src/share/classes/java/time/format/DateTimeParseContext.java + src/share/classes/java/time/format/DateTimeParseException.java + src/share/classes/java/time/format/DateTimePrintContext.java + src/share/classes/java/time/format/DateTimePrintException.java + src/share/classes/java/time/format/DateTimeTextProvider.java + src/share/classes/java/time/format/FormatStyle.java + src/share/classes/java/time/format/SignStyle.java + src/share/classes/java/time/format/TextStyle.java + src/share/classes/java/time/format/package-info.java + src/share/classes/java/time/overview.html + src/share/classes/java/time/package-info.java + src/share/classes/java/time/temporal/Adjusters.java + src/share/classes/java/time/temporal/Chrono.java + src/share/classes/java/time/temporal/ChronoField.java + src/share/classes/java/time/temporal/ChronoLocalDate.java + src/share/classes/java/time/temporal/ChronoLocalDateTime.java + src/share/classes/java/time/temporal/ChronoLocalDateTimeImpl.java + src/share/classes/java/time/temporal/ChronoUnit.java + src/share/classes/java/time/temporal/ChronoZonedDateTime.java + src/share/classes/java/time/temporal/ChronoZonedDateTimeImpl.java + src/share/classes/java/time/temporal/Era.java + src/share/classes/java/time/temporal/ISOChrono.java + src/share/classes/java/time/temporal/ISOEra.java + src/share/classes/java/time/temporal/ISOFields.java + src/share/classes/java/time/temporal/JulianFields.java + src/share/classes/java/time/temporal/MonthDay.java + src/share/classes/java/time/temporal/OffsetDate.java + src/share/classes/java/time/temporal/OffsetDateTime.java + src/share/classes/java/time/temporal/OffsetTime.java + src/share/classes/java/time/temporal/Queries.java + src/share/classes/java/time/temporal/Ser.java + src/share/classes/java/time/temporal/SimplePeriod.java + src/share/classes/java/time/temporal/Temporal.java + src/share/classes/java/time/temporal/TemporalAccessor.java + src/share/classes/java/time/temporal/TemporalAdder.java + src/share/classes/java/time/temporal/TemporalAdjuster.java + src/share/classes/java/time/temporal/TemporalField.java + src/share/classes/java/time/temporal/TemporalQuery.java + src/share/classes/java/time/temporal/TemporalSubtractor.java + src/share/classes/java/time/temporal/TemporalUnit.java + src/share/classes/java/time/temporal/ValueRange.java + src/share/classes/java/time/temporal/WeekFields.java + src/share/classes/java/time/temporal/Year.java + src/share/classes/java/time/temporal/YearMonth.java + src/share/classes/java/time/temporal/package-info.java + src/share/classes/java/time/zone/Ser.java + src/share/classes/java/time/zone/TzdbZoneRulesProvider.java + src/share/classes/java/time/zone/ZoneOffsetTransition.java + src/share/classes/java/time/zone/ZoneOffsetTransitionRule.java + src/share/classes/java/time/zone/ZoneRules.java + src/share/classes/java/time/zone/ZoneRulesException.java + src/share/classes/java/time/zone/ZoneRulesProvider.java + src/share/classes/java/time/zone/package-info.java ! src/share/classes/java/util/Formatter.java ! test/Makefile + test/java/time/META-INF/services/java.time.temporal.Chrono + test/java/time/TEST.properties + test/java/time/tck/java/time/AbstractDateTimeTest.java + test/java/time/tck/java/time/AbstractTCKTest.java + test/java/time/tck/java/time/TCKClock.java + test/java/time/tck/java/time/TCKClock_Fixed.java + test/java/time/tck/java/time/TCKClock_Offset.java + test/java/time/tck/java/time/TCKClock_System.java + test/java/time/tck/java/time/TCKClock_Tick.java + test/java/time/tck/java/time/TCKDayOfWeek.java + test/java/time/tck/java/time/TCKDuration.java + test/java/time/tck/java/time/TCKInstant.java + test/java/time/tck/java/time/TCKLocalDate.java + test/java/time/tck/java/time/TCKLocalDateTime.java + test/java/time/tck/java/time/TCKLocalTime.java + test/java/time/tck/java/time/TCKMonth.java + test/java/time/tck/java/time/TCKZoneId.java + test/java/time/tck/java/time/TCKZoneOffset.java + test/java/time/tck/java/time/TCKZonedDateTime.java + test/java/time/tck/java/time/calendar/CopticChrono.java + test/java/time/tck/java/time/calendar/CopticDate.java + test/java/time/tck/java/time/calendar/CopticEra.java + test/java/time/tck/java/time/calendar/TestChronoLocalDate.java + test/java/time/tck/java/time/calendar/TestChronoLocalDateTime.java + test/java/time/tck/java/time/calendar/TestHijrahChrono.java + test/java/time/tck/java/time/calendar/TestJapaneseChrono.java + test/java/time/tck/java/time/calendar/TestMinguoChrono.java + test/java/time/tck/java/time/calendar/TestServiceLoader.java + test/java/time/tck/java/time/calendar/TestThaiBuddhistChrono.java + test/java/time/tck/java/time/format/TCKDateTimeFormatSymbols.java + test/java/time/tck/java/time/format/TCKDateTimeFormatter.java + test/java/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java + test/java/time/tck/java/time/format/TCKDateTimeFormatters.java + test/java/time/tck/java/time/format/TCKDateTimePrintException.java + test/java/time/tck/java/time/format/TCKDateTimeTextPrinting.java + test/java/time/tck/java/time/format/TCKLocalizedFieldParser.java + test/java/time/tck/java/time/format/TCKLocalizedFieldPrinter.java + test/java/time/tck/java/time/temporal/TCKDateTimeAdjusters.java + test/java/time/tck/java/time/temporal/TCKISOFields.java + test/java/time/tck/java/time/temporal/TCKJulianFields.java + test/java/time/tck/java/time/temporal/TCKMonthDay.java + test/java/time/tck/java/time/temporal/TCKOffsetDate.java + test/java/time/tck/java/time/temporal/TCKOffsetDateTime.java + test/java/time/tck/java/time/temporal/TCKOffsetTime.java + test/java/time/tck/java/time/temporal/TCKSimplePeriod.java + test/java/time/tck/java/time/temporal/TCKWeekFields.java + test/java/time/tck/java/time/temporal/TCKYear.java + test/java/time/tck/java/time/temporal/TCKYearMonth.java + test/java/time/tck/java/time/temporal/TestChrono.java + test/java/time/tck/java/time/temporal/TestChronoLocalDate.java + test/java/time/tck/java/time/temporal/TestChronoLocalDateTime.java + test/java/time/tck/java/time/temporal/TestChronoZonedDateTime.java + test/java/time/tck/java/time/temporal/TestISOChrono.java + test/java/time/tck/java/time/zone/TCKFixedZoneRules.java + test/java/time/tck/java/time/zone/TCKZoneOffsetTransition.java + test/java/time/tck/java/time/zone/TCKZoneOffsetTransitionRule.java + test/java/time/tck/java/time/zone/TCKZoneRules.java + test/java/time/tck/java/time/zone/TCKZoneRulesProvider.java + test/java/time/test/java/time/AbstractTest.java + test/java/time/test/java/time/MockSimplePeriod.java + test/java/time/test/java/time/TestClock_Fixed.java + test/java/time/test/java/time/TestClock_Offset.java + test/java/time/test/java/time/TestClock_System.java + test/java/time/test/java/time/TestClock_Tick.java + test/java/time/test/java/time/TestDuration.java + test/java/time/test/java/time/TestInstant.java + test/java/time/test/java/time/TestLocalDate.java + test/java/time/test/java/time/TestLocalDateTime.java + test/java/time/test/java/time/TestLocalTime.java + test/java/time/test/java/time/TestPeriod.java + test/java/time/test/java/time/TestPeriodParser.java + test/java/time/test/java/time/TestZoneId.java + test/java/time/test/java/time/TestZoneOffset.java + test/java/time/test/java/time/TestZonedDateTime.java + test/java/time/test/java/time/format/AbstractTestPrinterParser.java + test/java/time/test/java/time/format/MockIOExceptionAppendable.java + test/java/time/test/java/time/format/TestCharLiteralParser.java + test/java/time/test/java/time/format/TestCharLiteralPrinter.java + test/java/time/test/java/time/format/TestDateTimeFormatSymbols.java + test/java/time/test/java/time/format/TestDateTimeFormatter.java + test/java/time/test/java/time/format/TestDateTimeFormatters.java + test/java/time/test/java/time/format/TestDateTimePrintException.java + test/java/time/test/java/time/format/TestDateTimeTextProvider.java + test/java/time/test/java/time/format/TestFractionPrinterParser.java + test/java/time/test/java/time/format/TestNumberParser.java + test/java/time/test/java/time/format/TestNumberPrinter.java + test/java/time/test/java/time/format/TestPadParserDecorator.java + test/java/time/test/java/time/format/TestPadPrinterDecorator.java + test/java/time/test/java/time/format/TestReducedParser.java + test/java/time/test/java/time/format/TestReducedPrinter.java + test/java/time/test/java/time/format/TestSettingsParser.java + test/java/time/test/java/time/format/TestStringLiteralParser.java + test/java/time/test/java/time/format/TestStringLiteralPrinter.java + test/java/time/test/java/time/format/TestTextParser.java + test/java/time/test/java/time/format/TestTextPrinter.java + test/java/time/test/java/time/format/TestZoneIdParser.java + test/java/time/test/java/time/format/TestZoneOffsetParser.java + test/java/time/test/java/time/format/TestZoneOffsetPrinter.java + test/java/time/test/java/time/format/TestZoneTextPrinterParser.java + test/java/time/test/java/time/temporal/MockFieldNoValue.java + test/java/time/test/java/time/temporal/MockFieldValue.java + test/java/time/test/java/time/temporal/TestChronoUnit.java + test/java/time/test/java/time/temporal/TestDateTimeAdjusters.java + test/java/time/test/java/time/temporal/TestDateTimeBuilderCombinations.java + test/java/time/test/java/time/temporal/TestDateTimeValueRange.java + test/java/time/test/java/time/temporal/TestISOChronoImpl.java + test/java/time/test/java/time/temporal/TestJapaneseChronoImpl.java + test/java/time/test/java/time/temporal/TestMonthDay.java + test/java/time/test/java/time/temporal/TestOffsetDate.java + test/java/time/test/java/time/temporal/TestOffsetDateTime.java + test/java/time/test/java/time/temporal/TestOffsetDateTime_instants.java + test/java/time/test/java/time/temporal/TestOffsetTime.java + test/java/time/test/java/time/temporal/TestThaiBuddhistChronoImpl.java + test/java/time/test/java/time/temporal/TestYear.java + test/java/time/test/java/time/temporal/TestYearMonth.java + test/java/time/test/java/time/zone/TestFixedZoneRules.java + test/java/time/test/java/util/TestFormatter.java Changeset: 71691b9d45ab Author: vinnie Date: 2013-01-23 09:49 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/71691b9d45ab 8006741: javadoc cleanup for 6263419 Reviewed-by: alanb ! src/share/classes/java/security/PrivateKey.java ! src/share/classes/javax/crypto/SecretKey.java Changeset: 01b36b400145 Author: uta Date: 2013-01-23 15:06 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/01b36b400145 6519127: user.home property not set correctly Summary: Registry-based approach was changed to SHGetKnownFolderPath/SHGetFolderPathW Reviewed-by: alanb, anthony ! src/windows/native/java/lang/java_props_md.c Changeset: bf2a14ebb6e9 Author: chegar Date: 2013-01-23 14:45 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/bf2a14ebb6e9 8006669: sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/PostThruProxy.sh fails on mac Reviewed-by: alanb ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/PostThruProxy.java ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/PostThruProxyWithAuth.java Changeset: 53064bbaeec5 Author: alanb Date: 2013-01-23 15:12 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/53064bbaeec5 8006764: FunctionalInterface missing from rt.jar (old build) Reviewed-by: lancea, forax ! make/java/java/FILES_java.gmk Changeset: c9eb1d3ef37f Author: robm Date: 2013-01-23 17:54 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/c9eb1d3ef37f 8004729: Add java.lang.reflect.Parameter and related changes for parameter reflection Reviewed-by: darcy, forax, psandoz, dholmes, tbell ! make/java/java/Exportedfiles.gmk ! make/java/java/FILES_c.gmk ! make/java/java/mapfile-vers ! makefiles/mapfiles/libjava/mapfile-vers ! src/share/classes/java/lang/reflect/Constructor.java ! src/share/classes/java/lang/reflect/Executable.java ! src/share/classes/java/lang/reflect/Method.java ! src/share/classes/java/lang/reflect/Modifier.java + src/share/classes/java/lang/reflect/Parameter.java ! src/share/javavm/export/jvm.h + src/share/native/java/lang/reflect/Executable.c + test/java/lang/reflect/Parameter/WithParameters.java + test/java/lang/reflect/Parameter/WithoutParameters.java Changeset: e0552f13f4a2 Author: sherman Date: 2013-01-23 10:29 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/e0552f13f4a2 8006773: test/java/util/zip/ZipFile/FinalizeZipFile.java failing intermittently Summary: fixed the test case Reviewed-by: alanb ! test/java/util/zip/ZipFile/FinalizeZipFile.java Changeset: 87f5569effdd Author: sherman Date: 2013-01-23 10:31 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/87f5569effdd Merge Changeset: 0c86df653029 Author: vinnie Date: 2013-01-23 21:25 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/0c86df653029 8006591: Protect keystore entries using stronger PBE algorithms Reviewed-by: mullan ! src/share/classes/java/security/KeyStore.java ! src/share/classes/sun/security/pkcs12/PKCS12KeyStore.java + test/java/security/KeyStore/PBETest.java Changeset: 1da93663f8f3 Author: vinnie Date: 2013-01-23 23:13 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/1da93663f8f3 8005408: KeyStore API enhancements Reviewed-by: mullan ! src/share/classes/java/security/KeyStore.java + src/share/classes/java/security/PKCS12Attribute.java ! src/share/classes/sun/security/pkcs12/PKCS12KeyStore.java ! src/share/classes/sun/security/x509/AlgorithmId.java + test/sun/security/pkcs12/StorePasswordTest.java + test/sun/security/pkcs12/StoreSecretKeyTest.java + test/sun/security/pkcs12/StoreTrustedCertTest.java + test/sun/security/pkcs12/trusted.pem Changeset: 89f37f7188df Author: mullan Date: 2013-01-23 20:46 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/89f37f7188df 8006813: Compilation error in PKCS12KeyStore.java Reviewed-by: valeriep ! src/share/classes/sun/security/pkcs12/PKCS12KeyStore.java Changeset: b68ac92d0b2a Author: alanb Date: 2013-01-24 09:47 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/b68ac92d0b2a 8006524: JSR-3: Allows java.beans to be optional Reviewed-by: dfuchs, mchung ! src/share/classes/javax/management/MXBean.java ! src/share/classes/javax/management/monitor/package.html Changeset: 943af87e0269 Author: vinnie Date: 2013-01-24 16:44 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/943af87e0269 8006855: PKCS12 test failures due to unsupported algorithm Reviewed-by: mullan ! src/share/classes/sun/security/pkcs12/PKCS12KeyStore.java ! test/java/security/KeyStore/PBETest.java ! test/sun/security/pkcs12/StoreSecretKeyTest.java Changeset: 1fd613016ad9 Author: ksrini Date: 2013-01-24 09:34 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/1fd613016ad9 8006850: [pack200] disable pack200 tests until JSR-308 is implemented Reviewed-by: alanb ! test/ProblemList.txt Changeset: b3f0e0c79bcc Author: vinnie Date: 2013-01-24 18:21 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/b3f0e0c79bcc 8006863: javadoc cleanup for 8005408 Reviewed-by: alanb ! src/share/classes/java/security/PKCS12Attribute.java Changeset: 4d3c05cc21d5 Author: darcy Date: 2013-01-24 16:54 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/4d3c05cc21d5 8006895: Clarify that FunctionalInferface is only informative Reviewed-by: briangoetz ! src/share/classes/java/lang/FunctionalInterface.java Changeset: 4c9fcb5cbc07 Author: dingxmin Date: 2013-01-25 17:00 +0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/4c9fcb5cbc07 7183373: URLClassloader.close() does not close JAR files whose resources have been loaded via getResource() Reviewed-by: chegar ! src/share/classes/sun/misc/URLClassPath.java + test/sun/misc/URLClassPath/JarLoaderTest.java Changeset: 4a4b97f7f83b Author: alanb Date: 2013-01-25 13:09 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/4a4b97f7f83b 8006565: java.lang.instrument specification should make it clear that -javaagent is optional Reviewed-by: sla, dcubed, mchung ! src/share/classes/java/lang/instrument/package.html Changeset: c6ea84a629db Author: vinnie Date: 2013-01-25 16:19 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/c6ea84a629db 8006946: PKCS12 test failure due to incorrect alias name Reviewed-by: mullan ! src/share/classes/sun/security/pkcs12/PKCS12KeyStore.java Changeset: 117491dd58c2 Author: vinnie Date: 2013-01-25 17:47 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/117491dd58c2 8006951: Avoid storing duplicate PKCS12 attributes Reviewed-by: mullan ! src/share/classes/sun/security/pkcs12/PKCS12KeyStore.java Changeset: 77bde15bc6a9 Author: khazra Date: 2013-01-25 11:52 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/77bde15bc6a9 7017962: Obsolete link is used in URL class level spec Summary: Change the link to an archived document Reviewed-by: chegar, mduigou ! src/share/classes/java/net/URL.java Changeset: 4209b3936a7f Author: mduigou Date: 2013-01-25 16:13 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/4209b3936a7f 8005632: Extend java.util.Logger to use Supplier for messages Reviewed-by: briangoetz, mduigou Contributed-by: henry.jen at oracle.com ! src/share/classes/java/util/logging/Logger.java + test/java/util/logging/LoggerSupplierAPIsTest.java Changeset: 1d918647332e Author: mduigou Date: 2013-01-25 16:13 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/1d918647332e 8004201: Add static utility methods to primitives to be used for redution operations. Reviewed-by: darcy, mduigou, briangoetz, dholmes Contributed-by: akhil.arora at oracle.com ! src/share/classes/java/lang/Boolean.java ! src/share/classes/java/lang/Double.java ! src/share/classes/java/lang/Float.java ! src/share/classes/java/lang/Integer.java ! src/share/classes/java/lang/Long.java + test/java/lang/PrimitiveSumMinMaxTest.java Changeset: 86a5b435c928 Author: jgish Date: 2013-01-22 11:14 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/86a5b435c928 4247235: (spec str) StringBuffer.insert(int, char[]) specification is inconsistent Summary: Add blanket null-handling statement to StringBuilder and StringBuffer Reviewed-by: mduigou ! src/share/classes/java/lang/AbstractStringBuilder.java ! src/share/classes/java/lang/String.java ! src/share/classes/java/lang/StringBuffer.java ! src/share/classes/java/lang/StringBuilder.java Changeset: e96577d82cbb Author: alanb Date: 2013-01-26 16:57 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/e96577d82cbb 8006503: JVM_PrintStackTrace is not used in JDK Reviewed-by: alanb, darcy Contributed-by: eric.mccorkle at oracle.com ! src/share/javavm/export/jvm.h Changeset: a8bbd962f34a Author: jlaskey Date: 2013-01-28 16:29 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/a8bbd962f34a 8006676: Integrate Nashorn into new build system Reviewed-by: jlaskey Contributed-by: james.laskey at oracle.com ! THIRD_PARTY_README ! make/launchers/Makefile ! makefiles/CompileLaunchers.gmk ! makefiles/CreateJars.gmk ! test/tools/launcher/VersionCheck.java From hannes.wallnoefer at oracle.com Mon Jan 28 13:44:28 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Mon, 28 Jan 2013 22:44:28 +0100 Subject: Review request for JDK-8006950 Message-ID: <5106F13C.9060009@oracle.com> Please review webrev for JDK-8006950: http://cr.openjdk.java.net/~hannesw/8006950/ The gist of this is that we can omit calling ScriptObject.setProto() in constructors of Nasgen-processed classes if we know the prototype has been set correctly in the object's $nasgenmap$ field. This is because Nasgen inserts $nasgenmap$ to all calls to zero-arg ScriptObject super-constructor. Also, prototype properties of native ES constructors are non-writable and non-configurable. The patch contains an incomplete array microbenchmark (only array creation covered so far), most of which now is roughly 3x faster. Hannes From james.laskey at oracle.com Mon Jan 28 13:22:50 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Mon, 28 Jan 2013 21:22:50 +0000 Subject: hg: nashorn/jdk8/corba: 5 new changesets Message-ID: <20130128212253.2AF1747627@hg.openjdk.java.net> Changeset: 603cceb495c8 Author: katleman Date: 2012-12-20 09:17 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/corba/rev/603cceb495c8 Added tag jdk8-b69 for changeset 22ddcac208a8 ! .hgtags Changeset: 8171d23e914d Author: katleman Date: 2012-12-27 12:14 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/corba/rev/8171d23e914d Added tag jdk8-b70 for changeset 603cceb495c8 ! .hgtags Changeset: cb40427f4714 Author: katleman Date: 2013-01-03 12:44 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/corba/rev/cb40427f4714 Added tag jdk8-b71 for changeset 8171d23e914d ! .hgtags Changeset: 191afde59e7b Author: katleman Date: 2013-01-10 09:55 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/corba/rev/191afde59e7b Added tag jdk8-b72 for changeset cb40427f4714 ! .hgtags Changeset: 2132845cf5f7 Author: katleman Date: 2013-01-16 11:59 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/corba/rev/2132845cf5f7 Added tag jdk8-b73 for changeset 191afde59e7b ! .hgtags From frank.westlake at gmail.com Mon Jan 28 14:10:26 2013 From: frank.westlake at gmail.com (Frank Westlake) Date: Mon, 28 Jan 2013 14:10:26 -0800 Subject: Input from the public Message-ID: <5106F752.4090906@gmail.com> Please pardon the intrusion, but do you accept suggestions and requests for language enhancements? If so, where do I submit them? Frank Westlake From james.laskey at oracle.com Mon Jan 28 14:19:57 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Mon, 28 Jan 2013 14:19:57 -0800 (PST) Subject: Input from the public In-Reply-To: <5106F752.4090906@gmail.com> References: <5106F752.4090906@gmail.com> Message-ID: <9FC6E9FA-0616-4707-9E01-67705D896F34@oracle.com> This would be the spot. :-) On 2013-01-28, at 6:10 PM, Frank Westlake wrote: > Please pardon the intrusion, but do you accept suggestions > and requests for language enhancements? If so, where do I > submit them? > > Frank Westlake From james.laskey at oracle.com Mon Jan 28 15:12:48 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Mon, 28 Jan 2013 23:12:48 +0000 Subject: hg: nashorn/jdk8: 51 new changesets Message-ID: <20130128231251.AF0F147634@hg.openjdk.java.net> Changeset: fb1bf5e5bc9e Author: henryjen Date: 2012-12-06 15:38 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/fb1bf5e5bc9e 8004685: add java.util.function to CORE_PKGS.gmk Reviewed-by: mduigou ! common/makefiles/javadoc/CORE_PKGS.gmk Changeset: 2ed5be3dd506 Author: lana Date: 2012-12-16 22:02 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/2ed5be3dd506 Merge Changeset: a0779b1e9a4d Author: jjg Date: 2012-12-17 08:34 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/a0779b1e9a4d 8005090: Include com.sun.source.doctree in Tree API docs Reviewed-by: erikj ! common/makefiles/javadoc/NON_CORE_PKGS.gmk Changeset: e08b0096058f Author: lana Date: 2012-12-14 11:22 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/e08b0096058f Merge Changeset: 68a81db3ceb1 Author: lana Date: 2012-12-18 17:42 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/68a81db3ceb1 Merge Changeset: c37401e77c80 Author: mchung Date: 2012-12-28 22:20 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/c37401e77c80 8003562: Provide a CLI tool to analyze class dependencies Reviewed-by: jjg, alanb, ulfzibis, erikj ! common/bin/compare_exceptions.sh.incl Changeset: 8e36a0fabf58 Author: ohrstrom Date: 2012-12-18 09:57 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/8e36a0fabf58 8004145: New improved hgforest.sh, ctrl-c now properly terminates mercurial processes. Reviewed-by: ohair, erikj + common/bin/hgforest.sh ! get_source.sh Changeset: 51d3b65b8093 Author: erikj Date: 2012-12-18 17:54 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/51d3b65b8093 8001901: build-infra: Fix "misbehaving" which command on Solaris Summary: Removed all uses of which in configure on solaris. Reviewed-by: ohair ! common/autoconf/basics.m4 ! common/autoconf/generated-configure.sh Changeset: 6ee8080a6efe Author: katleman Date: 2012-12-19 13:36 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/6ee8080a6efe Merge Changeset: 32148e971ac8 Author: katleman Date: 2012-12-20 09:17 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/32148e971ac8 Added tag jdk8-b69 for changeset 6ee8080a6efe ! .hgtags Changeset: 6b93e7a4401d Author: dholmes Date: 2012-12-20 01:44 -0500 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/6b93e7a4401d 7190137: Add support for JVM_VARIANT minimal1 Summary: Allow configuration of minimal1 as a target VM along with client and server Reviewed-by: ohair, erikj ! common/autoconf/generated-configure.sh ! common/autoconf/jdk-options.m4 ! common/autoconf/spec.gmk.in ! common/autoconf/toolchain.m4 Changeset: cd06b2ea58dd Author: katleman Date: 2012-12-20 16:22 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/cd06b2ea58dd 8004982: JDK8 source with GPL header errors Reviewed-by: ohair ! common/makefiles/RMICompilation.gmk Changeset: 105a25ffa4a4 Author: katleman Date: 2012-12-26 14:23 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/105a25ffa4a4 Merge Changeset: 3fb32a5a2388 Author: katleman Date: 2012-12-27 12:14 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/3fb32a5a2388 Added tag jdk8-b70 for changeset 105a25ffa4a4 ! .hgtags Changeset: 51ad2a343420 Author: lana Date: 2012-12-28 18:31 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/51ad2a343420 Merge Changeset: b845a2494261 Author: lana Date: 2013-01-01 12:47 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/b845a2494261 Merge Changeset: 1129fb75f611 Author: jjg Date: 2013-01-10 19:36 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/1129fb75f611 8004834: Add doclint support into javadoc Reviewed-by: erikj, tbell ! common/makefiles/javadoc/Javadoc.gmk Changeset: c1be681d80a1 Author: katleman Date: 2013-01-03 12:44 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/c1be681d80a1 Added tag jdk8-b71 for changeset 51ad2a343420 ! .hgtags Changeset: f03f90a4308d Author: katleman Date: 2013-01-10 09:55 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/f03f90a4308d Added tag jdk8-b72 for changeset c1be681d80a1 ! .hgtags Changeset: 93b9664f97ee Author: lana Date: 2013-01-10 15:49 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/93b9664f97ee Merge Changeset: cecfba251e4a Author: lana Date: 2013-01-16 11:58 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/cecfba251e4a Merge Changeset: 4090847a5444 Author: katleman Date: 2013-01-16 11:59 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/4090847a5444 Added tag jdk8-b73 for changeset 93b9664f97ee ! .hgtags Changeset: 77f062a41850 Author: erikj Date: 2012-12-27 20:15 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/77f062a41850 8001942: build-infra: General permission problems on Windows/cygwin Summary: Added sanity check for file permissions in configure Reviewed-by: tbell, ohair ! common/autoconf/basics.m4 ! common/autoconf/generated-configure.sh Changeset: d2c1f80118de Author: erikj Date: 2012-12-27 20:18 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/d2c1f80118de 8005540: build-infra: Improve incremental build speed on windows by caching find results Reviewed-by: ohair ! common/makefiles/IdlCompilation.gmk ! common/makefiles/JavaCompilation.gmk ! common/makefiles/MakeBase.gmk ! common/makefiles/NativeCompilation.gmk Changeset: d5f3a6f60d51 Author: erikj Date: 2012-12-27 20:55 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/d5f3a6f60d51 8005548: build-infra: Fix docs target on windows Summary: Fix path sep variable Reviewed-by: tbell ! common/makefiles/javadoc/Javadoc.gmk Changeset: ef6adbf511cc Author: erikj Date: 2012-12-28 09:51 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/ef6adbf511cc 8005549: build-infra: Merge NewMakefile.gmk and common/makefiles/Makefile Reviewed-by: ohair, tbell ! NewMakefile.gmk ! common/autoconf/Makefile.in ! common/autoconf/generated-configure.sh + common/makefiles/Jprt.gmk ! common/makefiles/Main.gmk ! common/makefiles/MakeHelpers.gmk ! common/makefiles/Makefile Changeset: 2d9bb72b4e34 Author: erikj Date: 2012-12-30 12:15 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/2d9bb72b4e34 8004490: build-infra: mac: hotspot is always built in product, regardless of --with-debug-level setting Reviewed-by: tbell ! common/autoconf/generated-configure.sh ! common/autoconf/jdk-options.m4 Changeset: abc8078e070b Author: erikj Date: 2013-01-01 14:13 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/abc8078e070b 8001895: build-infra: Make JDK_BUILD_NUMBER and MILESTONE customizable Summary: Added configure params Reviewed-by: ohair ! common/autoconf/generated-configure.sh ! common/autoconf/jdk-options.m4 ! common/autoconf/spec.gmk.in ! common/autoconf/version.numbers Changeset: 14d7ebe42c8d Author: erikj Date: 2013-01-02 11:29 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/14d7ebe42c8d 8005347: build-infra: Verify 'gnumake source' at the top level works ok Reviewed-by: tbell, ohair, dholmes ! common/autoconf/basics.m4 - common/autoconf/closed.version.numbers ! common/autoconf/generated-configure.sh ! common/autoconf/jdk-options.m4 ! common/autoconf/spec.gmk.in = common/autoconf/version-numbers < common/autoconf/version.numbers Changeset: 348a881c6da0 Author: erikj Date: 2013-01-02 15:36 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/348a881c6da0 8005355: build-infra: Java security signing (need a top-level make target). Reviewed-by: tbell, ohair ! common/autoconf/spec.gmk.in ! common/makefiles/Main.gmk Changeset: befbad2e4d87 Author: erikj Date: 2013-01-03 20:54 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/befbad2e4d87 8005635: build-infra: Support building install in jprt Reviewed-by: ohair Contributed-by: tim.bell at oracle.com, erik.joelsson at oracle.com ! common/autoconf/generated-configure.sh ! common/autoconf/spec.gmk.in ! common/bin/compare.sh ! common/bin/compare_exceptions.sh.incl ! common/makefiles/Jprt.gmk ! common/src/fixpath.c Changeset: 39194e004ade Author: erikj Date: 2013-01-04 11:31 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/39194e004ade 8005575: build-infra: Three JCK tests fails on Solaris with new RE Autoconf-Based build Reviewed-by: ohair ! common/autoconf/compare.sh.in ! common/bin/compare.sh Changeset: 9263657c2756 Author: erikj Date: 2013-01-04 16:56 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/9263657c2756 8005692: build-infra: Target "all" should do the right thing Reviewed-by: tbell ! common/makefiles/Main.gmk Changeset: c874a8a27933 Author: erikj Date: 2013-01-04 17:05 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/c874a8a27933 8005597: build-infra: bridgeBuild broken for pure openjdk build Reviewed-by: tbell ! common/makefiles/Jprt.gmk Changeset: 7b9c42f14281 Author: erikj Date: 2013-01-04 17:08 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/7b9c42f14281 8005654: build-infra: Create sec-bin.zip Reviewed-by: tbell ! common/bin/compare.sh ! common/makefiles/JavaCompilation.gmk Changeset: 2597feac57c0 Author: erikj Date: 2013-01-04 22:43 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/2597feac57c0 8005723: build-infra: in new infra build, sec-windows-bin-zip and jgss-windows-*-bin.zip are missing Reviewed-by: tbell ! common/bin/compare.sh ! common/bin/compare_exceptions.sh.incl Changeset: 5cf7750c8c43 Author: ohair Date: 2013-01-04 21:04 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/5cf7750c8c43 8004229: build-infra: Umbrella for switch of default "make" to new makefiles Reviewed-by: erikj, tbell ! Makefile ! make/jprt.properties Changeset: 7a3c6ffdf1fb Author: tbell Date: 2013-01-07 14:01 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/7a3c6ffdf1fb 8005442: autogen.sh sets DATE_WHEN_GENERATED to empty string on Solaris version 11 or later Reviewed-by: ohair ! common/autoconf/autogen.sh Changeset: 64a9ebad39fe Author: katleman Date: 2013-01-08 13:14 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/64a9ebad39fe Merge - common/autoconf/closed.version.numbers - common/autoconf/version.numbers Changeset: b284980b7d9a Author: tbell Date: 2013-01-08 16:23 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/b284980b7d9a 8005794: in new infra, how do we change java -version? Summary: Added configure parameter --with-user-release-suffix Reviewed-by: ohair, tbell ! common/autoconf/generated-configure.sh ! common/autoconf/jdk-options.m4 Changeset: db3984e4eb97 Author: erikj Date: 2013-01-10 12:20 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/db3984e4eb97 8005858: build-infra: Add missed comparison of sec-windows-bin.zip and friends to compare.sh Reviewed-by: tbell, ohair ! common/bin/compare.sh Changeset: 6f8f7a5449f6 Author: erikj Date: 2013-01-11 10:46 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/6f8f7a5449f6 8005850: build-infra: Make --enable-openjdk-only really disable custom Reviewed-by: ohair, dholmes ! common/autoconf/configure.ac ! common/autoconf/generated-configure.sh ! common/autoconf/jdk-options.m4 Changeset: b66c81dfa291 Author: ohair Date: 2013-01-14 16:38 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/b66c81dfa291 8005284: build-infra: nonstandard copyright headers under common/autoconf/build-aux Reviewed-by: katleman ! common/autoconf/build-aux/autoconf-config.guess ! common/autoconf/build-aux/config.sub ! common/autoconf/build-aux/pkg.m4 Changeset: 3540aa40c868 Author: erikj Date: 2013-01-14 13:09 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/3540aa40c868 8006074: build-infra: Configure fails to find SetEnv.Cmd in microsoft sdk Reviewed-by: tbell, ohair ! common/autoconf/basics_windows.m4 ! common/autoconf/generated-configure.sh Changeset: 6e822b534678 Author: erikj Date: 2013-01-14 15:30 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/6e822b534678 8006100: build-infra: Bundle up the correct images in jprt Reviewed-by: tbell ! NewMakefile.gmk ! common/makefiles/Jprt.gmk Changeset: 52cce3326649 Author: erikj Date: 2013-01-15 09:50 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/52cce3326649 Merge Changeset: fe1c94aca5a8 Author: katleman Date: 2013-01-15 10:06 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/fe1c94aca5a8 Merge - common/autoconf/closed.version.numbers - common/autoconf/version.numbers Changeset: dc84b505b408 Author: katleman Date: 2013-01-16 22:16 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/dc84b505b408 Merge - common/autoconf/closed.version.numbers - common/autoconf/version.numbers ! common/bin/compare_exceptions.sh.incl Changeset: 2e12a508d7ae Author: lana Date: 2013-01-20 23:35 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/2e12a508d7ae Merge - common/autoconf/closed.version.numbers - common/autoconf/version.numbers ! common/makefiles/javadoc/Javadoc.gmk Changeset: 8209c91b751d Author: sherman Date: 2013-01-22 21:02 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/8209c91b751d 8003680: JSR 310 Date/Time API Summary: Integration of JSR310 Date/Time API for M6 Reviewed-by: alanb, naoto, dholmes Contributed-by: scolebourne at joda.org, roger.riggs at oracle.com, richard.warburton at gmail.com, misterm at gmail.com ! common/makefiles/javadoc/CORE_PKGS.gmk ! make/jprt.properties ! test/Makefile Changeset: 3dc55f0c1b6f Author: jlaskey Date: 2013-01-28 16:29 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/3dc55f0c1b6f 8006676: Integrate Nashorn into new build system Reviewed-by: jlaskey Contributed-by: james.laskey at oracle.com ! common/autoconf/generated-configure.sh ! common/autoconf/source-dirs.m4 ! common/autoconf/spec.gmk.in ! common/bin/compare.sh ! common/makefiles/Main.gmk ! common/makefiles/MakeBase.gmk + make/nashorn-rules.gmk ! make/scripts/hgforest.sh From james.laskey at oracle.com Mon Jan 28 18:02:10 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Mon, 28 Jan 2013 22:02:10 -0400 Subject: Building a JDK with nashorn embedded Message-ID: <59FC9F00-2354-4AE1-BB1F-8465EA01AD1F@oracle.com> The basic build system is in place to build nashorn with jdk8. This is not part of the jdk8 build per se. It merely builds the jdk with nashorn in it's final resting place. The remaining effort involves getting dynalink integrated with nashorn and pushing to the main repo. hg fclone http://hg.openjdk.java.net/nashorn/jdk8 nashorn~jdk8 cd nashorn~jdk8 (cd nashorn/make ; ant get-dynalink) sh ./configure make all NEWBUILD=true An sdk home can be found at ./build/macosx-x86_64-normal-server-release/images/j2sdk-bundle/jdk1.8.0.jdk/Contents/Home so you could export JAVA_HOME=./build/macosx-x86_64-normal-server-release/images/j2sdk-bundle/jdk1.8.0.jdk/Contents/Home or setenv JAVA_HOME ./build/macosx-x86_64-normal-server-release/images/j2sdk-bundle/jdk1.8.0.jdk/Contents/Home and then $JAVA_HOME/bin/jjs or use this jdk with the script manager. Cheers, -- Jim From marcus.lagergren at oracle.com Tue Jan 29 00:06:47 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Tue, 29 Jan 2013 09:06:47 +0100 Subject: Please review http://cr.openjdk.java.net/~lagergren/8007062 - Lower refactoring Message-ID: <589071C1-D59B-43E4-8420-F1158D80E276@oracle.com> Soliciting code reviews for CR8007062. Finally this gruelling work is nearing its end, and forms a basis for execution architecture and type specialisation changes that are next on my agenda. Webrev is @ http://cr.openjdk.java.net/~lagergren/8007062 https://jbs.oracle.com/bugs/browse/JDK-8007062 - "Lower should be separated into at least Attr and Lower" Lower suffered from being a "God class" trying to do everything at once. As Nashorn code generation has grown, so has Lower. It does several post processing passes, tries to do several things at once even though all type information isn't in place, adjusting state afterwards and so on. It also performs control flow analysis, type attribution and constant folding, and everything else code generation related before byte code emission. I have now separated the compilation process into Lower (create low level nodes from high level ones, copy code such as finally block inlining etc), Attr (assign types and symbols to all nodes - freeze slot and scope information) and FinalizeTypes (insert explicit casts, specialize invoke dynamic types for scope accesses). I've removed the kludgy AccessSpecializer, as this now integrates naturally with typing. Everything is now much easier to read and each module performs only one thing. I have added separate loggers for the separate tiers. In the process I have also fixed * problems with type coercion (see test/script/basic/typecoercion.js, basically our coercion was too late and our symbol inference was erroneous. This only manifested itself in very rare occasions where toNumber coercion has side effects, such as for example when valueOf is overridden) * copying literal nodes (literal copy did not use the superclass copy, which made all the Node specific fields not to be copied) * erroneous literal tokenization (literals shouldn't always just inherit token information from whatever node that creates them) * splitter weighnodes - unary nodes were considered weightless * removed the hateful and kludgy "VarNode.shouldAppend", which really isn't needed when we have an attribution phase that determines self reference symbols (the only thing it was used for) * duplicate line number issues in the parser * convert bug in CodeGenerator for intermediate results of scope accesses (see test/script/basic/access-specializer.js) Several of these things just stopped being problems with the new architecture "can't happen anymore" and are not bug fixes per se. All tests run. No performance regressions exist that I've been able to measure. Some increases in performance were measured, but in the statistical margin of error (which is very wide as HotSpot currently has warmup issues with LambdaForms/invoke dynamic). Compile speed has not measurably increased. I get intermediate errors with test262parallel (NativeNumber wrapFilter gets wrong type and throws ClassCastException), but these reproduce exactly as with tip as well, and I have filed it as https://jbs.oracle.com/bugs/browse/JDK-8007060 Regards Marcus From marcus.lagergren at oracle.com Tue Jan 29 00:19:09 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Tue, 29 Jan 2013 09:19:09 +0100 Subject: Review request for JDK-8006950 In-Reply-To: <5106F13C.9060009@oracle.com> References: <5106F13C.9060009@oracle.com> Message-ID: +1 On Jan 28, 2013, at 10:44 PM, Hannes Wallnoefer wrote: > Please review webrev for JDK-8006950: http://cr.openjdk.java.net/~hannesw/8006950/ > > The gist of this is that we can omit calling ScriptObject.setProto() in constructors of Nasgen-processed classes if we know the prototype has been set correctly in the object's $nasgenmap$ field. This is because Nasgen inserts $nasgenmap$ to all calls to zero-arg ScriptObject super-constructor. Also, prototype properties of native ES constructors are non-writable and non-configurable. > > The patch contains an incomplete array microbenchmark (only array creation covered so far), most of which now is roughly 3x faster. > > Hannes From sundararajan.athijegannathan at oracle.com Tue Jan 29 02:43:28 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Tue, 29 Jan 2013 16:13:28 +0530 Subject: Review request for JDK-8006950 In-Reply-To: <5106F13C.9060009@oracle.com> References: <5106F13C.9060009@oracle.com> Message-ID: <5107A7D0.9090509@oracle.com> While properties of prototypes are non-writable, non-configurable, I think this one is still not correct. There may be more than global instances per context instance- and this is exposed via jsr-223 API as well. With two different global instances created per engine, code may check "String.prototype instanceof Object" in both global scopes. Since "Object" is different for different global scope, I think this check will fail for one of the global scopes.. A solution could be to use these maps from global instance and fetch global instance via Global.instance() method -Sundar On Tuesday 29 January 2013 03:14 AM, Hannes Wallnoefer wrote: > Please review webrev for JDK-8006950: > http://cr.openjdk.java.net/~hannesw/8006950/ > > The gist of this is that we can omit calling ScriptObject.setProto() > in constructors of Nasgen-processed classes if we know the prototype > has been set correctly in the object's $nasgenmap$ field. This is > because Nasgen inserts $nasgenmap$ to all calls to zero-arg > ScriptObject super-constructor. Also, prototype properties of native > ES constructors are non-writable and non-configurable. > > The patch contains an incomplete array microbenchmark (only array > creation covered so far), most of which now is roughly 3x faster. > > Hannes From sundararajan.athijegannathan at oracle.com Tue Jan 29 06:03:23 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Tue, 29 Jan 2013 19:33:23 +0530 Subject: Review request JDK-8007091: Provide private API to pass application class loader for nashorn script engine Message-ID: <5107D6AB.6070206@oracle.com> Hi, Please review http://cr.openjdk.java.net/~sundar/8007091/ Thanks -Sundar From james.laskey at oracle.com Tue Jan 29 06:19:11 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Tue, 29 Jan 2013 10:19:11 -0400 Subject: Please review http://cr.openjdk.java.net/~lagergren/8007062 - Lower refactoring In-Reply-To: <589071C1-D59B-43E4-8420-F1158D80E276@oracle.com> References: <589071C1-D59B-43E4-8420-F1158D80E276@oracle.com> Message-ID: CodeGenerator.java 534 final Map thisProperties = functionNode.getThisProperties(); 535 Comment out instead of delete or remove the dependent TODO. FunctionNode.java 164 /** Has this node been split because it was too large? */ 165 private static final int IS_SPLIT = 0b0000_0000_0100_0000; 166 /** Is this function lazily compiled? */ 167 private static final int IS_LAZY = 0b0000_0000_0100_0000; Have the same value. Even if mutually exclusive, should have distinct values - lots of bits around. Would prefer if this had been broken down into smaller change sets. Makes it hard to review. Otherwise. +1 On 2013-01-29, at 4:06 AM, Marcus Lagergren wrote: > Soliciting code reviews for CR8007062. Finally this gruelling work is nearing its end, and forms a basis for execution architecture and type specialisation changes that are next on my agenda. > > Webrev is @ http://cr.openjdk.java.net/~lagergren/8007062 > > https://jbs.oracle.com/bugs/browse/JDK-8007062 - "Lower should be separated into at least Attr and Lower" > > Lower suffered from being a "God class" trying to do everything at once. As Nashorn code generation has grown, so has Lower. It does several post processing passes, tries to do several things at once even though all type information isn't in place, adjusting state afterwards and so on. It also performs control flow analysis, type attribution and constant folding, and everything else code generation related before byte code emission. > > I have now separated the compilation process into Lower (create low level nodes from high level ones, copy code such as finally block inlining etc), Attr (assign types and symbols to all nodes - freeze slot and scope information) and FinalizeTypes (insert explicit casts, specialize invoke dynamic types for scope accesses). I've removed the kludgy AccessSpecializer, as this now integrates naturally with typing. Everything is now much easier to read and each module performs only one thing. I have added separate loggers for the separate tiers. > > In the process I have also fixed > > * problems with type coercion (see test/script/basic/typecoercion.js, basically our coercion was too late and our symbol inference was erroneous. This only manifested itself in very rare occasions where toNumber coercion has side effects, such as for example when valueOf is overridden) > * copying literal nodes (literal copy did not use the superclass copy, which made all the Node specific fields not to be copied) > * erroneous literal tokenization (literals shouldn't always just inherit token information from whatever node that creates them) > * splitter weighnodes - unary nodes were considered weightless > * removed the hateful and kludgy "VarNode.shouldAppend", which really isn't needed when we have an attribution phase that determines self reference symbols (the only thing it was used for) > * duplicate line number issues in the parser > * convert bug in CodeGenerator for intermediate results of scope accesses (see test/script/basic/access-specializer.js) > > Several of these things just stopped being problems with the new architecture "can't happen anymore" and are not bug fixes per se. > > All tests run. No performance regressions exist that I've been able to measure. Some increases in performance were measured, but in the statistical margin of error (which is very wide as HotSpot currently has warmup issues with LambdaForms/invoke dynamic). Compile speed has not measurably increased. I get intermediate errors with test262parallel (NativeNumber wrapFilter gets wrong type and throws ClassCastException), but these reproduce exactly as with tip as well, and I have filed it as https://jbs.oracle.com/bugs/browse/JDK-8007060 > > Regards > Marcus From james.laskey at oracle.com Tue Jan 29 06:20:34 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Tue, 29 Jan 2013 10:20:34 -0400 Subject: Review request JDK-8007091: Provide private API to pass application class loader for nashorn script engine In-Reply-To: <5107D6AB.6070206@oracle.com> References: <5107D6AB.6070206@oracle.com> Message-ID: <436D2BC7-3025-4E92-A840-D5D04FB52670@oracle.com> +1 On 2013-01-29, at 10:03 AM, "A. Sundararajan" wrote: > Hi, > > Please review http://cr.openjdk.java.net/~sundar/8007091/ > > Thanks > -Sundar From marcus.lagergren at oracle.com Tue Jan 29 06:26:13 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Tue, 29 Jan 2013 15:26:13 +0100 Subject: Please review http://cr.openjdk.java.net/~lagergren/8007062 - Lower refactoring In-Reply-To: References: <589071C1-D59B-43E4-8420-F1158D80E276@oracle.com> Message-ID: See webrev.01 - all traces of thisProperties have been removed. I will fix the LAZY flag. It is a merge artifact from Attila's latest change. It is currently not in use, so everything has worked. /M On Jan 29, 2013, at 3:19 PM, Jim Laskey (Oracle) wrote: > CodeGenerator.java > > 534 final Map thisProperties = functionNode.getThisProperties(); > 535 > > Comment out instead of delete or remove the dependent TODO. > > > FunctionNode.java > > 164 /** Has this node been split because it was too large? */ > 165 private static final int IS_SPLIT = 0b0000_0000_0100_0000; > 166 /** Is this function lazily compiled? */ > 167 private static final int IS_LAZY = 0b0000_0000_0100_0000; > > Have the same value. Even if mutually exclusive, should have distinct values - lots of bits around. > > > Would prefer if this had been broken down into smaller change sets. Makes it hard to review. Otherwise. +1 > > > On 2013-01-29, at 4:06 AM, Marcus Lagergren wrote: > >> Soliciting code reviews for CR8007062. Finally this gruelling work is nearing its end, and forms a basis for execution architecture and type specialisation changes that are next on my agenda. >> >> Webrev is @ http://cr.openjdk.java.net/~lagergren/8007062 >> >> https://jbs.oracle.com/bugs/browse/JDK-8007062 - "Lower should be separated into at least Attr and Lower" >> >> Lower suffered from being a "God class" trying to do everything at once. As Nashorn code generation has grown, so has Lower. It does several post processing passes, tries to do several things at once even though all type information isn't in place, adjusting state afterwards and so on. It also performs control flow analysis, type attribution and constant folding, and everything else code generation related before byte code emission. >> >> I have now separated the compilation process into Lower (create low level nodes from high level ones, copy code such as finally block inlining etc), Attr (assign types and symbols to all nodes - freeze slot and scope information) and FinalizeTypes (insert explicit casts, specialize invoke dynamic types for scope accesses). I've removed the kludgy AccessSpecializer, as this now integrates naturally with typing. Everything is now much easier to read and each module performs only one thing. I have added separate loggers for the separate tiers. >> >> In the process I have also fixed >> >> * problems with type coercion (see test/script/basic/typecoercion.js, basically our coercion was too late and our symbol inference was erroneous. This only manifested itself in very rare occasions where toNumber coercion has side effects, such as for example when valueOf is overridden) >> * copying literal nodes (literal copy did not use the superclass copy, which made all the Node specific fields not to be copied) >> * erroneous literal tokenization (literals shouldn't always just inherit token information from whatever node that creates them) >> * splitter weighnodes - unary nodes were considered weightless >> * removed the hateful and kludgy "VarNode.shouldAppend", which really isn't needed when we have an attribution phase that determines self reference symbols (the only thing it was used for) >> * duplicate line number issues in the parser >> * convert bug in CodeGenerator for intermediate results of scope accesses (see test/script/basic/access-specializer.js) >> >> Several of these things just stopped being problems with the new architecture "can't happen anymore" and are not bug fixes per se. >> >> All tests run. No performance regressions exist that I've been able to measure. Some increases in performance were measured, but in the statistical margin of error (which is very wide as HotSpot currently has warmup issues with LambdaForms/invoke dynamic). Compile speed has not measurably increased. I get intermediate errors with test262parallel (NativeNumber wrapFilter gets wrong type and throws ClassCastException), but these reproduce exactly as with tip as well, and I have filed it as https://jbs.oracle.com/bugs/browse/JDK-8007060 >> >> Regards >> Marcus > From marcus.lagergren at oracle.com Tue Jan 29 06:27:12 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Tue, 29 Jan 2013 15:27:12 +0100 Subject: Review request JDK-8007091: Provide private API to pass application class loader for nashorn script engine In-Reply-To: <5107D6AB.6070206@oracle.com> References: <5107D6AB.6070206@oracle.com> Message-ID: <9BBF8A37-FD55-4005-8988-78725BCAA9B0@oracle.com> +1 On Jan 29, 2013, at 3:03 PM, A. Sundararajan wrote: > Hi, > > Please review http://cr.openjdk.java.net/~sundar/8007091/ > > Thanks > -Sundar From sundararajan.athijegannathan at oracle.com Tue Jan 29 06:27:49 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Tue, 29 Jan 2013 14:27:49 +0000 Subject: hg: nashorn/jdk8/nashorn: 8007091: Provide private API to pass application class loader for nashorn script engine Message-ID: <20130129142750.C15FD47647@hg.openjdk.java.net> Changeset: 333748665588 Author: sundar Date: 2013-01-29 19:57 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/333748665588 8007091: Provide private API to pass application class loader for nashorn script engine Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/api/scripting/NashornScriptEngineFactory.java ! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java From james.laskey at oracle.com Tue Jan 29 10:28:31 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Tue, 29 Jan 2013 18:28:31 +0000 Subject: hg: nashorn/jdk8/nashorn: 8007094: Apply version to nashorn.jar manifest Message-ID: <20130129182832.953B647658@hg.openjdk.java.net> Changeset: 755404d7d189 Author: jlaskey Date: 2013-01-29 14:25 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/755404d7d189 8007094: Apply version to nashorn.jar manifest Reviewed-by: sundar Contributed-by: james.laskey at oracle.com ! makefiles/BuildNashorn.gmk From hannes.wallnoefer at oracle.com Wed Jan 30 01:18:43 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Wed, 30 Jan 2013 10:18:43 +0100 Subject: Review request for JDK-8007109 Message-ID: <5108E573.5060602@oracle.com> Please review http://cr.openjdk.java.net/~hannesw/8007109/ This fixes a regression in Node.jar and adds tests for methods that should always convert ConsString to java.lang.String. thanks, Hannes From sundararajan.athijegannathan at oracle.com Wed Jan 30 01:42:57 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Wed, 30 Jan 2013 15:12:57 +0530 Subject: Review request JDK-8007132: Java objects returned from constructor functions are lost Message-ID: <5108EB21.7050201@oracle.com> Hi, Please review http://cr.openjdk.java.net/~sundar/8007132/ Thanks -Sundar From hannes.wallnoefer at oracle.com Wed Jan 30 02:02:51 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Wed, 30 Jan 2013 11:02:51 +0100 Subject: Review request JDK-8007132: Java objects returned from constructor functions are lost In-Reply-To: <5108EB21.7050201@oracle.com> References: <5108EB21.7050201@oracle.com> Message-ID: <5108EFCB.6010000@oracle.com> Looks good. You have some added whitespace there. Maybe add a test for using a function returning a primitive as constructor? I guess it should be covered by test262, but you never know. Hannes Am 2013-01-30 10:42, schrieb A. Sundararajan: > Hi, > > Please review http://cr.openjdk.java.net/~sundar/8007132/ > > Thanks > -Sundar From attila.szegedi at oracle.com Wed Jan 30 02:33:13 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Wed, 30 Jan 2013 11:33:13 +0100 Subject: Please review http://cr.openjdk.java.net/~lagergren/8007062 - Lower refactoring In-Reply-To: <589071C1-D59B-43E4-8420-F1158D80E276@oracle.com> References: <589071C1-D59B-43E4-8420-F1158D80E276@oracle.com> Message-ID: <90DBA5CF-6714-49F8-8BBF-0E6D5B1B43AF@oracle.com> +1 from me; Marcus walked me through the code and we talked it through. All looks good. On Jan 29, 2013, at 9:06 AM, Marcus Lagergren wrote: > Soliciting code reviews for CR8007062. Finally this gruelling work is nearing its end, and forms a basis for execution architecture and type specialisation changes that are next on my agenda. > > Webrev is @ http://cr.openjdk.java.net/~lagergren/8007062 > > https://jbs.oracle.com/bugs/browse/JDK-8007062 - "Lower should be separated into at least Attr and Lower" > > Lower suffered from being a "God class" trying to do everything at once. As Nashorn code generation has grown, so has Lower. It does several post processing passes, tries to do several things at once even though all type information isn't in place, adjusting state afterwards and so on. It also performs control flow analysis, type attribution and constant folding, and everything else code generation related before byte code emission. > > I have now separated the compilation process into Lower (create low level nodes from high level ones, copy code such as finally block inlining etc), Attr (assign types and symbols to all nodes - freeze slot and scope information) and FinalizeTypes (insert explicit casts, specialize invoke dynamic types for scope accesses). I've removed the kludgy AccessSpecializer, as this now integrates naturally with typing. Everything is now much easier to read and each module performs only one thing. I have added separate loggers for the separate tiers. > > In the process I have also fixed > > * problems with type coercion (see test/script/basic/typecoercion.js, basically our coercion was too late and our symbol inference was erroneous. This only manifested itself in very rare occasions where toNumber coercion has side effects, such as for example when valueOf is overridden) > * copying literal nodes (literal copy did not use the superclass copy, which made all the Node specific fields not to be copied) > * erroneous literal tokenization (literals shouldn't always just inherit token information from whatever node that creates them) > * splitter weighnodes - unary nodes were considered weightless > * removed the hateful and kludgy "VarNode.shouldAppend", which really isn't needed when we have an attribution phase that determines self reference symbols (the only thing it was used for) > * duplicate line number issues in the parser > * convert bug in CodeGenerator for intermediate results of scope accesses (see test/script/basic/access-specializer.js) > > Several of these things just stopped being problems with the new architecture "can't happen anymore" and are not bug fixes per se. > > All tests run. No performance regressions exist that I've been able to measure. Some increases in performance were measured, but in the statistical margin of error (which is very wide as HotSpot currently has warmup issues with LambdaForms/invoke dynamic). Compile speed has not measurably increased. I get intermediate errors with test262parallel (NativeNumber wrapFilter gets wrong type and throws ClassCastException), but these reproduce exactly as with tip as well, and I have filed it as https://jbs.oracle.com/bugs/browse/JDK-8007060 > > Regards > Marcus From sundararajan.athijegannathan at oracle.com Wed Jan 30 03:23:38 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Wed, 30 Jan 2013 16:53:38 +0530 Subject: Review request JDK-8007132: Java objects returned from constructor functions are lost In-Reply-To: <5108EFCB.6010000@oracle.com> References: <5108EB21.7050201@oracle.com> <5108EFCB.6010000@oracle.com> Message-ID: <510902BA.5090009@oracle.com> Hi, Please review updated webrev @ http://cr.openjdk.java.net/~sundar/8007132/webrev.01/ Thanks -Sundar On Wednesday 30 January 2013 03:32 PM, Hannes Wallnoefer wrote: > Looks good. You have some added whitespace there. > > Maybe add a test for using a function returning a primitive as > constructor? I guess it should be covered by test262, but you never know. > > Hannes > > Am 2013-01-30 10:42, schrieb A. Sundararajan: >> Hi, >> >> Please review http://cr.openjdk.java.net/~sundar/8007132/ >> >> Thanks >> -Sundar > From marcus.lagergren at oracle.com Wed Jan 30 03:31:18 2013 From: marcus.lagergren at oracle.com (marcus.lagergren at oracle.com) Date: Wed, 30 Jan 2013 11:31:18 +0000 Subject: hg: nashorn/jdk8/nashorn: 8007062: Split Lower up into Lower/Attr/FinalizeTypes. Integrate AccessSpecalizer into FinalizeTypes. Message-ID: <20130130113120.21D5F4769B@hg.openjdk.java.net> Changeset: 59970b70ebb5 Author: lagergren Date: 2013-01-30 12:26 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/59970b70ebb5 8007062: Split Lower up into Lower/Attr/FinalizeTypes. Integrate AccessSpecalizer into FinalizeTypes. Summary: Lower suffered from being a "God class" trying to do everything at once. As Nashorn code generation has grown, so has Lower. It does several post processing passes, tries to do several things at once even though all type information isn't in place, adjusting state afterwards and so on. It also performs control flow analysis, type attribution and constant folding, and everything else code generation related before byte code emission. I have now separated the compilation process into Lower (create low level nodes from high level ones, copy code such as finally block inlining etc), Attr (assign types and symbols to all nodes - freeze slot and scope information) and FinalizeTypes (insert explicit casts, specialize invoke dynamic types for scope accesses). I've removed the kludgy AccessSpecializer, as this now integrates naturally with typing. Everything is now much easier to read and each module performs only one thing. I have added separate loggers for the separate ti ers. In the process I have also fixed: (1) problems with type coercion (see test/script/basic/typecoercion.js, basically our coercion was too late and our symbol inference was erroneous. This only manifested itself in very rare occasions where toNumber coercion has side effects, such as for example when valueOf is overridden) (2) copying literal nodes (literal copy did not use the superclass copy, which made all the Node specific fields not to be copied (3) erroneous literal tokenization (literals shouldn't always just inherit token information from whatever node that creates them) (4) splitter weighnodes - unary nodes were considered weightless (4) removed the hateful and kludgy "VarNode.shouldAppend", which really isn't needed when we have an attribution phase that determines self reference symbols (the only thing it was used for) (5) duplicate line number issues in the parser (6) convert bug in CodeGenerator for intermediate results of scope accesses (see test/script/b asic/access-specializer.js) ... Several of these things just stopped being problems with the new architecture "can't happen anymore" and are not bug fixes per se. All tests run. No performance regressions exist that I've been able to measure. Some increases in performance were measured, but in the statistical margin of error (which is very wide as HotSpot currently has warmup issues with LambdaForms/invoke dynamic). Compile speed has not measurably increased. Reviewed-by: jlaskey, attila ! docs/DEVELOPER_README ! src/jdk/nashorn/api/scripting/Formatter.java ! src/jdk/nashorn/api/scripting/NashornScriptEngine.java - src/jdk/nashorn/internal/codegen/AccessSpecializer.java + src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/Compiler.java + src/jdk/nashorn/internal/codegen/FinalizeTypes.java + src/jdk/nashorn/internal/codegen/FoldConstants.java ! src/jdk/nashorn/internal/codegen/Lower.java ! src/jdk/nashorn/internal/codegen/MethodEmitter.java ! src/jdk/nashorn/internal/codegen/SharedScopeCall.java ! src/jdk/nashorn/internal/codegen/WeighNodes.java ! src/jdk/nashorn/internal/codegen/objects/FunctionObjectCreator.java ! src/jdk/nashorn/internal/ir/Block.java ! src/jdk/nashorn/internal/ir/CallNode.java ! src/jdk/nashorn/internal/ir/CatchNode.java ! src/jdk/nashorn/internal/ir/ExecuteNode.java ! src/jdk/nashorn/internal/ir/FunctionNode.java ! src/jdk/nashorn/internal/ir/LiteralNode.java ! src/jdk/nashorn/internal/ir/Node.java ! src/jdk/nashorn/internal/ir/RuntimeNode.java ! src/jdk/nashorn/internal/ir/Symbol.java ! src/jdk/nashorn/internal/ir/TryNode.java ! src/jdk/nashorn/internal/ir/VarNode.java ! src/jdk/nashorn/internal/ir/debug/ASTWriter.java ! src/jdk/nashorn/internal/objects/NativeJSON.java ! src/jdk/nashorn/internal/objects/NativeString.java ! src/jdk/nashorn/internal/parser/AbstractParser.java ! src/jdk/nashorn/internal/parser/Parser.java ! src/jdk/nashorn/internal/parser/TokenType.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/DebugLogger.java ! src/jdk/nashorn/internal/runtime/OptionsObject.java ! src/jdk/nashorn/internal/runtime/PropertyMap.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/ScriptingFunctions.java ! src/jdk/nashorn/internal/runtime/arrays/ArrayIterator.java ! src/jdk/nashorn/internal/runtime/arrays/ArrayLikeIterator.java ! src/jdk/nashorn/internal/runtime/arrays/FrozenArrayFilter.java ! src/jdk/nashorn/internal/runtime/arrays/SealedArrayFilter.java ! src/jdk/nashorn/internal/runtime/linker/LinkerCallSite.java ! src/jdk/nashorn/internal/runtime/options/Options.java ! src/jdk/nashorn/tools/Shell.java + test/script/basic/access-specializer.js ! test/script/basic/compile-octane.js.EXPECTED ! test/script/basic/run-octane.js + test/script/basic/typecoerce.js + test/script/basic/typecoerce.js.EXPECTED From marcus.lagergren at oracle.com Wed Jan 30 03:41:50 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Wed, 30 Jan 2013 12:41:50 +0100 Subject: Review request JDK-8007132: Java objects returned from constructor functions are lost In-Reply-To: <510902BA.5090009@oracle.com> References: <5108EB21.7050201@oracle.com> <5108EFCB.6010000@oracle.com> <510902BA.5090009@oracle.com> Message-ID: +1 On Jan 30, 2013, at 12:23 PM, A. Sundararajan wrote: > Hi, > > Please review updated webrev @ http://cr.openjdk.java.net/~sundar/8007132/webrev.01/ > > Thanks > -Sundar > > On Wednesday 30 January 2013 03:32 PM, Hannes Wallnoefer wrote: >> Looks good. You have some added whitespace there. >> >> Maybe add a test for using a function returning a primitive as constructor? I guess it should be covered by test262, but you never know. >> >> Hannes >> >> Am 2013-01-30 10:42, schrieb A. Sundararajan: >>> Hi, >>> >>> Please review http://cr.openjdk.java.net/~sundar/8007132/ >>> >>> Thanks >>> -Sundar >> > From attila.szegedi at oracle.com Wed Jan 30 03:40:26 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Wed, 30 Jan 2013 12:40:26 +0100 Subject: Review request JDK-8007132: Java objects returned from constructor functions are lost In-Reply-To: <510902BA.5090009@oracle.com> References: <5108EB21.7050201@oracle.com> <5108EFCB.6010000@oracle.com> <510902BA.5090009@oracle.com> Message-ID: +1 On Jan 30, 2013, at 12:23 PM, "A. Sundararajan" wrote: > Hi, > > Please review updated webrev @ http://cr.openjdk.java.net/~sundar/8007132/webrev.01/ > > Thanks > -Sundar > > On Wednesday 30 January 2013 03:32 PM, Hannes Wallnoefer wrote: >> Looks good. You have some added whitespace there. >> >> Maybe add a test for using a function returning a primitive as constructor? I guess it should be covered by test262, but you never know. >> >> Hannes >> >> Am 2013-01-30 10:42, schrieb A. Sundararajan: >>> Hi, >>> >>> Please review http://cr.openjdk.java.net/~sundar/8007132/ >>> >>> Thanks >>> -Sundar >> > From marcus.lagergren at oracle.com Wed Jan 30 04:14:40 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Wed, 30 Jan 2013 13:14:40 +0100 Subject: Review request for JDK-8007109 In-Reply-To: <5108E573.5060602@oracle.com> References: <5108E573.5060602@oracle.com> Message-ID: <77E9FB25-570D-4E2B-AF34-8ED4C58E7EF2@oracle.com> +1 On Jan 30, 2013, at 10:18 AM, Hannes Wallnoefer wrote: > Please review http://cr.openjdk.java.net/~hannesw/8007109/ > > This fixes a regression in Node.jar and adds tests for methods that should always convert ConsString to java.lang.String. > > thanks, > > Hannes From sundararajan.athijegannathan at oracle.com Wed Jan 30 04:23:18 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Wed, 30 Jan 2013 12:23:18 +0000 Subject: hg: nashorn/jdk8/nashorn: 8007132: Java objects returned from constructor functions are lost Message-ID: <20130130122319.31AE94769C@hg.openjdk.java.net> Changeset: ca6d5e4b8170 Author: sundar Date: 2013-01-30 17:52 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/ca6d5e4b8170 8007132: Java objects returned from constructor functions are lost Reviewed-by: hannesw, lagergren, attila ! src/jdk/nashorn/internal/runtime/ScriptFunction.java + test/script/basic/JDK-8007132.js From hannes.wallnoefer at oracle.com Wed Jan 30 05:20:37 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Wed, 30 Jan 2013 14:20:37 +0100 Subject: Review request for JDK-8007060 Message-ID: <51091E25.5070200@oracle.com> Please review http://cr.openjdk.java.net/~hannesw/8007060/ This removes the NashornInvocationTarget class whose purpose was to track primitiveness of callsite targets and replaces it in two ways. 1) For functions invoked via ScriptRuntime.apply() (this includes ordinary megamorphic callsites) we simply check function strictness and this-argument primitiveness at runtime. We should have done that anyway, I think there were several uses of this method that forgot to wrap primitives when they should have. 2) For ordinary monomorphic callsites we check function strictness and this-argument primitiveness at link time. If this is primitive we install a wrapper methodhandle as argument filter. We then use a new NonStrictFunctionGuard that in addition to the FunctionGuard check tests whether primitiveness of this-argument has changed by doing one simple instanceof check. (This should be very rare, as invocation of script functions on JS primitives should generally be rare. I've tested this with test, test262parallel, and octane. Haven't tested node.jar yet. Haven't done any in-depth performance tests but I think there should be no notable regression. thanks, Hannes From hannes.wallnoefer at oracle.com Wed Jan 30 05:58:43 2013 From: hannes.wallnoefer at oracle.com (hannes.wallnoefer at oracle.com) Date: Wed, 30 Jan 2013 13:58:43 +0000 Subject: hg: nashorn/jdk8/nashorn: 8007109: Regression: String(ConsString) does not flatten argument to String Message-ID: <20130130135844.373654769F@hg.openjdk.java.net> Changeset: 9f913c1843c8 Author: hannesw Date: 2013-01-30 14:57 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/9f913c1843c8 8007109: Regression: String(ConsString) does not flatten argument to String Reviewed-by: sundar, lagergren ! src/jdk/nashorn/internal/objects/NativeString.java + test/script/basic/consstring.js + test/src/jdk/nashorn/internal/test/models/StringArgs.java From sundararajan.athijegannathan at oracle.com Wed Jan 30 06:00:40 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Wed, 30 Jan 2013 19:30:40 +0530 Subject: Review request for JDK-8007060 In-Reply-To: <51091E25.5070200@oracle.com> References: <51091E25.5070200@oracle.com> Message-ID: <51092788.3010201@oracle.com> +1 -Sundar On Wednesday 30 January 2013 06:50 PM, Hannes Wallnoefer wrote: > Please review http://cr.openjdk.java.net/~hannesw/8007060/ > > This removes the NashornInvocationTarget class whose purpose was to > track primitiveness of callsite targets and replaces it in two ways. > > 1) For functions invoked via ScriptRuntime.apply() (this includes > ordinary megamorphic callsites) we simply check function strictness > and this-argument primitiveness at runtime. We should have done that > anyway, I think there were several uses of this method that forgot to > wrap primitives when they should have. > > 2) For ordinary monomorphic callsites we check function strictness and > this-argument primitiveness at link time. If this is primitive we > install a wrapper methodhandle as argument filter. We then use a new > NonStrictFunctionGuard that in addition to the FunctionGuard check > tests whether primitiveness of this-argument has changed by doing one > simple instanceof check. (This should be very rare, as invocation of > script functions on JS primitives should generally be rare. > > I've tested this with test, test262parallel, and octane. Haven't > tested node.jar yet. Haven't done any in-depth performance tests but I > think there should be no notable regression. > > thanks, > Hannes From james.laskey at oracle.com Wed Jan 30 06:02:30 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Wed, 30 Jan 2013 10:02:30 -0400 Subject: Review request for JDK-8007060 In-Reply-To: <51091E25.5070200@oracle.com> References: <51091E25.5070200@oracle.com> Message-ID: +1 On 2013-01-30, at 9:20 AM, Hannes Wallnoefer wrote: > Please review http://cr.openjdk.java.net/~hannesw/8007060/ > > This removes the NashornInvocationTarget class whose purpose was to track primitiveness of callsite targets and replaces it in two ways. > > 1) For functions invoked via ScriptRuntime.apply() (this includes ordinary megamorphic callsites) we simply check function strictness and this-argument primitiveness at runtime. We should have done that anyway, I think there were several uses of this method that forgot to wrap primitives when they should have. > > 2) For ordinary monomorphic callsites we check function strictness and this-argument primitiveness at link time. If this is primitive we install a wrapper methodhandle as argument filter. We then use a new NonStrictFunctionGuard that in addition to the FunctionGuard check tests whether primitiveness of this-argument has changed by doing one simple instanceof check. (This should be very rare, as invocation of script functions on JS primitives should generally be rare. > > I've tested this with test, test262parallel, and octane. Haven't tested node.jar yet. Haven't done any in-depth performance tests but I think there should be no notable regression. > > thanks, > Hannes From sundararajan.athijegannathan at oracle.com Wed Jan 30 06:51:13 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Wed, 30 Jan 2013 20:21:13 +0530 Subject: Please review JDK-8007140: Java.extend crashes when attempting to extend java.lang.Object Message-ID: <51093361.9000802@oracle.com> Hi, Please review http://cr.openjdk.java.net/~sundar/8007140/ Thanks -Sundar From james.laskey at oracle.com Wed Jan 30 07:02:40 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Wed, 30 Jan 2013 11:02:40 -0400 Subject: Please review JDK-8007140: Java.extend crashes when attempting to extend java.lang.Object In-Reply-To: <51093361.9000802@oracle.com> References: <51093361.9000802@oracle.com> Message-ID: <64FCCC0D-3582-49A9-92F0-E9DC102282FE@oracle.com> +1 On 2013-01-30, at 10:51 AM, "A. Sundararajan" wrote: > Hi, > > Please review http://cr.openjdk.java.net/~sundar/8007140/ > > Thanks > -Sundar From marcus.lagergren at oracle.com Wed Jan 30 07:29:44 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Wed, 30 Jan 2013 16:29:44 +0100 Subject: Review request for JDK-8007060 In-Reply-To: <51091E25.5070200@oracle.com> References: <51091E25.5070200@oracle.com> Message-ID: <1AD7B13A-15FD-4CE5-B1B3-22160EDDE00A@oracle.com> +1. Very elegant. On Jan 30, 2013, at 2:20 PM, Hannes Wallnoefer wrote: > Please review http://cr.openjdk.java.net/~hannesw/8007060/ > > This removes the NashornInvocationTarget class whose purpose was to track primitiveness of callsite targets and replaces it in two ways. > > 1) For functions invoked via ScriptRuntime.apply() (this includes ordinary megamorphic callsites) we simply check function strictness and this-argument primitiveness at runtime. We should have done that anyway, I think there were several uses of this method that forgot to wrap primitives when they should have. > > 2) For ordinary monomorphic callsites we check function strictness and this-argument primitiveness at link time. If this is primitive we install a wrapper methodhandle as argument filter. We then use a new NonStrictFunctionGuard that in addition to the FunctionGuard check tests whether primitiveness of this-argument has changed by doing one simple instanceof check. (This should be very rare, as invocation of script functions on JS primitives should generally be rare. > > I've tested this with test, test262parallel, and octane. Haven't tested node.jar yet. Haven't done any in-depth performance tests but I think there should be no notable regression. > > thanks, > Hannes From marcus.lagergren at oracle.com Wed Jan 30 07:33:16 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Wed, 30 Jan 2013 16:33:16 +0100 Subject: Please review JDK-8007140: Java.extend crashes when attempting to extend java.lang.Object In-Reply-To: <51093361.9000802@oracle.com> References: <51093361.9000802@oracle.com> Message-ID: <2FC07325-6580-46F8-AFA1-F41EDCAB8472@oracle.com> +1 On Jan 30, 2013, at 3:51 PM, A. Sundararajan wrote: > Hi, > > Please review http://cr.openjdk.java.net/~sundar/8007140/ > > Thanks > -Sundar From hannes.wallnoefer at oracle.com Wed Jan 30 07:41:13 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Wed, 30 Jan 2013 16:41:13 +0100 Subject: Please review JDK-8007140: Java.extend crashes when attempting to extend java.lang.Object In-Reply-To: <51093361.9000802@oracle.com> References: <51093361.9000802@oracle.com> Message-ID: <51093F19.3060104@oracle.com> +1 Am 2013-01-30 15:51, schrieb A. Sundararajan: > Hi, > > Please review http://cr.openjdk.java.net/~sundar/8007140/ > > Thanks > -Sundar From sundararajan.athijegannathan at oracle.com Wed Jan 30 07:45:51 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Wed, 30 Jan 2013 15:45:51 +0000 Subject: hg: nashorn/jdk8/nashorn: 8007140: Java.extend crashes when attempting to extend java.lang.Object Message-ID: <20130130154552.9855F476A3@hg.openjdk.java.net> Changeset: c04f54d5b672 Author: sundar Date: 2013-01-30 21:15 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/c04f54d5b672 8007140: Java.extend crashes when attempting to extend java.lang.Object Reviewed-by: lagergren, hannesw ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java ! test/script/basic/JDK-8006424.js + test/script/basic/JDK-8007140.js From attila.szegedi at oracle.com Wed Jan 30 07:53:40 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Wed, 30 Jan 2013 16:53:40 +0100 Subject: Review request for JDK-8006529 Message-ID: <3AA4BF80-88A3-4147-BCEE-DC587B069BC5@oracle.com> Please review JDK-8006529 at http://cr.openjdk.java.net/~attila/8006529/webrev.00 Thanks, Attila. From james.laskey at oracle.com Wed Jan 30 08:20:37 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Wed, 30 Jan 2013 12:20:37 -0400 Subject: Review request for JDK-8006529 In-Reply-To: <3AA4BF80-88A3-4147-BCEE-DC587B069BC5@oracle.com> References: <3AA4BF80-88A3-4147-BCEE-DC587B069BC5@oracle.com> Message-ID: FinalizeTypes.java 549 private static void updateSymbols(final Block block) { 550 if (block instanceof FunctionNode && block.getFunction() == block) { Why not a visitor (instead of instanceof test)? and Shouldn't it be? 549 private static void updateSymbols(final Block block) { 550 if (block instanceof FunctionNode) { 551 assert block.getFunction() == block; I have to say jdk.nashorn.internal.codegen.CompilerAccess creeps me out a bit. Since it's for testing only, it should not get into fcs build. +1 otherwise. On 2013-01-30, at 11:53 AM, Attila Szegedi wrote: > Please review JDK-8006529 at http://cr.openjdk.java.net/~attila/8006529/webrev.00 > > Thanks, > Attila. From marcus.lagergren at oracle.com Wed Jan 30 09:55:41 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Wed, 30 Jan 2013 18:55:41 +0100 Subject: Review request for JDK-8006529 In-Reply-To: <3AA4BF80-88A3-4147-BCEE-DC587B069BC5@oracle.com> References: <3AA4BF80-88A3-4147-BCEE-DC587B069BC5@oracle.com> Message-ID: <125F20A4-ED7A-4543-B34F-BDB3D0F5AEDB@oracle.com> I've spent several hours with you looking at this code today, so I say +1 - very nice work. Significantly fewer callee and scope allocations in the generated byte code. There is no doubt that we should push this, but before the push it would be great with a quick benchmark profile summary of before and after. /M On Jan 30, 2013, at 4:53 PM, Attila Szegedi wrote: > Please review JDK-8006529 at http://cr.openjdk.java.net/~attila/8006529/webrev.00 > > Thanks, > Attila. From attila.szegedi at oracle.com Thu Jan 31 03:25:33 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Thu, 31 Jan 2013 12:25:33 +0100 Subject: Review request for JDK-8006529 In-Reply-To: References: <3AA4BF80-88A3-4147-BCEE-DC587B069BC5@oracle.com> Message-ID: <973A297E-1389-4C26-86EE-B94170472F5B@oracle.com> On Jan 30, 2013, at 5:20 PM, Jim Laskey (Oracle) wrote: > FinalizeTypes.java > > 549 private static void updateSymbols(final Block block) { > 550 if (block instanceof FunctionNode && block.getFunction() == block) { > > Why not a visitor (instead of instanceof test)? > and Shouldn't it be? > > 549 private static void updateSymbols(final Block block) { > 550 if (block instanceof FunctionNode) { > 551 assert block.getFunction() == block; > You're right - I should move this into enter(FunctionNode). > I have to say jdk.nashorn.internal.codegen.CompilerAccess creeps me out a bit. Since it's for testing only, it should not get into fcs build. Yup, it's very deliberately put into test directory. OTOH, this is something that anyone can do in absence of a security manager anyway (and can't do in presence of one). Alternatively, we can add a "public FunctionNode getRootFunctionNode()" to compiler - not sure if we want to expose it though (although not sure that we don't want to either - if you or Sundar have an opinion as to the preferred approach, I'm happy to hear it). > +1 otherwise. Thanks, Attila. > > > On 2013-01-30, at 11:53 AM, Attila Szegedi wrote: > >> Please review JDK-8006529 at http://cr.openjdk.java.net/~attila/8006529/webrev.00 >> >> Thanks, >> Attila. > From sundararajan.athijegannathan at oracle.com Thu Jan 31 03:46:49 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Thu, 31 Jan 2013 17:16:49 +0530 Subject: Review request for JDK-8006529 In-Reply-To: <973A297E-1389-4C26-86EE-B94170472F5B@oracle.com> References: <3AA4BF80-88A3-4147-BCEE-DC587B069BC5@oracle.com> <973A297E-1389-4C26-86EE-B94170472F5B@oracle.com> Message-ID: <510A59A9.40402@oracle.com> As Attila said, it is test-only code under test/src dir. Only issue is that the reflective and scripts dependencies on nashorn internal structures won't be caught by compile time. May be a package-private accessor and test code could use the same package? Again, only to help finding dependencies by refactoring tools (if possible). In any case, test(s) will fail if anyone makes incompatible change and so developer making such change will have to sync test cases - which is okay. -Sundar On Thursday 31 January 2013 04:55 PM, Attila Szegedi wrote: > On Jan 30, 2013, at 5:20 PM, Jim Laskey (Oracle) wrote: > >> FinalizeTypes.java >> >> 549 private static void updateSymbols(final Block block) { >> 550 if (block instanceof FunctionNode && block.getFunction() == block) { >> >> Why not a visitor (instead of instanceof test)? >> and Shouldn't it be? >> >> 549 private static void updateSymbols(final Block block) { >> 550 if (block instanceof FunctionNode) { >> 551 assert block.getFunction() == block; >> > You're right - I should move this into enter(FunctionNode). > >> I have to say jdk.nashorn.internal.codegen.CompilerAccess creeps me out a bit. Since it's for testing only, it should not get into fcs build. > Yup, it's very deliberately put into test directory. OTOH, this is something that anyone can do in absence of a security manager anyway (and can't do in presence of one). > > Alternatively, we can add a "public FunctionNode getRootFunctionNode()" to compiler - not sure if we want to expose it though (although not sure that we don't want to either - if you or Sundar have an opinion as to the preferred approach, I'm happy to hear it). > >> +1 otherwise. > Thanks, > Attila. > >> >> On 2013-01-30, at 11:53 AM, Attila Szegedi wrote: >> >>> Please review JDK-8006529 at http://cr.openjdk.java.net/~attila/8006529/webrev.00 >>> >>> Thanks, >>> Attila. From sundararajan.athijegannathan at oracle.com Thu Jan 31 05:25:28 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Thu, 31 Jan 2013 18:55:28 +0530 Subject: Review request for JDK-8007286: Add JavaAdapter and importPackage to compatibility script Message-ID: <510A70C8.8020400@oracle.com> Please review http://cr.openjdk.java.net/~sundar/8007286/ Thanks -Sundar From marcus.lagergren at oracle.com Thu Jan 31 05:36:27 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Thu, 31 Jan 2013 14:36:27 +0100 Subject: Review request for JDK-8007286: Add JavaAdapter and importPackage to compatibility script In-Reply-To: <510A70C8.8020400@oracle.com> References: <510A70C8.8020400@oracle.com> Message-ID: <708BA244-F60F-4B27-8829-DB357490040F@oracle.com> Looks good. Convention question: + protected static final String engineScriptSourceName = "nashorn:engine/resources/engine.js"; All other static final variables in Nashorn seem to be named in caps, so maybe it should be ENGINE_SCRIPT_SOURCE_NAME for consistency? /M On Jan 31, 2013, at 2:25 PM, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~sundar/8007286/ > > Thanks > -Sundar From sundararajan.athijegannathan at oracle.com Thu Jan 31 05:35:39 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Thu, 31 Jan 2013 19:05:39 +0530 Subject: Review request for JDK-8007286: Add JavaAdapter and importPackage to compatibility script In-Reply-To: <708BA244-F60F-4B27-8829-DB357490040F@oracle.com> References: <510A70C8.8020400@oracle.com> <708BA244-F60F-4B27-8829-DB357490040F@oracle.com> Message-ID: <510A732B.5030600@oracle.com> Okay, I'll make that change to be consistent. Thanks -Sundar On Thursday 31 January 2013 07:06 PM, Marcus Lagergren wrote: > Looks good. > > Convention question: > > + protected static final String engineScriptSourceName = "nashorn:engine/resources/engine.js"; > > All other static final variables in Nashorn seem to be named in caps, > so maybe it should be ENGINE_SCRIPT_SOURCE_NAME for consistency? > > /M > > On Jan 31, 2013, at 2:25 PM, A. Sundararajan > > wrote: > >> Please review http://cr.openjdk.java.net/~sundar/8007286/ >> >> >> Thanks >> -Sundar > From james.laskey at oracle.com Thu Jan 31 05:49:09 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Thu, 31 Jan 2013 09:49:09 -0400 Subject: Review request for JDK-8007286: Add JavaAdapter and importPackage to compatibility script In-Reply-To: <510A70C8.8020400@oracle.com> References: <510A70C8.8020400@oracle.com> Message-ID: Agree with Marcus' comment. Otherwise +1. On 2013-01-31, at 9:25 AM, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~sundar/8007286/ > > Thanks > -Sundar From sundararajan.athijegannathan at oracle.com Thu Jan 31 05:54:14 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Thu, 31 Jan 2013 19:24:14 +0530 Subject: Review request for JDK-8007286: Add JavaAdapter and importPackage to compatibility script In-Reply-To: References: <510A70C8.8020400@oracle.com> Message-ID: <510A7786.50808@oracle.com> Thanks. I've updated the webrev as per Marcus' comments. Updated webrev uploaded for historical purpose: http://cr.openjdk.java.net/~sundar/8007286/webrev.01/ -Sundar On Thursday 31 January 2013 07:19 PM, Jim Laskey (Oracle) wrote: > Agree with Marcus' comment. Otherwise +1. > > On 2013-01-31, at 9:25 AM, A. Sundararajan wrote: > >> Please review http://cr.openjdk.java.net/~sundar/8007286/ >> >> Thanks >> -Sundar From sundararajan.athijegannathan at oracle.com Thu Jan 31 06:37:59 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Thu, 31 Jan 2013 14:37:59 +0000 Subject: hg: nashorn/jdk8/nashorn: 8007286: Add JavaAdapter and importPackage to compatibility script Message-ID: <20130131143800.295F6476EA@hg.openjdk.java.net> Changeset: 9c1e7ae975db Author: sundar Date: 2013-01-31 20:07 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/9c1e7ae975db 8007286: Add JavaAdapter and importPackage to compatibility script Reviewed-by: lagergren, jlaskey ! src/jdk/nashorn/api/scripting/NashornException.java ! src/jdk/nashorn/api/scripting/NashornScriptEngine.java ! src/jdk/nashorn/api/scripting/resources/engine.js ! src/jdk/nashorn/internal/parser/TokenLookup.java ! src/jdk/nashorn/internal/parser/TokenType.java ! src/jdk/nashorn/internal/runtime/ECMAException.java ! src/jdk/nashorn/internal/runtime/PropertyHashMap.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/resources/mozilla_compat.js + test/script/basic/importpackage.js + test/script/basic/javaadapter.js From hannes.wallnoefer at oracle.com Thu Jan 31 08:42:14 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Thu, 31 Jan 2013 17:42:14 +0100 Subject: Review request for JDK-8007060 In-Reply-To: <51091E25.5070200@oracle.com> References: <51091E25.5070200@oracle.com> Message-ID: <510A9EE6.5090908@oracle.com> I did some octane testing with this patch today and didn't note any performance degradations. I also noticed that only one octane test uses non-builtin methods on primitives at all, and that is earley-boyer. Based on this I uploaded a slightly changed patch to http://cr.openjdk.java.net/~hannesw/8007060/: 1) Adding the wrapFilter is now a one-way, i.e. once added it stays there and also handles object this-arguments (it did that already anyway). This makes NonStrictFunctionGuard simpler because we only have to check whether this-argument is ScriptObject (we install an ordinary FunctionGuard when the wrap filter is used). 2) I moved primitive wrapping from ScriptRuntime.apply() to ScriptFunction.invoke(). It really belongs there and also makes related code a bit nicer. Hannes Am 2013-01-30 14:20, schrieb Hannes Wallnoefer: > Please review http://cr.openjdk.java.net/~hannesw/8007060/ > > This removes the NashornInvocationTarget class whose purpose was to > track primitiveness of callsite targets and replaces it in two ways. > > 1) For functions invoked via ScriptRuntime.apply() (this includes > ordinary megamorphic callsites) we simply check function strictness > and this-argument primitiveness at runtime. We should have done that > anyway, I think there were several uses of this method that forgot to > wrap primitives when they should have. > > 2) For ordinary monomorphic callsites we check function strictness and > this-argument primitiveness at link time. If this is primitive we > install a wrapper methodhandle as argument filter. We then use a new > NonStrictFunctionGuard that in addition to the FunctionGuard check > tests whether primitiveness of this-argument has changed by doing one > simple instanceof check. (This should be very rare, as invocation of > script functions on JS primitives should generally be rare. > > I've tested this with test, test262parallel, and octane. Haven't > tested node.jar yet. Haven't done any in-depth performance tests but I > think there should be no notable regression. > > thanks, > Hannes From marcus.lagergren at oracle.com Thu Jan 31 09:07:48 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Thu, 31 Jan 2013 18:07:48 +0100 Subject: Review request for JDK-8007060 In-Reply-To: <510A9EE6.5090908@oracle.com> References: <51091E25.5070200@oracle.com> <510A9EE6.5090908@oracle.com> Message-ID: Yes. I like it. +1 On Jan 31, 2013, at 5:42 PM, Hannes Wallnoefer wrote: > I did some octane testing with this patch today and didn't note any performance degradations. I also noticed that only one octane test uses non-builtin methods on primitives at all, and that is earley-boyer. > > Based on this I uploaded a slightly changed patch to http://cr.openjdk.java.net/~hannesw/8007060/: > > 1) Adding the wrapFilter is now a one-way, i.e. once added it stays there and also handles object this-arguments (it did that already anyway). This makes NonStrictFunctionGuard simpler because we only have to check whether this-argument is ScriptObject (we install an ordinary FunctionGuard when the wrap filter is used). > > 2) I moved primitive wrapping from ScriptRuntime.apply() to ScriptFunction.invoke(). It really belongs there and also makes related code a bit nicer. > > Hannes > > Am 2013-01-30 14:20, schrieb Hannes Wallnoefer: >> Please review http://cr.openjdk.java.net/~hannesw/8007060/ >> >> This removes the NashornInvocationTarget class whose purpose was to track primitiveness of callsite targets and replaces it in two ways. >> >> 1) For functions invoked via ScriptRuntime.apply() (this includes ordinary megamorphic callsites) we simply check function strictness and this-argument primitiveness at runtime. We should have done that anyway, I think there were several uses of this method that forgot to wrap primitives when they should have. >> >> 2) For ordinary monomorphic callsites we check function strictness and this-argument primitiveness at link time. If this is primitive we install a wrapper methodhandle as argument filter. We then use a new NonStrictFunctionGuard that in addition to the FunctionGuard check tests whether primitiveness of this-argument has changed by doing one simple instanceof check. (This should be very rare, as invocation of script functions on JS primitives should generally be rare. >> >> I've tested this with test, test262parallel, and octane. Haven't tested node.jar yet. Haven't done any in-depth performance tests but I think there should be no notable regression. >> >> thanks, >> Hannes > From james.laskey at oracle.com Thu Jan 31 09:21:14 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Thu, 31 Jan 2013 13:21:14 -0400 Subject: Review request for JDK-8007060 In-Reply-To: <510A9EE6.5090908@oracle.com> References: <51091E25.5070200@oracle.com> <510A9EE6.5090908@oracle.com> Message-ID: <5BE67001-152C-4FD2-BFD7-AF8DD3142107@oracle.com> +1 On 2013-01-31, at 12:42 PM, Hannes Wallnoefer wrote: > I did some octane testing with this patch today and didn't note any performance degradations. I also noticed that only one octane test uses non-builtin methods on primitives at all, and that is earley-boyer. > > Based on this I uploaded a slightly changed patch to http://cr.openjdk.java.net/~hannesw/8007060/: > > 1) Adding the wrapFilter is now a one-way, i.e. once added it stays there and also handles object this-arguments (it did that already anyway). This makes NonStrictFunctionGuard simpler because we only have to check whether this-argument is ScriptObject (we install an ordinary FunctionGuard when the wrap filter is used). > > 2) I moved primitive wrapping from ScriptRuntime.apply() to ScriptFunction.invoke(). It really belongs there and also makes related code a bit nicer. > > Hannes > > Am 2013-01-30 14:20, schrieb Hannes Wallnoefer: >> Please review http://cr.openjdk.java.net/~hannesw/8007060/ >> >> This removes the NashornInvocationTarget class whose purpose was to track primitiveness of callsite targets and replaces it in two ways. >> >> 1) For functions invoked via ScriptRuntime.apply() (this includes ordinary megamorphic callsites) we simply check function strictness and this-argument primitiveness at runtime. We should have done that anyway, I think there were several uses of this method that forgot to wrap primitives when they should have. >> >> 2) For ordinary monomorphic callsites we check function strictness and this-argument primitiveness at link time. If this is primitive we install a wrapper methodhandle as argument filter. We then use a new NonStrictFunctionGuard that in addition to the FunctionGuard check tests whether primitiveness of this-argument has changed by doing one simple instanceof check. (This should be very rare, as invocation of script functions on JS primitives should generally be rare. >> >> I've tested this with test, test262parallel, and octane. Haven't tested node.jar yet. Haven't done any in-depth performance tests but I think there should be no notable regression. >> >> thanks, >> Hannes > From attila.szegedi at oracle.com Thu Jan 31 09:34:50 2013 From: attila.szegedi at oracle.com (attila.szegedi at oracle.com) Date: Thu, 31 Jan 2013 17:34:50 +0000 Subject: hg: nashorn/jdk8/nashorn: 8006529: Methods always get callee - it should be conditional Message-ID: <20130131173451.BDC94476F2@hg.openjdk.java.net> Changeset: f7825c1a11d3 Author: attila Date: 2013-01-31 18:34 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/f7825c1a11d3 8006529: Methods always get callee - it should be conditional Summary: This commit streamlines the bytecode function signatures, prologue, local variable use, scope creation, and invocation. It started out quite innocently when we noticed that we always emit __callee__ parameters for all functions even when they are not needed, but it turned out to be quite a deep rabbit hole. In the end, I identified exact conditions when functions need to have a callee parameter, when they need to receive parent scope, when they need to create their own scope, when they need to have variable arity signature, and when they need to have an "arguments" object, and made sure that callee parameters in signatures only show up when they are needed, that parent function's scope is only passed to a child function when it is needed, that the function only creates its own scope when it is needed. In crypto.js, the number of scopes dropped from 446 to 244, and the number of callees dropped from 315 to 145. Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/Compiler.java ! src/jdk/nashorn/internal/codegen/FinalizeTypes.java ! src/jdk/nashorn/internal/codegen/Lower.java ! src/jdk/nashorn/internal/codegen/MethodEmitter.java ! src/jdk/nashorn/internal/codegen/objects/FieldObjectCreator.java ! src/jdk/nashorn/internal/codegen/objects/FunctionObjectCreator.java ! src/jdk/nashorn/internal/codegen/types/Type.java ! src/jdk/nashorn/internal/ir/Block.java ! src/jdk/nashorn/internal/ir/FunctionNode.java ! src/jdk/nashorn/internal/ir/Symbol.java ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/objects/NativeArguments.java ! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java ! src/jdk/nashorn/internal/parser/Parser.java + src/jdk/nashorn/internal/runtime/ArgumentSetter.java ! src/jdk/nashorn/internal/runtime/ScriptFunction.java ! src/jdk/nashorn/internal/runtime/ScriptRuntime.java + test/script/basic/JDK-8006529-b.js + test/script/basic/JDK-8006529-b.js.EXPECTED + test/script/basic/JDK-8006529.js + test/src/jdk/nashorn/internal/codegen/CompilerAccess.java From hannes.wallnoefer at oracle.com Thu Jan 31 17:26:29 2013 From: hannes.wallnoefer at oracle.com (hannes.wallnoefer at oracle.com) Date: Fri, 01 Feb 2013 01:26:29 +0000 Subject: hg: nashorn/jdk8/nashorn: 8007060: Primitive wrap filter throws ClassCastException in test262parallel Message-ID: <20130201012630.A714C47720@hg.openjdk.java.net> Changeset: 697f700d90c0 Author: hannesw Date: 2013-02-01 02:24 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/697f700d90c0 8007060: Primitive wrap filter throws ClassCastException in test262parallel Reviewed-by: sundar, jlaskey, lagergren ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/objects/NativeFunction.java ! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java ! src/jdk/nashorn/internal/runtime/GlobalObject.java ! src/jdk/nashorn/internal/runtime/ScriptFunction.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/SetMethodCreator.java - src/jdk/nashorn/internal/runtime/linker/NashornGuardedInvocation.java ! src/jdk/nashorn/internal/runtime/linker/NashornGuards.java ! src/jdk/nashorn/internal/runtime/linker/PrimitiveLookup.java + test/script/basic/JDK-8007060.js + test/script/basic/JDK-8007060.js.EXPECTED