Review request for 8020437: Wrong handling of line numbers with multiline string literals

Jim Laskey (Oracle) james.laskey at oracle.com
Fri Jul 12 04:57:45 PDT 2013


+1

nit:

Lexer.java 

1462             // keep line number updated
1463             int lastLine = line;
1464             int lastLinePosition = linePosition;
1465 

1466             skipLine(false);

1467             lastLine++;
1468             lastLinePosition = position;



should be



1462             // keep line number updated
1463             int lastLine = line;
1464 

1465             skipLine(false);

1466             lastLine++;
1467             int lastLinePosition = position;



On 2013-07-12, at 4:08 AM, A. Sundararajan <sundararajan.athijegannathan at oracle.com> wrote:

> Please review http://cr.openjdk.java.net/~sundar/8020437
> 
> -Sundar



More information about the nashorn-dev mailing list