[nashorn] Review request for CR 8017585 Exclude two failing tests from Nashorn CC run
Jim Laskey (Oracle)
james.laskey at oracle.com
Tue Jul 16 13:31:01 PDT 2013
I'll push it.
On 2013-07-16, at 5:20 PM, Konstantin Shefov <konstantin.shefov at oracle.com> wrote:
> Will it be OK if I push the fix to http://hg.openjdk.java.net/jdk8/awt/nashorn?
> I cannot push to http://hg.openjdk.java.net/nashorn/jdk8/nashorn.
> So may be it would be better if you push it.
>
> Thanks,
> Konstantin
>
> 16.07.2013 20:22, Jim Laskey (Oracle) пишет:
>> +1 Thank you.
>>
>> On 2013-07-16, at 1:03 PM, Konstantin Shefov <konstantin.shefov at oracle.com> wrote:
>>
>>> Please, review the two exception list solution:
>>>
>>> http://cr.openjdk.java.net/~kshefov/8017585/webrev.01/ <http://cr.openjdk.java.net/%7Ekshefov/8017585/webrev.01/>
>>>
>>> 16.07.2013 16:13, Konstantin Shefov пишет:
>>>> I will try to implement this.
>>>>
>>>> On 16-Jul-13 16:11, Jim Laskey (Oracle) wrote:
>>>>> We still expect a two exception list solution at some point.
>>>>>
>>>>> On 2013-07-16, at 8:50 AM, A. Sundararajan <sundararajan.athijegannathan at oracle.com> wrote:
>>>>>
>>>>>> And please make sure "ant clean test" and "ant clean test262parallel" are fine with your change before pushing the change.
>>>>>>
>>>>>> -Sundar
>>>>>>
>>>>>> On Tuesday 16 July 2013 04:33 PM, Jim Laskey (Oracle) wrote:
>>>>>>> We had a discussion about whether this was the best approach. I think we had been thinking in terms of two separate exclude lists. In lieu of a better solution, go a head with this change.
>>>>>>>
>>>>>>> Cheers,
>>>>>>>
>>>>>>> -- Jim
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On 2013-07-16, at 7:33 AM, Konstantin Shefov <konstantin.shefov at oracle.com> wrote:
>>>>>>>
>>>>>>>> REMINDER
>>>>>>>> On 11-Jul-13 14:41, Konstantin Shefov wrote:
>>>>>>>>> Hello,
>>>>>>>>>
>>>>>>>>> Please review a fix for the issue:
>>>>>>>>>
>>>>>>>>> 8017585 Exclude two failing tests from Nashorn CC run
>>>>>>>>>
>>>>>>>>> http://bugs.sun.com/view_bug.do?bug_id=8017585
>>>>>>>>>
>>>>>>>>> The webrev is: http://cr.openjdk.java.net/~kshefov/8017585/webrev.00
>>>>>>>>>
>>>>>>>>> Thanks,
>>>>>>>>> Konstantin
>
More information about the nashorn-dev
mailing list