Review request 8021321: Two runsunspider tests fail after updating sunspider to 1.0

A. Sundararajan sundararajan.athijegannathan at oracle.com
Fri Jul 26 04:05:10 PDT 2013


+1

PS. does print-all-after mismatched line work for failed tests? I'd 
suggest locally adding a deliberately failing test and manual check of 
.EXPECTED file diff before pushing the change.

-Sundar

On Friday 26 July 2013 03:50 PM, Hannes Wallnoefer wrote:
> The changes to get sunspider running again look good to me. Whitespace 
> changes seem inconsistent though. Many lines have the same indentation 
> level as their parent.
>
> Hannes
>
> Am 2013-07-25 20:08, schrieb Jim Laskey (Oracle):
>> http://cr.openjdk.java.net/~jlaskey/8021321/webrev.00/
>



More information about the nashorn-dev mailing list