Review request for JDK-8011095 PropertyHashMap.rehash() does not grow enough

Hannes Wallnoefer hannes.wallnoefer at oracle.com
Sat Mar 30 08:40:34 PDT 2013


Looks good to me. The one thing I'm not sure about is the implications 
of not caching history for empty properties. On the one hand it seems 
plausible to avoid creating a huge property map tree where nothing is 
ever garbage collected, but on the hand everything starting at the empty 
properties map will not use history while still recording it, which is a 
wasted effort.

I think we should do some testing with octane to see what operations 
actually use history or not with this scheme.

Hannes


Am 2013-03-30 14:53, schrieb Jim Laskey (Oracle):
> Please review http://cr.openjdk.java.net/~jlaskey/8011095/webrev.00/
>



More information about the nashorn-dev mailing list