From headius at headius.com Wed May 1 13:10:51 2013 From: headius at headius.com (Charles Oliver Nutter) Date: Wed, 1 May 2013 15:10:51 -0500 Subject: Future for the JOni regex library Message-ID: Hello! I saw a few weeks back that you guys have adopted JRuby's regex engine, JOni, modified to work only with Java's char[]. We're thrilled that you've found our engine useful enough to incorporate! However, I'm wondering about the future of these engines. We have planned improvements, patches that come in from time to time, and so on, and maintaining two separate copies will eventually lead to them diverging. But without any way to specialize our byte[]-based JOni for char[] easily, I'm not sure what can be done. Any thoughts on this? Just to tempt you... a few of the planned improvements: * JVM bytecode compiler, for more fastness * Thread interruptible execution, to kill off regex runs that don't complete It would be great if we could collaborate on such things. - Charlie From james.laskey at oracle.com Wed May 1 13:35:35 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Wed, 1 May 2013 17:35:35 -0300 Subject: Future for the JOni regex library In-Reply-To: References: Message-ID: <3A9ADE52-9C38-43A2-AC10-41E47CD02604@oracle.com> I'll let "Dr. RegExp" Hannes Walln?fer respond in full when he gets back (holidays in Europe and JavaOne in India), but we are interested in co-operating and work towards pushing back an improved RegExp into the JDK. Hannes has already implemented 98% of byte code generation in Nashorn. Just down to to the last few corner cases. Cheers, - Jim On 2013-05-01, at 5:10 PM, Charles Oliver Nutter wrote: > Hello! > > I saw a few weeks back that you guys have adopted JRuby's regex > engine, JOni, modified to work only with Java's char[]. We're thrilled > that you've found our engine useful enough to incorporate! > > However, I'm wondering about the future of these engines. We have > planned improvements, patches that come in from time to time, and so > on, and maintaining two separate copies will eventually lead to them > diverging. But without any way to specialize our byte[]-based JOni for > char[] easily, I'm not sure what can be done. > > Any thoughts on this? Just to tempt you... a few of the planned improvements: > > * JVM bytecode compiler, for more fastness > * Thread interruptible execution, to kill off regex runs that don't complete > > It would be great if we could collaborate on such things. > > - Charlie From hannes.wallnoefer at oracle.com Wed May 1 15:50:58 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Thu, 02 May 2013 00:50:58 +0200 Subject: Future for the JOni regex library In-Reply-To: References: Message-ID: <51819C52.4000904@oracle.com> Hi Charlie, I feel a bit guilty for not getting (or keeping) in touch with you about this. We recently switched to Joni as our default regexp engine and it's working pretty well. What we have in Nashorn now is still relatively close to the JRuby codebase. Both share the same package structure, classes, and methods. Our code is just simpler because it doesn't have to deal with different encodings. My github fork contains a "noencoding" branch that represents the connection between the two: https://github.com/hns/joni/tree/noencoding However, there are some forces that might force us to drift further apart. One of them is code coverage. As it is, JavaScript uses a rather limited subset of what Joni provides, and this means a lot of code is neither used nor tested. Maintaining these bits doesn't seem to make sense (as far as Nashorn is concerned). It's a similar story with coding standards. We ran FindBugs over Joni and it found a number of issues, including things like public final arrays. Fixing these could require us to change the package structure or make other structural changes. Not to mention missing Javadocs and obscure naming, which would also drive us apart when fixed on our side. As Jim said I also worked on ASM bytecode generation and got quite far with it except for some combinations of nested quantifiers and captures I couldn't figure out. I've suspended the work for the time being since it's not the highest priority thing to do, but here's the patch: http://cr.openjdk.java.net/~hannesw/8012269/ I definitely think it would be a great idea to keep our versions of Joni connected and evolving together. Right now this would still be relatively easy, but it will become harder as time goes by. Hannes Am 2013-05-01 22:10, schrieb Charles Oliver Nutter: > Hello! > > I saw a few weeks back that you guys have adopted JRuby's regex > engine, JOni, modified to work only with Java's char[]. We're thrilled > that you've found our engine useful enough to incorporate! > > However, I'm wondering about the future of these engines. We have > planned improvements, patches that come in from time to time, and so > on, and maintaining two separate copies will eventually lead to them > diverging. But without any way to specialize our byte[]-based JOni for > char[] easily, I'm not sure what can be done. > > Any thoughts on this? Just to tempt you... a few of the planned improvements: > > * JVM bytecode compiler, for more fastness > * Thread interruptible execution, to kill off regex runs that don't complete > > It would be great if we could collaborate on such things. > > - Charlie From hannes.wallnoefer at oracle.com Wed May 1 23:07:06 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Thu, 02 May 2013 08:07:06 +0200 Subject: Review request for JDK-8013729 Message-ID: <5182028A.90508@oracle.com> Please review my patch for JDK-8013729: SwitchPoint invalidation not working over prototype chain: http://cr.openjdk.java.net/~hannesw/8013729/ Thanks, Hannes From sundararajan.athijegannathan at oracle.com Wed May 1 23:58:39 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Thu, 02 May 2013 12:28:39 +0530 Subject: Review request for JDK-8013729 In-Reply-To: <5182028A.90508@oracle.com> References: <5182028A.90508@oracle.com> Message-ID: <51820E9F.1010104@oracle.com> +1 On Thursday 02 May 2013 11:37 AM, Hannes Wallnoefer wrote: > Please review my patch for JDK-8013729: SwitchPoint invalidation not > working over prototype chain: > > http://cr.openjdk.java.net/~hannesw/8013729/ > > Thanks, > Hannes From hannes.wallnoefer at oracle.com Thu May 2 00:20:23 2013 From: hannes.wallnoefer at oracle.com (hannes.wallnoefer at oracle.com) Date: Thu, 02 May 2013 07:20:23 +0000 Subject: hg: nashorn/jdk8/nashorn: 8013729: SwitchPoint invalidation not working over prototype chain Message-ID: <20130502072024.DF5C84876E@hg.openjdk.java.net> Changeset: 80cb02dedc83 Author: hannesw Date: 2013-05-02 09:19 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/80cb02dedc83 8013729: SwitchPoint invalidation not working over prototype chain Reviewed-by: lagergren, sundar ! src/jdk/nashorn/internal/runtime/ScriptObject.java + test/script/basic/JDK-8013729.js + test/script/basic/JDK-8013729.js.EXPECTED From marcus.lagergren at oracle.com Thu May 2 02:02:31 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Thu, 2 May 2013 11:02:31 +0200 Subject: Review request for JDK-8013729 In-Reply-To: <5182028A.90508@oracle.com> References: <5182028A.90508@oracle.com> Message-ID: <2B6150F2-9831-4F52-964E-848BC07ECC1C@oracle.com> +1 On May 2, 2013, at 8:07 AM, Hannes Wallnoefer wrote: > Please review my patch for JDK-8013729: SwitchPoint invalidation not working over prototype chain: > > http://cr.openjdk.java.net/~hannesw/8013729/ > > Thanks, > Hannes From james.laskey at oracle.com Thu May 2 09:15:32 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Thu, 2 May 2013 13:15:32 -0300 Subject: Review request for JDK-8013794 - JDK-8006220 caused an octane performance regression. Message-ID: http://cr.openjdk.java.net/~jlaskey/8013794/webrev.00/index.html The most significant change with PropertyMaps was the removal of embedded, replaced with extra padding fields. I added a computation for the amount of padding to be equal to round up to multiple of 4 plus 4. This would make some structures larger than before (the plan is to make padding related to the number of this.xxx sets in a constructor.) This fix reverts padding to a fixed 4 extra fields (as was embedded.) From james.laskey at oracle.com Thu May 2 09:23:53 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Thu, 02 May 2013 16:23:53 +0000 Subject: hg: nashorn/jdk8/nashorn: 2 new changesets Message-ID: <20130502162355.7A04648780@hg.openjdk.java.net> Changeset: 7563c56ca565 Author: jlaskey Date: 2013-05-02 13:22 -0300 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/7563c56ca565 8013794: JDK-8006220 caused an octane performance regression. Reviewed-by: lagergren, sundar Contributed-by: james.laskey at oracle.com ! src/jdk/nashorn/internal/codegen/ObjectCreator.java Changeset: 9c2376a250b6 Author: jlaskey Date: 2013-05-02 13:23 -0300 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/9c2376a250b6 Merge From sundararajan.athijegannathan at oracle.com Thu May 2 09:32:57 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Thu, 02 May 2013 22:02:57 +0530 Subject: Review request for JDK-8013794 - JDK-8006220 caused an octane performance regression. In-Reply-To: References: Message-ID: <51829539.5090406@oracle.com> +1 On Thursday 02 May 2013 09:45 PM, Jim Laskey (Oracle) wrote: > http://cr.openjdk.java.net/~jlaskey/8013794/webrev.00/index.html > > The most significant change with PropertyMaps was the removal of embedded, replaced with extra padding fields. I added a computation for the amount of padding to be equal to round up to multiple of 4 plus 4. This would make some structures larger than before (the plan is to make padding related to the number of this.xxx sets in a constructor.) This fix reverts padding to a fixed 4 extra fields (as was embedded.) > From james.laskey at oracle.com Thu May 2 09:54:04 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Thu, 2 May 2013 13:54:04 -0300 Subject: Review request for JDK-8013796 - load("fx:base.js") should not be in fx:bootstrap.js Message-ID: <882D03B1-0AC3-452D-9B7A-92A4CBDEEB2B@oracle.com> Please review http://cr.openjdk.java.net/~jlaskey/8013796/webrev.00/index.html . This removes the automatic load of the JavaFX base classes when using -fx. We need to allow the user to control how/what classes are loaded by default. In this case, they can load("fx:base.js"); or add classes explicitly using Java.type(). From james.laskey at oracle.com Thu May 2 11:01:40 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Thu, 02 May 2013 18:01:40 +0000 Subject: hg: nashorn/jdk8/nashorn: 8013796: load("fx:base.js") should not be in fx:bootstrap.js Message-ID: <20130502180145.7B1394878B@hg.openjdk.java.net> Changeset: c8023561505b Author: jlaskey Date: 2013-05-02 15:01 -0300 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/c8023561505b 8013796: load("fx:base.js") should not be in fx:bootstrap.js Reviewed-by: sundar, lagergren Contributed-by: james.laskey at oracle.com ! src/jdk/nashorn/internal/runtime/resources/fx/bootstrap.js From sundararajan.athijegannathan at oracle.com Thu May 2 21:27:45 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Fri, 03 May 2013 09:57:45 +0530 Subject: Review request for JDK-8013796 - load("fx:base.js") should not be in fx:bootstrap.js In-Reply-To: <882D03B1-0AC3-452D-9B7A-92A4CBDEEB2B@oracle.com> References: <882D03B1-0AC3-452D-9B7A-92A4CBDEEB2B@oracle.com> Message-ID: <51833CC1.3030308@oracle.com> +1 On Thursday 02 May 2013 10:24 PM, Jim Laskey (Oracle) wrote: > Please review http://cr.openjdk.java.net/~jlaskey/8013796/webrev.00/index.html . This removes the automatic load of the JavaFX base classes when using -fx. We need to allow the user to control how/what classes are loaded by default. In this case, they can load("fx:base.js"); or add classes explicitly using Java.type(). > From marcus.lagergren at oracle.com Fri May 3 03:57:39 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Fri, 3 May 2013 12:57:39 +0200 Subject: Please review http://cr.openjdk.java.net/~lagergren/8013447/webrev/ Message-ID: Node.setSymbol needs to be immutable copy on write as well + snapshot parsed IRs for recompilation. Found a couple of existing type bugs in Attr and in the recompilation logic that I fixed. Method specialization is still hidden behind a flag, and not active. /M From james.laskey at oracle.com Fri May 3 05:23:28 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Fri, 3 May 2013 09:23:28 -0300 Subject: Please review http://cr.openjdk.java.net/~lagergren/8013447/webrev/ In-Reply-To: References: Message-ID: <109378DE-436A-4524-9A7D-5CCE776223AB@oracle.com> +1 On 2013-05-03, at 7:57 AM, Marcus Lagergren wrote: > > Node.setSymbol needs to be immutable copy on write as well + snapshot parsed IRs for recompilation. > > Found a couple of existing type bugs in Attr and in the recompilation logic that I fixed. Method specialization is still hidden behind a flag, and not active. > > /M > From marcus.lagergren at oracle.com Fri May 3 06:36:36 2013 From: marcus.lagergren at oracle.com (marcus.lagergren at oracle.com) Date: Fri, 03 May 2013 13:36:36 +0000 Subject: hg: nashorn/jdk8/nashorn: 8013477: Node.setSymbol needs to be copy on write - enable IR snapshots for recompilation based on callsite type specialization. [not enabled by default, hidden by a flag for now] Message-ID: <20130503133640.69A6A487E8@hg.openjdk.java.net> Changeset: 5a3f7867e19c Author: lagergren Date: 2013-05-03 15:33 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/5a3f7867e19c 8013477: Node.setSymbol needs to be copy on write - enable IR snapshots for recompilation based on callsite type specialization. [not enabled by default, hidden by a flag for now] Reviewed-by: jlaskey, hannesw ! bin/jjs ! src/jdk/nashorn/api/scripting/NashornScriptEngineFactory.java ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/CompilationPhase.java ! src/jdk/nashorn/internal/codegen/Compiler.java ! src/jdk/nashorn/internal/codegen/FinalizeTypes.java ! src/jdk/nashorn/internal/codegen/ObjectCreator.java ! src/jdk/nashorn/internal/codegen/Splitter.java ! src/jdk/nashorn/internal/ir/Block.java ! src/jdk/nashorn/internal/ir/CatchNode.java ! src/jdk/nashorn/internal/ir/FunctionNode.java ! src/jdk/nashorn/internal/ir/LexicalContext.java ! src/jdk/nashorn/internal/ir/LexicalContextNode.java ! src/jdk/nashorn/internal/ir/LiteralNode.java ! src/jdk/nashorn/internal/ir/Node.java ! src/jdk/nashorn/internal/ir/Symbol.java ! src/jdk/nashorn/internal/objects/NativeRegExp.java ! src/jdk/nashorn/internal/parser/AbstractParser.java ! src/jdk/nashorn/internal/parser/Parser.java ! src/jdk/nashorn/internal/runtime/CompiledFunction.java ! src/jdk/nashorn/internal/runtime/CompiledFunctions.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/JSONFunctions.java ! src/jdk/nashorn/internal/runtime/RecompilableScriptFunctionData.java ! src/jdk/nashorn/internal/runtime/ScriptEnvironment.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/regexp/DefaultRegExp.java ! src/jdk/nashorn/internal/runtime/regexp/JoniRegExp.java ! src/jdk/nashorn/internal/runtime/regexp/RegExpScanner.java ! src/jdk/nashorn/internal/runtime/resources/Options.properties ! src/jdk/nashorn/tools/Shell.java + test/script/basic/paramspec.js + test/script/basic/paramspec.js.EXPECTED ! test/script/basic/runsunspider.js + test/script/currently-failing/logcoverage.js - test/script/trusted/logcoverage.js From marcus.lagergren at oracle.com Fri May 3 06:39:53 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Fri, 3 May 2013 15:39:53 +0200 Subject: Please review http://cr.openjdk.java.net/~lagergren/8013871/ Message-ID: <490ED6C7-21EA-43B3-A7A2-F83984EA8959@oracle.com> Mem usage histogram of IR size after each compilation phase added. You need --log:compiler=info level at least and --print-mem-usage flag. /M From marcus.lagergren at oracle.com Fri May 3 07:03:01 2013 From: marcus.lagergren at oracle.com (marcus.lagergren at oracle.com) Date: Fri, 03 May 2013 14:03:01 +0000 Subject: hg: nashorn/jdk8/nashorn: 8013871: mem usage histograms enabled with compiler logging level set to more specific than or equals to info when --print-mem-usage flag is used Message-ID: <20130503140302.246B1487E9@hg.openjdk.java.net> Changeset: 829b06307fb2 Author: lagergren Date: 2013-05-03 16:01 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/829b06307fb2 8013871: mem usage histograms enabled with compiler logging level set to more specific than or equals to info when --print-mem-usage flag is used Reviewed-by: jlaskey, hannesw ! src/jdk/nashorn/internal/codegen/Compiler.java + src/jdk/nashorn/internal/ir/debug/ClassHistogramElement.java + src/jdk/nashorn/internal/ir/debug/ObjectSizeCalculator.java ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/ScriptEnvironment.java ! src/jdk/nashorn/internal/runtime/options/Options.java ! src/jdk/nashorn/internal/runtime/resources/Options.properties ! src/jdk/nashorn/tools/Shell.java From peter.zhelezniakov at oracle.com Fri May 3 08:50:33 2013 From: peter.zhelezniakov at oracle.com (Peter Zhelezniakov) Date: Fri, 03 May 2013 19:50:33 +0400 Subject: JSObjectLinker questions In-Reply-To: References: <516D4D50.8020109@oracle.com> Message-ID: <5183DCC9.5070305@oracle.com> On 04/16/2013 05:20 PM, Attila Szegedi wrote: > I'd suggest you just assemble your own DynamicLinker using your own factory; probably just put "new NashornLinker()" into the list of prioritized linkers and nothing else (you probably don't need the other linkers in Nashorn's internal prioritized linker list - they're only needed when linking call sites in a JavaScript program). > > Then you can have your own bootstrap() and createDynamicInvoker() calls that delegate to your own DynamicLinker. I cannot do "new NashornLinker()" as NashornLinker is package-private. Is there some other way to obtain an instance? (I recall from your J1 presentation that NashornLinker was designed to be publicly reusable, as opposed to NashornPrimitiveLinker, or have I got it wrong?) Thanks! -- Peter | x33066 | St Petersburg, Russia | timezone: GMT+04 From hannes.wallnoefer at oracle.com Fri May 3 11:15:41 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Fri, 03 May 2013 20:15:41 +0200 Subject: Request for review: 3 simple patches Message-ID: <5183FECD.1080507@oracle.com> Please review the following three rather simple patches: http://cr.openjdk.java.net/~hannesw/8013873/ http://cr.openjdk.java.net/~hannesw/8013874/ http://cr.openjdk.java.net/~hannesw/8013878/ Thanks, Hannes From james.laskey at oracle.com Fri May 3 12:00:20 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Fri, 3 May 2013 16:00:20 -0300 Subject: Request for review: 3 simple patches In-Reply-To: <5183FECD.1080507@oracle.com> References: <5183FECD.1080507@oracle.com> Message-ID: +3 On 2013-05-03, at 3:15 PM, Hannes Wallnoefer wrote: > Please review the following three rather simple patches: > > http://cr.openjdk.java.net/~hannesw/8013873/ > http://cr.openjdk.java.net/~hannesw/8013874/ > http://cr.openjdk.java.net/~hannesw/8013878/ > > Thanks, > Hannes From hannes.wallnoefer at oracle.com Fri May 3 13:52:47 2013 From: hannes.wallnoefer at oracle.com (hannes.wallnoefer at oracle.com) Date: Fri, 03 May 2013 20:52:47 +0000 Subject: hg: nashorn/jdk8/nashorn: 3 new changesets Message-ID: <20130503205251.DDC58487FD@hg.openjdk.java.net> Changeset: c0f0033d7b08 Author: hannesw Date: 2013-05-03 22:47 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/c0f0033d7b08 8013878: ClassCastException in Regex Reviewed-by: jlaskey ! src/jdk/nashorn/internal/objects/NativeArray.java + test/script/basic/JDK-8013878.js + test/script/basic/JDK-8013878.js.EXPECTED Changeset: f98d22fa3cbc Author: hannesw Date: 2013-05-03 22:48 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/f98d22fa3cbc 8013873: Regexp regression for escaped dash in character class Reviewed-by: jlaskey ! src/jdk/nashorn/internal/runtime/regexp/RegExpScanner.java + test/script/basic/JDK-8013873.js + test/script/basic/JDK-8013873.js.EXPECTED Changeset: f3dcb12c8439 Author: hannesw Date: 2013-05-03 22:50 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/f3dcb12c8439 8013874: Function argument's prototype seem cached and wrongly reused Reviewed-by: jlaskey ! src/jdk/nashorn/internal/runtime/PropertyMap.java + test/script/basic/JDK-8013874.js + test/script/basic/JDK-8013874.js.EXPECTED From attila.szegedi at oracle.com Mon May 6 00:20:51 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Mon, 6 May 2013 09:20:51 +0200 Subject: JSObjectLinker questions In-Reply-To: <5183DCC9.5070305@oracle.com> References: <516D4D50.8020109@oracle.com> <5183DCC9.5070305@oracle.com> Message-ID: No, you haven't gotten it wrong at all. NashornLinker should be public. This change was a product of an over-eager clampdown of the public surface of our API. I'll look into fixing this. Actually, we have a bit of an access-related conundrum even if I make it public. Namely, as we integrated Dynalink, we put it into the jdk.internal.dynalink package. NashornLinker itself lives in jdk.nashorn.internal.runtime.linker package. Both jdk.internal.* and jdk.nashorn.internal.* packages are access-restricted. This isn't an issue if you're not running with a SecurityManager, but with SecurityManager, your code creating the linker will have to have the relevant accessClassInPackage permission. Is that an obstacle in your case? (It's only an obstacle if you both use SecurityManager and can't grant the permission to your framework code. I don't really think it should be an obstacle, just wanted to make sure you're aware of it.) If it isn't an obstacle, then simply making the class public should be sufficient for your purposes. If it is, then we have bigger problems, as your code won't be able to interface with internalized Dynalink at all. We'll then need to discuss further with various OpenJDK parties if we can ship Dynalink in a way that is not endorsed, but not restricted either (right now, jdk.internal is both non-endorsed and restricted code). Attila. On May 3, 2013, at 5:50 PM, Peter Zhelezniakov wrote: > On 04/16/2013 05:20 PM, Attila Szegedi wrote: >> I'd suggest you just assemble your own DynamicLinker using your own factory; probably just put "new NashornLinker()" into the list of prioritized linkers and nothing else (you probably don't need the other linkers in Nashorn's internal prioritized linker list - they're only needed when linking call sites in a JavaScript program). >> >> Then you can have your own bootstrap() and createDynamicInvoker() calls that delegate to your own DynamicLinker. > > I cannot do "new NashornLinker()" as NashornLinker is package-private. Is there some other way to obtain an instance? > > (I recall from your J1 presentation that NashornLinker was designed to be publicly reusable, as opposed to NashornPrimitiveLinker, or have I got it wrong?) > > Thanks! > -- > Peter | x33066 | St Petersburg, Russia | timezone: GMT+04 From marcus.lagergren at oracle.com Mon May 6 08:58:29 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Mon, 6 May 2013 17:58:29 +0200 Subject: Footprint reduction: Please review JDK-8013913 - Remove source field from all nodes Message-ID: <6BE80F1C-51EC-489B-947B-9797C0B7A9F1@oracle.com> This got the footprint for large scripts down by several megs. Source now only lives inside the FunctionNode. Fairly trivial change, but it affected a lot of files. http://cr.openjdk.java.net/~lagergren/8013913/ /M From attila.szegedi at oracle.com Mon May 6 09:06:10 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Mon, 6 May 2013 18:06:10 +0200 Subject: Footprint reduction: Please review JDK-8013913 - Remove source field from all nodes In-Reply-To: <6BE80F1C-51EC-489B-947B-9797C0B7A9F1@oracle.com> References: <6BE80F1C-51EC-489B-947B-9797C0B7A9F1@oracle.com> Message-ID: Looks good - yeah, lots of changes for the removal of source field/parameter from a zillion of places. I like that we got rid of Location.java. +1. On May 6, 2013, at 5:58 PM, Marcus Lagergren wrote: > This got the footprint for large scripts down by several megs. Source now only lives inside the FunctionNode. Fairly trivial change, but it affected a lot of files. > > http://cr.openjdk.java.net/~lagergren/8013913/ > > /M > From marcus.lagergren at oracle.com Mon May 6 09:08:27 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Mon, 6 May 2013 18:08:27 +0200 Subject: Please review JDK-8013914 - line number footprint Message-ID: <9B8A668F-6341-403D-A018-3B57A9CF8915@oracle.com> I've introduced the Statement node, which proved to be a design advantage from other points of view as well - a Statement being the only kind of node that results in steppable code on the root level. Currently the Statement holds line number information and line number nodes are deprecated. Line number nodes were brittle for several reasons 1) footprint 2) code moves around and they may not apply anymore, being loosely coupled instead of tightly coupled to code. The next logical step is probably to move location information down into Statement, save memory for Node instances that don't need it. IdentNode needs it though, as we all know "x" in JavaScript may very well be a getter. This fix saved quite a lot of IR footprint for large IRs. (I also slightly tweaked the heuristic for snapshotting parsed IR, so we don't save all IR all the time in case of future recompilation). All in all I got the IR footprint of Octane Mandrel down by almost 30% with this fix combined with JDK-8013913 http://cr.openjdk.java.net/~lagergren/8013914/ /M From headius at headius.com Mon May 6 11:09:25 2013 From: headius at headius.com (Charles Oliver Nutter) Date: Mon, 6 May 2013 13:09:25 -0500 Subject: Future for the JOni regex library In-Reply-To: <51819C52.4000904@oracle.com> References: <51819C52.4000904@oracle.com> Message-ID: Thanks for the updates, Hannes! Wow, I didn't expect to hear you already had a regex compiler, but I suppose I should have known :-) I wonder if we can port it back to Joni and finish it...regex compilation has been on our want list for a long time. I understand what you mean about stripping stuff out. We have to use Joni almost as-is because of the complexities of Ruby regex and encoding logic, but there's not much need for you to do the same. Sharing in the long term will probably be difficult. I'm also really excited to hear that you will try to JEP this into OpenJDK as the new regex backend. Have you been in contact with the author of Joni, Marcin Mielzinsky? He would be very proud to know this is in process, and obviously he deserves pretty much all the credit for making this thing happen. - Charlie On Wed, May 1, 2013 at 5:50 PM, Hannes Wallnoefer wrote: > Hi Charlie, > > I feel a bit guilty for not getting (or keeping) in touch with you about > this. We recently switched to Joni as our default regexp engine and it's > working pretty well. > > What we have in Nashorn now is still relatively close to the JRuby codebase. > Both share the same package structure, classes, and methods. Our code is > just simpler because it doesn't have to deal with different encodings. My > github fork contains a "noencoding" branch that represents the connection > between the two: > > https://github.com/hns/joni/tree/noencoding > > However, there are some forces that might force us to drift further apart. > One of them is code coverage. As it is, JavaScript uses a rather limited > subset of what Joni provides, and this means a lot of code is neither used > nor tested. Maintaining these bits doesn't seem to make sense (as far as > Nashorn is concerned). > > It's a similar story with coding standards. We ran FindBugs over Joni and it > found a number of issues, including things like public final arrays. Fixing > these could require us to change the package structure or make other > structural changes. Not to mention missing Javadocs and obscure naming, > which would also drive us apart when fixed on our side. > > As Jim said I also worked on ASM bytecode generation and got quite far with > it except for some combinations of nested quantifiers and captures I > couldn't figure out. I've suspended the work for the time being since it's > not the highest priority thing to do, but here's the patch: > > http://cr.openjdk.java.net/~hannesw/8012269/ > > I definitely think it would be a great idea to keep our versions of Joni > connected and evolving together. Right now this would still be relatively > easy, but it will become harder as time goes by. > > Hannes > > > Am 2013-05-01 22:10, schrieb Charles Oliver Nutter: > >> Hello! >> >> I saw a few weeks back that you guys have adopted JRuby's regex >> engine, JOni, modified to work only with Java's char[]. We're thrilled >> that you've found our engine useful enough to incorporate! >> >> However, I'm wondering about the future of these engines. We have >> planned improvements, patches that come in from time to time, and so >> on, and maintaining two separate copies will eventually lead to them >> diverging. But without any way to specialize our byte[]-based JOni for >> char[] easily, I'm not sure what can be done. >> >> Any thoughts on this? Just to tempt you... a few of the planned >> improvements: >> >> * JVM bytecode compiler, for more fastness >> * Thread interruptible execution, to kill off regex runs that don't >> complete >> >> It would be great if we could collaborate on such things. >> >> - Charlie > > From james.laskey at oracle.com Tue May 7 03:51:34 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Tue, 7 May 2013 07:51:34 -0300 Subject: Footprint reduction: Please review JDK-8013913 - Remove source field from all nodes In-Reply-To: <6BE80F1C-51EC-489B-947B-9797C0B7A9F1@oracle.com> References: <6BE80F1C-51EC-489B-947B-9797C0B7A9F1@oracle.com> Message-ID: <7F35DCB6-BE0C-447A-8DCE-AB174504394B@oracle.com> +1 Attr.java - mysterious blank line. 532 if (symbol != null && !identNode.isInitializedHere()) { 533 534 symbol.increaseUseCount(); 535 } On 2013-05-06, at 12:58 PM, Marcus Lagergren wrote: > This got the footprint for large scripts down by several megs. Source now only lives inside the FunctionNode. Fairly trivial change, but it affected a lot of files. > > http://cr.openjdk.java.net/~lagergren/8013913/ > > /M > From marcus.lagergren at oracle.com Tue May 7 03:59:22 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Tue, 7 May 2013 12:59:22 +0200 Subject: Please review JDK-8013914 - line number footprint In-Reply-To: <9B8A668F-6341-403D-A018-3B57A9CF8915@oracle.com> References: <9B8A668F-6341-403D-A018-3B57A9CF8915@oracle.com> Message-ID: I've uploaded a new web rev. This one revealed some issues that just "happened to work" in tip, and some that didn't. -debug-line=false, i.e. turning off line numbers, broke all over the code base. Apparently we don't have unit tests for that. I'll add one The other problem was that explicit LineNumberNodes always created jdk.nashorn.internal.ir.Labels that created an evaluation stack just just conveniently happened to be around for dead code, such as break; linenumbernode; print("never written") Removing the explicit line number node, broke CodeGenerator when it got to the dead code. Of course, the code generation shouldn't even HAVE that dead code in the first place, so I had to change Lower, where it picks out variable declarations during statement placement in any block to ONLY pick out variable declarations, by going deep into the nodes past the terminator node. All tests pass now. New web rev at: http://cr.openjdk.java.net/~lagergren/8013914/webrev.02/ /M On May 6, 2013, at 6:08 PM, Marcus Lagergren wrote: > I've introduced the Statement node, which proved to be a design advantage from other points of view as well - a Statement being the only kind of node that results in steppable code on the root level. Currently the Statement holds line number information and line number nodes are deprecated. > > Line number nodes were brittle for several reasons 1) footprint 2) code moves around and they may not apply anymore, being loosely coupled instead of tightly coupled to code. > > The next logical step is probably to move location information down into Statement, save memory for Node instances that don't need it. IdentNode needs it though, as we all know "x" in JavaScript may very well be a getter. > > This fix saved quite a lot of IR footprint for large IRs. > > (I also slightly tweaked the heuristic for snapshotting parsed IR, so we don't save all IR all the time in case of future recompilation). > > All in all I got the IR footprint of Octane Mandrel down by almost 30% with this fix combined with JDK-8013913 > > http://cr.openjdk.java.net/~lagergren/8013914/ > > /M From marcus.lagergren at oracle.com Tue May 7 04:06:16 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Tue, 7 May 2013 13:06:16 +0200 Subject: Footprint reduction: Please review JDK-8013913 - Remove source field from all nodes In-Reply-To: <7F35DCB6-BE0C-447A-8DCE-AB174504394B@oracle.com> References: <6BE80F1C-51EC-489B-947B-9797C0B7A9F1@oracle.com> <7F35DCB6-BE0C-447A-8DCE-AB174504394B@oracle.com> Message-ID: <890D5C9F-66FA-4C6C-9027-0E2E128BC095@oracle.com> Fixed that. It shouldn't even say symbol != null, that is always true. This is old code that had survived the lower Attr/Split. There is always a symbol there. /M On May 7, 2013, at 12:51 PM, Jim Laskey (Oracle) wrote: > +1 > > > > Attr.java - mysterious blank line. > > > 532 if (symbol != null && !identNode.isInitializedHere()) { > > 533 > > 534 symbol.increaseUseCount(); > 535 } > > > > > > On 2013-05-06, at 12:58 PM, Marcus Lagergren wrote: > >> This got the footprint for large scripts down by several megs. Source now only lives inside the FunctionNode. Fairly trivial change, but it affected a lot of files. >> >> http://cr.openjdk.java.net/~lagergren/8013913/ >> >> /M >> > From james.laskey at oracle.com Tue May 7 04:15:41 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Tue, 7 May 2013 08:15:41 -0300 Subject: Please review JDK-8013914 - line number footprint In-Reply-To: References: <9B8A668F-6341-403D-A018-3B57A9CF8915@oracle.com> Message-ID: <79A07794-7695-44EA-9B26-2DFC864E19DC@oracle.com> +1 On 2013-05-07, at 7:59 AM, Marcus Lagergren wrote: > I've uploaded a new web rev. This one revealed some issues that just "happened to work" in tip, and some that didn't. > > -debug-line=false, i.e. turning off line numbers, broke all over the code base. Apparently we don't have unit tests for that. I'll add one > > The other problem was that explicit LineNumberNodes always created jdk.nashorn.internal.ir.Labels that created an evaluation stack just just conveniently happened to be around for dead code, such as > > > break; > linenumbernode; > print("never written") > > Removing the explicit line number node, broke CodeGenerator when it got to the dead code. > > Of course, the code generation shouldn't even HAVE that dead code in the first place, so I had to change Lower, where it picks out variable declarations during statement placement in any block to ONLY pick out variable declarations, by going deep into the nodes past the terminator node. > > All tests pass now. > > New web rev at: > http://cr.openjdk.java.net/~lagergren/8013914/webrev.02/ > > > > /M > > On May 6, 2013, at 6:08 PM, Marcus Lagergren wrote: > >> I've introduced the Statement node, which proved to be a design advantage from other points of view as well - a Statement being the only kind of node that results in steppable code on the root level. Currently the Statement holds line number information and line number nodes are deprecated. >> >> Line number nodes were brittle for several reasons 1) footprint 2) code moves around and they may not apply anymore, being loosely coupled instead of tightly coupled to code. >> >> The next logical step is probably to move location information down into Statement, save memory for Node instances that don't need it. IdentNode needs it though, as we all know "x" in JavaScript may very well be a getter. >> >> This fix saved quite a lot of IR footprint for large IRs. >> >> (I also slightly tweaked the heuristic for snapshotting parsed IR, so we don't save all IR all the time in case of future recompilation). >> >> All in all I got the IR footprint of Octane Mandrel down by almost 30% with this fix combined with JDK-8013913 >> >> http://cr.openjdk.java.net/~lagergren/8013914/ >> >> /M > From marcus.lagergren at oracle.com Tue May 7 05:45:48 2013 From: marcus.lagergren at oracle.com (marcus.lagergren at oracle.com) Date: Tue, 07 May 2013 12:45:48 +0000 Subject: hg: nashorn/jdk8/nashorn: 2 new changesets Message-ID: <20130507124553.2F84248875@hg.openjdk.java.net> Changeset: 544e17632e96 Author: lagergren Date: 2013-05-07 14:36 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/544e17632e96 8013913: Removed Source field from all nodes except FunctionNode in order to save footprint Reviewed-by: jlaskey, attila ! src/jdk/nashorn/api/scripting/NashornScriptEngine.java ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/FinalizeTypes.java ! src/jdk/nashorn/internal/codegen/FoldConstants.java ! src/jdk/nashorn/internal/codegen/Lower.java ! src/jdk/nashorn/internal/codegen/Splitter.java ! src/jdk/nashorn/internal/ir/AccessNode.java ! src/jdk/nashorn/internal/ir/BaseNode.java ! src/jdk/nashorn/internal/ir/BinaryNode.java ! src/jdk/nashorn/internal/ir/Block.java ! src/jdk/nashorn/internal/ir/BreakNode.java ! src/jdk/nashorn/internal/ir/BreakableNode.java ! src/jdk/nashorn/internal/ir/CallNode.java ! src/jdk/nashorn/internal/ir/CaseNode.java ! src/jdk/nashorn/internal/ir/CatchNode.java ! src/jdk/nashorn/internal/ir/ContinueNode.java ! src/jdk/nashorn/internal/ir/EmptyNode.java ! src/jdk/nashorn/internal/ir/ExecuteNode.java ! src/jdk/nashorn/internal/ir/ForNode.java ! src/jdk/nashorn/internal/ir/FunctionNode.java ! src/jdk/nashorn/internal/ir/IdentNode.java ! src/jdk/nashorn/internal/ir/IfNode.java ! src/jdk/nashorn/internal/ir/IndexNode.java ! src/jdk/nashorn/internal/ir/LabelNode.java ! src/jdk/nashorn/internal/ir/LexicalContext.java ! src/jdk/nashorn/internal/ir/LexicalContextNode.java ! src/jdk/nashorn/internal/ir/LineNumberNode.java ! src/jdk/nashorn/internal/ir/LiteralNode.java - src/jdk/nashorn/internal/ir/Location.java ! src/jdk/nashorn/internal/ir/LoopNode.java ! src/jdk/nashorn/internal/ir/Node.java ! src/jdk/nashorn/internal/ir/ObjectNode.java ! src/jdk/nashorn/internal/ir/PropertyNode.java ! src/jdk/nashorn/internal/ir/ReturnNode.java ! src/jdk/nashorn/internal/ir/RuntimeNode.java ! src/jdk/nashorn/internal/ir/SplitNode.java ! src/jdk/nashorn/internal/ir/SwitchNode.java ! src/jdk/nashorn/internal/ir/TernaryNode.java ! src/jdk/nashorn/internal/ir/ThrowNode.java ! src/jdk/nashorn/internal/ir/TryNode.java ! src/jdk/nashorn/internal/ir/UnaryNode.java ! src/jdk/nashorn/internal/ir/VarNode.java ! src/jdk/nashorn/internal/ir/WhileNode.java ! src/jdk/nashorn/internal/ir/WithNode.java ! src/jdk/nashorn/internal/ir/debug/JSONWriter.java ! src/jdk/nashorn/internal/objects/NativeDebug.java ! src/jdk/nashorn/internal/parser/AbstractParser.java ! src/jdk/nashorn/internal/parser/JSONParser.java ! src/jdk/nashorn/internal/parser/Parser.java ! src/jdk/nashorn/internal/runtime/RecompilableScriptFunctionData.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/arrays/ArrayLikeIterator.java ! src/jdk/nashorn/internal/runtime/linker/LinkerCallSite.java ! src/jdk/nashorn/tools/Shell.java Changeset: fb1d7ea3e1b6 Author: lagergren Date: 2013-05-07 14:43 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/fb1d7ea3e1b6 8013914: Removed explicit LineNumberNodes that were too brittle when code moves around, and also introduced unnecessary footprint. Introduced the Statement node and fixed dead code elimination issues that were discovered by the absense of labels for LineNumberNodes. Reviewed-by: jlaskey, attila ! make/project.properties ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/FinalizeTypes.java ! src/jdk/nashorn/internal/codegen/FoldConstants.java ! src/jdk/nashorn/internal/codegen/Label.java ! src/jdk/nashorn/internal/codegen/Lower.java ! src/jdk/nashorn/internal/codegen/MethodEmitter.java ! src/jdk/nashorn/internal/codegen/Splitter.java ! src/jdk/nashorn/internal/ir/Block.java ! src/jdk/nashorn/internal/ir/BlockLexicalContext.java ! src/jdk/nashorn/internal/ir/BreakNode.java ! src/jdk/nashorn/internal/ir/BreakableNode.java ! src/jdk/nashorn/internal/ir/CallNode.java ! src/jdk/nashorn/internal/ir/CatchNode.java ! src/jdk/nashorn/internal/ir/ContinueNode.java ! src/jdk/nashorn/internal/ir/EmptyNode.java ! src/jdk/nashorn/internal/ir/ExecuteNode.java ! src/jdk/nashorn/internal/ir/ForNode.java ! src/jdk/nashorn/internal/ir/FunctionNode.java ! src/jdk/nashorn/internal/ir/IfNode.java ! src/jdk/nashorn/internal/ir/LabelNode.java ! src/jdk/nashorn/internal/ir/LexicalContextNode.java - src/jdk/nashorn/internal/ir/LineNumberNode.java ! src/jdk/nashorn/internal/ir/LoopNode.java ! src/jdk/nashorn/internal/ir/Node.java ! src/jdk/nashorn/internal/ir/ReturnNode.java ! src/jdk/nashorn/internal/ir/SplitNode.java + src/jdk/nashorn/internal/ir/Statement.java ! src/jdk/nashorn/internal/ir/SwitchNode.java ! src/jdk/nashorn/internal/ir/Symbol.java ! src/jdk/nashorn/internal/ir/ThrowNode.java ! src/jdk/nashorn/internal/ir/TryNode.java ! src/jdk/nashorn/internal/ir/VarNode.java ! src/jdk/nashorn/internal/ir/WhileNode.java ! src/jdk/nashorn/internal/ir/WithNode.java ! src/jdk/nashorn/internal/ir/debug/JSONWriter.java ! src/jdk/nashorn/internal/ir/debug/PrintVisitor.java ! src/jdk/nashorn/internal/ir/visitor/NodeOperatorVisitor.java ! src/jdk/nashorn/internal/ir/visitor/NodeVisitor.java ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/objects/NativeDebug.java ! src/jdk/nashorn/internal/parser/Parser.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/linker/LinkerCallSite.java ! src/jdk/nashorn/tools/Shell.java + test/script/basic/no_line_numbers.js + test/script/basic/no_line_numbers.js.EXPECTED From attila.szegedi at oracle.com Wed May 8 06:06:01 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Wed, 8 May 2013 15:06:01 +0200 Subject: Review request for JDK-8013912 Message-ID: <692763A1-ADEB-41B8-8959-D76C218C0862@oracle.com> Please review JDK-8013912 at http://cr.openjdk.java.net/~attila/8013912/webrev.00 Thanks, Attila. From james.laskey at oracle.com Wed May 8 06:22:13 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Wed, 8 May 2013 10:22:13 -0300 Subject: Review request for JDK-8013912 In-Reply-To: <692763A1-ADEB-41B8-8959-D76C218C0862@oracle.com> References: <692763A1-ADEB-41B8-8959-D76C218C0862@oracle.com> Message-ID: <1B4E1561-FEA3-4DCD-AAA5-6C0C692CC487@oracle.com> +1 Might as well do regex as well 125 /** prefix for regexps */ 126 REGEX_PREFIX(":regex"), -> ":r" On 2013-05-08, at 10:06 AM, Attila Szegedi wrote: > Please review JDK-8013912 at http://cr.openjdk.java.net/~attila/8013912/webrev.00 > > Thanks, > Attila. From marcus.lagergren at oracle.com Wed May 8 06:45:49 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Wed, 8 May 2013 15:45:49 +0200 Subject: Review request for JDK-8013912 In-Reply-To: <692763A1-ADEB-41B8-8959-D76C218C0862@oracle.com> References: <692763A1-ADEB-41B8-8959-D76C218C0862@oracle.com> Message-ID: +1 On May 8, 2013, at 3:06 PM, Attila Szegedi wrote: > Please review JDK-8013912 at http://cr.openjdk.java.net/~attila/8013912/webrev.00 > > Thanks, > Attila. From attila.szegedi at oracle.com Wed May 8 06:51:49 2013 From: attila.szegedi at oracle.com (attila.szegedi at oracle.com) Date: Wed, 08 May 2013 13:51:49 +0000 Subject: hg: nashorn/jdk8/nashorn: 8013912: Nashorn needs to reuse temporary symbols Message-ID: <20130508135151.B705A488D7@hg.openjdk.java.net> Changeset: d28180d97c61 Author: attila Date: 2013-05-08 15:51 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/d28180d97c61 8013912: Nashorn needs to reuse temporary symbols Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/codegen/CompilationPhase.java ! src/jdk/nashorn/internal/codegen/Compiler.java ! src/jdk/nashorn/internal/codegen/CompilerConstants.java ! src/jdk/nashorn/internal/codegen/FinalizeTypes.java ! src/jdk/nashorn/internal/ir/AccessNode.java ! src/jdk/nashorn/internal/ir/BlockLexicalContext.java ! src/jdk/nashorn/internal/ir/CallNode.java ! src/jdk/nashorn/internal/ir/IdentNode.java ! src/jdk/nashorn/internal/ir/IndexNode.java ! src/jdk/nashorn/internal/ir/Node.java ! src/jdk/nashorn/internal/ir/RuntimeNode.java ! src/jdk/nashorn/internal/ir/Symbol.java + src/jdk/nashorn/internal/ir/TemporarySymbols.java ! src/jdk/nashorn/internal/ir/TypeOverride.java From attila.szegedi at oracle.com Wed May 8 07:19:36 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Wed, 8 May 2013 16:19:36 +0200 Subject: Review request for JDK-8014225 Message-ID: <66B535F7-FE92-481D-8724-AA8E828E294A@oracle.com> Please review JDK-8014225 at http://cr.openjdk.java.net/~attila/8014225/webrev.00 Thanks, Attila. From james.laskey at oracle.com Wed May 8 07:38:28 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Wed, 8 May 2013 11:38:28 -0300 Subject: Review request for JDK-8014225 In-Reply-To: <66B535F7-FE92-481D-8724-AA8E828E294A@oracle.com> References: <66B535F7-FE92-481D-8724-AA8E828E294A@oracle.com> Message-ID: <86519807-C512-43E8-B1F8-57FE43B0041C@oracle.com> +1 On 2013-05-08, at 11:19 AM, Attila Szegedi wrote: > Please review JDK-8014225 at http://cr.openjdk.java.net/~attila/8014225/webrev.00 > > Thanks, > Attila. From attila.szegedi at oracle.com Wed May 8 07:48:47 2013 From: attila.szegedi at oracle.com (attila.szegedi at oracle.com) Date: Wed, 08 May 2013 14:48:47 +0000 Subject: hg: nashorn/jdk8/nashorn: 8014225: Rerun only failed 262 tests Message-ID: <20130508144848.8E369488DB@hg.openjdk.java.net> Changeset: 18ce1cd3026c Author: attila Date: 2013-05-08 16:48 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/18ce1cd3026c 8014225: Rerun only failed 262 tests Reviewed-by: jlaskey, lagergren ! make/project.properties ! test/src/jdk/nashorn/internal/test/framework/AbstractScriptRunnable.java ! test/src/jdk/nashorn/internal/test/framework/ParallelTestRunner.java ! test/src/jdk/nashorn/internal/test/framework/TestConfig.java ! test/src/jdk/nashorn/internal/test/framework/TestFinder.java From marcus.lagergren at oracle.com Wed May 8 09:17:25 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Wed, 8 May 2013 18:17:25 +0200 Subject: Review request for JDK-8014225 In-Reply-To: <66B535F7-FE92-481D-8724-AA8E828E294A@oracle.com> References: <66B535F7-FE92-481D-8724-AA8E828E294A@oracle.com> Message-ID: <755EFBC9-B673-45E5-89E7-C0DA6974BD66@oracle.com> +1 On May 8, 2013, at 4:19 PM, Attila Szegedi wrote: > Please review JDK-8014225 at http://cr.openjdk.java.net/~attila/8014225/webrev.00 > > Thanks, > Attila. From hannes.wallnoefer at oracle.com Thu May 9 18:48:18 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Fri, 10 May 2013 07:18:18 +0530 Subject: Future for the JOni regex library In-Reply-To: References: <51819C52.4000904@oracle.com> Message-ID: <518C51E2.6010305@oracle.com> Sorry for the late reply again. I've been at JavaOne India most of the week and was a bit distracted. All our changes to Joni were made under the original license, so in my understanding there shouldn't be any problem in taking them back. A I said the patch is incomplete and probably won't make it into JDK8, but of course if you could make something out if it that would be wonderful! We've just started discussing our plans for JDK9. I haven't contacted Marcin yet but I'll absolutely contact him and you about this. Hannes Am 2013-05-06 23:39, schrieb Charles Oliver Nutter: > Thanks for the updates, Hannes! > > Wow, I didn't expect to hear you already had a regex compiler, but I > suppose I should have known :-) I wonder if we can port it back to > Joni and finish it...regex compilation has been on our want list for a > long time. > > I understand what you mean about stripping stuff out. We have to use > Joni almost as-is because of the complexities of Ruby regex and > encoding logic, but there's not much need for you to do the same. > Sharing in the long term will probably be difficult. > > I'm also really excited to hear that you will try to JEP this into > OpenJDK as the new regex backend. Have you been in contact with the > author of Joni, Marcin Mielzinsky? He would be very proud to know this > is in process, and obviously he deserves pretty much all the credit > for making this thing happen. > > - Charlie > > On Wed, May 1, 2013 at 5:50 PM, Hannes Wallnoefer > wrote: >> Hi Charlie, >> >> I feel a bit guilty for not getting (or keeping) in touch with you about >> this. We recently switched to Joni as our default regexp engine and it's >> working pretty well. >> >> What we have in Nashorn now is still relatively close to the JRuby codebase. >> Both share the same package structure, classes, and methods. Our code is >> just simpler because it doesn't have to deal with different encodings. My >> github fork contains a "noencoding" branch that represents the connection >> between the two: >> >> https://github.com/hns/joni/tree/noencoding >> >> However, there are some forces that might force us to drift further apart. >> One of them is code coverage. As it is, JavaScript uses a rather limited >> subset of what Joni provides, and this means a lot of code is neither used >> nor tested. Maintaining these bits doesn't seem to make sense (as far as >> Nashorn is concerned). >> >> It's a similar story with coding standards. We ran FindBugs over Joni and it >> found a number of issues, including things like public final arrays. Fixing >> these could require us to change the package structure or make other >> structural changes. Not to mention missing Javadocs and obscure naming, >> which would also drive us apart when fixed on our side. >> >> As Jim said I also worked on ASM bytecode generation and got quite far with >> it except for some combinations of nested quantifiers and captures I >> couldn't figure out. I've suspended the work for the time being since it's >> not the highest priority thing to do, but here's the patch: >> >> http://cr.openjdk.java.net/~hannesw/8012269/ >> >> I definitely think it would be a great idea to keep our versions of Joni >> connected and evolving together. Right now this would still be relatively >> easy, but it will become harder as time goes by. >> >> Hannes >> >> >> Am 2013-05-01 22:10, schrieb Charles Oliver Nutter: >> >>> Hello! >>> >>> I saw a few weeks back that you guys have adopted JRuby's regex >>> engine, JOni, modified to work only with Java's char[]. We're thrilled >>> that you've found our engine useful enough to incorporate! >>> >>> However, I'm wondering about the future of these engines. We have >>> planned improvements, patches that come in from time to time, and so >>> on, and maintaining two separate copies will eventually lead to them >>> diverging. But without any way to specialize our byte[]-based JOni for >>> char[] easily, I'm not sure what can be done. >>> >>> Any thoughts on this? Just to tempt you... a few of the planned >>> improvements: >>> >>> * JVM bytecode compiler, for more fastness >>> * Thread interruptible execution, to kill off regex runs that don't >>> complete >>> >>> It would be great if we could collaborate on such things. >>> >>> - Charlie >> From marcus.lagergren at oracle.com Fri May 10 00:17:52 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Fri, 10 May 2013 09:17:52 +0200 Subject: Review request for JDK-8014329 Message-ID: <4C57A92B-910A-435D-8F97-16113C83753E@oracle.com> Please review JDK-8014329 at http://cr.openjdk.java.net/~lagergren/8014329/webrev.00 Thanks, Attila. From attila.szegedi at oracle.com Fri May 10 00:23:54 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Fri, 10 May 2013 09:23:54 +0200 Subject: Review request for JDK-8014329 In-Reply-To: <4C57A92B-910A-435D-8F97-16113C83753E@oracle.com> References: <4C57A92B-910A-435D-8F97-16113C83753E@oracle.com> Message-ID: <0C2C7522-931F-4F36-8247-C8A948A5D158@oracle.com> +1 On May 10, 2013, at 9:17 AM, Marcus Lagergren wrote: > Please review JDK-8014329 at http://cr.openjdk.java.net/~lagergren/8014329/webrev.00 > > Thanks, > Attila. From james.laskey at oracle.com Fri May 10 04:02:57 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Fri, 10 May 2013 08:02:57 -0300 Subject: Review request for JDK-8014329 In-Reply-To: <4C57A92B-910A-435D-8F97-16113C83753E@oracle.com> References: <4C57A92B-910A-435D-8F97-16113C83753E@oracle.com> Message-ID: <1F09EA15-046F-4C23-8AA0-C1F5F992E141@oracle.com> +1 On 2013-05-10, at 4:17 AM, Marcus Lagergren wrote: > Please review JDK-8014329 at http://cr.openjdk.java.net/~lagergren/8014329/webrev.00 > > Thanks, > Attila. From marcus.lagergren at oracle.com Fri May 10 04:16:54 2013 From: marcus.lagergren at oracle.com (marcus.lagergren at oracle.com) Date: Fri, 10 May 2013 11:16:54 +0000 Subject: hg: nashorn/jdk8/nashorn: 8014329: Slim down the label stack structure in CodeGenerator Message-ID: <20130510111656.8798A489A8@hg.openjdk.java.net> Changeset: 9073bcc4307b Author: lagergren Date: 2013-05-10 13:16 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/9073bcc4307b 8014329: Slim down the label stack structure in CodeGenerator Reviewed-by: attila, jlaskey ! .hgignore ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/codegen/Compiler.java ! src/jdk/nashorn/internal/codegen/Label.java ! src/jdk/nashorn/internal/codegen/MethodEmitter.java ! src/jdk/nashorn/internal/ir/BlockLexicalContext.java From frank.westlake at gmail.com Mon May 13 05:01:14 2013 From: frank.westlake at gmail.com (frank.westlake at gmail.com) Date: Mon, 13 May 2013 12:01:14 +0000 Subject: Packages Message-ID: <13e9e5d1b83$frank.westlake@gmail.com> If Nashorn doesn't already have this ability please consider making 'Packages' configurable -- perhaps by a system property. My hope is that I can add 'android' to the list so that I can use it without it being prefixed with 'Packages'. For example: // In the host application: java.lang.System.setProperty(keyAdditionalPackages, "android, js"); // In the script: var x=android.content.Intent.ACTION_SCREEN_OFF; In the past I have done the following, but it produced conflicts so I have abandoned it: // In the script: const android=Packages.android; var x=android.content.Intent.ACTION_SCREEN_OFF; // Conflicts with: // var y=Packages.android.content.Intent.ACTION_SCREEN_ON; I apologize if this is already available -- I am not a programmer. Frank From sundararajan.athijegannathan at oracle.com Mon May 13 08:11:25 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Mon, 13 May 2013 20:41:25 +0530 Subject: Packages In-Reply-To: <13e9e5d1b83$frank.westlake@gmail.com> References: <13e9e5d1b83$frank.westlake@gmail.com> Message-ID: <5191029D.5090609@oracle.com> Hi const android = Packages.android does not work with nashorn. But the following should work: var android = Packages.android You can still use "Packages.android" after defining the above. Not sure of the "conflict" that you mention. -Sundar On Monday 13 May 2013 05:31 PM, frank.westlake at gmail.com wrote: > If Nashorn doesn't already have this ability please consider making > 'Packages' configurable -- perhaps by a system property. My hope is > that I can add 'android' to the list so that I can use it without it > being prefixed with 'Packages'. For example: > > // In the host application: > java.lang.System.setProperty(keyAdditionalPackages, "android, js"); > > // In the script: > var x=android.content.Intent.ACTION_SCREEN_OFF; > > In the past I have done the following, but it produced conflicts so I > have abandoned it: > > // In the script: > const android=Packages.android; > var x=android.content.Intent.ACTION_SCREEN_OFF; > > // Conflicts with: > // var y=Packages.android.content.Intent.ACTION_SCREEN_ON; > > I apologize if this is already available -- I am not a programmer. > > Frank From james.laskey at oracle.com Mon May 13 08:26:17 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Mon, 13 May 2013 12:26:17 -0300 Subject: Packages In-Reply-To: <5191029D.5090609@oracle.com> References: <13e9e5d1b83$frank.westlake@gmail.com> <5191029D.5090609@oracle.com> Message-ID: You can also use the none package style; var Intent = Java.type("android.content.Intent"); var x = Intent.ACTION_SCREEN_OFF; Just make sure the Android jar is in your class path. -- Jim On 2013-05-13, at 12:11 PM, "A. Sundararajan" wrote: > Hi > > const android = Packages.android > > does not work with nashorn. But the following should work: > > var android = Packages.android > > You can still use "Packages.android" after defining the above. Not sure of the "conflict" that you mention. > > -Sundar > > On Monday 13 May 2013 05:31 PM, frank.westlake at gmail.com wrote: >> If Nashorn doesn't already have this ability please consider making 'Packages' configurable -- perhaps by a system property. My hope is that I can add 'android' to the list so that I can use it without it being prefixed with 'Packages'. For example: >> >> // In the host application: >> java.lang.System.setProperty(keyAdditionalPackages, "android, js"); >> >> // In the script: >> var x=android.content.Intent.ACTION_SCREEN_OFF; >> >> In the past I have done the following, but it produced conflicts so I have abandoned it: >> >> // In the script: >> const android=Packages.android; >> var x=android.content.Intent.ACTION_SCREEN_OFF; >> >> // Conflicts with: >> // var y=Packages.android.content.Intent.ACTION_SCREEN_ON; >> >> I apologize if this is already available -- I am not a programmer. >> >> Frank > From frank.westlake at gmail.com Mon May 13 08:39:34 2013 From: frank.westlake at gmail.com (frank.westlake at gmail.com) Date: Mon, 13 May 2013 15:39:34 +0000 Subject: Packages Message-ID: <13e9e91f8cc$frank.westlake@gmail.com> My apologies: I hit "reply" and it did not go to the list, so this is a duplicate of the private reply. >From "A. Sundararajan" : >Hi > const android = Packages.android >does not work with nashorn. But the following should >work: > var android = Packages.android >You can still use "Packages.android" after defining the >above. Not sure of the "conflict" that you mention. Thanks. My experience was with Rhino. I can't build Nashorn and no jar is available yet so I only assumed that it is the same. Frank From attila.szegedi at oracle.com Tue May 14 03:26:15 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Tue, 14 May 2013 12:26:15 +0200 Subject: Review request for JDK-8014492 Message-ID: <91496822-F484-4114-A242-89AE9E6D6DE0@oracle.com> Please review JDK-8014492 at http://cr.openjdk.java.net/~attila/8014492/webrev.00 Thanks, Attila. From attila.szegedi at oracle.com Tue May 14 03:27:18 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Tue, 14 May 2013 12:27:18 +0200 Subject: Review request for JDK-8014492 Message-ID: <1C5E6F5E-D025-4FAF-84AB-8D9B7199BA2B@oracle.com> Please review JDK-8014492 at http://cr.openjdk.java.net/~attila/8014492/webrev.00 Thanks, Attila. From marcus.lagergren at oracle.com Tue May 14 03:27:42 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Tue, 14 May 2013 12:27:42 +0200 Subject: Please review JDK-8014426 - synthetic rethrows in finallies Message-ID: <57123255-E6FC-4388-B4EA-C0C07FCC6D04@oracle.com> Fairly simple bug fix with test case attached. Finally catch blocks (synthetic rethrowers) should not unwrap the exception object. Nor should the rethrow at their ends wrap it. http://cr.openjdk.java.net/~lagergren/8014426/webrev/ /M From hannes.wallnoefer at oracle.com Tue May 14 03:31:54 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Tue, 14 May 2013 12:31:54 +0200 Subject: Review request for JDK-8014492 In-Reply-To: <1C5E6F5E-D025-4FAF-84AB-8D9B7199BA2B@oracle.com> References: <1C5E6F5E-D025-4FAF-84AB-8D9B7199BA2B@oracle.com> Message-ID: <5192129A.2040102@oracle.com> +1 Am 2013-05-14 12:27, schrieb Attila Szegedi: > Please review JDK-8014492 at http://cr.openjdk.java.net/~attila/8014492/webrev.00 > > Thanks, > Attila. From james.laskey at oracle.com Tue May 14 03:37:03 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Tue, 14 May 2013 07:37:03 -0300 Subject: Review request for JDK-8014492 In-Reply-To: <1C5E6F5E-D025-4FAF-84AB-8D9B7199BA2B@oracle.com> References: <1C5E6F5E-D025-4FAF-84AB-8D9B7199BA2B@oracle.com> Message-ID: <2510C309-9641-434F-8606-E287D82B2784@oracle.com> +1 On 2013-05-14, at 7:27 AM, Attila Szegedi wrote: > Please review JDK-8014492 at http://cr.openjdk.java.net/~attila/8014492/webrev.00 > > Thanks, > Attila. From attila.szegedi at oracle.com Tue May 14 03:39:26 2013 From: attila.szegedi at oracle.com (attila.szegedi at oracle.com) Date: Tue, 14 May 2013 10:39:26 +0000 Subject: hg: nashorn/jdk8/nashorn: 8014492: Make NashornLinker public Message-ID: <20130514103929.5F44A48A54@hg.openjdk.java.net> Changeset: 098a4cedcaf2 Author: attila Date: 2013-05-14 12:39 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/098a4cedcaf2 8014492: Make NashornLinker public Reviewed-by: hannesw, jlaskey ! src/jdk/nashorn/internal/runtime/linker/NashornLinker.java From james.laskey at oracle.com Tue May 14 03:47:28 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Tue, 14 May 2013 07:47:28 -0300 Subject: Please review JDK-8014426 - synthetic rethrows in finallies In-Reply-To: <57123255-E6FC-4388-B4EA-C0C07FCC6D04@oracle.com> References: <57123255-E6FC-4388-B4EA-C0C07FCC6D04@oracle.com> Message-ID: <71AA2CA5-2757-43B0-9CD3-088F5CDFC361@oracle.com> +1 On 2013-05-14, at 7:27 AM, Marcus Lagergren wrote: > Fairly simple bug fix with test case attached. Finally catch blocks (synthetic rethrowers) should not unwrap the exception object. Nor should the rethrow at their ends wrap it. > > http://cr.openjdk.java.net/~lagergren/8014426/webrev/ > > /M > > From hannes.wallnoefer at oracle.com Tue May 14 03:53:40 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Tue, 14 May 2013 12:53:40 +0200 Subject: Please review JDK-8014426 - synthetic rethrows in finallies In-Reply-To: <57123255-E6FC-4388-B4EA-C0C07FCC6D04@oracle.com> References: <57123255-E6FC-4388-B4EA-C0C07FCC6D04@oracle.com> Message-ID: <519217B4.7020500@oracle.com> Looks good, +1 Am 2013-05-14 12:27, schrieb Marcus Lagergren: > Fairly simple bug fix with test case attached. Finally catch blocks (synthetic rethrowers) should not unwrap the exception object. Nor should the rethrow at their ends wrap it. > > http://cr.openjdk.java.net/~lagergren/8014426/webrev/ > > /M > > From hannes.wallnoefer at oracle.com Tue May 14 04:15:51 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Tue, 14 May 2013 13:15:51 +0200 Subject: Review request for JDK-8012359 - Increase code coverage in Joni Message-ID: <51921CE7.9030609@oracle.com> Please review JDK-8012359 - Increase code coverage in Joni: http://cr.openjdk.java.net/~hannesw/8012359/ This removes most code we do not use in Joni, including regexp features not used in ECMAScript, alternative implementations of features, and things left over from multibyte encoding support. I tested with ant test and test262, currently running Node tests. Hannes From james.laskey at oracle.com Tue May 14 04:47:24 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Tue, 14 May 2013 08:47:24 -0300 Subject: Review request for JDK-8012359 - Increase code coverage in Joni In-Reply-To: <51921CE7.9030609@oracle.com> References: <51921CE7.9030609@oracle.com> Message-ID: +1 On 2013-05-14, at 8:15 AM, Hannes Wallnoefer wrote: > Please review JDK-8012359 - Increase code coverage in Joni: > > http://cr.openjdk.java.net/~hannesw/8012359/ > > This removes most code we do not use in Joni, including regexp features not used in ECMAScript, alternative implementations of features, and things left over from multibyte encoding support. > > I tested with ant test and test262, currently running Node tests. > > Hannes From james.laskey at oracle.com Tue May 14 05:07:04 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Tue, 14 May 2013 12:07:04 +0000 Subject: hg: nashorn/jdk8: 12 new changesets Message-ID: <20130514120706.20A4848A58@hg.openjdk.java.net> Changeset: c29b583938b1 Author: katleman Date: 2013-04-25 09:23 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/c29b583938b1 Added tag jdk8-b87 for changeset b9415faa7066 ! .hgtags Changeset: 1603c9216e83 Author: lana Date: 2013-04-30 17:41 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/1603c9216e83 Merge Changeset: e2eb6bc06621 Author: mduigou Date: 2013-05-08 21:42 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/e2eb6bc06621 8014269: Add missing .PHONY targets to Main.gmk Reviewed-by: mchung, tbell ! common/makefiles/Main.gmk Changeset: 1dfcc874461e Author: omajid Date: 2013-04-29 12:34 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/1dfcc874461e 8013480: fix zero build on arm Reviewed-by: erikj ! common/autoconf/generated-configure.sh ! common/autoconf/platform.m4 ! common/autoconf/spec.gmk.in Changeset: 7e7582e961ba Author: jwilhelm Date: 2013-04-25 16:00 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/7e7582e961ba 7074926: create Solaris Studio IDE (Netbeans) project for hotspot sources Summary: Project files for hotspot delevopment in Solaris Studio and NetBeans. Also reviewed by vladimir.voskresensky at oracle.com Reviewed-by: erikj, dsamersoff + common/nb_native/nbproject/configurations.xml + common/nb_native/nbproject/project.xml Changeset: b9bf111a9547 Author: katleman Date: 2013-04-30 14:39 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/b9bf111a9547 Merge Changeset: e404d321abc6 Author: erikj Date: 2013-05-02 15:46 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/e404d321abc6 8013786: JDK-8013480 broke configure on solaris Reviewed-by: tbell ! common/autoconf/configure.ac ! common/autoconf/generated-configure.sh ! common/autoconf/platform.m4 ! common/autoconf/toolchain.m4 Changeset: e1a929afcfc4 Author: erikj Date: 2013-05-02 15:56 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/e1a929afcfc4 8011687: Support correct dependencies from header files on windows and solaris Reviewed-by: tbell ! common/autoconf/generated-configure.sh ! common/autoconf/spec.gmk.in ! common/autoconf/toolchain.m4 ! common/makefiles/NativeCompilation.gmk Changeset: 8fb91165e596 Author: katleman Date: 2013-05-02 13:34 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/8fb91165e596 Added tag jdk8-b88 for changeset e1a929afcfc4 ! .hgtags Changeset: 892a0196d10c Author: lana Date: 2013-05-06 11:41 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/892a0196d10c Merge ! common/makefiles/NativeCompilation.gmk Changeset: 49ea9293fa49 Author: lana Date: 2013-05-09 14:23 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/49ea9293fa49 Merge Changeset: 1fca390200c1 Author: jlaskey Date: 2013-05-14 09:04 -0300 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/1fca390200c1 Merge ! common/autoconf/generated-configure.sh ! common/autoconf/spec.gmk.in ! common/makefiles/Main.gmk From james.laskey at oracle.com Tue May 14 05:07:11 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Tue, 14 May 2013 12:07:11 +0000 Subject: hg: nashorn/jdk8/corba: 4 new changesets Message-ID: <20130514120715.3DBFC48A59@hg.openjdk.java.net> Changeset: 4e3a881ebb1e Author: katleman Date: 2013-04-25 09:23 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/corba/rev/4e3a881ebb1e Added tag jdk8-b87 for changeset f1709874d55a ! .hgtags Changeset: ed59110eecdb Author: lana Date: 2013-04-30 17:41 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/corba/rev/ed59110eecdb Merge Changeset: 1f13a798d1b8 Author: katleman Date: 2013-05-02 13:34 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/corba/rev/1f13a798d1b8 Added tag jdk8-b88 for changeset 4e3a881ebb1e ! .hgtags Changeset: fe4150590ee5 Author: lana Date: 2013-05-06 11:41 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/corba/rev/fe4150590ee5 Merge From james.laskey at oracle.com Tue May 14 05:08:20 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Tue, 14 May 2013 12:08:20 +0000 Subject: hg: nashorn/jdk8/hotspot: 118 new changesets Message-ID: <20130514121221.7049648A5A@hg.openjdk.java.net> Changeset: d080f5168deb Author: katleman Date: 2013-04-25 09:24 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/d080f5168deb Added tag jdk8-b87 for changeset d4c266784660 ! .hgtags Changeset: c60f69931e1a Author: amurillo Date: 2013-04-11 21:54 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/c60f69931e1a 8011949: new hotspot build - hs25-b29 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 35f8765422b9 Author: zgu Date: 2013-04-10 08:55 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/35f8765422b9 8010151: nsk/regression/b6653214 fails "assert(snapshot != NULL) failed: Worker should not be started" Summary: Fixed a racing condition when shutting down NMT while worker thread is being started, also fixed a few mis-declared volatile pointers. Reviewed-by: dholmes, dlong ! src/share/vm/runtime/thread.hpp ! src/share/vm/services/memTrackWorker.cpp ! src/share/vm/services/memTrackWorker.hpp ! src/share/vm/services/memTracker.cpp ! src/share/vm/services/memTracker.hpp Changeset: f2c0ccccc6b6 Author: rdurbin Date: 2013-04-16 08:59 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/f2c0ccccc6b6 Merge Changeset: 71013d764f6e Author: johnc Date: 2013-04-10 10:57 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/71013d764f6e 8010780: G1: Eden occupancy/capacity output wrong after a full GC Summary: Move the calculation and recording of eden capacity to the start of a GC and print a detailed heap transition for full GCs. Reviewed-by: tschatzl, jmasa ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp Changeset: c0000f77bc6d Author: johnc Date: 2013-04-11 10:20 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/c0000f77bc6d Merge ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp Changeset: 9aa8d8037ee3 Author: mgerdin Date: 2013-04-16 12:46 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/9aa8d8037ee3 Merge ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp Changeset: df254344edf1 Author: jmasa Date: 2013-04-01 10:50 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/df254344edf1 8011173: NPG: Replace the ChunkList implementation with class FreeList Reviewed-by: mgerdin, tschatzl, johnc, coleenp ! src/share/vm/memory/metaspace.cpp Changeset: f2e682ef3156 Author: johnc Date: 2013-04-17 10:57 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/f2e682ef3156 8012335: G1: Fix bug with compressed oops in template interpreter on x86 and sparc. Summary: In do_oop_store the uncompressed value of the oop being stored needs to be preserved and passed to g1_write_barrier_post. This is necessary for the heap region cross check to work correctly. Reviewed-by: coleenp, johnc Contributed-by: Martin Doerr ! src/cpu/sparc/vm/templateTable_sparc.cpp ! src/cpu/x86/vm/templateTable_x86_64.cpp Changeset: 07a4efc5ed14 Author: brutisso Date: 2013-04-18 06:50 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/07a4efc5ed14 8012455: Missing time and date stamps for PrintGCApplicationConcurrentTime and PrintGCApplicationStoppedTime Summary: also reviewed by: kirk at kodewerk.com, brandon at twitter.com Reviewed-by: tschatzl, stefank, johnc ! src/share/vm/services/runtimeService.cpp Changeset: cbf8c8c25bbe Author: mgerdin Date: 2013-04-18 14:38 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/cbf8c8c25bbe Merge Changeset: aeaca88565e6 Author: jiangli Date: 2013-04-09 17:17 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/aeaca88565e6 8010862: The Method counter fields used for profiling can be allocated lazily. Summary: Allocate the method's profiling related metadata until they are needed. Reviewed-by: coleenp, roland ! agent/src/share/classes/sun/jvm/hotspot/oops/Method.java + agent/src/share/classes/sun/jvm/hotspot/oops/MethodCounters.java ! src/cpu/sparc/vm/cppInterpreter_sparc.cpp ! src/cpu/sparc/vm/interp_masm_sparc.cpp ! src/cpu/sparc/vm/interp_masm_sparc.hpp ! src/cpu/sparc/vm/templateInterpreter_sparc.cpp ! src/cpu/sparc/vm/templateTable_sparc.cpp ! src/cpu/x86/vm/cppInterpreter_x86.cpp ! src/cpu/x86/vm/interp_masm_x86_32.cpp ! src/cpu/x86/vm/interp_masm_x86_32.hpp ! src/cpu/x86/vm/interp_masm_x86_64.cpp ! src/cpu/x86/vm/interp_masm_x86_64.hpp ! src/cpu/x86/vm/templateInterpreter_x86_32.cpp ! src/cpu/x86/vm/templateInterpreter_x86_64.cpp ! src/cpu/x86/vm/templateTable_x86_32.cpp ! src/cpu/x86/vm/templateTable_x86_64.cpp ! src/share/vm/c1/c1_LIRGenerator.cpp ! src/share/vm/ci/ciMethod.cpp ! src/share/vm/ci/ciMethod.hpp ! src/share/vm/ci/ciReplay.cpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/interpreter/interpreterRuntime.hpp ! src/share/vm/interpreter/invocationCounter.cpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/method.hpp + src/share/vm/oops/methodCounters.cpp + src/share/vm/oops/methodCounters.hpp ! src/share/vm/oops/methodData.cpp ! src/share/vm/opto/parseHelper.cpp ! src/share/vm/runtime/advancedThresholdPolicy.cpp ! src/share/vm/runtime/compilationPolicy.cpp ! src/share/vm/runtime/fprofiler.cpp ! src/share/vm/runtime/simpleThresholdPolicy.cpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 42a42da29fd7 Author: jiangli Date: 2013-04-11 23:06 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/42a42da29fd7 8012052: java/lang/invoke/6987555/Test6987555.java crashes with assert(mcs != NULL) failed: MethodCounters cannot be NULL. Summary: Skip counter decay if the MethodCounters is NULL in NonTieredCompPolicy::delay_compilation(). Reviewed-by: kvn, dholmes ! src/share/vm/runtime/compilationPolicy.cpp Changeset: 8df6ddda8090 Author: jiangli Date: 2013-04-15 21:25 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/8df6ddda8090 Merge ! src/share/vm/c1/c1_LIRGenerator.cpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/oops/method.hpp ! src/share/vm/oops/methodData.cpp ! src/share/vm/prims/whitebox.cpp ! src/share/vm/runtime/compilationPolicy.cpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 9500809ceead Author: jiangli Date: 2013-04-18 17:00 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/9500809ceead Merge ! src/cpu/sparc/vm/templateTable_sparc.cpp ! src/cpu/x86/vm/templateTable_x86_64.cpp Changeset: b8b081e53312 Author: twisti Date: 2013-04-12 12:22 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/b8b081e53312 8011933: add number of classes, methods and time spent to CompileTheWorld Reviewed-by: jrose, kvn ! src/share/vm/classfile/classLoader.cpp ! src/share/vm/classfile/classLoader.hpp Changeset: 393fd4ef89c4 Author: twisti Date: 2013-04-12 15:43 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/393fd4ef89c4 8011678: test/Makefile should pick up JT_HOME environment variable Reviewed-by: kvn ! test/Makefile Changeset: f36e073d56a4 Author: drchase Date: 2013-04-12 15:53 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/f36e073d56a4 7104565: trim jprt build targets Summary: remove JPRT debug builds, remove -DDEBUG -DFASTDEBUG and use ASSERT instead in sources Reviewed-by: dholmes, kvn, coleenp ! make/Makefile ! make/bsd/Makefile ! make/bsd/makefiles/buildtree.make ! make/bsd/makefiles/debug.make ! make/bsd/makefiles/defs.make ! make/bsd/makefiles/fastdebug.make - make/bsd/makefiles/jvmg.make - make/bsd/makefiles/profiled.make ! make/jprt.properties ! make/linux/Makefile ! make/linux/makefiles/buildtree.make ! make/linux/makefiles/debug.make ! make/linux/makefiles/defs.make ! make/linux/makefiles/fastdebug.make - make/linux/makefiles/jvmg.make - make/linux/makefiles/profiled.make ! make/solaris/Makefile ! make/solaris/makefiles/buildtree.make ! make/solaris/makefiles/debug.make ! make/solaris/makefiles/defs.make ! make/solaris/makefiles/fastdebug.make - make/solaris/makefiles/jvmg.make - make/solaris/makefiles/profiled.make ! make/windows/build.make ! make/windows/makefiles/defs.make ! make/windows/makefiles/vm.make ! make/windows/projectfiles/compiler2/ADLCompiler.dsp ! make/windows/projectfiles/tiered/ADLCompiler.dsp ! src/cpu/sparc/vm/frame_sparc.cpp ! src/os/bsd/dtrace/generateJvmOffsets.cpp ! src/os/solaris/dtrace/generateJvmOffsets.cpp ! src/os/windows/vm/os_windows.cpp ! src/share/tools/hsdis/Makefile ! src/share/vm/classfile/stackMapFrame.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/memory/allocation.hpp ! src/share/vm/runtime/vmThread.cpp Changeset: bc63dd2539a4 Author: kvn Date: 2013-04-12 20:37 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/bc63dd2539a4 Merge ! make/bsd/makefiles/debug.make - make/bsd/makefiles/jvmg.make - make/bsd/makefiles/profiled.make ! make/linux/makefiles/debug.make - make/linux/makefiles/jvmg.make - make/linux/makefiles/profiled.make ! make/solaris/makefiles/debug.make - make/solaris/makefiles/jvmg.make - make/solaris/makefiles/profiled.make Changeset: 886d1fd67dc3 Author: drchase Date: 2013-04-12 19:14 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/886d1fd67dc3 6443505: Ideal() function for CmpLTMask Summary: Repair wrong code generation, added new matching rule Reviewed-by: kvn, twisti ! src/cpu/sparc/vm/sparc.ad ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/share/vm/opto/cfgnode.cpp + test/compiler/6443505/Test6443505.java Changeset: bb4a966cc68f Author: roland Date: 2013-04-15 09:42 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/bb4a966cc68f 8011582: assert(nbits == 32 || (-(1 << nbits-1) <= x && x < ( 1 << nbits-1))) failed: value out of range Summary: c1 runtime's predicate_failed_trap should use jump_to on sparc Reviewed-by: kvn ! src/cpu/sparc/vm/c1_Runtime1_sparc.cpp Changeset: 1c6887c9afaa Author: twisti Date: 2013-04-15 16:20 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/1c6887c9afaa 7172922: export_ makefile targets do not work unless all supported variants are built Reviewed-by: dholmes, kvn ! make/Makefile Changeset: acadb114c818 Author: roland Date: 2013-04-15 17:17 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/acadb114c818 8011648: C1: optimized build is broken after 7153771 Summary: missing #ifdef ASSERT Reviewed-by: kvn ! src/share/vm/c1/c1_Canonicalizer.cpp ! src/share/vm/c1/c1_Canonicalizer.hpp ! src/share/vm/c1/c1_Instruction.hpp ! src/share/vm/c1/c1_InstructionPrinter.cpp ! src/share/vm/c1/c1_InstructionPrinter.hpp ! src/share/vm/c1/c1_LIR.cpp ! src/share/vm/c1/c1_LIR.hpp ! src/share/vm/c1/c1_LIRGenerator.cpp ! src/share/vm/c1/c1_LIRGenerator.hpp ! src/share/vm/c1/c1_Optimizer.cpp ! src/share/vm/c1/c1_RangeCheckElimination.hpp ! src/share/vm/c1/c1_ValueMap.hpp Changeset: b105029fdbfd Author: roland Date: 2013-04-15 18:42 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/b105029fdbfd Merge Changeset: 8373c19be854 Author: neliasso Date: 2013-04-16 10:08 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/8373c19be854 8011621: live_ranges_in_separate_class.patch Reviewed-by: kvn, roland Contributed-by: niclas.adlertz at oracle.com ! make/bsd/makefiles/vm.make ! make/linux/makefiles/vm.make ! make/solaris/makefiles/vm.make ! make/windows/create_obj_files.sh - src/os/bsd/vm/chaitin_bsd.cpp - src/os/linux/vm/chaitin_linux.cpp - src/os/solaris/vm/chaitin_solaris.cpp - src/os/windows/vm/chaitin_windows.cpp ! src/share/vm/opto/chaitin.cpp ! src/share/vm/opto/chaitin.hpp ! src/share/vm/opto/coalesce.cpp ! src/share/vm/opto/coalesce.hpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/idealGraphPrinter.cpp ! src/share/vm/opto/ifg.cpp ! src/share/vm/opto/live.cpp ! src/share/vm/opto/live.hpp ! src/share/vm/opto/postaloc.cpp ! src/share/vm/opto/reg_split.cpp ! src/share/vm/opto/regalloc.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: c89eab0b6b30 Author: neliasso Date: 2013-04-16 10:37 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/c89eab0b6b30 Merge - src/os/bsd/vm/chaitin_bsd.cpp - src/os/linux/vm/chaitin_linux.cpp - src/os/solaris/vm/chaitin_solaris.cpp - src/os/windows/vm/chaitin_windows.cpp Changeset: 4b2eebe03f93 Author: iignatyev Date: 2013-04-16 10:04 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/4b2eebe03f93 8011971: WB API doesn't accept j.l.reflect.Constructor Reviewed-by: kvn, vlivanov ! src/share/vm/prims/whitebox.cpp ! test/compiler/whitebox/ClearMethodStateTest.java ! test/compiler/whitebox/CompilerWhiteBoxTest.java ! test/compiler/whitebox/DeoptimizeAllTest.java ! test/compiler/whitebox/DeoptimizeMethodTest.java ! test/compiler/whitebox/EnqueueMethodForCompilationTest.java ! test/compiler/whitebox/IsMethodCompilableTest.java ! test/compiler/whitebox/MakeMethodNotCompilableTest.java ! test/compiler/whitebox/SetDontInlineMethodTest.java ! test/compiler/whitebox/SetForceInlineMethodTest.java ! test/testlibrary/whitebox/sun/hotspot/WhiteBox.java Changeset: a7fb14888912 Author: neliasso Date: 2013-04-11 13:57 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/a7fb14888912 8006952: Slow VM due to excessive code cache freelist iteration Summary: Remove continous free block requirement Reviewed-by: kvn ! src/share/vm/code/codeBlob.cpp ! src/share/vm/code/codeCache.cpp ! src/share/vm/code/codeCache.hpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/memory/heap.cpp ! src/share/vm/memory/heap.hpp ! src/share/vm/opto/output.cpp Changeset: dedc8563e33d Author: bharadwaj Date: 2013-04-18 16:04 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/dedc8563e33d Merge - make/bsd/makefiles/jvmg.make - make/bsd/makefiles/profiled.make - make/linux/makefiles/jvmg.make - make/linux/makefiles/profiled.make - make/solaris/makefiles/jvmg.make - make/solaris/makefiles/profiled.make - src/os/bsd/vm/chaitin_bsd.cpp - src/os/linux/vm/chaitin_linux.cpp - src/os/solaris/vm/chaitin_solaris.cpp - src/os/windows/vm/chaitin_windows.cpp Changeset: 2a9d97b57920 Author: bharadwaj Date: 2013-04-19 03:13 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/2a9d97b57920 Merge - make/bsd/makefiles/jvmg.make - make/bsd/makefiles/profiled.make - make/linux/makefiles/jvmg.make - make/linux/makefiles/profiled.make - make/solaris/makefiles/jvmg.make - make/solaris/makefiles/profiled.make - src/os/bsd/vm/chaitin_bsd.cpp - src/os/linux/vm/chaitin_linux.cpp - src/os/solaris/vm/chaitin_solaris.cpp - src/os/windows/vm/chaitin_windows.cpp ! src/share/vm/c1/c1_LIRGenerator.cpp ! src/share/vm/prims/whitebox.cpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 01d5f04e64dc Author: amurillo Date: 2013-04-19 09:58 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/01d5f04e64dc Merge ! make/bsd/makefiles/fastdebug.make - make/bsd/makefiles/jvmg.make - make/bsd/makefiles/profiled.make - make/linux/makefiles/jvmg.make - make/linux/makefiles/profiled.make - make/solaris/makefiles/jvmg.make - make/solaris/makefiles/profiled.make - src/os/bsd/vm/chaitin_bsd.cpp - src/os/linux/vm/chaitin_linux.cpp - src/os/solaris/vm/chaitin_solaris.cpp - src/os/windows/vm/chaitin_windows.cpp ! test/testlibrary/whitebox/sun/hotspot/WhiteBox.java Changeset: 0491c26b1f1d Author: amurillo Date: 2013-04-19 09:58 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/0491c26b1f1d Added tag hs25-b29 for changeset 01d5f04e64dc ! .hgtags Changeset: f78763f49817 Author: amurillo Date: 2013-04-19 10:09 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/f78763f49817 8012559: new hotspot build - hs25-b30 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 63e31ce40bdb Author: hseigel Date: 2013-04-17 08:20 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/63e31ce40bdb 8009928: PSR:PERF Increase default string table size Summary: Increase default string table size to 60013 for 64-bit platforms. Reviewed-by: coleenp, dholmes ! src/share/vm/runtime/arguments.cpp ! src/share/vm/utilities/globalDefinitions.hpp Changeset: b80cc96882f7 Author: zgu Date: 2013-04-18 10:04 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/b80cc96882f7 8012464: NMT: classes should not derive from _ValueObj, use VALUE_OBJ_CLASS_SPEC instead Summary: NMT value objects should use VALUE_OBJ_CLASS_SPEC instead of deriving from _ValueObj Reviewed-by: coleenp, hseigel, dholmes ! src/share/vm/services/memBaseline.hpp ! src/share/vm/services/memPtr.hpp ! src/share/vm/services/memSnapshot.hpp ! src/share/vm/services/memTrackWorker.hpp Changeset: 41ed397cc0cd Author: bharadwaj Date: 2013-04-18 08:05 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/41ed397cc0cd 8006267: InterfaceMethod_ref should allow invokestatic and invokespecial Summary: Lambda changes; spec 0.6.2 - Allow static invokestatic and invokespecial calls to InterfaceMethod_ref Reviewed-by: dholmes, acorn ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/genericSignatures.cpp ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/prims/methodHandles.cpp Changeset: 7815eaceaa8c Author: bharadwaj Date: 2013-04-18 14:03 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/7815eaceaa8c Merge Changeset: 6f817ce50129 Author: minqi Date: 2013-04-19 11:08 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/6f817ce50129 8010992: Remove calls to global ::operator new[] and new Summary: disable use of global operator new and new[] which could cause unexpected exception and escape from NMT tracking. Reviewed-by: coleenp, dholmes, zgu Contributed-by: yumin.qi at oracle.com ! src/os/windows/vm/os_windows.cpp ! src/share/vm/classfile/altHashing.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsCollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp ! src/share/vm/memory/allocation.cpp ! src/share/vm/memory/allocation.hpp ! src/share/vm/memory/allocation.inline.hpp ! src/share/vm/memory/cardTableModRefBS.cpp ! src/share/vm/memory/cardTableModRefBS.hpp ! src/share/vm/memory/cardTableRS.cpp ! src/share/vm/memory/cardTableRS.hpp ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/opto/idealGraphPrinter.hpp ! src/share/vm/runtime/handles.hpp ! src/share/vm/runtime/reflectionUtils.hpp ! src/share/vm/runtime/synchronizer.cpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/utilities/events.hpp ! src/share/vm/utilities/quickSort.cpp ! src/share/vm/utilities/workgroup.cpp ! src/share/vm/utilities/workgroup.hpp Changeset: 17c51f84773a Author: dcubed Date: 2013-04-19 13:48 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/17c51f84773a Merge Changeset: 5b6512efcdc4 Author: dcubed Date: 2013-04-19 16:51 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/5b6512efcdc4 Merge - make/bsd/makefiles/jvmg.make - make/bsd/makefiles/profiled.make - make/linux/makefiles/jvmg.make - make/linux/makefiles/profiled.make - make/solaris/makefiles/jvmg.make - make/solaris/makefiles/profiled.make - src/os/bsd/vm/chaitin_bsd.cpp - src/os/linux/vm/chaitin_linux.cpp - src/os/solaris/vm/chaitin_solaris.cpp - src/os/windows/vm/chaitin_windows.cpp ! src/os/windows/vm/os_windows.cpp ! src/share/vm/memory/allocation.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 6337ca4dcad8 Author: sspitsyn Date: 2013-04-20 04:07 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/6337ca4dcad8 8008511: JSR 292: MemberName vmtarget refs to methods must be updated at class redefinition Summary: Lazily create and maintain the MemberNameTable to be able to update MemberName's Reviewed-by: coleenp, jrose, dholmes Contributed-by: serguei.spitsyn at oracle.com ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/prims/methodHandles.hpp ! src/share/vm/runtime/mutexLocker.cpp ! src/share/vm/runtime/mutexLocker.hpp Changeset: a527ddd44e07 Author: mgronlun Date: 2013-04-20 19:02 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/a527ddd44e07 6729929: I18N - Taking Heap Dump failed if project path contains multibyte characters Reviewed-by: dholmes, rbackman Contributed-by: peter.allwin at oracle.com ! src/share/vm/services/management.cpp Changeset: 5a9fa2ba85f0 Author: dcubed Date: 2013-04-21 20:41 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/5a9fa2ba85f0 8012907: anti-delta fix for 8010992 Summary: anti-delta fix for 8010992 until 8012902 can be fixed Reviewed-by: acorn, minqi, rdurbin ! src/os/windows/vm/os_windows.cpp ! src/share/vm/classfile/altHashing.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsCollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp ! src/share/vm/memory/allocation.cpp ! src/share/vm/memory/allocation.hpp ! src/share/vm/memory/allocation.inline.hpp ! src/share/vm/memory/cardTableModRefBS.cpp ! src/share/vm/memory/cardTableModRefBS.hpp ! src/share/vm/memory/cardTableRS.cpp ! src/share/vm/memory/cardTableRS.hpp ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/opto/idealGraphPrinter.hpp ! src/share/vm/runtime/handles.hpp ! src/share/vm/runtime/reflectionUtils.hpp ! src/share/vm/runtime/synchronizer.cpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/utilities/events.hpp ! src/share/vm/utilities/quickSort.cpp ! src/share/vm/utilities/workgroup.cpp ! src/share/vm/utilities/workgroup.hpp Changeset: cc12becb22e7 Author: dcubed Date: 2013-04-21 21:05 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/cc12becb22e7 Merge ! src/os/windows/vm/os_windows.cpp ! src/share/vm/memory/allocation.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: ce6d7e43501c Author: bharadwaj Date: 2013-04-23 08:12 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/ce6d7e43501c 8012961: Do not restrict static interface methods to be private Summary: Lambda changes; spec 0.6.2 - remove the restriction that was added as part of recent changes made to support upcoming changes to compilation of lambda methods. Reviewed-by: dholmes, acorn ! src/share/vm/prims/methodHandles.cpp Changeset: 1ea6a35dcbe5 Author: jiangli Date: 2013-04-23 12:32 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/1ea6a35dcbe5 8012927: 'assert(nbits == 32 || (-(1 << nbits-1) <= x && x < ( 1 << nbits-1))) failed: value out of range' in interpreter initialization. Summary: Change br_null_short() to br_null(). Reviewed-by: coleenp, hseigel ! src/cpu/sparc/vm/interp_masm_sparc.cpp Changeset: 35c15dad89ea Author: roland Date: 2013-04-16 17:06 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/35c15dad89ea 8011901: Unsafe.getAndAddLong(obj, off, delta) does not work properly with long deltas Summary: instruct xaddL_no_res shouldn't allow 64 bit constants. Reviewed-by: kvn ! src/cpu/x86/vm/x86_64.ad + test/compiler/8011901/Test8011901.java Changeset: 6a3629cf7075 Author: roland Date: 2013-04-24 09:42 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/6a3629cf7075 8011771: runThese crashed with EAV Summary: Array bound check elimination's in block motion doesn't always reset its data structures from one step to the other. Reviewed-by: kvn, twisti ! src/share/vm/c1/c1_RangeCheckElimination.cpp Changeset: 47766e2d2527 Author: jiangli Date: 2013-04-24 18:20 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/47766e2d2527 8013041: guarantee(this->is8bit(imm8)) failed: Short forward jump exceeds 8-bit offset. Summary: Change jmpb() to jmp(). Reviewed-by: coleenp, rdurbin, dcubed ! src/cpu/x86/vm/templateInterpreter_x86_32.cpp ! src/cpu/x86/vm/templateInterpreter_x86_64.cpp Changeset: e8a7a5995e65 Author: bharadwaj Date: 2013-04-25 13:10 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/e8a7a5995e65 Merge Changeset: c4af77d20454 Author: amurillo Date: 2013-04-26 00:29 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/c4af77d20454 Merge ! .hgtags - make/bsd/makefiles/jvmg.make - make/bsd/makefiles/profiled.make - make/linux/makefiles/jvmg.make - make/linux/makefiles/profiled.make - make/solaris/makefiles/jvmg.make - make/solaris/makefiles/profiled.make - src/os/bsd/vm/chaitin_bsd.cpp - src/os/linux/vm/chaitin_linux.cpp - src/os/solaris/vm/chaitin_solaris.cpp - src/os/windows/vm/chaitin_windows.cpp Changeset: 8482058e74bc Author: amurillo Date: 2013-04-26 00:29 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/8482058e74bc Added tag hs25-b30 for changeset c4af77d20454 ! .hgtags Changeset: d0081bfc425c Author: katleman Date: 2013-05-02 13:35 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/d0081bfc425c Added tag jdk8-b88 for changeset 8482058e74bc ! .hgtags Changeset: 57ac6a688ae6 Author: amurillo Date: 2013-04-26 00:40 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/57ac6a688ae6 8013227: new hotspot build - hs25-b31 Reviewed-by: jcoomes ! make/hotspot_version Changeset: cc70cbbd422e Author: hseigel Date: 2013-04-24 09:00 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/cc70cbbd422e 8012695: Assertion message displays %u and %s text instead of actual values Summary: USe err_msg() to create a proper assertion message. Reviewed-by: twisti, coleenp, iklam ! src/share/vm/classfile/classFileParser.hpp Changeset: fbca7eaeac2e Author: zgu Date: 2013-04-24 14:55 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/fbca7eaeac2e 8011218: Kitchensink hanged, likely NMT is to blame Summary: Made NMT query safepoint aware. Reviewed-by: dholmes, coleenp ! src/share/vm/services/memBaseline.cpp ! src/share/vm/services/memBaseline.hpp ! src/share/vm/services/memTracker.cpp Changeset: d587a5c30bd8 Author: coleenp Date: 2013-04-24 16:19 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/d587a5c30bd8 8011803: release_C_heap_structures is never called for anonymous classes. Summary: Call this function from the ClassLoaderData destructor instead of the system dictionary walk. Reviewed-by: stefank, mgerdin ! src/share/vm/classfile/classLoaderData.cpp ! src/share/vm/classfile/dictionary.cpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp Changeset: d66a24adbe3f Author: coleenp Date: 2013-04-24 15:57 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/d66a24adbe3f Merge Changeset: 15a99ca4ee34 Author: sspitsyn Date: 2013-04-25 03:58 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/15a99ca4ee34 8007037: JSR 292: the VM_RedefineClasses::append_entry() should do cross-checks with indy operands Summary: References from operands to CP entries and back must be correct after CP merge Reviewed-by: coleenp, twisti Contributed-by: serguei.spitsyn at oracle.com ! src/share/vm/oops/constantPool.cpp ! src/share/vm/oops/constantPool.hpp ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! src/share/vm/prims/jvmtiRedefineClasses.hpp Changeset: c115fac239eb Author: iklam Date: 2013-04-25 12:55 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/c115fac239eb 8008962: NPG: Memory regression: One extra Monitor per ConstantPool Summary: Re-use InstanceKlass::_init_lock locking ConstantPool as well. Reviewed-by: dholmes, coleenp, acorn ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/oops/constantPool.cpp ! src/share/vm/oops/constantPool.hpp ! src/share/vm/oops/cpCache.cpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/prims/jvmtiEnv.cpp Changeset: 3c9b7ef92c61 Author: dcubed Date: 2013-04-26 08:40 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/3c9b7ef92c61 Merge Changeset: d1644a010f52 Author: emc Date: 2013-04-26 07:34 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/d1644a010f52 8007154: Remove support for u4 MethodParameter flags fields Summary: Remove support for parsing class files with four-byte flags fields in MethodParameters attributes Reviewed-by: jrose, coleenp ! src/share/vm/classfile/classFileParser.cpp Changeset: f258c5828eb8 Author: hseigel Date: 2013-04-29 16:13 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/f258c5828eb8 8011773: Some tests on Interned String crashed JVM with OOM Summary: Instead of terminating the VM, throw OutOfMemoryError exceptions. Reviewed-by: coleenp, dholmes ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/symbolTable.cpp ! src/share/vm/memory/allocation.hpp ! src/share/vm/oops/oop.cpp ! src/share/vm/prims/whitebox.cpp Changeset: c53e49efe6a8 Author: hseigel Date: 2013-04-29 16:36 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/c53e49efe6a8 Merge Changeset: f32b6c267d2e Author: mikael Date: 2013-04-29 11:03 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/f32b6c267d2e 8012015: Use PROT_NONE when reserving memory Summary: Reserved memory had PROT_READ+PROT_WRITE access on Linux/bsd, now changed to PROT_NONE. Reviewed-by: dholmes, ctornqvi ! src/os/bsd/vm/os_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/share/vm/prims/whitebox.cpp + test/runtime/memory/ReserveMemory.java ! test/testlibrary/whitebox/sun/hotspot/WhiteBox.java Changeset: 9f96b7a853bc Author: sla Date: 2013-04-30 10:53 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/9f96b7a853bc 8013466: SA crashes when attaching to a process on OS X Reviewed-by: coleenp, rbackman, minqi ! agent/src/os/bsd/MacosxDebuggerLocal.m Changeset: 409d4b59e095 Author: sla Date: 2013-04-30 02:28 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/409d4b59e095 Merge Changeset: ed5a590835a4 Author: zgu Date: 2013-04-30 09:17 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/ed5a590835a4 8013214: BigApps fails due to 'fatal error: Illegal threadstate encountered: 6' Summary: Grab and drop SR_lock to get the thread to honor the safepoint protocol Reviewed-by: dcubed, coleenp ! src/share/vm/services/memBaseline.cpp Changeset: 746b070f5022 Author: ccheung Date: 2013-04-30 11:56 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/746b070f5022 8011661: Insufficient memory message says "malloc" when sometimes it should say "mmap" Reviewed-by: coleenp, zgu, hseigel ! src/os/solaris/vm/os_solaris.cpp ! src/os_cpu/linux_sparc/vm/os_linux_sparc.cpp ! src/os_cpu/linux_x86/vm/os_linux_x86.cpp ! src/os_cpu/linux_zero/vm/os_linux_zero.cpp ! src/os_cpu/solaris_sparc/vm/os_solaris_sparc.cpp ! src/os_cpu/solaris_x86/vm/os_solaris_x86.cpp ! src/share/vm/asm/assembler.cpp ! src/share/vm/code/stubs.cpp ! src/share/vm/code/vtableStubs.cpp ! src/share/vm/gc_implementation/g1/g1BlockOffsetTable.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp ! src/share/vm/gc_implementation/parallelScavenge/cardTableExtension.cpp ! src/share/vm/gc_implementation/parallelScavenge/gcTaskThread.cpp ! src/share/vm/gc_implementation/parallelScavenge/objectStartArray.cpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/memory/allocation.cpp ! src/share/vm/memory/allocation.inline.hpp ! src/share/vm/memory/blockOffsetTable.cpp ! src/share/vm/memory/cardTableModRefBS.cpp ! src/share/vm/oops/oop.cpp ! src/share/vm/prims/jvmtiTagMap.cpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/runtime/objectMonitor.cpp ! src/share/vm/runtime/stubRoutines.cpp ! src/share/vm/runtime/synchronizer.cpp ! src/share/vm/utilities/debug.cpp ! src/share/vm/utilities/debug.hpp ! src/share/vm/utilities/vmError.cpp ! src/share/vm/utilities/vmError.hpp ! src/share/vm/utilities/workgroup.cpp Changeset: e4614b063fe1 Author: sla Date: 2013-04-30 21:47 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/e4614b063fe1 8013364: SA-JDI exceptions caused by lack of permissions on OSX should be more verbose about issue cause Reviewed-by: coleenp, rbackman ! agent/src/os/bsd/MacosxDebuggerLocal.m Changeset: 376ff861f611 Author: sla Date: 2013-05-01 01:07 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/376ff861f611 Merge Changeset: b4081e9714ec Author: vladidan Date: 2013-04-30 17:36 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/b4081e9714ec 8013398: Adjust number of stack guard pages on systems with large memory page size Summary: Auto adjust number of stack guard pages on systems with large memory page size Reviewed-by: bobv, coleenp ! src/os/linux/vm/os_linux.cpp ! src/os/linux/vm/os_linux.hpp Changeset: 1847df492437 Author: vladidan Date: 2013-05-01 10:10 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/1847df492437 Merge Changeset: 08236d966eea Author: bharadwaj Date: 2013-05-01 08:07 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/08236d966eea 8013418: assert(i == total_args_passed) in AdapterHandlerLibrary::get_adapter since 8-b87 Summary: Do not treat static methods as miranda methods. Reviewed-by: dholmes, acorn ! src/share/vm/oops/klassVtable.cpp + test/runtime/lambda-features/PublicStaticInterfaceMethodHandling.java Changeset: 8fe2542bdc8d Author: bharadwaj Date: 2013-05-01 09:00 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/8fe2542bdc8d Merge Changeset: a6e09d6dd8e5 Author: dlong Date: 2013-04-24 20:55 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/a6e09d6dd8e5 8003853: specify offset of IC load in java_to_interp stub Summary: refactored code to allow platform-specific differences Reviewed-by: dlong, twisti Contributed-by: Goetz Lindenmaier + src/cpu/sparc/vm/compiledIC_sparc.cpp ! src/cpu/sparc/vm/sparc.ad + src/cpu/x86/vm/compiledIC_x86.cpp ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad + src/cpu/zero/vm/compiledIC_zero.cpp ! src/share/vm/adlc/main.cpp ! src/share/vm/code/compiledIC.cpp ! src/share/vm/code/compiledIC.hpp ! src/share/vm/opto/output.cpp Changeset: e10e43e58e92 Author: dlong Date: 2013-04-24 21:11 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/e10e43e58e92 Merge - make/bsd/makefiles/jvmg.make - make/bsd/makefiles/profiled.make - make/linux/makefiles/jvmg.make - make/linux/makefiles/profiled.make - make/solaris/makefiles/jvmg.make - make/solaris/makefiles/profiled.make ! src/cpu/sparc/vm/sparc.ad ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad - src/os/bsd/vm/chaitin_bsd.cpp - src/os/linux/vm/chaitin_linux.cpp - src/os/solaris/vm/chaitin_solaris.cpp - src/os/windows/vm/chaitin_windows.cpp ! src/share/vm/opto/output.cpp - test/gc/6941923/test6941923.sh - test/gc/TestVerifyBeforeGCDuringStartup.java - test/runtime/NMT/AllocTestType.java Changeset: 3c0584fec1e6 Author: dholmes Date: 2013-04-28 18:24 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/3c0584fec1e6 8010428: Special -agentpath checks needed with minimal VM to produce proper error message Reviewed-by: dholmes, alanb, cjplummer, olagneau Contributed-by: Carlos Lucasius ! src/share/vm/runtime/arguments.cpp Changeset: 78603aa58b1e Author: jiangli Date: 2013-04-26 16:58 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/78603aa58b1e Merge ! src/cpu/x86/vm/x86_64.ad Changeset: e01e02a9fcb6 Author: jiangli Date: 2013-04-29 01:58 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/e01e02a9fcb6 Merge ! src/share/vm/runtime/arguments.cpp Changeset: 052caeaeb771 Author: jiangli Date: 2013-05-02 12:16 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/052caeaeb771 Merge Changeset: 8f9fae155577 Author: jiangli Date: 2013-05-02 13:12 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/8f9fae155577 Merge Changeset: c23dbf0e8ab7 Author: jmasa Date: 2013-03-01 10:19 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/c23dbf0e8ab7 8011268: NPG: Free unused VirtualSpaceNodes Reviewed-by: mgerdin, coleenp, johnc ! src/share/vm/classfile/classLoaderData.cpp ! src/share/vm/memory/metachunk.cpp ! src/share/vm/memory/metachunk.hpp ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/metaspace.hpp Changeset: bfe3be9ebd6c Author: kevinw Date: 2013-04-18 17:02 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/bfe3be9ebd6c 7109087: gc/7072527/TestFullGCCount.java fails when GC is set in command-line Reviewed-by: mgerdin ! test/gc/7072527/TestFullGCCount.java Changeset: 12927badda81 Author: kevinw Date: 2013-04-19 05:14 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/12927badda81 Merge Changeset: d391427ddc29 Author: mgerdin Date: 2013-04-22 10:10 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/d391427ddc29 Merge Changeset: a08c80e9e1e5 Author: stefank Date: 2013-04-22 20:27 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/a08c80e9e1e5 8012687: Remove unused is_root checks and closures Reviewed-by: tschatzl, jmasa ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.hpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp ! src/share/vm/gc_implementation/shared/markSweep.cpp ! src/share/vm/gc_implementation/shared/markSweep.hpp ! src/share/vm/gc_implementation/shared/markSweep.inline.hpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/genCollectedHeap.hpp ! src/share/vm/memory/genMarkSweep.cpp ! src/share/vm/memory/sharedHeap.cpp ! src/share/vm/memory/sharedHeap.hpp Changeset: ebded0261dfc Author: jmasa Date: 2013-04-22 22:00 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/ebded0261dfc 8012111: Remove warning about CMS generation shrinking. Reviewed-by: johnc, brutisso, stefank ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp + test/gc/concurrentMarkSweep/GuardShrinkWarning.java Changeset: 1cb4795305b9 Author: mgerdin Date: 2013-04-23 08:39 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/1cb4795305b9 8011802: NPG: init_dependencies in class loader data graph can cause invalid CLD Summary: Restructure initialization of ClassLoaderData to not add a new instance if init_dependencies fail Reviewed-by: stefank, coleenp ! src/share/vm/classfile/classLoaderData.cpp ! src/share/vm/classfile/classLoaderData.hpp ! src/share/vm/classfile/classLoaderData.inline.hpp Changeset: 5c93c1f61226 Author: johnc Date: 2013-04-18 10:09 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/5c93c1f61226 8011724: G1: Stack allocate instances of HeapRegionRemSetIterator Summary: Stack allocate instances of HeapRegionRemSetIterator during RSet scanning. Reviewed-by: brutisso, jwilhelm ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1RemSet.cpp ! src/share/vm/gc_implementation/g1/g1RemSet.hpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.hpp ! src/share/vm/gc_implementation/g1/sparsePRT.cpp ! src/share/vm/gc_implementation/g1/sparsePRT.hpp Changeset: 868d87ed63c8 Author: jmasa Date: 2013-02-12 14:15 -0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/868d87ed63c8 8008966: NPG: Inefficient Metaspace counter functions cause large young GC regressions Reviewed-by: mgerdin, coleenp ! src/share/vm/classfile/classLoaderData.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/shared/vmGCOperations.cpp ! src/share/vm/memory/filemap.cpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/metaspace.hpp ! src/share/vm/memory/metaspaceCounters.cpp ! src/share/vm/memory/metaspaceCounters.hpp ! src/share/vm/memory/metaspaceShared.cpp Changeset: 9d75bcd7c890 Author: mgerdin Date: 2013-04-24 19:55 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/9d75bcd7c890 8013136: NPG: Parallel class loading tests fail after fix for JDK-8011802 Summary: Move initialization of dependencies to before allocation of CLD Reviewed-by: stefank, coleenp ! src/share/vm/classfile/classLoaderData.cpp ! src/share/vm/classfile/classLoaderData.hpp Changeset: d50cc62e94ff Author: johnc Date: 2013-04-24 14:48 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/d50cc62e94ff 8012715: G1: GraphKit accesses PtrQueue::_index as int but is size_t Summary: In graphKit INT operations were generated to access PtrQueue::_index which has type size_t. This is 64 bit on 64-bit machines. No problems occur on little endian machines as long as the index fits into 32 bit, but on big endian machines the upper part is read, which is zero. This leads to unnecessary branches to the slow path in the runtime. Reviewed-by: twisti, johnc Contributed-by: Martin Doerr ! src/share/vm/opto/graphKit.cpp Changeset: b06ac540229e Author: stefank Date: 2013-04-24 20:13 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/b06ac540229e 8013132: Add a flag to turn off the output of the verbose verification code Reviewed-by: johnc, brutisso ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/memory/universe.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/vmThread.cpp ! src/share/vm/runtime/vm_operations.hpp Changeset: b294421fa3c5 Author: brutisso Date: 2013-04-26 09:53 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/b294421fa3c5 8012915: ReservedSpace::align_reserved_region() broken on Windows Summary: remove unused constructors and helper methods for ReservedHeapSpace and ReservedSpace Reviewed-by: mgerdin, jmasa, johnc, tschatzl ! src/share/vm/runtime/virtualspace.cpp ! src/share/vm/runtime/virtualspace.hpp Changeset: 2f50bc369470 Author: stefank Date: 2013-04-26 10:40 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/2f50bc369470 8013160: NPG: Remove unnecessary mark stack draining after CodeCache::do_unloading Reviewed-by: coleenp, mgerdin ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/memory/genMarkSweep.cpp Changeset: 3edf23423bb2 Author: johnc Date: 2013-04-26 10:57 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/3edf23423bb2 8011898: gc/TestVerifyBeforeGCDuringStartup.java: java.lang.RuntimeException: '[Verifying' missing from stdout/stderr: [Error: Could not find or load main class] Summary: System.getProperty("test.java.opts") can return NULL, which gets converted to to the empty string, and the child java command then interprets that as the name of the main class. Reviewed-by: jmasa, brutisso ! test/gc/TestVerifyDuringStartup.java Changeset: caac22686b17 Author: mgerdin Date: 2013-04-29 09:31 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/caac22686b17 Merge ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp ! src/share/vm/runtime/thread.cpp Changeset: 601183f604b2 Author: mgerdin Date: 2013-04-29 13:07 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/601183f604b2 8013129: Possible deadlock with Metaspace locks due to mixed usage of safepoint aware and non-safepoint aware locking Summary: Change Metaspace::deallocate to take lock with _no_safepoint_check_flag Reviewed-by: coleenp, jmasa, dholmes ! src/share/vm/memory/metaspace.cpp Changeset: 9075044ed66b Author: ehelin Date: 2013-04-30 16:36 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/9075044ed66b 8008541: Remove old code in HotSpot that supported the jmap -permstat functionality Reviewed-by: sla, brutisso ! agent/src/share/classes/sun/jvm/hotspot/tools/JMap.java Changeset: d58c62b7447d Author: mgerdin Date: 2013-05-02 19:28 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/d58c62b7447d Merge ! src/share/vm/classfile/classLoaderData.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp Changeset: cbd4ce58f1f3 Author: mgerdin Date: 2013-05-02 16:41 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/cbd4ce58f1f3 Merge Changeset: e12c9b3740db Author: vlivanov Date: 2013-04-25 11:02 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/e12c9b3740db 8012260: ciReplay: Include PID into the name of replay data file Reviewed-by: kvn, twisti ! src/os/bsd/vm/os_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/posix/vm/os_posix.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciEnv.hpp ! src/share/vm/ci/ciReplay.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/os.hpp ! src/share/vm/utilities/ostream.hpp ! src/share/vm/utilities/vmError.cpp Changeset: dc7db03f5aa2 Author: iignatyev Date: 2013-04-25 11:04 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/dc7db03f5aa2 8012337: Change Whitebox implementation to make absence of method in Whitebox.class not fatal Reviewed-by: kvn, vlivanov ! src/share/vm/prims/whitebox.cpp + test/sanity/WhiteBox.java Changeset: 7b23cb975cf2 Author: iignatyev Date: 2013-04-25 11:09 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/7b23cb975cf2 8011675: adding compilation level to replay data Reviewed-by: kvn, vlivanov - agent/doc/c2replay.html + agent/doc/cireplay.html ! agent/doc/clhsdb.html ! agent/src/share/classes/sun/jvm/hotspot/ci/ciEnv.java ! agent/src/share/classes/sun/jvm/hotspot/code/NMethod.java ! agent/src/share/classes/sun/jvm/hotspot/compiler/CompileTask.java ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciReplay.cpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/vmStructs.cpp + test/compiler/ciReplay/TestSA.sh + test/compiler/ciReplay/TestVM.sh + test/compiler/ciReplay/TestVM_no_comp_level.sh + test/compiler/ciReplay/common.sh Changeset: 247342108a11 Author: neliasso Date: 2013-04-23 13:48 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/247342108a11 8010332: removed unused method: ciMethod::uses_monitors Reviewed-by: twisti, roland Contributed-by: albert.noll at oracle.com ! src/share/vm/ci/ciMethod.hpp Changeset: a5c95fcf7cb7 Author: neliasso Date: 2013-04-23 18:06 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/a5c95fcf7cb7 8012157: removed unused code in SharedRuntime::handle_wrong_method Reviewed-by: kvn, roland, rbackman Contributed-by: albert.noll at oracle.com ! src/share/vm/runtime/sharedRuntime.cpp Changeset: d1c9384eecb4 Author: iignatyev Date: 2013-04-26 07:21 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/d1c9384eecb4 8012322: Tiered: CompilationPolicy::can_be_compiled(CompLevel_all) mistakenly return false Reviewed-by: kvn, vlivanov ! src/share/vm/classfile/classLoader.cpp ! src/share/vm/runtime/compilationPolicy.cpp ! test/compiler/whitebox/CompilerWhiteBoxTest.java ! test/compiler/whitebox/MakeMethodNotCompilableTest.java Changeset: 93b8272814cf Author: vlivanov Date: 2013-04-26 08:33 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/93b8272814cf Merge Changeset: 0b55a78c6be5 Author: bharadwaj Date: 2013-04-26 10:52 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/0b55a78c6be5 Merge - agent/doc/c2replay.html ! src/os/windows/vm/os_windows.cpp ! src/share/vm/runtime/vmStructs.cpp Changeset: fd49109d0d88 Author: bharadwaj Date: 2013-04-26 14:50 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/fd49109d0d88 Merge Changeset: 487d442ef257 Author: jiangli Date: 2013-04-26 16:21 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/487d442ef257 8013036: vm/runtime/simpleThresholdPolicy.cpp: assert(mcs != NULL). Summary: Change the assert to if check as MethodCounters could be NULL under TieredCompilation. Reviewed-by: kvn, twisti ! src/share/vm/runtime/simpleThresholdPolicy.cpp Changeset: 62b683108582 Author: jiangli Date: 2013-04-26 14:41 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/62b683108582 Merge Changeset: 0cfa93c2fcc4 Author: neliasso Date: 2013-04-29 13:20 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/0cfa93c2fcc4 8012547: Code cache flushing can get stuck reclaming of memory Summary: Keep sweeping regardless of if we are flushing Reviewed-by: kvn, twisti ! src/share/vm/code/codeCache.cpp ! src/share/vm/code/codeCache.hpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/oops/method.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/sweeper.cpp ! src/share/vm/runtime/sweeper.hpp Changeset: e4e131b15d5c Author: roland Date: 2013-05-02 10:27 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/e4e131b15d5c 8013532: Remove unused parameter "compiler" from DTRACE_METHOD_COMPILE* macros Summary: remove unused parameter in dtrace macros Reviewed-by: kvn, roland Contributed-by: albert.noll at oracle.com ! src/share/vm/compiler/compileBroker.cpp Changeset: 9ce110b1d14a Author: kvn Date: 2013-05-02 18:50 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/9ce110b1d14a Merge - agent/doc/c2replay.html ! src/os/bsd/vm/os_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/prims/whitebox.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/utilities/vmError.cpp Changeset: 4ec913499722 Author: amurillo Date: 2013-05-03 08:10 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/4ec913499722 Merge - agent/doc/c2replay.html Changeset: 9c1fe0b419b4 Author: amurillo Date: 2013-05-03 08:10 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/9c1fe0b419b4 Added tag hs25-b31 for changeset 4ec913499722 ! .hgtags From james.laskey at oracle.com Tue May 14 05:12:33 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Tue, 14 May 2013 12:12:33 +0000 Subject: hg: nashorn/jdk8/jaxp: 9 new changesets Message-ID: <20130514121256.797C248A5B@hg.openjdk.java.net> Changeset: 7122f7bb0fcc Author: katleman Date: 2013-04-25 09:24 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxp/rev/7122f7bb0fcc Added tag jdk8-b87 for changeset eddbc8ad2435 ! .hgtags Changeset: be5d6853d821 Author: lana Date: 2013-04-30 17:50 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxp/rev/be5d6853d821 Merge Changeset: 452e1a182907 Author: dfuchs Date: 2013-05-06 18:50 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxp/rev/452e1a182907 8008738: Issue in com.sun.org.apache.xml.internal.serializer.Encodings causes some JCK tests to fail intermittently Summary: Encodings.java sometimes creates EncodingInfo objects whose java names are not recognized by the Charset API. This patch fixes that issue. Reviewed-by: joehw, alanb ! src/com/sun/org/apache/xml/internal/serializer/Encodings.java Changeset: 1e8d98012ab8 Author: joehw Date: 2013-05-08 23:38 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxp/rev/1e8d98012ab8 8011653: Upgrade JDK8 to JAXP 1.5 Reviewed-by: alanb, dfuchs ! src/com/sun/org/apache/xalan/internal/XalanConstants.java ! src/com/sun/org/apache/xalan/internal/utils/SecuritySupport.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/Import.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/Include.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/Parser.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/XSLTC.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_ca.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_cs.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_de.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_es.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_fr.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_it.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_ja.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_ko.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_pt_BR.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_sk.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_sv.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_zh_CN.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_zh_TW.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMsg.java ! src/com/sun/org/apache/xalan/internal/xsltc/dom/LoadDocument.java ! src/com/sun/org/apache/xalan/internal/xsltc/runtime/AbstractTranslet.java ! src/com/sun/org/apache/xalan/internal/xsltc/trax/TemplatesHandlerImpl.java ! src/com/sun/org/apache/xalan/internal/xsltc/trax/TemplatesImpl.java ! src/com/sun/org/apache/xalan/internal/xsltc/trax/TransformerFactoryImpl.java ! src/com/sun/org/apache/xalan/internal/xsltc/trax/TransformerImpl.java ! src/com/sun/org/apache/xalan/internal/xsltc/trax/Util.java ! src/com/sun/org/apache/xerces/internal/dom/DOMConfigurationImpl.java ! src/com/sun/org/apache/xerces/internal/impl/Constants.java ! src/com/sun/org/apache/xerces/internal/impl/PropertyManager.java ! src/com/sun/org/apache/xerces/internal/impl/XMLDocumentFragmentScannerImpl.java ! src/com/sun/org/apache/xerces/internal/impl/XMLDocumentScannerImpl.java ! src/com/sun/org/apache/xerces/internal/impl/XMLEntityManager.java ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_de.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_es.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_fr.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_it.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_ja.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_ko.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_pt_BR.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_sv.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_zh_CN.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_zh_TW.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_de.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_es.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_fr.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_it.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_ja.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_ko.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_pt_BR.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_sv.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_zh_CN.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_zh_TW.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_de.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_es.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_fr.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_it.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_ja.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_ko.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_pt_BR.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_sv.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_zh_CN.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_zh_TW.properties ! src/com/sun/org/apache/xerces/internal/impl/xs/XMLSchemaLoader.java ! src/com/sun/org/apache/xerces/internal/impl/xs/XMLSchemaValidator.java ! src/com/sun/org/apache/xerces/internal/impl/xs/XSDDescription.java ! src/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDHandler.java ! src/com/sun/org/apache/xerces/internal/jaxp/DocumentBuilderFactoryImpl.java ! src/com/sun/org/apache/xerces/internal/jaxp/DocumentBuilderImpl.java ! src/com/sun/org/apache/xerces/internal/jaxp/SAXParserFactoryImpl.java ! src/com/sun/org/apache/xerces/internal/jaxp/SAXParserImpl.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/AbstractXMLSchema.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/StreamValidatorHelper.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/ValidatorHandlerImpl.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/XMLSchemaFactory.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/XMLSchemaValidatorComponentManager.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/XSGrammarPoolContainer.java ! src/com/sun/org/apache/xerces/internal/parsers/XML11Configuration.java ! src/com/sun/org/apache/xerces/internal/utils/SecuritySupport.java ! src/com/sun/org/apache/xerces/internal/xinclude/XIncludeHandler.java ! src/com/sun/org/apache/xml/internal/utils/XMLReaderManager.java ! src/com/sun/xml/internal/stream/StaxXMLInputSource.java ! src/javax/xml/XMLConstants.java ! src/javax/xml/parsers/DocumentBuilderFactory.java ! src/javax/xml/parsers/SAXParser.java ! src/javax/xml/stream/XMLInputFactory.java ! src/javax/xml/transform/TransformerFactory.java ! src/javax/xml/validation/SchemaFactory.java ! src/javax/xml/validation/Validator.java Changeset: 21f75e572cb3 Author: katleman Date: 2013-05-02 13:35 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxp/rev/21f75e572cb3 Added tag jdk8-b88 for changeset 7122f7bb0fcc ! .hgtags Changeset: 893d2ba8bbea Author: lana Date: 2013-05-06 11:41 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxp/rev/893d2ba8bbea Merge Changeset: 6976616f5753 Author: lana Date: 2013-05-08 22:12 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxp/rev/6976616f5753 Merge Changeset: 9e4dfe933ba9 Author: lana Date: 2013-05-09 14:23 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxp/rev/9e4dfe933ba9 Merge Changeset: a229726149b4 Author: joehw Date: 2013-05-10 09:23 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxp/rev/a229726149b4 8014333: javadoc error in JAXP 1.5 patch Reviewed-by: lancea ! src/javax/xml/stream/XMLInputFactory.java From james.laskey at oracle.com Tue May 14 05:13:02 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Tue, 14 May 2013 12:13:02 +0000 Subject: hg: nashorn/jdk8/jaxws: 3 new changesets Message-ID: <20130514121312.E6EC148A5C@hg.openjdk.java.net> Changeset: 72e03566f0a6 Author: katleman Date: 2013-04-23 18:33 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxws/rev/72e03566f0a6 8012643: JDK8 b86 source with GPL header errors Reviewed-by: dholmes, alanb ! src/share/jaxws_classes/com/oracle/webservices/internal/api/EnvelopeStyle.java ! src/share/jaxws_classes/com/oracle/webservices/internal/api/EnvelopeStyleFeature.java ! src/share/jaxws_classes/com/oracle/webservices/internal/api/databinding/Databinding.java ! src/share/jaxws_classes/com/oracle/webservices/internal/api/databinding/DatabindingFactory.java ! src/share/jaxws_classes/com/oracle/webservices/internal/api/databinding/DatabindingMode.java ! src/share/jaxws_classes/com/oracle/webservices/internal/api/databinding/DatabindingModeFeature.java ! src/share/jaxws_classes/com/oracle/webservices/internal/api/databinding/ExternalMetadataFeature.java ! src/share/jaxws_classes/com/oracle/webservices/internal/api/databinding/JavaCallInfo.java ! src/share/jaxws_classes/com/oracle/webservices/internal/api/databinding/WSDLGenerator.java ! src/share/jaxws_classes/com/oracle/webservices/internal/api/databinding/WSDLResolver.java ! src/share/jaxws_classes/com/oracle/webservices/internal/api/message/BaseDistributedPropertySet.java ! src/share/jaxws_classes/com/oracle/webservices/internal/api/message/BasePropertySet.java ! src/share/jaxws_classes/com/oracle/webservices/internal/api/message/ContentType.java ! src/share/jaxws_classes/com/oracle/webservices/internal/api/message/DistributedPropertySet.java ! src/share/jaxws_classes/com/oracle/webservices/internal/api/message/MessageContext.java ! src/share/jaxws_classes/com/oracle/webservices/internal/api/message/MessageContextFactory.java ! src/share/jaxws_classes/com/oracle/webservices/internal/api/message/PropertySet.java ! src/share/jaxws_classes/com/oracle/webservices/internal/api/message/ReadOnlyPropertyException.java ! src/share/jaxws_classes/com/oracle/webservices/internal/impl/encoding/StreamDecoderImpl.java ! src/share/jaxws_classes/com/oracle/webservices/internal/impl/internalspi/encoding/StreamDecoder.java ! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/ExistingAnnotationsType.java ! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/JavaMethod.java ! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/JavaParam.java ! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/JavaWsdlMappingType.java ! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/ObjectFactory.java ! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/SoapBindingParameterStyle.java ! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/SoapBindingStyle.java ! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/SoapBindingUse.java ! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/Util.java ! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/WebParamMode.java ! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlAction.java ! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlAddressing.java ! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlBindingType.java ! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlFaultAction.java ! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlHandlerChain.java ! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlMTOM.java ! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlOneway.java ! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlRequestWrapper.java ! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlResponseWrapper.java ! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlSOAPBinding.java ! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlServiceMode.java ! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlWebEndpoint.java ! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlWebFault.java ! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlWebMethod.java ! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlWebParam.java ! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlWebResult.java ! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlWebService.java ! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlWebServiceClient.java ! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlWebServiceProvider.java ! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/XmlWebServiceRef.java ! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/package-info.java Changeset: 24fa5452e5d4 Author: katleman Date: 2013-04-25 09:24 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxws/rev/24fa5452e5d4 Added tag jdk8-b87 for changeset 72e03566f0a6 ! .hgtags Changeset: 88838e08e4ef Author: katleman Date: 2013-05-02 13:35 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxws/rev/88838e08e4ef Added tag jdk8-b88 for changeset 24fa5452e5d4 ! .hgtags From james.laskey at oracle.com Tue May 14 05:15:56 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Tue, 14 May 2013 12:15:56 +0000 Subject: hg: nashorn/jdk8/jdk: 93 new changesets Message-ID: <20130514123651.6729F48A5E@hg.openjdk.java.net> Changeset: 7857129859bd Author: briangoetz Date: 2013-04-20 18:53 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/7857129859bd 8012650: Arrays streams methods 8011918: java.util.stream.Streams Reviewed-by: alanb, mduigou, darcy, henryjen Contributed-by: brian.goetz at oracle.com, paul.sandoz at oracle.com ! src/share/classes/java/util/Arrays.java ! src/share/classes/java/util/stream/DoubleStream.java ! src/share/classes/java/util/stream/IntStream.java ! src/share/classes/java/util/stream/LongStream.java ! src/share/classes/java/util/stream/Stream.java + src/share/classes/java/util/stream/StreamBuilder.java + src/share/classes/java/util/stream/Streams.java + test/java/util/Arrays/SetAllTest.java Changeset: 46ddd9d272b5 Author: mduigou Date: 2013-04-29 22:03 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/46ddd9d272b5 8011917: Add java.util.stream.Collectors utilities Reviewed-by: darcy, mduigou Contributed-by: Brian Goetz + src/share/classes/java/util/stream/Collectors.java Changeset: fff665e54df0 Author: sla Date: 2013-04-30 10:48 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/fff665e54df0 8003671: [findbugs] sun.management.AgentConfigurationError.getParams() may expose internal representation by returning AgentConfigurationError.params Reviewed-by: mchung, rbackman, jbachorik ! src/share/classes/sun/management/AgentConfigurationError.java Changeset: 49d6596100db Author: msheppar Date: 2013-04-29 23:07 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/49d6596100db 8007373: Inet6Address serialization incompatibility Reviewed-by: alanb, chegar ! src/share/classes/java/net/Inet6Address.java + test/java/net/Inet6Address/serialize/Inet6AddressSerializationTest.java Changeset: ac3e189c9099 Author: lancea Date: 2013-04-30 14:44 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/ac3e189c9099 8010416: Add a way for java.sql.Driver to be notified when it is deregistered Reviewed-by: alanb, ulfzibis ! src/share/classes/java/sql/Driver.java + src/share/classes/java/sql/DriverAction.java ! src/share/classes/java/sql/DriverManager.java ! src/share/classes/java/sql/SQLPermission.java Changeset: 0e6f412f5536 Author: mduigou Date: 2013-04-30 12:31 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/0e6f412f5536 8011814: Add testng.jar to Netbeans projects test compile classpath 8013271: Add MacOS sources to J2SE Netbeans project 8013272: JDK Netbeans projects should use ASCII encoding for sources Reviewed-by: lancea ! make/netbeans/common/closed-share-sources.ent ! make/netbeans/common/demo-view.ent ! make/netbeans/common/java-data-native.ent ! make/netbeans/common/java-data-no-native.ent ! make/netbeans/common/jtreg-view.ent + make/netbeans/common/macosx-sources.ent + make/netbeans/common/macosx-view.ent ! make/netbeans/common/properties.ent ! make/netbeans/common/sample-view.ent ! make/netbeans/common/share-sources.ent ! make/netbeans/common/unix-sources.ent ! make/netbeans/common/windows-sources.ent ! make/netbeans/j2se/nbproject/project.xml ! make/netbeans/world/nbproject/project.xml Changeset: 2fba6ae13ed8 Author: mduigou Date: 2013-04-30 12:32 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/2fba6ae13ed8 Merge Changeset: 1432a6247ac9 Author: ksrini Date: 2013-04-30 13:12 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/1432a6247ac9 8009389: Unpack200 native library should be removed from profiles Reviewed-by: alanb, bobv, jrose ! makefiles/profile-includes.txt ! src/share/classes/com/sun/java/util/jar/pack/UnpackerImpl.java Changeset: eda99449ab26 Author: alanb Date: 2013-04-30 21:19 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/eda99449ab26 8013647: JPRT unable to clean-up after tests that leave file trees with loops Reviewed-by: chegar, tbell ! test/java/nio/file/Files/walkFileTree/MaxDepth.java ! test/java/nio/file/Files/walkFileTree/SkipSiblings.java ! test/java/nio/file/Files/walkFileTree/SkipSubtree.java ! test/java/nio/file/Files/walkFileTree/TerminateWalk.java Changeset: 4a82d2b86c75 Author: mchung Date: 2013-04-30 15:42 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/4a82d2b86c75 8013531: Provide a utility class in com.sun.tools.classfile to find field/method references Reviewed-by: alanb ! test/sun/reflect/CallerSensitive/CallerSensitiveFinder.java - test/sun/reflect/CallerSensitive/MethodFinder.java ! test/sun/reflect/CallerSensitive/MissingCallerSensitive.java Changeset: d5228e624826 Author: katleman Date: 2013-04-23 18:25 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/d5228e624826 8012643: JDK8 b86 source with GPL header errors Reviewed-by: dholmes, alanb ! test/java/lang/Runtime/exec/WinCommand.java ! test/java/lang/reflect/Method/DefaultMethodModeling.java Changeset: 53be90fb39d6 Author: katleman Date: 2013-04-25 09:24 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/53be90fb39d6 Added tag jdk8-b87 for changeset d5228e624826 ! .hgtags Changeset: 4550ba263cbf Author: lana Date: 2013-04-30 17:51 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/4550ba263cbf Merge Changeset: dddd17cf61ff Author: chegar Date: 2013-05-01 10:03 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/dddd17cf61ff 6594296: NetworkInterface.getHardwareAddress returns zero length byte array Reviewed-by: alanb ! src/windows/native/java/net/NetworkInterface_winXP.c ! test/java/net/NetworkInterface/Test.java Changeset: 73793f2af80a Author: msheppar Date: 2013-04-30 16:24 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/73793f2af80a 8007799: Base64.getEncoder(0, byte[]) returns an encoder that unexpectedly inserts line separators Reviewed-by: sherman, iris ! src/share/classes/java/util/Base64.java + test/java/util/Base64/Base64GetEncoderTest.java Changeset: 5941f7c9c76a Author: chegar Date: 2013-05-01 11:15 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/5941f7c9c76a 8013723: ProblemList.txt updates (5/2013) Reviewed-by: alanb ! test/ProblemList.txt Changeset: ae4a82e69da2 Author: weijun Date: 2013-05-01 21:05 +0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/ae4a82e69da2 8012082: SASL: auth-conf negotiated, but unencrypted data is accepted, reset to unencrypt Reviewed-by: vinnie ! src/share/classes/com/sun/security/sasl/gsskerb/GssKrb5Base.java ! src/share/classes/com/sun/security/sasl/gsskerb/GssKrb5Client.java ! src/share/classes/com/sun/security/sasl/gsskerb/GssKrb5Server.java + test/sun/security/krb5/auto/SaslGSS.java Changeset: c6aef650e615 Author: mduigou Date: 2013-05-01 08:35 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/c6aef650e615 8012665: add CharSequence.chars, CharSequence.codePoints Reviewed-by: martin, alanb, ulfzibis, mduigou Contributed-by: Stuart Marks , Henry Jen ! src/share/classes/java/lang/CharSequence.java + test/java/lang/CharSequence/DefaultTest.java ! test/java/lang/StringBuffer/TestSynchronization.java Changeset: 167d2dcaeeee Author: ksrini Date: 2013-05-01 15:08 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/167d2dcaeeee 8013225: Refresh jdk's private ASM to the latest. Reviewed-by: mduigou, sundar ! src/share/classes/jdk/internal/org/objectweb/asm/AnnotationVisitor.java ! src/share/classes/jdk/internal/org/objectweb/asm/AnnotationWriter.java ! src/share/classes/jdk/internal/org/objectweb/asm/Attribute.java ! src/share/classes/jdk/internal/org/objectweb/asm/ByteVector.java ! src/share/classes/jdk/internal/org/objectweb/asm/ClassReader.java ! src/share/classes/jdk/internal/org/objectweb/asm/ClassVisitor.java ! src/share/classes/jdk/internal/org/objectweb/asm/ClassWriter.java + src/share/classes/jdk/internal/org/objectweb/asm/Context.java ! src/share/classes/jdk/internal/org/objectweb/asm/FieldVisitor.java ! src/share/classes/jdk/internal/org/objectweb/asm/FieldWriter.java ! src/share/classes/jdk/internal/org/objectweb/asm/Frame.java ! src/share/classes/jdk/internal/org/objectweb/asm/Handle.java ! src/share/classes/jdk/internal/org/objectweb/asm/Handler.java ! src/share/classes/jdk/internal/org/objectweb/asm/Item.java ! src/share/classes/jdk/internal/org/objectweb/asm/Label.java ! src/share/classes/jdk/internal/org/objectweb/asm/MethodVisitor.java ! src/share/classes/jdk/internal/org/objectweb/asm/MethodWriter.java ! src/share/classes/jdk/internal/org/objectweb/asm/Opcodes.java ! src/share/classes/jdk/internal/org/objectweb/asm/Type.java + src/share/classes/jdk/internal/org/objectweb/asm/TypePath.java + src/share/classes/jdk/internal/org/objectweb/asm/TypeReference.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/AdviceAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/AnalyzerAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/CodeSizeEvaluator.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/GeneratorAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/InstructionAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/JSRInlinerAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/LocalVariablesSorter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/Method.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/Remapper.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/RemappingAnnotationAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/RemappingClassAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/RemappingFieldAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/RemappingMethodAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/RemappingSignatureAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/SerialVersionUIDAdder.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/StaticInitMerger.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/TableSwitchGenerator.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/TryCatchBlockSorter.java ! src/share/classes/jdk/internal/org/objectweb/asm/signature/SignatureReader.java ! src/share/classes/jdk/internal/org/objectweb/asm/signature/SignatureVisitor.java ! src/share/classes/jdk/internal/org/objectweb/asm/signature/SignatureWriter.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/AbstractInsnNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/AnnotationNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/ClassNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/FieldInsnNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/FieldNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/FrameNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/IincInsnNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/InnerClassNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/InsnList.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/InsnNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/IntInsnNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/InvokeDynamicInsnNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/JumpInsnNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/LdcInsnNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/LineNumberNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/LocalVariableAnnotationNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/LocalVariableNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/LookupSwitchInsnNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/MethodInsnNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/MethodNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/MultiANewArrayInsnNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/ParameterNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/TableSwitchInsnNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/TryCatchBlockNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/TypeAnnotationNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/TypeInsnNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/VarInsnNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/Analyzer.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/AnalyzerException.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/BasicInterpreter.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/BasicValue.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/BasicVerifier.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/Frame.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/Interpreter.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/SimpleVerifier.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/SourceInterpreter.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/SourceValue.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/Subroutine.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/ASMifiable.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/ASMifier.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/CheckAnnotationAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/CheckClassAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/CheckFieldAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/CheckMethodAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/CheckSignatureAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/Printer.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/Textifiable.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/Textifier.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/TraceAnnotationVisitor.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/TraceClassVisitor.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/TraceFieldVisitor.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/TraceMethodVisitor.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/TraceSignatureVisitor.java + src/share/classes/jdk/internal/org/objectweb/asm/version.txt Changeset: 5045eb04a579 Author: mduigou Date: 2013-05-02 09:18 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/5045eb04a579 8012645: Stream methods on BitSet, Random, ThreadLocalRandom, ZipFile Reviewed-by: mduigou, henryjen, alanb, martin, psandoz Contributed-by: akhil.arora at oracle.com, brian.goetz at oracle.com ! src/share/classes/java/util/BitSet.java ! src/share/classes/java/util/Random.java ! src/share/classes/java/util/concurrent/ThreadLocalRandom.java ! src/share/classes/java/util/jar/JarFile.java ! src/share/classes/java/util/zip/ZipFile.java + test/java/util/BitSet/BitSetStreamTest.java + test/java/util/Random/RandomStreamTest.java + test/java/util/zip/ZipFile/StreamZipEntriesTest.java Changeset: a6ff4a823164 Author: kizune Date: 2013-05-02 21:23 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/a6ff4a823164 8013155: [pack200] improve performance of pack200 Reviewed-by: ksrini, jrose ! src/share/classes/com/sun/java/util/jar/pack/Code.java ! src/share/classes/com/sun/java/util/jar/pack/ConstantPool.java Changeset: 3062bf908281 Author: khazra Date: 2013-05-02 14:26 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/3062bf908281 8013140: Heap corruption with NetworkInterface.getByInetAddress() and long i/f name Summary: Remove buffer overruns in native code Reviewed-by: alanb, chegar ! src/solaris/native/java/net/NetworkInterface.c Changeset: 81be41c7323f Author: weijun Date: 2013-05-03 10:43 +0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/81be41c7323f 8013855: DigestMD5Client has not checked RealmChoiceCallback value Reviewed-by: xuelei, mullan ! src/share/classes/com/sun/security/sasl/digest/DigestMD5Client.java + test/com/sun/security/sasl/digest/AuthRealmChoices.java Changeset: 470f19b6bfdd Author: jbachorik Date: 2013-05-02 13:21 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/470f19b6bfdd 7199324: Connection ID for IPv6 addresses is not generated accordingly to the specification Summary: RemoteServer.getClientHost is returning a String with an IPv6 literal address and we need to enclose it in [] when building the connection id Reviewed-by: alanb, sjiang ! src/share/classes/javax/management/remote/rmi/RMIServerImpl.java ! test/javax/management/remote/mandatory/connection/ConnectionTest.java Changeset: fc156b925259 Author: mduigou Date: 2013-05-03 10:57 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/fc156b925259 8013528: Provide SharedSecrets access to String(char[], boolean) constructor Reviewed-by: martin, alanb, chegar, plevart ! src/share/classes/java/lang/System.java ! src/share/classes/sun/misc/JavaLangAccess.java + test/sun/misc/JavaLangAccess/NewUnsafeString.java Changeset: d7f3d5659c46 Author: juh Date: 2013-05-03 15:04 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/d7f3d5659c46 8005922: TEST_BUG: There is no /tmp directory for windows system. Reviewed-by: weijun ! test/sun/security/tools/policytool/ChangeUI.html ! test/sun/security/tools/policytool/UpdatePermissions.html ! test/sun/security/tools/policytool/i18n.html Changeset: d8f01bfb1da4 Author: dwanvik Date: 2013-05-06 05:51 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/d8f01bfb1da4 8013403: Update JDK8 with Java DB 10.10.1.1. Summary: Drop Java DB 10.10.1.1 bits into JDK 8 and update image builds Reviewed-by: tbell ! make/common/Release.gmk ! makefiles/CompileDemos.gmk ! makefiles/Images.gmk Changeset: 398fe07f530f Author: dwanvik Date: 2013-05-06 06:05 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/398fe07f530f Merge - test/sun/reflect/CallerSensitive/MethodFinder.java Changeset: bd118033e44c Author: dxu Date: 2013-05-06 14:17 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/bd118033e44c 8003992: File and other classes in java.io do not handle embedded nulls properly Summary: Have every file operation done with File, FileInputStream, FileOutputStream, or RandomAccessFile that involves a file path containing NUL fail. Also reviewed by fweimer at redhat.com Reviewed-by: alanb, sherman, ahgross, mduigou, dholmes, aph, plevart, martin ! src/share/classes/java/io/File.java ! src/share/classes/java/io/FileInputStream.java ! src/share/classes/java/io/FileOutputStream.java ! src/share/classes/java/io/RandomAccessFile.java + test/java/io/File/NulFile.java Changeset: e13cf31e5a96 Author: mduigou Date: 2013-05-06 20:54 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/e13cf31e5a96 8013712: Add Objects.nonNull and Objects.isNull Reviewed-by: mchung, darcy ! src/share/classes/java/util/Objects.java ! test/java/util/Objects/BasicObjectsTest.java Changeset: 3cbb65d9af9e Author: mduigou Date: 2013-05-06 20:54 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/3cbb65d9af9e 8013150: Iterator.remove and forEachRemaining relationship not specified Reviewed-by: mduigou Contributed-by: Akhil Arora ! src/share/classes/java/util/ArrayList.java ! src/share/classes/java/util/LinkedList.java ! src/share/classes/java/util/Vector.java + test/java/util/Iterator/IteratorDefaults.java Changeset: 8221c421490f Author: mduigou Date: 2013-05-06 20:54 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/8221c421490f 8003258: BufferedReader.lines() Reviewed-by: alanb, mduigou, psandoz Contributed-by: Brian Goetz , Henry Jen ! src/share/classes/java/io/BufferedReader.java + src/share/classes/java/io/UncheckedIOException.java + test/java/io/BufferedReader/Lines.java Changeset: b4a013f4eff4 Author: sherman Date: 2013-05-06 21:24 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/b4a013f4eff4 8013252: Regex Matcher .start and .end should be accessible by group name 8013254: Constructor \w need update to add the support of \p{Join_Control} Summary: added the requested methods and updated the \w constructor Reviewed-by: mchung, alanb ! src/share/classes/java/util/regex/Matcher.java ! src/share/classes/java/util/regex/Pattern.java ! src/share/classes/java/util/regex/UnicodeProp.java ! test/java/util/regex/POSIX_Unicode.java ! test/java/util/regex/RegExTest.java Changeset: 814dcc08df52 Author: weijun Date: 2013-05-07 12:30 +0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/814dcc08df52 8010192: Enable native JGSS provider on Mac Reviewed-by: valeriep ! make/sun/security/Makefile ! makefiles/CompileNativeLibraries.gmk ! src/share/classes/sun/security/jgss/GSSManagerImpl.java ! src/share/classes/sun/security/jgss/wrapper/SunNativeProvider.java ! src/share/native/sun/security/jgss/wrapper/gssapi.h ! test/sun/security/krb5/runNameEquals.sh Changeset: 9c9b2385c1b0 Author: jfranck Date: 2013-05-07 09:52 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/9c9b2385c1b0 8013541: Revise javadoc for Executable.getAnnotatedReturnType() Reviewed-by: abuckley, darcy ! src/share/classes/java/lang/reflect/Executable.java Changeset: 2602eab5f086 Author: dfuchs Date: 2013-05-07 11:35 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/2602eab5f086 8008738: Issue in com.sun.org.apache.xml.internal.serializer.Encodings causes some JCK tests to fail intermittently Summary: Encodings.java sometimes creates EncodingInfo objects whose java names are not recognized by the Charset API. This patch fixes that issue. Reviewed-by: joehw, alanb + test/javax/xml/jaxp/Encodings/CheckEncodingPropertiesFile.java Changeset: 7b40394ad944 Author: sla Date: 2013-05-07 19:57 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/7b40394ad944 6980985: java/lang/management/MemoryMXBean/ResetPeakMemoryUsage is not robust when getMax() returns -1 7181907: TEST_BUG: j/l/management/MemoryMXBean/ResetPeakMemoryUsage fails with NegativeArraySizeException 7148492: java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java failing since update to hs23-b15 or b16 Reviewed-by: mchung, brutisso ! test/ProblemList.txt ! test/java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java Changeset: 100027950b05 Author: sla Date: 2013-05-07 20:00 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/100027950b05 8004007: test/sun/tools/jinfo/Basic.sh fails on when runSA is set to true Reviewed-by: alanb, dsamersoff ! test/sun/tools/jinfo/Basic.sh Changeset: e30396e22c6f Author: naoto Date: 2013-05-07 11:31 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/e30396e22c6f 8013086: NPE thrown by SimpleDateFormat with TimeZoneNameProvider supplied Reviewed-by: okutsu ! src/share/classes/sun/util/locale/provider/TimeZoneNameUtility.java ! test/java/util/Locale/LocaleProviders.java ! test/java/util/Locale/LocaleProviders.sh Changeset: fe4e9bc2186f Author: mduigou Date: 2013-05-07 12:05 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/fe4e9bc2186f 4802647: Throw required NPEs from removeAll()/retainAll() Reviewed-by: mduigou, chegar, dholmes Contributed-by: Brandon Passanisi ! src/share/classes/java/util/AbstractCollection.java ! src/share/classes/java/util/AbstractSet.java ! src/share/classes/java/util/ArrayList.java ! test/java/util/Collection/MOAT.java Changeset: 6feee75b0a8b Author: briangoetz Date: 2013-05-06 11:43 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/6feee75b0a8b 8012664: Add tests for java.util.stream and lambda translation Reviewed-by: mduigou, briangoetz Contributed-by: Brian Goetz , Paul Sandoz , Mike Duigou , Robert Field , Jim Gish ! test/Makefile + test/java/util/concurrent/atomic/AtomicReferenceTest.java + test/java/util/stream/bootlib/TEST.properties + test/java/util/stream/bootlib/java/util/stream/CollectorOps.java + test/java/util/stream/bootlib/java/util/stream/DoubleStreamTestDataProvider.java + test/java/util/stream/bootlib/java/util/stream/DoubleStreamTestScenario.java + test/java/util/stream/bootlib/java/util/stream/FlagDeclaringOp.java + test/java/util/stream/bootlib/java/util/stream/IntStreamTestDataProvider.java + test/java/util/stream/bootlib/java/util/stream/IntStreamTestScenario.java + test/java/util/stream/bootlib/java/util/stream/IntermediateTestOp.java + test/java/util/stream/bootlib/java/util/stream/LambdaTestHelpers.java + test/java/util/stream/bootlib/java/util/stream/LongStreamTestDataProvider.java + test/java/util/stream/bootlib/java/util/stream/LongStreamTestScenario.java + test/java/util/stream/bootlib/java/util/stream/OpTestCase.java + test/java/util/stream/bootlib/java/util/stream/SpliteratorTestHelper.java + test/java/util/stream/bootlib/java/util/stream/StatefulTestOp.java + test/java/util/stream/bootlib/java/util/stream/StatelessTestOp.java + test/java/util/stream/bootlib/java/util/stream/StreamOpFlagTestHelper.java + test/java/util/stream/bootlib/java/util/stream/StreamTestDataProvider.java + test/java/util/stream/bootlib/java/util/stream/StreamTestScenario.java + test/java/util/stream/bootlib/java/util/stream/TestData.java + test/java/util/stream/bootlib/java/util/stream/TestFlagExpectedOp.java + test/java/util/stream/boottest/TEST.properties + test/java/util/stream/boottest/java/util/stream/DoubleNodeTest.java + test/java/util/stream/boottest/java/util/stream/FlagOpTest.java + test/java/util/stream/boottest/java/util/stream/IntNodeTest.java + test/java/util/stream/boottest/java/util/stream/LongNodeTest.java + test/java/util/stream/boottest/java/util/stream/NodeBuilderTest.java + test/java/util/stream/boottest/java/util/stream/NodeTest.java + test/java/util/stream/boottest/java/util/stream/SpinedBufferTest.java + test/java/util/stream/boottest/java/util/stream/StreamFlagsTest.java + test/java/util/stream/boottest/java/util/stream/StreamOpFlagsTest.java + test/java/util/stream/boottest/java/util/stream/StreamReuseTest.java + test/java/util/stream/boottest/java/util/stream/UnorderedTest.java + test/java/util/stream/test/TEST.properties + test/java/util/stream/test/org/openjdk/tests/java/lang/invoke/DeserializeMethodTest.java + test/java/util/stream/test/org/openjdk/tests/java/lang/invoke/MHProxiesTest.java + test/java/util/stream/test/org/openjdk/tests/java/lang/invoke/SerializedLambdaTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/FillableStringTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/MapTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/NullArgsTestCase.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/CollectionAndMapModifyStreamTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/DistinctOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/DoublePrimitiveOpsTests.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/ExplodeOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/FilterOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/FindAnyOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/FindFirstOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/ForEachOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/GroupByOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/InfiniteStreamWithLimitOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/IntPrimitiveOpsTests.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/IntReduceTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/IntSliceOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/IntUniqOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/LongPrimitiveOpsTests.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/MapOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/MatchOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/MinMaxTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/PrimitiveAverageOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/PrimitiveSumTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/RangeTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/ReduceByOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/ReduceTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/SequentialOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/SliceOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/SortedOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/SpliteratorLateBindingFailFastTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/SpliteratorTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/SpliteratorTraversingAndSplittingTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/StreamBuilderTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/StreamLinkTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/StreamParSeqTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/StreamSpliteratorTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/SummaryStatisticsTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/TabulatorsTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/TeeOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/ToArrayOpTest.java + test/jdk/lambda/ArrayCtorRefTest.java + test/jdk/lambda/FDTest.java + test/jdk/lambda/LambdaTranslationCompoundSamTest.java + test/jdk/lambda/LambdaTranslationInInterface.java + test/jdk/lambda/LambdaTranslationInnerConstructor.java + test/jdk/lambda/LambdaTranslationTest1.java + test/jdk/lambda/LambdaTranslationTest2.java + test/jdk/lambda/MethodReferenceTestFDCCE.java + test/jdk/lambda/MethodReferenceTestInnerDefault.java + test/jdk/lambda/MethodReferenceTestInnerInstance.java + test/jdk/lambda/MethodReferenceTestInnerVarArgsThis.java + test/jdk/lambda/MethodReferenceTestInstance.java + test/jdk/lambda/MethodReferenceTestInstanceMethod.java + test/jdk/lambda/MethodReferenceTestKinds.java + test/jdk/lambda/MethodReferenceTestNew.java + test/jdk/lambda/MethodReferenceTestNewInner.java + test/jdk/lambda/MethodReferenceTestSueCase1.java + test/jdk/lambda/MethodReferenceTestSueCase2.java + test/jdk/lambda/MethodReferenceTestSueCase4.java + test/jdk/lambda/MethodReferenceTestSuper.java + test/jdk/lambda/MethodReferenceTestSuperDefault.java + test/jdk/lambda/MethodReferenceTestTypeConversion.java + test/jdk/lambda/MethodReferenceTestVarArgs.java + test/jdk/lambda/MethodReferenceTestVarArgsExt.java + test/jdk/lambda/MethodReferenceTestVarArgsSuper.java + test/jdk/lambda/MethodReferenceTestVarArgsSuperDefault.java + test/jdk/lambda/MethodReferenceTestVarArgsThis.java + test/jdk/lambda/TEST.properties + test/jdk/lambda/TestInnerCtorRef.java + test/jdk/lambda/TestPrivateCtorRef.java + test/jdk/lambda/separate/AttributeInjector.java + test/jdk/lambda/separate/ClassFile.java + test/jdk/lambda/separate/ClassFilePreprocessor.java + test/jdk/lambda/separate/ClassToInterfaceConverter.java + test/jdk/lambda/separate/Compiler.java + test/jdk/lambda/separate/DirectedClassLoader.java + test/jdk/lambda/separate/SourceModel.java + test/jdk/lambda/separate/TestHarness.java + test/jdk/lambda/shapegen/ClassCase.java + test/jdk/lambda/shapegen/Hierarchy.java + test/jdk/lambda/shapegen/HierarchyGenerator.java + test/jdk/lambda/shapegen/Rule.java + test/jdk/lambda/shapegen/RuleGroup.java + test/jdk/lambda/shapegen/TTNode.java + test/jdk/lambda/shapegen/TTParser.java + test/jdk/lambda/shapegen/TTShape.java + test/jdk/lambda/vm/DefaultMethodRegressionTests.java + test/jdk/lambda/vm/DefaultMethodsTest.java + test/jdk/lambda/vm/InterfaceAccessFlagsTest.java + test/jdk/lambda/vm/StrictfpDefault.java Changeset: 7d89b0dd973c Author: weijun Date: 2013-05-08 08:25 +0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/7d89b0dd973c 8012679: Let allow_weak_crypto default to false Reviewed-by: valeriep ! src/share/classes/sun/security/krb5/internal/crypto/EType.java ! test/sun/security/krb5/auto/DupEtypes.java ! test/sun/security/krb5/etype/WeakCrypto.java Changeset: c8f47674d105 Author: alanb Date: 2013-05-08 18:00 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/c8f47674d105 8013652: (profiles) Add javax.script to compact1 Reviewed-by: mchung, dholmes ! makefiles/profile-rtjar-includes.txt Changeset: 3fd83f282c61 Author: ksrini Date: 2013-05-07 13:15 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/3fd83f282c61 8013736: [launcher] cleanup code for correctness 8005735: [parfait] False positive integer overflow in jdk/src/solaris/bin/jexec.c 8009873: [parfait] Memory leak at jdk/src/share/bin/wildcard.c 8005807: [parfait] Undefined return value at jdk/src/share/bin/java.c Reviewed-by: alanb, martin ! src/share/bin/java.c ! src/share/bin/java.h ! src/share/bin/wildcard.c ! src/solaris/bin/jexec.c Changeset: bb9cdfac1a7d Author: juh Date: 2013-05-09 12:00 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/bb9cdfac1a7d 8007699: Move some tests from test/sun/security/provider/certpath/X509CertPath to closed repo Reviewed-by: mullan - test/sun/security/provider/certpath/X509CertPath/ForwardBuildCompromised.java - test/sun/security/provider/certpath/X509CertPath/ReverseBuildCompromised.java - test/sun/security/provider/certpath/X509CertPath/ValidateCompromised.java Changeset: 498ea4c3a4c6 Author: psandoz Date: 2013-05-01 18:40 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/498ea4c3a4c6 8012646: Pattern.splitAsStream Reviewed-by: forax, plevart, alanb Contributed-by: Ben Evans , Paul Sandoz ! src/share/classes/java/util/regex/Pattern.java ! test/java/util/regex/RegExTest.java Changeset: 78d08fc2dd12 Author: mullan Date: 2013-04-25 11:18 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/78d08fc2dd12 8011313: OCSP timeout set to wrong value if com.sun.security.ocsp.timeout not defined Reviewed-by: vinnie ! src/share/classes/sun/security/provider/certpath/OCSP.java Changeset: 3e282678a885 Author: mullan Date: 2013-04-25 15:48 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/3e282678a885 8013228: Create new system properties to control allowable OCSP clock skew and CRL connection timeout Reviewed-by: vinnie ! src/share/classes/sun/security/provider/certpath/CertPathHelper.java ! src/share/classes/sun/security/provider/certpath/DistributionPointFetcher.java ! src/share/classes/sun/security/provider/certpath/OCSPResponse.java ! src/share/classes/sun/security/provider/certpath/URICertStore.java Changeset: 7c4eb715c5e8 Author: ngthomas Date: 2013-04-30 21:49 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/7c4eb715c5e8 Merge Changeset: 12af7c32c648 Author: omajid Date: 2013-04-29 12:34 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/12af7c32c648 8013480: fix zero build on arm Reviewed-by: erikj ! makefiles/GensrcX11Wrappers.gmk Changeset: 7a96ead5ea89 Author: katleman Date: 2013-04-30 14:40 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/7a96ead5ea89 Merge Changeset: 55c7b90fe57e Author: katleman Date: 2013-05-01 14:59 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/55c7b90fe57e Merge Changeset: 8dbb4b159e04 Author: erikj Date: 2013-05-02 15:59 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/8dbb4b159e04 8013552: Add build support for different man pages for OpenJDK and OracleJDK Reviewed-by: tbell, omajid ! makefiles/Images.gmk Changeset: 1daef88acff2 Author: katleman Date: 2013-05-02 13:35 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/1daef88acff2 Added tag jdk8-b88 for changeset 8dbb4b159e04 ! .hgtags Changeset: b0c41789f500 Author: jgodinez Date: 2013-04-25 10:14 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/b0c41789f500 8009199: Printed text become garbage on Mac OSX Reviewed-by: bae, prr ! src/macosx/native/sun/awt/CTextPipe.m Changeset: f4aa34a7a44d Author: jchen Date: 2013-04-29 10:02 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/f4aa34a7a44d 8005302: [findbugs] public methods return internal arrays; may be private Reviewed-by: bae, prr ! src/share/classes/sun/java2d/pipe/AAShapePipe.java Changeset: 46686202aa23 Author: lana Date: 2013-04-30 22:43 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/46686202aa23 Merge Changeset: c70346f4c0a9 Author: pchelko Date: 2013-04-18 15:09 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/c70346f4c0a9 8011686: AWT accidentally disables the NSApplicationDelegate of SWT, causing loss of OS X integration functionality Reviewed-by: anthony, serb Contributed-by: Markus Persson ! src/macosx/native/sun/awt/awt.m Changeset: ac92ac05dde4 Author: kshefov Date: 2013-04-22 18:39 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/ac92ac05dde4 8011230: [TEST_BUG] java/awt/Toolkit/BadDisplayTest/BadDisplayTest.java failed on solaris Reviewed-by: serb, anthony ! test/java/awt/Toolkit/BadDisplayTest/BadDisplayTest.sh Changeset: 578fb8766200 Author: leonidr Date: 2013-04-22 19:24 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/578fb8766200 8008366: [macosx] ActionListener called twice for JMenuItem using ScreenMenuBar Reviewed-by: anthony, serb ! src/macosx/native/sun/awt/AWTEvent.h ! src/macosx/native/sun/awt/AWTEvent.m ! src/macosx/native/sun/awt/CMenuItem.m ! test/javax/swing/JMenuItem/ActionListenerCalledTwice/ActionListenerCalledTwiceTest.java Changeset: 0894b8476a49 Author: lana Date: 2013-04-23 15:17 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/0894b8476a49 Merge - src/share/classes/java/time/chrono/HijrahDeviationReader.java - src/share/classes/java/time/format/DateTimeBuilder.java - src/share/classes/java/time/format/DateTimeFormatStyleProvider.java - src/share/classes/java/time/temporal/Adjusters.java - src/share/classes/java/time/temporal/Queries.java - src/share/classes/sun/java2d/cmm/lcms/META-INF/services/sun.java2d.cmm.PCMM - src/share/native/java/lang/ResourceBundle.c - test/java/time/tck/java/time/TestChronology.java - test/java/time/tck/java/time/chrono/TestChronoLocalDate.java - test/java/time/tck/java/time/chrono/TestChronoLocalDateTime.java - test/java/time/tck/java/time/chrono/TestHijrahChronology.java - test/java/time/tck/java/time/chrono/TestJapaneseChronology.java - test/java/time/tck/java/time/chrono/TestMinguoChronology.java - test/java/time/tck/java/time/chrono/TestThaiBuddhistChronology.java - test/java/time/tck/java/time/temporal/TCKDateTimeAdjusters.java - test/java/time/tck/java/time/temporal/TestChronoLocalDate.java - test/java/time/tck/java/time/temporal/TestChronoLocalDateTime.java - test/java/time/tck/java/time/temporal/TestChronoZonedDateTime.java - test/java/time/test/java/time/temporal/TestDateTimeAdjusters.java - test/java/time/test/java/time/temporal/TestJapaneseChronoImpl.java - test/java/time/test/java/time/temporal/TestThaiBuddhistChronoImpl.java - test/java/util/ComparatorsTest.java Changeset: 7103434eefe2 Author: kshefov Date: 2013-04-24 11:48 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/7103434eefe2 8011186: [TEST_BUG] java/awt/Focus/OverrideRedirectWindowActivationTest/OverrideRedirectWindowActivationTest.java failed on windows 8 Reviewed-by: anthony, serb, ant - test/java/awt/Focus/OverrideRedirectWindowActivationTest/OverrideRedirectWindowActivationTest.java + test/java/awt/Focus/SimpleWindowActivationTest/SimpleWindowActivationTest.java Changeset: 854f60ec4bfb Author: anthony Date: 2013-04-26 18:48 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/854f60ec4bfb 8012586: [x11] Modal dialogs for fullscreen window may show behind its owner Summary: Use the _NET_WM_WINDOW_TYPE_DIALOG type for owned windows Reviewed-by: anthony, art, serb Contributed-by: Vladimir Kravets ! src/solaris/classes/sun/awt/X11/XWindowPeer.java + test/java/awt/WMSpecificTests/Metacity/FullscreenDialogModality.java Changeset: e76f3e8e653f Author: malenkov Date: 2013-04-29 16:42 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/e76f3e8e653f 8007458: [findbugs] One more beans issue, with ReflectionUtils Reviewed-by: art, alexsch ! src/share/classes/java/beans/MetaData.java - src/share/classes/java/beans/ReflectionUtils.java ! src/share/classes/java/beans/XMLEncoder.java ! test/java/beans/XMLEncoder/AbstractTest.java ! test/java/beans/XMLEncoder/BeanValidator.java ! test/java/beans/XMLEncoder/Test4631471.java ! test/java/beans/XMLEncoder/Test4679556.java ! test/java/beans/XMLEncoder/java_awt_BorderLayout.java + test/java/beans/XMLEncoder/java_awt_CardLayout.java + test/java/beans/XMLEncoder/java_awt_GridBagLayout.java ! test/java/beans/XMLEncoder/javax_swing_DefaultCellEditor.java Changeset: 358acb00cb2d Author: mcherkas Date: 2013-04-30 13:24 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/358acb00cb2d 8012004: JInternalFrame not being finalized after closing Reviewed-by: alexsch, alexp ! src/share/classes/javax/swing/JDesktopPane.java + test/javax/swing/JInternalFrame/InternalFrameIsNotCollectedTest.java Changeset: 31e111f82993 Author: serb Date: 2013-04-30 17:27 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/31e111f82993 7166296: closed/java/awt/Frame/DisabledParentOfToplevel/DisabledParentOfToplevel.html failed since 1.8.0b36 Reviewed-by: anthony, art ! src/macosx/classes/sun/lwawt/LWComponentPeer.java ! src/macosx/classes/sun/lwawt/LWWindowPeer.java ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Window.java ! src/windows/classes/sun/awt/windows/WComponentPeer.java ! src/windows/classes/sun/awt/windows/WWindowPeer.java Changeset: caeedce39396 Author: serb Date: 2013-05-01 12:19 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/caeedce39396 8009012: [macosx] DisplayChangedListener is not implemented in LWWindowPeer/CGraphicsEnvironment Reviewed-by: anthony, bae ! src/macosx/classes/sun/awt/CGraphicsDevice.java ! src/macosx/classes/sun/awt/CGraphicsEnvironment.java ! src/macosx/classes/sun/lwawt/LWWindowPeer.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/macosx/native/sun/awt/CGraphicsEnv.m ! src/macosx/native/sun/java2d/opengl/CGLLayer.m Changeset: c357c11f076f Author: lana Date: 2013-05-01 09:20 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/c357c11f076f Merge Changeset: 920ad6c95d93 Author: lana Date: 2013-05-01 11:27 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/920ad6c95d93 Merge - src/share/classes/java/beans/ReflectionUtils.java - test/java/awt/Focus/OverrideRedirectWindowActivationTest/OverrideRedirectWindowActivationTest.java Changeset: f6f2802f980c Author: lana Date: 2013-05-01 11:34 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/f6f2802f980c Merge - test/java/io/Serializable/accessConstants/AccessConstants.java - test/java/nio/file/Files/walkFileTree/walk_file_tree.sh - test/sun/reflect/CallerSensitive/MethodFinder.java Changeset: 336a110f1196 Author: lana Date: 2013-05-06 11:50 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/336a110f1196 Merge - src/share/classes/java/beans/ReflectionUtils.java - test/java/awt/Focus/OverrideRedirectWindowActivationTest/OverrideRedirectWindowActivationTest.java - test/java/io/Serializable/accessConstants/AccessConstants.java - test/java/nio/file/Files/walkFileTree/walk_file_tree.sh - test/sun/reflect/CallerSensitive/MethodFinder.java Changeset: 88125d32eb06 Author: andrew Date: 2013-05-04 17:04 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/88125d32eb06 8011366: Enable debug info on all libraries for OpenJDK builds Summary: The build should not be turning off debugging if it has been requested. Reviewed-by: erikj, dholmes ! makefiles/CompileNativeLibraries.gmk Changeset: 7ba77fff0ef6 Author: katleman Date: 2013-05-07 10:51 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/7ba77fff0ef6 Merge Changeset: 845025546e35 Author: katleman Date: 2013-05-07 13:13 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/845025546e35 Merge Changeset: 573a593379cb Author: lana Date: 2013-05-08 23:53 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/573a593379cb Merge ! makefiles/CompileNativeLibraries.gmk ! makefiles/Images.gmk - src/share/classes/java/beans/ReflectionUtils.java - test/java/awt/Focus/OverrideRedirectWindowActivationTest/OverrideRedirectWindowActivationTest.java Changeset: 2023e3d573eb Author: lana Date: 2013-05-09 14:23 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/2023e3d573eb Merge - test/sun/security/provider/certpath/X509CertPath/ForwardBuildCompromised.java - test/sun/security/provider/certpath/X509CertPath/ReverseBuildCompromised.java - test/sun/security/provider/certpath/X509CertPath/ValidateCompromised.java Changeset: ba74cd79e4f6 Author: jfranck Date: 2013-05-10 10:20 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/ba74cd79e4f6 8007073: Implement Core Reflection for Type Annotations on parameters Reviewed-by: darcy, abuckley ! src/share/classes/java/lang/reflect/Executable.java ! src/share/classes/java/lang/reflect/Field.java ! src/share/classes/java/lang/reflect/Parameter.java ! src/share/classes/sun/reflect/annotation/TypeAnnotation.java ! src/share/classes/sun/reflect/annotation/TypeAnnotationParser.java ! test/java/lang/annotation/TypeAnnotationReflection.java Changeset: 09a3b08c986f Author: alanb Date: 2013-05-10 14:53 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/09a3b08c986f 8011128: (fs) Files.createDirectory fails if the resolved path is exactly 248 characters long Reviewed-by: khazra, chegar ! src/windows/classes/sun/nio/fs/WindowsFileCopy.java ! src/windows/classes/sun/nio/fs/WindowsLinkSupport.java ! src/windows/classes/sun/nio/fs/WindowsPath.java + test/java/nio/file/Files/NameLimits.java Changeset: ece61e21782d Author: darcy Date: 2013-05-10 08:53 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/ece61e21782d 8014249: Add Modifer.parameterModifiers() Reviewed-by: mduigou, mchung ! src/share/classes/java/lang/reflect/Modifier.java Changeset: c26e0d29249a Author: rriggs Date: 2013-05-10 09:06 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/c26e0d29249a 8014296: DivModTests should not compare pointers Reviewed-by: darcy ! test/java/lang/Math/DivModTests.java Changeset: 2490769abdfa Author: mduigou Date: 2013-05-10 09:51 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/2490769abdfa 8014316: Use Method Refs in j.u.stream.MatchOps Reviewed-by: dholmes ! src/share/classes/java/util/stream/MatchOps.java Changeset: 9891e4d7d5b3 Author: mduigou Date: 2013-05-10 10:12 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/9891e4d7d5b3 Merge - src/share/classes/java/beans/ReflectionUtils.java - test/java/awt/Focus/OverrideRedirectWindowActivationTest/OverrideRedirectWindowActivationTest.java - test/sun/security/provider/certpath/X509CertPath/ForwardBuildCompromised.java - test/sun/security/provider/certpath/X509CertPath/ReverseBuildCompromised.java - test/sun/security/provider/certpath/X509CertPath/ValidateCompromised.java Changeset: f84b5498b2bb Author: darcy Date: 2013-05-10 12:25 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/f84b5498b2bb 8014357: Minor refactorings to sun.reflect.generics.reflectiveObjects.* Reviewed-by: mchung ! src/share/classes/sun/reflect/generics/reflectiveObjects/GenericArrayTypeImpl.java ! src/share/classes/sun/reflect/generics/reflectiveObjects/ParameterizedTypeImpl.java ! src/share/classes/sun/reflect/generics/reflectiveObjects/TypeVariableImpl.java ! src/share/classes/sun/reflect/generics/reflectiveObjects/WildcardTypeImpl.java Changeset: 90f715cceaae Author: dmeetry Date: 2013-05-10 23:56 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/90f715cceaae 7021870: GzipInputStream closes underlying stream during reading Reviewed-by: mduigou Contributed-by: ivan.gerasimov at oracle.com ! src/share/classes/java/util/zip/GZIPInputStream.java + test/java/util/zip/GZIP/GZIPInZip.java Changeset: 76998d11a643 Author: xuelei Date: 2013-05-13 05:41 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/76998d11a643 8005535: SSLSessionImpl should have protected finalize() Reviewed-by: weijun, wetmore ! src/share/classes/sun/security/ssl/SSLSessionImpl.java Changeset: 46db0e633240 Author: xuelei Date: 2013-05-13 06:05 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/46db0e633240 8005598: (reopened) Need to clone array of input/output parameters Reviewed-by: weijun ! src/share/classes/com/sun/jndi/dns/DnsContext.java ! src/share/classes/com/sun/jndi/ldap/BasicControl.java Changeset: 536678dffa97 Author: sundar Date: 2013-05-13 22:23 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/536678dffa97 8012975: Remove rhino from jdk8 Reviewed-by: alanb, tbell ! make/com/sun/Makefile - make/com/sun/script/Makefile ! make/sun/Makefile - make/sun/org/Makefile - make/sun/org/mozilla/Makefile - make/sun/org/mozilla/javascript/Makefile ! make/tools/src/build/tools/deps/refs.allowed ! makefiles/CopyFiles.gmk ! makefiles/CopyIntoClasses.gmk ! makefiles/profile-rtjar-includes.txt - src/share/classes/com/sun/script/javascript/ExternalScriptable.java - src/share/classes/com/sun/script/javascript/JSAdapter.java - src/share/classes/com/sun/script/javascript/JavaAdapter.java - src/share/classes/com/sun/script/javascript/META-INF/services/javax.script.ScriptEngineFactory - src/share/classes/com/sun/script/javascript/RhinoClassShutter.java - src/share/classes/com/sun/script/javascript/RhinoCompiledScript.java - src/share/classes/com/sun/script/javascript/RhinoScriptEngine.java - src/share/classes/com/sun/script/javascript/RhinoScriptEngineFactory.java - src/share/classes/com/sun/script/javascript/RhinoTopLevel.java - src/share/classes/com/sun/script/javascript/RhinoWrapFactory.java - src/share/classes/com/sun/script/util/BindingsBase.java - src/share/classes/com/sun/script/util/BindingsEntrySet.java - src/share/classes/com/sun/script/util/BindingsImpl.java - src/share/classes/com/sun/script/util/InterfaceImplementor.java - src/share/classes/com/sun/script/util/ScriptEngineFactoryBase.java Changeset: 6175fe5b07aa Author: bharadwaj Date: 2013-05-13 12:26 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/6175fe5b07aa 8008687: MethodHandle code: allow static and invokespecial calls to interface methods Summary: Changes to support invocation of lambda methods compiled either as static interface methods and or private instance methods. Reviewed-by: jrose, twisti ! src/share/classes/java/lang/invoke/MemberName.java Changeset: f7fcfb204a69 Author: mduigou Date: 2013-05-13 13:15 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/f7fcfb204a69 Merge - make/com/sun/script/Makefile - make/sun/org/Makefile - make/sun/org/mozilla/Makefile - make/sun/org/mozilla/javascript/Makefile - src/share/classes/com/sun/script/javascript/ExternalScriptable.java - src/share/classes/com/sun/script/javascript/JSAdapter.java - src/share/classes/com/sun/script/javascript/JavaAdapter.java - src/share/classes/com/sun/script/javascript/META-INF/services/javax.script.ScriptEngineFactory - src/share/classes/com/sun/script/javascript/RhinoClassShutter.java - src/share/classes/com/sun/script/javascript/RhinoCompiledScript.java - src/share/classes/com/sun/script/javascript/RhinoScriptEngine.java - src/share/classes/com/sun/script/javascript/RhinoScriptEngineFactory.java - src/share/classes/com/sun/script/javascript/RhinoTopLevel.java - src/share/classes/com/sun/script/javascript/RhinoWrapFactory.java - src/share/classes/com/sun/script/util/BindingsBase.java - src/share/classes/com/sun/script/util/BindingsEntrySet.java - src/share/classes/com/sun/script/util/BindingsImpl.java - src/share/classes/com/sun/script/util/InterfaceImplementor.java - src/share/classes/com/sun/script/util/ScriptEngineFactoryBase.java Changeset: 86c1e8c799f5 Author: khazra Date: 2013-05-13 13:48 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/86c1e8c799f5 8014254: Selector in HttpServer introduces a 1000 ms delay when using KeepAlive Summary: Rearrange event-handling code to remove bottle-neck. Also reviewed by mhall at mhcomputing.net. Reviewed-by: chegar, alanb ! src/share/classes/sun/net/httpserver/ServerImpl.java Changeset: ae35fdbab949 Author: sherman Date: 2013-05-13 20:35 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/ae35fdbab949 8013386: (tz) Support tzdata2013c Summary: updated tz data to version 2013c Reviewed-by: peytoia, okutsu ! make/sun/javazic/tzdata/VERSION ! make/sun/javazic/tzdata/africa ! make/sun/javazic/tzdata/antarctica ! make/sun/javazic/tzdata/asia ! make/sun/javazic/tzdata/australasia ! make/sun/javazic/tzdata/europe ! make/sun/javazic/tzdata/northamerica ! make/sun/javazic/tzdata/southamerica ! make/sun/javazic/tzdata/zone.tab ! src/share/classes/sun/util/calendar/ZoneInfoFile.java ! src/share/classes/sun/util/resources/TimeZoneNames.java ! src/share/classes/sun/util/resources/de/TimeZoneNames_de.java ! src/share/classes/sun/util/resources/es/TimeZoneNames_es.java ! src/share/classes/sun/util/resources/fr/TimeZoneNames_fr.java ! src/share/classes/sun/util/resources/it/TimeZoneNames_it.java ! src/share/classes/sun/util/resources/ja/TimeZoneNames_ja.java ! src/share/classes/sun/util/resources/ko/TimeZoneNames_ko.java ! src/share/classes/sun/util/resources/pt/TimeZoneNames_pt_BR.java ! src/share/classes/sun/util/resources/sv/TimeZoneNames_sv.java ! src/share/classes/sun/util/resources/zh/TimeZoneNames_zh_CN.java ! src/share/classes/sun/util/resources/zh/TimeZoneNames_zh_TW.java ! test/sun/util/calendar/zi/Rule.java ! test/sun/util/calendar/zi/tzdata/VERSION ! test/sun/util/calendar/zi/tzdata/africa ! test/sun/util/calendar/zi/tzdata/antarctica ! test/sun/util/calendar/zi/tzdata/asia ! test/sun/util/calendar/zi/tzdata/australasia ! test/sun/util/calendar/zi/tzdata/europe ! test/sun/util/calendar/zi/tzdata/northamerica ! test/sun/util/calendar/zi/tzdata/southamerica ! test/sun/util/calendar/zi/tzdata/zone.tab Changeset: a50bad038f31 Author: darcy Date: 2013-05-13 22:16 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/a50bad038f31 8014365: Restore Objects.requireNonNull(T, Supplier) Reviewed-by: mduigou ! src/share/classes/java/util/Objects.java ! test/java/util/Objects/BasicObjectsTest.java Changeset: 5bde43b1e463 Author: jlaskey Date: 2013-05-14 09:04 -0300 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/5bde43b1e463 Merge From james.laskey at oracle.com Tue May 14 05:37:08 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Tue, 14 May 2013 12:37:08 +0000 Subject: hg: nashorn/jdk8/langtools: 20 new changesets Message-ID: <20130514123806.93E6B48A5F@hg.openjdk.java.net> Changeset: 57648bad3287 Author: mchung Date: 2013-04-30 15:43 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/57648bad3287 8013531: Provide a utility class in com.sun.tools.classfile to find field/method references Reviewed-by: alanb ! src/share/classes/com/sun/tools/classfile/Dependencies.java + src/share/classes/com/sun/tools/classfile/ReferenceFinder.java Changeset: a1e10f3adc47 Author: katleman Date: 2013-04-25 09:24 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/a1e10f3adc47 Added tag jdk8-b87 for changeset 1329f9c38d93 ! .hgtags Changeset: 260013a710ef Author: lana Date: 2013-04-30 17:53 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/260013a710ef Merge Changeset: 8e27e84de2e9 Author: rfield Date: 2013-05-01 08:46 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/8e27e84de2e9 8011591: BootstrapMethodError when capturing constructor ref to local classes Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestNewInnerImplicitArgs.java Changeset: abd153854f16 Author: jjg Date: 2013-05-03 09:56 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/abd153854f16 8012728: Normalize @ignore comments on langtools tests Reviewed-by: vromero, mcimadamore ! test/com/sun/javadoc/_template/Template.java ! test/com/sun/javadoc/_template/TemplateComplete.java ! test/com/sun/javadoc/testTypeAnnotations/TestTypeAnnotations.java ! test/com/sun/javadoc/typeAnnotations/smoke/TestSmoke.java ! test/tools/javac/annotations/typeAnnotations/classfile/CombinationsTargetTest1.java ! test/tools/javac/annotations/typeAnnotations/classfile/CombinationsTargetTest2.java ! test/tools/javac/annotations/typeAnnotations/failures/CantAnnotateStaticClass.java ! test/tools/javac/annotations/typeAnnotations/newlocations/MultiCatch.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/MultiCatch.java ! test/tools/javac/defaultMethods/defaultMethodExecution/DefaultMethodRegressionTests.java ! test/tools/javac/generics/7034511/T7034511a.java ! test/tools/javac/generics/7034511/T7034511b.java ! test/tools/javac/generics/OverrideBridge.java ! test/tools/javac/lambda/TargetType36.java ! test/tools/javac/lambda/TargetType53.java ! test/tools/javac/lambda/TargetType54.java ! test/tools/javac/lambda/TargetType58.java ! test/tools/javac/lambda/TargetType59.java ! test/tools/javac/lambda/TargetType62.java ! test/tools/javac/processing/model/element/repeatingAnnotations/MixRepeatableAndOfficialContainerInheritedA1Test.java ! test/tools/javac/processing/model/element/repeatingAnnotations/MixRepeatableAndOfficialContainerInheritedB1Test.java ! test/tools/javac/processing/model/element/repeatingAnnotations/MixRepeatableAndOfficialContainerInheritedB2Test.java ! test/tools/javac/processing/model/element/repeatingAnnotations/RepeatableOverrideATest.java ! test/tools/javac/processing/model/element/repeatingAnnotations/RepeatableOverrideBTest.java ! test/tools/javap/output/RepeatingTypeAnnotations.java ! test/tools/javap/output/Tester.java Changeset: 38c4bade0ec1 Author: jjg Date: 2013-05-03 10:17 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/38c4bade0ec1 8002387: Improve rendered HTML formatting for {@code} Reviewed-by: ksrini ! src/share/classes/com/sun/tools/javadoc/Comment.java + test/com/sun/javadoc/testLiteralCodeInPre/TestLiteralCodeInPre.java + test/com/sun/javadoc/testLiteralCodeInPre/pkg/Test.java Changeset: a2889739cf21 Author: jjg Date: 2013-05-03 15:08 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/a2889739cf21 8000407: remove @GenerateNativeHeader Reviewed-by: vromero, darcy ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/jvm/JNIWriter.java - src/share/classes/javax/tools/annotation/GenerateNativeHeader.java ! test/tools/javac/nativeHeaders/NativeHeaderTest.java ! test/tools/javac/nativeHeaders/javahComparison/CompareTest.java - test/tools/javac/nativeHeaders/javahComparison/TestClass2.java - test/tools/javac/nativeHeaders/javahComparison/TestClass3.java Changeset: d918b63a5509 Author: jjg Date: 2013-05-03 17:44 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/d918b63a5509 8008768: Using {@inheritDoc} in simple tag defined via -tag fails Reviewed-by: jjg, mduigou Contributed-by: jonathan.gibbons at oracle.com, mike.duigou at oracle.com ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/InheritDocTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ParamTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ReturnTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/SeeTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/SimpleTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ThrowsTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocFinder.java + test/com/sun/javadoc/InheritDocForUserTags/DocTest.java + test/com/sun/javadoc/testSimpleTagInherit/TestSimpleTagInherit.java + test/com/sun/javadoc/testSimpleTagInherit/p/BaseClass.java + test/com/sun/javadoc/testSimpleTagInherit/p/TestClass.java Changeset: e8987ce7fb4b Author: darcy Date: 2013-05-05 21:04 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/e8987ce7fb4b 8013909: Fix doclint issues in javax.lang.model Reviewed-by: jjg ! src/share/classes/javax/annotation/processing/SupportedAnnotationTypes.java ! src/share/classes/javax/annotation/processing/SupportedOptions.java ! src/share/classes/javax/annotation/processing/SupportedSourceVersion.java ! src/share/classes/javax/lang/model/AnnotatedConstruct.java ! src/share/classes/javax/lang/model/element/NestingKind.java ! src/share/classes/javax/lang/model/util/ElementScanner6.java ! src/share/classes/javax/lang/model/util/Elements.java ! src/share/classes/javax/lang/model/util/Types.java Changeset: a7ff36d06fa2 Author: jlahoda Date: 2013-05-06 16:22 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/a7ff36d06fa2 8009724: Enhance the DocTree API with DocTreePath Summary: Adding DocTreePath and DocTreePathScanner similar to TreePath and TreePathScanner, respectively Reviewed-by: jjg Contributed-by: Ralph Benjamin Ruijs , Jan Lahoda + src/share/classes/com/sun/source/util/DocTreePath.java + src/share/classes/com/sun/source/util/DocTreePathScanner.java ! src/share/classes/com/sun/source/util/DocTrees.java ! src/share/classes/com/sun/tools/doclint/Checker.java ! src/share/classes/com/sun/tools/javac/api/JavacTrees.java + test/tools/javac/doctree/DocTreePathScannerTest.java ! test/tools/javac/doctree/ReferenceTest.java Changeset: 68142e69cafb Author: rfield Date: 2013-05-07 06:39 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/68142e69cafb 8014023: When a method reference to a local class constructor is contained in a method whose number of parameters matches the number of constructor parameters compilation fails Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java + test/tools/javac/lambda/methodReference/TreeMakerParamsIsGoofy.java Changeset: 43c2f7cb9c76 Author: jjg Date: 2013-05-07 14:27 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/43c2f7cb9c76 8004082: test/tools/javac/plugin/showtype/Test.java fails on windows: jtreg can't delete plugin.jar Reviewed-by: vromero, mcimadamore ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/main/Main.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java + src/share/classes/com/sun/tools/javac/util/ServiceLoader.java ! test/tools/javac/plugin/showtype/Test.java Changeset: 780014a234fa Author: jfranck Date: 2013-05-08 14:10 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/780014a234fa 8013485: javac can't handle annotations with a from a previous compilation unit Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/annotations/clinit/AnnoWithClinit1.java + test/tools/javac/annotations/clinit/AnnoWithClinitFail.java + test/tools/javac/annotations/clinit/AnnoWithClinitFail.out Changeset: adec2a5d510a Author: katleman Date: 2013-05-02 13:35 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/adec2a5d510a Added tag jdk8-b88 for changeset a1e10f3adc47 ! .hgtags Changeset: ec434cfd2752 Author: lana Date: 2013-05-06 11:53 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/ec434cfd2752 Merge - make/Makefile-classic Changeset: c68834236058 Author: lana Date: 2013-05-08 23:54 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/c68834236058 Merge Changeset: ce7e1674eb73 Author: alanb Date: 2013-05-10 16:10 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/ce7e1674eb73 8014318: tools/javac/profiles/ProfileOptionTest.java needs modifying now that javax.script is in compact1 Reviewed-by: mchung ! test/tools/javac/profiles/ProfileOptionTest.java Changeset: 1c43236f6d69 Author: darcy Date: 2013-05-10 14:31 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/1c43236f6d69 8014365: Restore Objects.requireNonNull(T, Supplier) Reviewed-by: jjg ! makefiles/BuildLangtools.gmk Changeset: e39669aea0bd Author: jjg Date: 2013-05-12 18:18 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/e39669aea0bd 8014363: javac test class ToolTester handles classpath incorrectly Reviewed-by: ksrini ! test/tools/javac/api/6406133/T6406133.java ! test/tools/javac/api/6410643/T6410643.java ! test/tools/javac/api/6411310/T6411310.java ! test/tools/javac/api/6411333/T6411333.java ! test/tools/javac/api/6412656/T6412656.java ! test/tools/javac/api/6415780/T6415780.java ! test/tools/javac/api/6418694/T6418694.java ! test/tools/javac/api/6421111/T6421111.java ! test/tools/javac/api/6421756/T6421756.java ! test/tools/javac/api/6422215/T6422215.java ! test/tools/javac/api/6422327/T6422327.java ! test/tools/javac/api/6423003/T6423003.java ! test/tools/javac/api/6431257/T6431257.java ! test/tools/javac/api/6437349/T6437349.java ! test/tools/javac/api/6437999/T6437999.java ! test/tools/javac/api/6440333/T6440333.java ! test/tools/javac/api/6440528/T6440528.java ! test/tools/javac/api/6468404/T6468404.java ! test/tools/javac/api/6731573/T6731573.java ! test/tools/javac/api/6733837/T6733837.java ! test/tools/javac/api/TestJavacTaskScanner.java ! test/tools/javac/api/guide/Test.java ! test/tools/javac/api/lib/ToolTester.java Changeset: 8dd528992c15 Author: jlahoda Date: 2013-05-10 15:15 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/8dd528992c15 8012929: Trees.getElement should work not only for declaration trees, but also for use-trees Reviewed-by: jjg Contributed-by: Dusan Balek , Jan Lahoda ! src/share/classes/com/sun/tools/doclint/Env.java ! src/share/classes/com/sun/tools/javac/api/JavacTrees.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java + test/tools/javac/api/TestGetElementReference.java + test/tools/javac/api/TestGetElementReferenceData.java From james.laskey at oracle.com Tue May 14 05:38:18 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Tue, 14 May 2013 12:38:18 +0000 Subject: hg: nashorn/jdk8/nashorn: 5 new changesets Message-ID: <20130514123823.6EC7448A60@hg.openjdk.java.net> Changeset: 40c107d1ae6f Author: katleman Date: 2013-04-25 09:24 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/40c107d1ae6f Added tag jdk8-b87 for changeset 774aeaa89bc1 ! .hgtags Changeset: 9fee4992f796 Author: lana Date: 2013-04-30 17:53 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/9fee4992f796 Merge Changeset: 501bc4aeb1b1 Author: katleman Date: 2013-05-02 13:35 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/501bc4aeb1b1 Added tag jdk8-b88 for changeset 40c107d1ae6f ! .hgtags Changeset: 45ce27fbe272 Author: lana Date: 2013-05-06 11:53 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/45ce27fbe272 Merge - src/jdk/nashorn/internal/codegen/Frame.java - src/jdk/nashorn/internal/ir/DoWhileNode.java - src/jdk/nashorn/internal/ir/LabeledNode.java Changeset: 264bb0af9e4e Author: jlaskey Date: 2013-05-14 09:05 -0300 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/264bb0af9e4e Merge - src/jdk/nashorn/internal/ir/LineNumberNode.java - src/jdk/nashorn/internal/ir/Location.java - src/jdk/nashorn/internal/runtime/SpillProperty.java - test/script/trusted/logcoverage.js From frank.westlake at gmail.com Tue May 14 07:12:14 2013 From: frank.westlake at gmail.com (Frank Westlake) Date: Tue, 14 May 2013 07:12:14 -0700 Subject: Packages Message-ID: <5192463E.1090709@gmail.com> From "A. Sundararajan" : > const android = Packages.android >does not work with nashorn. But the following should >work: > var android = Packages.android >You can still use "Packages.android" after defining the >above. Does that still work within importClass()? var android=Packages.android; importClass( android.app.Activity , android.content.Context , android.graphics.Typeface , android.view.Menu , android.view.SubMenu , android.widget.EditText , android.widget.HorizontalScrollView , android.widget.LinearLayout , android.widget.ScrollView , android.widget.TextView , android.widget.Toast , java.io.File ); Frank From james.laskey at oracle.com Tue May 14 07:17:20 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Tue, 14 May 2013 14:17:20 +0000 Subject: hg: nashorn/jdk8/nashorn: 2 new changesets Message-ID: <20130514141724.27CDA48A65@hg.openjdk.java.net> Changeset: 80d4db063d5a Author: jlaskey Date: 2013-05-14 11:15 -0300 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/80d4db063d5a 8014512: Exclude testing and infrastructure packages from code coverage Reviewed-by: sundar Contributed-by: james.laskey at oracle.com ! make/code_coverage.xml Changeset: eeed4db61215 Author: jlaskey Date: 2013-05-14 11:16 -0300 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/eeed4db61215 Merge - src/jdk/nashorn/internal/ir/LineNumberNode.java - src/jdk/nashorn/internal/ir/Location.java - test/script/trusted/logcoverage.js From sundararajan.athijegannathan at oracle.com Tue May 14 07:29:41 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Tue, 14 May 2013 19:59:41 +0530 Subject: Packages In-Reply-To: <5192463E.1090709@gmail.com> References: <5192463E.1090709@gmail.com> Message-ID: <51924A55.1060901@oracle.com> Yes - it should work. importClass and few other rhino specific extensions have been moved to "mozilla_compat.js". load("nashorn:mozilla_compat.js"); var util = Packages.java.util; importClass(util.HashMap); var m = new HashMap(); You can grab a recent jdk8 binary from https://jdk8.java.net/download.html. There is a shell tool called "jjs" in jdk/bin directory. Please do grab and play with it. And please report bugs/issues/problem you face with your javascript code. -Sundar On Tuesday 14 May 2013 07:42 PM, Frank Westlake wrote: > From "A. Sundararajan" : > > const android = Packages.android > > >does not work with nashorn. But the following should > >work: > > > var android = Packages.android > > >You can still use "Packages.android" after defining the > >above. > > Does that still work within importClass()? > > var android=Packages.android; > > importClass( > android.app.Activity > , android.content.Context > , android.graphics.Typeface > , android.view.Menu > , android.view.SubMenu > , android.widget.EditText > , android.widget.HorizontalScrollView > , android.widget.LinearLayout > , android.widget.ScrollView > , android.widget.TextView > , android.widget.Toast > , java.io.File > ); > > Frank From frank.westlake at gmail.com Tue May 14 07:33:40 2013 From: frank.westlake at gmail.com (Frank Westlake) Date: Tue, 14 May 2013 07:33:40 -0700 Subject: Packages In-Reply-To: <51924A55.1060901@oracle.com> References: <5192463E.1090709@gmail.com> <51924A55.1060901@oracle.com> Message-ID: <51924B44.1010808@gmail.com> 2013-05-14 07:29, A. Sundararajan: > Yes - it should work. Thank you. > You can grab a recent jdk8 binary ... And thanks for that too. Frank From sundararajan.athijegannathan at oracle.com Tue May 14 08:13:51 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Tue, 14 May 2013 20:43:51 +0530 Subject: Please review changes for JDK-8014519: scriptpad sample does not work with nashorn Message-ID: <519254AF.7050903@oracle.com> Please review http://cr.openjdk.java.net/~sundar/8014519/ This is a contribution by Andreas Rieber Thanks -Sundar From attila.szegedi at oracle.com Tue May 14 09:25:05 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Tue, 14 May 2013 18:25:05 +0200 Subject: Please review changes for JDK-8014519: scriptpad sample does not work with nashorn In-Reply-To: <519254AF.7050903@oracle.com> References: <519254AF.7050903@oracle.com> Message-ID: Hey Adreas, few things I'm curious about: - if (! (callback instanceof Function)) { + if (! (callback instanceof Function) && typeof callback !== "function") { When would you have a callback that is instanceof Function, but its typeof returns something other than "function"? function mbean(objName, async) { + var index; objName = objectName(objName); - var info = mbeanInfo(objName); + var info = mbeanInfo(objName); var attrs = info.attributes; var attrMap = new Object; - for (var index in attrs) { + for (index in attrs) { attrMap[attrs[index].name] = attrs[index]; } var opers = info.operations; var operMap = new Object; - for (var index in opers) { + for (index in opers) { operMap[opers[index].name] = opers[index]; } What do we gain from extracting "var index" from loop declarations into a function-level variable? // allocate an integer array of "big enough" size! var a = java.lang.reflect.Array.newInstance( - java.lang.Integer.TYPE, 1024*1024); - -// loop forever! -while (true); + java.lang.Integer.TYPE, input * 1024 * 1024); I know this doesn't pertain to the reason for this being in the patch, just wanted to note that in Nashorn you can use Java.type() to obtain the type for int[], and you can subsequently use that as a constructor to instantiate a new Java int array: var a = new (Java.type("int[]"))(input * 1024 * 1024) You don't have to go through java.lang.reflect.Array. Regards, Attila. On May 14, 2013, at 5:13 PM, "A. Sundararajan" wrote: > Please review http://cr.openjdk.java.net/~sundar/8014519/ > > This is a contribution by Andreas Rieber > > Thanks > -Sundar From rieberandreas at gmail.com Tue May 14 09:42:19 2013 From: rieberandreas at gmail.com (Andreas Rieber) Date: Tue, 14 May 2013 18:42:19 +0200 Subject: Please review changes for JDK-8014519: scriptpad sample does not work with nashorn In-Reply-To: References: <519254AF.7050903@oracle.com> Message-ID: <5192696B.1030403@gmail.com> Answers inline... On 14.05.13 18:25, Attila Szegedi wrote: > Hey Adreas, > > few things I'm curious about: > > - if (! (callback instanceof Function)) { > + if (! (callback instanceof Function) && typeof callback !== "function") { > > When would you have a callback that is instanceof Function, but its typeof returns something other than "function"? Patch is already some days old but as i remember it was Rhino/Nashorn differences and the case when someone would try: setTimeout( "print('something')", 2000); > > function mbean(objName, async) { > + var index; > objName = objectName(objName); > - var info = mbeanInfo(objName); > + var info = mbeanInfo(objName); > var attrs = info.attributes; > var attrMap = new Object; > - for (var index in attrs) { > + for (index in attrs) { > attrMap[attrs[index].name] = attrs[index]; > } > var opers = info.operations; > var operMap = new Object; > - for (var index in opers) { > + for (index in opers) { > operMap[opers[index].name] = opers[index]; > } > > What do we gain from extracting "var index" from loop declarations into a function-level variable? The 'var index' has function scope, so a second 'var index' is wrong. There is no block scope in javascript ;-) > > // allocate an integer array of "big enough" size! > var a = java.lang.reflect.Array.newInstance( > - java.lang.Integer.TYPE, 1024*1024); > - > -// loop forever! > -while (true); > + java.lang.Integer.TYPE, input * 1024 * 1024); > > I know this doesn't pertain to the reason for this being in the patch, just wanted to note that in Nashorn you can use Java.type() to obtain the type for int[], and you can subsequently use that as a constructor to instantiate a new Java int array: > > var a = new (Java.type("int[]"))(input * 1024 * 1024) > > You don't have to go through java.lang.reflect.Array. True, i didn't change that to keep Nashorn and Rhino working. Now it could be changed the Nashorn way. cheers Andreas > > Regards, > Attila. > > On May 14, 2013, at 5:13 PM, "A. Sundararajan" wrote: > >> Please review http://cr.openjdk.java.net/~sundar/8014519/ >> >> This is a contribution by Andreas Rieber >> >> Thanks >> -Sundar From attila.szegedi at oracle.com Tue May 14 09:46:43 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Tue, 14 May 2013 18:46:43 +0200 Subject: Please review changes for JDK-8014519: scriptpad sample does not work with nashorn In-Reply-To: <5192696B.1030403@gmail.com> References: <519254AF.7050903@oracle.com> <5192696B.1030403@gmail.com> Message-ID: <4663882F-7899-4173-BD9D-A2D1D38D9311@oracle.com> Thanks; +1 from me for committing this. On May 14, 2013, at 6:42 PM, Andreas Rieber wrote: > Answers inline... > > On 14.05.13 18:25, Attila Szegedi wrote: >> Hey Adreas, >> >> few things I'm curious about: >> >> - if (! (callback instanceof Function)) { >> + if (! (callback instanceof Function) && typeof callback !== "function") { >> >> When would you have a callback that is instanceof Function, but its typeof returns something other than "function"? > Patch is already some days old but as i remember it was Rhino/Nashorn differences and the case when someone would try: > > setTimeout( "print('something')", 2000); > >> >> function mbean(objName, async) { >> + var index; >> objName = objectName(objName); >> - var info = mbeanInfo(objName); >> + var info = mbeanInfo(objName); >> var attrs = info.attributes; >> var attrMap = new Object; >> - for (var index in attrs) { >> + for (index in attrs) { >> attrMap[attrs[index].name] = attrs[index]; >> } >> var opers = info.operations; >> var operMap = new Object; >> - for (var index in opers) { >> + for (index in opers) { >> operMap[opers[index].name] = opers[index]; >> } >> >> What do we gain from extracting "var index" from loop declarations into a function-level variable? > The 'var index' has function scope, so a second 'var index' is wrong. There is no block scope in javascript ;-) > >> >> // allocate an integer array of "big enough" size! >> var a = java.lang.reflect.Array.newInstance( >> - java.lang.Integer.TYPE, 1024*1024); >> - >> -// loop forever! >> -while (true); >> + java.lang.Integer.TYPE, input * 1024 * 1024); >> >> I know this doesn't pertain to the reason for this being in the patch, just wanted to note that in Nashorn you can use Java.type() to obtain the type for int[], and you can subsequently use that as a constructor to instantiate a new Java int array: >> >> var a = new (Java.type("int[]"))(input * 1024 * 1024) >> >> You don't have to go through java.lang.reflect.Array. > True, i didn't change that to keep Nashorn and Rhino working. Now it could be changed the Nashorn way. > > cheers > Andreas > >> >> Regards, >> Attila. >> >> On May 14, 2013, at 5:13 PM, "A. Sundararajan" wrote: >> >>> Please review http://cr.openjdk.java.net/~sundar/8014519/ >>> >>> This is a contribution by Andreas Rieber >>> >>> Thanks >>> -Sundar > > From james.laskey at oracle.com Tue May 14 09:52:03 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Tue, 14 May 2013 13:52:03 -0300 Subject: Please review changes for JDK-8014519: scriptpad sample does not work with nashorn In-Reply-To: <519254AF.7050903@oracle.com> References: <519254AF.7050903@oracle.com> Message-ID: <39D65A93-C332-422C-A309-AACA813319AF@oracle.com> +1 On 2013-05-14, at 12:13 PM, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~sundar/8014519/ > > This is a contribution by Andreas Rieber > > Thanks > -Sundar From attila.szegedi at oracle.com Tue May 14 09:55:39 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Tue, 14 May 2013 18:55:39 +0200 Subject: Review request for JDK-8011718 Message-ID: <30E439E8-AEA5-4A57-BA04-D8898000E3BE@oracle.com> Please review JDK-8011718 at http://cr.openjdk.java.net/~attila/8011718/webrev.00 Thanks, Attila. From james.laskey at oracle.com Tue May 14 10:02:29 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Tue, 14 May 2013 14:02:29 -0300 Subject: Review request for JDK-8011718 In-Reply-To: <30E439E8-AEA5-4A57-BA04-D8898000E3BE@oracle.com> References: <30E439E8-AEA5-4A57-BA04-D8898000E3BE@oracle.com> Message-ID: <7094253D-9DE8-41D7-9541-AFF1784A076E@oracle.com> +1 On 2013-05-14, at 1:55 PM, Attila Szegedi wrote: > Please review JDK-8011718 at http://cr.openjdk.java.net/~attila/8011718/webrev.00 > > Thanks, > Attila. From sundararajan.athijegannathan at oracle.com Tue May 14 10:10:01 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Tue, 14 May 2013 22:40:01 +0530 Subject: Please review changes for JDK-8014519: scriptpad sample does not work with nashorn In-Reply-To: <4663882F-7899-4173-BD9D-A2D1D38D9311@oracle.com> References: <519254AF.7050903@oracle.com> <5192696B.1030403@gmail.com> <4663882F-7899-4173-BD9D-A2D1D38D9311@oracle.com> Message-ID: <51926FE9.8020604@oracle.com> Hi Andreas, I pushed your scriptpad patch to jdk8-tl. Thanks for your contribution! -Sundar On Tuesday 14 May 2013 10:16 PM, Attila Szegedi wrote: > Thanks; +1 from me for committing this. > > On May 14, 2013, at 6:42 PM, Andreas Rieber wrote: > >> Answers inline... >> >> On 14.05.13 18:25, Attila Szegedi wrote: >>> Hey Adreas, >>> >>> few things I'm curious about: >>> >>> - if (! (callback instanceof Function)) { >>> + if (! (callback instanceof Function) && typeof callback !== "function") { >>> >>> When would you have a callback that is instanceof Function, but its typeof returns something other than "function"? >> Patch is already some days old but as i remember it was Rhino/Nashorn differences and the case when someone would try: >> >> setTimeout( "print('something')", 2000); >> >>> function mbean(objName, async) { >>> + var index; >>> objName = objectName(objName); >>> - var info = mbeanInfo(objName); >>> + var info = mbeanInfo(objName); >>> var attrs = info.attributes; >>> var attrMap = new Object; >>> - for (var index in attrs) { >>> + for (index in attrs) { >>> attrMap[attrs[index].name] = attrs[index]; >>> } >>> var opers = info.operations; >>> var operMap = new Object; >>> - for (var index in opers) { >>> + for (index in opers) { >>> operMap[opers[index].name] = opers[index]; >>> } >>> >>> What do we gain from extracting "var index" from loop declarations into a function-level variable? >> The 'var index' has function scope, so a second 'var index' is wrong. There is no block scope in javascript ;-) >> >>> // allocate an integer array of "big enough" size! >>> var a = java.lang.reflect.Array.newInstance( >>> - java.lang.Integer.TYPE, 1024*1024); >>> - >>> -// loop forever! >>> -while (true); >>> + java.lang.Integer.TYPE, input * 1024 * 1024); >>> >>> I know this doesn't pertain to the reason for this being in the patch, just wanted to note that in Nashorn you can use Java.type() to obtain the type for int[], and you can subsequently use that as a constructor to instantiate a new Java int array: >>> >>> var a = new (Java.type("int[]"))(input * 1024 * 1024) >>> >>> You don't have to go through java.lang.reflect.Array. >> True, i didn't change that to keep Nashorn and Rhino working. Now it could be changed the Nashorn way. >> >> cheers >> Andreas >> >>> Regards, >>> Attila. >>> >>> On May 14, 2013, at 5:13 PM, "A. Sundararajan" wrote: >>> >>>> Please review http://cr.openjdk.java.net/~sundar/8014519/ >>>> >>>> This is a contribution by Andreas Rieber >>>> >>>> Thanks >>>> -Sundar >> From sundararajan.athijegannathan at oracle.com Tue May 14 10:11:35 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Tue, 14 May 2013 22:41:35 +0530 Subject: Review request for JDK-8011718 In-Reply-To: <30E439E8-AEA5-4A57-BA04-D8898000E3BE@oracle.com> References: <30E439E8-AEA5-4A57-BA04-D8898000E3BE@oracle.com> Message-ID: <51927047.2030201@oracle.com> +1 -Sundar On Tuesday 14 May 2013 10:25 PM, Attila Szegedi wrote: > Please review JDK-8011718 at http://cr.openjdk.java.net/~attila/8011718/webrev.00 > > Thanks, > Attila. From attila.szegedi at oracle.com Tue May 14 10:18:22 2013 From: attila.szegedi at oracle.com (attila.szegedi at oracle.com) Date: Tue, 14 May 2013 17:18:22 +0000 Subject: hg: nashorn/jdk8/nashorn: 8011718: binding already bound function with extra arguments fails Message-ID: <20130514171825.5502548A7B@hg.openjdk.java.net> Changeset: fc20983ef38e Author: attila Date: 2013-05-14 19:18 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/fc20983ef38e 8011718: binding already bound function with extra arguments fails Reviewed-by: jlaskey, sundar ! src/jdk/nashorn/internal/runtime/ScriptFunctionData.java + test/script/basic/JDK-8011718.js + test/script/basic/JDK-8011718.js.EXPECTED From marcus.lagergren at oracle.com Tue May 14 11:00:54 2013 From: marcus.lagergren at oracle.com (marcus.lagergren at oracle.com) Date: Tue, 14 May 2013 18:00:54 +0000 Subject: hg: nashorn/jdk8/nashorn: 8014426: Original exception no longer thrown away when a finally rethrows Message-ID: <20130514180055.F124A48A7E@hg.openjdk.java.net> Changeset: f88a4818a4dc Author: lagergren Date: 2013-05-14 19:56 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/f88a4818a4dc 8014426: Original exception no longer thrown away when a finally rethrows Reviewed-by: attila, jlaskey ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/Lower.java ! src/jdk/nashorn/internal/ir/CatchNode.java ! src/jdk/nashorn/internal/ir/ThrowNode.java ! src/jdk/nashorn/internal/parser/Parser.java + test/script/basic/JDK-8014426.js + test/script/basic/JDK-8014426.js.EXPECTED From attila.szegedi at oracle.com Tue May 14 13:14:52 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Tue, 14 May 2013 22:14:52 +0200 Subject: Review request for JDK-8012359 - Increase code coverage in Joni In-Reply-To: <51921CE7.9030609@oracle.com> References: <51921CE7.9030609@oracle.com> Message-ID: <76A5FEB9-F8DD-431D-82C0-963EC3A5045A@oracle.com> +1 Huge surgical-precision axing effort. Tip o' the hat. On May 14, 2013, at 1:15 PM, Hannes Wallnoefer wrote: > Please review JDK-8012359 - Increase code coverage in Joni: > > http://cr.openjdk.java.net/~hannesw/8012359/ > > This removes most code we do not use in Joni, including regexp features not used in ECMAScript, alternative implementations of features, and things left over from multibyte encoding support. > > I tested with ant test and test262, currently running Node tests. > > Hannes From attila.szegedi at oracle.com Wed May 15 00:40:59 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Wed, 15 May 2013 09:40:59 +0200 Subject: Review request for JDK-8014639 Message-ID: <580A0DFC-C225-4C9B-8902-E978EAD1E6F3@oracle.com> Please review JDK-8014639 at http://cr.openjdk.java.net/~attila/8014639/webrev.00 Thanks, Attila. From marcus.lagergren at oracle.com Wed May 15 00:46:15 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Wed, 15 May 2013 09:46:15 +0200 Subject: Review request for JDK-8014639 In-Reply-To: <580A0DFC-C225-4C9B-8902-E978EAD1E6F3@oracle.com> References: <580A0DFC-C225-4C9B-8902-E978EAD1E6F3@oracle.com> Message-ID: <1D721193-81A3-49F0-B872-63EF728F0464@oracle.com> +1 But - why is debug=true enabled anywhere? I don't think the various scripts in the build dir should have it default enabled either, certainly not jjs. Or? I use bin/jjs for bootstrapping various benchmarks and have given it no second thought. /M On May 15, 2013, at 9:40 AM, Attila Szegedi wrote: > Please review JDK-8014639 at http://cr.openjdk.java.net/~attila/8014639/webrev.00 > > Thanks, > Attila. From hannes.wallnoefer at oracle.com Wed May 15 00:53:01 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Wed, 15 May 2013 09:53:01 +0200 Subject: Review request for JDK-8014639 In-Reply-To: <580A0DFC-C225-4C9B-8902-E978EAD1E6F3@oracle.com> References: <580A0DFC-C225-4C9B-8902-E978EAD1E6F3@oracle.com> Message-ID: <51933EDD.2070800@oracle.com> +1 Am 2013-05-15 09:40, schrieb Attila Szegedi: > Please review JDK-8014639 at http://cr.openjdk.java.net/~attila/8014639/webrev.00 > > Thanks, > Attila. From attila.szegedi at oracle.com Wed May 15 01:28:25 2013 From: attila.szegedi at oracle.com (attila.szegedi at oracle.com) Date: Wed, 15 May 2013 08:28:25 +0000 Subject: hg: nashorn/jdk8/nashorn: 8014639: Remove debug flag from test runs Message-ID: <20130515082827.20B0E48AAA@hg.openjdk.java.net> Changeset: 64ef1aeaeb4e Author: attila Date: 2013-05-15 10:28 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/64ef1aeaeb4e 8014639: Remove debug flag from test runs Reviewed-by: hannesw, lagergren ! make/project.properties From sundararajan.athijegannathan at oracle.com Wed May 15 02:39:14 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Wed, 15 May 2013 15:09:14 +0530 Subject: Review request for JDK-8014639 In-Reply-To: <580A0DFC-C225-4C9B-8902-E978EAD1E6F3@oracle.com> References: <580A0DFC-C225-4C9B-8902-E978EAD1E6F3@oracle.com> Message-ID: <519357C2.6070003@oracle.com> +1 -Sundar On Wednesday 15 May 2013 01:10 PM, Attila Szegedi wrote: > Please review JDK-8014639 at http://cr.openjdk.java.net/~attila/8014639/webrev.00 > > Thanks, > Attila. From attila.szegedi at oracle.com Wed May 15 04:11:59 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Wed, 15 May 2013 13:11:59 +0200 Subject: Review request for JDK-8014646 Message-ID: Please review JDK-8014646 at http://cr.openjdk.java.net/~attila/8014646/webrev.00 Thanks, Attila. From james.laskey at oracle.com Wed May 15 04:27:22 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Wed, 15 May 2013 08:27:22 -0300 Subject: Review request for JDK-8014646 In-Reply-To: References: Message-ID: <2B24FA5A-313F-4E28-8D70-D6A737145B9D@oracle.com> +1 On 2013-05-15, at 8:11 AM, Attila Szegedi wrote: > Please review JDK-8014646 at http://cr.openjdk.java.net/~attila/8014646/webrev.00 > > Thanks, > Attila. From sundararajan.athijegannathan at oracle.com Wed May 15 04:28:24 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Wed, 15 May 2013 16:58:24 +0530 Subject: Review request for JDK-8012305 Function.bind can't be called on prototype function inside constructor Message-ID: <51937158.20100@oracle.com> Please review http://cr.openjdk.java.net/~sundar/8012305/ Note that the bug has been fixed already - I'm just adding a regression test for future. Thanks -Sundar From hannes.wallnoefer at oracle.com Wed May 15 04:46:19 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Wed, 15 May 2013 13:46:19 +0200 Subject: Review request for JDK-8014646 In-Reply-To: References: Message-ID: <5193758B.7020605@oracle.com> I found one typo: "s selected" instead of "is selected". Other than that a very nice improvement to our docs. Hannes Am 2013-05-15 13:11, schrieb Attila Szegedi: > Please review JDK-8014646 at http://cr.openjdk.java.net/~attila/8014646/webrev.00 > > Thanks, > Attila. From attila.szegedi at oracle.com Wed May 15 05:54:31 2013 From: attila.szegedi at oracle.com (attila.szegedi at oracle.com) Date: Wed, 15 May 2013 12:54:31 +0000 Subject: hg: nashorn/jdk8/nashorn: 8014646: Update the Java interop documentation in the Java Scripting Programmer's Guide Message-ID: <20130515125432.E71A848ABF@hg.openjdk.java.net> Changeset: b37eb709ae27 Author: attila Date: 2013-05-15 14:54 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/b37eb709ae27 8014646: Update the Java interop documentation in the Java Scripting Programmer's Guide Reviewed-by: jlaskey, hannesw, lagergren ! docs/JavaScriptingProgrammersGuide.html From attila.szegedi at oracle.com Wed May 15 06:02:24 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Wed, 15 May 2013 15:02:24 +0200 Subject: Review request for JDK-8012305 Function.bind can't be called on prototype function inside constructor In-Reply-To: <51937158.20100@oracle.com> References: <51937158.20100@oracle.com> Message-ID: +1 On May 15, 2013, at 1:28 PM, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~sundar/8012305/ > > Note that the bug has been fixed already - I'm just adding a regression test for future. > > Thanks > -Sundar From attila.szegedi at oracle.com Wed May 15 06:05:43 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Wed, 15 May 2013 15:05:43 +0200 Subject: Review request for JDK-8014647 Message-ID: Please review JDK-8014647 at http://cr.openjdk.java.net/~attila/8014647/webrev.00 Thanks, Attila. From hannes.wallnoefer at oracle.com Wed May 15 06:29:28 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Wed, 15 May 2013 15:29:28 +0200 Subject: Review request for JDK-8014647 In-Reply-To: References: Message-ID: <51938DB8.4070304@oracle.com> +1 Am 2013-05-15 15:05, schrieb Attila Szegedi: > Please review JDK-8014647 at http://cr.openjdk.java.net/~attila/8014647/webrev.00 > > Thanks, > Attila. From sundararajan.athijegannathan at oracle.com Wed May 15 07:06:27 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Wed, 15 May 2013 19:36:27 +0530 Subject: Review request for JDK-8014647 In-Reply-To: References: Message-ID: <51939663.2040502@oracle.com> +1 -Sundar On Wednesday 15 May 2013 06:35 PM, Attila Szegedi wrote: > Please review JDK-8014647 at http://cr.openjdk.java.net/~attila/8014647/webrev.00 > > Thanks, > Attila. From james.laskey at oracle.com Wed May 15 07:15:10 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Wed, 15 May 2013 11:15:10 -0300 Subject: Review request for JDK-8014647 In-Reply-To: References: Message-ID: <2A78AD9D-A31E-4E34-BF9A-79F442793344@oracle.com> +1 On 2013-05-15, at 10:05 AM, Attila Szegedi wrote: > Please review JDK-8014647 at http://cr.openjdk.java.net/~attila/8014647/webrev.00 > > Thanks, > Attila. From sundararajan.athijegannathan at oracle.com Wed May 15 07:15:29 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Wed, 15 May 2013 14:15:29 +0000 Subject: hg: nashorn/jdk8/nashorn: 8012305: Function.bind can't be called on prototype function inside constructor Message-ID: <20130515141531.248EA48AC4@hg.openjdk.java.net> Changeset: 1eaa542cc8e2 Author: sundar Date: 2013-05-15 19:45 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/1eaa542cc8e2 8012305: Function.bind can't be called on prototype function inside constructor Reviewed-by: lagergren, attila + test/script/basic/JDK-8012305.js + test/script/basic/JDK-8012305.js.EXPECTED From james.laskey at oracle.com Wed May 15 08:10:08 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Wed, 15 May 2013 15:10:08 +0000 Subject: hg: nashorn/jdk8/nashorn: 8014648: Exclude testing and infrastructure packages from code coverage, round two Message-ID: <20130515151010.7AE6A48ACB@hg.openjdk.java.net> Changeset: 6344644b81ec Author: jlaskey Date: 2013-05-15 12:09 -0300 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/6344644b81ec 8014648: Exclude testing and infrastructure packages from code coverage, round two Reviewed-by: sundar Contributed-by: james.laskey at oracle.com ! make/code_coverage.xml ! src/jdk/nashorn/internal/runtime/options/Option.java ! src/jdk/nashorn/internal/runtime/options/Options.java - src/jdk/nashorn/internal/runtime/options/ValueOption.java ! test/script/basic/allgettersetters.js From attila.szegedi at oracle.com Wed May 15 11:22:11 2013 From: attila.szegedi at oracle.com (attila.szegedi at oracle.com) Date: Wed, 15 May 2013 18:22:11 +0000 Subject: hg: nashorn/jdk8/nashorn: 8014647: Allow class-based overrides to be initialized with a ScriptFunction Message-ID: <20130515182217.139A348AD5@hg.openjdk.java.net> Changeset: 19e9cd9c7010 Author: attila Date: 2013-05-15 20:21 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/19e9cd9c7010 8014647: Allow class-based overrides to be initialized with a ScriptFunction Reviewed-by: hannesw, jlaskey, sundar ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterBytecodeGenerator.java + test/script/basic/JDK-8014647.js + test/script/basic/JDK-8014647.js.EXPECTED From sundararajan.athijegannathan at oracle.com Wed May 15 23:00:11 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Thu, 16 May 2013 11:30:11 +0530 Subject: OCA please.. Message-ID: <519475EB.8050208@oracle.com> Hi Andr?, You sent out a fix for Math.round to this alias. Marcus had filed bug //JDK-8011023 to track it. But, to push your fix to openJDK, we need you to sign OCA. Details on Oracle SCA here: http://openjdk.java.net/contribute/ Will you please sign OCA to move forward? Thanks -Sundar / / From sundararajan.athijegannathan at oracle.com Thu May 16 01:40:11 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Thu, 16 May 2013 14:10:11 +0530 Subject: Review request for JDK-8009141: Avoid netscape.javascript.JSObject in nashorn code Message-ID: <51949B6B.40500@oracle.com> Please review http://cr.openjdk.java.net/~sundar/8009141/ Thanks, -Sundar From hannes.wallnoefer at oracle.com Thu May 16 02:05:19 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Thu, 16 May 2013 11:05:19 +0200 Subject: Review request for JDK-8009141: Avoid netscape.javascript.JSObject in nashorn code In-Reply-To: <51949B6B.40500@oracle.com> References: <51949B6B.40500@oracle.com> Message-ID: <5194A14F.6040203@oracle.com> +1 Am 2013-05-16 10:40, schrieb A. Sundararajan: > Please review http://cr.openjdk.java.net/~sundar/8009141/ > > Thanks, > -Sundar From sundararajan.athijegannathan at oracle.com Thu May 16 02:23:16 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Thu, 16 May 2013 09:23:16 +0000 Subject: hg: nashorn/jdk8/nashorn: 8009141: Avoid netscape.javascript.JSObject in nashorn code Message-ID: <20130516092319.AF50848AF7@hg.openjdk.java.net> Changeset: ac14a1fb0cab Author: sundar Date: 2013-05-16 14:52 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/ac14a1fb0cab 8009141: Avoid netscape.javascript.JSObject in nashorn code Reviewed-by: lagergren, hannesw + src/jdk/nashorn/api/scripting/JSObject.java ! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java ! src/jdk/nashorn/internal/runtime/linker/JSObjectLinker.java - src/netscape/javascript/JSObject.java ! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java From marcus.lagergren at oracle.com Thu May 16 04:17:15 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Thu, 16 May 2013 04:17:15 -0700 (PDT) Subject: Pls review http://cr.openjdk.java.net/~lagergren/8013919/webrev/ Message-ID: <7a401114-942b-48ee-8d63-de003ee32ab8@default> Can I get a review for the namespace collision problem described in JDK-8013919? We should probably make Attila's function declaration placement warnings default. This is stupid. http://cr.openjdk.java.net/~lagergren/8013919/webrev/ /M From james.laskey at oracle.com Thu May 16 04:25:01 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Thu, 16 May 2013 08:25:01 -0300 Subject: Review request for JDK-8009141: Avoid netscape.javascript.JSObject in nashorn code In-Reply-To: <51949B6B.40500@oracle.com> References: <51949B6B.40500@oracle.com> Message-ID: +1 On 2013-05-16, at 5:40 AM, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~sundar/8009141/ > > Thanks, > -Sundar From sundararajan.athijegannathan at oracle.com Thu May 16 04:32:00 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Thu, 16 May 2013 17:02:00 +0530 Subject: Pls review http://cr.openjdk.java.net/~lagergren/8013919/webrev/ In-Reply-To: <7a401114-942b-48ee-8d63-de003ee32ab8@default> References: <7a401114-942b-48ee-8d63-de003ee32ab8@default> Message-ID: <5194C3B0.5090408@oracle.com> +1 -Sundar On Thursday 16 May 2013 04:47 PM, Marcus Lagergren wrote: > Can I get a review for the namespace collision problem described in JDK-8013919? We should probably make Attila's function declaration placement warnings default. This is stupid. > > http://cr.openjdk.java.net/~lagergren/8013919/webrev/ > > /M From james.laskey at oracle.com Thu May 16 04:37:33 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Thu, 16 May 2013 08:37:33 -0300 Subject: Pls review http://cr.openjdk.java.net/~lagergren/8013919/webrev/ In-Reply-To: <7a401114-942b-48ee-8d63-de003ee32ab8@default> References: <7a401114-942b-48ee-8d63-de003ee32ab8@default> Message-ID: <3E4160F9-53FB-438B-8429-570DAF669DAA@oracle.com> +1 On 2013-05-16, at 8:17 AM, Marcus Lagergren wrote: > Can I get a review for the namespace collision problem described in JDK-8013919? We should probably make Attila's function declaration placement warnings default. This is stupid. > > http://cr.openjdk.java.net/~lagergren/8013919/webrev/ > > /M From marcus.lagergren at oracle.com Thu May 16 04:58:39 2013 From: marcus.lagergren at oracle.com (marcus.lagergren at oracle.com) Date: Thu, 16 May 2013 11:58:39 +0000 Subject: hg: nashorn/jdk8/nashorn: 8013919: Original exception no longer thrown away when a finally rethrows Message-ID: <20130516115841.56FB648AFA@hg.openjdk.java.net> Changeset: 4c67a692ef97 Author: lagergren Date: 2013-05-16 13:44 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/4c67a692ef97 8013919: Original exception no longer thrown away when a finally rethrows Reviewed-by: jlaskey, sundar ! src/jdk/nashorn/internal/codegen/Lower.java ! src/jdk/nashorn/internal/ir/FunctionNode.java + test/script/basic/JDK-8013919.js + test/script/basic/JDK-8013919.js.EXPECTED From hannes.wallnoefer at oracle.com Thu May 16 05:13:27 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Thu, 16 May 2013 14:13:27 +0200 Subject: Review request for JDK-8012359 - Increase code coverage in Joni In-Reply-To: <51921CE7.9030609@oracle.com> References: <51921CE7.9030609@oracle.com> Message-ID: <5194CD67.8030501@oracle.com> I wasn't quite happy with the improvement in coverage so I uploaded a second webrev: http://cr.openjdk.java.net/~hannesw/8012359/webrev.01/ Coverage is now 68% of methods in the main joni package, although lower for blocks, lines and branches. Please review. Hannes Am 2013-05-14 13:15, schrieb Hannes Wallnoefer: > Please review JDK-8012359 - Increase code coverage in Joni: > > http://cr.openjdk.java.net/~hannesw/8012359/ > > This removes most code we do not use in Joni, including regexp > features not used in ECMAScript, alternative implementations of > features, and things left over from multibyte encoding support. > > I tested with ant test and test262, currently running Node tests. > > Hannes From james.laskey at oracle.com Thu May 16 05:23:53 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Thu, 16 May 2013 09:23:53 -0300 Subject: Review request for JDK-8012359 - Increase code coverage in Joni In-Reply-To: <5194CD67.8030501@oracle.com> References: <51921CE7.9030609@oracle.com> <5194CD67.8030501@oracle.com> Message-ID: <64F3B228-629A-4417-9094-1AB949EF370C@oracle.com> +1 On 2013-05-16, at 9:13 AM, Hannes Wallnoefer wrote: > I wasn't quite happy with the improvement in coverage so I uploaded a second webrev: > > http://cr.openjdk.java.net/~hannesw/8012359/webrev.01/ > > Coverage is now 68% of methods in the main joni package, although lower for blocks, lines and branches. > > Please review. > > Hannes > > > Am 2013-05-14 13:15, schrieb Hannes Wallnoefer: >> Please review JDK-8012359 - Increase code coverage in Joni: >> >> http://cr.openjdk.java.net/~hannesw/8012359/ >> >> This removes most code we do not use in Joni, including regexp features not used in ECMAScript, alternative implementations of features, and things left over from multibyte encoding support. >> >> I tested with ant test and test262, currently running Node tests. >> >> Hannes > From hannes.wallnoefer at oracle.com Thu May 16 10:58:12 2013 From: hannes.wallnoefer at oracle.com (hannes.wallnoefer at oracle.com) Date: Thu, 16 May 2013 17:58:12 +0000 Subject: hg: nashorn/jdk8/nashorn: 8012359: Increase code coverage in Joni Message-ID: <20130516175814.6014E48B09@hg.openjdk.java.net> Changeset: 98798a6336de Author: hannesw Date: 2013-05-16 19:52 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/98798a6336de 8012359: Increase code coverage in Joni Reviewed-by: jlaskey, lagergren ! make/build.xml - src/jdk/nashorn/internal/runtime/regexp/DefaultRegExp.java + src/jdk/nashorn/internal/runtime/regexp/JdkRegExp.java ! src/jdk/nashorn/internal/runtime/regexp/JoniRegExp.java ! src/jdk/nashorn/internal/runtime/regexp/RegExpFactory.java ! src/jdk/nashorn/internal/runtime/regexp/joni/Analyser.java ! src/jdk/nashorn/internal/runtime/regexp/joni/ArrayCompiler.java - src/jdk/nashorn/internal/runtime/regexp/joni/AsmCompiler.java - src/jdk/nashorn/internal/runtime/regexp/joni/AsmCompilerSupport.java ! src/jdk/nashorn/internal/runtime/regexp/joni/BitSet.java ! src/jdk/nashorn/internal/runtime/regexp/joni/BitStatus.java ! src/jdk/nashorn/internal/runtime/regexp/joni/ByteCodeMachine.java ! src/jdk/nashorn/internal/runtime/regexp/joni/ByteCodePrinter.java - src/jdk/nashorn/internal/runtime/regexp/joni/CaptureTreeNode.java ! src/jdk/nashorn/internal/runtime/regexp/joni/Compiler.java ! src/jdk/nashorn/internal/runtime/regexp/joni/Config.java ! src/jdk/nashorn/internal/runtime/regexp/joni/EncodingHelper.java ! src/jdk/nashorn/internal/runtime/regexp/joni/Lexer.java ! src/jdk/nashorn/internal/runtime/regexp/joni/Matcher.java - src/jdk/nashorn/internal/runtime/regexp/joni/NameEntry.java - src/jdk/nashorn/internal/runtime/regexp/joni/NativeMachine.java ! src/jdk/nashorn/internal/runtime/regexp/joni/Parser.java ! src/jdk/nashorn/internal/runtime/regexp/joni/Regex.java ! src/jdk/nashorn/internal/runtime/regexp/joni/Region.java ! src/jdk/nashorn/internal/runtime/regexp/joni/ScanEnvironment.java ! src/jdk/nashorn/internal/runtime/regexp/joni/ScannerSupport.java ! src/jdk/nashorn/internal/runtime/regexp/joni/StackMachine.java ! src/jdk/nashorn/internal/runtime/regexp/joni/Syntax.java - src/jdk/nashorn/internal/runtime/regexp/joni/UnsetAddrList.java ! src/jdk/nashorn/internal/runtime/regexp/joni/ast/CClassNode.java - src/jdk/nashorn/internal/runtime/regexp/joni/ast/CTypeNode.java - src/jdk/nashorn/internal/runtime/regexp/joni/ast/CallNode.java ! src/jdk/nashorn/internal/runtime/regexp/joni/ast/EncloseNode.java ! src/jdk/nashorn/internal/runtime/regexp/joni/ast/QuantifierNode.java ! src/jdk/nashorn/internal/runtime/regexp/joni/ast/StateNode.java - src/jdk/nashorn/internal/runtime/regexp/joni/bench/AbstractBench.java - src/jdk/nashorn/internal/runtime/regexp/joni/bench/BenchGreedyBacktrack.java - src/jdk/nashorn/internal/runtime/regexp/joni/bench/BenchRailsRegs.java - src/jdk/nashorn/internal/runtime/regexp/joni/bench/BenchSeveralRegexps.java ! src/jdk/nashorn/internal/runtime/regexp/joni/constants/OPCode.java - src/jdk/nashorn/internal/runtime/regexp/joni/constants/Reduce.java - src/jdk/nashorn/internal/runtime/regexp/joni/encoding/AsciiTables.java ! src/jdk/nashorn/internal/runtime/regexp/joni/encoding/ObjPtr.java - src/jdk/nashorn/internal/runtime/regexp/joni/encoding/PosixBracket.java - src/jdk/nashorn/internal/runtime/regexp/joni/encoding/Ptr.java ! src/jdk/nashorn/internal/runtime/regexp/joni/exception/ErrorMessages.java ! src/jdk/nashorn/internal/runtime/regexp/joni/exception/ValueException.java + test/src/jdk/nashorn/internal/runtime/regexp/JdkRegExpTest.java + test/src/jdk/nashorn/internal/runtime/regexp/joni/JoniTest.java From attila.szegedi at oracle.com Fri May 17 05:39:10 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Fri, 17 May 2013 14:39:10 +0200 Subject: Review request for JDK-8014797 Message-ID: <745575DB-E996-4AEF-8291-69D64AC0A8FB@oracle.com> Please review JDK-8014797 at http://cr.openjdk.java.net/~attila/8014797/webrev.00 Thanks, Attila. From sundararajan.athijegannathan at oracle.com Fri May 17 05:59:24 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Fri, 17 May 2013 18:29:24 +0530 Subject: Review request for JDK-8014797 In-Reply-To: <745575DB-E996-4AEF-8291-69D64AC0A8FB@oracle.com> References: <745575DB-E996-4AEF-8291-69D64AC0A8FB@oracle.com> Message-ID: <519629AC.1090003@oracle.com> +1 -Sundar On Friday 17 May 2013 06:09 PM, Attila Szegedi wrote: > Please review JDK-8014797 at http://cr.openjdk.java.net/~attila/8014797/webrev.00 > > Thanks, > Attila. From james.laskey at oracle.com Fri May 17 06:10:15 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Fri, 17 May 2013 10:10:15 -0300 Subject: Review request for JDK-8014797 In-Reply-To: <745575DB-E996-4AEF-8291-69D64AC0A8FB@oracle.com> References: <745575DB-E996-4AEF-8291-69D64AC0A8FB@oracle.com> Message-ID: +1 On 2013-05-17, at 9:39 AM, Attila Szegedi wrote: > Please review JDK-8014797 at http://cr.openjdk.java.net/~attila/8014797/webrev.00 > > Thanks, > Attila. From james.laskey at oracle.com Fri May 17 12:13:09 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Fri, 17 May 2013 19:13:09 +0000 Subject: hg: nashorn/jdk8/nashorn: 2 new changesets Message-ID: <20130517191313.35CEB48B7C@hg.openjdk.java.net> Changeset: aa1b6e8c51a0 Author: jlaskey Date: 2013-05-17 14:30 -0300 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/aa1b6e8c51a0 8012694: Smoke test fail: Windows JDK-8008554.js - access denied ("java.io.FilePermission" "//C/aurora/sandbox/nashorn~source/test/script/basic/NASHORN-99.js" "read") Reviewed-by: jlaskey Contributed-by: konstantin.shefov at oracle.com Changeset: a92be4c0063b Author: jlaskey Date: 2013-05-17 16:12 -0300 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/a92be4c0063b Merge - src/jdk/nashorn/internal/runtime/regexp/DefaultRegExp.java - src/jdk/nashorn/internal/runtime/regexp/joni/AsmCompiler.java - src/jdk/nashorn/internal/runtime/regexp/joni/AsmCompilerSupport.java - src/jdk/nashorn/internal/runtime/regexp/joni/CaptureTreeNode.java - src/jdk/nashorn/internal/runtime/regexp/joni/NameEntry.java - src/jdk/nashorn/internal/runtime/regexp/joni/NativeMachine.java - src/jdk/nashorn/internal/runtime/regexp/joni/UnsetAddrList.java - src/jdk/nashorn/internal/runtime/regexp/joni/ast/CTypeNode.java - src/jdk/nashorn/internal/runtime/regexp/joni/ast/CallNode.java - src/jdk/nashorn/internal/runtime/regexp/joni/bench/AbstractBench.java - src/jdk/nashorn/internal/runtime/regexp/joni/bench/BenchGreedyBacktrack.java - src/jdk/nashorn/internal/runtime/regexp/joni/bench/BenchRailsRegs.java - src/jdk/nashorn/internal/runtime/regexp/joni/bench/BenchSeveralRegexps.java - src/jdk/nashorn/internal/runtime/regexp/joni/constants/Reduce.java - src/jdk/nashorn/internal/runtime/regexp/joni/encoding/AsciiTables.java - src/jdk/nashorn/internal/runtime/regexp/joni/encoding/PosixBracket.java - src/jdk/nashorn/internal/runtime/regexp/joni/encoding/Ptr.java - src/netscape/javascript/JSObject.java From james.laskey at oracle.com Fri May 17 12:45:06 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Fri, 17 May 2013 19:45:06 +0000 Subject: hg: nashorn/jdk8/nashorn: 8014823: Reprise - Smoke test fail: Windows JDK-8008554.js - access denied ("java.io.FilePermission" "//C/aurora/sandbox/nashorn~source/test/script/basic/NASHORN-99.js" "read") Message-ID: <20130517194507.4F9A548B81@hg.openjdk.java.net> Changeset: 1d5a8f1f416e Author: jlaskey Date: 2013-05-17 16:44 -0300 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/1d5a8f1f416e 8014823: Reprise - Smoke test fail: Windows JDK-8008554.js - access denied ("java.io.FilePermission" "//C/aurora/sandbox/nashorn~source/test/script/basic/NASHORN-99.js" "read") Reviewed-by: jlaskey Contributed-by: konstantin.shefov at oracle.com ! test/script/basic/JDK-8008554.js From marcus.lagergren at oracle.com Mon May 20 05:28:11 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Mon, 20 May 2013 14:28:11 +0200 Subject: Please review Range Analysis (JBS-8006069) Message-ID: <8D0F26B2-FE21-41D2-BFC1-06007B663685@oracle.com> Webrev @: http://cr.openjdk.java.net/~lagergren/8006069/ Range analysis, trying to narrow known compile time types to narrower ones. (typically doubles to ints or longs). Range analysis is disabled by default, enabled with flag --range-analysis. Aiming to make it default after testing. I've added unit tests to provide sanity check (same results) and code coverage that runs with the flag enabled. I've also done some changes to RecompilableScriptFunctionData to specialize more aggressively and based on runtime types if those are more specific than types known at compile time (adding guards to verify that the assumption holds). Still disabled by default (--specialize-calls is the flag). 25% performance increase on octane.crypto running with it enabled. These changes provide an infrastructure for trickle-through of all known compile type information, but this is not enough for performance. We need to do even more aggressive things at runtime. /M From james.laskey at oracle.com Mon May 20 06:03:06 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Mon, 20 May 2013 10:03:06 -0300 Subject: Please review Range Analysis (JBS-8006069) In-Reply-To: <8D0F26B2-FE21-41D2-BFC1-06007B663685@oracle.com> References: <8D0F26B2-FE21-41D2-BFC1-06007B663685@oracle.com> Message-ID: <344423A4-DC98-408B-ABDB-ACEA964FB480@oracle.com> +1 On 2013-05-20, at 9:28 AM, Marcus Lagergren wrote: > Webrev @: http://cr.openjdk.java.net/~lagergren/8006069/ > > Range analysis, trying to narrow known compile time types to narrower ones. (typically doubles to ints or longs). > > Range analysis is disabled by default, enabled with flag --range-analysis. Aiming to make it default after testing. I've added unit tests to provide sanity check (same results) and code coverage that runs with the flag enabled. > > I've also done some changes to RecompilableScriptFunctionData to specialize more aggressively and based on runtime types if those are more specific than types known at compile time (adding guards to verify that the assumption holds). Still disabled by default (--specialize-calls is the flag). 25% performance increase on octane.crypto running with it enabled. > > These changes provide an infrastructure for trickle-through of all known compile type information, but this is not enough for performance. We need to do even more aggressive things at runtime. > > /M > > > From sundararajan.athijegannathan at oracle.com Mon May 20 06:20:27 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Mon, 20 May 2013 18:50:27 +0530 Subject: Please review Range Analysis (JBS-8006069) In-Reply-To: <8D0F26B2-FE21-41D2-BFC1-06007B663685@oracle.com> References: <8D0F26B2-FE21-41D2-BFC1-06007B663685@oracle.com> Message-ID: <519A231B.5050308@oracle.com> +1 -Sundar On Monday 20 May 2013 05:58 PM, Marcus Lagergren wrote: > Webrev @: http://cr.openjdk.java.net/~lagergren/8006069/ > > Range analysis, trying to narrow known compile time types to narrower ones. (typically doubles to ints or longs). > > Range analysis is disabled by default, enabled with flag --range-analysis. Aiming to make it default after testing. I've added unit tests to provide sanity check (same results) and code coverage that runs with the flag enabled. > > I've also done some changes to RecompilableScriptFunctionData to specialize more aggressively and based on runtime types if those are more specific than types known at compile time (adding guards to verify that the assumption holds). Still disabled by default (--specialize-calls is the flag). 25% performance increase on octane.crypto running with it enabled. > > These changes provide an infrastructure for trickle-through of all known compile type information, but this is not enough for performance. We need to do even more aggressive things at runtime. > > /M > > > From marcus.lagergren at oracle.com Mon May 20 07:41:53 2013 From: marcus.lagergren at oracle.com (marcus.lagergren at oracle.com) Date: Mon, 20 May 2013 14:41:53 +0000 Subject: hg: nashorn/jdk8/nashorn: 8006069: Range analysis first iteration, runtime specializations Message-ID: <20130520144155.B40F348BBE@hg.openjdk.java.net> Changeset: 92164a5742db Author: lagergren Date: 2013-05-20 16:38 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/92164a5742db 8006069: Range analysis first iteration, runtime specializations Reviewed-by: jlaskey, sundar ! src/jdk/nashorn/internal/codegen/CompilationPhase.java ! src/jdk/nashorn/internal/codegen/Compiler.java ! src/jdk/nashorn/internal/codegen/CompilerConstants.java ! src/jdk/nashorn/internal/codegen/MethodEmitter.java + src/jdk/nashorn/internal/codegen/RangeAnalyzer.java + src/jdk/nashorn/internal/codegen/types/Range.java ! src/jdk/nashorn/internal/codegen/types/Type.java ! src/jdk/nashorn/internal/ir/BinaryNode.java ! src/jdk/nashorn/internal/ir/FunctionNode.java ! src/jdk/nashorn/internal/ir/LexicalContext.java ! src/jdk/nashorn/internal/ir/Node.java ! src/jdk/nashorn/internal/ir/Symbol.java ! src/jdk/nashorn/internal/runtime/CompiledFunction.java ! src/jdk/nashorn/internal/runtime/FinalScriptFunctionData.java ! src/jdk/nashorn/internal/runtime/RecompilableScriptFunctionData.java ! src/jdk/nashorn/internal/runtime/ScriptEnvironment.java ! src/jdk/nashorn/internal/runtime/ScriptFunctionData.java ! src/jdk/nashorn/internal/runtime/resources/Options.properties + test/script/basic/ranges_disabled.js + test/script/basic/ranges_disabled.js.EXPECTED + test/script/basic/ranges_enabled.js + test/script/basic/ranges_enabled.js.EXPECTED + test/script/basic/ranges_payload.js From sundararajan.athijegannathan at oracle.com Mon May 20 10:25:44 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Mon, 20 May 2013 22:55:44 +0530 Subject: Review request for 8014909: ant test compilation error with JoniTest.java Message-ID: <519A5C98.2060608@oracle.com> Please review http://cr.openjdk.java.net/~sundar/8014909/ -Sundar From sundararajan.athijegannathan at oracle.com Mon May 20 10:34:59 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Mon, 20 May 2013 17:34:59 +0000 Subject: hg: nashorn/jdk8/nashorn: 8014909: ant test compilation error with JoniTest.java Message-ID: <20130520173501.CAB8948BC5@hg.openjdk.java.net> Changeset: b558e19d5de5 Author: sundar Date: 2013-05-20 23:04 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/b558e19d5de5 8014909: ant test compilation error with JoniTest.java Reviewed-by: jlaskey ! make/build.xml From marcus.lagergren at oracle.com Mon May 20 10:48:23 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Mon, 20 May 2013 19:48:23 +0200 Subject: Review request for 8014909: ant test compilation error with JoniTest.java In-Reply-To: <519A5C98.2060608@oracle.com> References: <519A5C98.2060608@oracle.com> Message-ID: <0017B4BD-79AD-4581-9D1A-EE7891EA4886@oracle.com> +1 On May 20, 2013, at 7:25 PM, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~sundar/8014909/ > > -Sundar From attila.szegedi at oracle.com Mon May 20 12:18:33 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Mon, 20 May 2013 21:18:33 +0200 Subject: Please review Range Analysis (JBS-8006069) In-Reply-To: <8D0F26B2-FE21-41D2-BFC1-06007B663685@oracle.com> References: <8D0F26B2-FE21-41D2-BFC1-06007B663685@oracle.com> Message-ID: Sorry for chiming in late for this, but: Minor things: - you could have a pre-created constant Range object for Range.createRange(1) - assignedInLoop could have enterDefault() that returns assignmentsInLoop.isEmpty() to short circuit when an assignment is found. Actually, maybe don't even need a "HashSet assignmentInLoop" there, just a boolean[1] or an AtomicBoolean for "assignmentFound". What looks like an actual bug: - the visitor of assignedInLoop should only add getInit() and getModify() of a ForNode to skip set when forNode == loopNode. Otherwise an assignment in a nested loop initializer will slip past. Attila. On May 20, 2013, at 2:28 PM, Marcus Lagergren wrote: > Webrev @: http://cr.openjdk.java.net/~lagergren/8006069/ > > Range analysis, trying to narrow known compile time types to narrower ones. (typically doubles to ints or longs). > > Range analysis is disabled by default, enabled with flag --range-analysis. Aiming to make it default after testing. I've added unit tests to provide sanity check (same results) and code coverage that runs with the flag enabled. > > I've also done some changes to RecompilableScriptFunctionData to specialize more aggressively and based on runtime types if those are more specific than types known at compile time (adding guards to verify that the assumption holds). Still disabled by default (--specialize-calls is the flag). 25% performance increase on octane.crypto running with it enabled. > > These changes provide an infrastructure for trickle-through of all known compile type information, but this is not enough for performance. We need to do even more aggressive things at runtime. > > /M > > > From attila.szegedi at oracle.com Mon May 20 12:26:18 2013 From: attila.szegedi at oracle.com (attila.szegedi at oracle.com) Date: Mon, 20 May 2013 19:26:18 +0000 Subject: hg: nashorn/jdk8/nashorn: 8014797: rename Java.toJavaArray/toJavaScriptArray to Java.to/from, respectively. Message-ID: <20130520192620.37AC648BC8@hg.openjdk.java.net> Changeset: 1fd18f40ab52 Author: attila Date: 2013-05-20 21:25 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/1fd18f40ab52 8014797: rename Java.toJavaArray/toJavaScriptArray to Java.to/from, respectively. Reviewed-by: jlaskey, sundar ! docs/JavaScriptingProgrammersGuide.html ! docs/source/javaarray.js ! src/jdk/nashorn/api/scripting/resources/engine.js ! src/jdk/nashorn/internal/objects/NativeJava.java ! src/jdk/nashorn/internal/runtime/resources/Messages.properties ! test/script/basic/NASHORN-556.js ! test/script/basic/javaarrayconversion.js ! test/script/currently-failing/logcoverage.js ! test/script/trusted/NASHORN-638.js ! test/script/trusted/NASHORN-653.js From james.laskey at oracle.com Mon May 20 13:26:02 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Mon, 20 May 2013 17:26:02 -0300 Subject: Review request for 8014909: ant test compilation error with JoniTest.java In-Reply-To: <519A5C98.2060608@oracle.com> References: <519A5C98.2060608@oracle.com> Message-ID: +1 On 2013-05-20, at 2:25 PM, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~sundar/8014909/ > > -Sundar From attila.szegedi at oracle.com Tue May 21 03:24:13 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Tue, 21 May 2013 12:24:13 +0200 Subject: Review request for JDK-8014953 Message-ID: <8DB03237-EE09-46DA-A897-BF8ED52FDDB7@oracle.com> Please review JDK-8014953 at http://cr.openjdk.java.net/~attila/8014953/webrev.00 Thanks, Attila. From hannes.wallnoefer at oracle.com Tue May 21 03:46:30 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Tue, 21 May 2013 12:46:30 +0200 Subject: Review request for JDK-8014953 In-Reply-To: <8DB03237-EE09-46DA-A897-BF8ED52FDDB7@oracle.com> References: <8DB03237-EE09-46DA-A897-BF8ED52FDDB7@oracle.com> Message-ID: <519B5086.7000302@oracle.com> This looks correct, but I wouldn't it be simpler to just throw a RuntimeException/TypeError with a "class not found" message directly in findNewMethod/findCallMethod? This is the same thing that ScriptObject does, and I think the message is more important to script writers than the exception type. Hannes Am 2013-05-21 12:24, schrieb Attila Szegedi: > Please review JDK-8014953 at http://cr.openjdk.java.net/~attila/8014953/webrev.00 > > Thanks, > Attila. From sundararajan.athijegannathan at oracle.com Tue May 21 04:08:44 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Tue, 21 May 2013 16:38:44 +0530 Subject: Review request for JDK-8014953 In-Reply-To: <8DB03237-EE09-46DA-A897-BF8ED52FDDB7@oracle.com> References: <8DB03237-EE09-46DA-A897-BF8ED52FDDB7@oracle.com> Message-ID: <519B55BC.60007@oracle.com> +1 -Sundar On Tuesday 21 May 2013 03:54 PM, Attila Szegedi wrote: > Please review JDK-8014953 at http://cr.openjdk.java.net/~attila/8014953/webrev.00 > > Thanks, > Attila. From attila.szegedi at oracle.com Tue May 21 04:14:42 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Tue, 21 May 2013 13:14:42 +0200 Subject: Review request for JDK-8014953 In-Reply-To: <519B5086.7000302@oracle.com> References: <8DB03237-EE09-46DA-A897-BF8ED52FDDB7@oracle.com> <519B5086.7000302@oracle.com> Message-ID: <16751179-3085-4933-AA36-B4BDDDAF8B4B@oracle.com> It'd be simpler, but I like that we're throwing an exception consistent with Java platform. Also, we get shorter stack traces - none of the linker plumbing stack traces are visible. Namely: Caused by: java.lang.ClassNotFoundException: java.util.ArrrayList at jdk.nashorn.internal.runtime.NativeJavaPackage.classNotFound(NativeJavaPackage.java:157) at jdk.nashorn.internal.scripts.Script$x.runScript(x.js:1) vs. Exception in thread "main" java.lang.RuntimeException: java.lang.ClassNotFoundException: java.util.ArrrayList at jdk.nashorn.internal.runtime.NativeJavaPackage.createClassNotFoundInvocation(NativeJavaPackage.java:146) at jdk.nashorn.internal.runtime.NativeJavaPackage.findNewMethod(NativeJavaPackage.java:137) at jdk.nashorn.internal.runtime.ScriptObject.lookup(ScriptObject.java:1614) at jdk.nashorn.internal.runtime.linker.NashornLinker.getGuardedInvocation(NashornLinker.java:75) at jdk.internal.dynalink.support.CompositeTypeBasedGuardingDynamicLinker.getGuardedInvocation(CompositeTypeBasedGuardingDynamicLinker.java:176) at jdk.internal.dynalink.support.CompositeGuardingDynamicLinker.getGuardedInvocation(CompositeGuardingDynamicLinker.java:124) at jdk.internal.dynalink.support.LinkerServicesImpl.getGuardedInvocation(LinkerServicesImpl.java:138) at jdk.internal.dynalink.DynamicLinker.relink(DynamicLinker.java:229) at jdk.nashorn.internal.scripts.Script$x.runScript(x.js:1) On May 21, 2013, at 12:46 PM, Hannes Wallnoefer wrote: > This looks correct, but I wouldn't it be simpler to just throw a RuntimeException/TypeError with a "class not found" message directly in findNewMethod/findCallMethod? This is the same thing that ScriptObject does, and I think the message is more important to script writers than the exception type. > > Hannes > > Am 2013-05-21 12:24, schrieb Attila Szegedi: >> Please review JDK-8014953 at http://cr.openjdk.java.net/~attila/8014953/webrev.00 >> >> Thanks, >> Attila. > From james.laskey at oracle.com Tue May 21 04:36:53 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Tue, 21 May 2013 08:36:53 -0300 Subject: Review request for JDK-8014953 In-Reply-To: <8DB03237-EE09-46DA-A897-BF8ED52FDDB7@oracle.com> References: <8DB03237-EE09-46DA-A897-BF8ED52FDDB7@oracle.com> Message-ID: +1 On 2013-05-21, at 7:24 AM, Attila Szegedi wrote: > Please review JDK-8014953 at http://cr.openjdk.java.net/~attila/8014953/webrev.00 > > Thanks, > Attila. From attila.szegedi at oracle.com Tue May 21 04:40:12 2013 From: attila.szegedi at oracle.com (attila.szegedi at oracle.com) Date: Tue, 21 May 2013 11:40:12 +0000 Subject: hg: nashorn/jdk8/nashorn: 8014953: Have NativeJavaPackage throw a ClassNotFoundException when invoked Message-ID: <20130521114015.274F348BED@hg.openjdk.java.net> Changeset: 833a9a584b64 Author: attila Date: 2013-05-21 13:40 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/833a9a584b64 8014953: Have NativeJavaPackage throw a ClassNotFoundException when invoked Reviewed-by: jlaskey, sundar ! src/jdk/nashorn/internal/runtime/NativeJavaPackage.java + test/script/basic/JDK-8014953.js + test/script/basic/JDK-8014953.js.EXPECTED From james.laskey at oracle.com Tue May 21 05:42:30 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Tue, 21 May 2013 09:42:30 -0300 Subject: Please review JDK-8014827 - readLine should accept a prompt as an argument. Message-ID: Please review http://cr.openjdk.java.net/~jlaskey/8014827/webrev.00/index.html . From hannes.wallnoefer at oracle.com Tue May 21 06:02:31 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Tue, 21 May 2013 15:02:31 +0200 Subject: Please review JDK-8014827 - readLine should accept a prompt as an argument. In-Reply-To: References: Message-ID: <519B7067.5000205@oracle.com> +1 Am 2013-05-21 14:42, schrieb Jim Laskey (Oracle): > Please review http://cr.openjdk.java.net/~jlaskey/8014827/webrev.00/index.html . From sundararajan.athijegannathan at oracle.com Tue May 21 06:02:41 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Tue, 21 May 2013 18:32:41 +0530 Subject: Please review JDK-8014827 - readLine should accept a prompt as an argument. In-Reply-To: References: Message-ID: <519B7071.501@oracle.com> +1 On Tuesday 21 May 2013 06:12 PM, Jim Laskey (Oracle) wrote: > Please review http://cr.openjdk.java.net/~jlaskey/8014827/webrev.00/index.html . From james.laskey at oracle.com Tue May 21 06:18:42 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Tue, 21 May 2013 13:18:42 +0000 Subject: hg: nashorn/jdk8/nashorn: 8014827: readLine should accept a prompt as an argument Message-ID: <20130521131843.D2D9848BF4@hg.openjdk.java.net> Changeset: 288ff54da2a5 Author: jlaskey Date: 2013-05-21 10:17 -0300 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/288ff54da2a5 8014827: readLine should accept a prompt as an argument Reviewed-by: sundar, hannesw Contributed-by: james.laskey at oracle.com ! src/jdk/nashorn/internal/runtime/ScriptingFunctions.java From sundararajan.athijegannathan at oracle.com Wed May 22 00:07:48 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Wed, 22 May 2013 12:37:48 +0530 Subject: Review request for 8008947: ScriptEnvironment ctor should be public Message-ID: <519C6EC4.1090204@oracle.com> Please review http://cr.openjdk.java.net/~sundar/8008947/ -Sundar From marcus.lagergren at oracle.com Wed May 22 01:11:24 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Wed, 22 May 2013 10:11:24 +0200 Subject: Review request for 8008947: ScriptEnvironment ctor should be public In-Reply-To: <519C6EC4.1090204@oracle.com> References: <519C6EC4.1090204@oracle.com> Message-ID: +1 On May 22, 2013, at 9:07 AM, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~sundar/8008947/ > > -Sundar From attila.szegedi at oracle.com Wed May 22 03:50:59 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Wed, 22 May 2013 12:50:59 +0200 Subject: Review request for 8008947: ScriptEnvironment ctor should be public In-Reply-To: References: <519C6EC4.1090204@oracle.com> Message-ID: <9E1B972C-FAFC-4D11-83FA-D002542244C4@oracle.com> +1 On May 22, 2013, at 10:11 AM, Marcus Lagergren wrote: > +1 > > On May 22, 2013, at 9:07 AM, A. Sundararajan wrote: > >> Please review http://cr.openjdk.java.net/~sundar/8008947/ >> >> -Sundar > From sundararajan.athijegannathan at oracle.com Wed May 22 04:10:11 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Wed, 22 May 2013 11:10:11 +0000 Subject: hg: nashorn/jdk8/nashorn: 8008947: ScriptEnvironment ctor should be public Message-ID: <20130522111012.1652D48C35@hg.openjdk.java.net> Changeset: 07cefc062032 Author: sundar Date: 2013-05-22 16:39 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/07cefc062032 8008947: ScriptEnvironment ctor should be public Reviewed-by: lagergren, attila ! .hgignore ! src/jdk/nashorn/internal/runtime/ScriptEnvironment.java From hannes.wallnoefer at oracle.com Wed May 22 05:08:33 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Wed, 22 May 2013 14:08:33 +0200 Subject: Review request for 8010804: Review long and integer usage conventions Message-ID: <519CB541.9020403@oracle.com> Please review JDK-8010804: Review long and integer usage conventions. http://cr.openjdk.java.net/~hannesw/8010804/ Thanks, Hannes From james.laskey at oracle.com Wed May 22 05:50:56 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Wed, 22 May 2013 09:50:56 -0300 Subject: Review request for 8010804: Review long and integer usage conventions In-Reply-To: <519CB541.9020403@oracle.com> References: <519CB541.9020403@oracle.com> Message-ID: <1AAC6A60-6A67-46DF-9A81-2DA2E43B94E0@oracle.com> +1 On 2013-05-22, at 9:08 AM, Hannes Wallnoefer wrote: > Please review JDK-8010804: Review long and integer usage conventions. > > http://cr.openjdk.java.net/~hannesw/8010804/ > > Thanks, > Hannes From sundararajan.athijegannathan at oracle.com Wed May 22 06:37:08 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Wed, 22 May 2013 19:07:08 +0530 Subject: Review request for 8014735: Typed Array, BYTES_PER_ELEMENT should be a class property Message-ID: <519CCA04.8060204@oracle.com> Please review http://cr.openjdk.java.net/~sundar/8014735/ -Sundar From sundararajan.athijegannathan at oracle.com Wed May 22 07:03:27 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Wed, 22 May 2013 14:03:27 +0000 Subject: hg: nashorn/jdk8/nashorn: 8014735: Typed Array, BYTES_PER_ELEMENT should be a class property Message-ID: <20130522140329.087D248C3C@hg.openjdk.java.net> Changeset: 66685c69bdb3 Author: sundar Date: 2013-05-22 19:33 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/66685c69bdb3 8014735: Typed Array, BYTES_PER_ELEMENT should be a class property Reviewed-by: lagergren, jlaskey ! src/jdk/nashorn/internal/objects/ArrayBufferView.java ! src/jdk/nashorn/internal/objects/NativeFloat32Array.java ! src/jdk/nashorn/internal/objects/NativeFloat64Array.java ! src/jdk/nashorn/internal/objects/NativeInt16Array.java ! src/jdk/nashorn/internal/objects/NativeInt32Array.java ! src/jdk/nashorn/internal/objects/NativeInt8Array.java ! src/jdk/nashorn/internal/objects/NativeUint16Array.java ! src/jdk/nashorn/internal/objects/NativeUint32Array.java ! src/jdk/nashorn/internal/objects/NativeUint8Array.java ! src/jdk/nashorn/internal/objects/NativeUint8ClampedArray.java + test/script/basic/JDK-8014735.js + test/script/basic/JDK-8014735.js.EXPECTED ! test/script/basic/NASHORN-377.js From hannes.wallnoefer at oracle.com Wed May 22 07:12:36 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Wed, 22 May 2013 16:12:36 +0200 Subject: Review request for 8014735: Typed Array, BYTES_PER_ELEMENT should be a class property In-Reply-To: <519CCA04.8060204@oracle.com> References: <519CCA04.8060204@oracle.com> Message-ID: <519CD254.2080105@oracle.com> +1 Am 2013-05-22 15:37, schrieb A. Sundararajan: > Please review http://cr.openjdk.java.net/~sundar/8014735/ > > -Sundar From james.laskey at oracle.com Wed May 22 07:13:00 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Wed, 22 May 2013 11:13:00 -0300 Subject: Review request for 8014735: Typed Array, BYTES_PER_ELEMENT should be a class property In-Reply-To: <519CCA04.8060204@oracle.com> References: <519CCA04.8060204@oracle.com> Message-ID: +1 On 2013-05-22, at 10:37 AM, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~sundar/8014735/ > > -Sundar From james.laskey at oracle.com Wed May 22 07:22:23 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Wed, 22 May 2013 11:22:23 -0300 Subject: Review request for 8010804: Review long and integer usage conventions In-Reply-To: <519CB541.9020403@oracle.com> References: <519CB541.9020403@oracle.com> Message-ID: <26633972-795E-4D77-9E32-38C3A811E006@oracle.com> +1 On 2013-05-22, at 9:08 AM, Hannes Wallnoefer wrote: > Please review JDK-8010804: Review long and integer usage conventions. > > http://cr.openjdk.java.net/~hannesw/8010804/ > > Thanks, > Hannes From sundararajan.athijegannathan at oracle.com Wed May 22 07:32:18 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Wed, 22 May 2013 20:02:18 +0530 Subject: Review request for 8010804: Review long and integer usage conventions In-Reply-To: <26633972-795E-4D77-9E32-38C3A811E006@oracle.com> References: <519CB541.9020403@oracle.com> <26633972-795E-4D77-9E32-38C3A811E006@oracle.com> Message-ID: <519CD6F2.7010709@oracle.com> +1 On Wednesday 22 May 2013 07:52 PM, Jim Laskey (Oracle) wrote: > +1 > > On 2013-05-22, at 9:08 AM, Hannes Wallnoefer wrote: > >> Please review JDK-8010804: Review long and integer usage conventions. >> >> http://cr.openjdk.java.net/~hannesw/8010804/ >> >> Thanks, >> Hannes From hannes.wallnoefer at oracle.com Wed May 22 07:44:12 2013 From: hannes.wallnoefer at oracle.com (hannes.wallnoefer at oracle.com) Date: Wed, 22 May 2013 14:44:12 +0000 Subject: hg: nashorn/jdk8/nashorn: 8010804: Review long and integer usage conventions Message-ID: <20130522144413.C538148C3E@hg.openjdk.java.net> Changeset: 8f7553df4503 Author: hannesw Date: 2013-05-22 16:43 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/8f7553df4503 8010804: Review long and integer usage conventions Reviewed-by: jlaskey, sundar ! src/jdk/nashorn/internal/codegen/FoldConstants.java ! src/jdk/nashorn/internal/objects/NativeArray.java ! src/jdk/nashorn/internal/objects/NativeDate.java ! src/jdk/nashorn/internal/runtime/JSType.java + test/script/basic/JDK-8010804.js + test/script/basic/JDK-8010804.js.EXPECTED From attila.szegedi at oracle.com Wed May 22 23:30:59 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Thu, 23 May 2013 08:30:59 +0200 Subject: Review request for JDK-8015267 Message-ID: <0F6EBEAD-5FE8-4279-99D9-555FAB16B8F2@oracle.com> Please review JDK-8015267 at http://cr.openjdk.java.net/~attila/8015267/webrev.00 Thanks, Attila. From sundararajan.athijegannathan at oracle.com Wed May 22 23:52:39 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Thu, 23 May 2013 12:22:39 +0530 Subject: Review request for JDK-8015267 In-Reply-To: <0F6EBEAD-5FE8-4279-99D9-555FAB16B8F2@oracle.com> References: <0F6EBEAD-5FE8-4279-99D9-555FAB16B8F2@oracle.com> Message-ID: <519DBCB7.7010200@oracle.com> +1 On Thursday 23 May 2013 12:00 PM, Attila Szegedi wrote: > Please review JDK-8015267 at http://cr.openjdk.java.net/~attila/8015267/webrev.00 > > Thanks, > Attila. From marcus.lagergren at oracle.com Thu May 23 00:38:59 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Thu, 23 May 2013 09:38:59 +0200 Subject: Review request for JDK-8015267 In-Reply-To: <0F6EBEAD-5FE8-4279-99D9-555FAB16B8F2@oracle.com> References: <0F6EBEAD-5FE8-4279-99D9-555FAB16B8F2@oracle.com> Message-ID: <451CB9FA-C876-45A8-82D4-B4A3BFF360DB@oracle.com> +1 On May 23, 2013, at 8:30 AM, Attila Szegedi wrote: > Please review JDK-8015267 at http://cr.openjdk.java.net/~attila/8015267/webrev.00 > > Thanks, > Attila. From marcus.lagergren at oracle.com Thu May 23 02:59:03 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Thu, 23 May 2013 11:59:03 +0200 Subject: Please review http://cr.openjdk.java.net/~lagergren/8012083/webrev/ - ArrayLiterals Message-ID: <0896255E-EDD1-428F-976E-43A2F5B97822@oracle.com> ArrayLiterals can't just be constant evaluated during code generation as they are a construct containing Nodes. We can make this better and more intelligent, but right now I disabled constant evaluation for the array literals. http://cr.openjdk.java.net/~lagergren/8012083/webrev/ /M From attila.szegedi at oracle.com Thu May 23 03:01:37 2013 From: attila.szegedi at oracle.com (attila.szegedi at oracle.com) Date: Thu, 23 May 2013 10:01:37 +0000 Subject: hg: nashorn/jdk8/nashorn: 8015267: Allow conversion of JS arrays to Java List/Deque Message-ID: <20130523100139.0FF5348C92@hg.openjdk.java.net> Changeset: 1c1453863ea8 Author: attila Date: 2013-05-23 12:01 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/1c1453863ea8 8015267: Allow conversion of JS arrays to Java List/Deque Reviewed-by: lagergren, sundar ! make/build.xml ! src/jdk/nashorn/internal/objects/NativeJava.java + src/jdk/nashorn/internal/runtime/ListAdapter.java ! src/jdk/nashorn/internal/runtime/linker/InvokeByName.java ! src/jdk/nashorn/internal/runtime/resources/Messages.properties + test/script/basic/JDK-8015267.js + test/script/basic/JDK-8015267.js.EXPECTED From attila.szegedi at oracle.com Thu May 23 03:07:38 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Thu, 23 May 2013 12:07:38 +0200 Subject: Review request for JDK-8015278 Message-ID: <4C8F7CF2-8DF5-43C4-9177-D2E6F3EB1BEC@oracle.com> Please review JDK-8015278 at http://cr.openjdk.java.net/~attila/8015278/webrev.00 Thanks, Attila. From james.laskey at oracle.com Thu May 23 03:10:07 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Thu, 23 May 2013 07:10:07 -0300 Subject: Review request for JDK-8015267 In-Reply-To: <0F6EBEAD-5FE8-4279-99D9-555FAB16B8F2@oracle.com> References: <0F6EBEAD-5FE8-4279-99D9-555FAB16B8F2@oracle.com> Message-ID: <0C1FECB0-1558-4E34-B01F-B5C6B7350147@oracle.com> +1 On 2013-05-23, at 3:30 AM, Attila Szegedi wrote: > Please review JDK-8015267 at http://cr.openjdk.java.net/~attila/8015267/webrev.00 > > Thanks, > Attila. From james.laskey at oracle.com Thu May 23 03:10:27 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Thu, 23 May 2013 07:10:27 -0300 Subject: Please review http://cr.openjdk.java.net/~lagergren/8012083/webrev/ - ArrayLiterals In-Reply-To: <0896255E-EDD1-428F-976E-43A2F5B97822@oracle.com> References: <0896255E-EDD1-428F-976E-43A2F5B97822@oracle.com> Message-ID: <5B3339E3-8C2F-4452-9293-4BBCF4306028@oracle.com> +1 On 2013-05-23, at 6:59 AM, Marcus Lagergren wrote: > ArrayLiterals can't just be constant evaluated during code generation as they are a construct containing Nodes. We can make this better and more intelligent, but right now I disabled constant evaluation for the array literals. > > http://cr.openjdk.java.net/~lagergren/8012083/webrev/ > > /M > From james.laskey at oracle.com Thu May 23 03:31:30 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Thu, 23 May 2013 07:31:30 -0300 Subject: Review request for JDK-8015278 In-Reply-To: <4C8F7CF2-8DF5-43C4-9177-D2E6F3EB1BEC@oracle.com> References: <4C8F7CF2-8DF5-43C4-9177-D2E6F3EB1BEC@oracle.com> Message-ID: +1 On 2013-05-23, at 7:07 AM, Attila Szegedi wrote: > Please review JDK-8015278 at http://cr.openjdk.java.net/~attila/8015278/webrev.00 > > Thanks, > Attila. From attila.szegedi at oracle.com Thu May 23 03:31:59 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Thu, 23 May 2013 12:31:59 +0200 Subject: Please review http://cr.openjdk.java.net/~lagergren/8012083/webrev/ - ArrayLiterals In-Reply-To: <0896255E-EDD1-428F-976E-43A2F5B97822@oracle.com> References: <0896255E-EDD1-428F-976E-43A2F5B97822@oracle.com> Message-ID: <2BA87A0F-51D3-4F03-9C0E-0E3EDB299746@oracle.com> +1 On May 23, 2013, at 11:59 AM, Marcus Lagergren wrote: > ArrayLiterals can't just be constant evaluated during code generation as they are a construct containing Nodes. We can make this better and more intelligent, but right now I disabled constant evaluation for the array literals. > > http://cr.openjdk.java.net/~lagergren/8012083/webrev/ > > /M > From marcus.lagergren at oracle.com Thu May 23 04:12:11 2013 From: marcus.lagergren at oracle.com (marcus.lagergren at oracle.com) Date: Thu, 23 May 2013 11:12:11 +0000 Subject: hg: nashorn/jdk8/nashorn: 8012083: Array literal constant folding issue Message-ID: <20130523111212.CA60148C93@hg.openjdk.java.net> Changeset: f7eb4436410e Author: lagergren Date: 2013-05-23 13:10 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/f7eb4436410e 8012083: Array literal constant folding issue Reviewed-by: attila, jlaskey ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/FinalizeTypes.java ! src/jdk/nashorn/internal/codegen/FoldConstants.java + test/script/basic/JDK-8012083.js + test/script/basic/JDK-8012083.js.EXPECTED From attila.szegedi at oracle.com Thu May 23 04:36:45 2013 From: attila.szegedi at oracle.com (attila.szegedi at oracle.com) Date: Thu, 23 May 2013 11:36:45 +0000 Subject: hg: nashorn/jdk8/nashorn: 8015278: Revert accidental changes to build.xml Message-ID: <20130523113646.455A248C94@hg.openjdk.java.net> Changeset: 704bc91a0c41 Author: attila Date: 2013-05-23 13:36 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/704bc91a0c41 8015278: Revert accidental changes to build.xml Reviewed-by: jlaskey, lagergren ! make/build.xml From marcus.lagergren at oracle.com Thu May 23 05:53:39 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Thu, 23 May 2013 14:53:39 +0200 Subject: Review request for JDK-8012522 Message-ID: Please review JDK-8012522 at http://cr.openjdk.java.net/~lagergren/8012522/webrev.00 Thanks, Marcus. From james.laskey at oracle.com Thu May 23 05:54:51 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Thu, 23 May 2013 12:54:51 +0000 Subject: hg: nashorn/jdk8: 4 new changesets Message-ID: <20130523125451.ECDB448C9C@hg.openjdk.java.net> Changeset: 69b773a221b9 Author: katleman Date: 2013-05-09 10:03 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/69b773a221b9 Added tag jdk8-b89 for changeset 892a0196d10c ! .hgtags Changeset: 83b519cafa68 Author: katleman Date: 2013-05-16 12:13 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/83b519cafa68 Added tag jdk8-b90 for changeset 69b773a221b9 ! .hgtags Changeset: 40bba0507f76 Author: lana Date: 2013-05-17 10:06 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/40bba0507f76 Merge Changeset: 67b5cbe55744 Author: jlaskey Date: 2013-05-23 09:48 -0300 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/67b5cbe55744 Merge From james.laskey at oracle.com Thu May 23 05:54:56 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Thu, 23 May 2013 12:54:56 +0000 Subject: hg: nashorn/jdk8/corba: 2 new changesets Message-ID: <20130523125458.B58C148C9D@hg.openjdk.java.net> Changeset: c8286839d0df Author: katleman Date: 2013-05-09 10:03 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/corba/rev/c8286839d0df Added tag jdk8-b89 for changeset fe4150590ee5 ! .hgtags Changeset: 8f7ffb296385 Author: katleman Date: 2013-05-16 12:14 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/corba/rev/8f7ffb296385 Added tag jdk8-b90 for changeset c8286839d0df ! .hgtags From james.laskey at oracle.com Thu May 23 05:58:57 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Thu, 23 May 2013 12:58:57 +0000 Subject: hg: nashorn/jdk8/jaxp: 7 new changesets Message-ID: <20130523125914.7946C48C9F@hg.openjdk.java.net> Changeset: 6443f5627744 Author: dfuchs Date: 2013-05-17 10:40 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxp/rev/6443f5627744 8013900: More warnings compiling jaxp. Summary: Some internal implementation classes in Jaxp were redefining equals() without redefining hashCode(). This patch adds hashCode() methods that are consistent with equals(). Reviewed-by: chegar, joehw ! src/com/sun/org/apache/bcel/internal/generic/BasicType.java ! src/com/sun/org/apache/bcel/internal/generic/BranchInstruction.java ! src/com/sun/org/apache/bcel/internal/generic/CodeExceptionGen.java ! src/com/sun/org/apache/bcel/internal/generic/LineNumberGen.java ! src/com/sun/org/apache/bcel/internal/generic/LocalVariableGen.java ! src/com/sun/org/apache/bcel/internal/generic/ReturnaddressType.java ! src/com/sun/org/apache/bcel/internal/generic/Select.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/FunctionCall.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/VariableRefBase.java ! src/com/sun/org/apache/xerces/internal/impl/dv/xs/AbstractDateTimeDV.java ! src/com/sun/org/apache/xerces/internal/impl/dv/xs/DecimalDV.java ! src/com/sun/org/apache/xerces/internal/impl/dv/xs/PrecisionDecimalDV.java ! src/com/sun/org/apache/xerces/internal/util/URI.java ! src/com/sun/org/apache/xerces/internal/xinclude/XIncludeHandler.java ! src/com/sun/org/apache/xml/internal/dtm/ref/DTMNodeProxy.java ! src/com/sun/org/apache/xml/internal/serializer/utils/URI.java ! src/com/sun/org/apache/xml/internal/utils/URI.java ! src/com/sun/org/apache/xpath/internal/Arg.java Changeset: a7cec93e4682 Author: joehw Date: 2013-05-20 16:11 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxp/rev/a7cec93e4682 8014891: Redundant setting of external access properties in setFeatures Reviewed-by: lancea ! src/com/sun/org/apache/xerces/internal/jaxp/DocumentBuilderImpl.java ! src/com/sun/org/apache/xerces/internal/jaxp/SAXParserImpl.java Changeset: 37b73984640a Author: joehw Date: 2013-05-20 23:46 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxp/rev/37b73984640a 8012683: Remove unused, obsolete ObjectFactory classes Reviewed-by: lancea - src/com/sun/org/apache/xerces/internal/xinclude/ObjectFactory.java - src/com/sun/org/apache/xml/internal/serialize/ObjectFactory.java Changeset: 668acc0e1034 Author: katleman Date: 2013-05-09 10:03 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxp/rev/668acc0e1034 Added tag jdk8-b89 for changeset 893d2ba8bbea ! .hgtags Changeset: f39d61028d2f Author: katleman Date: 2013-05-16 12:14 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxp/rev/f39d61028d2f Added tag jdk8-b90 for changeset 668acc0e1034 ! .hgtags Changeset: e3065fb07877 Author: lana Date: 2013-05-17 10:07 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxp/rev/e3065fb07877 Merge Changeset: 0765806dcc58 Author: lana Date: 2013-05-22 09:54 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxp/rev/0765806dcc58 Merge From james.laskey at oracle.com Thu May 23 05:55:45 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Thu, 23 May 2013 12:55:45 +0000 Subject: hg: nashorn/jdk8/hotspot: 86 new changesets Message-ID: <20130523125847.D513348C9E@hg.openjdk.java.net> Changeset: 7d56b68a9672 Author: katleman Date: 2013-05-09 10:03 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/7d56b68a9672 Added tag jdk8-b89 for changeset 9c1fe0b419b4 ! .hgtags Changeset: 625ddb0052e1 Author: amurillo Date: 2013-05-03 08:19 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/625ddb0052e1 8013800: new hotspot build - hs25-b32 Reviewed-by: jcoomes ! make/hotspot_version Changeset: c456f4510385 Author: sla Date: 2013-05-03 12:24 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/c456f4510385 8008453: JvmtiClassFileReconstituter does not recognize default methods Reviewed-by: acorn, sspitsyn ! src/share/vm/prims/jvmtiClassFileReconstituter.cpp Changeset: 0380df7c3cd0 Author: sla Date: 2013-05-03 12:26 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/0380df7c3cd0 8013785: Respect EXTRA_CFLAGS on windows Reviewed-by: mgronlun, rbackman, kvn ! make/windows/makefiles/compile.make ! make/windows/makefiles/defs.make Changeset: 31a4e55f8c9d Author: fparain Date: 2013-05-03 05:05 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/31a4e55f8c9d 8004095: Add support for JMX interface to Diagnostic Framework and Commands Reviewed-by: acorn, sla ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/runtime/serviceThread.cpp ! src/share/vm/services/attachListener.cpp ! src/share/vm/services/diagnosticCommand.cpp ! src/share/vm/services/diagnosticCommand.hpp ! src/share/vm/services/diagnosticFramework.cpp ! src/share/vm/services/diagnosticFramework.hpp ! src/share/vm/services/jmm.h ! src/share/vm/services/management.cpp ! src/share/vm/services/management.hpp ! src/share/vm/services/nmtDCmd.cpp ! src/share/vm/services/nmtDCmd.hpp Changeset: 39fba0d6d9ad Author: fparain Date: 2013-05-03 05:17 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/39fba0d6d9ad Merge Changeset: bf089b838c9e Author: ccheung Date: 2013-05-02 16:55 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/bf089b838c9e 8012641: Perf_CreateLong creates perf counter of incorrect type Reviewed-by: mchung, hseigel, coleenp ! src/share/vm/prims/perf.cpp Changeset: a55b7b8c34af Author: zgu Date: 2013-05-03 13:00 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/a55b7b8c34af Merge Changeset: 9c8e2f44228d Author: dcubed Date: 2013-05-03 15:51 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/9c8e2f44228d Merge Changeset: 800078be49d2 Author: hseigel Date: 2013-05-06 09:10 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/800078be49d2 8013648: Guarantee(VerifyBeforeGC || VerifyDuringGC || VerifyBeforeExit || VerifyAfterGC) failed: too expensive Summary: Fix code to call correct version of function find_class(). Reviewed-by: coleenp, rdurbin, dcubed ! src/share/vm/classfile/systemDictionary.cpp Changeset: c18152e0554e Author: zgu Date: 2013-05-06 11:15 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/c18152e0554e 8013120: NMT: Kitchensink crashes with assert(next_region == NULL || !next_region->is_committed_region()) failed: Sanity check Summary: Fixed NMT to deal with releasing virtual memory region when there are still committed regions within it Reviewed-by: acorn, coleenp ! src/share/vm/memory/allocation.inline.hpp ! src/share/vm/runtime/os.cpp ! src/share/vm/runtime/os.hpp ! src/share/vm/services/memSnapshot.cpp + test/runtime/NMT/ReleaseCommittedMemory.java Changeset: da4d87770781 Author: zgu Date: 2013-05-06 08:49 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/da4d87770781 Merge Changeset: d9b08d62b95e Author: acorn Date: 2013-05-02 10:58 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/d9b08d62b95e 8010783: assert(s->refcount() != 0) failed: for create_overpasses Reviewed-by: kvn, dcubed ! src/share/vm/classfile/bytecodeAssembler.cpp Changeset: b7f3bf2ba33b Author: acorn Date: 2013-05-06 10:20 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/b7f3bf2ba33b Merge - agent/doc/c2replay.html Changeset: f916d5986c86 Author: acorn Date: 2013-05-06 12:36 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/f916d5986c86 Merge Changeset: 187154b7a226 Author: sla Date: 2013-05-06 19:49 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/187154b7a226 8009615: JvmtiClassFileReconstituter does not create BootstrapMethod attributes Reviewed-by: coleenp, sspitsyn ! src/share/vm/prims/jvmtiClassFileReconstituter.cpp ! src/share/vm/prims/jvmtiClassFileReconstituter.hpp Changeset: 3ecc6b9940de Author: sla Date: 2013-05-07 01:25 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/3ecc6b9940de Merge Changeset: b5fef8013a95 Author: sla Date: 2013-05-07 14:04 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/b5fef8013a95 8014044: Spelling error in JDK-8009615: boostrapmethod Reviewed-by: sspitsyn, coleenp ! src/share/vm/prims/jvmtiClassFileReconstituter.cpp ! src/share/vm/prims/jvmtiClassFileReconstituter.hpp Changeset: f6a055fcf47d Author: sla Date: 2013-05-07 14:33 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/f6a055fcf47d 8005038: remove crufty '_g' support from SA Reviewed-by: coleenp, mgronlun, rbackman ! agent/src/os/bsd/ps_core.c ! agent/src/os/linux/ps_core.c ! agent/src/os/solaris/proc/saproc.cpp ! agent/src/share/classes/sun/jvm/hotspot/HotSpotAgent.java ! agent/src/share/classes/sun/jvm/hotspot/LinuxVtblAccess.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebuggerLocal.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/linux/LinuxDebuggerLocal.java Changeset: 33bcd9ead1d5 Author: ctornqvi Date: 2013-05-07 21:36 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/33bcd9ead1d5 8009577: Test test/closed/runtime/classunload broken Summary: Fixed tests to use new way of utilizing the WB API, fixed issue with where custom classloader got the classes from Reviewed-by: collins, mgerdin, zgu + test/runtime/ClassUnload/KeepAliveClass.java + test/runtime/ClassUnload/KeepAliveClassLoader.java + test/runtime/ClassUnload/KeepAliveObject.java + test/runtime/ClassUnload/KeepAliveSoftReference.java + test/runtime/ClassUnload/UnloadTest.java + test/runtime/ClassUnload/classes/test/Empty.java + test/runtime/testlibrary/ClassUnloadCommon.java Changeset: 58bb870a0cbd Author: emc Date: 2013-05-07 13:45 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/58bb870a0cbd 8009729: Refix hotspot jni_.h JNIEXPORT and JNIIMPORT definitions to match jdk version Summary: Update JNIEXPORT and JNIIMPORT to work with other compilers that don't necessarily have the __attribute__ type qualifier Reviewed-by: dholmes, dcubed, coleenp ! src/cpu/sparc/vm/jni_sparc.h ! src/cpu/x86/vm/jni_x86.h ! src/cpu/zero/vm/jni_zero.h Changeset: 7243490a6847 Author: coleenp Date: 2013-05-07 14:30 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/7243490a6847 Merge Changeset: e60b3fce2b02 Author: jiangli Date: 2013-05-06 19:57 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/e60b3fce2b02 8013067: Zero builds are broken after 8010862. Summary: Fixed broken Zero build. Reviewed-by: twisti, coleenp, kvn ! src/cpu/zero/vm/cppInterpreter_zero.cpp ! src/share/vm/interpreter/bytecodeInterpreter.cpp ! src/share/vm/oops/method.hpp Changeset: 27d2d456cd96 Author: jiangli Date: 2013-05-06 20:11 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/27d2d456cd96 Merge Changeset: 6b388e7d4905 Author: bpittore Date: 2013-05-07 10:19 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/6b388e7d4905 8013633: Cleanup platform ifdefs in unsafe.cpp Summary: Replace ifdefs with SUPPORTS_NATIVE_CX8 set in platform include file Reviewed-by: dholmes, dlong ! src/cpu/sparc/vm/globalDefinitions_sparc.hpp ! src/cpu/x86/vm/globalDefinitions_x86.hpp ! src/share/vm/prims/unsafe.cpp Changeset: a258a8351528 Author: vladidan Date: 2013-05-07 10:36 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/a258a8351528 Merge - agent/doc/c2replay.html Changeset: d3c98423c146 Author: jiangli Date: 2013-05-09 16:27 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/d3c98423c146 Merge Changeset: 1d0fba8a2a6d Author: brutisso Date: 2013-05-02 22:35 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/1d0fba8a2a6d 8013574: PrintMalloc conflicts with the command line parsing Summary: Make sure that _num_jvm_args is not updated until the new entry to _jvm_args_array has been added Reviewed-by: johnc, tamao, tschatzl ! src/share/vm/runtime/arguments.cpp Changeset: f14063dcd52a Author: brutisso Date: 2013-05-06 09:16 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/f14063dcd52a 8013791: G1: G1CollectorPolicy::initialize_flags() may set min_alignment > max_alignment Summary: Make sure max alignemnt is at least as large as min alignment Reviewed-by: johnc, jmasa, tschatzl ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/memory/collectorPolicy.cpp + test/gc/g1/TestRegionAlignment.java Changeset: 30860066ae8f Author: jwilhelm Date: 2013-05-06 13:03 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/30860066ae8f Merge ! src/share/vm/runtime/arguments.cpp Changeset: d17700c82d7d Author: tschatzl Date: 2013-05-06 17:19 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/d17700c82d7d 8006088: Incompatible heap size flags accepted by VM Summary: Make processing of minimum, initial and maximum heap size more intiutive by removing previous limitations on allowed values, and make error reporting consistent. Further, fix errors in ergonomic heap sizing. Reviewed-by: johnc, jwilhelm, tamao ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/prims/whitebox.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp ! test/testlibrary/whitebox/sun/hotspot/WhiteBox.java Changeset: b0d20fa374b4 Author: brutisso Date: 2013-05-06 21:30 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/b0d20fa374b4 8013872: G1: HeapRegionSeq::shrink_by() has invalid assert Summary: Refactored shrink_by() to only use region counts and not byte sizes Reviewed-by: johnc, tschatzl ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/heapRegionSeq.cpp ! src/share/vm/gc_implementation/g1/heapRegionSeq.hpp + test/gc/g1/TestShrinkToOneRegion.java Changeset: a9d568b7df60 Author: jmasa Date: 2013-05-08 16:28 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/a9d568b7df60 8013032: CMS: assert(used() == used_after_gc && used_after_gc <= capacity()) failed: used: 0 used_after_gc: 292080 capacity: 1431699456 Reviewed-by: tschatzl, mgerdin, johnc ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp + test/gc/concurrentMarkSweep/CheckAllocateAndSystemGC.java Changeset: 06ab37f08701 Author: jmasa Date: 2013-05-08 17:12 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/06ab37f08701 8013184: CMS: Call reset_after_compaction() only if a compaction has been done Reviewed-by: mgerdin, johnc, tschatzl ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp + test/gc/concurrentMarkSweep/SystemGCOnForegroundCollector.java Changeset: 923ac8d1df95 Author: jwilhelm Date: 2013-05-09 12:23 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/923ac8d1df95 Merge Changeset: 194f52aa2f23 Author: johnc Date: 2013-05-09 11:16 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/194f52aa2f23 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap Summary: Refactor G1's hot card cache and card counts table into their own files. Simplify the card counts table, including removing the encoding of the card index in each entry. The card counts table now has a 1:1 correspondence with the cards spanned by heap. Space for the card counts table is reserved from virtual memory (rather than C heap) during JVM startup and is committed/expanded when the heap is expanded. Changes were also reviewed-by Vitaly Davidovich. Reviewed-by: tschatzl, jmasa ! make/excludeSrc.make ! src/share/vm/gc_implementation/g1/concurrentG1Refine.cpp ! src/share/vm/gc_implementation/g1/concurrentG1Refine.hpp + src/share/vm/gc_implementation/g1/g1CardCounts.cpp + src/share/vm/gc_implementation/g1/g1CardCounts.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1GCPhaseTimes.cpp ! src/share/vm/gc_implementation/g1/g1GCPhaseTimes.hpp + src/share/vm/gc_implementation/g1/g1HotCardCache.cpp + src/share/vm/gc_implementation/g1/g1HotCardCache.hpp ! src/share/vm/gc_implementation/g1/g1RemSet.cpp ! src/share/vm/gc_implementation/g1/g1RemSet.hpp ! src/share/vm/gc_implementation/g1/g1_globals.hpp ! src/share/vm/runtime/arguments.cpp Changeset: 73652d89e7c4 Author: stefank Date: 2013-05-10 09:24 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/73652d89e7c4 Merge Changeset: 69494caf5790 Author: amurillo Date: 2013-05-10 11:14 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/69494caf5790 Merge Changeset: 1ae0472ff3a0 Author: amurillo Date: 2013-05-10 11:14 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/1ae0472ff3a0 Added tag hs25-b32 for changeset 69494caf5790 ! .hgtags Changeset: 1cdbd42c3e49 Author: katleman Date: 2013-05-16 12:14 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/1cdbd42c3e49 Added tag jdk8-b90 for changeset 1ae0472ff3a0 ! .hgtags Changeset: 6114c49b31b5 Author: amurillo Date: 2013-05-10 11:27 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/6114c49b31b5 8014279: new hotspot build - hs25-b33 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 712a1e9c91f3 Author: coleenp Date: 2013-05-07 09:46 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/712a1e9c91f3 8013063: nsk/jvmti/RetransformClasses/retransform001 failed debug version on os::free Summary: Clear out class_file_bytes so they aren't deallocated twice Reviewed-by: dcubed, sspitsyn ! src/share/vm/prims/jvmtiRedefineClasses.cpp Changeset: 4674e409a9e6 Author: coleenp Date: 2013-05-07 18:51 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/4674e409a9e6 8014024: NPG: keep compiled ic methods from being deallocated in redefine classes Summary: Walk the compiledIC relocation records to keep Method* from being deallocated. Reviewed-by: dlong, kvn ! src/share/vm/code/nmethod.cpp Changeset: a1cc1d1e7ce5 Author: coleenp Date: 2013-05-07 16:17 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/a1cc1d1e7ce5 Merge Changeset: 28ae1d38d296 Author: coleenp Date: 2013-05-07 18:46 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/28ae1d38d296 Merge Changeset: 64340da5b68c Author: hseigel Date: 2013-05-08 08:20 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/64340da5b68c 8007018: RFE: -XX:+UseLargePages does not work with CDS Summary: Remove command line restriction. It should just work. Reviewed-by: ctornqvi, coleenp, dholmes ! src/share/vm/runtime/arguments.cpp Changeset: cbfe859bd244 Author: sla Date: 2013-05-08 15:37 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/cbfe859bd244 8013591: compiler/ciReplay/TestSA.sh fails in nightly Reviewed-by: coleenp, rbackman, dholmes ! agent/src/share/classes/sun/jvm/hotspot/ci/ciMethod.java ! agent/src/share/classes/sun/jvm/hotspot/oops/Method.java ! agent/src/share/classes/sun/jvm/hotspot/oops/MethodData.java Changeset: 0dc028fd5101 Author: sla Date: 2013-05-08 10:14 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/0dc028fd5101 Merge Changeset: 39ead0411f07 Author: bharadwaj Date: 2013-05-08 14:18 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/39ead0411f07 8013875: Incorrect vtable index being set during methodHandle creation for static Summary: Set vtable index as appropriate for static interface methods and for interface methods invoked via invokespecial. To be improved in a later enhancement to CallInfo. Reviewed-by: jrose, twisti ! src/share/vm/prims/methodHandles.cpp Changeset: 711016f146fd Author: dholmes Date: 2013-05-08 19:28 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/711016f146fd 8006997: ContendedPaddingWidth should be range-checked Summary: Constrain between zero and 8K Reviewed-by: dholmes, rbackman Contributed-by: Aleksey Shipilev ! src/share/vm/runtime/arguments.cpp Changeset: 9b77ca4ce35e Author: dholmes Date: 2013-05-08 19:38 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/9b77ca4ce35e Merge ! src/share/vm/runtime/arguments.cpp Changeset: c272092594bd Author: dholmes Date: 2013-05-08 21:06 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/c272092594bd Merge Changeset: 0b7f78069732 Author: rbackman Date: 2013-05-08 11:21 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/0b7f78069732 8008255: jvmtiExport.cpp::post_to_env() does not check malloc() return Reviewed-by: coleenp, dholmes, sla ! src/share/vm/prims/jvmtiExport.cpp Changeset: 735c995bf1a1 Author: rbackman Date: 2013-05-13 07:53 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/735c995bf1a1 Merge ! src/share/vm/runtime/arguments.cpp Changeset: 92ef81e2f571 Author: minqi Date: 2013-05-10 08:27 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/92ef81e2f571 8003557: NPG: Klass* const k should be const Klass* k. Summary: With NPG, const KlassOop klass which is in fact a definition converted to Klass* const, which is not the original intention. The right usage is converting them to const Klass*. Reviewed-by: coleenp, kvn Contributed-by: yumin.qi at oracle.com ! src/share/vm/c1/c1_Runtime1.cpp ! src/share/vm/classfile/verifier.cpp ! src/share/vm/classfile/verifier.hpp ! src/share/vm/gc_implementation/parallelScavenge/pcTasks.cpp ! src/share/vm/gc_implementation/parallelScavenge/psCompactionManager.cpp ! src/share/vm/gc_implementation/shared/markSweep.cpp ! src/share/vm/memory/heapInspection.cpp ! src/share/vm/memory/heapInspection.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/memory/universe.hpp ! src/share/vm/oops/constantPool.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/klass.cpp ! src/share/vm/oops/klass.hpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/method.hpp ! src/share/vm/oops/methodData.hpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvmtiTagMap.cpp Changeset: 1fcfc045b229 Author: minqi Date: 2013-05-10 19:30 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/1fcfc045b229 Merge Changeset: 8b40495b9381 Author: minqi Date: 2013-05-13 18:08 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/8b40495b9381 Merge ! src/share/vm/oops/method.hpp Changeset: 43083e670adf Author: coleenp Date: 2013-05-13 15:37 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/43083e670adf 8005056: NPG: Crash after redefining java.lang.Object Summary: Need to walk array class vtables replacing old methods too if j.l.o redefined Reviewed-by: sspitsyn, dcubed, ctornqvi ! src/share/vm/classfile/dictionary.cpp ! src/share/vm/classfile/dictionary.hpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/oops/klass.hpp ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! src/share/vm/prims/jvmtiRedefineClasses.hpp + test/runtime/RedefineObject/Agent.java + test/runtime/RedefineObject/TestRedefineObject.java ! test/testlibrary/ClassFileInstaller.java Changeset: a9270d9ecb13 Author: shade Date: 2013-05-14 11:34 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/a9270d9ecb13 8014448: Purge PrintCompactFieldsSavings Summary: Remove obsolete debugging code. Reviewed-by: dholmes, kvn Contributed-by: Aleksey Shipilev ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/runtime/globals.hpp Changeset: f944ba972151 Author: hseigel Date: 2013-05-14 09:17 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/f944ba972151 8014138: Add VM option to facilitate the writing of CDS tests Summary: Added the -XX:SharedArchiveFile option. Reviewed-by: coleenp, ccheung, acorn, dcubed, zgu ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp + test/runtime/SharedArchiveFile/SharedArchiveFile.java Changeset: f9be75d21404 Author: minqi Date: 2013-05-14 09:41 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/f9be75d21404 8012902: remove use of global operator new - take 2 Summary: The fix of 8010992, disable use of global operator new and new[] which caused failure on some tests. This takes two of the bugs also add ALLOW_OPERATOR_NEW_USAGE to prevent crash for third party code calling operator new of jvm on certain platforms. Reviewed-by: coleenp, dholmes, zgu Contributed-by: yumin.qi at oracle.com ! make/bsd/makefiles/fastdebug.make ! make/bsd/makefiles/vm.make ! src/os/windows/vm/os_windows.cpp ! src/share/vm/ci/ciReplay.cpp ! src/share/vm/classfile/altHashing.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsCollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp ! src/share/vm/memory/allocation.cpp ! src/share/vm/memory/allocation.hpp ! src/share/vm/memory/allocation.inline.hpp ! src/share/vm/memory/cardTableModRefBS.cpp ! src/share/vm/memory/cardTableModRefBS.hpp ! src/share/vm/memory/cardTableRS.cpp ! src/share/vm/memory/cardTableRS.hpp ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/memory/memRegion.cpp ! src/share/vm/memory/memRegion.hpp ! src/share/vm/opto/idealGraphPrinter.hpp ! src/share/vm/runtime/handles.cpp ! src/share/vm/runtime/handles.hpp ! src/share/vm/runtime/objectMonitor.hpp ! src/share/vm/runtime/reflectionUtils.hpp ! src/share/vm/runtime/unhandledOops.hpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/utilities/events.hpp ! src/share/vm/utilities/quickSort.cpp ! src/share/vm/utilities/workgroup.cpp ! src/share/vm/utilities/workgroup.hpp Changeset: 513a5298c1dd Author: minqi Date: 2013-05-14 17:33 +0000 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/513a5298c1dd Merge Changeset: d15464bfd4d0 Author: roland Date: 2013-05-03 09:32 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/d15464bfd4d0 8012037: Test8009761.java "Failed: init recursive calls: 7224. After deopt 58824" Summary: test shouldn't be run with a modified CompileThreshold Reviewed-by: kvn ! test/compiler/8009761/Test8009761.java Changeset: e76dd894b984 Author: roland Date: 2013-04-24 14:26 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/e76dd894b984 8012292: optimized build with GCC broken Summary: Some #ifndef PRODUCT should be #ifdef ASSERT Reviewed-by: kvn, twisti Contributed-by: gdub ! make/jprt.properties ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/vmSymbols.cpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/utilities/quickSort.cpp Changeset: d73c88e524ff Author: kvn Date: 2013-05-03 15:35 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/d73c88e524ff Merge ! src/share/vm/classfile/classFileParser.cpp Changeset: f0bc60565ba8 Author: twisti Date: 2013-05-06 13:53 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/f0bc60565ba8 7196277: JSR 292: Two jck/runtime tests crash on java.lang.invoke.MethodHandle.invokeExact Reviewed-by: jrose, kvn ! src/share/vm/oops/method.cpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/prims/nativeLookup.cpp ! src/share/vm/runtime/sharedRuntime.cpp Changeset: aabf54ccedb1 Author: twisti Date: 2013-05-06 19:49 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/aabf54ccedb1 8008772: remove gamma launcher Reviewed-by: kvn, neliasso, ctornqvi ! make/Makefile ! make/bsd/makefiles/buildtree.make - make/bsd/makefiles/launcher.make ! make/bsd/makefiles/vm.make + make/hotspot.script ! make/linux/makefiles/buildtree.make - make/linux/makefiles/launcher.make ! make/linux/makefiles/vm.make ! make/solaris/makefiles/buildtree.make - make/solaris/makefiles/launcher.make ! make/solaris/makefiles/vm.make ! make/windows/makefiles/debug.make ! make/windows/makefiles/fastdebug.make - make/windows/makefiles/launcher.make ! make/windows/makefiles/product.make ! make/windows/makefiles/projectcreator.make ! make/windows/projectfiles/common/Makefile - src/os/posix/launcher/java_md.c - src/os/posix/launcher/java_md.h - src/os/posix/launcher/launcher.script - src/os/windows/launcher/java_md.c - src/os/windows/launcher/java_md.h ! src/share/tools/ProjectCreator/BuildConfig.java ! src/share/tools/ProjectCreator/WinGammaPlatformVC10.java - src/share/tools/launcher/java.c - src/share/tools/launcher/java.h - src/share/tools/launcher/jli_util.c - src/share/tools/launcher/jli_util.h - src/share/tools/launcher/wildcard.c - src/share/tools/launcher/wildcard.h Changeset: 6f3fd5150b67 Author: kvn Date: 2013-05-08 15:08 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/6f3fd5150b67 6934604: enable parts of EliminateAutoBox by default Summary: Resurrected autobox elimination code and enabled part of it by default. Reviewed-by: roland, twisti ! src/share/vm/ci/ciInstanceKlass.cpp ! src/share/vm/ci/ciInstanceKlass.hpp ! src/share/vm/ci/ciMethod.cpp ! src/share/vm/ci/ciMethod.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/opto/c2compiler.cpp ! src/share/vm/opto/callGenerator.cpp ! src/share/vm/opto/callGenerator.hpp ! src/share/vm/opto/callnode.cpp ! src/share/vm/opto/callnode.hpp ! src/share/vm/opto/cfgnode.cpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/doCall.cpp ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/ifnode.cpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/loopPredicate.cpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/macro.hpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/memnode.hpp ! src/share/vm/opto/multnode.cpp ! src/share/vm/opto/multnode.hpp ! src/share/vm/opto/node.cpp ! src/share/vm/opto/node.hpp ! src/share/vm/opto/parse.hpp ! src/share/vm/opto/parse1.cpp ! src/share/vm/opto/parse2.cpp ! src/share/vm/opto/parse3.cpp ! src/share/vm/opto/parseHelper.cpp ! src/share/vm/opto/phase.cpp ! src/share/vm/opto/phase.hpp ! src/share/vm/opto/phaseX.cpp ! src/share/vm/opto/type.cpp ! src/share/vm/opto/type.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/vmStructs.cpp + test/compiler/6934604/TestByteBoxing.java + test/compiler/6934604/TestDoubleBoxing.java + test/compiler/6934604/TestFloatBoxing.java + test/compiler/6934604/TestIntBoxing.java + test/compiler/6934604/TestLongBoxing.java + test/compiler/6934604/TestShortBoxing.java Changeset: 70120f47d403 Author: kvn Date: 2013-05-09 17:28 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/70120f47d403 8014189: JVM crash with SEGV in ConnectionGraph::record_for_escape_analysis() Summary: Add NULL checks and asserts for Type::make_ptr() returned value. Reviewed-by: twisti ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/lcm.cpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/machnode.cpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/node.cpp ! src/share/vm/opto/node.hpp ! src/share/vm/opto/output.cpp ! src/share/vm/opto/subnode.cpp Changeset: 8bcfd9ce2c6b Author: twisti Date: 2013-05-13 12:43 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/8bcfd9ce2c6b Merge - make/bsd/makefiles/launcher.make - make/linux/makefiles/launcher.make - make/solaris/makefiles/launcher.make - make/windows/makefiles/launcher.make - src/os/posix/launcher/java_md.c - src/os/posix/launcher/java_md.h - src/os/posix/launcher/launcher.script - src/os/windows/launcher/java_md.c - src/os/windows/launcher/java_md.h - src/share/tools/launcher/java.c - src/share/tools/launcher/java.h - src/share/tools/launcher/jli_util.c - src/share/tools/launcher/jli_util.h - src/share/tools/launcher/wildcard.c - src/share/tools/launcher/wildcard.h ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/runtime/arguments.cpp Changeset: 1da5d70655e9 Author: kvn Date: 2013-05-13 14:36 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/1da5d70655e9 8014286: failed java/lang/Math/DivModTests.java after 6934604 changes Summary: Corrected escape state for the result of boxing method. Added force inlining executed boxing methods. Reviewed-by: twisti ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/escape.cpp Changeset: cd6f6fccd287 Author: iignatyev Date: 2013-05-15 22:44 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/cd6f6fccd287 8014068: TEST_BUG: compiler/ciReplay/TestSA.sh fails on Windows: core wasn't generated Reviewed-by: kvn ! test/compiler/ciReplay/TestSA.sh ! test/compiler/ciReplay/common.sh Changeset: e484fe2abebd Author: twisti Date: 2013-05-16 13:47 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/e484fe2abebd Merge - make/bsd/makefiles/launcher.make ! make/bsd/makefiles/vm.make - make/linux/makefiles/launcher.make - make/solaris/makefiles/launcher.make - make/windows/makefiles/launcher.make - src/os/posix/launcher/java_md.c - src/os/posix/launcher/java_md.h - src/os/posix/launcher/launcher.script - src/os/windows/launcher/java_md.c - src/os/windows/launcher/java_md.h - src/share/tools/launcher/java.c - src/share/tools/launcher/java.h - src/share/tools/launcher/jli_util.c - src/share/tools/launcher/jli_util.h - src/share/tools/launcher/wildcard.c - src/share/tools/launcher/wildcard.h ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/oops/method.cpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/utilities/quickSort.cpp Changeset: 7a95933197d0 Author: tschatzl Date: 2013-05-13 09:45 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/7a95933197d0 8014058: Regression tests for 8006088 Summary: The patch for 8006088 misses regression tests after a merge error, this CR provides them. Reviewed-by: jwilhelm, tamao, jmasa ! src/share/vm/memory/collectorPolicy.cpp + test/gc/arguments/TestCMSHeapSizeFlags.java + test/gc/arguments/TestG1HeapSizeFlags.java + test/gc/arguments/TestMaxHeapSizeTools.java + test/gc/arguments/TestMinInitialErgonomics.java + test/gc/arguments/TestParallelHeapSizeFlags.java + test/gc/arguments/TestSerialHeapSizeFlags.java Changeset: 4868caa99ecf Author: brutisso Date: 2013-05-13 14:09 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/4868caa99ecf 8014339: Improve assert and remove some dead code from parMarkBitMap.hpp/cpp Reviewed-by: stefank, tschatzl ! src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.cpp ! src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.hpp - src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.inline.hpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp Changeset: 0a2986f36965 Author: tschatzl Date: 2013-05-14 17:08 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/0a2986f36965 8014489: tests/gc/arguments/Test(Serial|CMS|Parallel|G1)HeapSizeFlags jtreg tests invoke wrong class Summary: Some jtreg tests reference unknown classes in the @run and @build lines. This change fixes them. Reviewed-by: stefank, ehelin ! test/gc/arguments/TestCMSHeapSizeFlags.java ! test/gc/arguments/TestG1HeapSizeFlags.java ! test/gc/arguments/TestParallelHeapSizeFlags.java ! test/gc/arguments/TestSerialHeapSizeFlags.java Changeset: 12f651e29f6b Author: tschatzl Date: 2013-05-15 11:05 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/12f651e29f6b 6843347: Boundary values in some public GC options cause crashes Summary: Setting some public integer options to specific values causes crashes or undefined GC behavior. This patchset adds the necessary argument checking for these options. Reviewed-by: jmasa, brutisso ! src/cpu/sparc/vm/globals_sparc.hpp ! src/cpu/x86/vm/globals_x86.hpp ! src/cpu/zero/vm/globals_zero.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweepDecorator.cpp ! src/share/vm/gc_implementation/shared/markSweep.cpp ! src/share/vm/gc_implementation/shared/markSweep.hpp ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/memory/space.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: eba99d16dc6f Author: tamao Date: 2013-05-15 10:41 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/eba99d16dc6f 8007763: Refactoring: split up compute_generation_free_space() into two functions for class PSAdaptiveSizePolicy Summary: split up compute_generation_free_space() into two functions: compute_eden_space_size() + compute_old_gen_free_space(), each of which (if needed) can be reused without executing an overhead of the other. Reviewed-by: jmasa, tschatzl Contributed-by: tamao ! src/share/vm/gc_implementation/parallelScavenge/psAdaptiveSizePolicy.cpp ! src/share/vm/gc_implementation/parallelScavenge/psAdaptiveSizePolicy.hpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp Changeset: bed55d125e37 Author: johnc Date: 2013-05-15 22:35 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/bed55d125e37 8014408: G1: crashes with assert assert(prev_committed_card_num == _committed_max_card_num) failed Summary: Mismatch in the card number calculation between next and previous committed sizes of the card counts table. Reviewed-by: jmasa, tschatzl ! src/share/vm/gc_implementation/g1/g1CardCounts.cpp ! src/share/vm/gc_implementation/g1/g1CardCounts.hpp Changeset: 05a17f270c7e Author: tschatzl Date: 2013-05-16 13:02 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/05a17f270c7e 8014240: G1: Add remembered set size information to output of G1PrintRegionLivenessInfo Summary: Improve the output of G1PrintRegionLivenessInfo by adding a per-region remembered set size information column Reviewed-by: jwilhelm, johnc ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp + test/gc/g1/TestPrintRegionRememberedSetInfo.java Changeset: 48391ab0687e Author: johnc Date: 2013-05-16 09:24 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/48391ab0687e 8010738: G1: Output for full GCs with +PrintGCDetails should contain perm gen size/meta data change info Summary: Include metaspace information (used, allocated, reserved) in the PrintGCDetails output for full GCs. Reviewed-by: poonam, jmasa, brutisso ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp + test/gc/g1/TestPrintGCDetails.java Changeset: acac2b03a07f Author: tschatzl Date: 2013-05-16 23:51 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/acac2b03a07f 8014765: VM exits if MaxTenuringThreshold is set below the default InitialTenuringThreshold, and InitialTenuringThreshold is not set Summary: The VM exits when the condition in the subject line applies. The fix sets InitialTenuringThreshold to MaxTenuringThreshold if it is larger than MaxTenuringThreshold and InitialTenuringThreshold has not been set (is default). Reviewed-by: jwilhelm, jmasa, brutisso, johnc ! src/share/vm/runtime/arguments.cpp + test/gc/arguments/TestInitialTenuringThreshold.java Changeset: 2958af1d8c5a Author: jwilhelm Date: 2013-05-17 06:01 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/2958af1d8c5a Merge ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp - src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.inline.hpp ! src/share/vm/gc_implementation/shared/markSweep.cpp ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: 2f9ac66165e6 Author: jwilhelm Date: 2013-05-17 08:00 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/2f9ac66165e6 Merge - src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.inline.hpp ! src/share/vm/runtime/arguments.cpp Changeset: b19517cecc2e Author: amurillo Date: 2013-05-17 08:59 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/b19517cecc2e Merge - make/bsd/makefiles/launcher.make - make/linux/makefiles/launcher.make - make/solaris/makefiles/launcher.make - make/windows/makefiles/launcher.make - src/os/posix/launcher/java_md.c - src/os/posix/launcher/java_md.h - src/os/posix/launcher/launcher.script - src/os/windows/launcher/java_md.c - src/os/windows/launcher/java_md.h - src/share/tools/launcher/java.c - src/share/tools/launcher/java.h - src/share/tools/launcher/jli_util.c - src/share/tools/launcher/jli_util.h - src/share/tools/launcher/wildcard.c - src/share/tools/launcher/wildcard.h - src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.inline.hpp Changeset: 7cbdf0e3725c Author: amurillo Date: 2013-05-17 08:59 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/hotspot/rev/7cbdf0e3725c Added tag hs25-b33 for changeset b19517cecc2e ! .hgtags From james.laskey at oracle.com Thu May 23 05:59:20 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Thu, 23 May 2013 12:59:20 +0000 Subject: hg: nashorn/jdk8/jaxws: 2 new changesets Message-ID: <20130523125927.28B4B48CA0@hg.openjdk.java.net> Changeset: 3e5b9ea5ac35 Author: katleman Date: 2013-05-09 10:04 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxws/rev/3e5b9ea5ac35 Added tag jdk8-b89 for changeset 88838e08e4ef ! .hgtags Changeset: 0bb1a9fa56b0 Author: katleman Date: 2013-05-16 12:14 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxws/rev/0bb1a9fa56b0 Added tag jdk8-b90 for changeset 3e5b9ea5ac35 ! .hgtags From attila.szegedi at oracle.com Thu May 23 06:05:31 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Thu, 23 May 2013 15:05:31 +0200 Subject: Review request for JDK-8012522 In-Reply-To: References: Message-ID: <06225D35-48EA-4A87-941D-E4788C33EF60@oracle.com> +1 On May 23, 2013, at 2:53 PM, Marcus Lagergren wrote: > Please review JDK-8012522 at http://cr.openjdk.java.net/~lagergren/8012522/webrev.00 > > Thanks, > Marcus. From james.laskey at oracle.com Thu May 23 06:01:41 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Thu, 23 May 2013 13:01:41 +0000 Subject: hg: nashorn/jdk8/jdk: 79 new changesets Message-ID: <20130523131753.58CD048CA3@hg.openjdk.java.net> Changeset: b315cb9a7544 Author: alanb Date: 2013-05-14 14:32 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/b315cb9a7544 8014500: bootcycle-images fails after upgrade to JAXP 1.5 Reviewed-by: lancea ! make/tools/src/build/tools/cldrconverter/CLDRConverter.java Changeset: 5ea5f5dfb96a Author: uta Date: 2013-05-14 20:16 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/5ea5f5dfb96a 8012453: (process) Runtime.exec(String) fails if command contains spaces [win] Reviewed-by: alanb ! src/share/classes/java/lang/ProcessBuilder.java ! src/windows/classes/java/lang/ProcessImpl.java + test/java/lang/Runtime/exec/ExecCommand.java Changeset: e0135f1a8627 Author: sundar Date: 2013-05-14 22:36 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/e0135f1a8627 8014519: scriptpad sample does not work with nashorn Reviewed-by: attila, jlaskey Contributed-by: rieberandreas at gmail.com ! src/share/sample/scripting/scriptpad/src/com/sun/sample/scriptpad/Main.java ! src/share/sample/scripting/scriptpad/src/resources/Main.js ! src/share/sample/scripting/scriptpad/src/resources/conc.js ! src/share/sample/scripting/scriptpad/src/resources/gui.js ! src/share/sample/scripting/scriptpad/src/resources/mm.js ! src/share/sample/scripting/scriptpad/src/resources/scriptpad.js ! src/share/sample/scripting/scriptpad/src/scripts/browse.js ! src/share/sample/scripting/scriptpad/src/scripts/insertfile.js ! src/share/sample/scripting/scriptpad/src/scripts/linewrap.js ! src/share/sample/scripting/scriptpad/src/scripts/mail.js ! src/share/sample/scripting/scriptpad/src/scripts/memmonitor.js ! src/share/sample/scripting/scriptpad/src/scripts/memory.js ! src/share/sample/scripting/scriptpad/src/scripts/memory.sh ! src/share/sample/scripting/scriptpad/src/scripts/textcolor.js Changeset: 790d292ee761 Author: khazra Date: 2013-05-14 12:01 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/790d292ee761 6328537: Improve javadocs for Socket class by adding references to SocketOptions Summary: Insert references to SocketOptions.java where applicable Reviewed-by: alanb, chegar ! src/share/classes/java/net/ServerSocket.java ! src/share/classes/java/net/Socket.java Changeset: 08ef70f60e0d Author: sherman Date: 2013-05-14 14:09 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/08ef70f60e0d 8012326: Deadlock occurs when Charset.availableCharsets() is called by several threads at the same time Summary: removed the race condition risk from ExtendedCahrset access code Reviewed-by: mchung, alanb ! make/sun/nio/cs/Makefile ! makefiles/CreateJars.gmk ! src/share/classes/java/nio/charset/Charset.java ! src/share/classes/sun/nio/cs/ext/ISO2022_JP_2.java - src/share/classes/sun/nio/cs/ext/META-INF/services/java.nio.charset.spi.CharsetProvider ! src/share/classes/sun/nio/cs/ext/MSISO2022JP.java Changeset: c70fff3db913 Author: sherman Date: 2013-05-14 14:20 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/c70fff3db913 8014217: Base64.getXDecoder().wrap(...).read() doesn't throw exception for an incorrect number of padding chars in the final unit Summary: to throw IOE for malformed final unit in base64 stream Reviewed-by: chegar, alanb ! src/share/classes/java/util/Base64.java ! test/java/util/Base64/TestBase64.java Changeset: a3d79a4c2a24 Author: dholmes Date: 2013-05-15 00:36 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/a3d79a4c2a24 8013395: StringBuffer.toString performance regression impacting embedded benchmarks Summary: cache a copy of the char[] to use with toString() and clear it when ever the sb content is modified Reviewed-by: alanb, plevart, mduigou, forax ! src/share/classes/java/lang/StringBuffer.java + test/java/lang/StringBuffer/ToStringCache.java Changeset: 93a268759ec3 Author: michaelm Date: 2013-05-15 15:01 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/93a268759ec3 8010464: Evolve java networking same origin policy Reviewed-by: alanb, chegar, dsamersoff, weijun ! src/share/classes/java/net/HttpURLConnection.java + src/share/classes/java/net/HttpURLPermission.java ! src/share/classes/sun/net/www/MessageHeader.java ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java + test/java/net/HttpURLPermission/HttpURLPermissionTest.java + test/java/net/HttpURLPermission/URLTest.java + test/java/net/HttpURLPermission/policy.1 + test/java/net/HttpURLPermission/policy.2 + test/java/net/HttpURLPermission/policy.3 Changeset: ef04044f77d2 Author: sherman Date: 2013-05-15 07:48 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/ef04044f77d2 8013730: JSR 310 DateTime API Updates III Summary: Integration of JSR310 Date/Time API update III Reviewed-by: naoto Contributed-by: scolebourne at joda.org, roger.riggs at oracle.com, masayoshi.okutsu at oracle.com, patrick.zhang at oracle.com ! src/share/classes/java/time/Clock.java ! src/share/classes/java/time/DateTimeException.java ! src/share/classes/java/time/DayOfWeek.java ! src/share/classes/java/time/Duration.java ! src/share/classes/java/time/Instant.java ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/LocalDateTime.java ! src/share/classes/java/time/LocalTime.java ! src/share/classes/java/time/Month.java ! src/share/classes/java/time/MonthDay.java ! src/share/classes/java/time/OffsetDateTime.java ! src/share/classes/java/time/OffsetTime.java ! src/share/classes/java/time/Period.java ! src/share/classes/java/time/Ser.java ! src/share/classes/java/time/Year.java ! src/share/classes/java/time/YearMonth.java ! src/share/classes/java/time/ZoneId.java ! src/share/classes/java/time/ZoneOffset.java ! src/share/classes/java/time/ZoneRegion.java ! src/share/classes/java/time/ZonedDateTime.java ! src/share/classes/java/time/chrono/ChronoDateImpl.java ! src/share/classes/java/time/chrono/ChronoLocalDate.java ! src/share/classes/java/time/chrono/ChronoLocalDateTime.java ! src/share/classes/java/time/chrono/ChronoLocalDateTimeImpl.java ! src/share/classes/java/time/chrono/ChronoZonedDateTime.java ! src/share/classes/java/time/chrono/ChronoZonedDateTimeImpl.java ! src/share/classes/java/time/chrono/Chronology.java ! src/share/classes/java/time/chrono/Era.java ! src/share/classes/java/time/chrono/HijrahChronology.java ! src/share/classes/java/time/chrono/HijrahDate.java ! src/share/classes/java/time/chrono/HijrahEra.java ! src/share/classes/java/time/chrono/IsoChronology.java ! src/share/classes/java/time/chrono/IsoEra.java ! src/share/classes/java/time/chrono/JapaneseChronology.java ! src/share/classes/java/time/chrono/JapaneseDate.java ! src/share/classes/java/time/chrono/JapaneseEra.java ! src/share/classes/java/time/chrono/MinguoChronology.java ! src/share/classes/java/time/chrono/MinguoDate.java ! src/share/classes/java/time/chrono/MinguoEra.java ! src/share/classes/java/time/chrono/Ser.java ! src/share/classes/java/time/chrono/ThaiBuddhistChronology.java ! src/share/classes/java/time/chrono/ThaiBuddhistDate.java ! src/share/classes/java/time/chrono/ThaiBuddhistEra.java - src/share/classes/java/time/format/DateTimeFormatSymbols.java ! src/share/classes/java/time/format/DateTimeFormatter.java ! src/share/classes/java/time/format/DateTimeFormatterBuilder.java ! src/share/classes/java/time/format/DateTimeParseContext.java ! src/share/classes/java/time/format/DateTimeParseException.java ! src/share/classes/java/time/format/DateTimePrintContext.java ! src/share/classes/java/time/format/DateTimeTextProvider.java + src/share/classes/java/time/format/DecimalStyle.java ! src/share/classes/java/time/format/FormatStyle.java ! src/share/classes/java/time/format/Parsed.java ! src/share/classes/java/time/format/ResolverStyle.java ! src/share/classes/java/time/format/SignStyle.java ! src/share/classes/java/time/format/TextStyle.java ! src/share/classes/java/time/format/package-info.java ! src/share/classes/java/time/temporal/ChronoField.java ! src/share/classes/java/time/temporal/ChronoUnit.java ! src/share/classes/java/time/temporal/IsoFields.java ! src/share/classes/java/time/temporal/JulianFields.java ! src/share/classes/java/time/temporal/Temporal.java ! src/share/classes/java/time/temporal/TemporalAccessor.java ! src/share/classes/java/time/temporal/TemporalAdjuster.java ! src/share/classes/java/time/temporal/TemporalAmount.java ! src/share/classes/java/time/temporal/TemporalField.java ! src/share/classes/java/time/temporal/TemporalQuery.java ! src/share/classes/java/time/temporal/TemporalUnit.java ! src/share/classes/java/time/temporal/UnsupportedTemporalTypeException.java ! src/share/classes/java/time/temporal/ValueRange.java ! src/share/classes/java/time/temporal/WeekFields.java ! src/share/classes/java/time/zone/Ser.java ! src/share/classes/java/time/zone/ZoneOffsetTransition.java ! src/share/classes/java/time/zone/ZoneOffsetTransitionRule.java ! src/share/classes/java/time/zone/ZoneRules.java ! src/share/classes/java/time/zone/ZoneRulesException.java ! src/share/classes/java/time/zone/ZoneRulesProvider.java ! src/share/classes/java/util/JapaneseImperialCalendar.java ! src/share/classes/sun/util/calendar/LocalGregorianCalendar.java ! test/java/time/tck/java/time/TCKInstant.java ! test/java/time/tck/java/time/TCKLocalTime.java ! test/java/time/tck/java/time/TCKOffsetTime.java ! test/java/time/tck/java/time/TCKYear.java ! test/java/time/tck/java/time/TCKYearMonth.java ! test/java/time/tck/java/time/TCKZoneOffset.java ! test/java/time/tck/java/time/chrono/TCKChronology.java ! test/java/time/tck/java/time/chrono/TCKChronologySerialization.java ! test/java/time/tck/java/time/chrono/TCKHijrahChronology.java ! test/java/time/tck/java/time/chrono/TCKJapaneseChronology.java ! test/java/time/tck/java/time/chrono/TCKThaiBuddhistChronology.java - test/java/time/tck/java/time/format/TCKDateTimeFormatSymbols.java ! test/java/time/tck/java/time/format/TCKDateTimeFormatter.java ! test/java/time/tck/java/time/format/TCKDateTimeFormatters.java ! test/java/time/tck/java/time/format/TCKDateTimeParseResolver.java + test/java/time/tck/java/time/format/TCKDecimalStyle.java + test/java/time/tck/java/time/format/TCKInstantPrinterParser.java ! test/java/time/tck/java/time/format/TCKTextStyle.java ! test/java/time/tck/java/time/temporal/TCKWeekFields.java ! test/java/time/test/java/time/chrono/TestChronologyPerf.java ! test/java/time/test/java/time/chrono/TestExampleCode.java + test/java/time/test/java/time/chrono/TestJapaneseChronology.java ! test/java/time/test/java/time/format/AbstractTestPrinterParser.java - test/java/time/test/java/time/format/TestDateTimeFormatSymbols.java ! test/java/time/test/java/time/format/TestDateTimeFormatter.java ! test/java/time/test/java/time/format/TestDateTimeFormatterBuilder.java + test/java/time/test/java/time/format/TestDecimalStyle.java ! test/java/time/test/java/time/format/TestFractionPrinterParser.java ! test/java/time/test/java/time/format/TestNonIsoFormatter.java ! test/java/time/test/java/time/format/TestNumberParser.java ! test/java/time/test/java/time/format/TestReducedParser.java ! test/java/time/test/java/time/format/TestReducedPrinter.java ! test/java/time/test/java/time/format/TestZoneTextPrinterParser.java Changeset: bad8f5237f10 Author: darcy Date: 2013-05-15 09:54 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/bad8f5237f10 8014677: Correct docs warning for Objects.requireNonNull(T, Supplier) Reviewed-by: alanb ! src/share/classes/java/util/Objects.java Changeset: 3d9f25dc630c Author: naoto Date: 2013-05-15 16:48 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/3d9f25dc630c 8013233: java/util/Locale/LocaleProviders.sh fails Reviewed-by: okutsu ! test/java/util/Locale/LocaleProviders.java ! test/java/util/Locale/LocaleProviders.sh Changeset: 2ec31660cc0e Author: valeriep Date: 2013-05-07 14:04 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/2ec31660cc0e 8010134: A finalizer in sun.security.pkcs11.wrapper.PKCS11 perhaps should be protected Summary: Change the finalize method of PKCS11 class to be protected. Reviewed-by: xuelei ! src/share/classes/sun/security/pkcs11/wrapper/PKCS11.java Changeset: 991420add35d Author: valeriep Date: 2013-05-07 14:06 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/991420add35d 7196009: SunPkcs11 provider fails to parse config path containing parenthesis Summary: Enhanced to allow quoted string as library path values. Reviewed-by: weijun ! src/share/classes/sun/security/pkcs11/Config.java ! test/sun/security/pkcs11/Provider/ConfigShortPath.java + test/sun/security/pkcs11/Provider/cspQuotedPath.cfg Changeset: 804da1e9bd04 Author: ascarpino Date: 2013-05-07 14:13 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/804da1e9bd04 8001284: Buffer problems with SunPKCS11-Solaris and CKM_AES_CTR Summary: Changed output length calculation to include incomplete blocks for CTR mode. Reviewed-by: valeriep ! src/share/classes/sun/security/pkcs11/P11Cipher.java ! test/sun/security/pkcs11/Cipher/TestSymmCiphersNoPad.java Changeset: fc70416beef3 Author: valeriep Date: 2013-05-13 16:52 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/fc70416beef3 Merge - make/com/sun/script/Makefile - make/sun/org/Makefile - make/sun/org/mozilla/Makefile - make/sun/org/mozilla/javascript/Makefile - src/share/classes/com/sun/script/javascript/ExternalScriptable.java - src/share/classes/com/sun/script/javascript/JSAdapter.java - src/share/classes/com/sun/script/javascript/JavaAdapter.java - src/share/classes/com/sun/script/javascript/META-INF/services/javax.script.ScriptEngineFactory - src/share/classes/com/sun/script/javascript/RhinoClassShutter.java - src/share/classes/com/sun/script/javascript/RhinoCompiledScript.java - src/share/classes/com/sun/script/javascript/RhinoScriptEngine.java - src/share/classes/com/sun/script/javascript/RhinoScriptEngineFactory.java - src/share/classes/com/sun/script/javascript/RhinoTopLevel.java - src/share/classes/com/sun/script/javascript/RhinoWrapFactory.java - src/share/classes/com/sun/script/util/BindingsBase.java - src/share/classes/com/sun/script/util/BindingsEntrySet.java - src/share/classes/com/sun/script/util/BindingsImpl.java - src/share/classes/com/sun/script/util/InterfaceImplementor.java - src/share/classes/com/sun/script/util/ScriptEngineFactoryBase.java - src/share/classes/java/beans/ReflectionUtils.java - test/java/awt/Focus/OverrideRedirectWindowActivationTest/OverrideRedirectWindowActivationTest.java - test/sun/security/provider/certpath/X509CertPath/ForwardBuildCompromised.java - test/sun/security/provider/certpath/X509CertPath/ReverseBuildCompromised.java - test/sun/security/provider/certpath/X509CertPath/ValidateCompromised.java Changeset: 59357ea7f131 Author: valeriep Date: 2013-05-15 18:38 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/59357ea7f131 Merge - src/share/classes/java/time/format/DateTimeFormatSymbols.java - src/share/classes/sun/nio/cs/ext/META-INF/services/java.nio.charset.spi.CharsetProvider - test/java/time/tck/java/time/format/TCKDateTimeFormatSymbols.java - test/java/time/test/java/time/format/TestDateTimeFormatSymbols.java Changeset: bb01cc14223c Author: ewang Date: 2013-05-16 10:59 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/bb01cc14223c 8004177: test/java/lang/Thread/GenerifyStackTraces.java doesn't clean-up Reviewed-by: alanb, dholmes, chegar ! test/java/lang/Thread/GenerifyStackTraces.java - test/java/lang/Thread/StackTraces.java Changeset: b198389f9da4 Author: xuelei Date: 2013-05-16 04:30 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/b198389f9da4 8010814: More buffers are stored or returned without cloning Reviewed-by: lancea ! src/share/classes/com/sun/jndi/ldap/BerDecoder.java ! src/share/classes/com/sun/jndi/ldap/BerEncoder.java ! src/share/classes/com/sun/jndi/ldap/ext/StartTlsResponseImpl.java Changeset: 81c449fd18fe Author: dmeetry Date: 2013-05-16 19:28 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/81c449fd18fe 8014676: Java debugger may fail to run Summary: The problem is observed when the binaries for windows are placed under a path which contains a space Reviewed-by: sla, alanb Contributed-by: ivan.gerasimov at oracle.com ! src/share/classes/com/sun/tools/jdi/AbstractLauncher.java ! src/share/classes/com/sun/tools/jdi/SunCommandLineLauncher.java Changeset: 74f91b7f4b66 Author: michaelm Date: 2013-05-16 17:28 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/74f91b7f4b66 8012625: Incorrect handling of HTTP/1.1 " Expect: 100-continue " in HttpURLConnection Reviewed-by: alanb, chegar ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java + test/sun/net/www/protocol/http/B8012625.java Changeset: d02d1b18d828 Author: michaelm Date: 2013-05-16 17:31 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/d02d1b18d828 Merge Changeset: da203779cb33 Author: jgish Date: 2013-05-16 11:19 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/da203779cb33 8013380: Removal of stack walk to find resource bundle breaks Glassfish startup Summary: Use caller's classloader to load resource as an alternative to thread context classloader and system classloader Reviewed-by: mchung, alanb ! src/share/classes/java/util/logging/LogManager.java ! src/share/classes/java/util/logging/Logger.java ! test/java/util/logging/bundlesearch/IndirectlyLoadABundle.java - test/java/util/logging/bundlesearch/LoadItUp.java + test/java/util/logging/bundlesearch/LoadItUp1.java + test/java/util/logging/bundlesearch/LoadItUp2.java + test/java/util/logging/bundlesearch/LoadItUp2Invoker.java ! test/java/util/logging/bundlesearch/ResourceBundleSearchTest.java + test/java/util/logging/bundlesearch/TwiceIndirectlyLoadABundle.java + test/java/util/logging/bundlesearch/resources/CallerSearchableResource_en.properties Changeset: df133f9cc4c9 Author: dfuchs Date: 2013-05-16 18:40 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/df133f9cc4c9 Merge Changeset: a8be9405bb4b Author: khazra Date: 2013-05-16 10:58 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/a8be9405bb4b 7150552: network test hangs [macosx] Summary: Remove usage of test/sun/net/www/httptest Reviewed-by: chegar ! test/ProblemList.txt ! test/java/net/CookieHandler/CookieManagerTest.java ! test/sun/net/www/protocol/http/B6299712.java Changeset: a13de892cefd Author: ksrini Date: 2013-05-15 18:26 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/a13de892cefd 8001163: [pack200] should support attributes introduced by JSR-308 Reviewed-by: jrose ! src/share/classes/com/sun/java/util/jar/pack/Attribute.java ! src/share/classes/com/sun/java/util/jar/pack/BandStructure.java ! src/share/classes/com/sun/java/util/jar/pack/Constants.java ! src/share/classes/com/sun/java/util/jar/pack/Fixups.java ! src/share/classes/com/sun/java/util/jar/pack/Package.java ! src/share/classes/com/sun/java/util/jar/pack/PackageReader.java ! src/share/native/com/sun/java/util/jar/pack/constants.h ! src/share/native/com/sun/java/util/jar/pack/unpack.cpp ! test/tools/pack200/AttributeTests.java + test/tools/pack200/BandIntegrity.java ! test/tools/pack200/InstructionTests.java ! test/tools/pack200/Utils.java ! test/tools/pack200/pack200-verifier/src/xmlkit/ClassReader.java + test/tools/pack200/typeannos/Lambda.java + test/tools/pack200/typeannos/Readme.txt + test/tools/pack200/typeannos/TargetTypes.java + test/tools/pack200/typeannos/TestTypeAnnotations.java + test/tools/pack200/typeannos/TypeUseTarget.java Changeset: 9abf5dc83823 Author: vinnie Date: 2013-05-14 18:08 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/9abf5dc83823 7194075: Various classes of sunec.jar are duplicated in rt.jar Reviewed-by: mullan, vinnie Contributed-by: Stephen Flores ! make/sun/security/ec/Makefile ! make/sun/security/other/Makefile ! makefiles/CreateJars.gmk + src/share/classes/sun/security/ec/CurveDB.java ! src/share/classes/sun/security/ec/ECDHKeyAgreement.java ! src/share/classes/sun/security/ec/ECDSASignature.java ! src/share/classes/sun/security/ec/ECKeyPairGenerator.java ! src/share/classes/sun/security/ec/ECParameters.java ! src/share/classes/sun/security/ec/ECPrivateKeyImpl.java ! src/share/classes/sun/security/ec/ECPublicKeyImpl.java ! src/share/classes/sun/security/ec/NamedCurve.java ! src/share/classes/sun/security/ec/SunECEntries.java ! src/share/classes/sun/security/pkcs11/P11ECKeyFactory.java ! src/share/classes/sun/security/pkcs11/P11Key.java ! src/share/classes/sun/security/pkcs11/P11KeyStore.java ! src/share/classes/sun/security/ssl/JsseJce.java + src/share/classes/sun/security/util/ECKeySizeParameterSpec.java + src/share/classes/sun/security/util/ECUtil.java ! test/sun/security/pkcs11/ec/TestCurves.java ! test/sun/security/pkcs11/ec/TestECDH2.java ! test/sun/security/pkcs11/ec/TestECDSA2.java Changeset: fdf082cddb69 Author: vinnie Date: 2013-05-14 18:11 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/fdf082cddb69 Merge Changeset: a399b8be56ae Author: vinnie Date: 2013-05-15 14:49 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/a399b8be56ae Merge ! makefiles/CreateJars.gmk - src/share/classes/sun/nio/cs/ext/META-INF/services/java.nio.charset.spi.CharsetProvider Changeset: 5153f5154162 Author: vinnie Date: 2013-05-15 15:39 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/5153f5154162 Merge Changeset: 0465f27f19f5 Author: vinnie Date: 2013-05-16 02:43 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/0465f27f19f5 Merge - src/share/classes/java/time/format/DateTimeFormatSymbols.java - test/java/time/tck/java/time/format/TCKDateTimeFormatSymbols.java - test/java/time/test/java/time/format/TestDateTimeFormatSymbols.java Changeset: 9783f07d43e6 Author: vinnie Date: 2013-05-16 13:22 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/9783f07d43e6 Merge - test/java/lang/Thread/StackTraces.java - test/java/util/logging/bundlesearch/LoadItUp.java Changeset: 5e8959ab64af Author: mchung Date: 2013-05-16 15:08 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/5e8959ab64af 4487672: (proxy) Proxy constructor should check for null argument Reviewed-by: alanb, lancea ! src/share/classes/java/lang/reflect/Proxy.java ! test/java/lang/reflect/Proxy/Basic1.java Changeset: 68209420aac2 Author: dfuchs Date: 2013-05-17 10:40 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/68209420aac2 8013900: More warnings compiling jaxp. Summary: Some internal implementation classes in Jaxp were redefining equals() without redefining hashCode(). This patch adds hashCode() methods that are consistent with equals(). Reviewed-by: chegar, joehw + test/javax/xml/jaxp/PrecisionDecimalDV/XPrecisionDecimalToString.java Changeset: 3981ad7ec458 Author: chegar Date: 2013-05-17 15:00 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/3981ad7ec458 8014791: More ProblemList.txt updates (5/2013) Reviewed-by: alanb ! test/ProblemList.txt Changeset: fab0e4b682e8 Author: chegar Date: 2013-05-17 15:18 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/fab0e4b682e8 Merge ! test/ProblemList.txt - test/java/util/logging/bundlesearch/LoadItUp.java Changeset: 222da3d4692a Author: chegar Date: 2013-05-17 16:44 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/222da3d4692a 8014783: java/net/HttpURLPermission/HttpURLPermissionTest.java leaves files open Reviewed-by: michaelm ! test/java/net/HttpURLPermission/HttpURLPermissionTest.java Changeset: fed779a87670 Author: chegar Date: 2013-05-17 16:44 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/fed779a87670 Merge - test/java/util/logging/bundlesearch/LoadItUp.java Changeset: 3b1450ee2bb9 Author: dxu Date: 2013-05-17 12:04 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/3b1450ee2bb9 8011136: FileInputStream.available and skip inconsistencies Summary: Correct the behavior of available() and update related java specs for available() and skip() in InputStream and FileInputStream classes. Reviewed-by: alanb ! src/share/classes/java/io/FileInputStream.java ! src/share/classes/java/io/InputStream.java ! src/share/native/java/io/FileInputStream.c ! test/java/io/FileInputStream/LargeFileAvailable.java ! test/java/io/FileInputStream/NegativeAvailable.java Changeset: 0f7aaabed25f Author: weijun Date: 2013-05-18 10:15 +0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/0f7aaabed25f 8012261: update policytool to support java.net.HttpURLPermission Reviewed-by: mullan ! src/share/classes/sun/security/tools/policytool/PolicyTool.java ! src/share/classes/sun/security/tools/policytool/Resources.java Changeset: e8b40b034fcd Author: psandoz Date: 2013-05-15 10:15 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/e8b40b034fcd 8013334: Spliterator behavior for LinkedList contradicts Spliterator.trySplit Summary: this changeset also contains some minor, non spec, related fixes to tidy up other areas of the JavaDoc. Reviewed-by: plevart, darcy Contributed-by: John Rose , Mike Duigou , Paul Sandoz ! src/share/classes/java/util/Spliterator.java Changeset: 6bbc2816d936 Author: psandoz Date: 2013-05-15 10:25 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/6bbc2816d936 8014133: Spliterator.OfPrimitive Reviewed-by: mduigou, forax Contributed-by: Paul Sandoz , Brian Goetz ! src/share/classes/java/util/Spliterator.java Changeset: dc5cf74c8c9c Author: mduigou Date: 2013-05-17 10:36 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/dc5cf74c8c9c 8004015: Additional static and instance utils for functional interfaces. 8011010: Spec j.u.f.Predicate doesn't specify NPEs thrown by the SE8's Reference Implementation Reviewed-by: briangoetz, dholmes, chegar ! src/share/classes/java/util/function/BiConsumer.java ! src/share/classes/java/util/function/BiFunction.java ! src/share/classes/java/util/function/BiPredicate.java ! src/share/classes/java/util/function/BooleanSupplier.java ! src/share/classes/java/util/function/Consumer.java ! src/share/classes/java/util/function/DoubleBinaryOperator.java ! src/share/classes/java/util/function/DoubleConsumer.java ! src/share/classes/java/util/function/DoubleFunction.java ! src/share/classes/java/util/function/DoublePredicate.java ! src/share/classes/java/util/function/DoubleSupplier.java ! src/share/classes/java/util/function/DoubleUnaryOperator.java ! src/share/classes/java/util/function/Function.java ! src/share/classes/java/util/function/IntBinaryOperator.java ! src/share/classes/java/util/function/IntConsumer.java ! src/share/classes/java/util/function/IntFunction.java ! src/share/classes/java/util/function/IntPredicate.java ! src/share/classes/java/util/function/IntSupplier.java ! src/share/classes/java/util/function/IntUnaryOperator.java ! src/share/classes/java/util/function/LongBinaryOperator.java ! src/share/classes/java/util/function/LongConsumer.java ! src/share/classes/java/util/function/LongFunction.java ! src/share/classes/java/util/function/LongPredicate.java ! src/share/classes/java/util/function/LongSupplier.java ! src/share/classes/java/util/function/LongUnaryOperator.java ! src/share/classes/java/util/function/ObjDoubleConsumer.java ! src/share/classes/java/util/function/ObjIntConsumer.java ! src/share/classes/java/util/function/ObjLongConsumer.java ! src/share/classes/java/util/function/Predicate.java ! src/share/classes/java/util/function/Supplier.java ! src/share/classes/java/util/function/ToDoubleBiFunction.java ! src/share/classes/java/util/function/ToDoubleFunction.java ! src/share/classes/java/util/function/ToIntBiFunction.java ! src/share/classes/java/util/function/ToIntFunction.java ! src/share/classes/java/util/function/ToLongBiFunction.java ! src/share/classes/java/util/function/ToLongFunction.java ! src/share/classes/java/util/function/UnaryOperator.java Changeset: 23e75751554a Author: henryjen Date: 2013-05-09 14:44 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/23e75751554a 8006884: (fs) Add Files.list, lines and find Reviewed-by: briangoetz, mduigou Contributed-by: alan.bateman at oracle.com, henry.jen at oracle.com + src/share/classes/java/nio/file/FileTreeIterator.java ! src/share/classes/java/nio/file/FileTreeWalker.java ! src/share/classes/java/nio/file/Files.java + test/java/nio/file/Files/FaultyFileSystem.java ! test/java/nio/file/Files/PassThroughFileSystem.java + test/java/nio/file/Files/StreamTest.java Changeset: b9b26b424bfc Author: mduigou Date: 2013-05-18 18:55 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/b9b26b424bfc Merge Changeset: 08ebdb2b53cc Author: plevart Date: 2013-05-17 14:41 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/08ebdb2b53cc 8014477: (str) Race condition in String.contentEquals when comparing with StringBuffer Reviewed-by: alanb, mduigou, dholmes ! src/share/classes/java/lang/String.java + test/java/lang/String/StringContentEqualsBug.java Changeset: 6a9148865139 Author: sherman Date: 2013-05-20 11:56 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/6a9148865139 8004789: (zipfs) zip provider doesn't work correctly with file systems providers rather than the default Summary: to use Files.createTempFile(...) to create the temp file on the same fs as the targeted path. Reviewed-by: alanb, sherman Contributed-by: philippe.marschall at gmail.com ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipFileSystem.java Changeset: 1baf3d7fe2f1 Author: dholmes Date: 2013-05-21 01:17 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/1baf3d7fe2f1 8014857: Enable ergonomic VM selection in arm/jvm.cfg Reviewed-by: darcy ! src/solaris/bin/arm/jvm.cfg Changeset: 20925206aef8 Author: alanb Date: 2013-05-21 08:53 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/20925206aef8 8014892: More ProblemList.txt updates (5/2013) Reviewed-by: alanb Contributed-by: amy.lu at oracle.com ! test/ProblemList.txt Changeset: 63c7e92e5e6d Author: yhuang Date: 2013-05-20 23:03 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/63c7e92e5e6d 7074882: Locale data needs correction (Month names for Maltese language) Reviewed-by: naoto ! src/share/classes/sun/text/resources/mt/FormatData_mt.java ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java Changeset: 1fba35ef4360 Author: yhuang Date: 2013-05-21 01:50 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/1fba35ef4360 Merge Changeset: 48e8a6e0c805 Author: chegar Date: 2013-05-22 13:50 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/48e8a6e0c805 8010182: Thread safety of Thread get/setName() Reviewed-by: dholmes, alanb, mduigou ! src/share/classes/java/lang/Thread.java Changeset: 4b555b53dc57 Author: mduigou Date: 2013-05-22 09:59 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/4b555b53dc57 8014819: set max size for jtreg testvms Reviewed-by: alanb, darcy ! test/Makefile Changeset: b8e7d145abc2 Author: katleman Date: 2013-05-09 10:04 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/b8e7d145abc2 Added tag jdk8-b89 for changeset 845025546e35 ! .hgtags Changeset: 1f1699686504 Author: katleman Date: 2013-05-09 15:04 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/1f1699686504 8014289: JDK8 b89 source with GPL header errors Reviewed-by: mchung, mduigou, tbell, dsamersoff ! src/share/classes/java/util/Base64.java ! src/share/classes/java/util/StringJoiner.java ! test/java/lang/CharSequence/DefaultTest.java ! test/java/util/StringJoiner/StringJoinerTest.java Changeset: c63eda8f6300 Author: katleman Date: 2013-05-14 12:19 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/c63eda8f6300 Merge Changeset: 08c28cdacd7b Author: katleman Date: 2013-05-16 12:15 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/08c28cdacd7b Added tag jdk8-b90 for changeset c63eda8f6300 ! .hgtags Changeset: 4dd6f7bb8bbd Author: simonis Date: 2013-05-06 12:57 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/4dd6f7bb8bbd 7191872: Xrender: No text displayed using 64 bit JDK on solaris11-sparc Reviewed-by: prr, ceisserer ! src/share/classes/sun/font/FileFontStrike.java ! src/share/classes/sun/font/GlyphList.java ! src/solaris/classes/sun/font/XRGlyphCacheEntry.java ! src/solaris/native/sun/java2d/x11/XRBackendNative.c Changeset: 23f7ff502a89 Author: jgodinez Date: 2013-05-07 09:32 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/23f7ff502a89 8011069: Printing: NullPointerException since jdk8 b82 showing native Page Setup Dialog. Reviewed-by: bae, prr ! src/macosx/classes/sun/lwawt/macosx/CPrinterJob.java ! src/share/classes/sun/print/RasterPrinterJob.java Changeset: 8a995d335d59 Author: lana Date: 2013-05-09 19:17 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/8a995d335d59 Merge - src/share/classes/java/beans/ReflectionUtils.java - test/java/awt/Focus/OverrideRedirectWindowActivationTest/OverrideRedirectWindowActivationTest.java - test/java/io/Serializable/accessConstants/AccessConstants.java - test/java/nio/file/Files/walkFileTree/walk_file_tree.sh - test/sun/reflect/CallerSensitive/MethodFinder.java Changeset: 103f492d8ce7 Author: vadim Date: 2013-05-17 17:19 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/103f492d8ce7 4892259: GIF ImageReader does not call passComplete in IIOReadUpdateListener Reviewed-by: prr, bae ! src/share/classes/com/sun/imageio/plugins/gif/GIFImageReader.java + test/javax/imageio/plugins/gif/GIFPassListenerTest.java Changeset: 4ee85e865a83 Author: vadim Date: 2013-05-17 14:18 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/4ee85e865a83 8000936: Enable Java2D D3D pipeline on newer Intel chipsets : Intel HD and later Reviewed-by: prr, bae ! src/windows/native/sun/java2d/d3d/D3DBadHardware.h Changeset: 51f5e544c88b Author: lana Date: 2013-05-17 10:04 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/51f5e544c88b Merge Changeset: 90b67c9a7eb2 Author: serb Date: 2013-05-06 16:23 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/90b67c9a7eb2 7161575: [macosx] On MacOSX port java.awt.Toolkit.is/setDynamicLayout() are not consistent Reviewed-by: anthony, art ! src/macosx/classes/sun/lwawt/LWToolkit.java Changeset: 7982299cd11c Author: serb Date: 2013-05-08 15:58 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/7982299cd11c 8013841: [macosx] Animations not disabled for CALayers used via JAWT Reviewed-by: anthony, alexsch ! src/macosx/native/sun/awt/AWTSurfaceLayers.m ! src/macosx/native/sun/java2d/opengl/CGLLayer.m Changeset: 5fe0a4da863d Author: lana Date: 2013-05-09 18:42 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/5fe0a4da863d Merge - test/java/io/Serializable/accessConstants/AccessConstants.java - test/java/nio/file/Files/walkFileTree/walk_file_tree.sh - test/sun/reflect/CallerSensitive/MethodFinder.java Changeset: a466a4192fea Author: pchelko Date: 2013-05-14 16:39 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/a466a4192fea 8002045: Auto failed and threw exception:java.lang.UnsatisfiedLinkError: Reviewed-by: serb, anthony ! make/sun/awt/mapfile-vers ! make/sun/awt/mapfile-vers-bsd ! make/sun/awt/mapfile-vers-linux ! makefiles/mapfiles/libawt/mapfile-vers ! makefiles/mapfiles/libawt/mapfile-vers-linux Changeset: b1a7cc79f13d Author: serb Date: 2013-05-14 17:25 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/b1a7cc79f13d 8014423: [macosx] The scrollbar's block increment performs incorrectly Reviewed-by: anthony, art ! src/macosx/classes/sun/lwawt/LWScrollBarPeer.java Changeset: 722ee3129ce0 Author: ant Date: 2013-05-15 16:49 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/722ee3129ce0 8014227: JLightweightFrame needs another synchronization policy Reviewed-by: art ! src/share/classes/sun/swing/JLightweightFrame.java Changeset: 7a8a8e31a126 Author: pchelko Date: 2013-05-17 11:02 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/7a8a8e31a126 7079254: Toolkit eventListener leaks memory Reviewed-by: serb, art ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Container.java + test/java/awt/LightweightDispatcher/LWDispatcherMemoryLeakTest.java Changeset: e944b78812a8 Author: kshefov Date: 2013-05-17 14:08 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/e944b78812a8 8014721: TEST_BUG: java/awt/TrayIcon/DragEventSource/DragEventSource.java fails with java.lang.UnsupportedOperationException Reviewed-by: anthony, serb ! test/java/awt/TrayIcon/DragEventSource/DragEventSource.java Changeset: 281add053efe Author: kshefov Date: 2013-05-17 14:11 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/281add053efe 8013426: TEST_BUG: java/awt/datatransfer/HTMLDataFlavors/HTMLDataFlavorTest.java fails with "RuntimeException: The data should be available" on Linux Reviewed-by: anthony, serb ! test/java/awt/datatransfer/HTMLDataFlavors/HTMLDataFlavorTest.java Changeset: 49871f1581b8 Author: lana Date: 2013-05-17 10:06 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/49871f1581b8 Merge Changeset: 30101f69e66f Author: lana Date: 2013-05-17 10:11 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/30101f69e66f Merge - make/com/sun/script/Makefile - make/sun/org/Makefile - make/sun/org/mozilla/Makefile - make/sun/org/mozilla/javascript/Makefile - src/share/classes/com/sun/script/javascript/ExternalScriptable.java - src/share/classes/com/sun/script/javascript/JSAdapter.java - src/share/classes/com/sun/script/javascript/JavaAdapter.java - src/share/classes/com/sun/script/javascript/META-INF/services/javax.script.ScriptEngineFactory - src/share/classes/com/sun/script/javascript/RhinoClassShutter.java - src/share/classes/com/sun/script/javascript/RhinoCompiledScript.java - src/share/classes/com/sun/script/javascript/RhinoScriptEngine.java - src/share/classes/com/sun/script/javascript/RhinoScriptEngineFactory.java - src/share/classes/com/sun/script/javascript/RhinoTopLevel.java - src/share/classes/com/sun/script/javascript/RhinoWrapFactory.java - src/share/classes/com/sun/script/util/BindingsBase.java - src/share/classes/com/sun/script/util/BindingsEntrySet.java - src/share/classes/com/sun/script/util/BindingsImpl.java - src/share/classes/com/sun/script/util/InterfaceImplementor.java - src/share/classes/com/sun/script/util/ScriptEngineFactoryBase.java - src/share/classes/java/time/format/DateTimeFormatSymbols.java ! src/share/classes/java/util/Base64.java - src/share/classes/sun/nio/cs/ext/META-INF/services/java.nio.charset.spi.CharsetProvider - test/java/lang/Thread/StackTraces.java - test/java/time/tck/java/time/format/TCKDateTimeFormatSymbols.java - test/java/time/test/java/time/format/TestDateTimeFormatSymbols.java - test/java/util/logging/bundlesearch/LoadItUp.java - test/sun/security/provider/certpath/X509CertPath/ForwardBuildCompromised.java - test/sun/security/provider/certpath/X509CertPath/ReverseBuildCompromised.java - test/sun/security/provider/certpath/X509CertPath/ValidateCompromised.java Changeset: bcfab7056195 Author: lana Date: 2013-05-22 09:57 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/bcfab7056195 Merge Changeset: 760d4187597a Author: lana Date: 2013-05-22 12:09 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/760d4187597a Merge Changeset: 50fde3eeb48c Author: naoto Date: 2013-05-22 16:43 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/50fde3eeb48c 7056126: DateFormatSymbols documentation has incorrect description about DateFormat 7083668: Sample code in ListResourceBundle is still not correct Reviewed-by: okutsu ! src/share/classes/java/text/DateFormatSymbols.java ! src/share/classes/java/util/ListResourceBundle.java Changeset: a1a8e71e130a Author: dholmes Date: 2013-05-22 20:21 -0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/a1a8e71e130a 8014814: (str) StringBuffer "null" is not appended Reviewed-by: alanb ! src/share/classes/java/lang/StringBuffer.java ! test/java/lang/StringBuffer/ToStringCache.java Changeset: e764bb01567e Author: darcy Date: 2013-05-22 20:03 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/e764bb01567e 8014836: Have GenericDeclaration extend AnnotatedElement Reviewed-by: abuckley, jfranck ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/reflect/GenericDeclaration.java Changeset: efd620f8963f Author: jlaskey Date: 2013-05-23 09:48 -0300 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/efd620f8963f Merge ! makefiles/CreateJars.gmk From james.laskey at oracle.com Thu May 23 06:18:17 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Thu, 23 May 2013 13:18:17 +0000 Subject: hg: nashorn/jdk8/langtools: 40 new changesets Message-ID: <20130523132014.6210648CA5@hg.openjdk.java.net> Changeset: 8ea30d59ac41 Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/8ea30d59ac41 8010440: Replace int constants in LinkInfoImpl with enum Reviewed-by: bpatel, darcy ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractExecutableMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractTreeWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AllClassesFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeRequiredMemberWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstantsSummaryWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/EnumConstantWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/FieldWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialFieldWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkInfoImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/MethodWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/NestedClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PropertyWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/SerializedFormWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/LinkInfo.java Changeset: 74cd21f2c2fe Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/74cd21f2c2fe 8011642: Remove LinkOutput in favor of direct use of Content Reviewed-by: bpatel, darcy ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractExecutableMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AllClassesFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeRequiredMemberWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstantsSummaryWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/EnumConstantWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/FieldWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialFieldWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/MethodWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/NestedClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageTreeWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PropertyWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/SerializedFormWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java + src/share/classes/com/sun/tools/doclets/formats/html/markup/ContentBuilder.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTree.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Content.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/PackageSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocletConstants.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/LinkFactory.java ! test/com/sun/javadoc/testNewLanguageFeatures/TestNewLanguageFeatures.java ! test/com/sun/javadoc/testTypeAnnotations/TestTypeAnnotations.java Changeset: 7a9ef837e57f Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/7a9ef837e57f 8011650: reduce use of RawHtml nodes in doclet Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractExecutableMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AllClassesFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/FieldWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkInfoImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/MethodWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/NestedClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageIndexFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PropertyWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/SerializedFormWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/SourceToHTMLConverter.java ! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/ContentBuilder.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTree.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/RawHtml.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/StringContent.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Content.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/LinkFactory.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/LinkInfo.java Changeset: 6ea964c78845 Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/6ea964c78845 8011651: simplify LinkInfoImpl API Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractExecutableMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AllClassesFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstantsSummaryWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkInfoImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/MethodWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/NestedClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/SerializedFormWriterImpl.java Changeset: e6c5b5ee9fac Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/e6c5b5ee9fac 8011662: Remove single instance of resource with HTML from doclet resource bundle Reviewed-by: bpatel, darcy ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/ContentBuilder.java ! src/share/classes/com/sun/tools/doclets/formats/html/resources/standard.properties Changeset: ce4f0769b4b2 Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/ce4f0769b4b2 8011668: Allow HTMLWriter.getResource to take Content args Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConfigurationImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/FrameOutputWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HelpWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageTreeWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/ContentBuilder.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/resources/standard.properties ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java Changeset: 4c43e51433ba Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/4c43e51433ba 8011288: Erratic/inconsistent indentation of signatures Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractExecutableMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstructorWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/MethodWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/RawHtml.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/StringContent.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Content.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/LinkFactory.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/LinkInfo.java + test/com/sun/javadoc/testIndentation/TestIndentation.java + test/com/sun/javadoc/testIndentation/p/Indent.java ! test/com/sun/javadoc/testNewLanguageFeatures/TestNewLanguageFeatures.java ! test/com/sun/javadoc/testTypeAnnotations/TestTypeAnnotations.java ! test/com/sun/javadoc/testTypeParams/TestTypeParameters.java Changeset: 7af0fa419a2b Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/7af0fa419a2b 8012174: {@literal} and {@code} should use \"new\" Taglet, not old. Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTag.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/CodeTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ExpertTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/LiteralTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletManager.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletWriter.java Changeset: 6a5288a298fd Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/6a5288a298fd 8012175: Convert TagletOutputImpl to use ContentBuilder instead of StringBuilder Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialFieldWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialMethodWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/TagletOutputImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/CodeTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/InheritDocTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/LiteralTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/Taglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletOutput.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletWriter.java ! test/com/sun/javadoc/AuthorDD/AuthorDD.java ! test/com/sun/javadoc/testConstructorIndent/TestConstructorIndent.java ! test/com/sun/javadoc/testHref/TestHref.java ! test/com/sun/javadoc/testHtmlDefinitionListTag/TestHtmlDefinitionListTag.java ! test/com/sun/javadoc/testJavaFX/TestJavaFX.java ! test/com/sun/javadoc/testNewLanguageFeatures/TestNewLanguageFeatures.java ! test/com/sun/javadoc/testParamTaglet/TestParamTaglet.java ! test/com/sun/javadoc/testSerializedFormDeprecationInfo/TestSerializedFormDeprecationInfo.java ! test/com/sun/javadoc/testSimpleTagInherit/TestSimpleTagInherit.java ! test/com/sun/javadoc/testSinceTag/TestSinceTag.java ! test/com/sun/javadoc/testValueTag/TestValueTag.java Changeset: 76a691e3e961 Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/76a691e3e961 8012176: reduce use of TagletOutputImpl.toString Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialFieldWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialMethodWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/TagletOutputImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java ! test/com/sun/javadoc/testConstructorIndent/TestConstructorIndent.java ! test/com/sun/javadoc/testHtmlDefinitionListTag/TestHtmlDefinitionListTag.java ! test/com/sun/javadoc/testJavaFX/TestJavaFX.java ! test/com/sun/javadoc/testNewLanguageFeatures/TestNewLanguageFeatures.java ! test/com/sun/javadoc/testSerializedFormDeprecationInfo/TestSerializedFormDeprecationInfo.java ! test/com/sun/javadoc/testSinceTag/TestSinceTag.java Changeset: 937aa020c667 Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/937aa020c667 8012177: HTMLDocletWriter methods should generate Content, not Strings Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java Changeset: bd51ca92c013 Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/bd51ca92c013 8012178: Cleanup use of Util.escapeHtmlChars Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/SubWriterHolderWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTree.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/StringContent.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/PackageSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ValueTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Util.java Changeset: df4f44800923 Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/df4f44800923 8012183: replace some uses of Configuration.getText with Configuration.getResource Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractPackageIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeOptionalMemberWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeRequiredMemberWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConfigurationImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstantsSummaryWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstructorWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/EnumConstantWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/FieldWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/MethodWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/NestedClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ProfileIndexFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageIndexFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PropertyWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/SerializedFormWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTree.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java Changeset: 051b728cfe90 Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/051b728cfe90 8012180: Speed up removeNonInlineHtmlTags Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/SourceToHTMLConverter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTag.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Util.java Changeset: 25c89a492f14 Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/25c89a492f14 8012295: Cleanup JavaFX features in standard doclet Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/BasePropertyTaglet.java - src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ExpertTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletManager.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletWriter.java ! test/com/sun/javadoc/testJavaFX/TestJavaFX.java Changeset: 081d7c72ee92 Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/081d7c72ee92 8012311: Cleanup names and duplicatre code in TagletManager Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialFieldWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialMethodWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletManager.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletWriter.java ! test/com/sun/javadoc/testJavaFX/TestJavaFX.java Changeset: ca8808c88f94 Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/ca8808c88f94 8012308: Remove TagletOutput in favor of direct use of Content Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialFieldWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialMethodWriter.java - src/share/classes/com/sun/tools/doclets/formats/html/TagletOutputImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/ContentBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/BasePropertyTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/BaseTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/CodeTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/DeprecatedTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/DocRootTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/InheritDocTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/LegacyTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/LiteralTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ParamTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ReturnTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/SeeTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/SimpleTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/Taglet.java - src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletOutput.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ThrowsTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ValueTaglet.java ! test/com/sun/javadoc/testNestedInlineTag/testtaglets/BoldTaglet.java ! test/com/sun/javadoc/testNestedInlineTag/testtaglets/GreenTaglet.java ! test/com/sun/javadoc/testNestedInlineTag/testtaglets/UnderlineTaglet.java ! test/com/sun/javadoc/testTaglets/taglets/Foo.java Changeset: c09b7234cded Author: rfield Date: 2013-05-14 11:11 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/c09b7234cded 8012556: Implement lambda methods on interfaces as static 8006140: Javac NPE compiling Lambda expression on initialization expression of static field in interface Summary: Lambdas occurring in static contexts or those not needing instance information should be generated into static methods. This has long been the case for classes. However, as a work-around to the lack of support for statics on interfaces, interface lambda methods have been generated into default methods. For lambdas in interface static contexts (fields and static methods) this causes an NPE in javac because there is no 'this'. MethodHandles now support static methods on interfaces. This changeset allows lambda methods to be generated as static interface methods. An existing bug in Hotspot (8013875) is exposed in a test when the "-esa" flag is used. This test and another test that already exposed this bug have been marked with @ignore. Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java + test/tools/javac/lambda/LambdaInterfaceStaticField.java ! test/tools/javac/lambda/MethodReference66.java ! test/tools/javac/lambda/bytecode/TestLambdaBytecode.java ! test/tools/javac/lambda/lambdaExecution/InInterface.java Changeset: 46b9c25f7024 Author: jjg Date: 2013-05-14 12:55 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/46b9c25f7024 8014461: genstubs creates default native methods Reviewed-by: alanb ! make/tools/genstubs/GenStubs.java Changeset: 0384683c64be Author: jjg Date: 2013-05-14 13:55 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/0384683c64be 8014557: Mutable static field in HtmlDocletWriter Reviewed-by: ksrini ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java Changeset: ddb4a2bfcd82 Author: jjg Date: 2013-05-14 15:04 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/ddb4a2bfcd82 8013852: update reference impl for type-annotations Reviewed-by: jjg Contributed-by: wdietl at gmail.com, steve.sides at oracle.com, joel.franck at oracle.com, alex.buckley at oracle.com ! src/share/classes/com/sun/tools/classfile/ClassWriter.java ! src/share/classes/com/sun/tools/classfile/TypeAnnotation.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/javac/code/Annotations.java ! src/share/classes/com/sun/tools/javac/code/Attribute.java ! src/share/classes/com/sun/tools/javac/code/Printer.java ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/TypeAnnotationPosition.java ! src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Annotate.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/share/classes/com/sun/tools/javac/tree/TreeCopier.java ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java ! src/share/classes/com/sun/tools/javac/tree/TreeScanner.java ! src/share/classes/com/sun/tools/javac/tree/TreeTranslator.java ! src/share/classes/com/sun/tools/javac/util/List.java ! src/share/classes/com/sun/tools/javadoc/AnnotationTypeDocImpl.java ! src/share/classes/com/sun/tools/javadoc/AnnotationTypeElementDocImpl.java ! src/share/classes/com/sun/tools/javadoc/AnnotationValueImpl.java ! src/share/classes/com/sun/tools/javadoc/ExecutableMemberDocImpl.java ! src/share/classes/com/sun/tools/javadoc/FieldDocImpl.java ! src/share/classes/com/sun/tools/javadoc/JavadocEnter.java ! src/share/classes/com/sun/tools/javadoc/Messager.java ! src/share/classes/com/sun/tools/javadoc/TypeMaker.java ! src/share/classes/com/sun/tools/javadoc/TypeVariableImpl.java ! test/com/sun/javadoc/testTypeAnnotations/TestTypeAnnotations.java ! test/com/sun/javadoc/typeAnnotations/smoke/TestSmoke.java ! test/com/sun/javadoc/typeAnnotations/smoke/pkg/TargetTypes.java ! test/tools/javac/annotations/typeAnnotations/attribution/Scopes.java ! test/tools/javac/annotations/typeAnnotations/classfile/ClassfileTestHelper.java ! test/tools/javac/annotations/typeAnnotations/classfile/CombinationsTargetTest1.java ! test/tools/javac/annotations/typeAnnotations/classfile/CombinationsTargetTest2.java + test/tools/javac/annotations/typeAnnotations/classfile/CombinationsTargetTest3.java ! test/tools/javac/annotations/typeAnnotations/classfile/DeadCode.java ! test/tools/javac/annotations/typeAnnotations/classfile/NewTypeArguments.java + test/tools/javac/annotations/typeAnnotations/classfile/T8008762.java + test/tools/javac/annotations/typeAnnotations/classfile/T8008769.java + test/tools/javac/annotations/typeAnnotations/classfile/T8010015.java + test/tools/javac/annotations/typeAnnotations/classfile/TestNewCastArray.java ! test/tools/javac/annotations/typeAnnotations/classfile/TypeCasts.java ! test/tools/javac/annotations/typeAnnotations/classfile/Wildcards.java ! test/tools/javac/annotations/typeAnnotations/failures/LazyConstantValue.java + test/tools/javac/annotations/typeAnnotations/failures/LazyConstantValue.out ! test/tools/javac/annotations/typeAnnotations/failures/LintCast.out ! test/tools/javac/annotations/typeAnnotations/failures/StaticMethods.java ! test/tools/javac/annotations/typeAnnotations/failures/StaticMethods.out + test/tools/javac/annotations/typeAnnotations/failures/T8008751.java + test/tools/javac/annotations/typeAnnotations/failures/T8009360.java + test/tools/javac/annotations/typeAnnotations/failures/T8011722.java + test/tools/javac/annotations/typeAnnotations/failures/common/arrays/DeclarationAnnotation.java + test/tools/javac/annotations/typeAnnotations/failures/common/arrays/DeclarationAnnotation.out + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/DeclarationAnnotation.java + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/DeclarationAnnotation.out ! test/tools/javac/annotations/typeAnnotations/failures/common/receiver/Nesting.java ! test/tools/javac/annotations/typeAnnotations/failures/common/receiver/StaticThings.out ! test/tools/javac/annotations/typeAnnotations/failures/common/receiver/WrongType.java ! test/tools/javac/annotations/typeAnnotations/failures/common/receiver/WrongType.out ! test/tools/javac/annotations/typeAnnotations/failures/common/rest/MissingAnnotationValue.java ! test/tools/javac/annotations/typeAnnotations/failures/common/rest/MissingAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/wildcards/DeclarationAnnotation.java + test/tools/javac/annotations/typeAnnotations/failures/common/wildcards/DeclarationAnnotation.out + test/tools/javac/annotations/typeAnnotations/newlocations/AnonymousClass.java ! test/tools/javac/annotations/typeAnnotations/newlocations/Lambda.java ! test/tools/javac/annotations/typeAnnotations/newlocations/MultiCatch.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/Constructors.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/Driver.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/ExceptionParameters.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/Initializers.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/Lambda.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/MethodThrows.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/MultiCatch.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/NestedTypes.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/NewObjects.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/ReferenceInfoUtil.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/Test.java ! test/tools/javac/api/TestJavacTaskScanner.java + test/tools/javac/diags/examples/ArrayAndReceiver.java + test/tools/javac/diags/examples/IncorrectConstructorReceiverName.java + test/tools/javac/diags/examples/IncorrectConstructorReceiverType.java + test/tools/javac/diags/examples/IncorrectReceiverName.java + test/tools/javac/diags/examples/ReceiverParameterNotApplicableConstructor.java + test/tools/javac/diags/examples/VarargsAndReceiver.java ! test/tools/javac/lib/DPrinter.java + test/tools/javac/processing/model/type/BasicAnnoTests.java ! test/tools/javac/tree/SourceTreeScannerTest.java ! test/tools/javap/output/RepeatingTypeAnnotations.java ! test/tools/javap/typeAnnotations/NewArray.java ! test/tools/javap/typeAnnotations/Presence.java ! test/tools/javap/typeAnnotations/TypeCasts.java Changeset: 53b389eb39c1 Author: sogoel Date: 2013-05-14 18:02 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/53b389eb39c1 8013163: Convert 4 tools multicatch tests to jtreg format Reviewed-by: jjg + test/tools/javac/multicatch/Pos11.java + test/tools/javac/multicatch/Pos12.java Changeset: 529fb3ed5d2a Author: jjg Date: 2013-05-14 21:08 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/529fb3ed5d2a 8014323: Add VariableTree.getNameExpression Reviewed-by: darcy ! src/share/classes/com/sun/source/tree/VariableTree.java ! src/share/classes/com/sun/source/util/TreeScanner.java ! test/tools/javac/tree/SourceTreeScannerTest.java Changeset: bcd927639039 Author: darcy Date: 2013-05-15 00:00 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/bcd927639039 8004133: Provide javax.lang.model.* implementation backed by core reflection Summary: Joint work by darcy and jfranck to provide sample code for JEP 119. Reviewed-by: jjg Contributed-by: joe.darcy at oracle.com, joel.franck at oracle.com + src/share/sample/language/model/CoreReflectionFactory.java Changeset: 05ec778794d0 Author: mcimadamore Date: 2013-05-15 14:00 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/05ec778794d0 8012003: Method diagnostics resolution need to be simplified in some cases Summary: Unfold method resolution diagnostics when they mention errors in poly expressions Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/main/Option.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/resources/javac.properties ! src/share/classes/com/sun/tools/javac/util/JCDiagnostic.java ! src/share/classes/com/sun/tools/javac/util/List.java ! src/share/classes/com/sun/tools/javac/util/Log.java + test/tools/javac/Diagnostics/compressed/T8012003a.java + test/tools/javac/Diagnostics/compressed/T8012003a.out + test/tools/javac/Diagnostics/compressed/T8012003b.java + test/tools/javac/Diagnostics/compressed/T8012003b.out + test/tools/javac/Diagnostics/compressed/T8012003c.java + test/tools/javac/Diagnostics/compressed/T8012003c.out ! test/tools/javac/diags/examples/BadArgTypesInLambda.java + test/tools/javac/diags/examples/CompressedDiags.java ! test/tools/javac/diags/examples/KindnameConstructor.java + test/tools/javac/diags/examples/ProbFoundReqFragment.java ! test/tools/javac/lambda/TargetType66.out Changeset: 33d1937af1a3 Author: mcimadamore Date: 2013-05-15 14:02 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/33d1937af1a3 8012685: Spurious raw types warning when using unbound method references Summary: Spurious raw type warning when unbound method reference qualifier parameter types are inferred from target Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/lambda/MethodReference67.java + test/tools/javac/lambda/MethodReference67.out Changeset: 78717f2d00e8 Author: mcimadamore Date: 2013-05-15 14:03 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/78717f2d00e8 8013222: Javac issues spurious raw type warnings when lambda has implicit parameter types Summary: Bad warnings and position for lambda inferred parameter types Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/comp/Attr.java + test/tools/javac/lambda/NoWarnOnImplicitParams.java + test/tools/javac/lambda/NoWarnOnImplicitParams.out Changeset: 31ef33db5e0e Author: rfield Date: 2013-05-15 06:53 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/31ef33db5e0e 8010006: NPE in javac with interface super in lambda Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java + test/tools/javac/lambda/LambdaWithInterfaceSuper.java Changeset: 445b8b5ae9f4 Author: jjg Date: 2013-05-15 10:39 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/445b8b5ae9f4 8006879: Detection of windows in sjavac fails. Reviewed-by: jjg Contributed-by: erik.joelsson at oracle.com ! src/share/classes/com/sun/tools/sjavac/server/CompilerThread.java Changeset: 0928f2cfbf8e Author: jjg Date: 2013-05-17 13:48 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/0928f2cfbf8e 6885876: add comments to javac/util/Convert.java Reviewed-by: mduigou ! src/share/classes/com/sun/tools/javac/util/Convert.java Changeset: 67cbd6d756f4 Author: jfranck Date: 2013-05-21 12:00 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/67cbd6d756f4 8013180: Qualified type reference with annotations in throws list crashes compiler Reviewed-by: jjg + test/tools/javac/annotations/typeAnnotations/8013180/QualifiedName.java Changeset: 824932ecdbc8 Author: vromero Date: 2013-05-21 11:41 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/824932ecdbc8 7177168: Redundant array copy in UnsharedNameTable Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/util/UnsharedNameTable.java Changeset: 3d9750039fff Author: vromero Date: 2013-05-21 12:17 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/3d9750039fff 7060779: test/tools/javac/diags/Example.java leaves directories in tempdir Reviewed-by: mcimadamore ! test/tools/javac/diags/Example.java Changeset: 37295244f534 Author: vromero Date: 2013-05-21 13:50 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/37295244f534 8005207: test has 2 @bug tags Reviewed-by: mcimadamore ! test/tools/doclint/RunTest.java ! test/tools/javac/5045412/Bar.java ! test/tools/javac/5045412/Foo.java ! test/tools/javac/lambda/MethodReferenceParserTest.java ! test/tools/javac/lambda/TestInvokeDynamic.java ! test/tools/javac/mandatoryWarnings/deprecated/Test.java ! test/tools/javac/mandatoryWarnings/unchecked/Test.java ! test/tools/javac/policy/test3/Test.java Changeset: 08daea43a7f8 Author: vromero Date: 2013-05-21 14:33 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/08daea43a7f8 7164114: Two jtreg tests are not run due to no file extension on the test files Reviewed-by: mcimadamore - test/tools/javac/HiddenAbstractMethod/Test + test/tools/javac/HiddenAbstractMethod/Test.java - test/tools/javac/NonAmbiguousField/Test + test/tools/javac/NonAmbiguousField/Test.java ! test/tools/javac/NonAmbiguousField/two/Child2.java Changeset: e19283cd30a4 Author: katleman Date: 2013-05-09 10:04 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/e19283cd30a4 Added tag jdk8-b89 for changeset ec434cfd2752 ! .hgtags Changeset: 9717b9523d46 Author: katleman Date: 2013-05-16 12:16 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/9717b9523d46 Added tag jdk8-b90 for changeset e19283cd30a4 ! .hgtags Changeset: 997c0fae2b12 Author: lana Date: 2013-05-17 10:13 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/997c0fae2b12 Merge - src/share/classes/com/sun/tools/doclets/formats/html/TagletOutputImpl.java - src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ExpertTaglet.java - src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletOutput.java - src/share/classes/javax/tools/annotation/GenerateNativeHeader.java - test/tools/javac/nativeHeaders/javahComparison/TestClass2.java - test/tools/javac/nativeHeaders/javahComparison/TestClass3.java Changeset: 31344e8e3343 Author: lana Date: 2013-05-22 09:59 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/31344e8e3343 Merge Changeset: 3bd22f99d408 Author: darcy Date: 2013-05-22 13:34 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/3bd22f99d408 8010680: Clarify "present" and annotation ordering in javax.lang.model Reviewed-by: abuckley, jjg ! src/share/classes/javax/lang/model/AnnotatedConstruct.java ! src/share/classes/javax/lang/model/util/Elements.java From james.laskey at oracle.com Thu May 23 06:20:23 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Thu, 23 May 2013 13:20:23 +0000 Subject: hg: nashorn/jdk8/nashorn: 5 new changesets Message-ID: <20130523132028.830A748CA6@hg.openjdk.java.net> Changeset: 67ca019e3713 Author: katleman Date: 2013-05-09 10:04 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/67ca019e3713 Added tag jdk8-b89 for changeset 45ce27fbe272 ! .hgtags Changeset: 4ce88eec5078 Author: katleman Date: 2013-05-16 12:16 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/4ce88eec5078 Added tag jdk8-b90 for changeset 67ca019e3713 ! .hgtags Changeset: 6b9f41203800 Author: lana Date: 2013-05-17 10:14 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/6b9f41203800 Merge - src/jdk/nashorn/internal/ir/LineNumberNode.java - src/jdk/nashorn/internal/ir/Location.java - src/jdk/nashorn/internal/runtime/SpillProperty.java - test/script/trusted/logcoverage.js Changeset: e955e64fd15d Author: lana Date: 2013-05-22 09:59 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/e955e64fd15d Merge Changeset: 8af550dee961 Author: jlaskey Date: 2013-05-23 09:49 -0300 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/8af550dee961 Merge From hannes.wallnoefer at oracle.com Thu May 23 06:53:21 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Thu, 23 May 2013 15:53:21 +0200 Subject: Review request for JDK-8012522 In-Reply-To: References: Message-ID: <519E1F51.7030208@oracle.com> +1 Am 2013-05-23 14:53, schrieb Marcus Lagergren: > Please review JDK-8012522 at http://cr.openjdk.java.net/~lagergren/8012522/webrev.00 > > Thanks, > Marcus. From marcus.lagergren at oracle.com Thu May 23 06:56:11 2013 From: marcus.lagergren at oracle.com (marcus.lagergren at oracle.com) Date: Thu, 23 May 2013 13:56:11 +0000 Subject: hg: nashorn/jdk8/nashorn: 8012522: Clean up lexical contexts - split out stack based functionality in CodeGenerator and generify NodeVisitors based on their LexicalContext type to avoid casts Message-ID: <20130523135611.E5CF448CAA@hg.openjdk.java.net> Changeset: 6fc7b51e83d6 Author: lagergren Date: 2013-05-23 15:51 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/6fc7b51e83d6 8012522: Clean up lexical contexts - split out stack based functionality in CodeGenerator and generify NodeVisitors based on their LexicalContext type to avoid casts Reviewed-by: attila, jlaskey ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/codegen/CodeGenerator.java + src/jdk/nashorn/internal/codegen/CodeGeneratorLexicalContext.java ! src/jdk/nashorn/internal/codegen/CompilationPhase.java ! src/jdk/nashorn/internal/codegen/FinalizeTypes.java ! src/jdk/nashorn/internal/codegen/FoldConstants.java ! src/jdk/nashorn/internal/codegen/Lower.java ! src/jdk/nashorn/internal/codegen/RangeAnalyzer.java ! src/jdk/nashorn/internal/codegen/SharedScopeCall.java ! src/jdk/nashorn/internal/codegen/Splitter.java ! src/jdk/nashorn/internal/codegen/WeighNodes.java ! src/jdk/nashorn/internal/ir/AccessNode.java ! src/jdk/nashorn/internal/ir/BinaryNode.java ! src/jdk/nashorn/internal/ir/Block.java ! src/jdk/nashorn/internal/ir/BreakNode.java ! src/jdk/nashorn/internal/ir/CallNode.java ! src/jdk/nashorn/internal/ir/CaseNode.java ! src/jdk/nashorn/internal/ir/CatchNode.java ! src/jdk/nashorn/internal/ir/ContinueNode.java ! src/jdk/nashorn/internal/ir/EmptyNode.java ! src/jdk/nashorn/internal/ir/ExecuteNode.java ! src/jdk/nashorn/internal/ir/ForNode.java ! src/jdk/nashorn/internal/ir/FunctionNode.java ! src/jdk/nashorn/internal/ir/IdentNode.java ! src/jdk/nashorn/internal/ir/IfNode.java ! src/jdk/nashorn/internal/ir/IndexNode.java ! src/jdk/nashorn/internal/ir/LabelNode.java ! src/jdk/nashorn/internal/ir/LexicalContextNode.java ! src/jdk/nashorn/internal/ir/LiteralNode.java ! src/jdk/nashorn/internal/ir/Node.java ! src/jdk/nashorn/internal/ir/ObjectNode.java ! src/jdk/nashorn/internal/ir/PropertyNode.java ! src/jdk/nashorn/internal/ir/ReturnNode.java ! src/jdk/nashorn/internal/ir/RuntimeNode.java ! src/jdk/nashorn/internal/ir/SplitNode.java ! src/jdk/nashorn/internal/ir/SwitchNode.java ! src/jdk/nashorn/internal/ir/TernaryNode.java ! src/jdk/nashorn/internal/ir/ThrowNode.java ! src/jdk/nashorn/internal/ir/TryNode.java ! src/jdk/nashorn/internal/ir/UnaryNode.java ! src/jdk/nashorn/internal/ir/VarNode.java ! src/jdk/nashorn/internal/ir/WhileNode.java ! src/jdk/nashorn/internal/ir/WithNode.java ! src/jdk/nashorn/internal/ir/debug/JSONWriter.java ! src/jdk/nashorn/internal/ir/debug/PrintVisitor.java ! src/jdk/nashorn/internal/ir/visitor/NodeOperatorVisitor.java ! src/jdk/nashorn/internal/ir/visitor/NodeVisitor.java ! src/jdk/nashorn/internal/objects/ArrayBufferView.java ! src/jdk/nashorn/internal/runtime/DebugLogger.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterClassLoader.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterGeneratorBase.java From sundararajan.athijegannathan at oracle.com Fri May 24 04:03:26 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Fri, 24 May 2013 16:33:26 +0530 Subject: Review request for 8015354: JSON.parse should not use [[Put]] but use [[DefineOwnProperty]] instead Message-ID: <519F48FE.2020604@oracle.com> Please review http://cr.openjdk.java.net/~sundar/8015354/ -Sundar From hannes.wallnoefer at oracle.com Fri May 24 04:15:34 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Fri, 24 May 2013 13:15:34 +0200 Subject: Review request for JDK-8011630 - JSON parsing performance issue Message-ID: <519F4BD6.9060509@oracle.com> Please review JDK-8011630 - JSON parsing performance issue http://cr.openjdk.java.net/~hannesw/8011630/ This adds new methods in Property and FindProperty to get and set values for spill and user accessor properties without creating a method handle. This reduces parsing time of the huge JSON file from about one minute to 15 seconds. Most of the remaining overhead seems to be in PropertyMap.addProperty(). Hannes From marcus.lagergren at oracle.com Fri May 24 04:33:08 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Fri, 24 May 2013 13:33:08 +0200 Subject: Review request for JDK-8011630 - JSON parsing performance issue In-Reply-To: <519F4BD6.9060509@oracle.com> References: <519F4BD6.9060509@oracle.com> Message-ID: +1. We really need to investigate this further as the creation of method handle getters and setters has so huge overhead. It should be ultra lazy. /M On May 24, 2013, at 1:15 PM, Hannes Wallnoefer wrote: > Please review JDK-8011630 - JSON parsing performance issue > > http://cr.openjdk.java.net/~hannesw/8011630/ > > This adds new methods in Property and FindProperty to get and set values for spill and user accessor properties without creating a method handle. > > This reduces parsing time of the huge JSON file from about one minute to 15 seconds. Most of the remaining overhead seems to be in PropertyMap.addProperty(). > > Hannes From sundararajan.athijegannathan at oracle.com Fri May 24 04:33:05 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Fri, 24 May 2013 17:03:05 +0530 Subject: Review request for JDK-8011630 - JSON parsing performance issue In-Reply-To: <519F4BD6.9060509@oracle.com> References: <519F4BD6.9060509@oracle.com> Message-ID: <519F4FF1.3010107@oracle.com> +1 -Sundar On Friday 24 May 2013 04:45 PM, Hannes Wallnoefer wrote: > Please review JDK-8011630 - JSON parsing performance issue > > http://cr.openjdk.java.net/~hannesw/8011630/ > > This adds new methods in Property and FindProperty to get and set > values for spill and user accessor properties without creating a > method handle. > > This reduces parsing time of the huge JSON file from about one minute > to 15 seconds. Most of the remaining overhead seems to be in > PropertyMap.addProperty(). > > Hannes From marcus.lagergren at oracle.com Fri May 24 04:33:13 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Fri, 24 May 2013 13:33:13 +0200 Subject: Review request for 8015354: JSON.parse should not use [[Put]] but use [[DefineOwnProperty]] instead In-Reply-To: <519F48FE.2020604@oracle.com> References: <519F48FE.2020604@oracle.com> Message-ID: +1 On May 24, 2013, at 1:03 PM, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~sundar/8015354/ > > -Sundar From hannes.wallnoefer at oracle.com Fri May 24 04:54:54 2013 From: hannes.wallnoefer at oracle.com (hannes.wallnoefer at oracle.com) Date: Fri, 24 May 2013 11:54:54 +0000 Subject: hg: nashorn/jdk8/nashorn: 8011630: JSON parsing performance issue Message-ID: <20130524115456.38FDC48D0C@hg.openjdk.java.net> Changeset: fdfb4edd78d6 Author: hannesw Date: 2013-05-24 13:54 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/fdfb4edd78d6 8011630: JSON parsing performance issue Reviewed-by: lagergren, sundar ! src/jdk/nashorn/internal/objects/NativeArguments.java ! src/jdk/nashorn/internal/runtime/AccessorProperty.java ! src/jdk/nashorn/internal/runtime/FindProperty.java ! src/jdk/nashorn/internal/runtime/Property.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/SetMethodCreator.java ! src/jdk/nashorn/internal/runtime/UserAccessorProperty.java From sundararajan.athijegannathan at oracle.com Fri May 24 06:09:51 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Fri, 24 May 2013 13:09:51 +0000 Subject: hg: nashorn/jdk8/nashorn: 8015354: JSON.parse should not use [[Put]] but use [[DefineOwnProperty]] instead Message-ID: <20130524130952.AE4B948D0E@hg.openjdk.java.net> Changeset: 4d2eca4d4d66 Author: sundar Date: 2013-05-24 18:39 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/4d2eca4d4d66 8015354: JSON.parse should not use [[Put]] but use [[DefineOwnProperty]] instead Reviewed-by: lagergren, hannesw ! src/jdk/nashorn/internal/objects/NativeFloat32Array.java ! src/jdk/nashorn/internal/objects/NativeFloat64Array.java ! src/jdk/nashorn/internal/objects/NativeInt16Array.java ! src/jdk/nashorn/internal/objects/NativeInt32Array.java ! src/jdk/nashorn/internal/objects/NativeInt8Array.java ! src/jdk/nashorn/internal/objects/NativeUint16Array.java ! src/jdk/nashorn/internal/objects/NativeUint32Array.java ! src/jdk/nashorn/internal/objects/NativeUint8Array.java ! src/jdk/nashorn/internal/objects/NativeUint8ClampedArray.java ! src/jdk/nashorn/internal/runtime/JSONFunctions.java ! src/jdk/nashorn/internal/runtime/Property.java + test/script/basic/JDK-8015354.js From sundararajan.athijegannathan at oracle.com Fri May 24 10:08:11 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Fri, 24 May 2013 22:38:11 +0530 Subject: Review request for 8015351: Nashorn shell does not start with Turkish locale Message-ID: <519F9E7B.4010707@oracle.com> Please review http://cr.openjdk.java.net/~sundar/8015351/ -Sundar From sundararajan.athijegannathan at oracle.com Fri May 24 11:00:59 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Fri, 24 May 2013 18:00:59 +0000 Subject: hg: nashorn/jdk8/nashorn: 8015351: Nashorn shell does not start with Turkish locale Message-ID: <20130524180101.11E8448D1E@hg.openjdk.java.net> Changeset: 751cfefff5eb Author: sundar Date: 2013-05-24 23:27 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/751cfefff5eb 8015351: Nashorn shell does not start with Turkish locale Reviewed-by: jlaskey ! make/project.properties ! src/jdk/nashorn/internal/runtime/options/OptionTemplate.java From marcus.lagergren at oracle.com Fri May 24 11:15:39 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Fri, 24 May 2013 20:15:39 +0200 Subject: Review request for 8015351: Nashorn shell does not start with Turkish locale In-Reply-To: <519F9E7B.4010707@oracle.com> References: <519F9E7B.4010707@oracle.com> Message-ID: <11F88B79-91DE-4E82-8E12-F95C39374399@oracle.com> +1 On May 24, 2013, at 7:08 PM, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~sundar/8015351/ > > -Sundar From james.laskey at oracle.com Fri May 24 11:20:32 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Fri, 24 May 2013 15:20:32 -0300 Subject: Review request for 8015351: Nashorn shell does not start with Turkish locale In-Reply-To: <519F9E7B.4010707@oracle.com> References: <519F9E7B.4010707@oracle.com> Message-ID: <693C674E-4F10-4092-9C8F-B9EFA48B7BC9@oracle.com> +1 On 2013-05-24, at 2:08 PM, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~sundar/8015351/ > > -Sundar From nobuoka+dev at vividcode.info Sat May 25 12:02:02 2013 From: nobuoka+dev at vividcode.info (nobuoka) Date: Sun, 26 May 2013 04:02:02 +0900 Subject: Array.prototype.slice.call method may throw ClassCastException Message-ID: <51A10AAA.80408@vividcode.info> Hello, I use Nashorn with JavaFX on JDK 8 build b91. When I run the following script, the ClassCastException occur. I think this may be bug, so I report it. // This code is a part of JavaFX application (run by `jss -fx filename.js` command) // // `doc` is org.w3c.dom.Document object returned from // javafx.scene.web.WebEngine#getDocument method var elems = doc.querySelectorAll("a"); Array.prototype.slice.call(elems); // exception occur > Exception in thread "JavaFX Application Thread" java.lang.ClassCastException: com.sun.webkit.dom.JSObject cannot be cast to jdk.nashorn.internal.runtime.ScriptObject (The method call `Array.prototype.slice.call(elems)` is commonly used idiom to convert W3C DOM NodeList object to Array object.) Note that ECMA-262 5.1th says: The |slice| function is intentionally generic; it does not require that its *this* value be an Array object. Therefore it can be transferred to other kinds of objects for use as a method. Whether the |slice| function can be applied successfully to a host object is implementation-dependent. ( http://www.ecma-international.org/ecma-262/5.1/#sec-15.4.4.10 ) Regards, From attila.szegedi at oracle.com Sat May 25 14:55:58 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Sat, 25 May 2013 23:55:58 +0200 Subject: Array.prototype.slice.call method may throw ClassCastException In-Reply-To: <51A10AAA.80408@vividcode.info> References: <51A10AAA.80408@vividcode.info> Message-ID: <3195CD4C-EF34-4E0A-B2E8-E98923A41C1D@oracle.com> The relevant part here is "Whether the |slice| function can be applied successfully to a host object is implementation-dependent." DOM objects are host objects. Slice will work for array-like built-in JS objects, though. We might investigate whether we have a fundamental architectural issue that prevents us from having it work on host objects. Attila. Sent from my iPad On 2013.05.25., at 21:02, nobuoka wrote: > Hello, > > I use Nashorn with JavaFX on JDK 8 build b91. > > When I run the following script, the ClassCastException occur. > I think this may be bug, so I report it. > > // This code is a part of JavaFX application (run by `jss -fx > filename.js` command) > // > // `doc` is org.w3c.dom.Document object returned from > // javafx.scene.web.WebEngine#getDocument method > var elems = doc.querySelectorAll("a"); > Array.prototype.slice.call(elems); // exception occur > >> Exception in thread "JavaFX Application Thread" > java.lang.ClassCastException: com.sun.webkit.dom.JSObject cannot be cast > to jdk.nashorn.internal.runtime.ScriptObject > > (The method call `Array.prototype.slice.call(elems)` is commonly used > idiom to > convert W3C DOM NodeList object to Array object.) > > Note that ECMA-262 5.1th says: The |slice| function is intentionally > generic; it does not require that > its *this* value be an Array object. Therefore it can be transferred to > other kinds of objects for > use as a method. Whether the |slice| function can be applied > successfully to a host object is > implementation-dependent. > ( http://www.ecma-international.org/ecma-262/5.1/#sec-15.4.4.10 ) > > Regards, From hannes.wallnoefer at oracle.com Mon May 27 02:00:39 2013 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Mon, 27 May 2013 11:00:39 +0200 Subject: Review request for JDK-8015348 Message-ID: <51A320B7.6050507@oracle.com> Please review my patch for JDK-8015348 - RegExp("[") results in StackOverflowError: http://cr.openjdk.java.net/~hannesw/8015348/ thanks, Hannes From sundararajan.athijegannathan at oracle.com Mon May 27 02:04:41 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Mon, 27 May 2013 14:34:41 +0530 Subject: Review request for JDK-8015348 In-Reply-To: <51A320B7.6050507@oracle.com> References: <51A320B7.6050507@oracle.com> Message-ID: <51A321A9.2070705@oracle.com> +1 On Monday 27 May 2013 02:30 PM, Hannes Wallnoefer wrote: > Please review my patch for JDK-8015348 - RegExp("[") results in > StackOverflowError: > > http://cr.openjdk.java.net/~hannesw/8015348/ > > thanks, > Hannes From attila.szegedi at oracle.com Mon May 27 02:10:13 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Mon, 27 May 2013 11:10:13 +0200 Subject: Review request for JDK-8015348 In-Reply-To: <51A320B7.6050507@oracle.com> References: <51A320B7.6050507@oracle.com> Message-ID: <21FBF7D6-BE75-477C-B717-475FEA28C992@oracle.com> +1 On May 27, 2013, at 11:00 AM, Hannes Wallnoefer wrote: > Please review my patch for JDK-8015348 - RegExp("[") results in StackOverflowError: > > http://cr.openjdk.java.net/~hannesw/8015348/ > > thanks, > Hannes From rieberandreas at gmail.com Mon May 27 03:06:52 2013 From: rieberandreas at gmail.com (Andreas Rieber) Date: Mon, 27 May 2013 12:06:52 +0200 Subject: JSAdapter problem Message-ID: <51A3303C.9040703@gmail.com> Hi, i just try to get the jconsole-plugin working and found the following issue with JSAdapter: var obj = new JSAdapter() { __get__: function (name) { return function() { print(name); }; } }; var func = obj.x; func(); obj.x(); Expected output should be x x but it fails with no such function "x". Plain old Rhino did handle that case. Andreas From marcus.lagergren at oracle.com Mon May 27 03:21:54 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Mon, 27 May 2013 12:21:54 +0200 Subject: Please review http://cr.openjdk.java.net/~lagergren/8014219 Message-ID: <2F735BD7-11DD-4F72-A7D5-48624BE6B886@oracle.com> Redo octane benchmark harness so the results have as little deviation as possible from javascript. verified that ant octane-xxx and octane-xxx-v8 works The scores will be unfamiliar to you, but do your benchmarking against a reference like tip until you have a feel for what they should be like on your machine. /M From hannes.wallnoefer at oracle.com Mon May 27 03:27:40 2013 From: hannes.wallnoefer at oracle.com (hannes.wallnoefer at oracle.com) Date: Mon, 27 May 2013 10:27:40 +0000 Subject: hg: nashorn/jdk8/nashorn: 8015348: RegExp("[") results in StackOverflowError Message-ID: <20130527102743.0C45048D54@hg.openjdk.java.net> Changeset: 0bf451c0678d Author: hannesw Date: 2013-05-27 12:26 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/0bf451c0678d 8015348: RegExp("[") results in StackOverflowError Reviewed-by: sundar, attila ! src/jdk/nashorn/internal/runtime/regexp/RegExpScanner.java + test/script/basic/JDK-8015348.js + test/script/basic/JDK-8015348.js.EXPECTED From james.laskey at oracle.com Mon May 27 03:35:07 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Mon, 27 May 2013 07:35:07 -0300 Subject: Please review http://cr.openjdk.java.net/~lagergren/8014219 In-Reply-To: <2F735BD7-11DD-4F72-A7D5-48624BE6B886@oracle.com> References: <2F735BD7-11DD-4F72-A7D5-48624BE6B886@oracle.com> Message-ID: <5027CB7C-C5FD-4D6C-B155-EDB2A63D6966@oracle.com> +1 On 2013-05-27, at 7:21 AM, Marcus Lagergren wrote: > Redo octane benchmark harness so the results have as little deviation as possible from javascript. verified that ant octane-xxx and octane-xxx-v8 works > The scores will be unfamiliar to you, but do your benchmarking against a reference like tip until you have a feel for what they should be like on your machine. > > /M > From attila.szegedi at oracle.com Mon May 27 04:03:20 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Mon, 27 May 2013 13:03:20 +0200 Subject: Please review http://cr.openjdk.java.net/~lagergren/8014219 In-Reply-To: <2F735BD7-11DD-4F72-A7D5-48624BE6B886@oracle.com> References: <2F735BD7-11DD-4F72-A7D5-48624BE6B886@oracle.com> Message-ID: +1 On May 27, 2013, at 12:21 PM, Marcus Lagergren wrote: > Redo octane benchmark harness so the results have as little deviation as possible from javascript. verified that ant octane-xxx and octane-xxx-v8 works > The scores will be unfamiliar to you, but do your benchmarking against a reference like tip until you have a feel for what they should be like on your machine. > > /M > From marcus.lagergren at oracle.com Mon May 27 04:14:32 2013 From: marcus.lagergren at oracle.com (marcus.lagergren at oracle.com) Date: Mon, 27 May 2013 11:14:32 +0000 Subject: hg: nashorn/jdk8/nashorn: 2 new changesets Message-ID: <20130527111434.36E6E48D57@hg.openjdk.java.net> Changeset: 1f57afd14cc1 Author: lagergren Date: 2013-05-27 13:11 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/1f57afd14cc1 8014219: Make the run-octane harness more deterministic by not measuring elapsed time every iteration. Also got rid of most of the run logic in base.js and call benchmarks directly for the same purpose Reviewed-by: jlaskey, attila ! make/build-benchmark.xml ! src/jdk/nashorn/internal/runtime/AccessorProperty.java ! src/jdk/nashorn/internal/runtime/Property.java ! src/jdk/nashorn/internal/runtime/UserAccessorProperty.java ! test/script/basic/compile-octane.js.EXPECTED ! test/script/basic/run-octane.js Changeset: 910fd2849c4c Author: lagergren Date: 2013-05-27 13:12 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/910fd2849c4c Merge From sundararajan.athijegannathan at oracle.com Mon May 27 06:36:08 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Mon, 27 May 2013 19:06:08 +0530 Subject: =?ISO-8859-1?Q?Review_request_for_8015352=3A_=22i=22=2Et?= =?ISO-8859-1?Q?oUpperCase=28=29_=3D=3E_currently_returns_=22=C4=B0?= =?ISO-8859-1?Q?=22=2C_but_should_be_=22I=22_=28with_Turkish_?= =?ISO-8859-1?Q?locale=29?= Message-ID: <51A36148.4080909@oracle.com> Please review http://cr.openjdk.java.net/~sundar/8015352/ -Sundar From james.laskey at oracle.com Mon May 27 06:43:39 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Mon, 27 May 2013 10:43:39 -0300 Subject: =?iso-8859-1?Q?Re=3A_Review_request_for_8015352=3A_=22i=22=2EtoU?= =?iso-8859-1?Q?pperCase=28=29_=3D=3E_currently_returns_=22=C4=B0?= =?iso-8859-1?Q?=22=2C_but_should_be_=22I=22_=28with_Turkish_loca?= =?iso-8859-1?Q?le=29?= In-Reply-To: <51A36148.4080909@oracle.com> References: <51A36148.4080909@oracle.com> Message-ID: +1 On 2013-05-27, at 10:36 AM, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~sundar/8015352/ > > -Sundar From marcus.lagergren at oracle.com Mon May 27 07:27:32 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Mon, 27 May 2013 16:27:32 +0200 Subject: =?iso-8859-1?Q?Re=3A_Review_request_for_8015352=3A_=22i=22=2EtoU?= =?iso-8859-1?Q?pperCase=28=29_=3D=3E_currently_returns_=22=C4=B0?= =?iso-8859-1?Q?=22=2C_but_should_be_=22I=22_=28with_Turkish_loca?= =?iso-8859-1?Q?le=29?= In-Reply-To: <51A36148.4080909@oracle.com> References: <51A36148.4080909@oracle.com> Message-ID: <428C62F7-E3FB-4E9D-A9D6-5B8C3DA7A53B@oracle.com> +1 On May 27, 2013, at 3:36 PM, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~sundar/8015352/ > > -Sundar From sundararajan.athijegannathan at oracle.com Mon May 27 08:11:54 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Mon, 27 May 2013 15:11:54 +0000 Subject: hg: nashorn/jdk8/nashorn: 8015352: "i".toUpperCase() => currently returns "İ", but should be "I" (with Turkish locale) Message-ID: <20130527151156.3773148D63@hg.openjdk.java.net> Changeset: 343fd0450802 Author: sundar Date: 2013-05-27 20:41 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/343fd0450802 8015352: "i".toUpperCase() => currently returns "??", but should be "I" (with Turkish locale) Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/internal/objects/NativeString.java ! src/jdk/nashorn/internal/runtime/ScriptEnvironment.java ! src/jdk/nashorn/internal/runtime/options/OptionTemplate.java ! src/jdk/nashorn/internal/runtime/options/Options.java ! src/jdk/nashorn/internal/runtime/resources/Options.properties + test/script/basic/JDK-8015352.js From marcus.lagergren at oracle.com Mon May 27 08:58:20 2013 From: marcus.lagergren at oracle.com (marcus.lagergren at oracle.com) Date: Mon, 27 May 2013 15:58:20 +0000 Subject: hg: nashorn/jdk8/nashorn: 8015447: Octane harness fixes for rhino and entire test runs: ant octane, ant octane-v8, ant octane-rhino Message-ID: <20130527155821.09D3048D65@hg.openjdk.java.net> Changeset: e6193dcfe36c Author: lagergren Date: 2013-05-27 17:57 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/e6193dcfe36c 8015447: Octane harness fixes for rhino and entire test runs: ant octane, ant octane-v8, ant octane-rhino Reviewed-by: sundar, jlaskey ! make/build-benchmark.xml ! test/script/basic/run-octane.js From han.solo at muenster.de Mon May 27 12:42:15 2013 From: han.solo at muenster.de (Gerrit Grunwald) Date: Mon, 27 May 2013 21:42:15 +0200 Subject: Including 3rd party controls libraries Message-ID: <4581815C-3FF0-430E-914A-8F011ABCE97D@muenster.de> Just started with Nashorn and JavaFX. The 'HelloWorld' example runs fine but I have problems when trying to use my own JavaFX controls library. Any hints on how to implement a 3rd party JavaFX controls lib to a Nashorn Script ? I guess I have to put the lib on the classpath somehow... Cheers, Gerrit From james.laskey at oracle.com Mon May 27 13:19:37 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Mon, 27 May 2013 17:19:37 -0300 Subject: Including 3rd party controls libraries In-Reply-To: <4581815C-3FF0-430E-914A-8F011ABCE97D@muenster.de> References: <4581815C-3FF0-430E-914A-8F011ABCE97D@muenster.de> Message-ID: Would you send me your source code? Offline if you choose. On 2013-05-27, at 4:42 PM, Gerrit Grunwald wrote: > Just started with Nashorn and JavaFX. The 'HelloWorld' example runs fine but I have problems when trying to use my own JavaFX controls library. > Any hints on how to implement a 3rd party JavaFX controls lib to a Nashorn Script ? > I guess I have to put the lib on the classpath somehow... > > Cheers, > > Gerrit > > > From sundararajan.athijegannathan at oracle.com Mon May 27 23:52:09 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Tue, 28 May 2013 12:22:09 +0530 Subject: Review request for 8015459: Octane test run fails on Turkish locale Message-ID: <51A45419.2010804@oracle.com> Please review http://cr.openjdk.java.net/~sundar/8015459/ -Sundar From attila.szegedi at oracle.com Tue May 28 03:59:05 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Tue, 28 May 2013 12:59:05 +0200 Subject: Review request for 8015459: Octane test run fails on Turkish locale In-Reply-To: <51A45419.2010804@oracle.com> References: <51A45419.2010804@oracle.com> Message-ID: <9FC71D33-5ED1-468C-B0E6-8DFE633184FF@oracle.com> +1 On May 28, 2013, at 8:52 AM, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~sundar/8015459/ > > -Sundar From sundararajan.athijegannathan at oracle.com Tue May 28 04:07:48 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Tue, 28 May 2013 11:07:48 +0000 Subject: hg: nashorn/jdk8/nashorn: 8015459: Octane test run fails on Turkish locale Message-ID: <20130528110752.3F1E548D7E@hg.openjdk.java.net> Changeset: d56168970de1 Author: sundar Date: 2013-05-28 16:37 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/d56168970de1 8015459: Octane test run fails on Turkish locale Reviewed-by: lagergren, attila ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/objects/DateParser.java ! src/jdk/nashorn/internal/parser/TokenType.java ! src/jdk/nashorn/internal/runtime/GlobalFunctions.java ! src/jdk/nashorn/internal/runtime/JSType.java ! src/jdk/nashorn/internal/runtime/Logging.java ! src/jdk/nashorn/internal/runtime/ScriptRuntime.java ! src/jdk/nashorn/internal/runtime/options/OptionTemplate.java From james.laskey at oracle.com Tue May 28 04:09:53 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Tue, 28 May 2013 08:09:53 -0300 Subject: Review request for 8015459: Octane test run fails on Turkish locale In-Reply-To: <51A45419.2010804@oracle.com> References: <51A45419.2010804@oracle.com> Message-ID: +1 On 2013-05-28, at 3:52 AM, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~sundar/8015459/ > > -Sundar From sundararajan.athijegannathan at oracle.com Tue May 28 05:06:13 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Tue, 28 May 2013 17:36:13 +0530 Subject: JSAdapter problem In-Reply-To: <51A3303C.9040703@gmail.com> References: <51A3303C.9040703@gmail.com> Message-ID: <51A49DB5.8090603@oracle.com> Hi Andreas, JSAdapter in nashorn introduces __call__ method. This is called when a "method" is called on an object. obj.x(); // --> calls __call__ method obj.x // --> calls __get__ method Thanks -Sundar On Monday 27 May 2013 03:36 PM, Andreas Rieber wrote: > Hi, > > i just try to get the jconsole-plugin working and found the following > issue with JSAdapter: > > var obj = new JSAdapter() { > __get__: function (name) { > return function() { > print(name); > }; > } > }; > > var func = obj.x; > func(); > obj.x(); > > Expected output should be x x but it fails with no such function "x". > Plain old Rhino did handle that case. > > Andreas > From rieberandreas at gmail.com Tue May 28 07:49:46 2013 From: rieberandreas at gmail.com (Andreas Rieber) Date: Tue, 28 May 2013 16:49:46 +0200 Subject: JSAdapter problem In-Reply-To: <51A49DB5.8090603@oracle.com> References: <51A3303C.9040703@gmail.com> <51A49DB5.8090603@oracle.com> Message-ID: <51A4C40A.80208@gmail.com> Hi Sundar, is it worth adding a compatibility or migration section to nashorn/docs/JavaScriptingProgrammersGuide.html? With the Rhino JSAdapter the __get__ method could return a function and there was no such __call__ method. regards Andreas On 28.05.13 14:06, A. Sundararajan wrote: > Hi Andreas, > > JSAdapter in nashorn introduces __call__ method. This is called when a > "method" is called on an object. > > obj.x(); // --> calls __call__ method > obj.x // --> calls __get__ method > > Thanks > -Sundar > > On Monday 27 May 2013 03:36 PM, Andreas Rieber wrote: >> Hi, >> >> i just try to get the jconsole-plugin working and found the following >> issue with JSAdapter: >> >> var obj = new JSAdapter() { >> __get__: function (name) { >> return function() { >> print(name); >> }; >> } >> }; >> >> var func = obj.x; >> func(); >> obj.x(); >> >> Expected output should be x x but it fails with no such function "x". >> Plain old Rhino did handle that case. >> >> Andreas >> > From james.laskey at oracle.com Tue May 28 08:00:55 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Tue, 28 May 2013 12:00:55 -0300 Subject: JSAdapter problem In-Reply-To: <51A4C40A.80208@gmail.com> References: <51A3303C.9040703@gmail.com> <51A49DB5.8090603@oracle.com> <51A4C40A.80208@gmail.com> Message-ID: <36036E21-81F4-43F5-9BE8-B2C5CCCCEB16@oracle.com> We are working up a Rhino to Nashorn migration document. It will be another month or so before it's ready for public consumption. Cheers, -- Jim On 2013-05-28, at 11:49 AM, Andreas Rieber wrote: > Hi Sundar, > > is it worth adding a compatibility or migration section to nashorn/docs/JavaScriptingProgrammersGuide.html? With the Rhino JSAdapter the __get__ method could return a function and there was no such __call__ method. > > regards > Andreas > > On 28.05.13 14:06, A. Sundararajan wrote: >> Hi Andreas, >> >> JSAdapter in nashorn introduces __call__ method. This is called when a "method" is called on an object. >> >> obj.x(); // --> calls __call__ method >> obj.x // --> calls __get__ method >> >> Thanks >> -Sundar >> >> On Monday 27 May 2013 03:36 PM, Andreas Rieber wrote: >>> Hi, >>> >>> i just try to get the jconsole-plugin working and found the following issue with JSAdapter: >>> >>> var obj = new JSAdapter() { >>> __get__: function (name) { >>> return function() { >>> print(name); >>> }; >>> } >>> }; >>> >>> var func = obj.x; >>> func(); >>> obj.x(); >>> >>> Expected output should be x x but it fails with no such function "x". Plain old Rhino did handle that case. >>> >>> Andreas >>> >> > From rieberandreas at gmail.com Tue May 28 23:31:19 2013 From: rieberandreas at gmail.com (Andreas Rieber) Date: Wed, 29 May 2013 08:31:19 +0200 Subject: 7051182: Regression: : jconsole scripting demo fails with UndeclaredThrowableException Message-ID: <51A5A0B7.2000506@gmail.com> Hi, i have a one line fix for this bug but i also have a patch to make jconsole-plugin demo working with Nashorn. The problems there are similar to scriptpad (sync function, array handling and the new JSAdapter __call__). Do you want two separate patches or is one OK? cheers Andreas From sundararajan.athijegannathan at oracle.com Wed May 29 02:36:10 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Wed, 29 May 2013 15:06:10 +0530 Subject: 7051182: Regression: : jconsole scripting demo fails with UndeclaredThrowableException In-Reply-To: <51A5A0B7.2000506@gmail.com> References: <51A5A0B7.2000506@gmail.com> Message-ID: <51A5CC0A.2060104@oracle.com> Hi Andreas, If changes are across repos (nashorn, jdk/demo) it is better to have two patches. But, you could zip everything and send as well. Thanks -Sundar On Wednesday 29 May 2013 12:01 PM, Andreas Rieber wrote: > Hi, > > i have a one line fix for this bug but i also have a patch to make > jconsole-plugin demo working with Nashorn. The problems there are > similar to scriptpad (sync function, array handling and the new > JSAdapter __call__). > > Do you want two separate patches or is one OK? > > cheers > Andreas > From sundararajan.athijegannathan at oracle.com Wed May 29 02:38:01 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Wed, 29 May 2013 15:08:01 +0530 Subject: Review request for 8005979: A lot of tests are named "runTest" in reports Message-ID: <51A5CC79.30506@oracle.com> Please review http://cr.openjdk.java.net/~sundar/8005979/ -Sundar From sundararajan.athijegannathan at oracle.com Wed May 29 03:11:39 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Wed, 29 May 2013 10:11:39 +0000 Subject: hg: nashorn/jdk8/nashorn: 8005979: A lot of tests are named "runTest" in reports Message-ID: <20130529101142.8DB0E48DD5@hg.openjdk.java.net> Changeset: f472f7046ec9 Author: sundar Date: 2013-05-29 15:41 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/f472f7046ec9 8005979: A lot of tests are named "runTest" in reports Reviewed-by: jlaskey ! make/project.properties From basabasafoo at gmail.com Tue May 28 20:45:42 2013 From: basabasafoo at gmail.com (toshiyuki kojima) Date: Wed, 29 May 2013 12:45:42 +0900 Subject: Bug at Math.round Message-ID: Hello, I found a bug: Math.round(-0) should return -0, but Math.round(-0) returns +0 in nashorn. I confirmed this bug using revision: changeset: d56168970de1 date: Tue May 28 16:37:11 2013 +0530 summary: 8015459: Octane test run fails on Turkish locale http://ecma-international.org/ecma-262/5.1/#sec-15.8.2.15 http://jsfiddle.net/gocho/TscsU/ http://hg.openjdk.java.net/nashorn/jdk8/nashorn/file/d56168970de1/src/jdk/nashorn/internal/objects/NativeMath.java Thanks, --gocho twitter.com/gocho From james.laskey at oracle.com Wed May 29 03:44:15 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Wed, 29 May 2013 07:44:15 -0300 Subject: Review request for 8005979: A lot of tests are named "runTest" in reports In-Reply-To: <51A5CC79.30506@oracle.com> References: <51A5CC79.30506@oracle.com> Message-ID: <55D93E3C-155C-4212-82FB-55F6FE6BEBC0@oracle.com> +1 On 2013-05-29, at 6:38 AM, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~sundar/8005979/ > > -Sundar From rieberandreas at gmail.com Wed May 29 04:34:47 2013 From: rieberandreas at gmail.com (Andreas Rieber) Date: Wed, 29 May 2013 13:34:47 +0200 Subject: 7051182: Regression: : jconsole scripting demo fails with UndeclaredThrowableException In-Reply-To: <51A5CC0A.2060104@oracle.com> References: <51A5A0B7.2000506@gmail.com> <51A5CC0A.2060104@oracle.com> Message-ID: <51A5E7D7.2080000@gmail.com> Hi Sundar, it is all in the same repro (jdk demo) but the fix (public class... in ScriptShellPanel.java) would not work without the changes required for Nashorn. So i guess one patch is fine and shorter this time. Andreas On 29.05.13 11:36, A. Sundararajan wrote: > Hi Andreas, > > If changes are across repos (nashorn, jdk/demo) it is better to have > two patches. But, you could zip everything and send as well. > > Thanks > -Sundar > > On Wednesday 29 May 2013 12:01 PM, Andreas Rieber wrote: >> Hi, >> >> i have a one line fix for this bug but i also have a patch to make >> jconsole-plugin demo working with Nashorn. The problems there are >> similar to scriptpad (sync function, array handling and the new >> JSAdapter __call__). >> >> Do you want two separate patches or is one OK? >> >> cheers >> Andreas >> > -------------- next part -------------- diff --git a/src/share/demo/scripting/jconsole-plugin/src/com/sun/demo/scripting/jconsole/ScriptJConsolePlugin.java b/src/share/demo/scripting/jconsole-plugin/src/com/sun/demo/scripting/jconsole/ScriptJConsolePlugin.java --- a/src/share/demo/scripting/jconsole-plugin/src/com/sun/demo/scripting/jconsole/ScriptJConsolePlugin.java +++ b/src/share/demo/scripting/jconsole-plugin/src/com/sun/demo/scripting/jconsole/ScriptJConsolePlugin.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2006, 2011, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2006, 2013, Oracle and/or its affiliates. All rights reserved. * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -148,10 +148,11 @@ private String getScriptLanguage() { // check whether explicit System property is set String lang = System.getProperty(LANGUAGE_KEY); + if (lang == null) { - // default is JavaScript - lang = "JavaScript"; + lang = "nashorn"; } + return lang; } diff --git a/src/share/demo/scripting/jconsole-plugin/src/com/sun/demo/scripting/jconsole/ScriptShellPanel.java b/src/share/demo/scripting/jconsole-plugin/src/com/sun/demo/scripting/jconsole/ScriptShellPanel.java --- a/src/share/demo/scripting/jconsole-plugin/src/com/sun/demo/scripting/jconsole/ScriptShellPanel.java +++ b/src/share/demo/scripting/jconsole-plugin/src/com/sun/demo/scripting/jconsole/ScriptShellPanel.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2006, 2011, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2006, 2013, Oracle and/or its affiliates. All rights reserved. * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -54,7 +54,7 @@ * jconsole's script console. */ -class ScriptShellPanel extends JPanel { +public class ScriptShellPanel extends JPanel { private static final long serialVersionUID = 4116273141148726319L; diff --git a/src/share/demo/scripting/jconsole-plugin/src/resources/jconsole.js b/src/share/demo/scripting/jconsole-plugin/src/resources/jconsole.js --- a/src/share/demo/scripting/jconsole-plugin/src/resources/jconsole.js +++ b/src/share/demo/scripting/jconsole-plugin/src/resources/jconsole.js @@ -1,5 +1,5 @@ /* - * Copyright (c) 2006, 2011, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2006, 2013, Oracle and/or its affiliates. All rights reserved. * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -77,12 +77,37 @@ function jcontext() { return plugin.getContext(); } -jcontext.docString = "returns JConsoleContext for the current jconsole plugin" +jcontext.docString = "returns JConsoleContext for the current jconsole plugin"; function mbeanConnection() { return jcontext().getMBeanServerConnection(); } -mbeanConnection.docString = "returns current MBeanServer connection" +mbeanConnection.docString = "returns current MBeanServer connection"; + +// check if there is a build in sync function, define one if missing +if (typeof sync === "undefined") { + var sync = function(func, obj) { + if (arguments.length < 1 || arguments.length > 2 ) { + throw "sync(function [,object]) parameter count mismatch"; + } + + var syncobj = (arguments.length == 2 ? obj : this); + + if (!syncobj._syncLock) { + syncobj._syncLock = new Lock(); + } + + return function() { + syncobj._syncLock.lock(); + try { + func.apply(null, arguments); + } finally { + syncobj._syncLock.unlock(); + } + }; + }; + sync.docString = "synchronize a function, optionally on an object"; +} /** * Prints one liner help message for each function exposed here @@ -188,22 +213,12 @@ // wraps a script array as java.lang.Object[] function objectArray(array) { - var len = array.length; - var res = java.lang.reflect.Array.newInstance(java.lang.Object, len); - for (var i = 0; i < array.length; i++) { - res[i] = array[i]; - } - return res; + return Java.to(array, "java.lang.Object[]"); } // wraps a script (string) array as java.lang.String[] function stringArray(array) { - var len = array.length; - var res = java.lang.reflect.Array.newInstance(java.lang.String, len); - for (var i = 0; i < array.length; i++) { - res[i] = String(array[i]); - } - return res; + return Java.to(array, "java.lang.String[]"); } // script array to Java List @@ -286,16 +301,18 @@ * will be of type FutureTask. When you need value, call 'get' on it. */ function mbean(objName, async) { + var index; + objName = objectName(objName); var info = mbeanInfo(objName); var attrs = info.attributes; var attrMap = new Object; - for (var index in attrs) { + for (index in attrs) { attrMap[attrs[index].name] = attrs[index]; } var opers = info.operations; var operMap = new Object; - for (var index in opers) { + for (index in opers) { operMap[opers[index].name] = opers[index]; } @@ -318,21 +335,30 @@ } else { return getMBeanAttribute(objName, name); } - } else if (isOperation(name)) { + } else { + return undefined; + } + }, + __call__: function(name) { + if (isOperation(name)) { var oper = operMap[name]; - return function() { - var params = objectArray(arguments); - var sigs = oper.signature; - var sigNames = new Array(sigs.length); - for (var index in sigs) { - sigNames[index] = sigs[index].getType(); - } - if (async) { - return invokeMBean.future(objName, name, - params, sigNames); - } else { - return invokeMBean(objName, name, params, sigNames); - } + + var params = []; + for (var j = 1; j < arguments.length; j++) { + params[j-1]= arguments[j]; + } + + var sigs = oper.signature; + + var sigNames = new Array(sigs.length); + for (var index in sigs) { + sigNames[index] = sigs[index].getType(); + } + + if (async) { + return invokeMBean.future(objName, name, params, sigNames); + } else { + return invokeMBean(objName, name, params, sigNames); } } else { return undefined; @@ -520,7 +546,7 @@ } finally { lock.unlock(); } -} +}; /** * Causes current thread to sleep for specified @@ -550,12 +576,16 @@ // and calls callback in an infinite loop return (function() { while (true) { - sleep(interval); + try { + sleep(interval); + } catch (x) { + break; + } callback(); } }).daemon(); } -setTimeout.docString = "calls given callback once after specified interval" +setTimeout.docString = "calls given callback once after specified interval"; /** * Cancels a timeout set earlier. @@ -680,7 +710,7 @@ if (msg === undefined) msg = "undefined"; if (msg === null) msg = "null"; if (title == undefined) title = msg; - if (msgType == undefined) type = JOptionPane.INFORMATION_MESSAGE; + if (msgType == undefined) msgType = JOptionPane.INFORMATION_MESSAGE; JOptionPane.showMessageDialog(window, msg, title, msgType); } if (isEventThread()) { @@ -800,7 +830,7 @@ * Clear the screen */ function clear() { - (function() { window.clear(false) }).invokeLater(); + (function() { window.clear(false); }).invokeLater(); } clear.docString = "clears interactive console screen"; diff --git a/src/share/demo/scripting/jconsole-plugin/src/scripts/jstack.js b/src/share/demo/scripting/jconsole-plugin/src/scripts/jstack.js --- a/src/share/demo/scripting/jconsole-plugin/src/scripts/jstack.js +++ b/src/share/demo/scripting/jconsole-plugin/src/scripts/jstack.js @@ -1,5 +1,5 @@ /* - * Copyright (c) 2006, 2011, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2006, 2013, Oracle and/or its affiliates. All rights reserved. * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -87,7 +87,7 @@ var tmbean = newPlatformMXBeanProxy( "java.lang:type=Threading", - java.lang.management.ThreadMXBean); + java.lang.management.ThreadMXBean.class); var tids = tmbean.allThreadIds; var tinfos = tmbean["getThreadInfo(long[],int)"](tids, maxFrames); diff --git a/src/share/demo/scripting/jconsole-plugin/src/scripts/jtop.js b/src/share/demo/scripting/jconsole-plugin/src/scripts/jtop.js --- a/src/share/demo/scripting/jconsole-plugin/src/scripts/jtop.js +++ b/src/share/demo/scripting/jconsole-plugin/src/scripts/jtop.js @@ -1,5 +1,5 @@ /* - * Copyright (c) 2006, 2011, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2006, 2013, Oracle and/or its affiliates. All rights reserved. * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -62,10 +62,10 @@ function getThreadList() { var tmbean = newPlatformMXBeanProxy( "java.lang:type=Threading", - java.lang.management.ThreadMXBean); + java.lang.management.ThreadMXBean.class); if (!tmbean.isThreadCpuTimeSupported()) { - return; + return new java.util.ArrayList(); } tmbean.setThreadCpuTimeEnabled(true); diff --git a/src/share/demo/scripting/jconsole-plugin/src/scripts/sysprops.js b/src/share/demo/scripting/jconsole-plugin/src/scripts/sysprops.js --- a/src/share/demo/scripting/jconsole-plugin/src/scripts/sysprops.js +++ b/src/share/demo/scripting/jconsole-plugin/src/scripts/sysprops.js @@ -1,5 +1,5 @@ /* - * Copyright (c) 2006, 2011, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2006, 2013, Oracle and/or its affiliates. All rights reserved. * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -62,7 +62,7 @@ function getSystemProps() { var runtimeBean = newPlatformMXBeanProxy( "java.lang:type=Runtime", - java.lang.management.RuntimeMXBean); + java.lang.management.RuntimeMXBean.class); return runtimeBean.systemProperties; } From sundararajan.athijegannathan at oracle.com Wed May 29 04:53:31 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Wed, 29 May 2013 17:23:31 +0530 Subject: 7051182: Regression: : jconsole scripting demo fails with UndeclaredThrowableException In-Reply-To: <51A5E7D7.2080000@gmail.com> References: <51A5A0B7.2000506@gmail.com> <51A5CC0A.2060104@oracle.com> <51A5E7D7.2080000@gmail.com> Message-ID: <51A5EC3B.4050303@oracle.com> Hi Andreas, I'll send out a webrev after build/test of your patch. Thanks for the contribution! -Sundar On Wednesday 29 May 2013 05:04 PM, Andreas Rieber wrote: > Hi Sundar, > > it is all in the same repro (jdk demo) but the fix (public class... in > ScriptShellPanel.java) would not work without the changes required for > Nashorn. So i guess one patch is fine and shorter this time. > > Andreas > > > > On 29.05.13 11:36, A. Sundararajan wrote: >> Hi Andreas, >> >> If changes are across repos (nashorn, jdk/demo) it is better to have >> two patches. But, you could zip everything and send as well. >> >> Thanks >> -Sundar >> >> On Wednesday 29 May 2013 12:01 PM, Andreas Rieber wrote: >>> Hi, >>> >>> i have a one line fix for this bug but i also have a patch to make >>> jconsole-plugin demo working with Nashorn. The problems there are >>> similar to scriptpad (sync function, array handling and the new >>> JSAdapter __call__). >>> >>> Do you want two separate patches or is one OK? >>> >>> cheers >>> Andreas >>> >> > From marcus.lagergren at oracle.com Wed May 29 05:09:16 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Wed, 29 May 2013 14:09:16 +0200 Subject: Bug at Math.round In-Reply-To: References: Message-ID: <0C7594E9-11F1-48DE-A628-C8ACC6E670F1@oracle.com> Hi! I just pushed a fix, which will be migrated to TL shortly. Thanks /M On May 29, 2013, at 5:45 AM, toshiyuki kojima wrote: > Hello, > > > I found a bug: > > Math.round(-0) should return -0, but Math.round(-0) returns +0 in nashorn. > > > I confirmed this bug using revision: > > changeset: d56168970de1 > > date: Tue May 28 16:37:11 2013 +0530 > > summary: 8015459: Octane test run fails on Turkish locale > > > > http://ecma-international.org/ecma-262/5.1/#sec-15.8.2.15 > > http://jsfiddle.net/gocho/TscsU/ > > http://hg.openjdk.java.net/nashorn/jdk8/nashorn/file/d56168970de1/src/jdk/nashorn/internal/objects/NativeMath.java > > > Thanks, > > --gocho > > twitter.com/gocho From marcus.lagergren at oracle.com Wed May 29 05:08:09 2013 From: marcus.lagergren at oracle.com (marcus.lagergren at oracle.com) Date: Wed, 29 May 2013 12:08:09 +0000 Subject: hg: nashorn/jdk8/nashorn: 8011023: Math round didn't conform to ECMAScript 5 spec Message-ID: <20130529120811.D405448DDB@hg.openjdk.java.net> Changeset: f69e76417211 Author: lagergren Date: 2013-05-29 14:08 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/f69e76417211 8011023: Math round didn't conform to ECMAScript 5 spec Reviewed-by: jlaskey, attila ! src/jdk/nashorn/internal/objects/NativeMath.java + test/script/basic/JDK-8011023.js + test/script/basic/JDK-8011023.js.EXPECTED From james.laskey at oracle.com Wed May 29 05:28:40 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Wed, 29 May 2013 09:28:40 -0300 Subject: Bug at Math.round In-Reply-To: References: Message-ID: <6685D897-6244-417D-BB5E-40EDD3397025@oracle.com> This looks to be an artifact of String.toString. We will address. jjs> java.lang.System.out["println(double)"](java.lang.Math.copySign(0.0, -1)); -0.0 jjs> java.lang.System.out["println(double)"](java.lang.Math.sin(-0.0)); -0.0 Cheers, -- Jim On 2013-05-29, at 12:45 AM, toshiyuki kojima wrote: > Hello, > > > I found a bug: > > Math.round(-0) should return -0, but Math.round(-0) returns +0 in nashorn. > > > I confirmed this bug using revision: > > changeset: d56168970de1 > > date: Tue May 28 16:37:11 2013 +0530 > > summary: 8015459: Octane test run fails on Turkish locale > > > > http://ecma-international.org/ecma-262/5.1/#sec-15.8.2.15 > > http://jsfiddle.net/gocho/TscsU/ > > http://hg.openjdk.java.net/nashorn/jdk8/nashorn/file/d56168970de1/src/jdk/nashorn/internal/objects/NativeMath.java > > > Thanks, > > --gocho > > twitter.com/gocho From sundararajan.athijegannathan at oracle.com Wed May 29 08:04:20 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Wed, 29 May 2013 20:34:20 +0530 Subject: Review request for 8015349: "abc".lastIndexOf("a", -1) should evaluate to 0 and not -1 Message-ID: <51A618F4.20402@oracle.com> Please review http://cr.openjdk.java.net/~sundar/8015349/ -Sundar From sundararajan.athijegannathan at oracle.com Wed May 29 08:57:48 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Wed, 29 May 2013 15:57:48 +0000 Subject: hg: nashorn/jdk8/nashorn: 8015349: "abc".lastIndexOf("a", -1) should evaluate to 0 and not -1 Message-ID: <20130529155750.5360848DE5@hg.openjdk.java.net> Changeset: a2e2797392b3 Author: sundar Date: 2013-05-29 21:27 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/a2e2797392b3 8015349: "abc".lastIndexOf("a",-1) should evaluate to 0 and not -1 Reviewed-by: lagergren, attila, jlaskey ! src/jdk/nashorn/internal/objects/NativeString.java + test/script/basic/JDK-8015349.js + test/script/basic/JDK-8015349.js.EXPECTED From james.laskey at oracle.com Wed May 29 09:06:10 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Wed, 29 May 2013 13:06:10 -0300 Subject: Review request for 8015349: "abc".lastIndexOf("a", -1) should evaluate to 0 and not -1 In-Reply-To: <51A618F4.20402@oracle.com> References: <51A618F4.20402@oracle.com> Message-ID: +1 On 2013-05-29, at 12:04 PM, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~sundar/8015349/ > > -Sundar From james.laskey at oracle.com Wed May 29 09:32:45 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Wed, 29 May 2013 16:32:45 +0000 Subject: hg: nashorn/jdk8/langtools: 8 new changesets Message-ID: <20130529163309.CFBD848DEC@hg.openjdk.java.net> Changeset: 58329d9f6b68 Author: mcimadamore Date: 2013-05-24 15:26 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/58329d9f6b68 8014643: Parser regression in JDK 8 when compiling super.x Summary: Fixed latent bug in JavacParser.analyzeParens() Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java + test/tools/javac/parser/8014643/T8014643.java Changeset: 97a9b4b3e63a Author: mcimadamore Date: 2013-05-24 15:27 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/97a9b4b3e63a 8014649: Regression: bug in Resolve.resolveOperator Summary: Missing curly braces causes Resolve.findMethod to be called spuriously Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! test/tools/javac/resolve/ResolveHarness.java + test/tools/javac/resolve/tests/PrimitiveBinopOverload.java Changeset: 6e5076af4660 Author: mcimadamore Date: 2013-05-24 15:27 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/6e5076af4660 8014494: javac crashes when varargs element of a method reference is inferred from the context Summary: varargs element is not refreshed after type-inference Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/lambda/TargetType73.java Changeset: 0f8e9a0e5d9a Author: darcy Date: 2013-05-24 11:26 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/0f8e9a0e5d9a 8014836: Have GenericDeclaration extend AnnotatedElement Reviewed-by: jfranck ! src/share/sample/language/model/CoreReflectionFactory.java Changeset: b391ecea538e Author: vromero Date: 2013-05-27 13:44 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/b391ecea538e 7030476: Fix conflicting use of JCTree/JCExpression Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/TreeCopier.java ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java Changeset: c6df5b20f9eb Author: vromero Date: 2013-05-28 12:46 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/c6df5b20f9eb 6970173: Debug pointer at bad position Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Lower.java + test/tools/javac/T6970173/DebugPointerAtBadPositionTest.java Changeset: d042cba65eab Author: vromero Date: 2013-05-28 17:39 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/d042cba65eab 8012333: javac, ClassFile should have a read(Path) method Reviewed-by: jjg ! src/share/classes/com/sun/tools/classfile/ClassFile.java Changeset: 92e420e9807d Author: vromero Date: 2013-05-29 10:56 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/92e420e9807d 7053059: VerifyError with double Assignment using a Generic Member of a Superclass Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java + test/tools/javac/T7053059/VerifyErrorWithDoubleAssignmentTest.java From james.laskey at oracle.com Wed May 29 09:28:21 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Wed, 29 May 2013 16:28:21 +0000 Subject: hg: nashorn/jdk8/jdk: 20 new changesets Message-ID: <20130529163236.463D748DEB@hg.openjdk.java.net> Changeset: 0da6485cf656 Author: nloodin Date: 2013-05-23 15:50 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/0da6485cf656 8014048: Online user guide of jconsole points incorrect link Reviewed-by: mchung, sla, jbachorik ! src/share/classes/sun/tools/jconsole/AboutDialog.java ! src/share/classes/sun/tools/jconsole/resources/messages.properties ! src/share/classes/sun/tools/jconsole/resources/messages_ja.properties ! src/share/classes/sun/tools/jconsole/resources/messages_zh_CN.properties Changeset: 3b23e3529ab3 Author: dl Date: 2013-05-23 18:34 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/3b23e3529ab3 8014076: Arrays parallel and serial sorting improvements Reviewed-by: chegar, mduigou ! src/share/classes/java/util/Arrays.java ! src/share/classes/java/util/ArraysParallelSortHelpers.java ! src/share/classes/java/util/ComparableTimSort.java ! src/share/classes/java/util/DualPivotQuicksort.java ! src/share/classes/java/util/TimSort.java ! test/java/util/Arrays/ParallelSorting.java Changeset: 6816afd70a68 Author: weijun Date: 2013-05-24 17:15 +0800 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/6816afd70a68 8014196: ktab creates a file with zero kt_vno Reviewed-by: valeriep ! src/share/classes/sun/security/krb5/internal/ktab/KeyTab.java ! src/windows/classes/sun/security/krb5/internal/tools/Ktab.java + test/sun/security/krb5/tools/KtabZero.java + test/sun/security/krb5/tools/ktzero.sh Changeset: 5e769206f036 Author: ksrini Date: 2013-05-24 17:01 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/5e769206f036 8007333: [launcher] removes multiple back slashes Reviewed-by: alanb, akhil ! src/windows/bin/cmdtoargs.c ! test/tools/launcher/Arrrghs.java Changeset: d78f91ab0e96 Author: uta Date: 2013-05-27 15:18 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/d78f91ab0e96 8014394: (fs) WatchService failing when watching \\server\$d Reviewed-by: alanb ! src/windows/classes/sun/nio/fs/WindowsConstants.java ! src/windows/classes/sun/nio/fs/WindowsNativeDispatcher.java ! src/windows/classes/sun/nio/fs/WindowsWatchService.java ! src/windows/native/sun/nio/fs/WindowsNativeDispatcher.c Changeset: 0b8dab7fec54 Author: plevart Date: 2013-05-27 09:41 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/0b8dab7fec54 7038914: VM could throw uncaught OOME in ReferenceHandler thread Summary: Catch OutOfMemoryError in reference handler thread if caused by allocation of an InterruptedException Reviewed-by: dholmes, alanb ! src/share/classes/java/lang/ref/Reference.java + test/java/lang/ref/OOMEInReferenceHandler.java Changeset: a2dc42667df3 Author: chegar Date: 2013-05-27 14:00 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/a2dc42667df3 8015439: Minor/sync/cleanup of ConcurrentHashMap Reviewed-by: chegar Contributed-by: Doug Lea
, Chris Hegarty ! src/share/classes/java/util/concurrent/ConcurrentHashMap.java Changeset: 9bbf2237071e Author: chegar Date: 2013-05-27 15:24 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/9bbf2237071e Merge Changeset: bbf6e6222726 Author: nloodin Date: 2013-05-27 17:10 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/bbf6e6222726 6470730: Disconnect button leads to wrong popup message Reviewed-by: dcubed, sla, egahlin ! src/share/classes/sun/tools/jconsole/VMPanel.java Changeset: 7d9fab5d86cd Author: jbachorik Date: 2013-05-28 15:57 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/7d9fab5d86cd 8005472: com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.sh failed on windows Reviewed-by: chegar, smarks, dfuchs ! test/ProblemList.txt ! test/com/sun/jmx/remote/NotificationMarshalVersions/Client/Client.java ! test/com/sun/jmx/remote/NotificationMarshalVersions/Server/Server.java + test/com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.java - test/com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.sh Changeset: 7d7bfce34a79 Author: dsamersoff Date: 2013-05-28 18:46 +0400 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/7d7bfce34a79 8014420: Default JDP address does not match the one assigned by IANA Summary: JDP protocol defaults changed to IANA assigned values Reviewed-by: dholmes, jbachorik, hirt Contributed-by: fweimer at redhat.com ! src/share/classes/sun/management/Agent.java ! src/share/classes/sun/management/jdp/package-info.java ! test/sun/management/jdp/JdpTest.sh Changeset: b16a8b4ae6b4 Author: robm Date: 2013-05-28 16:35 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/b16a8b4ae6b4 7038105: File.isHidden() should return true for pagefile.sys and hiberfil.sys Reviewed-by: alanb ! src/windows/native/java/io/WinNTFileSystem_md.c ! test/java/io/File/IsHidden.java Changeset: 7fa2d1dcb8f6 Author: sherman Date: 2013-05-28 10:42 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/7fa2d1dcb8f6 8001750: CharsetDecoder.replacement should not be changeable except via replaceWith method Summary: to make defensive copy for set/get replacement byte array Reviewed-by: martin ! src/share/classes/java/nio/charset/Charset-X-Coder.java.template ! src/share/classes/sun/nio/cs/UTF_8.java ! src/share/classes/sun/nio/cs/ext/DoubleByte.java ! src/share/classes/sun/nio/cs/ext/HKSCS.java Changeset: b99d56d1aa3f Author: naoto Date: 2013-05-28 14:02 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/b99d56d1aa3f 6251788: (rb) PropertyResourceBundle doesn't document exceptions Reviewed-by: okutsu ! src/share/classes/java/util/PropertyResourceBundle.java Changeset: 1652a22cf6e7 Author: xuelei Date: 2013-05-28 18:47 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/1652a22cf6e7 8010815: some constructors issues in com.sun.jndi.toolkit Reviewed-by: alanb ! src/share/classes/com/sun/jndi/toolkit/ctx/Continuation.java ! src/share/classes/com/sun/jndi/toolkit/dir/LazySearchEnumerationImpl.java ! src/share/classes/com/sun/jndi/toolkit/url/GenericURLContext.java Changeset: e59d7f0f36f7 Author: ewang Date: 2013-05-28 22:22 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/e59d7f0f36f7 8009258: TEST_BUG:java/io/pathNames/GeneralWin32.java fails intermittently Reviewed-by: dxu, alanb Contributed-by: yiming.wang at oracle.com ! test/java/io/pathNames/General.java ! test/java/io/pathNames/GeneralWin32.java Changeset: bd6d3801347b Author: sla Date: 2013-05-29 09:42 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/bd6d3801347b 8015440: java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java fails with RuntimeException Summary: Make sure serial gc compacts heap every time Reviewed-by: mchung, brutisso, nloodin ! test/java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java Changeset: 2b3242a69a44 Author: alanb Date: 2013-05-29 10:24 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/2b3242a69a44 8014928: (fs) Files.readAllBytes() copies content to new array when content completely read Reviewed-by: martin ! src/share/classes/java/nio/file/Files.java Changeset: 00ad19610e75 Author: vinnie Date: 2013-05-29 14:57 +0100 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/00ad19610e75 7174966: With OCSP enabled on Java 7 get error 'Wrong key usage' with Comodo certificate Reviewed-by: xuelei ! src/share/classes/sun/security/provider/certpath/OCSPResponse.java Changeset: 193652dff077 Author: jlaskey Date: 2013-05-29 13:22 -0300 URL: http://hg.openjdk.java.net/nashorn/jdk8/jdk/rev/193652dff077 Merge From james.laskey at oracle.com Wed May 29 12:24:32 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Wed, 29 May 2013 19:24:32 +0000 Subject: hg: nashorn/jdk8/nashorn: 8015636: Add more typed arrays code coverage tests. Message-ID: <20130529192433.89FBD48DF8@hg.openjdk.java.net> Changeset: 66b2fde90c9d Author: jlaskey Date: 2013-05-29 16:23 -0300 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/66b2fde90c9d 8015636: Add more typed arrays code coverage tests. Reviewed-by: sundar Contributed-by: james.laskey at oracle.com + test/script/basic/typedarrays.js From sundararajan.athijegannathan at oracle.com Thu May 30 03:11:50 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Thu, 30 May 2013 15:41:50 +0530 Subject: Review request for 8015353: Date.parse illegal string parsing issues Message-ID: <51A725E6.4050403@oracle.com> Please review http://cr.openjdk.java.net/~sundar/8015353/ -Sundar From james.laskey at oracle.com Thu May 30 04:09:06 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Thu, 30 May 2013 08:09:06 -0300 Subject: Review request for 8015353: Date.parse illegal string parsing issues In-Reply-To: <51A725E6.4050403@oracle.com> References: <51A725E6.4050403@oracle.com> Message-ID: <9A775E4D-9A4B-4B96-B140-099879A283DD@oracle.com> +1 On 2013-05-30, at 7:11 AM, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~sundar/8015353/ > > -Sundar From sundararajan.athijegannathan at oracle.com Thu May 30 04:20:09 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Thu, 30 May 2013 11:20:09 +0000 Subject: hg: nashorn/jdk8/nashorn: 8015353: Date.parse illegal string parsing issues Message-ID: <20130530112012.87C3B48E22@hg.openjdk.java.net> Changeset: eda227663eda Author: sundar Date: 2013-05-30 16:49 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/eda227663eda 8015353: Date.parse illegal string parsing issues Reviewed-by: jlaskey, lagergren - src/jdk/nashorn/internal/objects/DateParser.java ! src/jdk/nashorn/internal/objects/NativeDate.java + src/jdk/nashorn/internal/parser/DateParser.java + test/script/basic/JDK-8015353.js From brett.wooldridge at gmail.com Thu May 30 19:48:47 2013 From: brett.wooldridge at gmail.com (Brett Wooldridge) Date: Fri, 31 May 2013 11:48:47 +0900 Subject: node.jar Message-ID: Akhil, Is the node.jar source available in a public repo somewhere? If not, when will it be? I'm trying to add nashorn support to vertx (http://vertx.io), which currently uses rhino, but it relies on the recent addition of commonjs support to rhino. I understand that with node.jar I would pick up this support, is that true? Brett From sundararajan.athijegannathan at oracle.com Thu May 30 21:16:12 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Fri, 31 May 2013 09:46:12 +0530 Subject: Review request for 8012164: Error.stack needs trimming Message-ID: <51A8240C.5080002@oracle.com> Please review http://cr.openjdk.java.net/~sundar/8012164/ -Sundar From attila.szegedi at oracle.com Fri May 31 02:21:17 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Fri, 31 May 2013 11:21:17 +0200 Subject: Review request for JDK-8015693 Message-ID: <7569AB70-B4D1-44C0-A43E-F1FA371C0755@oracle.com> Please review JDK-8015693 at http://cr.openjdk.java.net/~attila/8015693/webrev.00 Thanks, Attila. From attila.szegedi at oracle.com Fri May 31 02:22:51 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Fri, 31 May 2013 11:22:51 +0200 Subject: Review request for JDK-8015684 Message-ID: Please review JDK-8015684 at http://cr.openjdk.java.net/~attila/8015684/webrev.00 Thanks, Attila. From attila.szegedi at oracle.com Fri May 31 02:24:16 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Fri, 31 May 2013 11:24:16 +0200 Subject: Review request for JDK-8015674 Message-ID: <31BCFA08-2308-46F0-BC1C-B08F094EAFD7@oracle.com> Please review JDK-8015674 at http://cr.openjdk.java.net/~attila/8015674/webrev.00 Thanks, Attila. From attila.szegedi at oracle.com Fri May 31 03:48:55 2013 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Fri, 31 May 2013 12:48:55 +0200 Subject: Review request for JDK-8015673 Message-ID: <9374DEC6-D17D-48CD-8C2F-4009DB9C5BDB@oracle.com> Please review JDK-8015673 at http://cr.openjdk.java.net/~attila/8015673/webrev.00 Thanks, Attila. From james.laskey at oracle.com Fri May 31 03:49:05 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Fri, 31 May 2013 07:49:05 -0300 Subject: Review request for 8012164: Error.stack needs trimming In-Reply-To: <51A8240C.5080002@oracle.com> References: <51A8240C.5080002@oracle.com> Message-ID: +1 On 2013-05-31, at 1:16 AM, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~sundar/8012164/ > > -Sundar From james.laskey at oracle.com Fri May 31 03:50:13 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Fri, 31 May 2013 07:50:13 -0300 Subject: Review request for JDK-8015684 In-Reply-To: References: Message-ID: +1 On 2013-05-31, at 6:22 AM, Attila Szegedi wrote: > Please review JDK-8015684 at http://cr.openjdk.java.net/~attila/8015684/webrev.00 > > Thanks, > Attila. From james.laskey at oracle.com Fri May 31 03:50:51 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Fri, 31 May 2013 07:50:51 -0300 Subject: Review request for JDK-8015674 In-Reply-To: <31BCFA08-2308-46F0-BC1C-B08F094EAFD7@oracle.com> References: <31BCFA08-2308-46F0-BC1C-B08F094EAFD7@oracle.com> Message-ID: +1 On 2013-05-31, at 6:24 AM, Attila Szegedi wrote: > Please review JDK-8015674 at http://cr.openjdk.java.net/~attila/8015674/webrev.00 > > Thanks, > Attila. From marcus.lagergren at oracle.com Fri May 31 03:51:35 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Fri, 31 May 2013 12:51:35 +0200 Subject: Review request for JDK-8015684 In-Reply-To: References: Message-ID: <781E68F4-79E5-4EB1-9C11-A16FD14162CB@oracle.com> +1 On May 31, 2013, at 11:22 AM, Attila Szegedi wrote: > Please review JDK-8015684 at http://cr.openjdk.java.net/~attila/8015684/webrev.00 > > Thanks, > Attila. From james.laskey at oracle.com Fri May 31 03:51:40 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Fri, 31 May 2013 07:51:40 -0300 Subject: Review request for JDK-8015693 In-Reply-To: <7569AB70-B4D1-44C0-A43E-F1FA371C0755@oracle.com> References: <7569AB70-B4D1-44C0-A43E-F1FA371C0755@oracle.com> Message-ID: +1 On 2013-05-31, at 6:21 AM, Attila Szegedi wrote: > Please review JDK-8015693 at http://cr.openjdk.java.net/~attila/8015693/webrev.00 > > Thanks, > Attila. From marcus.lagergren at oracle.com Fri May 31 03:52:16 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Fri, 31 May 2013 12:52:16 +0200 Subject: Review request for JDK-8015674 In-Reply-To: <31BCFA08-2308-46F0-BC1C-B08F094EAFD7@oracle.com> References: <31BCFA08-2308-46F0-BC1C-B08F094EAFD7@oracle.com> Message-ID: <95CA5DD2-8128-44B8-AC0D-9590209C2315@oracle.com> +1 On May 31, 2013, at 11:24 AM, Attila Szegedi wrote: > Please review JDK-8015674 at http://cr.openjdk.java.net/~attila/8015674/webrev.00 > > Thanks, > Attila. From marcus.lagergren at oracle.com Fri May 31 03:52:26 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Fri, 31 May 2013 12:52:26 +0200 Subject: Review request for JDK-8015693 In-Reply-To: <7569AB70-B4D1-44C0-A43E-F1FA371C0755@oracle.com> References: <7569AB70-B4D1-44C0-A43E-F1FA371C0755@oracle.com> Message-ID: +1 On May 31, 2013, at 11:21 AM, Attila Szegedi wrote: > Please review JDK-8015693 at http://cr.openjdk.java.net/~attila/8015693/webrev.00 > > Thanks, > Attila. From james.laskey at oracle.com Fri May 31 03:52:38 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Fri, 31 May 2013 07:52:38 -0300 Subject: Review request for JDK-8015673 In-Reply-To: <9374DEC6-D17D-48CD-8C2F-4009DB9C5BDB@oracle.com> References: <9374DEC6-D17D-48CD-8C2F-4009DB9C5BDB@oracle.com> Message-ID: <302030CA-864F-4676-9AA4-9A8A29386D13@oracle.com> +1 On 2013-05-31, at 7:48 AM, Attila Szegedi wrote: > Please review JDK-8015673 at http://cr.openjdk.java.net/~attila/8015673/webrev.00 > > Thanks, > Attila. From marcus.lagergren at oracle.com Fri May 31 03:53:05 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Fri, 31 May 2013 12:53:05 +0200 Subject: Review request for JDK-8015673 In-Reply-To: <9374DEC6-D17D-48CD-8C2F-4009DB9C5BDB@oracle.com> References: <9374DEC6-D17D-48CD-8C2F-4009DB9C5BDB@oracle.com> Message-ID: +1 On May 31, 2013, at 12:48 PM, Attila Szegedi wrote: > Please review JDK-8015673 at http://cr.openjdk.java.net/~attila/8015673/webrev.00 > > Thanks, > Attila. From attila.szegedi at oracle.com Fri May 31 03:57:07 2013 From: attila.szegedi at oracle.com (attila.szegedi at oracle.com) Date: Fri, 31 May 2013 10:57:07 +0000 Subject: hg: nashorn/jdk8/nashorn: 8015693: reduce NodeLiteralNode to NullLiteralNode Message-ID: <20130531105709.8C75C48E7E@hg.openjdk.java.net> Changeset: 818946884410 Author: attila Date: 2013-05-31 12:56 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/818946884410 8015693: reduce NodeLiteralNode to NullLiteralNode Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/internal/ir/LiteralNode.java From attila.szegedi at oracle.com Fri May 31 03:58:04 2013 From: attila.szegedi at oracle.com (attila.szegedi at oracle.com) Date: Fri, 31 May 2013 10:58:04 +0000 Subject: hg: nashorn/jdk8/nashorn: 8015673: Type for :e symbol is wrong Message-ID: <20130531105807.9531948E81@hg.openjdk.java.net> Changeset: 11b81fa7125a Author: attila Date: 2013-05-31 12:58 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/11b81fa7125a 8015673: Type for :e symbol is wrong Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/codegen/CompilerConstants.java From attila.szegedi at oracle.com Fri May 31 03:57:28 2013 From: attila.szegedi at oracle.com (attila.szegedi at oracle.com) Date: Fri, 31 May 2013 10:57:28 +0000 Subject: hg: nashorn/jdk8/nashorn: 8015684: FieldObjectCreator.putField ignores getValueType Message-ID: <20130531105729.688B448E7F@hg.openjdk.java.net> Changeset: d8a7727a519e Author: attila Date: 2013-05-31 12:57 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/d8a7727a519e 8015684: FieldObjectCreator.putField ignores getValueType Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/FieldObjectCreator.java From attila.szegedi at oracle.com Fri May 31 03:57:46 2013 From: attila.szegedi at oracle.com (attila.szegedi at oracle.com) Date: Fri, 31 May 2013 10:57:46 +0000 Subject: hg: nashorn/jdk8/nashorn: 8015674: CodeGenerator.initSymbols mutates a list Message-ID: <20130531105747.95B5148E80@hg.openjdk.java.net> Changeset: cab639125b98 Author: attila Date: 2013-05-31 12:57 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/cab639125b98 8015674: CodeGenerator.initSymbols mutates a list Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/internal/codegen/CodeGenerator.java From sundararajan.athijegannathan at oracle.com Fri May 31 05:09:29 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Fri, 31 May 2013 12:09:29 +0000 Subject: hg: nashorn/jdk8/nashorn: 8012164: Error.stack needs trimming Message-ID: <20130531120931.144AC48E85@hg.openjdk.java.net> Changeset: b4e6cc05ce09 Author: sundar Date: 2013-05-31 17:39 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/b4e6cc05ce09 8012164: Error.stack needs trimming Reviewed-by: lagergren, jlaskey ! src/jdk/nashorn/internal/objects/NativeError.java + test/script/basic/JDK-8012164.js + test/script/basic/JDK-8012164.js.EXPECTED ! test/script/basic/NASHORN-108.js.EXPECTED ! test/script/basic/NASHORN-109.js.EXPECTED ! test/script/basic/errorstack.js.EXPECTED From james.laskey at oracle.com Fri May 31 06:07:54 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Fri, 31 May 2013 10:07:54 -0300 Subject: Review request for JDK-8015727 Thread safe print function Message-ID: http://cr.openjdk.java.net/~jlaskey/8015727/webrev.00/index.html From sundararajan.athijegannathan at oracle.com Fri May 31 06:34:00 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Fri, 31 May 2013 19:04:00 +0530 Subject: Review request for JDK-8015727 Thread safe print function In-Reply-To: References: Message-ID: <51A8A6C8.7050109@oracle.com> +1 On Friday 31 May 2013 06:37 PM, Jim Laskey (Oracle) wrote: > http://cr.openjdk.java.net/~jlaskey/8015727/webrev.00/index.html From james.laskey at oracle.com Fri May 31 09:05:32 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Fri, 31 May 2013 16:05:32 +0000 Subject: hg: nashorn/jdk8/nashorn: 8015727: Thread safe print function Message-ID: <20130531160535.794F148E91@hg.openjdk.java.net> Changeset: 64250b3a2f2a Author: jlaskey Date: 2013-05-31 13:04 -0300 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/64250b3a2f2a 8015727: Thread safe print function Reviewed-by: sundar Contributed-by: james.laskey at oracle.com ! src/jdk/nashorn/internal/objects/Global.java