Footprint reduction: Please review JDK-8013913 - Remove source field from all nodes

Marcus Lagergren marcus.lagergren at oracle.com
Tue May 7 04:06:16 PDT 2013


Fixed that. It shouldn't even say symbol != null, that is always true. This is old code that had survived the lower Attr/Split. There is always a symbol there.

/M

On May 7, 2013, at 12:51 PM, Jim Laskey (Oracle) <james.laskey at oracle.com> wrote:

> +1
> 
> 
> 
> Attr.java - mysterious blank line.
> 
> 
> 532         if (symbol != null && !identNode.isInitializedHere()) {
> 
> 533             
> 
> 534             symbol.increaseUseCount();
> 535         }
> 
> 
> 
> 
> 
> On 2013-05-06, at 12:58 PM, Marcus Lagergren <marcus.lagergren at oracle.com> wrote:
> 
>> This got the footprint for large scripts down by several megs. Source now only lives inside the FunctionNode. Fairly trivial change, but it affected a lot of files.
>> 
>> http://cr.openjdk.java.net/~lagergren/8013913/
>> 
>> /M
>> 
> 



More information about the nashorn-dev mailing list