Review request for JDK-8012359 - Increase code coverage in Joni

Hannes Wallnoefer hannes.wallnoefer at oracle.com
Thu May 16 05:13:27 PDT 2013


I wasn't quite happy with the improvement in coverage so I uploaded a 
second webrev:

http://cr.openjdk.java.net/~hannesw/8012359/webrev.01/

Coverage is now 68% of methods in the main joni package, although lower 
for blocks, lines and branches.

Please review.

Hannes


Am 2013-05-14 13:15, schrieb Hannes Wallnoefer:
> Please review JDK-8012359 - Increase code coverage in Joni:
>
> http://cr.openjdk.java.net/~hannesw/8012359/
>
> This removes most code we do not use in Joni, including regexp 
> features not used in ECMAScript, alternative implementations of 
> features, and things left over from multibyte encoding support.
>
> I tested with ant test and test262, currently running Node tests.
>
> Hannes



More information about the nashorn-dev mailing list