Bug report: JavaScript arrays are not coerced into Java arrays when calling Java functions that expect arrays

[Jim Laskey (Oracle)]

Once you sign the contributor agreement we can accept your changes.

On 2013-10-11, at 11:20 AM, Tal Liron <tal.liron at threecrickets.com> wrote:

> I hope someone can help me get my contribution in soon! The project is moving quickly... an hg pull last night broke my fix, but I re-fixed and improved it. The sooner it can be integrated, the better.
> 
> Now only two files need to be changed: JavaArgumentConverters and NashornPrimitiveLinker. I've also added all the primitive array types and improved the logic a bit.
> 
> On 10/11/2013 12:50 AM, Tal Liron wrote:
>> I've created a patch that I think meets the requirements. I haven't done a lot of testing, but it seems to work. I currently support conversion to String[] and Object[] arrays, but it would be trivial to add conversions to other primitive array types (boolean[], Number[], int[], etc.)
>> 
>> Specifically, the changes are to TypeUtilities, JavaArgumenConverters, and Guards.
>> 
>> It took quite a bit of research to find the right place to add the converter, but it's actually very little code and it seems basically correct to me. I do have some questions about specifics, but you would need to see the code first. I'm especially concerned about how I handled the warning log check in Guards.
>> 
>> Where do I send the contributer agreement, and what is the best way to send my code to the team?
>> 
>> On 10/09/2013 11:27 PM, Attila Szegedi wrote:
>>> You'll also need to sign and send us an Oracle Contributor Agreement: <http://www.oracle.com/technetwork/oca-405177.pdf>
>>> 
>>> On Oct 9, 2013, at 4:28 PM, Jim Laskey <james.laskey at oracle.com <mailto:james.laskey at oracle.com>> wrote:
>>> 
>>>> If you can get the changes to me by Tuesday Oct 15th, I'll take a look.  No guarantees, but if the changes are small, are correct, and do not restrict future enhancements in this area then I'll run the changes up the approval chain.
>>>> 
>>>> Cheers,
>>>> 
>>>> -- Jim
>> 
>