Review request for JDK-8066669: dust.js performance regression caused by primitive field conversion

Marcus Lagergren lagergren at gmail.com
Thu Dec 11 18:16:17 UTC 2014


+1 on backport 

> On 11 Dec 2014, at 16:48, Attila Szegedi <attila.szegedi at oracle.com> wrote:
> 
> +1 on backport
> 
> On Dec 11, 2014, at 4:00 PM, Hannes Wallnoefer <hannes.wallnoefer at oracle.com> wrote:
> 
>> Backport patch to 8u40 failed in two places in MethodEmitter.java because the beginning of dynamicGet and dynamicSet methods changed in 9.
>> 
>> Please review backport to 8u here: http://cr.openjdk.java.net/~hannesw/8066669/
>> 
>> Thanks,
>> Hannes
>> 
>> Am 2014-12-11 um 14:47 schrieb Hannes Wallnoefer:
>>> I uploaded a new webrev that only replaces index nodes with string index expressions as suggested by Attila, and added tests for index operations on a java HashMap. Please review.
>>> 
>>> http://cr.openjdk.java.net/~hannesw/8066669/
>>> 
>>> Thanks,
>>> Hannes
>>> 
>>> Am 2014-12-11 um 13:48 schrieb Hannes Wallnoefer:
>>>> Please review JDK-8066669: dust.js performance regression caused by primitive field conversion:
>>>> 
>>>> http://cr.openjdk.java.net/~hannesw/8066669/
>>>> 
>>>> Thanks,
>>>> Hannes
>>> 
>> 
> 



More information about the nashorn-dev mailing list