Review request for JDK-8046201: Avoid repeated flattening of nested ConsStrings

[Marcus Lagergren]

finals missing for parameters (code standard nitpick).

Have you done any benchmarking to see if this introduces any regressions? I can’t for the life of me imagine why, in our single threaded environment, but just to be sure.

Otherwise +1


On 23 Jun 2014, at 18:10, Hannes Wallnoefer <hannes.wallnoefer at oracle.com> wrote:

> Uploaded a new webrev based on feedback regarding thread safety from Attila and Aleksey Shipilev:
> 
> http://cr.openjdk.java.net/~hannesw/8046201/webrev.02/
> 
> Hannes
> 
> Am 2014-06-23 15:58, schrieb Hannes Wallnoefer:
>> Please review JDK-8046201: Avoid repeated flattening of nested ConsStrings:
>> 
>> http://cr.openjdk.java.net/~hannesw/8046201/
>> 
>> Note that I made ConsString.flatten() synchronized. I didn't observe any performance degradation.
>> 
>> Thanks,
>> Hannes
>